Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Robert P. J. Day
On Sat, 29 Sep 2007, Linus Torvalds wrote: On Fri, 28 Sep 2007, Erez Zadok wrote: Documentation/CodingStyle | 88 +- I'm not very happy with this. CodingStyle should be about the big issues, not about details. Yes, we've messed that up

Re: FW: [patch 01/02] vfs: variant symlinks

2007-09-29 Thread Trond Myklebust
On Sat, 2007-09-29 at 12:40 -0700, Schmidt, Kenneth P wrote: The best example of how this can be useful is to allow a heterogeneous environment which uses a common filesystem. For example, both x86_64 and power systems could mount a root nfs share and execute with a common set of

Re: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model

2007-09-29 Thread Tejun Heo
Hello, Eric. Eric W. Biederman wrote: Mostly I am thinking that any non-object model users should have their own dedicated wrapper layer. To help keep things consistent and to make it hard enough to abuse the system that people will find that it is usually easier to do it the right

Re: [2.6.23-rc8-mm2] kernel BUG at mm/slab.c:591! | invalid opcode: 0000 [#1] SMP

2007-09-29 Thread Frans Pop
On Friday 28 September 2007, you wrote: My Toshiba Satellite A40 (i386, P4 Mobile) hangs during boot after: With 'hpet-force-enable-on-ich34' reverted the system boots OK again. We're not yet done though. It now fails to resume from suspend and there's also the BUG (see subject) during power

Re: [patch] Combine path_put and path_put_conditional

2007-09-29 Thread Ingo Oeser
Hi Andreas, On Friday 28 September 2007, Andreas Gruenbacher wrote: The name path_put_conditional (formerly, dput_path) is a little unclear. Replace (path_put_conditional + path_put) with path_walk_put_both, put a pair of paths after a path_walk (see the kerneldoc). ^ So

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Who says that needless parens could provide value? Jean, which is why he submitted the patch. You, implicitly, by acking a patch saying those parens are bad. But not me ... I don't think this

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread H. Peter Anvin
Wolfgang Erig wrote: Hi Peter, On Sat, Sep 29, 2007 at 11:35:53AM +0200, Wolfgang Erig wrote: I start again with a fresh tree and better controlled experiments. now the result of bisection seems to be consistent. The last good commit is f2d98ae63dc64dedb00499289e13a50677f771f9 Linker

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 15:30:15 -0700 David Brownell wrote: Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Who says that needless parens could provide value? Jean, which is why he submitted the patch. You, implicitly, by acking a patch

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Måns Rullgård
David Brownell [EMAIL PROTECTED] writes: Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Who says that needless parens could provide value? Jean, which is why he submitted the patch. You, implicitly, by acking a patch saying those parens

Re: 2.6.23-rc8-mm2 - PowerPC link failure at arch/powerpc/kernel/head_64.o

2007-09-29 Thread Kamalesh Babulal
Hi Andrew, The compilation with the cross compiler for the PowerPC-405 on the powerbox fails at linking LD init/built-in.o LD .tmp_vmlinux1 ld: arch/powerpc/kernel/head_64.o(.text+0x80c8): sibling call optimization to `.text.init.refok' does not allow automatic multiple TOCs;

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Erez Zadok
In message [EMAIL PROTECTED], Theodore Tso writes: On Sat, Sep 29, 2007 at 03:56:38PM -0400, J. Bruce Fields wrote: It'd be a start just to revert CodingStyle to its original content and move the rest to CodingStyleReference. But someone would want to skim through the CodingStyle history

[PATCH] Add Documentation/{w1,w1/masters}/00-INDEX

2007-09-29 Thread Rob Landley
From: Rob Landley [EMAIL PROTECTED] Two 00-INDEX files under Documentation/w1 Signed-off-by: Rob Landley [EMAIL PROTECTED] --- Documentation/w1/00-INDEX |8 Documentation/w1/masters/00-INDEX |6 ++ 2 files changed, 14 insertions(+) --- /dev/null 2007-04-23

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 11:18:05 PDT, Linus Torvalds said: CodingStyle should be about the big issues, not about details. Yes, we've messed that up over the years, but let's not continue that. In other words, I'd suggest *removing* lines from CodingStyle, not adding them. The file has already

Re: [patch] x86: improved memory barrier implementation

2007-09-29 Thread Dave Jones
On Fri, Sep 28, 2007 at 05:07:19PM +0100, Alan Cox wrote: Winchip: can any of these CPUs with ooostores do SMP? If not, then smp_wmb can also be a simple barrier on i386 too. The IDT Winchip can do SMP apparently. From the Winchip3 (which was the final winchip) specs.. The IDT

Re: 2.6.23-rc8-mm2

2007-09-29 Thread Dave Young
On 9/29/07, Greg KH [EMAIL PROTECTED] wrote: On Sat, Sep 29, 2007 at 05:37:29PM +0800, Dave Young wrote: Hi, The kernel report warnings about sysfs filename duplicate under rc8-mm1 and rc8-mm2. 1. cut NET: Registered protocol family 16 ACPI: bus type pci registered PCI:

Re: getting FUSD compiled with current kernels

2007-09-29 Thread Lee Revell
On 9/29/07, Florian Schmidt [EMAIL PROTECTED] wrote: My goal is to hack up oss2jack [3] to use ALSA pcm devices.. And a later goal is to create a virtual ALSA soundcard [which would multiplex access to a real non hw-mixing capable soundcard] to finally end the dmix software mixing woes linux

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, Erez Zadok wrote: Would you prefer if CodingStyle was reorganized or even split into (1) general principles and (2) details? Perhaps we need a CodingStylePrinciples and a CodingStyleDetails? I'm certainly ok with the split into two files. What I'm not ok with is

Re: F_DUPFD_CLOEXEC implementation

2007-09-29 Thread Denys Vlasenko
Hi Ulrich, On Friday 28 September 2007 18:34, Ulrich Drepper wrote: One more small change to extend the availability of creation of file descriptors with FD_CLOEXEC set. Adding a new command to fcntl() requires no new system call and the overall impact on code size if minimal. Tangential

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Erez Zadok
In message [EMAIL PROTECTED], Linus Torvalds writes: On Fri, 28 Sep 2007, Erez Zadok wrote: Documentation/CodingStyle | 88 +- I'm not very happy with this. CodingStyle should be about the big issues, not about details. Yes, we've

Re: 2.6.23-rc8-mm2

2007-09-29 Thread thunder7
From: Greg KH [EMAIL PROTECTED] Date: Sat, Sep 29, 2007 at 08:19:42AM -0700 On Sat, Sep 29, 2007 at 05:37:29PM +0800, Dave Young wrote: Hi, The kernel report warnings about sysfs filename duplicate under rc8-mm1 and rc8-mm2. 1. cut sysfs: duplicate filename 'usbcore' can not

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: I kind of meant the *maintainers* couldn't whine about things not in CodingStyle ;) No, I understood you. I'm personally of the opinion that the automated style checking, and having detailed rules is always a mistake. It's *much* better to

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Al Viro
On Sat, Sep 29, 2007 at 10:24:01PM -0400, [EMAIL PROTECTED] wrote: On Sat, 29 Sep 2007 11:18:05 PDT, Linus Torvalds said: CodingStyle should be about the big issues, not about details. Yes, we've messed that up over the years, but let's not continue that. In other words, I'd suggest

Re: [RFC] Extending kbuild syntax

2007-09-29 Thread Adrian Bunk
On Sat, Sep 29, 2007 at 10:11:45PM +0200, Sam Ravnborg wrote: ... The second is the more controversial suggestion. In several Makefile we have simple if expression of the variants: if ($(CONFIG_FOO),y) obj-$(CONFIG_BAR) += fubar.o endif The pattern varies over this theme. The suggestion

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: I think there needs to be a sense of fairness attached here - CodingStyle should cover all the stuff maintainers/reviewers are allowed to whinge about. No. People whine too much as is. Don't give them *license* to do so. Linus

Re: 2.6.23-rc8-mm2

2007-09-29 Thread Valdis . Kletnieks
On Thu, 27 Sep 2007 02:22:20 PDT, Andrew Morton said: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ Locks up hard at very early boot on my Dell Latitude - grub says loading kernel, the screen clears, and we lock up before we get penguins. -rc8-mm1 was

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Theodore Tso
On Sat, Sep 29, 2007 at 03:56:38PM -0400, J. Bruce Fields wrote: It'd be a start just to revert CodingStyle to its original content and move the rest to CodingStyleReference. But someone would want to skim through the CodingStyle history for any legimate corrections that we want to keep. How

bluetooth: hci_sysfs work queue problem

2007-09-29 Thread Dave Young
Hi, The hci_sysfs uses work queue to finish the sysfs add/del fuction. But when the same device connection failed, if another connection of same device come in before the delete work finish, sysfs will warn about duplicate filename creating. Sep 19 12:30:27 darkstar kernel: sysfs: duplicate

Re: [patch 2/5] Linux Kernel Markers

2007-09-29 Thread Rusty Russell
On Fri, 2007-09-28 at 10:28 -0400, Mathieu Desnoyers wrote: +struct __mark_marker; Hi Mathieu, How about, struct marker. You've taken the marker* namespace, so all these underscores are __gratuitious__ :) +/* + * module_mutex nests inside markers_mutex. Markers mutex protects the

Re: [PATCH] make unicode default

2007-09-29 Thread Antonino A. Daplas
On Sat, 2007-09-29 at 10:36 +0200, Jan Engelhardt wrote: Make the vt return to the system default when it is reset. Also make UTF-8 the system default. It's about time we do, so this is fine with me. Tony - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of

[ANNOUNCE] GIT 1.5.3.3

2007-09-29 Thread Junio C Hamano
The latest maintenance release GIT 1.5.3.3 is available at the usual places: http://www.kernel.org/pub/software/scm/git/ git-1.5.3.3.tar.{gz,bz2} (tarball) git-htmldocs-1.5.3.3.tar.{gz,bz2} (preformatted docs) git-manpages-1.5.3.3.tar.{gz,bz2}

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 03:51:56 PDT, Andrew Morton said: Printing something like bytes remaining: 0x12 (18) is a quite logical thing to do, although pretty darm pointless. On the other hand, printing this: magic number: 0x2710 probably doesn't ring any bells, but if you

Re: [PATCH RFC 6/9] RCU priority boosting for preemptible RCU

2007-09-29 Thread Paul E. McKenney
On Fri, Sep 28, 2007 at 07:05:14PM -0400, Steven Rostedt wrote: -- On Fri, 28 Sep 2007, Gautham R Shenoy wrote: +#ifdef CONFIG_PREEMPT_RCU_BOOST +/* + * Task state with respect to being RCU-boosted. This state is changed + * by the task itself in response to the following

[PATCH] Tweak Documentation/SM501.txt

2007-09-29 Thread Rob Landley
From: Rob Landley [EMAIL PROTECTED] The existing Documentation/SM501.txt gives no clue what the chip is or does, so copy the description from Kconfig help text. cc: Ben Dooks [EMAIL PROTECTED] Signed-off-by: Rob Landley [EMAIL PROTECTED] --- Documentation/SM501.txt |5 + 1 file

Re: [rfc][patch] i386: remove comment about barriers

2007-09-29 Thread Paul E. McKenney
On Sat, Sep 29, 2007 at 03:28:48PM +0200, Nick Piggin wrote: Hi, OK this was going to be a quick patch, but after sleeping on it, I think it deserves a better analysis... I can prove the comment is incorrect with a test program, but I'm not as sure about my thinking that leads me to call it

[PATCH] Add missing entries to top level Documentation/00-INDEX

2007-09-29 Thread Rob Landley
From: Rob Landley [EMAIL PROTECTED] Add missing entries to Documentation/00-INDEX Signed-off-by: Rob Landley [EMAIL PROTECTED] --- Documentation/00-INDEX | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff -r dc28e4e17791 Documentation/00-INDEX ---

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 20:00:01 PDT, Linus Torvalds said: On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: I think there needs to be a sense of fairness attached here - CodingStyle should cover all the stuff maintainers/reviewers are allowed to whinge about. No. People whine too much as

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sun, 30 Sep 2007 04:27:24 BST, Al Viro said: ... and no matter how many rules you put down, it's still possible to write a code that will be awful stylistically while adhering to all of them. Religiously. I've run into those sort of programmers. Unfortunately, there's no real cure for

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Erez Zadok
In message [EMAIL PROTECTED], Linus Torvalds writes: On Sat, 29 Sep 2007, Erez Zadok wrote: Would you prefer if CodingStyle was reorganized or even split into (1) general principles and (2) details? Perhaps we need a CodingStylePrinciples and a CodingStyleDetails? I'm certainly

<    1   2   3   4