Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device

2007-10-28 Thread Jeff Garzik
Dirk Hohndel wrote: [INPUT] hidinput_connect incorrectly ignored return value from input_register_device Signed-off-by: Dirk Hohndel <[EMAIL PROTECTED]> --- drivers/hid/hid-input.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-input.c b/driv

kernel BUG at mm/slab.c:597!

2007-10-28 Thread marco gaddoni
Hello, i got this oops on my server. the kernel is a 2.6.21-2-686 from the debian. this is an ext3 filesystem on a raid0 array of 2 ide disks. got the oops while doing a big rm. any idea on the possible cause? please cc me as i am not subscribed. ciao, marco. [ cut here ]

Re: [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-28 Thread Kirill Korotaev
Can you please send namespace related patches to containers@ ML first before sending them to Linus/Andrew? Thanks, Kirill Eric W. Biederman wrote: > This is my trivial patch to swat innumerable little bugs > with a single blow. > > After some intensive review (my apologies for not having > gott

Re: Problem: OOPS in khubd on disconnect of Labtec USB Headset

2007-10-28 Thread Andrew Morton
On Mon, 22 Oct 2007 15:03:54 -0400 Syd Alsobrook <[EMAIL PROTECTED]> wrote: > OOPS in khubd on disconnect of Labtec USB Headset > > Linux version 2.6.23.1 ([EMAIL PROTECTED]) (gcc version 4.1.3 20070831 > (prerelease) (Debian 4.1.2-16)) #5 SMP PREEMPT Sat Oct 20 11:53:38 EDT 2007 > > BUG: unabl

Re: [BUG] Unable to handle kernel NULL pointer dereference

2007-10-28 Thread Andrew Morton
On Mon, 22 Oct 2007 14:17:14 -0300 "Daniel Cid" <[EMAIL PROTECTED]> wrote: > Sorry if it isn't the right place to ask this question, but I was > reported the following error in the kernel. > > Syscheckd (process in the crash) is a userland (no kernel/lkm code) > file integrity checking tool that

Re: vm_ops.page_mkwrite() fails with vmalloc on 2.6.23

2007-10-28 Thread Andrew Morton
On Mon, 22 Oct 2007 16:40:57 +0200 Stefani Seibold <[EMAIL PROTECTED]> wrote: > Hi, > > i have a problem with vmalloc() and vm_ops.page_mkwrite(). > > ReadOnly access works, but on a write access the VM will > endless invoke the vm_ops.page_mkwrite() handler. > > I tracked down the problem to t

Re: [2.6.23.1] PCI device locking up the computer when its module loads

2007-10-28 Thread Andrew Morton
On Mon, 22 Oct 2007 13:43:16 +0100 (BST) Chris Rankin <[EMAIL PROTECTED]> wrote: > Hi, > > I have a Netgear MA301 PLX wireless networking adapter which wants to use the > hostap_plx driver in > Linux 2.6.23.1. This very same piece of hardware works fine in an old(!) P120 > machine running > 2.4

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-28 Thread Paul Jackson
> Let's add a Choice C: > > Any nodemask that is passed to set_mempolicy() is saved as > the intent of the application in struct mempolicy. Yes > All policies are effected on a contextualized per-allocation > basis. "contextualized" - I guess that means converted to cpuset relat

Re: Device mapper regression 2.6.23 vs. v2.6.23-6597-gcfa76f0

2007-10-28 Thread Andrew Morton
On Sun, 21 Oct 2007 21:23:21 +0200 Thomas Meyer <[EMAIL PROTECTED]> wrote: > Hi. > > I have an external hard drive with an encrypted partition. I am using > kde so all i had to do under 2.6.23 was > "cryptsetup luksOpen /dev/sdb2 crypt-extern" > > then udev/hal/kde (?)automatically created an

[PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device

2007-10-28 Thread Dirk Hohndel
[INPUT] hidinput_connect incorrectly ignored return value from input_register_device Signed-off-by: Dirk Hohndel <[EMAIL PROTECTED]> --- drivers/hid/hid-input.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c in

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-28 Thread Paul Jackson
David wrote: > The problem that I see with immediately offering both choices is that we > don't know if anybody is actually reverting back to Choice A behavior > because libnuma, by default, would use it. That's going to making it very > painful to remove later. Yes, that's a problem. I would

Re: [PATCH 1/2] I8K: Allow i8k driver to be built on x86_64 systems

2007-10-28 Thread Frank Sorenson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik wrote: > Bradley Smith wrote: >> From: Bradley Smith <[EMAIL PROTECTED]> >> >> Adds #if clause and additional inline assembly so that the driver >> builds on x86_64 systems. >> >> Signed-off-by: Bradley Smith <[EMAIL PROTECTED]> > > Is thi

Re: cpu governor ondemand issue

2007-10-28 Thread Andrew Morton
On Sun, 21 Oct 2007 13:16:14 +0200 Toralf Förster <[EMAIL PROTECTED]> wrote: > I use the following one liner for regression tests of the cpufreq governor and > friends: > > [EMAIL PROTECTED] ~ $ time factor 819734028463158891 > > which usually needs 5.5 secs to complete at 1.7 GHz of my pentium

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-28 Thread David Rientjes
On Sun, 28 Oct 2007, Paul Jackson wrote: > > If we can't identify any applications that would be broken by this, what's > > the difference in simply implementing Choice B and then, if we hear > > complaints, add your hack to revert back to Choice A behavior based on the > > get_mempolicy() call

Re: [BUG] [linux-pm] Commit "Hibernation: Enter platform hibernation state in a consistent way)" makes my system to resume instantly from S4

2007-10-28 Thread Maxim Levitsky
On Sunday 28 October 2007 22:23:15 Rafael J. Wysocki wrote: > On Sunday, 28 October 2007 21:00, Maxim Levitsky wrote: > > On Saturday 27 October 2007 23:46:45 Rafael J. Wysocki wrote: > > > On Saturday, 27 October 2007 14:05, Maxim Levitsky wrote: > > > > Hi, > > > > > > > > Recently I noticed tha

Abit F-190HD Onboard rlt8169 Ethernet Controller

2007-10-28 Thread Ciaran McCreesh
The Abit Fatal1ty F-190HD motherboard has a Realtek rlt8169 gigabit ethernet controller onboard. It shows up in lspci as: 02:00.0 Ethernet controller: Unknown device 0001:8168 (rev 01) Subsystem: ABIT Computer Corp. Unknown device 2410 Flags: bus master, fast devsel, latency 0, IRQ

dm: struct io_restriction reordered

2007-10-28 Thread Vasily Averin
it saves some bytes memory Signed-off-by: Vasily Averin <[EMAIL PROTECTED]> --- a/include/linux/device-mapper.h +++ b/include/linux/device-mapper.h @@ -110,12 +110,12 @@ struct target_type { }; struct io_restrictions { + unsigned long seg_boundary_mask; unsigned int

i2o: CONFIG_DEBUG_SG compilation fixed

2007-10-28 Thread Vasily Averin
i2o crashed when CONFIG_DEBUG_SG is enabled because i2o_block_request structure includes array of scatterlists that should be initialised Signed-off-by: Vasily Averin <[EMAIL PROTECTED]> --- a/drivers/message/i2o/i2o_block.c +++ b/drivers/message/i2o/i2o_block.c @@ -1137,6 +1137,18 @@ static stru

i2o: debug messages corrected

2007-10-28 Thread Vasily Averin
max_phys_segments and max_sectors were swapped Signed-off-by: Vasily Averin <[EMAIL PROTECTED]> --- a/drivers/message/i2o/i2o_block.c +++ b/drivers/message/i2o/i2o_block.c @@ -1076,8 +1076,8 @@ static int i2o_block_probe(struct device *dev) blk_queue_max_sectors(queue, max_sectors);

dm: bounce_pfn limit added

2007-10-28 Thread Vasily Averin
Device mapper uses its own bounce_pfn that may differ from one on underlying device. In that way dm can build incorrect requests that contain sg elements greater than underlying device is able to handle. This is the cause of slab corruption in i2o layer, occurred on i386 arch when very long direct

Re: [patch 09/10] SLUB: Do our own locking via slab_lock and slab_unlock.

2007-10-28 Thread Pekka Enberg
Hi, On 10/29/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: > > We don't need preempt_enable for CONFIG_SMP, right? > > preempt_enable is needed if preemption is enabled. Disabled? But yeah, I see that slab_trylock() can leave preemption disabled if cmpxchg fails. Was confused by the #ifdefs...

Re: [REGRESSION] 2.6.24-rc1 fails to boot on a 486

2007-10-28 Thread Mikael Pettersson
On Sun, 28 Oct 2007 21:34:58 -0700, H. Peter Anvin wrote: > Mikael Pettersson wrote: > > My old 486 fails to boot with the 2.6.24-rc1 kernel. > > Grub loads it, 4 lines of text appear but not the kernel's > > "Linux version greet", and the machine reboots. > > Double-checked with a serial console:

Re: [REGRESSION] 2.6.24-rc1 fails to boot on a 486

2007-10-28 Thread Mikael Pettersson
On Sun, 28 Oct 2007 21:33:02 -0700, H. Peter Anvin wrote: > Mikael Pettersson wrote: > > My old 486 fails to boot with the 2.6.24-rc1 kernel. > > Grub loads it, 4 lines of text appear but not the kernel's > > "Linux version greet", and the machine reboots. > > Double-checked with a serial console:

Re: 2.6.23 regression: second access of empty ntfs file leads to D state hang

2007-10-28 Thread Mike Galbraith
hrmph, CC to members only list removed. On Mon, 2007-10-29 at 07:08 +0100, Mike Galbraith wrote: > Greetings, > > I've stumbled across a 2.6.22->2.6.23 regression. First md5sum access > of an empty NTFS file leads to kernel I/O error gripe, a second access > leaves md5sum hung. 2.6.22.10 has no

Re: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

2007-10-28 Thread Tejun Heo
Shane Huang wrote: >> I would like those to be removed, but to be conservative we should >> first get some testing feedback that confirms this just like those >> provided to me from the AMD folks for the RS690, RX790 and RD580 >> cases. >> >> Otherwise the risk to break people's systems is very rea

RE: [PATCH] ucc_geth: add support for netpoll

2007-10-28 Thread Li Yang-r58472
> -Original Message- > From: Anton Vorontsov [mailto:[EMAIL PROTECTED] > Sent: Saturday, October 27, 2007 10:38 PM > To: Sergei Shtylyov > Cc: Anton Vorontsov; [EMAIL PROTECTED]; Li Yang-r58472; > linux-kernel@vger.kernel.org; [EMAIL PROTECTED] > Subject: Re: [PATCH] ucc_geth: add support

Re: western digital WD1500ADFD: spurious completions during NCQ

2007-10-28 Thread Tejun Heo
Jeff Garrett wrote: > Several threads that suggest this message is related to poor NCQ > support, but I did not see any for this drive. It's a Western Digital > WD1500ADFD-00NLR1. Is this the same thing, and should this drive be > blacklisted? How reproducible is the problem? -- tejun - To uns

2.6.23 regression: second access of empty ntfs file leads to D state hang

2007-10-28 Thread Mike Galbraith
Greetings, I've stumbled across a 2.6.22->2.6.23 regression. First md5sum access of an empty NTFS file leads to kernel I/O error gripe, a second access leaves md5sum hung. 2.6.22.10 has no trouble accessing this file. Looking at the 22->23 diff, I don't see a quick and dirty stab candidate, and

RE: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

2007-10-28 Thread Shane Huang
> I would like those to be removed, but to be conservative we should > first get some testing feedback that confirms this just like those > provided to me from the AMD folks for the RS690, RX790 and RD580 > cases. > > Otherwise the risk to break people's systems is very real. In fact, our team o

Re: [RFC: 2.6 patch] remove the USB_STORAGE_ONETOUCH driver

2007-10-28 Thread Torsten Kaiser
On 10/29/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > On Sunday 28 October 2007 16:39, Jiri Kosina wrote: > > On Sun, 28 Oct 2007, Torsten Kaiser wrote: > > > > > But it looks like that uses another driver: > > > hiddev0hidraw1: USB HID v1.10 Device [Western Digital External HDD] on > > > usb-0

Re: [PATCH] Align PCI memory regions to page size (4K) - Fix

2007-10-28 Thread Grant Grundler
On Sun, Oct 28, 2007 at 01:03:36PM -0700, Greg KH wrote: > On Sun, Oct 28, 2007 at 03:53:20PM -0400, Barak Fargoun wrote: ... > > About your question: today, some of the hypervisors are using linux > > kernel as their domain-0 (e.g. Xen). In order to implement direct > > hardware access for these n

Re: [alsa-devel] sysfs: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() - with ALSA

2007-10-28 Thread Kamalesh Babulal
Tobin Davis wrote: > First think I noticed, why are you compiling all the drivers into the > kernel instead of as modules? Do you need every sound device supported > simultaneously? > > Tobin > > On Fri, 2007-10-26 at 22:45 +0530, Kamalesh Babulal wrote: >> Takashi Iwai wrote: >> > At Fri, 26 Oc

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-28 Thread Paul Jackson
David wrote: > If we can't identify any applications that would be broken by this, what's > the difference in simply implementing Choice B and then, if we hear > complaints, add your hack to revert back to Choice A behavior based on the > get_mempolicy() call you specified is always part of libn

Re: [PATCH 1/4] stringbuf: A string buffer implementation

2007-10-28 Thread Rusty Russell
On Monday 29 October 2007 14:03:52 Matt Mackall wrote: > And on SLOB, which doesn't have those bloaty power-of-2 constraints? > Looks like ~500 reallocs, including 25 bytes of memcpy. Ouch! In other words, the system was compiled for size optimization and that's what happened. The question is

[PATCH] Quieten hrtimer printk: "Switched to high resolution mode .."

2007-10-28 Thread Michael Ellerman
Change the hrtimer printk "Switched to high resolution mode .." to be KERN_DEBUG, rather than KERN_INFO. If users need to see this they can pass "loglevel" or "debug" on the command line, or check dmesg. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- Any objections? It gets a little repe

Re: [PATCH] Silence radeon_pm warning

2007-10-28 Thread Stephen Rothwell
On Mon, 29 Oct 2007 00:02:02 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > I posted this one a few days ago, without adding a new ifdef (just moving the > declaration down into the already existing ifdef below it): > > http://marc.info/?l=linux-kernel&m=119311699109698&w=2 Yeah, missed that

Re: [2.6 patch] kprobe_exceptions_notify(): fix NULL dereference

2007-10-28 Thread Ananth N Mavinakayanahalli
On Sat, Oct 27, 2007 at 04:19:14PM +0200, Adrian Bunk wrote: > This patch fixes later NULL dereferences spotted by the Coverity > checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> NACK... see below > --- > > BTW: The avr32 and s390 versions of kprobe_exceptions_notify() are > no

Re: [PATCH] [SCTP] endianness annotations regression

2007-10-28 Thread David Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 05:03:23 + > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: David S. Miller <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majord

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-28 Thread Arjan van de Ven
On Sun, 28 Oct 2007 15:08:56 -0700 Crispin Cowan <[EMAIL PROTECTED]> wrote: > To reject an LSM for providing "bad" security, IMHO you should have to > show how it is possible to subvert the self-stated goals of that LSM. > Complaints that the LSM fails to meet some goal outside of its stated > pur

arcmsr: endianness bug

2007-10-28 Thread Al Viro
initializing a field in data shared with the card with cpu_to_le32(something) | 0x10 is broken - the field is, indeed, little-endian and we need cpu_to_le32() on both parts. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/scsi/arcmsr/arcmsr_hba.c |2 +- 1 files changed, 1 insertio

fix reentrancy bug in arcmsr_get_iop_{r,w}qbuffer()

2007-10-28 Thread Al Viro
doh... Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/scsi/arcmsr/arcmsr_hba.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index acbc50f..d466a2d 100644 --- a/drivers/scsi/arcmsr/arcmsr_hb

[PATCH] fix abuses of ptrdiff_t

2007-10-28 Thread Al Viro
Use of ptrdiff_t in places like - if (!access_ok(VERIFY_WRITE, u_tmp->rx_buf, u_tmp->len)) + if (!access_ok(VERIFY_WRITE, (u8 __user *) + (ptrdiff_t) u_tmp->rx_buf, +

deal with resource allocation bugs in arcmsr

2007-10-28 Thread Al Viro
a) for type B we should _not_ iounmap() acb->pmu; it's not ioremapped. b) for type B we should iounmap() two regions we _do_ ioremap. c) if ioremap() fails, we need to bail out (and clean up). Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/scsi/arcmsr/arcmsr.h |9 - drive

trivial annotations in arcmsr

2007-10-28 Thread Al Viro
driver still has serious portability problems Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/scsi/arcmsr/arcmsr.h | 32 --- drivers/scsi/arcmsr/arcmsr_attr.c |6 +- drivers/scsi/arcmsr/arcmsr_hba.c | 170 ++--- 3 files changed, 103 inserti

[PATCH] [SCTP] endianness annotations regression

2007-10-28 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- include/net/sctp/auth.h |2 +- net/sctp/auth.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/net/sctp/auth.h b/include/net/sctp/auth.h index 9e8f13b..5db261a 100644 --- a/include/net/sctp/auth.h +++ b

Re: [PATCH] Silence radeon_pm warning

2007-10-28 Thread Olof Johansson
On Mon, Oct 29, 2007 at 01:59:11PM +1100, Stephen Rothwell wrote: > drivers/video/aty/radeon_pm.c:30: warning: 'radeon_reinitialize_M10' declared > 'static' but never defined > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> I posted this one a few days ago, without adding a new ifdef (jus

[PATCH] intel-iommu fixes

2007-10-28 Thread Al Viro
* off by one in dmar_get_fault_reason() (maximal index in array is ARRAY_SIZE()-1, not ARRAY_SIZE()) * NULL noise removal * __iomem annotation fix Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c index 0c4ab3b

Re: [PATCH] [SUNRPC] endianness annotations

2007-10-28 Thread David Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 04:37:58 + > rpcrdma stuff lacks endianness annotations for on-the-wire data. > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: David S. Miller <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linu

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-28 Thread David Rientjes
On Sun, 28 Oct 2007, Paul Jackson wrote: > And, unless someone in the know tells us otherwise, I have to assume > that this could break them. Now, the odds are that they simply don't > run that solution stack on any system making active use of cpusets, > so the odds are this would be no problem f

Re: [PATCH] slub: nr_slabs is an atomic_long_t

2007-10-28 Thread Olof Johansson
On Mon, Oct 29, 2007 at 02:24:30PM +1100, Stephen Rothwell wrote: > On Sun, 28 Oct 2007 19:53:55 -0700 (PDT) Christoph Lameter <[EMAIL > PROTECTED]> wrote: > > > > That was already fixed AFAICT. > > Not in Linus' tree, yet. Nope, it's still sitting in -mm. Al Viro just posted the same fix too.

[PATCH] missing atomic_read_long() in slub.c

2007-10-28 Thread Al Viro
nr_slabs is atomic_long_t, not atomic_t Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/mm/slub.c b/mm/slub.c index aac1dd3..bcdb2c8 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2734,7 +2734,7 @@ static void slab_mem_offline_callback(void *arg) * and offline_page

[PATCH] [SUNRPC] endianness annotations

2007-10-28 Thread Al Viro
rpcrdma stuff lacks endianness annotations for on-the-wire data. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/include/linux/sunrpc/rpc_rdma.h b/include/linux/sunrpc/rpc_rdma.h index 0013a0d..87b895d 100644 --- a/include/linux/sunrpc/rpc_rdma.h +++ b/include/linux/sunrpc/rpc_rdma.h @

Re: [REGRESSION] 2.6.24-rc1 fails to boot on a 486

2007-10-28 Thread H. Peter Anvin
Mikael Pettersson wrote: My old 486 fails to boot with the 2.6.24-rc1 kernel. Grub loads it, 4 lines of text appear but not the kernel's "Linux version greet", and the machine reboots. Double-checked with a serial console: nothing appears before it reboots. All 2.6 kernels up to 2.6.23 worked f

Re: [REGRESSION] 2.6.24-rc1 fails to boot on a 486

2007-10-28 Thread H. Peter Anvin
Mikael Pettersson wrote: My old 486 fails to boot with the 2.6.24-rc1 kernel. Grub loads it, 4 lines of text appear but not the kernel's "Linux version greet", and the machine reboots. Double-checked with a serial console: nothing appears before it reboots. What four lines of text? -h

[PATCH] misc uml annotation and section fixes

2007-10-28 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c index 8456397..59822de 100644 --- a/arch/um/kernel/mem.c +++ b/arch/um/kernel/mem.c @@ -165,7 +165,7 @@ static void __init kmap_init(void) kmap_prot = PAGE_KERNEL; } -static void init

[PATCH] more x86 merge fallout (uml, again)

2007-10-28 Thread Al Viro
arch/i386/{Kconfig,Makefile}.cpu got moved Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/arch/um/Kconfig.i386 b/arch/um/Kconfig.i386 index 9876d80..e0ac74e 100644 --- a/arch/um/Kconfig.i386 +++ b/arch/um/Kconfig.i386 @@ -1,6 +1,6 @@ menu "Host processor type and features" -source

[PATCH] x86 merge fallout: uml

2007-10-28 Thread Al Viro
Don't undef __i386__/__x86_64__ in uml anymore, make sure that (few) places that required adjusting the ifdefs got those. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/um/Makefile-i386 |3 +-- arch/um/Makefile-x86_64 |5 + drivers/char/mem.c|4 ++-- drivers/md/

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-28 Thread Paul Jackson
> Nobody can show an example of an application that would be broken because > of this and, given the scenario and sequence of events that it requires to > be broken when implementing the default as Choice B, I don't think it's as > much of an issue as you believe. Well, neither you nor I have s

Re: [PATCH] [CIFS] Silence two "defined but unused" warning

2007-10-28 Thread Steve French
This should already be in the cifs-2.6.git tree and next -mm (I am waiting on the finish up of some CIFS ACL mapping code before requesting another cifs merge with mainline) http://git.kernel.org/?p=linux/kernel/git/sfrench/cifs-2.6.git;a=commitdiff;h=c94897790e7c67dcfe3a0b6f035996398c268313 On 1

Re: bluetooth: hci_sysfs work queue problem

2007-10-28 Thread Dave Young
On 10/1/07, Marcel Holtmann <[EMAIL PROTECTED]> wrote: > Hi Dave, > > > The hci_sysfs uses work queue to finish the sysfs add/del fuction. > > But when the same device connection failed, if another connection of > > same device come in before the delete work finish, sysfs will warn > > about duplic

Re: [patch 08/10] SLUB: Optional fast path using cmpxchg_local

2007-10-28 Thread Christoph Lameter
On Sun, 28 Oct 2007, Pekka J Enberg wrote: > - local_irq_restore(flags); > + object = do_slab_alloc(s, c, gfpflags, node, addr); > + if (unlikely(!object)) > + goto out; Undoing the optimization that one of the earlier patches added. The #ifdef version is for me at least

Re: [PATCH] slub: nr_slabs is an atomic_long_t

2007-10-28 Thread Stephen Rothwell
On Sun, 28 Oct 2007 19:53:55 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > > That was already fixed AFAICT. Not in Linus' tree, yet. -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpttYSDYSayZ.pgp Description: PGP signature

Re: [RFC, PATCH] locks: remove posix deadlock detection

2007-10-28 Thread Trond Myklebust
On Sun, 2007-10-28 at 16:41 -0600, Matthew Wilcox wrote: > On Sun, Oct 28, 2007 at 05:50:30PM -0400, Trond Myklebust wrote: > > > You can't fix the false EDEADLK detection without solving the halting > > > problem. Best of luck with that. > > > > I can see that it would be difficult to do effici

Re: [PATCH] Silence radeon_pm warning

2007-10-28 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 13:59:11 +1100 > drivers/video/aty/radeon_pm.c:30: warning: 'radeon_reinitialize_M10' declared > 'static' but never defined > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> Acked-by: David S. Miller <[EMAIL PROTECTED]> - T

Re: [PATCH 1/4] stringbuf: A string buffer implementation

2007-10-28 Thread Matt Mackall
On Sat, Oct 27, 2007 at 08:09:30PM +1000, Rusty Russell wrote: > On Saturday 27 October 2007 06:57:14 Matt Mackall wrote: > > Well I expect once you start letting people easily build strings by > > concatenation, you'll very shortly afterwards have people using them > > in loops. And having hidden

Re: [patch 09/10] SLUB: Do our own locking via slab_lock and slab_unlock.

2007-10-28 Thread Christoph Lameter
On Sun, 28 Oct 2007, Pekka J Enberg wrote: > It would be easier to review the actual locking changes if you did the > SlabXXX removal in a separate patch. There are no locking changes. > > -static __always_inline void slab_lock(struct page *page) > > +static __always_inline void slab_unlock(str

Re: [patch 08/10] SLUB: Optional fast path using cmpxchg_local

2007-10-28 Thread Christoph Lameter
On Sun, 28 Oct 2007, Pekka J Enberg wrote: > Can you please write a comment of the locking rules when cmpxchg_local() > is used? Looks as if we could push that local_irq_save() to slub_lock() > and local_irq_restore() to slub_unlock() and deal with the unused flags > variable for the non-CONFIG

[PATCH] Silence radeon_pm warning

2007-10-28 Thread Stephen Rothwell
drivers/video/aty/radeon_pm.c:30: warning: 'radeon_reinitialize_M10' declared 'static' but never defined Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- drivers/video/aty/radeon_pm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- Cheers, Stephen Rothwell

Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c

2007-10-28 Thread Daniel Phillips
On 10/28/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > While you're at it, it's probably worth splitting this out into > a small helper function. Why? Is the same pattern called from more than one place? Regards, Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [M68KNOMMU]: new style ColdFire UART driver

2007-10-28 Thread Greg Ungerer
Hi Andrew, Andrew Morton wrote: On Fri, 19 Oct 2007 11:42:41 +1000 Greg Ungerer <[EMAIL PROTECTED]> wrote: A new style serial driver for the Freescale ColdFire UART to replace the old style one currently in the tree (drivers/serial/mcfserial.c). Currently this UART is only found in the ColdFi

[PATCH] [CIFS] Silence two "defined but unused" warning

2007-10-28 Thread Stephen Rothwell
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- fs/cifs/cifssmb.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- Cheers, Stephen Rothwell[EMAIL PROTECTED] diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index f0d9a48..aa9dc9e 100644 --- a/fs/cifs/

Re: [PATCH] slub: nr_slabs is an atomic_long_t

2007-10-28 Thread Christoph Lameter
On Mon, 29 Oct 2007, Stephen Rothwell wrote: > so shouldn't be passed to atomic_read. That was already fixed AFAICT. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH 0/5] Detect hwmon and i2c bus drivers interfering with ACPI Operation Region resources

2007-10-28 Thread Bjorn Helgaas
On Saturday 27 October 2007 9:09:47 am Matthew Garrett wrote: > On Thu, Oct 25, 2007 at 09:06:22AM -0600, Bjorn Helgaas wrote: > > But we really *should* reserve things used by opregions, shouldn't > > we? After all, the whole point of resource reservation is to prevent > > conflicts. > > Only if

Re: [RFC: 2.6 patch] remove the USB_STORAGE_ONETOUCH driver

2007-10-28 Thread Dmitry Torokhov
On Sunday 28 October 2007 16:39, Jiri Kosina wrote: > On Sun, 28 Oct 2007, Torsten Kaiser wrote: > > > But it looks like that uses another driver: > > hiddev0hidraw1: USB HID v1.10 Device [Western Digital External HDD] on > > usb-:00:02.1-5.2 > > Otherwise I would be willing to try to test thi

Re: [PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names

2007-10-28 Thread Randy Dunlap
On Sun, 28 Oct 2007 20:40:56 -0400 Erez Zadok wrote: > Rename old vfs_ioctl to do_ioctl, because the comment above it clearly > indicates that it is an internal function not to be exported to modules; > therefore it should have a more traditional do_XXX name. The new do_ioctl > is exported in fs.

Re: [RFC, PATCH] locks: remove posix deadlock detection

2007-10-28 Thread J. Bruce Fields
On Sun, Oct 28, 2007 at 11:38:26PM +, Alan Cox wrote: > > > The spec and SYSV certainly ignore threading in this situation and you > > > know that perfectly well (or did in 2004) > > > > The discussion petered out (or that mailing list archive lost articles > > from the thread) without any kin

Re: aim7 -30% regression in 2.6.24-rc1

2007-10-28 Thread Zhang, Yanmin
On Fri, 2007-10-26 at 13:23 +0200, Ingo Molnar wrote: > * Zhang, Yanmin <[EMAIL PROTECTED]> wrote: > > > I tested 2.6.24-rc1 on my x86_64 machine which has 2 quad-core processors. > > > > Comparing with 2.6.23, aim7 has about -30% regression. I did a bisect > > and found patch > > http://git.ke

[PATCH] slub: nr_slabs is an atomic_long_t

2007-10-28 Thread Stephen Rothwell
so shouldn't be passed to atomic_read. mm/slub.c: In function 'slab_mem_offline_callback': mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from incompatible pointer type mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from incompatible pointer type mm/slub.c:2737: warni

Re: [RFC, PATCH] locks: remove posix deadlock detection

2007-10-28 Thread J. Bruce Fields
On Sun, Oct 28, 2007 at 04:41:57PM -0600, Matthew Wilcox wrote: > On Sun, Oct 28, 2007 at 05:50:30PM -0400, Trond Myklebust wrote: > > > You can't fix the false EDEADLK detection without solving the halting > > > problem. Best of luck with that. > > > > I can see that it would be difficult to do

Re: 2.6.24-rc1-git4: Reported regressions from 2.6.23

2007-10-28 Thread Frans Pop
David Miller wrote: > >> Subject: Settings to /proc/sys/net/ipv[46]/conf/all are >> not propagated. via sysctl too >> Submitter : Serge van den Boom <[EMAIL PROTECTED]> >> References: http://bugzilla.kernel.org/show_bug.cgi?id=9224 >> Handled-By: Hideaki YOSHIFUJI <[EMAIL PROTEC

Re: 2.6.24-rc1-git4: Reported regressions from 2.6.23

2007-10-28 Thread Rafael J. Wysocki
On Monday, 29 October 2007 02:17, David Miller wrote: > From: "Rafael J. Wysocki" <[EMAIL PROTECTED]> > Date: Sun, 28 Oct 2007 23:51:55 +0100 > > > Subject : Settings to /proc/sys/net/ipv[46]/conf/all are not > > propagated. via sysctl too > > Submitter : Serge van den Boom <[EMAIL

Re: 2.6.24-rc1-git4: Reported regressions from 2.6.23

2007-10-28 Thread David Miller
From: "Rafael J. Wysocki" <[EMAIL PROTECTED]> Date: Sun, 28 Oct 2007 23:51:55 +0100 > Subject : Settings to /proc/sys/net/ipv[46]/conf/all are not > propagated. via sysctl too > Submitter : Serge van den Boom <[EMAIL PROTECTED]> > References: http://bugzilla.kernel.org/show_

Re: [RFC, PATCH] locks: remove posix deadlock detection

2007-10-28 Thread J. Bruce Fields
On Sun, Oct 28, 2007 at 06:40:52PM +, Alan Cox wrote: > On Sun, 28 Oct 2007 12:27:32 -0600 > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > On Sun, Oct 28, 2007 at 01:43:21PM -0400, J. Bruce Fields wrote: > > > We currently attempt to return -EDEALK to blocking fcntl() file locking > > > requ

Re: [PATCH] Only show RESOURCES_64BIT on relevant architectures

2007-10-28 Thread David Miller
From: Kyle McMartin <[EMAIL PROTECTED]> Date: Sun, 28 Oct 2007 16:15:49 -0400 > To quote lolcats: CONFIG_RESOURCES_64BIT DO NOT WANT! > > I *think* I have the logic of this right... Anyway, I was annoyed by > having to do the bloody ugly casts to unsigned long long in > arch-specific code. As nea

Re: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

2007-10-28 Thread David Miller
From: "David Gaarenstroom" <[EMAIL PROTECTED]> Date: Sun, 28 Oct 2007 21:11:13 +0100 > > I would like those to be removed, but to be conservative we should > > first get some testing feedback that confirms this just like those > > provided to me from the AMD folks for the RS690, RX790 and RD580 >

Re: [PATCH] Align PCI memory regions to page size (4K) - Fix

2007-10-28 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Sun, 28 Oct 2007 13:03:36 -0700 > But doesn't aligning such regions on that alignment break some devices > as that is not what the device is asking for in the BIOS? There are also platforms where bootup firmware chooses the allocations, and that is what we

Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support

2007-10-28 Thread Huang, Ying
On Fri, 2007-10-26 at 12:31 +0100, Alan Cox wrote: > On Fri, 26 Oct 2007 09:03:11 +0800 > "Huang, Ying" <[EMAIL PROTECTED]> wrote: > > > On Thu, 2007-10-25 at 18:09 +0200, Thomas Gleixner wrote: > > > > EFI runtime > > > > services initialization are implemented in efi.c. Some x86_64 > > > > speci

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-28 Thread David Rientjes
On Sun, 28 Oct 2007, Paul Jackson wrote: > The Linux documentation is not a legal contract. Anytime we change the > actual behaviour of the code, we have to ask ourselves what will be the > impact of that change on existing users and usages. The burden is on > us to minimize breaking things (by

Linux 2.6.16.56-rc2

2007-10-28 Thread Adrian Bunk
Security fixes since 2.6.16.55: - CVE-2007-3739: Don't allow the stack to grow into hugetlb reserved regions - CVE-2007-4133: hugetlb: fix prio_tree unit Location: ftp://ftp.kernel.org/pub/linux/kernel/people/bunk/linux-2.6.16.y/testing/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/st

[PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names

2007-10-28 Thread Erez Zadok
Rename old vfs_ioctl to do_ioctl, because the comment above it clearly indicates that it is an internal function not to be exported to modules; therefore it should have a more traditional do_XXX name. The new do_ioctl is exported in fs.h but not to modules. Rename the old do_ioctl to vfs_ioctl be

[PATCH 4/4] Unionfs: use vfs_ioctl

2007-10-28 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 32 ++-- 1 files changed, 6 insertions(+), 26 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index 50e5775..c99b519 100644 --- a/fs/unionfs/commonfops.c +++ b/fs/

[PATCH 1/4] VFS: apply coding standards to fs/ioctl.c

2007-10-28 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/ioctl.c | 164 +++- 1 files changed, 84 insertions(+), 80 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index c2a773e..652cacf 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -12,8 +12,8

[PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls

2007-10-28 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/ioctl.c | 128 ++- 1 files changed, 74 insertions(+), 54 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index 34e3f58..8dd2ef1 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -54,32 +54,34

[PATCH] 0/4 fs/ioctl.c coding style, rename vfs_ioctl/do_ioctl, refactoring (take 2)

2007-10-28 Thread Erez Zadok
This series of 4 proposed patches changes fs/ioctl.c and Unionfs as follows. This series is against v2.6.24-rc1-192-gef49c32. Patch 1: just applies coding standards to fs/ioctl.c (while I'm at it, I figured it's worth cleaning VFS files one at a time). Patch 2: does two things: (a) Renames the

Re: aim7 -30% regression in 2.6.24-rc1

2007-10-28 Thread Zhang, Yanmin
On Fri, 2007-10-26 at 11:53 +0200, Peter Zijlstra wrote: > On Fri, 2007-10-26 at 17:43 +0800, Zhang, Yanmin wrote: > > I tested 2.6.24-rc1 on my x86_64 machine which has 2 quad-core processors. > > > > Comparing with 2.6.23, aim7 has about -30% regression. I did a bisect and > > found > > patch

Re: [PATCH v2] pcmcia: Remove replace kio_addr_t with unsigned int everywhere

2007-10-28 Thread Olof Johansson
On Mon, Oct 29, 2007 at 10:50:05AM +1100, Stephen Rothwell wrote: > Hi Olof, > > diffstat output is very useful - especially for patches like this that > touch lots of files. It makes it easier for potential reviewers to see > if they should be potential reviewers. :-) Hi, Good point. I'll inc

[REGRESSION] 2.6.24-rc1 fails to boot on a 486

2007-10-28 Thread Mikael Pettersson
My old 486 fails to boot with the 2.6.24-rc1 kernel. Grub loads it, 4 lines of text appear but not the kernel's "Linux version greet", and the machine reboots. Double-checked with a serial console: nothing appears before it reboots. All 2.6 kernels up to 2.6.23 worked fine on this machine. Confi

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-28 Thread Peter Dolding
On 10/29/07, Crispin Cowan <[EMAIL PROTECTED]> wrote: > To reject an LSM for providing "bad" security, IMHO you should have to > show how it is possible to subvert the self-stated goals of that LSM. > Complaints that the LSM fails to meet some goal outside of its stated > purpose is irrelevant. Con

Re: [PATCH v2] pcmcia: Remove replace kio_addr_t with unsigned int everywhere

2007-10-28 Thread Stephen Rothwell
Hi Olof, diffstat output is very useful - especially for patches like this that touch lots of files. It makes it easier for potential reviewers to see if they should be potential reviewers. :-) -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-28 Thread Paul Jackson
David wrote: > From a standpoint of the MPOL_PREFERRED memory policy itself, there > is no documented behavior or standard that specifies its interaction > with cpusets. Thus, it's "undefined." We are completely free > to implement an undefined behavior as we choose and change it as > Linux matur

  1   2   3   >