Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Marcin Slusarz <[EMAIL PROTECTED]> wrote: > if (hex_val < 0) > break; > *long_val = (*long_val << 4) | hex_val; > num++; > (*ptr)++; agreed, fixed. > > + remcom_out_buffer[0] = 'S'; > > + remcom_out_buffer[1] = hexchars[ks->signo >> 4]; > > + remcom_out_buffer[2] = hexchars[ks->si

Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Marcin Slusarz <[EMAIL PROTECTED]> wrote: > > + if (CACHE_FLUSH_IS_SAFE) { > > + if (current->mm && addr < TASK_SIZE) { > > + flush_cache_range(current->mm->mmap_cache, > > + addr, addr + BREAK_INSTR

Marvel based pcie gbit controller on nForce 630i mainboard

2008-02-10 Thread Christian Auby
I recently acquired an XFX nForce 630i based motherboard, and have been experiencing hard freezes from time to time that I originally had no idea why happened. With hard freeze I mean exactly that; no log messages that I know of (though there might be some I don't know of), picture and input fr

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Atsushi Nemoto
On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > + /* reset DMA masks only for SFF-style DMA controllers */ > + if ((d->host_flags && IDE_HFLAG_NO_DMA) == 0 && hwif->dma_base == 0) > + hwif->swdma_mask = hwif->mwdma_mask = hwif->ultra_m

Re: [4/6] consoles: polling support, kgdboc

2008-02-10 Thread Ingo Molnar
* Jan Kiszka <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > > From: Jan Kiszka <[EMAIL PROTECTED]> > > > > Well, actually not from me but from Jason. I think I just touched it > last for the configuration cleanups. i restructured it in some major ways but wanted to keep the original autho

Re: [PATCH] ftrace: remove unused tracing_sched_switch_enabled

2008-02-10 Thread Eugene Teo
> tracing_sched_switch_enabled isn't used anywhere. > > Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> Sorry, I forgot to remove the variable declaration. Here's a resend: tracing_sched_switch_enabled isn't used anywhere. Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> --- kernel/trace/trace.h

[PATCH] ftrace: remove unused tracing_sched_switch_enabled

2008-02-10 Thread Eugene Teo
tracing_sched_switch_enabled isn't used anywhere. Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> --- kernel/trace/trace.h |1 - kernel/trace/trace_sched_switch.c |9 + 2 files changed, 1 insertions(+), 9 deletions(-) diff --git a/kernel/trace/trace.h b/kernel/trace/tr

Re: sparc compile error

2008-02-10 Thread Martin Habets
This still gives build errors with CGROUP_MEM_CONT off. Some ifdef-ing will fix that. Martin Signed-off-by: Martin Habets <[EMAIL PROTECTED]> Index: sparc-2.6.git/mm/rmap.c === --- sparc-2.6.git.orig/mm/rmap.c2008-

Re: [PATCH] splice: fix user pointer access in get_iovec_page_array()

2008-02-10 Thread Oliver Pinter
Signed-off-by: Oliver Pinter <[EMAIL PROTECTED]> 8< Linux pancs 2.6.22.17-opt2-cve2 #1 SMP Sun Feb 10 16:22:37 CET 2008 i686 GNU/Linux --- Linux vmsplice Local Root Exploit By qaaz --- [+] mmap: 0x0 .. 0x1000 [+] page: 0x0

[PATCH] Cast cmpxchg and cmpxchg_local result for 386 and 486

2008-02-10 Thread Mathieu Desnoyers
Vegard Nossum <[EMAIL PROTECTED]> : > Hi, > > I get these warnings when compiling mm/slub.c in linux-2.6.git: > > mm/slub.c: In function 'slab_alloc': > mm/slub.c:1637: warning: assignment makes pointer from integer without a cast > mm/slub.c:1637: warning: assignment makes pointer from integer wit

Re: [PATCH][7/8] kgdb: exclusive use kgdb8250 uart I/O driver

2008-02-10 Thread Pavel Machek
Hi! > This patch some small hooks into the normal serial core so that a uart > can be unregistered to be exclusively used for KGDB. These changes > allow for registering and unregistering a port with a struct > uart_port. From that point on KGDB does raw accesses to the serial > IO ports it has t

Re: [12/19] ftrace: function tracer

2008-02-10 Thread Ingo Molnar
* Eugene Teo <[EMAIL PROTECTED]> wrote: > kerndev: /sys/kernel/debug/tracing$ cat current_tracer > ftrace > kerndev: /sys/kernel/debug/tracing$ cat tracing_enabled > 1 > kerndev: /sys/kernel/debug/tracing$ cat iter_ctrl > noprint-parent nosym-offset nosym-addr noverbose > kerndev: /sys/kernel

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-10 Thread Bauke Jan Douma
David Newall wrote on 03-02-08 16:07: Greg KH wrote: It comes down to the simple fact, if you wish to use Linux, abide by the license it comes under. To do otherwise is both disenginous and illegal[1]. I think you're being dishonest. This isn't really about Linux and it being licensed under

Re: [PATCH] splice: fix user pointer access in get_iovec_page_array()

2008-02-10 Thread Bastian Blank
On Sun, Feb 10, 2008 at 04:47:57PM +0200, Pekka J Enberg wrote: > From: Bastian Blank <[EMAIL PROTECTED]> > > The commit 8811930dc74a503415b35c4a79d14fb0b408a361 ("splice: missing user > pointer access verification") added access_ok() to copy_from_user_mmap_sem() > which only ensures we can copy t

[PATCH] [arch/arm/mach-pnx4008/gpio.c] duplication in if ... else if branches

2008-02-10 Thread Roel Kluin
There is a duplication of code in the following section. Possibly it was copy-pasted and it was forgotten to edit these lines? otherwise consider removing the duplicate lines with the patch below. --- Different if ... else if branches do the same, remove duplication Signed-off-by: Roel Kluin <[EMA

Re: cups slow on linux-2.6.24

2008-02-10 Thread Jeff Chua
On Feb 5, 2008 9:47 PM, Patrick McHardy wrote: On Feb 5, 2008 4:16 PM, Jozsef Kadlecsik wrote: Patrick, I suppose you need a patch against the latest git, don't you? Yes, please. I'll take you first patch for -stable though if you send me a Signed-off-by: line. Please note the lastest git com

Re: [RFC] ext3: per-process soft-syncing data=ordered mode

2008-02-10 Thread Al Boldi
Andreas Dilger wrote: > On Jan 26, 2008 08:27 +0300, Al Boldi wrote: > > Jan Kara wrote: > > > > data=ordered mode has proven reliable over the years, and it does > > > > this by ordering filedata flushes before metadata flushes. But this > > > > sometimes causes contention in the order of a 10x

Re: [PATCH] Change pci_raw_ops to pci_raw_read/write

2008-02-10 Thread Matthew Wilcox
On Sat, Feb 09, 2008 at 11:21:16PM -0800, Greg KH wrote: > Can I get a revised version of this, without the incorrect hunk? Sure. I've even rebased it against current HEAD. Damn whitespace cleanup introducing unnecessary conflicts I suggest Ivan's patch be merged ASAP as it actually fixes

[PATCH] splice: fix user pointer access in get_iovec_page_array()

2008-02-10 Thread Pekka J Enberg
From: Bastian Blank <[EMAIL PROTECTED]> The commit 8811930dc74a503415b35c4a79d14fb0b408a361 ("splice: missing user pointer access verification") added access_ok() to copy_from_user_mmap_sem() which only ensures we can copy the struct iovecs from userspace to the kernel but we also must check wheth

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread Boaz Harrosh
On Sun, Feb 10 2008 at 16:20 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > On Sun, 2008-02-10 at 13:58 +, Russell King wrote: >> On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: >>> It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310 >>> [SCSI] arm: convert to accesso

bug in checkpatch (on pointers to typedefs?)

2008-02-10 Thread Marcin Slusarz
Hi Checkpatch in current mainline outputs following errors: $ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c ERROR: need consistent spacing around '*' (ctx:WxV) #205: FILE: fs/udf/misc.c:205: + tag *tag_p; ^ $ ./scripts/checkpatch.pl -q --file ./fs/udf/unicode.c ERROR: need

Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

2008-02-10 Thread S.Çağlar Onur
Hi; 10 Şub 2008 Paz tarihinde, Richard Knutsson şunları yazmıştı: > S.Çağlar Onur wrote: > > Hi; > > > > Following patch silents > > > > net/bluetooth/hci_sysfs.c: In function `del_conn': > > net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around > > assignment used as truth value >

Re: [stable 2.6.24] WARNING: at kernel/time/clockevents.c

2008-02-10 Thread Frans Pop
On Sunday 10 February 2008, Frans Pop wrote: > I have no idea yet what triggers it and am unsure if I'll be able to > reproduce. I think I know at least _when_ it happens: during compilation of glibc. This was almost certainly while compiling in the normal amd64 environment: > Pid: 2210, comm: ld

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread James Bottomley
On Sun, 2008-02-10 at 13:58 +, Russell King wrote: > On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: > > It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310 > > [SCSI] arm: convert to accessors and !use_sg cleanup > > > > Thanks for checking. This patch was in scsi-pendi

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread Boaz Harrosh
On Sun, Feb 10 2008 at 15:58 +0200, Russell King <[EMAIL PROTECTED]> wrote: > On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: >> It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310 >> [SCSI] arm: convert to accessors and !use_sg cleanup >> >> Thanks for checking. This patch wa

[PATCH] leds: remove "checkpatch.pl" warnings

2008-02-10 Thread Németh Márton
Break the lines which were more than 80 characters into more lines; replace SPACEs with TABs; correct ident at switch-case; change character encoding from ISO-8859-2 to UTF-8. The order of the functions in led-triggers.c changed in order the similar functions can still be together under titles "Us

Re: [3/6] kgdb: core

2008-02-10 Thread Marcin Slusarz
On Sun, Feb 10, 2008 at 02:19:06PM +0100, Jesper Juhl wrote: > On 10/02/2008, Marcin Slusarz <[EMAIL PROTECTED]> wrote: > > On Sun, Feb 10, 2008 at 08:13:31AM +0100, Ingo Molnar wrote: > ... > > > + > > > + if (CACHE_FLUSH_IS_SAFE) { > > > + if (current->mm && addr <

2.6.24-sha1: RIP [] iov_iter_advance+0x38/0x70

2008-02-10 Thread Alexey Dobriyan
This happened during LTP. FWIW, modprobe/rmmod trivial empty module together with cat /proc/*/wchan and cat /proc/modules were also running. Box is E6400, much debugging is on, config below. [ 4057.31] BUG: unable to handle kernel paging request at 810101dbc008 [ 4057.31] IP: [] iov_

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread Russell King
On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: > It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310 > [SCSI] arm: convert to accessors and !use_sg cleanup > > Thanks for checking. This patch was in scsi-pending tree since forever, And > we were unable > to get a responsive

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread Adrian Bunk
On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: > On Sat, Feb 09 2008 at 2:04 +0200, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following > > compile error: > > > > <-- snip --> > > > > ... > > CC drivers/scsi/arm/

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread Russell King
On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: > On Sat, Feb 09 2008 at 2:04 +0200, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following > > compile error: > > > > <-- snip --> > > > > ... > > CC drivers/scsi/arm/

Re: [4/6] consoles: polling support, kgdboc

2008-02-10 Thread Jan Kiszka
Ingo Molnar wrote: > From: Jan Kiszka <[EMAIL PROTECTED]> > Well, actually not from me but from Jason. I think I just touched it last for the configuration cleanups. However, this fragment is additionally required to avoid crashes when doing runtime reconfigurations. To avoid the ifdef'ery of th

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Niki Denev
On Feb 10, 2008 12:22 PM, Bastian Blank <[EMAIL PROTECTED]> wrote: > On Sun, Feb 10, 2008 at 04:40:53AM -0500, Niki Denev wrote: > > this fixed the problem for me (kernel 2.6.24.1) : > > It appears that the initial patch checked the input to vmsplice_to_user, > > but the exploit used vmsplice_to_pi

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-10 Thread Olof Johansson
On 10/02/2008, Daniel Hazelton <[EMAIL PROTECTED]> wrote: > > Yes, of course, and I'll never argue otherwise. However, what I was saying is > that it is the claim of the FSF that, in no uncertain terms, a C program that > uses the standard C library interface and is linked to glibc instead of, say,

[stable 2.6.24] WARNING: at kernel/time/clockevents.c

2008-02-10 Thread Frans Pop
Kernel: vanilla 2.6.24 x86_64 SMP Environment: Debian unstable Processor: Intel(R) Pentium(R) D CPU 3.20GHz (dual core) I've been running this kernel without problems since its release, but yesterday evening I suddenly got the following error, and this afternoon it was repeated (below). The syst

Re: [3/6] kgdb: core

2008-02-10 Thread Jan Kiszka
Marcin Slusarz wrote: > On Sun, Feb 10, 2008 at 08:13:31AM +0100, Ingo Molnar wrote: >> +} else { >> +while (count-- > 0) { >> +unsigned char ch; >> + >> +if (probe_kernel_address(mem, ch)) { >> +kgdb_may_fault = 0;

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-10 Thread Daniel Hazelton
On Sunday 10 February 2008 06:20:45 Alan Cox wrote: > > Why? Because the pre-processor is what is including any GPL'd code in my > > application and expanding any macros. That is a purely mechanical process > > and > > And its not pirating Windows because Norton Ghost put Microsoft copyright > mate

Re: [0/6] kgdb light

2008-02-10 Thread Jan Kiszka
Sam Ravnborg wrote: > ... > +extern int kgdb_may_fault; > I searched but I could not find any places this > variable were set to anuthing else than 0 neither where it was tested. This is a leftover from the old jmp-on-fault logic that was missed by this tree. I have a patch under test that kills t

Re: [3/6] kgdb: core

2008-02-10 Thread Jesper Juhl
On 10/02/2008, Marcin Slusarz <[EMAIL PROTECTED]> wrote: > On Sun, Feb 10, 2008 at 08:13:31AM +0100, Ingo Molnar wrote: ... > > + > > + if (CACHE_FLUSH_IS_SAFE) { > > + if (current->mm && addr < TASK_SIZE) { > > + flush_cache_range(current

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread Boaz Harrosh
On Sat, Feb 09 2008 at 2:04 +0200, Adrian Bunk <[EMAIL PROTECTED]> wrote: > Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following > compile error: > > <-- snip --> > > ... > CC drivers/scsi/arm/fas216.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Oliver Pinter
thx it fixed for 2.6.22 >>> commit f6e993b835393543bab2d917f9dea75218473edd Author: Oliver Pinter <[EMAIL PROTECTED]> Date: Sun Feb 10 14:03:46 2008 +0100 [PATCH] vm: splice local root exploit fix for 2.6.22.y Based on Bastian Blank's patch Fix for CVE_2008_0009 and CVE_2008-

Re: preempt rcu bug on s390

2008-02-10 Thread Heiko Carstens
> > > > Using CONFIG_PREEMPT_RCU and CONFIG_NO_IDLE_HZ on s390 my system always > > > > gets stuck when running with more than one cpu. > > > > When booting with four cpus I get all four cpus caught withing cpu_idle > > > > and not advancing anymore. However there is the init process which is > > >

[PATCH] leds: add mail LED support for "Clevo D400P"

2008-02-10 Thread Németh Márton
The leds-clevo-mail module also works with model "Clevo D400P", add this model to the white list. Signed-off-by: Márton Németh <[EMAIL PROTECTED]> Cc: Andrey Kamenov <[EMAIL PROTECTED]> --- diff -uprN a/drivers/leds/Kconfig b/drivers/leds/Kconfig --- a/drivers/leds/Kconfig 2008-02-09 08:02:16

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Niki Denev
On Feb 10, 2008 12:47 PM, Bastian Blank <[EMAIL PROTECTED]> wrote: > On Sun, Feb 10, 2008 at 12:39:05PM +, Niki Denev wrote: > > This patch is against 2.6.24.1 which has already the fix to vmsplice_to_user > > With it i can't exploit the hole, and it is returns "invalid address" > > This is the

[patch 1/2] ELF: Use EI_NIDENT instead of numeric value

2008-02-10 Thread gorcunov
Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- elf.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.git/include/linux/elf.h === --- linux-2.6.git.orig/include/linux/elf.h 2008-02-08 19:09:52.0

[patch 2/2] BINFMT: fill_elf_header cleanup - use straigth memset first

2008-02-10 Thread gorcunov
This patch does simplify fill_elf_header function by setting to zero the whole elf header first. So we fillup the fields we really need only. before: textdata bss dec hex filename 11735 80 0 118152e27 fs/binfmt_elf.o after: textdata bss dec

[patch 0/2] ELF cleanup

2008-02-10 Thread gorcunov
These two patches do a simple cleaunp on ELF related code o Use EI_NIDENT instead of numeric value in elf64_hdr structure o Simplify fill_elf_header code by calling memset Please review. Any comments are welcome. -- -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Bastian Blank
On Sun, Feb 10, 2008 at 12:39:05PM +, Niki Denev wrote: > This patch is against 2.6.24.1 which has already the fix to vmsplice_to_user > With it i can't exploit the hole, and it is returns "invalid address" This is the vmsplice_to_pipe path and I have many reports that it is not fixed. Bastia

Re: [3/6] kgdb: core

2008-02-10 Thread Marcin Slusarz
On Sun, Feb 10, 2008 at 08:13:31AM +0100, Ingo Molnar wrote: > + } else { > + while (count-- > 0) { > + unsigned char ch; > + > + if (probe_kernel_address(mem, ch)) { > + kgdb_may_fault = 0; > +

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Niki Denev
On Feb 10, 2008 12:22 PM, Bastian Blank <[EMAIL PROTECTED]> wrote: > On Sun, Feb 10, 2008 at 04:40:53AM -0500, Niki Denev wrote: > > this fixed the problem for me (kernel 2.6.24.1) : > > It appears that the initial patch checked the input to vmsplice_to_user, > > but the exploit used vmsplice_to_pi

Re: [Regression] 2.6.24-git9: RT sched mishandles artswrapper (bisected)

2008-02-10 Thread Rafael J. Wysocki
On Thursday, 7 of February 2008, Ingo Molnar wrote: > > * Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > > http://programming.kicks-ass.net/kernel-patches/sched-rt-group/ > > > > > > on top of sched-devel. > > > > Indeed, with these patches applied the issue is not reproducible any > > mor

Re: [PATCH 2/5] Provide acpi_check_{mem_}region.

2008-02-10 Thread Jean Delvare
Hi Andrew, On Thu, 7 Feb 2008 23:40:02 -0800, Andrew Morton wrote: > On Wed, 24 Oct 2007 16:32:59 +0200 Thomas Renninger <[EMAIL PROTECTED]> wrote: > > > Provide acpi_check_{mem_}region. > > > > Drivers can additionally check against possible ACPI interference by also > > invoking this shortly b

Re: acpi dsts loading and populate_rootfs

2008-02-10 Thread Eric Piel
(adding some CC's) Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 08:12:26AM +0100, Christoph Hellwig wrote: Folks, moving this call around hidden behing in completely unreviewed acpi junk is not acceptable. Either populate_rootfs _is_ safe to be called earlier and then we should do it always

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Bastian Blank
On Sun, Feb 10, 2008 at 04:40:53AM -0500, Niki Denev wrote: > this fixed the problem for me (kernel 2.6.24.1) : > It appears that the initial patch checked the input to vmsplice_to_user, > but the exploit used vmsplice_to_pipe which remained open to the attack. This patch is broken. It opens the o

Re: [10/19] ftrace: add basic support for gcc profiler instrumentation

2008-02-10 Thread Jan Engelhardt
On Feb 10 2008 08:20, Ingo Molnar wrote: >--- linux.orig/Makefile >+++ linux/Makefile >@@ -509,6 +509,9 @@ endif > > include $(srctree)/arch/$(SRCARCH)/Makefile > >+ifdef CONFIG_FTRACE >+KBUILD_CFLAGS += -pg >+endif > ifdef CONFIG_FRAME_POINTER > KBUILD_CFLAGS += -fno-omit-frame-pointer -fno-opt

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Oliver Pinter
hmmm, with 2.6.22.y serie is too affected Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent permitted by applicable law. Last login: Sat Feb 9 15:34:35 2008 [EMAIL PROTECTED]:~$ ./2617_26241_root_exploit --- Linux vmsplice Local Root Exploit By qa

Re: [kvm-devel] KVM: add support for SVM Nested Paging

2008-02-10 Thread Avi Kivity
Joerg Roedel wrote: Hi, here is the improved patchset which adds support for the Nested Paging feature of the AMD Barcelona and Phenom processors to KVM. The patch set was successfully install- and runtime-tested with various guest operating systems (64 bit, 32 bit legacy and 32 bit PAE Linux, W

pata_sil680 regression 2.6.22->2.6.24

2008-02-10 Thread Robert Lowery
Hi Folks, Having recently upgaded my Ubuntu install from Gutsy to Hardy, my 750GB Seagate disk connected via a SiI680 PCI card is no longer detected. I suspect this is caused by the MMIO changes in 2.6.24. Strangely in 2.6.22 the drive appears as sda1, but on 2.6.24 it appears as a non functioni

Re: [PATCH] leds: disable triggers on brightness set

2008-02-10 Thread Németh Márton
Disable any active triggers when the brightness attribute is set to zero. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> Signed-off-by: Márton Németh <[EMAIL PROTECTED]> Cc: Richard Purdie <[EMAIL PROTECTED]> --- diff --git a/Documentation/leds-class.txt b/Documentation/leds-class.

Re: [GIT PULL] LED updates

2008-02-10 Thread Németh Márton
Henrique de Moraes Holschuh wrote: > On Fri, 08 Feb 2008, Németh Márton wrote: >> Richard Purdie wrote: > leds: Add support for hardware accelerated LED flashing This one has a loose end: when you call brightness_set on a led with hardware flash acceleration, you will leave the

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-10 Thread Sven Wegener
On Sat, 9 Feb 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: struct ip_vs_sync_thread_data { - struct completion *startup; + struct completion *startup; /* set to NULL once completed */ This is not needed anmore. kthread_run guarante

Re: [PATCH] make KVM selectable again

2008-02-10 Thread Balbir Singh
On Feb 10, 2008 2:29 AM, Dave Hansen <[EMAIL PROTECTED]> wrote: > Current git for me (b1d0e4f535e10775cffde922208b49629169aeaa) doesn't > let me build KVM. In fact, I don't seem to have *ANY* kvm-related > symbols in my .config at all. > > I've verified that arch/x86/kvm/Kconfig was getting run by

Re: ide/arm/bast-ide.c compile error

2008-02-10 Thread Russell King
FYI, from maintainers: SIMTEC EB2410ITX (BAST) P: Ben Dooks P: Vincent Sanders M: [EMAIL PROTECTED] W: http://www.simtec.co.uk/products/EB2410ITX/ S: Supported On Sat, Feb 09, 2008 at 02:15:15AM +0200, Adrian Bunk wrote: > Commit 9e016a719209d95338e314b46c3012cc7feaaeec c

Re: [git pull] x86 arch updates for v2.6.25

2008-02-10 Thread Jiri Kosina
On Sat, 9 Feb 2008, Amit Shah wrote: > cc503c1b "x86: PIE executable randomization" doesn't boot on my Ubuntu > Feisty Fawn Intel Core2 system. > I get numerous segfaults before getting a (initramfs) busybox shell. A > similar bug was reported much earlier: [ please, when you experience a problem

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-10 Thread Alan Cox
> Why? Because the pre-processor is what is including any GPL'd code in my > application and expanding any macros. That is a purely mechanical process and And its not pirating Windows because Norton Ghost put Microsoft copyright material in your hard disk either - thats a mechanical process too.

Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM

2008-02-10 Thread Olaf Hering
> Currently, make headers_check barfs due to , which > includes, not existing. Rather than add a zillion s, export kvm.h > only if the arch actually supports it. This makes headers_install_all unreliable. linux/kvm.h will not be exported, depending on what system the libc headers will be genera

Re: [PATCH] make KVM selectable again

2008-02-10 Thread Sam Ravnborg
Hi Dave. > > I've verified that arch/x86/kvm/Kconfig was getting run by putting some > comments in it. It seems to me like just putting: > > config HAVE_KVM > bool > > isn't letting anything come into my .config at all. I'm not sure why we > do that, and then have: > >

Re: acer aspire 5720ZG APIC error on CPU0: 40(40) ACPI/USB

2008-02-10 Thread Mr Souissi
acer aspire 5720 ZG APIC error on CPU0: 40(40) ACPI/USB dmesg: Linux version 2.6.24.1-zs-core2 ([EMAIL PROTECTED]) (gcc version 4.2.3 20080114 (prerelease) (Debian 4.2.2-7)) #1 SMP Sat Feb 9 11:12:29 CET 2008 BIOS-provided physical RAM map: BIOS-e820: - 0009fc00 (usable

udf regression: broken directory handling

2008-02-10 Thread Marcin Slusarz
Hi Current mainline has a problem with reading file list. Simple ls prints only 2 out of 8 files on my testing DVD. Reverting your patch "udf: cleanup directory offset handling" (af793295bf9ee92660f5e77d337b0493cea3f9b9) fixes the problem. Marcin -- To unsubscribe from this list: send the line "un

Re: [PATCH] make KVM selectable again

2008-02-10 Thread Sam Ravnborg
On Sat, Feb 09, 2008 at 10:24:01PM +0100, Ingo Molnar wrote: > > * Dave Hansen <[EMAIL PROTECTED]> wrote: > > > config HAVE_SETUP_PER_CPU_AREA > > def_bool X86_64 > > > > -select HAVE_KVM > > +config HAVE_KVM > > + def_bool y > > i think it might be better to just move the select to aft

[ANNOUNCE] GIT 1.5.4.1

2008-02-10 Thread Junio C Hamano
The latest maintenance release GIT 1.5.4.1 is available at the usual places: http://www.kernel.org/pub/software/scm/git/ git-1.5.4.1.tar.{gz,bz2} (tarball) git-htmldocs-1.5.4.1.tar.{gz,bz2} (preformatted docs) git-manpages-1.5.4.1.tar.{gz,bz2}

Re: [0/6] kgdb light

2008-02-10 Thread Sam Ravnborg
Hi Ingo. A few comments based on the git tree pulled as of ~11:00. We have following header files in the core part: linux/kgdb.h asm-generic/kgdb.h I would expect linux/kgdb.h to contain all the common definitions needed by an arch. And asm-generic/kgdb.h to list everything that the arch needs

Re: 2.6.24-git20 -- BUG: sleeping function called from invalid context at include/asm/uaccess_32.h:449

2008-02-10 Thread Stefan Richter
Arjan van de Ven wrote: > On Sat, 9 Feb 2008 16:26:43 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: >> Guys, how often mut it be said? PLEASE always test all code with all >> kernel deubg options enabled. > > maybe we should make a CONFIG_KERNEL_DEVELOPER option that SELECTs the > various opti

Re: [kvm-devel] [PATCH][RFC] SVM: Add Support for Nested Paging in AMD Fam16 CPUs

2008-02-10 Thread Avi Kivity
Joerg Roedel wrote: On Sun, Jan 27, 2008 at 10:57:07AM +0200, Avi Kivity wrote: Very nice patchset; small, simple, and clean. Apart from the comments I already posted, I'd like to avoid the term 'hap': I find it non-descriptive, and it reminds me of another hypervisor. I suggest 'tlp' for t

Re: [PATCH 2.6.24-mm1] Mempolicy: silently restrict nodemask to allowed nodes V3

2008-02-10 Thread Andrew Morton
On Sat, 9 Feb 2008 23:42:21 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Sat, 9 Feb 2008, Greg KH wrote: > > > > Once the patch goes into Linus's tree, feel free to send it to the > > [EMAIL PROTECTED] address so that we can include it in the 2.6.24.x > > tree. > > I've been

Re: [PATCH 6/6] udf: super.c reorganization

2008-02-10 Thread Marcin Slusarz
On Wed, Feb 06, 2008 at 12:09:36PM +0100, Jan Kara wrote: > On Tue 05-02-08 20:34:49, Marcin Slusarz wrote: > > On Tue, Feb 05, 2008 at 05:22:19PM +0100, Jan Kara wrote: > > > Actually, the loop below would be even more readable it you did: > > > > > > if (map->s_partition_num == le16_to_cpu(p

Re: KVM is not seen under X86 config with latest git (32 bit compile)

2008-02-10 Thread Avi Kivity
Balbir Singh wrote: The KVM configuration is no longer visible in the latest git tree. It looks like it is selected by HAVE_SETUP_PER_CPU_AREA. I've moved HAVE_KVM to under CONFIG_X86. Hopefully, this is the right fix. Yes, this was caused by my misunderstanding of the Kconfig language. Ac

Re: [PATCH 5/6] udf: remove unneeded kernel_timestamp type

2008-02-10 Thread Marcin Slusarz
On Tue, Feb 05, 2008 at 05:01:15PM +0100, Jan Kara wrote: > On Sun 03-02-08 19:36:10, [EMAIL PROTECTED] wrote: > > remove now unneeded kernel_timestamp type with conversion functions > OK. Acked-by: Jan Kara <[EMAIL PROTECTED]> updated version which aplies after changes to patch: udf: convert udf

Re: [PATCH 4/6] udf: convert udf_stamp_to_time and udf_time_to_stamp to use timestamps

2008-02-10 Thread Marcin Slusarz
On Wed, Feb 06, 2008 at 12:10:08PM +0100, Jan Kara wrote: > On Tue 05-02-08 20:21:58, Marcin Slusarz wrote: > > On Tue, Feb 05, 2008 at 04:59:56PM +0100, Jan Kara wrote: > > > On Sun 03-02-08 19:36:09, [EMAIL PROTECTED] wrote: > > > > kernel_timestamp type was almost unused - only callers of > > >

[PATCH resend] slab: avoid double initialization & do initialization in 1 place

2008-02-10 Thread Marcin Slusarz
- alloc_slabmgmt: initialize all slab fields in 1 place - slab->nodeid was initialized twice: in alloc_slabmgmt and immediately after it in cache_grow Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Christoph Lameter <[EMAIL PROTECTED]> Reviewed-by: Pekka Enberg <[EMAIL PROTECTED]> --- mm

[PATCH] xfs: convert beX_add to beX_add_cpu (new common API)

2008-02-10 Thread Marcin Slusarz
This patch was in Andrew tree, but it was uncomplete. Here is updated version. --- remove beX_add functions and replace all uses with beX_add_cpu Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> --- fs/xfs/quota/xfs_qm.c |6 ++-- fs/xfs/quota/xfs_trans_dquot.c |6 ++-- fs/xfs/xf

[PATCH resend] ext2/3/4: convert byte order of constant instead of variable

2008-02-10 Thread Marcin Slusarz
convert byte order of constant instead of variable which can be done at compile time (vs run time) ext3/4 bits are #if 0'ed, but someone might copy this code into other places Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> --- fs/ext2/super.c |8 +++- fs/ext3/super.c |2 +- fs/ext4

[PATCH resend] qla3xxx: convert byte order of constant instead of variable

2008-02-10 Thread Marcin Slusarz
convert byte order of constant instead of variable which can be done at compile time (vs run time) Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> --- drivers/net/qla3xxx.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.

pci_proc_init: proc_dir_entry '00' already registered

2008-02-10 Thread Olaf Hering
Current Linus tree gives this new warning during bootup: +proc_dir_entry '00' already registered +Call Trace: +[c0007b0dfba0] [c000e4b0] .show_stack+0x70/0x1bc (unreliable) +[c0007b0dfc50] [c00f2714] .proc_register+0x130/0x210 +[c0007b0dfd00] [c00f299c] .proc_mk

Re: CONFIG_HIGHPTE vs. sub-page page tables.

2008-02-10 Thread Mike Frysinger
On Feb 10, 2008 4:41 AM, Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > On Sun, 2008-02-10 at 04:25 -0500, Mike Frysinger wrote: > > i guess my point was more: the pgtable_t typdef is new therefore it > > must be defined for every architecture. your ability to directly > > cross-compile and/or te

[git pull] hrtimer/ntp bugfixes

2008-02-10 Thread Thomas Gleixner
Linus, please pull hrtimer and ntp bugfixes from: ssh://master.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-hrt.git master Following problems are addressed by these patches: - ntp: fix incorrect drift compensation - hrtimer: fix a stupid restart handling thinko, which keeps a

Re: [12/19] ftrace: function tracer

2008-02-10 Thread Eugene Teo
> From: Steven Rostedt <[EMAIL PROTECTED]> > > This is a simple trace that uses the ftrace infrastructure. It is > designed to be fast and small, and easy to use. It is useful to > record things that happen over a very short period of time, and > not to analyze the system in general. > > Update

Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

2008-02-10 Thread Richard Knutsson
S.Çağlar Onur wrote: Hi; Following patch silents net/bluetooth/hci_sysfs.c: In function `del_conn': net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth value compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: M

Re: [PATCH] unifdef linux/vt.h

2008-02-10 Thread Olaf Hering
On Fri, Feb 08, Andrew Morton wrote: > On Fri, 8 Feb 2008 18:38:10 +0100 > Olaf Hering <[EMAIL PROTECTED]> wrote: > > > On Fri, Jan 25, Olaf Hering wrote: > > > > > remove the newly added __KERNEL__ block from linux/vt.h > > > > Can you pick this up? The patch cant get any better. > > spose so

Re: CONFIG_HIGHPTE vs. sub-page page tables.

2008-02-10 Thread Martin Schwidefsky
On Sun, 2008-02-10 at 04:25 -0500, Mike Frysinger wrote: > i guess my point was more: the pgtable_t typdef is new therefore it > must be defined for every architecture. your ability to directly > cross-compile and/or test a subset is great, but posting a change that > is know for a fact to break a

Re: [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-10 Thread Niki Denev
On Feb 10, 2008 1:38 AM, Niki Denev <[EMAIL PROTECTED]> wrote: > > On Feb 10, 2008 8:32 AM, Willy Tarreau <[EMAIL PROTECTED]> wrote: > > On Sun, Feb 10, 2008 at 08:04:35AM +0200, Niki Denev wrote: > > > Hi, > > > > > > As the subject says the 2.6.24.1 is still vulnerable to the vmsplice > > > local

Re: [3/6] kgdb: core

2008-02-10 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 10:27:28AM +0100, Ingo Molnar wrote: > > The one I noticed quickly is the __ASSEMBLY__ removal from > > asm-x86/kgdb.h. [...] > > people might want to experiment with early debug code as well and > include asm-x86/kgdb.h in assembly files. So i kept that, it's sensible.

Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > tip 2e3ebf25b0bd8646e517806073e1991be1fec8a2. Shortlog, diffstat and > > the full patch can be found below, with all relevant review feedback > > addressed. Builds, boots and works fine on x86. > > here's gdb test-output from this 2e3ebf25b0bd kerne

Re: [3/6] kgdb: core

2008-02-10 Thread Christoph Hellwig
> +#ifdef UART_CAP_UUE > + if (up->capabilities & UART_CAP_UUE) > +#else > + if (up->port.type == PORT_XSCALE) > +#endif This looks very odd. Can anyone explain what's going on here? Especially as UART_CAP_UUE is defined in drivers/serial/8250.h unconditionally. > diff --git a/drivers/se

Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > i dont think so. Which ones do you mean? I just reviewed them and > > they are either already done, or moot (for kgdb complications that i > > objected to and removed from this kgdb-x86 tree). > > The one I noticed quickly is the __ASSEMBLY__

Re: CONFIG_HIGHPTE vs. sub-page page tables.

2008-02-10 Thread Mike Frysinger
On Feb 10, 2008 4:17 AM, Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > On Sat, 2008-02-09 at 12:56 -0500, Mike Frysinger wrote: > > On Feb 9, 2008 5:56 AM, Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > > > On Sat, 2008-02-09 at 11:37 +0100, Ingo Molnar wrote: > > > > i think the worst is over a

Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > Anyway, to resolve this i've turning them into non-docbook, > > descriptive comments. Please submit any docbook patch to > > arch/x86/kernel/kgdb.c to x86.git if you'd like more documentation. > > no ne

Re: [PATCH] [3/5] CPA: Make advised protection check truly advisory

2008-02-10 Thread Andi Kleen
Thomas Gleixner <[EMAIL PROTECTED]> writes: > 2) I care about RO as much as I care about the NX correctness. That's > the same logic and the same problem. If we have overlapping regions, > then we need to split large pages. Otherwise both protections are > useless to a certain degree. That's laud

Re: CONFIG_HIGHPTE vs. sub-page page tables.

2008-02-10 Thread Martin Schwidefsky
On Sat, 2008-02-09 at 12:56 -0500, Mike Frysinger wrote: > On Feb 9, 2008 5:56 AM, Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-09 at 11:37 +0100, Ingo Molnar wrote: > > > i think the worst is over already and i'm reasonably sure that there are > > > no more bugs in it - this _

Re: [git pull] x86 updates

2008-02-10 Thread Thomas Gleixner
On Sun, 10 Feb 2008, Linus Torvalds wrote: > On Sat, 9 Feb 2008, Randy Dunlap wrote: > > So Thomas, don't do this. I don't like it. The same way I didn't like > seeing Ingo trying to mix in a kgdb pull into his x86 pull. Keep these > things separate - git is *really* good at having multiple bran

<    1   2   3   4   >