Re: [3/6] kgdb: core

2008-02-10 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 09:57:35AM +0100, Ingo Molnar wrote: > > It would be nice if you could move the kerneldoc comments to the > > proper place at least. [...] > > i'd agree in general but this is really a special case, please look at > the context. This would duplicate all the kerneldoc head

Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Sun, Feb 10, 2008 at 09:21:32AM +0100, Ingo Molnar wrote: > > > Kerneldoc comments don't belong above the prototype of a function but > > > the function body. > > > > disagree - the best is to have it in both places - and in many > > places w

Re: [PATCH] [1/5] CPA: Split static_protections into required_static_prot and advised_static_prot

2008-02-10 Thread Andi Kleen
On Sat, Feb 09, 2008 at 06:09:23PM +0100, Thomas Gleixner wrote: > On Sat, 9 Feb 2008, Andi Kleen wrote: > > > > Note the behaviour for pageattr and thus DEBUG_RODATA / debugging > > > > sitations where you don't care about your TLB this > > > > does not change, this makes only a difference for the

Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Christoph Hellwig <[EMAIL PROTECTED]> wrote: > [...] And while you're at it please remove all the filenames in the > top-of-file comments, not just in include/asm-generic/kgdb.h. fixed: there was just one such file remaining: include/linux/kgdb.h. > While we're at it is there a good reason

Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-10 Thread Jiri Slaby
On 02/10/2008 04:37 AM, S.Çağlar Onur wrote: Hi; Following patch silents drivers/mtd/ubi/vmt.c: In function `ubi_create_volume': drivers/mtd/ubi/vmt.c:379: warning: statement with no effect compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Ima

Re: [3/6] kgdb: core

2008-02-10 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 09:21:32AM +0100, Ingo Molnar wrote: > > Kerneldoc comments don't belong above the prototype of a function but > > the function body. > > disagree - the best is to have it in both places - and in many places we > do that. Anyway, this is up to maintainer discretion. Huh?

Re: [3/6] kgdb: core

2008-02-10 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 09:02:25AM +0100, Ingo Molnar wrote: > thanks - i found Sam's mail meanwhile and addressed most of the > observations and updated the kgdb.git tree. I'll now check the threads > above whether i missed anything. (feel free to point it out if you > notice anything outright)

Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > It's all in the thread starting with '[PATCH 0/8] kgdb 2.6.25 > > version', msgid > > [EMAIL PROTECTED] or at > > http://lkml.org/lkml/2008/2/9/104 > > thanks - i found Sam's mail meanwhile and addressed most of the > observations and updated the

Re: [git pull] x86 updates

2008-02-10 Thread Linus Torvalds
On Sat, 9 Feb 2008, Randy Dunlap wrote: > On Sun, 10 Feb 2008 00:24:50 +0100 (CET) Thomas Gleixner wrote: > > > Linus, > > > > please pull the pending x86 updates from: > > > > ssh://master.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git > > master > > Hi Thomas, > can we please

Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Sun, Feb 10, 2008 at 08:43:52AM +0100, Ingo Molnar wrote: > > > > * Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > > This still doesn't address a lot of the review comments from Jason's > > > last posting. > > > > sorry, which mails ar

Re: [3/6] kgdb: core

2008-02-10 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > I see that only a very few of my comments posted yesterday got > addressed. On purpose or did you miss them? no, they went into another thread :-) i've now read your mail and addressed the majority of them - see the details below. i've trickled all

<    1   2   3   4