[PATCH] char: fix sparse shadowed variable warnings in cyclades.c

2008-02-22 Thread Harvey Harrison
Nested min() macros. drivers/char/cyclades.c:2750:7: warning: symbol '_x' shadows an earlier one drivers/char/cyclades.c:2750:7: originally declared here drivers/char/cyclades.c:2750:7: warning: symbol '_x' shadows an earlier one drivers/char/cyclades.c:2750:7: originally declared here

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Randy Dunlap
On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote:

Re: 100% C0 with 2.6.25-rc

2008-02-22 Thread Jan Willies
Pallipadi, Venkatesh wrote: -Original Message- From: Jan Willies [mailto:[EMAIL PROTECTED] Sent: Friday, February 22, 2008 9:50 AM To: Pallipadi, Venkatesh Cc: Rafael J. Wysocki; [EMAIL PROTECTED]; Ingo Molnar; LKML; Thomas Gleixner Subject: Re: 100% C0 with 2.6.25-rc Pallipadi,

[PATCH] char: static functions and integer as NULL pointer fixes in epca.c

2008-02-22 Thread Harvey Harrison
drivers/char/epca.c:926:28: warning: Using plain integer as NULL pointer drivers/char/epca.c:1841:2: warning: Using plain integer as NULL pointer Forward declarations were already marked static, mark the definitions too. drivers/char/epca.c:2493:6: warning: symbol 'digi_send_break' was not

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Nish Aravamudan
On 2/22/08, Randy Dunlap [EMAIL PROTECTED] wrote: On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote:

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Sam Ravnborg
Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config symbol to the user

Re: [PATCH 14/16] [ALSA] caiaq - fix section mismatch warning

2008-02-22 Thread Sam Ravnborg
Hi Takashi. On Fri, Feb 22, 2008 at 06:46:47PM +0100, Takashi Iwai wrote: Fix following warning: WARNING: vmlinux.o(.text+0x11ec01a): Section mismatch in reference from the function setup_card() to the function .devinit.text:snd_usb_caiaq_control_init() setup_card() are only used by

[PATCH 1/2] char: hide sparse expensive pointer subtraction warning in specialix.c

2008-02-22 Thread Harvey Harrison
The warnings come from two static inlines so the ugliness in hiding them is well contained. drivers/char/specialix.c:238:19: warning: potentially expensive pointer subtraction drivers/char/specialix.c:245:19: warning: potentially expensive pointer subtraction Signed-off-by: Harvey Harrison

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Randy Dunlap
Sam Ravnborg wrote: Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config

[PATCH 2/2] char: fix possible double-unlock in specialix.c

2008-02-22 Thread Harvey Harrison
Noticed by sparse, trivial to see: drivers/char/specialix.c:2112:3: warning: context imbalance in 'sx_throttle' - unexpected unlock Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- And with the torrent of warnings fixed, here we find a double-unlock. drivers/char/specialix.c |1 - 1

Re: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box

2008-02-22 Thread Yinghai Lu
On Friday 22 February 2008 04:25:18 am Andi Kleen wrote: Yinghai Lu [EMAIL PROTECTED] writes: quad core 8 socket system will have apic id lifting.the apic id range could be [4, 0x23]. or [8, 0x27]. apic_is_clustered_box will think that need to three clusters and that is large than 2.

[PATCH] x86: don't save unreliable stack trace entries

2008-02-22 Thread Vegard Nossum
I find the following patch to make saved stack traces so much easier to decipher. There might be other uses of save_stack_trace() that I am not aware of, though. Also, I suggest changing the underlying struct stack_trace to include the reliable/unreliable information. This, however, requires all

Re: [PATCH] x86: don't save unreliable stack trace entries

2008-02-22 Thread Arjan van de Ven
On Fri, 22 Feb 2008 19:44:05 +0100 Vegard Nossum [EMAIL PROTECTED] wrote: I find the following patch to make saved stack traces so much easier to decipher. There might be other uses of save_stack_trace() that I am not aware of, though. Also, I suggest changing the underlying struct

[PATCH 1/2] char: hide sparse expensive pointer subtraction warning in specialix.c

2008-02-22 Thread Harvey Harrison
The warnings come from two static inlines so the ugliness in hiding them is well contained. drivers/char/specialix.c:238:19: warning: potentially expensive pointer subtraction drivers/char/specialix.c:245:19: warning: potentially expensive pointer subtraction Signed-off-by: Harvey Harrison

Re: Merging of completely unreviewed drivers

2008-02-22 Thread Ingo Molnar
* Linus Torvalds [EMAIL PROTECTED] wrote: I'm personally of the opinion that a lot of checkpatch fixes are anything but. That mainly concerns fixing overlong lines (where the fixed version is usually worse than the original), but it's been true for some other warnings too. that was

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Sam Ravnborg
On Fri, Feb 22, 2008 at 10:29:38AM -0800, Randy Dunlap wrote: Sam Ravnborg wrote: Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to

Re: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box

2008-02-22 Thread Andi Kleen
or move CPUs have X86_FEATURE_CONSTANT_TSC check before apic_clustered check? No that would be not correct on Intel boxes. -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [spi-devel-general] [PATCH] atmel_spi: support zero length transfer

2008-02-22 Thread David Brownell
Quoth Atsushi Nemoto on Fri, 22 Feb 2008: On Fri, 22 Feb 2008 10:30:31 +0100, Marc Pignat [EMAIL PROTECTED] wrote: David, do you think writing 0 bytes is a valid use of this API? Just a zero byte transfer ... no, though it depends what you mean by valid. (I'm not sure I'd expect

Re: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box

2008-02-22 Thread Andi Kleen
so for that box [4, 0x23] still could be apic clustered? there is a hole [0,3].. I meant holes between the CPUs only, not including the IO-APICs. is their box using AMD cpu or not? Intel. AMD boxes don't really need clustered mode because they support bigflat mode. -Andi -- To

Re: 2.6.25-rc2 + smartd = hang

2008-02-22 Thread Anders Eriksson
[EMAIL PROTECTED] said: The sysrq-e output is probably just standard ext3 journalling unrelated to the problem... what does dmesg say? lspci? What's your hardware setup? dmesg ; smartd ; dmesg yields no new entries in dmesg. It seems on disk accesses are dead. it still routes packets

Re: [Xen-devel] [PATCH] let XEN depend on PAE

2008-02-22 Thread Jeremy Fitzhardinge
Arnd Hannemann wrote: This is with 2.6.24.2, but latest-git looks the same: I also tried with 2.6.23 which crashes instantly, without any output of the guest. I'm not too surprised. Non-PAE Xen is a bit of a rarity, and it only gets tested rarely. Chris Wright did spend some time on it

Re: [spi-devel-general] [PATCH] atmel_spi: support zero length transfer

2008-02-22 Thread David Brownell
David, do you think writing 0 bytes is a valid use of this API? Just a zero byte transfer ... no, though it depends what you mean by valid. (I'm not sure I'd expect all controller drivers to reject such requests.) That has no effect on bits-on-the-wire, and would make trouble for

Re: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box

2008-02-22 Thread Yinghai Lu
On Friday 22 February 2008 11:02:30 am Yinghai Lu wrote: On Friday 22 February 2008 04:25:18 am Andi Kleen wrote: Yinghai Lu [EMAIL PROTECTED] writes: quad core 8 socket system will have apic id lifting.the apic id range could be [4, 0x23]. or [8, 0x27]. apic_is_clustered_box will

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread John W. Linville
On Fri, Feb 22, 2008 at 04:17:17PM +0100, Peter Zijlstra wrote: Even with e-mail, I can easily show over 200 characters wide with a large font (say 11pt) but find it harder to read emails that don't nicely wrap at 78. So much so that I often find myself not reading the mail, or restyling it

Re: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box

2008-02-22 Thread Yinghai Lu
On Fri, Feb 22, 2008 at 11:00 AM, Andi Kleen [EMAIL PROTECTED] wrote: so for that box [4, 0x23] still could be apic clustered? there is a hole [0,3].. I meant holes between the CPUs only, not including the IO-APICs. is their box using AMD cpu or not? Intel. AMD boxes don't really

Re: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box

2008-02-22 Thread Andi Kleen
Yinghai Lu wrote: On Fri, Feb 22, 2008 at 11:00 AM, Andi Kleen [EMAIL PROTECTED] wrote: so for that box [4, 0x23] still could be apic clustered? there is a hole [0,3].. I meant holes between the CPUs only, not including the IO-APICs. is their box using AMD cpu or not? Intel. AMD

Re: [spi-devel-general] [PATCH] atmel_spi: support zero length transfer

2008-02-22 Thread David Brownell
If the driver could not handle zero length transfer, then the driver should reject it (just like unsupported transfer mode). Then the behavior will be 'assert chip select and wait some time' or 'rejected by the driver'. This would be OK. It would not be hard to fix pxa2xx_spi, for

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-22 Thread Jeremy Fitzhardinge
Linus Torvalds wrote: This isn't a problem with things like Signed-off-by: etc tags, because they have no automated meaning and don't really change the commit itself, but the From:/Date:/Subject: markers at the head of the message really do have real meaning, and get removed from the commit

Re: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box

2008-02-22 Thread Yinghai Lu
On Fri, Feb 22, 2008 at 11:07 AM, Andi Kleen [EMAIL PROTECTED] wrote: Yinghai Lu wrote: On Fri, Feb 22, 2008 at 11:00 AM, Andi Kleen [EMAIL PROTECTED] wrote: so for that box [4, 0x23] still could be apic clustered? there is a hole [0,3].. I meant holes between the CPUs only, not

Re: [PATCH [RT] 08/14] add a loop counter based timeout mechanism

2008-02-22 Thread Paul E. McKenney
On Thu, Feb 21, 2008 at 05:41:09PM +0100, Andi Kleen wrote: +config RTLOCK_DELAY + int Default delay (in loops) for adaptive rtlocks + range 0 10 + depends on ADAPTIVE_RTLOCK I must say I'm not a big fan of putting such subtle configurable numbers into Kconfig.

Re: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box

2008-02-22 Thread Andi Kleen
Yinghai Lu wrote: On Fri, Feb 22, 2008 at 11:07 AM, Andi Kleen [EMAIL PROTECTED] wrote: Yinghai Lu wrote: On Fri, Feb 22, 2008 at 11:00 AM, Andi Kleen [EMAIL PROTECTED] wrote: so for that box [4, 0x23] still could be apic clustered? there is a hole [0,3].. I meant holes between

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Bart Van Assche
On Fri, Feb 22, 2008 at 7:54 PM, Ingo Molnar [EMAIL PROTECTED] wrote: If a patch or if a file has a clean _style_, bugs and deeper structural problems often stand out like a sore thumb. But if the code is peppered with random style noise, it's a lot harder (for me at least) to

Re: [Rt2400-devel] 2.6.25-rc2 regression in rt61pci wireless driver

2008-02-22 Thread Ivo van Doorn
On Friday 22 February 2008, Chris Clayton wrote: On Thursday 21 February 2008, Chris Vine wrote: On Thu, 2008-02-21 at 23:04 +, Chris Clayton wrote: On Thursday 21 February 2008, Ivo van Doorn wrote: On Thursday 21 February 2008, Chris Vine wrote: [snip] This probably explains

Re: [PATCH 1/2] char: hide sparse expensive pointer subtraction warning in specialix.c

2008-02-22 Thread Joe Perches
On Fri, 2008-02-22 at 10:34 -0800, Harvey Harrison wrote: Andrew, take it or leave it, I just did this to make it easier to look at the other sparse issuesbut without this sparse produces 100 of these warnings for this file. drivers/char/specialix.c |6 +++--- 1 files changed,

Re: [PATCH [RT] 08/14] add a loop counter based timeout mechanism

2008-02-22 Thread Bill Huey (hui)
On Fri, Feb 22, 2008 at 11:08 AM, Paul E. McKenney [EMAIL PROTECTED] wrote: One approach would be to set the RTLOCK_DELAY parameter to something like -1 for default, and to set it to the number of cycles required for about 10 cache misses at boot time. This would automatically scale with

Re: Merging of completely unreviewed drivers

2008-02-22 Thread Jeff Garzik
Ingo Molnar wrote: 2) you might know that Deja-Vu moment when you look at a new patch that has been submitted to lkml and you have a strange, weird feeling that there's something wrong about the patch. It's totally subconscious, and you take a closer look and a few seconds

Re: Merging of completely unreviewed drivers

2008-02-22 Thread Pavel Machek
On Thu 2008-02-21 14:08:55, Arjan van de Ven wrote: On Thu, 21 Feb 2008 23:01:24 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: [ Linus Added to the To: since I want to hear his opinion on this issue. ] On Thu, Feb 21, 2008 at 12:28:55PM -0800, Roland Dreier wrote: This driver should

Re: Merging of completely unreviewed drivers

2008-02-22 Thread Pavel Machek
On Fri 2008-02-22 01:05:26, Krzysztof Halasa wrote: Jeff Garzik [EMAIL PROTECTED] writes: If a driver is full of lines of length 80, that's a problem. I'm not sure. We all have more than 80-chars wide displays for years, don't we? The No. Zaurus is one example, second is small screen

Re: [PATCH [RT] 08/14] add a loop counter based timeout mechanism

2008-02-22 Thread Bill Huey (hui)
On Fri, Feb 22, 2008 at 11:19 AM, Bill Huey (hui) [EMAIL PROTECTED] wrote: Yeah, I'm not very keen on having a constant there without some contention instrumentation to see how long the spins are. It would be better to just let it run until either task-on_cpu is off or checking if the

Re: [PATCH [RT] 11/14] optimize the !printk fastpath through the lock acquisition

2008-02-22 Thread Pavel Machek
Hi! Decorate the printk path with an unlikely() Signed-off-by: Gregory Haskins [EMAIL PROTECTED] --- kernel/rtmutex.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/rtmutex.c b/kernel/rtmutex.c index 122f143..ebdaa17 100644 ---

Re: [PATCH [RT] 07/14] adaptive real-time lock support

2008-02-22 Thread Pavel Machek
Hi! @@ -192,6 +192,26 @@ config RCU_TRACE Say Y/M here if you want to enable RCU tracing in-kernel/module. Say N if you are unsure. +config ADAPTIVE_RTLOCK +bool Adaptive real-time locks + default y tabs vs. spaces. + If unsure, say Y Missing dot?

Re: [PATCH 2/2] char: fix possible double-unlock in esp.c

2008-02-22 Thread Jiri Slaby
On 02/22/2008 06:34 PM, Harvey Harrison wrote: Hitting either of the break statements in the while loop would cause a double-unlock of info-lock. Add an out label and goto instead of break to skip the unlock in those cases. Noticed by sparse: drivers/char/esp.c:2042:2: warning: context

Re: [PATCH [RT] 02/14] spinlock: make preemptible-waiter feature a specific config option

2008-02-22 Thread Pavel Machek
Hi! We introduce a configuration variable for the feature to make it easier for various architectures and/or configs to enable or disable it based on their requirements. Signed-off-by: Gregory Haskins [EMAIL PROTECTED] --- kernel/Kconfig.preempt |9 + kernel/spinlock.c

Re: 2.6.25-rc1 xen pvops regression

2008-02-22 Thread Pavel Machek
On Fri 2008-02-22 11:15:59, Andi Kleen wrote: Alan Cox wrote: Actually I switched 64bit over to trust e820 completely and not reserve 640k-1MB explicitly some time ago and AFAIK there hasn't been any reports that it causes problems. So presumably trusting e802 is ok on modern systems

[PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Randy Dunlap
Let's see what the ACPI people think about this change. Thanks, Sam. --- From: Randy Dunlap [EMAIL PROTECTED] Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived value, based on the value of ACPI_CUSTOM_DSDT_FILE (string). Only the latter is presented to the user as a config option.

Re: [spi-devel-general] [PATCH] atmel_spi: support zero length transfer

2008-02-22 Thread Ned Forrester
David Brownell wrote: However, if the transfer is by DMA, note that the PXA255 and PXA270 Developer's Manuals have the following language regarding DMA lengths: LEN = 0 means zero bytes for descriptor-fetch transactions. LEN = 0 is an invalid setting for no-descriptor-fetch

Re: [Xen-devel] [PATCH] let XEN depend on PAE

2008-02-22 Thread Arnd Hannemann
Jeremy Fitzhardinge wrote: Arnd Hannemann wrote: This is with 2.6.24.2, but latest-git looks the same: I also tried with 2.6.23 which crashes instantly, without any output of the guest. I'm not too surprised. Non-PAE Xen is a bit of a rarity, and it only gets tested rarely. Chris

Re: Merging of completely unreviewed drivers

2008-02-22 Thread Greg KH
On Fri, Feb 22, 2008 at 02:20:12PM -0500, Jeff Garzik wrote: Ingo Molnar wrote: 2) you might know that Deja-Vu moment when you look at a new patch that has been submitted to lkml and you have a strange, weird feeling that there's something wrong about the patch. It's totally

[PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Sam Ravnborg
hpt366: fix section mismatch warnings Fix following warnings: WARNING: o-sparc64/vmlinux.o(.data+0x195a38): Section mismatch in reference from the variable hpt37x_info.0 to the variable .devinit.data:hpt370 WARNING: o-sparc64/vmlinux.o(.data+0x195a40): Section mismatch in reference from the

Re: 2.6.25-rc2 regression in rt61pci wireless driver

2008-02-22 Thread Ivo van Doorn
On Friday 22 February 2008, Chris Clayton wrote: Hi Ivo, On 18/02/2008, Ivo van Doorn [EMAIL PROTECTED] wrote: Hi, [...] Above traces should be enough, but to determine where rt2x00 broke down approximatly I need to have a few test result on specific moments. Could you test

[2.6 patch] make watchdog/hpwdt.c:asminline_call() static

2008-02-22 Thread Adrian Bunk
This patch makes the needlessly global asminline_call() static and removes the not required asmlinkage. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/watchdog/hpwdt.c |8 1 file changed, 4 insertions(+), 4 deletions(-) 83ff67cb18105141ba2f4a9eeb5e63d5ff0818ee diff

[2.6 patch] make smackfs.c:smk_unlbl_ambient() static

2008-02-22 Thread Adrian Bunk
This patch makes the needlessly global smk_unlbl_ambient() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 60c7072cb922cdecdb8a4f08e5710c014e0e8a8c diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 358c92c..7c6e671 100644 --- a/security/smack/smackfs.c +++

[2.6 patch] proper __do_softirq() prototype

2008-02-22 Thread Adrian Bunk
This patch adds a proper prototype for __do_softirq() in include/linux/interrupt.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- arch/s390/kernel/irq.c|2 -- arch/sh/kernel/irq.c |2 -- arch/x86/kernel/irq_32.c |2 -- include/asm-powerpc/irq.h |2 --

[2.6 patch] proper spawn_ksoftirqd() prototype

2008-02-22 Thread Adrian Bunk
This patch adds a proper prototype for spawn_ksoftirqd() in include/linux/interrupt.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- include/linux/interrupt.h |1 + init/main.c |2 -- 2 files changed, 1 insertion(+), 2 deletions(-)

[2.6 patch] proper pid{hash,map}_init() prototypes

2008-02-22 Thread Adrian Bunk
This patch adds proper prototypes for pid{hash,map}_init() in include/linux/pid_namespace.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- include/linux/pid_namespace.h |3 +++ init/main.c |2 -- 2 files changed, 3 insertions(+), 2 deletions(-)

[2.6 patch] kernel/ns_cgroup.c should #include linux/nsproxy.h

2008-02-22 Thread Adrian Bunk
Every file should include the headers containing the externs its global functions (in this case for ns_cgroup_clone()). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c index aead4d6..659f321 100644

[2.6 patch] make xen-blkfront.c:blkif_getgeo() static

2008-02-22 Thread Adrian Bunk
This patch makes the needlessly global blkif_getgeo() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 6f34bfdbb8c24e06d982ccaccd24c25dba5b1956 diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 9c6f3f9..ae7ee16 100644 --- a/drivers/block/xen-blkfront.c +++

[2.6 patch] x86: don't make swapper_pg_pmd global

2008-02-22 Thread Adrian Bunk
There doesn't seem to be any reason for swapper_pg_pmd being global. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- f07e9bb8705fc9b1b1d7d00883764f993cb09a4b diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S index 25eb985..fd8ca53 100644 --- a/arch/x86/kernel/head_32.S +++

[2.6 patch] usb/serial/io_ti.c: remove unneeded NULL check

2008-02-22 Thread Adrian Bunk
On Fri, Feb 22, 2008 at 10:10:16AM +, Alan Cox wrote: Either the test of port-tty here is unneeded: if (port-tty) port-tty-low_latency = low_latency; ...or the lack of test of port-tty here is a mistake: edge_set_termios (port, port-tty-termios);

[2.6 patch] pci/pcie/aer/aerdrv_acpi.c: remove unneeded NULL check

2008-02-22 Thread Adrian Bunk
On Wed, Feb 20, 2008 at 08:09:35AM -0800, Greg KH wrote: On Wed, Feb 20, 2008 at 09:56:28AM +0200, Adrian Bunk wrote: On Tue, Feb 19, 2008 at 09:47:58PM -0800, Greg KH wrote: On Tue, Feb 19, 2008 at 09:29:02PM +0200, Adrian Bunk wrote: The Coverity checker spotted the following

[2.6 patch] make struct mempolicy.c:default_policy static

2008-02-22 Thread Adrian Bunk
This patc makes the needlessly global struct default_policy static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 4a69fc08292ebe8b7d202436a71926950a980c21 diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h index 59c4865..fd20b03 100644 --- a/include/linux/mempolicy.h +++

[2.6 patch] mm/slub.c: remove unneeded NULL check

2008-02-22 Thread Adrian Bunk
On Wed, Feb 20, 2008 at 03:52:44PM +0200, Pekka Enberg wrote: Hi Adrian, On 2/20/2008, Adrian Bunk [EMAIL PROTECTED] wrote: The Coverity checker spotted the following inconsequent NULL checking introduced by commit 8ff12cfc009a2a38d87fa7058226fe197bb2696f: -- snip -- ...

[2.6 patch] mm/migrate.c should #include linux/syscalls.h

2008-02-22 Thread Adrian Bunk
Every file should include the headers containing the externs for its global functions (in this case for sys_move_pages()). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 5624ee2189a0b767e8e474cdd53d8a536dd8f262 diff --git a/mm/migrate.c b/mm/migrate.c index a73504f..36e1820 100644 ---

Re: [GIT PATCH] driver core fixes against 2.6.25-rc2 git

2008-02-22 Thread Greg KH
On Fri, Feb 22, 2008 at 08:56:25AM +0100, Sam Ravnborg wrote: Hi Greg. On Thu, Feb 21, 2008 at 03:46:49PM -0800, Greg KH wrote: Here are a few driver core fixes against your current git tree that fix some more problems that have cropped up: - shutdown problem due to logic problem

Re: [2.6 patch] make smackfs.c:smk_unlbl_ambient() static

2008-02-22 Thread Paul Moore
On Friday 22 February 2008 2:58:07 pm Adrian Bunk wrote: This patch makes the needlessly global smk_unlbl_ambient() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Fine with me. Acked-by: Paul Moore [EMAIL PROTECTED] --- 60c7072cb922cdecdb8a4f08e5710c014e0e8a8c diff --git

Re: [PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Sergei Shtylyov
Sam Ravnborg wrote: hpt366: fix section mismatch warnings Fix following warnings: WARNING: o-sparc64/vmlinux.o(.data+0x195a38): Section mismatch in reference from the variable hpt37x_info.0 to the variable .devinit.data:hpt370 WARNING: o-sparc64/vmlinux.o(.data+0x195a40): Section mismatch

Re: [PATCH [RT] 08/14] add a loop counter based timeout mechanism

2008-02-22 Thread Sven-Thorsten Dietrich
On Fri, 2008-02-22 at 11:43 -0800, Paul E. McKenney wrote: On Fri, Feb 22, 2008 at 11:21:14AM -0800, Bill Huey (hui) wrote: On Fri, Feb 22, 2008 at 11:19 AM, Bill Huey (hui) [EMAIL PROTECTED] wrote: Yeah, I'm not very keen on having a constant there without some contention

Re: [spi-devel-general] [PATCH] atmel_spi: support zero length transfer

2008-02-22 Thread Ned Forrester
David Brownell wrote: This would be OK. It would not be hard to fix pxa2xx_spi, for example, to reject zero-length transfers in DMA mode, as long as it is acceptable to reject the message in mid-message. Such illegal message rejection is best done early; fail-fast. Mid-message rejection

Re: [stable] [2.6.22.y] {13/14} - NFSv2/v3: Fix a memory leak when using -onolock - on top of 2.6.22.17

2008-02-22 Thread Oliver Pinter
On 2/22/08, Greg KH [EMAIL PROTECTED] wrote: On Thu, Feb 07, 2008 at 09:03:52PM +0100, Oliver Pinter wrote: aka: nfs-unmount-leak.patch From: Trond Myklebust [EMAIL PROTECTED] Date: Tue Dec 11 11:05:19 2007 -0500 Subject: NFSv2/v3: Fix a memory leak when using -onolock Patch-mainline:

Re: [UPDATED v2][PATCH 0/6] regulator: voltage and current regulator framework

2008-02-22 Thread David Brownell
For those PMIC that covers additional features, like - usb vbus detection (or pull-up/pull-down) - audio codec - touch screen - battery monitor/ fuel gauge - battery charger - possible many others Certainly many others ... like MMC transceivers, high speed USB

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Alexey Zaytsev
On Fri, Feb 22, 2008 at 11:12 PM, Michael Buesch [EMAIL PROTECTED] wrote: On Friday 22 February 2008 21:06:00 Alexey Zaytsev wrote: It is not my problem, if you refuse to use b43. You also still refuse to tell me details about your card and _what_ does not work. I do own lots of

Re: [PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Sam Ravnborg
@@ -1570,11 +1570,13 @@ static int __devinit hpt366_init_one(struct pci_dev *dev, const struct pci_devic if (rev 3) info = hpt36x; else { - static const struct hpt_info *hpt37x_info[] = - {

Re: BUG?: Cannot map mmconfig aperture

2008-02-22 Thread Diego Calleja
El Thu, 21 Feb 2008 21:26:56 +0100 (CET), Thomas Gleixner [EMAIL PROTECTED] escribió: Thanks. Nothing new there. Can you please apply the patch below and provide the output of the ioremap code ? [0.155485] ACPI: bus type pci registered [0.155581] PCI: Found Intel Corporation

xtansa common_defconfig compile error

2008-02-22 Thread Adrian Bunk
Trying to compile common_defconfig fails with the following error: -- snip -- ... CC init/main.o In file included from include2/asm/hardirq.h:15, from /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/hardirq.h:7, from

[PATCH] qd65xx: remove commented out code

2008-02-22 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/qd65xx.c | 37 - 1 file changed, 37 deletions(-) Index: b/drivers/ide/legacy/qd65xx.c === ---

[PATCH 21/21] Char: moxa, add firmware loading fix

2008-02-22 Thread Jiri Slaby
Be more verbose on fw load fail as noted by Oyvind. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Cc: Oyvind Aabling [EMAIL PROTECTED] --- drivers/char/moxa.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/char/moxa.c b/drivers/char/moxa.c index

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Alexey Zaytsev
[replying from my non-work account] On Fri, Feb 22, 2008 at 8:48 PM, Michael Buesch [EMAIL PROTECTED] wrote: On Friday 22 February 2008 19:10:39 Alexey Zaytsev wrote: Sorry, I don't get it. You are going to remove the (somehow) working driver, while there are known problems with the new

Re: [2.6 patch] make xen-blkfront.c:blkif_getgeo() static

2008-02-22 Thread Ian Campbell
On Fri, 2008-02-22 at 21:58 +0200, Adrian Bunk wrote: This patch makes the needlessly global blkif_getgeo() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: Ian Campbell [EMAIL PROTECTED] --- 6f34bfdbb8c24e06d982ccaccd24c25dba5b1956 diff --git

Re: [PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Bartlomiej Zolnierkiewicz
On Friday 22 February 2008, Sergei Shtylyov wrote: Sam Ravnborg wrote: hpt366: fix section mismatch warnings Fix following warnings: WARNING: o-sparc64/vmlinux.o(.data+0x195a38): Section mismatch in reference from the variable hpt37x_info.0 to the variable .devinit.data:hpt370

Re: [stable] [2.6.22.y] {13/14} - NFSv2/v3: Fix a memory leak when using -onolock - on top of 2.6.22.17

2008-02-22 Thread Greg KH
On Thu, Feb 07, 2008 at 09:03:52PM +0100, Oliver Pinter wrote: aka: nfs-unmount-leak.patch From: Trond Myklebust [EMAIL PROTECTED] Date: Tue Dec 11 11:05:19 2007 -0500 Subject: NFSv2/v3: Fix a memory leak when using -onolock Patch-mainline: 2.6.24 References: 336253 mainline:

Re: [PATCH [RT] 08/14] add a loop counter based timeout mechanism

2008-02-22 Thread Peter W. Morreale
On Fri, 2008-02-22 at 11:55 -0800, Sven-Thorsten Dietrich wrote: In high-contention, short-hold time situations, it may even make sense to have multiple CPUs with multiple waiters spinning, depending on hold-time vs. time to put a waiter to sleep and wake them up. The wake-up side could

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Michael Buesch
On Friday 22 February 2008 21:06:00 Alexey Zaytsev wrote: It is not my problem, if you refuse to use b43. You also still refuse to tell me details about your card and _what_ does not work. I do own lots of different card and they all work fine with b43. There's one exception, the 4311

Re: [GIT PATCH] driver core fixes against 2.6.25-rc2 git

2008-02-22 Thread Sam Ravnborg
On Fri, Feb 22, 2008 at 11:56:52AM -0800, Greg KH wrote: On Fri, Feb 22, 2008 at 08:56:25AM +0100, Sam Ravnborg wrote: Hi Greg. On Thu, Feb 21, 2008 at 03:46:49PM -0800, Greg KH wrote: Here are a few driver core fixes against your current git tree that fix some more problems that

Re: [Rt2400-devel] 2.6.25-rc2 regression in rt61pci wireless driver

2008-02-22 Thread Chris Vine
On Fri, 2008-02-22 at 07:39 +, Chris Clayton wrote: On Thursday 21 February 2008, Chris Vine wrote: [snip] Does the same happen with 2.0.14 under kernel 2.6.24? Unfortunately, a 2.6.24.2 tree with the drivers/net/wireless/rt2x00 directory replaced with that from 2.6.25-rc2-git4

Re: [PATCH [RT] 08/14] add a loop counter based timeout mechanism

2008-02-22 Thread Paul E. McKenney
On Fri, Feb 22, 2008 at 11:55:45AM -0800, Sven-Thorsten Dietrich wrote: On Fri, 2008-02-22 at 11:43 -0800, Paul E. McKenney wrote: On Fri, Feb 22, 2008 at 11:21:14AM -0800, Bill Huey (hui) wrote: On Fri, Feb 22, 2008 at 11:19 AM, Bill Huey (hui) [EMAIL PROTECTED] wrote: Yeah, I'm

ata_ram driver

2008-02-22 Thread Matthew Wilcox
I've ported the scsi_ram driver [1] to libata. It could use a lot more work -- there's a lot of stuff in the identify page that I haven't filled in, and there's a lot of commands it doesn't even try to execute. For example, when you unload the driver, you get the mildly disturbing messages: sd

Ocfs2 patches for linux-next

2008-02-22 Thread Mark Fasheh
Hi Stephen, Here's another git tree to add to linux-next. Ocfs2 cluster file system: git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git linux-next Thanks, --Mark -- Mark Fasheh Principal Software Developer, Oracle [EMAIL PROTECTED] -- To unsubscribe from this list: send

Re: [2.6 patch] mm/slub.c: remove unneeded NULL check

2008-02-22 Thread Pekka Enberg
Adrian Bunk wrote: There's no reason for checking c-freelist for being NULL here (and we'd anyway Oops below if it was). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- dae2a3c60f258f3ad2522b85d79b735a89d702f0 diff --git a/mm/slub.c b/mm/slub.c index 74c65af..072e0a6 100644 --- a/mm/slub.c

Re: [PATCH [RT] 08/14] add a loop counter based timeout mechanism

2008-02-22 Thread Peter W. Morreale
On Fri, 2008-02-22 at 11:43 -0800, Paul E. McKenney wrote: The fixed-time spins are very useful in cases where the critical section is almost always very short but can sometimes be very long. In such cases, you would want to spin until either ownership changes or it is apparent that the

Re: [2.6 patch] usb/serial/io_ti.c: remove unneeded NULL check

2008-02-22 Thread Alan Cox
Already patched in my tree -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 20/21] Char: moxa, update credits

2008-02-22 Thread Jiri Slaby
- update version - update maintainers - copyright the stuff Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- MAINTAINERS |2 +- drivers/char/moxa.c |5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5dd270f..4aec40b 100644 ---

Re: [PATCH sched-devel 0/7] CPU isolation extensions

2008-02-22 Thread Max Krasnyanskiy
Dmitry Adamushko wrote: Hi Max, [ ... ] Last patch to the stop machine is potentially unsafe and is marked as experimental. Unfortunately it's currently the only option that allows dynamic module insertion/removal for above scenarios. I'm puzzled by the following part (can be a

[PATCH sched-devel 2/7] cpuisol: Do not route IRQs to the CPUs isolated at boot

2008-02-22 Thread Max Krasnyansky
Most people would expect isolated CPUs to not get any IRQs by default. This happens naturally if a CPU is brought off-line, marked isolated and then brought back online. There was some confusion about this patch originaly. So I wanted to clarify that it does not completely disable IRQ handling on

[PATCH sched-devel 4/7] cpuisol: Move on-stack array used for boot cmd parsing into __initdata

2008-02-22 Thread Max Krasnyansky
Suggested by Andrew Morton: isolated_cpu_setup() has an on-stack array of NR_CPUS integers. This will consume 4k of stack on ia64 (at least). We'll just squeak through for a ittle while, but this needs to be fixed. Just move it into __initdata. Signed-off-by: Max Krasnyansky [EMAIL

[PATCH sched-devel 3/7] cpuisol: Do not schedule workqueues on the isolated CPUs

2008-02-22 Thread Max Krasnyansky
This patch is addressing the use case when a high priority realtime (FIFO, RR) user-space thread is using 100% CPU for extended periods of time. In which case kernel workqueue threads do not get a chance to run and entire machine essentially hangs because other CPUs are waiting for scheduled

[PATCH sched-devel 7/7] cpuisol: Do not halt isolated CPUs with Stop Machine

2008-02-22 Thread Max Krasnyansky
This patch makes stop machine ignore isolated CPUs (if the config option is enabled). It addresses exact same usecase explained in the previous workqueue isolation patch. Where a user-space RT thread can prevent stop machine threads from running, which causes the entire system to hang. Stop

[PATCH sched-devel 6/7] cpuisol: Minor updates to the Kconfig options

2008-02-22 Thread Max Krasnyansky
Fixed a couple of typos, long lines and referred to the documentation file. Signed-off-by: Max Krasnyansky [EMAIL PROTECTED] --- kernel/Kconfig.cpuisol | 31 +-- 1 files changed, 17 insertions(+), 14 deletions(-) diff --git a/kernel/Kconfig.cpuisol

[PATCH sched-devel 5/7] cpuisol: Documentation updates

2008-02-22 Thread Max Krasnyansky
Documented sysfs interface as suggested by Andrew Morton. Added general documentation that describes how to configure and use CPU isolation features. Signed-off-by: Max Krasnyansky [EMAIL PROTECTED] --- Documentation/ABI/testing/sysfs-devices-system-cpu | 41 +++

[PATCH sched-devel 1/7] cpuisol: Make cpu isolation configrable and export isolated map

2008-02-22 Thread Max Krasnyansky
This simple patch introduces new config option for CPU isolation. The reason I created the separate Kconfig file here is because more options will be added by the following patches. The patch also exports cpu_isolated_map, provides cpu_isolated() accessor macro and provides access to the

[PATCH] ide: remove stale comments from ide-dma.c

2008-02-22 Thread Bartlomiej Zolnierkiewicz
- ide-dma.c is not a separate module - ide-dma.c is not PCI specific anymore - DMA is enabled by default nowadays - link for Intel Zappa BIOS is dead etc. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c | 48

<    4   5   6   7   8   9   10   11   12   >