Hi Rui,
On Thu, 09 Aug 2012 14:45:46 +0800 Zhang Rui wrote:
>
> On 二, 2012-08-07 at 10:53 +0800, Zhang Rui wrote:
> > Hi, all,
> >
> > I just created a git tree for catching all thermal changes.
> > http://git.kernel.org/?p=linux/kernel/git/rzhang/linux.git;a=summary
> > and I also created the
Change log V2:
- Removed unnecessary tpm_bios_log_setup and tpm_bios_log_teardown
functions in tpm_eventlog.h (patch 3/3).
- Added more descriptions on vTPM (patch 1/3).
These patches add support for IBM vTPM for PPC64. This new device driver
works on firmware that supports vTPM (firmware
This converts the Nomadik to using pin control using the
driver for the STN8815 ASIC.
Signed-off-by: Linus Walleij
---
arch/arm/Kconfig | 1 +
arch/arm/mach-nomadik/board-nhk8815.c | 36 +++
arch/arm/mach-nomadik/cpu-8815.c | 13
This adds support for the STN8815 ASIC for the Nomadik pin
controller.
Signed-off-by: Linus Walleij
---
drivers/pinctrl/Kconfig | 4 +
drivers/pinctrl/Makefile | 1 +
drivers/pinctrl/pinctrl-nomadik-stn8815.c | 357 ++
On 08/09/2012 02:46 PM, Mel Gorman wrote:
On Thu, Aug 09, 2012 at 12:16:35PM -0600, Jim Schutt wrote:
On 08/09/2012 07:49 AM, Mel Gorman wrote:
Changelog since V2
o Capture !MIGRATE_MOVABLE pages where possible
o Document the treatment of MIGRATE_MOVABLE pages while capturing
o Expand
Hi Andi,
On Wed, 2012-08-08 at 15:17 -0700, Andi Kleen wrote:
> From: Andi Kleen
>
> According to the Intel PCI experts it's not safe to check any
> other field than vendor ID for 0x when doing PCI scans
> to see if the device exists.
>
> Several of the early PCI scans violated this. I
migrate_tasks() uses _pick_next_task_rt() to get tasks from the
real-time runqueues to be migrated. When rt_rq is throttled
_pick_next_task_rt() won't return anything, in which case
migrate_tasks() can't move all threads over and gets stuck in an
infinite loop.
Instead unthrottle rt runqueues
On 8/9/2012 3:05 PM, Eric Dumazet wrote:
> On Thu, 2012-08-09 at 14:53 -0700, Casey Schaufler wrote:
>> On 8/9/2012 2:29 PM, Eric Dumazet wrote:
>>> smack_sk_alloc_security() uses smk_of_current() : What can be the
>>> meaning of smk_of_current() in the context of 'kernel' sockets...
>> Yes, and
kallsyms__parse() takes a callback that is called on every discovered
symbol. As /proc/kallsyms does not supply symbol sizes, the callback was
simply called with end=start, faking the symbol size to 1.
All of the callbacks (there are 2) used in calls to kallsyms__parse()
are _only_ used as
On Thu, 2012-08-09 at 16:50 -0400, Mathieu Desnoyers wrote:
> I guess the very first thing to do would be to benchmark this patch
> thoroughly to see if it brings significant performance improvements to
> the "tracing built-in, not enabled" case. If it does bring a significant
> improvement, then
Previously dso__synthesize_plt_symbols() was reopening the elf file to
obtain dynsyms from it. Rather than reopen the file, use the already
opened reference within the symsrc to access it.
Setup for the later patch
"perf symbol: use both runtime and debug images"
Signed-off-by: Cody P Schafer
In certain cases, dso__load requires dso->symbol_type to be set prior to
calling it. With the introduction of symsrc*, the symtab_type is now
stored in a symsrc which is then passed to dso__load_sym().
Change dso__load_sym() to use the symtab_type from them symsrc (setting
dso->symtab_type as
We keep both a 'runtime' elf image as well as a 'debug' elf image around
and generate symbols by looking at both of these.
This eliminates the need for the want_symtab/goto restart mechanism
combined with iterating over and reopening the elf images a second time.
Also give
If we call elf_section_by_name() with a truncated elf image (ie: the file
header indicates that the section headers are placed past the end of the
file), elf_strptr() causes a segfault within libelf.
Avoid this by checking that we can access the section string table
properly.
Should really be
Prelink only adjusts the addresses of non-zero symbols. Do the same when
we reverse the adjustments.
Signed-off-by: Cody P Schafer
---
tools/perf/util/symbol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index
dso__set_long_name() is already called by dso__load_vmlinux(), avoid
calling it a second time unnecessarily.
Signed-off-by: Cody P Schafer
---
tools/perf/util/symbol.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
Only one callsite of dso__load_sym() uses the want_symtab functionality,
so place the logic at the callsite instead of within dso__load_sym().
This sets us up for removal of want_symtab completely once we keep
multiple elf handles (within symsrc's) around.
Setup for the later patch
"perf symbol:
dso__load_vmlinux() uses the filename passed to it to directly set the
dso long_name, which resulted in a use after free due to
dso__load_vmlinux_path() treating 0 symbols as a load failure and
subsequently freeing the contents of dso->long_name.
Change dso__load_vmlinux() so that finding 0
1-4,6,7 are small cleanups.
5 fixes a potential segfault.
8 fixes a use after free for dso->long_name
9 avoids a segfault in elfutils when a truncated elf is loaded.
10 properly tracks that a dso had symbols loaded from a vmlinux image
11-16 fix handling of the '.opd' section in the presence
The only site that jumps to out_fixup has (kallsyms_filename == NULL).
And all paths that reach 'if (err > 0)' without 'goto out_fixup' have
kallsyms_filename != NULL.
So skip over both the check & dso__set_long_name(), and remove the
check.
Signed-off-by: Cody P Schafer
---
Factors opening of certain sections & tracking certain elf info into an
external structure.
The goal here is to keep multiple elfs (and their looked up
sections/indexes) around during the symbol generation process (in
dso__load()).
We need this to properly resolve symbols on PPC due to the
use
map__objdump_2ip was introduced in:
ee11b90b12 perf top: Fix annotate for userspace
And it's last user removed in:
36532461a0 perf top: Ditch private annotation code, share perf annotate's
Remove it.
Signed-off-by: Cody P Schafer
---
tools/perf/util/map.c | 8
tools/perf/util/map.h |
To properly handle platforms with an opd section, both a runtime image
(which contains the opd section but possibly lacks symbols) and a symbol
image (which probably lacks an opd section but has symbols).
The next patch ("perf symbol: use both runtime and debug images")
adjusts the callsite in
Previously, symtab_type would have been left at 0, or KALLSYMS, which is not
quite accurate.
Introduce DSO_SYMTAB_TYPE__VMLINUX[_GUEST].
Signed-off-by: Cody P Schafer
---
tools/perf/util/symbol.c | 9 +
tools/perf/util/symbol.h | 2 ++
2 files changed, 11 insertions(+)
diff --git
If .dynsym exists but .dynstr is empty (NO_BITS or size==0), a segfault
occurs. Avoid this by checking that .dynstr is not empty.
Signed-off-by: Cody P Schafer
---
tools/perf/util/symbol.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
In kallsyms_parse() when calling process_symbol() (a callback argument
to kallsyms_parse()), we pass start as both start & end (ie:
start=start, end=start).
In map__process_kallsym_symbol(), the length is calculated as 'end - start + 1',
making the length 1, not 0.
Essentially, start & end
On Thu, 2012-08-09 at 14:53 -0700, Casey Schaufler wrote:
> On 8/9/2012 2:29 PM, Eric Dumazet wrote:
> > smack_sk_alloc_security() uses smk_of_current() : What can be the
> > meaning of smk_of_current() in the context of 'kernel' sockets...
>
> Yes, and all of it's callers - to date - have had
On Thu, Aug 9, 2012 at 2:23 PM, Jacob Shin wrote:
> Currently direct mappings are created for [ 0 to max_low_pfn< and [ 4GB to max_pfn< backed by actual DRAM. This is fine for holes under 4GB which are covered
> by fixed and variable range MTRRs to be UC. However, we run into trouble
> on higher
On Tue, Jul 31, 2012 at 09:12:22PM +0200, Peter Zijlstra wrote:
> Implement a per-task memory placement scheme for 'big' tasks (as per
> the last patch). It relies on a regular PROT_NONE 'migration' fault to
> scan the memory space of the procress and uses a two stage migration
> scheme to reduce
On 8/9/2012 2:29 PM, Eric Dumazet wrote:
> On Thu, 2012-08-09 at 16:06 -0400, Eric Paris wrote:
>> NAK.
>>
>> I personally think commit be9f4a44e7d41cee should be reverted until it
>> is fixed. Let me explain what all I believe it broke and how.
>>
> Suggesting to revert this commit while we have
Use the 'dev->board_name' instead of the 'dev->driver->driver_name'
as the resource name used when requesing the pci regions in
comedi_pci_enable(). The board_name has a closer affinity to the
card.
Also, remove the dev_err() message when comedi_pci_enable() fails.
It's just noise and doesn't
Convert this PCI driver to use the comedi PCI auto config attach mechanism
by adding an attach_pci callback function. Since the driver does not require
any external configuration options, disable the legacy attach by making the
attach callback simply return -ENOSYS. This removes the need to walk
The PCI-6208/6216 cards have 4 digital inputs and 4 digital outputs.
These are currently being handled by an 8 channel COMEDI_SUBD_DIO
subdevice in this driver. This causes the 4 digital outputs to
appear as channels 0 thru 3 and the 4 digital inputs to appear as
channels 4 thru 7. Userspace can
On Tue, Jul 31, 2012 at 09:12:19PM +0200, Peter Zijlstra wrote:
> @@ -2699,6 +2705,29 @@ select_task_rq_fair(struct task_struct *
> }
>
> rcu_read_lock();
> + if (sched_feat_numa(NUMA_BIAS) && node != -1) {
> + int node_cpu;
> +
> + node_cpu =
Add the boardinfo and pci device table information for the PCI-6216 card.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci6208.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git
Update the comedi adl_pci6208 pci driver.
H Hartley Sweeten (4):
staging: comedi: adl_pci6208: use attach_pci callback
staging: comedi: adl_pci6208: add support for the PCI-6216 card
staging: comedi: adl_pci6208: split the digital i/o subdevice
staging: comedi: adl_pci6208: use the
From: Alan Cox
Date: Thu, 9 Aug 2012 15:13:42 +0100
> On Thu, 9 Aug 2012 17:55:20 +0400
> Marina Makienko wrote:
>
>> The function blk_get_request() can return NULL in some cases. There are
>> checks on it if function is called with argumetns one of which is
>> GFP_ATOMIC/GFP_NOIO/etc. If
On Thu, Aug 9, 2012 at 1:58 PM, Geert Uytterhoeven wrote:
> On Thu, Aug 9, 2012 at 10:51 PM, Luis R. Rodriguez
> wrote:
>> of a second patch submission must supply their own Siged-off-by
>
> Signed-off-by
will send a v2.
Luis
--
To unsubscribe from this list: send the line "unsubscribe
From: "Luis R. Rodriguez"
Initial large code submissions typically are not accepted
on their first patch submission. The developers are
typically given feedback and at times some developers may
even submit changes to the original authors for integration
into their second submission attempt.
On Tue, Jul 31, 2012 at 09:12:14PM +0200, Peter Zijlstra wrote:
> +#ifdef CONFIG_NUMA
> /*
> - * Do fancy stuff...
> + * For NUMA systems we use the special PROT_NONE maps to drive
> + * lazy page migration, see MPOL_MF_LAZY and related.
>*/
> + page =
On Tue, Jul 31, 2012 at 09:12:11PM +0200, Peter Zijlstra wrote:
> From: Lee Schermerhorn
>
> This patch augments the MPOL_MF_LAZY feature by adding a "NOOP"
> policy to mbind(). When the NOOP policy is used with the 'MOVE
> and 'LAZY flags, mbind() [check_range()] will walk the specified
>
On Tue, Jul 31, 2012 at 09:12:09PM +0200, Peter Zijlstra wrote:
> +static bool pte_prot_none(struct vm_area_struct *vma, pte_t pte)
> +{
> + /*
> + * If we have the normal vma->vm_page_prot protections we're not a
> + * 'special' PROT_NONE page.
> + *
> + * This means we
On Tue, Jul 31, 2012 at 09:12:08PM +0200, Peter Zijlstra wrote:
> If we marked a THP with our special PROT_NONE protections, ensure we
> don't loose them over a split.
>
> Collapse seems to always allocate a new (huge) page which should
> already end up on the new target node so loosing
Hi,
On Tue, Jul 31, 2012 at 09:12:06PM +0200, Peter Zijlstra wrote:
> Since the NUMA_INTERLEAVE_HIT statistic is useless on its own; it wants
> to be compared to either a total of interleave allocations or to a miss
> count, remove it.
>
> Fixing it would be possible, but since we've gone years
On Thu, 2012-08-09 at 16:06 -0400, Eric Paris wrote:
> NAK.
>
> I personally think commit be9f4a44e7d41cee should be reverted until it
> is fixed. Let me explain what all I believe it broke and how.
>
Suggesting to revert this commit while we have known working fixes is a
bit of strange
On 08/09/2012 12:37 AM, Todd Poynor wrote:
alarmtimer suspend return -EBUSY if the next alarm will fire in less
than 2 seconds. This allows one RTC seconds tick to occur subsequent
to this check before the alarm wakeup time is set, ensuring the wakeup
time is still in the future (assuming the
This is a revision of an earlier attempt, with suggestions and concernes
from previous conversation (https://lkml.org/lkml/2011/12/16/486) taken
into account.
The following patchset creates direct mappings only for E820_RAM regions
between 0 ~ max_low_pfn and 4GB ~ max_pfn. And leaves
Currently direct mappings are created for [ 0 to max_low_pfn<
---
arch/x86/include/asm/page_types.h |9
arch/x86/kernel/setup.c | 87 +
2 files changed, 88 insertions(+), 8 deletions(-)
diff --git a/arch/x86/include/asm/page_types.h
Update code that previously assumed pfns [ 0 - max_low_pfn_mapped ) and
[ 4GB - max_pfn_mapped ) were always direct mapped; to now look up
pfn_mapped ranges instead.
Signed-off-by: Jacob Shin
---
arch/x86/kernel/cpu/amd.c |6 +-
arch/x86/platform/efi/efi.c |8
2 files
Current logic finds enough space to cover number of tables from 0 to end.
Instead, we only need to find enough space to cover from mr[0].start to
mr[nr_range].end.
Signed-off-by: Jacob Shin
---
arch/x86/mm/init.c | 57 +++-
1 file changed, 30
Update later calls to init_memory_mapping to keep track of direct mapped
pfn ranges.
Signed-off-by: Jacob Shin
---
arch/x86/kernel/amd_gart_64.c |4 +++-
arch/x86/mm/init_64.c |3 +--
arch/x86/platform/efi/efi_64.c |2 ++
3 files changed, 6 insertions(+), 3 deletions(-)
Since we now call init_memory_mapping for each E820_RAM region in a
loop, move cr4 writes out to setup_arch.
Signed-off-by: Jacob Shin
---
arch/x86/kernel/setup.c | 10 ++
arch/x86/mm/init.c | 10 --
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git
On Thu, 9 Aug 2012, Russell King - ARM Linux wrote:
> On Thu, Aug 09, 2012 at 05:12:58PM -0400, Nicolas Pitre wrote:
> > CFLAGS_THUMB2 should probably be renamed to something more appropriate
> > in this case, e.g. CFLAGS_MODE.
>
> CFLAGS_ISA would be more relevant to it, because it's selecting
On Thu, Aug 09, 2012 at 05:12:58PM -0400, Nicolas Pitre wrote:
> CFLAGS_THUMB2 should probably be renamed to something more appropriate
> in this case, e.g. CFLAGS_MODE.
CFLAGS_ISA would be more relevant to it, because it's selecting the
instruction set.
--
To unsubscribe from this list: send
On Thursday, August 09, 2012, Paul Mundt wrote:
> On Wed, Aug 08, 2012 at 11:23:04AM +0200, Rafael J. Wysocki wrote:
> > On Tuesday, August 07, 2012, Paul Mundt wrote:
> > > On Sun, Aug 05, 2012 at 12:02:43AM +0200, Rafael J. Wysocki wrote:
> > > > On Wednesday, August 01, 2012, Paul Mundt wrote:
On Wed, 8 Aug 2012, Arnd Bergmann wrote:
> The Linaro cross toolchain and probably others nowadays default to
> building in THUMB2 mode. When building a kernel for a CPU that does
> not support THUMB2, the compiler complains about incorrect flags.
> We can work around this by setting -marm for
On 08/09/2012 02:06 PM, John Stultz wrote:
On 08/09/2012 12:37 AM, Todd Poynor wrote:
@@ -288,9 +293,11 @@ static int alarmtimer_suspend(struct device *dev)
now = rtc_tm_to_ktime(tm);
now = ktime_add(now, min);
-rtc_timer_start(rtc, , now, ktime_set(0, 0));
-
-return 0;
+
On 08/09/2012 12:37 AM, Todd Poynor wrote:
@@ -288,9 +293,11 @@ static int alarmtimer_suspend(struct device *dev)
now = rtc_tm_to_ktime(tm);
now = ktime_add(now, min);
- rtc_timer_start(rtc, , now, ktime_set(0, 0));
-
- return 0;
+ /* Set alarm, if in the past
On Thu, Aug 9, 2012 at 10:51 PM, Luis R. Rodriguez
wrote:
> of a second patch submission must supply their own Siged-off-by
Signed-off-by
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -366,6 +366,21 @@ and protect the submitter from complaints. Note that
- Original Message -
> From: Hillf Danton
> To: Victor Meyerson
> Cc: "linux-m...@linux-mips.org" ; Ralf Baechle
> ; LKML
> Sent: Friday, July 27, 2012 7:47 AM
> Subject: Re: Direct I/O bug in kernel
>
> On Wed, Jul 25, 2012 at 1:28 AM, Victor Meyerson
> wrote:
>>
>> Still
From: "Luis R. Rodriguez"
Initial large code submissions typically are not accepted
on their first patch submission. The developers are
typically given feedback and at times some developers may
even submit changes to the original authors for integration
into their second submission attempt.
Hi Kent,
Thanks for looking into it. I'll fix in the next version.
Sorry if you got this message twice. I have some issues with my mail
server.
Thanks,
--Ashley Lai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
* Steven Rostedt (rost...@goodmis.org) wrote:
> With the recent talk of performance regressions, I decided to take a
> look a tracepoints. For those that are not familiar with them, they are
> static locations scattered throughout the kernel that let developers
> trace their code when needed, with
I have two USB wireless card with Ralink RT3070 chip, this is the lsusb
Bus 001 Device 013: ID 148f:3070 Ralink Technology, Corp.
RT2870/RT3070 Wireless Adapter
I connect to a router which is 200mt away so i always connect with low signal.
With kernels up to 3.3.x I hadn't any problem with the
On Thu, Aug 09, 2012 at 12:16:35PM -0600, Jim Schutt wrote:
> On 08/09/2012 07:49 AM, Mel Gorman wrote:
> >Changelog since V2
> >o Capture !MIGRATE_MOVABLE pages where possible
> >o Document the treatment of MIGRATE_MOVABLE pages while capturing
> >o Expand changelogs
> >
> >Changelog since V1
>
On Wed, 2012-08-08 at 15:34 -0700, H. Peter Anvin wrote:
> With this patch applied I get an error at:
>
> /home/hpa/kernel/tip.x86-fpu/arch/x86/kernel/signal.c:792:12: error:
> static declaration of ‘x32_setup_rt_frame’ follows non-static declaration
> In file included from
>
With the recent talk of performance regressions, I decided to take a
look a tracepoints. For those that are not familiar with them, they are
static locations scattered throughout the kernel that let developers
trace their code when needed, with very little overhead when not needed
but configured
Hi all,
On Thursday, August 09, 2012, Rafael J. Wysocki wrote:
>
> Unfortunately, pm_runtime_get() is not a very useful interface,
> because if the device is not in the "active" state already, it
> only queues up a work item supposed to resume the device. Then,
> the caller doesn't really know
Hi Ohad,
>> I realize that we have the same issue with the virtio rings.
>> Are there any way we can assign the device address of the virtio rings
>> to the resource table in shared memory?
>
> It's a gap we have today, but it should definitely be fixed.
Ok, good.
Any thoughts on how to go about
On 08/09/2012 05:20 AM, Mel Gorman wrote:
The intention is that an allocation can fail but each subsequent attempt will
try harder until there is success. Each allocation request does a portion
of the necessary work to spread the cost between multiple requests.
At some point we need to stop
On 08/09/2012 12:19 PM, Andy Lutomirski wrote:
> On 08/01/2012 03:10 PM, Meredydd Luff wrote:
>>
>> +#ifndef sys_execveat
>> +asmlinkage long sys_execveat(int dfd, const char __user *filename,
>> + const char __user *const __user *argv,
>> + const
From: Gyungoh Yoo
The MAX8907 is an I2C-based power-management IC containing voltage
regulators, a reset controller, a real-time clock, and a touch-screen
controller.
The original driver was written by:
* Gyungoh Yoo
Various fixes and enhancements by:
* Jin Park
* Tom Cherry
* Prashant
Hi,
I'm investigating some strange behaviour with NBD. Randomly my
nbd-client disconnects:
21:04:20.514159 IP 172.16.86.1.12341 > 172.16.86.129.39633: Flags [.], seq
3776733737:3776735185, ack 2604128070, win 11181, options [nop,nop,TS val
1145422093 ecr 141526], length 1448
21:04:20.514164 IP
On Sun, Jul 29, 2012 at 07:13:57PM +0200, Linus Walleij wrote:
> On Mon, Jul 23, 2012 at 1:59 PM, Thierry Reding
> wrote:
> > +static __devinit int adnp_i2c_probe(struct i2c_client *client,
> > + const struct i2c_device_id *id)
> > +{
> > + struct adnp
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com]
> Subject: Re: [PATCH 0/4] promote zcache from staging
>
> On 08/07/2012 03:23 PM, Seth Jennings wrote:
> > On 07/27/2012 01:18 PM, Seth Jennings wrote:
> >> Some benchmarking numbers demonstrating the I/O saving that can be had
> >> with
On Thu, Aug 9, 2012 at 4:06 PM, Eric Paris wrote:
> I'm going to work right now on exposing the equivalent struct sock LSM
> interface so we can call that as well. But it's going to take me a
> bit.
Before you go too far down this path, can you elaborate on what
exactly you mean by the above?
NAK.
I personally think commit be9f4a44e7d41cee should be reverted until it
is fixed. Let me explain what all I believe it broke and how.
Old callchain of the creation of the 'equivalent' socket previous to
the patch in question just for reference:
inet_ctl_sock_create
On Thu, 9 Aug 2012, Will Deacon wrote:
> On Thu, Aug 09, 2012 at 07:09:02PM +0100, Nicolas Pitre wrote:
> > On Thu, 9 Aug 2012, Will Deacon wrote:
> > > On Thu, Aug 09, 2012 at 05:57:33PM +0100, Nicolas Pitre wrote:
> > > > On Thu, 9 Aug 2012, Nicolas Pitre wrote:
> > > > diff --git
The result of converting an integer value to another signed integer
type that's unable to represent the original value is implementation
defined. (See notes in section 6.3.1.3 of the C standard.)
In match_number(), the result of simple_strtol() (which returns type
long) is assigned to a value
On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote:
> Yeah, that would work as well, although the code would look uglier.
> IMHO, using select/depend is better.
>
Agreed, I think it should be "depends on LEDS_CLASS" rather than select
it if there is a hard dependency that cannot be fixed with
If blk_init_queue fails, we do not call put_disk on the current dr
(dr is decremented first in the error handling loop).
Signed-off-by: Herton Ronaldo Krzesinski
Cc: sta...@vger.kernel.org
---
drivers/block/floppy.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/floppy.c
After commit 3f9a5aa ("floppy: Cleanup disk->queue before caling
put_disk() if add_disk() was never called"), if something fails in the
add_disk loop, we unconditionally set disks[dr]->queue to NULL. But
that's wrong, since we may have succesfully done an add_disk on some of
the drives previously
Following this are fixes for bugs I noticed on floppy driver, and some
extra cleanups.
v2: separate fixes, and incorporate suggestions by Vivek Goyal.
also I splitted the cleanups from fixes.
--
[]'s
Herton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
The check "if (disks[dr]->queue)" check is bogus, if we reach there
for each dr should exist an queue allocated (note that we decrement dr
first on entering the loop).
Signed-off-by: Herton Ronaldo Krzesinski
---
drivers/block/floppy.c | 16 +++-
1 file changed, 7 insertions(+), 9
Simplify/cleanup code, replacing remaining checks for drives present
using disk_registered array.
Signed-off-by: Herton Ronaldo Krzesinski
---
drivers/block/floppy.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
On do_floppy_init, if something failed inside the loop we call add_disk,
there was no cleanup of previous iterations in the error handling.
Signed-off-by: Herton Ronaldo Krzesinski
Cc: sta...@vger.kernel.org
---
drivers/block/floppy.c | 10 +-
1 file changed, 9 insertions(+), 1
Since commit 070ad7e ("floppy: convert to delayed work and single-thread
wq"), we end up calling alloc_ordered_workqueue multiple times inside
the loop, which shouldn't be intended. Besides the leak, other side
effect in the current code is if blk_init_queue fails, we would end up
calling
Hi Sjur,
On Wed, Aug 8, 2012 at 7:55 PM, Sjur Brændeland wrote:
> I realize that we have the same issue with the virtio rings.
> Are there any way we can assign the device address of the virtio rings
> to the resource table in shared memory?
It's a gap we have today, but it should definitely be
On 08/09/2012 10:53 AM, Lee Jones wrote:
> of_irq_find_parent is a handy function to use outside the confines of
> the Open Firmware subsystem. One such use-case is when the IRQ Domain
> wishes to find an IRQ domain for a given device node. Currently it can
> not take any notice of the
On Thu, Aug 09, 2012 at 11:20:54AM -0500, Rob Herring wrote:
> On 08/09/2012 10:53 AM, Lee Jones wrote:
> > of_irq_find_parent is a handy function to use outside the confines of
> > the Open Firmware subsystem. One such use-case is when the IRQ Domain
> > wishes to find an IRQ domain for a given
On Thursday, August 09, 2012, Mark Brown wrote:
> Commit a2c204 (timekeeping: Add suspend and resume of clock event devices)
> added suspend and resume operations for clockevents but did not provide
> stubs for these functions, breaking the build when clockevents are not
> being built. Add the
On Thu, Aug 09, 2012 at 07:50:29PM +0100, Mark Brown wrote:
> On Thu, Aug 09, 2012 at 04:47:26PM +0100, Lee Jones wrote:
> > Another fine instalment of Audio fixes and Device Tree enablement
> > surrounding the mop500 sound driver. Hopefully containing all of
> > the recommendations suggested by
On Thu, Aug 09, 2012 at 12:33:17PM -0700, John Stultz wrote:
> On 08/09/2012 06:35 AM, Andrea Righi wrote:
> >On Thu, Aug 09, 2012 at 02:46:37AM -0700, Michel Lespinasse wrote:
> >>On Fri, Jul 27, 2012 at 8:57 PM, John Stultz wrote:
> >>>v5:
> >>>* Drop intervaltree for prio_tree usage per Michel
On Fri, Aug 10, 2012 at 12:13:19AM +0800, Keng-Yu Lin wrote:
> On Thu, Aug 9, 2012 at 10:24 PM, Sarah Sharp
> wrote:
> > On Thu, Aug 09, 2012 at 05:31:51PM +0800, Keng-Yu Lin wrote:
> >> With a previous patch to enable the EHCI/XHCI port switching, it switches
> >> all the available ports.
> >>
>
On Thursday, August 09, 2012, Mark Brown wrote:
> Commit a2c204 (timekeeping: Add suspend and resume of clock event devices)
> added suspend and resume operations for clockevents but did not provide
> stubs for these functions, breaking the build when clockevents are not
> being built. Add the
On 08/09/2012 06:35 AM, Andrea Righi wrote:
On Thu, Aug 09, 2012 at 02:46:37AM -0700, Michel Lespinasse wrote:
On Fri, Jul 27, 2012 at 8:57 PM, John Stultz wrote:
v5:
* Drop intervaltree for prio_tree usage per Michel &
Dmitry's suggestions.
Actually, I believe the ranges you need to
On Thu, Aug 2, 2012 at 9:36 PM, James Morris wrote:
> On Wed, 1 Aug 2012, Andy Lutomirski wrote:
>
>> This fixes two issues that could cause incompatibility between
>> kernel versions:
>>
>> - If a tracer uses SECCOMP_RET_TRACE to select a syscall number
>>higher than the largest known
On Thu, 2012-08-09 at 14:08 -0500, Christoph Lameter (Open Source)
wrote:
> On Thu, 9 Aug 2012, Shuah Khan wrote:
>
> > Moving these checks into kmem_cache_sanity_check() would mean return
> > path handling will change. The first block of sanity checks for name,
> > and size etc. are done before
On Thu, Aug 9, 2012 at 12:13 PM, Luis R. Rodriguez
wrote:
> So -- are we OK to *not* include SOBs of evolutions sent to developers
> of joojoo-1 when company x submits joojoo-2 so long as those patches
> were sent publicly or a record is kept somewhere ?
And lets be fair, some folks *may* want
Em Mon, Aug 06, 2012 at 01:41:18PM +0900, Namhyung Kim escreveu:
> Hi,
>
> This is my forth version of the series. Please consider applying. :)
Thanks, applied to perf/core,
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
101 - 200 of 1336 matches
Mail list logo
