Anyone care to refresh my memory why we can't use the "global"
1:1+kernel map, possibly with some improvements (which would benefit the
users of those maps too)? With that I mean initial_page_map on i386 and
trampoline_pgd on x86-64...
-hpa
--
H. Peter Anvin, Intel Open Source Technol
On Thu, Sep 06, 2012 at 03:32:22PM +0200, Peter Zijlstra wrote:
> On Thu, 2012-08-30 at 11:18 -0700, Paul E. McKenney wrote:
> > +static int rcu_gp_kthread(void *arg)
> > +{
> > + unsigned long flags;
> > + struct rcu_data *rdp;
> > + struct rcu_node *rnp;
> > + struct rcu_s
On Fri, 31 Aug 2012, Marco Stornelli wrote:
> Date: Fri, 31 Aug 2012 15:50:20 +0200
> From: Marco Stornelli
> To: Linux FS Devel , linux...@kvack.org
> Cc: Linux Kernel
> Subject: [PATCH 00/21] drop vmtruncate
>
> Hi all,
>
> with this patch series I try to clean the vmtruncate code. The theor
* Sasha Levin (levinsasha...@gmail.com) wrote:
> On 09/06/2012 06:50 PM, Mathieu Desnoyers wrote:
> > * Sasha Levin (levinsasha...@gmail.com) wrote:
> >> On 09/06/2012 06:00 PM, Steven Rostedt wrote:
> > I think that that code doesn't make sense. The users of
> > hlist_for_each_* aren't
>
Hello, Lai.
On Thu, Sep 06, 2012 at 06:44:53PM +0800, Lai Jiangshan wrote:
> On 09/06/2012 04:04 AM, Tejun Heo wrote:
> > Please don't scatter small prep patches like this. Each piece in
> > isolation doesn't make much sense to me and the patch descriptions
> > don't help much. Please collect th
On 09/06/2012 06:50 PM, Mathieu Desnoyers wrote:
> * Sasha Levin (levinsasha...@gmail.com) wrote:
>> On 09/06/2012 06:00 PM, Steven Rostedt wrote:
> I think that that code doesn't make sense. The users of hlist_for_each_*
> aren't
> supposed to be changing the loop cursor.
>>> I totall
On Thu, 2012-09-06 at 09:47 -0700, Paul E. McKenney wrote:
> The key point is "would simple put RCU into extended quiescent state".
> This can only happen if the CPU has no callbacks. If the CPU does have
> callbacks, then RCU will need to do some work to advance the callbacks.
> Advancing the cal
On Thu, 2012-08-30 at 14:05 -0700, Paul E. McKenney wrote:
> From: Frederic Weisbecker
>
> When an exception or an irq exits, and we are going to resume into
> interrupted kernel code, the low level architecture code calls
> preempt_schedule_irq() if there is a need to reschedule.
>
> If the int
Hello, Lai.
On Thu, Sep 06, 2012 at 09:04:06AM +0800, Lai Jiangshan wrote:
> > This doesn't change anything. You're just moving the test to the
> > caller with comments there explaining how it won't change even if
> > gcwq->lock is released. It seems more confusing to me. The flag is
> > still
* Sasha Levin (levinsasha...@gmail.com) wrote:
> On 09/06/2012 06:00 PM, Steven Rostedt wrote:
> >> > I think that that code doesn't make sense. The users of hlist_for_each_*
> >> > aren't
> >> > supposed to be changing the loop cursor.
> > I totally agree. Modifying the 'node' pointer is just ask
Resending patch with latest kernel code:
In xhci-ring.c, function inc_enq and inc_deq calculate the dma address
of trb but never used.
Signed-off-by: Girish Verma
---
drivers/usb/host/xhci-ring.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/xhci
On 09/06/2012 11:09 AM, Peter Senna Tschudin wrote:
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/net/wireless/rtlwifi/rtl8192de/phy.c |2 +-
1 file changed, 1 insertion(+), 1 d
The double invocations are incorrect but seem to be safe so I don't
think this will fix any bugs.
Before:
[7.639366] drm_prime_init_file ee3675d0
[7.639377] drm_prime_init_file ee3675d0
[7.639507] drm_prime_destroy_file ee3675d0
[7.639518] drm_prime_destroy_file ee3675d0
[7.63
With the new i.mx clock framework the mxc_w1 clock is registered as:
clk_register_clkdev(clk[owire_gate], NULL, "mxc_w1.0"
So we do not need to pass "owire" string and can use NULL instead.
While at it, also fix the clock error handling code.
Signed-off-by: Fabio Estevam
-
Changes since v1
On Thu, Sep 06, 2012 at 12:13:37PM +0200, Peter Zijlstra wrote:
> On Wed, 2012-09-05 at 16:44 -0700, Paul E. McKenney wrote:
>
> > I was excited by this possibility when you first mentioned it, but
> > the low-OS-jitter fans are going to need the grace-period computation
> > to be offloaded as wel
OK, I am working on It.
I will sent a new patch for Dong's corrections as quickly as possible.
Thanks alot for Dong's corrections.
The new patch will base on the patch I have submitted,
because that patch has applied to Greg Kroah-Hartman's driver-core git tree.
So sorry about that mess code.
On Thu, Sep 06, 2012 at 02:00:16AM +, Liu, Chuansheng wrote:
> Because the IRQF_DISABLED as the flag is now a NOOP and has been
> deprecated and in hardirq context the interrupt is disabled.
>
> so in usb/host code:
> Removing the usage of flag IRQF_DISABLED;
> Removing the calling local_irq s
On 09/05/2012 07:08 PM, Steven Rostedt wrote:
> On Sun, 2012-09-02 at 11:04 +0200, Toralf Förster wrote:
>> The current git tree of linux gave with gcc-4.6.3 :
>>
>> kernel/trace/trace_events_filter.c: In function
>> ‘ftrace_function_set_filter_cb’:
>> kernel/trace/trace_events_filter.c:2074:8: wa
Hi,
On Thursday 06 September 2012 04:53:38 Minchan Kim wrote:
> Normally, MIGRATE_ISOLATE type is used for memory-hotplug.
> But it's irony type because the pages isolated would exist
> as free page in free_area->free_list[MIGRATE_ISOLATE] so people
> can think of it as allocatable pages but it i
On Thu, Sep 6, 2012 at 8:16 AM, Dave Jones wrote:
> On Thu, Sep 06, 2012 at 09:46:28AM -0400, Dave Jones wrote:
> > Hit this in overnight fuzz testing..
> >
> > BUG: unable to handle kernel NULL pointer dereference at 0020
> > IP: [] audit_log_d_path+0x35/0xf0
> > PGD 12fded067 PU
On 09/06/2012 07:42 AM, Steven Rostedt wrote:
> On Thu, 2012-09-06 at 22:29 +0800, Cong Wang wrote:
>
>> I don't think feature-removal-schedule.txt is for kernel users, it
>> is a kind of a TODO list for kernel developers.
>
> And this is exactly what Linus was complaining about. It shouldn't be
On Thu, Sep 06, 2012 at 03:17:18AM +0200, Tomas Hlavacek wrote:
> Added file /sys/devices/.../tty/ttySX/uartclk to allow reading
> uartclk value in struct uart_port in serial_core via sysfs.
>
> tty_register_device() has been generalized and refactored in order
> to add support for setting drvdata
On Thu, 2012-09-06 at 09:18 -0700, Paul E. McKenney wrote:
> On Thu, Sep 06, 2012 at 04:21:30PM +0200, Peter Zijlstra wrote:
> > On Wed, 2012-09-05 at 11:19 -0700, Paul E. McKenney wrote:
> > > I tried that, and got a surprisingly large set of conflicts. Ah, OK,
> > > the problem is that breaking
On Thu, Sep 06, 2012 at 03:45:19PM +0300, Felipe Balbi wrote:
> Hi guys,
>
> here's v4 of the omap uart patchset. No changes other than a rebase on top of
> Greg's tty-next branch and Tony's Acked-by being added to a couple patches
>
> Note: I'm resending the series with Vikram's Software Flow Co
On Thu, Sep 06, 2012 at 02:04:16PM +, maximilian attems wrote:
> On Thu, Sep 06, 2012 at 02:00:04PM +, maximilian attems wrote:
> > On Wed, Sep 05, 2012 at 08:26:05PM +, maximilian attems wrote:
> > > On Wed, Sep 05, 2012 at 07:40:09PM +0300, Tzafrir Cohen wrote:
> > > >
> > > > $ grep
On 09/06/2012 06:00 PM, Steven Rostedt wrote:
>> > I think that that code doesn't make sense. The users of hlist_for_each_*
>> > aren't
>> > supposed to be changing the loop cursor.
> I totally agree. Modifying the 'node' pointer is just asking for issues.
> Yes that is error prone, but not due to
Hi Peter,
On Thu, Sep 06, 2012 at 03:12:15PM +0300, Peter Ujfalusi wrote:
> Add support when the kernel has been booted with DT blob. In this case the
> pdata is NULL, we need to reach up to the core node and check if the codec
> part has been enabled to determine if we need to coexist with the co
On Thu, Sep 06, 2012 at 04:21:30PM +0200, Peter Zijlstra wrote:
> On Wed, 2012-09-05 at 11:19 -0700, Paul E. McKenney wrote:
> > I tried that, and got a surprisingly large set of conflicts. Ah, OK,
> > the problem is that breaking up rcu_gp_kthread() into subfunctions
> > did enough code motion to
On Thu, Aug 30, 2012 at 09:48:12PM -0600, Jim Cromie wrote:
> On Thu, Aug 30, 2012 at 11:43 AM, Jim Cromie wrote:
> > On Sun, Aug 26, 2012 at 5:25 AM, Joe Perches wrote:
> >> The recent commit to fix dynamic_debug was a bit unclean.
> >> Neaten the style for dynamic_debug.
> >> Reduce the stack u
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/media/radio/si4713-i2c.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff -u -p a/drivers/media/radio/si4713-i2c.
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/media/dvb-frontends/sp8870.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -u -p a/drivers/media/dvb-frontends/sp887
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/media/dvb-frontends/itd1000.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/media/dvb-frontends/itd1000.c
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/block/ataflop.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/block/ataflop.c b/drivers/block/ataflop.c
--
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/net/usb/sierra_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/net/usb/sierra_net.c b/drivers/net/usb/
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
net/mac80211/scan.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/net/mac80211/scan.c b/net/mac80211/scan.c
--- a/net/mac8
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/video/sis/initextlfb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/video/sis/initextlfb.c b/drivers/vide
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/media/pci/cx88/cx88-blackbird.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -u -p a/drivers/media/pci/cx88/cx88-bl
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/scsi/sym53c8xx_2/sym_fw.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -u -p a/drivers/scsi/sym53c8xx_2/sym_fw.c
b
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/net/wireless/rtlwifi/rtl8192de/phy.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/net/wireless/rtlwifi/rt
On Thu, 2012-09-06 at 15:23 +0200, Stephane Eranian wrote:
> Software events (sw,tracepoints,...) do not need to be
> multiplexed. However, when using a SW event, the SW PMU
> (TYPE_SOFTWARE, TYPE_TRACEPOINT) was added to the per-cpu
> rotation_list. That list is used by perf_rotate_context()
> to
Trivially triggerable by any user.
kernel BUG at mm/mempolicy.c:2546!
invalid opcode: [#1] SMP
CPU 2
Modules linked in: tun fuse binfmt_misc caif_socket caif phonet bluetooth
rfkill can llc2 pppoe pppox ppp_generic slhc irda crc_ccitt rds af_key decnet
rose x25 atm netrom appletalk ipx p8
On Thu, 2012-09-06 at 17:49 +0200, Sasha Levin wrote:
>
> > Looks reasonable. However, it would break (or rather, not break) on
> > code like this:
> >
> > hash_for_each_entry(...) {
> > if (...) {
> > foo(node);
> > node = NULL;
ug, I di
When the lowerdir represents a read-only filesystems, attempts to write
to the overlay will check for write permissions on files in the lower
layer via the lower layer inode .permissions operation. This operation
may take the read-only status into account and fail the request even
though the notio
When the upper filesystem does not support the same extended attribute
families as the lower filesystem attempts to copy these xattrs up will
fail EOPNOTSUPP. This is tickled by NFS which stores access information
in an NFS specific prefix. Ignore failures to set these attributes.
BugLink: http:
During some testing here we discovered that we could not successfully
use a NFS as the lower layer for overlayfs. There are two separate issues:
Firstly when using an NFSv4 lower layer we tickle an issue when copying
up the xattrs for the underlying file. NFS uses an xattr system.nfs4_acl
which
On Thu, Sep 06, 2012 at 11:47:49AM -0400, Dave Jones wrote:
> > Not certain because I haven't looked at what happens with the error
> > code, but I think this might not be right. auditd can be explictly
> > told not to audit certain events, in which case it is normal and
> > expected that ab w
On Thu, 2012-09-06 at 17:36 +0200, Robert Richter wrote:
> I meant:
>
> unsigned long kernel_stack_pointer(struct pt_regs *regs)
> {
> unsigned long context = (unsigned long)regs & ~(THREAD_SIZE - 1);
> unsigned long sp = (unsigned long)®s->sp;
> struct thread_info *tinfo;
>
>
Adding -b option to perf diff command to display only entries
with match in the baseline.
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Paul Mackerras
Cc: Corey Ashford
Cc: Frederic Weisbecker
Cc: Paul E. McKenney
Cc: Andi Kleen
Cc: David Ahern
Cc: Namhyung Kim
Sign
Putting 'perf diff' command back on track with the 'latest'
evsel hists changes. Each evsel has its own 'hists' object
gathering stats for the particular event.
While currently counts are accumulated for the whole session
regardless of the events diversification within compared
sessions.
The 'per
Currently for any of the data columns (like Overhead/Period..) in
stdio ui, there's separate code to print header/dots/value scattered
along the display code path.
Adding hists_stdio_column struct to centralize all info needed
to print column header/dots/value.
This change eases up addition for n
Adding support to sort hist entries based on the outcome of selected
computation. It's now possible to specify '+' as a first character
of '-c' option value to make such sort.
Example:
$ ./perf diff -cratio -b
# Event 'cache-misses'
#
# Baseline Ratio Shared Object
hi,
this patchset factors the perf diff command to be usable for
differential profiling following paper from Paul McKenney:
(thanks to Arnaldo for sharing it with me).
http://www2.rdrop.com/users/paulmck/scalability/paper/profiling.2002.06.04.pdf
The 'perf diff' and 'std/hist' code is now chang
Adding -c option to select computation method with the current
'Delta' computation as default. Current posible values are of
this option are: 'delta' and 'ratio'.
Adding 'ratio' as new computation way to compare hist entries.
If specified the 'Ratio' column is displayed with value 'r'
computed as:
On 09/06/2012 04:55 PM, Josh Triplett wrote:
> On Thu, Sep 06, 2012 at 03:53:58PM +0200, Sasha Levin wrote:
>> On 09/04/2012 07:01 PM, Mathieu Desnoyers wrote:
#define do_for_each_ftrace_rec(pg, rec)
\
> for (pg = ftrace_pages_start, r
Adding -F option to display the formula for specified computation.
This is mainly to facilitate debuging, but can be usefull anyway.
Adding this support for weighted diff computation.
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Paul Mackerras
Cc: Corey Ashford
Cc: Fre
On Wed, Sep 5, 2012 at 11:30 PM, David Miller wrote:
> From: Nicolas Ferre
> Date: Wed, 5 Sep 2012 10:19:11 +0200
>
>> From: Havard Skinnemoen
>>
>> Fix a race in macb_start_xmit() where we unconditionally set the TSTART bit.
>> If an underrun just happened (we do this with interrupts disabled,
The repsep_snprintf function was still using standalone field_sep,
which not even set anymore.
Replacing it with 'symbol_conf.field_sep'.
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Paul Mackerras
Cc: Corey Ashford
Cc: Frederic Weisbecker
Cc: Paul E. McKenney
Cc: An
Adding pointer back to the parent hists struct for struct hists_entry.
This will be useful in future for any hist_entry's data computation,
that depends on total data of its parent hists.
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Paul Mackerras
Cc: Corey Ashford
Cc:
On Thu, 2012-09-06 at 15:34 +0100, Jan Beulich wrote:
> >>> On 06.09.12 at 15:15, Matt Fleming wrote:
> > From: Matt Fleming
> >
> > Some firmware still needs a 1:1 (virt->phys) mapping even after we've
> > called SetVirtualAddressMap(). So install the mapping alongside our
> > existing kernel m
Moving the position calculation into the diff command, so the position
is prepared inside hist_entry data and there's no need to compute in
the output display path.
It will be needed for next cleanup patches.
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Paul Mackerras
C
Adding -p option to show period values for both compared hist
entries - showing hist columns HISTC_TOTAL_PERIOD and new stdio
hist column HISTC_BASELINE_TOTAL_PERIOD.
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Paul Mackerras
Cc: Corey Ashford
Cc: Frederic Weisbecker
The -F option displays the formula for specified computation.
Adding this support for weighted diff computation.
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Paul Mackerras
Cc: Corey Ashford
Cc: Frederic Weisbecker
Cc: Paul E. McKenney
Cc: Andi Kleen
Cc: David Ahern
Adding 'wdiff' as new computation way to compare hist entries.
If specified the 'Weighted diff' column is displayed with value 'd'
computed as:
d = B->period * WEIGHT-A - A->period * WEIGHT-B
- A/B being matching hist entry from first/second file specified
(or perf.data/perf.data.old) r
On Thu, Sep 06, 2012 at 11:36:06AM -0400, Eric Paris wrote:
> On Thu, Sep 6, 2012 at 11:08 AM, Dave Jones wrote:
> > Following on from the previous patch that fixed an oops, these
> > are all the other similar code patterns in the tree with the same
> > checks added. I never saw these causing
On Thu, Sep 6, 2012 at 8:21 AM, Daniel Kurtz wrote:
> chained_irq_enter/exit() already mask&ack/unmask the chained interrupt.
> There is no need to also explicitly do it in the handler.
>
> Signed-off-by: Daniel Kurtz
> ---
> arch/arm/mach-exynos/common.c |7 ---
> 1 files changed, 0 ins
On 06.09.12 11:14:42, Steven Rostedt wrote:
> On Thu, 2012-09-06 at 17:02 +0200, Robert Richter wrote:
>
> > > > --- a/arch/x86/oprofile/backtrace.c
> > > > +++ b/arch/x86/oprofile/backtrace.c
> > > > @@ -113,7 +113,7 @@ x86_backtrace(struct pt_regs * const regs, unsigned
> > > > int depth)
> > >
On 06.09.12 17:34:07, Robert Richter wrote:
> On 06.09.12 11:14:42, Steven Rostedt wrote:
> > On Thu, 2012-09-06 at 17:02 +0200, Robert Richter wrote:
> >
> > > > > --- a/arch/x86/oprofile/backtrace.c
> > > > > +++ b/arch/x86/oprofile/backtrace.c
> > > > > @@ -113,7 +113,7 @@ x86_backtrace(struct
On Thu, Sep 6, 2012 at 8:59 PM, Alan Cox wrote:
>> Sorry, I don't see anyone explained clearly why request_firmware()
>> can't be called inside module_init() in module case, so maybe it is
>> a bit early to say it is a fix on 'bug', :-)
>
> Because the firmware load may trigger a need to load a dr
On Thu, Sep 6, 2012 at 11:08 AM, Dave Jones wrote:
> Following on from the previous patch that fixed an oops, these
> are all the other similar code patterns in the tree with the same
> checks added. I never saw these causing problems, but checking
> this everywhere seems to make more sense than
On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote:
> The mailbox register for usb otg in omap is present in control module.
> On detection of any events VBUS or ID, this register should be written
> to send the notification to musb core.
>
> Till we have a separate control module driver to write
On Thu, Sep 6, 2012 at 11:16 AM, Dave Jones wrote:
> On Thu, Sep 06, 2012 at 09:46:28AM -0400, Dave Jones wrote:
> > Hit this in overnight fuzz testing..
> >
> > BUG: unable to handle kernel NULL pointer dereference at 0020
> > IP: [] audit_log_d_path+0x35/0xf0
> > PGD 12fded067 P
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
chained_irq_enter/exit() already mask&ack/unmask the chained interrupt.
There is no need to also explicitly do it in the handler.
Signed-off-by: Daniel Kurtz
---
arch/arm/mach-exynos/common.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-exynos/comm
On Thu, 2012-09-06 at 11:07 -0400, Steven Rostedt wrote:
> On Thu, 2012-09-06 at 16:56 +0200, Peter Zijlstra wrote:
> > On Thu, 2012-08-30 at 11:56 -0700, Paul E. McKenney wrote:
> > >
> > > If a given CPU avoids the idle loop but also avoids starting a new
> > > RCU grace period for a full minute
Hi Linus,
Please pull hwmon fixes for Linux 3.6-rc5 from signed tag:
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
hwmon-for-linus
There is only one patch in this pull request. While the changes are not in the
drivers/hwmon directory, the problem primarily affects h
Hi Omar,
On 09/03/2012 04:29 PM, Omar Ramirez Luna wrote:
> On 22 August 2012 00:42, Omar Ramirez Luna wrote:
>> From: Omar Ramirez Luna
>>
>> The patch to expose hwmod assert/deassert functions through omap_device
>> has been accepted and queued for 3.7[1], however these two patches are
>> need
On Thu, Sep 06, 2012 at 09:46:28AM -0400, Dave Jones wrote:
> Hit this in overnight fuzz testing..
>
> BUG: unable to handle kernel NULL pointer dereference at 0020
> IP: [] audit_log_d_path+0x35/0xf0
> PGD 12fded067 PUD 142c06067 PMD 0
> Oops: [#1] SMP
> Modules linked i
On Thu, 2012-09-06 at 17:02 +0200, Robert Richter wrote:
> > > --- a/arch/x86/oprofile/backtrace.c
> > > +++ b/arch/x86/oprofile/backtrace.c
> > > @@ -113,7 +113,7 @@ x86_backtrace(struct pt_regs * const regs, unsigned
> > > int depth)
> > >
> > > if (!user_mode_vm(regs)) {
> > > un
On Thu, 2012-08-30 at 11:56 -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney"
>
> The can_stop_idle_tick() function complains if a softirq vector is
> raised too late in the idle-entry process, presumably in order to
> prevent dangling softirq invocations from being delayed across the
> f
This patch started with the aim of fixing START STOP UNIT to a PSCSI
device. Right now, commands with a zero-size payload are skipped
completely. This is wrong; such commands should be passed down to the
device and processed normally. As a hint of this, we have a hack to
clear a unit attention s
The purpose of this function is to clear a LUN set in the CDB, in case
the initiator talking to us is speaking an old standards version.
However, as things stand, pscsi_clear_cdb_lun has two problems. It
will "deceive" the guest by clearing the LUN bits on initial
commands (INQUIRY, TEST UNIT READ
Hi all,
here are two more fixes for SCSI passthrough. The first removes an
(IMO) ill-conceived functionality and fixes passthrough of protection
information. The second started as a fix for START STOP UNIT, and ended
up as a more general change in transport_kmap_data_sg.
Please review!
Paolo
Hi Omar,
On 08/22/2012 07:42 AM, Omar Ramirez Luna wrote:
> For a reset sequence to complete cleanly, a module needs its
> associated clocks to be enabled, otherwise the timeout check
> in prcm code can print a false failure (failed to hardreset)
> that occurs because the clocks aren't powered ON
On Thu, Sep 06, 2012 at 01:17:39PM +0200, Fabio Baltieri wrote:
> Hi Kurt,
>
> On Thu, Sep 6, 2012 at 12:33 PM, Kurt Van Dijck wrote:
> > On Tue, Sep 04, 2012 at 10:15:53PM +0200, Fabio Baltieri wrote:
> >> On Tue, Sep 04, 2012 at 09:11:28AM +0200, Kurt Van Dijck wrote:
> > [...]
> >> > > The nam
On Thu, 2012-09-06 at 07:55 -0700, Josh Triplett wrote:
> > My solution to making 'break' work in the iterator is:
> >
> > for (bkt = 0, node = NULL; bkt < HASH_SIZE(name) && node == NULL; bkt++)
> > hlist_for_each_entry(obj, node, &name[bkt], member)
> >
>
> Looks reasonable.
Following on from the previous patch that fixed an oops, these
are all the other similar code patterns in the tree with the same
checks added. I never saw these causing problems, but checking
this everywhere seems to make more sense than every subsequent
routine that gets passed 'ab' having to che
On Wed, Sep 05, 2012 at 04:11:01PM +0200, walter harms wrote:
>
>
> Am 05.09.2012 14:34, schrieb Dan Carpenter:
> > We should decrement "i" before doing the free_irq(). If we call this
> > because request_threaded_irq() failed then we don't want to free the
> > thing which failed. Or in the cas
401 - 500 of 793 matches
Mail list logo
