Re: Check all returns from audit_log_start

2012-09-06 Thread Dave Jones
On Thu, Sep 06, 2012 at 11:47:49AM -0400, Dave Jones wrote: > > Not certain because I haven't looked at what happens with the error > > code, but I think this might not be right. auditd can be explictly > > told not to audit certain events, in which case it is normal and > > expected that ab

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 17:36 +0200, Robert Richter wrote: > I meant: > > unsigned long kernel_stack_pointer(struct pt_regs *regs) > { > unsigned long context = (unsigned long)regs & ~(THREAD_SIZE - 1); > unsigned long sp = (unsigned long)>sp; > struct thread_info *tinfo; > >

[PATCH 06/12] perf diff: Add -b option for perf diff to display paired entries only

2012-09-06 Thread Jiri Olsa
Adding -b option to perf diff command to display only entries with match in the baseline. Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Paul E. McKenney Cc: Andi Kleen Cc: David Ahern Cc: Namhyung Kim

[PATCH 01/12] perf diff: Make diff command work with evsel hists

2012-09-06 Thread Jiri Olsa
Putting 'perf diff' command back on track with the 'latest' evsel hists changes. Each evsel has its own 'hists' object gathering stats for the particular event. While currently counts are accumulated for the whole session regardless of the events diversification within compared sessions. The

[PATCH 05/12] perf diff: Refactor stdio ui data columns output

2012-09-06 Thread Jiri Olsa
Currently for any of the data columns (like Overhead/Period..) in stdio ui, there's separate code to print header/dots/value scattered along the display code path. Adding hists_stdio_column struct to centralize all info needed to print column header/dots/value. This change eases up addition for

[PATCH 08/12] perf diff: Add option to sort entries based on diff computation

2012-09-06 Thread Jiri Olsa
Adding support to sort hist entries based on the outcome of selected computation. It's now possible to specify '+' as a first character of '-c' option value to make such sort. Example: $ ./perf diff -cratio -b # Event 'cache-misses' # # Baseline Ratio Shared Object

[RFC 00/12] perf diff: Factor diff command

2012-09-06 Thread Jiri Olsa
hi, this patchset factors the perf diff command to be usable for differential profiling following paper from Paul McKenney: (thanks to Arnaldo for sharing it with me). http://www2.rdrop.com/users/paulmck/scalability/paper/profiling.2002.06.04.pdf The 'perf diff' and 'std/hist' code is now

[PATCH 07/12] perf diff: Add ratio computation way to compare hist entries

2012-09-06 Thread Jiri Olsa
Adding -c option to select computation method with the current 'Delta' computation as default. Current posible values are of this option are: 'delta' and 'ratio'. Adding 'ratio' as new computation way to compare hist entries. If specified the 'Ratio' column is displayed with value 'r' computed

Re: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Sasha Levin
On 09/06/2012 04:55 PM, Josh Triplett wrote: > On Thu, Sep 06, 2012 at 03:53:58PM +0200, Sasha Levin wrote: >> On 09/04/2012 07:01 PM, Mathieu Desnoyers wrote: #define do_for_each_ftrace_rec(pg, rec) \ > for (pg = ftrace_pages_start,

[PATCH 11/12] perf diff: Add -F option to display formula for computation

2012-09-06 Thread Jiri Olsa
Adding -F option to display the formula for specified computation. This is mainly to facilitate debuging, but can be usefull anyway. Adding this support for weighted diff computation. Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc:

Re: [PATCH 04/10] net/macb: Fix a race in macb_start_xmit()

2012-09-06 Thread Havard Skinnemoen
On Wed, Sep 5, 2012 at 11:30 PM, David Miller wrote: > From: Nicolas Ferre > Date: Wed, 5 Sep 2012 10:19:11 +0200 > >> From: Havard Skinnemoen >> >> Fix a race in macb_start_xmit() where we unconditionally set the TSTART bit. >> If an underrun just happened (we do this with interrupts disabled,

[PATCH 02/12] perf tools: Replace sort's standalone field_sep with symbol_conf.field_sep

2012-09-06 Thread Jiri Olsa
The repsep_snprintf function was still using standalone field_sep, which not even set anymore. Replacing it with 'symbol_conf.field_sep'. Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Paul E. McKenney Cc:

[PATCH 03/12] perf hists: Add struct hists pointer to struct hist_entry

2012-09-06 Thread Jiri Olsa
Adding pointer back to the parent hists struct for struct hists_entry. This will be useful in future for any hist_entry's data computation, that depends on total data of its parent hists. Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford

Re: [PATCH] x86, efi: 1:1 pagetable mapping for virtual EFI calls

2012-09-06 Thread Matt Fleming
On Thu, 2012-09-06 at 15:34 +0100, Jan Beulich wrote: > >>> On 06.09.12 at 15:15, Matt Fleming wrote: > > From: Matt Fleming > > > > Some firmware still needs a 1:1 (virt->phys) mapping even after we've > > called SetVirtualAddressMap(). So install the mapping alongside our > > existing kernel

[PATCH 04/12] perf diff: Refactor diff displacement possition info

2012-09-06 Thread Jiri Olsa
Moving the position calculation into the diff command, so the position is prepared inside hist_entry data and there's no need to compute in the output display path. It will be needed for next cleanup patches. Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras

[PATCH 10/12] perf diff: Add -p option to display period values for hist entries

2012-09-06 Thread Jiri Olsa
Adding -p option to show period values for both compared hist entries - showing hist columns HISTC_TOTAL_PERIOD and new stdio hist column HISTC_BASELINE_TOTAL_PERIOD. Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker

[PATCH 12/12] perf diff: Add -F option for ratio computation

2012-09-06 Thread Jiri Olsa
The -F option displays the formula for specified computation. Adding this support for weighted diff computation. Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Paul E. McKenney Cc: Andi Kleen Cc: David Ahern

[PATCH 09/12] perf diff: Add weighted diff computation way to compare hist entries

2012-09-06 Thread Jiri Olsa
Adding 'wdiff' as new computation way to compare hist entries. If specified the 'Weighted diff' column is displayed with value 'd' computed as: d = B->period * WEIGHT-A - A->period * WEIGHT-B - A/B being matching hist entry from first/second file specified (or perf.data/perf.data.old)

Re: Check all returns from audit_log_start

2012-09-06 Thread Dave Jones
On Thu, Sep 06, 2012 at 11:36:06AM -0400, Eric Paris wrote: > On Thu, Sep 6, 2012 at 11:08 AM, Dave Jones wrote: > > Following on from the previous patch that fixed an oops, these > > are all the other similar code patterns in the tree with the same > > checks added. I never saw these

Re: [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15

2012-09-06 Thread Doug Anderson
On Thu, Sep 6, 2012 at 8:21 AM, Daniel Kurtz wrote: > chained_irq_enter/exit() already mask/unmask the chained interrupt. > There is no need to also explicitly do it in the handler. > > Signed-off-by: Daniel Kurtz > --- > arch/arm/mach-exynos/common.c |7 --- > 1 files changed, 0

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Robert Richter
On 06.09.12 11:14:42, Steven Rostedt wrote: > On Thu, 2012-09-06 at 17:02 +0200, Robert Richter wrote: > > > > > --- a/arch/x86/oprofile/backtrace.c > > > > +++ b/arch/x86/oprofile/backtrace.c > > > > @@ -113,7 +113,7 @@ x86_backtrace(struct pt_regs * const regs, unsigned > > > > int depth) > >

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Robert Richter
On 06.09.12 17:34:07, Robert Richter wrote: > On 06.09.12 11:14:42, Steven Rostedt wrote: > > On Thu, 2012-09-06 at 17:02 +0200, Robert Richter wrote: > > > > > > > --- a/arch/x86/oprofile/backtrace.c > > > > > +++ b/arch/x86/oprofile/backtrace.c > > > > > @@ -113,7 +113,7 @@ x86_backtrace(struct

Re: A workaround for request_firmware() stuck in module_init

2012-09-06 Thread Ming Lei
On Thu, Sep 6, 2012 at 8:59 PM, Alan Cox wrote: >> Sorry, I don't see anyone explained clearly why request_firmware() >> can't be called inside module_init() in module case, so maybe it is >> a bit early to say it is a fix on 'bug', :-) > > Because the firmware load may trigger a need to load a

Re: Check all returns from audit_log_start

2012-09-06 Thread Eric Paris
On Thu, Sep 6, 2012 at 11:08 AM, Dave Jones wrote: > Following on from the previous patch that fixed an oops, these > are all the other similar code patterns in the tree with the same > checks added. I never saw these causing problems, but checking > this everywhere seems to make more sense than

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Vaibhav Hiremath
On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: > The mailbox register for usb otg in omap is present in control module. > On detection of any events VBUS or ID, this register should be written > to send the notification to musb core. > > Till we have a separate control module driver to

Re: 3.6-rc4 audit_log_d_path oops.

2012-09-06 Thread Eric Paris
On Thu, Sep 6, 2012 at 11:16 AM, Dave Jones wrote: > On Thu, Sep 06, 2012 at 09:46:28AM -0400, Dave Jones wrote: > > Hit this in overnight fuzz testing.. > > > > BUG: unable to handle kernel NULL pointer dereference at 0020 > > IP: [] audit_log_d_path+0x35/0xf0 > > PGD 12fded067

[PATCH 11/14] drivers/media/usb/stk1160/stk1160-i2c.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 10/14] drivers/media/i2c/mt9m032.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 9/14] drivers/media/radio/radio-cadet.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 6/14] drivers/media/pci/dm1105/dm1105.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 12/14] drivers/media/usb/tm6000/tm6000-video.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 13/14] drivers/media/usb/hdpvr/hdpvr-core.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 7/14] drivers/media/pci/ngene/ngene-core.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 5/14] drivers/media/pci/cx25821/cx25821-video-upstream.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 3/14] drivers/media/platform/blackfin/bfin_capture.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 1/14] drivers/media/platform/soc_camera/soc_camera.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 8/14] drivers/media/pci/ttpci/budget-av.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 14/14] drivers/media/usb/gspca/cpia1.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH 4/14] drivers/media/v4l2-core/videobuf2-core.c: fix error return code

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15

2012-09-06 Thread Daniel Kurtz
chained_irq_enter/exit() already mask/unmask the chained interrupt. There is no need to also explicitly do it in the handler. Signed-off-by: Daniel Kurtz --- arch/arm/mach-exynos/common.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git

Re: [PATCH tip/core/rcu 11/15] rcu: Avoid spurious RCU CPU stall warnings

2012-09-06 Thread Peter Zijlstra
On Thu, 2012-09-06 at 11:07 -0400, Steven Rostedt wrote: > On Thu, 2012-09-06 at 16:56 +0200, Peter Zijlstra wrote: > > On Thu, 2012-08-30 at 11:56 -0700, Paul E. McKenney wrote: > > > > > > If a given CPU avoids the idle loop but also avoids starting a new > > > RCU grace period for a full

[GIT PULL] hwmon fixes for 3.6-rc5

2012-09-06 Thread Guenter Roeck
Hi Linus, Please pull hwmon fixes for Linux 3.6-rc5 from signed tag: git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-for-linus There is only one patch in this pull request. While the changes are not in the drivers/hwmon directory, the problem primarily affects

Re: [PATCH 0/2] OMAP: hwmod: fix hardreset handling

2012-09-06 Thread Benoit Cousson
Hi Omar, On 09/03/2012 04:29 PM, Omar Ramirez Luna wrote: > On 22 August 2012 00:42, Omar Ramirez Luna wrote: >> From: Omar Ramirez Luna >> >> The patch to expose hwmod assert/deassert functions through omap_device >> has been accepted and queued for 3.7[1], however these two patches are >>

Re: 3.6-rc4 audit_log_d_path oops.

2012-09-06 Thread Dave Jones
On Thu, Sep 06, 2012 at 09:46:28AM -0400, Dave Jones wrote: > Hit this in overnight fuzz testing.. > > BUG: unable to handle kernel NULL pointer dereference at 0020 > IP: [] audit_log_d_path+0x35/0xf0 > PGD 12fded067 PUD 142c06067 PMD 0 > Oops: [#1] SMP > Modules linked

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 17:02 +0200, Robert Richter wrote: > > > --- a/arch/x86/oprofile/backtrace.c > > > +++ b/arch/x86/oprofile/backtrace.c > > > @@ -113,7 +113,7 @@ x86_backtrace(struct pt_regs * const regs, unsigned > > > int depth) > > > > > > if (!user_mode_vm(regs)) { > > >

Re: [PATCH tip/core/rcu 14/15] time: RCU permitted to stop idle entry via softirq

2012-09-06 Thread Peter Zijlstra
On Thu, 2012-08-30 at 11:56 -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > The can_stop_idle_tick() function complains if a softirq vector is > raised too late in the idle-entry process, presumably in order to > prevent dangling softirq invocations from being delayed across the >

[PATCH 3.6 2/2] target: use a bounce buffer in transport_kmap_data_sg for 0 or 1-page sglist

2012-09-06 Thread Paolo Bonzini
This patch started with the aim of fixing START STOP UNIT to a PSCSI device. Right now, commands with a zero-size payload are skipped completely. This is wrong; such commands should be passed down to the device and processed normally. As a hint of this, we have a hack to clear a unit attention

[PATCH 3.6 1/2] target: remove pscsi_clear_cdb_lun

2012-09-06 Thread Paolo Bonzini
The purpose of this function is to clear a LUN set in the CDB, in case the initiator talking to us is speaking an old standards version. However, as things stand, pscsi_clear_cdb_lun has two problems. It will "deceive" the guest by clearing the LUN bits on initial commands (INQUIRY, TEST UNIT

[PATCH 3.6 0/2] More PSCSI fixes

2012-09-06 Thread Paolo Bonzini
Hi all, here are two more fixes for SCSI passthrough. The first removes an (IMO) ill-conceived functionality and fixes passthrough of protection information. The second started as a fix for START STOP UNIT, and ended up as a more general change in transport_kmap_data_sg. Please review! Paolo

Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-06 Thread Benoit Cousson
Hi Omar, On 08/22/2012 07:42 AM, Omar Ramirez Luna wrote: > For a reset sequence to complete cleanly, a module needs its > associated clocks to be enabled, otherwise the timeout check > in prcm code can print a false failure (failed to hardreset) > that occurs because the clocks aren't powered ON

Re: [PATCH can-next v6] can: add tx/rx LED trigger support

2012-09-06 Thread Kurt Van Dijck
On Thu, Sep 06, 2012 at 01:17:39PM +0200, Fabio Baltieri wrote: > Hi Kurt, > > On Thu, Sep 6, 2012 at 12:33 PM, Kurt Van Dijck wrote: > > On Tue, Sep 04, 2012 at 10:15:53PM +0200, Fabio Baltieri wrote: > >> On Tue, Sep 04, 2012 at 09:11:28AM +0200, Kurt Van Dijck wrote: > > [...] > >> > > The

Re: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 07:55 -0700, Josh Triplett wrote: > > My solution to making 'break' work in the iterator is: > > > > for (bkt = 0, node = NULL; bkt < HASH_SIZE(name) && node == NULL; bkt++) > > hlist_for_each_entry(obj, node, [bkt], member) > > > > Looks reasonable.

Check all returns from audit_log_start

2012-09-06 Thread Dave Jones
Following on from the previous patch that fixed an oops, these are all the other similar code patterns in the tree with the same checks added. I never saw these causing problems, but checking this everywhere seems to make more sense than every subsequent routine that gets passed 'ab' having to

Re: [patch] da9052-battery: don't free IRQ that wasn't requested

2012-09-06 Thread Dan Carpenter
On Wed, Sep 05, 2012 at 04:11:01PM +0200, walter harms wrote: > > > Am 05.09.2012 14:34, schrieb Dan Carpenter: > > We should decrement "i" before doing the free_irq(). If we call this > > because request_threaded_irq() failed then we don't want to free the > > thing which failed. Or in the

Re: [PATCH tip/core/rcu 11/15] rcu: Avoid spurious RCU CPU stall warnings

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 16:56 +0200, Peter Zijlstra wrote: > On Thu, 2012-08-30 at 11:56 -0700, Paul E. McKenney wrote: > > > > If a given CPU avoids the idle loop but also avoids starting a new > > RCU grace period for a full minute, RCU can issue spurious RCU CPU > > stall warnings. This commit

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Robert Richter
On 06.09.12 09:14:42, Steven Rostedt wrote: > On Thu, 2012-09-06 at 12:04 +0200, Robert Richter wrote: > > > please take a look at this. Not sure if Linus want to look at this too > > and if we need more optimization here. > > It could probably go either way. Although the function has several >

Re: [RFC PATCH 2/5] arm: omap: remove ocp2scp_usb_phy_ick clock node

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, May 30, 2012 at 4:26 PM, Kishon Vijay Abraham I wrote: > "ocp2scp_usb_phy_ick" clock node was a fake clock node created > to control MODULEMODE of ocp2scp. Since the hwmod for ocp2scp is now added > (which can be used to control MODULEMODE) this clock node is removed. > > Cc: Benoit

Re: [PATCH] arm: omap: hwmod: make *phy_48m* as the main_clk of ocp2scp

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 2, 2012 at 2:25 PM, Kishon Vijay Abraham I wrote: > Made *ocp2scp_usb_phy_phy_48m* as the main_clk for ocp2scp. > Since this ocp2scp module does not have any fck but does have a > single opt_clock, it is added as the main_clk for ocp2scp. Also > removed phy_48m as the optional

[PATCH 3/3] usb: musb: omap: Add device tree support for omap musb glue

2012-09-06 Thread Kishon Vijay Abraham I
Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt | 33 drivers/usb/musb/omap2430.c| 54

[PATCH 0/5] usb: phy/otg: add dt support

2012-09-06 Thread Kishon Vijay Abraham I
This patch series adds device tree support for phy's (twl4030 and twl6030). A new omap-usb2 phy driver has been added (with only dt suppport) to perform phy configurations. Previously this configuration was performed by twl6030, using pdata function pointers. With the addition of omap-usb2 to

[PATCH 4/5] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-09-06 Thread Kishon Vijay Abraham I
Add device tree support for twl4030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 19 ++ drivers/usb/otg/twl4030-usb.c | 26

[PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Kishon Vijay Abraham I
The mailbox register for usb otg in omap is present in control module. On detection of any events VBUS or ID, this register should be written to send the notification to musb core. Till we have a separate control module driver to write to control module, omap2430 will handle the register writes

[PATCH 5/5] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-09-06 Thread Kishon Vijay Abraham I
All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap-usb2 phy driver. Cc: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/mach-omap2/omap_phy_internal.c | 138 ---

[PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-06 Thread Kishon Vijay Abraham I
All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related functionality like srp. This also includes device tree support for usb2 phy driver and the documentation with device tree binding information is

[PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-09-06 Thread Kishon Vijay Abraham I
All the PHY configuration other than VBUS, ID GND and OTG SRP are removed from twl6030. The phy configurations are taken care by the dedicated usb2 phy driver. So twl6030 is made as comparator driver for VBUS and ID detection. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/Kconfig

[PATCH 3/5] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-09-06 Thread Kishon Vijay Abraham I
Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 21 +++ drivers/usb/otg/twl6030-usb.c | 39

Re: [PATCH tip/core/rcu 11/15] rcu: Avoid spurious RCU CPU stall warnings

2012-09-06 Thread Peter Zijlstra
On Thu, 2012-08-30 at 11:56 -0700, Paul E. McKenney wrote: > > If a given CPU avoids the idle loop but also avoids starting a new > RCU grace period for a full minute, RCU can issue spurious RCU CPU > stall warnings. This commit fixes this issue by adding a check for > ongoing grace period to

[PATCH 2/3] usb: musb: omap: write directly to mailbox instead of using phy

2012-09-06 Thread Kishon Vijay Abraham I
The glue layer should directly write to mailbox register (present in control module) instead of calling phy layer to write to mailbox register. Writing to mailbox register notifies the core of events like device connect/disconnect. Currently writing to control module register is taken care in

Re: [PATCH tip/core/rcu 10/15] rcu: Protect rcu_node accesses during CPU stall warnings

2012-09-06 Thread Peter Zijlstra
On Thu, 2012-08-30 at 11:56 -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > The print_other_cpu_stall() function accesses a number of rcu_node > fields without protection from the ->lock. In theory, this is not > a problem because the fields accessed are all integers, but in >

[PATCH 1/2] ARM: tegra: fix return value for debugfs init

2012-09-06 Thread Peter De Schrijver
tegra_powergate_debugfs_init() always returns -ENOMEM. It shouldn't do that when registering the debugfs entry succeeded. Signed-off-by: Peter De Schrijver --- arch/arm/mach-tegra/powergate.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

[PATCH 2/2] ARM: tegra: fix debugfs entry for Tegra30

2012-09-06 Thread Peter De Schrijver
Tegra30 has more powerdomains than Tegra20. The debugfs code did not take this into account. Signed-off-by: Peter De Schrijver --- arch/arm/mach-tegra/powergate.c | 40 ++ 1 files changed, 35 insertions(+), 5 deletions(-) diff --git

[PATCH 0/3] omap: musb: Add device tree support

2012-09-06 Thread Kishon Vijay Abraham I
This patch series adds device tree support for MUSB. The glue layer is now made to write to mailbox register (present in control module) instead of calling phy layer to write to mailbox register. Writing to mailbox register notifies the core of events like device connect/disconnect. Previously

Re: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Josh Triplett
On Thu, Sep 06, 2012 at 03:53:58PM +0200, Sasha Levin wrote: > On 09/04/2012 07:01 PM, Mathieu Desnoyers wrote: > >> #define do_for_each_ftrace_rec(pg, rec) > >> \ > >> > for (pg = ftrace_pages_start, rec = >records[pg->index]; > >> >

Re: [PATCH 04/10] net/macb: Fix a race in macb_start_xmit()

2012-09-06 Thread Nicolas Ferre
On 09/05/2012 11:30 PM, David Miller : > From: Nicolas Ferre > Date: Wed, 5 Sep 2012 10:19:11 +0200 > >> From: Havard Skinnemoen >> >> Fix a race in macb_start_xmit() where we unconditionally set the TSTART bit. >> If an underrun just happened (we do this with interrupts disabled, so it >>

Re: [RFC,PATCH v2] efi: Add support for a UEFI variable filesystem

2012-09-06 Thread Matt Fleming
On Thu, 2012-09-06 at 22:37 +0800, Jeremy Kerr wrote: > That's correct, but we can't use unlink to delete a secure variable, we > need to do a write instead, in order to provide the authentication > descriptor. Ah, duh. Thanks for clearing that up. -- To unsubscribe from this list: send the

[PATCH] HID: picoLCD: Remove use of deprecated function

2012-09-06 Thread Emil Goode
The flush_delayed_work_sync function is deprecated, we can instead call flush_delayed_work directly. Sparse is giving a warning: drivers/hid/hid-picolcd_fb.c:611:2: warning: ‘flush_delayed_work_sync’ is deprecated (declared at include/linux/workqueue.h:454)

Re: [PATCH] Add feature-removal-schedule.txt removal to feature-removal-schedule.txt

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 22:29 +0800, Cong Wang wrote: > I don't think feature-removal-schedule.txt is for kernel users, it > is a kind of a TODO list for kernel developers. And this is exactly what Linus was complaining about. It shouldn't be used as a TODO list for developers. -- Steve -- To

Re: [PATCH tip/core/rcu 03/15] rcu: Properly initialize ->boost_tasks on CPU offline

2012-09-06 Thread Peter Zijlstra
On Thu, 2012-08-30 at 11:56 -0700, Paul E. McKenney wrote: > When rcu_preempt_offline_tasks() clears tasks from a leaf rcu_node > structure, it does not NULL out the structure's ->boost_tasks field. > This commit therefore fixes this issue. What would have been the side-effects of this? Would

Re: snd-usb: "delay: estimated 0, actual 352"

2012-09-06 Thread Daniel Mack
On 06.09.2012 16:31, Takashi Iwai wrote: > At Thu, 6 Sep 2012 15:17:58 +0200, > Markus Trippelsdorf wrote: >> >> On 2012.09.06 at 15:08 +0200, Takashi Iwai wrote: >>> At Thu, 6 Sep 2012 11:43:48 +0200, >>> Markus Trippelsdorf wrote: On 2012.09.06 at 10:21 +0200, Takashi Iwai wrote: >

Re: [PATCH tip/core/rcu 01/15] rcu: Add PROVE_RCU_DELAY to provoke difficult races

2012-09-06 Thread Peter Zijlstra
On Thu, 2012-08-30 at 11:56 -0700, Paul E. McKenney wrote: > +#ifdef CONFIG_PROVE_RCU_DELAY > + udelay(10); /* Make preemption more probable. */ cond_resched(); /* for extra fun? */ > +#endif /* #ifdef CONFIG_PROVE_RCU_DELAY */ -- To unsubscribe from this list:

RE: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread David Laight
> My solution to making 'break' work in the iterator is: > > for (bkt = 0, node = NULL; bkt < HASH_SIZE(name) && node == NULL; bkt++) > hlist_for_each_entry(obj, node, [bkt], member) I'd take a look at the generated code. Might come out a bit better if the condition is

Re: [PATCH tip/core/rcu 23/23] rcu: Simplify quiescent-state detection

2012-09-06 Thread Peter Zijlstra
On Thu, 2012-08-30 at 11:18 -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > The current quiescent-state detection algorithm is needlessly > complex. Heh! Be careful, we might be led into believing all this RCU is actually really rather simple and this complexity is a bug on your

Re: [RFC,PATCH v2] efi: Add support for a UEFI variable filesystem

2012-09-06 Thread Jeremy Kerr
Hi Matt, I think this is the problematic chunk of code, static int efivars_unlink(struct inode *dir, struct dentry *dentry) { struct efivar_entry *var = dentry->d_inode->i_private; struct efivars *efivars = var->efivars; efi_status_t status;

[PATCH 2/2] serial: mxs-auart: put the device in mxs_auart_probe()

2012-09-06 Thread Huang Shijie
We call the get_device() in the mxs_auart_probe(). For the balance of the reference count, we should put the device in the mxs_auart_remove(). Signed-off-by: Huang Shijie --- drivers/tty/serial/mxs-auart.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[PATCH 1/2] serial: mxs-auart: fix the wrong setting order

2012-09-06 Thread Huang Shijie
After set the AUART_CTRL0_CLKGATE, the UART will gate all the clocks off. So the following line will not take effect. writel(AUART_INTR_RXIEN | AUART_INTR_RTIEN | AUART_INTR_CTSMIEN, u->membase

Re: [PATCH v2 09/10] net/macb: ethtool interface: add register dump feature

2012-09-06 Thread Ben Hutchings
On Thu, 2012-09-06 at 16:20 +0200, Nicolas Ferre wrote: > Add macb_get_regs() ethtool function and its helper function: > macb_get_regs_len(). > The version field is deduced from the IP revision which gives the > "MACB or GEM" information. An additional version field is reserved. > >

Re: [PATCH] x86, efi: 1:1 pagetable mapping for virtual EFI calls

2012-09-06 Thread Jan Beulich
>>> On 06.09.12 at 15:15, Matt Fleming wrote: > From: Matt Fleming > > Some firmware still needs a 1:1 (virt->phys) mapping even after we've > called SetVirtualAddressMap(). So install the mapping alongside our > existing kernel mapping whenever we make EFI calls in virtual mode. > > This bug

Re: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Mathieu Desnoyers
* Sasha Levin (levinsasha...@gmail.com) wrote: > On 09/04/2012 07:01 PM, Mathieu Desnoyers wrote: > >> #define do_for_each_ftrace_rec(pg, rec) > >> \ > >> > for (pg = ftrace_pages_start, rec = >records[pg->index]; > >> > \ > >> >

Re: drm/vmwgfx: add MODULE_DEVICE_TABLE so vmwgfx loads at boot

2012-09-06 Thread Jakob Bornecrantz
On Thu, Sep 6, 2012 at 3:35 PM, Tim Gardner wrote: > Dave - I couldn't find this patch in your git repo at > git://people.freedesktop.org/~airlied/linux in the drm-next or drm-fixes > branches. > > https://patchwork.kernel.org/patch/1379071/ > > It appears to fix a real problem for Mac users - >

Re: snd-usb: "delay: estimated 0, actual 352"

2012-09-06 Thread Takashi Iwai
At Thu, 6 Sep 2012 15:17:58 +0200, Markus Trippelsdorf wrote: > > On 2012.09.06 at 15:08 +0200, Takashi Iwai wrote: > > At Thu, 6 Sep 2012 11:43:48 +0200, > > Markus Trippelsdorf wrote: > > > > > > On 2012.09.06 at 10:21 +0200, Takashi Iwai wrote: > > > > At Thu, 06 Sep 2012 09:35:26 +0200, > >

Re: [RFC,PATCH v2] efi: Add support for a UEFI variable filesystem

2012-09-06 Thread Matt Fleming
(Cc'ing Peter Jones who wrote a auth deletion patch for efivars) On Thu, 2012-09-06 at 22:23 +0800, Jeremy Kerr wrote: > Hi Matt, > > > Am I correct in thinking that this filesystem doesn't handle deletion of > > authenticated variables? > > Unless I'm missing something, this should work fine;

Re: [PATCH tip/core/rcu 17/23] rcu: Fix day-zero grace-period initialization/cleanup race

2012-09-06 Thread Peter Zijlstra
On Thu, 2012-08-30 at 11:18 -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > The current approach to grace-period initialization is vulnerable to > extremely low-probabity races. These races stem fro the fact that the > old grace period is marked completed on the same traversal

Re: [PATCH] Add feature-removal-schedule.txt removal to feature-removal-schedule.txt

2012-09-06 Thread Cong Wang
On Tue, Sep 4, 2012 at 11:39 PM, Steven Rostedt wrote: > On Wed, 2012-08-29 at 09:28 +0800, Cong Wang wrote: >> On Tue, Aug 28, 2012 at 2:22 AM, Steven Rostedt wrote: >> > The file feature-removal-schedule.txt is ignored by most people except >> > for people that add to it. It's more of a global

Re: [PATCH tip/core/rcu 18/23] rcu: Add random PROVE_RCU_DELAY to grace-period initialization

2012-09-06 Thread Peter Zijlstra
On Thu, 2012-08-30 at 11:18 -0700, Paul E. McKenney wrote: > > 1. CPU 0 completes a grace period, but needs an additional > grace period, so starts initializing one, initializing all > the non-leaf rcu_node strcutures and the first leaf rcu_node > structure. Because

Re: [RFC,PATCH v2] efi: Add support for a UEFI variable filesystem

2012-09-06 Thread Jeremy Kerr
Hi Matt, Am I correct in thinking that this filesystem doesn't handle deletion of authenticated variables? Unless I'm missing something, this should work fine; we just pass the EFI_VARIABLE_AUTHENTICATION_2 descriptor (with the usual attribute header), but no data following the descriptor.

Re: [PATCH 1/1] [SCSI] scsi_debug: Add "removable" parameter

2012-09-06 Thread Douglas Gilbert
On 12-09-06 06:04 AM, Martin Pitt wrote: Add "removable" module parameter to set the "removable" attribute of any subsequently created debug block device. It is a writable driver option, so that you can switch between removable and "fixed" media block devices in between the add_host calls. This

Re: [PATCH tip/core/rcu 16/23] rcu: Prevent initialization-time quiescent-state race

2012-09-06 Thread Peter Zijlstra
On Wed, 2012-09-05 at 11:19 -0700, Paul E. McKenney wrote: > I tried that, and got a surprisingly large set of conflicts. Ah, OK, > the problem is that breaking up rcu_gp_kthread() into subfunctions > did enough code motion to defeat straightforward rebasing. Is there > some way to tell "git

Re: [PATCH] UDF: Fix incorrect error handling in udf_direct_IO()

2012-09-06 Thread Jan Kara
On Thu 06-09-12 11:08:11, Ian Abbott wrote: > My recent patch to add DIRECT_IO support to the UDF filesystem handler > contains a mistake in the error recovery if blockdev_direct_IO() fails. > The test `rw && WRITE` should be `rw & WRITE`. Fix it. > > Signed-off-by: Ian Abbott Thanks. I've

[PATCH v2 09/10] net/macb: ethtool interface: add register dump feature

2012-09-06 Thread Nicolas Ferre
Add macb_get_regs() ethtool function and its helper function: macb_get_regs_len(). The version field is deduced from the IP revision which gives the "MACB or GEM" information. An additional version field is reserved. Signed-off-by: Nicolas Ferre --- v2: - modify MACB_GREGS_NBR name and adapt to

<    1   2   3   4   5   6   7   8   9   10   >