Re: [PATCH] Update sched_domains_numa_masks when new cpus are onlined.

2012-09-23 Thread Tang Chen
Hi, Would you please help to review this patch ? Thanks. :) On 09/18/2012 06:12 PM, Tang Chen wrote: Once array sched_domains_numa_masks is defined, it is never updated. When a new cpu on a new node is onlined, the coincident member in sched_domains_numa_masks is not initialized, and all the

RE: [PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer

2012-09-23 Thread AnilKumar, Chimata
Hi Eric, Thanks for the comments, On Mon, Sep 24, 2012 at 03:08:19, Éric Piel wrote: > On 22-08-12 08:30, AnilKumar Ch wrote: > > This patch adds support for lis331dlh digital accelerometer to the > > lis3lv02d driver family. Adds ID field for detecting the lis331dlh > > module, based on this ID

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-23 Thread James Bottomley
On Mon, 2012-09-24 at 13:30 +0800, Li Zhong wrote: > Just noticed that after commit 919f797, it is possible that > scsi_cmd_to_driver() returns NULL. This patch adds the NULL checking for drv > returned from the above function. > > Maybe it is not possible at run time, but from the code

Re: performance degradation on kernel upgrade (due to commit ab0a9735e06914ce4d2a94ffa41497dbc142fe7f)

2012-09-23 Thread Jagdish Motwani
On 09/21/2012 07:55 PM, Andres Freund wrote: Hi, On Friday, September 21, 2012 03:47:56 PM Jagdish Motwani wrote: Recently i upgraded my kernel from 2.6.29.6 to 2.6.35.14. After upgrading i got very poor performance on my postgre database. My test.sql contains 1 postgre insert query

[PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-23 Thread Li Zhong
Just noticed that after commit 919f797, it is possible that scsi_cmd_to_driver() returns NULL. This patch adds the NULL checking for drv returned from the above function. Maybe it is not possible at run time, but from the code itself, we'd better have this check? This patch actually is a

linux-next: manual merge of the edac tree with Linus' tree

2012-09-23 Thread Stephen Rothwell
Hi Mauro, Today's linux-next merge of the edac tree got a conflict in drivers/edac/edac_mc.c between commit faa2ad09c01c ("edac_mc: edac_mc_free() cannot assume mem_ctl_info is registered in sysfs") from Linus' tree and commit 12c3ab9422cc ("edac: edac_mc_free() cannot assume mem_ctl_info is

Re: [PATCH 10/11] userns: Convert the udf filesystem to use kuid/kgid where appropriate

2012-09-23 Thread Jan Kara
On Fri 21-09-12 18:35:11, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > Cc: Jan Kara > Acked-by: Serge Hallyn > Signed-off-by: Eric W. Biederman The patch looks good. You can add: Acked-by: Jan Kara Honza > --- >

Re: [2.6.38-3.x] [BUG] soft lockup - CPU#X stuck for 23s! (vfs, autofs, vserver)

2012-09-23 Thread Paweł Sikora
On Sunday 23 of September 2012 18:10:30 Linus Torvalds wrote: > On Sat, Sep 22, 2012 at 11:09 PM, Paweł Sikora wrote: > > > > br_read_lock(vfsmount_lock); > > The vfsmount_lock is a "local-global" lock, where a read-lock is > rather cheap and takes just a per-cpu lock, but the downside

Re: Conditional Unlink

2012-09-23 Thread NeilBrown
On Fri, 21 Sep 2012 10:32:36 -0700 "Fox, Kevin M" wrote: > Quick question: > Is there a syscall or some algorithm that would allow an unlink that would > only happen if no writes to the file have occurred between a stat and an > unlink, race free? > > Background: > I'm writing a program that

Re: [PATCH v3 1/7] KVM: MMU: fix release noslot pfn

2012-09-23 Thread Xiao Guangrong
On 09/23/2012 05:13 PM, Gleb Natapov wrote: > On Fri, Sep 21, 2012 at 02:57:19PM +0800, Xiao Guangrong wrote: >> We can not directly call kvm_release_pfn_clean to release the pfn >> since we can meet noslot pfn which is used to cache mmio info into >> spte >> > Wouldn't it be better to move the

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-23 Thread Namjae Jeon
2012/9/24, OGAWA Hirofumi : > Namjae Jeon writes: > >>> I think we don't need this. Because FH and ino is not necessary to have >>> relation. >>> >>> Can we re-introduce ->encode_fh() handler, and export i_pos again? With >>> this, I think we can get i_pos correctly. Otherwise, ino may not

[PATCH] block: makes bio_split support bio without data

2012-09-23 Thread NeilBrown
Hi Jens, this patch has been sitting in my -next tree for a little while and I was hoping for it to go in for the next merge window. It simply allows bio_split() to be used on bios without a payload, such as 'discard'. Are you happy with it going in though my 'md' tree, or would you rather

RE: gpmc_cs_request() causes early boot hang

2012-09-23 Thread Mohammed, Afzal
Hi Mark, On Sat, Sep 22, 2012 at 00:57:38, Mark Jackson wrote: > I'm developing a beaglebone cape board which requires the use of a GPMC > chip select. > > I've chosen GPMC_CS0, and in board-am335xevm.c, I have added the following:- > > static void gpmc_test() > { > unsigned long base =

Re: [PATCH 00/14] Media Controller capture driver for DM365

2012-09-23 Thread Prabhakar Lad
Hi Sakari, On Sun, Sep 23, 2012 at 8:46 PM, Sakari Ailus wrote: > Hi Prabhakar, > > > Prabhakar Lad wrote: >> >> From: Lad, Prabhakar >> >> This patch set adds media controller based capture driver for >> DM365. > > > Thanks for the set. Do you happen to have an updated version of the same >

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-23 Thread OGAWA Hirofumi
Namjae Jeon writes: >> I think we don't need this. Because FH and ino is not necessary to have >> relation. >> >> Can we re-introduce ->encode_fh() handler, and export i_pos again? With >> this, I think we can get i_pos correctly. Otherwise, ino may not contain >> all bits of i_pos. > I already

Btrfs: check range early in map_private_extent_buffer

2012-09-23 Thread Wang Sheng-Hui
Check range early to avoid further check/compute in case of range error. Signed-off-by: Wang Sheng-Hui --- fs/btrfs/extent_io.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 4c87847..9250cf5 100644 ---

Re: [RFC v4 Patch 0/4] fs/inode.c: optimization for inode lock usage

2012-09-23 Thread Dave Chinner
On Mon, Sep 24, 2012 at 10:42:21AM +0800, Guo Chao wrote: > On Sat, Sep 22, 2012 at 08:49:12AM +1000, Dave Chinner wrote: > > > On Fri, Sep 21, 2012 at 05:31:02PM +0800, Guo Chao wrote: > > > This patchset optimizes several places which take the per inode spin lock. > > > They have not been fully

Re: [PATCH v3 4/5] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-09-23 Thread Namjae Jeon
2012/9/22, OGAWA Hirofumi : > Namjae Jeon writes: > >> From: Namjae Jeon >> >> This patch enables rebuilding of directory inodes which are not present >> in the cache.This is done by traversing the disk clusters to find the >> directory entry of the parent directory and using its i_pos to build

Re: [PATCH v3 3/5] fat (exportfs): rebuild inode if ilookup() fails

2012-09-23 Thread Namjae Jeon
2012/9/22, OGAWA Hirofumi : > Namjae Jeon writes: > >> +if (inode == NULL && MSDOS_SB(sb)->options.nfs == FAT_NFS_LIMITED) { >> +struct buffer_head *bh = NULL; >> +struct msdos_dir_entry *de ; >> +loff_t i_pos = (loff_t)ino; >> +int bits =

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-23 Thread Namjae Jeon
2012/9/22, OGAWA Hirofumi : > Namjae Jeon writes: > >> -inode->i_ino = iunique(sb, MSDOS_ROOT_INO); >> +if (MSDOS_SB(sb)->options.nfs == FAT_NFS_LIMITED) >> +inode->i_ino = i_pos; >> +else >> +inode->i_ino = iunique(sb, MSDOS_ROOT_INO); >> inode->i_version

[PATCH] ahci: add a boot option to enable promise ahci

2012-09-23 Thread Tony Hung - PTT 洪瑞嶸
linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback': Use min_t(size_t, ...) to fix. Signed-off-by: Tony Hung --- diff --git a/linux-3.2.0/drivers/ata/ahci.c b/linux-3.2.0/drivers/ata/ahci.c --- a/linux-3.2.0/drivers/ata/ahci.c2012-08-29 13:40:26.046851693 +0800 +++

Re: [PATCH v3 1/5] fat: modify nfs mount option

2012-09-23 Thread Namjae Jeon
2012/9/22, OGAWA Hirofumi : > Namjae Jeon writes: > >> +case Opt_nfs_full: >> +opts->nfs = FAT_NFS_FULL; >> +break; >> +case Opt_nfs_limited: >> +opts->nfs = FAT_NFS_LIMITED; >> +sb->s_flags |=

linux-next: build failure after merge of the sound and sound-asoc trees

2012-09-23 Thread Stephen Rothwell
Hi all, After merging the sound tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from include/linux/skbuff.h:31:0, from include/linux/if_ether.h:135, from include/linux/netdevice.h:29, from

linux-next: build failure after merge of the drm tree

2012-09-23 Thread Stephen Rothwell
Hi Dave, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/intel_hdmi.c: In function 'intel_enable_hdmi': drivers/gpu/drm/i915/intel_hdmi.c:633:31: error: 'mode' undeclared (first use in this function) Caused by commit

[PATCH] ARM: gic: fix irq affinity mismatch.

2012-09-23 Thread Chanho Min
Even if we set affinity to multiple cpus via procfs, gic_set_affinity allows to set one target only. But, '/proc/irq/xxx/smp_affinity' shows as we are successful in the setting of multiple affinity. Thus irq_data-> affinity mismatches with the GICD_ITARGETSRs. fix it as bellows. - Set the default

[GIT PULL] Ceph fixes for 3.6

2012-09-23 Thread Sage Weil
Hi Linus, Please pull the following fixes for Ceph from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus The first fixes a leak in the rbd setup error path, and the second fixes a more serious problem with mismatched kmap/kunmap that surfaced after the recent

RE: [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common

2012-09-23 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:34, Porter, Matt wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx atm) as well. This just moves > the private EDMA API but does not support OMAP. > > Signed-off-by: Matt Porter > --- > arch/arm/Kconfig

Re: [RFC v4 Patch 0/4] fs/inode.c: optimization for inode lock usage

2012-09-23 Thread Guo Chao
On Sat, Sep 22, 2012 at 08:49:12AM +1000, Dave Chinner wrote: > On Fri, Sep 21, 2012 at 05:31:02PM +0800, Guo Chao wrote: > > This patchset optimizes several places which take the per inode spin lock. > > They have not been fully tested yet, thus they are marked as RFC. > > Inodes are RCU

Re: [PATCH 05/14] userns: Convert hostfs to use kuid and kgid where appropriate

2012-09-23 Thread Eric W. Biederman
Richard Weinberger writes: > Am 21.09.2012 02:28, schrieb Eric W. Biederman: >> From: "Eric W. Biederman" >> >> Cc: Jeff Dike >> Cc: Richard Weinberger >> Acked-by: Serge Hallyn >> Signed-off-by: Eric W. Biederman >> --- > > Looks sane to me. > > Acked-by: Richard Weinberger > > BTW: How

Re: [PATCH 1/1] drivers/char/tpm: remove tasklet and cleanup

2012-09-23 Thread James Morris
On Wed, 12 Sep 2012, Ashley Lai wrote: > This patch removed the tasklet and moved the wait queue into the > private structure. It also cleaned up the response CRQ path. > > Signed-off-by: Ashley Lai Kent: any comment on this? You should probably push this to me via your tree. > --- >

[PATCH]scripts:kconfig:meconf: Add Save button to save config at anytime

2012-09-23 Thread Wang YanQing
mconf make me annoying I have to make menuconfig && exit to save the config when I am tuning .config time by time, it is even worse I have to search down to my desire submenu time by time. So I add "Save" button to save our time. With "Save" button, I can use CRTL-Z after save config, and then use

Re: [PATCH v4] create sun sysfs file

2012-09-23 Thread Yasuaki Ishimatsu
Hi Len, Ping... I want you to merge the patch into your tree for linux-3.7. Thanks, Yasuaki Ishimatsu 2012/08/30 10:34, Yasuaki Ishimatsu wrote: > Hi Len, > > Three weeks passed after I post the patch. > All comments have already been applied to it. And I think there is no > comments about it.

[PATCH] Thermal: Fix bug on generic thermal framework.

2012-09-23 Thread Jonghwa Lee
When system fails to bind cooling devices to thermal zone device during registering thermal zone device, it leaves registering without canceling delayed work. It probably makes panic if polling rate is not enough to release that work from workqueue. So it is better to ignore initialization of

Re: Linux 3.6-rc7

2012-09-23 Thread Stephen Rothwell
On Sun, 23 Sep 2012 18:51:04 -0700 Linus Torvalds wrote: > > Ho humm. I really *really* want to say that this is the last -rc, but > we do have a few small things pending still. So who knows. There may > be a -rc8, we'll just have to see. And this means that *everything* destined for the merge

Linux 3.6-rc7

2012-09-23 Thread Linus Torvalds
Ho humm. I really *really* want to say that this is the last -rc, but we do have a few small things pending still. So who knows. There may be a -rc8, we'll just have to see. That said, nothing here looks really bad. You can get a fairly good feel for the flavor of fixes form the appended

linux-next: manual merge of the vfs tree with Linus' tree

2012-09-23 Thread Stephen Rothwell
Hi Al, Today's linux-next merge of the vfs tree got a conflict in fs/stat.c between commit 55815f70147d ("vfs: make O_PATH file descriptors usable for 'fstat()'") from Linus' tree and commit 19ba95358327 ("switch simple cases of fget_light to fdget") from the vfs tree. I just used the vfs tree

linux-next: manual merge of the vfs tree with the tree

2012-09-23 Thread Stephen Rothwell
Hi Al, Today's linux-next merge of the vfs tree got a conflict in kernel/events/core.c between commit a6fa941d94b4 ("perf_event: Switch to internal refcount, fix race with close()") from Linus' and the vfs trees and commit 19ba95358327 ("switch simple cases of fget_light to fdget") from the vfs

Re: [PATCH] x86: Distinguish TLB shootdown interrupts from other functions call interrupts

2012-09-23 Thread Alex Shi
On 09/20/2012 04:50 PM, Tomoki Sekiyama wrote: > unsigned int irq_resched_count; > unsigned int irq_call_count; > + /* irq_tlb_count is double-counted in irq_call_count, so it must be > +subtracted from irq_call_count when displaying irq_call_count */ > unsigned int

Re: [2.6.38-3.x] [BUG] soft lockup - CPU#X stuck for 23s! (vfs, autofs, vserver)

2012-09-23 Thread Linus Torvalds
On Sat, Sep 22, 2012 at 11:09 PM, Paweł Sikora wrote: > > br_read_lock(vfsmount_lock); The vfsmount_lock is a "local-global" lock, where a read-lock is rather cheap and takes just a per-cpu lock, but the downside is that a write-lock is *very* expensive, and can cause serious trouble.

Re: [PATCH] leds: lm3642: Use regmap_update_bits() in lm3642_chip_init()

2012-09-23 Thread gshark
2012년 09월 22일 15:40, Axel Lin 쓴 글: Use regmap_update_bits() to replace regmap_read() + regmap_write(). With this patch, we only show the error message when regmap_update_bits() fails. Looks good..You're right. Thank you Alex. Signed-off-by: Axel Lin Acked-by: G.Shark Jeong ---

[PATCH v4] KSM: numa awareness sysfs knob

2012-09-23 Thread Petr Holasek
Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_across_nodes which control merging pages across different numa nodes. When it is set to zero only pages from the same node are merged, otherwise pages from all nodes can be merged together (default behavior). Typical use-case could be a

Re: [PATCH 0/2] struct pid-ify autofs4

2012-09-23 Thread Ian Kent
On Fri, 2012-09-21 at 17:44 +0200, Miklos Szeredi wrote: > Miklos Szeredi writes: > > > These two patches change autofs4 to store struct pid pointers instead of > > pid_t > > values. > > > > Fixed various issues with the previous post. Not tested, handle with > > care! > > Customer gave

Re: cifs: fix return value in cifsConvertToUTF16

2012-09-23 Thread Jeff Layton
On Sun, 23 Sep 2012 23:18:19 +0100 Anton Altaparmakov wrote: > Hi Steve, > > Hey, I sent you that exact same patch on the 12th June! Would have saved you > and others some valuable time if you hadn't ignored it then! (-; > > Told you it was an obvious logic bug! (-; > > Best regards, > >

Re: cifs: fix return value in cifsConvertToUTF16

2012-09-23 Thread Steve French
You are right - this should have gone in 3.5. Please remind me if you see an important patch not make linux-next (or equivalently the cifs-2.6.git for-next branch). I get a big volume of email. On Sun, Sep 23, 2012 at 5:18 PM, Anton Altaparmakov wrote: > Hi Steve, > > Hey, I sent you that

Re: Linux 3.6-rc6

2012-09-23 Thread Notifications
Works fine on my (localized) desktop, except with bootparameter "threadirqs" which has not been working since it was introduced. Jitterlevels are very low now, regular os-jitter is typically below 1 ms. (with a low jitter config) Which means audioapps run 1 ms latency, without rt-threads,

Re: cifs: fix return value in cifsConvertToUTF16

2012-09-23 Thread Anton Altaparmakov
Hi Steve, Hey, I sent you that exact same patch on the 12th June! Would have saved you and others some valuable time if you hadn't ignored it then! (-; Told you it was an obvious logic bug! (-; Best regards, Anton On 22 Sep 2012, at 21:28, Linux Kernel Mailing List wrote: >

[GIT] kbuild rc fixes

2012-09-23 Thread Michal Marek
Hi Linus, there are two more kbuild fixes for 3.6. One fixes a race between x86's archscripts target and the rule (re)building scripts/basic/fixdep. The second is a fix for the previous attempt at fixing make firmware_install with make 3.82. This new solution should work with any version of GNU

Re: [PATCH 05/14] userns: Convert hostfs to use kuid and kgid where appropriate

2012-09-23 Thread Richard Weinberger
Am 21.09.2012 02:28, schrieb Eric W. Biederman: > From: "Eric W. Biederman" > > Cc: Jeff Dike > Cc: Richard Weinberger > Acked-by: Serge Hallyn > Signed-off-by: Eric W. Biederman > --- Looks sane to me. Acked-by: Richard Weinberger BTW: How you do test your user namespace patches? Is

[PATCH v2 1/1] perf stat: implement --big-num grouping

2012-09-23 Thread Irina Tirdea
From: Irina Tirdea In glibc, printf supports ' to group numbers with thousands' grouping characters. Bionic does not support ' for printf. Implement thousands's grouping for numbers according to locale. The implementation uses the algorithm from glibc (http://www.gnu.org/software/libc/).

Re: [PATCH 6/7][RFC] netfilter: xt_IDLETIMER: Add new netlink msg type

2012-09-23 Thread Pablo Neira Ayuso
On Fri, Sep 21, 2012 at 10:10:52PM -0400, John Stultz wrote: > From: JP Abgrall > > Send notifications when the label becomes active after an idle period. > Send netlink message notifications in addition to sysfs notifications. > Using a uevent with > subsystem=xt_idletimer > INTERFACE=... >

Re: [PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer

2012-09-23 Thread Éric Piel
On 22-08-12 08:30, AnilKumar Ch wrote: This patch adds support for lis331dlh digital accelerometer to the lis3lv02d driver family. Adds ID field for detecting the lis331dlh module, based on this ID field lis3lv02d driver will export the lis331dlh module functionality. Hello AnilKumar, Sorry

Re: Fwd: [PATCH 1/14] drivers/media/platform/soc_camera/soc_camera.c: fix error return code

2012-09-23 Thread Guennadi Liakhovetski
Hi Mauro, Peter On Sun, 23 Sep 2012, Mauro Carvalho Chehab wrote: > Please review. > Please review. > > Regards, > Mauro. > > Mensagem original > Assunto: [PATCH 1/14] drivers/media/platform/soc_camera/soc_camera.c: fix > error return code > Data: Thu, 6 Sep 2012 17:24:00

Re: [PATCH 2/7][RFC] netfilter: add xt_qtaguid matching module

2012-09-23 Thread Pablo Neira Ayuso
Hi John, Cc'ing netfilter-devel (better than only netdev, to attract the attention from other Netfilter hacker fellows). Some comments on this: On Fri, Sep 21, 2012 at 10:10:48PM -0400, John Stultz wrote: > From: JP Abgrall > > This module allows tracking stats at the socket level for given

Re: Fwd: [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code

2012-09-23 Thread Guennadi Liakhovetski
Hi Peter Thanks for the patch, but I think it can be improved: On Sun, 23 Sep 2012, Mauro Carvalho Chehab wrote: > Please review, > > Regards, > Mauro. > > > Mensagem original > Assunto: [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix > error return code >

Re: [PATCH v2] leds: add led_trigger_rename function

2012-09-23 Thread Fabio Baltieri
Hello Bryan, On Sat, Sep 15, 2012 at 06:18:44PM +0200, Fabio Baltieri wrote: > Implements a "led_trigger_rename" function to rename a trigger with > proper locking. > > This assumes that led name was originally allocated in non-constant > storage. Did you have any chance to review this patch?

Re: kexec/kdump kernel fails to start

2012-09-23 Thread Yinghai Lu
On Sun, Sep 23, 2012 at 1:27 PM, Dan Carpenter wrote: > On Wed, Sep 05, 2012 at 11:34:25PM +0800, Cong Wang wrote: >> On Wed, Sep 5, 2012 at 1:32 AM, Flavio Leitner wrote: >> > Hi folks, >> > >> > I have system that no longer boots kdump kernel. Basically, >> > >> > # echo c >

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-23 Thread Konrad Rzeszutek Wilk
On Fri, Sep 21, 2012 at 11:27:00AM -0700, Yinghai Lu wrote: > On Fri, Sep 21, 2012 at 9:50 AM, Konrad Rzeszutek Wilk > wrote: > > On Wed, Sep 19, 2012 at 10:49:00AM -0700, Yinghai Lu wrote: > > > > Can you include the stack trace? > > [ 414.997281] pci_bus :00: freeing pci_bus info > [

Re: [PATCH] drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c: Replace kmemdup for kstrdup

2012-09-23 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2012 14:45:54 +0200 Peter Senna Tschudin escreveu: > From: Peter Senna Tschudin > > Replace kmemdup for kstrdup and cleaning up the code. > > Signed-off-by: Peter Senna Tschudin Maintainers/interested parties not copied. Also: Hunk #1 succeeded at 708 (offset 1 line). Hunk

Re: kexec/kdump kernel fails to start

2012-09-23 Thread Dan Carpenter
On Wed, Sep 05, 2012 at 11:34:25PM +0800, Cong Wang wrote: > On Wed, Sep 5, 2012 at 1:32 AM, Flavio Leitner wrote: > > Hi folks, > > > > I have system that no longer boots kdump kernel. Basically, > > > > # echo c > /proc/sysrq-trigger > > > > to dump a vmcore doesn't work. It just hangs after

[PATCH 2/4] uprobes: Introduce copy_opcode(), kill read_opcode()

2012-09-23 Thread Oleg Nesterov
No functional changes, preparations. 1. Extract the kmap-and-memcpy code from read_opcode() into the new trivial helper, copy_opcode(). The next patch will add another user. 2. read_opcode() becomes really trivial, fold it into its single caller, is_swbp_at_addr(). 3. Remove "auprobe"

Re: WARNING: at block/genhd.c:1570 disk_clear_events+0xbf/0xd0()

2012-09-23 Thread Dan Carpenter
Hi, I have created a bug for this: https://bugzilla.kernel.org/show_bug.cgi?id=47871 Please add the following information: *) Last known good kernel version *) Current broken kernel version *) Complete dmesg regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 0/4] uprobes: remove is_swbp_at_addr() from register/unregister

2012-09-23 Thread Oleg Nesterov
Hello. 1. the usage of is_swbp_at_addr() is confusing. This series tries to answer the questions we got during the discussion about powerpc port which has multiple trap insns. Ananth, please review too ;) at least the changelog in 1/4. Note: the changelog doesn't mention

[PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at_addr()

2012-09-23 Thread Oleg Nesterov
Unlike set_swbp(), set_orig_insn()->is_swbp_at_addr() makes sense, although it can't prevent all confusions. But the usage of is_swbp_at_addr() is equally confusing, and it adds the extra get_user_pages() we can avoid. This patch removes set_orig_insn()->is_swbp_at_addr() but changes

[PATCH 4/4] uprobes: Simplify is_swbp_at_addr(), remove stale comments

2012-09-23 Thread Oleg Nesterov
After the previous change is_swbp_at_addr() is always called with current->mm. Remove this check and move it close to its single caller. Also, remove the obsolete comment about is_swbp_at_addr() and uprobe_state.count. Signed-off-by: Oleg Nesterov --- kernel/events/uprobes.c | 73

[PATCH 1/4] uprobes: Kill set_swbp()->is_swbp_at_addr()

2012-09-23 Thread Oleg Nesterov
A separate patch for better documentation. set_swbp()->is_swbp_at_addr() is not needed for correctness, it is harmless to do the unnecessary __replace_page(old_page, new_page) when these 2 pages are identical. And it can not be counted as optimization. mmap/register races are very unlikely,

Re: [PATCH 3/5] video: msm: Remove useless mach/* includes

2012-09-23 Thread Florian Tobias Schandinat
On 09/19/2012 07:00 AM, Stephen Boyd wrote: > This driver doesn't need to use these mach includes so remove > them. This is a necessary step to support a single zImage. > > Cc: Florian Tobias Schandinat > Signed-off-by: Stephen Boyd Applied. Thanks, Florian Tobias Schandinat > --- >

Re: [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code

2012-09-23 Thread Florian Tobias Schandinat
Applied all 10 patches of this series. Thanks, Florian Tobias Schandinat On 09/18/2012 12:07 PM, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > > A simplified version of the

[PATCH v3 4/4] perf tools: configure addr2line path at compile time

2012-09-23 Thread Irina Tirdea
From: Irina Tirdea The default name for addr2line is hardcoded to "addr2line". When cross-compiling the name of addr2line will be different (e.g. arm-eabi-addr2line in Android). Set the default addr2line name in the Makefile with DEFAULT_ADDR2LINE_PATH. Signed-off-by: Irina Tirdea ---

Re: [PATCH] fbdev: jz4740: Use devm_request_and_ioremap

2012-09-23 Thread Florian Tobias Schandinat
On 09/09/2012 03:38 PM, Lars-Peter Clausen wrote: > Use devm_request_and_ioremap instead of request_mem_region + devm_ioremap. > > This also fixes the following compile error introduced in commit b2ca7f4d > ("drivers/video/jz4740_fb.c: use devm_ functions"): > > drivers/video/jz4740_fb.c: In

Re: [PATCH 7/10] drivers/video/sis/initextlfb.c: removes unnecessary semicolon

2012-09-23 Thread Florian Tobias Schandinat
On 09/06/2012 04:09 PM, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > removes unnecessary semicolon > > Found by Coccinelle: http://coccinelle.lip6.fr/ > > Signed-off-by: Peter Senna Tschudin Applied. Thanks, Florian Tobias Schandinat > > --- >

Re: [PATCH] video: mbxfb: Include linux/io.h instead of asm/io.h

2012-09-23 Thread Florian Tobias Schandinat
On 08/31/2012 01:39 PM, Axel Lin wrote: > This fixes below build error: > > CC [M] drivers/video/mbx/mbxfb.o > drivers/video/mbx/mbxfb.c: In function 'mbxfb_probe': > drivers/video/mbx/mbxfb.c:942:2: error: implicit declaration of function > 'devm_ioremap_nocache'

Fwd: [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code

2012-09-23 Thread Mauro Carvalho Chehab
Please review, Regards, Mauro. Mensagem original Assunto: [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code Data: Thu, 6 Sep 2012 17:23:59 +0200 De: Peter Senna Tschudin Para: Mauro Carvalho Chehab CC: kernel-janit...@vger.kernel.org,

Fwd: [PATCH 1/14] drivers/media/platform/soc_camera/soc_camera.c: fix error return code

2012-09-23 Thread Mauro Carvalho Chehab
Please review. Please review. Regards, Mauro. Mensagem original Assunto: [PATCH 1/14] drivers/media/platform/soc_camera/soc_camera.c: fix error return code Data: Thu, 6 Sep 2012 17:24:00 +0200 De: Peter Senna Tschudin Para: Mauro Carvalho Chehab CC:

Re: [PATCH] video: Remove pnx4008 driver

2012-09-23 Thread Florian Tobias Schandinat
On 08/26/2012 02:23 PM, Roland Stigge wrote: > This patch removes the video driver for pnx4008. The architecture is being > removed via the arm-soc tree. > > Signed-off-by: Roland Stigge Applied as it doesn't make sense to keep it around if there is no architecture left that can use it. Though

Fwd: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-23 Thread Mauro Carvalho Chehab
Sylwester, Please review. Regards, Mauro Mensagem original Assunto: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code Data: Thu, 6 Sep 2012 10:38:29 +0200 De: Peter Senna Tschudin Para: peter.se...@gmail.com, Mauro Carvalho Chehab CC:

[PATCH v2 4/4] perf tools: configure addr2line path at compile time

2012-09-23 Thread Irina Tirdea
From: Irina Tirdea The default name for addr2line is hardcoded to "addr2line". When cross-compiling the name of addr2line will be different (e.g. arm-eabi-addr2line in Android). Sett the default addr2line name in the Makefile with DEFAULT_ADDR2LINE_PATH. Signed-off-by: Irina Tirdea ---

[PATCH v2 2/4] perf tools: configure shell path at compile time

2012-09-23 Thread Irina Tirdea
From: Irina Tirdea Shell path /bin/sh is hardcoded in various places in perf. Android has a different folder structure and does not have /bin/sh. Set the shell path at compile time in the Makefile by setting PERF_SHELL_PATH. By default it is set to /bin/sh. Signed-off-by: Irina Tirdea ---

[PATCH v2 3/4] perf annotate: configure objdump path at compile time

2012-09-23 Thread Irina Tirdea
From: Irina Tirdea The default name for objdump is "objdump". For cross-compiling the name of objdump will be different (e.g. arm-eabi-objdump in Android). Set the default objdump name in the Makefile with DEFAULT_OBJDUMP_PATH. Signed-off-by: Irina Tirdea --- tools/perf/Makefile|

[PATCH v2 1/4] perf tools: configure tmp path at build time

2012-09-23 Thread Irina Tirdea
From: Irina Tirdea Temporary perf files are hardcoded to point to /tmp. Android does not have a /tmp directory so it needs to set this path at compile time. Add a compile-time definition (PERF_TMP_DIR) in the Makefile that sets the path to temp directory. By default it points to /tmp.

[PATCH v2 0/4] perf: android: configure hardcoded paths

2012-09-23 Thread Irina Tirdea
From: Irina Tirdea This is version 2 of the set of patches that replace hardcoded paths used in perf with configurable options in the Makefile. First version can be found at https://lkml.org/lkml/2012/9/20/537. Thanks everybody for the reviews! This version fixes all issues mentioned in

Re: [PATCH] video: hpfb: Fix error handling

2012-09-23 Thread Florian Tobias Schandinat
On 08/20/2012 06:32 PM, Emil Goode wrote: > This patch solves problems with the error handling by > introducing labels for proper error paths and it also > frees resources that where missed. > > Signed-off-by: Emil Goode Applied. Thanks, Florian Tobias Schandinat > --- >

Re: [PATCH v2] lxt PHY: Support for the buggy LXT973 rev A2

2012-09-23 Thread Lutz Jaenicke
On Sat, Sep 22, 2012 at 06:21:38PM +0200, leroy christophe wrote: > > Le 10/09/2012 20:17, Lutz Jaenicke a écrit : > >On Mon, Sep 10, 2012 at 05:45:49PM +0200, Christophe Leroy wrote: > >>This patch adds proper handling of the buggy revision A2 of LXT973 phy, > >>adding > >>precautions linked to

Re: [PATCH 2/2] i2c: busses: i2c-ocores: switch to devm_request_and_ioremap

2012-09-23 Thread Peter Korsgaard
> "Maxin" == Maxin B John writes: Maxin> This drops a few lines of code and allows common APIs to handle Maxin> those for us. Maxin> Signed-off-by: Maxin B. John Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 3/4] lib: vsprintf: Optimize put_dec_trunc8

2012-09-23 Thread Michal Nazarewicz
On Fri, Aug 03 2012, George Spelvin wrote: > If you're going to have a conditional branch after > each 32x32->64-bit multiply, might as well shrink the code > and make it a loop. > > This also avoids using the long multiply for small integers. > > (This leaves the comments in a confusing state,

Re: [PATCH 1/2] i2c: busses: i2c-ocores: Fix documentation filename

2012-09-23 Thread Peter Korsgaard
> "Maxin" == Maxin B John writes: Maxin> Fixes the wrong filename. Maxin> Signed-off-by: Maxin B. John Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 5/5] drivers/media/platform/omap3isp/isp.c: fix error return code

2012-09-23 Thread Peter Senna Tschudin
On Sun, Sep 23, 2012 at 7:39 PM, Mauro Carvalho Chehab wrote: > Laurent, > > Could you please review this patch? > > Peter, > > Please, always c/c the driver maintainer/author on patches you submit. > > You can check it with scripts/get_maintainer.pl. Sorry for that. I'll be more careful next

Re: [PATCH 0/4] devpts: fix devpts mount behavior

2012-09-23 Thread H. Peter Anvin
On 09/23/2012 10:42 AM, Eric W. Biederman wrote: Greg, Kay, any idea how to make ptmx show up in devtmpfs as a symlink to pts/pmtx instead of as a device node? The conversation stalled in January with that very question. What I am proposing doesn't conflict with any effort like that. I

Re: [PATCH 0/4] devpts: fix devpts mount behavior

2012-09-23 Thread Eric W. Biederman
"H. Peter Anvin" writes: > On 09/22/2012 08:47 PM, Eric W. Biederman wrote: >> Making /dev/ptmx a symlink sounds simple, but in practice no one could >> actually figure out how to make it happen. > > This feels particularly ridiculous since udev now requires devtmpfs > (as in it will no longer

Fwd: [PATCH 5/5] drivers/media/platform/omap3isp/isp.c: fix error return code

2012-09-23 Thread Mauro Carvalho Chehab
Laurent, Could you please review this patch? Peter, Please, always c/c the driver maintainer/author on patches you submit. You can check it with scripts/get_maintainer.pl. Regards, Mauro Mensagem original Assunto: [PATCH 5/5] drivers/media/platform/omap3isp/isp.c: fix error

Re: [PATCH 2/4] lib: vsprintf: Optimize division by 10000

2012-09-23 Thread Michal Nazarewicz
On Fri, Aug 03 2012, George Spelvin wrote: > The same multiply-by-inverse technique can be used to > convert division by 1 to a 32x32->64-bit multiply. > > Signed-off-by: George Spelvin You are using a 64-bit multiply in a path that is designed for 32-bit processors, which makes me feel that

Re: [PATCH 1/4] lib: vsprintf: Optimize division by 10 for small integers.

2012-09-23 Thread Michal Nazarewicz
On Fri, Aug 03 2012, George Spelvin wrote: > Shrink the reciprocal approximations used in put_dec_full4 > based on the comments in put_dec_full9. > > Signed-off-by: George Spelvin > Cc: Denys Vlasenko > Cc: Michal Nazarewicz Have you verified that the comment is correct? > --- >

Re: [PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-23 Thread Federico Vaga
> > +struct sta2x11_vip_fh { > > + struct v4l2_fh fh; > > +}; > > No need to make a sta2x11_vip_fh struct, just use v4l2_fh directly. It > doesn't add anything. In fact, it's not even used. Thank you :) > > static int vidioc_try_fmt_vid_cap(struct file *file, void *priv, > > > >

Re: [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework

2012-09-23 Thread Thierry Reding
On Sun, Sep 23, 2012 at 03:56:35PM +0200, Ralf Baechle wrote: > On Sat, Sep 22, 2012 at 09:41:45AM +0200, Thierry Reding wrote: > > > Have you had a chance to look at this? It is the last remaining PWM > > driver that isn't moved to the PWM framework yet. All the others are > > either in

[PATCH] net: scm: moving dereference after NULL check

2012-09-23 Thread Maxin B. John
scm_destroy_cred() dereferences 'scm' before null check Signed-off-by: Maxin B. John --- diff --git a/include/net/scm.h b/include/net/scm.h index 7dc0854..ed25aa1 100644 --- a/include/net/scm.h +++ b/include/net/scm.h @@ -64,9 +64,11 @@ static __inline__ void scm_destroy_cred(struct scm_cookie

Re: [PATCH 0/4] devpts: fix devpts mount behavior

2012-09-23 Thread H. Peter Anvin
On 09/22/2012 08:47 PM, Eric W. Biederman wrote: Making /dev/ptmx a symlink sounds simple, but in practice no one could actually figure out how to make it happen. This feels particularly ridiculous since udev now requires devtmpfs (as in it will no longer work without it), which means this is

Re: Areca hardware RAID / first-ever SCSI bus reset: am I about to lose this disk controller?

2012-09-23 Thread Nix
On 19 Sep 2012, Chris Murphy outgrape: > > On Sep 19, 2012, at 12:52 PM, Nix wrote: > >> So I have this x86-64 server running Linux 3.5.1 with a SATA-on-PCIe >> Areca 1210 hardware RAID-5 controller > > Did you find this? Same controller family. Weird that this just shows > up now, but perhaps

Re: Question on /sys/class/tty/tty0/active

2012-09-23 Thread Alan Cox
On Sun, 23 Sep 2012 16:40:07 +0200 richard -rw- weinberger wrote: > Hi! > > I'm booting 3.6-rc6 using KVM and observe the following output: > $ tty > /dev/tty0 > $ cat /sys/class/tty/tty0/active > tty1 > > Why does the active file say I'm on tty1? > There is no tty1, I'm on tty0. > (Also "who"

Re: [PATCH 1/2] i2c: busses: i2c-ocores: Fix documentation filename

2012-09-23 Thread Rob Herring
On 09/23/2012 08:30 AM, Maxin B. John wrote: > Fixes the wrong filename. > > Signed-off-by: Maxin B. John > --- Acked-by: Rob Herring > diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c > index bffd550..e39c122 100644 > --- a/drivers/i2c/busses/i2c-ocores.c > +++

PROBLEM: kernel 3.6.rc6 bug report (usb 3.0 external hard drive problem)

2012-09-23 Thread Gabor Takacs
Bug report for kernel version 3.6.rc6 Content of message: - One-line description - Full description - Keywords - CPU info - Modules info - Kernel version - Loaded driver and hardware information - PCI information - SCSI information One-line description: Western Digital My Passport USB 3.0 hard

Re: [PATCH 01/40] PCI: fix default vga ref_count

2012-09-23 Thread Jiang Liu
On 09/20/2012 02:54 AM, Yinghai Lu wrote: > when __ARCH_HAS_VGA_DEFAULT_DEVICE is not defined, aka EFIFB is not used, > for static path, vga_default setting is through vga_arbiter_add_pci_device. > and later x86 pci_fixup_video, will skip setting again. > - subsys_initcall(vga_arb_device_init)

  1   2   3   >