Re: [PATCH v2 02/14] crypto: omap-aes: Add useful debug macros

2013-08-17 Thread Joel Fernandes
On 08/17/2013 11:22 PM, Joe Perches wrote: > On Sat, 2013-08-17 at 21:42 -0500, Joel Fernandes wrote: >> When DEBUG is enabled, these macros can be used to print variables in integer >> and hex format, and clearly display which registers, offsets and values are >> being read/written , including

[PATCH v3 6/7] ARM: davinci: dmxxx: gpio device creation

2013-08-17 Thread Lad, Prabhakar
From: Philip Avinash Create davinci gpio device and remove gpio references in davinci_soc_info structure for dmxxx platforms. Also add Memory and IRQ resources for GPIO platform device. Also rearrange header file inclusion in group basis. Signed-off-by: Philip Avinash Signed-off-by: Sekhar

[PATCH v3 7/7] ARM: davinci: Start using gpiolib API inplace of inline functions

2013-08-17 Thread Lad, Prabhakar
From: Philip Avinash Remove NEED_MACH_GPIO_H config select option for ARCH_DAVINCI to start use gpiolib interface for davinci platforms. However with this software latencies for gpio_get/set APIs will affect. Latency has increased by 18 microsecond with gpiolib API as compared with inline API's.

[PATCH v3 5/7] ARM: davinci: da8xx: gpio device creation

2013-08-17 Thread Lad, Prabhakar
From: Philip Avinash Create davinci gpio device and remove references in davinci_soc_info structure. Also rearrange header file inclusion in group basis. Signed-off-by: Philip Avinash Signed-off-by: Sekhar Nori Signed-off-by: Lad, Prabhakar Acked-by: Linus Walleij ---

[PATCH v3 3/7] ARM: davinci: da8xx: support gpio platform device

2013-08-17 Thread Lad, Prabhakar
From: KV Sujith DaVinci GPIO driver now uses platform device model. Convert DA8XX SoC code to use the new model. - Add Memory and IRQ resources for da8xx - Add da8xx_register_gpio API to create platform device for da8xx platforms. - Removed unused GPIO initialization in davinci_soc_info

[PATCH v3 4/7] ARM: davinci: devices.c: support gpio platform device

2013-08-17 Thread Lad, Prabhakar
From: Philip Avinash DaVinci GPIO driver now uses platform device model. Add a GPIO platform register API to convert the traditional DaVinci SoCs to use the new model. Signed-off-by: Philip Avinash Acked-by: Linus Walleij [nsek...@ti.com: move function declaration to local header, simplify

[PATCH v3 2/7] gpio: davinci: move to platform device

2013-08-17 Thread Lad, Prabhakar
From: KV Sujith Modify GPIO Davinci driver to be compliant to standard platform drivers. The driver did not have platform driver structure or a probe. Instead, had a davinci_gpio_setup() function which is called in the pure_init sequence. The function also had dependency on davinci_soc_info

[PATCH v3 1/7] gpio: davinci: coding style correction

2013-08-17 Thread Lad, Prabhakar
From: Philip Avinash Make some minor coding style fixes. Use proper multi-line commenting style, arrange include files alphabetically and use a macro for register offset. Signed-off-by: Philip Avinash [nsek...@ti.com: dropped changes which were considered churn - line break fixes and variable

[PATCH v3 0/7] Convert GPIO Davinci to platform driver

2013-08-17 Thread Lad, Prabhakar
From: Philip Avinash To support DT booting of da850 EVM, davinci gpio driver converted to platform driver. Also when here, start using gpiolib API for gpio get/set functionalities. Hence removing gpio inline functionalities. However usage of gpiolib API will cause an additional software

Re: [PATCH v2 02/14] crypto: omap-aes: Add useful debug macros

2013-08-17 Thread Joe Perches
On Sat, 2013-08-17 at 21:42 -0500, Joel Fernandes wrote: > When DEBUG is enabled, these macros can be used to print variables in integer > and hex format, and clearly display which registers, offsets and values are > being read/written , including printing the names of the offsets and their >

howto make define seen in all files?

2013-08-17 Thread l...@tigusoft.pl
Hi, I want to provide a general defined macro like __MY__TIME__ (for determinictic build) and that symbol should be seen as #define or -D... to gcc in all files; Value of __MY_TIME__ is determined once, at start of build. I was using file scripts/mkcompile_h as in the attached .diff patch,

Re: [PATCH tip/core/rcu 11/11] jiffies: Avoid undefined behavior from signed overflow

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:37:56PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > According to the C standard 3.4.3p3, overflow of a signed integer results > in undefined behavior. This commit therefore changes the definitions > of time_after(), time_after_eq(), time_after64(),

Re: [PATCH tip/core/rcu 0/11] Fixes for 3.12

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:37:35PM -0700, Paul E. McKenney wrote: > Hello! > > This series contains a number of miscellaneous fixes: > > 1.Switch to expedited grace periods during hibernation operations > (courtesy of Borislav Petkov). > > 2.Restrict above expediting to systems of

Re: [PATCH tip/core/rcu 06/11] rcu: Switch to exedited grace periods for suspend as well as hibernation

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:37:51PM -0700, Paul E. McKenney wrote: > From: Bjørn Mork > > Commit 587ff2cf ("rcu: Expedite grace periods during suspend/resume") > enabled expedited grace periods for hibernation, but not for suspend. > The same issue applies to both cases, so this commit simply

Re: [PATCH tip/core/rcu 02/11] rcu: Expedite during suspend and resume only on smallish systems

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:37:47PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > Expedited grace periods are of dubious benefit on very large systems, > so this commit restricts their automated use during suspend and resume > to systems of 256 or fewer CPUs. > > Signed-off-by:

Re: [PATCH tip/core/rcu 01/11] rcu: Expedite grace periods during suspend/resume

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:37:46PM -0700, Paul E. McKenney wrote: > From: Borislav Petkov > > CONFIG_RCU_FAST_NO_HZ can increase grace-period durations by up to > a factor of four, which can result in long suspend and resume times. > Thus, this commit temporarily switches to expedited grace

Re: [PATCH tip/core/rcu 0/9] sysidle changes for v3.12

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:49:18PM -0700, Paul E. McKenney wrote: > Hello! > > Whenever there is at least one non-idle CPU, it is necessary to > periodically update timekeeping information. Before NO_HZ_FULL, this > updating was carried out by the scheduling-clock tick, which ran on > every

Re: [PATCH tip/core/rcu 7/9] nohz_full: Add full-system-idle arguments to API

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:49:42PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > This commit adds an isidle and jiffies argument to force_qs_rnp(), > dyntick_save_progress_counter(), and rcu_implicit_dynticks_qs() to enable > RCU's force-quiescent-state process to check for

Re: [PATCH tip/core/rcu 6/9] nohz_full: Add full-system idle states and variables

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:49:41PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > This commit adds control variables and states for full-system idle. > The system will progress through the states in numerical order when > the system is fully idle (other than the timekeeping CPU),

Re: [PATCH tip/core/rcu 5/9] nohz_full: Add per-CPU idle-state tracking

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:49:40PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > This commit adds the code that updates the rcu_dyntick structure's > new fields to track the per-CPU idle state based on interrupts and > transitions into and out of the idle loop (NMIs are ignored

[PATCH 1/2] iscsi/iser-target: Convert to command priv_size usage

2013-08-17 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This command converts iscsi/isert-target to use allocations based on iscsit_transport->priv_size within iscsit_allocate_cmd(), instead of using an embedded isert_cmd->iscsi_cmd. This includes removing iscsit_transport->alloc_cmd() usage, along with updating isert-target

[PATCH 2/2] iscsi-target: Convert to per-cpu ida_alloc + ida_free command map

2013-08-17 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes iscsi-target to use transport_alloc_session_tags() pre-allocation logic for per-cpu session tag pooling with internal ida_alloc() + ida_free() calls based upon the saved se_cmd->map_tag id. This includes tag pool setup based upon per NodeACL

Re: [PATCH tip/core/rcu 4/9] nohz_full: Add rcu_dyntick data for scalable detection of all-idle state

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:49:39PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > This commit adds fields to the rcu_dyntick structure that are used to > detect idle CPUs. These new fields differ from the existing ones in > that the existing ones consider a CPU executing in user

[PATCH 0/2] iscsi/iser-target: Add per-cpu ida tag pre-allocation for v3.12

2013-08-17 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This series adds tag pre-allocation support of iscsi_cmd descriptors with iscsi/iser-target code, utilizing Kent's latest per-cpu ida bits posted earlier here: [PATCH-v3 1/4] idr: Percpu ida http://marc.info/?l=linux-virtualization=137669883717043=2 and

Re: [PATCH tip/core/rcu 0/5] rcutorture updates for 3.12

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 07:24:53PM -0700, Paul E. McKenney wrote: > Hello! > > This series provides some rcutorture updates: > > 1.Add a debug_object option to rcutorture to allow testing > of RCU's debug-objects facilities. > > 2.Increase rcutorture test coverage by concurrently

Re: [PATCH tip/core/rcu 5/5] rcu: Make rcutorture emit online failures if verbose

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 07:25:17PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > Although rcutorture counts CPU-hotplug online failures, it does > not explicitly record which CPUs were having trouble coming online. > This commit therefore emits a console message when online

Re: [PATCH tip/core/rcu 3/5] rcu: Sort rcutorture module parameters

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 07:25:15PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > There are getting to be too many module parameters to permit the current > semi-random order, so this patch orders them. > > Signed-off-by: Paul E. McKenney As long as you're reordering them

Re: [PATCH tip/core/rcu 1/5] rcu: Add duplicate-callback tests to rcutorture

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 07:25:13PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > This commit adds a object_debug option to rcutorture to allow the > debug-object-based checks for duplicate call_rcu() invocations to > be deterministically tested. > > Signed-off-by: Paul E.

Re: [PATCH tip/core/rcu 0/3] Documentation updates for 3.12

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:25:22PM -0700, Paul E. McKenney wrote: > Hello! > > This series provides a few documentation updates: > > 1.Update rcu_barrier() documentation to note that it no longer is > guaranteed to wait for a full grace period. This guarantee was > a victim of

[PATCH v2 11/14] crypto: omap-aes: Add support for cases of unaligned lengths

2013-08-17 Thread Joel Fernandes
For cases where offset/length of on any page of the input SG is not aligned by AES_BLOCK_SIZE, we copy all the pages from the input SG list into a contiguous buffer and prepare a single element SG list for this buffer with length as the total bytes to crypt. This is requried for cases such as

[PATCH v2 01/14] crypto: scatterwalk: Add support for calculating number of SG elements

2013-08-17 Thread Joel Fernandes
Crypto layer only passes nbytes to encrypt but in omap-aes driver we need to know number of SG elements to pass to dmaengine slave API. We add function for the same to scatterwalk library. Signed-off-by: Joel Fernandes --- crypto/scatterwalk.c | 22 ++

[PATCH v2 03/14] crypto: omap-aes: Populate number of SG elements

2013-08-17 Thread Joel Fernandes
Crypto layer only passes nbytes but number of SG elements is needed for mapping or unmapping SGs at one time using dma_map* API and also needed to pass in for dmaengine prep function. We call function added to scatterwalk for this purpose in omap_aes_handle_queue to populate the values which are

[PATCH v2 14/14] crypto: omap-aes: Kconfig: Add build support for AM437x

2013-08-17 Thread Joel Fernandes
For AM437x SoC, ARCH_OMAP2 and ARCH_OMAP3 is not enabled in the defconfig. We follow same thing as SHA driver, and add depends on ARCH_OMAP2PLUS so that the config is selectable for AES driver on AM437x SoC builds. Signed-off-by: Joel Fernandes --- drivers/crypto/Kconfig |2 +- 1 file

[PATCH v2 05/14] crypto: omap-aes: Sync SG before DMA operation

2013-08-17 Thread Joel Fernandes
Earlier functions that did a similar sync are replaced by the dma_sync_sg_* which can operate on entire SG list. Signed-off-by: Joel Fernandes --- drivers/crypto/omap-aes.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index

[PATCH v2 13/14] crypto: omap-aes: Convert request_irq to devm_request_irq

2013-08-17 Thread Joel Fernandes
Keeps request_irq exit/error code paths simpler. Suggested-by: Lokesh Vutla Signed-off-by: Joel Fernandes --- drivers/crypto/omap-aes.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 6a4ac4a..ab449b5

Re: [PATCH tip/core/rcu 2/3] rcu: Update RTFP documentation

2013-08-17 Thread Josh Triplett
On Sat, Aug 17, 2013 at 06:25:52PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" Could you mention the BibTeX formatting changes (and the rationale for them) in the commit message, please? > Signed-off-by: Paul E. McKenney A couple of comments below (and above); with those fixed,

[PATCH v2 10/14] crypto: omap-aes: Switch to PIO mode during probe

2013-08-17 Thread Joel Fernandes
In cases where requesting for DMA channels fails for some reason, or channel numbers are not provided in DT or platform data, we switch to PIO-only mode also checking if platform provides IRQ numbers and interrupt register offsets in DT and platform data. All dma-only paths are avoided in this

[PATCH v2 09/14] crypto: omap-aes: PIO mode: platform data for OMAP4/AM437x and trigger

2013-08-17 Thread Joel Fernandes
We initialize the scatter gather walk lists needed for PIO mode and avoid all DMA paths such as mapping/unmapping buffers by checking for the pio_only flag. Signed-off-by: Joel Fernandes --- drivers/crypto/omap-aes.c | 43 ++- 1 file changed, 30

[PATCH v2 12/14] crypto: omap-aes: Convert kzalloc to devm_kzalloc

2013-08-17 Thread Joel Fernandes
Use devm_kzalloc instead of kzalloc. With this change, there is no need to call kfree in error/exit paths. Signed-off-by: Joel Fernandes --- drivers/crypto/omap-aes.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c

[PATCH v2 02/14] crypto: omap-aes: Add useful debug macros

2013-08-17 Thread Joel Fernandes
When DEBUG is enabled, these macros can be used to print variables in integer and hex format, and clearly display which registers, offsets and values are being read/written , including printing the names of the offsets and their values. Note: This patch results in a checkpatch error that cannot

[PATCH v2 04/14] crypto: omap-aes: Simplify DMA usage by using direct SGs

2013-08-17 Thread Joel Fernandes
In early version of this driver, assumptions were made such as DMA layer requires contiguous buffers etc. Due to this, new buffers were allocated, mapped and used for DMA. These assumptions are no longer true and DMAEngine scatter-gather DMA doesn't have such requirements. We simply the DMA

[PATCH v2 07/14] crypto: omap-aes: Add IRQ info and helper macros

2013-08-17 Thread Joel Fernandes
Add IRQ information to pdata and helper macros. These are required for PIO-mode support. Signed-off-by: Joel Fernandes --- drivers/crypto/omap-aes.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index bbdd1c3..9a964e8 100644

[PATCH v2 06/14] crypto: omap-aes: Remove previously used intermediate buffers

2013-08-17 Thread Joel Fernandes
Intermdiate buffers were allocated, mapped and used for DMA. These are no longer required as we use the SGs from crypto layer directly in previous commits in the series. Also along with it, remove the logic for copying SGs etc as they are no longer used, and all the associated variables in

[PATCH v2 00/14] crypto: omap-aes: Improve DMA, add PIO mode and support for AM437x

2013-08-17 Thread Joel Fernandes
Following patch series rewrites the DMA code to be cleaner and faster. Earlier, only a single SG was used for DMA purpose, and the SG-list passed from the crypto layer was being copied and DMA'd one entry at a time. This turns out to be quite inefficient and lot of code, we replace it with much

[PATCH v2 08/14] crypto: omap-aes: PIO mode: Add IRQ handler and walk SGs

2013-08-17 Thread Joel Fernandes
We add an IRQ handler that implements a state-machine for PIO-mode and data structures for walking the scatter-gather list. The IRQ handler is called in succession both when data is available to read or next data can be sent for processing. This process continues till the entire in/out SG lists

[PATCH tip/core/rcu 3/5] rcu: Sort rcutorture module parameters

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" There are getting to be too many module parameters to permit the current semi-random order, so this patch orders them. Signed-off-by: Paul E. McKenney --- kernel/rcutorture.c | 68 ++--- 1 file changed, 34 insertions(+),

[PATCH tip/core/rcu 1/5] rcu: Add duplicate-callback tests to rcutorture

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds a object_debug option to rcutorture to allow the debug-object-based checks for duplicate call_rcu() invocations to be deterministically tested. Signed-off-by: Paul E. McKenney Cc: Mathieu Desnoyers Cc: Sedat Dilek Cc: Davidlohr Bueso Cc: Rik van

[PATCH tip/core/rcu 5/5] rcu: Make rcutorture emit online failures if verbose

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" Although rcutorture counts CPU-hotplug online failures, it does not explicitly record which CPUs were having trouble coming online. This commit therefore emits a console message when online failure occurs. Signed-off-by: Paul E. McKenney --- kernel/rcutorture.c | 8

[PATCH tip/core/rcu 4/5] rcu: Remove unused variable from rcu_torture_writer()

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" The oldbatch variable in rcu_torture_writer() is stored to, but never loaded from. This commit therefore removes it. Signed-off-by: Paul E. McKenney --- kernel/rcutorture.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c

[PATCH tip/core/rcu 2/5] rcu: Increase rcutorture test coverage

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" Currently, rcutorture has separate torture_types to test synchronous, asynchronous, and expedited grace-period primitives. This has two disadvantages: (1) Three times the number of runs to cover the combinations and (2) Little testing of concurrent combinations of the

[PATCH tip/core/rcu 0/5] rcutorture updates for 3.12

2013-08-17 Thread Paul E. McKenney
Hello! This series provides some rcutorture updates: 1. Add a debug_object option to rcutorture to allow testing of RCU's debug-objects facilities. 2. Increase rcutorture test coverage by concurrently testing synchronous, asynchronous, and expedited grace periods. 3.

[PATCH tip/core/rcu 7/9] nohz_full: Add full-system-idle arguments to API

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds an isidle and jiffies argument to force_qs_rnp(), dyntick_save_progress_counter(), and rcu_implicit_dynticks_qs() to enable RCU's force-quiescent-state process to check for full-system idle. Signed-off-by: Paul E. McKenney Cc: Frederic Weisbecker Cc:

[PATCH tip/core/rcu 4/9] nohz_full: Add rcu_dyntick data for scalable detection of all-idle state

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds fields to the rcu_dyntick structure that are used to detect idle CPUs. These new fields differ from the existing ones in that the existing ones consider a CPU executing in user mode to be idle, where the new ones consider CPUs executing in user mode to

[PATCH tip/core/rcu 6/9] nohz_full: Add full-system idle states and variables

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds control variables and states for full-system idle. The system will progress through the states in numerical order when the system is fully idle (other than the timekeeping CPU), and reset down to the initial state if any non-timekeeping CPU goes

[PATCH tip/core/rcu 1/9] rcu: Eliminate unused APIs intended for adaptive ticks

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" The rcu_user_enter_after_irq() and rcu_user_exit_after_irq() functions were intended for use by adaptive ticks, but changes in implementation have rendered them unnecessary. This commit therefore removes them. Reported-by: Frederic Weisbecker Signed-off-by: Paul E.

[PATCH tip/core/rcu 8/9] nohz_full: Add full-system-idle state machine

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds the state machine that takes the per-CPU idle data as input and produces a full-system-idle indication as output. This state machine is driven out of RCU's quiescent-state-forcing mechanism, which invokes rcu_sysidle_check_cpu() to collect per-CPU idle

[PATCH tip/core/rcu 2/9] nohz_full: Add testing information to documentation

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds information about testing nohz_full, and also emphasizes the fact that you need a multi-CPU system to get any benefit from nohz_full. Signed-off-by: Paul E. McKenney Acked-by: Frederic Weisbecker --- Documentation/timers/NO_HZ.txt | 44

[PATCH tip/core/rcu 9/9] nohz_full: Force RCU's grace-period kthreads onto timekeeping CPU

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" Because RCU's quiescent-state-forcing mechanism is used to drive the full-system-idle state machine, and because this mechanism is executed by RCU's grace-period kthreads, this commit forces these kthreads to run on the timekeeping CPU (tick_do_timer_cpu). To do

[PATCH tip/core/rcu 5/9] nohz_full: Add per-CPU idle-state tracking

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds the code that updates the rcu_dyntick structure's new fields to track the per-CPU idle state based on interrupts and transitions into and out of the idle loop (NMIs are ignored because NMI handlers cannot cleanly read out the time anyway). This code is

[PATCH tip/core/rcu 3/9] nohz_full: Add Kconfig parameter for scalable detection of all-idle state

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" At least one CPU must keep the scheduling-clock tick running for timekeeping purposes whenever there is a non-idle CPU. However, with the new nohz_full adaptive-idle machinery, it is difficult to distinguish between all CPUs really being idle as opposed to all non-idle

[PATCH tip/core/rcu 0/9] sysidle changes for v3.12

2013-08-17 Thread Paul E. McKenney
Hello! Whenever there is at least one non-idle CPU, it is necessary to periodically update timekeeping information. Before NO_HZ_FULL, this updating was carried out by the scheduling-clock tick, which ran on every non-idle CPU. With the advent of NO_HZ_FULL, it is possible to have non-idle CPUs

[PATCH tip/core/rcu 01/11] rcu: Expedite grace periods during suspend/resume

2013-08-17 Thread Paul E. McKenney
From: Borislav Petkov CONFIG_RCU_FAST_NO_HZ can increase grace-period durations by up to a factor of four, which can result in long suspend and resume times. Thus, this commit temporarily switches to expedited grace periods when suspending the box and return to normal settings when resuming. [

[PATCH tip/core/rcu 09/11] rcu: Select IRQ_WORK from TREE_PREEMPT_RCU

2013-08-17 Thread Paul E. McKenney
From: James Hogan TREE_RCU and TREE_PREEMPT_RCU both cause kernel/rcutree.c to be built, but only TREE_RCU selects IRQ_WORK, which can result in an undefined reference to irq_work_queue for some (random) configs: kernel/built-in.o In function `rcu_start_gp_advanced': kernel/rcutree.c:1564:

[PATCH tip/core/rcu 03/11] rcu: Simplify debug-objects fixups

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" The current debug-objects fixups are complex and heavyweight, and the fixups are not complete: Even with the fixups, RCU's callback lists can still be corrupted. This commit therefore strips the fixups down to their minimal form, eliminating two of the three. It would

[PATCH tip/core/rcu 10/11] rcu: Simplify _rcu_barrier() processing

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit drops an unneeded ACCESS_ONCE() and simplifies an "our work is done" check in _rcu_barrier(). This applies feedback from Linus (https://lkml.org/lkml/2013/7/26/777) that he gave to similar code in an unrelated patch. Signed-off-by: Paul E. McKenney ---

[PATCH tip/core/rcu 06/11] rcu: Switch to exedited grace periods for suspend as well as hibernation

2013-08-17 Thread Paul E. McKenney
From: Bjørn Mork Commit 587ff2cf ("rcu: Expedite grace periods during suspend/resume") enabled expedited grace periods for hibernation, but not for suspend. The same issue applies to both cases, so this commit simply applies the same logic by adding additional cases to the switch statement.

[PATCH tip/core/rcu 04/11] debugobjects: Make debug_object_activate() return status

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" In order to better respond to things like duplicate invocations of call_rcu(), RCU needs to see the status of a call to debug_object_activate(). This would allow RCU to leak the callback in order to avoid adding freelist-reuse mischief to the duplicate invoations. This

[PATCH tip/core/rcu 05/11] rcu: Make call_rcu() leak callbacks for debug-object errors

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" If someone does a duplicate call_rcu(), the worst thing the second call_rcu() could do would be to actually queue the callback the second time because doing so corrupts whatever list the callback was already queued on. This commit therefore makes __call_rcu() check the

[PATCH tip/core/rcu 07/11] rcu: Avoid redundant grace-period kthread wakeups

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" When setting up an in-the-future "advanced" grace period, the code needs to wake up the relevant grace-period kthread, which it currently does unconditionally. However, this results in needless wakeups in the case where the advanced grace period is being set up by the

[PATCH tip/core/rcu 08/11] rculist: list_first_or_null_rcu() should use list_entry_rcu()

2013-08-17 Thread Paul E. McKenney
From: Tejun Heo list_first_or_null() should test whether the list is empty and return pointer to the first entry if not in a RCU safe manner. It's broken in several ways. * It compares __kernel @__ptr with __rcu @__next triggering the following sparse warning. net/core/dev.c:4331:17:

[PATCH tip/core/rcu 11/11] jiffies: Avoid undefined behavior from signed overflow

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" According to the C standard 3.4.3p3, overflow of a signed integer results in undefined behavior. This commit therefore changes the definitions of time_after(), time_after_eq(), time_after64(), and time_after_eq64() to avoid this undefined behavior. The trick is that

[PATCH tip/core/rcu 0/11] Fixes for 3.12

2013-08-17 Thread Paul E. McKenney
Hello! This series contains a number of miscellaneous fixes: 1. Switch to expedited grace periods during hibernation operations (courtesy of Borislav Petkov). 2. Restrict above expediting to systems of 256 or fewer CPUs. 3. Make RCU debugobjects fixup actions leak

[PATCH tip/core/rcu 02/11] rcu: Expedite during suspend and resume only on smallish systems

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" Expedited grace periods are of dubious benefit on very large systems, so this commit restricts their automated use during suspend and resume to systems of 256 or fewer CPUs. Signed-off-by: Paul E. McKenney --- kernel/rcutree.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH tip/core/rcu 2/3] rcu: Update RTFP documentation

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" Signed-off-by: Paul E. McKenney --- Documentation/RCU/RTFP.txt | 855 + 1 file changed, 550 insertions(+), 305 deletions(-) diff --git a/Documentation/RCU/RTFP.txt b/Documentation/RCU/RTFP.txt index 7f40c72..350be9a 100644

[PATCH tip/core/rcu 3/3] doc: Fix memory-barrier control-dependency example

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" Each control-dependency example needs its barriers between the "if" condition and the body of the "if" because a control dependency is a dependency induced by a branch. This commit makes the needed adjustment. Reported-by: Yongming Shen Signed-off-by: Paul E. McKenney

[PATCH tip/core/rcu 1/3] rcu: Fix rcu_barrier() documentation

2013-08-17 Thread Paul E. McKenney
From: "Paul E. McKenney" There was a time when rcu_barrier() was guaranteed to wait for at least a grace period, but that time ended due to energy-efficiency concerns. So now rcu_barrier() is a no-op if there are no RCU callbacks queued in the system. This commit updates the documentation to

[PATCH tip/core/rcu 0/3] Documentation updates for 3.12

2013-08-17 Thread Paul E. McKenney
Hello! This series provides a few documentation updates: 1. Update rcu_barrier() documentation to note that it no longer is guaranteed to wait for a full grace period. This guarantee was a victim of energy efficiency. 2. Update RTFP documentation. 3. Fix a

[3.11-rc5..] NULL pointer dereference in bdi_writeback_workfn

2013-08-17 Thread Alan Stern
Forwarding this message to Tejun and Jens, because it concerns a bug in the block layer. Alan Stern -- Forwarded message -- Date: Sun, 18 Aug 2013 00:12:10 +0200 From: Peter Wu To: linux-...@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [3.11-rc5..] NULL pointer

Re: [PATCH 0/4] Unify CPU hotplug lock interface

2013-08-17 Thread Rafael J. Wysocki
On Saturday, August 17, 2013 01:46:55 PM Toshi Kani wrote: > lock_device_hotplug() was recently introduced to serialize CPU & Memory > online/offline and hotplug operations, along with sysfs online interface > restructure (commit 4f3549d7). With this new locking scheme, >

Re: [PATCH 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock()

2013-08-17 Thread Rafael J. Wysocki
On Saturday, August 17, 2013 01:46:59 PM Toshi Kani wrote: > cpu_hotplug_driver_lock() serializes CPU online/offline operations > when ARCH_CPU_PROBE_RELEASE is set. This lock interface is no longer > necessary with the following reason: > > - lock_device_hotplug() now protects CPU

Re: [PATCH 3/4] hotplug, x86: Disable ARCH_CPU_PROBE_RELEASE on x86

2013-08-17 Thread Rafael J. Wysocki
On Saturday, August 17, 2013 01:46:58 PM Toshi Kani wrote: > Commit d7c53c9e enabled ARCH_CPU_PROBE_RELEASE on x86 in order to > serialize CPU online/offline operations. Although it is the config > option to enable CPU hotplug test interfaces, probe & release, it is > also the option to enable

Re: [PATCH 2/4] hotplug, x86: Add hotplug lock to missing places

2013-08-17 Thread Rafael J. Wysocki
On Saturday, August 17, 2013 01:46:57 PM Toshi Kani wrote: > lock_device_hotplug() serializes CPU & Memory online/offline and hotplug > operations. However, this lock is not held in the debug interfaces below > that initiate CPU online/offline operations. > > - _debug_hotplug_cpu(), cpu0

Re: [PATCH 1/4] hotplug, x86: Fix online state in cpu0 debug interface

2013-08-17 Thread Rafael J. Wysocki
On Saturday, August 17, 2013 01:46:56 PM Toshi Kani wrote: > _debug_hotplug_cpu() is a debug interface that puts cpu0 offline during > boot-up when CONFIG_DEBUG_HOTPLUG_CPU0 is set. After cpu0 is put offline > in this interface, however, /sys/devices/system/cpu/cpu0/online still > shows 1

Re: [PATCH RFC nohz_full 1/7] nohz_full: Add Kconfig parameter for scalable detection of all-idle state

2013-08-17 Thread Paul E. McKenney
On Mon, Aug 05, 2013 at 03:04:55AM +0200, Frederic Weisbecker wrote: > On Fri, Jul 26, 2013 at 04:19:18PM -0700, Paul E. McKenney wrote: > > From: "Paul E. McKenney" > > > > At least one CPU must keep the scheduling-clock tick running for > > timekeeping purposes whenever there is a non-idle

Re: [PATCH 2/4] hotplug, x86: Add hotplug lock to missing places

2013-08-17 Thread Greg KH
On Sat, Aug 17, 2013 at 01:46:57PM -0600, Toshi Kani wrote: > lock_device_hotplug() serializes CPU & Memory online/offline and hotplug > operations. However, this lock is not held in the debug interfaces below > that initiate CPU online/offline operations. > > - _debug_hotplug_cpu(), cpu0

Re: Large pastes into readline enabled programs causes breakage from v2.6.31 onwards

2013-08-17 Thread Margarita Manterola
Hi, On Sat, Aug 17, 2013 at 5:28 PM, Pavel Machek wrote: >> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c >> index 4bf0fc0..2ba7f4e 100644 >> --- a/drivers/tty/n_tty.c >> +++ b/drivers/tty/n_tty.c >> @@ -149,7 +149,8 @@ static int set_room(struct tty_struct *tty) >> *

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-17 Thread Tomasz Figa
On Sunday 18 of August 2013 08:09:36 Benjamin Herrenschmidt wrote: > On Sat, 2013-08-17 at 12:50 +0200, Tomasz Figa wrote: > > I wonder how would this handle uniprocessor ARM (pre-v7) cores, for > > which > > the updated bindings[1] define #address-cells = <0> and so no reg > > property. > > > >

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-17 Thread Benjamin Herrenschmidt
On Sat, 2013-08-17 at 12:50 +0200, Tomasz Figa wrote: > I wonder how would this handle uniprocessor ARM (pre-v7) cores, for > which > the updated bindings[1] define #address-cells = <0> and so no reg > property. > > [1] - http://thread.gmane.org/gmane.linux.ports.arm.kernel/260795 Why did you

[3.11-rc5..] NULL pointer dereference, lockup after XHCI device dropped out

2013-08-17 Thread Peter Wu
Hi, I hit a BUG followed by a lockup when trying to wipe a new external USB 3.0 1TB 2.5" "Western Digital My Passport" (WDBBEP0010BBK-EESN) HDD. The following command is used (with sudo): dd if=/dev/zero of=/dev/sdd bs=1M In another shell, I kept sending a USR1 signal to watch progress

[PATCH] um: ubd: Add REQ_FLUSH suppport

2013-08-17 Thread Richard Weinberger
UML's block device driver does not support write barriers, to support this this patch adds REQ_FLUSH suppport. Every time the block layer sends a REQ_FLUSH we fsync() now our backing file to guarantee data consistency. Cc: rjo...@redhat.com Signed-off-by: Richard Weinberger ---

[PATCH v3 5/8] watchdog: w83627hf: Auto-detect IO address and supported chips

2013-08-17 Thread Guenter Roeck
Instead of requiring the user to provide an IO address per module parameter, auto-detect it as well as supported chips. Signed-off-by: Guenter Roeck --- drivers/watchdog/Kconfig| 15 +++- drivers/watchdog/w83627hf_wdt.c | 182 ++- 2 files changed,

[PATCH v3 2/8] watchdog: w83627hf: Enable watchdog only once

2013-08-17 Thread Guenter Roeck
It is unnecessary to enable the logical device and WDT0 each time the watchdog is accessed. Do it only once during initialization. Signed-off-by: Guenter Roeck --- drivers/watchdog/w83627hf_wdt.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff

[PATCH v3 8/8] watchdog: w83627hf_wdt: Reset watchdog trigger during initialization

2013-08-17 Thread Guenter Roeck
If the watchdog has already triggered for whatever reason, it won't restart unless the trigger is reset. Signed-off-by: Guenter Roeck --- drivers/watchdog/w83627hf_wdt.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/w83627hf_wdt.c

[PATCH v3 4/8] watchdog: w83627hf: Use helper functions to access superio registers

2013-08-17 Thread Guenter Roeck
Use helper functions named similar to other drivers to access superio registers. Request memory region only when needed, and use request_muxed_region(). This lets other devices (hwmon, gpio) use the same region. Signed-off-by: Guenter Roeck --- drivers/watchdog/w83627hf_wdt.c | 132

[PATCH v3 1/8] watchdog: w83627hf: Convert to watchdog infrastructure

2013-08-17 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/watchdog/Kconfig|1 + drivers/watchdog/w83627hf_wdt.c | 225 +-- 2 files changed, 51 insertions(+), 175 deletions(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 362085d..c73db85

[PATCH v3 7/8] watchdog: Remove drivers for W83697HF and W83697UG

2013-08-17 Thread Guenter Roeck
Since both chips are now supported by the w83627hf watchdog driver, the chip specific drivers are no longer needed and can be removed. Signed-off-by: Guenter Roeck --- drivers/watchdog/Kconfig| 30 --- drivers/watchdog/Makefile |2 - drivers/watchdog/w83697hf_wdt.c | 461

[PATCH v3 6/8] watchdog: w83627hf: Add support for W83697HF and W83697UG

2013-08-17 Thread Guenter Roeck
Major difference is that the watchdog control and counter registers are different on both chips. Signed-off-by: Guenter Roeck --- drivers/watchdog/Kconfig|2 ++ drivers/watchdog/w83627hf_wdt.c | 62 +++ 2 files changed, 51 insertions(+), 13

[PATCH v3 3/8] watchdog: w83627hf: Enable watchdog device only if not already enabled

2013-08-17 Thread Guenter Roeck
There is no need to enable the watchdog device if it is already enabled. Also, when enabling the watchdog device, only set the watchdog device enable bit and do not touch other bits; depending on the chip type, those bits may enable other functionality. Signed-off-by: Guenter Roeck ---

[PATCH v3 0/8] watchdog: w83627hf: Convert to watchdog infrastructure

2013-08-17 Thread Guenter Roeck
Convert to watchdog infrastructure, cleanup, add support for additional chips, and merge with W83697HF and W83697UG watchdog drivers. Tested with W83627UHG, NCT6775, NCT6776. Original idea was to prepare the driver for use as a client to an MFD driver, but I found that requesting memory with

Re: arch/x86/kernel/cpu/intel.c needs an update for Haswell?

2013-08-17 Thread Ilari Stenroth
On 5.8.2013 5.59, H. Peter Anvin wrote: > On 08/04/2013 07:48 PM, Alex Shi wrote: >> >> Any comments on this, Peter? :) >> > > Sounds like you have done the measurements, so it seems fine. > > -hpa > I've been using these patches. No compalints. Should the patches get pulled to

  1   2   3   4   >