Re: [PATCH V3 11/11] Add option to automatically enforce module signatures when in Secure Boot mode

2013-09-03 Thread Matthew Garrett
On Wed, 2013-09-04 at 11:42 +1000, James Morris wrote: > On Tue, 3 Sep 2013, Matthew Garrett wrote: > > > + status = efi_call_phys5(sys_table->runtime->get_variable, > > + L"SecureBoot", &var_guid, NULL, &datasize, &sb); > > + > > > What's 'L' ? Wide-character string

Re: [PATCH V3 11/11] Add option to automatically enforce module signatures when in Secure Boot mode

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > + status = efi_call_phys5(sys_table->runtime->get_variable, > + L"SecureBoot", &var_guid, NULL, &datasize, &sb); > + What's 'L' ? -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-ke

RE: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-09-03 Thread Nelson, Shannon
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Tuesday, September 03, 2013 6:31 PM > > On Wed, 2013-09-04 at 01:00 +, Nelson, Shannon wrote: > > Hi Shannon. > > > > -Original Message- > From: Joe Perches > > [mailto:j...@perches.com] > Sent: Friday

Re: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-09-03 Thread Joe Perches
On Wed, 2013-09-04 at 01:00 +, Nelson, Shannon wrote: Hi Shannon. > > -Original Message- > From: Joe Perches > [mailto:j...@perches.com] > Sent: Friday, August 30, 2013 4:06 PM > > > Just some potential cleanings... > > > i40e: Whitespace cleaning > > Hmmm, we hadn't noticed the n

[RELEASE] LTTng modules 2.3.0

2013-09-03 Thread Mathieu Desnoyers
The LTTng modules provide Linux kernel tracing capability to the LTTng 2.x tracer toolset. Noteworthy changes: - Support for Linux kernels up to (including) 3.11, - Flight recorder (snapshot) support, - Updated ARM, x86 system call instrumentation, - Add 32-bit PowerPC system call instrumentation.

Re: [PATCH-v5 1/6] idr: Percpu ida

2013-09-03 Thread Andrew Morton
On Tue, 03 Sep 2013 09:06:58 -0700 "Nicholas A. Bellinger" wrote: > Are there any other review comments to be addressed for this patch..? > > If not, please kindly give your Reviewed-by if your OK for an initial > standalone merge. Sorry, I'm largely offline for the next week... It looks OK t

Re: [RFC][PATCH 19/18] ftrace: Print a message when the rcu checker is disabled

2013-09-03 Thread Paul E. McKenney
On Tue, Sep 03, 2013 at 09:11:27PM -0400, Steven Rostedt wrote: > From f8f5d278e272c42349b3cd32485faf426d0c459e Mon Sep 17 00:00:00 2001 > From: "Steven Rostedt (Red Hat)" > Date: Tue, 3 Sep 2013 20:47:59 -0400 > Subject: [PATCH] ftrace: Print a message when the rcu checker is disabled > > Let th

Re: [RFC][PATCH 01/18 v2] ftrace: Add hash list to save RCU unsafe functions

2013-09-03 Thread Paul E. McKenney
On Tue, Sep 03, 2013 at 07:57:05PM -0400, Steven Rostedt wrote: > On Tue, 3 Sep 2013 15:18:08 -0700 > "Paul E. McKenney" wrote: > > > > > Just found this bug. Strange that gcc never gave me a warning :-/ > > > > I can't give gcc too much trouble, as I also didn't give you an > > uninitialized-v

[PATCH] x86/irq: correct comment about i8259 initialization

2013-09-03 Thread Yanchuan Nian
From: Yanchuan Nian 0x30-0x3f have been used for ISA interrupts on i386 since 5 years ago, but some comments about i8259 initialization were missed to update at the same time. Signed-off-by: Yanchuan Nian --- arch/x86/kernel/i8259.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [PATCH 3/3] extcon: Simplify extcon_dev_register() prototype by removing unnecessary parameter

2013-09-03 Thread Greg KH
On Wed, Sep 04, 2013 at 09:17:02AM +0900, Chanwoo Choi wrote: > On 09/04/2013 12:57 AM, Greg KH wrote: > > On Mon, Sep 02, 2013 at 10:13:44AM +0900, Chanwoo Choi wrote: > >> Hi Greg, > >> > >> On 09/02/2013 09:40 AM, Greg KH wrote: > >>> On Mon, Sep 02, 2013 at 09:20:08AM +0900, Chanwoo Choi wrote:

[RFC][PATCH 19/18] ftrace: Print a message when the rcu checker is disabled

2013-09-03 Thread Steven Rostedt
>From f8f5d278e272c42349b3cd32485faf426d0c459e Mon Sep 17 00:00:00 2001 From: "Steven Rostedt (Red Hat)" Date: Tue, 3 Sep 2013 20:47:59 -0400 Subject: [PATCH] ftrace: Print a message when the rcu checker is disabled Let the user know that the RCU safety checker for function tracing has been disab

Re: [tip:x86/smap] Introduce [compat_]save_altstack_ex() to unbreak x86 SMAP

2013-09-03 Thread Stephen Rothwell
On Sun, 1 Sep 2013 14:45:56 -0700 tip-bot for Al Viro wrote: > > Commit-ID: bd1c149aa9915b9abb6d83d0f01dfd2ace0680b5 > Gitweb: http://git.kernel.org/tip/bd1c149aa9915b9abb6d83d0f01dfd2ace0680b5 > Author: Al Viro > AuthorDate: Sun, 1 Sep 2013 20:35:01 +0100 > Committer: H. Peter Anvin >

Re: [RFC, 14/18, v2] ftrace/lockdep: Have the RCU lockdep splat show what function triggered

2013-09-03 Thread Steven Rostedt
On Sun, 01 Sep 2013 16:28:36 +0800 Wang Shilong wrote: > Hello, Using checkpatch.pl, i get the following warnings(errors): > WARNING: printk() should include KERN_ facility level > #90: FILE: kernel/trace/trace_functions.c:583: > + printk("ftrace_rcu_func: %pS\n", > > total: 0 errors

Re: [PATCH trivial] UAPI: Kbuild: add/modify comments for "uapi/Kbuild" and "uapi/linux/Kbuild"

2013-09-03 Thread Chen Gang
On 09/04/2013 12:41 AM, Geert Uytterhoeven wrote: > On Tue, Aug 6, 2013 at 3:46 AM, Chen Gang wrote: >> --- a/include/uapi/Kbuild >> +++ b/include/uapi/Kbuild >> @@ -1,7 +1,6 @@ >> # UAPI Header export list >> -# Top-level Makefile calls into asm-$(ARCH) >> -# List only non-arch directories below

Re: [PATCH 1/3] autofs4 - fix device ioctl mount lookup

2013-09-03 Thread Al Viro
On Wed, Sep 04, 2013 at 08:54:57AM +0800, Ian Kent wrote: > +static int kern_path_top(const char *pathname, > + unsigned int flags, struct path *path) > +{ > + struct dentry *dentry; > + struct qstr name; > + const char *tmp; > + unsigned int len; > + int er

Re: [PATCH 06/11] memblock: Improve memblock to support allocation from lower address.

2013-09-03 Thread Tang Chen
On 09/04/2013 08:24 AM, Toshi Kani wrote: .. +phys_addr_t __init_memblock +__memblock_find_range(phys_addr_t start, phys_addr_t end, + phys_addr_t size, phys_addr_t align, int nid) This func should be static as it must be an internal func. .. +phys_addr_t __init_m

RE: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-09-03 Thread Nelson, Shannon
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, August 30, 2013 4:06 PM > > Just some potential cleanings... > i40e: Whitespace cleaning Hmmm, we hadn't noticed the new experimental "--fix" option before. There are a lot of good suggestions there, b

[PATCH 3/3] autofs: use IS_ROOT to replace root dentry checks

2013-09-03 Thread Ian Kent
From: Rui Xiang Use the helper macro !IS_ROOT to replace parent != dentry->d_parent. Just clean up. Signed-off-by: Rui Xiang Acked-by: Ian Kent --- fs/autofs4/root.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c index 92ef34

[PATCH 2/3] autofs: fix the return value of autofs4_fill_super

2013-09-03 Thread Ian Kent
From: Rui Xiang While kzallocing sbi/ino fails, it should return -ENOMEM. And it should return the err value from autofs_prepare_pipe. Signed-off-by: Rui Xiang Acked-by: Ian Kent --- fs/autofs4/inode.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/fs/aut

[PATCH 1/3] autofs4 - fix device ioctl mount lookup

2013-09-03 Thread Ian Kent
When reconnecting to automounts at startup an autofs ioctl is used to find the device and inode of existing mounts so they can be used to open a file descriptor of possibly covered mounts. At this time the the caller might not yet "own" the mount so it can trigger calling ->d_automount(). This cau

Re: [PATCH 4/4] clk: tegra114: table driven PMC clock init

2013-09-03 Thread Joseph Lo
On Tue, 2013-09-03 at 21:31 +0800, Peter De Schrijver wrote: > This patch converts the Tegra114 audio clock registration to be table driven > like the periph clocks. s/audio/PMC/ :) > > Signed-off-by: Peter De Schrijver > --- > drivers/clk/tegra/clk-tegra114.c | 58 > +++--

Re: [Ksummit-2013-discuss] [PATCH] checkpatch: Add comment about updating Documentation/CodingStyle

2013-09-03 Thread Fengguang Wu
On Tue, Sep 03, 2013 at 12:09:31PM -0600, Bjorn Helgaas wrote: > On Mon, Sep 2, 2013 at 6:39 PM, Fengguang Wu wrote: > > > Thanks! Yes I'm now running checkpatch these days because some people > > suggested to me that some of the checkpatch warnings do help catch > > real bugs. > > > > However I

Re: [PATCH V3 10/11] x86: Restrict MSR access when module loading is restricted

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > Writing to MSRs should not be allowed if module loading is restricted, > since it could lead to execution of arbitrary code in kernel mode. Based > on a patch by Kees Cook. > > Cc: Kees Cook > Signed-off-by: Matthew Garrett Reviewed-by: James Morri

Re: [PATCH V3 08/11] kexec: Disable at runtime if the kernel enforces module loading restrictions

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > kexec permits the loading and execution of arbitrary code in ring 0, which > is something that module signing enforcement is meant to prevent. It makes > sense to disable kexec in this situation. > > Signed-off-by: Matthew Garrett Reviewed-by: James

Re: [PATCH V3 09/11] uswsusp: Disable when module loading is restricted

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > uswsusp allows a user process to dump and then restore kernel state, which > makes it possible to avoid module loading restrictions. Prevent this when > any restrictions have been imposed on loading modules. > > Signed-off-by: Matthew Garrett Review

Re: [PATCH V3 06/11] Restrict /dev/mem and /dev/kmem when module loading is restricted

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > Allowing users to write to address space makes it possible for the kernel > to be subverted, avoiding module loading restrictions. Prevent this when > any restrictions have been imposed on loading modules. > > Signed-off-by: Matthew Garrett Reviewed

Re: [PATCH V3 05/11] asus-wmi: Restrict debugfs interface when module loading is restricted

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > We have no way of validating what all of the Asus WMI methods do on a > given machine, and there's a risk that some will allow hardware state to > be manipulated in such a way that arbitrary code can be executed in the > kernel, circumventing module loa

Re: [PATCH V3 03/11] x86: Lock down IO port access when module security is enabled

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > IO port access would permit users to gain access to PCI configuration > registers, which in turn (on a lot of hardware) give access to MMIO register > space. This would potentially permit root to trigger arbitrary DMA, so lock > it down by default. > >

Re: [PATCH V3 04/11] ACPI: Limit access to custom_method

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > custom_method effectively allows arbitrary access to system memory, making > it possible for an attacker to circumvent restrictions on module loading. > Disable it if any such restrictions have been enabled. > > Signed-off-by: Matthew Garrett Reviewe

Re: [PATCH V3 02/11] PCI: Lock down BAR access when module security is enabled

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > Any hardware that can potentially generate DMA has to be locked down from > userspace in order to avoid it being possible for an attacker to modify > kernel code, allowing them to circumvent disabled module loading or module > signing. Default to parano

Re: [PATCH V3 01/11] Add secure_modules() call

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, Matthew Garrett wrote: > Provide a single call to allow kernel code to determine whether the system > has been configured to either disable module loading entirely or to load > only modules signed with a trusted key. > > Signed-off-by: Matthew Garrett Reviewed-by: James Morr

Re: [GIT PULL] Expand keyring capacity and provide support for libkrb5

2013-09-03 Thread James Morris
On Tue, 3 Sep 2013, David Howells wrote: > James Morris wrote: > > > > Ummm... Where did that come from? That doesn't look like what's in my > > > tree... > > > > Is your tree based on mine? > > It is now. See: > > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/

Re: [PATCH 07/11] x86, memblock: Set lowest limit for memblock_alloc_base_nid().

2013-09-03 Thread Toshi Kani
On Tue, 2013-08-27 at 17:37 +0800, Tang Chen wrote: > memblock_alloc_base_nid() is a common API of memblock. And it calls > memblock_find_in_range_node() with %start = 0, which means it has no > limit for the lowest address by default. > > memblock_find_in_range_node(0, max_addr, size, align

drivers/char/hpet.c ACPI parsing

2013-09-03 Thread Tomas Winkler
In hpet_resources function Can anybody explain why we check fixmem32 for NULL, looks strange as it derreferences a member address I'm asking since a static analyzer is complaining about it. } else if (res->id == ACPI_RSTYPE_FIXED_MEM32) { struct acpi_resource_fixed_mem32 *f

[PATCH] kernel-doc: Update script to find more "Return:" sections

2013-09-03 Thread Joe Perches
Many kernel-doc return description sections headers use variants of the "Return:" section prefix. (some or maybe even most of these aren't in kernel-doc sections, but many are) $ git grep -E -i "^\s*\*\s*return[s]?:"| \ cut -f2- -d":" | awk '{print $1 $2}' | \ sort | uniq -c 121 *return:

I Need Your Assistance.

2013-09-03 Thread Dr.Malik Wasim
Dear Friend, I am Dr.Malik Wasim, Manager Auditing and Accountancy Department, Bank of Africa in (B.O.A) Burkina Faso. I got your email account while searching for a business oriented personality and you happen to be the one. I bring forth a business proposal in the tune of $12.5 million U.S. dol

Re: [PATCH 06/11] memblock: Improve memblock to support allocation from lower address.

2013-09-03 Thread Toshi Kani
On Tue, 2013-08-27 at 17:37 +0800, Tang Chen wrote: > This patch modifies the memblock_find_in_range_node() to support two > different allocation orders. After this patch, memblock will check > memblock.current_order, and decide in which order to allocate memory. > > Signed-off-by: Tang Chen > Re

Re: ipv4: warnings on sk_wmem_queued

2013-09-03 Thread Eric Wong
dormando wrote: > > I noticed these warnings on stock 3.10.9 running stress tests on > > cmogstored.git (git://bogomips.org/cmogstored.git) doing standard > > HTTP server stuff between lo and tmpfs: > > > [...] > > I was going to reboot into 3.10.10 before I looked at dmesg. These > > warnings ha

Re: [RFC][PATCH 01/18 v2] ftrace: Add hash list to save RCU unsafe functions

2013-09-03 Thread Steven Rostedt
On Tue, 3 Sep 2013 19:57:05 -0400 Steven Rostedt wrote: > I was also chasing down a nasty bug that looked to be a pointer > corruption somewhere. Still never found exactly where it happened, but > it always happened with the following conditions: > > synchronize_sched() was in progress > > The

Re: [RFC][PATCH 17/18 v2] ftrace/cpuidle/x86: Mark functions that are RCU unsafe

2013-09-03 Thread H. Peter Anvin
On 08/30/2013 10:11 PM, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > Some callbacks of the function tracer use rcu_read_lock(). This means that > there's places that can not be traced because RCU is not tracking the CPU > for various reasons (like NO_HZ_FULL and coming back from u

Re: [PATCH 3/3] extcon: Simplify extcon_dev_register() prototype by removing unnecessary parameter

2013-09-03 Thread Chanwoo Choi
On 09/04/2013 12:57 AM, Greg KH wrote: > On Mon, Sep 02, 2013 at 10:13:44AM +0900, Chanwoo Choi wrote: >> Hi Greg, >> >> On 09/02/2013 09:40 AM, Greg KH wrote: >>> On Mon, Sep 02, 2013 at 09:20:08AM +0900, Chanwoo Choi wrote: This patch remove extcon_dev_register()'s second parameter which mea

drivers/char/hpet.c check

2013-09-03 Thread Tomas Winkler
In hpet_resources function Can anybody explain why we check fixmem32 for NULL, looks strange as it derreferences a member address I'm asking since a static analyzer is complaining about it. } else if (res->id == ACPI_RSTYPE_FIXED_MEM32) { struct acpi_resource_fixed_mem32 *f

[PATCH net-next 1/2] bridge: prevent flooding IPv6 packets that do not have a listener

2013-09-03 Thread Linus Lüssing
Currently if there is no listener for a certain group then IPv6 packets for that group are flooded on all ports, even though there might be no host and router interested in it on a port. With this commit they are only forwarded to ports with a multicast router. Just like commit bd4265fe36 ("bridg

bride: IPv6 multicast snooping enhancements

2013-09-03 Thread Linus Lüssing
Hi, Here are two, small feature changes I would like to submit to increase the usefulness of the multicast snooping of the bridge code. The first patch is an unaltered one I had submitted before, but since it got no feedback I'm resubmitting it here for net-next. With the recently added patch to

[PATCH net-next 2/2] bridge: apply multicast snooping to IPv6 link-local, too

2013-09-03 Thread Linus Lüssing
The multicast snooping code should have matured enough to be safely applicable to IPv6 link-local multicast addresses (excluding the link-local all nodes address, ff02::1), too. Signed-off-by: Linus Lüssing --- net/bridge/br_mdb.c |3 ++- net/bridge/br_multicast.c |7 --- net/b

[PATCH V3 11/11] Add option to automatically enforce module signatures when in Secure Boot mode

2013-09-03 Thread Matthew Garrett
UEFI Secure Boot provides a mechanism for ensuring that the firmware will only load signed bootloaders and kernels. Certain use cases may also require that all kernel modules also be signed. Add a configuration option that enforces this automatically when enabled. Signed-off-by: Matthew Garrett -

[PATCH V3 10/11] x86: Restrict MSR access when module loading is restricted

2013-09-03 Thread Matthew Garrett
Writing to MSRs should not be allowed if module loading is restricted, since it could lead to execution of arbitrary code in kernel mode. Based on a patch by Kees Cook. Cc: Kees Cook Signed-off-by: Matthew Garrett --- arch/x86/kernel/msr.c | 7 +++ 1 file changed, 7 insertions(+) diff --gi

Re: [PATCH] f2fs: optimize gc for better performance

2013-09-03 Thread Jin Xu
Hi Jaegeuk, On 03/09/2013 08:45, Jaegeuk Kim wrote: Hi Jin, [...] It seems that we can obtain the performance gain just by setting the MAX_VICTIM_SEARCH to 4096, for example. So, how about just adding an ending criteria like below? I agree that we could get the performance improvement by

Re: linux-next: build warning after merge of the pci tree

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 3, 2013 at 5:55 PM, Stephen Rothwell wrote: > Hi Bjorn, > > You have sent a pull request to Linus for the pci tree, but at the same > time you have reset the branch I pull into linux-next to be v3.11. So > you have effectively removed all that code from linux-next until Linus' > merge

Re: [RFC][PATCH 01/18 v2] ftrace: Add hash list to save RCU unsafe functions

2013-09-03 Thread Steven Rostedt
On Tue, 3 Sep 2013 15:18:08 -0700 "Paul E. McKenney" wrote: > > Just found this bug. Strange that gcc never gave me a warning :-/ > > I can't give gcc too much trouble, as I also didn't give you an > uninitialized-variable warning. I was also chasing down a nasty bug that looked to be a pointe

linux-next: build warning after merge of the pci tree

2013-09-03 Thread Stephen Rothwell
Hi Bjorn, You have sent a pull request to Linus for the pci tree, but at the same time you have reset the branch I pull into linux-next to be v3.11. So you have effectively removed all that code from linux-next until Linus' merges it :-( Ordering is important. -- Cheers, Stephen Rothwell

[PATCH V3 04/11] ACPI: Limit access to custom_method

2013-09-03 Thread Matthew Garrett
custom_method effectively allows arbitrary access to system memory, making it possible for an attacker to circumvent restrictions on module loading. Disable it if any such restrictions have been enabled. Signed-off-by: Matthew Garrett --- drivers/acpi/custom_method.c | 3 +++ 1 file changed, 3 i

[PATCH V3 03/11] x86: Lock down IO port access when module security is enabled

2013-09-03 Thread Matthew Garrett
IO port access would permit users to gain access to PCI configuration registers, which in turn (on a lot of hardware) give access to MMIO register space. This would potentially permit root to trigger arbitrary DMA, so lock it down by default. Signed-off-by: Matthew Garrett --- arch/x86/kernel/io

[PATCH V3 05/11] asus-wmi: Restrict debugfs interface when module loading is restricted

2013-09-03 Thread Matthew Garrett
We have no way of validating what all of the Asus WMI methods do on a given machine, and there's a risk that some will allow hardware state to be manipulated in such a way that arbitrary code can be executed in the kernel, circumventing module loading restrictions. Prevent that if any of these feat

[PATCH V3 06/11] Restrict /dev/mem and /dev/kmem when module loading is restricted

2013-09-03 Thread Matthew Garrett
Allowing users to write to address space makes it possible for the kernel to be subverted, avoiding module loading restrictions. Prevent this when any restrictions have been imposed on loading modules. Signed-off-by: Matthew Garrett --- drivers/char/mem.c | 6 ++ 1 file changed, 6 insertions

[PATCH V3 01/11] Add secure_modules() call

2013-09-03 Thread Matthew Garrett
Provide a single call to allow kernel code to determine whether the system has been configured to either disable module loading entirely or to load only modules signed with a trusted key. Signed-off-by: Matthew Garrett --- include/linux/module.h | 7 +++ kernel/module.c| 10

[PATCH V3 02/11] PCI: Lock down BAR access when module security is enabled

2013-09-03 Thread Matthew Garrett
Any hardware that can potentially generate DMA has to be locked down from userspace in order to avoid it being possible for an attacker to modify kernel code, allowing them to circumvent disabled module loading or module signing. Default to paranoid - in future we can potentially relax this for suf

[PATCH V3 07/11] acpi: Ignore acpi_rsdp kernel parameter when module loading is restricted

2013-09-03 Thread Matthew Garrett
From: Josh Boyer This option allows userspace to pass the RSDP address to the kernel, which makes it possible for a user to circumvent any restrictions imposed on loading modules. Disable it in that case. Signed-off-by: Josh Boyer --- drivers/acpi/osl.c | 3 ++- 1 file changed, 2 insertions(+)

[PATCH V3 09/11] uswsusp: Disable when module loading is restricted

2013-09-03 Thread Matthew Garrett
uswsusp allows a user process to dump and then restore kernel state, which makes it possible to avoid module loading restrictions. Prevent this when any restrictions have been imposed on loading modules. Signed-off-by: Matthew Garrett --- kernel/power/user.c | 4 1 file changed, 4 insertion

[PATCH V3 08/11] kexec: Disable at runtime if the kernel enforces module loading restrictions

2013-09-03 Thread Matthew Garrett
kexec permits the loading and execution of arbitrary code in ring 0, which is something that module signing enforcement is meant to prevent. It makes sense to disable kexec in this situation. Signed-off-by: Matthew Garrett --- kernel/kexec.c | 8 1 file changed, 8 insertions(+) diff --

[no subject]

2013-09-03 Thread Matthew Garrett
We have two in-kernel mechanisms for restricting module loading - disabling it entirely, or limiting it to the loading of modules signed with a trusted key. These can both be configured in such a way that even root is unable to relax the restrictions. However, right now, there's several other stra

Re: [PATCH 2/7] scsi/csiostor: use pcie_capability_xxx to simplify code

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 03, 2013 at 03:35:10PM +0800, Yijing Wang wrote: > Pcie_capability_xxx() interfaces were introudced to s/introudced/introduced/ > simplify code to access PCIe Cap config space. And > because PCI core saves the PCIe Cap offset in > set_pcie_port_type() when device is enumerated. > So w

Re: [PATCH 1/7] scsi/bfa: use pcie_capability_xxx to simplify code

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 03, 2013 at 03:35:09PM +0800, Yijing Wang wrote: > Pcie_capability_xxx() interfaces were introudced to > simplify code to access PCIe Cap config space. And > because PCI core saves the PCIe Cap offset in > set_pcie_port_type() when device is enumerated. > So we can use pci_is_pcie() ins

Very profitable project

2013-09-03 Thread Mr. Martin Bongani Sibisiso
Good day, Kindly peruse the attached letter and follow the instruction therein. Regard, Name: Mr. Martin Bongani Sibisiso Position: Director - General Department of Trade and Industry (dti) Republic of South Africa Phone: 00(27)-82-350-2862 Official Email: marti...@postafiok.hu Project.pdf Des

[PATCH v2] of_irq.h: fix build warnings when CONFIG_OF is not enabled

2013-09-03 Thread Randy Dunlap
From: Randy Dunlap Fix build warnings when CONFIG_OF is not enabled: (seen on i386 and x86_64) include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside parameter list [enabled by default] include/linux/of_irq.h:82:7: warning: its scope is only this definition or declaration,

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-09-03 Thread Sedat Dilek
On Wed, Sep 4, 2013 at 1:15 AM, Dave Jones wrote: > On Wed, Sep 04, 2013 at 01:05:38AM +0200, Sedat Dilek wrote: > > On Wed, Sep 4, 2013 at 12:55 AM, Dave Jones wrote: > > > On Wed, Sep 04, 2013 at 12:37:25AM +0200, Sedat Dilek wrote: > > > > > > > > You're spending more time on the task sta

Re: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled

2013-09-03 Thread Randy Dunlap
On 09/03/13 15:31, Rob Herring wrote: > On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix build warnings when CONFIG_OF is not enabled: > > It would be nice to know what arch/config you see this on. i386 and x86_64. > >> include/linux/of_irq.h:82:7: warning:

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-09-03 Thread Dave Jones
On Wed, Sep 04, 2013 at 01:05:38AM +0200, Sedat Dilek wrote: > On Wed, Sep 4, 2013 at 12:55 AM, Dave Jones wrote: > > On Wed, Sep 04, 2013 at 12:37:25AM +0200, Sedat Dilek wrote: > > > > > > You're spending more time on the task stats than on the actual lookup. > > > > Maybe you should turn

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-09-03 Thread Sedat Dilek
On Wed, Sep 4, 2013 at 12:41 AM, Sedat Dilek wrote: > On Tue, Sep 3, 2013 at 5:14 PM, Waiman Long wrote: >> On 09/03/2013 02:01 AM, Ingo Molnar wrote: >>> >>> * Waiman Long wrote: >>> Yes, that patch worked. It eliminated the lglock as a bottleneck in the AIM7 workload. The lg_global_l

[PATCH 2/2] ceph: page still marked private_2

2013-09-03 Thread Milosz Tanski
Previous patch that allowed us to cleanup most of the issues with pages marked as private_2 when calling ceph_readpages. However, there seams to be a case in the error case clean up in start read that still trigers this from time to time. I've only seen this one a couple times. BUG: Bad page state

Re: [PATCH] pci.h: Fix typo, remove unnecessary !!

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 03, 2013 at 01:31:05PM -0700, Joe Perches wrote: > Use normal kernel-doc "Returns:" instead of retruns > Assignment to bool is always 1 or 0 so the !! isn't necessary. > > Signed-off-by: Joe Perches Applied to pci/misc, thanks. This branch will be rebased and will not appear in -nex

[PATCH 1/2] ceph: ceph_readpage_to_fscache didn't check if marked

2013-09-03 Thread Milosz Tanski
Previously ceph_readpage_to_fscache did not call if page was marked as cached before calling fscache_write_page resulting in a BUG inside of fscache. FS-Cache: Assertion failed [ cut here ] kernel BUG at fs/fscache/page.c:874! invalid opcode: [#1] SMP Call Trace: [] _

[PATCH 0/2] fscache fixes for ceph

2013-09-03 Thread Milosz Tanski
On the whole the current iteration of FSCache on Ceph has been quite stable for me. We've had it deployed on 4 clients running for a week in a row. I did run into two small issues. First one, I wasn't checking if the page was marked with private_2 before asking FSCache to write to it. I've never s

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-09-03 Thread Sedat Dilek
On Wed, Sep 4, 2013 at 12:55 AM, Dave Jones wrote: > On Wed, Sep 04, 2013 at 12:37:25AM +0200, Sedat Dilek wrote: > > > > You're spending more time on the task stats than on the actual lookup. > > > Maybe you should turn off CONFIG_TASKSTATS..But why that whole > > > irq_return thing? Odd. > >

[gcv v4 11/38] tracing: Replace __get_cpu_var uses

2013-09-03 Thread Christoph Lameter
__get_cpu_var() is used for multiple purposes in the kernel source. One of them is address calculation via the form &__get_cpu_var(x). This calculates the address for the instance of the percpu variable of the current processor based on an offset. Other use cases are for storing and retrieving d

[gcv v4 08/38] time: Replace __get_cpu_var uses

2013-09-03 Thread Christoph Lameter
__get_cpu_var() is used for multiple purposes in the kernel source. One of them is address calculation via the form &__get_cpu_var(x). This calculates the address for the instance of the percpu variable of the current processor based on an offset. Other use cases are for storing and retrieving d

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-09-03 Thread Sedat Dilek
On Tue, Sep 3, 2013 at 5:14 PM, Waiman Long wrote: > On 09/03/2013 02:01 AM, Ingo Molnar wrote: >> >> * Waiman Long wrote: >> >>> Yes, that patch worked. It eliminated the lglock as a bottleneck in the >>> AIM7 workload. The lg_global_lock did not show up in the perf profile, >>> whereas the lg_l

[GIT PULL] cgroup changes for v3.12-rc1

2013-09-03 Thread Tejun Heo
Hello, Linus. A lot of activities on the cgroup front. Most changes aren't visible to userland at all at this point and are laying foundation for the planned unified hierarchy. * The biggest change is decoupling the lifetime management of css (cgroup_subsys_state) from that of cgroup's. Becau

Re: Linux 3.11

2013-09-03 Thread Linus Torvalds
On Tue, Sep 3, 2013 at 2:46 PM, Nicholas A. Bellinger wrote: > > Ok, so another PULL request was sent out last night for the missing > target fixes below, after putting DKIM + SPF authentication in place for > linux-iscsi.org: > > [GIT PULL -v3] target fixes for v3.12-rc0 (was v3.11) > http://marc

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-09-03 Thread Dave Jones
On Wed, Sep 04, 2013 at 12:37:25AM +0200, Sedat Dilek wrote: > > You're spending more time on the task stats than on the actual lookup. > > Maybe you should turn off CONFIG_TASKSTATS..But why that whole > > irq_return thing? Odd. > > > > [ init/Kconfig ] > ... > config TASKSTATS >

[gcv v4 05/38] percpu: Add preemption checks to __this_cpu ops

2013-09-03 Thread Christoph Lameter
We define a check function in order to avoid trouble with the include files. Then the higher level __this_cpu macros are modified to involve the check before any operation. Signed-off-by: Christoph Lameter Index: linux/include/linux/percpu.h ==

Re: Linux 3.11

2013-09-03 Thread Nicholas A. Bellinger
On Tue, 2013-09-03 at 15:44 -0700, Linus Torvalds wrote: > On Tue, Sep 3, 2013 at 2:46 PM, Nicholas A. Bellinger > wrote: > > > > Ok, so another PULL request was sent out last night for the missing > > target fixes below, after putting DKIM + SPF authentication in place for > > linux-iscsi.org: >

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-09-03 Thread Sedat Dilek
On Sun, Sep 1, 2013 at 5:32 PM, Linus Torvalds wrote: > On Sun, Sep 1, 2013 at 3:01 AM, Sedat Dilek wrote: >> >> Looks like this is now 10x faster: ~2.66Mloops (debug) VS. >> ~26.60Mloops (no-debug). > > Ok, that's getting to be in the right ballpark. > > But your profile is still odd. > >> Sampl

Re: [PATCH] mm/vmscan: make global_reclaim() inline

2013-09-03 Thread Johannes Weiner
On Thu, Aug 22, 2013 at 01:39:56PM +0800, larmbr wrote: > Though Gcc is likely to inline them, we should better > explictly do it manually, and also, this serve to document > this fact. Why? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to maj

Re: [PATCH 1/2] hwspinlock/omap: add support for dt nodes

2013-09-03 Thread Suman Anna
Kumar, >> >> On 09/03/2013 01:50 PM, Kumar Gala wrote: >>> >>> On Sep 3, 2013, at 12:52 PM, Suman Anna wrote: >>> HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes

Re: [PATCH] memcg: fix multiple large threshold notifications

2013-09-03 Thread Johannes Weiner
On Sat, Aug 31, 2013 at 05:06:42PM -0700, Greg Thelen wrote: > A memory cgroup with (1) multiple threshold notifications and (2) at > least one threshold >=2G was not reliable. Specifically the > notifications would either not fire or would not fire in the proper > order. > > The __mem_cgroup_thr

Re: ipc msg now works (was Re: ipc-msg broken again on 3.11-rc7?)

2013-09-03 Thread Sedat Dilek
On Tue, Sep 3, 2013 at 12:32 PM, Vineet Gupta wrote: > On 09/03/2013 03:47 PM, Manfred Spraul wrote: >> Hi Vineet, >> >> On 09/03/2013 11:51 AM, Vineet Gupta wrote: >>> On 09/03/2013 02:53 PM, Manfred Spraul wrote: The access to msq->q_cbytes is not protected. Vineet, could you try

Re: [PATCH RESEND] mm/vmscan : use vmcan_swappiness( ) basing on MEMCG config to elimiate unnecessary runtime cost

2013-09-03 Thread Johannes Weiner
On Mon, Aug 26, 2013 at 09:36:58PM +0800, larmbr wrote: > Currently, we get the vm_swappiness via vmscan_swappiness(), which > calls global_reclaim() to check if this is a global reclaim. > > Besides, the current implementation of global_reclaim() always returns > true for the !CONFIG_MEGCG case

Re: [PATCH 5/5] perf, x86: Support Haswell v4 LBR format v2

2013-09-03 Thread Andi Kleen
On Tue, Sep 03, 2013 at 05:14:51PM -0400, Vince Weaver wrote: > On Tue, 3 Sep 2013, Andi Kleen wrote: > > > > > + PERF_SAMPLE_BRANCH_ABORT_TX = 1U << 7, /* transaction > > > > aborts */ > > > > + PERF_SAMPLE_BRANCH_IN_TX= 1U << 8, /* in transaction */ > > > > + PERF_

[gcv v4 14/38] percpu: Replace __get_cpu_var uses

2013-09-03 Thread Christoph Lameter
__get_cpu_var() is used for multiple purposes in the kernel source. One of them is address calculation via the form &__get_cpu_var(x). This calculates the address for the instance of the percpu variable of the current processor based on an offset. Other use cases are for storing and retrieving d

Re: [PATCH] memcg: fix multiple large threshold notifications

2013-09-03 Thread Kirill A. Shutemov
On Sat, Aug 31, 2013 at 05:06:42PM -0700, Greg Thelen wrote: > A memory cgroup with (1) multiple threshold notifications and (2) at > least one threshold >=2G was not reliable. Specifically the > notifications would either not fire or would not fire in the proper > order. > > The __mem_cgroup_thr

Re: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled

2013-09-03 Thread Rob Herring
On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build warnings when CONFIG_OF is not enabled: It would be nice to know what arch/config you see this on. > include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside > parameter list [enabled by d

Re: [RFC][PATCH 01/18 v2] ftrace: Add hash list to save RCU unsafe functions

2013-09-03 Thread Paul E. McKenney
On Tue, Sep 03, 2013 at 05:15:16PM -0400, Steven Rostedt wrote: > On Sat, 31 Aug 2013 01:11:18 -0400 > Steven Rostedt wrote: > > > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > > index a6d098c..3750360 100644 > > --- a/kernel/trace/ftrace.c > > +++ b/kernel/trace/ftrace.c > > @@

Re: Unusually high system CPU usage with recent kernels

2013-09-03 Thread Paul E. McKenney
On Tue, Sep 03, 2013 at 11:11:01PM +0200, Tibor Billes wrote: > > From: Paul E. McKenney Sent: 08/30/13 03:24 AM > > On Tue, Aug 27, 2013 at 10:05:42PM +0200, Tibor Billes wrote: > > > From: Paul E. McKenney Sent: 08/26/13 06:28 AM > > > > Here is a patch that is more likely to help. I am testing i

Re: usb: host: Faraday fotg210-hcd driver

2013-09-03 Thread Greg KH
On Tue, Sep 03, 2013 at 05:32:05PM -0400, Dave Jones wrote: > On Tue, Sep 03, 2013 at 02:23:55PM -0700, Greg KH wrote: > > > > > +config USB_FOTG210_HCD > > > > + tristate "FOTG210 HCD support" > > > > + depends on USB > > > > + default N > > > > + ---help--- > > > > +

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-09-03 Thread Linus Torvalds
On Tue, Sep 3, 2013 at 2:34 PM, Linus Torvalds wrote: > > I'll try to hack that up too, but it's looking like it really is just > the "lock xadd", not the memory dependency chain.. Yeah, no difference: Better code generation with my quick hack for a percpu spinlock: │81078e70

Re: usb: host: Faraday fotg210-hcd driver

2013-09-03 Thread Greg KH
On Tue, Sep 03, 2013 at 05:46:26PM -0400, Dave Jones wrote: > On Tue, Sep 03, 2013 at 02:40:09PM -0700, Greg KH wrote: > > On Tue, Sep 03, 2013 at 05:32:05PM -0400, Dave Jones wrote: > > > > PS: What happened with this driver ? > > > > > > This patch landed twice in your tree, once in > 1dd

Restrict AM335x PHY driver to only be built on !ARM when COMPILE_TEST is set.

2013-09-03 Thread Dave Jones
Signed-off-by: Dave Jones diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index d5589f9..51ffe11 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -93,6 +93,7 @@ config AM335X_CONTROL_USB config AM335X_PHY_USB tristate "AM335x USB PHY Driver" +

Re: usb: host: Faraday fotg210-hcd driver

2013-09-03 Thread Dave Jones
On Tue, Sep 03, 2013 at 02:40:09PM -0700, Greg KH wrote: > On Tue, Sep 03, 2013 at 05:32:05PM -0400, Dave Jones wrote: > > PS: What happened with this driver ? > > > > This patch landed twice in your tree, once in > > 1dd3d123239179fad5de5dc00a6e0014a1918fde from Yuan-Hsin Chen > > > >

Re: fix typo in usb serial simple driver Kconfig

2013-09-03 Thread Greg KH
On Tue, Sep 03, 2013 at 05:18:38PM -0400, Dave Jones wrote: > Signed-off-by: Dave Jones > > diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig > index c454bfa..ddb9c51 100644 > --- a/drivers/usb/serial/Kconfig > +++ b/drivers/usb/serial/Kconfig > @@ -60,7 +60,7 @@ config USB_SER

<    1   2   3   4   5   6   7   >