Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

2013-09-10 Thread Aaron Lu
On Tue, Sep 10, 2013 at 09:23:04PM +0200, Rafael J. Wysocki wrote: > On Tuesday, September 10, 2013 04:53:40 PM Jani Nikula wrote: > > On Mon, 09 Sep 2013, "Rafael J. Wysocki" wrote: > > > On Monday, September 09, 2013 05:21:18 PM Daniel Vetter wrote: > > >> On Mon, Sep 09, 2013 at 02:16:12PM

Re: [PATCH v3] mfd: rtsx: Modify rts5249_optimize_phy

2013-09-10 Thread wwang
于 2013年09月10日 19:08, Lee Jones 写道: I'm not asking for in-depth analysis, just an overview. What's wrong with the default config? Why is the signal quality bad and what makes it bad? What did the old magic numbers do? How will the configuration differ if I applied your patch? It is a little

Re: [PATCH 1/1] staging/speakup/kobjects.c: Code improvement.

2013-09-10 Thread Chris Brannon
Dan Carpenter writes: > Good eye for spotting the memory corruption bug! > > This is a bug fix, so the fix should go in a separate patch and not > merged with a code cleanup patch. Ordinary users can trigger this so > it's a security bug and separating it out is extra important. Ok. I just

Re: [PATCH 2/6] extcon-gpio: If the gpio driver/chip supports debounce, use it

2013-09-10 Thread Chanwoo Choi
Hi Guenter I agree to use gpio_set_debounce() API but, I suggest following patch to code clean. and I'd like you to use declarative sentence on patch name instead of 'If ...'. On 08/30/2013 01:29 PM, Guenter Roeck wrote: > Signed-off-by: Guenter Roeck > --- > drivers/extcon/extcon-gpio.c |

Re: [PATCH 1/6] extcon-gpio: Do not unnecessarily initialize variables

2013-09-10 Thread Chanwoo Choi
On 08/30/2013 01:29 PM, Guenter Roeck wrote: > Signed-off-by: Guenter Roeck > --- > drivers/extcon/extcon-gpio.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c > index 02bec32..77d35a7 100644 > ---

Re: [PATCH] /dev/random: Insufficient of entropy on many architectures

2013-09-10 Thread John Stultz
On 09/10/2013 05:50 PM, Theodore Ts'o wrote: > On Tue, Sep 10, 2013 at 05:31:45PM -0700, John Stultz wrote: >> Yea, that point about "every single interrupt" vs "every timer >> interrupt". I suspect that if its every timer interrupt, this can be >> done easily w/ clocksources as we already do that

Re: [PATCH] bcm63xx_enet: remove deprecated IRQF_DISABLED

2013-09-10 Thread Jingoo Han
On Saturday, September 07, 2013 3:57 PM, Michael Opdenacker wrote: > > This patch proposes to remove the IRQF_DISABLED flag from > drivers/net/ethernet/broadcom/bcm63xx_enet.c > > It's a NOOP since 2.6.35 and it will be removed one day. > > Signed-off-by: Michael Opdenacker Reviewed-by:

Re: [REPOST PATCH 3/4] slab: introduce byte sized index for the freelist of a slab

2013-09-10 Thread Joonsoo Kim
On Tue, Sep 10, 2013 at 09:25:05PM +, Christoph Lameter wrote: > On Tue, 10 Sep 2013, Joonsoo Kim wrote: > > > On Mon, Sep 09, 2013 at 02:44:03PM +, Christoph Lameter wrote: > > > On Mon, 9 Sep 2013, Joonsoo Kim wrote: > > > > > > > 32 byte is not minimum object size, minimum *kmalloc*

Re: [PATCH RESEND 1/2] i2c: prepare runtime PM support for I2C client devices

2013-09-10 Thread Aaron Lu
On 09/11/2013 06:32 AM, Rafael J. Wysocki wrote: > On Tuesday, September 10, 2013 10:35:22 PM Mark Brown wrote: >> On Tue, Sep 10, 2013 at 10:04:21PM +0200, Rafael J. Wysocki wrote: >>> On Tuesday, September 10, 2013 05:13:21 PM Mark Brown wrote: >> OK, that is very much not the model which

Re: [PATCH] net: korina: remove deprecated IRQF_DISABLED

2013-09-10 Thread Jingoo Han
On Saturday, September 07, 2013 2:21 PM, Michael Opdenacker wrote: > > This patch proposes to remove the IRQF_DISABLED flag from > drivers/net/ethernet/korina.c > > It's a NOOP since 2.6.35 and it will be removed one day. > > Signed-off-by: Michael Opdenacker Reviewed-by: Jingoo Han Best

Re: [16/85] b43: ensue that BCMA is "y" when B43 is "y"

2013-09-10 Thread Ben Hutchings
On Mon, 2013-09-09 at 16:56 -0400, Konstantin Ryabitsev wrote: > On 09/09/13 02:46 PM, Steven Rostedt wrote: > > Initially, LKML would be archived on kernel.org, but that never > > happened and doesn't seem it will after the whole security breach > > incident. > > I believe we're hoping vger will

Re: [PATCH 01/50] sched: monolithic code dump of what is being pushed upstream

2013-09-10 Thread Joonsoo Kim
On Tue, Sep 10, 2013 at 10:31:41AM +0100, Mel Gorman wrote: > @@ -5045,15 +5038,50 @@ static int need_active_balance(struct lb_env *env) > > static int active_load_balance_cpu_stop(void *data); > > +static int should_we_balance(struct lb_env *env) > +{ > + struct sched_group *sg =

Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs

2013-09-10 Thread Javier Martinez Canillas
On 09/11/2013 12:34 AM, Stephen Warren wrote: > On 09/10/2013 03:37 PM, Mark Brown wrote: >> On Tue, Sep 10, 2013 at 01:53:47PM -0600, Stephen Warren wrote: >> >>> Doesn't this patch call gpio_request() on the GPIO first, and >>> hence prevent the driver's own gpio_request() from succeeding, >>>

Re: [PATCH] /dev/random: Insufficient of entropy on many architectures

2013-09-10 Thread Theodore Ts'o
On Tue, Sep 10, 2013 at 05:31:45PM -0700, John Stultz wrote: > Yea, that point about "every single interrupt" vs "every timer > interrupt". I suspect that if its every timer interrupt, this can be > done easily w/ clocksources as we already do that read, but every single > interrupt would have

Re: [PATCH] workqueue: remove redundant timer_stats_timer_set_start_info() call

2013-09-10 Thread Libin
On 2013/9/10 21:45, Tejun Heo wrote: > On Tue, Sep 10, 2013 at 02:35:27PM +0800, Libin wrote: >> From: Li Bin >> >> There is a redundant call for timer_stats_timer_set_start_info(), >> because it is the responsibility of the 'timer add' function: >> >> add_timer_on() >> |-

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Linus Torvalds
On Tue, Sep 10, 2013 at 5:30 PM, Stephen Rothwell wrote: > > So, Andrew, you should be able to just about send those 375 patches to > Linus (I know that there may be some fix folding to do before that) and > have him apply them on top of v3.11-rc7-14-gfa8218d in a separate branch > and then merge

Re: Resend: [PATCH 2/2] s390: provide hardware randomness from zcrypt card to /dev/random

2013-09-10 Thread Joe Perches
On Wed, 2013-09-04 at 10:48 +0200, Torsten Duwe wrote: [] > +++ b/drivers/s390/crypto/zcrypt_api.c > @@ -1141,6 +1144,36 @@ static struct hwrng zcrypt_rng_dev = { ][ > +static int zcrypt_hwrng_fillfn(void *unused) > +{ > + long rc; > + > + while (!kthread_should_stop()) { > +

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Dave Chinner
On Tue, Sep 10, 2013 at 05:01:23PM -0700, Linus Torvalds wrote: > On Tue, Sep 10, 2013 at 4:53 PM, Al Viro wrote: > > > > list_lru_add() can fail if it's already on the list; leaving the counter > > alone should've been conditional on that, setting the flag - no. Said > > that, it probably

Re: kernel deadlock

2013-09-10 Thread Lin Ming
On Wed, Sep 11, 2013 at 12:38 AM, John Stultz wrote: > On 09/10/2013 01:59 AM, Lin Ming wrote: >> On Tue, Sep 10, 2013 at 4:29 AM, John Stultz wrote: >> >> [snip] >> >>> So I think I've managed to finally reproduce this and hunt it down. >>> >>> With Peter's "sched: Fix HRTICK" patch and HRTICK

Re: [PATCH] extcon: Remove casting the return value which is a void pointer

2013-09-10 Thread Chanwoo Choi
Hi Jingoo, On 09/09/2013 02:33 PM, Jingoo Han wrote: > Casting the return value which is a void pointer is redundant. > The conversion from void pointer to any other pointer type is > guaranteed by the C programming language. > > Signed-off-by: Jingoo Han > --- > drivers/extcon/extcon-class.c

Re: [PATCH] /dev/random: Insufficient of entropy on many architectures

2013-09-10 Thread John Stultz
On 09/10/2013 03:33 PM, Theodore Ts'o wrote: > On Tue, Sep 10, 2013 at 03:08:12PM -0700, John Stultz wrote: >> One other area you might look at is using the delta between when the >> next hrtimer was scheduled for and when we actually expired it? That's >> something we could cheaply calculate on

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Stephen Rothwell
Hi Linus, On Tue, 10 Sep 2013 15:44:00 -0700 Andrew Morton wrote: > > On Tue, 10 Sep 2013 15:35:04 -0700 Linus Torvalds > wrote: > > > So I'd (once again) suggest you base your pile of patches on the > > previous stable kernel, and that linux-next take it *first* rather > > than take it

Re: [PATCH 1/2] uinput: Support injecting multiple events in one write() call

2013-09-10 Thread Ryan Mallon
On 11/09/13 10:14, Dmitry Torokhov wrote: > Hi Ryan, > > On Wed, Sep 11, 2013 at 09:32:52AM +1000, Ryan Mallon wrote: >> Rework the code in uinput_inject_event so that it matches the code in >> evdev_write and allows injecting more than one event, or zero events. >> >> Signed-off-by: Ryan Mallon

Re: [PATCH 2/2] uinput: Use input_inject_event in uinput_inject_event

2013-09-10 Thread Ryan Mallon
On 11/09/13 10:12, Dmitry Torokhov wrote: > Hi Ryan, > > On Wed, Sep 11, 2013 at 09:32:53AM +1000, Ryan Mallon wrote: >> Call input_inject_event rather than input_event in uinput_inject_event. This >> mirrors the behaviour of evdev_write. input_inject_event will ignore the >> injected event if

Re: [linux-next-20130822] module: broken module versions?

2013-09-10 Thread Andrew Morton
On Tue, 27 Aug 2013 11:14:33 +0900 penguin-ker...@i-love.sakura.ne.jp wrote: > I noticed that symbols which cause "disagrees about version of symbol" > messages > have crc == 0. > > -- scripts/mod/modpost.c -- > /* CRC'd symbol */ > if (strncmp(symname, CRC_PFX,

[GIT PULL] x86/jumpmplabel changes for v3.12-rc1

2013-09-10 Thread H. Peter Anvin
Hi Linus, One more x86 tree for this merge window. This tree improves the handling of jump labels, so that most of the time we don't have to do a massive initial patching run. Furthermore, we will error out of the jump label is not what is expected, e.g. if it has been corrupted or tampered

Re: [PATCH 1/2] uinput: Support injecting multiple events in one write() call

2013-09-10 Thread Dmitry Torokhov
Hi Ryan, On Wed, Sep 11, 2013 at 09:32:52AM +1000, Ryan Mallon wrote: > Rework the code in uinput_inject_event so that it matches the code in > evdev_write and allows injecting more than one event, or zero events. > > Signed-off-by: Ryan Mallon > --- > drivers/input/misc/uinput.c | 14

Re: slab: krealloc with GFP_ZERO defect

2013-09-10 Thread Joe Perches
ping? On Thu, 2013-08-29 at 14:47 -0700, Joe Perches wrote: > This sequence can return non-zeroed memory from the > padding area of the original allocation. > > ptr = kzalloc(foo, GFP_KERNEL); > if (!ptr) > ... > new_ptr = krealloc(ptr, foo + bar, GFP_KERNEL |

Re: [PATCH 00/12] One more attempt at useful kernel lockdown

2013-09-10 Thread Mimi Zohar
On Tue, 2013-09-10 at 16:48 -0700, H. Peter Anvin wrote: > On 09/10/2013 04:43 PM, Mimi Zohar wrote: > > > > Why invent yet another method of verifying the integrity of a file based > > on a signature? Why not use the existing method for appraising files? > > Just create a new integrity hook at

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Al Viro
On Tue, Sep 10, 2013 at 04:37:19PM -0700, Linus Torvalds wrote: > On Tue, Sep 10, 2013 at 3:59 PM, Al Viro wrote: > > > > It's not that bad, actually; I think the variant I've pushed right now > > (vfs.git#for-next, head at f5e1dd34561e0fb06400b378d595198918833021) should > > be doing the right

Re: [PATCH 00/12] One more attempt at useful kernel lockdown

2013-09-10 Thread H. Peter Anvin
On 09/10/2013 04:43 PM, Mimi Zohar wrote: > > Why invent yet another method of verifying the integrity of a file based > on a signature? Why not use the existing method for appraising files? > Just create a new integrity hook at the appropriate place. > What would the deliverables be from the

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Al Viro
On Tue, Sep 10, 2013 at 04:13:02PM -0700, Andrew Morton wrote: > > in -next from "fs: bump inode and dentry counters to long" on to the > > end of queue. > > That's the correct starting point. The end point should be > "staging/lustre/libcfs: cleanup linux-mem.h". ... which is the end of queue

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Linus Torvalds
On Tue, Sep 10, 2013 at 4:53 PM, Al Viro wrote: > > list_lru_add() can fail if it's already on the list; leaving the counter > alone should've been conditional on that, setting the flag - no. Said > that, it probably should be WARN_ON(!...); this_cpu_inc(); ... |= ...; That WARN_ON_(!..) might

Re: [PATCH 2/2] uinput: Use input_inject_event in uinput_inject_event

2013-09-10 Thread Dmitry Torokhov
Hi Ryan, On Wed, Sep 11, 2013 at 09:32:53AM +1000, Ryan Mallon wrote: > Call input_inject_event rather than input_event in uinput_inject_event. This > mirrors the behaviour of evdev_write. input_inject_event will ignore the > injected event if the uinput input device has been grabbed for

Re: [PATCH 00/12] One more attempt at useful kernel lockdown

2013-09-10 Thread Mimi Zohar
On Tue, 2013-09-10 at 12:44 -0700, H. Peter Anvin wrote: > On 09/10/2013 12:17 PM, David Lang wrote: > >> > >> In theory these blobs are traceable to a manufacturer. It's not really > >> an indication that it's "safe" more than it's an indication that it > >> hasn't been changed. But I haven't

Re: [PATCH 00/12] One more attempt at useful kernel lockdown

2013-09-10 Thread H. Peter Anvin
On 09/10/2013 04:55 PM, Mimi Zohar wrote: >> >> What would the deliverables be from the hardware vendor and what tools >> would you expect them to need on their end? > > The package installer needs to not only install files, but file metadata > as well. Elena Reshetova (Intel) has already added

Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-09-10 Thread Andrew Morton
On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven wrote: > On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen wrote: > > might_sleep is moving from linux/kernel.h to linux/sched.h, so any users > > need to include linux/sched.h > > Really? is the worst choice w.r.t. include hell. Yes.

[PATCH] slab: Make allocations with GFP_ZERO slightly more efficient

2013-09-10 Thread Joe Perches
Use the likely mechanism already around valid pointer tests to better choose when to memset to 0 allocations with __GFP_ZERO Signed-off-by: Joe Perches --- mm/slab.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index 2580db0..94e7e54

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Linus Torvalds
On Tue, Sep 10, 2013 at 3:59 PM, Al Viro wrote: > > It's not that bad, actually; I think the variant I've pushed right now > (vfs.git#for-next, head at f5e1dd34561e0fb06400b378d595198918833021) should > be doing the right thing. It ought to cover everything in your branch > in -next from "fs:

Re: [PATCH] drm/msm: fix return value check in ERR_PTR()

2013-09-10 Thread Rob Clark
On Tue, Sep 10, 2013 at 6:56 PM, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function drm_prime_pages_to_sg() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun good catch,

[PATCH 1/2] uinput: Support injecting multiple events in one write() call

2013-09-10 Thread Ryan Mallon
Rework the code in uinput_inject_event so that it matches the code in evdev_write and allows injecting more than one event, or zero events. Signed-off-by: Ryan Mallon --- drivers/input/misc/uinput.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[PATCH 2/2] uinput: Use input_inject_event in uinput_inject_event

2013-09-10 Thread Ryan Mallon
Call input_inject_event rather than input_event in uinput_inject_event. This mirrors the behaviour of evdev_write. input_inject_event will ignore the injected event if the uinput input device has been grabbed for exclusive access by a handler other than uinput. Signed-off-by: Ryan Mallon ---

[tip:x86/uaccess] x86: Add 1/2/4/ 8 byte optimization to 64bit __copy_{from,to}_user_inatomic

2013-09-10 Thread tip-bot for Andi Kleen
Commit-ID: ff47ab4ff3cddfa7bc1b25b990e24abe2ae474ff Gitweb: http://git.kernel.org/tip/ff47ab4ff3cddfa7bc1b25b990e24abe2ae474ff Author: Andi Kleen AuthorDate: Fri, 16 Aug 2013 14:17:19 -0700 Committer: H. Peter Anvin CommitDate: Tue, 10 Sep 2013 15:27:43 -0700 x86: Add 1/2/4/8 byte

Re: [PATCH 1/2] staging: zram: minimize `slot_free_lock' usage (v2)

2013-09-10 Thread Sergey Senozhatsky
On (09/10/13 17:34), Sergey Senozhatsky wrote: [..] > > > > Now I think we can drop the call to handle_pending_slot_free() in > > zram_bvec_rw() altogether. As long as the write lock is held when > > handle_pending_slot_free() is called, there is no race. It's no different > > from any write

Re: [git pull] drm tree for 3.12-rc1

2013-09-10 Thread Dave Airlie
On Wed, Sep 11, 2013 at 1:49 AM, Linus Torvalds wrote: > [ Dave - your linux.ie email generates bounces for me, trying redhat instead ] Uggh no worries, I read my list mail from gmail mostly anyways, so if its on a list I'll probably see it. >> Can you give a little more detail about video not

[PATCH 2/2] staging: zram: remove init_done from zram struct (v3)

2013-09-10 Thread Sergey Senozhatsky
`zram->init_done' in fact mimics `zram->meta != NULL' value. Introduce init_done() function that checks zram->meta (iow, checks if initialisation was performed), so `zram->init_done' can be removed. v3: init_done() in handle_pending_slot_free() v2: introduce init_done() Signed-off-by: Sergey

Re: [git pull] drm tree for 3.12-rc1

2013-09-10 Thread Sean V Kelley
On Tue, Sep 10, 2013 at 1:50 PM, Sean V Kelley wrote: > On Tue, Sep 10, 2013 at 08:49:58AM -0700, Linus Torvalds writes : >> [ Dave - your linux.ie email generates bounces for me, trying redhat instead >> ] >> >> On Mon, Sep 9, 2013 at 11:25 PM, Sean V Kelley >> wrote: >> >> >> >> I'm also a

Re: [PATCH 1/1] staging/speakup/kobjects.c: Code improvement.

2013-09-10 Thread Dan Carpenter
Good eye for spotting the memory corruption bug! This is a bug fix, so the fix should go in a separate patch and not merged with a code cleanup patch. Ordinary users can trigger this so it's a security bug and separating it out is extra important. The checking in spk_set_num_var() is not

Re: [PATCH 5/9] mbind: add hugepage migration code to mbind()

2013-09-10 Thread Andi Kleen
> > It makes me wonder how actually useful generic hugetlbfs page migration > > will be in practice. Are there really usecases where the system > > administrator is willing to create unused hugepage pools on each node > > just to enable migration? > > Maybe most users don't want it. I'm sure

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Andrew Morton
On Tue, 10 Sep 2013 23:36:24 +0100 Al Viro wrote: > On Tue, Sep 10, 2013 at 03:35:20PM -0700, Andrew Morton wrote: > > On Tue, 10 Sep 2013 23:29:24 +0100 Al Viro wrote: > > > > > On Tue, Sep 10, 2013 at 03:27:53PM -0700, Andrew Morton wrote: > > > > > > > This is rather a fiasco. "vfs:

Re: [PATCH 14/16] kexec: Export sysfs attributes for secureboot and secure modules to user space

2013-09-10 Thread Greg KH
On Tue, Sep 10, 2013 at 05:44:29PM -0400, Vivek Goyal wrote: > User space kexec-tools need to know whether to verify signature of kernel > image being loaded. This patch exports two knobs to user space. One is > for knowing if secureboot is enabled, this knob will be set to 1 if secure > boot is

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Al Viro
On Tue, Sep 10, 2013 at 03:41:16PM -0700, Andrew Morton wrote: > Obtained from where? There are a whole pile of fixes resulting from > review and linux-next testing. Are they included? -next and yes. The trivial ones - folded into the commits they are fixing (I mean, ones directly following

Re: [PATCH] usb: ohci/uhci - add soft dependencies on ehci_hcd

2013-09-10 Thread Lucas De Marchi
On Tue, Sep 10, 2013 at 6:27 PM, Tom Gundersen wrote: > On Tue, Sep 10, 2013 at 7:31 PM, Alan Stern wrote: >> On Tue, 10 Sep 2013, Tom Gundersen wrote: >> >>> Hi Alan, >>> >>> On Tue, Sep 10, 2013 at 7:02 PM, Alan Stern >>> wrote: >>> > On Tue, 10 Sep 2013, Tom Gundersen wrote: >>> > >>> >>

[PATCH 1/2] staging: zram: fix handle_pending_slot_free() and zram_reset_device() race

2013-09-10 Thread Sergey Senozhatsky
Dan Carpenter noted that handle_pending_slot_free() is racy with zram_reset_device(). Take write init_lock in zram_slot_free(), thus preventing any concurrent zram_slot_free(), zram_bvec_rw() or zram_reset_device(). This also allows to safely check zram->init_done in handle_pending_slot_free().

[PATCH v2] cpu/mem hotplug: Add try_online_node() for cpu_up()

2013-09-10 Thread Toshi Kani
cpu_up() has #ifdef CONFIG_MEMORY_HOTPLUG code blocks, which call mem_online_node() to put its node online if offlined and then call build_all_zonelists() to initialize the zone list. These steps are specific to memory hotplug, and should be managed in mm/memory_hotplug.c. lock_memory_hotplug()

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Andrew Morton
On Tue, 10 Sep 2013 15:35:04 -0700 Linus Torvalds wrote: > So I'd (once again) suggest you base your pile of patches on the > previous stable kernel, and that linux-next take it *first* rather > than take it last. That's what we're now doing. But this particular patchset was different because

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Al Viro
On Tue, Sep 10, 2013 at 11:36:24PM +0100, Al Viro wrote: > On Tue, Sep 10, 2013 at 03:35:20PM -0700, Andrew Morton wrote: > > On Tue, 10 Sep 2013 23:29:24 +0100 Al Viro wrote: > > > > > On Tue, Sep 10, 2013 at 03:27:53PM -0700, Andrew Morton wrote: > > > > > > > This is rather a fiasco. "vfs:

Re: [PATCH] panic: call panic handlers before kmsg_dump

2013-09-10 Thread Kees Cook
On Tue, Sep 10, 2013 at 3:41 PM, Kees Cook wrote: > On Thu, Jul 18, 2013 at 4:17 PM, Tony Luck wrote: >> On Thu, Jul 18, 2013 at 4:03 PM, Kees Cook wrote: >>> Since the panic handlers may produce additional information (via printk) >>> for the kernel log, it should be reported as part of the

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Al Viro
On Tue, Sep 10, 2013 at 11:48:23PM +0100, Al Viro wrote: > On Tue, Sep 10, 2013 at 03:41:16PM -0700, Andrew Morton wrote: > > > Obtained from where? There are a whole pile of fixes resulting from > > review and linux-next testing. Are they included? > > -next and yes. The trivial ones -

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Andrew Morton
On Tue, 10 Sep 2013 23:59:34 +0100 Al Viro wrote: > On Tue, Sep 10, 2013 at 11:48:23PM +0100, Al Viro wrote: > > On Tue, Sep 10, 2013 at 03:41:16PM -0700, Andrew Morton wrote: > > > > > Obtained from where? There are a whole pile of fixes resulting from > > > review and linux-next testing.

Re: [PATCH v3 0/2] ext4: increase mbcache scalability

2013-09-10 Thread Thavatchai Makphaibulchoke
On 09/10/2013 09:02 PM, Theodore Ts'o wrote: > On Tue, Sep 10, 2013 at 02:47:33PM -0600, Andreas Dilger wrote: >> I agree that SELinux is enabled on enterprise distributions by default, >> but I'm also interested to know how much overhead this imposes. I would >> expect that writing large

[PATCH] drm/msm: fix return value check in ERR_PTR()

2013-09-10 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function drm_prime_pages_to_sg() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/gpu/drm/msm/msm_gem.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace)

2013-09-10 Thread Guenter Roeck
On Wed, Sep 11, 2013 at 08:02:49AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2013-09-09 at 16:55 -0700, Asai Thambi S P wrote: > > On 09/08/2013 5:28 PM, Guenter Roeck wrote: > > > Hi all, > > > > > > powerpc allmodconfig build on the latest upstream kernel results in: > > > > > > ERROR:

Re: [PATCH] panic: call panic handlers before kmsg_dump

2013-09-10 Thread Kees Cook
On Thu, Jul 18, 2013 at 4:17 PM, Tony Luck wrote: > On Thu, Jul 18, 2013 at 4:03 PM, Kees Cook wrote: >> Since the panic handlers may produce additional information (via printk) >> for the kernel log, it should be reported as part of the panic output >> saved by kmsg_dump(). Without this

Re: dirty_expire_centisecs, msync behavior

2013-09-10 Thread Jan Kara
On Tue 10-09-13 14:46:52, Howard Chu wrote: > >On Sat 07-09-13 17:01:10, Howard Chu wrote: > >>The documentation for dirty_expire_centisecs states: "Data which has > >>been dirty in-memory for longer than this interval will be written > >>out next time a flusher thread wakes up." > >> > >>In

Re: [PATCH 15/16] bootparam: Pass acpi_rsdp pointer in bootparam

2013-09-10 Thread H. Peter Anvin
On 09/10/2013 02:44 PM, Vivek Goyal wrote: > Currently kexec does not enables EFI and its tables in second kernel. Hence > acpi rsdp root pointer is passed on command line. But secureboot does not > trust > acpi_rsdp on command line as kernel can execute some of the code as retrieved > by

Re: [PATCH 14/16] kexec: Export sysfs attributes for secureboot and secure modules to user space

2013-09-10 Thread Josh Boyer
On Tue, Sep 10, 2013 at 5:44 PM, Vivek Goyal wrote: > User space kexec-tools need to know whether to verify signature of kernel > image being loaded. This patch exports two knobs to user space. One is > for knowing if secureboot is enabled, this knob will be set to 1 if secure > boot is enabled.

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Al Viro
On Tue, Sep 10, 2013 at 03:35:20PM -0700, Andrew Morton wrote: > On Tue, 10 Sep 2013 23:29:24 +0100 Al Viro wrote: > > > On Tue, Sep 10, 2013 at 03:27:53PM -0700, Andrew Morton wrote: > > > > > This is rather a fiasco. "vfs: reorganize dput() memory accesses" made > > > rather a mess of a 46

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Andrew Morton
On Tue, 10 Sep 2013 23:29:24 +0100 Al Viro wrote: > On Tue, Sep 10, 2013 at 03:27:53PM -0700, Andrew Morton wrote: > > > This is rather a fiasco. "vfs: reorganize dput() memory accesses" made > > rather a mess of a 46 patch series which has been under development and > > test for two cycles so

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Linus Torvalds
On Tue, Sep 10, 2013 at 3:27 PM, Andrew Morton wrote: > > This is rather a fiasco. "vfs: reorganize dput() memory accesses" made > rather a mess of a 46 patch series which has been under development and > test for two cycles so far. Andrew, *please* don't do the insane rebasing you keep on

Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs

2013-09-10 Thread Stephen Warren
On 09/10/2013 03:37 PM, Mark Brown wrote: > On Tue, Sep 10, 2013 at 01:53:47PM -0600, Stephen Warren wrote: > >> Doesn't this patch call gpio_request() on the GPIO first, and >> hence prevent the driver's own gpio_request() from succeeding, >> since the GPIO is already requested? If this is not a

Re: [PATCH] /dev/random: Insufficient of entropy on many architectures

2013-09-10 Thread Theodore Ts'o
On Tue, Sep 10, 2013 at 03:08:12PM -0700, John Stultz wrote: > One other area you might look at is using the delta between when the > next hrtimer was scheduled for and when we actually expired it? That's > something we could cheaply calculate on every hrtimer expiration. Though > I probably

Re: [PATCH 1/4] hpsa: add HP Smart Array Gen9 PCI ID's

2013-09-10 Thread James Bottomley
On Tue, 2013-09-10 at 22:17 +, Miller, Mike (OS Dev) wrote: > > -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Tuesday, September 10, 2013 5:02 PM > To: Miller, Mike (OS Dev) > Cc: Andrew Morton; LKML; LKML-scsi > Subject: Re: [PATCH

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Al Viro
On Tue, Sep 10, 2013 at 03:27:53PM -0700, Andrew Morton wrote: > This is rather a fiasco. "vfs: reorganize dput() memory accesses" made > rather a mess of a 46 patch series which has been under development and > test for two cycles so far. Check vfs.git#for-next... -- To unsubscribe from this

Re: linux-next: manual merge of the akpm tree with Linus' tree

2013-09-10 Thread Andrew Morton
On Tue, 10 Sep 2013 14:38:07 +1000 Stephen Rothwell wrote: > Hi Andrew, > > Today's linux-next merge of the akpm tree got a conflict in fs/dcache.c > between commit 8aab6a27332b ("vfs: reorganize dput() memory accesses") > from Linus' tree and commit "dcache: convert to use new lru list >

Re: [PATCH 0/7] preempt_count rework -v2

2013-09-10 Thread H. Peter Anvin
On 09/10/2013 03:02 PM, Linus Torvalds wrote: > On Tue, Sep 10, 2013 at 2:51 PM, H. Peter Anvin wrote: >> On 09/10/2013 02:43 PM, Linus Torvalds wrote: >> >> Actually, the right thing here really is "er" (which I think you meant, >> but just to make it clear.) > > Yes, I was just answering the

3.10.10: WARNING: at kernel/smp.c:181 generic_smp_call_function_single_interrupt+0x11c/0x130()

2013-09-10 Thread Martin MOKREJŠ
Hi, I got this stacktrace shortly after bootup. I am disabling the two hyper-threaded cores in my startup scripts so possibly that was the trigger, at least per earlier report from Fernando Soto on Jul 08 2013: https://lkml.org/lkml/2013/7/8/301 I don't see his name in this patch series

[PATCH] Staging: fwserial: wrap a line that exceeds 80 characters

2013-09-10 Thread Jon Bernard
This is a patch to fwserial.c that wraps a line which previously exceeded the 80 character limit warning found by checkpatch.pl. This driver is now warning and error free, according to checkpatch.pl Signed-off-by: Jon Bernard --- drivers/staging/fwserial/fwserial.c | 3 ++- 1 file changed, 2

[PATCH 01/16] mm: vm_brk(), align the length to page boundary

2013-09-10 Thread Vivek Goyal
I was writing some code where I was locking all pages of a process during exec() time by setting VM_LOCKED flag in mm->def_flags. But that lead to errors because length of mapping is not page aligned. login: [ 174.669002] INFO: rcu_sched self-detected stall on CPU { 2} (t=6 jiffies g=2580

Re: Out-of-bounds access in get_wchan (arch/x86/kernel/process_64.c)

2013-09-10 Thread Andi Kleen
> Indeed, get_wchan ensures that fp fp+8: > > 434 if (fp < (unsigned long)stack || > 435 fp >= (unsigned long)stack+THREAD_SIZE) > 436 return 0; > 437 ip = *(u64 *)(fp+8); > > It must check that fp+8 As far as I see, the

Re: powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace)

2013-09-10 Thread Benjamin Herrenschmidt
On Mon, 2013-09-09 at 16:55 -0700, Asai Thambi S P wrote: > On 09/08/2013 5:28 PM, Guenter Roeck wrote: > > Hi all, > > > > powerpc allmodconfig build on the latest upstream kernel results in: > > > > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! > > > > This is due to

Re: [PATCH 5/9] mbind: add hugepage migration code to mbind()

2013-09-10 Thread Naoya Horiguchi
On Tue, Sep 10, 2013 at 03:41:09PM +0100, Mel Gorman wrote: > On Fri, Aug 09, 2013 at 01:21:38AM -0400, Naoya Horiguchi wrote: > > This patch extends do_mbind() to handle vma with VM_HUGETLB set. > > We will be able to migrate hugepage with mbind(2) after > > applying the enablement patch which

Re: [PATCH] /dev/random: Insufficient of entropy on many architectures

2013-09-10 Thread John Stultz
On 09/10/2013 02:10 PM, Theodore Ts'o wrote: > On Tue, Sep 10, 2013 at 01:46:21PM -0700, John Stultz wrote: >> We do read the clocksource fairly frequently though, so rather then >> re-reading on each interrupt, could you instead re-use the points at >> interrupt time where we already read the

[PATCH 2/2] vt: properly ignore xterm-256 colour codes

2013-09-10 Thread Adam Borowski
This is not a bug on our side, but a misdesign in ITU T.416, yet with all popular terminals supporting these codes, people consider this to be a bug in Linux. By breaking the design principles behind SGR codes (gracefully ignoring unsupported ones should not require knowing about them), 256

[PATCH 10/16] keyctl: Introduce a new operation KEYCTL_VERIFY_SIGNATURE

2013-09-10 Thread Vivek Goyal
This is based on a patch david howells sent me. I have modified that patch to meet my needs. Extend kecytl() to add an option to verify signature of a user buffer. One needs to pass in the signature type also so that respective handler can be called. Currently I have defined a new signature type

[PATCH 04/16] integrity: Allow digital signature verification with a given keyring ptr

2013-09-10 Thread Vivek Goyal
Currently digital signature verification code assumes that it can be used only with 3 keyrings. IMA, EVM and MODULE keyring. Provide another variant where one can pass in a pointer to keyring (struct key *), and integrity code can try to find key in that keyring and verify signature. This will be

Re: dirty_expire_centisecs, msync behavior

2013-09-10 Thread Howard Chu
Jan Kara wrote: Hello, Hi Jan, thanks for your answers. On Sat 07-09-13 17:01:10, Howard Chu wrote: The documentation for dirty_expire_centisecs states: "Data which has been dirty in-memory for longer than this interval will be written out next time a flusher thread wakes up." In

Re: [PATCH 0/7] preempt_count rework -v2

2013-09-10 Thread H. Peter Anvin
On 09/10/2013 02:43 PM, Linus Torvalds wrote: > On Tue, Sep 10, 2013 at 2:25 PM, Peter Zijlstra wrote: >> >> Here's one that builds and boots on kvm until wanting to mount root. >> >> I'm not entirely sure on the "ir" vs "er" thing and atomic64_t and >> local_t are inconsistent wrt that so I'm

[PATCH 16/16] mount: Add a flag to not follow symlink at the end of mount point

2013-09-10 Thread Vivek Goyal
I have a requirement where I want to make sure that mount() fails if mount point is a symlink. Hence introducing a new mount flag MS_NOSYMLINK. Following is little more info on what I am trying to do. I am trying to write patches for signed /sbin/kexec. That is /sbin/kexec binary will be signed

[PATCH 13/16] kexec: Allow only signed processes to call sys_kexec() in secureboot mode

2013-09-10 Thread Vivek Goyal
Modify sys_kexec() so that it allows only signed processes to execute sys_kexec() when secureboot is enabled. Signed-off-by: Vivek Goyal --- kernel/kexec.c | 29 + 1 file changed, 29 insertions(+) diff --git a/kernel/kexec.c b/kernel/kexec.c index 59f7b55..478566e

[PATCH 14/16] kexec: Export sysfs attributes for secureboot and secure modules to user space

2013-09-10 Thread Vivek Goyal
User space kexec-tools need to know whether to verify signature of kernel image being loaded. This patch exports two knobs to user space. One is for knowing if secureboot is enabled, this knob will be set to 1 if secure boot is enabled. Other knob is secure_module_enabled. This knob will be set

[PATCH 07/16] mm: Define a task flag MMF_VM_LOCKED for memlocked tasks and don't allow munlock

2013-09-10 Thread Vivek Goyal
Define a flag to mark tasks which are running locked in memory. And use it to deny munlock/munlockall operation. We want to lock down a task in memory so that it is not swapped out. Otherwise it is susceptible to attack on swap disk and then modified code/data will be swapped back. I am not sure

RE: [PATCH 1/4] hpsa: add HP Smart Array Gen9 PCI ID's

2013-09-10 Thread Miller, Mike (OS Dev)
-Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Tuesday, September 10, 2013 5:02 PM To: Miller, Mike (OS Dev) Cc: Andrew Morton; LKML; LKML-scsi Subject: Re: [PATCH 1/4] hpsa: add HP Smart Array Gen9 PCI ID's On Wed, 2013-09-04 at 15:05

[PATCH 08/16] binfmt_elf: Elf executable signature verification

2013-09-10 Thread Vivek Goyal
Do elf executable signature verification (if one is present). If signature is present, it should be valid. Validly signed executables are locked in memory and a flag cred->proc_signed gets set to signify this process executable contents are signed. If file is unsigned, it can execute but it does

[PATCH 00/16] [RFC PATCH] Signed kexec support

2013-09-10 Thread Vivek Goyal
Hi, Matthew has been posting patches to lock down kernel either due to secureboot requirements or because of signed modules with signing enforced. In kernel lock down mode, kexec will be disabled and that means kdump will not work either. These patches sign /sbin/kexec and kernel verifies the

[PATCH 09/16] ima: define functions to appraise memory buffer contents

2013-09-10 Thread Vivek Goyal
I need to provide user space with facility that it can call into kernel for signature verification of a file. Trying to rely on file based appraisal has the downside that somebody might write to file after appraisal and it is racy. Alternative is that one can copy file contents in memory buffer

[PATCH 06/16] ima: export new IMA functions for signature verification

2013-09-10 Thread Vivek Goyal
Export IMA functions so that other subsystems can use IMA for file signature verification. Why introduce these functions and not use security hooks? Now callers have new requirements which are not satisfied by the hooks. a. Caller need to know whether signature verification actually took

Re: kernel BUG at fs/dcache.c:648! with v3.11-7890-ge5c832d

2013-09-10 Thread Josh Boyer
On Tue, Sep 10, 2013 at 4:25 PM, Linus Torvalds wrote: > On Tue, Sep 10, 2013 at 12:57 PM, Mace Moneta wrote: >> The (first) patch looks good; no recurrence. It has only taken 3-5 minutes >> before, and I've been up for about half an hour now. > > Ok, good. It's pushed out. Thanks to the both

Re: [patch 0/7] improve memcg oom killer robustness v2

2013-09-10 Thread Johannes Weiner
On Tue, Sep 10, 2013 at 11:32:47PM +0200, azurIt wrote: > >On Tue, Sep 10, 2013 at 11:08:53PM +0200, azurIt wrote: > >> >On Tue, Sep 10, 2013 at 09:32:53PM +0200, azurIt wrote: > >> >> Here is full kernel log between 6:00 and 7:59: > >> >> http://watchdog.sk/lkml/kern6.log > >> > > >> >Wow, your

[PATCH 02/16] integrity: Add a function to determine digital signature length

2013-09-10 Thread Vivek Goyal
Currently if security.ima has digital signature, there is only one structure in there. Either version 1 or version 2 of digital signature. So all the functions assume that whole of the security.ima xattr contains digital signautre and uses the length accordingly. But, now I am planning to add

<    1   2   3   4   5   6   7   8   9   10   >