Stephen Rothwell wrote:
>Hi Greg,
>
>Today's linux-next merge of the staging tree got a conflict in
>drivers/iio/industrialio-buffer.c between commit d66e0452bf6b ("iio:
>Fix
>crash when scan_bytes is computed with active_scan_mask == NUL") from
>the
>staging.current tree and commit
Thanks Stephen.
Sorry Greg, I meant to mention these two would occur but clean forgot when
sending that pull request.
Both are are correctly merged by Stephen.
Jonathan
Stephen Rothwell wrote:
>Hi Greg,
>
>Today's linux-next merge of the staging tree got a conflict in
Series applied, thanks Joe.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Markus,
Am 23.09.2013 04:38, schrieb Markus Elfring:
> Would it become useful to move "drivers" which do not manage hardware to a
> separate directory?
> Should such source files belong to a different software category (or "class")?
IMHO it would be not very useful.
We have more serious issues
On 09/22/13 at 08:27am, H. Peter Anvin wrote:
> The address that faults is interesting in that it is indeed just below -4G.
> The question at hand is probably what information you are using to build the
> EFI mappings in the secondary kernel and what could make it not match the
> primary.
>
>
Hi Pratyush,
On Monday 23 September 2013 09:44 AM, Pratyush Anand wrote:
> Hi Kishon,
>
>
> On Sun, Sep 22, 2013 at 07:16:34PM +0800, Kishon Vijay Abraham I wrote:
>> Hi Arnd,
>>
>> Thanks for replying :-)
>>
>> On Sunday 22 September 2013 03:33 AM, Arnd Bergmann wrote:
>>> On Saturday 21
On Tue, Sep 17, 2013 at 08:08:46AM +, Lu Jingchang-B35083 wrote:
> > > + case DMA_PAUSE:
> > > + if (fsl_chan->edesc)
> > > + fsl_edma_disable_request(fsl_chan);
> > racy here too...
> It only set the channel HW register, no list is handled,
> is lock needed here?
On Wed, Sep 18, 2013 at 09:33:08AM +0200, Guennadi Liakhovetski wrote:
> dst_addr_width and src_addr_width should be a power of 2. Currently the
> driver checks, that they both lie between 1 and 8 and that they are eqal
typo ^
>
On Tue, Sep 17, 2013 at 03:56:05PM +0200, Michael Grzeschik wrote:
> Hello,
>
> this series is solving some lockdep issues in the imx-dma code.
> There are some list_head and deadlock issues in the code,
> that is running the implementation into unsafe situations.
Thanks for this, I have trying
From: Benjamin Herrenschmidt
Date: Mon, 23 Sep 2013 14:40:34 +1000
> Heads up guys: i386 and sparc at least seem to need the same
> treatment.
I'll take a look thanks for the heads up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On 09/22/2013 07:30 PM, Miles Lane wrote:
yep, thanks for the report. I have a patch for this one, attached
below but is also being sent up to the security tree.
---
apparmor: Use shash crypto API interface for profile hashes
Use the shash interface, rather than the hash interface, when
Hi Ted,
On Mon, 23 Sep 2013 14:39:24 +1000 Stephen Rothwell
wrote:
>
> After merging the random tree, today's linux-next build (powerpc64
> allnoconfig) produced this warning:
>
> In file included from include/linux/kernel.h:10:0,
> from include/linux/sched.h:15,
>
On Sun, 2013-09-22 at 07:45 +1000, Benjamin Herrenschmidt wrote:
> What I *can* do that would help I suppose would be to switch to the irq
> stack before irq_enter/exit which would at least mean that softirq would
> run from the top of the irq stack which is better than the current
> situation.
>
Hi Ted,
After merging the random tree, today's linux-next build (powerpc64
allnoconfig) produced this warning:
In file included from include/linux/kernel.h:10:0,
from include/linux/sched.h:15,
from include/linux/utsname.h:5,
from
Nowadays, irq_exit() calls __do_softirq() pretty much directly
instead of calling do_softirq() which switches to the decicated
softirq stack.
This has lead to observed stack overflows on powerpc since we call
irq_enter() and irq_exit() outside of the scope that switches to
the irq stack.
This
On Sun, Sep 22, 2013 at 09:11:58PM -0700, H. Peter Anvin wrote:
>
> This doesn't mix in across the entire width of the hash (my original
> motivation for putting this at the end was to do it after the hash is
> folded in half -- which is still believe is cryptographically dubious,
> but please
Hi Jens,
After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from include/linux/kernel.h:13:0,
from drivers/block/skd_main.c:19:
drivers/block/skd_main.c: In function 'skd_cons_skmsg':
On Tue, Sep 17, 2013 at 08:24:45PM +0300, Sergey Senozhatsky wrote:
>
> Hello,
>
> On (09/16/13 09:02), Minchan Kim wrote:
> > Hello Sergey,
> >
> > Sorry for really slow response. I was really busy by internal works
> > and Thanks for pointing the BUG, Dan, Jerome and Sergey.
> > I read your
Hi Kishon,
On Sun, Sep 22, 2013 at 07:16:34PM +0800, Kishon Vijay Abraham I wrote:
> Hi Arnd,
>
> Thanks for replying :-)
>
> On Sunday 22 September 2013 03:33 AM, Arnd Bergmann wrote:
> > On Saturday 21 September 2013, Kishon Vijay Abraham I wrote:
> >> {
> >> u32 val;
> >>
On 09/22/2013 01:38 PM, Theodore Ts'o wrote:
> Previously if CPU chip had a built-in random number generator (i.e.,
> RDRAND on newer x86 chips), we mixed it in at the very end of
> extract_buf() using an XOR operation.
>
> We now mix it in right after the calculate a hash across the entire
>
On 09/22/2013 09:01 PM, Theodore Ts'o wrote:
> I've added the following changes to this patch since upon testing,
> there were some uses of r->entropy_count that were not properly
> converted from using fractional bits to bits.
>
Thanks for catching that.
-hpa
--
To unsubscribe from
Hi Theodore,
Today's linux-next merge of the random tree got a conflict in init/main.c
between commit 65f382fd0c8f ("context_tracking: Ground setup for static
key use") from Linus' tree and commit 382521d2478b ("random: run
random_int_secret_init() run after all late_initcalls") from the random
I've added the following changes to this patch since upon testing,
there were some uses of r->entropy_count that were not properly
converted from using fractional bits to bits.
- Ted
diff --git a/drivers/char/random.c b/drivers/char/random.c
index
From: Sonic Zhang
Signed-off-by: Sonic Zhang
---
drivers/pinctrl/pinctrl-adi2-bf60x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-adi2-bf60x.c
b/drivers/pinctrl/pinctrl-adi2-bf60x.c
index e90cb80..bf57aea 100644
---
Hi Mateusz,
On 21 September 2013 20:30, Mateusz Krawczuk
wrote:
> This patch series add restoring previous vpll rate after driver offs stream
> or recives error.
> It also replace mxr_info, mxr_dbg, mxr_warn and mxr_err macro
> by generic solution.
It is a good practice to include revision
Hi Andrey,
On Sat, Sep 21, 2013 at 10:48:21AM +0400, Andrey Moiseev wrote:
> Is it ok that in /drivers/input/serio/i8042.c it's allowed to install
> only one i8042_filter? Theoretically, there may be several different
> devices that need their drivers to install i8042_filter, to eat out
> some
From: Sonic Zhang
Signed-off-by: Sonic Zhang
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 08b8337..9bb6efb 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -51,6 +51,7 @@ config
This delay got introduced in:
"7415f17 usb: dwc3: core: add power management support"
which reflected similar code in dwc3_core_soft_reset() function.
However, originally the delay of 100ms in dwc3_core_soft_reset() was
meant to assist USB2PHY and USB3PHY reset, not for usb_phy_init()
sequence.
On 09/21/2013 07:00 AM, Maxime Ripard wrote:
[ ... ]
+ /* assert cpu core reset */
+ writel(0, sunxi7i_cc_base + CPUX_RESET_CTL(cpu));
+ /* L1RSTDISABLE hold low */
+ pwr_reg = readl(sunxi7i_cc_base + AW_CPUCFG_GENCTL);
+ pwr_reg &= ~(1<
Use BIT(cpu) here. And
Acked-by: Steven Miao
On Tue, Sep 3, 2013 at 4:29 PM, Sonic Zhang wrote:
> From: Sonic Zhang
>
> - Remove unused macro MAX_RESOURCES
> - Override blackfin legacy peripheral pinmux request and free APIs by
> devm_pinctrl_get_select_default() to init the peripheral portmux setting.
>
>
Hi Greg,
Today's linux-next merge of the staging tree got a conflict in
drivers/iio/industrialio-event.c between commit cadc2125e140 ("iio: fix:
Keep a reference to the IIO device for open file descriptors") from the
staging.current tree and commit a646fbf0fd11 ("iio: use anon_inode_getfd
() with
Acked-by: Steven Miao
On Tue, Sep 3, 2013 at 4:29 PM, Sonic Zhang wrote:
> From: Sonic Zhang
>
> - Remove non gpio lib code from blackfin architecture.
> - Limit the lagecy blackfin gpio driver to bf5xx processors only.
> - Remove unused definition of the pint power functions.
>
>
Hi Linus,
On Thu, Sep 19, 2013 at 8:45 PM, Linus Walleij wrote:
> On Tue, Sep 3, 2013 at 10:28 AM, Sonic Zhang wrote:
>
>> From: Sonic Zhang
>>
>> The new ADI GPIO2 controller was introduced since the BF548 and BF60x
>> processors. It differs a lot from the old one on BF5xx processors. So,
>>
Hi Greg,
Today's linux-next merge of the staging tree got a conflict in
drivers/iio/industrialio-buffer.c between commit d66e0452bf6b ("iio: Fix
crash when scan_bytes is computed with active_scan_mask == NUL") from the
staging.current tree and commit 705ee2c98a37 ("iio:buffer: Simplify
On Sun, Sep 22, 2013 at 08:16:23PM -0400, Jörn Engel wrote:
> How about we switch between the two mixing functions depending on the
> interrupt load? If this CPU has seen fewer than 1000 interrupts in
> the last second, use the better one, otherwise us the cheaper one?
I guess the question here
On Mon, 2013-09-23 at 12:38 +1000, Ryan Mallon wrote:
> A checkpatch rule might help,
Extant.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
> In the systemd case we have to ensure that we never ever merge a module named
> "systemd".
Interesting ...
> We have all kinds of strange modules/drivers. Usually you don't have to think
> whether your module is a "ordinary" driver or not...
Would it become useful to move "drivers" which do
On 23/09/13 12:16, Joe Perches wrote:
> On Mon, 2013-09-23 at 11:59 +1000, Ryan Mallon wrote:
>> This seems like a lot of code churn for very little benefit. At a quick
>> glance:
>>
>> git grep extern include/ | wc -l
>> 11427
>>
>> Not all of those will need to be removed, but that is still
[ 27.190017] kernel BUG at include/linux/scatterlist.h:115!
[ 27.190017] invalid opcode: [#1] PREEMPT SMP DEBUG_PAGEALLOC
[ 27.190017] Modules linked in: mxm_wmi iwldvm mac80211 iwlwifi
cfg80211 snd_hda_intel(+) snd_hda_codec snd_hwdep snd_pcm_oss
snd_mixer_oss hwmon snd_pcm ttm
Hi Tomi,
Today's linux-next merge of the omap_dss2 tree got a conflict in
drivers/video/atmel_lcdfb.c between commits a17c2e7b704f ("video:
atmel_lcdfb: fix platform data struct") and 5e8be022fb5b ("video:
atmel_lcdfb: add device tree suport") from the fbdev tree and commit
a5d58be0796a ("video:
On Sun, 22 Sep 2013, Kurt Garloff wrote:
> Hi Alan,
>
> thanks for your review and your constructive comments!
You're welcome.
> >> Hi,
> >>
> >> USB devio rejects control messages when the index does not have the
> >> direction bit set correctly.
> >
> >I wouldn't describe it that way. It
On Mon, 23 Sep 2013 03:08:36 +0200 from bitbuc...@online.de wrote:
> On Sun, 2013-09-22 at 12:42 +0200, Manfred Spraul wrote:
>
>> Mike: no, your patch makes it worse:
>> - wait-for-zero semops still don't update sem_otime
>> - sem_otime is initialized to sem_ctime. That's not mentioned in the
On Mon, 2013-09-23 at 11:59 +1000, Ryan Mallon wrote:
> This seems like a lot of code churn for very little benefit. At a quick
> glance:
>
> git grep extern include/ | wc -l
> 11427
>
> Not all of those will need to be removed, but that is still a huge
> number to change, and doesn't
On 09/10/2013 12:29 AM, Seth Jennings wrote:
> On Fri, Sep 06, 2013 at 01:16:45PM +0800, Weijie Yang wrote:
>> add SetPageReclaim before __swap_writepage so that page can be moved to the
>> tail of the inactive list, which can avoid unnecessary page scanning as this
>> page was reclaimed by swap
When recording raw_syscalls for the entire system, e.g.,
perf record -e raw_syscalls:*,sched:sched_switch -a -- sleep 1
you end up with a negative feedback loop as perf itself calls
write() fairly often. This patch mmap's the file in chunks of 64M
at a time and copies events from the event
On 23/09/13 03:32, Joe Perches wrote:
> There are a mix of function prototypes with and without extern
> in the kernel sources. Standardize on not using extern for
> function prototypes.
>
> Function prototypes don't need to be written with extern.
> extern is assumed by the compiler. Its use
This patch fixes a problem with EFI memory maps larger than 128 entries
when booting using the EFI stub, which results in overflowing e820_map
in boot_params and an eventual halt when checking the map size in
sanitize_e820_map().
If the number of map entries is greater than what can fit in
On 09/22/2013 03:51 PM, Chao Yu wrote:
> Previously, recover_fsync_data still to write checkpoint when there is
> nothing to recover with normal umount image.
> It may reduce mount performance and flash memory lifetime, so let's remove
> it.
>
> Signed-off-by: Tan Shu
> Signed-off-by: Yu Chao
On 09/22/2013 03:50 PM, Chao Yu wrote:
> This patch add macro MAX_BIO_BLOCKS to limit value of npages in
> f2fs_bio_alloc, it can avoid allocating failure in bio_alloc caused by
> npages is larger than BIO_MAX_PAGES.
>
> Signed-off-by: Yu Chao
Reviewed-by: Gu Zheng
> ---
>
5c5e854b changed perf_event__synthesize_mmap_events to generate MMAP2
events. Since perf-trace does not have a handler for it it dies with a
segfault when trying to process files:
perf trace -i /tmp/perf.data
Segmentation fault
Signed-off-by: David Ahern
---
tools/perf/builtin-trace.c |1 +
Before:
0.030 ( 0.002 ms): 2571 clock_gettime(which_clock: 1, tp: 0x7f3b45729cd0 ) = 0
After:
0.030 ( 0.002 ms): 2571 clock_gettime(which_clock: MONOTONIC, tp:
0x7f3b45729cd0 ) = 0
v2: Update to use the STRARRAY option
Signed-off-by: David Ahern
Cc: Adrian Hunter
Cc: Frederic Weisbecker
Cc:
Commands that do not implement an mmap2 handler should at least
not die with a segfault when processing files with MMAP2 events.
Signed-off-by: David Ahern
---
tools/perf/util/session.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/session.c
Fixes compile failure on Fedora 12.
Signed-off-by: David Ahern
---
tools/perf/config/Makefile |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 6850529..85fc870 100644
--- a/tools/perf/config/Makefile
+++
Arnaldo:
Various bug fixes hit working on the mmap write change and version 2 on the
clock_gettime beautifier. One other problem I was not able to resolve is
with perf-trace not displaying comms when processing files. eg.,
0.025 ( 0.000 ms): :7137/7137 ... [continued]: ioctl()) = 0
Needed for compiles on Fedora 12 for example.
Signed-off-by: David Ahern
---
tools/perf/builtin-trace.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index f869c87..9c7f017 100644
--- a/tools/perf/builtin-trace.c
+++
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han
---
drivers/misc/pti.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/pti.c
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han
---
drivers/misc/mei/pci-me.c |1 -
1 file changed, 1 deletion(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han
---
drivers/misc/ibmasm/module.c |2 --
1 file changed, 2 deletions(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han
---
drivers/misc/tifm_7xx1.c |3 ---
1 file changed, 3 deletions(-)
diff --git
On Sun, 22 September 2013 19:36:41 -0400, Theodore Ts'o wrote:
> On Sun, Sep 22, 2013 at 04:53:34PM -0400, Jörn Engel wrote:
> >
> > And I want to keep that function. Essentially the point of fast_mix()
> > is to ratelimit _mix_pool_bytes(). Naïve ratelimiting would simply
> > discard the input
Rob Landley writes:
> On 09/15/2013 11:08:35 PM, Rusty Russell wrote:
>> Predates git, does anyone remember the rationale?
>
> Depends which git: http://landley.net/kdocs/fullhist/ :)
Not useful. See Geert's more helpful response.
Cheers,
Rusty.
--
To unsubscribe from this list: send the line
The FAULT_FLAG_WRITE flag has been set based on uninitialized variable
Signed-off-by: Felipe Pena
---
arch/parisc/mm/fault.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/parisc/mm/fault.c b/arch/parisc/mm/fault.c
index d10d27a..00c0ed3 100644
---
On Sun, 2013-09-22 at 12:42 +0200, Manfred Spraul wrote:
> Mike: no, your patch makes it worse:
> - wait-for-zero semops still don't update sem_otime
> - sem_otime is initialized to sem_ctime. That's not mentioned in the
> sysv standard.
So sem_otime = 0 is a specified semaphore state? I
I'm apologize ahead of time if this thread isn't appropriate, I'm not
very familiar with mailing lists, especially lkml. I'm also very new
to kernel/module development (as of literally yesterday).
I was looking into getting the LED working properly for the Xbox 360
controllers and learning about
On Sun, 2013-09-22 at 20:44 +0200, Peter Senna Tschudin wrote:
> Convert 0 to false and 1 to true when assigning values to bool
> variables. Inspired by commit 3db1cd5c05f35fb43eb134df6f321de4e63141f2.
[]
> @@
> bool b;
> @@
> -b = 1
> +b = true
You might also look for non-zero values other than
On 09/22/2013 04:23 PM, Theodore Ts'o wrote:
> On Sun, Sep 22, 2013 at 03:45:11PM -0700, H. Peter Anvin wrote:
>> I understand the motivation, but I question basing it in a fixed amount of
>> time.
>
> We already have a threshold based on the amount of the entropy in the
> input pool. I could
On 09/22/2013 04:07 PM, Roy Franz wrote:
> On Sun, Sep 22, 2013 at 3:54 PM, H. Peter Anvin wrote:
>> Sorry this version is broken and doesn't even compile due to remaining
>> options_size references.
>
> I compiled and tested this series on both x86_64 (using OVMF) and on
> the ARM simulator.
On Tue, Sep 17, 2013 at 09:14:52PM +0100, Matt Fleming wrote:
> > +static efi_status_t alloc_e820ext(u32 nr_desc, struct setup_data **e820ext,
> > + u32 *e820ext_size)
> > +{
> > + efi_status_t status;
> > + unsigned long size;
> > +
> > + size = sizeof(struct
Hello Johannes,
On Sun, Sep 22, 2013 at 7:58 PM, Johannes Weiner wrote:
> Hello Felipe,
>
> On Sun, Sep 22, 2013 at 03:17:46PM -0300, Felipe Pena wrote:
>> The FAULT_FLAG_WRITE flag has been set based on uninitialized variable
>
> Oops, you are right.
>
>> Signed-off-by: Felipe Pena
>> ---
>>
Hi Konrad,
On Fri, 20 Sep 2013 14:35:17 -0400 Konrad Rzeszutek Wilk
wrote:
>
> > ibft1 year, 9 months ago
>
> Can go away.
>
> > swiotlb 11 months ago
>
> Need it. Don't remove it pls.
>
> > tmem11 months ago
>
> Can go away.
OK, 2 removed.
On Sun, Sep 22 2013, Linus Torvalds wrote:
> On Sun, Sep 22, 2013 at 4:12 PM, Jens Axboe wrote:
> >
> > Not necessarily bad quality control, but yeah, the commit messages
> > could've been prettier. Those two should have been git ammended, most of
> > them are directly applied byt git am fwiw.
>
On Sun, Sep 22, 2013 at 04:53:34PM -0400, Jörn Engel wrote:
>
> And I want to keep that function. Essentially the point of fast_mix()
> is to ratelimit _mix_pool_bytes(). Naïve ratelimiting would simply
> discard the input once the ratelimit has been reached. My proposal is
> to still use the
On Sun, Sep 22, 2013 at 4:12 PM, Jens Axboe wrote:
>
> Not necessarily bad quality control, but yeah, the commit messages
> could've been prettier. Those two should have been git ammended, most of
> them are directly applied byt git am fwiw.
No, one of them was clearly *not* done with git am,
On Sun, Sep 22, 2013 at 03:45:11PM -0700, H. Peter Anvin wrote:
> I understand the motivation, but I question basing it in a fixed amount of
> time.
We already have a threshold based on the amount of the entropy in the
input pool. I could increase that threshold, but then instead of
having the
On Sun, Sep 22 2013, Olof Johansson wrote:
> On Sat, Sep 21, 2013 at 1:01 PM, Jens Axboe wrote:
> > On Fri, Sep 20 2013, Andrew Morton wrote:
> >> On Tue, 17 Sep 2013 14:20:55 -0600 Jens Axboe wrote:
> >>
> >> > > So, it looks like this driver needs a bunch of work before it's ready
> >> > > to
On Sun, Sep 22 2013, Linus Torvalds wrote:
> On Sun, Sep 22, 2013 at 2:55 PM, Jens Axboe wrote:
> >
> > Mike Christie (1):
> > If the queue is dying then we only call the rq->end_io callout.
> > This leaves bios setup on the request, because the caller assumes when
> > the
On Sun, Sep 22, 2013 at 3:54 PM, H. Peter Anvin wrote:
> Sorry this version is broken and doesn't even compile due to remaining
> options_size references.
I compiled and tested this series on both x86_64 (using OVMF) and on
the ARM simulator. I just doubled checked
my kernel .config to verify
On Sat, Sep 21, 2013 at 1:01 PM, Jens Axboe wrote:
> On Fri, Sep 20 2013, Andrew Morton wrote:
>> On Tue, 17 Sep 2013 14:20:55 -0600 Jens Axboe wrote:
>>
>> > > So, it looks like this driver needs a bunch of work before it's ready
>> > > to go in. Or, maybe it's better to submit it with a TODO
Hello Felipe,
On Sun, Sep 22, 2013 at 03:17:46PM -0300, Felipe Pena wrote:
> The FAULT_FLAG_WRITE flag has been set based on uninitialized variable
Oops, you are right.
> Signed-off-by: Felipe Pena
> ---
> arch/parisc/mm/fault.c |5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Sorry this version is broken and doesn't even compile due to remaining
options_size references.
Roy Franz wrote:
>From: "H. Peter Anvin"
>
>Improve the conversion of the UTF-16 EFI command line
>to UTF-8 for passing to the kernel.
>
>Signed-off-by: Roy Franz
>---
>
Rename function in preparation for making it more flexible
and sharing it.
Signed-off-by: Roy Franz
---
drivers/firmware/efi/efi-stub-helper.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/firmware/efi/efi-stub-helper.c
The x86/AMD64 EFI stubs must use a call wrapper to convert between
the Linux and EFI ABIs, so void pointers are sufficient. For ARM,
the ABIs are compatible, so we can directly invoke the function
pointers. The functions that are used by the ARM stub are updated
to match the EFI definitions.
No code changes made, just moving functions and #define from x86 arch
directory to common location. Code is shared using #include, similar
to how decompression code is shared among architectures.
Signed-off-by: Roy Franz
Acked-by: Mark Salter
Reviewed-by: Grant Likely
---
Add system table pointer argument to shared EFI stub related functions
so they no longer use a global system table pointer as they did when part
of eboot.c. For the ARM EFI stub this allows us to avoid global
variables completely and thereby not have to deal with GOT fixups.
Not having the EFI
From: "H. Peter Anvin"
Improve the conversion of the UTF-16 EFI command line
to UTF-8 for passing to the kernel.
Signed-off-by: Roy Franz
---
arch/x86/boot/compressed/eboot.c |3 +-
drivers/firmware/efi/efi-stub-helper.c | 92
2 files changed, 72
Rename relocate_kernel() to efi_relocate_kernel(), and take
parameters rather than x86 specific structure. Add max_addr
argument as for ARM we have some address constraints that we
need to enforce when relocating the kernel. Add alloc_size
parameter for use by ARM64 which uses an uncompressed
Move the open-coded conversion to a shared function for
use by all architectures. Change the allocation to prefer
a high address for ARM, as this is required to avoid conflicts
with reserved regions in low memory. We don't know the specifics
of these regions until after we process the command
Move efi-stub.txt out of x86 directory and into common directory
in preparation for adding ARM EFI stub support.
Signed-off-by: Roy Franz
---
Documentation/efi-stub.txt | 65
Documentation/x86/efi-stub.txt | 65
The relocate_kernel() function will be generalized and used
by all architectures, as they all have similar requirements.
Signed-off-by: Roy Franz
---
arch/x86/boot/compressed/eboot.c | 34 ---
drivers/firmware/efi/efi-stub-helper.c | 35
Rename them to be more similar, as low_free() could be used to free
memory allocated by both high_alloc() and low_alloc().
high_alloc() -> efi_high_alloc()
low_alloc() -> efi_low_alloc()
low_free() -> efi_free()
Signed-off-by: Roy Franz
Acked-by: Mark Salter
Reviewed-by: Grant Likely
---
The handle_cmdline_files now takes the option to handle as a string,
and returns the loaded data through parameters, rather than taking
an x86 specific setup_header structure. For ARM, this will be used
to load a device tree blob in addition to initrd images.
Signed-off-by: Roy Franz
Acked-by:
Replace the open-coded memory map getting with the
efi_get_memory_map() that is now general enough to use.
Signed-off-by: Roy Franz
---
arch/x86/boot/compressed/eboot.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/arch/x86/boot/compressed/eboot.c
Make efi_free() safely callable with size of 0, similar to free() being
callable with NULL pointers.
Remove size checks that this makes redundant. This also avoids some
size checks in the ARM EFI stub code that will be added as well.
Signed-off-by: Roy Franz
---
Rename variables to be not initrd specific, as now the function
loads arbitrary files. This change is exclusively renames
and comment changes to reflect the generalization.
Signed-off-by: Roy Franz
Acked-by: Mark Salter
Reviewed-by: Grant Likely
---
drivers/firmware/efi/efi-stub-helper.c |
warnings from gcc:
warning: label 'free_pool' defined but not used [-Wunused-label]
warning: value computed is not used [-Wunused-value]
Signed-off-by: Roy Franz
---
drivers/firmware/efi/efi-stub-helper.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
Add arguments for returning the descriptor version and also
the memory map key. The key is required for calling
exit_boot_services().
Signed-off-by: Roy Franz
---
drivers/firmware/efi/efi-stub-helper.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git
EFI calls can made directly on ARM, so the function pointers
are directly invoked. This allows types to be checked at
compile time, so here we ensure that the parameters match
the function signature. The wrappers used by x86 prevent
any type checking.
Correct the type of chunksize to be based on
I understand the motivation, but I question basing it in a fixed amount of time.
Theodore Ts'o wrote:
>On Sun, Sep 22, 2013 at 02:21:48PM -0700, H. Peter Anvin wrote:
>> Is this really an improvement on a system with plenty of entropy?
>Would it not make more sense to modulate this bad on
This patch is the common/x86 portion of the ARM EFI stub
patchset broken out. These changes support the addition
of EFI stub support for the ARM and ARM64 architectures.
The common code that is now shared in efi-stub-helper.c
is based on code in the x86 stub that has been generalized
to support
The efi_high_alloc() and efi_low_alloc() functions
use the EFI_ALLOCATE_ADDRESS option to the EFI
function allocate_pages(), which requires a minimum
of page alignment, and rejects all other requests.
The existing code could fail to allocate depending
on allocation size, as although repeated
1 - 100 of 598 matches
Mail list logo
