Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 10:49:07PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov > wrote: > > On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: > >> On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov > >> wrote: > >> >

[PATCH] slub: Fix possible format string bug.

2014-01-03 Thread Tetsuo Handa
I found an unapplied patch from https://lkml.org/lkml/2013/9/19/17 . -- >From 38f01b48ae371058845274f4d7def4d81dbac4ea Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Sat, 4 Jan 2014 16:26:00 +0900 Subject: [PATCH] slub: Fix possible format string bug. The "name" is determined at

Re: [RFC PATCHv3 00/11] Intermix Lowmem and vmalloc

2014-01-03 Thread Minchan Kim
Hello, On Fri, Jan 03, 2014 at 02:08:52PM -0800, Laura Abbott wrote: > On 1/3/2014 10:23 AM, Dave Hansen wrote: > >On 01/02/2014 01:53 PM, Laura Abbott wrote: > >>The goal here is to allow as much lowmem to be mapped as if the block of > >>memory > >>was not reserved from the physical lowmem

[PATCH v2 1/8] staging/lustre/llite: remove ll_d_root_ops

2014-01-03 Thread Peng Tao
From: Lai Siyao Mnt root dentry will never be revalidated, but its d_op->d_compare will be called for its children, to simplify code, we use the same ll_d_ops as normal dentries. But its attribute may be invalid before access, this won't cause any issue because it always exists, and the only

[PATCH v2 2/8] staging/lustre/llite: don't d_add for create only files

2014-01-03 Thread Peng Tao
From: Lai Siyao This is only part of the original Lustre commit. Splitted to remove d_add() for create only files, because the dentry is fake, and will be released right after use. Lustre-change: http://review.whamcloud.com/6797 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3486

[PATCH v2 6/8] staging/lustre/obdclass: remove extra break in class_process_config

2014-01-03 Thread Peng Tao
From: Artem Blagodarenko This is only part of the original Lustre commit, splitted to do the cleanup work. Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3155 Lustre-change: http://review.whamcloud.com/6025 Signed-off-by: Artem Blagodarenko Reviewed-by: Andreas Dilger Reviewed-by: Emoly

[PATCH v2 5/8] staging/lustre/mgs: set_param -P option that sets value permanently

2014-01-03 Thread Peng Tao
From: Artem Blagodarenko set_param and conf_param have different syntaxes. Also conf_param has unimplemented paths and no wildcarding support. This patch adds set_param -P option, that replaces the whole conf_param "direct" proc access with a simple upcall-type mechanism from the MGC. Option

[PATCH v2 3/8] staging/lustre/llite: pass correct pointer to obd_iocontrol()

2014-01-03 Thread Peng Tao
From: "John L. Hammond" In copy_and_ioctl() use the kernel space copy as the karg to obd_iocontrol(). Lustre-change: http://review.whamcloud.com/6274 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3283 Signed-off-by: John L. Hammond Reviewed-by: Sebastien Buisson Reviewed-by: Oleg Drokin

[PATCH v2 7/8] staging/lustre/lustre_user.h: remove obsolete comments

2014-01-03 Thread Peng Tao
From: JC Lafoucriere This is only part of the original Lustre commit, main part of which changes user space code. And now the comments above struct hsm_copy is no more true. Lustre-change: http://review.whamcloud.com/4737 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2062 Signed-off-by:

[PATCH v2 8/8] staging/lustre/ptlrpc: flock deadlock detection does not work

2014-01-03 Thread Peng Tao
From: Andriy Skulysh Flock deadlocks are checked on the first attempt to grant the flock only. If we try again to grant it after its blocking lock is cancelled, we don't check for deadlocks which also may exist. Perform deadlock detection during reprocess Intel-bug-id:

[PATCH v2 0/8] staging/lustre: sync with external tree

2014-01-03 Thread Peng Tao
Hi Greg, Happy New Year! I hope it is long enough to start sending you new patches. Here are the updated version of previous series. Each patch is checkpatch'ed and build-tested independently. Please see if it is OK to merge them. Thanks, Tao Cc: Andreas Dilger Andreas Dilger (1):

[PATCH v2 4/8] staging/lustre/idl: remove LASSERT/CLASSERT from lustre_idl.h

2014-01-03 Thread Peng Tao
From: Andreas Dilger Remove the usage of LASSERT() and CLASSERT() from lustre_idl.h, so that it is usable from userspace programs if needed. These have crept in over the years, but are not intended to be there. The CLASSERT() checks for fid swabbing were largely redundant, and have been moved

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov wrote: > On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: >> On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov >> wrote: >> > pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use >> > get_unaligned_le16 to access

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov > wrote: > > pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use > > get_unaligned_le16 to access it. > > > > Also let's add build time check to make sure it

Re: [BUG]NULL pointer dereference at 0000000000000008 __blkdev_put+0x17f/0x1d0

2014-01-03 Thread Al Viro
On Thu, Jan 02, 2014 at 10:36:30AM +0100, Jack Wang wrote: > > Bug happened at line 1486, looks disk->fops is NULL here for some > > reason, is it reasonable to add a check like: > > > > if (disk->fops) > > if (disk->fops->release) > > ret = disk->fops->release(disk, mode); > >

[net-next v5 01/17] pci_regs.h: Add PCI bus link speed and width defines

2014-01-03 Thread Jeff Kirsher
Add missing PCI bus link speed 8.0 GT/s and bus link widths of x1, x2, x4 and x8. CC: CC: Bjorn Helgaas Signed-off-by: Jeff Kirsher Acked-by: Bjorn Helgaas --- include/uapi/linux/pci_regs.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/pci_regs.h

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov wrote: > pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use > get_unaligned_le16 to access it. > > Also let's add build time check to make sure it stays aligned. - AFAIK, there's no guarantee the "pcu" itself is aligned -

Re: [PATCH 1/1] watchdog: Adding Merrifield watchdog driver support

2014-01-03 Thread Guenter Roeck
On 01/02/2014 04:56 PM, eric.er...@linux.intel.com wrote: From: Gabriel Touzeau Added Merrifield watchdog driver support. Based on initial implementation from prior Intel SCU-based platforms, this driver has several changes specific to the Tangier SoC / Merrifield platform. New watchdog

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 09:03:11PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 8:44 PM, Dmitry Torokhov > wrote: > > On Fri, Jan 03, 2014 at 08:24:17PM -0800, Andrey Smirnov wrote: > >> On Fri, Jan 3, 2014 at 5:39 PM, Dmitry Torokhov > >> wrote: > >> > Hi Andrey, > >> > > >> > On Wed,

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v2]

2014-01-03 Thread rui wang
On 12/29/13, Prarit Bhargava wrote: > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 > > When downing a cpu it is possible that there are unhandled irqs left in > the APIC IRR register. The following code path shows how the problem > can occur: > > 1. CPU 5 is to go down. > 2. CPU 5

Re: [PATCHv4 0/2] twl4030-keypad DT binding

2014-01-03 Thread Sebastian Reichel
Dmitry, What's the status of this patch? Can you queue this for 3.14? -- Sebastian signature.asc Description: Digital signature

Re: [PATCH] Input: ims-pcu - fix error unwinding path in application mode

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 09:13:10PM -0800, Andrey Smirnov wrote: > Dmitry, > > Do you want this patch to go separatly or do you want me to bundle it > with my other changes(probably the first one)? I'll apply it separately. > Also, offtopic, do you want me to backport this changes to 2.6 kernel

[PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use get_unaligned_le16 to access it. Also let's add build time check to make sure it stays aligned. Signed-off-by: Dmitry Torokhov --- drivers/input/misc/ims-pcu.c | 8 ++-- 1 file changed, 6 insertions(+), 2

Re: [PATCH] Input: ims-pcu - fix error unwinding path in application mode

2014-01-03 Thread Andrey Smirnov
Dmitry, Do you want this patch to go separatly or do you want me to bundle it with my other changes(probably the first one)? Also, offtopic, do you want me to backport this changes to 2.6 kernel that IMS uses or would you do it? Thanks, On Fri, Jan 3, 2014 at 9:00 PM, Dmitry Torokhov wrote: >

Re: linux-next: manual merge of the renesas tree with the arm-soc tree

2014-01-03 Thread Olof Johansson
On Mon, Dec 16, 2013 at 2:00 AM, Nicolas Ferre wrote: > On 16/12/2013 00:47, Stephen Rothwell : >> Hi Simon, >> >> Today's linux-next merge of the renesas tree got a conflict in >> drivers/clk/Makefile between commit 0ad6125b1579 ("clk: at91: add PMC >> base support") from the arm-soc tree and

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 8:44 PM, Dmitry Torokhov wrote: > On Fri, Jan 03, 2014 at 08:24:17PM -0800, Andrey Smirnov wrote: >> On Fri, Jan 3, 2014 at 5:39 PM, Dmitry Torokhov >> wrote: >> > Hi Andrey, >> > >> > On Wed, Jan 01, 2014 at 04:47:01PM -0800, Andrey Smirnov wrote: >> >> New version of the

[PATCH] Input: ims-pcu - fix error unwinding path in application mode

2014-01-03 Thread Dmitry Torokhov
We first create backlight and then input devices so we shoudl destroy them in opposite order when handling errors. Signed-off-by: Dmitry Torokhov --- Andrey, this fixup was split off from the patch I sent earlier today. drivers/input/misc/ims-pcu.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 08:24:17PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 5:39 PM, Dmitry Torokhov > wrote: > > Hi Andrey, > > > > On Wed, Jan 01, 2014 at 04:47:01PM -0800, Andrey Smirnov wrote: > >> New version of the PCU firmware supports two new commands: > >> -

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 5:39 PM, Dmitry Torokhov wrote: > Hi Andrey, > > On Wed, Jan 01, 2014 at 04:47:01PM -0800, Andrey Smirnov wrote: >> New version of the PCU firmware supports two new commands: >> - IMS_PCU_CMD_OFN_SET_CONFIG which allows to write data to the >> registers of one finger

Re: [PATCH] mm/mlock: fix BUG_ON unlocked page for nolinear VMAs

2014-01-03 Thread Bob Liu
On 01/04/2014 04:52 AM, Linus Torvalds wrote: > On Fri, Jan 3, 2014 at 12:17 PM, Sasha Levin wrote: >> >> Ping? This BUG() is triggerable in 3.13-rc6 right now. > > So Andrew suggested just removing the BUG_ON(), but it's been there > for a *long* time. > > And I detest the patch that was sent

Re: [PATCH] mm/mlock: fix BUG_ON unlocked page for nolinear VMAs

2014-01-03 Thread Sasha Levin
On 01/03/2014 06:56 PM, Andrew Morton wrote: Nobody answered my question! Is this a new bug or is it a five-year-old bug which we only just discovered? I've rolled trinity back and was unable to reproduce this issue anymore. This seems to be a 5 year old bug. Thanks, Sasha -- To unsubscribe

Re: mm: kernel BUG at include/linux/swapops.h:131!

2014-01-03 Thread Sasha Levin
On 01/02/2014 01:36 AM, Bob Liu wrote: I have no idea why this BUG_ON was triggered. And it looks like 'mm: kernel BUG at mm/huge_memory.c:1440!' have the same call trace with this one. Perhaps they were introduced by the same reason. Could you confirm whether those issues exist in v3.13-rc6?

RE: [PATCH V4 1/6] clk: exynos-audss: convert to platform device

2014-01-03 Thread kgene
Tomasz Figa wrote: > > Hi Kukjin, Mike, > > On Monday 02 of December 2013 07:43:42 Kukjin Kim wrote: > > On 11/28/13 03:41, Mike Turquette wrote: > > > Quoting Padma Venkat (2013-11-25 22:29:44) > > >> Hi Mike and Kukjin, > > >> > > >> On Tue, Oct 8, 2013 at 10:23 PM, Andrew Bresticker > > >>

[PATCH 02/15] tpm/tpm_ppi: Check return value of acpi_get_name

2014-01-03 Thread Peter Huewe
From: Peter Huewe If status = acpi_get_name(handle, ACPI_FULL_PATHNAME, ); fails for whatever reason and does not return AE_OK if (strstr(buffer.pointer, context) != NULL) { does dereference a null pointer. -> Check the return value and return the status to the caller Found by coverity Cc:

[PATCH 12/15] tpm: Use the ops structure instead of a copy in tpm_vendor_specific

2014-01-03 Thread Peter Huewe
From: Jason Gunthorpe This builds on the last commit to use the ops structure in the core and reduce the size of tpm_vendor_specific. Signed-off-by: Jason Gunthorpe Reviewed-by: Joel Schopp Reviewed-by: Ashley Lai Signed-off-by: Peter Huewe --- drivers/char/tpm/tpm-interface.c| 34

[PATCH 04/15] tpm/tpm_ibmvtpm: fix unreachable code warning (smatch warning)

2014-01-03 Thread Peter Huewe
From: Peter Huewe smatch complains: drivers/char/tpm/tpm_ibmvtpm.c:510 ibmvtpm_crq_process() info: ignoring unreachable code. -> The return is not necessary here, remove it Signed-off-by: Peter Huewe --- drivers/char/tpm/tpm_ibmvtpm.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 14/15] tpm: tpm_tis: Fix compile problems with CONFIG_PM_SLEEP/CONFIG_PNP

2014-01-03 Thread Peter Huewe
From: Jason Gunthorpe If CONFIG_PM_SLEEP=n, CONFIG_PNP=y we get this warning: drivers/char/tpm/tpm_tis.c:706:13: warning: 'tpm_tis_reenable_interrupts' defined but not used [-Wunused-function] This seems to have been introduced in a2fa3fb0d 'tpm: convert tpm_tis driver to use dev_pm_ops from

[PATCH 13/15] tpm: Make tpm-dev allocate a per-file structure

2014-01-03 Thread Peter Huewe
From: Jason Gunthorpe This consolidates everything that is only used within tpm-dev.c into tpm-dev.c and out of the publicly visible struct tpm_chip. The per-file allocation lays the ground work for someday fixing the strange forced O_EXCL behaviour of the current code. Signed-off-by: Jason

[PATCH 03/15] tpm/tpm_i2c_stm_st33: Check return code of get_burstcount

2014-01-03 Thread Peter Huewe
From: Peter Huewe The 'get_burstcount' function can in some circumstances 'return -EBUSY' which in tpm_stm_i2c_send is stored in an 'u32 burstcnt' thus converting the signed value into an unsigned value, resulting in 'burstcnt' being huge. Changing the type to u32 only does not solve the problem

[PATCH 15/15] tpm/tpm-sysfs: active_show() can be static

2014-01-03 Thread Peter Huewe
From: Fengguang Wu so we make it static CC: Jason Gunthorpe CC: Peter Huewe Signed-off-by: Fengguang Wu Signed-off-by: Peter Huewe --- drivers/char/tpm/tpm-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm-sysfs.c

[PATCH 05/15] tpm/tpm_i2c_atmel: fix coccinelle warnings

2014-01-03 Thread Peter Huewe
From: Fengguang Wu drivers/char/tpm/tpm_i2c_atmel.c:178:8-9: WARNING: return of 0/1 in function 'i2c_atmel_req_canceled' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: coccinelle/misc/boolreturn.cocci CC: Jason

[PATCH 06/15] tpm: MAINTAINERS: Cleanup TPM Maintainers file

2014-01-03 Thread Peter Huewe
From: Peter Huewe - removing stale/inactive maintainers - removing stale/outdated website - regrouped maintainers Signed-off-by: Peter Huewe --- MAINTAINERS | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d5e4ff3..3924b10 100644 ---

[PATCH 08/15] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2014-01-03 Thread Peter Huewe
From: Jason Gunthorpe CLASS-dev.c is a common idiom for Linux subsystems This pulls all the code related to the miscdev into tpm-dev.c and makes it static. The identical file_operation structs in the drivers are purged and the tpm common code unconditionally creates the miscdev. Signed-off-by:

[PATCH 07/15] char: tpm: nuvoton: remove unused variable

2014-01-03 Thread Peter Huewe
From: Michal Nazarewicz “wait” wait queue is defined but never used in the function, thus it can be removed. Signed-off-by: Michal Nazarewicz Acked-by: Jason Gunthorpe Signed-off-by: Peter Huewe --- drivers/char/tpm/tpm_i2c_nuvoton.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 09/15] tpm: Move sysfs functions from tpm-interface to tpm-sysfs

2014-01-03 Thread Peter Huewe
From: Jason Gunthorpe CLASS-sysfs.c is a common idiom for linux subsystems. This is the first step to pulling all the sysfs support code from the drivers into tpm-sysfs. This is a plain text copy from tpm-interface with support changes to make it compile. _tpm_pcr_read is made non-static and

[PATCH 11/15] tpm: Create a tpm_class_ops structure and use it in the drivers

2014-01-03 Thread Peter Huewe
From: Jason Gunthorpe This replaces the static initialization of a tpm_vendor_specific structure in the drivers with the standard Linux idiom of providing a const structure of function pointers. Signed-off-by: Jason Gunthorpe Reviewed-by: Joel Schopp Reviewed-by: Ashley Lai [phuewe: did

[PATCH 10/15] tpm: Pull all driver sysfs code into tpm-sysfs.c

2014-01-03 Thread Peter Huewe
From: Jason Gunthorpe The tpm core now sets up and controls all sysfs attributes, instead of having each driver have a unique take on it. All drivers now now have a uniform set of attributes, and no sysfs related entry points are exported from the tpm core module. This also uses the new method

[PATCH 01/15] tpm/tpm_ppi: Do not compare strcmp(a,b) == -1

2014-01-03 Thread Peter Huewe
From: Peter Huewe Depending on the implementation strcmp might return the difference between two strings not only -1,0,1 consequently if (strcmp (a,b) == -1) might lead to taking the wrong branch -> compare with < 0 instead, which in any case is more canonical. Cc: sta...@vger.kernel.org

[ANNOUNCE] 3.4.75-rt93

2014-01-03 Thread Steven Rostedt
Dear RT Folks, I'm pleased to announce the 3.4.75-rt93 stable release. This release is just an update to the new stable 3.4.75 version and no RT specific changes have been made. You can get this release via the git tree at:

TPM Changes for 3.14

2014-01-03 Thread Peter Hüwe
Hi James, since the next merge window approaches, can you please pull the following TPM Changes for 3.14? I'll send the patches as replies to this email. The following changes since commit 802eee95bde72fd0cd0f3a5b2098375a487d1eda: Linux 3.13-rc6 (2013-12-29 16:01:33 -0800) are available in

[ANNOUNCE] 3.10.25-rt23

2014-01-03 Thread Steven Rostedt
Dear RT Folks, I'm pleased to announce the 3.10.25-rt23 stable release. This release is just an update to the new stable 3.10.25 version and no RT specific changes have been made. You can get this release via the git tree at:

Re: [PATCH v12 10/18] xen/pvh: Update E820 to work with PVH (v2)

2014-01-03 Thread Konrad Rzeszutek Wilk
On Fri, Jan 03, 2014 at 05:23:37PM -0800, Mukesh Rathor wrote: > On Thu, 2 Jan 2014 13:41:34 -0500 > Konrad Rzeszutek Wilk wrote: > > > On Thu, Jan 02, 2014 at 04:14:32PM +, David Vrabel wrote: > > > On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote: > > > > From: Mukesh Rathor > > > > > > >

Re: [PATCH] lib/vsprintf: add %pT[C012] format specifier

2014-01-03 Thread Tetsuo Handa
I'm planning to convert task_struct->comm to use RCU so that they always get consistent result. Inconsistent result (e.g. trailing '\0' byte is emitted when printing string argument) is caused by breaking a rule that the string argument must not change during the function when it is passed as

Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

2014-01-03 Thread Jeff Kirsher
On Fri, 2014-01-03 at 20:48 -0500, David Miller wrote: > From: Jeff Kirsher > Date: Fri, 03 Jan 2014 17:27:39 -0800 > > > What do you want to do with the current series of patches > > (mainly the ixgbe LER patches) on my tree? I know that there is a > > thread going on between Joe Perches and

Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

2014-01-03 Thread David Miller
From: Jeff Kirsher Date: Fri, 03 Jan 2014 17:27:39 -0800 > What do you want to do with the current series of patches > (mainly the ixgbe LER patches) on my tree? I know that there is a > thread going on between Joe Perches and Mark, but it sounded like Mark > is working on a follow-on patch to

Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW

2014-01-03 Thread Dmitry Torokhov
Hi Andrey, On Wed, Jan 01, 2014 at 04:47:01PM -0800, Andrey Smirnov wrote: > New version of the PCU firmware supports two new commands: > - IMS_PCU_CMD_OFN_SET_CONFIG which allows to write data to the > registers of one finger navigation(OFN) chip present on the device > -

Re: [PATCH net-next] r8152: fix the wrong return value

2014-01-03 Thread David Miller
From: Hayes Wang Date: Fri, 3 Jan 2014 11:21:56 +0800 > The return value should be the boolean value, not the error code. > > Signed-off-by: Hayes Wang > Spotted-by: Dan Carpenter Applied, but I agree with others that it's more canonical to have the function return either an error code, or

Personal Loan

2014-01-03 Thread ''Hyde Finance Loan Company''
Are you in any kind of financial difficulties? if yes,Contact hydena...@gmail.com now for more details. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

2014-01-03 Thread Jeff Kirsher
On Fri, 2014-01-03 at 19:30 -0500, David Miller wrote: > From: Bjorn Helgaas > Date: Fri, 3 Jan 2014 17:00:42 -0700 > > > On Fri, Jan 3, 2014 at 4:56 PM, David Miller wrote: > >> From: Bjorn Helgaas > >> Date: Fri, 3 Jan 2014 15:15:57 -0700 > >> > >>> However, I do raise my eyebrows a bit at

Re: [PATCH v12 10/18] xen/pvh: Update E820 to work with PVH (v2)

2014-01-03 Thread Mukesh Rathor
On Thu, 2 Jan 2014 13:41:34 -0500 Konrad Rzeszutek Wilk wrote: > On Thu, Jan 02, 2014 at 04:14:32PM +, David Vrabel wrote: > > On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote: > > > From: Mukesh Rathor > > > > > > In xen_add_extra_mem() we can skip updating P2M as it's managed > > > by Xen.

Re: [PATCH v12 03/18] xen/pvh: Early bootup changes in PV code (v2).

2014-01-03 Thread Mukesh Rathor
On Fri, 3 Jan 2014 12:35:55 -0500 Konrad Rzeszutek Wilk wrote: > On Thu, Jan 02, 2014 at 05:34:38PM -0800, Mukesh Rathor wrote: > > On Thu, 2 Jan 2014 13:32:21 -0500 > > Konrad Rzeszutek Wilk wrote: > > > > > On Thu, Jan 02, 2014 at 03:32:33PM +, David Vrabel wrote: > > > > On 01/01/14

Re: [PATCH 3/3] smsc9420: use named constants for pci_power_t values

2014-01-03 Thread David Miller
From: Julia Lawall Date: Fri, 3 Jan 2014 00:40:31 +0100 > From: Julia Lawall > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall Applied, thanks Julia. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v3 1/2] usb: musb: add support for JZ4740 usb device controller

2014-01-03 Thread Richard Weinberger
On Thu, Dec 19, 2013 at 9:42 PM, Apelete Seketeli wrote: > Add support for Ingenic JZ4740 USB Device Controller through a > specific musb glue layer. > > JZ4740 UDC not being OTG compatible and missing some hardware > registers, this musb glue layer is written from scratch to be used in > gadget

Re: [Xen-devel] [PATCH v11 09/12] xen/pvh: Piggyback on PVHVM XenBus and event channels for PVH.

2014-01-03 Thread Mukesh Rathor
On Wed, 18 Dec 2013 16:17:39 -0500 Konrad Rzeszutek Wilk wrote: > On Wed, Dec 18, 2013 at 06:31:43PM +, Stefano Stabellini wrote: > > On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: > > > From: Mukesh Rathor > > > > > > PVH is a PV guest with a twist - there are certain things > > > that

Re: [PATCH] net: tulip: delete useless tests on netdev_priv

2014-01-03 Thread David Miller
From: Grant Grundler Date: Thu, 2 Jan 2014 07:57:26 -0800 > On Thu, Jan 2, 2014 at 8:28 AM, Julia Lawall wrote: >> From: Julia Lawall >> >> Netdev_priv performs an addition, not a pointer dereference, so it seems >> quit unlikely that its result would ever be NULL. > > LGTM. > > > >> A

Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

2014-01-03 Thread David Miller
From: Bjorn Helgaas Date: Fri, 3 Jan 2014 17:00:42 -0700 > On Fri, Jan 3, 2014 at 4:56 PM, David Miller wrote: >> From: Bjorn Helgaas >> Date: Fri, 3 Jan 2014 15:15:57 -0700 >> >>> However, I do raise my eyebrows a bit at drivers that poke around in >>> the PCIe capability. I would prefer to

Re: [Xen-devel] [PATCH v11 09/12] xen/pvh: Piggyback on PVHVM XenBus and event channels for PVH.

2014-01-03 Thread Mukesh Rathor
On Fri, 3 Jan 2014 15:04:27 + Stefano Stabellini wrote: > On Tue, 31 Dec 2013, Konrad Rzeszutek Wilk wrote: > > > > --- a/drivers/xen/xenbus/xenbus_client.c > > > > +++ b/drivers/xen/xenbus/xenbus_client.c > > > > @@ -45,6 +45,7 @@ > > > > #include > > > > #include > > > > #include > >

Re: [PATCH RESEND] netfilter: remove unused variable

2014-01-03 Thread Michal Nazarewicz
On Sat, Jan 04 2014, Pablo Neira Ayuso wrote: > On Wed, Jan 01, 2014 at 06:27:19AM +0100, Michal Nazarewicz wrote: >> The nfmsg variable is not used (except in sizeof operator which does >> not care about its value) between the first and second time it is >> assigned the value. Furthermore,

Re: [PATCH] cxgb4: allow large buffer size to have page size

2014-01-03 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Mon, 23 Dec 2013 15:34:29 -0200 > Since commit 52367a763d8046190754ab43743e42638564a2d1 > ("cxgb4/cxgb4vf: Code cleanup to enable T4 Configuration File support"), > we have failures like this during cxgb4 probe: > > cxgb4 :01:00.4: bad SGE FL page

Re: [PATCH 1/2] seqlock: Use raw_ prefix instead of _no_lockdep

2014-01-03 Thread John Stultz
On 01/02/2014 04:50 PM, Linus Torvalds wrote: > On Thu, Jan 2, 2014 at 3:11 PM, John Stultz wrote: >> Linus disliked the _no_lockdep() naming, so instead >> use the more-consistent raw_* prefix to the non-lockdep >> enabled seqcount methods. >> >> This also adds raw_ methods for the write

Re: [PATCH v5 0/4] Introduce pci_enable_msi/msix_range() interfaces

2014-01-03 Thread Bjorn Helgaas
On Mon, Dec 30, 2013 at 08:28:12AM +0100, Alexander Gordeev wrote: > This series is against "next" branch in Bjorn's repo: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > > Changes from v4 to v5: > - pci_auto_enable_msi* functions renamed to pci_enable_msi* ones; > -

Re: [PATCH 0/3] Deferrable timers support for timerfd API

2014-01-03 Thread John Stultz
On 01/03/2014 09:45 AM, Alexey Perevalov wrote: > On 01/03/2014 03:17 AM, John Stultz wrote: >> On 01/02/2014 10:30 AM, Alexey Perevalov wrote: >>> This version introduces new clockid (CLOCK_DEFERRABLE) , for >>> timerfd_create, instead of >>> new flag (TFD_TIMER_DEFERRABLE) for timerfd_settime

Re: [PATCH] mm/mlock: fix BUG_ON unlocked page for nolinear VMAs

2014-01-03 Thread Linus Torvalds
On Fri, Jan 3, 2014 at 3:36 PM, Vlastimil Babka wrote: > > I'm for going with the removal of BUG_ON. The TestSetPageMlocked should > provide enough > race protection. Maybe. But dammit, that's subtle, and I don't think you're even right. It basically depends on mlock_vma_page() and

[PATCH 1/2] efi: Fix krealloc defect

2014-01-03 Thread Joe Perches
krealloc should use a temporary pointer for allocations and check the temporary pointer returned against NULL too. Signed-off-by: Joe Perches cc: Matthew Garrett --- arch/x86/platform/efi/efi.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH 0/2] efi: Fix krealloc defect and misc neatening

2014-01-03 Thread Joe Perches
Joe Perches (2): efi: Fix krealloc defect efi: style neatening arch/x86/platform/efi/efi.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) -- 1.8.1.2.459.gbcd45b4.dirty -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 2/2] efi: style neatening

2014-01-03 Thread Joe Perches
Coalesce formats and remove spaces before tabs. Move __initdata after the variable declaration. Signed-off-by: Joe Perches --- arch/x86/platform/efi/efi.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/arch/x86/platform/efi/efi.c

Re: [PATCH v3 1/2] regulator: anatop-regulator: Fix the error handling on probe

2014-01-03 Thread Dmitry Torokhov
On Tue, Dec 24, 2013 at 01:03:57PM +, Mark Brown wrote: > On Mon, Dec 23, 2013 at 12:44:40PM -0200, Fabio Estevam wrote: > > From: Fabio Estevam > > > > Currently when of_get_parent() or syscon_node_to_regmap() fail > > 'kfree(sreg->name)' is not called, which is incorrect. > > Applied

Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

2014-01-03 Thread Bjorn Helgaas
On Fri, Jan 3, 2014 at 4:56 PM, David Miller wrote: > From: Bjorn Helgaas > Date: Fri, 3 Jan 2014 15:15:57 -0700 > >> However, I do raise my eyebrows a bit at drivers that poke around in >> the PCIe capability. I would prefer to have PCI core interfaces that >> handle that instead. But I

Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

2014-01-03 Thread David Miller
From: Bjorn Helgaas Date: Fri, 3 Jan 2014 15:15:57 -0700 > However, I do raise my eyebrows a bit at drivers that poke around in > the PCIe capability. I would prefer to have PCI core interfaces that > handle that instead. But I haven't seen Jeff's changes yet. The changes just read the link

Re: [PATCH] mm/mlock: fix BUG_ON unlocked page for nolinear VMAs

2014-01-03 Thread Andrew Morton
On Sat, 04 Jan 2014 00:36:18 +0100 Vlastimil Babka wrote: > On 01/03/2014 09:52 PM, Linus Torvalds wrote: > > On Fri, Jan 3, 2014 at 12:17 PM, Sasha Levin wrote: > >> > >> Ping? This BUG() is triggerable in 3.13-rc6 right now. > > > > So Andrew suggested just removing the BUG_ON(), but it's

[tip:x86/cpu] x86, cpu: Detect more TLB configuration

2014-01-03 Thread tip-bot for Kirill A. Shutemov
Commit-ID: dd360393f4d948eb518372316e52101cf3b44212 Gitweb: http://git.kernel.org/tip/dd360393f4d948eb518372316e52101cf3b44212 Author: Kirill A. Shutemov AuthorDate: Mon, 23 Dec 2013 14:16:58 +0200 Committer: H. Peter Anvin CommitDate: Fri, 3 Jan 2014 14:35:42 -0800 x86, cpu: Detect

Re: [PATCH] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 05:01:11PM -0200, Leandro Dorileo wrote: > On Thu, Jan 02, 2014 at 03:37:57PM +0800, Lan Tianyu wrote: > > The aml method _BIX of NEC LZ750/LS returns a broken package which > > skip the first member "Revision" according ACPI 5.0 spec Table 10-234. > > > > This patch is to

Re: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 09:16:06AM +, li.xi...@freescale.com wrote: > Hi Dmitry, > > > Subject: Re: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support > > > > Hi Xiubo, > > > > On Fri, Jan 03, 2014 at 01:24:21PM +0800, Xiubo Li wrote: > > > + > > > +static inline int

Re: [PATCH v4] cpufreq: Fix timer/workqueue corruption by protecting reading governor_enabled

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 03:40:16PM +0530, Viresh Kumar wrote: > On 3 January 2014 14:47, wrote: > > From: Jane Li > > > > When a CPU is hot removed we'll cancel all the delayed work items via > > gov_cancel_work(). Sometimes the delayed work function determines that > > it should adjust the

Re: [PATCH] mm/mlock: fix BUG_ON unlocked page for nolinear VMAs

2014-01-03 Thread Vlastimil Babka
On 01/03/2014 09:52 PM, Linus Torvalds wrote: > On Fri, Jan 3, 2014 at 12:17 PM, Sasha Levin wrote: >> >> Ping? This BUG() is triggerable in 3.13-rc6 right now. > > So Andrew suggested just removing the BUG_ON(), but it's been there > for a *long* time. Yes, Andrew also merged this patch for

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-03 Thread Sarah Sharp
On Fri, Jan 03, 2014 at 01:21:18PM -0800, walt wrote: > I'm so sorry Sarah, that was another mistake. The mistake is so stupid I'm > not > going to publish it here :( > > Once I finally ran the kernel with debugging actually compiled in, dmesg > contains > xhci debugging messages. Wow :) > >

Re: [PATCH] x86/boot: use .code16 instead of .code16gcc

2014-01-03 Thread H. Peter Anvin
On 01/03/2014 03:12 PM, David Woodhouse wrote: > On Fri, 2014-01-03 at 14:34 -0800, H. Peter Anvin wrote: >> >> Nice. I would really like a gcc option "-m16" even if all it did was >> emit .code16gcc first in any assembly file > > Is there a PR for that specific request? >

Re: [PATCH] x86/boot: use .code16 instead of .code16gcc

2014-01-03 Thread David Woodhouse
On Fri, 2014-01-03 at 14:34 -0800, H. Peter Anvin wrote: > > Nice. I would really like a gcc option "-m16" even if all it did was > emit .code16gcc first in any assembly file Is there a PR for that specific request? -- dwmw2 smime.p7s Description: S/MIME cryptographic signature

Re: Sanitize FPU-state when switching tasks (was sanitize CPU-state when switching from virtual-8086 mode to other task)

2014-01-03 Thread halfdog
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 H. Peter Anvin wrote: > On 12/31/2013 11:21 AM, Konrad Rzeszutek Wilk wrote: >> >> So, I am wondering if this is related to " x86/fpu: CR0.TS should >> be set before trap into PV guest's #NM exception handle" which >> does have a similar pattern -

Re: [PATCH RESEND] netfilter: remove unused variable

2014-01-03 Thread Pablo Neira Ayuso
On Wed, Jan 01, 2014 at 06:27:19AM +0100, Michal Nazarewicz wrote: > The nfmsg variable is not used (except in sizeof operator which does > not care about its value) between the first and second time it is > assigned the value. Furthermore, nlmsg_data has no side effects, so > the assignment can

Re: GPL violators (charging for a Linux kernel by itself and then charging again for source)

2014-01-03 Thread Richard Weinberger
On Fri, Jan 3, 2014 at 11:25 PM, Phil Turmel wrote: > On 01/03/2014 05:07 PM, Richard Weinberger wrote: >> On Fri, Jan 3, 2014 at 7:56 PM, Eric Appleman wrote: > >>> Wasn't the whole idea of a fee being permitted an acknowledgment that >>> physical distribution of source was acceptable if

[tip:x86/build] x86, boot: Use .code16 instead of .code16gcc

2014-01-03 Thread tip-bot for David Woodhouse
Commit-ID: c86cd70a46c97b001dd9d8b3e925d2a38b88d3ca Gitweb: http://git.kernel.org/tip/c86cd70a46c97b001dd9d8b3e925d2a38b88d3ca Author: David Woodhouse AuthorDate: Fri, 3 Jan 2014 22:30:42 + Committer: H. Peter Anvin CommitDate: Fri, 3 Jan 2014 14:40:09 -0800 x86, boot: Use .code16

Re: [PATCH v5 25/33] PCI, x86: Make ioapic hotplug support built-in

2014-01-03 Thread Bjorn Helgaas
[fixed Rafael's email address; I imagine you got a few bounces :)] On Thu, Jan 02, 2014 at 04:05:57PM -0800, Yinghai Lu wrote: > ioapic hotplug should be built-in like pci root bus hotplug. > > Also need to make it depends on X86_IO_APIC. > > Signed-off-by: Yinghai Lu Most of this series is

[tip:x86/build] x86, sparse: Do not force removal of __user when calling copy_to/from_user_nocheck()

2014-01-03 Thread tip-bot for Steven Rostedt
Commit-ID: c7c4c8f1b828b550295f1d937578e3090f3b5d66 Gitweb: http://git.kernel.org/tip/c7c4c8f1b828b550295f1d937578e3090f3b5d66 Author: Steven Rostedt AuthorDate: Fri, 3 Jan 2014 16:45:00 -0500 Committer: H. Peter Anvin CommitDate: Fri, 3 Jan 2014 14:43:44 -0800 x86, sparse: Do not

Re: [PATCH] Perf: Correct Assumptions about Sample Timestamps in Passes

2014-01-03 Thread David Ahern
On 1/3/14, 3:07 PM, Frederic Weisbecker wrote: On Wed, Jan 01, 2014 at 11:37:55AM -0700, David Ahern wrote: On 12/26/13, 8:30 AM, Frederic Weisbecker wrote: On Thu, Dec 26, 2013 at 10:24:03AM -0500, David Ahern wrote: On 12/26/13, 10:14 AM, Frederic Weisbecker wrote: I was carrying that

Re: [PATCH v5 30/33] PCI, x86, ACPI: Enable ioapic hotplug support with acpi host bridge.

2014-01-03 Thread Bjorn Helgaas
On Thu, Jan 02, 2014 at 04:06:02PM -0800, Yinghai Lu wrote: > We need to have ioapic setup before normal pci drivers. > otherwise other pci driver can not setup irq. > > So we should not treat them as normal pci devices. > Also we will need to support ioapic hotplug without pci device around. >

Re: GPL violators (charging for a Linux kernel by itself and then charging again for source)

2014-01-03 Thread Phil Turmel
On 01/03/2014 05:07 PM, Richard Weinberger wrote: > On Fri, Jan 3, 2014 at 7:56 PM, Eric Appleman wrote: >> Wasn't the whole idea of a fee being permitted an acknowledgment that >> physical distribution of source was acceptable if electronic was not >> possible (low bandwidth ISP, security

Re: [PATCH] x86/boot: use .code16 instead of .code16gcc

2014-01-03 Thread H. Peter Anvin
On 01/03/2014 02:30 PM, David Woodhouse wrote: > Since I just made .code16 work in LLVM, this removes one more barrier to > building the kernel with LLVM/clang. And it looks like 'clang -m16' for > the C code in arch/x86/boot shouldn't actually be that hard to do now > either. Nice. I would

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-03 Thread Rafael J. Wysocki
On Friday, January 03, 2014 08:04:36 PM Gleb Natapov wrote: > On Fri, Jan 03, 2014 at 09:30:28AM -0800, Dirk Brandewie wrote: > > Hi All, > > > > Sorry for being late to the party but I just got back from vacation. > > > > There is something deeply wrong here. We should have never gotten to > >

[GIT PULL] EFI kexec fixes

2014-01-03 Thread Matt Fleming
Peter, please pull these fixes for the EFI kexec patches sitting in tip/x86/efi-kexec - the kbuild bot reported some build breakage. The following changes since commit 518548abd61808ea1e31614ccbdae34d3c32dfa4: x86/efi: Delete superfluous global variables (2013-12-29 13:09:08 +) are

  1   2   3   4   5   6   7   8   >