RE: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data

2014-01-13 Thread li.xi...@freescale.com
> > Whether the dt is used or not, almost all the simple card information > > for the DAI link and sound card are initialized in the simple card driver. > > > > And for the platform caller, the snd_link and snd_card are of no use, so > > move them from struct asoc_simple_card_info to struct

[PATCH net-next 03/10] eql: use __dev_get_by_name instead of dev_get_by_name to find interface

2014-01-13 Thread Ying Xue
The following call chain indicates that eql_ioctl(), eql_enslave(), eql_emancipate(), eql_g_slave_cfg() and eql_s_slave_cfg() are protected under rtnl_lock. So if we use __dev_get_by_name() instead of dev_get_by_name() to find interface handlers in them, this would help us avoid to change

[PATCH v2 0/3] Add modules for realtek USB card reader

2014-01-13 Thread rogerable
From: Roger Tseng This patchset adds modules to support Realtek USB vendor specific class flash card reader: one base module in MFD subsystem and two host modules in both mmc and memstick subsystems. The architecture is similar to rtsx_pci. This work is done primarily to replace the staging

[PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-13 Thread rogerable
From: Roger Tseng Realtek USB card reader provides a channel to transfer command or data to flash memory cards. This driver exports host instances for mmc and memstick subsystems and handles basic works. Signed-off-by: Roger Tseng --- drivers/mfd/Kconfig | 10 + drivers/mfd/Makefile

[RESEND][PATCH] APIC: Read Error Status Register correctly

2014-01-13 Thread Richard Weinberger
Currently we do a read, a dummy write and a final read to fetch the error code. The value from the final read is taken. This is not the recommended way and leads to corrupted/lost ESR values. Intel(c) 64 and IA-32 Architectures Software Developer's Manual, Combined Volumes 1, 2ABC, 3ABC, Section

[PATCH 3/3] memstick: Add realtek USB memstick host driver

2014-01-13 Thread rogerable
From: Roger Tseng Realtek USB memstick host driver provides memstick host support based on the Realtek USB card reader MFD driver. Signed-off-by: Roger Tseng --- drivers/memstick/host/Kconfig | 10 + drivers/memstick/host/Makefile | 1 + drivers/memstick/host/rtsx_usb_ms.c | 855

[PATCH 2/3] mmc: Add realtek USB sdmmc host driver

2014-01-13 Thread rogerable
From: Roger Tseng Realtek USB SD/MMC host driver provides mmc host support based on the Realtek USB card reader MFD driver. Signed-off-by: Roger Tseng --- drivers/mmc/host/Kconfig |7 + drivers/mmc/host/Makefile |1 + drivers/mmc/host/rtsx_usb_sdmmc.c | 1509

Re: [PATCH 02/14] target: Add DIF CHECK_CONDITION ASC/ASCQ exception cases

2014-01-13 Thread Sagi Grimberg
On 1/10/2014 8:53 AM, Nicholas A. Bellinger wrote: On Thu, 2014-01-09 at 12:43 +0200, Sagi Grimberg wrote: On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch adds support for DIF related CHECK_CONDITION ASC/ASCQ exception cases into

[PATCH net-next 04/10] dcb: use __dev_get_by_name instead of dev_get_by_name to find interface

2014-01-13 Thread Ying Xue
The following call chain indicates that dcb_doit() is protected under rtnl_lock. So if we use __dev_get_by_name() instead of dev_get_by_name() to find interface handlers in it, this would help us avoid to change interface reference counter. rtnetlink_rcv() rtnl_lock() netlink_rcv_skb()

[PATCH net-next 07/10] batman-adv: use __dev_get_by_index instead of dev_get_by_index to find interface

2014-01-13 Thread Ying Xue
The following call chains indicate that batadv_is_on_batman_iface() is always under rtnl_lock protection as call_netdevice_notifier() is protected by rtnl_lock. So if __dev_get_by_index() rather than dev_get_by_index() is used to find interface handler in it, this would help us avoid to change

[PATCH net-next 05/10] decnet: use __dev_get_by_index instead of dev_get_by_index to find interface

2014-01-13 Thread Ying Xue
The following call chain we can identify that dn_cache_getroute() is protected under rtnl_lock. So if we use __dev_get_by_index() instead of dev_get_by_index() to find interface handlers in it, this would help us avoid to change interface reference counter. rtnetlink_rcv() rtnl_lock()

[PATCH net-next 06/10] vxlan: use __dev_get_by_index instead of dev_get_by_index to find interface

2014-01-13 Thread Ying Xue
The following call chains indicate that vxlan_fdb_parse() is under rtnl_lock protection. So if we use __dev_get_by_index() instead of dev_get_by_index() to find interface handler in it, this would help us avoid to change interface reference counter. rtnetlink_rcv() rtnl_lock()

[PATCH net-next 08/10] caif: __dev_get_by_index instead of dev_get_by_index to find interface

2014-01-13 Thread Ying Xue
The following call chains indicate that chnl_net_open() is under rtnl_lock protection as __dev_open() is protected by rtnl_lock. So if __dev_get_by_index() instead of dev_get_by_index() is used to find interface handler in it, this would help us avoid to change interface reference counter.

[PATCH net-next 09/10] can: use __dev_get_by_index instead of dev_get_by_index to find interface

2014-01-13 Thread Ying Xue
As cgw_create_job() is always under rtnl_lock protection, __dev_get_by_index() instead of dev_get_by_index() should be used to find interface handler in it having us avoid to change interface reference counter. Cc: Oliver Hartkopp Signed-off-by: Ying Xue --- net/can/gw.c | 15 +--

[PATCH net-next 10/10] net: nl80211: __dev_get_by_index instead of dev_get_by_index to find interface

2014-01-13 Thread Ying Xue
As __cfg80211_rdev_from_attrs(), nl80211_dump_wiphy_parse() and nl80211_set_wiphy() are all under rtnl_lock protection, __dev_get_by_index() instead of dev_get_by_index() should be used to find interface handler in them allowing us to avoid to change interface reference counter. Cc: Johannes Berg

[PATCH net-next 02/10] bonding: use __dev_get_by_name instead of dev_get_by_name to find interface

2014-01-13 Thread Ying Xue
The following call chain indicates that bond_do_ioctl() is protected under rtnl_lock. If we use __dev_get_by_name() instead of dev_get_by_name() to find interface handler in it, this would help us avoid to change reference counter of interface once. dev_ioctl() rtnl_lock() dev_ifsioc()

[PATCH net-next 00/10] use appropriate APIs to get interfaces

2014-01-13 Thread Ying Xue
Under rtnl_lock protection, we should use __dev_get_name/index() rather than dev_get_name()/index() to find interface handlers because the former interfaces can help us avoid to change interface reference counter. Ying Xue (10): Drivers: Staging: cxt1e1: use __dev_get_name instead of

[PATCH net-next 01/10] Drivers: Staging: cxt1e1: use __dev_get_name instead of dev_get_name to find interfaces

2014-01-13 Thread Ying Xue
The following call chain denotes that both do_reset() and do_del_chan() are protected under rtnl_lock. If we use __dev_get_by_name() instead of dev_get_by_name() to find interface handlers in them, this would help us avoid to change interface reference counter. dev_ioctl() rtnl_lock()

Re: [PATCH] cpuidle/menu: Fail cpuidle_idle_call() if no idle state is acceptable

2014-01-13 Thread Srivatsa S. Bhat
On 01/14/2014 12:30 PM, Srivatsa S. Bhat wrote: > On 01/14/2014 11:35 AM, Preeti U Murthy wrote: >> On PowerPC, in a particular test scenario, all the cpu idle states were >> disabled. >> Inspite of this it was observed that the idle state count of the shallowest >> idle state, snooze, was

[RFC PATCH] audit: Use hex_byte_pack_upper

2014-01-13 Thread Joe Perches
Using the generic kernel function causes the object size to increase with gcc 4.8.1. $ size kernel/audit.o* textdata bss dec hex filename 1857760798436 330928144 kernel/audit.o.new 1857960158420 3301480f6 kernel/audit.o.old Unsigned... ---

Re: Idle power fix regresses ebizzy performance (was 3.12-stable backport of NUMA balancing patches)

2014-01-13 Thread Len Brown
> This is a false alarm. Thanks for the follow-up, Mel. Agreed, it makes no sense for ebizzy measure 'throughput', when a library debug bottleneck prevents it from scaling past 3% CPU utilization. Still, the broken configuration did find a difference due to the addition of CLFLUSH on this box.

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
Hello, Kim 2014/1/14 Minchan Kim : > Hello Bob, > > On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: >> >> On 01/14/2014 07:35 AM, Minchan Kim wrote: >> > Hello, >> > >> > On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: >> >> zswap can support multiple swapfiles. So we need to

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-13 Thread Vladimir Davydov
On 01/14/2014 03:05 AM, Andrew Morton wrote: > On Sat, 11 Jan 2014 16:36:31 +0400 Vladimir Davydov > wrote: > >> When reclaiming kmem, we currently don't scan slabs that have less than >> batch_size objects (see shrink_slab_node()): >> >> while (total_scan >= batch_size) { >>

Re: [PATCH] Staging: comedi: move trailing statement to next line in ni_mio_common.c

2014-01-13 Thread Dan Carpenter
On Mon, Jan 13, 2014 at 07:16:14PM -0800, Joe Perches wrote: > On Mon, 2014-01-13 at 21:13 -0600, Chase Southwood wrote: > > This patch for ni_mio_common.c silences a checkpatch error due to a > > trailing statement. > [] > > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c > >

[PATCHv2] driver core/platform: don't leak memory allocated for dma_mask

2014-01-13 Thread Yann Droneaud
no small allocation. The drawback is the additional code needed to handle dma_mask allocation: Before (on next-20140113 with gcc-4.8): textdata bss dec hex filename 5600 472 32610417d8 obj-arm/drivers/base/platform.o 5927 532 326491195b o

Re: [PATCH 1/7] zram: fix race between reset and flushing pending work

2014-01-13 Thread Sergey Senozhatsky
On (01/13/14 15:55), Andrew Morton wrote: [..] > > > > --- a/drivers/block/zram/zram_drv.c > > +++ b/drivers/block/zram/zram_drv.c > > @@ -553,14 +553,14 @@ static void zram_reset_device(struct zram *zram, bool > > reset_capacity) > > size_t index; > > struct zram_meta *meta; > > > > -

Re: [PATCH] Staging: comedi: remove unnecessary braces in pcl711.c

2014-01-13 Thread Dan Carpenter
On Mon, Jan 13, 2014 at 09:13:16PM -0600, Chase Southwood wrote: > This patch for pcl711.c removes braces causing a checkpatch.pl warning. > It also removes an empty else arm of an if-else statement. > > Signed-off-by: Chase Southwood > --- > > I removed the "else" arm of this statement because

[PATCH] PM: Enable asynchronous noirq resume threads to save the resuming time

2014-01-13 Thread Chuansheng Liu
Currently, the dpm_resume_noirq() is done synchronously, and for PCI devices pci_pm_resume_noirq(): pci_pm_resume_noirq() pci_pm_default_resume_early() pci_power_up() pci_raw_set_power_state() Which set the device from D3hot to D0 mostly, for every device, there will be one

Re: [PATCH 6/7] zram: remove workqueue for freeing removed pending slot

2014-01-13 Thread Sergey Senozhatsky
Hello Minchan, On (01/14/14 08:38), Minchan Kim wrote: > Hello Sergey, > > On Mon, Jan 13, 2014 at 10:42:56PM +0300, Sergey Senozhatsky wrote: > > On (01/13/14 20:19), Minchan Kim wrote: > > > > Hello Minchan, > > I think we need to down_write init_lock in zram_slot_free_notify(), > > and thus

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
2014/1/14 Bob Liu : > > On 01/14/2014 01:05 PM, Minchan Kim wrote: >> On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: >>> Hello Bob, >>> >>> On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: > Hello, > > On Sat,

Re: [PATCH 2/2] BCM2835: Add I2S driver to device tree

2014-01-13 Thread Florian Meier
On 14.01.2014 03:57, Stephen Warren wrote: > On 01/13/2014 04:16 AM, Florian Meier wrote: >> This adds the definitions for the BCM2835 I2S driver >> to the device tree. Some GPIO settings are needed for >> the correct pin functions. > > Patch 1/1 and the .dtsi portion of patch 2/2 look fine; I can

Re: [PATCH] [RFC] timekeeping: Rework frequency adjustments to work better w/ nohz

2014-01-13 Thread Richard Cochran
On Mon, Jan 13, 2014 at 10:15:18AM -0800, John Stultz wrote: > That's great to hear! Thanks so much, I really appreciate the testing! > And this is with HZ=? HZ=1000 > If you do get a chance to look again, I'd also be interested if running > with nohz=off w/ the fix doesn't show any regression

Re: [PATCH] cpuidle/menu: Fail cpuidle_idle_call() if no idle state is acceptable

2014-01-13 Thread Srivatsa S. Bhat
On 01/14/2014 11:35 AM, Preeti U Murthy wrote: > On PowerPC, in a particular test scenario, all the cpu idle states were > disabled. > Inspite of this it was observed that the idle state count of the shallowest > idle state, snooze, was increasing. > > This is because the governor returns the

Re: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data

2014-01-13 Thread Kuninori Morimoto
Hi Xiubo Thank you for your patch > Whether the dt is used or not, almost all the simple card information > for the DAI link and sound card are initialized in the simple card driver. > > And for the platform caller, the snd_link and snd_card are of no use, so > move them from struct

Re: [PATCH V2 0/4] misc: xgene: Add support for APM X-Gene SoC Queue Manager/Traffic Manager

2014-01-13 Thread Arnd Bergmann
On Monday 13 January 2014, Ravi Patel wrote: > > For inbound messages, the QMTM serves a similar purpose as an MSI > > controller, ensuring that inbound DMA data has arrived in RAM > > before an interrupt is delivered to the CPU and thereby avoiding > > the need for an expensive MMIO read to

Re: [PATCH 3/5] mm: vmscan: respect NUMA policy mask when shrinking slab on direct reclaim

2014-01-13 Thread Vladimir Davydov
On 01/14/2014 03:11 AM, Andrew Morton wrote: > On Sat, 11 Jan 2014 16:36:33 +0400 Vladimir Davydov > wrote: > >> When direct reclaim is executed by a process bound to a set of NUMA >> nodes, we should scan only those nodes when possible, but currently we >> will scan kmem from all online nodes

[PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-13 Thread Jason Wang
We used to limit the number of packets queued through tx_queue_length. This has several issues: - tx_queue_length is the control of qdisc queue length, simply reusing it to control the packets queued by device may cause confusion. - After commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523

Re: [PATCH 4/5] mm: vmscan: move call to shrink_slab() to shrink_zones()

2014-01-13 Thread Vladimir Davydov
On 01/14/2014 03:13 AM, Andrew Morton wrote: > On Sat, 11 Jan 2014 16:36:34 +0400 Vladimir Davydov > wrote: > >> This reduces the indentation level of do_try_to_free_pages() and removes >> extra loop over all eligible zones counting the number of on-LRU pages. > So this should cause no

Re: [PATCH v4 4/5] arm: Add [U]EFI runtime services support

2014-01-13 Thread Arnd Bergmann
On Monday 13 January 2014, Leif Lindholm wrote: > On Mon, Jan 13, 2014 at 07:43:09PM +0100, Arnd Bergmann wrote: > > > This patch implements basic support for UEFI runtime services in the > > > ARM architecture - a requirement for using efibootmgr to read and update > > > the system boot

Re: [PATCH 1/2] net/mlx4_core: clean up cq_res_start_move_to()

2014-01-13 Thread Jack Morgenstein
This time, replying to the list as well. -Jack P.S. sorry for the delay, I was swamped. On Tue, 07 Jan 2014 14:01:18 +0100 Paul Bolle wrote: > + } else { > + /* state == RES_CQ_HW */ > + if (r->com.state != RES_CQ_ALLOCATED) if (state != RES_CQ_HW || r->com.state

Re: [PATCH v2 0/3] Deferrable timers support for timerfd API

2014-01-13 Thread Alexey Perevalov
On 01/13/2014 09:36 PM, Andi Kleen wrote: Alexey Perevalov writes: Hello all, one remark - timerfd is not documented in linux Documentation directory at all. I think it's better to have such description. The documentation is the manpage in man-pages. Ideally you change would come with the

[RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data

2014-01-13 Thread Xiubo Li
Whether the dt is used or not, almost all the simple card information for the DAI link and sound card are initialized in the simple card driver. And for the platform caller, the snd_link and snd_card are of no use, so move them from struct asoc_simple_card_info to struct asoc_simple_card_data.

Re: [PATCH 2/2] net/mlx4_core: clean up srq_res_start_move_to()

2014-01-13 Thread Jack Morgenstein
On Tue, 07 Jan 2014 14:02:14 +0100 Paul Bolle wrote: > diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c > b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index > a41f01e..8ace450 100644 --- > a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++ >

Re: [PATCH] cpuidle/menu: Fail cpuidle_idle_call() if no idle state is acceptable

2014-01-13 Thread Deepthi Dharwar
On 01/14/2014 11:35 AM, Preeti U Murthy wrote: > On PowerPC, in a particular test scenario, all the cpu idle states were > disabled. > Inspite of this it was observed that the idle state count of the shallowest > idle state, snooze, was increasing. > > This is because the governor returns the

Re: [PATCH 3/8 v3] crypto:s5p-sss: Add support for SSS module on Exynos

2014-01-13 Thread Naveen Krishna Ch
Hell Vladimir, Tomasz, On 14 January 2014 02:36, Vladimir Zapolskiy wrote: > Hi Naveen and Tomasz, > > > On 01/10/14 17:44, Tomasz Figa wrote: >> >> Hi Naveen, >> >> Please see my comments inline. >> >> On 10.01.2014 12:42, Naveen Krishna Chatradhi wrote: >>> >>> This patch adds new compatible

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Weijie Yang
On Tue, Jan 14, 2014 at 1:42 PM, Bob Liu wrote: > > On 01/14/2014 01:05 PM, Minchan Kim wrote: >> On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: >>> Hello Bob, >>> >>> On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: >

Re: linux-next: manual merge of the tip tree with the net-next tree

2014-01-13 Thread Stephen Rothwell
Hi Dave, On Mon, 13 Jan 2014 21:48:41 -0800 (PST) David Miller wrote: > > Net patch applied, thanks Stephen. Thanks. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpLeAmu5C984.pgp Description: PGP signature

[PATCH] cpuidle/menu: Fail cpuidle_idle_call() if no idle state is acceptable

2014-01-13 Thread Preeti U Murthy
On PowerPC, in a particular test scenario, all the cpu idle states were disabled. Inspite of this it was observed that the idle state count of the shallowest idle state, snooze, was increasing. This is because the governor returns the idle state index as 0 even in scenarios when no idle state

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Arnd Bergmann
On Tuesday 14 January 2014, Feng Kan wrote: > > > > > Is this related to the standard ARM SCU that manages multiprocessor > > systems, or a different unit that uses the same name? > > FKAN: You mean the snoop control unit in ARM. This is different from > that, the main function of this unit is

Re: [PATCH v3 2/4] net_dma: revert 'copied_early'

2014-01-13 Thread Dan Williams
On Mon, Jan 13, 2014 at 9:16 PM, David Miller wrote: > From: Dan Williams > Date: Mon, 13 Jan 2014 16:47:14 -0800 > >> Now that tcp_dma_try_early_copy() is gone nothing ever sets >> copied_early. >> >> Also reverts "53240c208776 tcp: Fix possible double-ack w/ user dma" >> since it is no longer

[tip:core/locking] arch: Re-sort some Kbuild files to hopefully help avoid some conflicts

2014-01-13 Thread tip-bot for Stephen Rothwell
Commit-ID: f549ed1abc7e4f0292ce08c4143c64a610c8b2cb Gitweb: http://git.kernel.org/tip/f549ed1abc7e4f0292ce08c4143c64a610c8b2cb Author: Stephen Rothwell AuthorDate: Tue, 14 Jan 2014 16:36:10 +1100 Committer: H. Peter Anvin CommitDate: Mon, 13 Jan 2014 21:56:54 -0800 arch: Re-sort some

linux-next: Tree for Jan 14

2014-01-13 Thread Stephen Rothwell
Hi all, This tree fails (more than usual) the powerpc allyesconfig build. Changes since 20140113: Dropped tree: sh (complex merge conflicts against very old commits) The powerpc tree still had its build failure. The v4l-dvb tree gained a conflict against Linus' tree. The tip tree gained

Re: linux-next: manual merge of the tip tree with the net-next tree

2014-01-13 Thread David Miller
From: Stephen Rothwell Date: Tue, 14 Jan 2014 16:44:20 +1100 > On Mon, 13 Jan 2014 21:19:46 -0800 (PST) David Miller > wrote: >> >> From: "H. Peter Anvin" >> Date: Mon, 13 Jan 2014 20:51:43 -0800 >> >> > Is there a sensible way we can fix this in either net-next or tip? >> >> I think if I

Re: linux-next: manual merge of the tip tree with the net-next tree

2014-01-13 Thread Stephen Rothwell
On Mon, 13 Jan 2014 21:19:46 -0800 (PST) David Miller wrote: > > From: "H. Peter Anvin" > Date: Mon, 13 Jan 2014 20:51:43 -0800 > > > Is there a sensible way we can fix this in either net-next or tip? > > I think if I sort the files in net-next the problem will go away, > if someone can

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Bob Liu
On 01/14/2014 01:05 PM, Minchan Kim wrote: > On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: >> Hello Bob, >> >> On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: >>> >>> On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800,

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-13 Thread Minchan Kim
On Mon, Jan 13, 2014 at 04:39:47PM +0900, Minchan Kim wrote: > On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, which

[PATCH resend] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-13 Thread Xiubo Li
It's a bug that writing to the platform data directly, for it should be constant. So just copy it before writing. Signed-off-by: Xiubo Li --- Resend this patch. sound/soc/generic/simple-card.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-)

[PATCH 08/24] perf tools: Update cpumode for each cumulative entry

2014-01-13 Thread Namhyung Kim
The cpumode and level in struct addr_localtion was set for a sample and but updated as cumulative callchains were added. This led to have non-matching symbol and cpumode in the output. Update it accordingly based on the fact whether the map is a part of the kernel or not. This is a reverse of

[PATCH 01/24] perf tools: Remove symbol_conf.use_callchain check

2014-01-13 Thread Namhyung Kim
The machine__resolve_callchain() is called only if symbol_conf. use_callchain is set so no need to check it again. Signed-off-by: Namhyung Kim --- tools/perf/util/machine.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index

[PATCH 05/24] perf hists: Add support for accumulated stat of hist entry

2014-01-13 Thread Namhyung Kim
Maintain accumulated stat information in hist_entry->stat_acc if symbol_conf.cumulate_callchain is set. Fields in ->stat_acc have same vaules initially, and will be updated as callchain is processed later. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim ---

[PATCH 12/24] perf hists: Sort hist entries by accumulated period

2014-01-13 Thread Namhyung Kim
When callchain accumulation is requested, we need to sort the entries by accumulated period value. When accumulated periods of two entries are same (i.e. single path callchain) put the caller above since accumulation tends to put callers on higher position for obvious reason. Cc: Arun Sharma

[PATCH 10/24] perf callchain: Add callchain_cursor_snapshot()

2014-01-13 Thread Namhyung Kim
The callchain_cursor_snapshot() is for saving current status of the callchain. It'll be used to accumulate callchain information for each node. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/util/callchain.h | 9 + 1 file changed, 9 insertions(+)

[PATCH 03/24] perf tools: Introduce struct hist_entry_iter

2014-01-13 Thread Namhyung Kim
There're some duplicate code when adding hist entries. They are different in that some have branch info or mem info but generally do same thing. So introduce new struct hist_entry_iter and add callbacks to customize each case in general way. The new perf_evsel__add_entry() function will look

[PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v6)

2014-01-13 Thread Namhyung Kim
Hello, This is a new attempt to implement cumulative hist period report. This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely rewrote it from scratch. This patchset is based on my previous patchset [2] but I think it's almost independent so that it can be applied separately.

[PATCH 06/24] perf hists: Check if accumulated when adding a hist entry

2014-01-13 Thread Namhyung Kim
To support callchain accumulation, @entry should be recognized if it's accumulated or not when add_hist_entry() called. The period of an accumulated entry should be added to ->stat_acc but not ->stat. Add @sample_self arg for that. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by:

[PATCH 11/24] perf tools: Save callchain info for each cumulative entry

2014-01-13 Thread Namhyung Kim
When accumulating callchain entry, also save current snapshot of the chain so that it can show the rest of the chain. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/util/hist.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff

[PATCH 14/24] perf ui/browser: Add support to accumulated hist stat

2014-01-13 Thread Namhyung Kim
Print accumulated stat of a hist entry if requested. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/ui/browsers/hists.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c

[PATCH 13/24] perf ui/hist: Add support to accumulated hist stat

2014-01-13 Thread Namhyung Kim
Print accumulated stat of a hist entry if requested. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/ui/hist.c | 45 + tools/perf/util/hist.h | 1 + 2 files changed, 46 insertions(+) diff --git

[PATCH 23/24] perf top: Add top.children config option

2014-01-13 Thread Namhyung Kim
Add top.children config option for setting default value of callchain accumulation. It affects the output only if one of -g or --call-graph option is given as well. A user can write .perfconfig file like below to enable accumulation by default: $ cat ~/.perfconfig [top] children = true

[PATCH 22/24] perf top: Add --children option

2014-01-13 Thread Namhyung Kim
The --children option is for showing accumulated overhead (period) value as well as self overhead. It should be used with one of -g or --call-graph option. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-top.txt | 6 ++

[PATCH 19/24] perf report: Add report.children config option

2014-01-13 Thread Namhyung Kim
Add report.children config option for setting default value of callchain accumulation. It affects the report output only if perf.data contains callchain info. A user can write .perfconfig file like below to enable accumulation by default: $ cat ~/.perfconfig [report] children = true And

[PATCH 18/24] perf report: Add --children option

2014-01-13 Thread Namhyung Kim
The --children option is for showing accumulated overhead (period) value as well as self overhead. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-report.txt | 5 + tools/perf/builtin-report.c | 10 ++ 2 files

[PATCH 21/24] perf top: Convert to hist_entry_iter

2014-01-13 Thread Namhyung Kim
Reuse hist_entry_iter__add() function to share the similar code with perf report. Note that it needs to be called with hists.lock so tweak some internal functions not to deadlock or hold the lock too long. Signed-off-by: Namhyung Kim --- tools/perf/builtin-top.c | 78

[PATCH 16/24] perf tools: Apply percent-limit to cumulative percentage

2014-01-13 Thread Namhyung Kim
If -g cumulative option is given, it needs to show entries which don't have self overhead. So apply percent-limit to accumulated overhead percentage in this case. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/ui/browsers/hists.c | 33

[PATCH 24/24] perf tools: Enable --children option by default

2014-01-13 Thread Namhyung Kim
Now perf top and perf report will show children column by default if it has callchain information. Requested-by: Ingo Molnar Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/util/symbol.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

[PATCH 17/24] perf tools: Add more hpp helper functions

2014-01-13 Thread Namhyung Kim
Sometimes it needs to disable some columns at runtime. Add help functions to support that. Cc: Jiri Olsa Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/ui/hist.c | 17 + tools/perf/util/hist.h | 3 +++ 2 files changed, 20 insertions(+)

[PATCH 04/24] perf hists: Convert hist entry functions to use struct he_stat

2014-01-13 Thread Namhyung Kim
hist_entry__add_cpumode_period() and hist_entry__decay() are dealing with hist_entry's stat fields only. So make them use the struct directly. Acked-by: Jiri Olsa Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/util/hist.c | 22 +++--- 1

[PATCH 09/24] perf report: Cache cumulative callchains

2014-01-13 Thread Namhyung Kim
It is possble that a callchain has cycles or recursive calls. In that case it'll end up having entries more than 100% overhead in the output. In order to prevent such entries, cache each callchain node and skip if same entry already cumulated. Cc: Arun Sharma Cc: Frederic Weisbecker

[PATCH 07/24] perf hists: Accumulate hist entry stat based on the callchain

2014-01-13 Thread Namhyung Kim
Call __hists__add_entry() for each callchain node to get an accumulated stat for an entry. Introduce new cumulative_iter ops to process them properly. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/builtin-report.c | 2 ++ tools/perf/util/hist.c | 87

[PATCH 20/24] perf tools: Add callback function to hist_entry_iter

2014-01-13 Thread Namhyung Kim
The new ->add_entry_cb() will be called after an entry was added to the histogram. It's used for code sharing between perf report and perf top. Note that ops->add_*_entry() should set iter->he properly in order to call the ->add_entry_cb. Also pass @arg to the callback function. It'll be used

[PATCH 15/24] perf ui/gtk: Add support to accumulated hist stat

2014-01-13 Thread Namhyung Kim
Print accumulated stat of a hist entry if requested. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/ui/gtk/hists.c | 16 1 file changed, 16 insertions(+) diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c index

[PATCH 02/24] perf tools: Factor out sample__resolve_callchain()

2014-01-13 Thread Namhyung Kim
The report__resolve_callchain() can be shared with perf top code as it doesn't really depend on the perf report code. Factor it out as sample__resolve_callchain(). The same goes to the hist_entry__append_ callchain() too. Acked-by: Jiri Olsa Cc: Arun Sharma Cc: Frederic Weisbecker

Re: linux-next: manual merge of the tip tree with the net-next tree

2014-01-13 Thread David Miller
From: "H. Peter Anvin" Date: Mon, 13 Jan 2014 20:51:43 -0800 > Is there a sensible way we can fix this in either net-next or tip? I think if I sort the files in net-next the problem will go away, if someone can confirm this I'll do it. -- To unsubscribe from this list: send the line

Re: linux-next: manual merge of the tip tree with the net-next tree

2014-01-13 Thread Stephen Rothwell
Hi, On Mon, 13 Jan 2014 20:51:43 -0800 "H. Peter Anvin" wrote: > > On 01/13/2014 07:02 PM, Stephen Rothwell wrote: > > > > On Mon, 13 Jan 2014 14:20:59 +1100 Stephen Rothwell > > wrote: > >> > >> On Mon, 13 Jan 2014 14:18:24 +1100 Stephen Rothwell > >> wrote: > >>> > >>> Today's

Re: [PATCH v3 2/4] net_dma: revert 'copied_early'

2014-01-13 Thread David Miller
From: Dan Williams Date: Mon, 13 Jan 2014 16:47:14 -0800 > Now that tcp_dma_try_early_copy() is gone nothing ever sets > copied_early. > > Also reverts "53240c208776 tcp: Fix possible double-ack w/ user dma" > since it is no longer necessary. > > Cc: Ali Saidi > Cc: James Morris > Cc:

[PATCH] staging: ced1401: Fix dev_ messages

2014-01-13 Thread Joe Perches
Add a missing newline to each message. Standardize style to "%s: ...", __func__. Signed-off-by: Joe Perches --- There are a _lot_ of function tracing style uses of dev_dbg that could/should be deleted. This patch doesn't attempt to delete them. drivers/staging/ced1401/ced_ioc.c | 151

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Minchan Kim
On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: > Hello Bob, > > On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: > > > > On 01/14/2014 07:35 AM, Minchan Kim wrote: > > > Hello, > > > > > > On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: > > >> zswap can support

Re: linux-next: manual merge of the akpm-current tree with the tip tree

2014-01-13 Thread Davidlohr Bueso
On Tue, 2014-01-14 at 15:53 +1100, Stephen Rothwell wrote: > Hi Andrew, > > Today's linux-next merge of the akpm-current tree got a conflict in > kernel/futex.c between commit a52b89ebb6d4 ("futexes: Increase hash table > size for better performance") from the tip tree and commit 61beee6c76e5 >

Re: [patch/rfc] perf on raspberry-pi without overflow interrupt

2014-01-13 Thread Vince Weaver
On Fri, 10 Jan 2014, Peter Zijlstra wrote: > On Thu, Jan 09, 2014 at 11:08:47PM -0500, Vince Weaver wrote: > > On Thu, 9 Jan 2014, Will Deacon wrote: > > > > > I'd rather see it in the generic code if at all possible. Maybe we could > > > add > > > a flags field to perf_pmu_register? > > > > I

linux-next: manual merge of the akpm-current tree with the tip tree

2014-01-13 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm-current tree got a conflict in kernel/futex.c between commit a52b89ebb6d4 ("futexes: Increase hash table size for better performance") from the tip tree and commit 61beee6c76e5 ("futex: switch to USER_DS for futex test") from the akpm-current tree.

Re: linux-next: manual merge of the tip tree with the net-next tree

2014-01-13 Thread H. Peter Anvin
On 01/13/2014 07:02 PM, Stephen Rothwell wrote: > Hi all, > > On Mon, 13 Jan 2014 14:20:59 +1100 Stephen Rothwell > wrote: >> >> On Mon, 13 Jan 2014 14:18:24 +1100 Stephen Rothwell >> wrote: >>> >>> Today's linux-next merge of the tip tree got conflicts in >>> arch/arc/include/asm/Kbuild,

linux-next: manual merge of the akpm-current tree with the char-misc tree

2014-01-13 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm-current tree got a conflict in drivers/misc/mei/init.c between commit 33ec08263147 ("mei: revamp mei reset state machine") from the char-misc tree and commit dd045dab2999 ("drivers/misc/mei: ratelimit several error messages") from the akpm-current

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Minchan Kim
Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: > > On 01/14/2014 07:35 AM, Minchan Kim wrote: > > Hello, > > > > On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: > >> zswap can support multiple swapfiles. So we need to check > >> all zbud pool pages in zswap. > > >

Re: next bio iters break discard?

2014-01-13 Thread Kent Overstreet
On Mon, Jan 13, 2014 at 11:06:33PM -0500, Martin K. Petersen wrote: > > "Kent" == Kent Overstreet writes: > > Kent, > > Kent> I think for discards we can deal with this easily enough - > Kent> __blk_recalc_rq_segments() will have to special case them - but > Kent> there's a similar (but

[PATCH 3/5] perf report: Add --percentage option

2014-01-13 Thread Namhyung Kim
The --percentage option is for controlling overhead percentage displayed. It can only receive either of "relative" or "absolute". "relative" means it's relative to filtered entries only so that the sum of shown entries will be always 100%. "absolute" means it retains original value before and

[PATCH 5/5] perf tools: Show absolute percentage by default

2014-01-13 Thread Namhyung Kim
Now perf report will show absolute percentage on filter entries by default. Suggested-by: Jiri Olsa Signed-off-by: Namhyung Kim --- tools/perf/util/symbol.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index ac3d9748993c..39ce9adbaaf0

[PATCHSET 0/5] perf tools: Update on filtered entries' percentage output

2014-01-13 Thread Namhyung Kim
Hello, I added --percentage option to perf report to control display of percentage of filtered entries. usage: perf report [] --percentage how to display percentage of filtered entries "relative" means it's relative to filtered entries only so that the sum

[PATCH 2/5] perf ui/tui: Add support for showing relative percentage

2014-01-13 Thread Namhyung Kim
When filtering by thread, dso or symbol on TUI it also update total period so that the output shows different result than no filter - the percentage changed to relative to filtered entries only. Sometimes (always?) this is not desired since users might expect same results with filter. So change

[PATCH 4/5] perf report: Add report.percentage config option

2014-01-13 Thread Namhyung Kim
Add report.percentage option for setting default value of the symbol_conf.filter_relative. It affects the report output only if a filter applied. An user can write .perfconfig file like below to show absolute percentage of filtered entries by default: $ cat ~/.perfconfig [report]

[PATCH 1/5] perf tools: Count filtered entries to total period also

2014-01-13 Thread Namhyung Kim
Currently if a sample was filtered by command line option, it just dropped. But this affects final output in that the percentage can be different since the filtered entries were not included to the total. But user might want to see the original percentages when filter applied so change the

  1   2   3   4   5   6   7   8   9   10   >