Hello Alexey
On 5/17/2014 1:15 AM, Alexey Khoroshilov wrote:
There are calls to might sleep functions in atomic context in
stmmac_resume():
- the first one is clk_prepare_enable(priv->stmmac_clk);
- the second one is stmmac_hw_setup()
-> init_dma_desc_rings()
-> stmmac_init_rx_buffers()
On nie, 2014-05-18 at 23:51 +0800, Axel Lin wrote:
> The devm_clk_unregister() in probe error paths are not necessary as it will be
> automatically called when probe fails.
>
> Signed-off-by: Axel Lin
> ---
> drivers/clk/clk-s2mps11.c | 14 --
> 1 file changed, 4 insertions(+), 10 de
CMA-allocated memory must be freed by an exact mirror call to
dma_release_from_contiguous(). It cannot be freed page-by-page as was
previously believed without severe memory leakage.
This page records the address and size of every allocated memory chunk
so they can be properly freed when needed.
CMA functions are not available to kernel modules, but the GK20A FB
driver currently (and temporarily) relies on them.
This patch replaces the calls to CMA functions in problematic cases (CMA
enabled and Nouveau compiled as a module) with dummy stubs that will
make this particular driver fail, but
Fix a very shameful memory leak and a compilation error due to the use of
non-exported CMA functions. The workaround for the latter is not really elegant
(replace the CMA functions by a runtime failure if we are compiled as a
module), but is temporary and still an improvement over the current situa
The DR7 masking which is done on task switch emulation should be in hex format
(clearing the local breakpoints enable bits 0,2,4 and 6).
Signed-off-by: Nadav Amit
---
arch/x86/kvm/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
in
Hi Lothar,
Thanks for your review.
On 05/19/2014 01:53 PM, Lothar Waßmann wrote:
> Hi,
>
> Liu Ying wrote:
> [...]
>> @@ -30,6 +32,7 @@
>> /* i.MX27, i.MX31, i.MX35 share the same PWM function block: */
>>
>> #define MX3_PWMCR 0x00/* PWM Control Register */
>> +#define MX
On Mon, May 19, 2014 at 08:31:45AM +0200, Uwe Kleine-König wrote:
> On Sun, May 18, 2014 at 10:50:59PM +0200, Emil Goode wrote:
> > If we fail to allocate struct platform_device pdev we
> > dereference it after the goto label err.
> >
> > This bug was found using coccinelle.
> >
> > Signed-off-by
Hi NIck,
On Thu, Apr 03, 2014 at 11:41:57AM +0100, Nick Dyer wrote:
> Hi Dmitry-
>
> Nick Dyer wrote:
> > Here is a set of patches for atmel_mxt_ts that you've already
> > signed-off. I've rebased them against the most recent mainline and made
> > some very minor changes such as INIT_COMPLETION-
The callback was used by TUI for determining color of folded sign
using percent of first field/column. But it cannot be used anymore
since it now support dynamic reording of output field.
So move the logic to the hist_browser__show_entry().
Acked-by: Ingo Molnar
Signed-off-by: Namhyung Kim
---
On Sun, May 18, 2014 at 10:50:59PM +0200, Emil Goode wrote:
> If we fail to allocate struct platform_device pdev we
> dereference it after the goto label err.
>
> This bug was found using coccinelle.
>
> Signed-off-by: Emil Goode
Acked-by: Uwe Kleine-König
Shawn, is it already to late for 3.15
Move logic of hist_entry__sort_on_period to __hpp__sort() in order to
support event group report.
Acked-by: Ingo Molnar
Signed-off-by: Namhyung Kim
---
tools/perf/ui/hist.c | 64 +++-
1 file changed, 58 insertions(+), 6 deletions(-)
diff --git a/
Until now the hpp and sort functions do similar jobs different ways.
Since the sort functions converted/wrapped to hpp formats it can do
the job in a uniform way.
The perf_hpp__sort_list has a list of hpp formats to sort entries and
the perf_hpp__list has a list of hpp formats to print output resu
Those function pointers will be used to sort report output based on
the selected fields. This is a preparation of later change.
Acked-by: Ingo Molnar
Signed-off-by: Namhyung Kim
---
tools/perf/ui/hist.c | 39 +++
tools/perf/util/hist.h | 3 +++
2 files ch
The reset_output_field() function is for clearing output field
settings and will be used for test code in later patch.
Signed-off-by: Namhyung Kim
---
tools/perf/ui/hist.c | 17 +
tools/perf/util/hist.h | 7 +++
tools/perf/util/sort.c | 11 +++
tools/perf/util/sort
Now we moved to the perf_hpp_[_sort]_list so no need to keep the old
hist_entry__sort_list and sort__first_dimension. Also the
hist_entry__sort_snprintf() can be gone as hist_entry__snprintf()
provides the functionality.
Signed-off-by: Namhyung Kim
---
tools/perf/ui/hist.c | 36 +-
Some fields missed to set default column length so it broke align in
--stdio output. Add perf_hpp__reset_width() to set it to a sane
default value.
Note that this change will ignore -w/--column-widths option for now.
Before:
$ perf report -F cpu,comm,overhead --stdio
...
# CPU Com
When it converted sort entries to hpp formats, it missed se->elide
handling, so add it for compatibility.
Signed-off-by: Namhyung Kim
---
tools/perf/ui/browsers/hists.c | 3 +++
tools/perf/ui/gtk/hists.c | 6 ++
tools/perf/ui/stdio/hist.c | 9 +
tools/perf/util/hist.c
Add overhead{,_sys,_us,_guest_sys,_guest_us}, sample and period sort
keys so that they can be selected with --sort/-s option.
$ perf report -s period,comm --stdio
...
# OverheadPeriod Command
# ...
#
47.06% 152
Hello,
This is a patchset implementing -F/--fields option to setup output
field/column as Ingo requested.
The -F option can receive any sort keys that -s option recognize, plus
following fields (name can be changed):
overhead, overhead_sys, overhead_us, sample, period
The overhead_guest_sys a
Those print helper functions can be reused by later hist test cases so
factor them out to a common location.
Signed-off-by: Namhyung Kim
---
tools/perf/tests/hists_common.c | 57 +
tools/perf/tests/hists_common.h | 3 +++
tools/perf/tests/hists_filter.c |
All drivers expecting CPU's OPPs from device tree initialize OPP table using
of_init_opp_table() and there is nothing driver specific in that. They all do it
in the same way adding to code redundancy.
It would be better if we can get rid of code redundancy by initializing CPU OPPs
from core code f
This is a preparation of consolidating management of output field and
sort keys.
Acked-by: Ingo Molnar
Signed-off-by: Namhyung Kim
---
tools/perf/ui/hist.c | 6
tools/perf/util/hist.h | 6
tools/perf/util/sort.c | 80 +++---
3 files chan
Convert output sorting function to use ->sort hpp functions.
Acked-by: Ingo Molnar
Signed-off-by: Namhyung Kim
---
tools/perf/util/hist.c | 62 +++---
1 file changed, 8 insertions(+), 54 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/u
The -F/--fields option is to allow user setup output field in any
order. It can recieve any sort keys and following (hpp) fields:
overhead, overhead_sys, overhead_us, sample and period
If guest profiling is enabled, overhead_guest_{sys,us} will be
available too.
The output fields also affect
It wrapped sort entries to hpp functions, so using the hpp sort list
to sort entries.
Acked-by: Ingo Molnar
Signed-off-by: Namhyung Kim
---
tools/perf/util/hist.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.
With new output fields option, its internal implementation was changed
so add a new testcase to verify whether it breaks things.
Signed-off-by: Namhyung Kim
---
tools/perf/Makefile.perf| 1 +
tools/perf/tests/builtin-test.c | 4 +
tools/perf/tests/hists_common.c | 4 +-
tools/perf/
Hello Emil,
thanks for your effort.
On Sun, May 18, 2014 at 10:51:00PM +0200, Emil Goode wrote:
> This converts the imx camera allocation and initialization functions
> to use platform_device_register_full() thus simplifying the code.
>
> Signed-off-by: Emil Goode
> ---
> Only build tested, unf
The hists__filter_entries() function is called when down arrow key is
pressed for navigating through the entries in TUI. It has a check for
filtering out entries that have very small overhead (under min_pcnt).
However it just assumed the entries are sorted by the overhead so when
it saw such a sm
So that it can be set properly prior to set up output fields. That
makes easy to handle/warn errors during the setup since it doesn't
need to be bothered with the GUI.
Signed-off-by: Namhyung Kim
---
tools/perf/builtin-report.c| 6 +++---
tools/perf/builtin-top.c | 2 ++
tools/perf/ui
The --fields option is to allow user setup output field in any order.
It can recieve any sort keys and following (hpp) fields:
overhead, overhead_sys, overhead_us, sample and period
If guest profiling is enabled, overhead_guest_{sys,us} will be
available too.
More more information, please see
The perf uses different default sort orders for different use-cases,
and this was scattered throughout the code. Add get_default_sort_
order() function to handle this and change initial value of sort_order
to NULL to distinguish it from user-given one.
Cc: Stephane Eranian
Signed-off-by: Namhyun
Currently, what the sort_entry does is just identifying hist entries
so that they can be grouped properly. However, with -F option
support, it indeed needs to sort entries appropriately to be shown to
users. So add ->sort() member to do it.
Acked-by: Ingo Molnar
Signed-off-by: Namhyung Kim
---
OPP tables are already initialized for CPU0 by cpufreq core and so we don't need
to reinitialize them from exynos5440's driver.
Cc: Amit Daniel Kachhap
Cc: Kukjin Kim
Signed-off-by: Viresh Kumar
---
drivers/cpufreq/exynos5440-cpufreq.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/d
All drivers expecting CPU's OPPs from device tree initialize OPP table using
of_init_opp_table() and there is nothing driver specific in that. They all do it
in the same way adding to code redundancy.
It would be better if we can get rid of code redundancy by initializing CPU OPPs
from core code f
OPP tables are already initialized for CPU0 by cpufreq core and so we don't need
to reinitialize them from cpufreq-cpu0 driver.
Cc: Shawn Guo
Signed-off-by: Viresh Kumar
---
drivers/cpufreq/cpufreq-cpu0.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/
OPP tables are already initialized for all CPUs by cpufreq core and so we don't
need to reinitialize them from arm_big_little_dt driver.
Also, as the arm_big_little_dt driver doesn't have a .init_opp_table() callback
anymore, make it optional in arm_big_little driver.
Cc: Sudeep Holla
Signed-off
OPP tables are already initialized for CPU0 by cpufreq core and so we don't need
to reinitialize them from imx6q specific code.
Cc: Shawn Guo
Signed-off-by: Viresh Kumar
---
arch/arm/mach-imx/mach-imx6q.c | 36
drivers/cpufreq/imx6q-cpufreq.c | 20 +
All drivers expecting CPU's OPPs from device tree initialize OPP table using
of_init_opp_table() and there is nothing driver specific in that. They all do it
in the same way adding to code redundancy.
It would be better if we can get rid of code redundancy by initializing CPU OPPs
from core code f
On 5/15/14, Zhang Rui wrote:
> On 一, 2014-05-05 at 13:15 +0200, Bartlomiej Zolnierkiewicz wrote:
>> Hi,
>>
>> This patch series contains various cleanups for EXYNOS thermal
>> driver. Overall it decreases driver's LOC by 13%. It is based
>> on next-20140428 kernel. It should not cause any funct
On 5/5/14, Bartlomiej Zolnierkiewicz wrote:
> There is no need for abstracting configuration for registers that
> are identical on all SoC types.
Changes look fine and also that shift and masks may not change in
future socs also.
Reviewed-by: Amit Daniel Kachhap
>
> There should be no functional c
On Fri, May 16, 2014 at 11:09:29AM +0200, Paul Bolle wrote:
> None of the defines "for modules using static and dynamic DMA channels"
> are used. Remove these.
>
> Signed-off-by: Paul Bolle
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
Hi Bartlomiej,
On 5/5/14, Bartlomiej Zolnierkiewicz wrote:
> pdata->reference_voltage and pdata->gain are always defined
> to non-zero values so remove the redundant checks from
> exynos_tmu_control().
I prefer to have these checks for the same reason that new soc support
should not add these same
On 05/19/2014 05:10 AM, Tushar Behera wrote:
On 16 May 2014 00:51, Lars-Peter Clausen wrote:
On 05/15/2014 02:01 PM, Tushar Behera wrote:
On 14 May 2014 17:54, Lars-Peter Clausen wrote:
On 05/14/2014 02:07 PM, Tushar Behera wrote:
On 14 May 2014 17:29, Jassi Brar wrote:
On Wed, May
On Mon, May 19, 2014 at 06:31:15AM +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> Delete unnecessary local variable whose value is always 0 and that hides
> the fact that the result is always 0.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows: (http://
On Fri, 16 May 2014 15:33:14 +0900, Namhyung Kim wrote:
> On Thu, 15 May 2014 15:17:17 +0200, Jiri Olsa wrote:
>> On Mon, May 12, 2014 at 03:28:44PM +0900, Namhyung Kim wrote:
>>
>> SNIP
>>
>>> +
>>> +int setup_output_field(void)
>>> +{
>>> + char *tmp, *tok, *str;
>>> + int ret = 0;
>>> +
>>>
Hi Jiri,
On Fri, 16 May 2014 15:30:29 +0900, Namhyung Kim wrote:
> On Thu, 15 May 2014 14:51:32 +0200, Jiri Olsa wrote:
>> On Mon, May 12, 2014 at 03:28:41PM +0900, Namhyung Kim wrote:
>>
>> SNIP
>>
>>> +static struct hpp_dimension hpp_sort_dimensions[] = {
>>> + DIM(PERF_HPP__OVERHEAD, "overhea
On Tue, May 06, 2014 at 02:06:08PM +0300, Roger Quadros wrote:
> Get rid of the attb_read_val() platform hook. Instead,
> read the ATTB gpio directly from the driver.
>
> Fail if valid ATTB gpio is not provided by patform data.
>
> Signed-off-by: Roger Quadros
> Acked-by: Mugunthan V N
Applied
On Tue, May 06, 2014 at 02:06:11PM +0300, Roger Quadros wrote:
> Improve the suspend and resume handlers to allow the device
> to wakeup the system from suspend.
>
> Signed-off-by: Roger Quadros
> Acked-by: Mugunthan V N
Applied, thank you.
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c |
On 5/5/14, Bartlomiej Zolnierkiewicz wrote:
> Cache number of non-hardware trigger levels in a new pdata field
> (non_hw_trigger_levels) and convert code in exynos_tmu_initialize()
> accordingly.
Changes looks fine,
Reviewed-by: Amit Daniel Kachhap
>
> There should be no functional changes caused
On Tue, May 06, 2014 at 02:06:09PM +0300, Roger Quadros wrote:
> Switch to using the Type-B Multi-Touch protocol.
>
Henrik, any chance you could take a look at MT-B support?
> Signed-off-by: Roger Quadros
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 125
> ++
On Tue, May 06, 2014 at 02:06:06PM +0300, Roger Quadros wrote:
> Use devm_() and friends for allocating memory, input device
> and IRQ.
>
> Signed-off-by: Roger Quadros
> Acked-by: Mugunthan V N
Applied, thank you.
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 38
>
On Tue, May 06, 2014 at 02:06:07PM +0300, Roger Quadros wrote:
> Introduce helper functions to configure power and interrupt registers.
> Default to IDLE mode on probe as device supports auto wakeup to ACVIE mode
> on detecting finger touch.
>
> Configure interrupt mode and polarity on start up.
On 5/5/14, Bartlomiej Zolnierkiewicz wrote:
> * Remove dead temp check from temp_to_code() (this function users
> in exynos_tmu_initialize() always pass correct temperatures and
> exynos_tmu_set_emulation() returns early for EXYNOS4210 because
> TMU_SUPPORT_EMULATION flag is not set on this
On Tue, May 06, 2014 at 02:06:12PM +0300, Roger Quadros wrote:
> Provide device tree support and binding information.
> Also provide support for a new chip "pixcir_tangoc".
>
> Signed-off-by: Roger Quadros
> ---
> .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26
> .../devicetree
Hi,
Liu Ying wrote:
[...]
> @@ -30,6 +32,7 @@
> /* i.MX27, i.MX31, i.MX35 share the same PWM function block: */
>
> #define MX3_PWMCR 0x00/* PWM Control Register */
> +#define MX3_PWMIR 0x08/* PWM Interrupt Register */
> #define MX3_PWMSAR
On Mon, May 19, 2014 at 10:47:12AM +0900, Gioh Kim wrote:
> Thank you for your advice. I didn't notice it.
>
> I'm adding followings according to your advice:
>
> - range restrict for CMA_SIZE_MBYTES and *CMA_SIZE_PERCENTAGE*
> I think this can prevent the wrong kernel option.
>
> - change size_
On 5/5/14, Bartlomiej Zolnierkiewicz wrote:
> Remove runtime checks for negative return values of temp_to_code()
> from exynos_tmu_initialize(). The current level temperature data
> hardcoded in pdata will never cause a negative temp_to_code()
> return values and for the new code potential mistak
On 5/15/14, Bartlomiej Zolnierkiewicz wrote:
> On Thursday, May 15, 2014 10:47:40 AM Eduardo Valentin wrote:
>> Hello Bartlomiej,
>
> Hi,
>
>> On Mon, May 05, 2014 at 01:15:34PM +0200, Bartlomiej Zolnierkiewicz
>> wrote:
>> > Remove runtime checks for pdata sanity from exynos_tmu_initialize().
>>
Hi Linus,
The following changes since commit d6d211db37e75de2ddc3a4f979038c40df7cc79c:
Linux 3.15-rc5 (2014-05-09 13:10:52 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus
for you to fetch changes up to fa81511bb0
On 5/5/14, Bartlomiej Zolnierkiewicz wrote:
> Only TYPE_ONE_POINT_TRIMMING calibration is used so remove
> the dead code for TYPE_TWO_POINT_TRIMMING calibration.
I prefer to retain this feature as it is provided by the TMU
controller. This will avoid unnecessary churning of code when some new
soc
Hi,
Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> sound/soc/samsung/dma.c | 10 ++
> 1 fil ändrad, 6 tillägg(
Hi Daniel/Kgene,
On 16 May 2014 13:33, Chander Kashyap wrote:
> Exynos5420 is a big-little Soc from Samsung. It has 4 A15 and 4 A7 cores.
>
> This patchset adds cpuidle support for Exynos5420 SoC based on
> generic big.little cpuidle driver.
>
> Tested on SMDK5420.
>
> This patch set depends on:
On Tue, May 06, 2014 at 01:04:12AM +0200, Sebastian Reichel wrote:
> On Mon, May 05, 2014 at 12:51:39PM -0700, Dmitry Torokhov wrote:
> > On Mon, May 05, 2014 at 12:41:26PM -0700, Tony Lindgren wrote:
> > > * Sebastian Reichel [140425 16:56]:
> > > > Add common DT binding documentation for touchsc
On Mon, May 19, 2014 at 04:44:41AM +0200, Mike Galbraith wrote:
> On Sun, 2014-05-18 at 08:58 -0700, Paul E. McKenney wrote:
> > On Sun, May 18, 2014 at 10:36:41AM +0200, Mike Galbraith wrote:
> > > On Sat, 2014-05-17 at 22:20 -0700, Paul E. McKenney wrote:
> > >
> > > > If you are saying that tu
On Sat, Apr 26, 2014 at 01:56:16AM +0200, Sebastian Reichel wrote:
> Change some dev_dbg() invocations to dev_err() ones, because they
> are supposed to output error messages.
>
> Signed-off-by: Sebastian Reichel
Applied, thank you.
> ---
> drivers/input/touchscreen/tsc2005.c | 4 ++--
> 1 fil
On Sat, Apr 26, 2014 at 01:56:17AM +0200, Sebastian Reichel wrote:
> Simplify the driver by using managed resources for memory allocation of
> internal struct, input device allocation and irq request.
>
> Signed-off-by: Sebastian Reichel
Applied, thank you.
> ---
> drivers/input/touchscreen/ts
Hi Bartlomiej,
On 5/5/14, Bartlomiej Zolnierkiewicz wrote:
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/thermal/samsung/exynos_tmu.c | 33
> +--
> drivers/thermal/samsung/exynos_tmu.h
cpufreq-cpu0 uses thermal framework to register a cooling device, but doesn't
depend on it as there are dummy calls provided by thermal layer when
CONFIG_THERMAL=n. So, we don't really need to mention thermal as a dependency
for cpufreq-cpu0 in Kconfig.
Remove it.
Signed-off-by: Viresh Kumar
---
Hi Bartlomiej,
On 5/5/14, Bartlomiej Zolnierkiewicz wrote:
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/thermal/samsung/exynos_tmu_data.h | 27 +--
> 1 file changed, 1 insertion(+), 26 deletion
Hi Bartlomiej,
On 5/5/14, Bartlomiej Zolnierkiewicz wrote:
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/thermal/samsung/exynos_tmu.h | 40
> ---
> drivers/thermal/samsung/exynos_tmu_da
From: Julia Lawall
Delete unnecessary use of a local variable to immediately return 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
position p;
@@
-ret = 0;
... when != ret =
On Mon, May 19, 2014 at 11:53:05AM +0900, Minchan Kim wrote:
> On Mon, May 19, 2014 at 11:11:21AM +0900, Joonsoo Kim wrote:
> > On Thu, May 15, 2014 at 11:43:53AM +0900, Minchan Kim wrote:
> > > On Thu, May 15, 2014 at 10:53:01AM +0900, Joonsoo Kim wrote:
> > > > On Tue, May 13, 2014 at 12:00:57PM
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
Additionally dropped some unneeded braces in an affected if.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
Sometimes a local variable is used as a return value in a case where the
return value is always 0. The result is more apparent if this variable is
just replaced by 0. This is done by the following semantic patch, although
some cleanups may be needed. (http://coccinelle.lip6.fr/)
//
@r exists@
l
From: Julia Lawall
Delete unnecessary use of a local variable to immediately return 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
position p;
@@
-ret = 0;
... when != ret =
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
Code have skein_512_ctx and skein_256_ctx but skein1024_ctx.
It would be logical to convert these names to a single form.
Signed-off-by: Anton Saraev
---
drivers/staging/skein/include/skein.h | 14 +++---
drivers/staging/skein/include/skeinApi.h| 2 +-
drivers/staging/skein/in
> Subject: Re: [PATCHv4 2/2] regmap: add DT endianness binding support.
>
> On Fri, May 09, 2014 at 03:04:33AM +0100, Xiubo Li wrote:
> > For many drivers which will support rich endianness of CPU<-->Dev
> > need define DT properties by itself without the binding support.
> >
> > The endianness us
camelCase is not accepted in the Linux Kernel. To prepare skein
driver for mainline inclusion, we rename all files to
non-camelCase equivalents.
Signed-off-by: Anton Saraev
---
drivers/staging/skein/Makefile | 10 +-
drivers/staging/skein/TODO
camelCase is not accepted in the Linux Kernel. To prepare skein
driver for mainline inclusion, we rename all functions to
non-camelCase equivalents.
Signed-off-by: Anton Saraev
---
drivers/staging/skein/TODO | 1 -
drivers/staging/skein/include/skein.h| 66 --
Hi! To prepare skein driver for mainline inclusion we fixing most of
style issues (wrong names of functions, vars, macros, files) and
checkpatch problems in this patch set. For example, existing code
is widely use camelCase names. This patch fix it.
Anton Saraev (6):
staging: crypto: skein: re
Linux Kernel use capitalized names for enum. To prepare skein
driver to mainline inclusion, we rename all enums to capitalized
names.
Signed-off-by: Anton Saraev
---
drivers/staging/skein/include/skein.h| 6 +++---
drivers/staging/skein/include/skeinApi.h | 8
drivers/stag
Currently, we use (zone->managed_pages + KSWAPD_ZONE_BALANCE_GAP_RATIO-1) /
KSWAPD_ZONE_BALANCE_GAP_RATIO to avoid a zero gap value. It's better to
use DIV_ROUND_UP macro for neater code and clear meaning.
Besides, the gap value is calculated against the per-zone "managed pages",
not "present page
On 12 May 11:26 PM, Ezequiel Garcia wrote:
> On 12 May 05:50 PM, Brian Norris wrote:
> > > There are some guidelines about attributes in
> > > 'Documentation/filesystems/sysfs.txt'
> > > Though it's acceptable to put array of values of the "same type" in
> > > single sysfs file,
> > > But I'm sti
--
Ich brauche Ihre dringende Antwort
Ich bin mit diesem Medium, um Sie Transaktion in meiner Bank in
China, Sie als Empfänger zu informieren, die die Übertragung von
21.500.000 $ (Zwanzig Millionen fünfhunderttausend US-Dollar). Das wird
100% sicher, verstorben der Zahl Kunden.
EXYNOS5410 is SoC in Samsung's Exynos5 SoC series.
Add initial support for this SoC.
Signed-off-by: Tarek Dakhran
Signed-off-by: Vyacheslav Tyrtov
Reviewed-by: Tomasz Figa
---
arch/arm/mach-exynos/Kconfig |8
arch/arm/mach-exynos/exynos.c|1 +
arch/arm/
Hi all,
After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig, gcc 4.6.3) failed like this:
drivers/built-in.o: In function `cdc_ncm_get_coalesce':
ak8975.c:(.text+0x1ac994): undefined reference to `__aeabi_uldivmod'
(The file name above seems to be rubbish, the above
The EXYNOS5410 clocks are statically listed and registered
using the Samsung specific common clock helper functions.
Signed-off-by: Tarek Dakhran
Signed-off-by: Vyacheslav Tyrtov
Acked-by: Tomasz Figa
---
.../devicetree/bindings/clock/exynos5410-clock.txt | 51 +
drivers/clk/samsung/Make
Add initial device tree nodes for EXYNOS5410 SoC and SMDK5410 board.
Signed-off-by: Tarek Dakhran
Signed-off-by: Vyacheslav Tyrtov
Reviewed-by: Tomasz Figa
---
arch/arm/boot/dts/Makefile|1 +
arch/arm/boot/dts/exynos5410-smdk5410.dts | 65
arch/arm/boot/dts/e
The series of patches represent support of Exynos 5410 SoC
The Exynos 5410 is the first Samsung SoC based on big.LITTLE architecture
Patches add new platform description, support of clock controller and device
tree for Exynos 5410.
Has been build on Samsung Linux Kernel
(branch: for-next, comm
1 - 100 of 299 matches
Mail list logo
