Re: [PATCH] arch,locking: Ciao arch_mutex_cpu_relax()

2014-06-22 Thread Peter Zijlstra
On Fri, Jun 20, 2014 at 11:21:13AM -0700, Davidlohr Bueso wrote: > From: Davidlohr Bueso > > The arch_mutex_cpu_relax() function, introduced by 34b133f, is > hacky and ugly. It was added a few years ago to address the fact > that common cpu_relax() calls include yielding on s390, and thus > impac

Re: [PATCH v3 04/13] mm, compaction: move pageblock checks up from isolate_migratepages_range()

2014-06-22 Thread Zhang Yanfei
On 06/20/2014 11:49 PM, Vlastimil Babka wrote: > isolate_migratepages_range() is the main function of the compaction scanner, > called either on a single pageblock by isolate_migratepages() during regular > compaction, or on an arbitrary range by CMA's __alloc_contig_migrate_range(). > It currently

[PATCH] crypto:caam - Configuration for platforms with virtualization enabled in CAAM

2014-06-22 Thread Ruchika Gupta
For platforms with virtualization enabled 1. The job ring registers can be written to only is the job ring has been started i.e STARTR bit in JRSTART register is 1 2. For DECO's under direct software control, with virtualization enabled PL, BMT, ICID and SDID values need to

Re: [PATCH] arch,locking: Ciao arch_mutex_cpu_relax()

2014-06-22 Thread Peter Zijlstra
On Fri, Jun 20, 2014 at 11:21:13AM -0700, Davidlohr Bueso wrote: > diff --git a/arch/arc/include/asm/processor.h > b/arch/arc/include/asm/processor.h > index d99f9b3..8e1bf6b 100644 > --- a/arch/arc/include/asm/processor.h > +++ b/arch/arc/include/asm/processor.h > @@ -62,6 +62,8 @@ unsigned long

Re: [patch 4/4] mm: vmscan: move swappiness out of scan_control

2014-06-22 Thread Minchan Kim
On Fri, Jun 20, 2014 at 12:33:50PM -0400, Johannes Weiner wrote: > Swappiness is determined for each scanned memcg individually in > shrink_zone() and is not a parameter that applies throughout the > reclaim scan. Move it out of struct scan_control to prevent > accidental use of a stale value. >

Re: [patch 3/4] mm: vmscan: remove all_unreclaimable()

2014-06-22 Thread Minchan Kim
On Fri, Jun 20, 2014 at 12:33:49PM -0400, Johannes Weiner wrote: > Direct reclaim currently calls shrink_zones() to reclaim all members > of a zonelist, and if that wasn't successful it does another pass > through the same zonelist to check overall reclaimability. > > Just check reclaimability in

Re: [PATCH] sched: Fix potential near-infinite distribute_cfs_runtime loop

2014-06-22 Thread Peter Zijlstra
On Fri, Jun 20, 2014 at 03:21:20PM -0700, Ben Segall wrote: > distribute_cfs_runtime intentionally only hands out enough runtime to > bring each cfs_rq to 1 ns of runtime, expecting the cfs_rqs to then take > the runtime they need only once they actually get to run. However, if > they get to run su

Re: [PATCH v1 2/2] block: virtio-blk: support multi virt queues per virtio-blk device

2014-06-22 Thread Michael S. Tsirkin
On Mon, Jun 23, 2014 at 01:42:51PM +1000, Dave Chinner wrote: > On Sun, Jun 22, 2014 at 01:24:48PM +0300, Michael S. Tsirkin wrote: > > On Fri, Jun 20, 2014 at 11:29:40PM +0800, Ming Lei wrote: > > > @@ -24,8 +26,8 @@ static struct workqueue_struct *virtblk_wq; > > > struct virtio_blk > > > { > >

Re: [patch 2/4] mm: vmscan: rework compaction-ready signaling in direct reclaim

2014-06-22 Thread Minchan Kim
On Fri, Jun 20, 2014 at 12:33:48PM -0400, Johannes Weiner wrote: > Page reclaim for a higher-order page runs until compaction is ready, > then aborts and signals this situation through the return value of > shrink_zones(). This is an oddly specific signal to encode in the > return value of shrink_

Re: [PATCH 1/2] slip: Fix deadlock in write_wakeup

2014-06-22 Thread Alexander Stein
On Monday 16 June 2014 19:55:04, Oliver Hartkopp wrote: > Hello Tyler, > > On 16.06.2014 04:23, Tyler Hall wrote: > > Use schedule_work() to avoid potentially taking the spinlock in > > interrupt context. > > > (..) > > > > > To deal with these issues, don't grab the lock in the wakeup function

Re: [RFC PATCH 0/3] Mark literal strings in __init / __exit code

2014-06-22 Thread Joe Perches
On Mon, 2014-06-23 at 08:23 +0200, Mathias Krause wrote: > On 23 June 2014 00:56, Joe Perches wrote: > > On Mon, 2014-06-23 at 00:46 +0200, Mathias Krause wrote: > >> [...] patch 2 adds some syntactical sugar for the most popular use > >> case, by providing pr_ alike macros, namely pi_ for __init

Re: [RFC PATCH 0/3] Mark literal strings in __init / __exit code

2014-06-22 Thread Mathias Krause
On 23 June 2014 03:30, Joe Perches wrote: > On Mon, 2014-06-23 at 00:46 +0200, Mathias Krause wrote: >> This RFC series tries to address the problem of dangling strings of >> __init functions after initialization, as well as __exit strings for >> code not even included in the final kernel image. T

Re: [PATCH tip/core/rcu] Reduce overhead of cond_resched() checks for RCU

2014-06-22 Thread Peter Zijlstra
On Fri, Jun 20, 2014 at 07:59:58PM -0700, Paul E. McKenney wrote: > Commit ac1bea85781e (Make cond_resched() report RCU quiescent states) > fixed a problem where a CPU looping in the kernel with but one runnable > task would give RCU CPU stall warnings, even if the in-kernel loop > contained cond_r

Re: [PATCH v3 02/13] mm, compaction: defer each zone individually instead of preferred zone

2014-06-22 Thread Zhang Yanfei
On 06/20/2014 11:49 PM, Vlastimil Babka wrote: > When direct sync compaction is often unsuccessful, it may become deferred for > some time to avoid further useless attempts, both sync and async. Successful > high-order allocations un-defer compaction, while further unsuccessful > compaction attempt

Re: [RFC PATCH 0/3] Mark literal strings in __init / __exit code

2014-06-22 Thread Mathias Krause
On 23 June 2014 00:56, Joe Perches wrote: > On Mon, 2014-06-23 at 00:46 +0200, Mathias Krause wrote: >> [...] patch 2 adds some syntactical sugar for the most popular use >> case, by providing pr_ alike macros, namely pi_ for __init >> code and pe_ for __exit code. This hides the use of the marker

Re: [PATCH 1/2] ASoC: max98090: Add max98091 compatible string

2014-06-22 Thread Tushar Behera
On 06/21/2014 02:02 AM, Doug Anderson wrote: > Tushar, > > On Fri, Jun 20, 2014 at 1:03 AM, Tushar Behera wrote: >> From: Wonjoon Lee >> >> The MAX98091 CODEC is the same as MAX98090 CODEC, but with an extra >> microphone. Existing driver for MAX98090 CODEC already has support >> for MAX98091 CO

Re: [PATCH] usb: misc: usb3503: Update error code in print message

2014-06-22 Thread Tushar Behera
On 06/17/2014 04:54 PM, Marek Szyprowski wrote: > Hello, > > On 2014-06-17 13:08, Tushar Behera wrote: >> 'err' is uninitialized, rather print the error code directly. >> >> This also fixes following warning. >> drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’: >> drivers/usb/misc/usb3503.c

Re: [patch 12/13] mm: memcontrol: rewrite charge API

2014-06-22 Thread Uwe Kleine-König
Hello, On Wed, Jun 18, 2014 at 04:40:44PM -0400, Johannes Weiner wrote: > The memcg charge API charges pages before they are rmapped - i.e. have > an actual "type" - and so every callsite needs its own set of charge > and uncharge functions to know what type is being operated on. Worse, > uncharg

Re: [patch 1/4] mm: vmscan: remove remains of kswapd-managed zone->all_unreclaimable

2014-06-22 Thread Minchan Kim
On Fri, Jun 20, 2014 at 12:33:47PM -0400, Johannes Weiner wrote: > shrink_zones() has a special branch to skip the all_unreclaimable() > check during hibernation, because a frozen kswapd can't mark a zone > unreclaimable. > > But ever since 6e543d5780e3 ("mm: vmscan: fix do_try_to_free_pages() > l

Re: [RFC][PATCH 3/3] x86: make MP a required-feature on 64-bit

2014-06-22 Thread Andi Kleen
> We probably should just the cpu_has_mp macro entirely. All it is used > for is printing a warning in amd_k7_smp_check(). > > Andi, Borislav -- as far as I can tell, we have *never* enforced this on > the 64-bit kernel, although we have enforced it on 64-bit processors > running the 32-bit kerne

Re: [PATCH] serial: samsung: Remove redundant label

2014-06-22 Thread Sachin Kamat
On Mon, Jun 23, 2014 at 11:32 AM, Tushar Behera wrote: > probe_err label only returns the error code. This label can be removed > and the error code can be returned directly. > > Signed-off-by: Tushar Behera > --- > drivers/tty/serial/samsung.c |5 + > 1 file changed, 1 insertion(+), 4 d

Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-22 Thread Robert Baldyga
On 06/19/2014 05:08 PM, Felipe Balbi wrote: > On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Baldyga wrote: >> This field allows to mark ep as claimed in more clear way. Claiming >> endpoint by setting driver_data to non-null value is leaky solution >> and makes code unreadable. > > how come ? H

[PATCH] serial: samsung: Remove redundant label

2014-06-22 Thread Tushar Behera
probe_err label only returns the error code. This label can be removed and the error code can be returned directly. Signed-off-by: Tushar Behera --- drivers/tty/serial/samsung.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/

[PATCH 0/2] serial: amba-pl01x: Clean up patches

2014-06-22 Thread Tushar Behera
The patches are based next-20140620 and they have only been build tested. Tushar Behera (2): serial: amba-pl011: Simplify goto statements serial: amba-pl010: Use devres APIs drivers/tty/serial/amba-pl010.c | 46 ++- drivers/tty/serial/amba-pl011.c | 30

[PATCH 2/2] serial: amba-pl010: Use devres APIs

2014-06-22 Thread Tushar Behera
Migrating to use devres managed APIs devm_kzalloc, devm_ioremap and devm_clk_get. Signed-off-by: Tushar Behera --- drivers/tty/serial/amba-pl010.c | 46 ++- 1 file changed, 16 insertions(+), 30 deletions(-) diff --git a/drivers/tty/serial/amba-pl010.c b/dri

[PATCH 1/2] serial: amba-pl011: Remove redundant label

2014-06-22 Thread Tushar Behera
The label 'out' is only used to return the error code. We can return the error code directly and remove 'out' label. Signed-off-by: Tushar Behera --- drivers/tty/serial/amba-pl011.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/tty

Re: [PATCH] kconfig: plug false-positive warning in get_prompt_str() seen with gcc-4.9

2014-06-22 Thread Uwe Kleine-König
Hello, On Sun, May 25, 2014 at 08:47:51PM +0400, Konstantin Khlebnikov wrote: > scripts/kconfig/menu.c: In function ‘get_symbol_str’: > scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in > this function [-Wmaybe-uninitialized] > jump->offset = strlen(r->s); >

Re: [PATCH v3 01/13] mm, THP: don't hold mmap_sem in khugepaged when allocating THP

2014-06-22 Thread Zhang Yanfei
Hello On 06/21/2014 01:45 AM, Kirill A. Shutemov wrote: > On Fri, Jun 20, 2014 at 05:49:31PM +0200, Vlastimil Babka wrote: >> When allocating huge page for collapsing, khugepaged currently holds mmap_sem >> for reading on the mm where collapsing occurs. Afterwards the read lock is >> dropped befor

[PATCH] x86, vsmp: Remove is_vsmp_box() from apic_is_clustered_box()

2014-06-22 Thread Oren Twaig
Remove invalid code which caused TSC to be declared as "unstable" on vSMP Foundation box even if it was stable and let the kernel decide for itself. When a vSMP Foundation box is detected, the function apic_cluster_num() counts the number of APIC clusters found. If more than one found, a multi boa

Re: [PATCH v2 0/8] Add Keystone PCIe controller driver

2014-06-22 Thread Pratyush Anand
On Sat, Jun 21, 2014 at 03:05:30AM +0800, Arnd Bergmann wrote: > On Friday 20 June 2014 13:11:37 Santosh Shilimkar wrote: > > > > > Arnd suggestion was to have the version 3.65 code in generic place since > > its IP specific and just in case some other vendor using the same version > > can levera

RE: [PATCH v2 2/8] PCI: designware: refactor host init code to re-use on v3.65 DW pci hw

2014-06-22 Thread Mohit KUMAR DCG
Hello Murali, > -Original Message- > From: Pratyush ANAND > Sent: Monday, June 23, 2014 10:36 AM > To: Murali Karicheri > Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux- > d...@vger.kernel.org; Shilimka

Re: [PATCH v2 0/8] Add Keystone PCIe controller driver

2014-06-22 Thread Pratyush Anand
On Sat, Jun 21, 2014 at 05:17:07AM +0800, Murali Karicheri wrote: > > Sorry, my previous response was in html and not sure it has made to the > list. I did > get an error as well. So resending my response. > > On 6/18/2014 6:14 AM, Mohit KUMAR DCG wrote: > > Hello Murali, > > > [...] > *pos =

[PATCH] mm:kswapd: clean up the kswapd

2014-06-22 Thread Chen Yucong
According to the commit 215ddd66 (mm: vmscan: only read new_classzone_idx from pgdat when reclaiming successfully) and the commit d2ebd0f6b (kswapd: avoid unnecessary rebalance after an unsuccessful balancing), we can use a boolean variable for replace balanced_* variables, which makes the kswapd m

Re: [PATCH v2 2/8] PCI: designware: refactor host init code to re-use on v3.65 DW pci hw

2014-06-22 Thread Pratyush Anand
On Sat, Jun 21, 2014 at 02:47:27AM +0800, Murali Karicheri wrote: > On 6/18/2014 3:05 AM, Pratyush Anand wrote: > > Hi Murali, > > > > On Wed, Jun 11, 2014 at 02:51:21AM +0800, Murali Karicheri wrote: [...] > Pratyush, > > Thanks for the comments. > > This is IP specific code and another driver

linux-next: Tree for Jun 23

2014-06-22 Thread Stephen Rothwell
Hi all, The powerpc allyesconfig is again broken more than usual. Changes since 20140620: The mvebu tree gained a conflict against Linus' tree. The crypto tree gained a build failure so I used the version from next-20140620. The staging tree still had its build failure for which I disabled a d

[PATCH] arm64: make CONFIG_ZONE_DMA user settable

2014-06-22 Thread Mark Salter
Commit 19e7640d1f (arm64: Replace ZONE_DMA32 with ZONE_DMA) moves support for 32-bit DMA addressing into ZONE_DMA and renames CONFIG_ZONE_DMA32 to CONFIG_ZONE_DMA. Commit 2d5a5612bc (arm64: Limit the CMA buffer to 32-bit if ZONE_DMA) forces the CMA buffer to be 32-bit addressable if CONFIG_ZONE_DM

[PATCH] arm64: fix CONFIG_ZONE_DMA on systems with no 32-bit addressable DRAM

2014-06-22 Thread Mark Salter
Commit 2d5a5612bc (arm64: Limit the CMA buffer to 32-bit if ZONE_DMA) forces the CMA buffer to be 32-bit addressable if CONFIG_ZONE_DMA is defined. This breaks CMA on platforms with no 32-bit addressable DRAM. This patch checks to make sure there is 32-bit addressable DRAM before setting the 32-bit

Re: [PATCH 0/2] ARM: DRA7: hwmod: fixes for 3.16

2014-06-22 Thread Paul Walmsley
Hi Roger On Wed, 18 Jun 2014, Roger Quadros wrote: > These patches add the missing OCP2SCP3 module and fixup the SATA hwmod > for DRA7 SoC. Both patches are tested on 3.16-rc1. Could you please post a quick serial capture of a boot log for these patches, as Felipe has done for other patches? t

Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-22 Thread Chen Gang
On 06/23/2014 11:10 AM, Lennox Wu wrote: > Yes, it's the reason we still thank Chen's checking. > Arbitrary configurations except the default configure are not > guaranteed to pass compiling. > To discover combinations which doesn't make sense might weast Chen's time. > It does not waste my time

Re: [PATCH 4/5] hrtimer: Kick lowres dynticks targets on timer enqueue

2014-06-22 Thread Viresh Kumar
On 22 June 2014 19:06, Thomas Gleixner wrote: > On Sun, 22 Jun 2014, Frederic Weisbecker wrote: >> + wake_up_nohz_cpu(base->cpu_base->cpu); > > The timer is queued on new_base not on base. Oops, thanks for spotting this bug. Will be fixed in next version. -- To unsubscribe from this

Re: [PATCH v2 09/20] clk: sunxi: Add sun6i MBUS clock support

2014-06-22 Thread Chen-Yu Tsai
On Wed, Jun 18, 2014 at 6:04 PM, Maxime Ripard wrote: > On Tue, Jun 17, 2014 at 10:52:46PM +0800, Chen-Yu Tsai wrote: >> Signed-off-by: Chen-Yu Tsai >> --- >> Documentation/devicetree/bindings/clock/sunxi.txt | 1 + >> drivers/clk/sunxi/clk-sunxi.c | 44 >> +

linux-next: manual merge of the akpm tree with the char-misc tree

2014-06-22 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in drivers/w1/w1_int.c between commit fdc9167a7853 ("w1: use pr_* instead of printk") from the char-misc tree and commit "drivers/w1/w1_int.c: call put_device if device_register fails" from the akpm tree. I fixed it up (see below

Re: [PATCH v2] sched: Fast idling of CPU when system is partially loaded

2014-06-22 Thread Jason Low
On Mon, 2014-06-16 at 12:48 -0700, Tim Chen wrote: > Thanks to the review from Jason and Peter. I've moved the check > of whether load balance is required into fair.c's idle_balance. > > When a system is lightly loaded (i.e. no more than 1 job per cpu), > attempt to pull job to a cpu before putt

[PATCH][v4] crypto: caam - Correct definition of registers in memory map

2014-06-22 Thread Ruchika Gupta
Some registers like SECVID, CHAVID, CHA Revision Number, CTPR were defined as 64 bit resgisters. The IP provides a DWT bit(Double word Transpose) to transpose the two words when a double word register is accessed. However setting this bit would also affect the operation of job descriptors as well

Re: [PATCH -mm] memcg: mem_cgroup_charge_statistics needs preempt_disable

2014-06-22 Thread Johannes Weiner
On Fri, Jun 20, 2014 at 06:36:11PM +0200, Michal Hocko wrote: > preempt_disable was previously disabled by lock_page_cgroup which has > been removed by "mm: memcontrol: rewrite uncharge API". > > This fixes the a flood of splats like this: > [3.149371] BUG: using __this_cpu_add() in preemptibl

Re: [RFC] Per-user namespace process accounting

2014-06-22 Thread Serge E. Hallyn
Quoting Marian Marinov (m...@1h.com): > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/03/2014 08:54 PM, Eric W. Biederman wrote: > > Serge Hallyn writes: > > > >> Quoting Pavel Emelyanov (xe...@parallels.com): > >>> On 05/29/2014 07:32 PM, Serge Hallyn wrote: > Quoting Marian Ma

Re: [PATCH v1 2/2] block: virtio-blk: support multi virt queues per virtio-blk device

2014-06-22 Thread Dave Chinner
On Sun, Jun 22, 2014 at 01:24:48PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 20, 2014 at 11:29:40PM +0800, Ming Lei wrote: > > @@ -24,8 +26,8 @@ static struct workqueue_struct *virtblk_wq; > > struct virtio_blk > > { > > struct virtio_device *vdev; > > - struct virtqueue *vq; > > - s

Re: [PATCH 2/4] Documentation: devicetree: Fix s2mps11 example syntax

2014-06-22 Thread Sachin Kamat
On Mon, Jun 23, 2014 at 6:51 AM, Andreas Färber wrote: > It's <1>, not 1. > > Signed-off-by: Andreas Färber > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt > b/Do

Re: [PATCH 1/4] Documentation: devicetree: Fix s2mps11 and s5m8767 typos

2014-06-22 Thread Sachin Kamat
On Mon, Jun 23, 2014 at 6:51 AM, Andreas Färber wrote: > It's LDO2, not LD02. > > Signed-off-by: Andreas Färber > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +- > Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt | 2 +- > 2 files changed, 2 inser

[PATCH -tip ] [BUGFIX]: Fix to add a missing pair of braces for error path.

2014-06-22 Thread Masami Hiramatsu
Fix to add a missing pair of braces for error path. Commit 36d789a4d75f (perf probe: Improve error message for unknown member of data structure) introduced this bug. Without this fix, defining an event with global variables is always failed, because it always returns -ENOENT if the argument is not

RE: [PATCH 1/2] f2fs: introduce f2fs_do_tmpfile for code consistency

2014-06-22 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Monday, June 23, 2014 9:13 AM > To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-de...@lists.sourceforge.net > Cc: Jaegeuk Kim; Chao Yu > Subject: [PATCH 1/2] f2fs: introduce f2fs_

Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-22 Thread Lennox Wu
Sorry for the typo . To discover combinations which doesn't make sense might waste Chen's time. 2014-06-23 11:07 GMT+08:00 Chen Gang : > On 06/23/2014 12:28 AM, Guenter Roeck wrote: >> On 06/22/2014 01:09 AM, Lennox Wu wrote: >>> Hi Chen, >>> Do you find other modules except device module

[PATCH] samples/kprobes: Update jprobe_example.c for do_fork() change

2014-06-22 Thread Michael Ellerman
In commit e80d666 "flagday: kill pt_regs argument of do_fork()", the arguments to do_fork() changed. The example code in jprobe_example.c was not updated to match, so the arguments inside the jprobe handler do not match reality. Fix it by updating the arguments to match do_fork(). While we're at

Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-22 Thread Lennox Wu
Yes, it's the reason we still thank Chen's checking. Arbitrary configurations except the default configure are not guaranteed to pass compiling. To discover combinations which doesn't make sense might weast Chen's time. Best, Lennox 2014-06-23 0:28 GMT+08:00 Guenter Roeck : > On 06/22/2014 01:09

Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-22 Thread Chen Gang
On 06/23/2014 12:28 AM, Guenter Roeck wrote: > On 06/22/2014 01:09 AM, Lennox Wu wrote: >> Hi Chen, >> Do you find other modules except device modules cause issues of >> compiling? >> The applications of Score are limited. Acutally, some errors never occur >> in the limited applications, for exampl

Re: [PATCH v3 11/13] mm, compaction: pass gfp mask to compact_control

2014-06-22 Thread Minchan Kim
On Fri, Jun 20, 2014 at 05:49:41PM +0200, Vlastimil Babka wrote: > From: David Rientjes > > struct compact_control currently converts the gfp mask to a migratetype, but > we > need the entire gfp mask in a follow-up patch. > > Pass the entire gfp mask as part of struct compact_control. > > Sig

Re: [PATCH v3 09/13] mm, compaction: skip buddy pages by their order in the migrate scanner

2014-06-22 Thread Minchan Kim
On Fri, Jun 20, 2014 at 05:49:39PM +0200, Vlastimil Babka wrote: > The migration scanner skips PageBuddy pages, but does not consider their order > as checking page_order() is generally unsafe without holding the zone->lock, > and acquiring the lock just for the check wouldn't be a good tradeoff. >

Re: [PATCH v3 08/13] mm, compaction: remember position within pageblock in free pages scanner

2014-06-22 Thread Minchan Kim
On Fri, Jun 20, 2014 at 05:49:38PM +0200, Vlastimil Babka wrote: > Unlike the migration scanner, the free scanner remembers the beginning of the > last scanned pageblock in cc->free_pfn. It might be therefore rescanning pages > uselessly when called several times during single compaction. This migh

Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-22 Thread Chen Gang
On 06/22/2014 11:02 PM, Guenter Roeck wrote: > On 06/22/2014 07:53 AM, Guenter Roeck wrote: >> I did that, and managed to build gcc. >> >> However, when trying to compile score defconfig, I get internal >> compiler errors in cc1 >> when compiling drivers/tty/tty_mutex.o and block/elevator.o. >> >>

Re: [PATCH] fs/ntfs: Use '%tx' instead of '%zx'

2014-06-22 Thread Chen Gang
On 06/23/2014 09:46 AM, Joe Perches wrote: > Please make sure to cc the specific maintainer > > $ ./scripts/get_maintainer.pl -f fs/ntfs/ > Anton Altaparmakov (supporter:NTFS FILESYSTEM) > linux-ntfs-...@lists.sourceforge.net (open list:NTFS FILESYSTEM) > linux-kernel@vger.kernel.org (open list)

Re: [PATCH v3 06/13] mm, compaction: periodically drop lock and restore IRQs in scanners

2014-06-22 Thread Minchan Kim
On Fri, Jun 20, 2014 at 05:49:36PM +0200, Vlastimil Babka wrote: > Compaction scanners regularly check for lock contention and need_resched() > through the compact_checklock_irqsave() function. However, if there is no > contention, the lock can be held and IRQ disabled for potentially long time. >

[Patch] x86: intel-mid: fix conflicts between 78a3bb9e408b and 9f354b0252b8

2014-06-22 Thread Jiang Liu
Commit 9f354b0252b8 "x86, irq: Clean up unused IOAPIC interface" kills interface io_apic_set_pci_routing(), so change arch/x86/platform/ intel-mid/device_libs/platform_wdt.c to use new interfaces. Due to hardware resource restriction, this patch only passes compilation without functional tests. S

Re: [PATCH v3 02/13] mm, compaction: defer each zone individually instead of preferred zone

2014-06-22 Thread Minchan Kim
On Fri, Jun 20, 2014 at 05:49:32PM +0200, Vlastimil Babka wrote: > When direct sync compaction is often unsuccessful, it may become deferred for > some time to avoid further useless attempts, both sync and async. Successful > high-order allocations un-defer compaction, while further unsuccessful >

Re: [PATCH 1/1] net/netfilter/ipvs/ip_vs_sync.c: remove null test before kfree

2014-06-22 Thread Simon Horman
On Fri, Jun 20, 2014 at 10:35:42PM +0200, Fabian Frederick wrote: > Fix checkpatch warning: > WARNING: kfree(NULL) is safe this check is probably not required > > Cc: Wensong Zhang > Cc: Simon Horman > Cc: net...@vger.kernel.org > Signed-off-by: Fabian Frederick Thanks, applied. > --- > net/

Re: [PATCH -tip 1/4] perf/probe: Improve error message for unknown member of data structure

2014-06-22 Thread Masami Hiramatsu
(2014/06/22 3:18), Patrick Palka wrote: > On Fri, Jun 6, 2014 at 3:13 AM, Masami Hiramatsu > wrote: >> Improve the error message if we can not find given member in >> the given structure. Currently perf probe shows a wrong error >> message as below. >> >> - >> # perf probe getname_flags:65

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-22 Thread Ilia Mirkin
On Sat, Jun 21, 2014 at 3:45 PM, Greg KH wrote: > On Sat, Jun 21, 2014 at 02:22:59PM -0400, Ilia Mirkin wrote: >> On Sat, Jun 21, 2014 at 2:02 PM, Pavel Machek wrote: >> > Hi! >> > >> > AFAICT, pstate file will contain something like >> > >> > 07: core 100 MHz memory 123 MHz * >> > 08: core 100-2

Re: [PATCH 0/8] mm: add page cache limit and reclaim feature

2014-06-22 Thread Xishi Qiu
On 2014/6/20 23:32, Michal Hocko wrote: > On Fri 20-06-14 15:56:56, Xishi Qiu wrote: >> On 2014/6/17 9:35, Xishi Qiu wrote: >> >>> On 2014/6/16 20:50, Rafael Aquini wrote: >>> On Mon, Jun 16, 2014 at 01:14:22PM +0200, Michal Hocko wrote: > On Mon 16-06-14 17:24:38, Xishi Qiu wrote: >>

linux-next: build failure after merge of the crypto tree

2014-06-22 Thread Stephen Rothwell
Hi Herbert, After merging the crypto tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c:47:31: fatal error: adf_accel_devices.h: No such file or directory #include ^ drivers/crypto/qat/qa

Re: [RFC PATCH 1/1] Move two pinned pages to non-movable node in kvm.

2014-06-22 Thread Tang Chen
Hi Marcelo, Gleb, Sorry for the delayed reply and thanks for the advices. On 06/21/2014 04:39 AM, Marcelo Tosatti wrote: On Fri, Jun 20, 2014 at 05:31:46PM -0300, Marcelo Tosatti wrote: IIRC your shadow page pinning patch series support flushing of ptes by mmu notifier by forcing MMU reload an

Re: [PATCH] fs/ntfs: Use '%tx' instead of '%zx'

2014-06-22 Thread Joe Perches
Please make sure to cc the specific maintainer $ ./scripts/get_maintainer.pl -f fs/ntfs/ Anton Altaparmakov (supporter:NTFS FILESYSTEM) linux-ntfs-...@lists.sourceforge.net (open list:NTFS FILESYSTEM) linux-kernel@vger.kernel.org (open list) (cc'ing Anton) btw Anton, it seems ntfs_debug does no

Re: [PATCH v2 0/8] Add Keystone PCIe controller driver

2014-06-22 Thread Jingoo Han
On Saturday, June 21, 2014 12:31 AM, Murali Karicheri wrote: > On 6/17/2014 8:08 PM, Bjorn Helgaas wrote: > > On Tue, Jun 10, 2014 at 02:51:19PM -0400, Murali Karicheri wrote: > >> This patch adds a PCIe controller driver for Keystone SoCs. This > >> is based on v1 of the series posted to the maili

Re: [PATCH v3 05/13] mm, compaction: report compaction as contended only due to lock contention

2014-06-22 Thread Minchan Kim
Hello Vlastimil, On Fri, Jun 20, 2014 at 05:49:35PM +0200, Vlastimil Babka wrote: > Async compaction aborts when it detects zone lock contention or need_resched() > is true. David Rientjes has reported that in practice, most direct async > compactions for THP allocation abort due to need_resched()

[PATCH 05/18] staging/lustre/ptlrpc: fix NULL pointer dereference of {exp,imp}_obd

2014-06-22 Thread Oleg Drokin
From: Dmitry Eremin Pointer 'obd' checked for NULL at line 694 may be dereferenced at line 813. Pointer 'req->rq_export->exp_obd' checked for NULL at line 1155 may be dereferenced at line 1164. Also there is one similar error on line 1170. Signed-off-by: Dmitry Eremin Reviewed-on: http://revie

[PATCH 03/18] staging/lustre/llite: Only kill SGID/SUID bits

2014-06-22 Thread Oleg Drokin
From: Nathaniel Clark Check that attr mode is valid before using it when determining if to clear SGID and SUID bits in ll_setattr. Signed-off-by: Nathaniel Clark Reviewed-on: http://review.whamcloud.com/10153 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4924 Reviewed-by: Lai Siyao Revie

[PATCH 08/18] staging/lustre/ptlrpc: race at req processing

2014-06-22 Thread Oleg Drokin
From: "Alexander.Boyko" Race between ptlrpc_resend_req() and ptlrpc_check_set(). 1 thread do ptlrpc_check_set()->after_reply() 2 thread do ptlrpc_resend_req() The result is request with rq_resend = 1 and MSG_REPLY flag. When this request will came to server it will cause client eviction. The patc

[PATCH 04/18] staging/lustre: fix frong ldlm flags type used

2014-06-22 Thread Oleg Drokin
From: Dmitry Eremin Fixed implicit conversion from 'unsigned long long' to 'int'. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/7799 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4023 Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lus

[PATCH 02/18] staging/lustre/ptlrpc: Protect request buffer changing

2014-06-22 Thread Oleg Drokin
*_enlarge_reqbuf class of functions can change request body location for a request that's already in replay list, as such a parallel traverser of the list (after_reply -> ptlrpc_free_committed) might access freed and scrambled memory causing assertion. Since all such users only can get to this req

[PATCH 09/18] staging/lustre/mgc: replace hard-coded MGC_ENQUEUE_LIMIT value

2014-06-22 Thread Oleg Drokin
From: Cheng Shao During client mount, the client will send an LDLM_ENQUEUE request to MGS with send delay set to MGC_ENQUEUE_LIMIT, which is hard coded to 50 seconds. On the other hand, the interval for pinger is deduced from obd_timeout. When obd_timeout is configured for a longer period of time

[PATCH 06/18] staging/lustre/mgc: mgc import reconnect race

2014-06-22 Thread Oleg Drokin
From: Andriy Skulysh mgc import can be reconnected by pinger or ptlrpc_reconnect_import(). ptlrpc_invalidate_import() isn't protected against alteration of imp_invalid state. Import can be reconnected by pinger which makes imp_invalid equal to false. Thus LASSERT(imp->imp_invalid) fails in ptlrpc

[PATCH] fs/ntfs: Use '%tx' instead of '%zx'

2014-06-22 Thread Chen Gang
For subtraction between 2 pointers, the result's type is 'ptrdiff_t', so need use '%tx' instead of '%zx'. The related warning (allmodconfig under unicore32): CC [M] fs/ntfs/compress.o fs/ntfs/compress.c: In function 'ntfs_decompress': fs/ntfs/compress.c:207:2: warning: format '%zx' expec

[PATCH 07/18] staging/lustre/osc: get rid of old checksum initial value

2014-06-22 Thread Oleg Drokin
From: Bobi Jam Old code residue assumes initial checksum value as ~0, and relies on that to check whether OST server has calculated bulk data checksum. That is not the case anymore. Signed-off-by: Bobi Jam Reviewed-on: http://review.whamcloud.com/10354 Intel-bug-id: https://jira.hpdd.intel.com/

[PATCH 11/18] staging/lustre/obdclass: Fix uninitialized variables

2014-06-22 Thread Oleg Drokin
From: Dmitry Eremin 'sd.page_link' is used uninitialized in this function. 'ss.page_link' is used uninitialized in this function. 'sl.page_link' is used uninitialized in this function. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/10613 Intel-bug-id: https://jira.hpdd.in

[PATCH 13/18] staging/lustre/llite: Fix uninitialized variable

2014-06-22 Thread Oleg Drokin
From: Dmitry Eremin 'f.f_flags' might be used uninitialized in this function. xattr.c:248: 'f.f_flags' is declared. xattr.c:244: lump!= ( (void* )0) is true xattr.c:254: 'f.f_flags' is used, but is uninitialized. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/10663 Intel

[PATCH 14/18] staging/lustre/ptlrpc: unlink request buffer correctly

2014-06-22 Thread Oleg Drokin
From: Alexey Lyashkov outgoning buffer may be hold by lnet and don't unlinked fast, it's break unloading a lustre modules as request hold a reference to the export/obd Signed-off-by: Alexey Lyashkov Xyratex-bug-id: MRP-1848 Reviewed-on: http://review.whamcloud.com/10353 Intel-bug-id: https://ji

[PATCH 16/18] staging/lustre/vvp: release mmap_sem in error case

2014-06-22 Thread Oleg Drokin
From: Patrick Farrell The mmap_sem is downed in vvp_mmap_locks, but in case of error from cl_io_lock_alloc_add, it is not upped. Credit to Paul Casella at Cray for finding this. Signed-off-by: Patrick Farrell Reviewed-on: http://review.whamcloud.com/10741 Intel-bug-id: https://jira.hpdd.intel.

[PATCH 18/18] staging/lustre/lnet: abort messages whose MD has been unlinked

2014-06-22 Thread Oleg Drokin
From: Isaac Huang If LNetMDUnlink has been called, all outgoing messages on that MD should be aborted before lnet_ni_send() is called. Signed-off-by: Isaac Huang Reviewed-on: http://review.whamcloud.com/8041 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4006 Reviewed-by: Liang Zhen Revie

[PATCH 15/18] staging/lustre/obdclass: runtime load lustre client when needed

2014-06-22 Thread Oleg Drokin
From: Bob Glossman Manually force loading of lustre.ko during client mounts with request_module for cases where autoloading doesn't happen. Signed-off-by: Bob Glossman Reviewed-on: http://review.whamcloud.com/10587 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4800 Reviewed-by: John L. Ha

[PATCH 12/18] staging/lustre/osc: osc_extent_truncate()) ASSERTION( !ext->oe_urgent ) failed

2014-06-22 Thread Oleg Drokin
From: Andriy Skulysh The bug was caused by race between truncate & fsync. osc_extent_wait() doesn't takes into account oe_trunc_pending during setting oe_urgent. The race arises after osc_object_unlock(). osc_extent_wait() should ignore extents with oe_trunc_pending while waiting for OES_INV. osc

[PATCH 10/18] staging/lustre/ptlrpc: Add schedule point to ptlrpc_check_set()

2014-06-22 Thread Oleg Drokin
From: "Christopher J. Morrone" Most ptlrpc sets are believed to be small and bounded in length. However at the very least the ptlrpcd reuses the ptlrpc sets at its primary work queue. This work queue can easily have work added faster than the ptlrpcd thread can process the work. The unbounded

[PATCH 01/18] staging/lustre/libcfs: revert changes to libcfs_sock_ioctl

2014-06-22 Thread Oleg Drokin
Changes introduced by 80db2734acbc78db12798cfb611d6acc7fe389e6 unfortunately totally break lustre, we use this function to access not only socket proto obs, but also device ioctl like SIOCGIFCONF that now fail. Reverting part of the previous patch to regain the needed functionality. Signed-off-by:

[PATCH 17/18] staging/lustre/llite: fix a flag bug of vvp_io_kernel_fault()

2014-06-22 Thread Oleg Drokin
From: Li Xi After vvp_io_kernel_fault() locked the page, it should set VM_FAULT_LOCKED. Signed-off-by: Li Xi Reviewed-on: http://review.whamcloud.com/10740 Reviewed-by: Jinshan Xiong Reviewed-by: Emoly Liu Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/vvp_io.c | 2 +- 1

[PATCH 00/18] Lustre fixes

2014-06-22 Thread Oleg Drokin
These patches here represent most of recent fixes we added recently in our tree. The first patch also unbreaks lustre from total breakage that was introduced by commit 80db2734acbc78db12798cfb611d6acc7fe389e6 The changes seem to pass my testing. checkpatch output is clean except for the last patch

Re: [RFC PATCH 0/3] Mark literal strings in __init / __exit code

2014-06-22 Thread Joe Perches
On Mon, 2014-06-23 at 00:46 +0200, Mathias Krause wrote: > This RFC series tries to address the problem of dangling strings of > __init functions after initialization, as well as __exit strings for > code not even included in the final kernel image. The code might get > freed, but the format string

Re: [PATCH] fs/ntfs: Use '%lx' instead of '%zx'

2014-06-22 Thread Chen Gang
On 06/22/2014 02:06 PM, Joe Perches wrote: > On Sun, 2014-06-22 at 11:14 +0800, Chen Gang wrote: >> For subtraction between 2 pointers, the result's type is 'long', so >> need use '%lx' instead of '%zx'. > > result should be a ptrdiff_t so please use %tx > OK, thanks, I shall send patch v2 for i

[RFC 4/4] ARM: dts: exynos5250: Add Spring device tree

2014-06-22 Thread Andreas Färber
Adds initial support for the HP Chromebook 11. Cc: Vincent Palatin Cc: Doug Anderson Cc: Stephan van Schaik Signed-off-by: Andreas Färber --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/exynos5250-spring.dts | 556 2 files changed, 557 i

[PATCH 3/4] Documentation: devicetree: Fix tps65090 typos

2014-06-22 Thread Andreas Färber
It's vsys-l{1,2}-supply, not vsys_l{1,2}-supply. Signed-off-by: Andreas Färber --- Documentation/devicetree/bindings/regulator/tps65090.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator/tps65090.txt b/Documentation/devicetree

[PATCH 2/4] Documentation: devicetree: Fix s2mps11 example syntax

2014-06-22 Thread Andreas Färber
It's <1>, not 1. Signed-off-by: Andreas Färber --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt index 55ab4f4..99a0c52 1

[PATCH 1/4] Documentation: devicetree: Fix s2mps11 and s5m8767 typos

2014-06-22 Thread Andreas Färber
It's LDO2, not LD02. Signed-off-by: Andreas Färber --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +- Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindi

[PATCH 2/2] f2fs: clean up an unused parameter and assignment

2014-06-22 Thread Jaegeuk Kim
This patch cleans up simple unnecessary codes. Signed-off-by: Jaegeuk Kim --- fs/f2fs/dir.c | 2 +- fs/f2fs/f2fs.h | 2 +- fs/f2fs/namei.c | 26 +- fs/f2fs/node.c | 2 +- 4 files changed, 12 insertions(+), 20 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c

[PATCH] Input: evdev - Fix incorrect kfree of err_free_client after vzalloc

2014-06-22 Thread Yongtaek Lee
This bug was introduced by commit 92eb77d ("Input: evdev - fall back to vmalloc for client event buffer"). vzalloc is used to alloc memory as fallback in case of failure of kzalloc. But err_free_client was not considered on below case. 1. kzalloc fail 2. vzalloc success 3. evdev_open_device fail 4

  1   2   3   >