[PATCH 1/20] staging: lustre: ldlm: ldlm_lib: remove unneeded null test before free

2015-05-01 Thread Julia Lawall
Kfree can cope with a null argument, so drop null tests. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression ptr; @@ - if (ptr != NULL) kfree(ptr); // Signed-off-by: Julia Lawall --- drivers/staging/lustre/lustre/ldlm/ldlm_lib.c |3 +

[PATCH 7/20] Staging: lustre: llite: llite_lib: remove unneeded null test before free

2015-05-01 Thread Julia Lawall
Kfree can cope with a null argument, so drop null tests. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression ptr; @@ - if (ptr != NULL) kfree(ptr); // Signed-off-by: Julia Lawall --- drivers/staging/lustre/lustre/llite/llite_lib.c | 12

Re: [PATCH] checkkconfigsymbols.py: add option -i to ignore files

2015-05-01 Thread Greg KH
On Fri, May 01, 2015 at 09:31:36PM +0200, Paul Bolle wrote: > Valentin Rothberg schreef op wo 29-04-2015 om 16:58 [+0200]: > > Sometimes a user might be interested to filter certain reports (e.g., > > the many defconfigs). > > Is this actually useful outside of filtering out defconfigs? > > > Now

Re: RCU recursion? (code inspection)

2015-05-01 Thread Paul E. McKenney
On Fri, May 01, 2015 at 03:18:28PM -0400, Rik van Riel wrote: > Hi Paul, > > While looking at synchronize_rcu(), I noticed that > synchronize_rcu_expedited() calls synchronize_sched_expedited(), > which can call synchronize_sched() when it is worried about > the counter wrapping, which can call sy

[RFC PATCH 02/11] MIPS: OCTEON: move ethernet-specific helpers into a separate file

2015-05-01 Thread Aaro Koskinen
Move ethernet-specific helpers into a separate file. Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/Makefile | 1 + .../cavium-octeon/executive/cvmx-helper-ethernet.c | 912 arch/mips/cavium-octeon/executive/cvmx-helper.c| 915 +-

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-01 Thread Arnd Bergmann
On Friday 01 May 2015 20:30:04 One Thousand Gnomes wrote: > > > channel control, unless I'm missing something. If people are flexible > > with extending that I could propose something. Let me know which way you > > prefer to go. Thanks. > > I would strongly favour fixing PTP to do this right. Oth

[RFC PATCH 10/11] MIPS: OCTEON: ethernet: delete unneeded symbol exports

2015-05-01 Thread Aaro Koskinen
Delete unneeded symbol exports. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/cvmx-cmd-queue.c | 1 - drivers/staging/octeon/cvmx-helper-ethernet.c | 5 - drivers/staging/octeon/cvmx-helper-util.c | 4 drivers/staging/octeon/cvmx-pko.c | 2 -- drivers/sta

Re: [PATCH 3/3] context_tracking,x86: remove extraneous irq disable & enable from context tracking on syscall entry

2015-05-01 Thread Andy Lutomirski
On Fri, May 1, 2015 at 12:11 PM, Rik van Riel wrote: > On 05/01/2015 02:40 PM, Ingo Molnar wrote: > >> Or we could do that in the syscall path with a single store of a >> constant flag to a location in the task struct. We have a number of >> natural flags that get written on syscall entry, such as

[RFC PATCH 06/11] MIPS: OCTEON: rename __cvmx_helper_npi/rgmii_probe

2015-05-01 Thread Aaro Koskinen
Rename __cvmx_helper_npi/rgmii_probe to __cvmx_helper_npi/rgmii_enumerate as only latter are used. Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 12 ++-- arch/mips/include/asm/octeon/cvmx-helper-npi.h | 7 +++ arch/mips/include/asm/octeon/cvmx

[RFC PATCH 03/11] MIPS: OCTEON: make __cvmx_helper_sgmii/xaui_probe void

2015-05-01 Thread Aaro Koskinen
Make __cvmx_helper_sgmii/xaui_probe void, nobody is using return values and this makes functions independent of enumeration functions. Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper-sgmii.c | 5 + arch/mips/cavium-octeon/executive/cvmx-helper-xaui.c | 5 +

[RFC PATCH 05/11] MIPS: OCTEON: delete calls to __cvmx_helper_npi/rgmii_probe

2015-05-01 Thread Aaro Koskinen
These calls have no side effects so drop the calls, so that we don't need to export these functions to modules. Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper-ethernet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/mips/cavium-octeon/executive/cvmx-he

[RFC PATCH 09/11] MIPS: OCTEON: move ethernet-specific helpers to staging

2015-05-01 Thread Aaro Koskinen
Move all ethernet-specific helpers to staging. Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/Makefile| 8 +--- arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 1 + arch/mips/cavium-octeon/executive/cvmx-helper.c | 1 + drivers/sta

[RFC PATCH 04/11] MIPS: OCTEON: move interface enumeration helpers to cvmx-helper

2015-05-01 Thread Aaro Koskinen
Move interface enumeration helpers to cvmx-helper. Signed-off-by: Aaro Koskinen --- .../mips/cavium-octeon/executive/cvmx-helper-npi.c | 38 --- .../cavium-octeon/executive/cvmx-helper-rgmii.c| 46 .../cavium-octeon/executive/cvmx-helper-sgmii.c| 4 - .../mips/cavium-oct

[RFC PATCH 00/11] MIPS: OCTEON: move all octeon-ethernet code to staging

2015-05-01 Thread Aaro Koskinen
Hi, In order to octeon-ethernet staging work to proceed, we should have all the code in the same tree (staging). Currently, most of the driver code actually lives in the MIPS tree in the "cvmx" helper or OS abstraction routines and include files. Majority of this code needs refactoring (or deletio

[RFC PATCH 08/11] MIPS: OCTEON: move the link helpers into a separate file

2015-05-01 Thread Aaro Koskinen
Move the link helpers into a separate file. Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/Makefile | 2 +- .../cavium-octeon/executive/cvmx-helper-board.c| 511 arch/mips/cavium-octeon/executive/cvmx-link.c | 534 +

[RFC PATCH 11/11] MIPS: OCTEON: move all ethernet-specific headers to staging

2015-05-01 Thread Aaro Koskinen
Move all ethernet-specific headers to staging. Signed-off-by: Aaro Koskinen --- arch/mips/include/asm/octeon/cvmx-helper-board.h | 70 --- arch/mips/include/asm/octeon/cvmx-helper.h | 124 .../asm => drivers/staging}/octeon/cvmx-address.h | 0 .../staging}/octeon/c

Re: [Linux-nvdimm] [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices

2015-05-01 Thread Dan Williams
On Fri, May 1, 2015 at 12:15 PM, Toshi Kani wrote: > On Fri, 2015-05-01 at 11:43 -0700, Dan Williams wrote: >> On Fri, May 1, 2015 at 11:19 AM, Toshi Kani wrote: >> > On Fri, 2015-05-01 at 11:22 -0700, Dan Williams wrote: >> >> On Fri, May 1, 2015 at 10:48 AM, Toshi Kani wrote: >> >> > On Tue, 2

[PATCH] signals: Generate warning when flush_signals() is called from non-kthread context

2015-05-01 Thread Ingo Molnar
* Linus Torvalds wrote: > On Fri, May 1, 2015 at 10:40 AM, Alex Williamson > wrote: > > > > - Flush signals on interrupted wait to retain polling interval (Alex > > Williamson) > > This cannot *possibly* be right. If I read this patch right, you're > randomly just getting rid of signals. No w

[RFC PATCH 07/11] MIPS: OCTEON: make all interface enumeration helpers static

2015-05-01 Thread Aaro Koskinen
Make all interface enumeration helpers static. Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 10 +- arch/mips/include/asm/octeon/cvmx-helper-npi.h | 11 --- arch/mips/include/asm/octeon/cvmx-helper-rgmii.h | 9 - arch/mips/include/

[RFC PATCH 01/11] MIPS: OCTEON: cvmx-helper: use function to access interface_port_count

2015-05-01 Thread Aaro Koskinen
Use function to access interface_port_count. This allows moving functions requiring the info to different files. Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/cavium-octeon/execut

Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out

2015-05-01 Thread Jeff Moyer
Shaohua Li writes: > V2: don't change ->in_iowait > > Cc: NeilBrown > Signed-off-by: Shaohua Li > --- > kernel/sched/core.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index f9123a8..1ab3d2d 100644 > --- a/kernel/sche

Re: [Linux-nvdimm] [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices

2015-05-01 Thread Toshi Kani
On Fri, 2015-05-01 at 11:43 -0700, Dan Williams wrote: > On Fri, May 1, 2015 at 11:19 AM, Toshi Kani wrote: > > On Fri, 2015-05-01 at 11:22 -0700, Dan Williams wrote: > >> On Fri, May 1, 2015 at 10:48 AM, Toshi Kani wrote: > >> > On Tue, 2015-04-28 at 14:24 -0400, Dan Williams wrote: > >> >> Regi

Re: [PATCH] checkkconfigsymbols.py: add option -i to ignore files

2015-05-01 Thread Paul Bolle
Valentin Rothberg schreef op wo 29-04-2015 om 16:58 [+0200]: > Sometimes a user might be interested to filter certain reports (e.g., > the many defconfigs). Is this actually useful outside of filtering out defconfigs? > Now, this can be achieved by specifying a Python > regex with -i / --ignore.

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-01 Thread One Thousand Gnomes
> It's a bit more than a PTP hardware clock on a NIC. It's a clock for PTP > plus timestamping 32 other hardware inputs that can be enabled at any > time with timestamps being generated at varying frequencies. As clients > are enabled that generate timestamps at higher frequencies, the > isochronou

Re: [PATCH RFC 2/2] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-05-01 Thread Tadeusz Struk
On 05/01/2015 09:21 AM, David Howells wrote: >> +.verify = RSA_verify_signature, >> > + .capabilities = PKEY_CAN_VERIFY, > Can we keep .verify_signature as the name of the first. The second is > redundant given the function pointers. I'm thinking that .verify

Re: [PATCH] Allow TCP connections to cache SYN packet for userspace inspection

2015-05-01 Thread Andy Lutomirski
On Fri, May 1, 2015 at 10:43 AM, Eric B Munson wrote: > In order to enable policy decisions in userspace, the data contained in > the SYN packet would be useful for tracking or identifying connections. > Only parts of this data are available to userspace after the hand shake > is completed. This

[PATCH] PCI: ACS quirks for Intel 9-series PCH root ports

2015-05-01 Thread Alex Williamson
Intel confirms that 9-series chipset root ports provide ACS-equivalent isolation when configured via the existing Intel PCH ACS quirk setup. Signed-off-by: Alex Williamson Cc: Don Dugger --- drivers/pci/quirks.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/quirks.c b/dri

RCU recursion? (code inspection)

2015-05-01 Thread Rik van Riel
Hi Paul, While looking at synchronize_rcu(), I noticed that synchronize_rcu_expedited() calls synchronize_sched_expedited(), which can call synchronize_sched() when it is worried about the counter wrapping, which can call synchronize_sched_expedited() The code is sufficiently convoluted that I am

Re: [PATCH arm 1/2] arm64: Use common outgoing-CPU-notification code

2015-05-01 Thread Paul E. McKenney
On Fri, May 01, 2015 at 05:29:15PM +0100, Catalin Marinas wrote: > On Fri, May 01, 2015 at 08:08:48AM -0700, Paul E. McKenney wrote: > > On Thu, Apr 30, 2015 at 10:50:55AM +0100, Catalin Marinas wrote: > > > On Thu, Apr 23, 2015 at 01:07:33PM -0700, Paul E. McKenney wrote: > > > > diff --git a/arch

Re: [PATCH 3/3] context_tracking,x86: remove extraneous irq disable & enable from context tracking on syscall entry

2015-05-01 Thread Rik van Riel
On 05/01/2015 02:40 PM, Ingo Molnar wrote: > Or we could do that in the syscall path with a single store of a > constant flag to a location in the task struct. We have a number of > natural flags that get written on syscall entry, such as: > > pushq_cfi $__USER_DS/*

Re: [PATCH] x86: Optimize variable_test_bit()

2015-05-01 Thread Vladimir Makarov
On 01/05/15 12:33 PM, Jakub Jelinek wrote: On Fri, May 01, 2015 at 09:03:32AM -0700, Linus Torvalds wrote: PPS. Jakub, I see gcc5.1 still hasn't got output operands for asm goto; is this something we can get 'fixed' ? CCing Richard as author of asm goto and Vlad as register allocator ma

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-01 Thread Jonathan Richardson
Arnd, some more info is provided and also some questions before I can proceed. On 15-04-23 01:04 AM, Arnd Bergmann wrote: > On Wednesday 22 April 2015 16:22:03 Jonathan Richardson wrote: >> Reviewed-by: Scott Branden >> Tested-by: Scott Branden >> Signed-off-by: Jonathan Richardson > > No desc

[PATCH v3 01/20] clk: tegra: Modify tegra_audio_clk_init to accept more plls

2015-05-01 Thread Rhyland Klein
tegra_audio_clk_init was written expecting a single PLL to be passed in directly. Change this to accept an array which will allow for supporting multiple plls and specifying specific data about them, like their parent, which may change over time. Signed-off-by: Rhyland Klein --- drivers/clk/tegr

[PATCH v3 02/20] clk: tegra: periph: add new periph clks and muxes for Tegra210

2015-05-01 Thread Rhyland Klein
Tegra210 has significant differences in muxes for peripheral clocks. One of the most important changes is that pll_m isn't to be used as a source for peripherals. Therefore, we need to define the new muxes and new clocks to use those muxes for Tegra210 support. Signed-off-by: Rhyland Klein --- d

[PATCH v3 04/20] clk: tegra: pll: simplify clk_enable_path

2015-05-01 Thread Rhyland Klein
Instead of having multiple similar wrapper functions for _clk_pll_[enable|disable], we can simplify it to single wrappers and use checks to avoid the logic we don't want to use. Signed-off-by: Rhyland Klein --- v2: - Moved the iddq settings into _clk_pll_enable/disable. This is because some

[PATCH v3 05/20] clk: tegra: pll: update warning msg

2015-05-01 Thread Rhyland Klein
Swap out the generic WARN_ON with a WARN which gives more information about what is happening. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-pll.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c index 1e1

[PATCH v3 08/20] clk: tegra: pll: Add logic for handling SDM data

2015-05-01 Thread Rhyland Klein
This adds logic for taking SDM_DIN (Sigma Delta Modulator) setting into the equation to calculate the effective N value for PLL which supports fractional divider. The effective N = NDIV + 1/2 + SDM_DIN/2^13, where NDIV is the integer feedback divider. Signed-off-by: Rhyland Klein --- drivers/cl

[PATCH v3 03/20] clk: tegra: pll: add tegra_pll_wait_for_lock to clk header

2015-05-01 Thread Rhyland Klein
Create a wrapper interface to make use of the existing clk_pll_wait_for_lock. This will be useful for implementations of callbacks in Tegra SoC specific clock drivers. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-pll.c |5 + drivers/clk/tegra/clk.h |1 + 2 files changed

[PATCH v3 12/20] clk: tegra: pll: Add specialized logic for T210

2015-05-01 Thread Rhyland Klein
On Tegra210 SoC's, the logic to enable several of the plls is different from previous generations. Therefore, add registeration functions specific to Tegra210 which will handle them appropriately. Signed-off-by: Rhyland Klein --- v2: - Fixed plle logic. PLLE on Tegra210 has had its enable bit m

[PATCH v3 09/20] clk: tegra: pll: Add logic for SS

2015-05-01 Thread Rhyland Klein
From: Bill Huang Add some logic for Spread Spectrum control. It is used in conjuncture with SDM fractional dividers. SSC has to be disabled when we configure the divider settings. Signed-off-by: Bill Huang --- drivers/clk/tegra/clk-pll.c | 25 - drivers/clk/tegra/clk.

Re: [PATCH] xen: vcpu_info reinit error after 'xl save -c' & 'xl restore' on PVOPS VM which has multi-cpu

2015-05-01 Thread Boris Ostrovsky
On 04/30/2015 03:27 AM, Ouyang Zhaowei (Charles) wrote: On 2015.4.29 5:31, Boris Ostrovsky wrote: On 04/28/2015 08:30 AM, Ouyang Zhaowei (Charles) wrote: On 2015.4.26 7:31, Boris Ostrovsky wrote: On 04/24/2015 05:30 AM, Ouyang Zhaowei (Charles) wrote: If a PVOPS VM has multi-cpu the vcpu_inf

[PATCH v3 14/20] clk: tegra: pll: Adjust vco_min if SDM present

2015-05-01 Thread Rhyland Klein
From: Bill Huang This code makes use of the SDM fractional divider if present to contrain the allowable programming range of the PLL divider register bitfields to take advantage of higher frequency granularity that can be induced by the SDM divider. Based on original work by Aleksandr Frid Sig

[PATCH v3 07/20] clk: tegra: pll: Don't unconditionally set LOCK flags

2015-05-01 Thread Rhyland Klein
SoC specific drivers should define the appropriate flags for each PLL rather than relying on the registration functions to automatically set flags on their behalf. This will properly allow for changes between SoC generations where flags might be different and allow sharing the same logic functions.

[PATCH v3 13/20] clk: tegra: pll: Add support for PLLMB for T210

2015-05-01 Thread Rhyland Klein
Tegra210 SoC's have 2 PLLS for memory usage. Add plumbing to register and handle PLLMB. PLLMB is used to allow switching between 2 PLLM's without having to use and intermediate backup PLL, as we need to lock the PLL before we can switch to it. Signed-off-by: Rhyland Klein --- v3: - Flushed out

[PATCH v3 10/20] clk: tegra: pll: Add logic for out-of-table rates for T210

2015-05-01 Thread Rhyland Klein
For Tegra210, the logic to calculate out-of-table rates is different from previous generations. Add callbacks that can be overridden to allow for different ways of calculating rates. Default to _cal_rate when not specified. Based on original work by Aleksandr Frid Signed-off-by: Rhyland Klein -

[PATCH v3 17/20] clk: tegra: pll: Fix _pll_ramp_calc_pll logic and _calc_dynamic_ramp_rate

2015-05-01 Thread Rhyland Klein
This removes the conversion from pdiv to hw, which is already taken care of by _get_table_rate before this code is run. This avoids incorrectly converting pdiv to hw twice and getting the wrong hw value. Also set the input_rate in the freq cfg in _calc_dynamic_ramp_rate while setting all the other

[PATCH v3 18/20] clk: tegra: Add Super Gen5 Logic

2015-05-01 Thread Rhyland Klein
From: Bill Huang Super clock divider control and clock source mux of Tegra210 has changed a little against prior SoCs, this patch adds Gen5 logic to address those differences. Signed-off-by: Bill Huang --- v2: - Fixed sclk divider address (0x370 -> 0x2c) drivers/clk/tegra/Makefile

[PATCH v3 11/20] clk: tegra: pll: Add code to handle if resets are supported by PLL

2015-05-01 Thread Rhyland Klein
From: Bill Huang If a PLL has a reset_reg specified, properly handle that in the enable/disable logic paths. Signed-off-by: Bill Huang --- v2: - Moved reset logic to _clk_pll_enable/disable as well drivers/clk/tegra/clk-pll.c | 12 drivers/clk/tegra/clk.h |2 ++ 2 fil

[PATCH v3 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-01 Thread Rhyland Klein
Implement clock support for Tegra210. Signed-off-by: Rhyland Klein --- v3: - Fixed pll_u hierarchy. PLL_U has a vco output now, and out1 and out2 clocks which are used to generate 60M and 48M clocks. VCO is used for 480M clock and the pll_u_out clock generates the 240M clock. - Rename

[PATCH v3 16/20] clk: tegra: pll: Add Set_default logic

2015-05-01 Thread Rhyland Klein
From: Bill Huang Add logic which (if specified for a pll) can verify that a PLL is set to the proper default value and if not can set it. This can be specified per PLL as each will have different default values. Based on original work by Aleksandr Frid Signed-off-by: Bill Huang --- v2: - Re

[PATCH v3 15/20] clk: tegra: pll: Add dyn_ramp callback

2015-05-01 Thread Rhyland Klein
From: Bill Huang Add a callback to the pll_params for custom dynamic ramping functions which can be specified per PLL. Signed-off-by: Bill Huang --- drivers/clk/tegra/clk.h |4 1 file changed, 4 insertions(+) diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h index 27075a

[PATCH v3 20/20] clk: tegra: pll: Fix issues with rates for VCO PLLs

2015-05-01 Thread Rhyland Klein
From: Andrew Bresticker Without this change clk_get_rate would return the final output rather than the VCO output as it would factor in the pdiv when it shouldn't. This will cause problems for all dividers in the subtree of the VCO PLL. Signed-off-by: Andrew Bresticker Signed-off-by: Rhyland Kl

[PATCH v3 06/20] clk: tegra: pll-params: change misc_reg count from 3 -> 6

2015-05-01 Thread Rhyland Klein
From: Bill Huang New SoC's may have more then 3 MISC registers, so bump up the array size and use a #define to be more informative about the value. Signed-off-by: Bill Huang --- drivers/clk/tegra/clk.h |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/tegra/

[PATCH v3 00/20] Tegra210 Clock Support

2015-05-01 Thread Rhyland Klein
This patch series updates the tegra common clock driver and adds support for the Tegra210 clocks. The clocks in Tegra210 changed significantly in some ways from earlier generations, so to support them, we need to extend our base framework a bit and add some new features. Some patches here also add

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread Alan Cox
> > Possibly but that ought to go via staging and really is one for the SCSI > > folks to call. The dpt_i2o was a bit more common than i2o proper. > > But if the staging i2o core is removed, doesn't that mean that this > driver will stop working? It uses code in uapi i2o.h, which I'm > guessing i

Re: regression in ktime.h circa 3.16.0-rc5+ breaks lirc irsend, bad commit 166afb64511

2015-05-01 Thread John Stultz
On Fri, May 1, 2015 at 11:29 AM, Nicolas Pitre wrote: > On Fri, 1 May 2015, John Stultz wrote: > >> So yea. I see the issue now. The ktime_divns() function uses do_div >> which is an unsigned divide. So negative numbers look like large >> numbers, and it doesn't do sign-extension, so when it divid

Re: [PATCH v2 8/8] MIPS: Alchemy: Remove unneeded cast removing const

2015-05-01 Thread Stephen Boyd
On 04/28, Krzysztof Kozlowski wrote: > Parent names in clock init data is now array of const pointers to const > strings so the cast is not needed. > > Signed-off-by: Krzysztof Kozlowski I can take this through clk-next with an ack from Ralf. -- Qualcomm Innovation Center, Inc. is a member of

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Drokin, Oleg
Hello! On May 1, 2015, at 1:48 PM, Julia Lawall wrote: >>> From: Julia Lawall >>> >>> Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by >>> kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. >> >> Nak: James Simmons >> >> A simple replace will not work. The OBD_

Re: [GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Alex Williamson
On Fri, 2015-05-01 at 11:37 -0700, Linus Torvalds wrote: > On Fri, May 1, 2015 at 10:40 AM, Alex Williamson > wrote: > > > > - Flush signals on interrupted wait to retain polling interval (Alex > > Williamson) > > This cannot *possibly* be right. If I read this patch right, you're > randomly jus

Re: [Linux-nvdimm] [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices

2015-05-01 Thread Dan Williams
On Fri, May 1, 2015 at 11:19 AM, Toshi Kani wrote: > On Fri, 2015-05-01 at 11:22 -0700, Dan Williams wrote: >> On Fri, May 1, 2015 at 10:48 AM, Toshi Kani wrote: >> > On Tue, 2015-04-28 at 14:24 -0400, Dan Williams wrote: >> >> Register the memory devices described in the nfit as libnd 'dimm' >>

Re: [PATCH v2 3/8] clk: tegra: Fix inconsistent indenting

2015-05-01 Thread Stephen Boyd
On 04/28, Krzysztof Kozlowski wrote: > Fix the indentation - spaces used instead of tabs and actually wrong > number of spaces. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/tegra/clk-emc.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) What branch is this

Re: [PATCH] Allow TCP connections to cache SYN packet for userspace inspection

2015-05-01 Thread Eric Dumazet
On Fri, 2015-05-01 at 13:43 -0400, Eric B Munson wrote: > In order to enable policy decisions in userspace, the data contained in > the SYN packet would be useful for tracking or identifying connections. > Only parts of this data are available to userspace after the hand shake > is completed. This

Re: [PATCH 8/11] staging: lustre: obdclass: Use kzalloc and kfree

2015-05-01 Thread Julia Lawall
On Fri, 1 May 2015, walter harms wrote: > hi Julia, > your patch seems fine. > I tried to understand the code and it seems that much of it > can be simplified by using already available functions. > I have added some comments but i am not sure what to make of it. Thanks for the review. Comments

Re: [PATCH 3/3] context_tracking,x86: remove extraneous irq disable & enable from context tracking on syscall entry

2015-05-01 Thread Ingo Molnar
* Rik van Riel wrote: > On 05/01/2015 12:34 PM, Ingo Molnar wrote: > > > > * Rik van Riel wrote: > > > >>> I can understand people running hard-RT workloads not wanting to > >>> see the overhead of a timer tick or a scheduler tick with variable > >>> (and occasionally heavy) work done in IR

Re: [Linux-nvdimm] [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices

2015-05-01 Thread Toshi Kani
On Fri, 2015-05-01 at 11:22 -0700, Dan Williams wrote: > On Fri, May 1, 2015 at 10:48 AM, Toshi Kani wrote: > > On Tue, 2015-04-28 at 14:24 -0400, Dan Williams wrote: > >> Register the memory devices described in the nfit as libnd 'dimm' > >> devices on an nd bus. The kernel assigned device id fo

Re: [GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Linus Torvalds
On Fri, May 1, 2015 at 10:40 AM, Alex Williamson wrote: > > - Flush signals on interrupted wait to retain polling interval (Alex > Williamson) This cannot *possibly* be right. If I read this patch right, you're randomly just getting rid of signals. No way in hell is that correct. "flush_signals

[PATCH 3/3] netconsole: implement extended console support

2015-05-01 Thread Tejun Heo
printk logbuf keeps various metadata and optional key=value dictionary for structured messages, both of which are stripped when messages are handed to regular console drivers. It can be useful to have this metadata and dictionary available to netconsole consumers. This obviously makes logging via

[PATCHSET] netconsole: implement extended console support

2015-05-01 Thread Tejun Heo
This patchset is v2 of netconsole extended console support. v1 was part of "printk, netconsole: implement reliable netconsole" patchset[1]. The printk part is broken off to a separate patchset[2] "printk: implement extended console support" which this patchset is dependant upon. Changes from the

[PATCH 2/3] netconsole: make all dynamic netconsoles share a mutex

2015-05-01 Thread Tejun Heo
Currently, each dynamic netconsole_target uses its own separate mutex to synchronize the configuration operations. This patch replaces the per-netconsole_target mutexes with a single mutex - dynamic_netconsole_mutex. The reduced granularity doesn't hurt anything, the code is minutely simpler and

[PATCH 1/3] netconsole: make netconsole_target->enabled a bool

2015-05-01 Thread Tejun Heo
netconsole uses both bool and int for boolean values. Let's convert nt->enabled to bool for consistency. Signed-off-by: Tejun Heo Cc: David Miller --- drivers/net/netconsole.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/netconsole.c b/driv

Re: [PATCH 8/11] staging: lustre: obdclass: Use kzalloc and kfree

2015-05-01 Thread walter harms
hi Julia, your patch seems fine. I tried to understand the code and it seems that much of it can be simplified by using already available functions. I have added some comments but i am not sure what to make of it. re, wh Am 01.05.2015 17:51, schrieb Julia Lawall: > From: Julia Lawall > > Repl

Re: regression in ktime.h circa 3.16.0-rc5+ breaks lirc irsend, bad commit 166afb64511

2015-05-01 Thread Nicolas Pitre
On Fri, 1 May 2015, John Stultz wrote: > So yea. I see the issue now. The ktime_divns() function uses do_div > which is an unsigned divide. So negative numbers look like large > numbers, and it doesn't do sign-extension, so when it divides we lose > the sign bit. That doesn't stop there. On 32-bi

Re: [PATCH v2 01/11] coresight-etm4x: Adding CoreSight ETM4x driver

2015-05-01 Thread Paul Bolle
Mathieu Poirier schreef op vr 01-05-2015 om 08:39 [-0600]: > On 30 April 2015 at 15:29, Paul Bolle wrote: > > On Wed, 2015-04-29 at 11:16 -0600, Mathieu Poirier wrote: > >> +#include > > > > Is this include needed? > > It is needed for "module_param_named()". I guess that it should suffice to i

Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out

2015-05-01 Thread Shaohua Li
On Fri, May 01, 2015 at 02:07:42PM -0400, Jeff Moyer wrote: > Jeff Moyer writes: > > > Shaohua Li writes: > > > >> block plug callback could sleep, so we introduce a parameter > >> 'from_schedule' and corresponding drivers can use it to destinguish a > >> schedule plug flush or a plug finish. Un

Re: [PATCH RFC 1/2] crypto: add PKE API

2015-05-01 Thread Tadeusz Struk
On 05/01/2015 09:04 AM, David Howells wrote: >> +config CRYPTO_PKE > I would prefer CRYPTO_PKEY and pkey rather than pke generally and algo rather > than alg where possible - this will have more consistency with what we have > now. > > I understand, however, that in core crypto code, 'alg' is used

Re: [patch] ARM: fix module-bound check in setting page attributes

2015-05-01 Thread Laura Abbott
On 3/24/15 9:20 PM, Hillf Danton wrote: It was introduced in commit f2ca09f381a59 (ARM: 8311/1: Don't use is_module_addr in setting page attributes) We have no need to check start twice, but see if end is also in range. Signed-off-by: Hillf Danton --- --- a/arch/arm/mm/pageattr.cWed Mar

Re: [Linux-nvdimm] [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices

2015-05-01 Thread Dan Williams
On Fri, May 1, 2015 at 10:48 AM, Toshi Kani wrote: > On Tue, 2015-04-28 at 14:24 -0400, Dan Williams wrote: >> Register the memory devices described in the nfit as libnd 'dimm' >> devices on an nd bus. The kernel assigned device id for dimms is >> dynamic. If userspace needs a more static identi

Re: [PATCH] x86/fpu: always restore_xinit_state() when !use_eager_cpu()

2015-05-01 Thread Dave Hansen
On 04/27/2015 07:46 AM, Dave Hansen wrote: >> > static inline void restore_init_xstate(void) >> > { >> > if (use_xsave()) >> > xrstor_state(init_xstate_buf, -1); >> > else >> > fxrstor_checking(&init_xstate_buf->i387); >> > } > I'll do some testing of

Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out

2015-05-01 Thread Jeff Moyer
Jeff Moyer writes: > Shaohua Li writes: > >> block plug callback could sleep, so we introduce a parameter >> 'from_schedule' and corresponding drivers can use it to destinguish a >> schedule plug flush or a plug finish. Unfortunately io_schedule_out >> still uses blk_flush_plug(). This causes be

Re: [Linux-nvdimm] [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices

2015-05-01 Thread Toshi Kani
On Tue, 2015-04-28 at 14:24 -0400, Dan Williams wrote: > Register the memory devices described in the nfit as libnd 'dimm' > devices on an nd bus. The kernel assigned device id for dimms is > dynamic. If userspace needs a more static identifier it should consult > a provider-specific attribute.

Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out

2015-05-01 Thread Shaohua Li
On Fri, May 01, 2015 at 07:14:10PM +0200, Christoph Hellwig wrote: > On Thu, Apr 30, 2015 at 10:45:15AM -0700, Shaohua Li wrote: > > long __sched io_schedule_timeout(long timeout) > > { > > - int old_iowait = current->in_iowait; > > struct rq *rq; > > long ret; > > > > current->in

Re: [PATCH 3/3] context_tracking,x86: remove extraneous irq disable & enable from context tracking on syscall entry

2015-05-01 Thread Rik van Riel
On 05/01/2015 12:34 PM, Ingo Molnar wrote: > > * Rik van Riel wrote: > >>> I can understand people running hard-RT workloads not wanting to >>> see the overhead of a timer tick or a scheduler tick with variable >>> (and occasionally heavy) work done in IRQ context, but the jitter >>> caused b

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Greg Kroah-Hartman
On Fri, May 01, 2015 at 05:38:49PM +, Simmons, James A. wrote: > >From: Julia Lawall > > > >Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by > >kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. > > Nak: James Simmons > > A simple replace will not work. The O

Re: [PATCH] watchdog: max63xx_wdt: Constify platform_device_id

2015-05-01 Thread Guenter Roeck
On Sat, May 02, 2015 at 12:36:52AM +0900, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Guenter Roeck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH 2/2] hwmon: sht15: Constify platform_device_id

2015-05-01 Thread Guenter Roeck
On Sat, May 02, 2015 at 12:56:23AM +0900, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. > > Signed-off-by: Krzysztof Kozlowski Applied to -next. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH 1/2] hwmon: max197: Constify platform_device_id

2015-05-01 Thread Guenter Roeck
On Sat, May 02, 2015 at 12:56:22AM +0900, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. > > Signed-off-by: Krzysztof Kozlowski Applied to -next. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH] net: dsa: mv88e6xxx: unregister mv88e6352 driver

2015-05-01 Thread Guenter Roeck
On Fri, May 01, 2015 at 10:43:52AM -0400, Vivien Didelot wrote: > Add the missing unregister for the mv88e6352_switch_driver. > > Signed-off-by: Vivien Didelot Reviewed-by: Guenter Roeck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH 3/3] context_tracking,x86: remove extraneous irq disable & enable from context tracking on syscall entry

2015-05-01 Thread Ingo Molnar
* Rik van Riel wrote: > > I.e. much of what we do today, except that we could skip variable > > work such as the scheduler tick or (unforced) RCU processing like > > the RCU softirq work. > > Any ideas how we could avoid that sampling timer interrupt latency > stacking up when dealing with b

RE: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Simmons, James A.
>From: Julia Lawall > >Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by >kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. Nak: James Simmons A simple replace will not work. The OBD_ALLOC and OBD_FREE functions allocate memory anywhere from one page to 4MB in s

RE: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Julia Lawall
On Fri, 1 May 2015, Simmons, James A. wrote: > >From: Julia Lawall > > > >Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by > >kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. > > Nak: James Simmons > > A simple replace will not work. The OBD_ALLOC and OBD_FREE

Re: [PATCH 3/5] blk-mq: fix plugging in blk_sq_make_request

2015-05-01 Thread Jeff Moyer
Christoph Hellwig writes: >> -if (use_plug && !blk_queue_nomerges(q) && >> +if (likely(!is_flush_fua) && !blk_queue_nomerges(q) && > > Please don't sprinkle likely annotations for no go reason. Especially > on metadata write heavy workloads (e.g. an NFS server) it might be very > likely.

[PATCH] Allow TCP connections to cache SYN packet for userspace inspection

2015-05-01 Thread Eric B Munson
In order to enable policy decisions in userspace, the data contained in the SYN packet would be useful for tracking or identifying connections. Only parts of this data are available to userspace after the hand shake is completed. This patch exposes a new setsockopt() option that will, when used wi

Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out

2015-05-01 Thread Jeff Moyer
Shaohua Li writes: > block plug callback could sleep, so we introduce a parameter > 'from_schedule' and corresponding drivers can use it to destinguish a > schedule plug flush or a plug finish. Unfortunately io_schedule_out > still uses blk_flush_plug(). This causes below output (Note, I added a

[GIT PULL] VFIO fixes for v4.1-rc2

2015-05-01 Thread Alex Williamson
Hi Linus, The following changes since commit b787f68c36d49bb1d9236f403813641efa74a031: Linux 4.1-rc1 (2015-04-26 17:59:10 -0700) are available in the git repository at: git://github.com/awilliam/linux-vfio.git tags/vfio-v4.1-rc2 for you to fetch changes up to 82a0eaab980a3af92d46e93eaf299d

Re: [PATCH v2 2/5] sched, numa: Document usages of mm->numa_scan_seq

2015-05-01 Thread Jason Low
On Fri, 2015-05-01 at 08:21 -0700, Paul E. McKenney wrote: > On Thu, Apr 30, 2015 at 02:13:07PM -0700, Jason Low wrote: > > On Thu, 2015-04-30 at 14:42 -0400, Waiman Long wrote: > > > > > I do have a question of what kind of tearing you are talking about. Do > > > you mean the tearing due to mm b

Re: [PATCH 4/4] ARM: net fix emit_udiv() for BPF_ALU | BPF_DIV | BPF_K intruction.

2015-05-01 Thread Russell King - ARM Linux
On Wed, Apr 29, 2015 at 03:37:37PM +0200, Nicolas Schichan wrote: > In that case, emit_udiv() will be called with rn == ARM_R0 (r_scratch) > and loading rm first into ARM_R0 will result in jit_udiv() function > being called the same dividend and divisor. Fix that by loading rn > first into ARM_R1 a

Re: [PATCH RFC 0/2] crypto: Introduce Public Key Encryption API

2015-05-01 Thread Tadeusz Struk
On 05/01/2015 01:47 AM, Jean Delvare wrote: > I have nothing to do with this, please drop me from Cc. Sorry, your name was reported by scripts/get_maintainer.pl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More maj

Re: [PATCH RFC 1/2] crypto: add PKE API

2015-05-01 Thread Tadeusz Struk
Hi Stephan, On 05/01/2015 12:24 AM, Stephan Mueller wrote: >> +struct public_key; >> >+struct public_key_signature; > Wouldn't it make sense to move the struct definitions here and have them > documented? I'm not sure if they belong here. I think we can add some documentation without moving them.

Re: regression in ktime.h circa 3.16.0-rc5+ breaks lirc irsend, bad commit 166afb64511

2015-05-01 Thread John Stultz
On Fri, May 1, 2015 at 3:02 AM, Trevor Cordes wrote: > May 1 04:46:12 piles kernel: [ 356.838029] JDB: ktime_to_us: -20157485 -> > divns 18446744073689394 != old method: -20158 > > The last 2-3 or 3 groups of output I could produce on demand by stopping > mythbackend and running: > systemctl r

Re: [PATCH] hwspinlock: qcom: Lock #7 is special lock, uses dynamic proc_id

2015-05-01 Thread Lina Iyer
On Fri, May 01 2015 at 11:27 -0600, Jeffrey Hugo wrote: On 5/1/2015 11:06 AM, Lina Iyer wrote: diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c index 93b62e0..043c62c 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++ b/drivers/hwspinlock/qcom_hwspinl

<    1   2   3   4   5   6   7   >