[PATCH 2/2] pstore: Cleanup pstore_dump()

The code is duplicate between compression is enabled or not. Signed-off-by: Namhyung Kim --- fs/pstore/platform.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index

[PATCH 2/2] pstore: Cleanup pstore_dump()

The code is duplicate between compression is enabled or not. Signed-off-by: Namhyung Kim --- fs/pstore/platform.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 04a0164a2066..277730f6c462

Re: [PATCH 00/14] staging: comedi: daqboard2000: checkpatch clean-ups

On 17/05/16 18:46, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: This series of patches to the daqboard2000 driver is mostly to fix the checkpatch.pl warnings. There is one warning remaining about one of the `udelay` calls with a parameter of 10 microseconds, but I

[PATCH 1/2] pstore: Enable compression on normal path (again)

The commit f0e2efcfd2717 ("pstore: do not use message compression without lock") added a check to 'is_locked' to avoid breakage in concurrent accesses. But it has a side-effect of disabling compression on normal path since 'is_locked' variable is not set. As normal path always takes the lock, it

Re: [PATCH 00/14] staging: comedi: daqboard2000: checkpatch clean-ups

On 17/05/16 18:46, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: This series of patches to the daqboard2000 driver is mostly to fix the checkpatch.pl warnings. There is one warning remaining about one of the `udelay` calls with a parameter of 10 microseconds, but I

[PATCH 1/2] pstore: Enable compression on normal path (again)

The commit f0e2efcfd2717 ("pstore: do not use message compression without lock") added a check to 'is_locked' to avoid breakage in concurrent accesses. But it has a side-effect of disabling compression on normal path since 'is_locked' variable is not set. As normal path always takes the lock, it

Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations

On 05/13/2016 02:05 PM, Michal Hocko wrote: > On Fri 13-05-16 10:23:31, Vlastimil Babka wrote: >> On 05/12/2016 06:20 PM, Michal Hocko wrote: >>> On Tue 10-05-16 09:35:56, Vlastimil Babka wrote: >>> [...] diff --git a/include/linux/gfp.h b/include/linux/gfp.h index

Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations

On 05/13/2016 02:05 PM, Michal Hocko wrote: > On Fri 13-05-16 10:23:31, Vlastimil Babka wrote: >> On 05/12/2016 06:20 PM, Michal Hocko wrote: >>> On Tue 10-05-16 09:35:56, Vlastimil Babka wrote: >>> [...] diff --git a/include/linux/gfp.h b/include/linux/gfp.h index

Re: [PATCH net-next] tuntap: introduce tx skb ring

On Wed, 18 May 2016 18:23:48 +0800 Jason Wang wrote: > > > > > > > Maybe Steven Rostedt have an even better ring queue implementation > > already avail in the kernel? > > > > You mean ring buffer in tracing? Not sure, but it looks rather complex > at first glance. Yes

Re: [PATCH net-next] tuntap: introduce tx skb ring

On Wed, 18 May 2016 18:23:48 +0800 Jason Wang wrote: > > > > > > > Maybe Steven Rostedt have an even better ring queue implementation > > already avail in the kernel? > > > > You mean ring buffer in tracing? Not sure, but it looks rather complex > at first glance. Yes it is, and I'm not

Re: [Patch]cpuidle: Save current cpu as local variable instead of calling smp_processor_id() in loop

Much better; but the below does not in fact apply. > --- > > diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c > index 1214f0a..82698e5 100644 > --- a/kernel/sched/idle.c > +++ b/kernel/sched/idle.c > @@ -185,6 +185,8 @@ exit_idle: > */ > static void cpu_idle_loop(void) > { > + int

Re: [Patch]cpuidle: Save current cpu as local variable instead of calling smp_processor_id() in loop

Much better; but the below does not in fact apply. > --- > > diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c > index 1214f0a..82698e5 100644 > --- a/kernel/sched/idle.c > +++ b/kernel/sched/idle.c > @@ -185,6 +185,8 @@ exit_idle: > */ > static void cpu_idle_loop(void) > { > + int

[PATCH] net: af_unix: protect ->sk_shutdown change with lock_sock()

->sk_shutdown bits share one bitfield with some other bits in sock struct, such as ->sk_no_check_[r,t]x, ->sk_userlocks ... sock_setsockopt() may write to these bits, while holding the socket lock. In case of AF_UNIX sockets, we change ->sk_shutdown bits while holding only unix_state_lock(). So

[PATCH] net: af_unix: protect ->sk_shutdown change with lock_sock()

->sk_shutdown bits share one bitfield with some other bits in sock struct, such as ->sk_no_check_[r,t]x, ->sk_userlocks ... sock_setsockopt() may write to these bits, while holding the socket lock. In case of AF_UNIX sockets, we change ->sk_shutdown bits while holding only unix_state_lock(). So

general protection fault (btrfs_real_readdir)

I'm running the latest Linus git tree and the parallel filesystem directory handling update seems to cause the following issue: general protection fault: [#1] SMP CPU: 0 PID: 24801 Comm: ld Not tainted 4.6.0-03623-g0b7962a6c4a3-dirty #118 Hardware name: System manufacturer System Product

general protection fault (btrfs_real_readdir)

I'm running the latest Linus git tree and the parallel filesystem directory handling update seems to cause the following issue: general protection fault: [#1] SMP CPU: 0 PID: 24801 Comm: ld Not tainted 4.6.0-03623-g0b7962a6c4a3-dirty #118 Hardware name: System manufacturer System Product

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

On 18 May 2016 at 19:21, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> @@ -1748,15 +1754,25 @@ static int dwc3_gadget_start(struct usb_gadget >> *g, >> * even though host mode might be active. Don't actually perform >>

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

On 18 May 2016 at 19:21, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> @@ -1748,15 +1754,25 @@ static int dwc3_gadget_start(struct usb_gadget >> *g, >> * even though host mode might be active. Don't actually perform >> * device-specific initialization

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

Hi, Baolin Wang writes: > @@ -1748,15 +1754,25 @@ static int dwc3_gadget_start(struct usb_gadget *g, > * even though host mode might be active. Don't actually perform > * device-specific initialization until device mode is activated. >

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

Hi, Baolin Wang writes: > @@ -1748,15 +1754,25 @@ static int dwc3_gadget_start(struct usb_gadget *g, > * even though host mode might be active. Don't actually perform > * device-specific initialization until device mode is activated. > */ > > +

Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

On Tue, May 17, 2016 at 10:05:26PM +0300, Yury Norov wrote: > On Mon, May 16, 2016 at 06:06:05PM +0100, Catalin Marinas wrote: > > On Sat, May 14, 2016 at 06:03:52PM +0300, Yury Norov wrote: > > > +SYSCALL_DEFINE6(mmap2, unsigned long, addr, unsigned long, len, > > > + unsigned long, prot,

Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

On Tue, May 17, 2016 at 10:05:26PM +0300, Yury Norov wrote: > On Mon, May 16, 2016 at 06:06:05PM +0100, Catalin Marinas wrote: > > On Sat, May 14, 2016 at 06:03:52PM +0300, Yury Norov wrote: > > > +SYSCALL_DEFINE6(mmap2, unsigned long, addr, unsigned long, len, > > > + unsigned long, prot,

[GIT PULL] first round of SCSI updates for the 4.6+ merge window

This patch includes the usual quota of driver updates (bnx2fc, mp3sas, hpsa, ncr5380, lpfc, hisi_sas, snic, aacraid, megaraid_sas) there's also a multiqueue update for scsi_debug, assorted bug fixes and a few other minor updates (refactor of scsi_sg_pools into generic code, alua and VPD updates,

[GIT PULL] first round of SCSI updates for the 4.6+ merge window

This patch includes the usual quota of driver updates (bnx2fc, mp3sas, hpsa, ncr5380, lpfc, hisi_sas, snic, aacraid, megaraid_sas) there's also a multiqueue update for scsi_debug, assorted bug fixes and a few other minor updates (refactor of scsi_sg_pools into generic code, alua and VPD updates,

[PATCH V2] drm/tegra: Fix crash caused by reference count imbalance

dia.com> --- V2 changes: - Updated to next-20160518 - Replaced open coding of call to drm_connector_reference() with __drm_atomic_helper_connector_duplicate_state() per Daniel's feedback. drivers/gpu/drm/tegra/dsi.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --g

[PATCH V2] drm/tegra: Fix crash caused by reference count imbalance

ector_destroy_state() in order to put the reference for the connector. Finally, add a warning if allocating memory for the state information fails in tegra_dsi_connector_reset(). Fixes: d2307dea14a4 ("drm/atomic: use connector references (v3)") Signed-off-by: Jon Hunter --- V2 changes: -

Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2

On 05/18/16 11:45, Kishon Vijay Abraham I wrote: > +static int omap_hsmmc_dma_init(struct omap_hsmmc_host *host) > +{ > + dma_cap_mask_t mask; > + unsigned int tx_req, rx_req; > + struct resource *res; > + struct platform_device *pdev = to_platform_device(host->dev); > + > +

Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2

On 05/18/16 11:45, Kishon Vijay Abraham I wrote: > +static int omap_hsmmc_dma_init(struct omap_hsmmc_host *host) > +{ > + dma_cap_mask_t mask; > + unsigned int tx_req, rx_req; > + struct resource *res; > + struct platform_device *pdev = to_platform_device(host->dev); > + > +

Re: [PATCH] devfreq: fix double call put_device

Hi Cai, On 2016년 05월 14일 15:28, Caizhiyong wrote: > From: Cai Zhiyong > Date: Sat, 14 May 2016 14:13:30 +0800 > Subject: [PATCH] devfreq: fix double call put_device The patch description don't need to include the 'Date/Subject'. You need to delete them. > > 1295 */ >

Re: [PATCH] devfreq: fix double call put_device

Hi Cai, On 2016년 05월 14일 15:28, Caizhiyong wrote: > From: Cai Zhiyong > Date: Sat, 14 May 2016 14:13:30 +0800 > Subject: [PATCH] devfreq: fix double call put_device The patch description don't need to include the 'Date/Subject'. You need to delete them. > > 1295 */ > 1296 void

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

Hi, On 18 May 2016 at 18:22, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: @@ -1485,16 +1490,11 @@ static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend) { u32 reg;

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

Hi, On 18 May 2016 at 18:22, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: @@ -1485,16 +1490,11 @@ static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend) { u32 reg; u32 timeout = 500, i;

Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner field

On Tue, May 17, 2016 at 12:46:07PM -0700, Paul E. McKenney wrote: > Actually, if you show a case where this makes a visible system-wide > difference, you could create a set of primitives for #1 below. Have > a compiler version check, and if it is an old compiler, map them to > READ_ONCE() and

Re: [PATCH v2] locking/rwsem: Add reader-owned state to the owner field

On Tue, May 17, 2016 at 12:46:07PM -0700, Paul E. McKenney wrote: > Actually, if you show a case where this makes a visible system-wide > difference, you could create a set of primitives for #1 below. Have > a compiler version check, and if it is an old compiler, map them to > READ_ONCE() and

Re: [PATCH net-next] tuntap: introduce tx skb ring

On Wed, May 18, 2016 at 06:42:10PM +0800, Jason Wang wrote: > > > On 2016年05月18日 17:55, Michael S. Tsirkin wrote: > >On Wed, May 18, 2016 at 11:21:29AM +0200, Jesper Dangaard Brouer wrote: > >>On Wed, 18 May 2016 11:21:59 +0300 > >>"Michael S. Tsirkin" wrote: > >> > >>>On Wed,

Re: [PATCH net-next] tuntap: introduce tx skb ring

On Wed, May 18, 2016 at 06:42:10PM +0800, Jason Wang wrote: > > > On 2016年05月18日 17:55, Michael S. Tsirkin wrote: > >On Wed, May 18, 2016 at 11:21:29AM +0200, Jesper Dangaard Brouer wrote: > >>On Wed, 18 May 2016 11:21:59 +0300 > >>"Michael S. Tsirkin" wrote: > >> > >>>On Wed, May 18, 2016 at

[PATCH net] tuntap: correctly wake up process during uninit

We used to check dev->reg_state against NETREG_REGISTERED after each time we are woke up. But after commit 9e641bdcfa4e ("net-tun: restructure tun_do_read for better sleep/wakeup efficiency"), it uses skb_recv_datagram() which does not check dev->reg_state. This will result if we delete a tun/tap

[PATCH net] tuntap: correctly wake up process during uninit

We used to check dev->reg_state against NETREG_REGISTERED after each time we are woke up. But after commit 9e641bdcfa4e ("net-tun: restructure tun_do_read for better sleep/wakeup efficiency"), it uses skb_recv_datagram() which does not check dev->reg_state. This will result if we delete a tun/tap

[PATCH 6/9] irqchip/ls1x-cpu: Move the CPU IRQ driver from arch/mips/loongson32/common/

Signed-off-by: Chunbo Cui Signed-off-by: Binbin Zhou Signed-off-by: Huacai Chen --- arch/mips/include/asm/irq_cpu.h | 1 + arch/mips/loongson32/common/irq.c | 128 +--- drivers/irqchip/Makefile | 1 +

[PATCH 6/9] irqchip/ls1x-cpu: Move the CPU IRQ driver from arch/mips/loongson32/common/

Signed-off-by: Chunbo Cui Signed-off-by: Binbin Zhou Signed-off-by: Huacai Chen --- arch/mips/include/asm/irq_cpu.h | 1 + arch/mips/loongson32/common/irq.c | 128 +--- drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-ls1x-cpu.c| 242

Re: [PATCH 1/6] statx: Add a system call to make enhanced file info available

Arnd Bergmann wrote: > I'm trying to understand what that means for the 64-bit time_t syscalls. > > The patch series I did last year had a replacement 'sys_newfstatat()' > syscall but IIRC no other stat variant, the idea being that we would > only need to provide this one to the

Re: [PATCH 1/6] statx: Add a system call to make enhanced file info available

Arnd Bergmann wrote: > I'm trying to understand what that means for the 64-bit time_t syscalls. > > The patch series I did last year had a replacement 'sys_newfstatat()' > syscall but IIRC no other stat variant, the idea being that we would > only need to provide this one to the libc and have

Re: [PATCH] kvm-pr: manage illegal instructions

On 18.05.2016 12:18, Thomas Huth wrote: > On 17.05.2016 19:49, Laurent Vivier wrote: >> >> >> On 17/05/2016 10:37, Alexander Graf wrote: >>> On 05/17/2016 10:35 AM, Laurent Vivier wrote: On 12/05/2016 16:23, Laurent Vivier wrote: > > On 12/05/2016 11:27, Alexander Graf wrote:

Re: [PATCH] kvm-pr: manage illegal instructions

On 18.05.2016 12:18, Thomas Huth wrote: > On 17.05.2016 19:49, Laurent Vivier wrote: >> >> >> On 17/05/2016 10:37, Alexander Graf wrote: >>> On 05/17/2016 10:35 AM, Laurent Vivier wrote: On 12/05/2016 16:23, Laurent Vivier wrote: > > On 12/05/2016 11:27, Alexander Graf wrote:

Re: [PATCH] arm64: Allow for different DMA and CPU bus offsets

On Wednesday 18 May 2016 11:33:01 Alexander Graf wrote: > diff --git a/arch/arm64/include/asm/dma-mapping.h > b/arch/arm64/include/asm/dma-mapping.h > index ba437f0..67bf8e1 100644 > --- a/arch/arm64/include/asm/dma-mapping.h > +++ b/arch/arm64/include/asm/dma-mapping.h > @@ -66,12 +66,16 @@

Re: [PATCH] arm64: Allow for different DMA and CPU bus offsets

On Wednesday 18 May 2016 11:33:01 Alexander Graf wrote: > diff --git a/arch/arm64/include/asm/dma-mapping.h > b/arch/arm64/include/asm/dma-mapping.h > index ba437f0..67bf8e1 100644 > --- a/arch/arm64/include/asm/dma-mapping.h > +++ b/arch/arm64/include/asm/dma-mapping.h > @@ -66,12 +66,16 @@

Re: [f2fs-dev] [RFC] f2fs: fix a race condition between evict & gc

On 2016/5/18 1:23, Jaegeuk Kim wrote: On Tue, May 17, 2016 at 11:00:53AM +0800, Hou Pengyang wrote: On 2016/5/16 23:10, Chao Yu wrote: Hi chao, Hi Pengyang, On 2016/5/16 18:40, Hou Pengyang wrote: When collecting data segment(gc_data_segment), there is a race condition between evict and

Re: [PATCH v4 0/5] [PATCH v3 0/4] locking/rwsem: Add reader-owned state to the owner field

OK, I frobbed all 3 rwsem patch sets together and hopefully have something that 'works' ;-) Please have a look at the result here: https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/log/?h=locking/core

Re: [f2fs-dev] [RFC] f2fs: fix a race condition between evict & gc

On 2016/5/18 1:23, Jaegeuk Kim wrote: On Tue, May 17, 2016 at 11:00:53AM +0800, Hou Pengyang wrote: On 2016/5/16 23:10, Chao Yu wrote: Hi chao, Hi Pengyang, On 2016/5/16 18:40, Hou Pengyang wrote: When collecting data segment(gc_data_segment), there is a race condition between evict and

Re: [PATCH v4 0/5] [PATCH v3 0/4] locking/rwsem: Add reader-owned state to the owner field

OK, I frobbed all 3 rwsem patch sets together and hopefully have something that 'works' ;-) Please have a look at the result here: https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/log/?h=locking/core

Re: [GIT] Networking

Hi Emmanuel, Linus, On Wed, 2016-05-18 at 06:37 +0300, Emmanuel Grumbach wrote: > On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds > wrote: > > > > On Tue, May 17, 2016 at 12:11 PM, David Miller > > wrote: > > > > > > > > > Highlights: > >

Re: [GIT] Networking

Hi Emmanuel, Linus, On Wed, 2016-05-18 at 06:37 +0300, Emmanuel Grumbach wrote: > On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds > wrote: > > > > On Tue, May 17, 2016 at 12:11 PM, David Miller > > wrote: > > > > > > > > > Highlights: > > Lowlights: > > > >  1) the iwlwifi driver seems to

Re: [PATCH v8 2/4] GCC plugin infrastructure

On Tue, 17 May 2016 16:28:05 +0200 Michal Marek wrote: > Dne 13.5.2016 v 01:57 Emese Revfy napsal(a): > > --- /dev/null > > +++ b/scripts/Makefile.gcc-plugins > > @@ -0,0 +1,21 @@ > > +ifdef CONFIG_GCC_PLUGINS > > + __PLUGINCC := $(call cc-ifversion, -ge, 0408, $(HOSTCXX),

Re: [PATCH v8 2/4] GCC plugin infrastructure

On Tue, 17 May 2016 16:28:05 +0200 Michal Marek wrote: > Dne 13.5.2016 v 01:57 Emese Revfy napsal(a): > > --- /dev/null > > +++ b/scripts/Makefile.gcc-plugins > > @@ -0,0 +1,21 @@ > > +ifdef CONFIG_GCC_PLUGINS > > + __PLUGINCC := $(call cc-ifversion, -ge, 0408, $(HOSTCXX), $(HOSTCC)) > > +

Re: [Xen-devel] [GIT PULL] EFI ARM Xen support

On Wed, 18 May, at 12:46:38PM, Ingo Molnar wrote: > > I have no particular objections, since this seems to be Xen-next merged to > the EFI > tree that is already upstream, plus this single commit on top of t: > > 11ee5491e5ff Xen: EFI: Parse DT parameters for Xen specific UEFI > > Which, if

Re: [Xen-devel] [GIT PULL] EFI ARM Xen support

On Wed, 18 May, at 12:46:38PM, Ingo Molnar wrote: > > I have no particular objections, since this seems to be Xen-next merged to > the EFI > tree that is already upstream, plus this single commit on top of t: > > 11ee5491e5ff Xen: EFI: Parse DT parameters for Xen specific UEFI > > Which, if

Re: [Xen-devel] [GIT PULL] EFI ARM Xen support

* Stefano Stabellini wrote: > On Tue, 17 May 2016, David Vrabel wrote: > > On 17/05/16 11:12, Stefano Stabellini wrote: > > > On Sat, 14 May 2016, Matt Fleming wrote: > > >> Folks, > > >> > > >> Please pull the following branch which contains support for Xen on ARM > >

Re: [Xen-devel] [GIT PULL] EFI ARM Xen support

* Stefano Stabellini wrote: > On Tue, 17 May 2016, David Vrabel wrote: > > On 17/05/16 11:12, Stefano Stabellini wrote: > > > On Sat, 14 May 2016, Matt Fleming wrote: > > >> Folks, > > >> > > >> Please pull the following branch which contains support for Xen on ARM > > >> EFI platforms. > > >>

Re: [kernel-hardening] [PATCH v8 3/4] Add Cyclomatic complexity GCC plugin

On Wed, 18 May 2016 18:25:00 +1000 Andrew Donnellan wrote: > On 13/05/16 09:58, Emese Revfy wrote: > > Add a very simple plugin to demonstrate the GCC plugin infrastructure. This > > GCC > > plugin computes the cyclomatic complexity of each function. > > ... > >

Re: [kernel-hardening] [PATCH v8 3/4] Add Cyclomatic complexity GCC plugin

On Wed, 18 May 2016 18:25:00 +1000 Andrew Donnellan wrote: > On 13/05/16 09:58, Emese Revfy wrote: > > Add a very simple plugin to demonstrate the GCC plugin infrastructure. This > > GCC > > plugin computes the cyclomatic complexity of each function. > > ... > > > +config

Re: [PATCH net-next] tuntap: introduce tx skb ring

On 2016年05月18日 17:55, Michael S. Tsirkin wrote: On Wed, May 18, 2016 at 11:21:29AM +0200, Jesper Dangaard Brouer wrote: On Wed, 18 May 2016 11:21:59 +0300 "Michael S. Tsirkin" wrote: On Wed, May 18, 2016 at 10:16:31AM +0200, Jesper Dangaard Brouer wrote: On Tue, 17 May

Re: [PATCH net-next] tuntap: introduce tx skb ring

On 2016年05月18日 17:55, Michael S. Tsirkin wrote: On Wed, May 18, 2016 at 11:21:29AM +0200, Jesper Dangaard Brouer wrote: On Wed, 18 May 2016 11:21:59 +0300 "Michael S. Tsirkin" wrote: On Wed, May 18, 2016 at 10:16:31AM +0200, Jesper Dangaard Brouer wrote: On Tue, 17 May 2016 09:38:37 +0800

Re: [PATCH] net: af_unix: protect ->sk_shutdown change with lock_sock()

On 18.05.2016 12:14, Andrey Ryabinin wrote: > ->sk_shutdown bits share one bitfield with some other bits in sock struct, > such as ->sk_no_check_[r,t]x, ->sk_userlocks ... > sock_setsockopt() may write to these bits, while holding the socket lock. > In case of AF_UNIX sockets, we change

Re: [PATCH -v2] x86/hweight: Get rid of the special calling convention

On Thu, May 12, 2016 at 03:09:32PM +0200, Borislav Petkov wrote: > I wanted to have gcc use %[w] and this way not hardcode the reg but the > ABI kinda hardcodes it to rAX. And you're right about tracing funkyness > adding glue so we're probably better off doing the .S thing directly and > making

Re: [PATCH] net: af_unix: protect ->sk_shutdown change with lock_sock()

On 18.05.2016 12:14, Andrey Ryabinin wrote: > ->sk_shutdown bits share one bitfield with some other bits in sock struct, > such as ->sk_no_check_[r,t]x, ->sk_userlocks ... > sock_setsockopt() may write to these bits, while holding the socket lock. > In case of AF_UNIX sockets, we change

Re: [PATCH -v2] x86/hweight: Get rid of the special calling convention

On Thu, May 12, 2016 at 03:09:32PM +0200, Borislav Petkov wrote: > I wanted to have gcc use %[w] and this way not hardcode the reg but the > ABI kinda hardcodes it to rAX. And you're right about tracing funkyness > adding glue so we're probably better off doing the .S thing directly and > making

Re: [PATCH] Let chip-driver set brightness if, software blink not used.

On 18/05/16 10:03, Jacek Anaszewski wrote: > Hi Tony, > > Thanks for the patch. I'd like to improve the commit message. > > Please let me know if you have any suggestions related to the below: > > led: core: Fix brightness setting upon hardware blinking enabled > > Commit 76931edd54

Re: [PATCH] Let chip-driver set brightness if, software blink not used.

On 18/05/16 10:03, Jacek Anaszewski wrote: > Hi Tony, > > Thanks for the patch. I'd like to improve the commit message. > > Please let me know if you have any suggestions related to the below: > > led: core: Fix brightness setting upon hardware blinking enabled > > Commit 76931edd54

Re: [PATCH v4 3/5] locking/rwsem: Don't wake up one's own task

On Tue, May 17, 2016 at 09:26:21PM -0400, Waiman Long wrote: > As rwsem_down_read_failed() will queue itself and potentially call > __rwsem_do_wake(sem, RWSEM_WAKE_ANY), it is possible that a reader > will try to wake up its own task. This patch adds a check to make > sure that this won't happen.

Re: [PATCH v4 3/5] locking/rwsem: Don't wake up one's own task

On Tue, May 17, 2016 at 09:26:21PM -0400, Waiman Long wrote: > As rwsem_down_read_failed() will queue itself and potentially call > __rwsem_do_wake(sem, RWSEM_WAKE_ANY), it is possible that a reader > will try to wake up its own task. This patch adds a check to make > sure that this won't happen.

Re: [PATCH 06/14] staging: comedi: daqboard2000: rename register offset macros

On 17/05/16 18:27, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: Rename the macros defining register offsets to avoid CamelCase, and to use namespace associated with the driver. Signed-off-by: Ian Abbott --- Other CamelCase issues in this patch

Re: [PATCH 14/14] staging: comedi: daqboard2000: prefer usleep_range()

On 17/05/16 18:42, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: The checkpatch.pl warns about two `udelay(x)` calls, one of 100 microseconds, and one of 10 microseconds. The 100 microseconds one is used when waiting for FPGA to become ready to accept firmware, and

Re: [PATCH 06/14] staging: comedi: daqboard2000: rename register offset macros

On 17/05/16 18:27, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: Rename the macros defining register offsets to avoid CamelCase, and to use namespace associated with the driver. Signed-off-by: Ian Abbott --- Other CamelCase issues in this patch will be dealt with

Re: [PATCH 14/14] staging: comedi: daqboard2000: prefer usleep_range()

On 17/05/16 18:42, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: The checkpatch.pl warns about two `udelay(x)` calls, one of 100 microseconds, and one of 10 microseconds. The 100 microseconds one is used when waiting for FPGA to become ready to accept firmware, and

Re: [PATCH] drm/tegra: Fix crash caused by reference count imbalance

On Wed, May 18, 2016 at 10:18:52AM +0100, Jon Hunter wrote: > > On 17/05/16 18:36, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 7:29 PM, Jon Hunter wrote: > @@ -764,6 +769,9 @@ tegra_dsi_connector_duplicate_state(struct > drm_connector *connector) >

Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure

> I've done some basic sanity testing on powerpc with the cyclomatic > complexity plugin (with LE native + cross-compilers) and it seems to > work with the patch below. > > Signed-off-by: Andrew Donnellan > > diff --git a/arch/powerpc/Kconfig

Re: [PATCH] drm/tegra: Fix crash caused by reference count imbalance

On Wed, May 18, 2016 at 10:18:52AM +0100, Jon Hunter wrote: > > On 17/05/16 18:36, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 7:29 PM, Jon Hunter wrote: > @@ -764,6 +769,9 @@ tegra_dsi_connector_duplicate_state(struct > drm_connector *connector) > if (!copy) >

Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure

> I've done some basic sanity testing on powerpc with the cyclomatic > complexity plugin (with LE native + cross-compilers) and it seems to > work with the patch below. > > Signed-off-by: Andrew Donnellan > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index a18a0dc..0cfed5b

Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2

On 05/18/16 11:45, Kishon Vijay Abraham I wrote: > omap hsmmc host controller has ADMA2 feature. Enable it here > for better read and write throughput. Add a new dt binding > "ti,use_adma" to enable ADMA2. > > Signed-off-by: Kishon Vijay Abraham I > --- >

Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2

On 05/18/16 11:45, Kishon Vijay Abraham I wrote: > omap hsmmc host controller has ADMA2 feature. Enable it here > for better read and write throughput. Add a new dt binding > "ti,use_adma" to enable ADMA2. > > Signed-off-by: Kishon Vijay Abraham I > --- >

Re: [PATCH 05/14] staging: comedi: daqboard2000: rename serial EEPROM register macros

On 17/05/16 18:22, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: Rename the macros defining values for the Serial EEPROM Control Register to avoid CamelCase. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/daqboard2000.c | 26

Re: [PATCH 05/14] staging: comedi: daqboard2000: rename serial EEPROM register macros

On 17/05/16 18:22, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: Rename the macros defining values for the Serial EEPROM Control Register to avoid CamelCase. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/daqboard2000.c | 26

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

Hi, Baolin Wang writes: >>> @@ -1485,16 +1490,11 @@ static int dwc3_gadget_run_stop(struct dwc3 >>> *dwc, int is_on, int suspend) >>> { >>> u32 reg; >>> u32 timeout = 500, i; >>> >>> + if

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

Hi, Baolin Wang writes: >>> @@ -1485,16 +1490,11 @@ static int dwc3_gadget_run_stop(struct dwc3 >>> *dwc, int is_on, int suspend) >>> { >>> u32 reg; >>> u32 timeout = 500, i; >>> >>> + if (pm_runtime_suspended(dwc->dev)) >>> +

Re: [PATCH net-next] tuntap: introduce tx skb ring

On 2016年05月18日 16:13, Jesper Dangaard Brouer wrote: On Mon, 16 May 2016 15:51:48 +0800 Jason Wang wrote: On 2016年05月16日 11:56, Eric Dumazet wrote: On Mon, 2016-05-16 at 09:17 +0800, Jason Wang wrote: We used to queue tx packets in sk_receive_queue, this is less

Re: [PATCH net-next] tuntap: introduce tx skb ring

On 2016年05月18日 16:13, Jesper Dangaard Brouer wrote: On Mon, 16 May 2016 15:51:48 +0800 Jason Wang wrote: On 2016年05月16日 11:56, Eric Dumazet wrote: On Mon, 2016-05-16 at 09:17 +0800, Jason Wang wrote: We used to queue tx packets in sk_receive_queue, this is less efficient since it requires

Re: UBSAN whinge in ihci-hub.c

On Wed, 2016-05-18 at 12:16 +0300, Andrey Ryabinin wrote: > 2016-05-18 11:18 GMT+03:00 Oliver Neukum : > > On Wed, 2016-05-18 at 10:40 +0300, Andrey Ryabinin wrote: > >> 2016-05-18 1:16 GMT+03:00 Greg Kroah-Hartman : > >> > On Tue, May 17, 2016 at

Re: UBSAN whinge in ihci-hub.c

On Wed, 2016-05-18 at 12:16 +0300, Andrey Ryabinin wrote: > 2016-05-18 11:18 GMT+03:00 Oliver Neukum : > > On Wed, 2016-05-18 at 10:40 +0300, Andrey Ryabinin wrote: > >> 2016-05-18 1:16 GMT+03:00 Greg Kroah-Hartman : > >> > On Tue, May 17, 2016 at 05:52:40PM -0400, Valdis Kletnieks wrote: > >> >>

Re: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code

On 17/05/16 18:14, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: Remove some commented out code. Some of it uses constructs that don't exist in the driver, and probably come from the source code for the MS Windows driver. Signed-off-by: Ian Abbott

Re: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code

On 17/05/16 18:14, Hartley Sweeten wrote: On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: Remove some commented out code. Some of it uses constructs that don't exist in the driver, and probably come from the source code for the MS Windows driver. Signed-off-by: Ian Abbott ---

Re: [PATCH] kvm-pr: manage illegal instructions

On 17.05.2016 19:49, Laurent Vivier wrote: > > > On 17/05/2016 10:37, Alexander Graf wrote: >> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >>> >>> On 12/05/2016 16:23, Laurent Vivier wrote: On 12/05/2016 11:27, Alexander Graf wrote: > On 05/12/2016 11:10 AM, Laurent Vivier wrote:

Re: [PATCH v1] mm: bad_page() checks bad_flags instead of page->flags for hwpoison page

On Wed, May 18, 2016 at 10:52:51AM +0100, Mel Gorman wrote: > On Wed, May 18, 2016 at 11:31:07AM +0200, Vlastimil Babka wrote: > > On 05/18/2016 11:21 AM, Mel Gorman wrote: > > >On Tue, May 17, 2016 at 04:42:55PM +0900, Naoya Horiguchi wrote: > > >>There's a race window between checking

Re: [PATCH] kvm-pr: manage illegal instructions

On 17.05.2016 19:49, Laurent Vivier wrote: > > > On 17/05/2016 10:37, Alexander Graf wrote: >> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >>> >>> On 12/05/2016 16:23, Laurent Vivier wrote: On 12/05/2016 11:27, Alexander Graf wrote: > On 05/12/2016 11:10 AM, Laurent Vivier wrote:

Re: [PATCH v1] mm: bad_page() checks bad_flags instead of page->flags for hwpoison page

On Wed, May 18, 2016 at 10:52:51AM +0100, Mel Gorman wrote: > On Wed, May 18, 2016 at 11:31:07AM +0200, Vlastimil Babka wrote: > > On 05/18/2016 11:21 AM, Mel Gorman wrote: > > >On Tue, May 17, 2016 at 04:42:55PM +0900, Naoya Horiguchi wrote: > > >>There's a race window between checking

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

On 18 May 2016 at 18:12, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: Baolin Wang writes: > Make sense. cool, if you wanna work on it, let me know and I can give some details of what

Re: [PATCH] dwc3: gadget: Defer starting the gadget device until gadget is power on

On 18 May 2016 at 18:12, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: Baolin Wang writes: > Make sense. cool, if you wanna work on it, let me know and I can give some details of what I have in mind. >>> >>> Could you explain details to me,

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

Hi, Michal Nazarewicz writes: > On Tue, May 17 2016, Changbin Du wrote: >>> There appears to be no kfifo support for iov_iter though, so I just went >>> with a simple buffer. >>> >>> I haven’t looked at the patch too carefully so this is an RFC rather >>> than an actual

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

Hi, Michal Nazarewicz writes: > On Tue, May 17 2016, Changbin Du wrote: >>> There appears to be no kfifo support for iov_iter though, so I just went >>> with a simple buffer. >>> >>> I haven’t looked at the patch too carefully so this is an RFC rather >>> than an actual patch at this point.

Re: [PATCH 1/1] Staging: comedi: fix CHECK: Prefer using the BIT macro issues in pcmmio.c

On 18/05/16 05:57, Ravishankar Karkala Mallikarjunayya wrote: This patch Replace all occurences of (1< ---

Re: [PATCH 1/1] Staging: comedi: fix CHECK: Prefer using the BIT macro issues in pcmmio.c

On 18/05/16 05:57, Ravishankar Karkala Mallikarjunayya wrote: This patch Replace all occurences of (1< --- drivers/staging/comedi/drivers/pcmmio.c | 40 - 1 file changed, 20 insertions(+), 20 deletions(-) Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott

<    7   8   9   10   11   12   13   14   15   >