Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-16 Thread Max Kellermann
On 2016/06/16 18:24, Shuah Khan wrote: > On 06/15/2016 02:15 PM, Max Kellermann wrote: > > media_gobj_destroy() may be called twice on one instance - once by > > media_device_unregister() and again by dvb_media_device_free(). The > > function media_remove_intf_links() establishes and documents th

Re: [PATCH v2 08/11] Documentation: phy: Let the rockchip eMMC PHY get an exported card clock

2016-06-16 Thread Rob Herring
On Mon, Jun 13, 2016 at 04:04:32PM -0700, Douglas Anderson wrote: > As of an earlier change in this series ("Documentation: mmc: > sdhci-of-arasan: Add ability to export card clock") the SDHCI driver > used on Rockchip SoCs can now expose its clock. Let's now specify that > the PHY can use it. >

Re: [PATCH 1/3] drivers/media/dvb-core/en50221: use kref to manage struct dvb_ca_private

2016-06-16 Thread Max Kellermann
On 2016/06/16 18:06, Shuah Khan wrote: > On 06/15/2016 02:15 PM, Max Kellermann wrote: > > Don't free the object until the file handle has been closed. Fixes > > use-after-free bug which occurs when I disconnect my DVB-S received > > while VDR is running. > > Which file handle? /dev/dvb--- I do

Re: [PATCH 10/13] x86/dumpstack: Try harder to get a call trace on stack overflow

2016-06-16 Thread Andy Lutomirski
On Thu, Jun 16, 2016 at 11:33 AM, Josh Poimboeuf wrote: > On Thu, Jun 16, 2016 at 11:22:14AM -0700, Andy Lutomirski wrote: >> On Thu, Jun 16, 2016 at 11:16 AM, Josh Poimboeuf wrote: >> > On Wed, Jun 15, 2016 at 05:28:32PM -0700, Andy Lutomirski wrote: >> >> If we overflow the stack, print_context

Re: [PATCH 10/13] x86/dumpstack: Try harder to get a call trace on stack overflow

2016-06-16 Thread Josh Poimboeuf
On Thu, Jun 16, 2016 at 11:22:14AM -0700, Andy Lutomirski wrote: > On Thu, Jun 16, 2016 at 11:16 AM, Josh Poimboeuf wrote: > > On Wed, Jun 15, 2016 at 05:28:32PM -0700, Andy Lutomirski wrote: > >> If we overflow the stack, print_context_stack will abort. Detect > >> this case and rewind back into

[PATCH v2] tty: serial: msm: Don't reconfigure same baud rate

2016-06-16 Thread Bjorn Andersson
msm_set_termios() is called whenever the tty is opened. Setting the baud rate requires a full reset of the msm serial block, even when the rate is unchanged. In the case when the same uart is used as console this reset will discard any console output data still being clocked out of the TX fifo. By

Re: [PATCH 10/13] x86/dumpstack: Try harder to get a call trace on stack overflow

2016-06-16 Thread Andy Lutomirski
On Thu, Jun 16, 2016 at 11:16 AM, Josh Poimboeuf wrote: > On Wed, Jun 15, 2016 at 05:28:32PM -0700, Andy Lutomirski wrote: >> If we overflow the stack, print_context_stack will abort. Detect >> this case and rewind back into the valid part of the stack so that >> we can trace it. >> >> Signed-off

Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival

2016-06-16 Thread Michal Hocko
On Thu 16-06-16 18:08:57, Odzioba, Lukasz wrote: > On Thru 09-06-16 02:22 PM Michal Hocko wrote: > > I agree it would be better to do the same for others as well. Even if > > this is not an immediate problem for those. > > I am not able to find clear reasons why we shouldn't do it for the rest. >

Re: [PATCH 10/13] x86/dumpstack: Try harder to get a call trace on stack overflow

2016-06-16 Thread Josh Poimboeuf
On Wed, Jun 15, 2016 at 05:28:32PM -0700, Andy Lutomirski wrote: > If we overflow the stack, print_context_stack will abort. Detect > this case and rewind back into the valid part of the stack so that > we can trace it. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/kernel/dumpstack.c | 7

Re: [PATCH 00/13] Virtually mapped stacks with guard pages (x86, core)

2016-06-16 Thread Andy Lutomirski
Adding Paul, because RCU blew up. On Thu, Jun 16, 2016 at 10:50 AM, Andy Lutomirski wrote: > On Wed, Jun 15, 2016 at 11:05 PM, Heiko Carstens > wrote: >> On Wed, Jun 15, 2016 at 05:28:22PM -0700, Andy Lutomirski wrote: >>> Since the dawn of time, a kernel stack overflow has been a real PITA >>>

Re: [patch 13/20] timer: Switch to a non cascading wheel

2016-06-16 Thread Peter Zijlstra
On Thu, Jun 16, 2016 at 09:02:15AM -0700, Paul E. McKenney wrote: > > 2) When we do that right, we can make the tick frequency a command line > > option > >and just have a compiled in default. > > As long as there is something that tells RCU what the tick frequency > actually is at runtime, t

Re: linux-next: Tree for Jun 16 (linux/firmware.h)

2016-06-16 Thread Stephen Boyd
Quoting Randy Dunlap (2016-06-16 09:46:43) > [adding Stephen Boyd] > > On 06/16/16 08:02, Randy Dunlap wrote: > > On 06/15/16 22:49, Stephen Rothwell wrote: > >> Hi all, > >> > >> Changes since 20160615: > >> > > > > on i386 and/or x86_64: > > > > In file included from ../drivers/fpga/fpga-mgr.c

Re: [PATCH 6/8] net: gianfar: fix old-style declaration

2016-06-16 Thread Joe Perches
On Thu, 2016-06-16 at 21:02 +0300, Sergei Shtylyov wrote: > On 06/16/2016 04:52 PM, Arnd Bergmann wrote: > > Modern C standards expect the '__inline__' keyword to come before the return > > type in a declaration, and we get a warning for this with "make W=1": [] > > diff --git a/drivers/net/etherne

RE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival

2016-06-16 Thread Odzioba, Lukasz
On Thru 09-06-16 02:22 PM Michal Hocko wrote: > I agree it would be better to do the same for others as well. Even if > this is not an immediate problem for those. I am not able to find clear reasons why we shouldn't do it for the rest. Ok so what do we do now? I'll send v2 with proposed changes.

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-16 Thread Ben Hutchings
On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote: > On 2016/06/13 11:46, Netanel Belgazal wrote: [...] > > +static ssize_t ena_show_small_copy_len(struct device *dev, > > +    struct device_attribute *attr, char *buf) > > +{ > > + struct ena_adapter *adapter

Re: [PATCH v2 1/3] firmware: arm_scpi: add support for device power state management

2016-06-16 Thread Jon Medhurst (Tixy)
On Thu, 2016-06-16 at 11:37 +0100, Sudeep Holla wrote: > SCPI protocol supports device power state management. This deals with > power states of various peripheral devices in the system other than the > core compute subsystem. > > This patch adds support for the power state management of those > p

Re: [PATCH 6/8] net: gianfar: fix old-style declaration

2016-06-16 Thread Sergei Shtylyov
Hello. On 06/16/2016 04:52 PM, Arnd Bergmann wrote: Modern C standards expect the '__inline__' keyword to come before the return type in a declaration, and we get a warning for this with "make W=1": drivers/net/ethernet/freescale/gianfar.c:2278:1: error: 'inline' is not at beginning of declar

Re: [PATCH] sparc64: Swap registers for fault code and address in mna trap

2016-06-16 Thread David Miller
Your patch has been whitespace corrupted by your email client. Also, the correct mailing list to submit Sparc patches to is sparcli...@vger.kernel.org

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-16 Thread Sudeep Holla
On 16/06/16 18:47, Jon Medhurst (Tixy) wrote: On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: [...] +enum scpi_power_domain_state { + SCPI_PD_STATE_ON = 0, + SCPI_PD_STATE_OFF = 3, +}; The SCPI doc defines the meaning of these numbers (0 and 3) in the 'Juno specifics' chap

Re: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument

2016-06-16 Thread Robert Jarzmik
Arnd Bergmann writes: > We get a warning for this when building with W=1 because the > argument gets assigned to something else but never read: > > drivers/usb/gadget/udc/pxa27x_udc.c: In function 'stop_activity': > drivers/usb/gadget/udc/pxa27x_udc.c:1828:74: error: parameter 'driver' set > but

Re: [PATCH 08/13] x86/dumpstack: When OOPSing, rewind the stack before do_exit

2016-06-16 Thread Andy Lutomirski
On Thu, Jun 16, 2016 at 10:50 AM, Josh Poimboeuf wrote: > On Wed, Jun 15, 2016 at 05:28:30PM -0700, Andy Lutomirski wrote: >> If we call do_exit with a clean stack, we greatly reduce the risk of >> recursive oopses due to stack overflow in do_exit, and we allow >> do_exit to work even if we OOPS f

Re: [PATCH] dsa: b53: fix big-endian register access

2016-06-16 Thread Florian Fainelli
On 06/16/2016 02:00 AM, Arnd Bergmann wrote: > The b53 dsa register access confusingly uses __raw register accessors > when both the CPU and the device are big-endian, but it uses little- > endian accessors when the same device is used from a little-endian > CPU, which makes no sense. > > This use

[PATCH net-next v5 6/7] vmxnet3: introduce command to register memory region

2016-06-16 Thread Shrikrishna Khare
In vmxnet3 version 3, the emulation added support for the vmxnet3 driver to communicate information about the memory regions the driver will use for rx/tx buffers. The driver can also indicate which rx/tx queue the memory region is applicable for. If this information is communicated to the emulatio

[PATCH net-next v5 3/7] vmxnet3: allow variable length transmit data ring buffer

2016-06-16 Thread Shrikrishna Khare
vmxnet3 driver supports transmit data ring viz. a set of fixed size buffers used by the driver to copy packet headers. Small packets that fit these buffers are copied into these buffers entirely. Currently this buffer size of fixed at 128 bytes. This patch extends transmit data ring implementation

[PATCH net-next v5 0/7] vmxnet3: upgrade to version 3

2016-06-16 Thread Shrikrishna Khare
vmxnet3 emulation has recently added several new features which includes support for new commands the driver can issue to emulation, change in descriptor fields etc. This patch series extends the vmxnet3 driver to leverage these new features. Compatibility is maintained using existing vmxnet3 vers

[PATCH net-next v5 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations

2016-06-16 Thread Shrikrishna Khare
The emulation supports a variety of coalescing modes viz. disabled (no coalescing), adaptive, static (number of packets to batch before raising an interrupt), rate based (number of interrupts per second). This patch implements get_coalesce and set_coalesce methods to allow querying and configuring

[PATCH net-next v5 7/7] vmxnet3: update to version 3

2016-06-16 Thread Shrikrishna Khare
With all vmxnet3 version 3 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 3, provided the emulation advertises support for version 3. Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3/

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-16 Thread Benjamin Poirier
On 2016/06/13 11:46, Netanel Belgazal wrote: [...] > + > +static int ena_set_coalesce(struct net_device *net_dev, > + struct ethtool_coalesce *coalesce) > +{ > + struct ena_adapter *adapter = netdev_priv(net_dev); > + struct ena_com_dev *ena_dev = adapter->ena_dev; >

[PATCH net-next v5 2/7] vmxnet3: introduce generalized command interface to configure the device

2016-06-16 Thread Shrikrishna Khare
Shared memory is used to exchange information between the vmxnet3 driver and the emulation. In order to request emulation to perform a task, the driver first populates specific fields in this shared memory and then issues corresponding command by writing to the command register(CMD). The layout of

[PATCH net-next v5 4/7] vmxnet3: add receive data ring support

2016-06-16 Thread Shrikrishna Khare
vmxnet3 driver preallocates buffers for receiving packets and posts the buffers to the emulation. In order to deliver a received packet to the guest, the emulation must map buffer(s) and copy the packet into it. To avoid this memory mapping overhead, this patch introduces the receive data ring - a

[PATCH v3] of: fix memory leak related to safe_name()

2016-06-16 Thread Frank Rowand
From: Frank Rowand Fix a memory leak resulting from memory allocation in safe_name(). This patch fixes all call sites of safe_name(). Mathieu Malaterre reported the memory leak on boot: On my PowerMac device-tree would generate a duplicate name: [0.023043] device-tree: Duplicate name in Po

[PATCH net-next v5 1/7] vmxnet3: prepare for version 3 changes

2016-06-16 Thread Shrikrishna Khare
vmxnet3 is currently at version 2, but some command definitions from previous vmxnet3 versions are missing. Add those definitions before moving to version 3. Also, introduce utility macros for vmxnet3 version comparison and update Copyright information and Maintained by. Signed-off-by: Shrikrishn

Re: [PATCH 00/13] Virtually mapped stacks with guard pages (x86, core)

2016-06-16 Thread Andy Lutomirski
On Wed, Jun 15, 2016 at 11:05 PM, Heiko Carstens wrote: > On Wed, Jun 15, 2016 at 05:28:22PM -0700, Andy Lutomirski wrote: >> Since the dawn of time, a kernel stack overflow has been a real PITA >> to debug, has caused nondeterministic crashes some time after the >> actual overflow, and has genera

Re: [PATCH 08/13] x86/dumpstack: When OOPSing, rewind the stack before do_exit

2016-06-16 Thread Josh Poimboeuf
On Wed, Jun 15, 2016 at 05:28:30PM -0700, Andy Lutomirski wrote: > If we call do_exit with a clean stack, we greatly reduce the risk of > recursive oopses due to stack overflow in do_exit, and we allow > do_exit to work even if we OOPS from an IST stack. The latter gives > us a much better chance

Re: [RFC PATCH v3 2/2] ARM64/PCI: Start using quirks handling for ACPI based PCI host controller

2016-06-16 Thread Lorenzo Pieralisi
On Wed, Jun 15, 2016 at 11:34:11AM -0400, Christopher Covington wrote: > From: Tomasz Nowicki > > pci_generic_ecam_ops is used by default. Since there are platforms > which have non-compliant ECAM space we need to overwrite these > accessors prior to PCI buses enumeration. In order to do that > w

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-16 Thread Jon Medhurst (Tixy)
On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: [...] > +enum scpi_power_domain_state { > + SCPI_PD_STATE_ON = 0, > + SCPI_PD_STATE_OFF = 3, > +}; The SCPI doc defines the meaning of these numbers (0 and 3) in the 'Juno specifics' chapter. So does these values need to come from devi

Re: [PATCH v2] of: fix memory leak related to safe_name()

2016-06-16 Thread Frank Rowand
On 06/16/16 00:51, Mathieu Malaterre wrote: > Sorry, symptoms not solved. According to kmemleak, I have now: > > [ 661.323100] kmemleak: 100 new suspected memory leaks (see > /sys/kernel/debug/kmemleak) > [ 1260.226120] kmemleak: 1 new suspected memory leaks (see > /sys/kernel/debug/kmemleak) >

Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()

2016-06-16 Thread Peter Zijlstra
On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote: > Peter Zijlstra writes: > > > If not, do you want me to 'fix' this or just remove the comment? > > It's not broken, so nothing to fix. Its non obvious code, that's usually plenty reason to change it. Geert, you maintain this stuf

Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks

2016-06-16 Thread Andy Lutomirski
On Thu, Jun 16, 2016 at 8:33 AM, Josh Poimboeuf wrote: > On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote: >> Currently, NR_KERNEL_STACK tracks the number of kernel stacks in a >> zone. This only makes sense if each kernel stack exists entirely in >> one zone, and allowing vmapped

Re: [PATCH] [ACPI] Change structure initialisation to C99 style

2016-06-16 Thread Kees Cook
On Tue, Jun 14, 2016 at 1:42 AM, Amitoj Kaur Chawla wrote: > Replace the in order struct initialisation style with explicit field > style. > > The Coccinelle semantic patch used to make this change is as follows: > > @decl@ > identifier i1,fld; > type T; > field list[n] fs; > @@ > > struct i1 { >

Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit

2016-06-16 Thread kbuild test robot
Hi, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.7-rc3 next-20160616] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/scsi-lpfc-avoid-harmless

Re: [PATCH 06/13] fork: Add generic vmalloced stack support

2016-06-16 Thread Andy Lutomirski
On Thu, Jun 16, 2016 at 10:25 AM, Kees Cook wrote: > On Wed, Jun 15, 2016 at 5:28 PM, Andy Lutomirski wrote: >> If CONFIG_VMAP_STACK is selected, kernel stacks are allocated with >> vmalloc_node. >> >> Signed-off-by: Andy Lutomirski >> --- >> arch/Kconfig | 12 >> kernel/fork.c |

Re: [PATCH] sched/fair: initialize throttle_count for new task-groups lazily

2016-06-16 Thread bsegall
Konstantin Khlebnikov writes: > On 16.06.2016 20:03, bseg...@google.com wrote: >> Konstantin Khlebnikov writes: >> >>> Cgroup created inside throttled group must inherit current throttle_count. >>> Broken throttle_count allows to nominate throttled entries as a next buddy, >>> later this leads t

Re: [PATCH 06/13] fork: Add generic vmalloced stack support

2016-06-16 Thread Kees Cook
On Wed, Jun 15, 2016 at 5:28 PM, Andy Lutomirski wrote: > If CONFIG_VMAP_STACK is selected, kernel stacks are allocated with > vmalloc_node. > > Signed-off-by: Andy Lutomirski > --- > arch/Kconfig | 12 > kernel/fork.c | 45 + > 2 files c

Re: [PATCH] sched/fair: initialize throttle_count for new task-groups lazily

2016-06-16 Thread Konstantin Khlebnikov
On 16.06.2016 20:03, bseg...@google.com wrote: Konstantin Khlebnikov writes: Cgroup created inside throttled group must inherit current throttle_count. Broken throttle_count allows to nominate throttled entries as a next buddy, later this leads to null pointer dereference in pick_next_task_fai

Re: [PATCH 00/13] Virtually mapped stacks with guard pages (x86, core)

2016-06-16 Thread Kees Cook
On Wed, Jun 15, 2016 at 5:28 PM, Andy Lutomirski wrote: > Since the dawn of time, a kernel stack overflow has been a real PITA > to debug, has caused nondeterministic crashes some time after the > actual overflow, and has generally been easy to exploit for root. > > With this series, arches can en

Re: Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and SPECjvm2008 benchmarks against 4.6 kernel

2016-06-16 Thread Peter Zijlstra
On Thu, Jun 16, 2016 at 06:38:50PM +0200, Jirka Hladky wrote: > Hello, > > we see performance drop 30-40% for SPECjbb2005 and SPECjvm2008 Blergh, of course I don't have those.. :/ > benchmarks starting from 4.7.0-0.rc0 kernel compared to 4.6 kernel. > > We have tested kernels 4.7.0-0.rc1 and 4.

[RFC] [PATCH 2/3] staging: media: omap1: convert to videobuf2

2016-06-16 Thread Janusz Krzysztofik
Created and tested on Amstrad Delta on top of Linux-4.7-rc3 with "staging: media: omap1: drop videobuf-dma-sg mode" applied. Signed-off-by: Janusz Krzysztofik --- drivers/staging/media/omap1/Kconfig| 2 +- drivers/staging/media/omap1/omap1_camera.c | 363 -

[RFC] [PATCH 3/3] staging: media: omap1: use dmaengine

2016-06-16 Thread Janusz Krzysztofik
Created and tested on Amstrad Delta on top of Linux-4.7-rc3 with "staging: media: omap1: convert to videobuf2" applied. Signed-off-by: Janusz Krzysztofik --- drivers/staging/media/omap1/Kconfig| 2 +- drivers/staging/media/omap1/omap1_camera.c | 432 + 2 fil

[RFC] [PATCH 1/3] staging: media: omap1: drop videobuf-dma-sg mode

2016-06-16 Thread Janusz Krzysztofik
For over 20 last kernel versions the driver has been able to allocate DMA buffers in videobuf-dma-contig mode without any issues. Drop the no longer needed sg mode in preparation for conversion to videobuf2. Created and tested on Amstrad Delta against Linux-4.7-rc3 with omap1_camera and ov6650 fix

Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit

2016-06-16 Thread Paolo Bonzini
On 16/06/2016 19:03, David Matlack wrote: > > > If you make the else case the same as svm_handle_external_intr, can we > > > avoid requiring ack-intr-on-exit? > > > > Yes, but the sti/nop/cli would be useless if ack-intr-on-exit is > > available. It's a bit ugly, so I RFCed the bold thing instea

[RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera driver

2016-06-16 Thread Janusz Krzysztofik
As requested by media subsystem maintainers, here is an attempt to convert the omap1_camera driver to the vb2 framework. Also, conversion to the dmaengine framework, long awaited by ARM/OMAP maintainers, is done. Next, I'm going to approach removal of soc-camera dependency. Please let me know

Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks

2016-06-16 Thread Andy Lutomirski
On Thu, Jun 16, 2016 at 4:10 AM, Vladimir Davydov wrote: > On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote: > ... >> @@ -225,7 +225,8 @@ static void account_kernel_stack(struct thread_info *ti, >> int account) >> { >> struct zone *zone = page_zone(virt_to_page(ti)); >> >> -

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Peter Zijlstra
On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote: > Le Wednesday 15 Jun 2016 à 17:22:17 (+0200), Peter Zijlstra a écrit : > > On Wed, Jun 15, 2016 at 09:46:53AM +0200, Vincent Guittot wrote: > > > I still have concerned with this change of the behavior that attaches > > > the task o

[PATCH 0/2] x86/amd_nb: Two fixes

2016-06-16 Thread Borislav Petkov
From: Borislav Petkov Hi, the first one is CC:stable so please queue it for tip:x86/urgent when you get a chance. The second one is a simple cleanup and can go in 4.8. Thanks. Borislav Petkov (2): x86/amd_nb: Return negative value when no northbridges x86/amd_nb: Cleanup init path arch/x

[PATCH 2/2] x86/amd_nb: Cleanup init path

2016-06-16 Thread Borislav Petkov
From: Borislav Petkov The initcall had unnecessary pr_notice() messages which are useless noise on distro kernels. Also, push the GART init error message where it belongs, *after* the check whether the current hw we're loaded on, supports GART at all. Signed-off-by: Borislav Petkov --- arch/x

[PATCH 1/2] x86/amd_nb: Return negative value when no northbridges

2016-06-16 Thread Borislav Petkov
From: Borislav Petkov AMD northbridges users call amd_cache_northbridges() and it returns a negative value to signal that we weren't able to cache/detect any northbridges on the system. At least, it should do so as all its callers expect it to do so. But it does return a negative value only when

Re: [PATCH V3 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot

2016-06-16 Thread Bjorn Helgaas
On Sun, Jun 12, 2016 at 02:06:09PM +0800, Rui Wang wrote: > On Saturday, June 11, 2016 12:43 AM, Bjorn Helgaas wrote: > > On Wed, Jun 08, 2016 at 05:32:44PM +0800, Rui Wang wrote: > > > @@ -1779,8 +1780,12 @@ void __init > > > pci_assign_unassigned_resources(void) > > > { > > > struct pci_bus *r

Re: [RFC PATCH v3 1/2] ACPI/PCI: Check platform specific ECAM quirks

2016-06-16 Thread Lorenzo Pieralisi
On Wed, Jun 15, 2016 at 11:34:10AM -0400, Christopher Covington wrote: > From: Tomasz Nowicki > > Some platforms may not be fully compliant with the generic PCI config > operations. For these cases we implement a way to use custom map and > accessor functions. The algorithm traverses the availabl

Re: [PATCH V7 7/9] vfio, platform: make reset driver a requirement by default

2016-06-16 Thread Sinan Kaya
On 6/16/2016 4:15 AM, Auger Eric wrote: > Unfortunately this causes a crash when the reset module is not > available. You should do the vfio_add_group_dev at the end. Something > like below. > Thanks for testing. I'll post v8 with this change. > Best Regards > > Eric > > --- > drivers/vfio

Re: [PATCH v2] ARM: mm: fix location of _etext

2016-06-16 Thread Kees Cook
On Thu, Jun 16, 2016 at 5:04 AM, Ard Biesheuvel wrote: > On 15 June 2016 at 22:24, Kees Cook wrote: >> The _etext position is defined to be the end of the kernel text code, >> and should not include any part of the data segments. This interferes >> with things that might check memory ranges and e

Re: [v2 PATCH 2/4] phy: Add USB Type-C PHY driver for rk3399

2016-06-16 Thread Kever Yang
Hi Chris, On 06/13/2016 05:39 PM, Chris Zhong wrote: Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB Type-C PHY is designed to support the USB3 and DP applications. The PHY basically has two main components: USB3 and DisplyPort. USB3 operates in SuperSpeed mode and the DP can op

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-06-16 Thread bsegall
Konstantin Khlebnikov writes: > Hierarchy could be already throttled at this point. Throttled next > buddy could trigger null pointer dereference in pick_next_task_fair(). > > Signed-off-by: Konstantin Khlebnikov Reviewed-by: Ben Segall > Cc: Stable # v3.2+ > --- > kernel/sched/fair.c |

Re: [PATCH] sched/fair: initialize throttle_count for new task-groups lazily

2016-06-16 Thread bsegall
Konstantin Khlebnikov writes: > Cgroup created inside throttled group must inherit current throttle_count. > Broken throttle_count allows to nominate throttled entries as a next buddy, > later this leads to null pointer dereference in pick_next_task_fair(). > > This patch initialize cfs_rq->throt

Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit

2016-06-16 Thread David Matlack
On Thu, Jun 16, 2016 at 9:47 AM, Paolo Bonzini wrote: > On 16/06/2016 18:43, David Matlack wrote: >> On Thu, Jun 16, 2016 at 1:21 AM, Paolo Bonzini wrote: >>> This gains ~20 clock cycles per vmexit. On Intel there is no need >>> anymore to enable the interrupts in vmx_handle_external_intr, since

Re: [PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-16 Thread Emil Velikov
Hi Vinay, I belive I've spotted a few issues. If my understanding is correct, then I'll defer to Thierry if he'd like them fixed here, or as follow-ups. On 16 June 2016 at 04:00, Vinay Simha BN wrote: > +#define PANEL_NUM_REGULATORS 3 > + Nit: #define PANEL_NUM_REGULATORS ARRAY_SIZE(regulato

Re: [PATCH 4/5] netdev: implement infrastructure for threadable napi irq

2016-06-16 Thread Eric Dumazet
> > I guess you means 'consumer' here. The scheduler doesn't fail to migrate > it: the consumer is actually migrated a lot of times, but on each cpu a > competing and running ksoftirqd thread is found. > > The general problem is that under significant network load (not > necessary udp flood, simila

[PATCH 3/3] tools/power/turbostat: add denverton rapl support

2016-06-16 Thread Jacob Pan
Denverton CPU RAPL supports package, core, and dram domains. Signed-off-by: Jacob Pan --- tools/power/x86/turbostat/turbostat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c index d219c4f..3c10d6d 100644 ---

Re: [PATCH v5] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs

2016-06-16 Thread Suzuki K Poulose
On 16/06/16 17:43, Will Deacon wrote: On Thu, Jun 16, 2016 at 02:28:50PM +0100, Suzuki K Poulose wrote: +static int __init cpuinfo_regs_init(void) +{ + int cpu, finalcpu, ret; + struct device *dev; + + cpu_hotplug_disable(); + + for_each_present_cpu(cpu) { +

[PATCH 1/3] tools/power/turbostat: handle missing rapl msrs

2016-06-16 Thread Jacob Pan
Some CPUs may not have PP0/Core domain power limit MSRs. We should still allow its domain energy status to be used. This patch splits PP0/Core RAPL into two separate flags for power limit and energy status such that energy status can continue to be reported without power limit. Without this patch,

[PATCH 2/3] tools/power/turbostat: add denverton support

2016-06-16 Thread Jacob Pan
Denverton is an Atom based micro server which shares the same Goldmont architecture as Broxton. The available C-states on Denverton is a subset of Broxton with only C1, C1e, and C6. Signed-off-by: Jacob Pan --- tools/power/x86/turbostat/turbostat.c | 2 ++ 1 file changed, 2 insertions(+) diff -

Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options

2016-06-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 16, 2016 at 01:48:15PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 16, 2016 at 08:02:41AM +, Wang Nan escreveu: > > With '--dry-run', 'perf record' doesn't do reall recording. Combine with > > llvm.dump-obj option, --dry-run can be used to help compile BPF objects for >

[PATCH 0/3] Tools/Power/Turbostat update for Denverton

2016-06-16 Thread Jacob Pan
This simple series first address missing RAPL MSR handling such that new CPUs such as Denverton can be supported. Denverton specific bits are added later. Jacob Pan (3): tools/power/turbostat: handle missing rapl msrs tools/power/turbostat: add denverton support tools/power/turbostat: add d

Re: [patch] devlink: clean up a condition

2016-06-16 Thread Or Gerlitz
On 6/16/2016 9:50 AM, Dan Carpenter wrote: Presumably having a _get() function implies that we also have a _set() function but lets make it match when we're calling. Signed-off-by: Dan Carpenter diff --git a/net/core/devlink.c b/net/core/devlink.c index a4f88cb..b2e592a 100644 --- a/net/core/d

PATCH 1/1] AX.25: Close socket connection on session completion

2016-06-16 Thread Basil Gunn
A socket connection made in ax.25 is not closed when session is completed. The heartbeat timer is stopped prematurely and this is where the socket gets closed. Allow heatbeat timer to run to close socket. Symptom occurs in kernels >= 4.2.0 Originally sent 6/15/2016. Resend with distribution list

Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit

2016-06-16 Thread Paolo Bonzini
On 16/06/2016 18:43, David Matlack wrote: > On Thu, Jun 16, 2016 at 1:21 AM, Paolo Bonzini wrote: >> This gains ~20 clock cycles per vmexit. On Intel there is no need >> anymore to enable the interrupts in vmx_handle_external_intr, since we >> are using the "acknowledge interrupt on exit" featu

Re: [PATCH 2/2] perf record: Add --dry-run option to check cmdline options

2016-06-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 16, 2016 at 08:02:41AM +, Wang Nan escreveu: > With '--dry-run', 'perf record' doesn't do reall recording. Combine with > llvm.dump-obj option, --dry-run can be used to help compile BPF objects for > embedded platform. So these are nice and have value, but can we have a subcommand

Re: [PATCH] mm: fix account pmd page to the process

2016-06-16 Thread Mike Kravetz
On 06/16/2016 09:31 AM, Michal Hocko wrote: > On Thu 16-06-16 09:05:23, Mike Kravetz wrote: >> On 06/16/2016 08:43 AM, Michal Hocko wrote: >>> [It seems that this patch has been sent several times and this >>> particular copy didn't add Kirill who has added this code CC him now] >>> >>> On Thu 16-0

Re: [REDO PATCH v7] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-06-16 Thread Borislav Petkov
On Thu, Jun 16, 2016 at 01:38:14PM +0800, Huang Rui wrote: > I was told this feature would be supported on fam15h 60h, 70h and > later processors before. Just checked the fam16h model 30h BKDG, yes, > it should be also supported. But I didn't test that platform, if you > confirm it works in your si

Re: linux-next: Tree for Jun 16 (linux/firmware.h)

2016-06-16 Thread Randy Dunlap
[adding Stephen Boyd] On 06/16/16 08:02, Randy Dunlap wrote: > On 06/15/16 22:49, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20160615: >> > > on i386 and/or x86_64: > > In file included from ../drivers/fpga/fpga-mgr.c:21:0: > ../include/linux/firmware.h:82:1: error: expected identifi

Re: [PATCH v4] arm64: allow building with kcov coverage on ARM64

2016-06-16 Thread Catalin Marinas
On Thu, Jun 16, 2016 at 06:39:52PM +0200, Alexander Potapenko wrote: > Add ARCH_HAS_KCOV to ARM64 config. To avoid potential crashes, disable > instrumentation of the files in arch/arm64/kvm/hyp/*. > > Signed-off-by: Alexander Potapenko > Acked-by: Mark Rutland > Acked-by: Marc Zyngier > Tested

[PATCH] idle/intel: add denverton

2016-06-16 Thread Jacob Pan
Signed-off-by: Jacob Pan --- drivers/idle/intel_idle.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index c966492..633fc35 100644 --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -8

Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit

2016-06-16 Thread David Matlack
On Thu, Jun 16, 2016 at 1:21 AM, Paolo Bonzini wrote: > This gains ~20 clock cycles per vmexit. On Intel there is no need > anymore to enable the interrupts in vmx_handle_external_intr, since we > are using the "acknowledge interrupt on exit" feature. AMD needs to do > that temporarily, and must

Re: [PATCH v3] Linux VM workaround for Knights Landing A/D leak

2016-06-16 Thread Nadav Amit
Lukasz Anaczkowski wrote: > From: Andi Kleen > > +void fix_pte_leak(struct mm_struct *mm, unsigned long addr, pte_t *ptep) > +{ > + if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids) { > + trace_tlb_flush(TLB_LOCAL_SHOOTDOWN, TLB_FLUSH_ALL); This tracing seem

Re: [PATCH v5] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs

2016-06-16 Thread Will Deacon
On Thu, Jun 16, 2016 at 02:28:50PM +0100, Suzuki K Poulose wrote: > +static int __init cpuinfo_regs_init(void) > +{ > + int cpu, finalcpu, ret; > + struct device *dev; > + > + cpu_hotplug_disable(); > + > + for_each_present_cpu(cpu) { > + dev = get_cpu_device(cpu); > + >

[PATCH v4] arm64: allow building with kcov coverage on ARM64

2016-06-16 Thread Alexander Potapenko
Add ARCH_HAS_KCOV to ARM64 config. To avoid potential crashes, disable instrumentation of the files in arch/arm64/kvm/hyp/*. Signed-off-by: Alexander Potapenko Acked-by: Mark Rutland Acked-by: Marc Zyngier Tested-by: James Morse --- v4: - added ack from Marc Zyngier and Tested-by from James Mo

Re: [PATCH v2] arm64: allow building with kcov coverage on ARM64

2016-06-16 Thread Catalin Marinas
On Thu, Jun 16, 2016 at 05:32:59PM +0100, Mark Rutland wrote: > On Thu, Jun 16, 2016 at 05:25:31PM +0100, Catalin Marinas wrote: > > On Thu, Jun 16, 2016 at 04:44:12PM +0100, Mark Rutland wrote: > > > On Thu, Jun 16, 2016 at 05:20:03PM +0200, Alexander Potapenko wrote: > > > > I think it's time to

Kernel 4.7rc3 - Performance drop 30-40% for SPECjbb2005 and SPECjvm2008 benchmarks against 4.6 kernel

2016-06-16 Thread Jirka Hladky
Hello, we see performance drop 30-40% for SPECjbb2005 and SPECjvm2008 benchmarks starting from 4.7.0-0.rc0 kernel compared to 4.6 kernel. We have tested kernels 4.7.0-0.rc1 and 4.7.0-0.rc3 and these are as well affected. We have observed the drop on variety of different x86_64 servers with diffe

Re: [PATCH v2] arm64: allow building with kcov coverage on ARM64

2016-06-16 Thread James Morse
On 16/06/16 17:36, Alexander Potapenko wrote: > On Thu, Jun 16, 2016 at 6:32 PM, Mark Rutland wrote: >> On Thu, Jun 16, 2016 at 05:25:31PM +0100, Catalin Marinas wrote: >>> I noticed that there was an ack on v1 form Marc Z that's missing in v2. >> >> I believe Marc's reply [1] was to v3 [2], it's

Re: [PATCH RFC 0/3] perf script: Add callindent option

2016-06-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 16, 2016 at 03:34:31PM +0300, Adrian Hunter escreveu: > Hi > > Andi Kleen sent a couple of patches to add a callindent option to > perf script. If Andi is agreeable, I would like to propose an > alternative implementation. Andi? - Arnaldo > While there are some differences in the r

Re: [PATCH v2] arm64: allow building with kcov coverage on ARM64

2016-06-16 Thread Alexander Potapenko
On Thu, Jun 16, 2016 at 6:32 PM, Mark Rutland wrote: > On Thu, Jun 16, 2016 at 05:25:31PM +0100, Catalin Marinas wrote: >> On Thu, Jun 16, 2016 at 04:44:12PM +0100, Mark Rutland wrote: >> > On Thu, Jun 16, 2016 at 05:20:03PM +0200, Alexander Potapenko wrote: >> > > I think it's time to ask now :)

Re: [PATCH v2] arm64: allow building with kcov coverage on ARM64

2016-06-16 Thread Mark Rutland
On Thu, Jun 16, 2016 at 05:25:31PM +0100, Catalin Marinas wrote: > On Thu, Jun 16, 2016 at 04:44:12PM +0100, Mark Rutland wrote: > > On Thu, Jun 16, 2016 at 05:20:03PM +0200, Alexander Potapenko wrote: > > > I think it's time to ask now :) > > > If I receive "Tested-by" or "Acked-by" responses, do

Re: [PATCH v3 1/7 UPDATE2] perf tools: Find vdso with the consider of cross-platform

2016-06-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 16, 2016 at 04:00:12PM +0300, Adrian Hunter escreveu: > On 15/06/16 16:34, Arnaldo Carvalho de Melo wrote: > > Em Tue, May 17, 2016 at 09:04:54AM +, He Kuang escreveu: > >> There's a problem in machine__findnew_vdso(), vdso buildid generated > >> by a 32-bit machine stores it with t

Re: [PATCH] mm: fix account pmd page to the process

2016-06-16 Thread Michal Hocko
On Thu 16-06-16 09:05:23, Mike Kravetz wrote: > On 06/16/2016 08:43 AM, Michal Hocko wrote: > > [It seems that this patch has been sent several times and this > > particular copy didn't add Kirill who has added this code CC him now] > > > > On Thu 16-06-16 17:42:14, Michal Hocko wrote: > >> On Thu

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-16 Thread Shuah Khan
On 06/15/2016 02:15 PM, Max Kellermann wrote: > media_gobj_destroy() may be called twice on one instance - once by > media_device_unregister() and again by dvb_media_device_free(). The > function media_remove_intf_links() establishes and documents the > convention that mdev==NULL means that the ob

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Vincent Guittot
Le Wednesday 15 Jun 2016 à 17:22:17 (+0200), Peter Zijlstra a écrit : > On Wed, Jun 15, 2016 at 09:46:53AM +0200, Vincent Guittot wrote: > > I still have concerned with this change of the behavior that attaches > > the task only when it is enqueued. The load avg of the task will not > > be decayed

Re: [PATCH 6/7] phy: Add SATA3 PHY support for Broadcom NSP SoC

2016-06-16 Thread Florian Fainelli
On 06/16/2016 06:53 AM, Yendapally Reddy Dhananjaya Reddy wrote: > This patch adds support for Broadcom NSP SATA3 PHY in existing > Broadcom SATA PHY driver. > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy > Acked-by: Florian Fainelli -- Florian

Re: [PATCH 7/7] ARM: dts: nsp: Add sata device tree entry

2016-06-16 Thread Florian Fainelli
On 06/16/2016 06:53 AM, Yendapally Reddy Dhananjaya Reddy wrote: > Add sata support to the Northstar Plus SoC device tree. > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy > Acked-by: Florian Fainelli -- Florian

Re: [PATCH 4/7] ata: ahci_brcmstb: rename to support across Broadcom SoC's

2016-06-16 Thread Florian Fainelli
On 06/16/2016 06:53 AM, Yendapally Reddy Dhananjaya Reddy wrote: > Rename the existing Broadcom STB ahci driver to common > Broadcom SATA3 driver to share this across Broadcom SoCs. > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy > There is currently nothing referencing AHCI_BRCMSTB in the

Re: [PATCH 5/7] ata: ahci_brcm: Add support for Broadcom NSP SoC

2016-06-16 Thread Florian Fainelli
On 06/16/2016 06:53 AM, Yendapally Reddy Dhananjaya Reddy wrote: > Add SATA3 support for Broadcom NSP SoC > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy > Acked-by: Florian Fainelli -- Florian

<    1   2   3   4   5   6   7   8   9   10   >