Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread Niklas Cassel
On 12/19/2016 06:10 PM, Joao Pinto wrote: > Hi, > > I am trying to built net-next git tree and it is failing: > > CC drivers/pnp/card.o > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function > ‘stmmac_hw_fix_mac_speed’: > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:224:34: er

[PATCH 2/4] mm: drop zap_details::check_swap_entries

2016-12-19 Thread Kirill A. Shutemov
detail == NULL would give the same functionality as .check_swap_entries==true. Signed-off-by: Kirill A. Shutemov Acked-by: Michal Hocko --- include/linux/mm.h | 1 - mm/memory.c| 4 ++-- mm/oom_kill.c | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/include/l

[PATCH 1/4] mm: drop zap_details::ignore_dirty

2016-12-19 Thread Kirill A. Shutemov
The only user of ignore_dirty is oom-reaper. But it doesn't really use it. ignore_dirty only has effect on file pages mapped with dirty pte. But oom-repear skips shared VMAs, so there's no way we can dirty file pte in them. Signed-off-by: Kirill A. Shutemov Acked-by: Michal Hocko --- include/l

Re: [PATCH 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor

2016-12-19 Thread Laurent Pinchart
Hi Kedar, On Monday 19 Dec 2016 15:39:43 Appana Durga Kedareswara Rao wrote: > Hi Laurent Pinchart, > > Thanks for the review... > > > > + if (!chan->idle) > > > + return; > > > > Don't you need to perform the same check for the DMA and CDMA channels ? > > If so, shouldn't this be

[PATCH 4/4] oom-reaper: use madvise_dontneed() logic to decide if unmap the VMA

2016-12-19 Thread Kirill A. Shutemov
Logic on whether we can reap pages from the VMA should match what we have in madvise_dontneed(). In particular, we should skip, VM_PFNMAP VMAs, but we don't now. Let's just extract condition on which we can shoot down pagesi from a VMA with MADV_DONTNEED into separate function and use it in both p

[PATCH 3/4] mm: drop unused argument of zap_page_range()

2016-12-19 Thread Kirill A. Shutemov
There's no users of zap_page_range() who wants non-NULL 'details'. Let's drop it. Signed-off-by: Kirill A. Shutemov Acked-by: Michal Hocko --- arch/s390/mm/gmap.c | 2 +- arch/x86/mm/mpx.c | 2 +- drivers/android/binder.c | 2 +- drivers/staging/android/io

Re: [PATCH] serial: 8250: Avoid "too much work" from bogus rx timeout interrupt

2016-12-19 Thread Doug Anderson
Hi, On Mon, Dec 19, 2016 at 4:59 AM, Andy Shevchenko wrote: > On Sun, 2016-12-18 at 17:14 -0800, Douglas Anderson wrote: >> On a Rockchip rk3399-based board during suspend/resume testing, we >> found that we could get the console UART into a state where it would >> print this to the console a lot

[PATCH] ivtv: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/pci/ivtv/ivtv-alsa-pcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/ivtv/ivtv-alsa-pcm.c b/drivers/media/pci/ivtv/ivtv-alsa-pcm.c index a26f980..d0d2c93 100644

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> On Mon, Dec 19, 2016 at 8:22 AM, James Simmons > >> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> @@ -143,7 +143,7 @@ static int ldlm_process_flock_lock(struct ldlm_lock > >> *req, __u64 *flags, > >> int added = (mode

[PATCH] tm6000: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/usb/tm6000/tm6000-video.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/tm6000/tm6000-video.c b/drivers/media/usb/tm6000/tm6000

Re: [lustre-devel] [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> James, > > > This should be a purely syntactical change, to help out tools - for GCC, I'm > pretty sure the meaning of { > } and { NULL } are the same.  Also, I don't think struct randomization does > what you're thinking. Yep. I misread his commit message. That is why it didn't make sense

Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread Joao Pinto
Hi, I am trying to built net-next git tree and it is failing: CC drivers/pnp/card.o drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function ‘stmmac_hw_fix_mac_speed’: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:224:34: error: ‘struct stmmac_priv’ has no member named ‘phydev’

Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

2016-12-19 Thread Jason A. Donenfeld
On Sat, Dec 17, 2016 at 3:55 PM, Jeffrey Walton wrote: > It may be prudent to include the endian reversal in the test to ensure > big endian machines produce expected results. Some closely related > testing on an old Apple PowerMac G5 revealed that result needed to be > reversed before returning i

[RFC] arch/x86/Kconfig.cpu: Update with new gcc disponible 64bits CPU uarchs.

2016-12-19 Thread Gustavo da Silva
Good afternon! Are there reasons to 'Kconfig.cpu' and 'Makefile' not contains the 'gcc -mtune=???' recent options? Well, bellow I send some diffs (untested) just for clarifications. Best regards, Gustavo da Silva. --- old/arch/x86/Kconfig.cpu +++ new/arch/x86/Kconfig.cpu

[PATCH] staging: lustre: headers: potential UAPI headers

2016-12-19 Thread James Simmons
Not for landing. This is the purposed UAPI headers with the removal of unlikely and debugging macros. This is just for feedback to see if this is acceptable for the upstream client. Signed-off-by: James Simmons --- .../lustre/lustre/include/lustre/lustre_fid.h | 353 + .

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-19 Thread Logan Gunthorpe
On 19/12/16 10:02 AM, Keith Busch wrote: > Some of this would be simplified if you use the managed device API's: > devm_request_irq, pcim_enable_device, pcim_iomap, etc... Thanks Keith, I'll look into using those. Logan

Re: [RFC 0/1] New PCI Switch Management Driver

2016-12-19 Thread Logan Gunthorpe
Hey, On 19/12/16 09:09 AM, Myron Stowe wrote: > I guess the obvious questions is: why is a driver for a PCI switch > necessary? The core works with all compliant switches today and there > are no specifics for a particular design or such. > So I guess I'd like to hear the reasoning and justifica

Re: [PATCH] NTB: Fix 'request_irq()' and 'free_irq()' inconsistancy

2016-12-19 Thread Dave Jiang
On 12/18/2016 10:52 PM, Christophe JAILLET wrote: > 'request_irq()' and 'free_irq()' should have the same 'dev_id'. > > Signed-off-by: Christophe JAILLET Acking the Intel driver portion. Acked-by: Dave Jiang > --- > drivers/ntb/hw/amd/ntb_hw_amd.c | 2 +- > drivers/ntb/hw/intel/ntb_hw_i

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-19 Thread James Simmons
> On Tue, Dec 13, 2016 at 12:55:01AM +, Dilger, Andreas wrote: > > On Dec 12, 2016, at 13:00, James Simmons wrote: > > > > > > > > >> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > >>> In order for lustre_idl.h to be usable for both user > > >>> land and kernel space it

[PATCH] tm6000: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/usb/tm6000/tm6000-video.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/tm6000/tm6000-video.c b/drivers/media/usb/tm6000/tm6000

Re: [PATCH v4 4/8] mtd: spi-nor: add support of SPI protocols like SPI 1-2-2 and SPI 1-4-4

2016-12-19 Thread Cyrille Pitchen
Le 16/12/2016 à 14:47, Krzeminski, Marcin (Nokia - PL/Wroclaw) a écrit : >> -Original Message- >> From: Krzeminski, Marcin (Nokia - PL/Wroclaw) >> Sent: Tuesday, December 13, 2016 10:46 AM >> To: Cyrille Pitchen ; >> computersforpe...@gmail.com; marek.va...@gmail.com; >> boris.brezil...@fre

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-19 Thread Keith Busch
On Sat, Dec 17, 2016 at 10:09:22AM -0700, Logan Gunthorpe wrote: > Microsemi's "Switchtec" line of PCI switch devices is already > supported by the kernel with standard PCI switch drivers. However, the > Switchtec device advertises a special management endpoint which > enables some additional funct

Re: *** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated

2016-12-19 Thread Markus Trippelsdorf
On 2016.12.19 at 17:18 +0100, Markus Trippelsdorf wrote: > Running the latest kernel git tree, I get buffer overflow warnings when > I try to run "perf top": > > *** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated > > > __GI_raise (sig=sig@entry=6) at ../sysdeps/u

Re: [PATCH v3 0/5] introduce DAX tracepoint support

2016-12-19 Thread Ross Zwisler
On Thu, Dec 01, 2016 at 09:37:46AM -0700, Ross Zwisler wrote: > Tracepoints are the standard way to capture debugging and tracing > information in many parts of the kernel, including the XFS and ext4 > filesystems. This series creates a tracepoint header for FS DAX and add > the first few DAX trac

Re: [PATCH] drm: tilcdc: simplify the recovery from sync lost error on rev1

2016-12-19 Thread Jyri Sarha
On 12/19/16 16:19, Bartosz Golaszewski wrote: >> I would add here: >> + if ((tilcdc_read(dev, LCDC_RASTER_CTRL_REG) & >> + LCDC_RASTER_ENABLE)) { >> >>> + tilcdc_clear(dev, >>> + LCDC_RASTER_CTRL_REG,

[PATCH] zoran: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/pci/zoran/zoran_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/zoran/zoran_driver.c b/drivers/media/pci/zoran/zoran_driver.c index d6b631a.

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread Bruce Korb
On Mon, Dec 19, 2016 at 8:22 AM, James Simmons >> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c >> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c >> @@ -143,7 +143,7 @@ static int ldlm_process_flock_lock(struct ldlm_lock >> *req, __u64 *flags, >> int added = (mode == LCK_NL);

Re: [PATCH] btrfs: use rb_entry()

2016-12-19 Thread Josef Bacik
On Mon, Dec 19, 2016 at 9:53 AM, Geliang Tang wrote: To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang Reviewed-by: Josef Bacik Thanks, Josef

Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver

2016-12-19 Thread Mark Brown
On Mon, Dec 19, 2016 at 10:30:09AM -0600, Pierre-Louis Bossart wrote: > All this code seems to be largely a copy-paste of the bytcr_rt5640 machine > driver and the same comments would apply there. This patch did miss the last Yes, there's a lot of room for cleanups in the existing code too (and o

Re: [PATCH] x86/microcode: Adjust ramdisk address when accessing by virtual address

2016-12-19 Thread Borislav Petkov
On Mon, Dec 19, 2016 at 11:10:29AM -0500, Boris Ostrovsky wrote: > config attached. I'll see how I can get you the initrd. Wait a bit, lemme see if I can repro with my initrd here. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

RE: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[]

2016-12-19 Thread Madalin-Cristian Bucur
> From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, December 19, 2016 5:37 PM > > From: Madalin Bucur > Date: Mon, 19 Dec 2016 11:22:20 +0200 > > > The fsl/fman drivers will use of_platform_populate() on all > > supported platforms. > > > > Signed-off-by: Madalin Bucur > > It see

Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

2016-12-19 Thread Miroslav Benes
On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > The _TIF_ALLWORK_MASK macro automatically includes the least-significant > 16 bits of the thread_info flags, which is less than obvious and tends > to create confusion and surprises when reading or modifying the code. Yes. > Define the flags explicitl

Re: [PATCH v4 4/8] mtd: spi-nor: add support of SPI protocols like SPI 1-2-2 and SPI 1-4-4

2016-12-19 Thread Cyrille Pitchen
Hi Marcin, Le 13/12/2016 à 10:46, Krzeminski, Marcin (Nokia - PL/Wroclaw) a écrit : > Cyrille, > >> -Original Message- >> From: linux-mtd [mailto:linux-mtd-boun...@lists.infradead.org] On Behalf >> Of Cyrille Pitchen >> Sent: Monday, November 21, 2016 3:16 PM >> To: computersforpe...@gmai

Re: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring

2016-12-19 Thread James Simmons
> A recent clean-up declared och_flags as a int rather than fmode_t. This > lead to the following sparse warning: > > drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted > fmode_t degrades to integer > > This patch fixes this issue. Acked-by: James Simmons > Fixes: 0a12009

[PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-by: Stefan Wahre

RE: thermal zones break with patch "Reimplement IDR and IDA using the radix tree" (mainline+next)

2016-12-19 Thread Matthew Wilcox
From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > On Fri, Dec 16, 2016 at 11:19 PM, Matthew Wilcox > wrote: > > Now ... thermal is actually using an IDR when it could save memory by using > an IDA. Are you interested in doing that conversion? > > +Cc: Mika, Vinod > > Same here for at l

Re: [PATCH v2 03/10] dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU

2016-12-19 Thread Rob Herring
On Wed, Dec 07, 2016 at 11:55:59AM -0500, Anurup M wrote: > 1) Device tree bindings for Hisilicon SoC PMU. > 2) Add example for Hisilicon L3 cache and MN PMU. > 3) Add child nodes of L3C and MN in djtag bindings example. > > Signed-off-by: Anurup M > Signed-off-by: Shaokun Zhang > --- > .../dev

Re: [PATCH v2 02/10] dt-bindings: hisi: Add Hisilicon HiP05/06/07 Djtag dts bindings

2016-12-19 Thread Rob Herring
On Wed, Dec 07, 2016 at 11:55:19AM -0500, Anurup M wrote: > From: Tan Xiaojun > > Add Hisilicon HiP05/06/07 Djtag dts bindings for CPU and IO Die > > Signed-off-by: Tan Xiaojun > Signed-off-by: Anurup M > --- > .../devicetree/bindings/arm/hisilicon/djtag.txt| 41 > ++

Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver

2016-12-19 Thread Pierre-Louis Bossart
On 12/19/16 9:55 AM, Mark Brown wrote: On Mon, Dec 19, 2016 at 09:51:47PM +0800, Shrirang Bagul wrote: + +#define DEBUG This should be production code... +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include The ordering o

Re: [PATCH v3 2/2] iio: adc: hx711: Add IIO driver for AVIA HX711

2016-12-19 Thread Lars-Peter Clausen
On 12/14/2016 05:17 PM, Andreas Klinger wrote: [...] > +#include > +#include Since you used the consumer API linux/gpio.h is not needed. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define

Re: [PATCH v3 01/15] stacktrace/x86: add function for detecting reliable stack traces

2016-12-19 Thread Miroslav Benes
On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 215612c..b4a6663 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -155,6 +155,7 @@ config X86 > select HAVE_PERF_REGS > select HAVE_PERF_USER_STACK_DUMP > select HAVE

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook > --- > driver

Re: [PATCH] tpm, tpm_crb: Handle 64-bit resource in crb_check_resource()

2016-12-19 Thread Jason Gunthorpe
On Mon, Dec 19, 2016 at 03:56:24PM +0200, Jarkko Sakkinen wrote: > On Sun, Dec 18, 2016 at 10:20:53PM -0600, Jiandi An wrote: > > crb_check_resource() in TPM CRB driver calls > > acpi_dev_resource_memory() which only handles 32-bit resources. > > Adding a call to acpi_dev_resource_address_space() i

[PATCH 1/6] KVM: vmx: clear pending interrupts on KVM_SET_LAPIC

2016-12-19 Thread Paolo Bonzini
Pending interrupts might be in the PI descriptor when the LAPIC is restored from an external state; we do not want them to be injected. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 3 +-- arch/x86/kvm/vmx.c | 9 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH 2/6] kvm: nVMX: move nested events check to kvm_vcpu_running

2016-12-19 Thread Paolo Bonzini
vcpu_run calls kvm_vcpu_running, not kvm_arch_vcpu_runnable, and the former does not call check_nested_events. Once KVM_REQ_EVENT is removed from the APICv interrupt injection path, however, this would leave no place to trigger a vmexit from L2 to L1, causing a missed interrupt delivery while in g

[PATCH v2 0/6] KVM: x86: cleanup and speedup for APICv

2016-12-19 Thread Paolo Bonzini
These are the fixed patches that now pass vmx.flat. The issue in "KVM: x86: do not scan IRR twice on APICv vmentry" was that, in v1 of the patches, kvm_cpu_get_interrupt did not scan IRR at all if it found PIR.ON=0. This is now fixed in patches 4 and 5. Another latent bug has to be fixed in patc

Re: [v2] block: check partition alignment

2016-12-19 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

*** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated

2016-12-19 Thread Markus Trippelsdorf
Running the latest kernel git tree, I get buffer overflow warnings when I try to run "perf top": *** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 51 } (gdb) bt #0 __GI_raise (sig=sig@en

[PATCH 4/6] KVM: vmx: move sync_pir_to_irr from apic_find_highest_irr to callers

2016-12-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 7 --- arch/x86/kvm/x86.c | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 4c76c602576e..4af0e105caad 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.

[PATCH 6/6] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-12-19 Thread Paolo Bonzini
Since bf9f6ac8d749 ("KVM: Update Posted-Interrupts Descriptor when vCPU is blocked", 2015-09-18) the posted interrupt descriptor is checked unconditionally for PIR.ON. Therefore we don't need KVM_REQ_EVENT to trigger the scan and, if NMIs or SMIs are not involved, we can avoid the complicated even

[PATCH 3/6] KVM: x86: preparatory changes for APICv cleanups

2016-12-19 Thread Paolo Bonzini
Add return value to __kvm_apic_update_irr/kvm_apic_update_irr. Move vmx_sync_pir_to_irr around. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 25 + arch/x86/kvm/lapic.h | 4 ++-- arch/x86/kvm/vmx.c | 32 3 files changed, 35 in

[PATCH 5/6] KVM: x86: do not scan IRR twice on APICv vmentry

2016-12-19 Thread Paolo Bonzini
Calls to apic_find_highest_irr are scanning IRR twice, once in vmx_sync_pir_from_irr and once in apic_search_irr. Change sync_pir_from_irr to get the new maximum IRR from kvm_apic_update_irr; now that it does the computation, it can also do the RVI write. In order to avoid complications in svm.c,

Re: [GIT PULL] MFD for v4.10

2016-12-19 Thread Linus Torvalds
On Mon, Dec 19, 2016 at 3:47 AM, Lee Jones wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git HEAD Nothing there. I'm assuming you meant the "for-linus-4.10" tag. Linus

[PATCH net v3 2/4] powerpc: fsl/fman: remove fsl,fman from of_device_ids[]

2016-12-19 Thread Madalin Bucur
The fsl/fman drivers will use of_platform_populate() on all supported platforms. Call of_platform_populate() to probe the FMan sub-nodes. Signed-off-by: Igal Liberman Signed-off-by: Madalin Bucur --- arch/powerpc/platforms/85xx/corenet_generic.c | 3 --- drivers/net/ethernet/freescale/fman/fman

[PATCH net v3 4/4] fsl/fman: enable compilation on ARM64

2016-12-19 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/Kconfig b/drivers/net/ethernet/freescale/fman/Kconfig index 79b7c84..dc0850b 100644 --- a/drivers/net/ethernet/free

[PATCH v2] vim2m: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/platform/vim2m.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index a98f679..9fd24b8 100644 --- a/d

Re: [RFC] block: check partition alignment

2016-12-19 Thread Stefan Haberland
Am 14.12.2016 um 18:07 schrieb Christoph Hellwig: >> To prevent partitions that are not aligned to the physical blocksize >> > of a device check for the alignment in the blkpg_ioctl. > We'd also need to reject this when reading partitions from disk, right? > I am not sure if there is a problem. I

[v2] block: check partition alignment

2016-12-19 Thread Stefan Haberland
Partitions that are not aligned to the blocksize of a device may cause invalid I/O requests because the blocklayer cares only about alignment within the partition when building requests on partitions. device |4096|4096|4096| partition offset 512byte

[PATCH net v3 3/4] fsl/fman: A007273 only applies to PPC SoCs

2016-12-19 Thread Madalin Bucur
Signed-off-by: Madalin Bucur Reviewed-by: Camelia Groza --- drivers/net/ethernet/freescale/fman/fman.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c index 0b7f711..003b86d 100644 --- a/drivers/

[PATCH net v3 1/4] fsl/fman: fix 1G support for QSGMII interfaces

2016-12-19 Thread Madalin Bucur
QSGMII ports were not advertising 1G speed. Signed-off-by: Madalin Bucur Reviewed-by: Camelia Groza --- drivers/net/ethernet/freescale/fman/mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 69ca

[PATCH net v3 0/4] fsl/fman: fixes for ARM

2016-12-19 Thread Madalin Bucur
The patch set fixes advertised speeds for QSGMII interfaces, disables A007273 erratum workaround on non-PowerPC platforms where it does not apply, enables compilation on ARM64 and addresses a probing issue on non PPC platforms. Changes from v2: merged fsl/fman changes to avoid a point of failure C

Re: [RFC PATCH 1/3] crypto: zip - Add ThunderX ZIP driver core

2016-12-19 Thread Sasha Levin
On Mon, Dec 12, 2016 at 10:04 AM, Jan Glauber wrote: > +/* error messages */ > +#define zip_err(fmt, args...) pr_err("ZIP ERR:%s():%d: " \ > + fmt "\n", __func__, __LINE__, ## args) > + > +#ifdef MSG_ENABLE > +/* Enable all messages */ > +#define zip_msg(fmt, args...) p

Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: use designated initializers

2016-12-19 Thread Geert Uytterhoeven
On Sat, Dec 17, 2016 at 2:02 AM, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecuri

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

2016-12-19 Thread Pierre-Louis Bossart
On 12/17/16 7:57 AM, Andy Shevchenko wrote: On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote: On 12/15, Pierre-Louis Bossart wrote: Clients use devm_clk_get() with a "pmc_plt_clk_" argument. This is the problem. Clients should be calling clk_get() like: clk_get(dev, "signal nam

RE: [PATCH] ARM: ep93xx: Disable TS-72xx watchdog before uncompressing

2016-12-19 Thread Hartley Sweeten
On Sunday, December 18, 2016 7:08 PM, Florian Fainelli wrote: > Le 12/11/16 à 11:16, Florian Fainelli a écrit : >> The TS-72xx/73xx boards have a CPLD watchdog which is configured to >> reset the board after 8 seconds, if the kernel is large enough that this >> takes about this time to decompress t

Re: [RFC 0/1] New PCI Switch Management Driver

2016-12-19 Thread Myron Stowe
I guess the obvious questions is: why is a driver for a PCI switch necessary? The core works with all compliant switches today and there are no specifics for a particular design or such. So I guess I'd like to hear the reasoning and justifications for why a driver for a common device that should

Re: [PATCH] x86/microcode: Adjust ramdisk address when accessing by virtual address

2016-12-19 Thread Boris Ostrovsky
On 12/19/2016 10:37 AM, Borislav Petkov wrote: > On Mon, Dec 19, 2016 at 10:32:13AM -0500, Boris Ostrovsky wrote: >> When searching for microcode in the ramdisk image we need to adjust the >> start address after paging has been turned on (in 32-bit mode). > I need more info: > > * Is this fixing a

Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread David Miller
From: Pavel Machek Date: Sun, 18 Dec 2016 21:38:12 +0100 > Fix up memory barriers in stmmac driver. They are meant to protect > against DMA engine, so smp_ variants are certainly wrong, and dma_ > variants are preferable. > > Signed-off-by: Pavel Machek Applied.

Re: [PATCH 1/1] xfs: silent -Wformat-security warning

2016-12-19 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 02:41:11PM +0100, Nicolas Iooss wrote: > When building the XFS driver with clang, the compiler reports a > -Wformat-security warning in xlog_recover_validate_buf_type() because > xfs_warn() is being called with a non-literal string. Even though > variable warnmsg is always i

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-19 Thread Rob Herring
On Mon, Dec 19, 2016 at 2:14 AM, Dongpo Li wrote: > Hi Rob and David, > > On 2016/12/12 22:21, Rob Herring wrote: >> On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li wrote: >>> Hi Rob, >>> >>> On 2016/12/10 6:35, Rob Herring wrote: On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: [...]

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

2016-12-19 Thread David Miller
From: Arvind Yadav Date: Thu, 15 Dec 2016 00:33:30 +0530 > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > This error check will avoid NULL pointer dereference. > > Signed-off-by: Arvind Yadav Since ioremap() is in fact designed to poss

Re: [RFC PATCH 1/3] crypto: zip - Add ThunderX ZIP driver core

2016-12-19 Thread Jan Glauber
Hi Corentin, thanks for your review! Your comments all look reasonable to me, Mahipal will address them. Since I posted this series at the beginning of the merge window I'd like to wait for some more time before we post an updated version. --Jan On Tue, Dec 13, 2016 at 02:39:00PM +0100, Corenti

Re: [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver

2016-12-19 Thread Mark Brown
On Mon, Dec 19, 2016 at 09:51:47PM +0800, Shrirang Bagul wrote: > + > +#define DEBUG This should be production code... > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include The ordering of the headers is ve

RE: [PATCH 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor

2016-12-19 Thread Appana Durga Kedareswara Rao
Hi Laurent Pinchart, Thanks for the review... > > > > + if (!chan->idle) > > + return; > > Don't you need to perform the same check for the DMA and CDMA channels ? If > so, shouldn't this be moved to common code ? Will fix it in v2... > > There's another problem (not stric

RE: [PATCH 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma

2016-12-19 Thread Appana Durga Kedareswara Rao
Hi Jose Miguel Abreu, Thanks for the review... > > > >>> - last = segment; > >>> + for (j = 0; j < chan->num_frms; ) { > >>> + list_for_each_entry(segment, &desc->segments, node) > >> { > >>> + if (chan->ext_addr) > >>> +

[PATCH] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-by: Stefan Wahre

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-19 Thread Vinod Koul
On Sun, Dec 18, 2016 at 11:06:42PM -0600, Andy Gross wrote: > On Sun, Dec 18, 2016 at 09:56:02PM +0530, Vinod Koul wrote: > > On Thu, Dec 15, 2016 at 03:25:52PM +0530, Abhishek Sahu wrote: > > > The current DMA APIs only support SGL or data in generic format. > > > The QCA BAM DMA engine data canno

[GIT PULL v2] KVM fixes for 4.10 merge window

2016-12-19 Thread Paolo Bonzini
Linus, The following changes since commit cdb98c2698b4af287925abcba4d77d92af82a0c3: Revert "nvme: add support for the Write Zeroes command" (2016-12-13 19:53:37 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch cha

Re: [PATCH 2/2] nvme: improve cmb sysfs reporting

2016-12-19 Thread Jon Derrick
Minor nit below On Fri, Dec 16, 2016 at 11:54:51AM -0700, Stephen Bates wrote: > Add more information to the NVMe CMB sysfs entry. This includes > information about the CMB size, location and capabilities. > > Signed-off-by: Stephen Bates > --- > drivers/nvme/host/pci.c | 31 +++

Re: [PATCH 1/2] ASoC: rt5660: Add ACPI support

2016-12-19 Thread Mark Brown
On Mon, Dec 19, 2016 at 09:51:46PM +0800, Shrirang Bagul wrote: > +static const struct acpi_gpio_params audio_wake_intr_gpio = { 0, 0, false }; > +static const struct acpi_gpio_params lineout_mute_gpio = { 1, 0, true }; Can we please write these in a fashion more idiomatic for the kernel and usef

RE: [PATCH 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma

2016-12-19 Thread Appana Durga Kedareswara Rao
Hi Laurent Pinchart, Thanks for the review... > > + int i = 0, j = 0; > > > > if (chan->desc_submitcount < chan->num_frms) > > i = chan->desc_submitcount; > > I don't get this. i seems to index into a segment start address array, but > gets > in

Re: [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs

2016-12-19 Thread Jens Axboe
On 12/16/2016 11:54 AM, Stephen Bates wrote: > Hi > > This series adds some more verbosity to the NVMe CMB sysfs entry. > > Jens I based this off v4.9 because for some reason your for-4.10/block > is missing my original CMB commit (202021c1a63c6)? > > Stephen > > Stephen Bates (2): > nvme : U

Re: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[]

2016-12-19 Thread David Miller
From: Madalin Bucur Date: Mon, 19 Dec 2016 11:22:20 +0200 > The fsl/fman drivers will use of_platform_populate() on all > supported platforms. > > Signed-off-by: Madalin Bucur It seems that this creates a failure point between patches #2 and #3. If the cases handled by this "fsl,fman" entry a

Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread Giuseppe CAVALLARO
On 12/18/2016 9:38 PM, Pavel Machek wrote: Fix up memory barriers in stmmac driver. They are meant to protect against DMA engine, so smp_ variants are certainly wrong, and dma_ variants are preferable. Signed-off-by: Pavel Machek Acked-by: Giuseppe Cavallaro diff --git a/drivers/net/ethe

Re: [PATCH] x86/microcode: Adjust ramdisk address when accessing by virtual address

2016-12-19 Thread Borislav Petkov
On Mon, Dec 19, 2016 at 10:32:13AM -0500, Boris Ostrovsky wrote: > When searching for microcode in the ramdisk image we need to adjust the > start address after paging has been turned on (in 32-bit mode). I need more info: * Is this fixing a real issue? * how do you reproduce this? * kernel ver

Re: [PATCH RESEND] block: allow WRITE_SAME commands with the SG_IO ioctl

2016-12-19 Thread Jens Axboe
On 12/15/2016 10:48 AM, Mauricio Faria de Oliveira wrote: > The WRITE_SAME commands are not present in the blk_default_cmd_filter > write_ok list, and thus are failed with -EPERM when the SG_IO ioctl() > is executed without CAP_SYS_RAWIO capability (e.g., unprivileged users). > [ sg_io() -> blk_fil

Re: [PATCHSET v4] blk-mq-scheduling framework

2016-12-19 Thread Jens Axboe
On 12/19/2016 08:20 AM, Jens Axboe wrote: > On 12/19/2016 04:32 AM, Paolo Valente wrote: >> >>> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >>> >>> This is version 4 of this patchset, version 3 was posted here: >>> >>> https://marc.info/?l=linux-block&m=148178513407631&w=2 >>> >>

[PATCH] x86/microcode: Adjust ramdisk address when accessing by virtual address

2016-12-19 Thread Boris Ostrovsky
When searching for microcode in the ramdisk image we need to adjust the start address after paging has been turned on (in 32-bit mode). Signed-off-by: Boris Ostrovsky --- arch/x86/kernel/cpu/microcode/core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/

[PATCH v3] usb: musb: debugfs: allow forcing host mode together with speed in testmode

2016-12-19 Thread Pali Rohár
Based on the musb ug, force_host bit is allowed to be set along with force_hs or force_fs bit. It could help to implement forced host mode via testmode on Nokia N900. Signed-off-by: Pali Rohár --- Changes in v2: * Use == instead of & for comparison of testmode Changes in v3: * Increase buf[] to

Re: [PATCHSET v4] blk-mq-scheduling framework

2016-12-19 Thread Jens Axboe
On 12/19/2016 04:32 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is version 4 of this patchset, version 3 was posted here: >> >> https://marc.info/?l=linux-block&m=148178513407631&w=2 >> >> From the discussion last time, I looked into the

Re: [PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal()

2016-12-19 Thread Michal Hocko
On Sun 18-12-16 14:47:50, Wei Yang wrote: > memblock_reserve() may fail in case there is not enough regions. Have you seen this happenning in the real setups or this is a by-review driven change? [...] > again: > alloc = memblock_find_in_range_node(size, align, min_addr, max_addr, >

Re: [PATCH 1/2] nvme : Use correct scnprintf in cmb show

2016-12-19 Thread Jon Derrick
Looks good. Thanks Stephen. Reviewed-by Jon Derrick: On Fri, Dec 16, 2016 at 11:54:50AM -0700, Stephen Bates wrote: > Make sure we are using the correct scnprintf in the sysfs show > function for the CMB. > > Signed-off-by: Stephen Bates > --- > drivers/nvme/host/pci.c | 4 ++-- > 1 file chan

[PATCH] proc: use rb_entry()

2016-12-19 Thread Geliang Tang
To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang --- fs/proc/generic.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 7eb3cef..f842650 100644 --- a/fs/p

[PATCH] mfd: palmas: constify struct regmap_irq_chip

2016-12-19 Thread Corentin Labbe
From: LABBE Corentin The regmap_irq_chip struct is never modified and so can be set as const. This permit to remove a casted access to match->data and use the proper of_device_get_match_data() Signed-off-by: Corentin Labbe --- drivers/mfd/palmas.c | 22 +- 1 file changed, 9

[PATCH] ASoC: wm_adsp: Don't overrun firmware file buffer when reading region data

2016-12-19 Thread Richard Fitzgerald
Protect against corrupt firmware files by ensuring that the length we get for the data in a region actually lies within the available firmware file data buffer. Signed-off-by: Richard Fitzgerald --- sound/soc/codecs/wm_adsp.c | 25 - 1 file changed, 24 insertions(+), 1 de

Re: [PATCH net-next v4 2/4] dt-bindings: net: add EEE capability constants

2016-12-19 Thread Jerome Brunet
Hi Rob, First, Thx for this information and sorry for this late reply As you may have seen yourself, there was little bit of confusion while discussing this patch series. The point is the v3 was applied before your reply (patches 2 and 3 not combined unfortunately). Because of this confusion, the

[PATCH] staging: comedi: cb_pcidas64: Fixed coding issue about multiple line dereferencing

2016-12-19 Thread devendra sharma
Fixed coding issue about multiple line dereferencing Signed-off-by: Devendra Sharma --- drivers/staging/comedi/drivers/cb_pcidas64.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb

Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-19 Thread Michal Hocko
On Sun 18-12-16 14:47:49, Wei Yang wrote: > The base address is already guaranteed to be in the region by > memblock_search(). First of all the way how the check is removed is the worst possible... Apart from that it is really not clear to me why checking the base is not needed. You are mentioning

Re: [RFC v2 4/5] rcu: Use for_each_leaf_node_cpu() in force_qs_rnp()

2016-12-19 Thread Boqun Feng
On Thu, Dec 15, 2016 at 02:51:36PM +, Colin Ian King wrote: > On 15/12/16 14:42, Boqun Feng wrote: > > On Thu, Dec 15, 2016 at 12:04:59PM +, Mark Rutland wrote: > >> On Thu, Dec 15, 2016 at 10:42:03AM +0800, Boqun Feng wrote: > >>> ->qsmask of an RCU leaf node is usually more sparse than th

Re: [PATCH v2] usb: musb: debugfs: allow forcing host mode together with speed in testmode

2016-12-19 Thread Bin Liu
On Sun, Dec 18, 2016 at 12:54:40AM +0100, Pali Rohár wrote: > Based on the musb ug, force_host bit is allowed to be set along with > force_hs or force_fs bit. > > It could help to implement forced host mode via testmode on Nokia N900. > > Signed-off-by: Pali Rohár > --- > Changes in v2: > * Use

<    1   2   3   4   5   6   7   >