Re: Mistake in include IS_ENABLED(CONFIG_LIVEPATCH)

2017-02-10 Thread Jiri Kosina
On Sat, 11 Feb 2017, Denys Fedoryshchenko wrote: > I noticed that sample of livepatch is not working in 4.9.9, because in > include, > linux/livepatch.h > it is: > #if IS_ENABLED(CONFIG_LIVEPATCH) > > while config option is: > CONFIG_HAVE_LIVEPATCH=y > > After editing livepatch.h sample module c

Re: [PATCH] ASoC: fsl_sai: support more than 2 channels

2017-02-10 Thread Nicolin Chen
On Fri, Feb 10, 2017 at 07:42:43PM +0100, Alexandre Belloni wrote: > The FSL SAI can support up to 32 channels using TDM. Report that value so > they can actually be used. > > Tested using 8 channels. > > Signed-off-by: Alexandre Belloni Acked-by: Nicolin Chen > --- > sound/soc/fsl/fsl_sai.c

Re: [PULL] IIO fixes for 4.10 set 3 - a couple of regression fixes.

2017-02-10 Thread Greg Kroah-Hartman
On Fri, Feb 10, 2017 at 11:35:35PM +0100, Peter Rosin wrote: > > On Sun, Feb 05, 2017 at 10:35:02AM +, Jonathan Cameron wrote: > >> The following changes since commit > >> 5c113b5e0082e90d2e1c7b12e96a7b8cf0623e27: > >> > >> iio: dht11: Use usleep_range instead of msleep for start signal >

Re: [PATCH] device-dax: don't set kobj parent during cdev init

2017-02-10 Thread Greg Kroah-Hartman
On Fri, Feb 10, 2017 at 02:25:35PM -0800, Dan Williams wrote: > On Fri, Feb 10, 2017 at 12:17 PM, Greg Kroah-Hartman > wrote: > > On Fri, Feb 10, 2017 at 11:41:20AM -0800, Dan Williams wrote: > >> On Fri, Feb 10, 2017 at 11:19 AM, Logan Gunthorpe > >> wrote: > >> > I copied this code and per fee

Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task activated after the deadline

2017-02-10 Thread luca abeni
Hi Daniel, On Fri, 10 Feb 2017 20:48:11 +0100 Daniel Bristot de Oliveira wrote: > During the activation, CBS checks if it can reuse the current task's > runtime and period. If the deadline of the task is in the past, CBS > cannot use the runtime, and so it replenishes the task. This rule > works

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-10 Thread luca abeni
Hi Daniel, On Fri, 10 Feb 2017 20:48:10 +0100 Daniel Bristot de Oliveira wrote: [...] > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index 70ef2b1..3c94d85 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -505,10 +505,15 @@ static void update_dl_ent

Re: [GIT PULL] PCI fixes for v4.10

2017-02-10 Thread Yinghai Lu
On Fri, Feb 10, 2017 at 6:39 PM, Yinghai Lu wrote: > Ashok, > > Can ask your QA guys check only attached patch and commit 68db9bc ? more clean patches: split that into two small patches. Thanks Yinghai From 68db9bc814362e7f24371c27d12a4f34477d9356 Mon Sep 17 00:00:00 2001 From: Lukas Wunner Da

[PATCH] HID: intel-ish-hid: constify device_type structure

2017-02-10 Thread Bhumika Goyal
Declare device_type structure as const as it is only stored in the type field of a device structure. This field is of type const, so add const to the declaration of device_type structure. File size before: drivers/hid/intel-ish-hid/ishtp/bus.o textdata bss dec hex filename 42

Re: [PATCH] staging: rtl8192u: Fix brace placement

2017-02-10 Thread Greg KH
On Sat, Feb 11, 2017 at 10:46:27AM +0530, simran singhal wrote: > Fix brace placement errors caught by checkpatch.pl ERROR: that open > brace { should be on the previous line > > Signed-off-by: simran singhal > --- > .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 90 >

Re: [PATCH] staging: rtl8192u: Removing multiple blank lines

2017-02-10 Thread Greg KH
On Sat, Feb 11, 2017 at 09:34:12AM +0530, SIMRAN SINGHAL wrote: > Multiple patches ...? You sent me lots of patches, how am I supposed to know which one to apply in what order? > Can you please clarify what all patches you are including in "Multiple > Patches". Everything you have sent me. > A

Re: [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue

2017-02-10 Thread Greg KH
On Sat, Feb 11, 2017 at 07:48:35AM +0530, Arushi Singhal wrote: > Hi > Sorry Greg but how this not applying to your mailing list. Your patch did not apply to my staging-next git tree. Probably because soemone else already did this same work before you did. Try rebasing your patch on my staging-n

[PATCH] rbd: constify device_type structure

2017-02-10 Thread Bhumika Goyal
Declare device_type structure as const as it is only stored in the type field of a device structure. This field is of type const, so add const to the declaration of device_type structure. File size before: textdata bss dec hex filename 61546 11610 208 73364 11e94 dri

Re: [PATCH v4] fork: free vmapped stacks in cache when cpus are offline

2017-02-10 Thread Michal Hocko
On Sat 11-02-17 08:40:38, Hoeun Ryu wrote: > Using virtually mapped stack, kernel stacks are allocated via vmalloc. > In the current implementation, two stacks per cpu can be cached when > tasks are freed and the cached stacks are used again in task duplications. > but the cached stacks may remain

[GIT PULL] SCSI fixes for 4.10-rc7

2017-02-10 Thread James Bottomley
Six fairly small fixes. None is a real show stopper, two automation detected problems: one memory leak, one use after free and four others each of which fixes something that has been a significant source of annoyance to someone. The patch is available here: git://git.kernel.org/pub/scm/linux/ker

Re: [PATCH] f2fs: introduce nid cache

2017-02-10 Thread Chao Yu
On 2017/2/9 9:28, Jaegeuk Kim wrote: > On 02/08, Chao Yu wrote: >> On 2017/2/7 15:24, Chao Yu wrote: >>> Hi Jaegeuk, >>> >>> Happy Chinese New Year! :) >>> >>> On 2017/1/24 12:35, Jaegeuk Kim wrote: Hi Chao, On 01/22, Chao Yu wrote: > In scenario of intensively node allocation, f

[PATCH] staging: rtl8192u: Fix RETURN_VOID warnings

2017-02-10 Thread simran singhal
Fix 'void function return statements are not generally useful' checkpatch.pl warnings. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/stagin

[PATCH] staging: rtl8192u: Fix brace placement

2017-02-10 Thread simran singhal
Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: simran singhal --- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 90 -- 1 file changed, 30 insertions(+), 60 deletions(-) diff --git a/drivers/sta

Mistake in include IS_ENABLED(CONFIG_LIVEPATCH)

2017-02-10 Thread Denys Fedoryshchenko
Hello, I noticed that sample of livepatch is not working in 4.9.9, because in include, linux/livepatch.h it is: #if IS_ENABLED(CONFIG_LIVEPATCH) while config option is: CONFIG_HAVE_LIVEPATCH=y After editing livepatch.h sample module compiles fine Probably that's just a typo?

[PATCH] staging: dgnc: dgnc_tty.c: fix argument list alignment issue.

2017-02-10 Thread Nathan Howard
Fix checkpatch.pl issue of the form: "CHECK: Alignment should match open parenthesis". Signed-off-by: Nathan Howard --- drivers/staging/dgnc/dgnc_tty.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c

Re: [PATCH v2] arm64: dts: Enable ir-spi in the tm2 and tm2e boards

2017-02-10 Thread Andi Shyti
Hi Javier, On Fri, Feb 10, 2017 at 11:04:50AM -0300, Javier Martinez Canillas wrote: > On 02/09/2017 11:22 PM, Andi Shyti wrote: ... > > + irda_regulator: irda-regulator { > > + compatible = "regulator-fixed"; > > + enable-active-high; > > + gpio = <&gpr3 3 GPIO_ACT

Re: module: Optimize search_module_extables()

2017-02-10 Thread Jessica Yu
+++ Peter Zijlstra [08/02/17 15:48 +0100]: While looking through the __ex_table stuff I found that we do a linear lookup of the module. Also fix up a comment. Signed-off-by: Peter Zijlstra (Intel) Applied, thanks. Hm. A quick scan through module.c still shows a couple of places that use sim

[PATCH] staging: greybus: arpc.h: remove duplicate line.

2017-02-10 Thread Nathan Howard
Fix checkpatch.pl issue of the form: "CHECK: Please don't use multiple blank lines". Signed-off-by: Nathan Howard --- drivers/staging/greybus/arpc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/arpc.h b/drivers/staging/greybus/arpc.h index 7fbddfc..c0b63c0 100644 --

Re: [PATCH] staging: rtl8192u: Removing multiple blank lines

2017-02-10 Thread SIMRAN SINGHAL
Multiple patches ...? Can you please clarify what all patches you are including in "Multiple Patches". And the Order you should go for is the order in which I submitted them. On Sat, Feb 11, 2017 at 7:48 AM, SIMRAN SINGHAL wrote: > Multiple patches ...? > Can you please clarify what all patches

[PATCH] block/loop: fix race between I/O and set_status

2017-02-10 Thread Ming Lei
Inside set_status, transfer need to setup again, so we have to drain IO before the transition, otherwise oops may be triggered like the following: divide error: [#1] SMP KASAN CPU: 0 PID: 2935 Comm: loop7 Not tainted 4.10.0-rc7+ #213 Hardware name: QEMU Standard PC (i4

Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-10 Thread Joe Perches
On Sat, 2017-02-11 at 01:32 +, Roberts, William C wrote: > > > > By "normal" I'm referring to things that call into pointer(), just > > > casually looking I see bstr_printf vsnprintf kvasprintf, which would > > > be easy enough to add > > > > > > > What do you think is missing? sn?printf ? T

Re: [PATCH 3/3] DT: add Faraday Tec. as vendor

2017-02-10 Thread Joel Stanley
On Fri, Feb 10, 2017 at 11:46 PM, Linus Walleij wrote: > On Wed, Feb 8, 2017 at 9:00 PM, Hans Ulli Kroll > wrote: > >> add Faraday Technology Corporation as vendor faraday for DT >> >> Signed-off-by: Hans Ulli Kroll > > Reviewed-by: Linus Walleij > > I think I should use this for the PCI block

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Joel Stanley
Hey Greg, On Sat, Feb 11, 2017 at 1:00 AM, Greg KH wrote: > On Wed, Feb 08, 2017 at 10:42:47AM +1100, Cyril Bur wrote: >> In order to manage server systems, there is typically another processor >> known as a BMC (Baseboard Management Controller) which is responsible >> for powering the server and

Re: [GIT PULL] PCI fixes for v4.10

2017-02-10 Thread Yinghai Lu
On Thu, Feb 9, 2017 at 12:11 PM, Bjorn Helgaas wrote: > On Thu, Feb 09, 2017 at 09:09:50AM -0600, Bjorn Helgaas wrote: >> [+cc Ashok, Keith] >> >> On Thu, Feb 09, 2017 at 05:06:48AM +0100, Lukas Wunner wrote: >> > On Wed, Feb 08, 2017 at 01:22:56PM -0600, Bjorn Helgaas wrote: >> > > Bjorn Helgaas

[PATCH v6 2/8] devicetree: property-units: Add uWh and uAh units

2017-02-10 Thread Liam Breck
From: Matt Ranostay Add entries for microwatt-hours and microamp-hours. Cc: Rob Herring Cc: Mark Rutland Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Matt Ranostay Signed-off-by: Liam Breck Acked-by: Sebastian Reichel Acked-by: Rob Herring --- Documentati

Re: Is it really safe to use workqueues to drive expedited grace periods?

2017-02-10 Thread Tejun Heo
Hello, Paul. On Fri, Feb 10, 2017 at 01:21:58PM -0800, Paul E. McKenney wrote: > So RCU's expedited grace periods have been using workqueues for a > little while, and things seem to be working. But as usual, I worry... > Is this use subject to some sort of deadlock where RCU's workqueue cannot >

Re: [RFC PATCH 2/2] mm/sparse: add last_section_nr in sparse_init() to reduce some iteration cycle

2017-02-10 Thread Tejun Heo
Hello, On Sat, Feb 11, 2017 at 10:18:29AM +0800, Wei Yang wrote: > During the sparse_init(), it iterate on each possible section. On x86_64, > it would always be (2^19) even there is not much memory. For example, on a > typical 4G machine, it has only (2^5) to (2^6) present sections. This > benefi

[RFC PATCH 2/2] mm/sparse: add last_section_nr in sparse_init() to reduce some iteration cycle

2017-02-10 Thread Wei Yang
During the sparse_init(), it iterate on each possible section. On x86_64, it would always be (2^19) even there is not much memory. For example, on a typical 4G machine, it has only (2^5) to (2^6) present sections. This benefits more on a system with smaller memory. This patch calculates the last s

[RFC PATCH 1/2] mm/memblock: introduce for_each_mem_pfn_range_rev()

2017-02-10 Thread Wei Yang
This patch introduces the helper function for_each_mem_pfn_range_rev() for later use. Signed-off-by: Wei Yang --- include/linux/memblock.h | 18 ++ mm/memblock.c| 39 ++- 2 files changed, 56 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after_init

2017-02-10 Thread John Stultz
On Fri, Feb 10, 2017 at 5:37 PM, Jess Frazelle wrote: > Marked syscore_ops structs as __ro_after_init when register_syscore_ops was > called only during init. Most of the caller functions were already annotated > as > __init. > unregister_syscore_ops() was never called on these ops. > This protec

[PATCH v13 07/12] usb: ehci: use bus->sysdev for DMA configuration

2017-02-10 Thread Peter Chen
Set the dma for ehci from sysdev. The sysdev is pointing to device that is known to the system firmware or hardware. Cc: Arnd Bergmann Cc: Sriram Dash Signed-off-by: Peter Chen Acked-by: Alan Stern --- drivers/usb/host/ehci-mem.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions

[PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

2017-02-10 Thread Peter Chen
From: Arnd Bergmann For xhci-hcd platform device, all the DMA parameters are not configured properly, notably dma ops for dwc3 devices. So, set the dma for xhci from sysdev. sysdev is pointing to device that is known to the system firmware or hardware. Cc: Baolin Wang Cc: Vivek Gautam Cc: Alex

[PATCH v13 10/12] ARM: dts: imx6qdl: Enable usb node children with

2017-02-10 Thread Peter Chen
From: Joshua Clayton Give usb nodes #address and #size attributes, so that a child node representing a permanently connected device such as an onboard hub may be addressed with a attribute Signed-off-by: Joshua Clayton Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl.dtsi | 6 ++

[PATCH v13 02/12] power: add power sequence library

2017-02-10 Thread Peter Chen
We have an well-known problem that the device needs to do some power sequence before it can be recognized by related host, the typical example like hard-wired mmc devices and usb devices. This power sequence is hard to be described at device tree and handled by related host driver, so we have crea

[PATCH v13 00/12] power: add power sequence library

2017-02-10 Thread Peter Chen
Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2]. The kinds of power sequence instances will be added at postcore_initcall, the match criteria is compatible string first, if the compatible string is not matched b

[PATCH v13 12/12] ARM: dts: imx6q-evi: Fix onboard hub reset line

2017-02-10 Thread Peter Chen
From: Joshua Clayton Previously the onboard hub was made to work by treating its reset gpio as a regulator enable. Get rid of that kludge now that pwseq has added reset gpio support Move pin muxing the hub reset pin into the usbh1 group Signed-off-by: Joshua Clayton Signed-off-by: Peter Chen -

[PATCH v13 03/12] usb: separate out sysdev pointer from usb_bus

2017-02-10 Thread Peter Chen
From: Arnd Bergmann For xhci-hcd platform device, all the DMA parameters are not configured properly, notably dma ops for dwc3 devices. The idea here is that you pass in the parent of_node along with the child device pointer, so it would behave exactly like the parent already does. The differenc

[PATCH v13 04/12] usb: chipidea: use bus->sysdev for DMA configuration

2017-02-10 Thread Peter Chen
From: Arnd Bergmann Set the dma for chipidea from sysdev. This is inherited from its parent node. Also, do not set dma mask for child as it is not required now. Signed-off-by: Arnd Bergmann Signed-off-by: Sriram Dash Acked-by: Peter Chen Signed-off-by: Mathias Nyman --- drivers/usb/chipidea

[PATCH v13 11/12] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2017-02-10 Thread Peter Chen
The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Besides, using gpio pinctrl setting for USB2415's reset pin. Signed-off-by: Peter Chen Signed-off-by: Josh

[PATCH v13 09/12] usb: core: add power sequence handling for USB devices

2017-02-10 Thread Peter Chen
Some hard-wired USB devices need to do power sequence to let the device work normally, the typical power sequence like: enable USB PHY clock, toggle reset pin, etc. But current Linux USB driver lacks of such code to do it, it may cause some hard-wired USB devices works abnormal or can't be recogniz

[PATCH] net: ethernet: ti: cpsw: return NET_XMIT_DROP if skb_padto failed

2017-02-10 Thread Ivan Khoronzhuk
If skb_padto failed the skb has been dropped already, so it was consumed, but it doesn't mean it was sent, thus no need to update queue tx time, etc. So, return NET_XMIT_DROP as more appropriate. Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/cpsw.c | 2 +-

[PATCH v13 05/12] usb: ehci: fsl: use bus->sysdev for DMA configuration

2017-02-10 Thread Peter Chen
From: Arnd Bergmann For the dual role ehci fsl driver, sysdev will handle the dma config. Signed-off-by: Arnd Bergmann Signed-off-by: Sriram Dash Signed-off-by: Mathias Nyman --- drivers/usb/host/ehci-fsl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/h

[PATCH v13 01/12] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2017-02-10 Thread Peter Chen
Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/binding

[PATCH v13 08/12] binding-doc: usb: usb-device: add optional properties for power sequence

2017-02-10 Thread Peter Chen
Add optional properties for power sequence. Signed-off-by: Peter Chen Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentatio

[PATCH] usb: musb: add code comment for clarification

2017-02-10 Thread Gustavo A. R. Silva
Add code comment to make it clear that the fall-through is intentional. Read the link for more details: https://lkml.org/lkml/2017/2/9/292 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/musb/musb_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_core.c b/drive

Re: [PATCH 2/3] Bluetooth: cmtp: fix possible might sleep error in cmtp_session

2017-02-10 Thread Brian Norris
Hi, On Tue, Jan 24, 2017 at 12:07:50PM +0800, Jeffy Chen wrote: > It looks like cmtp_session has same pattern as the issue reported in > old rfcomm: > > while (1) { > set_current_state(TASK_INTERRUPTIBLE); > if (condition) > break; >

Re: Linux 4.9.6 ( Restore IO-APIC irq_chip retrigger callback , breaks my box )

2017-02-10 Thread Gabriel C
On 11.02.2017 00:17, Gabriel C wrote: Btw, how far in the boot process is the machine when this happens? Right after : Uncompressing Linux. Booting the kernel.. So early.. After lots more boots .. I found out sometimes it gets to : .. [4.656826] Key type dns_resolver registe

Re: [PATCH 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session

2017-02-10 Thread Brian Norris
Hi, On Tue, Jan 24, 2017 at 12:07:49PM +0800, Jeffy Chen wrote: > It looks like bnep_session has same pattern as the issue reported in > old rfcomm: > > while (1) { > set_current_state(TASK_INTERRUPTIBLE); > if (condition) > break; >

[PATCH v2 4/5] staging: set msi_domain_ops as __ro_after_init

2017-02-10 Thread Jess Frazelle
Marked msi_domain_ops structs as __ro_after_init when called only during init. This protects the data structure from accidental corruption. Suggested-by: Kees Cook Signed-off-by: Jess Frazelle --- drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH v2 5/5] x86: set msi_domain_ops as __ro_after_init

2017-02-10 Thread Jess Frazelle
Marked msi_domain_ops structs as __ro_after_init when called only during init. This protects the data structure from accidental corruption. Suggested-by: Kees Cook Signed-off-by: Jess Frazelle --- arch/x86/kernel/apic/msi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 2/5] time: mark syscore_ops as __ro_after_init

2017-02-10 Thread Jess Frazelle
Marked syscore_ops structs as __ro_after_init when register_syscore_ops was called only during init. Most of the caller functions were already annotated as __init. unregister_syscore_ops() was never called on these ops. This protects the data structure from accidental corruption. Suggested-by: Kee

[PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-02-10 Thread Jess Frazelle
Marked msi_domain_ops structs as __ro_after_init when called only during init. This protects the data structure from accidental corruption. Suggested-by: Kees Cook Signed-off-by: Jess Frazelle --- drivers/pci/host/pci-hyperv.c | 2 +- drivers/pci/host/vmd.c| 2 +- drivers/pci/msi.c

[PATCH v2 1/5] irq: set {msi_domain,syscore}_ops as __ro_after_init

2017-02-10 Thread Jess Frazelle
Marked msi_domain_ops structs as __ro_after_init when called only during init. Marked syscore_ops structs as __ro_after_init when register_syscore_ops was called only during init. Most of the caller functions were already annotated as __init. unregister_syscore_ops() was never called on these sysco

RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-10 Thread Roberts, William C
> > By "normal" I'm referring to things that call into pointer(), just > > casually looking I see bstr_printf vsnprintf kvasprintf, which would > > be easy enough to add > > > > > What do you think is missing? sn?printf ? That's easy to add. > > > > The problem starts to get hairy when we think o

Tracebacks in -next due to 'of: fix of_node leak caused in of_find_node_opts_by_path'

2017-02-10 Thread Guenter Roeck
Hi, I see a number of tracebacks in test runs on qemu-next, all related to omap configurations. Here is an example: [0.00] OF: ERROR: Bad of_node_put() on /ocp@6800 [0.00] CPU: 0 PID: 0 Comm: swapper/0 Tainted: GW 4.10.0-rc7-next-20170210 #1 [0.00] Hardware

Is it really safe to use workqueues to drive expedited grace periods?

2017-02-10 Thread Paul E. McKenney
Hello! So RCU's expedited grace periods have been using workqueues for a little while, and things seem to be working. But as usual, I worry... Is this use subject to some sort of deadlock where RCU's workqueue cannot start running until after a grace period completes, but that grace period is the

Re: [PATCH 3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread

2017-02-10 Thread Brian Norris
Hi Jeffy, I'm really not an expert on bluetooth or HIDP, but I can't bring myself to say that this is correct. I still think you have a problem. On Tue, Jan 24, 2017 at 12:07:51PM +0800, Jeffy Chen wrote: > It looks like hidp_session_thread has same pattern as the issue reported in > old rfcomm:

RE: [Resend PATCH 1/2 v3] pci-hyperv: properly handle pci bus remove

2017-02-10 Thread Long Li
Hi Bjorn, This patch and the other one in the series ([Resend PATCH 2/2 v3] pci-hyperv: lock pci bus on device eject) have been Acked. Is there anything else should be done before it can be merged? Please let me know. Thanks Long > -Original Message- > From: KY Srinivasan > Sent: Fri

Re: [PATCH 0/2] net: ethernet: ti: cpsw: fix susp/resume

2017-02-10 Thread Ivan Khoronzhuk
On Fri, Feb 10, 2017 at 12:05:07PM -0600, Grygorii Strashko wrote: > > > On 02/09/2017 07:45 PM, David Miller wrote: > >From: Ivan Khoronzhuk > >Date: Fri, 10 Feb 2017 00:54:24 +0200 > > > >>On Thu, Feb 09, 2017 at 05:21:26PM -0500, David Miller wrote: > >>>From: Ivan Khoronzhuk > >>>Date: Thu,

[PATCH] Staging: media: platform: bcm2835 - style fix

2017-02-10 Thread Derek Robson
Changed permissions to octal style Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/platform/bcm2835/bcm2835-camera.c b/drivers/staging/m

Re: [PATCH] net: ethernet: ti: netcp_core: return netdev_tx_t in xmit

2017-02-10 Thread Ivan Khoronzhuk
On Fri, Feb 10, 2017 at 02:45:21PM -0500, David Miller wrote: > From: Ivan Khoronzhuk > Date: Thu, 9 Feb 2017 16:24:14 +0200 > > > @@ -1300,7 +1301,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, > > struct net_device *ndev) > > dev_warn(netcp->ndev_dev, "padding f

[PATCH] Staging: media: lirc - style fix

2017-02-10 Thread Derek Robson
Changed permissions to octal across whole driver Found by checkpatch Signed-off-by: Derek Robson --- drivers/staging/media/lirc/lirc_sasem.c | 2 +- drivers/staging/media/lirc/lirc_sir.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/lirc/lir

Re: [PATCH v1 0/5] md: use bio_clone_fast()

2017-02-10 Thread Shaohua Li
On Fri, Feb 10, 2017 at 06:56:12PM +0800, Ming Lei wrote: > Hi, > > This patches replaces bio_clone() with bio_fast_clone() in > bio_clone_mddev() because: > > 1) bio_clone_mddev() is used in raid normal I/O and isn't in > resync I/O path, and all the direct access to bvec table in > raid happens

[PATCH v2 1/9] sysctl: fix lax sysctl_check_table() sanity check

2017-02-10 Thread Luis R. Rodriguez
Commit 7c60c48f58a7 ("sysctl: Improve the sysctl sanity checks") improved sanity checks considerbly, however the enhancements on sysctl_check_table() meant adding a functional change so that only the last table entry's sanity error is propagated. It also changed the way errors were propagated so th

[PATCH v2 9/9] test_sysctl: test against int proc_dointvec() array support

2017-02-10 Thread Luis R. Rodriguez
Add a few initial respective tests for an array: o Echoing values separated by spaces works o Echoing only first elements will set first elements o Confirm PAGE_SIZE limit still applies even if an array is used Signed-off-by: Luis R. Rodriguez --- lib/test_sysctl.c

[rcu:rcu/dev 31/38] kernel/rcu/rcu_segcblist.h:77:2: error: implicit declaration of function 'prefetch'

2017-02-10 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev head: 1f7c9e1bb76b7dc50e515bd6ce9b3a8526377d17 commit: 0e629d6798567fe31bcf7e16ba5c5affcad15059 [31/38] rcu: Abstract multi-tail callback list handling config: parisc-allyesconfig (attached as .config) compile

[PATCH v2 4/9] test_sysctl: add dedicated proc sysctl test driver

2017-02-10 Thread Luis R. Rodriguez
Although we have had tools/testing/selftests/sysctl/ with two test cases these use existing kernel sysctl interfaces. We want to expand test coverage, we can't just be looking for random safe production values to poke at, instead just dedicate a test driver for debugging purposes and port the exist

[PATCH v2 2/9] sysctl: add proper unsigned int support

2017-02-10 Thread Luis R. Rodriguez
Commit e7d316a02f6838 ("sysctl: handle error writing UINT_MAX to u32 fields") added proc_douintvec() to start help adding support for unsigned int, this however was only half the work needed, all these issues are present with the current implementation: o Printing the values shows a negative val

[PATCH v2 7/9] test_sysctl: add simple proc_dointvec() case

2017-02-10 Thread Luis R. Rodriguez
Test against a simple proc_dointvec() case. While at it, add a test against INT_MAX. Make sure INT_MAX works, and INT_MAX+1 will fail. Also test negative values work. Signed-off-by: Luis R. Rodriguez --- lib/test_sysctl.c| 11 ++ tools/testing/selftests/sysctl/sysctl.

[PATCH v2 5/9] test_sysctl: add generic script to expand on tests

2017-02-10 Thread Luis R. Rodriguez
This adds a generic script to let us more easily add more tests cases. Since we really have only two types of tests cases just fold them into the one file. Each test unit is now identified into its separate function: # ./sysctl.sh -l Test ID list: TEST_ID x NUM_TEST TEST_ID: Test ID NUM_TESTS

[PATCH v2 8/9] test_sysctl: add simple proc_douintvec() case

2017-02-10 Thread Luis R. Rodriguez
Test against a simple proc_douintvec() case. While at it, add a test against UINT_MAX. Make sure UINT_MAX works, and UINT_MAX+1 will fail and that negative values are not accepted. Signed-off-by: Luis R. Rodriguez --- lib/test_sysctl.c| 11 ++ tools/testing/selftests/

[PATCH v2 6/9] test_sysctl: test against PAGE_SIZE for int

2017-02-10 Thread Luis R. Rodriguez
Add the following tests to ensure we do not regress: o Test using a buffer full of space (PAGE_SIZE-1) followed by a single digit works o Test using a buffer full of spaces (PAGE_SIZE or over) will fail As tests increase instead of unloading the module and reloading it we can just do a s

[PATCH v2 3/9] sysctl: add unsigned int range support

2017-02-10 Thread Luis R. Rodriguez
To keep parity with regular int interfaces provide the an unsigned int proc_douintvec_minmax() which allows you to specify a range of allowed valid numbers. Adding proc_douintvec_minmax_sysadmin() is easy but we can wait for an actual user for that. Cc: Subash Abhinov Kasiviswanathan Cc: Heinric

[PATCH v2 0/9] sysctl: add and fix proper unsigned int support

2017-02-10 Thread Luis R. Rodriguez
On this v2 I've taken Alexey's recommendation and looked at array users of the proc sysctl interface which complicate the interfece to see if we can instead just simplify the unsigned int implementation. I could not find any clear candidate. As such I've just ripped out array support. Since some f

Re: [RFC/PATCH 2/3] security: Add the Timgad module

2017-02-10 Thread Kees Cook
On Thu, Feb 2, 2017 at 9:04 AM, Djalal Harouni wrote: > From: Djalal Harouni > > This adds the Timgad module. Timgad allows to apply restrictions on > which task is allowed to load or unload kernel modules. Auto-load module > feature is also handled. The settings can also be applied globally usin

Re: [PATCH v1] regulator: Add driver for voltage controlled regulators

2017-02-10 Thread Matthias Kaehlcke
El Fri, Feb 10, 2017 at 12:43:48PM -0800 Matthias Kaehlcke ha dit: > The output voltage of a voltage controlled regulator can be controlled > through the voltage of another regulator. The current version of this > driver assumes that the output voltage is a linear function of the control > voltage

Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support

2017-02-10 Thread Stephen Hemminger
On Fri, 10 Feb 2017 09:38:20 -0800 Shannon Nelson wrote: > +static void vsw_get_ethtool_stats(struct net_device *dev, > + struct ethtool_stats *estats, u64 *data) > +{ > + int i = 0; > + > + data[i++] = dev->stats.rx_packets; > + data[i++] = dev->stats.tx

Re: [PATCH v2 3/4] seccomp: Create an action to log before allowing

2017-02-10 Thread Tyler Hicks
On 02/07/2017 06:33 PM, Kees Cook wrote: > On Thu, Feb 2, 2017 at 9:37 PM, Tyler Hicks wrote: >> Add a new action, SECCOMP_RET_LOG, that logs a syscall before allowing >> the syscall. At the implementation level, this action is identical to >> the existing SECCOMP_RET_ALLOW action. However, it can

Re: [PATCH v2 3/4] seccomp: Create an action to log before allowing

2017-02-10 Thread Kees Cook
On Fri, Feb 10, 2017 at 4:01 PM, Tyler Hicks wrote: > On 02/07/2017 06:33 PM, Kees Cook wrote: >> This adds to UAPI, so it'd be good to think for a moment about how >> this would work on older kernels: right now, if someone tried to use >> this RET_LOG on an old kernel, it'll get treated like RET_

Re: [PATCH v2 3/4] seccomp: Create an action to log before allowing

2017-02-10 Thread Tyler Hicks
On 02/10/2017 06:08 PM, Kees Cook wrote: > On Fri, Feb 10, 2017 at 4:01 PM, Tyler Hicks wrote: >> On 02/07/2017 06:33 PM, Kees Cook wrote: >>> This adds to UAPI, so it'd be good to think for a moment about how >>> this would work on older kernels: right now, if someone tried to use >>> this RET_LO

[PATCH 3/3] Input: tsc2004/5 - switch to using generic device properties

2017-02-10 Thread Dmitry Torokhov
Instead of supporting legacy platform data (of which we have no mainline users) and OF-based properties, let's switch to generic device properties. This will still allow legacy boards to use the driver (by defining property sets and attaching them to the drivers) and will simplify probe and make dr

[PATCH] Documentation: make Makefile.sphinx no-ops quieter

2017-02-10 Thread Jim Davis
Silence the "make[1]: Nothing to be done for ..." messages for the no-op targets in Makefile.sphinx. Signed-off-by: Jim Davis --- Documentation/Makefile.sphinx | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/Makefile.sphinx b/Documentation/Makefile.sphinx index 707c65337ebf

[PATCH 2/3] Input: tsc2004/5 - fix regulator handling

2017-02-10 Thread Dmitry Torokhov
In case of an optional regulator missing regulator core will return ERR_PTR(-ENOENT) and not NULL, so the check for missing regulator is incorrect. Also, the regulator is not optional, it may simply be missing from platform decsription, so let's use devm_regulator_get() and rely on regulator core t

RE: [PATCHv5 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

2017-02-10 Thread Grandhi, Sainath
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, February 09, 2017 2:08 PM > To: Grandhi, Sainath > Cc: net...@vger.kernel.org; mah...@bandewar.net; linux- > ker...@vger.kernel.org > Subject: Re: [PATCHv5 0/7] Refactor macvtap to re-use tap functio

[PATCHv6 2/7] tap: Renaming tap related APIs, data structures, macros

2017-02-10 Thread Sainath Grandhi
Renaming tap related APIs, data structures and macros in tap.c from macvtap_.* to tap_.* Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 18 +-- drivers/net/tap.c | 332 ++--- drivers/vhost/net.c| 3 +- include/linux/if

[PATCHv6 1/7] tap: Refactoring macvtap.c

2017-02-10 Thread Sainath Grandhi
macvtap module has code for tap/queue management and link management. This patch splits the code into macvtap_main.c for link management and tap.c for tap/queue management. Functionality in tap.c can be re-used for implementing tap on other virtual interfaces. Signed-off-by: Sainath Grandhi --

[PATCH 1/3] Input: tsc2005 - add OF device table

2017-02-10 Thread Dmitry Torokhov
To be prepared for SPI module loading using full compatible strings from device tree, let's add OF module device table data. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/tsc2005.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/input/touch

Re: [PATCH v2 2/4] seccomp: Add sysctl to configure actions that should be logged

2017-02-10 Thread Kees Cook
On Fri, Feb 10, 2017 at 3:56 PM, Tyler Hicks wrote: > On 02/07/2017 06:24 PM, Kees Cook wrote: >> case SECCOMP_RET_ALLOW: >> /* Open-coded seccomp_log(), optimized for RET_ALLOW. */ >> if (unlikely(seccomp_max_action_to_log == 0)) >> __audit_seccomp(syscall, signr, action); >>

[PATCHv6 4/7] tap: Abstract type of virtual interface from tap implementation

2017-02-10 Thread Sainath Grandhi
macvlan object is re-structured to hold tap related elements in a separate entity, tap_dev. Upon NETDEV_REGISTER device_event, tap_dev is registered with idr and fetched again on tap_open. Few of the tap functions are modified to accepted tap_dev as argument. tap_dev object includes callbacks to be

[PATCHv6 7/7] ipvtap: IP-VLAN based tap driver

2017-02-10 Thread Sainath Grandhi
This patch adds a tap character device driver that is based on the IP-VLAN network interface, called ipvtap. An ipvtap device can be created in the same way as an ipvlan device, using 'type ipvtap', and then accessed using the tap user space interface. Signed-off-by: Sainath Grandhi --- drivers/

[PATCHv6 5/7] tap: Extending tap device create/destroy APIs

2017-02-10 Thread Sainath Grandhi
Extending tap APIs get/free_minor and create/destroy_cdev to handle more than one type of virtual interface. Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 6 +-- drivers/net/tap.c | 118 + include/linux/if_tap.h | 4

[PATCHv6 6/7] tap: tap as an independent module

2017-02-10 Thread Sainath Grandhi
This patch makes tap a separate module for other types of virtual interfaces, for example, ipvlan to use. Signed-off-by: Sainath Grandhi --- drivers/net/Kconfig | 7 +++ drivers/net/Makefile | 3 +-- drivers/net/{macvtap_main.c => macvtap.c} | 0

[PATCHv6 3/7] tap: Tap character device creation/destroy API

2017-02-10 Thread Sainath Grandhi
This patch provides tap device create/destroy APIs in tap.c. Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 30 +++--- drivers/net/tap.c | 62 ++ include/linux/if_tap.h | 3 +++ 3 files changed, 63 inserti

[PATCHv6 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

2017-02-10 Thread Sainath Grandhi
Tap character devices can be implemented on other virtual interfaces like ipvlan, similar to macvtap. Source code for tap functionality in macvtap can be re-used for this purpose. This patch series splits macvtap source into two modules, macvtap and tap. This patch series also includes a patch for

Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-10 Thread Joe Perches
On Fri, 2017-02-10 at 23:54 +, Roberts, William C wrote: > > The problem starts to get hairy when we think of how often folks roll their > > own > > logging macros (see some small sampling at the end). It's not just the "hairy" local macros. In its current form, checkpatch could not find use

Re: [PATCH v2 2/4] seccomp: Add sysctl to configure actions that should be logged

2017-02-10 Thread Tyler Hicks
On 02/07/2017 06:24 PM, Kees Cook wrote: > On Thu, Feb 2, 2017 at 9:37 PM, Tyler Hicks wrote: >> Administrators can write to this sysctl to set the maximum seccomp >> action that should be logged. Any actions with values greater than >> what's written to the sysctl will not be logged. >> >> For ex

  1   2   3   4   5   6   7   8   >