Re: IB on s390 broken with commit 99db94940 "IB/core: Remove ib_device.dma_device"

2017-02-27 Thread Bart Van Assche
On Mon, 2017-02-27 at 21:17 +0100, Sebastian Ott wrote: > commit 99db94940 "IB/core: Remove ib_device.dma_device" > breaks infiniband on s390 (and I think also other archs that do something > like to_pci_dev(dev) in one of their dma_ops callbacks). > > With this commit you use the dma_ops of the

Re: IB on s390 broken with commit 99db94940 "IB/core: Remove ib_device.dma_device"

2017-02-27 Thread Bart Van Assche
On Mon, 2017-02-27 at 21:17 +0100, Sebastian Ott wrote: > commit 99db94940 "IB/core: Remove ib_device.dma_device" > breaks infiniband on s390 (and I think also other archs that do something > like to_pci_dev(dev) in one of their dma_ops callbacks). > > With this commit you use the dma_ops of the

Re: [Outreachy kernel] [PATCH] staging: iio: accel: Move header file content to source file

2017-02-27 Thread Julia Lawall
> diff --git a/drivers/staging/iio/accel/adis16201_core.c > b/drivers/staging/iio/accel/adis16201_core.c > index 7963d4a..210699e 100644 > --- a/drivers/staging/iio/accel/adis16201_core.c > +++ b/drivers/staging/iio/accel/adis16201_core.c > @@ -20,7 +20,150 @@ > #include > #include > >

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

2017-02-27 Thread David Howells
Jan Stancek wrote: > this is a follow-up for "suspicious RCU usage" warning described > in these 2 linux-nfs threads: > http://marc.info/?t=14755883033=1=2 > http://marc.info/?t=14877677051=1=2 > > Did you have something like in mind? How about the attached?

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-27 Thread Michael Zoran
On Mon, 2017-02-27 at 12:35 -0800, Scott Branden wrote: > > > Hi Julia, > > On 17-02-26 10:25 PM, Julia Lawall wrote: > > > > If you consider that you are getting too much outreachy mail at the > > moment, just let me know what subsystem you want me to add an > > exception > > for. > > The

Re: [Outreachy kernel] [PATCH] staging: iio: accel: Move header file content to source file

2017-02-27 Thread Julia Lawall
> diff --git a/drivers/staging/iio/accel/adis16201_core.c > b/drivers/staging/iio/accel/adis16201_core.c > index 7963d4a..210699e 100644 > --- a/drivers/staging/iio/accel/adis16201_core.c > +++ b/drivers/staging/iio/accel/adis16201_core.c > @@ -20,7 +20,150 @@ > #include > #include > >

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

2017-02-27 Thread David Howells
Jan Stancek wrote: > this is a follow-up for "suspicious RCU usage" warning described > in these 2 linux-nfs threads: > http://marc.info/?t=14755883033=1=2 > http://marc.info/?t=14877677051=1=2 > > Did you have something like in mind? How about the attached? It's similar to what

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-27 Thread Michael Zoran
On Mon, 2017-02-27 at 12:35 -0800, Scott Branden wrote: > > > Hi Julia, > > On 17-02-26 10:25 PM, Julia Lawall wrote: > > > > If you consider that you are getting too much outreachy mail at the > > moment, just let me know what subsystem you want me to add an > > exception > > for. > > The

Re: [PATCH] mfd: Add Cherrytrail WhiskeyCove PMIC driver

2017-02-27 Thread Andy Shevchenko
On Mon, Feb 27, 2017 at 12:18 PM, Hans de Goede wrote: > Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non > upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal > version which implements just enough to get ACPI PMIC opregion support to

Re: [PATCH] mfd: Add Cherrytrail WhiskeyCove PMIC driver

2017-02-27 Thread Andy Shevchenko
On Mon, Feb 27, 2017 at 12:18 PM, Hans de Goede wrote: > Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non > upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal > version which implements just enough to get ACPI PMIC opregion support to > work, so that

[PATCH 3/4] ARM: sun7i: Convert to CCU

2017-02-27 Thread Priit Laes
Convert sun7i-a20.dtsi to new CCU driver. Signed-off-by: Priit Laes --- arch/arm/boot/dts/sun7i-a20.dtsi | 719 +-- 1 file changed, 86 insertions(+), 633 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi

[PATCH 3/4] ARM: sun7i: Convert to CCU

2017-02-27 Thread Priit Laes
Convert sun7i-a20.dtsi to new CCU driver. Signed-off-by: Priit Laes --- arch/arm/boot/dts/sun7i-a20.dtsi | 719 +-- 1 file changed, 86 insertions(+), 633 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index

[PATCH] Delete redundant return value check of platform_get_resource()

2017-02-27 Thread Belen Sarabia
Delete error handling from the result of a call to platform_get_resource() when the value is immediately passed to devm_ioremap_resource(). Signed-off-by: Belen Sarabia --- drivers/ata/ahci_octeon.c | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH] Delete redundant return value check of platform_get_resource()

2017-02-27 Thread Belen Sarabia
Delete error handling from the result of a call to platform_get_resource() when the value is immediately passed to devm_ioremap_resource(). Signed-off-by: Belen Sarabia --- drivers/ata/ahci_octeon.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/ata/ahci_octeon.c

[PATCH] f2fs: avoid to issue redundant discard commands

2017-02-27 Thread Jaegeuk Kim
If segs_per_sec is over 1 like under SMR, previously f2fs issues discard commands redundantly on the same section, since we didn't move end position for the previous discard command. E.g., start end || prefree_bitmap = [010000]

RE: [Resend PATCH 2/2 v3] pci-hyperv: lock pci bus on device eject

2017-02-27 Thread Long Li
Ok, I will resend. > -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Saturday, February 25, 2017 12:02 AM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; >

[PATCH] f2fs: avoid to issue redundant discard commands

2017-02-27 Thread Jaegeuk Kim
If segs_per_sec is over 1 like under SMR, previously f2fs issues discard commands redundantly on the same section, since we didn't move end position for the previous discard command. E.g., start end || prefree_bitmap = [010000]

RE: [Resend PATCH 2/2 v3] pci-hyperv: lock pci bus on device eject

2017-02-27 Thread Long Li
Ok, I will resend. > -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Saturday, February 25, 2017 12:02 AM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; > de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; linux- > p...@vger.kernel.org >

[PATCH 2/4] clk: sunxi-ng: Add sun7i-a20 CCU driver

2017-02-27 Thread Priit Laes
Introduce a clock controller driver for sun7i A20 SoC. Signed-off-by: Priit Laes --- drivers/clk/sunxi-ng/Kconfig | 11 + drivers/clk/sunxi-ng/Makefile|1 + drivers/clk/sunxi-ng/ccu-sun7i-a20.c | 1068 ++

[PATCH 2/4] clk: sunxi-ng: Add sun7i-a20 CCU driver

2017-02-27 Thread Priit Laes
Introduce a clock controller driver for sun7i A20 SoC. Signed-off-by: Priit Laes --- drivers/clk/sunxi-ng/Kconfig | 11 + drivers/clk/sunxi-ng/Makefile|1 + drivers/clk/sunxi-ng/ccu-sun7i-a20.c | 1068 ++ drivers/clk/sunxi-ng/ccu-sun7i-a20.h

Re: [PATCH 13/20] PCI: iproc-platform: update PCI config space remap function

2017-02-27 Thread Ray Jui
Hi Lorenzo, On 2/27/2017 7:14 AM, Lorenzo Pieralisi wrote: > PCI configuration space should be mapped with a memory region type that > generates on the CPU host bus non-posted write transations. Update the > driver to use the devm_pci_remap_cfg* interface to make sure the correct > memory

Re: [PATCH 13/20] PCI: iproc-platform: update PCI config space remap function

2017-02-27 Thread Ray Jui
Hi Lorenzo, On 2/27/2017 7:14 AM, Lorenzo Pieralisi wrote: > PCI configuration space should be mapped with a memory region type that > generates on the CPU host bus non-posted write transations. Update the > driver to use the devm_pci_remap_cfg* interface to make sure the correct > memory

next: runtime warning after 'locking/refcounts: Out-of-line everything'

2017-02-27 Thread Guenter Roeck
: 1 Comm: swapper Not tainted 4.10.0-next-20170227 #1 task: cf81d5a0 task.stack: cf81e000 NIP: c02100e0 LR: c02100e0 CTR: c0279970 REGS: cf81fc90 TRAP: 0700 Not tainted (4.10.0-next-20170227) MSR: 00029000 <CE,EE,ME> CR: 2422 XER: GPR00: c02100e0 cf81fd40 cf81d5a0 0026 00

next: runtime warning after 'locking/refcounts: Out-of-line everything'

2017-02-27 Thread Guenter Roeck
: 1 Comm: swapper Not tainted 4.10.0-next-20170227 #1 task: cf81d5a0 task.stack: cf81e000 NIP: c02100e0 LR: c02100e0 CTR: c0279970 REGS: cf81fc90 TRAP: 0700 Not tainted (4.10.0-next-20170227) MSR: 00029000 CR: 2422 XER: GPR00: c02100e0 cf81fd40 cf81d5a0 0026

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread David Ahern
On 2/27/17 12:37 PM, Andrey Konovalov wrote: > That's what I thought when I read your message, thanks! > > I was just confused by David saying that the fuzzer is doing something > interesting, when the reproducer is just an ioctl call on a socket. It means I have a cold, recently off a plane and

Re: [kernel-hardening] [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-27 Thread Kees Cook
On Mon, Feb 27, 2017 at 12:54 PM, Joe Perches wrote: > %pK was at least once misused at %pk in an out-of-tree module. > This lead to some security concerns. Add the ability to track > single and multiple line statements for misuses of %p. > > Signed-off-by: Joe Perches

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread David Ahern
On 2/27/17 12:37 PM, Andrey Konovalov wrote: > That's what I thought when I read your message, thanks! > > I was just confused by David saying that the fuzzer is doing something > interesting, when the reproducer is just an ioctl call on a socket. It means I have a cold, recently off a plane and

Re: [kernel-hardening] [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-27 Thread Kees Cook
On Mon, Feb 27, 2017 at 12:54 PM, Joe Perches wrote: > %pK was at least once misused at %pk in an out-of-tree module. > This lead to some security concerns. Add the ability to track > single and multiple line statements for misuses of %p. > > Signed-off-by: Joe Perches Acked-by: Kees Cook

Re: [RFC 0/3] drivers: Add an API to read device specific config data

2017-02-27 Thread Boris Brezillon
+Moritz Hi Alban, On Mon, 27 Feb 2017 21:28:09 +0100 Alban wrote: > Hi all, > > while looking at adding OF support for the ath9k driver I had the problem of > reading the EEPROM data. On the SoC platforms this data is stored in an SPI > flash along with a few other things. In

Re: [RFC 0/3] drivers: Add an API to read device specific config data

2017-02-27 Thread Boris Brezillon
+Moritz Hi Alban, On Mon, 27 Feb 2017 21:28:09 +0100 Alban wrote: > Hi all, > > while looking at adding OF support for the ath9k driver I had the problem of > reading the EEPROM data. On the SoC platforms this data is stored in an SPI > flash along with a few other things. In OpenWRT/LEDE

RE: [PATCH] IB/qib: fix false-postive maybe-uninitialized warning

2017-02-27 Thread Weiny, Ira
> > aarch64-linux-gcc-7 complains about code it doesn't fully understand: > > drivers/infiniband/hw/qib/qib_iba7322.c: In function > 'qib_7322_txchk_change': > include/asm-generic/bitops/non-atomic.h:105:35: error: 'shadow' may be used > uninitialized in this function

RE: [PATCH] IB/qib: fix false-postive maybe-uninitialized warning

2017-02-27 Thread Weiny, Ira
> > aarch64-linux-gcc-7 complains about code it doesn't fully understand: > > drivers/infiniband/hw/qib/qib_iba7322.c: In function > 'qib_7322_txchk_change': > include/asm-generic/bitops/non-atomic.h:105:35: error: 'shadow' may be used > uninitialized in this function

[PATCH 0/4] ARM: sun7i: Convert sun7i SoC to sunxi-ng

2017-02-27 Thread Priit Laes
Hi, This is serie brings another SoC into the sunxi-ng world. As mentioned in sun5i conversion, this is pretty much standard stuff as all the required clocks were already implemented in the sunxi-ng framework. Priit Laes (4): clk: sunxi-ng: Add clocks and reset indices for sun7i-a20 SoC

[PATCH 0/4] ARM: sun7i: Convert sun7i SoC to sunxi-ng

2017-02-27 Thread Priit Laes
Hi, This is serie brings another SoC into the sunxi-ng world. As mentioned in sun5i conversion, this is pretty much standard stuff as all the required clocks were already implemented in the sunxi-ng framework. Priit Laes (4): clk: sunxi-ng: Add clocks and reset indices for sun7i-a20 SoC

[PATCH] staging: fbtft: fix unnecessary line continuations

2017-02-27 Thread Cezary Gapinski
Fix the following formatting issues: WARNING: Avoid unnecessary line continuations Signed-off-by: Cezary Gapinski --- This patch is a part of task 10 of eudyptula challenge drivers/staging/fbtft/fbtft-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] staging: fbtft: fix unnecessary line continuations

2017-02-27 Thread Cezary Gapinski
Fix the following formatting issues: WARNING: Avoid unnecessary line continuations Signed-off-by: Cezary Gapinski --- This patch is a part of task 10 of eudyptula challenge drivers/staging/fbtft/fbtft-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread Andrey Konovalov
On Mon, Feb 27, 2017 at 9:34 PM, Cong Wang wrote: > On Mon, Feb 27, 2017 at 12:05 PM, Andrey Konovalov > wrote: >> On Mon, Feb 27, 2017 at 8:59 PM, David Ahern >> wrote: >>> On 2/27/17 10:11 AM, Cong Wang wrote:

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread Andrey Konovalov
On Mon, Feb 27, 2017 at 9:34 PM, Cong Wang wrote: > On Mon, Feb 27, 2017 at 12:05 PM, Andrey Konovalov > wrote: >> On Mon, Feb 27, 2017 at 8:59 PM, David Ahern >> wrote: >>> On 2/27/17 10:11 AM, Cong Wang wrote: The attached patch fixes this crash, but I am not sure if it is the best

Re: [Regression?] 1ea0ce4069 ("selinux: allow changing labels for cgroupfs") stops Android from booting

2017-02-27 Thread Stephen Smalley
On Mon, 2017-02-27 at 16:23 -0500, Stephen Smalley wrote: > On Mon, 2017-02-27 at 12:48 -0800, Nick Kralevich wrote: > > > > On Mon, Feb 27, 2017 at 11:53 AM, Stephen Smalley > v> > > wrote: > > > > > > > > > > > > > > > > > > I can reproduce it on angler (with a

Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

2017-02-27 Thread Tejun Heo
On Mon, Feb 27, 2017 at 01:12:11PM -0800, Tahsin Erdogan wrote: > That makes sense. I will work a patch that does that (unless you are > interested in implementing it yourself). I'd really appreciate if you can work on it. Thanks a lot! -- tejun

Re: [Regression?] 1ea0ce4069 ("selinux: allow changing labels for cgroupfs") stops Android from booting

2017-02-27 Thread Stephen Smalley
On Mon, 2017-02-27 at 16:23 -0500, Stephen Smalley wrote: > On Mon, 2017-02-27 at 12:48 -0800, Nick Kralevich wrote: > > > > On Mon, Feb 27, 2017 at 11:53 AM, Stephen Smalley > v> > > wrote: > > > > > > > > > > > > > > > > > > I can reproduce it on angler (with a back-port of just that > > >

Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

2017-02-27 Thread Tejun Heo
On Mon, Feb 27, 2017 at 01:12:11PM -0800, Tahsin Erdogan wrote: > That makes sense. I will work a patch that does that (unless you are > interested in implementing it yourself). I'd really appreciate if you can work on it. Thanks a lot! -- tejun

Re: [Outreachy kernel] [PATCH 2/5] staging: rtl8192u: Remove unnecessary else after return

2017-02-27 Thread Julia Lawall
On Mon, 27 Feb 2017, simran singhal wrote: > This patch fixes the checkpatch warning that else is not generally > useful after a break or return. > > This was done using Coccinelle: > > @@ > expression e2; > statement s1; > @@ > if(e2) { ... return ...; } > -else > s1 > >

Re: [Outreachy kernel] [PATCH 2/5] staging: rtl8192u: Remove unnecessary else after return

2017-02-27 Thread Julia Lawall
On Mon, 27 Feb 2017, simran singhal wrote: > This patch fixes the checkpatch warning that else is not generally > useful after a break or return. > > This was done using Coccinelle: > > @@ > expression e2; > statement s1; > @@ > if(e2) { ... return ...; } > -else > s1 > >

[PATCH 4/4] dt-bindings: List devicetree binding for the CCU of Allwinner A20

2017-02-27 Thread Priit Laes
Allwinner A20 is now driven by sunxi-ng CCU driver. Add devicetree binding for it. Signed-off-by: Priit Laes --- Documentation/devicetree/bindings/clock/sunxi-ccu.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/clock/sunxi-ccu.txt

[PATCH 4/4] dt-bindings: List devicetree binding for the CCU of Allwinner A20

2017-02-27 Thread Priit Laes
Allwinner A20 is now driven by sunxi-ng CCU driver. Add devicetree binding for it. Signed-off-by: Priit Laes --- Documentation/devicetree/bindings/clock/sunxi-ccu.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/clock/sunxi-ccu.txt

[PATCH] staging: fsl-mc: fix warning in DT ranges parser

2017-02-27 Thread Arnd Bergmann
The fsl-mc-bus driver in staging contains a copy of the standard 'ranges' property parsing algorithm with a hack to treat a missing property the same way as an empty one. This code produces false-positive warnings for me in an allmodconfig build: drivers/staging/fsl-mc/bus/fsl-mc-bus.c: In

[PATCH] staging: fsl-mc: fix warning in DT ranges parser

2017-02-27 Thread Arnd Bergmann
The fsl-mc-bus driver in staging contains a copy of the standard 'ranges' property parsing algorithm with a hack to treat a missing property the same way as an empty one. This code produces false-positive warnings for me in an allmodconfig build: drivers/staging/fsl-mc/bus/fsl-mc-bus.c: In

Re: [PATCH 3/3] ath9k: ahb: Add OF support

2017-02-27 Thread Rafał Miłecki
Why you didn't cc linux-wireless?!?! On 27 February 2017 at 21:28, Alban wrote: > @@ -513,6 +515,43 @@ static void ath9k_eeprom_release(struct ath_softc *sc) > release_firmware(sc->sc_ah->eeprom_blob); > } > > +#ifdef CONFIG_OF > +static int ath9k_init_of(struct ath_softc

Re: [PATCH 3/3] ath9k: ahb: Add OF support

2017-02-27 Thread Rafał Miłecki
Why you didn't cc linux-wireless?!?! On 27 February 2017 at 21:28, Alban wrote: > @@ -513,6 +515,43 @@ static void ath9k_eeprom_release(struct ath_softc *sc) > release_firmware(sc->sc_ah->eeprom_blob); > } > > +#ifdef CONFIG_OF > +static int ath9k_init_of(struct ath_softc *sc) > +{ > +

Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

2017-02-27 Thread Tahsin Erdogan
>> Doing preallocations would probably work but not sure if that can be >> done without >> complicating code too much. Could you describe what you have in mind? > > So, blkg_create() already takes @new_blkg argument which is the > preallocated blkg and used during q init. Wouldn't it work to make

Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

2017-02-27 Thread Tahsin Erdogan
>> Doing preallocations would probably work but not sure if that can be >> done without >> complicating code too much. Could you describe what you have in mind? > > So, blkg_create() already takes @new_blkg argument which is the > preallocated blkg and used during q init. Wouldn't it work to make

[PATCH] touchscreen: ad7879: include linux/property.h

2017-02-27 Thread Arnd Bergmann
I ran into this build failure during randconfig testing: drivers/input/touchscreen/ad7879.c: In function 'ad7879_parse_dt': drivers/input/touchscreen/ad7879.c:505:8: error: implicit declaration of function 'device_property_read_u32' drivers/input/touchscreen/ad7879.c:512:2: error: implicit

[PATCH] touchscreen: ad7879: include linux/property.h

2017-02-27 Thread Arnd Bergmann
I ran into this build failure during randconfig testing: drivers/input/touchscreen/ad7879.c: In function 'ad7879_parse_dt': drivers/input/touchscreen/ad7879.c:505:8: error: implicit declaration of function 'device_property_read_u32' drivers/input/touchscreen/ad7879.c:512:2: error: implicit

Crash in -next due to 'objtool: Improve detection of BUG() and other dead ends'

2017-02-27 Thread Guenter Roeck
: [ed7b11e565c736828f0b793f596a4ca20efee747] Add linux-next specific files for 20170227 # good: [c470abd4fde40ea6a0846a2beab642a578c0b8cd] Linux 4.10 git bisect start 'HEAD' 'v4.10' # good: [caa59428971d5ad81d19512365c9ba580d83268c] Merge tag 'staging-4.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel

Crash in -next due to 'objtool: Improve detection of BUG() and other dead ends'

2017-02-27 Thread Guenter Roeck
: [ed7b11e565c736828f0b793f596a4ca20efee747] Add linux-next specific files for 20170227 # good: [c470abd4fde40ea6a0846a2beab642a578c0b8cd] Linux 4.10 git bisect start 'HEAD' 'v4.10' # good: [caa59428971d5ad81d19512365c9ba580d83268c] Merge tag 'staging-4.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel

[PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-27 Thread Joe Perches
%pK was at least once misused at %pk in an out-of-tree module. This lead to some security concerns. Add the ability to track single and multiple line statements for misuses of %p. Signed-off-by: Joe Perches --- Andrew, this has gone back and forth a few times. It's imperfect

[PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-27 Thread Joe Perches
%pK was at least once misused at %pk in an out-of-tree module. This lead to some security concerns. Add the ability to track single and multiple line statements for misuses of %p. Signed-off-by: Joe Perches --- Andrew, this has gone back and forth a few times. It's imperfect as a patch

Re: [PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-27 Thread Rob Herring
On Tue, Feb 21, 2017 at 05:13:03PM +0530, Raviteja Garimella wrote: > The device node is used for UDCs integrated into Broadcom's > iProc family of SoCs'. The UDC is based on Synopsys Designware > Cores AHB Subsystem USB Device Controller IP. For subject: dt-bindings: usb: Add Broadcom IPROC USB

Re: [PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-27 Thread Rob Herring
On Tue, Feb 21, 2017 at 05:13:03PM +0530, Raviteja Garimella wrote: > The device node is used for UDCs integrated into Broadcom's > iProc family of SoCs'. The UDC is based on Synopsys Designware > Cores AHB Subsystem USB Device Controller IP. For subject: dt-bindings: usb: Add Broadcom IPROC USB

Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times

2017-02-27 Thread Sakari Ailus
Hi Pavel, Please find my comments below. On Sat, Feb 25, 2017 at 11:12:55PM +0100, Pavel Machek wrote: > Hi! > > > > On Mon 2017-02-20 15:56:36, Sakari Ailus wrote: > > > > On Mon, Feb 20, 2017 at 03:09:13PM +0200, Sakari Ailus wrote: > > > > > I've tested ACPI, will test DT soon... > > > > >

Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times

2017-02-27 Thread Sakari Ailus
Hi Pavel, Please find my comments below. On Sat, Feb 25, 2017 at 11:12:55PM +0100, Pavel Machek wrote: > Hi! > > > > On Mon 2017-02-20 15:56:36, Sakari Ailus wrote: > > > > On Mon, Feb 20, 2017 at 03:09:13PM +0200, Sakari Ailus wrote: > > > > > I've tested ACPI, will test DT soon... > > > > >

Re: [PATCH 3/3] DT: i2c: add sht21 to trivial-devices

2017-02-27 Thread Rob Herring
On Sun, Feb 19, 2017 at 9:00 AM, Tomasz Duszynski wrote: > Add binding for Sensirion sht21 relative humidity and temperature > sensor driver. > > Signed-off-by: Tomasz Duszynski > --- > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + > 1

Re: [PATCH 2/3] usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time

2017-02-27 Thread Rob Herring
On Tue, Feb 21, 2017 at 09:56:18AM +0100, Richard Leitner wrote: > Rename oc-delay-* to oc-delay-us and make it expect a time value. > Furthermore add -ms suffix to power-on-time. These changes were > suggested by Rob Herring in https://lkml.org/lkml/2017/2/15/1283. > > Signed-off-by: Richard

Re: [PATCH 3/3] DT: i2c: add sht21 to trivial-devices

2017-02-27 Thread Rob Herring
On Sun, Feb 19, 2017 at 9:00 AM, Tomasz Duszynski wrote: > Add binding for Sensirion sht21 relative humidity and temperature > sensor driver. > > Signed-off-by: Tomasz Duszynski > --- > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + > 1 file changed, 1 insertion(+) Looks

Re: [PATCH 2/3] usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time

2017-02-27 Thread Rob Herring
On Tue, Feb 21, 2017 at 09:56:18AM +0100, Richard Leitner wrote: > Rename oc-delay-* to oc-delay-us and make it expect a time value. > Furthermore add -ms suffix to power-on-time. These changes were > suggested by Rob Herring in https://lkml.org/lkml/2017/2/15/1283. > > Signed-off-by: Richard

Re: LTP write03 writev07 xfs failures

2017-02-27 Thread Brian Foster
On Mon, Feb 27, 2017 at 11:09:01AM -0500, Brian Foster wrote: > cc Christoph > > On Mon, Feb 27, 2017 at 12:22:20PM +0800, Xiong Zhou wrote: > > Hi, > > > > These 2 tests PASS on Linus tree commit: > > 37c8596 Merge tag 'tty-4.11-rc1' of git://git.kernel.org/pub/scm/linux... > > FAIL on

Re: LTP write03 writev07 xfs failures

2017-02-27 Thread Brian Foster
On Mon, Feb 27, 2017 at 11:09:01AM -0500, Brian Foster wrote: > cc Christoph > > On Mon, Feb 27, 2017 at 12:22:20PM +0800, Xiong Zhou wrote: > > Hi, > > > > These 2 tests PASS on Linus tree commit: > > 37c8596 Merge tag 'tty-4.11-rc1' of git://git.kernel.org/pub/scm/linux... > > FAIL on

Re: [PATCH v4] reset: Add i.MX7 SRC reset driver

2017-02-27 Thread Rob Herring
On Tue, Feb 21, 2017 at 08:13:31AM -0800, Andrey Smirnov wrote: > Add reset controller driver exposing various reset faculties, > implemented by System Reset Controller IP block. > > Cc: Lucas Stach > Cc: Rob Herring > Cc: Mark Rutland

Re: [PATCH v4] reset: Add i.MX7 SRC reset driver

2017-02-27 Thread Rob Herring
On Tue, Feb 21, 2017 at 08:13:31AM -0800, Andrey Smirnov wrote: > Add reset controller driver exposing various reset faculties, > implemented by System Reset Controller IP block. > > Cc: Lucas Stach > Cc: Rob Herring > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Cc:

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-27 Thread Scott Branden
Hi Julia, On 17-02-26 10:25 PM, Julia Lawall wrote: On Sun, 26 Feb 2017, Scott Branden wrote: On 17-02-26 01:56 PM, Joe Perches wrote: On Sun, 2017-02-26 at 20:40 +0100, Julia Lawall wrote: On Sun, 26 Feb 2017, Joe Perches wrote: On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote:

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-27 Thread Scott Branden
Hi Julia, On 17-02-26 10:25 PM, Julia Lawall wrote: On Sun, 26 Feb 2017, Scott Branden wrote: On 17-02-26 01:56 PM, Joe Perches wrote: On Sun, 2017-02-26 at 20:40 +0100, Julia Lawall wrote: On Sun, 26 Feb 2017, Joe Perches wrote: On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote:

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread Cong Wang
On Mon, Feb 27, 2017 at 12:05 PM, Andrey Konovalov wrote: > On Mon, Feb 27, 2017 at 8:59 PM, David Ahern wrote: >> On 2/27/17 10:11 AM, Cong Wang wrote: >>> The attached patch fixes this crash, but I am not sure if it is the >>> best way to fix

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread Cong Wang
On Mon, Feb 27, 2017 at 12:05 PM, Andrey Konovalov wrote: > On Mon, Feb 27, 2017 at 8:59 PM, David Ahern wrote: >> On 2/27/17 10:11 AM, Cong Wang wrote: >>> The attached patch fixes this crash, but I am not sure if it is the >>> best way to fix this bug yet... >> >> I'll take a look. I can not

[PATCH] scsi: lpfc: use proper format string for dma_addr_t

2017-02-27 Thread Arnd Bergmann
dma_addr_t may be either u32 or u64, depending on the kernel configuration, and we get a warning for the 32-bit case: drivers/scsi/lpfc/lpfc_nvme.c: In function 'lpfc_nvme_ls_req': drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but

Re: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

2017-02-27 Thread SIMRAN SINGHAL
On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches wrote: > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: >> This patch fixes the checkpatch warning that else is not generally >> useful after a break or return. > >> This was done using Coccinelle: >> @@ >> expression e2; >>

[PATCH] scsi: lpfc: use proper format string for dma_addr_t

2017-02-27 Thread Arnd Bergmann
dma_addr_t may be either u32 or u64, depending on the kernel configuration, and we get a warning for the 32-bit case: drivers/scsi/lpfc/lpfc_nvme.c: In function 'lpfc_nvme_ls_req': drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but

Re: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

2017-02-27 Thread SIMRAN SINGHAL
On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches wrote: > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: >> This patch fixes the checkpatch warning that else is not generally >> useful after a break or return. > >> This was done using Coccinelle: >> @@ >> expression e2; >> statement s1; >>

Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return

2017-02-27 Thread Joe Perches
On Tue, 2017-02-28 at 01:51 +0530, SIMRAN SINGHAL wrote: > On Tue, Feb 28, 2017 at 12:55 AM, Joe Perches wrote: > > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: > > > This patch fixes the checkpatch warning that else is not generally > > > useful after a break or

Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return

2017-02-27 Thread Joe Perches
On Tue, 2017-02-28 at 01:51 +0530, SIMRAN SINGHAL wrote: > On Tue, Feb 28, 2017 at 12:55 AM, Joe Perches wrote: > > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote: > > > This patch fixes the checkpatch warning that else is not generally > > > useful after a break or return. > > > >

Re: [RFC 0/3] drivers: Add an API to read device specific config data

2017-02-27 Thread Marek Vasut
On 02/27/2017 09:28 PM, Alban wrote: > Hi all, > > while looking at adding OF support for the ath9k driver I had the problem of > reading the EEPROM data. On the SoC platforms this data is stored in an SPI > flash along with a few other things. In OpenWRT/LEDE this data is read from > the board

Re: [RFC 0/3] drivers: Add an API to read device specific config data

2017-02-27 Thread Marek Vasut
On 02/27/2017 09:28 PM, Alban wrote: > Hi all, > > while looking at adding OF support for the ath9k driver I had the problem of > reading the EEPROM data. On the SoC platforms this data is stored in an SPI > flash along with a few other things. In OpenWRT/LEDE this data is read from > the board

[PATCH 3/3] ath9k: ahb: Add OF support

2017-02-27 Thread Alban
From: Alban Bedel Allow registering ath9k AHB devices defined in OF. The binding currently only allow to set the MAC address and to optionally disable the 2GHz or 5GHz band. The EEPROM data is loaded using the device data API. Signed-off-by: Alban Bedel ---

[PATCH 3/3] ath9k: ahb: Add OF support

2017-02-27 Thread Alban
From: Alban Bedel Allow registering ath9k AHB devices defined in OF. The binding currently only allow to set the MAC address and to optionally disable the 2GHz or 5GHz band. The EEPROM data is loaded using the device data API. Signed-off-by: Alban Bedel ---

Re: [PATCH] mm,fs,dax: mark dax_iomap_pmd_fault as const

2017-02-27 Thread Dave Jiang
On 02/27/2017 01:33 PM, Arnd Bergmann wrote: > The two alternative implementations of dax_iomap_fault have different > prototypes, and one of them is obviously wrong as seen from this build > warning: > > fs/dax.c: In function 'dax_iomap_fault': > fs/dax.c:1462:35: error: passing argument 2 of

Re: [PATCH] mm,fs,dax: mark dax_iomap_pmd_fault as const

2017-02-27 Thread Dave Jiang
On 02/27/2017 01:33 PM, Arnd Bergmann wrote: > The two alternative implementations of dax_iomap_fault have different > prototypes, and one of them is obviously wrong as seen from this build > warning: > > fs/dax.c: In function 'dax_iomap_fault': > fs/dax.c:1462:35: error: passing argument 2 of

Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

2017-02-27 Thread Tahsin Erdogan
On Mon, Feb 27, 2017 at 12:29 PM, Tejun Heo wrote: > Hello, > > On Mon, Feb 27, 2017 at 12:27:08PM -0800, Tahsin Erdogan wrote: >> A better example is the call path below: >> >> pcpu_alloc+0x68f/0x710 >> __alloc_percpu_gfp+0xd/0x10 >> __percpu_counter_init+0x55/0xc0 >>

Re: [PATCH] PCI: Add cavium acs pci quirk

2017-02-27 Thread David Daney
On 02/27/2017 11:13 AM, Chalamarla, Tirumalesh wrote: On 2/27/17, 11:02 AM, "David Daney" wrote: On 02/14/2017 07:07 AM, Bjorn Helgaas wrote: > On Mon, Feb 13, 2017 at 09:44:57PM -0700, Alex Williamson wrote: >> On Sat, 30 Jan 2016 01:33:58 +0530 >>

Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

2017-02-27 Thread Tahsin Erdogan
On Mon, Feb 27, 2017 at 12:29 PM, Tejun Heo wrote: > Hello, > > On Mon, Feb 27, 2017 at 12:27:08PM -0800, Tahsin Erdogan wrote: >> A better example is the call path below: >> >> pcpu_alloc+0x68f/0x710 >> __alloc_percpu_gfp+0xd/0x10 >> __percpu_counter_init+0x55/0xc0 >> cfq_pd_alloc+0x3b2/0x4e0 >>

Re: [PATCH] PCI: Add cavium acs pci quirk

2017-02-27 Thread David Daney
On 02/27/2017 11:13 AM, Chalamarla, Tirumalesh wrote: On 2/27/17, 11:02 AM, "David Daney" wrote: On 02/14/2017 07:07 AM, Bjorn Helgaas wrote: > On Mon, Feb 13, 2017 at 09:44:57PM -0700, Alex Williamson wrote: >> On Sat, 30 Jan 2016 01:33:58 +0530 >> Manish Jaggi wrote:

Re: nios2 crash/hang in mainline due to 'lib: update LZ4 compressor module'

2017-02-27 Thread Guenter Roeck
On Mon, Feb 27, 2017 at 08:34:55PM +0100, Sven Schmidt wrote: > Hi Guenter, > > thanks for your testing! > > I must admit, I'm fairly new to kernel development and a little overwhelmed > by all that tools used. > So I do not really know how to reproduce your test using your script. I >

Re: nios2 crash/hang in mainline due to 'lib: update LZ4 compressor module'

2017-02-27 Thread Guenter Roeck
On Mon, Feb 27, 2017 at 08:34:55PM +0100, Sven Schmidt wrote: > Hi Guenter, > > thanks for your testing! > > I must admit, I'm fairly new to kernel development and a little overwhelmed > by all that tools used. > So I do not really know how to reproduce your test using your script. I >

[PATCH] gcc-plugins: fix sancov_plugin for gcc-5

2017-02-27 Thread Arnd Bergmann
The name of the local variable was inadvertantly changed from sancov_plugin_pass_info to sancov_pass_info: scripts/gcc-plugins/sancov_plugin.c: In function ‘int plugin_init(plugin_name_args*, plugin_gcc_version*)’: scripts/gcc-plugins/sancov_plugin.c:136:67: error: ‘sancov_plugin_pass_info’ was

[PATCH] gcc-plugins: fix sancov_plugin for gcc-5

2017-02-27 Thread Arnd Bergmann
The name of the local variable was inadvertantly changed from sancov_plugin_pass_info to sancov_pass_info: scripts/gcc-plugins/sancov_plugin.c: In function ‘int plugin_init(plugin_name_args*, plugin_gcc_version*)’: scripts/gcc-plugins/sancov_plugin.c:136:67: error: ‘sancov_plugin_pass_info’ was

Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

2017-02-27 Thread Tejun Heo
Hello, On Mon, Feb 27, 2017 at 12:27:08PM -0800, Tahsin Erdogan wrote: > A better example is the call path below: > > pcpu_alloc+0x68f/0x710 > __alloc_percpu_gfp+0xd/0x10 > __percpu_counter_init+0x55/0xc0 > cfq_pd_alloc+0x3b2/0x4e0 > blkg_alloc+0x187/0x230 > blkg_create+0x489/0x670 >

Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

2017-02-27 Thread Tejun Heo
Hello, On Mon, Feb 27, 2017 at 12:27:08PM -0800, Tahsin Erdogan wrote: > A better example is the call path below: > > pcpu_alloc+0x68f/0x710 > __alloc_percpu_gfp+0xd/0x10 > __percpu_counter_init+0x55/0xc0 > cfq_pd_alloc+0x3b2/0x4e0 > blkg_alloc+0x187/0x230 > blkg_create+0x489/0x670 >

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-27 Thread David Daney
On 02/27/2017 11:18 AM, Jason Baron wrote: On 02/27/2017 01:57 PM, David Daney wrote: On 02/27/2017 10:49 AM, Jason Baron wrote: The core jump_label code makes use of the 2 lower bits of the static_key::[type|entries|next] field. Thus, ensure that the jump_entry table is at least 4-byte

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-27 Thread David Daney
On 02/27/2017 11:18 AM, Jason Baron wrote: On 02/27/2017 01:57 PM, David Daney wrote: On 02/27/2017 10:49 AM, Jason Baron wrote: The core jump_label code makes use of the 2 lower bits of the static_key::[type|entries|next] field. Thus, ensure that the jump_entry table is at least 4-byte

[PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-27 Thread Arnd Bergmann
tw5864_frameinterval_get() only initializes its output when it successfully identifies the video standard in tw5864_input. We get a warning here because gcc can't always track the state if initialized warnings across a WARN() macro, and thinks it might get used incorrectly in tw5864_s_parm:

[PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-27 Thread Arnd Bergmann
tw5864_frameinterval_get() only initializes its output when it successfully identifies the video standard in tw5864_input. We get a warning here because gcc can't always track the state if initialized warnings across a WARN() macro, and thinks it might get used incorrectly in tw5864_s_parm:

<    2   3   4   5   6   7   8   9   10   11   >