On Sun, 24 Sep 2017, Harsha Sharma wrote:
> Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/
> ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros
> Done using following coccinelle semantic patch
Some calls after under comments. They could be dropped.
Some calls appear
Hi Thomas,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: cd4175b11685b11c40e31a03e05084cc212b0649
commit: d3488649dcd23b7a6e63895274ec69f80e92d4ed um: Fix CONFIG_GCOV for
modules.
date: 10 days ago
config: um-al
All sanity checks in this function set 'sdmac->status = DMA_ERROR' if
something looks wrong, except if the byte count or the address don't match
the bus width.
Fix it and report the error in status in such a case.
Signed-off-by: Christophe JAILLET
---
Untested, so please review carefuly.
---
dr
Hi Daniel,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: cd4175b11685b11c40e31a03e05084cc212b0649
commit: dc11bae78529526605c5c45c369c9512fd012093 clocksource/drivers: Add
timer-of common init routine
date: 3 mo
On Sat, Sep 23, 2017, Yang Shi wrote：
>
> Kernel may panic when oom happens without killable process sometimes it
> is caused by huge unreclaimable slabs used by kernel.
>
> Although kdump could help debug such problem, however, kdump is not
> available on all architectures and it might be malfunc
Looks good,
Reviewed-by: Sagi Grimberg
If we don't find a matching device node, we must free the memory allocated
in 'omap_dmm' a few lines above.
Fixes: 7cb0d6c17b96 ("drm/omap: fix TILER on OMAP5")
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/
ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros
Done using following coccinelle semantic patch
@r@
@@
(
-dev_info
+DRM_DEV_INFO
|
-dev_err
+DRM_DEV_ERROR
|
-dev_dbg
+DRM_DEV_DEBUG
)
Signed-off-by: Harsha Sharma
---
dri
Currently, the aes_ccm.c and aes_gcm.c are almost line by line
copy of each other. This patch reduce code redundancy by moving
the code in these two files to crypto/aead_api.c to make it a
higher level aead api. The aes_ccm.c and aes_gcm.c are removed
and all the functions are now implemented in th
This is the remaining "general" change in the security tree for v4.14,
following the direct merging of SELinux (+ TOMOYO), AppArmor, and seccomp.
That's everything now for the security tree except IMA, which will follow
shortly (I've been traveling for the past week with patchy internet).
Ple
Hi,
On Sep 6 2017 19:22, SF Markus Elfring wrote:
From: Markus Elfring
Date: Wed, 6 Sep 2017 11:40:53 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus E
Hi Huacai,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.14-rc1 next-20170922]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Huacai-Chen/dma-mapping-Introduce-device_is_c
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: cd4175b11685b11c40e31a03e05084cc212b0649
commit: d3202d1981dc5a5f03f9afc96480619b48b60124 media: solo6x10: export
hardware GPIO pins 8:31 to gpiolib interface
date: 7 weeks ago
config: x86_64-randconfig-a0
Signed-off-by: yuzhoujian
---
tools/perf/builtin-script.c | 404
1 file changed, 220 insertions(+), 184 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 271dfc4..6182859 100644
--- a/tools/perf/builtin-script.c
Signed-off-by: yuzhoujian
---
tools/perf/builtin-script.c | 3 +++
tools/perf/util/tool.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 9092de0..936af8b 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-s
Signed-off-by: yuzhoujian
---
tools/perf/builtin-script.c | 190 +++-
1 file changed, 100 insertions(+), 90 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 936af8b..065bea7 100644
--- a/tools/perf/builtin-script.c
Introduce a new option to print trace output to files named by the
monitored events and update perf-script documentation accordingly.
Shown below is output of perf script command with the newly introduced
option.
$perf record -e cycles -e context-switches -ag -- sleep 10
$per
Signed-off-by: yuzhoujian
---
tools/perf/builtin-script.c | 178 ++--
1 file changed, 89 insertions(+), 89 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 065bea7..271dfc4 100644
--- a/tools/perf/builtin-script.c
+
Hi Jaharkes and Coda filesystem developers,
I am resending the email on a potential race condition bug I found in the
Coda filesystem as well as the patch I propose. Please feel free to comment
whether you think this is a serious problem and whether the patch will work.
Thank you.
Best Regards,
M
Hi Dong,
[auto build test ERROR on clk/clk-next]
[also build test ERROR on v4.14-rc1 next-20170922]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Dong-Aisheng/clk-bulk-add-of_clk_bulk_get/20170
Hi Felix,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: cd4175b11685b11c40e31a03e05084cc212b0649
commit: 70539bd79500245cbb4c7af00572fcce540d0105 drm/amd: Update MEC HQD
loading code for KFD
date: 6 weeks ago
co
From: Randy Dunlap
Add descriptive info to prompt string so that someone can know what
a Retrode is. Drop an unneeded blank line.
Signed-off-by: Randy Dunlap
Cc: Bastien Nocera
Cc: Jiri Kosina
Cc: Benjamin Tissoires
---
drivers/hid/Kconfig |3 +--
1 file changed, 1 insertion(+), 2 dele
On 9/23/2017 8:16 PM, Sinan Kaya wrote:
> @@ -4056,7 +4056,7 @@ static int pci_parent_bus_reset(struct pci_dev *dev,
> int probe)
>
> pci_reset_bridge_secondary_bus(dev->bus->self);
>
> - return 0;
> + return pci_dev_wait(dev, "bus reset", 1000, 6);
> }
This doesn't solve t
On Fri, Sep 22, 2017 at 09:46:28AM +0100, Charles Keepax wrote:
>On Wed, Sep 20, 2017 at 04:45:02AM +, Levin, Alexander (Sasha Levin) wrote:
>> From: Nicholas Mc Guire
>>
>> [ Upstream commit ed784c532a3d0959db488f40a96c5127f63d42dc ]
>>
>> The delay here is not in atomic context and does not
pci_flr_wait() and pci_af_flr() functions assume graceful return even
though the device is inaccessible under error conditions.
Return -ENOTTY in error cases so that __pci_reset_function_locked() can
try other reset types if AF_FLR/FLR reset fails.
Signed-off-by: Sinan Kaya
---
drivers/pci/pci.
Rev 3.1 Sec 2.3.1 Request Handling Rules indicates that a device can issue
CRS following secondary bus reset. Handle device presence gracefully.
Signed-off-by: Sinan Kaya
---
drivers/pci/pci.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci.c b/driver
Commit b014e96d1abb ("PCI: Protect pci_error_handlers->reset_notify() usage
with device_lock()") added protection around pci_dev_restore() function so
that device specific remove callback does not cause a race condition
against hotplug.
pci_dev_lock() usage has been forgotten in two different plac
Rev 3.1 Sec 2.3.1 Request Handling Rules says a device can issue CRS
following a D3hot->D0 transition. Add pci_dev_wait() call with 1 second
timeout to see if device is available before returning.
Signed-off-by: Sinan Kaya
---
drivers/pci/pci.c | 6 +-
1 file changed, 5 insertions(+), 1 dele
Rev 3.1 Sec 2.3.1 Request Handling Rules:
Valid reset conditions after which a device is permitted to return CRS
are:
* Cold, Warm, and Hot Resets,
* FLR
* A reset initiated in response to a D3hot to D0 uninitialized
Try to reuse FLR implementation towards other reset types.
Signed-off-by: Sinan
From: Christophe JAILLET
Date: Fri, 22 Sep 2017 01:01:11 +0200
> All the error handling paths 'goto error', except this one.
> We should also go to error in this case, or some resources will be
> leaking.
>
> Signed-off-by: Christophe JAILLET
Applied, thank you.
On Mittwoch, 20. September 2017 22:53:00 CEST Rob Herring wrote:
> On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote:
> > The A64 is register compatible with the H3, but has a different number
> > of dma channels and request ports.
> >
> > Attach additional properties to the node to all
* Juergen Gross wrote:
> On 23/09/17 15:02, Ingo Molnar wrote:
> >
> > * Ingo Molnar wrote:
> >
> >> So I'd like to push these changes to Linus tomorrow-ish as an RFC pull
> >> request in 1-2 days, because there's now 4 fixes depending on these
> >> changes, and because the result will be mor
Instead of reading the value from the register on each query, store the
set value.
Signed-off-by: Stefan Brüns
---
drivers/iio/light/vl6180.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/light/vl6180.c b/drivers/iio/light/vl6180.c
index 68b9babfd2
This improves code uniformity (range checks for als_gain are also done
in the setter). Also unmangle rounding and calculation of register value.
The calculated integration time it_ms is required in the next patch of
the series.
Signed-off-by: Stefan Brüns
---
v2: removed redundant parenthesis
The reported scale was only correct for the default settings of 100 ms
integration time and gain 1.
This aligns the reported scale with the behaviour of any other IIO driver
and the documented ABI, but may require userspace changes if someone uses
non-default settings.
Signed-off-by: Stefan Brüns
Currently, the vl6180 driver reports bogus in_illuminance_scale values
when the integration time or hardware gain are changed from its default
value, i.e. it always reports a fixed value.
To avoid readback of the register values in case integration time, gain
or scale is queried, save the register
Instead of manually iterating the array of allowed gain values, use
find_closest. Storing the current gain setting avoids accessing the
hardware on each query.
Signed-off-by: Stefan Brüns
---
v2: add missing spaces
drivers/iio/light/vl6180.c | 85 --
Hi Phil,
> Greg Kroah-Hartman hat am 23. September 2017 um
> 18:15 geschrieben:
>
>
> On Sat, Sep 23, 2017 at 12:57:33PM +0200, Stefan Wahren wrote:
> > Hi Greg,
> >
> > > Phil Elwell hat am 11. August 2017 um 12:20
> > > geschrieben:
> > >
> > >
> > > The previous commit (0adbfd46) fixed
00 0 Merge
'linux-review/Thiebaud-Weksteen/Call-GetEventLog-before-ExitBootServices/20170923-004848'
into devel-spot-201709232001
git bisect good 422c87daea34f0298708f6afdf4591e5a0f9b9ea # 01:13 G 10
00 0 Merge
'linux-review/Colin-King/video-fbdev-radeon
Hi people,
Well, after reading those links provided by all of you, I'd like to start
contributing as a Kernel tester.
Have also read this link about testing the Kernel:
http://m.linuxjournal.com/content/linux-kernel-testing-and-debugging?page=0,0
Which are the minimal hardware requirements to
A recent pull on Linus' kernel repo triggered a "git gc --auto"
maintenance action that *finally* finished after beating my poor Alpha
PWS 433au to death for 32 hours.
Here's a snapshot of the ".git/objects/pack" directory for the repo:
total 1366084
190535 12 drwxr-xr-x 2 root root 122
On 09/23/2017 10:13 PM, Pavel Machek wrote:
> C++ comments look wrong in kernel tree. Fix one.
AFAIR they are now (sadly) accepted, but this patch works for me.
Would be nice if trivial could pick it.
> Signed-off-by: Pavel Machek
>
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd
Linus,
Stack tracing and RCU has been having issues with each other and lockdep
has been pointing out constant problems. The changes have been going into
the stack tracer, but it has been discovered that the problem isn't
with the stack tracer itself, but it is with calling save_stack_trace()
fro
From: "Steven Rostedt (VMware)"
Currently the stack tracer calls rcu_irq_enter() to make sure RCU
is watching when it records a stack trace. But if the stack tracer
is triggered while tracing inside of a rcu_irq_enter(), calling
rcu_irq_enter() unconditionally can be problematic.
The reason for
From: "Paul E. McKenney"
A number of architecture invoke rcu_irq_enter() on exception entry in
order to allow RCU read-side critical sections in the exception handler
when the exception is from an idle or nohz_full CPU. This works, at
least unless the exception happens in an NMI handler. In tha
From: "Steven Rostedt (VMware)"
If kernel_text_address() is called when RCU is not watching, it can cause an
RCU bug because is_module_text_address(), the is_kprobe_*insn_slot()
and is_bpf_text_address() functions require the use of RCU.
Only enable RCU if it is not currently watching before it
From: "Steven Rostedt (VMware)"
The functionality between kernel_text_address() and _kernel_text_address()
is the same except that _kernel_text_address() does a little more (that
function needs a rename, but that can be done another time). Instead of
having duplicate code in both, simply have _ke
Please find the following patches:
iio: accel: mma8452: Fix code style warning for symbolic permissions
iio: accel: mma8452: Fix code style warning for unsigned int
declarations
drivers/iio/accel/mma8452.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
--
2.7.4
Replace 'unsigned' with 'unsigned int'
to improve code readability.
Issue found by checkpatch.
Signed-off-by: Harinath Nampally
---
drivers/iio/accel/mma8452.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index
Replace symbolic permissions with octal permissions
to improve code readability.
Issue found by checkpatch.
Signed-off-by: Harinath Nampally
---
drivers/iio/accel/mma8452.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/
On Wed, 20 Sep 2017, Kees Cook wrote:
> This improves the patch mode of setup_timer.cocci. Several patterns
> were missing:
> - assignments-before-init_timer() cases
> - limit the .data case removal to the specific struct timer_list instance
> - handling calls by dereference (timer->field vs
On Sat, Sep 23, 2017 at 06:19:26PM +0100, Al Viro wrote:
> On Sat, Sep 23, 2017 at 05:55:37PM +0100, Al Viro wrote:
>
> > IOW, the loop on failure exit should go through the bio, like
> > __bio_unmap_user()
> > does. We *also* need to put everything left unused in pages[], but only
> > from the
This patch fixes the following checkpatch.pl warning: fix
Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ...
then pr_info(... to printk(KERN_INFO ...
Signed-off-by: Yurii Pavlenko
---
drivers/staging/irda/drivers/au1k_ir.c | 40 +++---
1 fi
C++ comments look wrong in kernel tree. Fix one.
Signed-off-by: Pavel Machek
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 6cd0f6b..849543f1 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -267,7 +267,7 @@ struct mtd_info {
*/
unsigne
From: Markus Elfring
Date: Sat, 23 Sep 2017 21:10:02 +0200
The script "checkpatch.pl" pointed information out like the following.
Comparison to NULL could be written "!format"
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
drivers/media/platform/qcom/camss-8x16/c
From: Markus Elfring
Date: Sat, 23 Sep 2017 21:00:30 +0200
Move the definition for the local variable "dev" into an if branch
so that the corresponding setting will only be performed if it was
selected by the parameter "on" of this function.
Signed-off-by: Markus Elfring
---
drivers/media/plat
From: Markus Elfring
Date: Sat, 23 Sep 2017 20:48:33 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/platform/qcom/camss-8x16/
From: Markus Elfring
Date: Sat, 23 Sep 2017 21:24:56 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Use common error handling code in csid_set_power()
Reduce the scope for a variable in csid_set_power()
Adjust a null pointer che
This got rejected by gmail once. Let's see if it works now.
On Thursday, September 21, 2017 8:22:45 PM CEST Andrey Konovalov wrote:
> On Wed, Sep 20, 2017 at 9:55 PM, Johannes Berg
> wrote:
> > On Wed, 2017-09-20 at 21:27 +0200, Christian Lamparter wrote:
> >
> >> It seems this is caused as a res
Orderly poweroff is silent, so it would be nice to
pr_alert("something") at the place of FIXME.
Thanks,
Pavel
diff --git a/drivers/platform/mips/cpu_hwmon.c
b/drivers/platform/mips/cpu_hwmon.c
index 322de58..df24292 100644
--- a/drivers/platform/mi
Kilo should be "k" not "K", fix it it comments and messages.
Signed-off-by: Pavel Machek
index 88e48b3..41a09f5 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -334,7 +334,7 @@ static int ssi_clk_event(struct notifier_block *nb,
unsigned lo
Hi!
Not only it is unneccessarily complex, it is also broken; GFP_ATOMIC
allocation can fail.. and then you fail to shut down the machine.
Someone please fix this.
Thanks,
Pavel
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.
The driver probe path hits 'BUG_ON(entries != vpe_proxy.dev->nr_ites)'
on systems where it has VLPI capability, doesn't support direct LPI
feature and boot with a single CPU.
Relax the BUG_ON() condition to fix the issue.
Signed-off-by: Shanker Donthineni
---
drivers/irqchip/irq-gic-v3-its.c |
On Sat, Sep 23, 2017 at 01:29:32PM +0200, Ingo Molnar wrote:
> > > >
> > > > Ok - could you please rebase these to to tip:master that is at:
> > > >
> > > > git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> > > > master
> > > >
> > > > In particular this has a WIP.x86/fpu
This patch adds chip compatible string to remove the warnings
generated by checkpatch that -DT compatible string
"toshiba,apb-dummy-codec" appears un-documented.
Signed-off-by: Shreeya Patel
---
Documentation/devicetree/bindings/sound/sirf-audio-codec.txt | 3 ++-
1 file changed, 2 insertions(+)
On 09/23/2017 09:57 AM, Colin King wrote:
> From: Colin Ian King
>
> Currently p->phy is being null checked in several places to avoid
> null pointer dereferences on p->phy, however, the final call
> to phy_attached_info on p->phy when p->phy will perform a null
> pointer dereference. Fix this
On Sat, Sep 23, 2017 at 05:55:37PM +0100, Al Viro wrote:
> IOW, the loop on failure exit should go through the bio, like
> __bio_unmap_user()
> does. We *also* need to put everything left unused in pages[], but only from
> the
> last iteration through iov_for_each().
>
> Frankly, I would prefe
On Sat, Sep 23, 2017 at 07:22:04AM -0400, Steven Rostedt wrote:
> On Fri, 22 Sep 2017 23:07:37 -0700
> "Paul E. McKenney" wrote:
>
> > OK, how about the following?
> >
> > It turns out that functions called from rcu_irq_enter() can
> > be subject to various kinds of tracing, which can re
On Sat, 2017-09-23 at 17:57 +0100, Colin King wrote:
> From: Colin Ian King
>
> Currently p->phy is being null checked in several places to avoid
> null pointer dereferences on p->phy, however, the final call
> to phy_attached_info on p->phy when p->phy will perform a null
> pointer dereference.
From: Colin Ian King
Currently p->phy is being null checked in several places to avoid
null pointer dereferences on p->phy, however, the final call
to phy_attached_info on p->phy when p->phy will perform a null
pointer dereference. Fix this by simply moving the call into
the previous code block t
Le 10/08/17 à 19:40, Cihangir Akturk a écrit :
When invoked with V=1, coccicheck script prints the information about
which semantic patch (*.cocci file) used for this operation. Actually,
it prints out the relative path of the related semantic patch. The
script uses sed to remove the source tree
On Sat, Sep 23, 2017 at 05:39:28PM +0100, Al Viro wrote:
> On Fri, Sep 22, 2017 at 01:18:39AM -0400, Vitaly Mayatskikh wrote:
> > bio_map_user_iov and bio_unmap_user do unbalanced pages refcounting if
> > IO vector has small consecutive buffers belonging to the same page.
> > bio_add_pc_page merges
On Fri, Sep 22, 2017 at 01:18:39AM -0400, Vitaly Mayatskikh wrote:
> bio_map_user_iov and bio_unmap_user do unbalanced pages refcounting if
> IO vector has small consecutive buffers belonging to the same page.
> bio_add_pc_page merges them into one, but the page reference is never
> dropped.
>
> S
Some asus laptops (ROG series for example) are provided
with a lightbar behind the monitor.
This patch make possible to switch it on and off.
This lightbar works exactly as any other led.
V2 : fix whitespaces and typo
Signed-off-by: Maxime Bellengé
---
drivers/platform/x86/asus-wmi.c | 63 +
On Sat, Sep 23, 2017 at 8:49 AM, Rajat Jain wrote:
> On Sat, Sep 23, 2017 at 5:55 AM, Rafael J. Wysocki wrote:
>> On Thu, Sep 21, 2017 at 4:11 PM, Rafael J. Wysocki
>> wrote:
>>> On Thursday, September 21, 2017 3:13:56 AM CEST Rajat Jain wrote:
On Wed, Sep 20, 2017 at 5:24 PM, Rafael J. Wy
On Sat, Sep 23, 2017 at 12:57:33PM +0200, Stefan Wahren wrote:
> Hi Greg,
>
> > Phil Elwell hat am 11. August 2017 um 12:20
> > geschrieben:
> >
> >
> > The previous commit (0adbfd46) fixed a memory leak but also freed a
> > block in the success case, causing a stale pointer to be used with
>
On Sat, Sep 23, 2017 at 5:55 AM, Rafael J. Wysocki wrote:
> On Thu, Sep 21, 2017 at 4:11 PM, Rafael J. Wysocki wrote:
>> On Thursday, September 21, 2017 3:13:56 AM CEST Rajat Jain wrote:
>>> On Wed, Sep 20, 2017 at 5:24 PM, Rafael J. Wysocki
>>> wrote:
>>> > On Thu, Sep 21, 2017 at 12:31 AM, Ra
Hi Ingo,
On Sat, 23 Sep 2017 12:50:31 +0200, Ingo Molnar wrote:
> * Jean Delvare wrote:
>
> > I don't think it makes sense to check for a possible bad
> > initialization order at run time on every system when it is all
> > decided at build time.
> >
> > A more efficient way to make sure develop
>> Will the software evolution be continued for related source files?
>> Are there any update candidates left over in the directory “v4l2-core”?
>
> Sorry, I don't understand the question.
I try to explain my view again.
> We don't want to touch the videobuf-* files unless there is a very good
On 23/09/17 15:02, Ingo Molnar wrote:
>
> * Ingo Molnar wrote:
>
>> So I'd like to push these changes to Linus tomorrow-ish as an RFC pull
>> request in 1-2 days, because there's now 4 fixes depending on these
>> changes, and because the result will be more maintainable for the
>> LTS v4.14 kern
> The point is: Once both external ports are in "forwarding", I see no way
> to prevent traffic flowing directly between the external ports.
Generally, there are port vectors. Port X can send frames only to Port
Y.
If you don't have that, there are possibilities with VLANs. Each port
is given a u
Hello, Peter.
On Sat, Sep 23, 2017 at 03:37:31PM +0200, Peter Zijlstra wrote:
> On Fri, Sep 22, 2017 at 11:05:30AM -0700, Tejun Heo wrote:
> > Peter, ping?
>
> Humm,. So I think I was good, but I was under the impression you'd send
> a new version better explaining the need/design of that iterati
On Sat, Sep 23, 2017 at 12:56:12PM +0200, Paolo Bonzini wrote:
> On 22/09/2017 14:55, Peter Zijlstra wrote:
> > You just explained it yourself. If the thread that needs to complete
> > what you're waiting on has lower priority, it will _never_ get to run if
> > you're busy waiting on it.
> >
> > T
On Fri, Sep 22, 2017 at 11:05:30AM -0700, Tejun Heo wrote:
> Peter, ping?
Humm,. So I think I was good, but I was under the impression you'd send
a new version better explaining the need/design of that iteration stuff.
Could be I lost the plot somehow.
Commit-ID: f5caf621ee357279e759c0911daf6d55c7d36f03
Gitweb: http://git.kernel.org/tip/f5caf621ee357279e759c0911daf6d55c7d36f03
Author: Josh Poimboeuf
AuthorDate: Wed, 20 Sep 2017 16:24:33 -0500
Committer: Ingo Molnar
CommitDate: Sat, 23 Sep 2017 15:06:20 +0200
x86/asm: Fix inline asm c
Commit-ID: 0d0970eef3b03ef08b19da5bc3044410731cf38f
Gitweb: http://git.kernel.org/tip/0d0970eef3b03ef08b19da5bc3044410731cf38f
Author: Josh Poimboeuf
AuthorDate: Wed, 20 Sep 2017 16:24:32 -0500
Committer: Ingo Molnar
CommitDate: Sat, 23 Sep 2017 15:06:19 +0200
objtool: Handle another G
From: Rik van Riel
On Skylake CPUs I noticed that XRSTOR is unable to deal with states
created by copyout_from_xsaves() if the xstate has only SSE/YMM state, and
no FP state. That is, xfeatures had XFEATURE_MASK_SSE set, but not
XFEATURE_MASK_FP.
The reason is that part of the SSE/YMM state live
The 'ubuf' parameter is unused in the _kernel() side of the API, remove it.
This simplifies the code and makes it easier to think about.
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Dave Hansen
Cc: Fenghua Yu
Cc: H. Peter Anvin
Cc: Linus Torvalds
Cc: Oleg Nesterov
Cc: Peter Zijlstra
Cc: Ri
copy_xstate_to_user() is a weird API - in part due to a bad API inherited
from the regset APIs.
But don't propagate that bad API choice into the FPU code - so as a first
step split the API into kernel and user buffer handling routines.
(Also split the xstate_copyout() internal helper.)
The split
Remove pointless 'const' of non-pointer input parameter.
Remove unnecessary parenthesis that shows uncertainty about arithmetic operator
precedence.
Clarify copy_xstate_to_user() description.
No change in functionality.
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Dave Hansen
Cc: Fenghua Yu
Parameter ordering is weird:
int copy_xstate_to_kernel(unsigned int pos, unsigned int count, void *kbuf,
struct xregs_state *xsave);
int copy_xstate_to_user(unsigned int pos, unsigned int count, void __user
*ubuf, struct xregs_state *xsave);
'pos' and 'count', which are attributes of the de
Right now there's a confusing mixture of 'offset' and 'size' parameters:
- __copy_xstate_to_*() input parameter 'end_pos' not not really an offset,
but the full size of the copy to be performed.
- input parameter 'count' to copy_xstate_to_*() shadows that of
__copy_xstate_to_*()'s 'count'
'start_pos' is always 0, so remove it and remove the pointless check of 'pos <
0'
which can not ever be true as 'pos' is unsigned ...
No change in functionality.
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Dave Hansen
Cc: Fenghua Yu
Cc: H. Peter Anvin
Cc: Linus Torvalds
Cc: Oleg Nesterov
* Josh Poimboeuf wrote:
> On Sat, Sep 23, 2017 at 12:53:18PM +0200, Ingo Molnar wrote:
> >
> > * Josh Poimboeuf wrote:
> >
> > > Patch 1 is a bug fix for an objtool issue which was uncovered by patch 2.
> > >
> > > Patch 2 is the last fix needed for clang to be able to compile and boot
> > >
Similar to:
x86/fpu: Split copy_xstate_to_user() into copy_xstate_to_kernel() &
copy_xstate_to_user()
No change in functionality.
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Dave Hansen
Cc: Fenghua Yu
Cc: H. Peter Anvin
Cc: Linus Torvalds
Cc: Oleg Nesterov
Cc: Peter Zijlstra
Cc: Rik v
No change in functionality.
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Dave Hansen
Cc: Fenghua Yu
Cc: H. Peter Anvin
Cc: Linus Torvalds
Cc: Oleg Nesterov
Cc: Peter Zijlstra
Cc: Rik van Riel
Cc: Thomas Gleixner
Cc: Yu-cheng Yu
Signed-off-by: Ingo Molnar
---
arch/x86/include/asm/fpu/xs
Prepare fpu__drop() to use fpu->fpregs_active.
There are two distinct usecases for fpu__drop() in this context:
exit_thread() when called for 'current' in exit(), and when called
for another task in fork().
This patch does not change behavior, it only adds a couple of
debug checks and structures
We want to simplify the FPU state machine by eliminating fpu->fpregs_active,
and we can do that because the two state flags (::fpregs_active and
::fpstate_active) are set essentially together.
The old lazy FPU switching code used to make a distinction - but there's
no lazy switching code anymore,
No change in functionality.
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Dave Hansen
Cc: Fenghua Yu
Cc: H. Peter Anvin
Cc: Linus Torvalds
Cc: Oleg Nesterov
Cc: Peter Zijlstra
Cc: Rik van Riel
Cc: Thomas Gleixner
Cc: Yu-cheng Yu
Signed-off-by: Ingo Molnar
---
arch/x86/include/asm/fpu/xs
Do this temporarily only, to make it easier to change the FPU state machine,
in particular this change couples the fpu->fpregs_active and fpu->fpstate_active
states: they are only set/cleared together (as far as the scheduler sees them).
This will be removed by later patches.
Cc: Andy Lutomirski
1 - 100 of 147 matches
Mail list logo
