[PATCH v2 2/5] video: smscufx: Less checks in ufx_usb_probe() after error detection

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 26 Nov 2017 08:18:20 +0100 Up to four checks could be repeated by the ufx_usb_probe() function during error handling even if the relevant properties can be determined for the involved variables before by source code analysis. * Return directly after a call of the

linux-next: Signed-off-by missing for commit in the hdlcd tree

2017-11-25 Thread Stephen Rothwell
Hi Liviu, Commit 7f2189b12359 ("drm: Fix checkpatch issue: "WARNING: braces {} are not necessary for single statement blocks."") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell

Re: [PATCH v2 1/5] mm: memory_hotplug: Memory hotplug (add) support for arm64

2017-11-25 Thread Arun KS
On Fri, Nov 24, 2017 at 4:23 PM, Maciej Bielski wrote: > On Fri, Nov 24, 2017 at 09:42:33AM +, Andrea Reale wrote: >> Hi Arun, >> >> >> On Fri 24 Nov 2017, 11:25, Arun KS wrote: >> > On Thu, Nov 23, 2017 at 4:43 PM, Maciej Bielski >> > wrote: >> >> [ ...] >> > > Introduces memory hotplug func

Re: [PATCHv2 2/2] userns: control capabilities of some user namespaces

2017-11-25 Thread Serge E. Hallyn
Quoting Mahesh Bandewar (mah...@bandewar.net): > From: Mahesh Bandewar > > With this new notion of "controlled" user-namespaces, the controlled > user-namespaces are marked at the time of their creation while the > capabilities of processes that belong to them are controlled using the > global ma

Re: [PATCHv2 1/2] capability: introduce sysctl for controlled user-ns capability whitelist

2017-11-25 Thread Serge E. Hallyn
Quoting Mahesh Bandewar (mah...@bandewar.net): > From: Mahesh Bandewar > > Add a sysctl variable kernel.controlled_userns_caps_whitelist. This > takes input as capability mask expressed as two comma separated hex > u32 words. The mask, however, is stored in kernel as kernel_cap_t type. > > Any c

Re: perf test LLVM & clang 6 failing

2017-11-25 Thread Yonghong Song
On 11/24/17 11:09 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Nov 24, 2017 at 04:16:52PM +0100, Daniel Borkmann escreveu: [ +Yonghong ] On 11/24/2017 03:47 PM, Arnaldo Carvalho de Melo wrote: FYI, just noticed, recently updated clang to version 6, from its upstream git repo. Do you recall

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-25 Thread Joe Perches
On Sun, 2017-11-26 at 06:51 +0100, Julia Lawall wrote: > > On Sat, 25 Nov 2017, Logan Gunthorpe wrote: > > > Check for lines with a log function using a relatively strict regular > > expression catching only printk, dev_* and pr_* functions. Once > > one is found, accumulate further lines for any

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-25 Thread Julia Lawall
On Sat, 25 Nov 2017, Logan Gunthorpe wrote: > Check for lines with a log function using a relatively strict regular > expression catching only printk, dev_* and pr_* functions. Once > one is found, accumulate further lines for any functions that > are split over multiple lines. I don't understa

Sparse warnings from sched.h

2017-11-25 Thread Jakub Kicinski
Hi! Did these: ./include/linux/sched.h:476:62: error: dubious one-bit signed bitfield ./include/linux/sched.h:477:62: error: dubious one-bit signed bitfield ./include/linux/sched.h:478:62: error: dubious one-bit signed bitfield ./include/linux/sched.h:479:62: error: dubious one-bit signed bitfiel

[PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-25 Thread Logan Gunthorpe
Check for lines with a log function using a relatively strict regular expression catching only printk, dev_* and pr_* functions. Once one is found, accumulate further lines for any functions that are split over multiple lines. Stop accumulating the log function line when we find a ';' or match the

Re: [PATCH] x86/orc: Don't bail on stack overflow

2017-11-25 Thread Josh Poimboeuf
On Sat, Nov 25, 2017 at 10:41:15PM -0600, Josh Poimboeuf wrote: > On Sat, Nov 25, 2017 at 08:25:12PM -0800, Andy Lutomirski wrote: > > On Sat, Nov 25, 2017 at 6:40 PM, Josh Poimboeuf wrote: > > > On Sat, Nov 25, 2017 at 04:16:23PM -0800, Andy Lutomirski wrote: > > >> Can you send me whatever confi

Re: [PATCH] x86/orc: Don't bail on stack overflow

2017-11-25 Thread Josh Poimboeuf
On Sat, Nov 25, 2017 at 08:25:12PM -0800, Andy Lutomirski wrote: > On Sat, Nov 25, 2017 at 6:40 PM, Josh Poimboeuf wrote: > > On Sat, Nov 25, 2017 at 04:16:23PM -0800, Andy Lutomirski wrote: > >> Can you send me whatever config and exact commit hash generated this? > >> I can try to figure out why

Re: [PATCH] x86/orc: Don't bail on stack overflow

2017-11-25 Thread Andy Lutomirski
On Sat, Nov 25, 2017 at 6:40 PM, Josh Poimboeuf wrote: > On Sat, Nov 25, 2017 at 04:16:23PM -0800, Andy Lutomirski wrote: >> Can you send me whatever config and exact commit hash generated this? >> I can try to figure out why it failed. > > Sorry, I've been traveling. I just got some time to take

[PATCH] fs: befs: btree: Fixed some coding standard issues

2017-11-25 Thread Alex Frappier Lachapelle
Fixed some coding standard issues. Signed-off-by: Alex Frappier Lachapelle --- fs/befs/btree.c | 97 ++--- 1 file changed, 51 insertions(+), 46 deletions(-) diff --git a/fs/befs/btree.c b/fs/befs/btree.c index 1b7e0f7128d6..76a401c48bae 100644

d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!

2017-11-25 Thread Fengguang Wu
FYI, we noticed the following commit (built with gcc-4.8): commit: d7be102f2945a626f55e0501e52bb31ba3e77b81 ("cfg80211: initialize regulatory keys/database later") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master in testcase: boot on test machine: qemu-system-x86_64 -enabl

[PATCH] auxdisplay: img-ascii-lcd: add MODULE_LICENSE("GPL")

2017-11-25 Thread Daniel Axtens
This matches the header at the top of the file and squashes: WARNING: modpost: missing MODULE_LICENSE() in drivers/auxdisplay/img-ascii-lcd.o see include/linux/module.h for more information Signed-off-by: Daniel Axtens --- drivers/auxdisplay/img-ascii-lcd.c | 2 ++ 1 file changed, 2 insertions(

Re: [PATCH] x86/orc: Don't bail on stack overflow

2017-11-25 Thread Josh Poimboeuf
On Sat, Nov 25, 2017 at 04:16:23PM -0800, Andy Lutomirski wrote: > Can you send me whatever config and exact commit hash generated this? > I can try to figure out why it failed. Sorry, I've been traveling. I just got some time to take a look at this. I think there are at least two unwinder issue

[lib/rbtree,drm/mm] 653c9f9a4d: BUG:kernel_hang_in_boot_stage

2017-11-25 Thread Fengguang Wu
FYI, we noticed the following commit (built with gcc-5): commit: 653c9f9a4dd8037ffc5afbb1040d15566aa8f533 ("lib/rbtree,drm/mm: Add rbtree_replace_node_cached()") git://anongit.freedesktop.org/drm-intel topic/core-for-CI in testcase: boot on test machine: qemu-system-i386 -enable-kvm -smp 2 -m 3

Re: [PATCH v2] xfs: handle register_shrinker error

2017-11-25 Thread Tetsuo Handa
Dave Chinner wrote: > IOWs, we don't actually need to touch this code, but if you really > must, just remove the KM_NOFS tag. OK. Then, please remove KM_NOFS. GFP_KERNEL is safer than GFP_NOFS in the sense that it won't cause OOM lockup due to unable to invoke the OOM killer.

Re: [PATCH 1/6] perf: Add new type PERF_TYPE_PROBE

2017-11-25 Thread Alexei Starovoitov
On 11/24/17 12:28 AM, Peter Zijlstra wrote: On Thu, Nov 23, 2017 at 10:31:29PM -0800, Alexei Starovoitov wrote: unfortunately 32-bit is more screwed than it seems: $ cat align.c #include struct S { unsigned long long a; } s; struct U { unsigned long long a; } u; int main() { pri

[PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-25 Thread Alex Frappier Lachapelle
Fixed a coding style issue. Signed-off-by: Alex Frappier Lachapelle --- drivers/staging/comedi/drivers/das16.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c index ddd4aeab6365..ed1e9e9b651d

[PATCH v2] Staging: sm750fb: Fix coding style issue in ddk750_sii164.c

2017-11-25 Thread Jeremy Lacomis
This is a patch to the ddk750_sii164.c file that fixes line length warnings found by the checkpatch.pl script Signed-off-by: Jeremy Lacomis --- Changes in v2: - Change definition of i2cReadReg/i2cWriteReg - Remove unnecessary casts drivers/staging/sm750fb/ddk750_sii164.c | 87 --

Re: [PATCH] Input: elantech - add new icbody type 15

2017-11-25 Thread Dmitry Torokhov
On Sun, Nov 19, 2017 at 10:56:47PM +0800, Aaron Ma wrote: > The touchpad of Lenovo Thinkpad L480 reports it's version as 15. > > Cc: sta...@vger.kernel.org > Signed-off-by: Aaron Ma Applied, thank you. > --- > drivers/input/mouse/elantech.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-25 Thread Ishraq Ibne Ashraf
Hi, What was broken was private/device specific IOCTL calls implemented by this driver. The standard IOCTL calls worked and the driver worked as it was in client mode. But in AP mode with hostapd (https://w1.fi/hostapd/) the rtl871xdrv driver of hostapd (which is required for using devices tha

Re: [PATCH] input: pegasus_notetaker: add license information

2017-11-25 Thread Dmitry Torokhov
Hi Martin, On Sat, Nov 18, 2017 at 09:45:18AM +0100, Martin Kepplinger wrote: > This adds an SPDX license identifier to this driver I wrote some time back. > > Signed-off-by: Martin Kepplinger > --- > drivers/input/tablet/pegasus_notetaker.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

[PATCH] rtc: Remove unused RTC_DEVICE_NAME_SIZE

2017-11-25 Thread Cole Robinson
The last usage was removed in 5c82a6ae0 when rtc_device.name was removed Signed-off-by: Cole Robinson --- Just noticed this when looking at commits a few months back... include/linux/rtc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/rtc.h b/include/linux/rtc.h index 41319a2

Re: [PATCH] ASoC: fsl_ssi: Override bit clock rate based on slot number

2017-11-25 Thread Nicolin Chen
On Sat, Nov 25, 2017 at 11:29:48PM +0100, Lukasz Majewski wrote: > Nicolin, do you know what happened with this patch? I couldn't find it > in current linux/master. > > Has it been applied to any asoc tree for being upstreamed? A similar patch with an updated subject got applied: https://git.ker

Re: [PATCH 42/43] x86/mm/kaiser: Allow KAISER to be enabled/disabled at runtime

2017-11-25 Thread Andy Lutomirski
On Sat, Nov 25, 2017 at 2:48 PM, Thomas Gleixner wrote: > On Sat, 25 Nov 2017, Andy Lutomirski wrote: >> > On Nov 25, 2017, at 1:05 PM, Thomas Gleixner wrote: >> > On Sat, 25 Nov 2017, Andy Lutomirski wrote: >> >> Keep in mind that, for a static_branch, actually setting the thing needs >> >> to b

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-11-25 Thread Dmitry Torokhov
On Mon, Nov 20, 2017 at 04:55:30PM +0900, Masaki Ota wrote: > From: Masaki Ota > - The issue is that Thinkpad L570 TrackStick does not work. Because the main > interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface > Firmware setting of TrackStick. The detail is that TrackS

Re: [PATCH] x86/orc: Don't bail on stack overflow

2017-11-25 Thread Andy Lutomirski
Can you send me whatever config and exact commit hash generated this? I can try to figure out why it failed. On Sat, Nov 25, 2017 at 3:13 PM, Thomas Gleixner wrote: > On Sat, 25 Nov 2017, Andy Lutomirski wrote: > >> On Sat, Nov 25, 2017 at 9:28 AM, Andy Lutomirski wrote: >> > If we overflow the

Re: [PATCH] Support TrackStick of Thinkpad L570

2017-11-25 Thread Dmitry Torokhov
Hi, On Mon, Nov 20, 2017 at 04:55:30PM +0900, Masaki Ota wrote: > From: Masaki Ota > - The issue is that Thinkpad L570 TrackStick does not work. Because the main > interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface > Firmware setting of TrackStick. The detail is that T

Re: [PATCH v2] powerpc: fix boot on BOOK3S_32 with CONFIG_STRICT_KERNEL_RWX

2017-11-25 Thread Balbir Singh
On Thu, Nov 23, 2017 at 11:04 PM, Michael Ellerman wrote: > Christophe LEROY writes: >> Le 22/11/2017 à 12:48, Michael Ellerman a écrit : >>> Christophe LEROY writes: Le 22/11/2017 à 00:07, Balbir Singh a écrit : > On Wed, Nov 22, 2017 at 1:28 AM, Christophe Leroy > wrote: >> O

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Philippe Ombredanne
Pavel: On Sat, Nov 25, 2017 at 7:51 PM, Pavel Machek wrote: > On Fri 2017-11-17 15:06:39, Mauro Carvalho Chehab wrote: >> Hi Thomas, >> >> Em Fri, 17 Nov 2017 11:00:33 +0100 (CET) >> Thomas Gleixner escreveu: >> >> > Subject: Documentation: Add license-rules.rst to describe how to properly >> >

Re: [PATCH v2] xfs: handle register_shrinker error

2017-11-25 Thread Dave Chinner
On Fri, Nov 24, 2017 at 09:03:28PM +0900, Tetsuo Handa wrote: > Michal Hocko wrote: > > Thanks. Updated patch below > > --- > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Thu, 23 Nov 2017 17:13:40 +0100 > > Subject: [PATCH] xfs: fortify

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread David Howells
Linus Torvalds wrote: > However, even when you do that, the page can be writable in other > mappings. At least fork(), for example, only clears the dirty bit, > doesn't mark it write-protected. I assumed the rmap walk done by page_mkclean() would take care of that but I'm not really clear on wha

Re: [PATCH] x86/orc: Don't bail on stack overflow

2017-11-25 Thread Thomas Gleixner
On Sat, 25 Nov 2017, Andy Lutomirski wrote: > On Sat, Nov 25, 2017 at 9:28 AM, Andy Lutomirski wrote: > > If we overflow the stack into a guard page and then try to unwind > > it with ORC, it should work perfectly: by construction, there can't > > be any meaningful data in the guard page because

Re: regression: 4.13 cannot follow symlinks on some ext3 fs

2017-11-25 Thread Reindl Harald
Am 25.11.2017 um 23:32 schrieb Dave Chinner: On Fri, Nov 24, 2017 at 03:03:37PM -0700, Andreas Dilger wrote: Any worse an idea than running a new kernel on an old system? Newer e2fsck fixes a lot of bugs that are present in older e2fsck as well... I'm running with everything up to date (debia

[PATCH] nvmem: core: let stride and word_size default to 1

2017-11-25 Thread Heiner Kallweit
If the caller doesn't set stride and/or word_size in struct nvmem_config then nvmem_register accepts this but we may face strange effects later due to both values being 0. Therefore use 1 as default for both values. Signed-off-by: Heiner Kallweit --- drivers/nvmem/core.c | 4 ++-- 1 file change

Re: regression: 4.13 cannot follow symlinks on some ext3 fs

2017-11-25 Thread Dave Chinner
On Sat, Nov 25, 2017 at 11:45:07PM +0100, Reindl Harald wrote: > > Am 25.11.2017 um 23:32 schrieb Dave Chinner: > >On Fri, Nov 24, 2017 at 03:03:37PM -0700, Andreas Dilger wrote: > >>Any worse an idea than running a new kernel on an old system? > >>Newer e2fsck fixes a lot of bugs that are present

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread Linus Torvalds
On Sat, Nov 25, 2017 at 12:35 PM, David Howells wrote: > > Doesn't clear_page_dirty_for_io() write-protect the PTE for the page to be > written out, in which case ->page_mkwrite() will get called again before the > page is redirtied? No, it literally just sets the dirty bit (and does accounting).

[PATCH v2] staging: sm750b: Fix coding style issues in sm750_accel.c

2017-11-25 Thread Jeremy Lacomis
This is a patch to sm750_accel.c that fixes 80-character line length warnings found by checkpatch.pl. It also fixes some grammatical errors in comments and moves parameter-specific comments from inline to before the function. Signed-off-by: Jeremy Lacomis --- Changes in v2: - Change function comm

Re: [PATCH 42/43] x86/mm/kaiser: Allow KAISER to be enabled/disabled at runtime

2017-11-25 Thread Thomas Gleixner
On Sat, 25 Nov 2017, Andy Lutomirski wrote: > > On Nov 25, 2017, at 1:05 PM, Thomas Gleixner wrote: > > On Sat, 25 Nov 2017, Andy Lutomirski wrote: > >> Keep in mind that, for a static_branch, actually setting the thing needs > >> to be deferred, but that's straightforward. > > > > That's not an

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread Dave Chinner
On Sat, Nov 25, 2017 at 10:35:43PM +, David Howells wrote: > Linus Torvalds wrote: > > > So I see in the commit message why afs needs to do this, but it's > > worth pointing out that it's > > > > (a) impossible to avoid the "inconsistent data" case for writable mmap'ed > > pages > > Doesn

Re: [PATCH 0/5] Consolidate init_task handling

2017-11-25 Thread David Howells
I've updated my git branch with changed descriptions, but the content is the same. David

[PATCH] ALSA: ice1724: Fix resume issues with Prodigy 7.1 HiFi

2017-11-25 Thread Yussuf Khalil
There are two issues after resuming from suspend on the Audiotrak Prodigy 7.1 HiFi: - the output volume is set to 100% - microphone input isn't working anymore This patch fixes these issues by reinitializing both codecs of the device and restoring the previous volumes during resume. Signed-off-

Re: [PATCH 0/5] Consolidate init_task handling

2017-11-25 Thread David Howells
Linus Torvalds wrote: > Or at least it's a very unusual use of that word. Why doesn't the > explanation just say what it does: "move", and say from where to where > ("from macro to definition" or something)? > > Or "remove macro XYZ, expanding it in place", or something? To me, > "unroll" has a

Re: [PATCH] Staging: sm750fb: Fix coding style issue in ddk750_sii164.c

2017-11-25 Thread Joe Perches
On Sat, 2017-11-25 at 12:59 -0500, Jeremy Lacomis wrote: > This is a patch to the ddk750_sii164.c file that fixes line length warnings > found by the checkpatch.pl script > > Signed-off-by: Jeremy Lacomis > --- > drivers/staging/sm750fb/ddk750_sii164.c | 39 > +++-- >

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread David Howells
Linus Torvalds wrote: > So I see in the commit message why afs needs to do this, but it's > worth pointing out that it's > > (a) impossible to avoid the "inconsistent data" case for writable mmap'ed > pages Doesn't clear_page_dirty_for_io() write-protect the PTE for the page to be written out

Re: regression: 4.13 cannot follow symlinks on some ext3 fs

2017-11-25 Thread Dave Chinner
On Fri, Nov 24, 2017 at 03:03:37PM -0700, Andreas Dilger wrote: > On Nov 24, 2017, at 9:51 AM, Andi Kleen wrote: > > > >> We checked old kernels, and old e2fsprogs, and didn't see any cases > >> where fast (<= 60 chars) symlinks were created using external blocks. > >> It seems that _something_ d

Re: [PATCH] ASoC: fsl_ssi: Override bit clock rate based on slot number

2017-11-25 Thread Lukasz Majewski
Hi Nicolin, > On Wed, Sep 13, 2017 at 10:02:20AM +0200, Arnaud Mouiche wrote: > > > >Could you please give me a few set of examples of how you set > > >set_sysclk(), set_tdm_slot() with the current driver? The idea > > >here is to figure out a way to calculate the bclk in hw_params > > >without g

Re: [PATCH 1/2] iio: adc: ina2xx: Make calibration register value fixed

2017-11-25 Thread Stefan Brüns
On Wednesday, November 22, 2017 4:32:14 PM CET Maciej Purski wrote: > Calibration register is used for calculating current register in > hardware according to datasheet: > current = shunt_volt * calib_register / 2048 (ina 226) > current = shunt_volt * calib_register / 4096 (ina 219) > > Fix calib_

Re: [PATCH 42/43] x86/mm/kaiser: Allow KAISER to be enabled/disabled at runtime

2017-11-25 Thread Andy Lutomirski
> On Nov 25, 2017, at 1:05 PM, Thomas Gleixner wrote: > > On Sat, 25 Nov 2017, Andy Lutomirski wrote: On Nov 25, 2017, at 12:18 PM, Thomas Gleixner wrote: On Fri, 24 Nov 2017, Ingo Molnar wrote: From: Dave Hansen The KAISER CR3 switches are expensive for many r

[PATCH] NFC: use timer_setup() helper

2017-11-25 Thread Vasyl Gomonovych
Use timer_setup function instead of initializing timer with the function and data fields. net/nfc/core.c:1097:2-12: Use setup_timer function for function on line 1098 net/nfc/hci/core.c:1007:1-11: Use setup_timer function for function on line 1008 net/nfc/hci/llc_shdlc.c:766:1-11: Use setup_timer

Re: [PATCH v2 2/3] iio: adc: ina2xx: Use LSB specifier instead of divider in config

2017-11-25 Thread Stefan Brüns
On Sunday, November 19, 2017 5:15:03 PM CET Jonathan Cameron wrote: > On Sat, 28 Oct 2017 23:12:47 +0200 > > Stefan Brüns wrote: > > While the config uses the physical value corresponding to the LSB > > for both the power and the bus voltage register, the shunt voltage is > > specified as parts o

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-25 Thread Joe Perches
On Sat, 2017-11-25 at 20:12 +0100, Pavel Machek wrote: > [Linus Torvalds...] > > Having it be the first line of the file is good, it's obvious, and > > stands out, which is the point, you want it to, it's a license :) > > What is good about that? License is about the least interesting thing > abou

Re: [PATCH 28/43] x86/mm/kaiser: Map cpu entry area

2017-11-25 Thread Thomas Gleixner
On Fri, 24 Nov 2017, Ingo Molnar wrote: > +void kaiser_add_mapping_cpu_entry(int cpu) > +{ > + kaiser_add_user_map_early(get_cpu_gdt_ro(cpu), PAGE_SIZE, > + __PAGE_KERNEL_RO); > + > + /* includes the entry stack */ > + kaiser_add_user_map_early(&get_cpu_ent

Re: [PATCH 2/2] staging: sm750b: Fix coding style issues in sm750_accel.c

2017-11-25 Thread Joe Perches
On Sat, 2017-11-25 at 13:26 -0500, Jeremy Lacomis wrote: > This is a patch to sm750_accel.c that fixes 80-character line length > warnings found by checkpatch.pl. It also fixes some grammatical errors > in comments and moves parameter-specific comments from inline to before > the function. [] > + *

[PATCH RFC] veth: make veth aware of gso buffer size

2017-11-25 Thread Solio Sarabia
GSO buffer size supported by underlying devices is not propagated to veth. In high-speed connections with hw TSO enabled, veth sends buffers bigger than lower device's maximum GSO, forcing sw TSO and increasing system CPU usage. Signed-off-by: Solio Sarabia --- Exposing gso_max_size via sysfs is

Re: [PATCH v3] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-25 Thread Dan Carpenter
Thanks. This is looking *much* better... On Sat, Nov 25, 2017 at 07:29:41PM +0100, ishraq.i.ash...@gmail.com wrote: > From: Ishraq Ibne Ashraf > > Commit 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback") breaks > private WEXT > IOCTL calls of this driver as these are not invoked th

Re: [PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-25 Thread Willem de Bruijn
On Sat, Nov 25, 2017 at 2:14 PM, Gustavo A. R. Silva wrote: > gso_type is being used in binary AND operations together with SKB_GSO_UDP. > The issue is that variable gso_type is of type unsigned short and > SKB_GSO_UDP expands to more than 16 bits: > > SKB_GSO_UDP = 1 << 16 > > this makes any bina

[PATCH 5/5] video: smscufx: Adjust three checks for null pointers

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 25 Nov 2017 21:21:20 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code pla

Re: [PATCH 2/2] hwmon: (ina2xx) Make calibration register value fixed

2017-11-25 Thread Stefan Brüns
On Saturday, November 25, 2017 7:50:16 PM CET Guenter Roeck wrote: > On 11/22/2017 07:32 AM, Maciej Purski wrote: > > Calibration register is used for calculating current register in > > hardware according to datasheet: > > current = shunt_volt * calib_register / 2048 (ina 226) > > current = shunt_

[PATCH 4/5] video: smscufx: Improve a size determination in two functions

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 25 Nov 2017 21:10:22 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Marku

[PATCH 3/5] video: smscufx: Return an error code only as a constant in ufx_realloc_framebuffer()

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 25 Nov 2017 19:56:44 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/video/fbdev/smsc

[PATCH 2/5] video: smscufx: Less checks in ufx_usb_probe() after error detection

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 25 Nov 2017 19:47:51 +0100 Up to four checks could be repeated by the ufx_usb_probe() function during error handling even if the relevant properties can be determined for the involved variables before by source code analysis. * Return directly after a call of the

[PATCH 1/5] video: smscufx: Delete an error message for a failed memory allocation in two functions

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 25 Nov 2017 18:32:29 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/smscufx.c | 8 ++-- 1 file changed, 2 insert

[PATCH 0/5] video-SMSC UFX: Adjustments for five function implementations

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 25 Nov 2017 21:38:42 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Delete an error message for a failed memory allocation in two functions Less checks in ufx_usb_probe() after error detection Ret

Re: [PATCH] lib: memmove: Use optimised memcpy if possible

2017-11-25 Thread Dan Carpenter
Paul's original patch should have been separated into two patches to begin with. The patch does two different things and one part goes through the MIPS tree and one part goes through Andrew, probably. On Sat, Nov 25, 2017 at 10:52:04PM +0530, PrasannaKumar Muralidharan wrote: > Hi, > > On 4 Octo

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Linus Torvalds
On Sat, Nov 25, 2017 at 9:53 AM, Mauro Carvalho Chehab wrote: > > Let me see if I got it straight. At drivers/media/common/siano/smsir.c, > we have, currently: .. snip snip .. > With is completely out of standard. I'd like to add an SPDX tag there > and, while doing that, adjust the comments. >

Re: [PATCH] hwmon: (pmbus) Use 64bit math for DIRECT format values

2017-11-25 Thread kbuild test robot
Hi Robert, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on v4.14 next-20171124] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH v6 01/11] intel_sgx: updated MAINTAINERS

2017-11-25 Thread Joe Perches
On Sat, 2017-11-25 at 21:29 +0200, Jarkko Sakkinen wrote: > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -14932,6 +14932,11 @@ L: linux...@kvack.org > S: Maintained > F: mm/zswap.c > > +INTEL SGX > +M: Jarkko Sakkinen > +L: intel-sgx-kernel-...@lists.01.org > +Q: https://patchwor

[PATCH v4] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-11-25 Thread Pierre-Hugues Husson
Support the "cec" optional clock. The documentation already mentions "cec" optional clock and it is used by several boards, but currently the driver doesn't enable it, thus preventing cec from working on those boards. And even worse: a /dev/cecX device will appear for those boards, but it won't be

Re: [PATCH] x86/mm/kaiser: Fix IRQ entries text section mapping

2017-11-25 Thread Steven Rostedt
On Sat, 25 Nov 2017 17:08:08 +0100 (CET) Thomas Gleixner wrote: > Tracing uses it to stop the printout of the function graph. Should be safe > to print the C-Code functions. It uses it to filter out interrupts, as well as to print the: "<==" "==>" annotations. Since function t

Re: [PATCH 42/43] x86/mm/kaiser: Allow KAISER to be enabled/disabled at runtime

2017-11-25 Thread Thomas Gleixner
On Sat, 25 Nov 2017, Andy Lutomirski wrote: > > On Nov 25, 2017, at 12:18 PM, Thomas Gleixner wrote: > >> On Fri, 24 Nov 2017, Ingo Molnar wrote: > >> > >> From: Dave Hansen > >> > >> The KAISER CR3 switches are expensive for many reasons. Not all systems > >> benefit from the protection provi

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Mauro Carvalho Chehab
Em Sat, 25 Nov 2017 09:30:46 -1000 Linus Torvalds escreveu: > On Sat, Nov 25, 2017 at 9:17 AM, Pavel Machek wrote: > > > > There's logical place in the comment, and it should look like this: > > > > /* > > * Driver for SMSC USB3503 USB 2.0 hub controller driver > > * > > * SPDX-License-Identi

Re: [PATCH 42/43] x86/mm/kaiser: Allow KAISER to be enabled/disabled at runtime

2017-11-25 Thread Andy Lutomirski
> On Nov 25, 2017, at 12:18 PM, Thomas Gleixner wrote: > >> On Fri, 24 Nov 2017, Ingo Molnar wrote: >> >> From: Dave Hansen >> >> The KAISER CR3 switches are expensive for many reasons. Not all systems >> benefit from the protection provided by KAISER. Some of them can not >> pay the high

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Linus Torvalds
On Sat, Nov 25, 2017 at 9:17 AM, Pavel Machek wrote: > > There's logical place in the comment, and it should look like this: > > /* > * Driver for SMSC USB3503 USB 2.0 hub controller driver > * > * SPDX-License-Identifier: GPL-2.0+ > * Copyright (c) 2012-2013 Dongjin Kim (tobet...@gmail.co

[PATCH v6 11/11] intel_sgx: driver documentation

2017-11-25 Thread Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen --- Documentation/index.rst | 1 + Documentation/x86/intel_sgx.rst | 101 2 files changed, 102 insertions(+) create mode 100644 Documentation/x86/intel_sgx.rst diff --git a/Documentation/index.rst b/Documentation/

[PATCH v6 06/11] intel_sgx: driver for Intel Software Guard Extensions

2017-11-25 Thread Jarkko Sakkinen
Intel SGX is a set of CPU instructions that can be used by applications to set aside private regions of code and data. The code outside the enclave is disallowed to access the memory inside the enclave by the CPU access control. SGX driver provides a ioctl API for loading and initializing enclave

[PATCH v6 10/11] intel_sgx: glue code for in-kernel LE

2017-11-25 Thread Jarkko Sakkinen
Glue code for hosting in-kernel Launch Enclave (LE) by using the user space helper framework. Tokens for launching enclaves are generated with by the following protocol: 1. The driver sends a SIGSTRUCT blob to the LE hosting process to the input pipe. 2. The LE hosting process reads the SIGSTR

[PATCH v6 09/11] fs/pipe.c: export create_pipe_files() and replace_fd()

2017-11-25 Thread Jarkko Sakkinen
Exported create_pipe_files() and replace_fd() because the SGX driver needs to be able to setup pipes in order to communicate with the helper process that hosts the Launch Enclave (LE). The pipe creation will be done in the init-callback supplied to call_usermodehelper_setup(). The driver will use

[PATCH v6 08/11] intel_sgx: in-kernel launch enclave

2017-11-25 Thread Jarkko Sakkinen
This commits implements the in-kernel launch enclave. It is wrapped into a user space program that reads SIGSTRUCT instances from stdin and outputs launch tokens to stdout. The commit also adds enclave signing tool that is used by kbuild to measure and sign the launch enclave. CONFIG_INTEL_SGX_SI

[PATCH v6 03/11] x86: define IA32_FEATURE_CONTROL.SGX_ENABLE

2017-11-25 Thread Jarkko Sakkinen
From: Sean Christopherson When IA32_FEATURE_CONTROL.SGX_ENABLE and IA32_FEATURE_CONTROL.LOCK are set by the pre-boot firmware, SGX is usable by the OS. Signed-off-by: Sean Christopherson Signed-off-by: Jarkko Sakkinen --- arch/x86/include/asm/msr-index.h | 1 + 1 file changed, 1 insertion(+)

[PATCH v6 04/11] x86: define IA32_FEATUE_CONTROL.SGX_LC

2017-11-25 Thread Jarkko Sakkinen
When IA32_FEATURE_CONTROL.SGX_LC identifies that the root key for enclave signatures can be configured either by the OS or pre-boot firmware. If this the case, IA32_SGXLEPUBKEYHASHn MSRs (0 < n < 4) can be used to set the SHA256 of the root key. IA32_FEATURE_CONTROL bit 17 controls whether the MSR

[PATCH v6 00/11] Intel SGX Driver

2017-11-25 Thread Jarkko Sakkinen
Intel(R) SGX is a set of CPU instructions that can be used by applications to set aside private regions of code and data. The code outside the enclave is disallowed to access the memory inside the enclave by the CPU access control. In a way you can think that SGX provides inverted sandbox. It prote

[PATCH v6 01/11] intel_sgx: updated MAINTAINERS

2017-11-25 Thread Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2d3d750b19c0..30a4b7f97a93 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14932,6 +14932,11 @@ L: linux...@kvack.org S: Maintained F: mm/zswap.c

[PATCH v6 07/11] intel_sgx: ptrace() support

2017-11-25 Thread Jarkko Sakkinen
Implemented VMA callbacks in order to ptrace() debug enclaves. With debug enclaves data can be read and write the memory word at a time by using ENCLS(EDBGRD) and ENCLS(EDBGWR) leaf instructions. Signed-off-by: Jarkko Sakkinen --- drivers/platform/x86/intel_sgx/sgx_vma.c | 119 ++

[PATCH v6 02/11] x86: add SGX definition to cpufeature

2017-11-25 Thread Jarkko Sakkinen
From: Kai Huang Added X86_FEATURE_SGX, which identifies that CPU supports software guard extensions (SGX). Signed-off-by: Kai Huang Signed-off-by: Jarkko Sakkinen --- arch/x86/include/asm/cpufeatures.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/asm/cpufeatures.h b/a

[PATCH v6 05/11] x86: add SGX MSRs to msr-index.h

2017-11-25 Thread Jarkko Sakkinen
From: Haim Cohen These MSRs hold the SHA256 checksum of the currently configured root key for enclave signatures. Signed-off-by: Haim Cohen Signed-off-by: Jarkko Sakkinen --- arch/x86/include/asm/msr-index.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/include/asm/msr-i

lib/zstd/decompress.c:416:2: warning: argument 1 null where non-null expected

2017-11-25 Thread kbuild test robot
Hi Nick, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 844056fd74ebdd826bd23a7d989597e15f478acb commit: 5c1aab1dd5445ed8bdcdbb575abc1b0d7ee5b2e7 btrfs: Add zstd support date: 3 months ago config: x86_64-randcon

Re: [PATCH net] net: dsa: fix 'increment on 0' warning

2017-11-25 Thread David Miller
From: Vivien Didelot Date: Fri, 24 Nov 2017 11:36:06 -0500 > Setting the refcount to 0 when allocating a tree to match the number of > switch devices it holds may cause an 'increment on 0; use-after-free', > if CONFIG_REFCOUNT_FULL is enabled. > > To fix this, do not decrement the refcount of a

Re: [PATCH v2] VSOCK: Don't call vsock_stream_has_data in atomic context

2017-11-25 Thread David Miller
From: Jorgen Hansen Date: Fri, 24 Nov 2017 06:25:28 -0800 > When using the host personality, VMCI will grab a mutex for any > queue pair access. In the detach callback for the vmci vsock > transport, we call vsock_stream_has_data while holding a spinlock, > and vsock_stream_has_data will access a

Re: [PATCH 42/43] x86/mm/kaiser: Allow KAISER to be enabled/disabled at runtime

2017-11-25 Thread Thomas Gleixner
On Fri, 24 Nov 2017, Ingo Molnar wrote: > From: Dave Hansen > > The KAISER CR3 switches are expensive for many reasons. Not all systems > benefit from the protection provided by KAISER. Some of them can not > pay the high performance cost. > > This patch adds a debugfs file. To disable KAISE

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Pavel Machek
On Sat 2017-11-25 09:11:58, Linus Torvalds wrote: > On Sat, Nov 25, 2017 at 9:04 AM, Pavel Machek wrote: > > > > That does not sound like he was deciding between /* */ and //. And > > actually this was in context of files with no existing license. You > > made the ugly patches. Stop hiding behind

[PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-25 Thread Gustavo A. R. Silva
gso_type is being used in binary AND operations together with SKB_GSO_UDP. The issue is that variable gso_type is of type unsigned short and SKB_GSO_UDP expands to more than 16 bits: SKB_GSO_UDP = 1 << 16 this makes any binary AND operation between gso_type and SKB_GSO_UDP to be always zero, henc

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-25 Thread Pavel Machek
Hi! > > This would be even better: > > > > /* > > * Driver for SMSC USB3503 USB 2.0 hub controller driver > > * > > * Copyright (c) 2012-2013 Dongjin Kim (tobet...@gmail.com) > > */ > > ... > > SPDX_MODULE_LICENSE("GPL-2.0+") > > > > So yes, SPDX can be improvement. But in current implementa

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Linus Torvalds
On Sat, Nov 25, 2017 at 9:04 AM, Pavel Machek wrote: > > That does not sound like he was deciding between /* */ and //. And > actually this was in context of files with no existing license. You > made the ugly patches. Stop hiding behind Linus. No, Linus happily stands up for //. I really don't

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Pavel Machek
On Wed 2017-11-22 14:48:04, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 09:51:17AM -0200, Mauro Carvalho Chehab wrote: > > Em Wed, 22 Nov 2017 12:12:04 +0100 (CET) > > Thomas Gleixner escreveu: > > > > > On Fri, 17 Nov 2017, Christoph Hellwig wrote: > > > > On Fri, Nov 17, 2017 at 07:11:4

hi3521a syscon-reboot issue, reboot fails oddly.

2017-11-25 Thread Marty E. Plummer
Greetings, Having a slight issue with getting reboot to work on the board I'm tinkering with; according to the documentation writing any value to 0x12050004 should reset the system, as such I have the following snippet in my dts to make it work: sysctrl: system-controller@1205 { compa

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Pavel Machek
On Fri 2017-11-17 15:06:39, Mauro Carvalho Chehab wrote: > Hi Thomas, > > Em Fri, 17 Nov 2017 11:00:33 +0100 (CET) > Thomas Gleixner escreveu: > > > Subject: Documentation: Add license-rules.rst to describe how to properly > > identify file licenses > > From: Thomas Gleixner > > Date: Fri, 10

  1   2   >