Re: [PATCH 1/6] perf: Add new type PERF_TYPE_PROBE

2017-11-26 Thread Peter Zijlstra
On Sat, Nov 25, 2017 at 05:59:54PM -0800, Alexei Starovoitov wrote: > If we were poking into 'struct perf_event_attr __user *uptr' > directly like get|put_user(.., &uptr->config) > then 32-bit user space with 4-byte aligned u64s would cause > 64-bit kernel to trap on archs like sparc. But surely

Re: [PATCH] input: pegasus_notetaker: add license information

2017-11-26 Thread Greg Kroah-Hartman
On Sun, Nov 26, 2017 at 12:28:49PM +0100, Philippe Ombredanne wrote: > Greg, Martin: > > On Sun, Nov 26, 2017 at 9:59 AM, Greg Kroah-Hartman > wrote: > > On Sat, Nov 25, 2017 at 04:42:59PM -0800, Dmitry Torokhov wrote: > >> Hi Martin, > >> > >> On Sat, Nov 18, 2017 at 09:45:18AM +0100, Martin Kep

[PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

2017-11-26 Thread Sagar Arun Kamble
There is no real need for the users of timecounters to define cyclecounter and timecounter variables separately. Since timecounter will always be based on cyclecounter, have cyclecounter struct as member of timecounter struct. Suggested-by: Chris Wilson Signed-off-by: Sagar Arun Kamble Cc: John

Re: [PATCH v2] input: pegasus_notetaker: add license information

2017-11-26 Thread Greg KH
On Mon, Nov 27, 2017 at 08:44:01AM +0100, Martin Kepplinger wrote: > This adds an SPDX license identifier to this driver I wrote some time back. > > Signed-off-by: Martin Kepplinger > --- > > Thanks for the feedback. GPL2+ was what I had in mind. My bad. And as I > already see a lot of SPDX tags

[lkp-robot] [x86/mm/kasan] d17a1d97dc: WARNING:at_lib/stackdepot.c:#depot_save_stack

2017-11-26 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-7): commit: d17a1d97dc208d664c91cc387ffb752c7f85dc61 ("x86/mm/kasan: don't use vmemmap_populate() to initialize shadow") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master in testcase: trinity with following parameters:

[PATCH] x86/mm/kmmio: Fix mmiotrace for page unaligned addresses

2017-11-26 Thread Karol Herbst
If something calls ioremap with an address not aligned to PAGE_SIZE, the returned address might be not aligned as well. This led to a probe registered on exactly the returned address, but the entire page was armed for mmiotracing. On calling iounmap the address passed to unregister_kmmio_probe was

[RFC PATCH 2/3] net: macb: Tie-off unused RX queues

2017-11-26 Thread Harini Katakam
From: "Edgar E. Iglesias" Currently, we only use the first receive queue and leave the remaining DMA descriptor pointers pointing at 0. Disable unused queues by connecting them to a looped descriptor chain without free slots. Signed-off-by: Edgar E. Iglesias Signed-off-by: Harini Katakam Sign

Re: [PATCH] mm:Add watermark slope for high mark

2017-11-26 Thread kbuild test robot
Hi Peter, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.15-rc1 next-20171127] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

[PATCH v2] input: pegasus_notetaker: add license information

2017-11-26 Thread Martin Kepplinger
This adds an SPDX license identifier to this driver I wrote some time back. Signed-off-by: Martin Kepplinger --- Thanks for the feedback. GPL2+ was what I had in mind. My bad. And as I already see a lot of SPDX tags using /**/ comments, I'll use that too. I think if it is hand-written, it should

[RFC PATCH 1/3] net: macb: Add RBQP to the macb queues

2017-11-26 Thread Harini Katakam
From: "Edgar E. Iglesias" Add RX queue pointer to macb queues to make it accessible for the multiple queues available. Currently the first RX queue is used. Signed-off-by: Edgar E. Iglesias Signed-off-by: Harini Katakam Signed-off-by: Michal Simek --- drivers/net/ethernet/cadence/macb.h

[RFC PATCH 3/3] net: macb: Handle HRESP error

2017-11-26 Thread Harini Katakam
From: Harini Katakam Handle HRESP error by doing a SW reset of RX and TX and re-initializing the descriptors, RX and TX queue pointers. Signed-off-by: Harini Katakam Signed-off-by: Michal Simek --- drivers/net/ethernet/cadence/macb.h | 2 + drivers/net/ethernet/cadence/macb_main.c | 65

[RFC PATCH 0/3] Miscellaneous fixes in macb driver

2017-11-26 Thread Harini Katakam
This series fixes the following: -> Ties off unused RX queues -> Handles RX HRESP error Edgar E. Iglesias (2): net: macb: Add RBQP to the macb queues net: macb: Tie-off unused RX queues Harini Katakam (1): net: macb: Handle HRESP error drivers/net/ethernet/cadence/macb.h | 5 ++ dr

Re: [RFC PATCH 1/2] net: macb: Add RBQP to the macb queues

2017-11-26 Thread Harini Katakam
Hi, Please ignore this series. I'm sending another updated one. Sorry for the inconvenience. Regards, Harini On Mon, Nov 27, 2017 at 12:33 PM, Harini Katakam wrote: > From: "Edgar E. Iglesias" > > Add RX queue pointer to macb queues to make it accessible for the > multiple queues available. Cu

[PATCH v7,2/2] misc: rtsx: Add support for RTS5260

2017-11-26 Thread rui_feng
From: Rui Feng Add support for new chip rts5260. In order to support rts5260, the definitions of some internal registers and workflow have to be modified and are different from its predecessors and OCP function is added for RTS5260. So we need this patch to ensure RTS5260 can work. Signed-off-by

[PATCH v7,1/2] misc: rtsx: Move Realtek Card Reader Driver to misc

2017-11-26 Thread rui_feng
From: Rui Feng Because Realtek card reader drivers are pcie and usb drivers, and they bridge mmc subsystem and memstick subsystem, they are not mfd drivers. Greg and Lee Jones had a discussion about where to put the drivers, the result is that misc is a good place for them, so I move all files to

Re: [PATCH] s390/drivers: use setup_timer instead of init_timer

2017-11-26 Thread Julian Wiedmann
On 11/24/2017 01:50 PM, Colin King wrote: > From: Colin Ian King > > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Colin Ian King > --- > drivers/s390/net/fsm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff

Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-11-26 Thread Łukasz Stelmach
It was <2017-11-24 pią 16:25>, when PrasannaKumar Muralidharan wrote: >> +} >> + >> +static int exynos_trng_do_read(struct hwrng *rng, void *data, size_t max, >> + bool wait) >> +{ >> + struct exynos_trng_dev *trng; >> + u32 val; >> + >> + max = max >

[PATCH v4 2/4] vm: add a syscall to map a process memory into a pipe

2017-11-26 Thread Mike Rapoport
From: Andrei Vagin It is a hybrid of process_vm_readv() and vmsplice(). vmsplice can map memory from a current address space into a pipe. process_vm_readv can read memory of another process. A new system call can map memory of another process into a pipe. ssize_t process_vmsplice(pid_t pid, in

[PATCH] process_vmsplice.2: New page describing process_vmsplice(2) system call.

2017-11-26 Thread Mike Rapoport
Signed-off-by: Mike Rapoport --- man2/process_vmsplice.2 | 188 1 file changed, 188 insertions(+) create mode 100644 man2/process_vmsplice.2 diff --git a/man2/process_vmsplice.2 b/man2/process_vmsplice.2 new file mode 100644 index 000..b99c06

[PATCH v4 1/4] fs/splice: introduce pages_to_pipe helper

2017-11-26 Thread Mike Rapoport
Signed-off-by: Mike Rapoport --- fs/splice.c | 57 - 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/fs/splice.c b/fs/splice.c index 39e2dc0..7f1ffc5 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -1185,6 +1185,36 @@ static lo

[PATCH v4 3/4] x86: wire up the process_vmsplice syscall

2017-11-26 Thread Mike Rapoport
From: Andrei Vagin Signed-off-by: Andrei Vagin --- arch/x86/entry/syscalls/syscall_32.tbl | 1 + arch/x86/entry/syscalls/syscall_64.tbl | 2 ++ 2 files changed, 3 insertions(+) diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl index 448ac21..dc64bf5

[PATCH v4 4/4] test: add a test for the process_vmsplice syscall

2017-11-26 Thread Mike Rapoport
From: Andrei Vagin This test checks that process_vmsplice() can splice pages from a remote process and returns EFAULT, if process_vmsplice() tries to splice pages by an unaccessiable address. Signed-off-by: Andrei Vagin Signed-off-by: Mike Rapoport --- tools/testing/selftests/process_vmsplice

[PATCH v4 0/4] vm: add a syscall to map a process memory into a pipe

2017-11-26 Thread Mike Rapoport
Hi, This patches introduces new process_vmsplice system call that combines functionality of process_vm_read and vmsplice. It allows to map the memory of another process into a pipe, similarly to what vmsplice does for its own address space. The patch 2/4 ("vm: add a syscall to map a process memo

[PATCH RESEND] net: phy: harmonize phy_id{,_mask} data type

2017-11-26 Thread Richard Leitner
From: Richard Leitner Previously phy_id was u32 and phy_id_mask was unsigned int. As the phy_id_mask defines the important bits of the phy_id (and is therefore the same size) these two variables should be the same data type. Signed-off-by: Richard Leitner Reviewed-by: Florian Fainelli Reviewed

[RFC PATCH 2/2] net: macb: Tie-off unused RX queues

2017-11-26 Thread Harini Katakam
From: "Edgar E. Iglesias" Currently, we only use the first receive queue and leave the remaining DMA descriptor pointers pointing at 0. Disable unused queues by connecting them to a looped descriptor chain without free slots. Signed-off-by: Edgar E. Iglesias Signed-off-by: Harini Katakam Sign

[RFC PATCH 1/2] net: macb: Add RBQP to the macb queues

2017-11-26 Thread Harini Katakam
From: "Edgar E. Iglesias" Add RX queue pointer to macb queues to make it accessible for the multiple queues available. Currently the first RX queue is used. Signed-off-by: Edgar E. Iglesias Signed-off-by: Harini Katakam Signed-off-by: Michal Simek --- drivers/net/ethernet/cadence/macb.h

Re: [PATCH v4 2/4] tpm: ignore burstcount to improve tpm_tis send() performance

2017-11-26 Thread Leendert van Doorn
Hmm, this is almost 20 years old code ( I think the original code did a burst write and didn't check for error conditions until the very last byte write. I seem to remember that there was some text in the original standard to that effect (this may have gone back as far as IBM's ESS spec). The

[PATCH] i2c: core: decrease reference count of device node in i2c_unregister_device

2017-11-26 Thread Lixin Wang
Reference count of device node was increased in of_i2c_register_device, but without decreasing it in i2c_unregister_device. Then the dynamically added device node will never be released. Fix this by adding the of_node_put. Signed-off-by: Lixin Wang --- drivers/i2c/i2c-core-base.c | 4 +++- 1 fil

Re: [PATCH] mm:Add watermark slope for high mark

2017-11-26 Thread kbuild test robot
Hi Peter, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.15-rc1 next-20171124] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

[PATCH v3 02/21] fpga: mgr: add region_id to fpga_image_info

2017-11-26 Thread Wu Hao
This patch adds region_id to fpga_image_info data structure, it allows driver to pass region id information to fpga-mgr via fpga_image_info for fpga reconfiguration function. Signed-off-by: Wu Hao v3: add one line comment for region_id --- include/linux/fpga/fpga-mgr.h | 2 ++ 1 file change

[PATCH v3 01/21] docs: fpga: add a document for Intel FPGA driver overview

2017-11-26 Thread Wu Hao
Add a document for Intel FPGA driver overview. Signed-off-by: Enno Luebbers Signed-off-by: Xiao Guangrong Signed-off-by: Wu Hao v2: added FME fpga-mgr/bridge/region platform driver to driver organization. updated open discussion per current implementation. fixed some typos. v3: use

[PATCH v3 00/21] Intel FPGA Device Drivers

2017-11-26 Thread Wu Hao
Hi All, Here is v3 patch-series adding drivers for Intel FPGA devices. The Intel FPGA driver provides interfaces for userspace applications to configure, enumerate, open, and access FPGA accelerators on platforms equipped with Intel(R) PCIe based FPGA solutions and enables system level management

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-26 Thread Julia Lawall
On Sun, 26 Nov 2017, Logan Gunthorpe wrote: > > > On 26/11/17 11:42 PM, Julia Lawall wrote: > > Although I guess that in that case the whole exercise is pointless? > > Because every print will at runtime be followed by another print, which > > will add either the newline or a continuation. > > Y

[PATCH v3 04/21] fpga: add device feature list support

2017-11-26 Thread Wu Hao
Device Feature List (DFL) defines a feature list structure that creates a link list of feature headers within the MMIO space to provide an extensible way of adding features. This patch introduces a kernel module to provide basic infrastructure to support FPGA devices which implement the Device Feat

[PATCH v3 06/21] fpga: dfl: adds fpga_cdev_find_port

2017-11-26 Thread Wu Hao
For feature devices, e.g FPGA Management Engine (FME), it may require fpga_cdev_find_port function to find dedicate port for further actions, so export this function from feature device driver module. Signed-off-by: Tim Whisonant Signed-off-by: Enno Luebbers Signed-off-by: Shiva Rao Signed-off-

[PATCH v3 07/21] fpga: dfl: add feature device infrastructure

2017-11-26 Thread Wu Hao
From: Xiao Guangrong This patch abstracts the common operations of the sub features, and defines the feature_ops data structure, including init, uinit and ioctl function pointers. And this patch adds some common helper functions for FME and AFU drivers, e.g feature_dev_use_begin/end which are use

[PATCH v3 10/21] fpga: dfl: add FPGA Management Engine driver basic framework

2017-11-26 Thread Wu Hao
From: Kang Luwei The FPGA Management Engine (FME) provides power, thermal management, performance counters, partial reconfiguration and other functions. For each function, it is packaged into a private feature linked to the FME feature device in the 'Device Feature List'. It's a platform device c

[PATCH] f2fs: avoid false positive of free secs check

2017-11-26 Thread Yunlong Song
Sometimes f2fs_gc is called with no target victim (e.g. xfstest generic/027, ndirty_node:545 ndiry_dent:1 ndirty_imeta:513 rsvd_segs:21 free_segs:27, has_not_enough_free_secs will return true). This patch first merges pages and then converts into sections. Signed-off-by: Yunlong Song --- fs/f2fs

[PATCH v3 11/21] fpga: dfl: fme: add header sub feature support

2017-11-26 Thread Wu Hao
From: Kang Luwei The header register set is always present for FPGA Management Engine (FME), this patch implements init and uinit function for header sub feature and introduce several read-only sysfs interfaces for the capability and status. Sysfs interfaces: * /sys/class/fpga_region///ports_num

[PATCH v3 09/21] fpga: intel-dfl-pci: add enumeration for feature devices

2017-11-26 Thread Wu Hao
The Device Feature List (DFL) is implemented in MMIO, and features are linked via the DFLs. This patch enables pcie driver to prepare enumeration information (e.g locations of all device feature lists in MMIO) and use common APIs provided by the Device Feature List framework to enumerate each featu

[PATCH v3 15/21] fpga: dfl: add fpga bridge platform driver for FME

2017-11-26 Thread Wu Hao
This patch adds fpga bridge platform driver for FPGA Management Engine. It implements the enable_set call back for fpga bridge. Signed-off-by: Tim Whisonant Signed-off-by: Enno Luebbers Signed-off-by: Shiva Rao Signed-off-by: Christopher Rauer Signed-off-by: Wu Hao v3: rename driver to f

[PATCH v3 16/21] fpga: dfl: add fpga region platform driver for FME

2017-11-26 Thread Wu Hao
This patch adds fpga region platform driver for FPGA Management Engine. It register an fpga region with given fpga manager / bridge device. Signed-off-by: Tim Whisonant Signed-off-by: Enno Luebbers Signed-off-by: Shiva Rao Signed-off-by: Christopher Rauer Signed-off-by: Wu Hao v3: rename

[PATCH v3 12/21] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2017-11-26 Thread Wu Hao
FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which need to be supported by all feature devices drivers including FME and AFU. Userspace application can use these ioctl interfaces to get the API info and check if specific extension is supported or not in current driver. This

[PATCH v3 18/21] fpga: dfl: afu: add header sub feature support

2017-11-26 Thread Wu Hao
The port header register set is always present for port, it is mainly for capability, control and status of the ports that AFU connected to. This patch implements header sub feature support. Below user interfaces are created by this patch. Sysfs interface: * /sys/class/fpga_region///id Read-onl

[PATCH v3 20/21] fpga: dfl: afu: add user afu sub feature support

2017-11-26 Thread Wu Hao
From: Xiao Guangrong User Accelerated Function Unit sub feature exposes the MMIO region of the AFU. After valid green bitstream (GBS) is programmed and port is enabled, then this MMIO region could be accessed. This patch adds support to enumerate the AFU MMIO region and expose it to userspace vi

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-26 Thread Logan Gunthorpe
On 26/11/17 11:42 PM, Julia Lawall wrote: > Although I guess that in that case the whole exercise is pointless? > Because every print will at runtime be followed by another print, which > will add either the newline or a continuation. Yes, in practice the '\n' at the end of every log line is opt

[PATCH v3 19/21] fpga: dfl: afu: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2017-11-26 Thread Wu Hao
FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which need to be supported by all feature devices drivers including FME and AFU. This patch implements above 2 ioctls in FPGA Accelerated Function Unit (AFU) driver. Signed-off-by: Tim Whisonant Signed-off-by: Enno Luebbers Sig

[PATCH v3 14/21] fpga: dfl: add fpga manager platform driver for FME

2017-11-26 Thread Wu Hao
This patch adds fpga manager driver for FPGA Management Engine (FME). It implements fpga_manager_ops for FPGA Partial Reconfiguration function. Signed-off-by: Tim Whisonant Signed-off-by: Enno Luebbers Signed-off-by: Shiva Rao Signed-off-by: Christopher Rauer Signed-off-by: Kang Luwei Signed-

[PATCH v3 21/21] fpga: dfl: afu: add FPGA_PORT_DMA_MAP/UNMAP ioctls support

2017-11-26 Thread Wu Hao
DMA memory regions are required for Accelerated Function Unit (AFU) usage. These two ioctls allow user space applications to map user memory regions for dma, and unmap them after use. Iova is returned from driver to user space application via FPGA_PORT_DMA_MAP ioctl. Application needs to unmap it a

[PATCH v3 03/21] fpga: mgr: add status for fpga-manager

2017-11-26 Thread Wu Hao
This patch adds status to fpga-manager data structure, to allow driver to store full/partial reconfiguration errors and other status information, and adds one status callback to fpga_manager_ops to allow fpga_manager to collect latest status when failures are detected. The following sysfs file is

[PATCH v3 05/21] fpga: dfl: add chardev support for feature devices

2017-11-26 Thread Wu Hao
For feature devices drivers, both the FPGA Management Engine (FME) and Accelerated Function Unit (AFU) driver need to expose user interfaces via the device file, for example, mmap and ioctls. This patch adds chardev support in the fpga-dfl driver for feature devices, FME and AFU. It reserves the c

[PATCH v3 13/21] fpga: dfl: fme: add partial reconfiguration sub feature support

2017-11-26 Thread Wu Hao
From: Kang Luwei Partial Reconfiguration (PR) is the most important function for FME. It allows reconfiguration for given Port/Accelerated Function Unit (AFU). It creates platform devices for fpga-mgr, fpga-regions and fpga-bridges, and invokes fpga-region's interface (fpga_region_program_fpga)

[PATCH v3 17/21] fpga: dfl: add FPGA Accelerated Function Unit driver basic framework

2017-11-26 Thread Wu Hao
On DFL FPGA devices, the Accelerated Function Unit (AFU), can be reprogrammed for different functions. It connects to the FPGA infrastructure("blue bistream") via a Port. Port CSRs are implemented separately from the AFU CSRs to provide control and status of the Port. Once valid green bitstream is

[PATCH v3 08/21] fpga: add Intel FPGA DFL PCIe device

2017-11-26 Thread Wu Hao
From: Zhang Yi The Intel FPGA device appears as a PCIe device on the system. This patch implements the basic framework of the driver for Intel PCIe device which is located between CPU and Accelerated Function Units (AFUs), and has the Device Feature List (DFL) implemented in its MMIO space. Sign

Re: [PATCH] perf/core: Enable the bp only if the .disable field is 0.

2017-11-26 Thread Milind Chabbi
On Sun, Nov 26, 2017 at 10:43 PM, Milind Chabbi wrote: > Signed-off-by: Milind Chabbi > --- > kernel/events/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 35747a58ffb4..1b8eae85e9de 100644 > --- a/kernel/event

[PATCH] rtc: add support for maxim dallas ds1682

2017-11-26 Thread venkat . prashanth2498
From: Venkat Prashanth B U Add supporting driver for Dallas Semiconductor DS1682 2 wire total elapsed time recorder. Signed-off-by: Venkat Prashanth B U --- drivers/rtc/rtc-ds1682.c | 284 +++ 1 file changed, 284 insertions(+) diff --git a/drivers/r

[PATCH] perf/core: Enable the bp only if the .disable field is 0.

2017-11-26 Thread Milind Chabbi
Signed-off-by: Milind Chabbi --- kernel/events/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 35747a58ffb4..1b8eae85e9de 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2659,7 +2659,8 @@ static int pe

Re: hugetlb page migration vs. overcommit

2017-11-26 Thread Naoya Horiguchi
On 11/23/2017 04:11 AM, Mike Kravetz wrote: > On 11/22/2017 07:28 AM, Michal Hocko wrote: >> Hi, >> is there any reason why we enforce the overcommit limit during hugetlb >> pages migration? It's in alloc_huge_page_node->__alloc_buddy_huge_page >> path. I am wondering whether this is really an inte

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-26 Thread Julia Lawall
On Mon, 27 Nov 2017, Julia Lawall wrote: > > > On Sun, 26 Nov 2017, Joe Perches wrote: > > > On Sun, 2017-11-26 at 19:17 +0100, Julia Lawall wrote: > > > I just assume that a printk that has no KERN_ is adding a > > > newline, which is my understanding of Joe's comment. > > > > More precisely: >

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-26 Thread Logan Gunthorpe
On 26/11/17 11:34 PM, Julia Lawall wrote: > It would probably be better not to mention the KERN_CONT possibility at > all. Oh? I don't disagree... but what are we supposed to do in these cases? The way v2 of my patch works it just says that there is a missing new line. But Joe calls that a false

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-26 Thread Julia Lawall
On Sun, 26 Nov 2017, Joe Perches wrote: > On Sun, 2017-11-26 at 19:17 +0100, Julia Lawall wrote: > > I just assume that a printk that has no KERN_ is adding a > > newline, which is my understanding of Joe's comment. > > More precisely: > > Any printk without an initial KERN_CONT prepends a newli

Re: [PATCH] mm/vmscan: make do_shrink_slab more robust.

2017-11-26 Thread Minchan Kim
On Mon, Nov 27, 2017 at 02:27:20PM +0800, jiang.bi...@zte.com.cn wrote: > > On Mon, Nov 27, 2017 at 12:46:27PM +0800, jiang.bi...@zte.com.cn wrote:> > > > On Mon, Nov 27, 2017 at 09:37:30AM +0800, Jiang Biao wrote:> > > > > > > This patch make do_shrink_slab more robust when > > > > > shrinker->co

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-26 Thread Julia Lawall
On Sun, 26 Nov 2017, Logan Gunthorpe wrote: > > > On 26/11/17 11:11 PM, Julia Lawall wrote: > > I don't have a different warning if the string ends in a space. I have a > > different warning when one possible control-flow path is fine and another > > control-flow path is not. The space thing r

Re: [PATCH] mm: Do not stall register_shrinker

2017-11-26 Thread Minchan Kim
On Mon, Nov 27, 2017 at 11:16:46AM +0530, Anshuman Khandual wrote: > On 11/24/2017 05:34 AM, Minchan Kim wrote: > > Shakeel Butt reported, he have observed in production system that > > the job loader gets stuck for 10s of seconds while doing mount > > operation. It turns out that it was stuck in r

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-26 Thread Logan Gunthorpe
On 26/11/17 11:11 PM, Julia Lawall wrote: > I don't have a different warning if the string ends in a space. I have a > different warning when one possible control-flow path is fine and another > control-flow path is not. The space thing relates to guessing whether > some other printing API func

Re: [PATCH 1/4] 44x/fsp2: add fsp2 headers

2017-11-26 Thread Alistair Popple
Hi Ivan, Does it make sense to have these in a seperate include file? From what I could see these defines were only used in fsp2.c so you could just put them directly in there. - Alistair On Thursday, 2 November 2017 4:07:03 PM AEDT Ivan Mikhaylov wrote: > * add cmu, plbX, l2 register definition

Re: [PATCH 4/4] 44x/fsp2: add irq error handlers

2017-11-26 Thread Alistair Popple
On Thursday, 2 November 2017 4:07:06 PM AEDT Ivan Mikhaylov wrote: > * add irq error handlers for cmu, plb, opb, mcue, conf > with debug information output in case of problem. > > Signed-off-by: Ivan Mikhaylov > --- > arch/powerpc/platforms/44x/fsp2.c | 204 >

Re: [PATCH 3/4] 44x/fsp2: tvsense workaround for dd1

2017-11-26 Thread Alistair Popple
Again, I'm not familiar with this specific hardware so can only provide general comments. On Thursday, 2 November 2017 4:07:05 PM AEDT Ivan Mikhaylov wrote: > * tvsense(temperature and voltage sensors) may provide > erratic sense values which may result in parity errors > on CMU. It would be

Re: [PATCH 2/4] 44x/fsp2: l2 setup with error clear

2017-11-26 Thread Alistair Popple
I'm not familiar with the hardware setup going on here so I can't comment on it's correctness but the code looks ok. A commit message describing why this particular setup is needed would be nice though. Reviewed-by: Alistair Popple On Thursday, 2 November 2017 4:07:04 PM AEDT Ivan Mikhaylov wrot

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

2017-11-26 Thread Anshuman Khandual
On 11/25/2017 12:50 PM, JianKang Chen wrote: > From: Jiankang Chen > > __get_free_pages will return an 64bit address in 64bit System > like arm64 or x86_64. And this comment really confuse new bigenner of > mm. Normally its not 64 bit virtual address though CPU architecture supports 64 bits. But

[PATCH V2 2/7] PCI: handle FLR failure and allow other reset types

2017-11-26 Thread Sinan Kaya
pci_flr_wait() and pci_af_flr() functions assume graceful return even though the device is inaccessible under error conditions. Return -ENOTTY in error cases so that __pci_reset_function_locked() can try other reset types if AF_FLR/FLR reset fails. Signed-off-by: Sinan Kaya --- drivers/pci/pci.

[PATCH V2 1/7] PCI: protect restore with device lock to be consistent

2017-11-26 Thread Sinan Kaya
Commit b014e96d1abb ("PCI: Protect pci_error_handlers->reset_notify() usage with device_lock()") added protection around pci_dev_restore() function so that device specific remove callback does not cause a race condition against hotplug. pci_dev_lock() usage has been forgotten in two different plac

[PATCH V2 4/7] PCI: wait device ready after pci_pm_reset()

2017-11-26 Thread Sinan Kaya
Rev 3.1 Sec 2.3.1 Request Handling Rules says a device can issue CRS following a D3hot->D0 transition. Add pci_dev_wait() call to see if device is available before returning. Signed-off-by: Sinan Kaya --- drivers/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH V2 5/7] PCI: add a return type for pci_reset_bridge_secondary_bus()

2017-11-26 Thread Sinan Kaya
Getting ready to return an error from pci_reset_bridge_secondary_bus() when device is unreachable. Signed-off-by: Sinan Kaya --- drivers/pci/pci.c | 4 +++- include/linux/pci.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 87

[PATCH V2 7/7] PCI: make reset poll time adjustable

2017-11-26 Thread Sinan Kaya
Introduce pci=resetpolltime= argument to override 60 seconds poll time in units of milliseconds. Signed-off-by: Sinan Kaya --- Documentation/admin-guide/kernel-parameters.txt | 2 ++ drivers/pci/pci.c | 13 - 2 files changed, 10 insertions(+), 5 deletio

[PATCH V2 6/7] PCI: add device wait after slot and bus reset

2017-11-26 Thread Sinan Kaya
Rev 3.1 Sec 2.3.1 Request Handling Rules indicates that a device can issue CRS following secondary bus reset. Handle device presence gracefully. Signed-off-by: Sinan Kaya --- drivers/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci

[PATCH V2 3/7] PCI: make pci_flr_wait() generic and rename to pci_dev_wait()

2017-11-26 Thread Sinan Kaya
Rev 3.1 Sec 2.3.1 Request Handling Rules: Valid reset conditions after which a device is permitted to return CRS are: * Cold, Warm, and Hot Resets, * FLR * A reset initiated in response to a D3hot to D0 uninitialized Try to reuse FLR implementation towards other reset types. Signed-off-by: Sinan

Re: KASAN: use-after-free Read in handle_userfault

2017-11-26 Thread Eric Biggers
+Cc aarca...@redhat.com, xe...@parallels.com, linux...@kvack.org On Fri, Oct 27, 2017 at 11:46:13AM +0200, Dmitry Vyukov wrote: > On Fri, Oct 27, 2017 at 11:44 AM, syzbot > > wrote: > > Hello, > > > > syzkaller hit the following crash on > > a31cc455c512f3f1dd5f79cac8e29a7c8a617af8 > > git://git.

[PATCH v2 03/10] perf util: Extend rbtree to support shadow stats

2017-11-26 Thread Jin Yao
Previously the rbtree was used to link generic metrics. This patches adds new ctx/type/stat into rbtree keys because we will use this rbtree to maintain shadow metrics to replace original a couple of static arrays for supporting per-thread shadow stats. Signed-off-by: Jin Yao --- tools/perf/uti

[PATCH v2 04/10] perf util: Add rbtree node_delete ops

2017-11-26 Thread Jin Yao
In current stat-shadow.c, the rbtree deleting is ignored. The patch reconstructs the code of rblist init/free, and adds the implementation to node_delete method of rblist. Signed-off-by: Jin Yao --- tools/perf/util/stat-shadow.c | 33 + tools/perf/util/stat.h

[PATCH v2 00/10] perf stat: Enable '--per-thread' on all threads

2017-11-26 Thread Jin Yao
v2: --- Update according to Jiri's comments. The major modifications are: 1. Remove unnecessary memset for runtime_stat and walltime_nsecs_stats. 2. Remove init_saved_rblist/free_saved_rblist and move the codes to runtime_stat__init/runtime_stat__free. 3. Change function name from perf_sta

[PATCH v2 08/10] perf util: Reuse thread_map__new_by_uid to enumerate threads from /proc

2017-11-26 Thread Jin Yao
Perf already has a function thread_map__new_by_uid() which can enumerate all threads from /proc by uid. This patch creates a static function enumerate_threads() which reuses the common code in thread_map__new_by_uid() to enumerate threads from /proc. The enumerate_threads() is shared by thread_ma

[PATCH v2 10/10] perf stat: Resort '--per-thread' result

2017-11-26 Thread Jin Yao
There are many threads reported if we enable '--per-thread' globally. 1. Most of the threads are not counted or counting value 0. This patch removes these threads. 2. We also resort the threads in display according to the counting value. It's useful for user to see the hottest threads easily. Fo

[PATCH v2 06/10] perf util: Remove a set of shadow stats static variables

2017-11-26 Thread Jin Yao
In previous patches, we have reconstructed the code and let it not access the static variables directly. This patch removes these static variables. Signed-off-by: Jin Yao --- tools/perf/util/stat-shadow.c | 64 ++- tools/perf/util/stat.h| 1 + 2

[PATCH v2 07/10] perf stat: Allocate shadow stats buffer for threads

2017-11-26 Thread Jin Yao
After perf_evlist__create_maps() being executed, we can get all threads from /proc. And via thread_map__nr(), we can also get the number of threads. With the number of threads, the patch allocates a buffer which will record the shadow stats for these threads. The buffer pointer is saved in stat_c

[PATCH v2 09/10] perf stat: Remove --per-thread pid/tid limitation

2017-11-26 Thread Jin Yao
Currently, if we execute 'perf stat --per-thread' without specifying pid/tid, perf will return error. root@skl:/tmp# perf stat --per-thread The --per-thread option is only available when monitoring via -p -t options. -p, --pidstat events on existing process id -t, --tidstat

[PATCH v2 01/10] perf util: Create rblist__reset() function

2017-11-26 Thread Jin Yao
Currently we have a rblist__delete() which is used to delete a rblist. While rblist__delete() will free the pointer of rblist at the end. It's inconvenience for user to delete a rblist which is not allocated by something like malloc(). For example, the rblist is defined in a data structure. This

[PATCH v2 02/10] perf util: Define a structure for runtime shadow metrics stats

2017-11-26 Thread Jin Yao
Perf has a set of static variables to record the runtime shadow metrics stats. While if we want to record the runtime shadow stats for per-thread, it will be the limitation. This patch creates a structure and the next patches will use this structure to update the runtime shadow stats for per-threa

[PATCH v2 05/10] perf util: Update and print per-thread shadow stats

2017-11-26 Thread Jin Yao
The functions perf_stat__update_shadow_stats() and perf_stat__print_shadow_statss() are called to update and print the shadow stats on a set of static variables. But the static variables are the limitations to support per-thread shadow stats. This patch lets the perf_stat__update_shadow_stats() s

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-26 Thread Julia Lawall
On Sun, 26 Nov 2017, Logan Gunthorpe wrote: > > > On 26/11/17 03:29 PM, Joe Perches wrote: > > This proposal has a very high false positive rate. > > The only actual false positive you've pointed out is the one that is > just incorrect in the wrong way (the author should have used a KERN_CONT >

Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

2017-11-26 Thread Julia Lawall
On Sun, 26 Nov 2017, Joe Perches wrote: > On Sun, 2017-11-26 at 23:44 +0100, Julia Lawall wrote: > > My semantic patch and results are below. The semantic patch has some > > features that may or may not be desired: > > > > 1. It goes beyond printk, pr_xxx, dev_xxx, and netdev_xxx, by finding >

Re: [PATCH -tip 0/7] tools/perf: Update rbtree implementation and optimize users

2017-11-26 Thread Andi Kleen
> Applies on today's -tip tree. Please consider for v4.16. No numbers on the improvements? -Andi

Re: [2/4] crypto: af_alg - Allow arbitrarily long algorithm names" email-alg_bind.txt

2017-11-26 Thread Herbert Xu
On Wed, Nov 08, 2017 at 05:51:36PM +0100, Lukasz Odzioba wrote: > Hi, > I found this patch by accident and it got my attention. > I think we can't make this name arbitrarily long because bind syscall checks > addrlen before feeding protocol with it. > Current limit on my machine is 128 bytes and I

Re: [PATCH v7 06/13] slimbus: Add messaging APIs to slimbus framework

2017-11-26 Thread Vinod Koul
On Mon, Nov 20, 2017 at 06:47:52AM +, Srinivas Kandagatla wrote: > >>+ * -ENOTCONN: If the transmitted message was not ACKed by destination > >>+ * device. > > > >I am preferring ENODATA in SDW for this case, as Slaves didnt respond or > >ACK. > Isn't that a timeout error then. > > ENODATA is

Re: [PATCH v7 04/13] slimbus: core: Add slim controllers support

2017-11-26 Thread Vinod Koul
On Mon, Nov 20, 2017 at 06:47:58AM +, Srinivas Kandagatla wrote: > >>>thanks for the comments. > >>> > >>> > >>>On 16/11/17 16:42, Vinod Koul wrote: > On Wed, Nov 15, 2017 at 02:10:34PM +,srinivas.kandaga...@linaro.org > wrote: > > >+static void slim_dev_release(struct de

Re: [PATCH] mm: Do not stall register_shrinker

2017-11-26 Thread Anshuman Khandual
On 11/24/2017 05:34 AM, Minchan Kim wrote: > Shakeel Butt reported, he have observed in production system that > the job loader gets stuck for 10s of seconds while doing mount > operation. It turns out that it was stuck in register_shrinker() > and some unrelated job was under memory pressure and s

Re: x86/umip: Enable User-Mode Instruction Prevention at runtime

2017-11-26 Thread Ingo Molnar
* Dave Jones wrote: > On Mon, Nov 13, 2017 at 11:44:02PM +, Linux Kernel wrote: > > Web: > https://git.kernel.org/torvalds/c/aa35f896979d9610bb11df485cf7bb6ca241febb > > Commit: aa35f896979d9610bb11df485cf7bb6ca241febb > > Parent: c6a960bbf6a36572a06bde866d94a7338c7f256a >

[PATCH] powerpc/powernv : Add support to enable sensor groups

2017-11-26 Thread Shilpasri G Bhat
Adds support to enable/disable a sensor group. This can be used to select the sensor groups that needs to be copied to main memory by OCC. Sensor groups like power, temperature, current, voltage, frequency, utilization can be enabled/disabled at runtime. Signed-off-by: Shilpasri G Bhat --- The sk

RE: [PATCH] scsi: bfa: use setup_timer instead of init_timer

2017-11-26 Thread Gurumurthy, Anil
-Original Message- From: Colin King [mailto:colin.k...@canonical.com] Sent: 24 November 2017 19:14 To: Gurumurthy, Anil ; Kalluru, Sudarsana ; James E . J . Bottomley ; Martin K . Petersen ; linux-s...@vger.kernel.org Cc: kernel-janit...@vger.kernel.org; linux-kernel@vger.kernel.org Su

Re: Xen PV breakage after IRQ stack code refactoring

2017-11-26 Thread Juergen Gross
On 27/11/17 05:03, Andy Lutomirski wrote: > On Sun, Nov 26, 2017 at 9:10 AM, Boris Ostrovsky > wrote: >> Andy, >> >> (Can't find the original patch in my mailbox) >> >> This hunk from 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make >> them NMI-safe") >> >> >> diff --git a/arch/x86/entry/

  1   2   3   4   >