Re: [PATCH/RFC] Re: 'perf test BPF' failing, libbpf regression wrt "basic API for BPF obj name"

2017-11-30 Thread Martin KaFai Lau
On Thu, Nov 30, 2017 at 04:00:42PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 30, 2017 at 10:28:08AM -0800, Martin KaFai Lau escreveu: > > On Thu, Nov 30, 2017 at 01:53:58PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Thu, Nov 30, 2017 at 12:01:10AM -0300, Arnaldo Carvalho de Melo >

Re: [PATCH] NTB: Fix UB/bug in ntb_mw_get_align()

2017-11-30 Thread Logan Gunthorpe
On 30/11/17 02:39 PM, Serge Semin wrote: Simple (1 << pidx) operation causes undefined behaviour when pidx >= 32. It must be casted to u64 to match the actual return value of ntb_link_is_up() method, so to have all the possible peer indexes covered and to get rid of undefined behaviour. Additio

Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string

2017-11-30 Thread Sebastian Reichel
Hi, On Thu, Nov 30, 2017 at 07:24:30AM -0800, Tony Lindgren wrote: > * H. Nikolaus Schaller [171128 18:35]: > > Hi, > > > > > Am 28.11.2017 um 17:18 schrieb Tony Lindgren : > > > > > > * H. Nikolaus Schaller [171128 16:17]: > > >> Hi Tony, > > >> > > >>> Am 28.11.2017 um 17:04 schrieb Tony Li

Re: [PATCH] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology

2017-11-30 Thread Logan Gunthorpe
On 30/11/17 02:41 PM, Serge Semin wrote: Since Switchtec patch there has been a new topology added to the NTB API. It's called NTB_TOPO_SWITCH and dedicated for PCIe switch chips. Even though topo field isn't used within the IDT driver much, lets set it for the sake of unification. Signed-off-

[PATCH] usb: host: fotg210: Use dma_pool_zalloc

2017-11-30 Thread Vasyl Gomonovych
Replacing dma_pool_alloc and memset with a single call to dma_pool_zalloc Signed-off-by: Vasyl Gomonovych --- drivers/usb/host/fotg210-hcd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index 62fc955085

Re: [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace

2017-11-30 Thread Logan Gunthorpe
Hey, I took a cursory look at this series and it largely looks good to me. Nice work. If I have time in the next couple days I'll do a more thorough review. However, does the series not depend on changes to ntb_tool? It would have been good to include a cover letter describing the intention/p

Re: [PATCH] leds: pm8058: Make ledtype pointer sized type

2017-11-30 Thread Jacek Anaszewski
On 11/30/2017 09:31 AM, Lee Jones wrote: > On Thu, 30 Nov 2017, Lee Jones wrote: > >> On Wed, 29 Nov 2017, Bjorn Andersson wrote: >> >>> The pointer returned by of_device_get_match_data() doesn't have the same >>> size as u32 on 64-bit architectures, causing issues when compile testing >>> the dri

Re: [PATCH] leds: pm8058: Make ledtype pointer sized type

2017-11-30 Thread Jacek Anaszewski
On 11/30/2017 10:40 AM, Pavel Machek wrote: > On Wed 2017-11-29 19:05:43, Bjorn Andersson wrote: >> The pointer returned by of_device_get_match_data() doesn't have the same >> size as u32 on 64-bit architectures, causing issues when compile testing >> the driver on such platform. Make ledtype unsig

Re: [PATCH/RFC] Re: 'perf test BPF' failing, libbpf regression wrt "basic API for BPF obj name"

2017-11-30 Thread Alexei Starovoitov
On 11/30/17 11:00 AM, Arnaldo Carvalho de Melo wrote: Instead of sinking all future bpf_attr's backward compatibility requirements to sys_bpf, I would push it up to its own BPF_* command helper which has a better sense of its bpf_attr, i.e. push it up to bpf_create_map_node() and bpf_load_progra

Re: [PATCH v4 1/2] livepatch: send a fake signal to all blocking tasks

2017-11-30 Thread Jiri Kosina
On Wed, 15 Nov 2017, Miroslav Benes wrote: > Live patching consistency model is of LEAVE_PATCHED_SET and > SWITCH_THREAD. This means that all tasks in the system have to be marked > one by one as safe to call a new patched function. Safe means when a > task is not (sleeping) in a set of patched fu

Re: [PATCH 00/11] fs: use freeze_fs on suspend/hibernate

2017-11-30 Thread Pavel Machek
Hi! > Proposed solution: > > Instead of fixing such semantics and trying to get all filesystems to do it > right, we can easily do away with all freezing calls if the filesystem > implements a proper freeze_fs() callback. The following 9 filesystems have > freeze_fs() implemented as such we can l

Re: [PATCH 15/24] x86/mm: Allow flushing for future ASID switches

2017-11-30 Thread Andy Lutomirski
On Thu, Nov 30, 2017 at 12:01 PM, Peter Zijlstra wrote: > On Thu, Nov 30, 2017 at 10:48:56AM -0800, Andy Lutomirski wrote: >> Should it be >> tlb_flush_shared_nonglobals_if_kernel_and_user_pagetables_are_separate()? > > Its effectively invpcid_flush_all_other() or something like that. Of > course

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread David Daney
On 11/30/2017 01:36 PM, James Hogan wrote: On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote: From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O devic

Re: [PATCH v18 01/10] idr: add #include

2017-11-30 Thread Andrew Morton
On Wed, 29 Nov 2017 16:58:17 -0800 Matthew Wilcox wrote: > On Wed, Nov 29, 2017 at 09:55:17PM +0800, Wei Wang wrote: > > The was removed from radix-tree.h by the following commit: > > f5bba9d11a256ad2a1c2f8e7fc6aabe6416b7890. > > > > Since that commit, tools/testing/radix-tree/ couldn't pass co

[GIT PULL] ACPI fixes for v4.15-rc2

2017-11-30 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-4.15-rc2 with top-most commit b6c70268723bc89743b87d17f6889d72497a Merge branch 'acpi-ec' into acpi on top of commit 190b10367b0d311f68dc71e40b254fd4427affc2 Merge tag 'acpi-fix

[GIT PULL] Power management fixes for v4.15-rc2

2017-11-30 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-4.15-rc2 with top-most commit 6981037442b05b192504fbc3c165cb240e01f6e2 Merge branch 'pm-tools' on top of commit e75080f185c103a638c66d7b65c673769a57cb87 Merge tag 'pm-fixes-4.15-rc1'

[PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace

2017-11-30 Thread Serge Semin
If some of variables like LOC/REM or LOCAL_*/REMOTE_* got whitespaces, the script may fail with syntax error. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh | 62 - 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/tools/testi

[PATCH 03/08] NTB: ntb_test: Update ntb_tool link tests

2017-11-30 Thread Serge Semin
Link Up and Down methods are used to change NTB link settings on local side only for multi-port devices. Link is considered up only if both sides local and peer set it up. Intel/AMD hardware acts a bit different by assigning the Primary and Secondary roles, so Primary device only is able to change

[PATCH v2 2/2] iio: hx711: fix bug in reset functionality

2017-11-30 Thread Andreas Klinger
return value in hx711_reset() should indicate status of dout otherwise the calling function is reporting an error als false positive wait up to 1 second until the device is in normal state by changing the channel on every trigger event it turned out that the former 100 ms are not enough for waitin

[PATCH 05/08] NTB: ntb_test: Update ntb_tool Scratchpad tests

2017-11-30 Thread Serge Semin
Scratchpad NTB API has changed so has the ntb_tool driver. Outbound Scratchpad DebugFS files have been moved to peer specific directories. Each scratchpad is now available via separate file. The test code has been accordingly altered. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/nt

[PATCH 07/08] NTB: ntb_test: Update ntb_tool MW tests

2017-11-30 Thread Serge Semin
There are devices (like IDT PCIe switches), which outbound MWs xlat address is setup on peer side. In this case local side is supposed to allocate a memory buffer and somehow deliver the xlat DMA address to peer so one could set the outbound MW up. The MW test is altered so to support both previous

[PATCH v2 1/2] iio: hx711: add triggered buffer support

2017-11-30 Thread Andreas Klinger
Add buffer to device data struct and add trigger function Data format is quite simple: voltage - channel 0 32 Bit voltage - channel 1 32 Bit timestamp 64 Bit Using both channels at the same time is working quite slow because of changing the channel which needs a

[PATCH 08/08] NTB: ntb_test: Update ntb_perf tests

2017-11-30 Thread Serge Semin
ntb_perf driver has been also updated so to have the multi-port interface support. User now must specify what peer port is going to be used to perform the test. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions

[PATCH 06/08] NTB: ntb_test: Add ntb_tool Message tests

2017-11-30 Thread Serge Semin
Messages NTB API is now available. ntb_tool driver has been altered to perform messages send and receive operation. The test of messages read/write to/from peer device has been added to the script. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh | 37 ++

[PATCH 04/08] NTB: ntb_test: Update ntb_tool DB tests

2017-11-30 Thread Serge Semin
DB interface of ntb_tool driver hasn't been changed much, but db_valid_mask DebugFS file has still been added. In this case it's much better to test all valid DB bits instead of using the predefined mask, which may be incorrect in general. Signed-off-by: Serge Semin --- tools/testing/selftests/n

[PATCH v2 0/2] iio: hx711: add buffered trigger support

2017-11-30 Thread Andreas Klinger
changes in v2: - in Kconfig it's needed to select IIO_BUFFER and IIO_TRIGGERED_BUFFER to compile cleanly with buffered triggers This small patch series adds: - support for buffered triggers - fixes a bug in the reset functionality Andreas Klinger (2): iio: hx711: add triggered buffer support

[PATCH 02/08] NTB: ntb_test: Add ntb_tool port tests

2017-11-30 Thread Serge Semin
Multi-port interface is now available in ntb_tool driver. According to the new NTB API, there might be more than two devices connected over NTB. It means each device can have multiple freely enumerated ports. Each port got index assigned by NTB hardware driver. This test is performed to determine t

[PATCH] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology

2017-11-30 Thread Serge Semin
Since Switchtec patch there has been a new topology added to the NTB API. It's called NTB_TOPO_SWITCH and dedicated for PCIe switch chips. Even though topo field isn't used within the IDT driver much, lets set it for the sake of unification. Signed-off-by: Serge Semin Acked-by: Serge Semin ---

Re: [PATCH v2 16/23] test_firmware: enable custom fallback testing on limited kernel configs

2017-11-30 Thread Shuah Khan
On 11/30/2017 01:31 PM, Luis R. Rodriguez wrote: > On Wed, Nov 29, 2017 at 11:22:35AM +0100, Greg KH wrote: >> On Mon, Nov 20, 2017 at 10:24:02AM -0800, Luis R. Rodriguez wrote: >>> When a kernel is not built with: >>> >>> CONFIG_HAS_FW_LOADER_USER_HELPER_FALLBACK=y >>> >>> We don't currently enabl

Re: [PATCH v5 2/2] leds: lm3692x: Introduce LM3692x dual string driver

2017-11-30 Thread Jacek Anaszewski
Dan, Thanks for addressing my remarks. LED class device name composition stills needs some tweaking, though. Please refer below to the piece of code in question. On 11/30/2017 08:22 PM, Dan Murphy wrote: > Introducing the LM3692x Dual-String white LED driver. > > Data sheet is located > http://

[PATCH] staging: pi433: pi433_if.c Fix SET_CHECKED style issues

2017-11-30 Thread Nguyen Phan Quang Minh
Fix checkpatch warning and add result holder variable to reduce overhead since the macro is called on functions. Signed-off-by: Nguyen Phan Quang Minh --- Since SET_CHECKED has a return statement, I'm very tempted to straight up remove it and do the checking inline. But the macro is used a lot (~

Re: [PATCH] mtd: nand: remove unnecessary extern from driver headers

2017-11-30 Thread Boris Brezillon
On Thu, 23 Nov 2017 22:18:43 +0900 Masahiro Yamada wrote: > 'extern' is not necessary for function declarations. > > scripts/checkpatch.pl with --strict option reports the following: > > CHECK: extern prototypes should be avoided in .h files Applied. Thanks, Boris > > Signed-off-by: Masa

[PATCH] NTB: Set dma mask and dma coherent mask to NTB devices

2017-11-30 Thread Serge Semin
The dma_mask and dma_coherent_mask fields of the NTB struct device weren't initialized in hardware drivers. In fact it should be done instead of PCIe interface usage, since NTB clients are supposed to use NTB API and left unaware of real hardware implementation. In addition to that ntb_device_regis

[PATCH] NTB: Fix UB/bug in ntb_mw_get_align()

2017-11-30 Thread Serge Semin
Simple (1 << pidx) operation causes undefined behaviour when pidx >= 32. It must be casted to u64 to match the actual return value of ntb_link_is_up() method, so to have all the possible peer indexes covered and to get rid of undefined behaviour. Additionally there are special macros in "linux/bito

Re: [PATCH] mtd: nand: denali: rename misleading dma_buf to tmp_buf

2017-11-30 Thread Boris Brezillon
On Thu, 23 Nov 2017 22:32:28 +0900 Masahiro Yamada wrote: > The "dma_buf" is not used for a DMA bounce buffer, but for arranging > the transferred data for the syndrome page layout. In fact, it is > used in the PIO mode as well, so "dma_buf" is a misleading name. > Rename it to "tmp_buf". Appli

Re: waitqueue lockdep annotation

2017-11-30 Thread Jason Baron
On 11/30/2017 03:50 PM, Andrew Morton wrote: > On Thu, 30 Nov 2017 06:20:35 -0800 Christoph Hellwig wrote: > >> Hi all, >> >> this series adds a strategic lockdep_assert_held to __wake_up_common >> to ensure callers really do hold the wait_queue_head lock when calling >> the unlocked wake_up va

[PATCH v2] NTB: ntb_perf: Add full multi-port NTB API support

2017-11-30 Thread Serge Semin
NTB API has been updated to support multi-port devices like IDT 89HPESx series or Microsemi Switchtec. Message registers functionality has also been added to new API. In order to keep the new hardware and corresponding capabilities well tested, NTB performance driver is accordingly altered. Signed

Re: [PATCH v2 00/10] trace-cmd: Refactoring trace_record()

2017-11-30 Thread Steven Rostedt
On Thu, 30 Nov 2017 15:19:47 +0200 "Vladislav Valtchev (VMware)" wrote: > The following series of patches is a refactoring of trace_record() trying to > reduce as much as possible its complexity but, at the same time, without > making > risky changes. All the patches are relatively small and pot

Re: [PATCH RFC 2/2] arm64: allwinner: a64: Add Brava Keller initial support

2017-11-30 Thread Philippe Ombredanne
Jagan, On Thu, Nov 30, 2017 at 7:42 PM, Jagan Teki wrote: [] > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > new file mode 100644 > index 000..f5303a3 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinne

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread James Hogan
On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote: > From: Carlos Munoz > > LMTDMA/LMTST operations move data between cores and I/O devices: > > * LMTST operations can send an address and a variable length > (up to 128 bytes) of data to an I/O device. > * LMTDMA operations can send a

[PATCH v2] NTB: ntb_tool: Add full multi-port NTB API support

2017-11-30 Thread Serge Semin
NTB API has been updated to support multi-port devices like IDT 89HPESx series or Microsemi Switchtec. Message registers functionality has also been added to new API. In order to keep the new hardware and corresponding capabilities well tested, NTB tool driver is accordingly altered. Signed-off-by

Re: [PATCH AUTOSEL for 4.9 04/52] x86/selftests: Add clobbers for int80 on x86_64

2017-11-30 Thread alexander . levin
On Wed, Nov 29, 2017 at 05:42:25PM +, Dmitry Safonov wrote: >Hi Sasha, > >I would object including this to stable tree: >1. It's selftest fixup >2. I have never saw selftests failing because of it (but it's possible) >I saw this in CRIU (Checkpoint Restore In Userspace) project >trigger

Re: [PATCH] mtd: nand: denali_pci: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE

2017-11-30 Thread Boris Brezillon
On Mon, 20 Nov 2017 12:57:13 -0800 Jesse Chan wrote: > This change resolves a new compile-time warning > when built as a loadable module: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/denali_pci.o > see include/linux/module.h for more information > > This adds the license a

[PATCH v2] NTB: ntb_pp: Add full multi-port NTB API support

2017-11-30 Thread Serge Semin
NTB API has been updated to support multi-port devices like IDT 89HPESx series or Microsemi Switchtec. Message registers functionality has also been added to new API. In order to keep the new hardware and corresponding capabilities well tested, NTB pingpong driver is accordingly altered. Signed-of

Re: [PATCH AUTOSEL for 3.18 16/16] EDAC, i5000, i5400: Fix use of MTR_DRAM_WIDTH macro

2017-11-30 Thread alexander . levin
On Wed, Nov 29, 2017 at 08:34:30PM -0500, Jérémy Lefaure wrote: >On Wed, 29 Nov 2017 17:22:22 + >alexander.le...@verizon.com wrote: > >> From: Jérémy Lefaure >> >> [ Upstream commit e61555c29c28a4a3b6ba6207f4a0883ee236004d ] >> >> The MTR_DRAM_WIDTH macro returns the data width. It is sometime

[PATCH v2] NTB: Rename NTB messaging API methods

2017-11-30 Thread Serge Semin
There is a common methods signature form used over all the NTB API like functions naming scheme, arguments names and order, etc. Recently added NTB messaging API IO callbacks were named a bit different so should be renamed to be in compliance with the rest of the API. Signed-off-by: Serge Semin -

[PATCH] net: ethernet: ixp4xx_eth: Use dma_pool_zalloc

2017-11-30 Thread Vasyl Gomonovych
Replacing dma_pool_alloc and memset with a single call to dma_pool_zalloc Signed-off-by: Vasyl Gomonovych --- drivers/net/ethernet/xscale/ixp4xx_eth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale

Re: [PATCH] block, bfq: remove batches of confusing ifdefs

2017-11-30 Thread Jens Axboe
On 11/28/2017 02:37 AM, Paolo Valente wrote: > Commit a33801e8b473 ("block, bfq: move debug blkio stats behind > CONFIG_DEBUG_BLK_CGROUP") introduced two batches of confusing ifdefs: > one reported in [1], plus a similar one in another function. This > commit removes both batches, in the way sugges

Re: [PATCH] hwmon: (max31785) Add OF device ID table

2017-11-30 Thread Guenter Roeck
On Thu, Nov 30, 2017 at 07:12:57PM +0100, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID a

Re: [PATCH v2 2/2] ARM: dts: at91: disable the nxp,se97b SMBUS timeout on the TSE-850

2017-11-30 Thread Guenter Roeck
On Thu, Nov 30, 2017 at 07:46:09PM +0100, Peter Rosin wrote: > On 2017-11-30 18:26, Alexandre Belloni wrote: > > On 30/11/2017 at 09:16:38 -0800, Guenter Roeck wrote: > >> On Wed, Nov 29, 2017 at 09:56:29PM +0100, Alexandre Belloni wrote: > >>> On 29/11/2017 at 12:53:11 -0800, Guenter Roeck wrote:

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

2017-11-30 Thread Andrew Morton
On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko wrote: > > mm... So we have a caller which hopes to be getting highmem pages but > > isn't. Caller then proceeds to pointlessly kmap the page and wonders > > why it isn't getting as much memory as it would like on 32-bit systems, > > etc. > > How

Re: [PATCH] mtd: nand: gpmi: replace _manual_ swap with swap macro

2017-11-30 Thread Boris Brezillon
On Fri, 3 Nov 2017 15:31:47 -0500 "Gustavo A. R. Silva" wrote: > Make use of the swap macro and remove unnecessary variables swap. > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. Applied. Thanks, Boris > > Signed-off-by: Gustavo A.

Re: [RFC] Rebasing the IDR

2017-11-30 Thread Matthew Wilcox
On Thu, Nov 30, 2017 at 08:56:43PM +0100, Daniel Vetter wrote: > Adding dri-devel, I think a pile of those are in drm. Yeah, quite a lot! This is a good thing; means you didn't invent your own custom ID allocator. > On Thu, Nov 30, 2017 at 6:36 PM, Matthew Wilcox wrote: > > About 40 of the appr

Re: [PATCH 00/11] fs: use freeze_fs on suspend/hibernate

2017-11-30 Thread Dave Chinner
On Thu, Nov 30, 2017 at 08:53:52PM +, Bart Van Assche wrote: > On Thu, 2017-11-30 at 20:42 +0100, Luis R. Rodriguez wrote: > > On Thu, Nov 30, 2017 at 05:01:13PM +, Bart Van Assche wrote: > > > The md resync > > > thread must be stopped before a system is frozen. Today the md driver uses >

Re: Creating cyclecounter and lock member in timecounter structure [ Was Re: [RFC 1/4] drm/i915/perf: Add support to correlate GPU timestamp with system time]

2017-11-30 Thread Saeed Mahameed
On Mon, Nov 27, 2017 at 2:05 AM, Sagar Arun Kamble wrote: > > > On 11/24/2017 7:01 PM, Thomas Gleixner wrote: >> >> On Fri, 24 Nov 2017, Sagar Arun Kamble wrote: >>> >>> On 11/24/2017 12:29 AM, Thomas Gleixner wrote: On Thu, 23 Nov 2017, Sagar Arun Kamble wrote: > > We needed inp

[PATCH] NFS: allow name_to_handle_at() to work for Amazon EFS.

2017-11-30 Thread NeilBrown
Amazon EFS provides an NFSv4.1 filesystem which appears to use (close to) full length (128 byte) file handles. This causes the handle reported by name_to_handle_at() to exceed MAX_HANDLE_SZ, resulting in EOVERFLOW if 128 bytes were requested, or EINVAL if the size reported by the previous call

Re: [PATCH] list_lru: Prefetch neighboring list entries before acquiring lock

2017-11-30 Thread Waiman Long
On 11/30/2017 03:38 PM, Dave Chinner wrote: > On Thu, Nov 30, 2017 at 08:54:04AM -0500, Waiman Long wrote: >> >> For the record, I add one more list_empty() check at the beginning of >> list_lru_del() in the patch for 2 purpose: >> 1. it allows the code to bail out early. > Which is what I said was

[PATCH] KEYS: reject NULL restriction string when type is specified

2017-11-30 Thread Eric Biggers
From: Eric Biggers keyctl_restrict_keyring() allows through a NULL restriction when the "type" is non-NULL, which causes a NULL pointer dereference in asymmetric_lookup_restriction() when it calls strcmp() on the restriction string. But no key types actually use a "NULL restriction" to mean anyt

Re: [PATCH 00/11] fs: use freeze_fs on suspend/hibernate

2017-11-30 Thread Bart Van Assche
On Thu, 2017-11-30 at 20:42 +0100, Luis R. Rodriguez wrote: > On Thu, Nov 30, 2017 at 05:01:13PM +, Bart Van Assche wrote: > > The md resync > > thread must be stopped before a system is frozen. Today the md driver uses > > the kthread freezing mechanism for that purpose. Do you have a plan for

Re: waitqueue lockdep annotation

2017-11-30 Thread Andrew Morton
On Thu, 30 Nov 2017 06:20:35 -0800 Christoph Hellwig wrote: > Hi all, > > this series adds a strategic lockdep_assert_held to __wake_up_common > to ensure callers really do hold the wait_queue_head lock when calling > the unlocked wake_up variants. It turns out epoll did not do this > for a fai

Re: [PATCH v2 2/2] cros_ec: Move cros_ec_dev module to drivers/mfd

2017-11-30 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 8:15 AM, Thierry Escande wrote: > The cros_ec_dev module is responsible for registering the MFD devices > attached to the ChromeOS EC. This patch moves this module to drivers/mfd > so calls to mfd_add_devices() are not done from outside the MFD subtree > anymore. > > Signed

Re: [PATCH v2 1/2] cros_ec: Split cros_ec_devs module

2017-11-30 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 8:15 AM, Thierry Escande wrote: > This patch splits the cros_ec_devs module in two parts with a > cros_ec_dev module responsible for handling MFD devices registration and > a cros_ec_ctl module responsible for handling the various user-space > interfaces. > > For consistenc

Re: [PATCH] list_lru: Prefetch neighboring list entries before acquiring lock

2017-11-30 Thread Waiman Long
On 11/30/2017 03:47 PM, Andrew Morton wrote: > On Thu, 30 Nov 2017 08:54:04 -0500 Waiman Long wrote: > >>> And, from that perspective, the racy shortcut in the proposed patch >>> is wrong, too. Prefetch is fine, but in general shortcutting list >>> empty checks outside the internal lock isn't. >>

Re: [PATCH] list_lru: Prefetch neighboring list entries before acquiring lock

2017-11-30 Thread Andrew Morton
On Thu, 30 Nov 2017 08:54:04 -0500 Waiman Long wrote: > > And, from that perspective, the racy shortcut in the proposed patch > > is wrong, too. Prefetch is fine, but in general shortcutting list > > empty checks outside the internal lock isn't. > > For the record, I add one more list_empty() ch

Re: BUG: sleeping function called from invalid context at arch/x86/mm/fault.c:LINE

2017-11-30 Thread Eric Biggers
On Thu, Nov 30, 2017 at 11:55:00AM -0800, syzbot wrote: > Call Trace: > __dump_stack lib/dump_stack.c:17 [inline] > dump_stack+0x194/0x257 lib/dump_stack.c:53 > ___might_sleep+0x2b2/0x470 kernel/sched/core.c:6060 > __might_sleep+0x95/0x190 kernel/sched/core.c:6013 > __do_page_fault+0x350/0xc90

Re: [PATCH 2/2] kvm: x86: fix KVM_XEN_HVM_CONFIG ioctl

2017-11-30 Thread Kees Cook
On Thu, Oct 26, 2017 at 6:45 AM, Paolo Bonzini wrote: > This ioctl is obsolete (it was used by Xenner as far as I know) but > still let's not break it gratuitously... Its handler is copying > directly into struct kvm. Go through a bounce buffer instead, with > the added benefit that we can actua

Re: [PATCH v13 0/7] cgroup-aware OOM killer

2017-11-30 Thread Andrew Morton
On Thu, 30 Nov 2017 15:28:17 + Roman Gushchin wrote: > This patchset makes the OOM killer cgroup-aware. Thanks, I'll grab these. There has been controversy over this patchset, to say the least. I can't say that I followed it closely! Could those who still have reservations please summaris

Re: [PATCH] list_lru: Prefetch neighboring list entries before acquiring lock

2017-11-30 Thread Dave Chinner
On Thu, Nov 30, 2017 at 08:54:04AM -0500, Waiman Long wrote: > On 11/29/2017 07:42 PM, Dave Chinner wrote: > > On Wed, Nov 29, 2017 at 01:53:19PM -0800, Andrew Morton wrote: > >> On Wed, 29 Nov 2017 09:17:34 -0500 Waiman Long wrote: > >> > >>> The list_lru_del() function removes the given item fro

Re: [PATCH v2 19/23] firmware: add debug facility to emulate forcing sysfs fallback

2017-11-30 Thread Luis R. Rodriguez
On Wed, Nov 29, 2017 at 11:28:04AM +0100, Greg KH wrote: > On Mon, Nov 20, 2017 at 10:24:05AM -0800, Luis R. Rodriguez wrote: > > diff --git a/drivers/base/firmware_debug.c b/drivers/base/firmware_debug.c > > new file mode 100644 > > index ..f2817eb6f480 > > --- /dev/null > > +++ b/driv

Re: [PATCH] KVM: x86: inject exceptions produced by x86_decode_insn

2017-11-30 Thread Eduardo Habkost
On Wed, Nov 29, 2017 at 04:42:16PM -0200, Eduardo Habkost wrote: > On Wed, Nov 29, 2017 at 12:44:42PM +0100, Paolo Bonzini wrote: > > On 29/11/2017 12:44, Eduardo Habkost wrote: > > > On Mon, Nov 13, 2017 at 09:32:09AM +0100, Paolo Bonzini wrote: > > >> On 13/11/2017 08:15, Wanpeng Li wrote: > > >>

Re: [PATCH 07/11] xfs: remove not needed freezing calls

2017-11-30 Thread Rafael J. Wysocki
On Thu, Nov 30, 2017 at 5:21 PM, Jan Kara wrote: > On Wed 29-11-17 15:23:52, Luis R. Rodriguez wrote: >> This removes superflous freezer calls as they are no longer needed >> as the VFS now performs filesystem freezing/thaw if the filesystem has >> support for it. >> >> The following Coccinelle ru

Re: [PATCH v2 16/23] test_firmware: enable custom fallback testing on limited kernel configs

2017-11-30 Thread Luis R. Rodriguez
On Wed, Nov 29, 2017 at 11:22:35AM +0100, Greg KH wrote: > On Mon, Nov 20, 2017 at 10:24:02AM -0800, Luis R. Rodriguez wrote: > > When a kernel is not built with: > > > > CONFIG_HAS_FW_LOADER_USER_HELPER_FALLBACK=y > > > > We don't currently enable testing fw_fallback.sh. For kernels that > > sti

Re: [patches] [PATCH 3/4] RISC-V: Flush I$ when making a dirty page executable

2017-11-30 Thread Olof Johansson
Hi, On Mon, Nov 20, 2017 at 10:57 AM, Palmer Dabbelt wrote: > From: Andrew Waterman > > The RISC-V ISA allows for instruction caches that are not coherent WRT > stores, even on a single hart. As a result, we need to explicitly flush > the instruction cache whenever marking a dirty page as execu

Re: [PATCH] dt-bindings: pinctrl: uniphier: add UniPhier pinctrl binding

2017-11-30 Thread Rob Herring
On Tue, Nov 28, 2017 at 9:44 PM, Masahiro Yamada wrote: > Hi Rob, > > > 2017-11-29 0:27 GMT+09:00 Rob Herring : >> On Tue, Nov 28, 2017 at 04:49:45PM +0900, Masahiro Yamada wrote: >>> The driver has been in the tree for a while, but its binding document >>> is missing. Hence, here it is. >>> >>>

Re: [PATCH] riscv/ftrace: Add basic support

2017-11-30 Thread Steven Rostedt
On Thu, 30 Nov 2017 16:53:35 +0800 Alan Kao wrote: > This patch contains basic ftrace support for RV64I platform. > Specifically, function tracer (HAVE_FUNCTION_TRACER), function graph > tracer (HAVE_FUNCTION_GRAPH_TRACER), and a frame pointer test > (HAVE_FUNCTION_GRAPH_FP_TEST) are implemented

Re: [patches] Re: [PATCH 08/10] RISC-V: Set __ARCH_WANT_RENAMEAT to pick up generic version

2017-11-30 Thread Olof Johansson
On Thu, Nov 30, 2017 at 10:38 AM, Palmer Dabbelt wrote: > On Thu, 30 Nov 2017 10:30:32 PST (-0800), Christoph Hellwig wrote: >> >> On Wed, Nov 29, 2017 at 05:55:19PM -0800, Olof Johansson wrote: >>> >>> In file included from ../lib/audit.c:8:0: >>> ../include/asm-generic/audit_dir_write.h:30:1: er

[PATCH] sched/isolation: Make NO_HZ_FULL select CPU_ISOLATION

2017-11-30 Thread Paul E. McKenney
Commit 5c4991e24c69 ("sched/isolation: Split out new CONFIG_CPU_ISOLATION=y config from CONFIG_NO_HZ_FULL") can result in RCU CPU stall warnings when running rcutorture with CONFIG_NO_HZ_FULL_ALL=y and CONFIG_CPU_ISOLATION=n. These warnings are caused by RCU's grace-period kthreads sleeping for a

Re: [PATCH v2 10/23] firmware: add helper to copy built-in data to pre-alloc buffer

2017-11-30 Thread Luis R. Rodriguez
On Wed, Nov 29, 2017 at 11:17:15AM +0100, Greg KH wrote: > On Mon, Nov 20, 2017 at 10:23:56AM -0800, Luis R. Rodriguez wrote: > > This makes it clearer that the parameters passed are only used for > > the preallocated buffer option, ie, when a caller uses: > > > > request_firmware_into_buf() >

[PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts

2017-11-30 Thread tyler
From: Tyler Baker The Compulab IoT Gateway is based on an NXP i.MX7D, dual core Cortex-A7 clocking at 1GHz. It supports up to 2GB of DDR3, and 32GB of eMMC flash. Onboard, there are two gigabit ethernet controllers, 4 x USB2, RS485, and CAN. This platform is based on the imx7d-cl-som-imx7 module

[PATCH 5/8] ARM: dts: imx7s: add node and supplies for vdd1p2

2017-11-30 Thread tyler
From: Tyler Baker Add the regulator nodes and supplies for vdd1p2. This regulator is used to power the GPC and USB HSIC PHY. Signed-off-by: Tyler Baker --- arch/arm/boot/dts/imx7s.dtsi | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7s

Re: [PATCH v7 1/5] add infrastructure for tagging functions as error injectable

2017-11-30 Thread Josef Bacik
On Wed, Nov 29, 2017 at 05:59:39PM +0100, Daniel Borkmann wrote: > On 11/28/2017 09:02 PM, Josef Bacik wrote: > > On Tue, Nov 28, 2017 at 11:58:41AM -0700, Jonathan Corbet wrote: > >> On Wed, 22 Nov 2017 16:23:30 -0500 > >> Josef Bacik wrote: > >>> From: Josef Bacik > >>> > >>> Using BPF we can o

[PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb

2017-11-30 Thread tyler
From: Tyler Baker Build the imx7d-sbc-iot-imx7 device tree blob. Signed-off-by: Tyler Baker --- arch/arm/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index d0381e9..0334137 100644 --- a/arch/arm/boot/dts/Makefile

[PATCH 4/8] ARM: dts: imx7s: add dma support

2017-11-30 Thread tyler
From: Tyler Baker Enable dma on all SPI and UART interfaces. Signed-off-by: Tyler Baker --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 82ad26e..7b85659 100644 --- a/arch/arm/boot/dts/i

[PATCH 6/8] ARM: dts: imx7d-sbc-iot: enable PCIe peripheral

2017-11-30 Thread tyler
From: Tyler Baker Add a PCIe device tree node to enable PCIe support. Signed-off-by: Tyler Baker --- arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts b/arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts

[PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2

2017-11-30 Thread tyler
From: Tyler Baker Add device tree nodes for the USB hub, and USB OTG. i2c2 on this platform supports low state retention power state so lets use it. Signed-off-by: Tyler Baker --- arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 36 + 1 file changed, 28 insertions(+),

[PATCH 8/8] PCIe: imx6: imx7d: add support for phy refclk source

2017-11-30 Thread tyler
From: Tyler Baker In the i.MX7D the PCIe PHY can use either externel oscillator or internal PLL as a reference clock source. Add support for the PHY Reference Clock source including device tree property phy-ref-clk. External oscillator is used as a default reference clock source. Signed-off-by:

[PATCH v1] PCI: Remove PCI_REASSIGN_ALL_RSRC use on arm and arm64

2017-11-30 Thread Bjorn Helgaas
From: Bjorn Helgaas On arm, PCI_REASSIGN_ALL_RSRC is used only in pcibios_assign_all_busses(), which helps decide whether to reconfigure bridge bus numbers. It has nothing to do with BAR assignments. On arm64 and powerpc, pcibios_assign_all_busses() tests PCI_REASSIGN_ALL_BUS, which makes more

[PATCH 0/8] ARM: dts: introduce Compulab IoT Gateway

2017-11-30 Thread tyler
From: Tyler Baker The Compulab IoT Gateway is based on an NXP i.MX7D, dual core Cortex-A7 clocking at 1GHz. It supports up to 2GB of DDR3, and 32GB of eMMC flash. Onboard, there are two gigabit ethernet controllers, 4 x USB2, RS485, and CAN. It uses the same SoM as the cl-som-imx7, but includes

[PATCH 7/8] ARM: dts: imx7s: add usb hsic phy domain

2017-11-30 Thread tyler
From: Tyler Baker The GPCv2 driver should control the MIPI, PCIe, and USB HSIC PHY regulators. Add the USB HSIC power domain to the GPC node. Signed-off-by: Tyler Baker --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arc

Re: [PATCH RFC 2/2] mm, hugetlb: do not rely on overcommit limit during migration

2017-11-30 Thread Michal Hocko
On Thu 30-11-17 20:57:43, Michal Hocko wrote: > On Thu 30-11-17 11:35:11, Mike Kravetz wrote: > > On 11/29/2017 11:57 PM, Michal Hocko wrote: > > > On Wed 29-11-17 11:52:53, Mike Kravetz wrote: > > >> On 11/29/2017 01:22 AM, Michal Hocko wrote: > > >>> What about this on top. I haven't tested this

Re: [PATCH 0/5] PCI: Add support to the Cadence PCIe controller

2017-11-30 Thread Cyrille Pitchen
Le 30/11/2017 à 19:45, Cyrille Pitchen a écrit : > Hi all, > > Le 30/11/2017 à 19:18, Lorenzo Pieralisi a écrit : >> On Thu, Nov 30, 2017 at 12:43:20PM +0530, Kishon Vijay Abraham I wrote: >> >> [...] >> > For linux-next, I applied this series on top of Kishon's patch > ("PCI: endpoint: Us

[PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings

2017-11-30 Thread Christoph Böhmwalder
The kbuild test bot complained about a new coccinelle warning nearby, which sparked a discussion about the assignment to 'memory' inside of the conditional expression. See Link below for the original post. Fix the assignment to silence the coccinelle warning and also make the code look a little n

Re: [PATCH 15/24] x86/mm: Allow flushing for future ASID switches

2017-11-30 Thread Peter Zijlstra
On Thu, Nov 30, 2017 at 10:48:56AM -0800, Andy Lutomirski wrote: > Should it be > tlb_flush_shared_nonglobals_if_kernel_and_user_pagetables_are_separate()? Its effectively invpcid_flush_all_other() or something like that. Of course, its not invpcid based, so we should not name it such. flush_asi

Re: [PATCH v3 5/6] ARM: ep93xx: ts72xx: cosmetic: Add some description to ts72xx code

2017-11-30 Thread Alexander Sverdlin
Hello Hartley! On Thu, 30 Nov 2017 17:23:02 + Hartley Sweeten wrote: > > +/** > > +*** > > + * IO map > > + > > +*** > > +**/ > > There is also something

Re: [PATCH 1/2] x86/stacktrace: do not fail when regs on stack for ORC

2017-11-30 Thread Josh Poimboeuf
On Thu, Nov 30, 2017 at 01:57:10PM -0600, Josh Poimboeuf wrote: > On Thu, Nov 30, 2017 at 09:03:24AM +0100, Jiri Slaby wrote: > > save_stack_trace_reliable now returns "non reliable" when there are > > kernel pt_regs on stack. This means an interrupt or exception happened. > > Somewhere down the ro

Re: [pcpu] BUG: KASAN: use-after-scope in pcpu_setup_first_chunk+0x1e3b/0x29e2

2017-11-30 Thread Ard Biesheuvel
On 30 November 2017 at 19:56, Kees Cook wrote: > On Thu, Nov 30, 2017 at 11:22 AM, Dennis Zhou wrote: >> Hi Dmitry and Kees, >> >> On Thu, Nov 30, 2017 at 10:10:41AM -0800, Kees Cook wrote: >>> > Are we sure that structleak plugin is not at fault? If yes, then we >>> > need to report this to http

Re: [PATCH RFC 2/2] mm, hugetlb: do not rely on overcommit limit during migration

2017-11-30 Thread Michal Hocko
On Thu 30-11-17 11:35:11, Mike Kravetz wrote: > On 11/29/2017 11:57 PM, Michal Hocko wrote: > > On Wed 29-11-17 11:52:53, Mike Kravetz wrote: > >> On 11/29/2017 01:22 AM, Michal Hocko wrote: > >>> What about this on top. I haven't tested this yet though. > >> > >> Yes, this would work. > >> > >> Ho

Re: [PATCH v2 01/18] dt-bindings: panel: lvds: Document power-supply property

2017-11-30 Thread Rob Herring
On Thu, Nov 30, 2017 at 9:30 AM, Maxime Ripard wrote: > Hi Rob, > > On Tue, Nov 28, 2017 at 11:48:47AM -0600, Rob Herring wrote: >> Please CC DT list. >> >> On Mon, Nov 27, 2017 at 9:41 AM, Maxime Ripard >> wrote: >> > The power-supply property is used by a vast majority of panels, including >> >

Re: [PATCH 1/2] x86/stacktrace: do not fail when regs on stack for ORC

2017-11-30 Thread Josh Poimboeuf
On Thu, Nov 30, 2017 at 09:03:24AM +0100, Jiri Slaby wrote: > save_stack_trace_reliable now returns "non reliable" when there are > kernel pt_regs on stack. This means an interrupt or exception happened. > Somewhere down the route. It is a problem for frame pointer unwinder, > because the frame mig

Re: [RFC] Rebasing the IDR

2017-11-30 Thread Daniel Vetter
Adding dri-devel, I think a pile of those are in drm. On Thu, Nov 30, 2017 at 6:36 PM, Matthew Wilcox wrote: > About 40 of the approximately 180 users of the IDR in the kernel are > "1-based" instead of "0-based". That is, they never want to have ID 0 > allocated; they want to see IDs allocated

<    1   2   3   4   5   6   7   8   9   10   >