[RFC PATCH v3 0/7] ktask: multithread CPU-intensive kernel work

2017-12-05 Thread Daniel Jordan
What do people think of the overall design and direction? There's documentation describing the design in the first patch of the series and the second patch has the API in ktask.h. Thanks, Daniel Changelog: v2 -> v3: - Changed cpu to CPU in the ktask Documentation, as sugg

[RFC PATCH v3 6/7] hugetlbfs: parallelize hugetlbfs_fallocate with ktask

2017-12-05 Thread Daniel Jordan
hugetlbfs_fallocate preallocates huge pages to back a file in a hugetlbfs filesystem. The time to call this function grows linearly with size. ktask performs well with its default thread count of 4; higher thread counts are given for context only. Machine: Intel(R) Xeon(R) CPU E7-8895 v3 @ 2.60G

[RFC PATCH v3 4/7] mm: enlarge type of offset argument in mem_map_offset and mem_map_next

2017-12-05 Thread Daniel Jordan
Changes the type of 'offset' from int to unsigned long in both mem_map_offset and mem_map_next. This facilitates ktask's use of mem_map_next with its unsigned long types to avoid silent truncation when these unsigned longs are passed as ints. It also fixes the preexisting truncation of 'offset' f

[RFC PATCH v3 5/7] mm: parallelize clear_gigantic_page

2017-12-05 Thread Daniel Jordan
Parallelize clear_gigantic_page, which zeroes any page size larger than 8M (e.g. 1G on x86 or 2G on SPARC). Performance results (the default number of threads is 4; higher thread counts shown for context only): Machine: SPARC T7-4, 1024 CPUs, 504G memory Test:Clear a range of gigantic pages

Re: [PATCH v2] pata_pdc2027x: Fix coding sytle errors

2017-12-05 Thread Tejun Heo
On Tue, Dec 05, 2017 at 11:56:38PM +0530, Arvind Yadav wrote: > Fix these checkpatch.pl errors: > Fix checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > ERROR: space prohibited after that '~' (ctx:WxW) > + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); > > ERRO

[RFC PATCH v3 2/7] ktask: multithread CPU-intensive kernel work

2017-12-05 Thread Daniel Jordan
ktask is a generic framework for parallelizing CPU-intensive work in the kernel. The intended use is for big machines that can use their CPU power to speed up large tasks that can't otherwise be multithreaded in userland. The API is generic enough to add concurrency to many different kinds of tas

[RFC PATCH v3 7/7] mm: parallelize deferred struct page initialization within each node

2017-12-05 Thread Daniel Jordan
Deferred struct page initialization currently uses one thread per node (pgdatinit threads), but this is a bottleneck during boot on big machines, so use ktask within each pgdatinit thread to parallelize the struct page initialization on each node, allowing the system to take better advantage of its

[RFC PATCH v3 1/7] ktask: add documentation

2017-12-05 Thread Daniel Jordan
Motivates and explains the ktask API for kernel clients. Signed-off-by: Daniel Jordan Reviewed-by: Steve Sistare Cc: Aaron Lu Cc: Andrew Morton Cc: Dave Hansen Cc: Mel Gorman Cc: Michal Hocko Cc: Mike Kravetz Cc: Pavel Tatashin Cc: Tim Chen --- Documentation/core-api/index.rst | 1 +

Re: [PATCH v2 cgroup/for-4.15-fixes] cgroup: add warning about RT not being supported on cgroup2

2017-12-05 Thread Tejun Heo
On Tue, Dec 05, 2017 at 07:53:51PM +0100, Michael Kerrisk (man-pages) wrote: > > +WARNING: cgroup2 doesn't yet support control of realtime processes and > > +the cpu controller can only be enabled when all RT processes are in > > +the root cgroup. Be aware that that system management software may

Re: [PATCH net-next 0/5] net: dsa: use per-port upstream port

2017-12-05 Thread David Miller
From: Vivien Didelot Date: Mon, 4 Dec 2017 12:34:52 -0500 > An upstream port is a local switch port used to reach a CPU port. > > DSA still considers a unique CPU port in the whole switch fabric and > thus return a unique upstream port for a given switch. This is wrong in > a multiple CPU ports

[PATCH resubmit 2/2] eeprom: at24: switch to device-managed version of i2c_new_dummy

2017-12-05 Thread Heiner Kallweit
Make use of recently introduced device-managed version of i2c_new_dummy to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/misc/eeprom/at24.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c

[PATCH resubmit 1/2] i2c: core: add device-managed version of i2c_new_dummy

2017-12-05 Thread Heiner Kallweit
i2c_new_dummy is typically called from the probe function of the driver for the primary i2c client. It requires calls to i2c_unregister_device in the error path of the probe function and in the remove function. This can be simplified by introducing a device-managed version. Note the changed error

Re: [PATCH v3 1/4] kaslr: add immovable_mem=nn[KMG]@ss[KMG] to specify extracting memory

2017-12-05 Thread Kees Cook
On Tue, Dec 5, 2017 at 12:51 AM, Chao Fan wrote: > In current code, kaslr may choose the memory region in movable > nodes to extract kernel, which will make the nodes can't be hot-removed. > To solve it, we can specify the memory region in immovable node. > Create immovable_mem to store the region

Re: [PATCH 0/7] Switchtec NTB Crosslink Support

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 12:15 PM, Jon Mason wrote: On Wed, Nov 29, 2017 at 12:58 PM, Logan Gunthorpe wrote: Also, I forgot to mention, this patch set is based on today's ntb-next. All of these look sane to me. Assuming they apply cleanly, adding to ntb-next. Great, thanks! Logan

Re: [PATCH v1 0/2] PCI/ASPM: Refine L1 PM Substates support

2017-12-05 Thread Bjorn Helgaas
On Sat, Dec 02, 2017 at 03:45:38PM -0600, Bjorn Helgaas wrote: > The PCIe active link power state is L0. ASPM defines two low-power > states: L0s and L1. The L1 PM Substates feature defines two > additional low-power states: L1.1 and L2.2. > > The L1.2 state may have substantial entry/exit laten

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 12:12 PM, Jon Mason wrote: It sucks that we don't already have a struct for PCI config space we can reuse here. If you find the time, it would be good to add in the future to reduce duplicate code here and in the PCI core. However, this patch is fine without it. I agree. And bel

[PATCH 0/2] i2c: introduce devm_i2c_new_dummy and use it in at24 driver

2017-12-05 Thread Heiner Kallweit
i2c_new_dummy is typically called from the probe function of the driver for the primary i2c client. It requires calls to i2c_unregister_device in the error path of the probe function and in the remove function. This can be simplified by introducing a device-managed version. Make at24 driver the fi

Re: [PATCH v3 2/4] kaslr: calculate the memory region in immovable node

2017-12-05 Thread Kees Cook
On Tue, Dec 5, 2017 at 12:51 AM, Chao Fan wrote: > If there is no immovable memory region specified, go on the old code. > There are several conditons: > 1. CONFIG_MEMORY_HOTPLUG is not specified to y. > 2. immovable_mem= is not specified. > > Otherwise, calculate the intersecting between memmap e

Re: [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device

2017-12-05 Thread Nicolin Chen
On Tue, Dec 05, 2017 at 01:04:46PM +, Mark Brown wrote: > On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote: > > struct device is defined in system level header files any way. > > As long as fsl_ssi.h is included after those header files, it > > should be safe to remove this line. >

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 11:27 AM, Jon Mason wrote: echo "Running db tests on: $(basename $LOC) / $(basename $REM)" - write_file "c $DB_BITMASK" "$REM/db" + DB_VALID_MASK=$(read_file "$LOC/db_valid_mask") - for ((i=1; i <= 8; i++)); do - let DB=$(read_file "$REM/db

Re: [PATCH][next] netdevsim: make functions nsim_bpf_create_prog and nsim_bpf_destroy_prog static

2017-12-05 Thread David Miller
From: Colin King Date: Mon, 4 Dec 2017 12:56:09 + > From: Colin Ian King > > Functions nsim_bpf_create_prog and nsim_bpf_destroy_prog are local to the > source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'nsim_bpf_create_prog' was no

Re: [PATCH] Arm: mm: ftrace: Only set text back to ro after kernel has been marked ro

2017-12-05 Thread Kees Cook
On Tue, Dec 5, 2017 at 5:36 AM, Russell King - ARM Linux wrote: > On Tue, Dec 05, 2017 at 01:30:11PM +, Phil Elwell wrote: >> This was my initial explanation: >> >> 1. Data which is marked __ro_after_init is initially writeable. >> >> 2. The ro_perms data covers kernel text, read-only data and

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Paul E. McKenney
On Tue, Dec 05, 2017 at 09:24:21PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 08:17:33PM +0100, Peter Zijlstra wrote: > > On Tue, Dec 05, 2017 at 08:57:46PM +0200, Michael S. Tsirkin wrote: > > > > > I don't see WRITE_ONCE inserting any barriers, release or > > > write. > > > > Co

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-05 Thread Nicolin Chen
On Tue, Dec 05, 2017 at 02:01:17PM +0100, Maciej S. Szmigiero wrote: > > ==Verification== > > Theoretically, it only needs code review, build and sanity tests. I > > have done build and sanity tests on an i.MX 6 platform by building > > using imx_v6_v7_defconfig and testing with I2S slave/master m

Re: [linux-sunxi] [PATCH 1/2] clk: sunxi-ng: Support fixed post-dividers on MP style clocks

2017-12-05 Thread Maxime Ripard
1;5002;0c On Tue, Dec 05, 2017 at 11:01:11AM +0800, Chen-Yu Tsai wrote: > On Tue, Dec 5, 2017 at 7:18 AM, André Przywara wrote: > > Hi Chen-Yu, > > > > On 04/12/17 05:19, Chen-Yu Tsai wrote: > >> On the A64, the MMC module clocks are fixed in the new timing mode, > >> i.e. they do not have a bit t

[PATCH] ptr_ring: add barriers

2017-12-05 Thread Michael S. Tsirkin
Users of ptr_ring expect that it's safe to give the data structure a pointer and have it be available to consumers, but that actually requires an smb_wmb or a stronger barrier. In absence of such barriers and on architectures that reorder writes, consumer might read an un=initialized value from an

Re: [PATCH] ALSA: pcm: prevent UAF in snd_pcm_info

2017-12-05 Thread Kees Cook
On Tue, Dec 5, 2017 at 11:14 AM, Takashi Iwai wrote: > On Tue, 05 Dec 2017 18:16:55 +0100, > Nick Desaulniers wrote: >> >> From: Robb Glasser >> >> When the device descriptor is closed, the `substream->runtime` pointer >> is freed. But another thread may be in the ioctl handler, case >> SNDRV_CTL

[PATCH] ASoC: Intel: bxt: Refine the HW contraint of Ref capture.

2017-12-05 Thread Harry Pan
The patch restricts the HW contraint of the refcap of WoV stream in single channel (mono) and 16k Hz based on platform implementation. Such that, the userspace program can rely on correct HW parameters through the ALSA library call to manipulate the device. Signed-off-by: Harry Pan --- sound/so

Re: [PATCH 1/2] [RFC] kbuild: add macro for controlling warnings to linux/compiler.h

2017-12-05 Thread Kees Cook
On Tue, Dec 5, 2017 at 7:32 AM, Arnd Bergmann wrote: > I have occasionally run into a situation where it would make sense to > control a compiler warning from a source file rather than doing so from > a Makefile using the $(cc-disable-warning, ...) or $(cc-option, ...) > helpers. > > The approach

Re: [PATCH v3] irqchip/gic-v3: Fix the driver probe() fail due to disabled GICC entry

2017-12-05 Thread Shanker Donthineni
Hi Marc, I messed-up patch contents please disregard this one and review v4 patch. [v4] irqchip/gic-v3: Fix the driver probe() fail due to disabled GICC entry https://patchwork.kernel.org/patch/10093653/ -- Shanker Donthineni Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm T

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Michael S. Tsirkin
On Tue, Dec 05, 2017 at 08:17:33PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 08:57:46PM +0200, Michael S. Tsirkin wrote: > > > I don't see WRITE_ONCE inserting any barriers, release or > > write. > > Correct, never claimed there was. > > Just saying that: > > obj = READ_ONCE(

Re: [PATCH v2 00/27] Improve DE2 support

2017-12-05 Thread Maxime Ripard
Hi, On Tue, Dec 05, 2017 at 04:52:57PM +0100, Jernej Škrabec wrote: > Dne torek, 05. december 2017 ob 11:36:18 CET je Maxime Ripard napisal(a): > > Hi, > > > > On Fri, Dec 01, 2017 at 07:05:23AM +0100, Jernej Skrabec wrote: > > > Current DE2 driver is very basic and uses a lot of magic constants

Re: [PATCH v2] irqchip/gic-v3: Fix the driver probe() fail due to disabled GICC entry

2017-12-05 Thread Shanker Donthineni
Hi Marc, I messed-up patch contents please disregard this one and review v4 patch. [v4] irqchip/gic-v3: Fix the driver probe() fail due to disabled GICC entry https://patchwork.kernel.org/patch/10093653/ -- Shanker Donthineni Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm

Re: [e1000_shutdown] e1000 0000:00:03.0: disabling already-disabled device

2017-12-05 Thread Tushar Dave
On 12/04/2017 05:03 PM, Fengguang Wu wrote: Hi Tushar, On Tue, Nov 28, 2017 at 01:01:23AM +0530, Tushar Dave wrote: On 11/23/2017 04:43 AM, Fengguang Wu wrote: On Wed, Nov 22, 2017 at 03:40:52AM +0530, Tushar Dave wrote: On 11/21/2017 06:11 PM, Fengguang Wu wrote: Hello, FYI this happ

Re: [PATCH] ocfs2: use get_task_comm

2017-12-05 Thread Kees Cook
On Tue, Dec 5, 2017 at 7:20 AM, Arnd Bergmann wrote: > While reviewing all callers of get_task_comm(), I stumbled > over this one that claimed it was not exported, when in fact > it is. Accessing task->comm directly is not safe, so better > convert this one to using get_task_comm as well. Using g

Re: [patch 34/60] x86/mm/kpti: Populate user PGD

2017-12-05 Thread Borislav Petkov
On Mon, Dec 04, 2017 at 03:07:40PM +0100, Thomas Gleixner wrote: > From: Dave Hansen > > Populate the PGD entries in the init user PGD which cover the kernel half > of the address space. This makes sure that the installment of the user > visible kernel mappings finds a populated PGD. > > In clon

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Peter Zijlstra
On Tue, Dec 05, 2017 at 08:57:46PM +0200, Michael S. Tsirkin wrote: > I don't see WRITE_ONCE inserting any barriers, release or > write. Correct, never claimed there was. Just saying that: obj = READ_ONCE(*foo); val = READ_ONCE(obj->val); Never needs a barrier (except on Alpha

Re: [PATCH v2 05/15] NTB: ntb_tool: Add full multi-port NTB API support

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 11:03 AM, Jon Mason wrote: +static ssize_t tool_fn_read(struct tool_ctx *tc, char __user *ubuf, + size_t size, loff_t *offp, + u64 (*fn_read)(struct ntb_dev *)) { size_t buf_size; - char *buf; - ssize_t pos,

[PATCH v4] irqchip/gic-v3: Fix the driver probe() fail due to disabled GICC entry

2017-12-05 Thread Shanker Donthineni
The ACPI specification says OS shouldn't attempt to use GICC configuration parameters if the flag ACPI_MADT_ENABLED is cleared. The ARM64-SMP code skips the disabled GICC entries but not causing any issue. However the current GICv3 driver probe bails out causing kernel panic() instead of skipping t

Re: [PATCH 0/7] Switchtec NTB Crosslink Support

2017-12-05 Thread Jon Mason
On Wed, Nov 29, 2017 at 12:58 PM, Logan Gunthorpe wrote: > Also, I forgot to mention, this patch set is based on today's ntb-next. All of these look sane to me. Assuming they apply cleanly, adding to ntb-next. Thanks, Jon > > Logan > > > On 29/11/17 10:55 AM, Logan Gunthorpe wrote: >> >> Hi, >

Re: [PATCH] ALSA: pcm: prevent UAF in snd_pcm_info

2017-12-05 Thread Takashi Iwai
On Tue, 05 Dec 2017 18:16:55 +0100, Nick Desaulniers wrote: > > From: Robb Glasser > > When the device descriptor is closed, the `substream->runtime` pointer > is freed. But another thread may be in the ioctl handler, case > SNDRV_CTL_IOCTL_PCM_INFO. This case calls snd_pcm_info_user() which > c

Re: [PATCH] arch, mm: introduce arch_tlb_gather_mmu_exit

2017-12-05 Thread Michal Hocko
On Tue 05-12-17 10:31:12, Linus Torvalds wrote: > On Tue, Dec 5, 2017 at 6:58 AM, Michal Hocko wrote: > > > > This all is nice but tlb_gather users are not aware of that and this can > > actually cause some real problems. E.g. the oom_reaper tries to reap the > > whole address space but it might r

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Jon Mason
On Wed, Nov 29, 2017 at 12:55 PM, Logan Gunthorpe wrote: > The PFF CSR registers actual mirrors the PCI configuration space > for all the ports in the switch. Previously, this was not needed by > the driver but will be used by the crosslink code to enumerate the > bus in an host-less centre partit

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 10:31 AM, Serge Semin wrote: -static int idt_ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx, u32 *msg) +static u32 idt_ntb_msg_read(struct ntb_dev *ntb, int *pidx, int midx) { struct idt_ntb_dev *ndev = to_ndev_ntb(ntb); if (midx < 0 || IDT_MSG_CNT <= mid

[PATCH RFC v2] Fix race window during idle cpu selection.

2017-12-05 Thread Atish Patra
This patch tries to fix a possible race window that lets multiple tasks wakeup on the same cpu. schbench, uperf & Jackbench (Android) mostly showed improvements while none of the other standard benchmarks have shown any regression. changes from v1->v2: 1. Added the performance numbers. 2. Did not

[PATCH RFC v2] sched: Minimize the idle cpu selection race window.

2017-12-05 Thread Atish Patra
Currently, multiple tasks can wakeup on same cpu from select_idle_sibiling() path in case they wakeup simulatenously and last ran on the same llc. This happens because an idle cpu is not updated until idle task is scheduled out. Any task waking during that period may potentially select that cpu for

Re: [PATCH v2] exec: avoid gcc-8 warning for get_task_comm

2017-12-05 Thread Kees Cook
On Tue, Dec 5, 2017 at 7:17 AM, Arnd Bergmann wrote: > gcc-8 warns about using strncpy() with the source size as the limit: > > fs/exec.c:1223:32: error: argument to 'sizeof' in 'strncpy' call is the same > expression as the source; did you mean to use the size of the destination? > [-Werror=siz

[PATCH v3] irqchip/gic-v3: Fix the driver probe() fail due to disabled GICC entry

2017-12-05 Thread Shanker Donthineni
The ACPI specification says OS shouldn't attempt to use GICC configuration parameters if the flag ACPI_MADT_ENABLED is cleared. The ARM64-SMP code skips the disabled GICC entries but not causing any issue. However the current GICv3 driver probe bails out causing kernel panic() instead of skipping t

[PATCHv6 1/1] ima: re-introduce own integrity cache lock

2017-12-05 Thread Dmitry Kasatkin
The original design was discussed 3+ years ago, but was never completed/upstreamed. Based on the recent discussions with Linus https://patchwork.kernel.org/patch/9975919, I've rebased this patch. Before IMA appraisal was introduced, IMA was using own integrity cache lock along with i_mutex. proce

[PATCH v2] irqchip/gic-v3: Fix the driver probe() fail due to disabled GICC entry

2017-12-05 Thread Shanker Donthineni
The ACPI specification says OS shouldn't attempt to use GICC configuration parameters if the flag ACPI_MADT_ENABLED is cleared. The ARM64-SMP code skips the disabled GICC entries but not causing any issue. However the current GICv3 driver probe bails out causing kernel panic() instead of skipping t

Re: [RFC PATCH 1/6] drm: Add Content Protection property

2017-12-05 Thread Sean Paul
On Tue, Dec 5, 2017 at 12:34 PM, Pavel Machek wrote: > On Tue 2017-12-05 11:45:38, Daniel Vetter wrote: >> On Tue, Dec 05, 2017 at 11:28:40AM +0100, Pavel Machek wrote: >> > On Wed 2017-11-29 22:08:56, Sean Paul wrote: >> > > This patch adds a new optional connector property to allow userspace to

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Michael S. Tsirkin
On Tue, Dec 05, 2017 at 07:39:46PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 08:31:20PM +0200, Michael S. Tsirkin wrote: > > > Apropos, READ_ONCE is now asymmetrical with WRITE_ONCE. > > > > I can read a pointer with READ_ONCE and be sure the value > > is sane, but only if I also rem

Re: [PATCH 2/3 v3] kernel: Move groups_sort to the caller of set_groups.

2017-12-05 Thread Thiago Rafael Becker
It seems I missed another one in arch/s390, uploaded an update. On Tue, 5 Dec 2017, Thiago Rafael Becker wrote: The responsibility for calling groups_sort is now on the caller of set_groups.

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-05 Thread Brian Norris
Hi Nickey, On Tue, Dec 05, 2017 at 05:14:11PM +0800, Nickey Yang wrote: > On 2017年12月01日 18:07, Philippe CORNU wrote: > >On 12/01/2017 10:11 AM, Nickey Yang wrote: > >>On 2017年12月01日 16:32, Philippe CORNU wrote: > >>>I am sorry to say that but you can not add my "Acked-by" to this patch > >>>becau

[PATCH 2/3] kernel: Move groups_sort to the caller of set_groups.

2017-12-05 Thread Thiago Rafael Becker
The responsibility for calling groups_sort is now on the caller of set_groups. Signed-off-by: Thiago Rafael Becker --- arch/s390/kernel/compat_linux.c | 1 + fs/nfsd/auth.c| 3 +++ kernel/groups.c | 1 + kernel/uid16.c| 1 + net/sunrpc/

Re: [PATCH v2 cgroup/for-4.15-fixes] cgroup: add warning about RT not being supported on cgroup2

2017-12-05 Thread Michael Kerrisk (man-pages)
On 5 December 2017 at 19:29, Tejun Heo wrote: > From f0a821260f24ea9378ed0e0c149e3bbc1a1bd008 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Tue, 5 Dec 2017 09:10:17 -0800 > > We haven't yet figured out what to do with RT threads on cgroup2. > Document the limitation. > > v2: Included the war

Re: [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE

2017-12-05 Thread Jason Gerecke
Looks like this might also be needed for the MobileStudio Pro... https://bugzilla.kernel.org/show_bug.cgi?id=197991 Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three,/ So

[PATCH v4] pata_pdc2027x: Fix pdc_adjust_pll() to return the error value

2017-12-05 Thread Arvind Yadav
This change is to ensure that function pdc_adjust_pll() returns the error value to avoid the unnecessary error check for pdc_hardware_init() in pdc2027x_reinit_one(). Signed-off-by: Arvind Yadav --- changes in v2 : Make function return type 'void' instead of 'int. Ad

Re: [PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Jerome Brunet
On Tue, 2017-12-05 at 19:01 +0100, Andrew Lunn wrote: > On Tue, Dec 05, 2017 at 10:33:34AM +0100, Jerome Brunet wrote: > > From: Neil Armstrong > > > > Define registers and bits in meson-gxl PHY driver to make a bit > > more human friendly. No functional change > > > > static int meson_gxl_con

Re: [PATCH v9 3/5] perf utils: use pmu->is_uncore to detect PMU UNCORE devices

2017-12-05 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 05, 2017 at 08:35:22PM +0800, Jin, Yao escreveu: > A quick test with the new patch 'fix_json_v9_2.patch' shows it working. I'll take this as a Tested-by: you, ok? > See the log: > > root@skl:/tmp# perf stat --per-thread -p 10322 -M CPI,IPC > ^C > Performance counter stats for proce

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Peter Zijlstra
On Tue, Dec 05, 2017 at 08:31:20PM +0200, Michael S. Tsirkin wrote: > Apropos, READ_ONCE is now asymmetrical with WRITE_ONCE. > > I can read a pointer with READ_ONCE and be sure the value > is sane, but only if I also remember to put in smp_wmb before > WRITE_ONCE. Otherwise the pointer is ok but

Re: [tip:x86/mpx] x86/insn-eval: Add utility function to get segment descriptor

2017-12-05 Thread Peter Zijlstra
On Tue, Dec 05, 2017 at 07:14:56PM +0100, Borislav Petkov wrote: > On Tue, Dec 05, 2017 at 06:48:44PM +0100, Peter Zijlstra wrote: > > This is broken right? You unlock and then return @desc, which afaict can > > at that point get freed by free_ldt_struct(). > > > > Something like the below ought t

Re: [patch 33/60] x86/mm/kpti: Allocate a separate user PGD

2017-12-05 Thread Borislav Petkov
On Mon, Dec 04, 2017 at 03:07:39PM +0100, Thomas Gleixner wrote: > From: Dave Hansen > > Kernel page table isolation requires to have two PGDs. One for the kernel, > which contains the full kernel mapping plus the user space mapping and one > for user space which contains the user space mappings

Re: [PATCH] arch, mm: introduce arch_tlb_gather_mmu_exit

2017-12-05 Thread Linus Torvalds
On Tue, Dec 5, 2017 at 6:58 AM, Michal Hocko wrote: > > This all is nice but tlb_gather users are not aware of that and this can > actually cause some real problems. E.g. the oom_reaper tries to reap the > whole address space but it might race with threads accessing the memory [1]. > It is possibl

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Michael S. Tsirkin
On Fri, Dec 01, 2017 at 11:51:16AM -0800, Paul E. McKenney wrote: > Because READ_ONCE() now implies read_barrier_depends(), the > read_barrier_depends() in next_desc() is now redundant. This commit > therefore removes it and the related comments. > > Signed-off-by: Paul E. McKenney > Cc: "Michae

[PATCH v2 cgroup/for-4.15-fixes] cgroup: add warning about RT not being supported on cgroup2

2017-12-05 Thread Tejun Heo
>From f0a821260f24ea9378ed0e0c149e3bbc1a1bd008 Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Tue, 5 Dec 2017 09:10:17 -0800 We haven't yet figured out what to do with RT threads on cgroup2. Document the limitation. v2: Included the warning about system management software behavior as sugges

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > DB interface of ntb_tool driver hasn't been changed much, but > db_valid_mask DebugFS file has still been added to new ntb_tool > driver. In this case it's much better to test all valid DB bits > instead of using the predefined mask, which may b

[PATCH v2] pata_pdc2027x: Fix coding sytle errors

2017-12-05 Thread Arvind Yadav
Fix these checkpatch.pl errors: Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. ERROR: space prohibited after that '~' (ctx:WxW) + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); ERROR: spaces required around that '?' (ctx:VxW) + long pout_required = bo

Re: [PATCH v2 09/15] NTB: ntb_test: Update ntb_tool link tests

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > Link Up and Down methods are used to change NTB link settings on > local side only for multi-port devices. Link is considered up > only if both sides local and peer set it up. Intel/AMD hardware > acts a bit different by assigning the Primary an

Re: [PATCH v2 07/15] NTB: ntb_test: Safely use paths with whitespace

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > If some of the variables like LOC/REM or LOCAL_*/REMOTE_* got > whitespaces, the script may fail with syntax error. > > Signed-off-by: Serge Semin > Acked-by: Logan Gunthorpe > Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB

Re: [PATCH cgroup/for-4.15-fixes] cgroup: add warning about RT not being supported on cgroup2

2017-12-05 Thread Michael Kerrisk (man-pages)
Hello Tejun, On 5 December 2017 at 18:13, Tejun Heo wrote: > From: Tejun Heo > Date: Tue, 5 Dec 2017 09:10:17 -0800 > > We haven't yet figured out what to do with RT threads on cgroup2. > Document the limitation. > > Signed-off-by: Tejun Heo > Reported-by: "Michael Kerrisk (man-pages)" > --- >

Re: [PATCH 08/45] drivers: input: remove duplicate includes

2017-12-05 Thread Dmitry Torokhov
On Tue, Dec 05, 2017 at 09:15:55AM +0100, Benjamin Tissoires wrote: > Hi, > > [adding Jiri, the HID maintainer in CC] > > On Tue, Dec 5, 2017 at 3:01 AM, Pravin Shedge > wrote: > > These duplicate includes have been found with scripts/checkincludes.pl but > > they have been removed manually to a

Re: [PATCH v2 06/15] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > NTB API has been updated to support multi-port devices like IDT > 89HPESx series or Microsemi Switchtec. Message registers > functionality has also been added to new API. In order to keep > the new hardware and corresponding capabilities well te

Re: [PATCH] driver-core: platform: Avoid to return IRQ 0 in platform_get_irq()

2017-12-05 Thread Dmitry Torokhov
On Tue, Dec 05, 2017 at 11:41:52PM +0530, Arvind Yadav wrote: > Function platform_get_irq() can return 0. Which means NO_IRQ. > So this change will not allow to return 0. > > This change is help to use platform_get_irq() without this, > > val = platform_get_irq(); > if (val <= 0) >

[RFC PATCH 3/3] ASoC: Platforms: Move OMAP platform drivers into platforms directory

2017-12-05 Thread Andrew F. Davis
Split the OMAP platform drivers from the machine drivers that use these platform drivers by moving them into the new platforms directory. Signed-off-by: Andrew F. Davis --- MAINTAINERS | 1 + sound/soc/omap/Kconfig | 29

[RFC PATCH 2/3] ASoC: Platforms: Move Davinci platform drivers into platforms directory

2017-12-05 Thread Andrew F. Davis
Split the Davinci platform drivers from the machine drivers that use these platform drivers by moving them into the new platforms directory. Signed-off-by: Andrew F. Davis --- sound/soc/davinci/Kconfig | 37 --- sound/soc/davinci/Makefile

Re: [PATCH v2] efi: move some sysfs files to be read-only by root

2017-12-05 Thread Ard Biesheuvel
On 5 December 2017 at 10:41, Greg Kroah-Hartman wrote: > Thanks to the scripts/leaking_addresses.pl script, it was found that > some EFI values should not be readable by non-root users. > > So make them root-only, and to do that, add a __ATTR_RO_MODE() macro to > make this easier, and use it in ot

Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption

2017-12-05 Thread Heiko Carstens
On Tue, Dec 05, 2017 at 06:08:47PM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 05, 2017 at 05:02:32PM +, Ben Hutchings wrote: > > On Tue, 2017-11-28 at 11:22 +0100, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch.  If anyone has any objections, please let me > > > know. > > > > > >

Re: [tip:x86/mpx] x86/insn-eval: Add utility function to get segment descriptor

2017-12-05 Thread Borislav Petkov
On Tue, Dec 05, 2017 at 06:48:44PM +0100, Peter Zijlstra wrote: > This is broken right? You unlock and then return @desc, which afaict can > at that point get freed by free_ldt_struct(). > > Something like the below ought to cure; although its not entirely > pretty either. Right. Or, instead of

[RFC PATCH 0/3] Add ASoC platforms directory

2017-12-05 Thread Andrew F. Davis
Hello all, The first patch, I think, sums up well what I'm trying to do here with this series. The last two are a couple examples of what the moving would look like. The very end result would look something like: soc/ |_codecs/ |_codecs*.c |_platforms/ |_adi/ |_adi_i2s.c |_... |_am

[RFC PATCH 1/3] ASoC: Add platforms directory

2017-12-05 Thread Andrew F. Davis
Platform ASoC drivers are a lot like ASoC CODEC drivers in that they both are independent pieces of a sound device, or "machine". Platform drivers should be free of CODEC specifics and visa-versa. Both are then used by the the "machine" driver to form the complete sound device. This forms a hierarc

RE: [PATCH v4 0/5] ARM: ep93xx: ts72xx: Add support for BK3 board

2017-12-05 Thread Hartley Sweeten
On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote: > > This patch series adds support for Liebherr's BK3 board, being a derivative > of TS72XX design. > > This patchset consists of following patches: > > - ts72xx.[c|h] cosmetic cleanup/improvement > - Rewrite ts72xx.c to be reusable by

[PATCH] driver-core: platform: Avoid to return IRQ 0 in platform_get_irq()

2017-12-05 Thread Arvind Yadav
Function platform_get_irq() can return 0. Which means NO_IRQ. So this change will not allow to return 0. This change is help to use platform_get_irq() without this, val = platform_get_irq(); if (val <= 0) ret = val ? val : -ENODEV; Signed-off-by: Arvind Yadav ---

Re: [LTP] 3239b6f29b ("KEYS: return full count in keyring_read() if buffer is too small"): ltp.keyctl06.fail

2017-12-05 Thread Eric Biggers
On Tue, Dec 05, 2017 at 10:43:08AM +0100, Richard Palethorpe wrote: > > We are getting the following result, even with the follow up patch: > > keyctl06.c:68: FAIL: KEYCTL_READ returned 4 but expected 8 > > This is with SUSE SLE15 kernel 4.12.14. I haven't had chance to > investigate it yet. >

Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Jon Mason
On Tue, Dec 5, 2017 at 12:56 PM, Serge Semin wrote: > On Tue, Dec 05, 2017 at 11:52:32AM -0500, Jon Mason wrote: >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: >> > Simple (1 << pidx) operation causes undefined behaviour when >> > pidx >= 32. It must be casted to u64 to match the actual r

Re: efi/esrt: use memunmap rather kfree to free the remapping

2017-12-05 Thread Ard Biesheuvel
On 29 October 2017 at 14:51, Pan Bian wrote: > The remapping result of memremap should be freed with memunmap, not > kfree. > > Signed-off-by: Pan Bian > --- > drivers/firmware/efi/esrt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/esrt.c b/drive

Re: [PATCH net-next v3 2/4] phylib: add reset after clk enable support

2017-12-05 Thread Richard Leitner
Hi Andrew, On 12/05/2017 06:34 PM, Andrew Lunn wrote: On Tue, Dec 05, 2017 at 02:25:58PM +0100, Richard Leitner wrote: From: Richard Leitner Some PHYs need the refclk to be a continuous clock. Therefore they don't allow turning it off and on again during operation. Nonetheless such a clock sw

Re: [linux-next][41e83b9][gcc 4.8.5] make modules fail at net/netfilter/xt_bpf.ko

2017-12-05 Thread Al Viro
On Tue, Dec 05, 2017 at 08:13:11PM +0530, Abdul Haleem wrote: > Hi Al Viro, > > Today's next kernel build failed with commit 41e83b9: fix "netfilter: > xt_bpf: Fix XT_BPF_MODE_FD_PINNED > > Machine Type: Power 7 > kernel version: 4.15.0-rc2-next-20171204 > kernel config: attached > test: 'make mo

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Jon Mason
On Tue, Dec 5, 2017 at 12:31 PM, Serge Semin wrote: > On Tue, Dec 05, 2017 at 11:49:10AM -0500, Jon Mason wrote: >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: >> > There is a common methods signature form used over all the NTB API >> > like functions naming scheme, arguments names and or

Re: [v2] mfd: stm32: Adopt SPDX identifier

2017-12-05 Thread Guenter Roeck
On Tue, Dec 05, 2017 at 06:28:11PM +0100, Greg KH wrote: > On Tue, Dec 05, 2017 at 09:23:37AM -0800, Guenter Roeck wrote: > > On Tue, Dec 05, 2017 at 04:24:18PM +0100, benjamin.gaign...@linaro.org > > wrote: > > > Add SPDX identifier > > > > > > Signed-off-by: Benjamin Gaignard > > > --- > > >

Re: [PATCH net-next v3 1/4] phylib: Add device reset delay support

2017-12-05 Thread Richard Leitner
Hi Andrew, On 12/05/2017 06:28 PM, Andrew Lunn wrote: Hi Richard +++ b/drivers/of/of_mdio.c @@ -77,6 +77,14 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, if (of_property_read_bool(child, "broken-turn-around")) mdio->phy_ignore_ta_mask |= 1 << addr; + if

Re: [PATCH 2/3] crypto: exynos - Improve performance of PRNG

2017-12-05 Thread Krzysztof Kozlowski
On Tue, Dec 5, 2017 at 6:53 PM, Krzysztof Kozlowski wrote: > On Tue, Dec 05, 2017 at 05:43:10PM +0100, Łukasz Stelmach wrote: >> It was <2017-12-05 wto 14:54>, when Stephan Mueller wrote: >> > Am Dienstag, 5. Dezember 2017, 13:35:57 CET schrieb Łukasz Stelmach: >> > >> > Hi Łukasz, >> > >> >> Use

Re: [RFC PATCH] net: stmmac: enable EEE in MII, GMII or RGMII only

2017-12-05 Thread Andrew Lunn
> bool stmmac_eee_init(struct stmmac_priv *priv) > { > struct net_device *ndev = priv->dev; > + int interface = priv->plat->interface; > unsigned long flags; > bool ret = false; > > + if ((interface != PHY_INTERFACE_MODE_MII) && > + (interface != PHY_INTERFACE_

Re: [PATCH v2 05/15] NTB: ntb_tool: Add full multi-port NTB API support

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > NTB API has been updated to support multi-port devices like IDT > 89HPESx series or Microsemi Switchtec. Message registers > functionality has also been added to new API. In order to keep > the new hardware and corresponding capabilities well te

Re: [PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Andrew Lunn
On Tue, Dec 05, 2017 at 10:33:34AM +0100, Jerome Brunet wrote: > From: Neil Armstrong > > Define registers and bits in meson-gxl PHY driver to make a bit > more human friendly. No functional change > static int meson_gxl_config_init(struct phy_device *phydev) > { > - /* Enable Analog and

Re: [RFC PATCH 1/6] drm: Add Content Protection property

2017-12-05 Thread Pavel Machek
Hi! > >> > Why would user of the machine want this to be something else than > >> > 'OFF'? > >> > > >> > If kernel implements this, will it mean hardware vendors will have to > >> > prevent user from updating kernel on machines they own? > >> > > >> > If this is merged, does it open kernel develop

[PATCH] video/console/sticore: Delete an error message for a failed memory allocation in sti_try_rom_generic()

2017-12-05 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 5 Dec 2017 18:45:42 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/console/sticore.c | 4 +--- 1 file changed, 1 insertion(+

Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Serge Semin
On Tue, Dec 05, 2017 at 11:52:32AM -0500, Jon Mason wrote: > On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > > Simple (1 << pidx) operation causes undefined behaviour when > > pidx >= 32. It must be casted to u64 to match the actual return > > value of ntb_link_is_up() method, so to have all

Re: [PATCH v2 3/4] Add support for AMD Core Perf Extension in guest

2017-12-05 Thread Radim Krcmar
2017-12-01 13:30-0600, Natarajan, Janakarajan: > On 11/17/2017 5:44 AM, Borislav Petkov wrote: > > On Thu, Nov 16, 2017 at 12:00:11PM -0600, Natarajan, Janakarajan wrote: > > > Ah my apologies. So when the pmu is initialized the cpuid entries > > > aren't available then. > > So let's see: > > > >

Re: [PATCH] crypto: exynos - Icrease the priority of the driver

2017-12-05 Thread Krzysztof Kozlowski
On Tue, Dec 05, 2017 at 05:20:46PM +0100, Łukasz Stelmach wrote: > exynos-rng is one of many implementations of stdrng. With priority as > low as 100 it isn't selected, if software implementations (DRBG) are > available. The value 300 was selected to give the PRNG priority before > software impleme

<    1   2   3   4   5   6   7   8   9   10   >