Re: [PATCH] scsi: qlogicpti: Fix an error handling path in 'qpti_sbus_probe()'

2018-05-18 Thread Martin K. Petersen
Christophe, > The 'free_irq()' call is not at the right place in the error handling > path. The changed order has been introduced in commit 3d4253d9afab > ("[SCSI] qlogicpti: Convert to new SBUS device framework.") Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux En

Re: [RFC PATCH] PM / devfreq: Add policy notifier

2018-05-18 Thread Matthias Kaehlcke
On Fri, May 18, 2018 at 08:26:30AM +0900, Chanwoo Choi wrote: > Hi, > > On 2018년 05월 18일 08:07, Matthias Kaehlcke wrote: > > Hi, > > > > On Thu, May 17, 2018 at 11:01:34AM +0900, Chanwoo Choi wrote: > >> Hi, > >> > >> Could you give some use-case of DEVFREQ_POLICY_NOTIFIER > >> or send use-case p

Re: [PATCH v5 2/4] Documentation: bindings: add phy_config for Rockchip USB Type-C PHY

2018-05-18 Thread Heiko Stuebner
Am Donnerstag, 17. Mai 2018, 11:17:58 CEST schrieb Lin Huang: > If want to do training outside DP Firmware, need phy voltage swing > and pre_emphasis value. > > Signed-off-by: Lin Huang > --- > Changes in v2: > - None > Changes in v3: > - modify property description and add this property to Exam

Re: [PATCH 2/6] x86: bug: prevent gcc distortions

2018-05-18 Thread Linus Torvalds
On Fri, May 18, 2018 at 12:59 AM Peter Zijlstra wrote: > This is an awesome hack, but is there really nothing we can do to make > it more readable? Esp, that global asm doing the macro definition is a > pain to read. I actually find that macro to be *more* legible than what we do now, although I

Re: [PATCH 00/10] Misc block layer patches for bcachefs

2018-05-18 Thread Christoph Hellwig
On Fri, May 11, 2018 at 03:13:38PM -0600, Jens Axboe wrote: > Looked over the series, and looks like both good cleanups and optimizations. > If we can get the mempool patch sorted, I can apply this for 4.18. FYI, I agree on the actual cleanups and optimization, but we really shouldn't add new func

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-18 Thread Randy Dunlap
On 05/17/2018 11:09 PM, Ian Kent wrote: > On 18/05/18 12:38, Ian Kent wrote: >> On 18/05/18 12:23, Randy Dunlap wrote: >>> On 05/17/2018 08:50 PM, Ian Kent wrote: On 18/05/18 08:21, Randy Dunlap wrote: > On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >> The mm-of-the-moment s

[PATCH] tc-testing: flush gact actions on test teardown

2018-05-18 Thread Vlad Buslov
Test 6fb4 creates one mirred and one pipe action, but only flushes mirred on teardown. Leaking pipe action causes failures in other tests. Add additional teardown command to also flush gact actions. Signed-off-by: Vlad Buslov --- tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json |

Re: [PATCH 02/10] block: Convert bio_set to mempool_init()

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 09:20:28AM -0700, Christoph Hellwig wrote: > On Tue, May 08, 2018 at 09:33:50PM -0400, Kent Overstreet wrote: > > Minor performance improvement by getting rid of pointer indirections > > from allocation/freeing fastpaths. > > Can you please also send a long conversion for t

Re: [PATCH 02/10] block: Convert bio_set to mempool_init()

2018-05-18 Thread Christoph Hellwig
On Tue, May 08, 2018 at 09:33:50PM -0400, Kent Overstreet wrote: > Minor performance improvement by getting rid of pointer indirections > from allocation/freeing fastpaths. Can you please also send a long conversion for the remaining few bioset_create users? It would be rather silly to keep two a

Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly inside the mkbp event > ins

Re: [PATCH] scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 04:23:18PM +0200, Alexander Potapenko wrote: > This shall help avoid copying uninitialized memory to the userspace > when calling ioctl(fd, SG_IO) with an empty command. Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH net v2] net: dsa: Do not register devlink for unused ports

2018-05-18 Thread David Miller
From: Florian Fainelli Date: Thu, 17 May 2018 16:55:39 -0700 > Even if commit 1d27732f411d ("net: dsa: setup and teardown ports") indicated > that registering a devlink instance for unused ports is not a problem, and > this > is true, this can be confusing nonetheless, so let's not do it. > > F

Re: [PATCH] objtool: Detect assembly code falling through to INT3 padding

2018-05-18 Thread Borislav Petkov
On Fri, May 18, 2018 at 12:27:15AM -0700, H. Peter Anvin wrote: > On 05/18/18 00:18, Ingo Molnar wrote: > > > > Ok, this is cool, it addresses the robustness problem that INT3 padding > > introduced > > very nicely. > > > > The concept of built-in kernel tooling working at the machine code leve

Re: [PATCH v2] usbip: vhci_sysfs: fix potential Spectre v1

2018-05-18 Thread Shuah Khan
On 05/18/2018 07:47 AM, Greg Kroah-Hartman wrote: > On Thu, May 17, 2018 at 03:16:28PM -0500, Gustavo A. R. Silva wrote: >> pdev_nr and rhport can be controlled by user-space, hence leading to >> a potential exploitation of the Spectre variant 1 vulnerability. >> >> This issue was detected with the

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Christoph Hellwig
Looks fine, although I'd split it into a aio and block_dev patch. Also please wire this up for the fs/iomap.c direct I/O code, it should be essentially the same sniplet as in the block_dev.c code.

Re: [PATCH] scsi: dpt_i2o: Remove VLA usage

2018-05-18 Thread Martin K. Petersen
Kees, >> On the quest to remove all VLAs from the kernel[1] this moves the sg_list >> variable off the stack, as already done for other allocated buffers in >> adpt_i2o_passthru(). Additionally consolidates the error path for kfree(). > > Friendly ping! How does this look for v4.18? Applied to 4

Re: [PATCH] gpu: ipu-csi: add rgb/bgr888 24bit support to mbus_code_to_bus_cfg

2018-05-18 Thread Philipp Zabel
On Wed, 2018-05-02 at 14:52 +0200, Michael Grzeschik wrote: > The 24bit RGB format configuration is currently missing, we add > it now. > > Signed-off-by: Michael Grzeschik Applied to imx-drm/next. regards Philipp

Re: [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-18 Thread Christoph Hellwig
> +/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */ I don't think this comment is very useful. > +static inline u16 ki_hint_valid(enum rw_hint hint) I'd call this ki_hint_validate. > +{ > + if (hint > MAX_KI_HINT) > + return 0; > + > + return hint; Ni

Re: [PATCH net-next 1/2] net: mscc: ocelot: add bonding support

2018-05-18 Thread Andrew Lunn
On Fri, May 18, 2018 at 08:41:05AM +0200, Alexandre Belloni wrote: > Add link aggregation hardware offload support for Ocelot. Hi Alexandre What i don't see here is anything checking the mode being requested. If the user requests 'random' but the hardware only supports 'roundrobin', you probably

Re: [PATCH v4 1/3] block: add ioprio_check_cap function

2018-05-18 Thread Christoph Hellwig
On Thu, May 17, 2018 at 01:38:01PM -0700, adam.manzana...@wdc.com wrote: > From: Adam Manzanares > > Aio per command iopriority support introduces a second interface between > userland and the kernel capable of passing iopriority. The aio interface also > needs the ability to verify that the subm

Re: [PATCH v9 07/11] arm64: kexec_file: add crash dump support

2018-05-18 Thread James Morse
Hi Akashi, On 18/05/18 11:39, AKASHI Takahiro wrote: > On Tue, May 15, 2018 at 06:11:15PM +0100, James Morse wrote: >> On 25/04/18 07:26, AKASHI Takahiro wrote: >>> Enabling crash dump (kdump) includes >>> * prepare contents of ELF header of a core dump file, /proc/vmcore, >>> using crash_prepar

Re: [PATCH 08/10] bcache: move closures to lib/

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 03:49:13AM -0400, Kent Overstreet wrote: > Prep work for bcachefs - being a fork of bcache it also uses closures Hell no. This code needs to go away and not actually be promoted to lib/.

Re: [PATCH 10/10] Dynamic fault injection

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 03:49:18AM -0400, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet Completely lacks any explanation or argument why it would be useful.

Re: KASAN: use-after-free Read in remove_wait_queue (2)

2018-05-18 Thread Guillaume Nault
On Sun, May 13, 2018 at 11:11:55PM -0700, Eric Biggers wrote: > [+ppp list and maintainer] > > This is a bug in ppp_generic.c; it still happens on Linus' tree and it's > easily > reproducible, see program below. The bug is that the PPPIOCDETACH ioctl > doesn't > consider that the file can still

Re: [PATCH v9 05/11] arm64: kexec_file: load initrd and device-tree

2018-05-18 Thread James Morse
Hi Akashi, On 18/05/18 08:42, AKASHI Takahiro wrote: > On Fri, May 18, 2018 at 04:11:35PM +0900, AKASHI Takahiro wrote: >> On Tue, May 15, 2018 at 05:20:00PM +0100, James Morse wrote: >>> On 25/04/18 07:26, AKASHI Takahiro wrote: diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arc

Re: [PATCH 06/10] Generic radix trees

2018-05-18 Thread Christoph Hellwig
Completely lacks any explanation, including why this should be in lib/. Also should come in the same series with actual users of the infrastructure.

Re: [PATCH] PCI: endpoint: Create configfs entry for each pci_epf_device_id table entry

2018-05-18 Thread Lorenzo Pieralisi
On Fri, May 18, 2018 at 08:19:20PM +0530, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On Friday 18 May 2018 07:52 PM, Lorenzo Pieralisi wrote: > > Hi Kishon, Gustavo, > > > > On Mon, Apr 02, 2018 at 06:59:35PM +0530, Kishon Vijay Abraham I wrote: > >> In order to be able to provide correct dr

Re: [PATCH 05/10] don't use spin_lock_irqsave() unnecessarily

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 03:49:08AM -0400, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet Looks generally fine. A little changelog with an explanation of how we obviously never could get here with irqs disabled would be nice, though.

Re: [PATCH] audit: add containerid support for IMA-audit

2018-05-18 Thread Richard Guy Briggs
On 2018-05-18 10:52, Stefan Berger wrote: > On 05/18/2018 10:39 AM, Mimi Zohar wrote: > > On Fri, 2018-05-18 at 09:54 -0400, Stefan Berger wrote: > > > On 05/18/2018 08:53 AM, Mimi Zohar wrote: > > [..] > > > > > > > > > If so, which ones? We could probably refactor the current > > > > > > > integ

Re: [PATCH] mm/kasan: Don't vfree() nonexistent vm_area.

2018-05-18 Thread David Hildenbrand
On 18.05.2018 17:57, David Hildenbrand wrote: > On 01.02.2018 17:33, Andrey Ryabinin wrote: >> KASAN uses different routines to map shadow for hot added memory and memory >> obtained in boot process. Attempt to offline memory onlined by normal boot >> process leads to this: >> >> Trying to vfre

Re: [PATCH 02/10] mm: export find_get_pages()

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 03:49:02AM -0400, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet > --- > mm/filemap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 31dd888785..78b99019bf 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1845,6

Re: [PATCH 6/6] arm64: perf: Add support for chaining counters

2018-05-18 Thread Suzuki K Poulose
Hi Robin, On 18/05/18 14:49, Robin Murphy wrote: On 18/05/18 11:22, Suzuki K Poulose wrote: Add support for chained event counters. PMUv3 allows chaining a pair of adjacent PMU counters (with the lower counter number being always "even"). The low counter is programmed to count the event of inte

Re: [PATCH] audit: add containerid support for IMA-audit

2018-05-18 Thread Richard Guy Briggs
On 2018-05-18 10:39, Mimi Zohar wrote: > On Fri, 2018-05-18 at 09:54 -0400, Stefan Berger wrote: > > On 05/18/2018 08:53 AM, Mimi Zohar wrote: > > [..] > > > If so, which ones? We could probably refactor the current > > integrity_audit_message() and have ima_parse_rule() call into it to

Re: [PATCH] mm/kasan: Don't vfree() nonexistent vm_area.

2018-05-18 Thread David Hildenbrand
On 01.02.2018 17:33, Andrey Ryabinin wrote: > KASAN uses different routines to map shadow for hot added memory and memory > obtained in boot process. Attempt to offline memory onlined by normal boot > process leads to this: > > Trying to vfree() nonexistent vm area (5d3b34b9) > WAR

Re: [RFC PATCH 01/11] vfs: push __sync_blockdev calls down into sync_fs routines

2018-05-18 Thread Christoph Hellwig
> --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1097,7 +1097,7 @@ xfs_fs_sync_fs( >* Doing anything during the async pass would be counterproductive. >*/ > if (!wait) > - return 0; > + goto out; > > xfs_log_force(mp, XFS_LOG_SYNC); >

Re: [PATCH 2/6] x86: bug: prevent gcc distortions

2018-05-18 Thread Borislav Petkov
On Fri, May 18, 2018 at 03:46:33PM +, Nadav Amit wrote: > In case you didn’t read the cover-letter: the patch-set does give a 2% > performance improvement for #PF-MADV_DONTNEED microbenchmark loop. I saw it but *micro*-benchmark doesn't tell me a whole lot. If that "improvement" is not visible

[PATCH] kernfs: fix dentry unexpected skip

2018-05-18 Thread Hatayama, Daisuke
kernfs_dir_next_pos() overlooks the situation that the dentry corresponding to a given pos object has already been inactive. Hence, when kernfs_dir_pos() returns the dentry with a hash value larger than the original one, kernfs_dir_next_pos() returns the dentry next to the one returned by kernfs_di

Re: [PATCH 01/10] mm: pagecache add lock

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 06:13:06AM -0700, Matthew Wilcox wrote: > > Historically, the only problematic case has been direct IO, and people > > have been willing to say "well, if you mix buffered and direct IO you > > get what you deserve", and that's probably not unreasonable. But now we > > have f

Re: [PATCH] audit: add containerid support for IMA-audit

2018-05-18 Thread Richard Guy Briggs
On 2018-05-18 08:53, Mimi Zohar wrote: > On Fri, 2018-05-18 at 07:49 -0400, Stefan Berger wrote: > > On 05/17/2018 05:30 PM, Richard Guy Briggs wrote: > > [...] > > > >>> auxiliary record either by being converted to a syscall auxiliary record > > >>> by using current->audit_context rather than N

[PATCH] kernfs: fix dentry unexpected skip

2018-05-18 Thread Hatayama, Daisuke
kernfs_dir_next_pos() overlooks the situation that the dentry corresponding to a given pos object has already been inactive. Hence, when kernfs_dir_pos() returns the dentry with a hash value larger than the original one, kernfs_dir_next_pos() returns the dentry next to the one returned by kernfs_di

Re: [PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-18 Thread Sean Paul
On Fri, May 18, 2018 at 03:05:00PM +0200, Neil Armstrong wrote: > In non device-tree world, we can need to get the notifier by the driver > name directly and eventually defer probe if not yet created. > > This patch adds a variant of the get function by using the device name > instead and will not

Re: [PATCH 2/6] x86: bug: prevent gcc distortions

2018-05-18 Thread Nadav Amit
Borislav Petkov wrote: > On Fri, May 18, 2018 at 02:36:21PM +, Nadav Amit wrote: >> I didn’t try too hard to find more affected (micro)benchmarks, but I am >> pretty sure there are: > > So you being pretty sure there are, doesn't make me go, oh, ok, then, > this is an uglification we should

Re: [PATCH] audit: add containerid support for IMA-audit

2018-05-18 Thread Richard Guy Briggs
On 2018-05-18 07:49, Stefan Berger wrote: > On 05/17/2018 05:30 PM, Richard Guy Briggs wrote: > > On 2018-05-17 10:18, Stefan Berger wrote: > > > On 03/08/2018 06:21 AM, Richard Guy Briggs wrote: > > > > On 2018-03-05 09:24, Mimi Zohar wrote: > > > > > On Mon, 2018-03-05 at 08:50 -0500, Richard Guy

[PATCH] net: sched: don't disable bh when accessing action idr

2018-05-18 Thread Vlad Buslov
Underlying implementation of action map has changed and doesn't require disabling bh anymore. Replace all action idr spinlock usage with regular calls that do not disable bh. Signed-off-by: Vlad Buslov --- net/sched/act_api.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deleti

Re: WARNING in ip_recv_error

2018-05-18 Thread David Miller
From: Eric Dumazet Date: Fri, 18 May 2018 08:30:43 -0700 > We probably need to revert Willem patch > (7ce875e5ecb8562fd44040f69bda96c999e38bbc) Is it really valid to reach ip_recv_err with an ipv6 socket?

Re: [PATCH v3] sched/fair: update scale invariance of PELT

2018-05-18 Thread Vincent Guittot
On 18 May 2018 at 17:16, Dietmar Eggemann wrote: > On 05/18/2018 10:36 AM, Peter Zijlstra wrote: >> >> >> Replying to the latest version available; given the current interest I >> figure I'd re-read some of the old threads and look at this stuff again. >> >> On Fri, Apr 28, 2017 at 04:23:55PM +020

Re: [PATCH 2/6] x86: bug: prevent gcc distortions

2018-05-18 Thread Borislav Petkov
On Fri, May 18, 2018 at 02:36:21PM +, Nadav Amit wrote: > I didn’t try too hard to find more affected (micro)benchmarks, but I am > pretty sure there are: So you being pretty sure there are, doesn't make me go, oh, ok, then, this is an uglification we should try to live with. It is still ugly

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-05-18 Thread Steve Grubb
On Fri, 18 May 2018 11:21:06 -0400 Richard Guy Briggs wrote: > On 2018-05-18 09:56, Steve Grubb wrote: > > On Thu, 17 May 2018 17:56:00 -0400 > > Richard Guy Briggs wrote: > > > > > > During syscall events, the path info is returned in a a record > > > > simply called AUDIT_PATH, cwd info is

Re: [PATCH v5 4/4] drm/rockchip: support dp training outside dp firmware

2018-05-18 Thread Sean Paul
On Fri, May 18, 2018 at 10:52:17AM +0200, Heiko Stuebner wrote: > Am Freitag, 18. Mai 2018, 03:45:46 CEST schrieb Brian Norris: > > On Thu, May 17, 2018 at 6:41 PM, hl wrote: > > > On Thursday, May 17, 2018 09:51 PM, Sean Paul wrote: > > >> On Thu, May 17, 2018 at 05:18:00PM +0800, Lin Huang wrote

Re: [PATCH v10 25/27] ARM: davinci: add device tree support to timer

2018-05-18 Thread David Lechner
On 05/18/2018 01:05 AM, Sekhar Nori wrote: On Thursday 17 May 2018 08:39 PM, David Lechner wrote: On 05/17/2018 09:35 AM, Sekhar Nori wrote: Hi David, On Wednesday 09 May 2018 10:56 PM, David Lechner wrote: This adds device tree support to the davinci timer so that when clocks are moved to de

Re: [PATCH v9 07/11] arm64: kexec_file: add crash dump support

2018-05-18 Thread Rob Herring
On Tue, May 15, 2018 at 06:12:59PM +0100, James Morse wrote: > Hi guys, > > (CC: +RobH, devicetree list) Thanks. > On 25/04/18 07:26, AKASHI Takahiro wrote: > > Enabling crash dump (kdump) includes > > * prepare contents of ELF header of a core dump file, /proc/vmcore, > > using crash_prepare_

Re: [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents

2018-05-18 Thread Jernej Škrabec
Hi, Dne petek, 18. maj 2018 ob 17:26:51 CEST je Maxime Ripard napisal(a): > On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej Škrabec wrote: > > > And this is a bit sloppy, since if phy_clk_num == 3, you won't try to > > > lookup pll-2 either. > > > > It is highly unlikely this will be higher than

Re: [PATCH 2/2] kselftests: ftrace: Add tests for the preemptoff and irqsoff tracers

2018-05-18 Thread Masami Hiramatsu
Hi Joel, 55ty jmnOn Thu, 17 May 2018 18:54:21 -0700 "Joel Fernandes (Google)" wrote: > Here we add unit tests for the preemptoff and irqsoff tracer by using a > kernel module introduced previously to trigger atomic sections in the > kernel. > > Cc: Steven Rostedt > Cc: Peter Zilstra > Cc: Ing

Re: WARNING in ip_recv_error

2018-05-18 Thread Eric Dumazet
On 05/18/2018 05:08 AM, DaeRyong Jeong wrote: > We report the crash: WARNING in ip_recv_error > (I resend the email since I mistakenly missed the subject in my previous > email. I'm sorry.) > > > This crash has been found in v4.17-rc1 using RaceFuzzer (a modified > version of Syzkaller), which

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

2018-05-18 Thread David Miller
From: Alexandre Belloni Date: Thu, 17 May 2018 21:23:05 +0200 > ocelot_qsys.h is missing the SPDX identfier, fix that. > > Signed-off-by: Alexandre Belloni Applied, thank you.

Re: [PATCH v2 3/9] security: define security_kernel_read_blob() wrapper

2018-05-18 Thread Mimi Zohar
On Fri, 2018-05-18 at 07:58 -0700, Casey Schaufler wrote: > On 5/18/2018 4:30 AM, Mimi Zohar wrote: > > Having to define a separate LSM hook for each of the original, non > > kernel_read_file(), buffer based method callers, kind of makes sense, > > as the callers themselves are specific, but is it

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Adam Manzanares
On 5/18/18 8:14 AM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the >> newly added kiocb ki_ioprio f

Re: [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents

2018-05-18 Thread Maxime Ripard
On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej Škrabec wrote: > > And this is a bit sloppy, since if phy_clk_num == 3, you won't try to > > lookup pll-2 either. > > It is highly unlikely this will be higher than 2, at least for this HDMI PHY, > since it has only 1 bit reserved for parent select

[PATCH 1/2] mfd: stm32-timers: fix pwm-stm32 linker issue with COMPILE_TEST

2018-05-18 Thread Fabrice Gasnier
This is seen when COMPILE_TEST=y and MFD_STM32_TIMERS=n. drivers/pwm/pwm-stm32.o: In function 'stm32_pwm_raw_capture': pwm-stm32.c:... undefined reference to 'stm32_timers_dma_burst_read' Fixes: 0c6609805b63 ("mfd: stm32-timers: Add support for DMAs") Signed-off-by: Fabrice Gasnier --- include/l

Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"

2018-05-18 Thread David Miller
From: Jes Sorensen Date: Fri, 18 May 2018 10:33:50 -0400 > I do wonder if it's time to retire this driver and the HIPPI code. I > haven't had access to hardware for over a decade so I have no idea > if it even works anymore. That's a good question. If you really think nobody is using this stuff

[PATCH 0/2] Fix STM32 PWM capture build with COMPILE_TEST

2018-05-18 Thread Fabrice Gasnier
Build issue has been identified when COMPILE_TEST=y and MFD_STM32_TIMERS=n: https://lkml.org/lkml/2018/5/17/825 - First patch introduces a stub routine in mfd header file - Sub-sequent patch solves warning in pwm-stm32 with these configs Fabrice Gasnier (2): mfd: stm32-timers: fix pwm-stm32 link

Re: [PATCH v3 0/3] Fix UFS and devfreq interaction

2018-05-18 Thread Martin K. Petersen
Bjorn, > With the introduction of f1d981eaecf8 ("PM / devfreq: Use the > available min/max frequency") the UFS host controller driver (UFSHCD) > stopped probing for platforms that supports frequency scaling, > e.g. all modern Qualcomm platforms. Applied to 4.18/scsi-queue. Thank you! -- Martin

[PATCH 2/2] pwm: stm32: initialize raw local variables

2018-05-18 Thread Fabrice Gasnier
This removes build warning when COMPILE_TEST=y and MFD_STM32_TIMERS=n in drivers/pwm/pwm-stm32.c. In function 'stm32_pwm_capture' 'raw_prd' and 'raw_dty' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Fabrice Gasnier --- drivers/pwm/pwm-stm32.c | 2 +- 1 file c

Re: [PATCH 1/1] scsi: storvsc: Avoid allocating memory for temp cpumasks

2018-05-18 Thread Martin K. Petersen
Michael, > Current code allocates 240 Kbytes (in typical configs) for each > synthetic SCSI controller to use as temp cpumask variables. Recode to > avoid needing the temp cpumask variables and remove the memory > allocation. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Orac

[PATCH v2 2/2] iio:dac:ad5686: Add AD5681R/AD5682R/AD5683/AD5683R support

2018-05-18 Thread Stefan Popa
The AD5681R/AD5682R/AD5683/AD5683R are a family of one channel DACs with 12-bit, 14-bit and 16-bit precision respectively. The devices have either no built-in reference, or built-in 2.5V reference. These devices are similar to AD5691R/AD5692R/AD5693/AD5693R except with a few notable differences:

Re: [RFC PATCH 07/11] ext4: have sync_fs op report writeback errors when passed a since pointer

2018-05-18 Thread Matthew Wilcox
On Fri, May 18, 2018 at 08:34:11AM -0400, Jeff Layton wrote: > From: Jeff Layton > > When ext4_sync_fs gets a non-NULL since pointer, use it to report > errors vs. the errseq_t in the super_block. This allows us to > properly report an error to sync_fs when any inode has failed writeback > since

[PATCH v2 1/2] iio:dac:ad5686: Add AD5691R/AD5692R/AD5693/AD5693R support

2018-05-18 Thread Stefan Popa
The AD5691R/AD5692R/AD5693/AD5693R are a family of one channel DACs with 12-bit, 14-bit and 16-bit precision respectively. The devices have either no built-in reference, or built-in 2.5V reference. These devices are pretty similar to AD5671R/AD5675R and AD5694/AD5694R/AD5695R/AD5696/AD5696R, excep

Re: [PATCH 0/6] hisi_sas: improve DQ locking

2018-05-18 Thread Martin K. Petersen
John, > This patchset introduces some patches to much improve DQ lockout for > sending commands to the HW. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH] arm64: dts: specify 1.8V EMMC capabilities for bcm958742k

2018-05-18 Thread Scott Branden
Specify 1.8V EMMC capabilities for bcm958742k board to indicate support for UHS mode. Fixes: d4b4aba6be8a ("arm64: dts: Initial DTS files for Broadcom Stingray SOC") Signed-off-by: Scott Branden --- arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dts | 4 1 file changed, 4 insertions(+) d

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-05-18 Thread Richard Guy Briggs
On 2018-05-18 09:56, Steve Grubb wrote: > On Thu, 17 May 2018 17:56:00 -0400 > Richard Guy Briggs wrote: > > > > During syscall events, the path info is returned in a a record > > > simply called AUDIT_PATH, cwd info is returned in AUDIT_CWD. So, > > > rather than calling the record that gets att

Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-18 Thread Tycho Andersen
On Fri, May 18, 2018 at 04:04:16PM +0200, Christian Brauner wrote: > On Thu, May 17, 2018 at 09:12:15AM -0600, Tycho Andersen wrote: > > +#ifdef CONFIG_SECCOMP_USER_NOTIFICATION > > +static u64 seccomp_next_notify_id(struct seccomp_filter *filter) > > +{ > > + u64 ret = filter->next_id; > > + > >

Re: [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents

2018-05-18 Thread Sergey Suloev
Hi, Jernej, On 05/18/2018 06:15 PM, Jernej Škrabec wrote: Hi, Dne petek, 18. maj 2018 ob 17:09:40 CEST je Sergey Suloev napisal(a): Hi, guys, On 05/18/2018 05:46 PM, Jernej Škrabec wrote: Hi, Dne petek, 18. maj 2018 ob 12:01:16 CEST je Maxime Ripard napisal(a): On Fri, May 18, 2018 at 03:1

Re: [PATCH v2 5/5] powerpc/lib: inline memcmp() for small constant sizes

2018-05-18 Thread Segher Boessenkool
On Fri, May 18, 2018 at 12:35:48PM +0200, Christophe Leroy wrote: > On 05/17/2018 03:55 PM, Segher Boessenkool wrote: > >On Thu, May 17, 2018 at 12:49:58PM +0200, Christophe Leroy wrote: > >>In my 8xx configuration, I get 208 calls to memcmp() > >Could you show results with a more recent GCC? What

Re: [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-05-18 Thread Gary R Hook
On 05/15/2018 08:46 AM, Joerg Roedel wrote: On Mon, May 14, 2018 at 03:00:50PM -0500, Gary R Hook wrote: This was brought up a few weeks ago in, I believe, version 3 of this patch. That question was discussed (because that's what I did the first time out), and _someone_ _else_ asked about why I

[PATCH v8 1/3] drm: Add writeback connector type

2018-05-18 Thread Liviu Dudau
From: Brian Starkey Writeback connectors represent writeback engines which can write the CRTC output to a memory framebuffer. Add a writeback connector type and related support functions. Drivers should initialize a writeback connector with drm_writeback_connector_init() which takes care of sett

[PATCH] powerpc/32: Implement csum_ipv6_magic in assembly

2018-05-18 Thread Christophe Leroy
The generic csum_ipv6_magic() generates a pretty bad result : 0: 81 23 00 00 lwz r9,0(r3) 4: 81 03 00 04 lwz r8,4(r3) 8: 7c e7 4a 14 add r7,r7,r9 c: 7d 29 38 10 subfc r9,r9,r7 10: 7d 4a 51 10 subfe r10,r10,r10 14: 7d 27 42 14

[PATCH v8 3/3] drm: writeback: Add client capability for exposing writeback connectors

2018-05-18 Thread Liviu Dudau
Due to the fact that writeback connectors behave in a special way in DRM (they always report being disconnected) we might confuse some userspace. Add a client capability for writeback connectors that will filter them out for clients that don't understand the capability. Re-requested-by: Sean Paul

[PATCH v8 0/3] drm: Introduce writeback connectors

2018-05-18 Thread Liviu Dudau
Hi, This is v8 of the writeback connector series. v7 got flagged by the kbuild bot as not being correctly bisectable, so I went and fix that. For anyone that wants a refresh on what changed in v6, the series can be found here [2]. The only change in v7 is that the userspace capabilities patch doe

[PATCH v8 2/3] drm: writeback: Add out-fences for writeback connectors

2018-05-18 Thread Liviu Dudau
From: Brian Starkey Add the WRITEBACK_OUT_FENCE_PTR property to writeback connectors, to enable userspace to get a fence which will signal once the writeback is complete. It is not allowed to request an out-fence without a framebuffer attached to the connector. A timeline is added to drm_writeba

Re: [PATCH v3] sched/fair: update scale invariance of PELT

2018-05-18 Thread Dietmar Eggemann
On 05/18/2018 10:36 AM, Peter Zijlstra wrote: Replying to the latest version available; given the current interest I figure I'd re-read some of the old threads and look at this stuff again. On Fri, Apr 28, 2017 at 04:23:55PM +0200, Vincent Guittot wrote: [...] What happened to the proposed

Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9360/9370

2018-05-18 Thread Greg Kroah-Hartman
On Fri, May 18, 2018 at 06:08:24PM +0300, Heikki Krogerus wrote: > > Rafael, the problem here with these Dell laptops is that a memory page > that is used as a mailbox for special communication between EC FW and > OS (called UCSI mailbox) should be in uncached memory, but the memory > is marked as

Re: [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents

2018-05-18 Thread Jernej Škrabec
Hi, Dne petek, 18. maj 2018 ob 17:09:40 CEST je Sergey Suloev napisal(a): > Hi, guys, > > On 05/18/2018 05:46 PM, Jernej Škrabec wrote: > > Hi, > > > > Dne petek, 18. maj 2018 ob 12:01:16 CEST je Maxime Ripard napisal(a): > >> On Fri, May 18, 2018 at 03:15:22PM +0530, Jagan Teki wrote: > >>> Fro

Re: [PATCH v2 08/29] venus: hfi_venus: fix suspend function for venus 3xx versions

2018-05-18 Thread Tomasz Figa
On Tue, May 15, 2018 at 5:11 PM Stanimir Varbanov < stanimir.varba...@linaro.org> wrote: > This fixes the suspend function for Venus 3xx versions by > add a check for WFI (wait for interrupt) bit. This bit > is on when the ARM9 is idle and entered in low power mode. > Signed-off-by: Stanimir Varb

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Jens Axboe
On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: > From: Adam Manzanares > > This is the per-I/O equivalent of the ioprio_set system call. > > When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the > newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio fiel

Re: [PATCH 1/5] dt-bindings: pinctrl: document the STMFX pinctrl bindings

2018-05-18 Thread Amelie DELAUNAY
On 05/18/2018 03:52 PM, Lee Jones wrote: > On Fri, 18 May 2018, Amelie DELAUNAY wrote: > >> On 05/17/2018 08:36 AM, Lee Jones wrote: >>> On Wed, 16 May 2018, Amelie DELAUNAY wrote: >>> On 05/16/2018 04:20 PM, Linus Walleij wrote: > On Wed, May 9, 2018 at 9:56 AM, Amelie DELAUNAY

Re: [PATCH 00/10] Misc block layer patches for bcachefs

2018-05-18 Thread Bart Van Assche
On Fri, 2018-05-18 at 05:06 -0400, Kent Overstreet wrote: > On Thu, May 17, 2018 at 08:54:57PM +, Bart Van Assche wrote: > > With Jens' latest for-next branch I hit the kernel warning shown below. Can > > you have a look? > > Any hints on how to reproduce it? Sure. This is how I triggered it:

Re: [PATCH v3 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-18 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Friday, 18 May 2018 17:47:58 EEST Jacopo Mondi wrote: > Describe HDMI input connector and ADV7612 HDMI decoder installed on > R-Car Gen3 Draak board. > > The video signal routing to the HDMI decoder to the video input interface > VIN4 is multiplexed with CV

Re: [PATCH] scsi: dpt_i2o: Remove VLA usage

2018-05-18 Thread Kees Cook
On Wed, May 2, 2018 at 3:21 PM, Kees Cook wrote: > On the quest to remove all VLAs from the kernel[1] this moves the sg_list > variable off the stack, as already done for other allocated buffers in > adpt_i2o_passthru(). Additionally consolidates the error path for kfree(). > > [1] > https://lkml

Re: [PATCH v3 2/3] arm64: dts: renesas: draak: Describe CVBS input

2018-05-18 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Friday, 18 May 2018 17:47:57 EEST Jacopo Mondi wrote: > Describe CVBS video input through analog video decoder ADV7180 > connected to video input interface VIN4. > > The video input signal path is shared with HDMI video input, and > selected by on-board swi

Re: [PATCH v6 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-18 Thread Rob Herring
On Tue, May 15, 2018 at 10:43:51AM -0500, Dan Murphy wrote: > Introduce the device tree bindings for the lm3601x > family of LED torch, flash and IR drivers. > > Signed-off-by: Dan Murphy > --- > > v6 - Removed multiple led child nodes, fixed example to display micro ranges > for corresponding c

Re: [PATCH v2 3/4] seccomp: add a way to get a listener fd from ptrace

2018-05-18 Thread Tycho Andersen
On Fri, May 18, 2018 at 04:05:56PM +0200, Christian Brauner wrote: > On Thu, May 17, 2018 at 09:12:17AM -0600, Tycho Andersen wrote: > > As an alternative to SECCOMP_FILTER_FLAG_GET_LISTENER, perhaps a ptrace() > > version which can acquire filters is useful. There are at least two reasons > > this

Re: [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents

2018-05-18 Thread Sergey Suloev
Hi, guys, On 05/18/2018 05:46 PM, Jernej Škrabec wrote: Hi, Dne petek, 18. maj 2018 ob 12:01:16 CEST je Maxime Ripard napisal(a): On Fri, May 18, 2018 at 03:15:22PM +0530, Jagan Teki wrote: From: Jernej Skrabec Some SoCs with DW HDMI have multiple possible clock parents, like A64 and R40.

Re: [PATCH v2 02/26] sysfs: export sysfs_remove_file_self()

2018-05-18 Thread Tejun Heo
On Fri, May 18, 2018 at 03:03:49PM +0200, Roman Pen wrote: > Function is going to be used in transport over RDMA module > in subsequent patches. > > Signed-off-by: Roman Pen > Cc: Tejun Heo > Cc: linux-kernel@vger.kernel.org Acked-by: Tejun Heo Please feel free to apply with other patches. T

[GIT PULL] USB driver fixes for 4.17-rc6

2018-05-18 Thread Greg KH
The following changes since commit 75bc37fefc4471e718ba8e651aa74673d4e0a9eb: Linux 4.17-rc4 (2018-05-06 16:57:38 -1000) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.17-rc6 for you to fetch changes up to c171654caa875919be3

Re: [PATCH v2 0/2] ti-cpufreq: minor fixes/cleanups

2018-05-18 Thread Suman Anna
On 04/02/2018 11:49 AM, Suman Anna wrote: > Hi Viresh, > > Please find the updated series replacing the previous patch [1] fixing > couple of issues in the TI CPUFreq driver. I have split up the patches > as per your comments on v1. Final code diff remains the same as before. > > regards > Suman

Re: [PATCH v4 0/3] AIO add per-command iopriority

2018-05-18 Thread Adam Manzanares
On 5/17/18 7:41 PM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> See the following link for performance implications on a SATA HDD: >> https://lkml.org/lkml/2016/12/6/495 >>

Re: [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the A minor nit, there is a "consensus" on tell cros-ec as "ChromeOS Embedded Controller" or "ChromeOS EC". Yes, I know that you can see in the kernel many other ways to r

Re: [PATCH] ocfs2: drop a VLA in ocfs2_orphan_del()

2018-05-18 Thread Kees Cook
On Tue, Mar 13, 2018 at 12:51 PM, Salvatore Mesoraca wrote: > Avoid a VLA[1] by using a real constant expression instead of a variable. > The compiler should be able to optimize the original code and avoid using > an actual VLA. Anyway this change is useful because it will avoid a false > positive

Re: [PATCH v2 3/9] security: define security_kernel_read_blob() wrapper

2018-05-18 Thread Casey Schaufler
On 5/18/2018 4:30 AM, Mimi Zohar wrote: > On Thu, 2018-05-17 at 22:37 -0500, Eric W. Biederman wrote: >> Casey Schaufler writes: >> >>> On 5/17/2018 7:48 AM, Mimi Zohar wrote: In order for LSMs and IMA-appraisal to differentiate between the original and new syscalls (eg. kexec, kernel mo

Re: [PATCH 6/6] arm64: perf: Add support for chaining counters

2018-05-18 Thread Robin Murphy
One more thing now that I've actually looked at the Arm ARM... On 18/05/18 11:22, Suzuki K Poulose wrote: [...] +static inline void armv8pmu_write_event_type(struct perf_event *event) +{ + struct hw_perf_event *hwc = &event->hw; + int idx = hwc->idx; + + /* +* For chain

<    1   2   3   4   5   6   7   8   9   10   >