[PATCH 1/6] ipc: reorganize initialization of kern_ipc_perm.id

2018-07-04 Thread Manfred Spraul
ipc_addid() initializes kern_ipc_perm.id after having called ipc_idr_alloc(). Thus a parallel semop() or msgrcv() that uses ipc_obtain_object_idr() may see an uninitialized value. The patch moves all accesses to kern_ipc_perm.id under the spin_lock(). The issues is related to the finding of

[PATCH 1/6] ipc: reorganize initialization of kern_ipc_perm.id

2018-07-04 Thread Manfred Spraul
ipc_addid() initializes kern_ipc_perm.id after having called ipc_idr_alloc(). Thus a parallel semop() or msgrcv() that uses ipc_obtain_object_idr() may see an uninitialized value. The patch moves all accesses to kern_ipc_perm.id under the spin_lock(). The issues is related to the finding of

[PATCH 0/5] ipc: cleanups & bugfixes

2018-07-04 Thread Manfred Spraul
Hi, Dmitry convinced me that I should properly review the initialization of new ipc objects, and I found another issue. The series corrects 3 issues with ipc_addid(), and also renames two functions and corrects a wrong comment. 0001-ipc-reorganize-initialization-of-kern_ipc_perm.id:

[PATCH 0/5] ipc: cleanups & bugfixes

2018-07-04 Thread Manfred Spraul
Hi, Dmitry convinced me that I should properly review the initialization of new ipc objects, and I found another issue. The series corrects 3 issues with ipc_addid(), and also renames two functions and corrects a wrong comment. 0001-ipc-reorganize-initialization-of-kern_ipc_perm.id:

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-04 Thread Tony Lindgren
* Faiz Abbas [180704 13:37]: > After taking a second look at this thread, I don't see anything big to > be modified. > > We both agree that "reset status bit in sysconfig register" is the quirk > case which can be added once such an IP is discovered in ti-sysc. Yes agreed. > All I need to

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-04 Thread Tony Lindgren
* Faiz Abbas [180704 13:37]: > After taking a second look at this thread, I don't see anything big to > be modified. > > We both agree that "reset status bit in sysconfig register" is the quirk > case which can be added once such an IP is discovered in ti-sysc. Yes agreed. > All I need to

Re: [PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Enric Balletbo Serra wrote: > Missatge de Dmitry Torokhov del dia dc., 4 > de jul. 2018 a les 17:10: > > > > Hi Enric, > > > > On Tue, Jun 26, 2018 at 11:06:33AM +0200, Enric Balletbo Serra wrote: > > > Hi Matti, > > > > > > Thanks for the patch, a few comments below, some

Re: [PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Enric Balletbo Serra wrote: > Missatge de Dmitry Torokhov del dia dc., 4 > de jul. 2018 a les 17:10: > > > > Hi Enric, > > > > On Tue, Jun 26, 2018 at 11:06:33AM +0200, Enric Balletbo Serra wrote: > > > Hi Matti, > > > > > > Thanks for the patch, a few comments below, some

Re: ltp/read_all_sys (read_all -d /sys -q -r 10) cause system panic with kernel-4.18.0-rc1

2018-07-04 Thread Li Wang
Hi there, The problem is still in kernel-v4.18-rc3. Panic was caused by command: # ./read_all -d /sys -q -r 10 Or, you can try the full steps to reproduce: # git clone https://github.com/linux-test-project/ltp/ # cd ltp # ./build.sh # cd ../ltp-install # ./runltp -s read_all_sys dmesg

Re: [lkp-robot] [fs] 5c6de586e8: vm-scalability.throughput +12.4% improvement (from reorganizing struct inode?)

2018-07-04 Thread Amir Goldstein
On Thu, Jul 5, 2018 at 4:37 AM, Linus Torvalds wrote: > On Wed, Jul 4, 2018 at 4:34 PM Al Viro wrote: >> >> I don't hate that patch, but there are immediate followup questions - e.g. >> how sensitive is relative position of i_lock/i_hash/i_sb? Those are *not* >> close to each other. E.g. what

Re: [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Janusz Krzysztofik wrote: > On Tuesday, July 3, 2018 7:31:41 PM CEST Boris Brezillon wrote: > > Hi Janusz, > > > > On Tue, 3 Jul 2018 19:26:35 +0200 > > > > Janusz Krzysztofik wrote: > > > Avoid replication of error code conversion in non-DT GPIO consumers' > > > code by

Re: ltp/read_all_sys (read_all -d /sys -q -r 10) cause system panic with kernel-4.18.0-rc1

2018-07-04 Thread Li Wang
Hi there, The problem is still in kernel-v4.18-rc3. Panic was caused by command: # ./read_all -d /sys -q -r 10 Or, you can try the full steps to reproduce: # git clone https://github.com/linux-test-project/ltp/ # cd ltp # ./build.sh # cd ../ltp-install # ./runltp -s read_all_sys dmesg

Re: [lkp-robot] [fs] 5c6de586e8: vm-scalability.throughput +12.4% improvement (from reorganizing struct inode?)

2018-07-04 Thread Amir Goldstein
On Thu, Jul 5, 2018 at 4:37 AM, Linus Torvalds wrote: > On Wed, Jul 4, 2018 at 4:34 PM Al Viro wrote: >> >> I don't hate that patch, but there are immediate followup questions - e.g. >> how sensitive is relative position of i_lock/i_hash/i_sb? Those are *not* >> close to each other. E.g. what

Re: [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Janusz Krzysztofik wrote: > On Tuesday, July 3, 2018 7:31:41 PM CEST Boris Brezillon wrote: > > Hi Janusz, > > > > On Tue, 3 Jul 2018 19:26:35 +0200 > > > > Janusz Krzysztofik wrote: > > > Avoid replication of error code conversion in non-DT GPIO consumers' > > > code by

Re: [PATCH] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Yang, Bin
Sorry for the misunderstanding. I mean I will improve the check loop in patch v2. I just submitted patch v2. Thanks in advance for your kind review. Thanks, Bin On 05/07/2018, 1:30 PM, "Thomas Gleixner" wrote: Sorry, I don't see in which way your patch would improve the check loop.

Re: [PATCH] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Yang, Bin
Sorry for the misunderstanding. I mean I will improve the check loop in patch v2. I just submitted patch v2. Thanks in advance for your kind review. Thanks, Bin On 05/07/2018, 1:30 PM, "Thomas Gleixner" wrote: Sorry, I don't see in which way your patch would improve the check loop.

Re: include architecture Kconfig files from top-level Kconfig

2018-07-04 Thread Masahiro Yamada
Hi. 2018-07-02 23:47 GMT+09:00 Christoph Hellwig : > Hi Masahiro, > > what do you think about the series below, which moves the includes > of all the architecture independ Kconfig files to the top-level > Kconfig instead of duplicating the includes in all architectures? > > Note that this only

Re: include architecture Kconfig files from top-level Kconfig

2018-07-04 Thread Masahiro Yamada
Hi. 2018-07-02 23:47 GMT+09:00 Christoph Hellwig : > Hi Masahiro, > > what do you think about the series below, which moves the includes > of all the architecture independ Kconfig files to the top-level > Kconfig instead of duplicating the includes in all architectures? > > Note that this only

[PATCH v2] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Bin Yang
When changing a 4K page attr inside 1G/2M large page range, __change_page_attr() will call try_preserve_large_page() to decide to split the big page or not. And try_preserve_large_page() will call static_protections() to check all 4K pages inside the large page range one by one. The check loop is

[PATCH v2] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Bin Yang
When changing a 4K page attr inside 1G/2M large page range, __change_page_attr() will call try_preserve_large_page() to decide to split the big page or not. And try_preserve_large_page() will call static_protections() to check all 4K pages inside the large page range one by one. The check loop is

Re: [PATCH 2/5] Kconfig: consolidate the "Kernel hacking menu"

2018-07-04 Thread Masahiro Yamada
2018-07-02 23:47 GMT+09:00 Christoph Hellwig : > Move the source of lib/Kconfig.debug and arch/$(ARCH)/Kconfig.debug to > the top-level Kconfig. For two architectures that means moving their > arch-specific symbols in that menu into a new arch Kconfig.debug file, > and for a few more creating a

Re: [PATCH 2/5] Kconfig: consolidate the "Kernel hacking menu"

2018-07-04 Thread Masahiro Yamada
2018-07-02 23:47 GMT+09:00 Christoph Hellwig : > Move the source of lib/Kconfig.debug and arch/$(ARCH)/Kconfig.debug to > the top-level Kconfig. For two architectures that means moving their > arch-specific symbols in that menu into a new arch Kconfig.debug file, > and for a few more creating a

Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig

2018-07-04 Thread Masahiro Yamada
2018-07-04 1:11 GMT+09:00 Randy Dunlap : > On 07/03/18 06:36, Christoph Hellwig wrote: >> On Mon, Jul 02, 2018 at 01:08:16PM -0700, Randy Dunlap wrote: I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. >>> >>> Ugh, that won't get this set correctly on x86_64: >>>

Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig

2018-07-04 Thread Masahiro Yamada
2018-07-04 1:11 GMT+09:00 Randy Dunlap : > On 07/03/18 06:36, Christoph Hellwig wrote: >> On Mon, Jul 02, 2018 at 01:08:16PM -0700, Randy Dunlap wrote: I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. >>> >>> Ugh, that won't get this set correctly on x86_64: >>>

Re: [PATCH V2 05/19] csky: System Call

2018-07-04 Thread Guo Ren
On Wed, Jul 04, 2018 at 11:04:37PM +0200, Arnd Bergmann wrote: > Right, I do understand what it's used for, my point was that you > don't really need a separate system call number for it, just redirect > the entry point using the same trick that nds32 has in > arch/nds32/kernel/syscall_table.c: >

Re: [PATCH V2 05/19] csky: System Call

2018-07-04 Thread Guo Ren
On Wed, Jul 04, 2018 at 11:04:37PM +0200, Arnd Bergmann wrote: > Right, I do understand what it's used for, my point was that you > don't really need a separate system call number for it, just redirect > the entry point using the same trick that nds32 has in > arch/nds32/kernel/syscall_table.c: >

Re: general protection fault in vmx_vcpu_run

2018-07-04 Thread Dmitry Vyukov
On Wed, Jul 4, 2018 at 9:31 PM, Raslan, KarimAllah wrote: > Dmitry, > > Can you share the host kernel version? > > I can not reproduce any of these crash signatures and I think it's > really a nested virtualization bug. So I will need the exact host > kernel version as well. > > I am currently

Re: general protection fault in vmx_vcpu_run

2018-07-04 Thread Dmitry Vyukov
On Wed, Jul 4, 2018 at 9:31 PM, Raslan, KarimAllah wrote: > Dmitry, > > Can you share the host kernel version? > > I can not reproduce any of these crash signatures and I think it's > really a nested virtualization bug. So I will need the exact host > kernel version as well. > > I am currently

Re: [PATCH] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Thomas Gleixner
On Thu, 5 Jul 2018, Yang, Bin wrote: Please do not top post. > This is what my new patch tries to improve. > On 04/07/2018, 10:02 PM, "Thomas Gleixner" wrote: > > The check loop itself is stupid as well. Instead of looping in 4K steps > the thing can be rewritten to check for

Re: [PATCH] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Thomas Gleixner
On Thu, 5 Jul 2018, Yang, Bin wrote: Please do not top post. > This is what my new patch tries to improve. > On 04/07/2018, 10:02 PM, "Thomas Gleixner" wrote: > > The check loop itself is stupid as well. Instead of looping in 4K steps > the thing can be rewritten to check for

Re: [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure

2018-07-04 Thread Uwe Kleine-König
Hello, On Wed, Jul 04, 2018 at 09:13:42PM +0200, Janusz Krzysztofik wrote: > On Tuesday, July 3, 2018 7:31:41 PM CEST Boris Brezillon wrote: > > Hi Janusz, > > > > On Tue, 3 Jul 2018 19:26:35 +0200 > > > > Janusz Krzysztofik wrote: > > > Avoid replication of error code conversion in non-DT

Re: [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure

2018-07-04 Thread Uwe Kleine-König
Hello, On Wed, Jul 04, 2018 at 09:13:42PM +0200, Janusz Krzysztofik wrote: > On Tuesday, July 3, 2018 7:31:41 PM CEST Boris Brezillon wrote: > > Hi Janusz, > > > > On Tue, 3 Jul 2018 19:26:35 +0200 > > > > Janusz Krzysztofik wrote: > > > Avoid replication of error code conversion in non-DT

[PATCH] zlib: remove fall through warnings

2018-07-04 Thread Corentin Labbe
This patch remove all following fall through warnings by adding /* fall through */ markers. Note that we cannot add "__attribute__ ((fallthrough));" due to it is GCC7 only arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:384:25: warning: this statement may fall through

[PATCH v3 02/11] hugetlb: Introduce generic version of hugetlb_free_pgd_range

2018-07-04 Thread Alexandre Ghiti
arm, arm64, mips, parisc, sh, x86 architectures use the same version of hugetlb_free_pgd_range, so move this generic implementation into asm-generic/hugetlb.h. Signed-off-by: Alexandre Ghiti --- arch/arm/include/asm/hugetlb.h | 12 ++-- arch/arm64/include/asm/hugetlb.h | 10

[PATCH] zlib: remove fall through warnings

2018-07-04 Thread Corentin Labbe
This patch remove all following fall through warnings by adding /* fall through */ markers. Note that we cannot add "__attribute__ ((fallthrough));" due to it is GCC7 only arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:384:25: warning: this statement may fall through

[PATCH v3 02/11] hugetlb: Introduce generic version of hugetlb_free_pgd_range

2018-07-04 Thread Alexandre Ghiti
arm, arm64, mips, parisc, sh, x86 architectures use the same version of hugetlb_free_pgd_range, so move this generic implementation into asm-generic/hugetlb.h. Signed-off-by: Alexandre Ghiti --- arch/arm/include/asm/hugetlb.h | 12 ++-- arch/arm64/include/asm/hugetlb.h | 10

linux-next: build failure after merge of the ida tree

2018-07-04 Thread Stephen Rothwell
Hi Matthew, After merging the ida tree, today's linux-next build (x86_64 allmodconfig) failed like this: lib/test_xarray.c: In function 'xa_alloc_value': lib/test_xarray.c:39:16: error: implicit declaration of function 'xa_alloc'; did you mean 'ida_alloc'?

linux-next: build failure after merge of the ida tree

2018-07-04 Thread Stephen Rothwell
Hi Matthew, After merging the ida tree, today's linux-next build (x86_64 allmodconfig) failed like this: lib/test_xarray.c: In function 'xa_alloc_value': lib/test_xarray.c:39:16: error: implicit declaration of function 'xa_alloc'; did you mean 'ida_alloc'?

[PATCH 1/2] dt-bindings: thermal: Allow multiple devices to share cooling map

2018-07-04 Thread Viresh Kumar
Allow cooling devices sharing same trip point with same contribution value to share the cooling map as well. Otherwise the same information will be duplicated for each device sharing the trip point. Signed-off-by: Viresh Kumar --- Documentation/devicetree/bindings/thermal/thermal.txt | 11

[PATCH 0/2] dt: thermal: Fix broken cooling-maps

2018-07-04 Thread Viresh Kumar
Hi, This is an attempt to fix the broken or partially defined DT bindings for cooling-maps. We should list every device that participates in cooling down at a certain trip point, instead of just the first in the list as that depends on certain ordering of events to work properly. The first patch

[PATCH 1/2] dt-bindings: thermal: Allow multiple devices to share cooling map

2018-07-04 Thread Viresh Kumar
Allow cooling devices sharing same trip point with same contribution value to share the cooling map as well. Otherwise the same information will be duplicated for each device sharing the trip point. Signed-off-by: Viresh Kumar --- Documentation/devicetree/bindings/thermal/thermal.txt | 11

[PATCH 0/2] dt: thermal: Fix broken cooling-maps

2018-07-04 Thread Viresh Kumar
Hi, This is an attempt to fix the broken or partially defined DT bindings for cooling-maps. We should list every device that participates in cooling down at a certain trip point, instead of just the first in the list as that depends on certain ordering of events to work properly. The first patch

[PATCH 2/2] arm64: dts: hi6220: Add all CPUs in cooling maps

2018-07-04 Thread Viresh Kumar
Each CPU can (and does) participate in cooling down the system but the DT only captures the CPU0 in the cooling maps. Things work by chance as under normal circumstances its the CPU0 which is used by the operating systems to probe the cooling devices. But as soon as that ordering changes and any

[PATCH 2/2] arm64: dts: hi6220: Add all CPUs in cooling maps

2018-07-04 Thread Viresh Kumar
Each CPU can (and does) participate in cooling down the system but the DT only captures the CPU0 in the cooling maps. Things work by chance as under normal circumstances its the CPU0 which is used by the operating systems to probe the cooling devices. But as soon as that ordering changes and any

Re: [PATCH V2 18/19] clocksource: add C-SKY clocksource drivers

2018-07-04 Thread Guo Ren
On Wed, Jul 04, 2018 at 04:35:43PM +0200, Thomas Gleixner wrote: > On Wed, 4 Jul 2018, Guo Ren wrote: > > On Tue, Jul 03, 2018 at 11:39:05AM +0200, Thomas Gleixner wrote: > > > > +static inline u64 get_ccvr(void) > > > > +{ > > > > + u32 lo, hi, t; > > > > + > > > > + do { > > > > +

Re: [PATCH V2 18/19] clocksource: add C-SKY clocksource drivers

2018-07-04 Thread Guo Ren
On Wed, Jul 04, 2018 at 04:35:43PM +0200, Thomas Gleixner wrote: > On Wed, 4 Jul 2018, Guo Ren wrote: > > On Tue, Jul 03, 2018 at 11:39:05AM +0200, Thomas Gleixner wrote: > > > > +static inline u64 get_ccvr(void) > > > > +{ > > > > + u32 lo, hi, t; > > > > + > > > > + do { > > > > +

Re: linux-next: build warning after merge of the slave-dma tree

2018-07-04 Thread Vinod
Hi Stephen, On 05-07-18, 12:47, Stephen Rothwell wrote: > On Wed, 4 Jul 2018 09:50:17 +0530 Vinod wrote: > > On 04-07-18, 13:30, Stephen Rothwell wrote: > > > > > > After merging the slave-dma tree, today's linux-next build (x86_64 > > > allmodconfig) produced this warning: > > > > > >

Re: linux-next: build warning after merge of the slave-dma tree

2018-07-04 Thread Vinod
Hi Stephen, On 05-07-18, 12:47, Stephen Rothwell wrote: > On Wed, 4 Jul 2018 09:50:17 +0530 Vinod wrote: > > On 04-07-18, 13:30, Stephen Rothwell wrote: > > > > > > After merging the slave-dma tree, today's linux-next build (x86_64 > > > allmodconfig) produced this warning: > > > > > >

[PATCH v2] w1: fix w1_ds2438 documentation

2018-07-04 Thread Mariusz Bialonczyk
The previous documentation was wrongly stating about the order of magnitude of CONVERT_V result files contents (vad, vdd). This commit is correcting this. Reported-by: Adam Stolarczyk Signed-off-by: Mariusz Bialonczyk --- Resending as V2 because it was malformed by mail mail app recently. I

[PATCH v2] w1: fix w1_ds2438 documentation

2018-07-04 Thread Mariusz Bialonczyk
The previous documentation was wrongly stating about the order of magnitude of CONVERT_V result files contents (vad, vdd). This commit is correcting this. Reported-by: Adam Stolarczyk Signed-off-by: Mariusz Bialonczyk --- Resending as V2 because it was malformed by mail mail app recently. I

KASAN: stack-out-of-bounds Read in __run_timers

2018-07-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2bdea157b999 Merge branch 'sctp-fully-support-for-dscp-and.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=15438ad040 kernel config: https://syzkaller.appspot.com/x/.config?x=f62553dc846b0692

KASAN: stack-out-of-bounds Read in __run_timers

2018-07-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2bdea157b999 Merge branch 'sctp-fully-support-for-dscp-and.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=15438ad040 kernel config: https://syzkaller.appspot.com/x/.config?x=f62553dc846b0692

KASAN: stack-out-of-bounds Read in move_expired_inodes

2018-07-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2bdea157b999 Merge branch 'sctp-fully-support-for-dscp-and.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=17d35aa440 kernel config: https://syzkaller.appspot.com/x/.config?x=f62553dc846b0692

KASAN: stack-out-of-bounds Read in move_expired_inodes

2018-07-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2bdea157b999 Merge branch 'sctp-fully-support-for-dscp-and.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=17d35aa440 kernel config: https://syzkaller.appspot.com/x/.config?x=f62553dc846b0692

Re: XArray -next inclusion request

2018-07-04 Thread Stephen Rothwell
Hi Willy, On Wed, 4 Jul 2018 15:54:31 -0700 Matthew Wilcox wrote: > > I have some additional patches for the IDA that I'd like to > send to Linus as a separate pull request. Unfortunately, they conflict with > the XArray patches, so I've done them as a separate branch in the same tree: > >

Re: XArray -next inclusion request

2018-07-04 Thread Stephen Rothwell
Hi Willy, On Wed, 4 Jul 2018 15:54:31 -0700 Matthew Wilcox wrote: > > I have some additional patches for the IDA that I'd like to > send to Linus as a separate pull request. Unfortunately, they conflict with > the XArray patches, so I've done them as a separate branch in the same tree: > >

linux-next: build failure after merge of the ida tree

2018-07-04 Thread Stephen Rothwell
Hi all, After merging the ida tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from include/linux/kernel.h:14:0, from include/asm-generic/bug.h:18, from arch/powerpc/include/asm/bug.h:128, from

linux-next: build failure after merge of the ida tree

2018-07-04 Thread Stephen Rothwell
Hi all, After merging the ida tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from include/linux/kernel.h:14:0, from include/asm-generic/bug.h:18, from arch/powerpc/include/asm/bug.h:128, from

Re: [PATCH] tpm: Fix NULL pointer dereference in tpm_transmit()

2018-07-04 Thread S, Shirish
On 7/4/2018 10:43 PM, Jarkko Sakkinen wrote: On Wed, Jul 04, 2018 at 02:33:40PM +0530, Shirish S wrote: During system shutdown, tpm_class_shutdown() when called with TPM_CHIP_FLAG_TPM2 flag set, makes chip->ops NULL. However tpm_chip_unregister() called later in shutdown sequence tries to

Re: [PATCH] tpm: Fix NULL pointer dereference in tpm_transmit()

2018-07-04 Thread S, Shirish
On 7/4/2018 10:43 PM, Jarkko Sakkinen wrote: On Wed, Jul 04, 2018 at 02:33:40PM +0530, Shirish S wrote: During system shutdown, tpm_class_shutdown() when called with TPM_CHIP_FLAG_TPM2 flag set, makes chip->ops NULL. However tpm_chip_unregister() called later in shutdown sequence tries to

[RESEND PATCH 1/2] Makefile: .PHONY is not a variable, but PHONY is

2018-07-04 Thread Masahiro Yamada
From: Ulf Magnusson .PHONY is a target, not a variable. Signed-off-by: Ulf Magnusson Signed-off-by: Masahiro Yamada --- Ulf sent this a long time ago. https://patchwork.kernel.org/patch/7111711/ Unfortunately, it was lost for some reason. I am resending to apply it if Ulf does not mind it.

[RESEND PATCH 1/2] Makefile: .PHONY is not a variable, but PHONY is

2018-07-04 Thread Masahiro Yamada
From: Ulf Magnusson .PHONY is a target, not a variable. Signed-off-by: Ulf Magnusson Signed-off-by: Masahiro Yamada --- Ulf sent this a long time ago. https://patchwork.kernel.org/patch/7111711/ Unfortunately, it was lost for some reason. I am resending to apply it if Ulf does not mind it.

[RESEND PATCH 2/2] kbuild: remove duplicated comments about PHONY

2018-07-04 Thread Masahiro Yamada
The comment is the same as in the top-level Makefile. Also, the comments contain typos: - the .PHONY variable -> the PHONY variable - se we can ...-> so we can ... Instead of fixing the typos, just remove the duplicated comments. Signed-off-by: Masahiro Yamada ---

[RESEND PATCH 2/2] kbuild: remove duplicated comments about PHONY

2018-07-04 Thread Masahiro Yamada
The comment is the same as in the top-level Makefile. Also, the comments contain typos: - the .PHONY variable -> the PHONY variable - se we can ...-> so we can ... Instead of fixing the typos, just remove the duplicated comments. Signed-off-by: Masahiro Yamada ---

Re: [PATCH V2 18/19] clocksource: add C-SKY clocksource drivers

2018-07-04 Thread Guo Ren
On Wed, Jul 04, 2018 at 07:05:05PM +0200, Daniel Lezcano wrote: > > create mode 100644 drivers/clocksource/timer-csky-v1.c > > create mode 100644 drivers/clocksource/timer-nationalchip.c > > Provide two separates patches, one for each timer. Ok. > > +obj-$(CONFIG_CSKY) +=

Re: [PATCH V2 18/19] clocksource: add C-SKY clocksource drivers

2018-07-04 Thread Guo Ren
On Wed, Jul 04, 2018 at 07:05:05PM +0200, Daniel Lezcano wrote: > > create mode 100644 drivers/clocksource/timer-csky-v1.c > > create mode 100644 drivers/clocksource/timer-nationalchip.c > > Provide two separates patches, one for each timer. Ok. > > +obj-$(CONFIG_CSKY) +=

Re: [PATCH 1/1] ASoC: rsnd: cmd: Add missing newline to debug message

2018-07-04 Thread Kuninori Morimoto
Hi > From: Andrew Gabbasov > > To comply with the style of all kernel messages, add newline > to the end of every message. > > Fixes: 70fb10529f61 ("ASoC: rsnd: add MIX (Mixer) support") > Signed-off-by: Andrew Gabbasov > Signed-off-by: Jiada Wang > --- Acked-by: Kuninori Morimoto Best

Re: [PATCH 1/1] ASoC: rsnd: cmd: Add missing newline to debug message

2018-07-04 Thread Kuninori Morimoto
Hi > From: Andrew Gabbasov > > To comply with the style of all kernel messages, add newline > to the end of every message. > > Fixes: 70fb10529f61 ("ASoC: rsnd: add MIX (Mixer) support") > Signed-off-by: Andrew Gabbasov > Signed-off-by: Jiada Wang > --- Acked-by: Kuninori Morimoto Best

[RFC PATCH] watchdog: sp805: Add clock-frequency property

2018-07-04 Thread Srinath Mannam
When using ACPI node, binding clock devices are not available as device tree, So clock-frequency property given in _DSD object of ACPI device is used to calculate Watchdog rate. Signed-off-by: Srinath Mannam --- drivers/watchdog/sp805_wdt.c | 29 - 1 file changed, 24

[RFC PATCH] watchdog: sp805: Add clock-frequency property

2018-07-04 Thread Srinath Mannam
When using ACPI node, binding clock devices are not available as device tree, So clock-frequency property given in _DSD object of ACPI device is used to calculate Watchdog rate. Signed-off-by: Srinath Mannam --- drivers/watchdog/sp805_wdt.c | 29 - 1 file changed, 24

Re: [PATCH 0/3] pinctrl: meson-g12a: add pinctrl driver support

2018-07-04 Thread Yixun Lan
HI Neil On 07/04/18 22:57, Neil Armstrong wrote: > Hi Yixun, > > On 05/07/2018 00:45, Yixun Lan wrote: >> This patch series try to add pinctrl driver support for >> the Meson-G12A SoC. > > Thanks for submitting these patches. > > Can you explicit this patchset with more details on the G12A SoC

RE: [PATCH 1/3] mmc: sdhci-esdhc-imx: get rid of support_vsel

2018-07-04 Thread A.s. Dong
> -Original Message- > From: Stefan Agner [mailto:ste...@agner.ch] > Sent: Thursday, June 28, 2018 4:13 PM > To: adrian.hun...@intel.com; ulf.hans...@linaro.org > Cc: Fabio Estevam ; Bough Chen > ; A.s. Dong ; > mich...@amarulasolutions.com; rmk+ker...@armlinux.org.uk; linux- >

RE: [PATCH 1/3] mmc: sdhci-esdhc-imx: get rid of support_vsel

2018-07-04 Thread A.s. Dong
> -Original Message- > From: Stefan Agner [mailto:ste...@agner.ch] > Sent: Thursday, June 28, 2018 4:13 PM > To: adrian.hun...@intel.com; ulf.hans...@linaro.org > Cc: Fabio Estevam ; Bough Chen > ; A.s. Dong ; > mich...@amarulasolutions.com; rmk+ker...@armlinux.org.uk; linux- >

Re: [PATCH 0/3] pinctrl: meson-g12a: add pinctrl driver support

2018-07-04 Thread Yixun Lan
HI Neil On 07/04/18 22:57, Neil Armstrong wrote: > Hi Yixun, > > On 05/07/2018 00:45, Yixun Lan wrote: >> This patch series try to add pinctrl driver support for >> the Meson-G12A SoC. > > Thanks for submitting these patches. > > Can you explicit this patchset with more details on the G12A SoC

[PATCH] kbuild: do not drop -I without parameter

2018-07-04 Thread Masahiro Yamada
The comment line for addtree says "skip if -I has no parameter". What it actually does is "drop if -I has no parameter". For example, if you have the compiler flag '-I foo' (a space between), it will be converted to 'foo'. This completely changes the meaning. What we want is, "do nothing" for

[PATCH] kbuild: do not drop -I without parameter

2018-07-04 Thread Masahiro Yamada
The comment line for addtree says "skip if -I has no parameter". What it actually does is "drop if -I has no parameter". For example, if you have the compiler flag '-I foo' (a space between), it will be converted to 'foo'. This completely changes the meaning. What we want is, "do nothing" for

[PATCH] kconfig: handle format string before calling conf_message_callback()

2018-07-04 Thread Masahiro Yamada
As you see in mconf.c and nconf.c, conf_message_callback() hooks are likely to end up with the boilerplate of vsnprintf(). Process the string format before calling conf_message_callback() so that it receives a simple string. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 17

[PATCH] kbuild: document the KBUILD_KCONFIG env. variable

2018-07-04 Thread Randy Dunlap
From: Randy Dunlap Add usage info for the Kbuild environment variable KBUILD_KCONFIG. Signed-off-by: Randy Dunlap --- Documentation/kbuild/kbuild.txt |5 + 1 file changed, 5 insertions(+) --- lnx-418-rc3.orig/Documentation/kbuild/kbuild.txt +++

[PATCH] kbuild: document the KBUILD_KCONFIG env. variable

2018-07-04 Thread Randy Dunlap
From: Randy Dunlap Add usage info for the Kbuild environment variable KBUILD_KCONFIG. Signed-off-by: Randy Dunlap --- Documentation/kbuild/kbuild.txt |5 + 1 file changed, 5 insertions(+) --- lnx-418-rc3.orig/Documentation/kbuild/kbuild.txt +++

[PATCH] kconfig: handle format string before calling conf_message_callback()

2018-07-04 Thread Masahiro Yamada
As you see in mconf.c and nconf.c, conf_message_callback() hooks are likely to end up with the boilerplate of vsnprintf(). Process the string format before calling conf_message_callback() so that it receives a simple string. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 17

Re: linux-next: build warning after merge of the slave-dma tree

2018-07-04 Thread Stephen Rothwell
' before string constant MODULE_LICENSE("GPL v2"); ^~~~ presumable a missing include of module.h ... I have gone back to the slave-dma tree from next-20180704 for today. -- Cheers, Stephen Rothwell pgpfIhizur9j_.pgp Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the slave-dma tree

2018-07-04 Thread Stephen Rothwell
' before string constant MODULE_LICENSE("GPL v2"); ^~~~ presumable a missing include of module.h ... I have gone back to the slave-dma tree from next-20180704 for today. -- Cheers, Stephen Rothwell pgpfIhizur9j_.pgp Description: OpenPGP digital signature

[PATCH v3 02/12] kconfig: split out helpers to check file/directory, create directory

2018-07-04 Thread Masahiro Yamada
Split out helpers: is_file() - check if the given path exists and it is a regular file is_dir() - check if the given path exists and it is a directory mkdir_p() - create the parent directories of the given path These helpers will be reused in later commits. Signed-off-by: Masahiro Yamada ---

[PATCH v3 00/12] kbuild/kconfig: do not update config during installation

2018-07-04 Thread Masahiro Yamada
The main motivation of this patch series is to suppress the syncconfig during running installation targets. V1 consisted of only two patches: https://patchwork.kernel.org/patch/10468105/ https://patchwork.kernel.org/patch/10468103/ I noticed that installation targets would continue running

[PATCH v3 02/12] kconfig: split out helpers to check file/directory, create directory

2018-07-04 Thread Masahiro Yamada
Split out helpers: is_file() - check if the given path exists and it is a regular file is_dir() - check if the given path exists and it is a directory mkdir_p() - create the parent directories of the given path These helpers will be reused in later commits. Signed-off-by: Masahiro Yamada ---

[PATCH v3 00/12] kbuild/kconfig: do not update config during installation

2018-07-04 Thread Masahiro Yamada
The main motivation of this patch series is to suppress the syncconfig during running installation targets. V1 consisted of only two patches: https://patchwork.kernel.org/patch/10468105/ https://patchwork.kernel.org/patch/10468103/ I noticed that installation targets would continue running

[PATCH v3 04/12] kconfig: create directories needed for syncconfig by itself

2018-07-04 Thread Masahiro Yamada
'make syncconfig' creates some files such as include/config/auto.conf, include/generate/autoconf.h, etc. but the necessary directory creation relies on scripts/kconfig/Makefile. To make Kconfig self-contained, create directories as needed in conf_write_autoconf(). This change allows

[PATCH v3 04/12] kconfig: create directories needed for syncconfig by itself

2018-07-04 Thread Masahiro Yamada
'make syncconfig' creates some files such as include/config/auto.conf, include/generate/autoconf.h, etc. but the necessary directory creation relies on scripts/kconfig/Makefile. To make Kconfig self-contained, create directories as needed in conf_write_autoconf(). This change allows

[PATCH v3 06/12] kconfig: allow all config targets to write auto.conf if missing

2018-07-04 Thread Masahiro Yamada
Currently, only syncconfig creates or updates include/config/auto.conf and some other files. Other config targets create or update only the .config file. When you configure and build the kernel from a pristine source tree, any config target is followed by syncconfig in the build stage since

[PATCH v3 06/12] kconfig: allow all config targets to write auto.conf if missing

2018-07-04 Thread Masahiro Yamada
Currently, only syncconfig creates or updates include/config/auto.conf and some other files. Other config targets create or update only the .config file. When you configure and build the kernel from a pristine source tree, any config target is followed by syncconfig in the build stage since

[PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-04 Thread Masahiro Yamada
syncconfig updates the .config only when sym_change_count > 0, i.e. any change in config symbols has been detected. Not only symbols but also comments are contained in the .config file. If only comments are updated, they are not fed back to the .config, then the stale comments are left-over. Of

[PATCH v3 01/12] kconfig: rename file_write_dep and move it to confdata.c

2018-07-04 Thread Masahiro Yamada
file_write_dep() is called only from conf_write_autoconf(). Move it from util.c to confdata.c to make it static. Also, rename it to conf_write_dep() since it should belong to the group of conf_write* functions. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 31

[PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-04 Thread Masahiro Yamada
syncconfig updates the .config only when sym_change_count > 0, i.e. any change in config symbols has been detected. Not only symbols but also comments are contained in the .config file. If only comments are updated, they are not fed back to the .config, then the stale comments are left-over. Of

[PATCH v3 01/12] kconfig: rename file_write_dep and move it to confdata.c

2018-07-04 Thread Masahiro Yamada
file_write_dep() is called only from conf_write_autoconf(). Move it from util.c to confdata.c to make it static. Also, rename it to conf_write_dep() since it should belong to the group of conf_write* functions. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 31

[PATCH v3 03/12] kconfig: remove unneeded directory generation from local*config

2018-07-04 Thread Masahiro Yamada
Commit 17263baf958b ("kconfig: Create include/generated for localmodconfig") added the 'mkdir' line because local{yes,mod}config ran streamline_config.pl followed by silentoldconfig at that time. Since commit 81d2bc227305 ("kconfig: invoke oldconfig instead of silentoldconfig from local*config"),

[PATCH v3 03/12] kconfig: remove unneeded directory generation from local*config

2018-07-04 Thread Masahiro Yamada
Commit 17263baf958b ("kconfig: Create include/generated for localmodconfig") added the 'mkdir' line because local{yes,mod}config ran streamline_config.pl followed by silentoldconfig at that time. Since commit 81d2bc227305 ("kconfig: invoke oldconfig instead of silentoldconfig from local*config"),

Re: [PATCH v3] media: dvb-frontends: add Socionext SC1501A ISDB-S/T demodulator driver

2018-07-04 Thread Mauro Carvalho Chehab
Em Thu, 5 Jul 2018 10:58:42 +0900 "Katsuhiro Suzuki" escreveu: > Hi Mauro, > > > -Original Message- > > From: Mauro Carvalho Chehab > > Sent: Thursday, July 5, 2018 1:58 AM > > To: Suzuki, Katsuhiro/鈴木 勝博 > > Cc: linux-me...@vger.kernel.org; Masami Hiramatsu > ; > > Jassi Brar ; >

Re: [PATCH v3] media: dvb-frontends: add Socionext SC1501A ISDB-S/T demodulator driver

2018-07-04 Thread Mauro Carvalho Chehab
Em Thu, 5 Jul 2018 10:58:42 +0900 "Katsuhiro Suzuki" escreveu: > Hi Mauro, > > > -Original Message- > > From: Mauro Carvalho Chehab > > Sent: Thursday, July 5, 2018 1:58 AM > > To: Suzuki, Katsuhiro/鈴木 勝博 > > Cc: linux-me...@vger.kernel.org; Masami Hiramatsu > ; > > Jassi Brar ; >

[PATCH v3 07/12] kbuild: use 'include' directive to load auto.conf from top Makefile

2018-07-04 Thread Masahiro Yamada
When you build targets that require the kernel configuration, dot-config is set to 1, then the top-level Makefile includes auto.conf. However, Make considers its inclusion is optional because the '-include' directive is used here. If a necessary configuration file is missing for the external

[PATCH v3 07/12] kbuild: use 'include' directive to load auto.conf from top Makefile

2018-07-04 Thread Masahiro Yamada
When you build targets that require the kernel configuration, dot-config is set to 1, then the top-level Makefile includes auto.conf. However, Make considers its inclusion is optional because the '-include' directive is used here. If a necessary configuration file is missing for the external

  1   2   3   4   5   6   7   8   9   10   >