Re: [PATCH v3 3/3] clk: qcom: Add display clock controller driver for SDM845

2018-07-15 Thread Taniya Das
Hello Stephen, On 7/13/2018 1:55 PM, spa...@codeaurora.org wrote: On 2018-07-13 01:11, Stephen Boyd wrote: Quoting Taniya Das (2018-07-12 10:21:33) ++ Display driver team, On 7/9/2018 8:36 PM, Stephen Boyd wrote: > Quoting Taniya Das (2018-07-09 02:34:07) >> >> >> On 7/9/2018 1:07 PM,

Re: [PATCH v3 3/3] clk: qcom: Add display clock controller driver for SDM845

2018-07-15 Thread Taniya Das
Hello Stephen, On 7/13/2018 1:55 PM, spa...@codeaurora.org wrote: On 2018-07-13 01:11, Stephen Boyd wrote: Quoting Taniya Das (2018-07-12 10:21:33) ++ Display driver team, On 7/9/2018 8:36 PM, Stephen Boyd wrote: > Quoting Taniya Das (2018-07-09 02:34:07) >> >> >> On 7/9/2018 1:07 PM,

[PATCH] clk: qcom: Update SPDX headers for common files

2018-07-15 Thread Taniya Das
SPDX headers updated for common/branch/pll/regmap files. Signed-off-by: Taniya Das --- drivers/clk/qcom/clk-alpha-pll.c | 10 +- drivers/clk/qcom/clk-alpha-pll.h | 14 ++ drivers/clk/qcom/clk-branch.c| 10 +- drivers/clk/qcom/clk-branch.h| 14 ++

[PATCH] clk: qcom: Update SPDX headers for common files

2018-07-15 Thread Taniya Das
SPDX headers updated for common/branch/pll/regmap files. Signed-off-by: Taniya Das --- drivers/clk/qcom/clk-alpha-pll.c | 10 +- drivers/clk/qcom/clk-alpha-pll.h | 14 ++ drivers/clk/qcom/clk-branch.c| 10 +- drivers/clk/qcom/clk-branch.h| 14 ++

linux-next: build warning after merge of the random tree

2018-07-15 Thread Stephen Rothwell
Hi Ted, After merging the random tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/char/random.c: In function 'write_pool.constprop': drivers/char/random.c:1912:11: warning: 't' may be used uninitialized in this function [-Wmaybe-uninitialized] buf[i] ^=

linux-next: build warning after merge of the random tree

2018-07-15 Thread Stephen Rothwell
Hi Ted, After merging the random tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/char/random.c: In function 'write_pool.constprop': drivers/char/random.c:1912:11: warning: 't' may be used uninitialized in this function [-Wmaybe-uninitialized] buf[i] ^=

[PATCH] doc: livepatch: fix minor typo in shadow-vars.txt

2018-07-15 Thread Kamalesh Babulal
Fix the spelling of 'varibles' -> 'variables' in shadows->vars.txt file. Signed-off-by: Kamalesh Babulal --- Documentation/livepatch/shadow-vars.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/livepatch/shadow-vars.txt

[PATCH] doc: livepatch: fix minor typo in shadow-vars.txt

2018-07-15 Thread Kamalesh Babulal
Fix the spelling of 'varibles' -> 'variables' in shadows->vars.txt file. Signed-off-by: Kamalesh Babulal --- Documentation/livepatch/shadow-vars.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/livepatch/shadow-vars.txt

Re: [PATCH 1/3] binfmt_elf: Respect error return from `regset->active'

2018-07-15 Thread Maciej W. Rozycki
Hi Paul, > > --- linux-jhogan-test.orig/fs/binfmt_elf.c 2018-03-21 17:14:55.0 > > + > > +++ linux-jhogan-test/fs/binfmt_elf.c 2018-05-09 23:25:50.742255000 > > +0100 > > @@ -1739,7 +1739,7 @@ static int fill_thread_core_info(struct > > const struct user_regset

Re: [PATCH 1/3] binfmt_elf: Respect error return from `regset->active'

2018-07-15 Thread Maciej W. Rozycki
Hi Paul, > > --- linux-jhogan-test.orig/fs/binfmt_elf.c 2018-03-21 17:14:55.0 > > + > > +++ linux-jhogan-test/fs/binfmt_elf.c 2018-05-09 23:25:50.742255000 > > +0100 > > @@ -1739,7 +1739,7 @@ static int fill_thread_core_info(struct > > const struct user_regset

[PATCH v3 2/2] clk: qcom: gcc: Register QUPv3 RCGs for DFS on SDM845

2018-07-15 Thread Taniya Das
QUPv3 clocks support DFS and thus register the RCGs which require support for the same. Signed-off-by: Taniya Das --- drivers/clk/qcom/gcc-sdm845.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c index

[PATCH v3 2/2] clk: qcom: gcc: Register QUPv3 RCGs for DFS on SDM845

2018-07-15 Thread Taniya Das
QUPv3 clocks support DFS and thus register the RCGs which require support for the same. Signed-off-by: Taniya Das --- drivers/clk/qcom/gcc-sdm845.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c index

[PATCH v3 1/2] clk: qcom: Add support for RCG to register for DFS

2018-07-15 Thread Taniya Das
Dynamic Frequency switch is a feature of clock controller by which request from peripherals allows automatic switching frequency of input clock without SW intervention. There are various performance levels associated with a root clock. When the input performance state changes, the source clocks

[PATCH v3 1/2] clk: qcom: Add support for RCG to register for DFS

2018-07-15 Thread Taniya Das
Dynamic Frequency switch is a feature of clock controller by which request from peripherals allows automatic switching frequency of input clock without SW intervention. There are various performance levels associated with a root clock. When the input performance state changes, the source clocks

[PATCH v3 0/2] clk: qcom: Add support for RCG to register for DFS

2018-07-15 Thread Taniya Das
[v3] * Rename clk_rcg2_calculate_m_and_n with clk_rcg2_calculate_freq, as this function would now calculate the frequency. * Rename dfs_freq_tbl to freq_tbl. * Remove the logic to remove duplicate frequencies. * Remove recalc_rate & set_rate clock ops. * clk_rcg2_dfs_ops clock ops

[PATCH v3 0/2] clk: qcom: Add support for RCG to register for DFS

2018-07-15 Thread Taniya Das
[v3] * Rename clk_rcg2_calculate_m_and_n with clk_rcg2_calculate_freq, as this function would now calculate the frequency. * Rename dfs_freq_tbl to freq_tbl. * Remove the logic to remove duplicate frequencies. * Remove recalc_rate & set_rate clock ops. * clk_rcg2_dfs_ops clock ops

Re: [PATCH v2 1/2] clk: qcom: Add support for RCG to register for DFS

2018-07-15 Thread Taniya Das
Hello Stephen, Thanks for your review comments. On 7/9/2018 12:34 PM, Stephen Boyd wrote: Quoting Taniya Das (2018-06-28 04:47:30) Dynamic Frequency switch is a feature of clock controller by which request from peripherals allows automatic switching frequency of input clock. There are various

Re: [PATCH v2 1/2] clk: qcom: Add support for RCG to register for DFS

2018-07-15 Thread Taniya Das
Hello Stephen, Thanks for your review comments. On 7/9/2018 12:34 PM, Stephen Boyd wrote: Quoting Taniya Das (2018-06-28 04:47:30) Dynamic Frequency switch is a feature of clock controller by which request from peripherals allows automatic switching frequency of input clock. There are various

Re: [PATCH v5 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-07-15 Thread Viresh Kumar
On 12-07-18, 23:35, Taniya Das wrote: > +static int qcom_cpu_resources_init(struct platform_device *pdev, > +struct device_node *np, unsigned int cpu) > +{ > + struct cpufreq_qcom *c; > + struct resource res; > + struct device *dev = >dev; > +

Re: [PATCH v5 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-07-15 Thread Viresh Kumar
On 12-07-18, 23:35, Taniya Das wrote: > +static int qcom_cpu_resources_init(struct platform_device *pdev, > +struct device_node *np, unsigned int cpu) > +{ > + struct cpufreq_qcom *c; > + struct resource res; > + struct device *dev = >dev; > +

Re: [PATCH v5 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-07-15 Thread Viresh Kumar
On 12-07-18, 23:35, Taniya Das wrote: > The CPUfreq HW present in some QCOM chipsets offloads the steps necessary > for changing the frequency of CPUs. The driver implements the cpufreq > driver interface for this hardware engine. > > Signed-off-by: Saravana Kannan > Signed-off-by: Taniya Das >

Re: [PATCH v5 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-07-15 Thread Viresh Kumar
On 12-07-18, 23:35, Taniya Das wrote: > The CPUfreq HW present in some QCOM chipsets offloads the steps necessary > for changing the frequency of CPUs. The driver implements the cpufreq > driver interface for this hardware engine. > > Signed-off-by: Saravana Kannan > Signed-off-by: Taniya Das >

[PATCH] soc: imx: gpc: restrict register range for regmap access

2018-07-15 Thread Anson Huang
GPC registers are NOT continuous, some registers are reserved and accessing them from userspace will trigger external abort, add regmap register access table to avoid below abort: root@imx6slevk:~# cat /sys/kernel/debug/regmap/20dc000.gpc/registers [ 108.480477] Unhandled fault: imprecise

[PATCH] soc: imx: gpc: restrict register range for regmap access

2018-07-15 Thread Anson Huang
GPC registers are NOT continuous, some registers are reserved and accessing them from userspace will trigger external abort, add regmap register access table to avoid below abort: root@imx6slevk:~# cat /sys/kernel/debug/regmap/20dc000.gpc/registers [ 108.480477] Unhandled fault: imprecise

Re: [PATCH] fs: ext4: use new return type vm_fault_t

2018-07-15 Thread Souptick Joarder
On Sat, Jul 7, 2018 at 4:00 PM, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler > ext4_filemap_fault. > > Signed-off-by: Souptick Joarder Any comment on this patch ? > --- > fs/ext4/ext4.h | 2 +- > fs/ext4/inode.c | 8 > 2 files changed, 5 insertions(+), 5

Re: [PATCH] fs: ext4: use new return type vm_fault_t

2018-07-15 Thread Souptick Joarder
On Sat, Jul 7, 2018 at 4:00 PM, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler > ext4_filemap_fault. > > Signed-off-by: Souptick Joarder Any comment on this patch ? > --- > fs/ext4/ext4.h | 2 +- > fs/ext4/inode.c | 8 > 2 files changed, 5 insertions(+), 5

Re: [PATCH 1/2] dt-bindings: thermal: Allow multiple devices to share cooling map

2018-07-15 Thread Viresh Kumar
On 05-07-18, 10:39, Viresh Kumar wrote: > Allow cooling devices sharing same trip point with same contribution > value to share the cooling map as well. Otherwise the same information > will be duplicated for each device sharing the trip point. > > Signed-off-by: Viresh Kumar > --- >

Re: [PATCH 1/2] dt-bindings: thermal: Allow multiple devices to share cooling map

2018-07-15 Thread Viresh Kumar
On 05-07-18, 10:39, Viresh Kumar wrote: > Allow cooling devices sharing same trip point with same contribution > value to share the cooling map as well. Otherwise the same information > will be duplicated for each device sharing the trip point. > > Signed-off-by: Viresh Kumar > --- >

Re: [PATCH 00/10] OPP: Support multiple power-domains per device

2018-07-15 Thread Viresh Kumar
On 29-06-18, 11:49, Viresh Kumar wrote: > Hi, > > This series improves the OPP core (and a bit of genpd core as well) to > support multiple phandles in the "required-opps" property, which are > only used for multiple power-domains per device for now. > > We still don't propagate the changes to

Re: [PATCH 00/10] OPP: Support multiple power-domains per device

2018-07-15 Thread Viresh Kumar
On 29-06-18, 11:49, Viresh Kumar wrote: > Hi, > > This series improves the OPP core (and a bit of genpd core as well) to > support multiple phandles in the "required-opps" property, which are > only used for multiple power-domains per device for now. > > We still don't propagate the changes to

Re: [PATCH v2 0/5] ASoC: core: add support to card re-bind using component framework

2018-07-15 Thread Vinod
On 13-07-18, 16:36, Srinivas Kandagatla wrote: > During discussion regarding card re-binding when components unregister > and register back at https://lkml.org/lkml/2018/7/9/785 it was suggested > that component framework can be added into core to provide this feature. > > With this new changes

Re: [PATCH v2 0/5] ASoC: core: add support to card re-bind using component framework

2018-07-15 Thread Vinod
On 13-07-18, 16:36, Srinivas Kandagatla wrote: > During discussion regarding card re-binding when components unregister > and register back at https://lkml.org/lkml/2018/7/9/785 it was suggested > that component framework can be added into core to provide this feature. > > With this new changes

[PATCH 4/5] x86/pti: warn for unknown pti boot options

2018-07-15 Thread Jiang Biao
When using unknown pti boot options other than on/off/auto, we select auto silently, which is sometimes confusing. Add warning for unknown pti boot options like we do in spectre_v2_select_mitigation(). Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 10 +- 1 file changed, 5

[PATCH 4/5] x86/pti: warn for unknown pti boot options

2018-07-15 Thread Jiang Biao
When using unknown pti boot options other than on/off/auto, we select auto silently, which is sometimes confusing. Add warning for unknown pti boot options like we do in spectre_v2_select_mitigation(). Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 10 +- 1 file changed, 5

[PATCH 1/5] x86/pti: check the return value of pti_user_pagetable_walk_p4d

2018-07-15 Thread Jiang Biao
pti_user_pagetable_walk_p4d() may return NULL, we should check the return value to avoid NULL pointer dereference. Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index

[PATCH 3/5] x86/pti: make pti_set_kernel_image_nonglobal static

2018-07-15 Thread Jiang Biao
pti_set_kernel_image_nonglobal() is only used in pti.c, make it static. Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index bb6f608..a76b2cc 100644 --- a/arch/x86/mm/pti.c +++

[PATCH 1/5] x86/pti: check the return value of pti_user_pagetable_walk_p4d

2018-07-15 Thread Jiang Biao
pti_user_pagetable_walk_p4d() may return NULL, we should check the return value to avoid NULL pointer dereference. Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index

[PATCH 3/5] x86/pti: make pti_set_kernel_image_nonglobal static

2018-07-15 Thread Jiang Biao
pti_set_kernel_image_nonglobal() is only used in pti.c, make it static. Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index bb6f608..a76b2cc 100644 --- a/arch/x86/mm/pti.c +++

[PATCH 5/5] x86/pti: constify address parameters

2018-07-15 Thread Jiang Biao
Addresses passed in pti_user_pagetable_walk_*() are not supposed to change at runtime, make them const to aviod future slipups. Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index

[PATCH 2/5] x86/pti: check the return value of pti_user_pagetable_walk_pmd

2018-07-15 Thread Jiang Biao
pti_user_pagetable_walk_pmd() may return NULL, we should check the return value in pti_user_pagetable_walk_pte() to avoid NULL pointer dereference like it is checked in pti_clone_pmds(). Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH 5/5] x86/pti: constify address parameters

2018-07-15 Thread Jiang Biao
Addresses passed in pti_user_pagetable_walk_*() are not supposed to change at runtime, make them const to aviod future slipups. Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index

[PATCH 2/5] x86/pti: check the return value of pti_user_pagetable_walk_pmd

2018-07-15 Thread Jiang Biao
pti_user_pagetable_walk_pmd() may return NULL, we should check the return value in pti_user_pagetable_walk_pte() to avoid NULL pointer dereference like it is checked in pti_clone_pmds(). Signed-off-by: Jiang Biao --- arch/x86/mm/pti.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH 0/5] x86/pti: small fixes and cleanups for pti

2018-07-15 Thread Jiang Biao
This is a short series of fixes and cleanups found when reading the code, no functional changes. Jiang Biao (5): x86/pti: check the return value of pti_user_pagetable_walk_p4d x86/pti: check the return value of pti_user_pagetable_walk_pmd x86/pti: make pti_set_kernel_image_nonglobal static

[PATCH 0/5] x86/pti: small fixes and cleanups for pti

2018-07-15 Thread Jiang Biao
This is a short series of fixes and cleanups found when reading the code, no functional changes. Jiang Biao (5): x86/pti: check the return value of pti_user_pagetable_walk_p4d x86/pti: check the return value of pti_user_pagetable_walk_pmd x86/pti: make pti_set_kernel_image_nonglobal static

Re: [PATCH v4.9] PM / OPP: Update voltage in case freq == old_freq

2018-07-15 Thread Viresh Kumar
On 10-07-18, 15:59, Greg KH wrote: > On Mon, Jul 02, 2018 at 02:19:47PM +0530, Viresh Kumar wrote: > > From: Waldemar Rymarkiewicz > > > > Original commit c5c2a97b3ac7 ("PM / OPP: Update voltage in case freq == > > old_freq"). Looking for this ^^ information ? > Always give me a hint as to

Re: [PATCH v4.9] PM / OPP: Update voltage in case freq == old_freq

2018-07-15 Thread Viresh Kumar
On 10-07-18, 15:59, Greg KH wrote: > On Mon, Jul 02, 2018 at 02:19:47PM +0530, Viresh Kumar wrote: > > From: Waldemar Rymarkiewicz > > > > Original commit c5c2a97b3ac7 ("PM / OPP: Update voltage in case freq == > > old_freq"). Looking for this ^^ information ? > Always give me a hint as to

Re: Perf JSON events mismatch with Intel SDM

2018-07-15 Thread Andi Kleen
> now need to dive in deep into the actual implementation. Simple question: is > this a bug? These are derived events from MEM_TRANS_RETIRED.LOAD_LATENCY, which is in the SDM. It's not a bug. In general the event lists used by perf are newer versions than what is in the SDM. -Andi

[PATCH] dm crypt: Convert essiv from ahash to shash

2018-07-15 Thread Kees Cook
In preparing to remove all stack VLA usage from the kernel[1], this removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash to direct shash. The stack allocation will be made a fixed size in a later patch to the

Re: Perf JSON events mismatch with Intel SDM

2018-07-15 Thread Andi Kleen
> now need to dive in deep into the actual implementation. Simple question: is > this a bug? These are derived events from MEM_TRANS_RETIRED.LOAD_LATENCY, which is in the SDM. It's not a bug. In general the event lists used by perf are newer versions than what is in the SDM. -Andi

[PATCH] dm crypt: Convert essiv from ahash to shash

2018-07-15 Thread Kees Cook
In preparing to remove all stack VLA usage from the kernel[1], this removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash to direct shash. The stack allocation will be made a fixed size in a later patch to the

[PATCH] x86/power/64: Remove VLA usage

2018-07-15 Thread Kees Cook
In the quest to remove all stack VLA usage from the kernel[1], this removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to shash directly and allocating the descriptor in heap memory (which should be fine: the tfm has already been allocated there too). [1]

[PATCH] x86/power/64: Remove VLA usage

2018-07-15 Thread Kees Cook
In the quest to remove all stack VLA usage from the kernel[1], this removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to shash directly and allocating the descriptor in heap memory (which should be fine: the tfm has already been allocated there too). [1]

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-15 Thread Yafang Shao
On Mon, Jul 16, 2018 at 11:09 AM, Shakeel Butt wrote: > On Sun, Jul 15, 2018 at 6:50 PM Yafang Shao wrote: >> >> On Sun, Jul 15, 2018 at 11:04 PM, Shakeel Butt wrote: >> > On Sun, Jul 15, 2018 at 1:02 AM Yafang Shao wrote: >> >> >> >> On Sun, Jul 15, 2018 at 2:34 PM, Shakeel Butt wrote: >> >>

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-15 Thread Yafang Shao
On Mon, Jul 16, 2018 at 11:09 AM, Shakeel Butt wrote: > On Sun, Jul 15, 2018 at 6:50 PM Yafang Shao wrote: >> >> On Sun, Jul 15, 2018 at 11:04 PM, Shakeel Butt wrote: >> > On Sun, Jul 15, 2018 at 1:02 AM Yafang Shao wrote: >> >> >> >> On Sun, Jul 15, 2018 at 2:34 PM, Shakeel Butt wrote: >> >>

RE: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-15 Thread Gary Hsu
Hi Jae, In originally, we reserved these register bits for debug purpose. But for some error handling case, we found it is also useful to help to clarify some error conditions. So driver also can use these fields information to check something. As for how driver use these information in their

RE: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-15 Thread Gary Hsu
Hi Jae, In originally, we reserved these register bits for debug purpose. But for some error handling case, we found it is also useful to help to clarify some error conditions. So driver also can use these fields information to check something. As for how driver use these information in their

Re: [PATCH v3 0/4] PCI: mediatek: fixup find_port, enable_msi and add pm, module support

2018-07-15 Thread Honghui Zhang
Hi, Bjorn, Lorenzo, could you kindly take a look at this serial? thanks. On Mon, 2018-07-02 at 15:57 +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > This patchset includes misc patchs: > > The first patch fixup the mtk_pcie_find_port logical which will cause system > could

Re: [PATCH v3 0/4] PCI: mediatek: fixup find_port, enable_msi and add pm, module support

2018-07-15 Thread Honghui Zhang
Hi, Bjorn, Lorenzo, could you kindly take a look at this serial? thanks. On Mon, 2018-07-02 at 15:57 +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > This patchset includes misc patchs: > > The first patch fixup the mtk_pcie_find_port logical which will cause system > could

WARNING: kmalloc bug in krealloc

2018-07-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:483d835c8189 Add linux-next specific files for 20180713 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=13689bb240 kernel config: https://syzkaller.appspot.com/x/.config?x=60e5ac2478928314

WARNING: kmalloc bug in krealloc

2018-07-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:483d835c8189 Add linux-next specific files for 20180713 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=13689bb240 kernel config: https://syzkaller.appspot.com/x/.config?x=60e5ac2478928314

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-15 Thread Shakeel Butt
On Sun, Jul 15, 2018 at 6:50 PM Yafang Shao wrote: > > On Sun, Jul 15, 2018 at 11:04 PM, Shakeel Butt wrote: > > On Sun, Jul 15, 2018 at 1:02 AM Yafang Shao wrote: > >> > >> On Sun, Jul 15, 2018 at 2:34 PM, Shakeel Butt wrote: > >> > On Sat, Jul 14, 2018 at 10:26 PM Yafang Shao > >> > wrote:

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-15 Thread Shakeel Butt
On Sun, Jul 15, 2018 at 6:50 PM Yafang Shao wrote: > > On Sun, Jul 15, 2018 at 11:04 PM, Shakeel Butt wrote: > > On Sun, Jul 15, 2018 at 1:02 AM Yafang Shao wrote: > >> > >> On Sun, Jul 15, 2018 at 2:34 PM, Shakeel Butt wrote: > >> > On Sat, Jul 14, 2018 at 10:26 PM Yafang Shao > >> > wrote:

Re: [PATCH v1 1/2] dt-binding: bmc: Add NPCM7xx LPC BPC documentation

2018-07-15 Thread Andrew Jeffery
On Thu, 12 Jul 2018, at 05:51, Rob Herring wrote: > On Wed, Jul 04, 2018 at 12:14:26PM +0300, Tomer Maimon wrote: > > Added device tree binding documentation for Nuvoton BMC > > NPCM7xx BIOS Post Code (BPC). > > The NPCM7xx BPC monitoring two configurable I/O addresses > > written by the host on

Re: [PATCH v1 1/2] dt-binding: bmc: Add NPCM7xx LPC BPC documentation

2018-07-15 Thread Andrew Jeffery
On Thu, 12 Jul 2018, at 05:51, Rob Herring wrote: > On Wed, Jul 04, 2018 at 12:14:26PM +0300, Tomer Maimon wrote: > > Added device tree binding documentation for Nuvoton BMC > > NPCM7xx BIOS Post Code (BPC). > > The NPCM7xx BPC monitoring two configurable I/O addresses > > written by the host on

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-15 Thread Paul E. McKenney
On Fri, Jul 13, 2018 at 07:58:25PM -0700, Linus Torvalds wrote: > On Fri, Jul 13, 2018 at 6:51 PM Alan Stern wrote: > > > > The point being that the scenarios under discussion in this thread all > > fall most definitely into the "Non-standard usage; you'd better know > > exactly what you're

[lkp-robot] [debugobjects] 3f96d20faf: WARNING:at_kernel/locking/lockdep.c:#register_lock_class

2018-07-15 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-4.9): commit: 3f96d20fafb19e6dd869362ace53662b06e6f6c1 ("[PATCH] debugobjects: Disable lockdep tracking of debugobjects internal locks") url:

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-15 Thread Paul E. McKenney
On Fri, Jul 13, 2018 at 07:58:25PM -0700, Linus Torvalds wrote: > On Fri, Jul 13, 2018 at 6:51 PM Alan Stern wrote: > > > > The point being that the scenarios under discussion in this thread all > > fall most definitely into the "Non-standard usage; you'd better know > > exactly what you're

[lkp-robot] [debugobjects] 3f96d20faf: WARNING:at_kernel/locking/lockdep.c:#register_lock_class

2018-07-15 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-4.9): commit: 3f96d20fafb19e6dd869362ace53662b06e6f6c1 ("[PATCH] debugobjects: Disable lockdep tracking of debugobjects internal locks") url:

Re: [PATCH] x86/mtrr: don't copy out-of-bounds data in mtrr_write

2018-07-15 Thread Al Viro
On Mon, Jul 16, 2018 at 12:03:39AM +0200, Ingo Molnar wrote: > > * Jann Horn wrote: > > > - A malicious user can pass an arbitrary file to a setuid binary as > > stdin/stdout/stderr. When the setuid binary (expecting stdin/stdout to > > be something normal, like a proper file or a pipe) then

Re: [PATCH] x86/mtrr: don't copy out-of-bounds data in mtrr_write

2018-07-15 Thread Al Viro
On Mon, Jul 16, 2018 at 12:03:39AM +0200, Ingo Molnar wrote: > > * Jann Horn wrote: > > > - A malicious user can pass an arbitrary file to a setuid binary as > > stdin/stdout/stderr. When the setuid binary (expecting stdin/stdout to > > be something normal, like a proper file or a pipe) then

Re: [PATCH - revised] rhashtable: detect when object movement might have invalidated a lookup

2018-07-15 Thread Herbert Xu
On Mon, Jul 16, 2018 at 11:23:43AM +1000, NeilBrown wrote: > > kmem_cache_free() directly. For this, I need rhashtable to be safe if > an object is deleted and immediately re-inserted into the same hash > chain. This means that rcu_read_lock(); A = rhashtable_lookup();

Re: [PATCH - revised] rhashtable: detect when object movement might have invalidated a lookup

2018-07-15 Thread Herbert Xu
On Mon, Jul 16, 2018 at 11:23:43AM +1000, NeilBrown wrote: > > kmem_cache_free() directly. For this, I need rhashtable to be safe if > an object is deleted and immediately re-inserted into the same hash > chain. This means that rcu_read_lock(); A = rhashtable_lookup();

Re: [PATCH v4 1/2] leds: core: Introduce generic pattern interface

2018-07-15 Thread Baolin Wang
On 14 July 2018 at 14:29, Pavel Machek wrote: > >> @@ -446,4 +455,14 @@ static inline void >> led_classdev_notify_brightness_hw_changed( >> struct led_classdev *led_cdev, enum led_brightness brightness) { } >> #endif >> >> +/** >> + * struct led_pattern - brigheness value in a pattern > >

Re: [PATCH v4 1/2] leds: core: Introduce generic pattern interface

2018-07-15 Thread Baolin Wang
On 14 July 2018 at 14:29, Pavel Machek wrote: > >> @@ -446,4 +455,14 @@ static inline void >> led_classdev_notify_brightness_hw_changed( >> struct led_classdev *led_cdev, enum led_brightness brightness) { } >> #endif >> >> +/** >> + * struct led_pattern - brigheness value in a pattern > >

Re: [PATCH v4 0/3] uio: fix potential crash bug

2018-07-15 Thread Xiubo Li
On 2018/7/13 4:34, Hamish Martin wrote: Hi Xiubo, Tested-by: Hamish Martin I see these were already merged into Linus' tree but I wanted to let you know that I tested v4.18-rc4 (which contains these three patches) and the issue which led to my original series is still fixed and this patch

Re: [PATCH v4 0/3] uio: fix potential crash bug

2018-07-15 Thread Xiubo Li
On 2018/7/13 4:34, Hamish Martin wrote: Hi Xiubo, Tested-by: Hamish Martin I see these were already merged into Linus' tree but I wanted to let you know that I tested v4.18-rc4 (which contains these three patches) and the issue which led to my original series is still fixed and this patch

Re: [V9fs-developer] [PATCH] net/9p: Fix a deadlock case in the virtio transport

2018-07-15 Thread jiangyiwen
On 2018/7/14 20:47, Dominique Martinet wrote: > jiangyiwen wrote on Sat, Jul 14, 2018: >> On 2018/7/14 17:05, Dominique Martinet wrote: >>> jiangyiwen wrote on Sat, Jul 14, 2018: When client has multiple threads that issue io requests all the time, and the server has a very good

Re: [V9fs-developer] [PATCH] net/9p: Fix a deadlock case in the virtio transport

2018-07-15 Thread jiangyiwen
On 2018/7/14 20:47, Dominique Martinet wrote: > jiangyiwen wrote on Sat, Jul 14, 2018: >> On 2018/7/14 17:05, Dominique Martinet wrote: >>> jiangyiwen wrote on Sat, Jul 14, 2018: When client has multiple threads that issue io requests all the time, and the server has a very good

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-15 Thread Yafang Shao
On Sun, Jul 15, 2018 at 11:04 PM, Shakeel Butt wrote: > On Sun, Jul 15, 2018 at 1:02 AM Yafang Shao wrote: >> >> On Sun, Jul 15, 2018 at 2:34 PM, Shakeel Butt wrote: >> > On Sat, Jul 14, 2018 at 10:26 PM Yafang Shao wrote: >> >> >> >> On Sun, Jul 15, 2018 at 12:25 PM, Shakeel Butt >> >>

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-15 Thread Yafang Shao
On Sun, Jul 15, 2018 at 11:04 PM, Shakeel Butt wrote: > On Sun, Jul 15, 2018 at 1:02 AM Yafang Shao wrote: >> >> On Sun, Jul 15, 2018 at 2:34 PM, Shakeel Butt wrote: >> > On Sat, Jul 14, 2018 at 10:26 PM Yafang Shao wrote: >> >> >> >> On Sun, Jul 15, 2018 at 12:25 PM, Shakeel Butt >> >>

Re: [PATCH] x86/mtrr: don't copy out-of-bounds data in mtrr_write

2018-07-15 Thread Linus Torvalds
On Sun, Jul 15, 2018 at 6:33 PM Jann Horn wrote: > > +Linus, Andy, Al from the other thread > > On Mon, Jul 16, 2018 at 12:03 AM Ingo Molnar wrote: > > > > BTW., a naive question: would it make sense to simply disallow 'special' > > fds to be passed to setuid binaries, and fix any user-space

Re: [PATCH] x86/mtrr: don't copy out-of-bounds data in mtrr_write

2018-07-15 Thread Linus Torvalds
On Sun, Jul 15, 2018 at 6:33 PM Jann Horn wrote: > > +Linus, Andy, Al from the other thread > > On Mon, Jul 16, 2018 at 12:03 AM Ingo Molnar wrote: > > > > BTW., a naive question: would it make sense to simply disallow 'special' > > fds to be passed to setuid binaries, and fix any user-space

Re: [PATCH] x86/mtrr: don't copy out-of-bounds data in mtrr_write

2018-07-15 Thread Jann Horn
+Linus, Andy, Al from the other thread On Mon, Jul 16, 2018 at 12:03 AM Ingo Molnar wrote: > * Jann Horn wrote: > > > - A malicious user can pass an arbitrary file to a setuid binary as > > stdin/stdout/stderr. When the setuid binary (expecting stdin/stdout to > > be something normal, like a

Re: [PATCH] x86/mtrr: don't copy out-of-bounds data in mtrr_write

2018-07-15 Thread Jann Horn
+Linus, Andy, Al from the other thread On Mon, Jul 16, 2018 at 12:03 AM Ingo Molnar wrote: > * Jann Horn wrote: > > > - A malicious user can pass an arbitrary file to a setuid binary as > > stdin/stdout/stderr. When the setuid binary (expecting stdin/stdout to > > be something normal, like a

Re: [V9fs-developer] [PATCH] net/9p/client.c: fix misuse of spin_lock_irqsave for p9_client lock

2018-07-15 Thread piaojun
Hi Dominique, On 2018/7/12 15:01, Dominique Martinet wrote: > piaojun wrote on Thu, Jul 12, 2018: >> In p9_read_work(), we use spin_lock for client->lock, but misuse >> spin_lock_irqsave for it in p9_fid_create(). As p9_client lock won't be >> locked in irq context, so spin_lock is enough. And

Re: [V9fs-developer] [PATCH] net/9p/client.c: fix misuse of spin_lock_irqsave for p9_client lock

2018-07-15 Thread piaojun
Hi Dominique, On 2018/7/12 15:01, Dominique Martinet wrote: > piaojun wrote on Thu, Jul 12, 2018: >> In p9_read_work(), we use spin_lock for client->lock, but misuse >> spin_lock_irqsave for it in p9_fid_create(). As p9_client lock won't be >> locked in irq context, so spin_lock is enough. And

Re: [PATCH - revised] rhashtable: detect when object movement might have invalidated a lookup

2018-07-15 Thread NeilBrown
On Mon, Jul 16 2018, Herbert Xu wrote: > On Mon, Jul 16, 2018 at 09:57:11AM +1000, NeilBrown wrote: >> >> Some users of rhashtable might need to change the key >> of an object and move it to a different location in the table. >> Other users might want to allocate objects using >>

Re: [PATCH - revised] rhashtable: detect when object movement might have invalidated a lookup

2018-07-15 Thread NeilBrown
On Mon, Jul 16 2018, Herbert Xu wrote: > On Mon, Jul 16, 2018 at 09:57:11AM +1000, NeilBrown wrote: >> >> Some users of rhashtable might need to change the key >> of an object and move it to a different location in the table. >> Other users might want to allocate objects using >>

Re: [PATCH 1/7] mm: allocate mm_cpumask dynamically based on nr_cpu_ids

2018-07-15 Thread Ingo Molnar
* Rik van Riel wrote: > On Mon, 2018-07-16 at 00:59 +0200, Ingo Molnar wrote: > > * Rik van Riel wrote: > > > > > The mm_struct always contains a cpumask bitmap, regardless of > > > CONFIG_CPUMASK_OFFSTACK. That means the first step can be to > > > simplify things, and simply have one

Re: [PATCH 1/7] mm: allocate mm_cpumask dynamically based on nr_cpu_ids

2018-07-15 Thread Ingo Molnar
* Rik van Riel wrote: > On Mon, 2018-07-16 at 00:59 +0200, Ingo Molnar wrote: > > * Rik van Riel wrote: > > > > > The mm_struct always contains a cpumask bitmap, regardless of > > > CONFIG_CPUMASK_OFFSTACK. That means the first step can be to > > > simplify things, and simply have one

Re: [PATCH 7/7] x86,switch_mm: skip atomic operations for init_mm

2018-07-15 Thread Ingo Molnar
* Rik van Riel wrote: > On Mon, 2018-07-16 at 01:04 +0200, Ingo Molnar wrote: > > * Rik van Riel wrote: > > > > > + /* > > > + * Stop remote flushes for the previous mm. > > > + * Skip the idle task; we never send init_mm TLB > > > flushing IPIs, > > > + *

Re: [PATCH 7/7] x86,switch_mm: skip atomic operations for init_mm

2018-07-15 Thread Ingo Molnar
* Rik van Riel wrote: > On Mon, 2018-07-16 at 01:04 +0200, Ingo Molnar wrote: > > * Rik van Riel wrote: > > > > > + /* > > > + * Stop remote flushes for the previous mm. > > > + * Skip the idle task; we never send init_mm TLB > > > flushing IPIs, > > > + *

Re: [PATCH 2/8] efi/x86: Use non-blocking SetVariable() for efi_delete_dummy_variable()

2018-07-15 Thread Ingo Molnar
* Prakhya, Sai Praneeth wrote: > > > diff --git a/arch/x86/platform/efi/quirks.c > > > b/arch/x86/platform/efi/quirks.c index 36c1f8b9f7e0..6af39dc40325 > > > 100644 > > > --- a/arch/x86/platform/efi/quirks.c > > > +++ b/arch/x86/platform/efi/quirks.c > > > @@ -105,12 +105,11 @@

Re: [PATCH 2/8] efi/x86: Use non-blocking SetVariable() for efi_delete_dummy_variable()

2018-07-15 Thread Ingo Molnar
* Prakhya, Sai Praneeth wrote: > > > diff --git a/arch/x86/platform/efi/quirks.c > > > b/arch/x86/platform/efi/quirks.c index 36c1f8b9f7e0..6af39dc40325 > > > 100644 > > > --- a/arch/x86/platform/efi/quirks.c > > > +++ b/arch/x86/platform/efi/quirks.c > > > @@ -105,12 +105,11 @@

Re: Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-15 Thread David Lechner
On 07/15/2018 07:22 AM, Jacek Anaszewski wrote: On 07/15/2018 12:39 AM, Pavel Machek wrote: On Sun 2018-07-15 00:29:25, Pavel Machek wrote: On Sun 2018-07-15 00:02:57, Jacek Anaszewski wrote: Hi Pavel, On 07/14/2018 11:20 PM, Pavel Machek wrote: Hi! It also drew my attention to the issue

Re: Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-15 Thread David Lechner
On 07/15/2018 07:22 AM, Jacek Anaszewski wrote: On 07/15/2018 12:39 AM, Pavel Machek wrote: On Sun 2018-07-15 00:29:25, Pavel Machek wrote: On Sun 2018-07-15 00:02:57, Jacek Anaszewski wrote: Hi Pavel, On 07/14/2018 11:20 PM, Pavel Machek wrote: Hi! It also drew my attention to the issue

Re: [RFC PATCH v2 1/4] dt-bindings: misc: Add bindings for misc. BMC control fields

2018-07-15 Thread Andrew Jeffery
Hi Alexander, I've rearranged your reply slightly :) On Sat, 14 Jul 2018, at 00:44, Alexander Amelkin wrote: > > So I'm writing this to support your position in this discussion and to > let Rob and other reviewers know that this feature is actually needed. Thanks. So to summarise some other

Re: [RFC PATCH v2 1/4] dt-bindings: misc: Add bindings for misc. BMC control fields

2018-07-15 Thread Andrew Jeffery
Hi Alexander, I've rearranged your reply slightly :) On Sat, 14 Jul 2018, at 00:44, Alexander Amelkin wrote: > > So I'm writing this to support your position in this discussion and to > let Rob and other reviewers know that this feature is actually needed. Thanks. So to summarise some other

Re: [PATCH - revised] rhashtable: detect when object movement might have invalidated a lookup

2018-07-15 Thread Herbert Xu
On Mon, Jul 16, 2018 at 09:57:11AM +1000, NeilBrown wrote: > > Some users of rhashtable might need to change the key > of an object and move it to a different location in the table. > Other users might want to allocate objects using > SLAB_TYPESAFE_BY_RCU which can result in the same memory

Re: [PATCH - revised] rhashtable: detect when object movement might have invalidated a lookup

2018-07-15 Thread Herbert Xu
On Mon, Jul 16, 2018 at 09:57:11AM +1000, NeilBrown wrote: > > Some users of rhashtable might need to change the key > of an object and move it to a different location in the table. > Other users might want to allocate objects using > SLAB_TYPESAFE_BY_RCU which can result in the same memory

  1   2   3   4   5   >