Hi,
On Fri, Jul 27, 2018 at 10:07 PM, Stephen Boyd wrote:
> Quoting Amit Daniel Kachhap (2018-07-27 07:01:52)
>> This fix rounds the clock rate properly by using quotient and not
>> remainder in the calculation. This issue was found while testing HDMI
>> in the Juno platform.
>>
>>
Hi,
On Fri, Jul 27, 2018 at 10:07 PM, Stephen Boyd wrote:
> Quoting Amit Daniel Kachhap (2018-07-27 07:01:52)
>> This fix rounds the clock rate properly by using quotient and not
>> remainder in the calculation. This issue was found while testing HDMI
>> in the Juno platform.
>>
>>
Hello Trent and Andy,
> From: Trent Piepho [mailto:tpie...@impinj.com]
> Sent: Friday, July 27, 2018 2:02 AM
> To: andy.shevche...@gmail.com; Hayashibara, Keiji/林原 啓二
>
> Subject: Re: [PATCH v2 2/2] spi: add SPI controller driver for UniPhier SoC
>
> On Thu, 2018-07-26 at 11:46 +0300, Andy
Hello Trent and Andy,
> From: Trent Piepho [mailto:tpie...@impinj.com]
> Sent: Friday, July 27, 2018 2:02 AM
> To: andy.shevche...@gmail.com; Hayashibara, Keiji/林原 啓二
>
> Subject: Re: [PATCH v2 2/2] spi: add SPI controller driver for UniPhier SoC
>
> On Thu, 2018-07-26 at 11:46 +0300, Andy
Hi Cong,
On 7/28/18 8:24 AM, Cong Wang wrote:
> Each time we sync cfs_rq->runtime_expires with cfs_b->runtime_expires,
> we should sync its ->expires_seq too. However it is missing
> for distribute_cfs_runtime(), especially the slack timer call path.
I don't think it's a problem, as expires_seq
Hi Cong,
On 7/28/18 8:24 AM, Cong Wang wrote:
> Each time we sync cfs_rq->runtime_expires with cfs_b->runtime_expires,
> we should sync its ->expires_seq too. However it is missing
> for distribute_cfs_runtime(), especially the slack timer call path.
I don't think it's a problem, as expires_seq
Hi.
Many thanks for the response! Some replies inline.
On Sun, 2018-07-22 at 22:42 +0300, Andy Shevchenko wrote:
> On Sun, Jul 22, 2018 at 1:36 AM, Lubomir Rintel
> wrote:
> > This driver switches the P10T tablet to "Android" mode, where the
> > Home
> > button sends a single sancode instead of
Hi.
Many thanks for the response! Some replies inline.
On Sun, 2018-07-22 at 22:42 +0300, Andy Shevchenko wrote:
> On Sun, Jul 22, 2018 at 1:36 AM, Lubomir Rintel
> wrote:
> > This driver switches the P10T tablet to "Android" mode, where the
> > Home
> > button sends a single sancode instead of
Dear Friend,
Good day, this is Mr. Henri Zongo, I'm happy to inform you about my success in
getting the fund $29.6Million transferred under the co-operation of a new
partner from Dubai, Presently I'm in Dubai for investment projects with my own
share of the total sum. Meanwhile,I didn't
Dear Friend,
Good day, this is Mr. Henri Zongo, I'm happy to inform you about my success in
getting the fund $29.6Million transferred under the co-operation of a new
partner from Dubai, Presently I'm in Dubai for investment projects with my own
share of the total sum. Meanwhile,I didn't
On Mon, Jul 30, 2018 at 1:04 AM, Al Viro wrote:
> From: Miklos Szeredi
>
> iput() ends up calling ->evict() on new inode, which is not yet initialized
> by owning fs. So use destroy_inode() instead.
>
> Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning
> that it wasn't
On Mon, Jul 30, 2018 at 1:04 AM, Al Viro wrote:
> From: Miklos Szeredi
>
> iput() ends up calling ->evict() on new inode, which is not yet initialized
> by owning fs. So use destroy_inode() instead.
>
> Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning
> that it wasn't
On 24-07-18, 01:46, Robin Gong wrote:
> Add macro SDMA_BD_MAX_CNT to replace '0x'.
Applied, thanks
--
~Vinod
On 24-07-18, 01:46, Robin Gong wrote:
> Add MEMCPY capability for imx-sdma driver.
Applied, thanks
--
~Vinod
On 24-07-18, 01:46, Robin Gong wrote:
> Add macro SDMA_BD_MAX_CNT to replace '0x'.
Applied, thanks
--
~Vinod
On 24-07-18, 01:46, Robin Gong wrote:
> Add MEMCPY capability for imx-sdma driver.
Applied, thanks
--
~Vinod
On Sat, Jul 28, 2018 at 8:34 PM, Jens Axboe wrote:
> On 7/28/18 3:50 AM, Souptick Joarder wrote:
>> out_unlock:
>> unlock_page(page);
>> + ret = block_page_mkwrite_return(err);
>> return ret;
>
> return block_page_mkwrite_return(err);
>
> --
> Jens Axboe
>
OK, I will
On Sat, Jul 28, 2018 at 8:34 PM, Jens Axboe wrote:
> On 7/28/18 3:50 AM, Souptick Joarder wrote:
>> out_unlock:
>> unlock_page(page);
>> + ret = block_page_mkwrite_return(err);
>> return ret;
>
> return block_page_mkwrite_return(err);
>
> --
> Jens Axboe
>
OK, I will
On 27-07-18, 13:17, Srinivas Kandagatla wrote:
> Thankyou for reviewing v1 patchset, here is v2 addressing comments from v1.
>
> Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC.
> It is integrated in multiple Qualcomm SoCs like: MSM8996, MSM8976,
> and MSM8956 chipsets.
>
> WCD9335
On 27-07-18, 13:17, Srinivas Kandagatla wrote:
> Thankyou for reviewing v1 patchset, here is v2 addressing comments from v1.
>
> Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC.
> It is integrated in multiple Qualcomm SoCs like: MSM8996, MSM8976,
> and MSM8956 chipsets.
>
> WCD9335
On 27-07-18, 13:17, Srinivas Kandagatla wrote:
> +obj-$(CONFIG_MFD_WCD9335)+= wcd9335.o
> +wcd9335-objs := wcd9335-core.o
> +
no slimbus objs?
> +static int wcd9335_bring_up(struct wcd9335 *wcd)
> +{
> + struct regmap *rm = wcd->regmap;
> + int val, byte0;
> + int
On 27-07-18, 13:17, Srinivas Kandagatla wrote:
> +obj-$(CONFIG_MFD_WCD9335)+= wcd9335.o
> +wcd9335-objs := wcd9335-core.o
> +
no slimbus objs?
> +static int wcd9335_bring_up(struct wcd9335 *wcd)
> +{
> + struct regmap *rm = wcd->regmap;
> + int val, byte0;
> + int
Hello Linus,
I have sent modified patch for this bag as v2.
Please refer to the following.
[PATCH v2]
https://patchwork.kernel.org/patch/10533929/
[Changes since v1]
diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c
b/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c
-index
Hello Linus,
I have sent modified patch for this bag as v2.
Please refer to the following.
[PATCH v2]
https://patchwork.kernel.org/patch/10533929/
[Changes since v1]
diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c
b/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c
-index
Hi
My name is Wang Shengkun, i am a software programmer and i work with a lottery
company over here in the United States. I can give you the winning numbers in
our admin to play and win the lottery and we will share the proceeds 50% each.
If you are interested , kindly write me back at :
Hi
My name is Wang Shengkun, i am a software programmer and i work with a lottery
company over here in the United States. I can give you the winning numbers in
our admin to play and win the lottery and we will share the proceeds 50% each.
If you are interested , kindly write me back at :
On Mon, 30 Jul 2018 03:11:59 +
Matthew Leon wrote:
> >> Hey Jisheng,
>
> >Hi,
>
> >>
>
> >In LKML, we'd better not top post.
>
> Noted. My apologies.
>
> >> Shouldn't we be splitting until all DMA blocks are less than 128M
> boundary?
> >> I am a noob, but I think we should
On Mon, 30 Jul 2018 03:11:59 +
Matthew Leon wrote:
> >> Hey Jisheng,
>
> >Hi,
>
> >>
>
> >In LKML, we'd better not top post.
>
> Noted. My apologies.
>
> >> Shouldn't we be splitting until all DMA blocks are less than 128M
> boundary?
> >> I am a noob, but I think we should
>> Hey Jisheng,
>Hi,
>>
>In LKML, we'd better not top post.
Noted. My apologies.
>> Shouldn't we be splitting until all DMA blocks are less than 128M
boundary?
>> I am a noob, but I think we should be prepared for boundaries that when
>> split in two, will still be greater than 128M. Feel
>> Hey Jisheng,
>Hi,
>>
>In LKML, we'd better not top post.
Noted. My apologies.
>> Shouldn't we be splitting until all DMA blocks are less than 128M
boundary?
>> I am a noob, but I think we should be prepared for boundaries that when
>> split in two, will still be greater than 128M. Feel
On Mon, 30 Jul 2018 02:56:20 + Matthew Leon wrote:
> Hey Jisheng,
Hi,
>
In LKML, we'd better not top post.
> Shouldn't we be splitting until all DMA blocks are less than 128M boundary?
> I am a noob, but I think we should be prepared for boundaries that when
> split in two, will still
On Mon, 30 Jul 2018 02:56:20 + Matthew Leon wrote:
> Hey Jisheng,
Hi,
>
In LKML, we'd better not top post.
> Shouldn't we be splitting until all DMA blocks are less than 128M boundary?
> I am a noob, but I think we should be prepared for boundaries that when
> split in two, will still
Hey Jisheng,
Shouldn't we be splitting until all DMA blocks are less than 128M boundary?
I am a noob, but I think we should be prepared for boundaries that when
split in two, will still be greater than 128M. Feel free to disagree but
please explain why I may be wrong. Thank-you.
Sincerely,
Hey Jisheng,
Shouldn't we be splitting until all DMA blocks are less than 128M boundary?
I am a noob, but I think we should be prepared for boundaries that when
split in two, will still be greater than 128M. Feel free to disagree but
please explain why I may be wrong. Thank-you.
Sincerely,
When using DMA, if the DMA addr spans 128MB boundary, we have to split
the DMA transfer into two so that each one doesn't exceed the boundary.
Signed-off-by: Jisheng Zhang
---
drivers/mmc/host/sdhci-of-dwcmshc.c | 43 +
1 file changed, 43 insertions(+)
diff --git
When using DMA, if the DMA addr spans 128MB boundary, we have to split
the DMA transfer into two so that each one doesn't exceed the boundary.
Signed-off-by: Jisheng Zhang
---
drivers/mmc/host/sdhci-of-dwcmshc.c | 43 +
1 file changed, 43 insertions(+)
diff --git
Hi Saravanan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pinctrl/devel]
[also build test ERROR on next-20180727]
[cannot apply to v4.18-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Hi Saravanan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pinctrl/devel]
[also build test ERROR on next-20180727]
[cannot apply to v4.18-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Add this hook so that it can be overridden with driver specific
implementations. We also rename the original sdhci_adma_write_desc()
to _sdhci_adma_write_desc() and export it, so that it could be reused
by driver's specific implementations.
Signed-off-by: Jisheng Zhang
---
Add this hook so that it can be overridden with driver specific
implementations. We also rename the original sdhci_adma_write_desc()
to _sdhci_adma_write_desc() and export it, so that it could be reused
by driver's specific implementations.
Signed-off-by: Jisheng Zhang
---
This patch adds adma_table_num member to struct sdhci_host to give more
flexibility to drivers to control the ADMA table number.
Default value of adma_table_num is set to (SDHCI_MAX_SEGS * 2 + 1).
Signed-off-by: Jisheng Zhang
---
drivers/mmc/host/sdhci.c | 17 +
This patch adds adma_table_num member to struct sdhci_host to give more
flexibility to drivers to control the ADMA table number.
Default value of adma_table_num is set to (SDHCI_MAX_SEGS * 2 + 1).
Signed-off-by: Jisheng Zhang
---
drivers/mmc/host/sdhci.c | 17 +
When using DMA, if the DMA addr spans 128MB boundary, we have to split
the DMA transfer into two so that each one doesn't exceed the boundary.
patch1 adds adma_table_num to struct sdhci_host so that driver can
control the ADMA table number.
patch2 introduces adma_write_desc() hook to struct
When using DMA, if the DMA addr spans 128MB boundary, we have to split
the DMA transfer into two so that each one doesn't exceed the boundary.
patch1 adds adma_table_num to struct sdhci_host so that driver can
control the ADMA table number.
patch2 introduces adma_write_desc() hook to struct
From: Levin Du
ROC-RK3399-PC is a power efficient 4GB LPDDR4 single board
computer with USB 3.0 and Gigabit Ethernet in a form factor
compatible with the Raspberry Pi. It is based on the Rockchip
RK3399 SoC, powered by the Type-C port.
The devicetree currently supports peripherals of:
-
From: Levin Du
ROC-RK3399-PC is a power efficient 4GB LPDDR4 single board
computer with USB 3.0 and Gigabit Ethernet in a form factor
compatible with the Raspberry Pi. It is based on the Rockchip
RK3399 SoC, powered by the Type-C port.
The devicetree currently supports peripherals of:
-
Hi Rafael,
After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized in
this function [-Wmaybe-uninitialized]
Hi Rafael,
After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized in
this function [-Wmaybe-uninitialized]
Hello Andy,
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Andy
> Shevchenko
> Sent: Thursday, July 26, 2018 10:44 PM
> To: Hayashibara, Keiji/林原 啓二
> Cc: Mark Brown ; Rob Herring ; Mark
> Rutland ;
> Yamada,
Hello Andy,
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Andy
> Shevchenko
> Sent: Thursday, July 26, 2018 10:44 PM
> To: Hayashibara, Keiji/林原 啓二
> Cc: Mark Brown ; Rob Herring ; Mark
> Rutland ;
> Yamada,
On Tue, 2018-07-24 at 17:34 +0300, Anton Vasilyev wrote:
> ish_dev_init() allocates 512*176 bytes memory for tx_buf and stores
> it at
> >wr_free_list_head.link list on ish_probe().
> But there is no deallocation of this memory in ish_remove() and in
> ish_probe() error path.
> So current
On Tue, 2018-07-24 at 17:34 +0300, Anton Vasilyev wrote:
> ish_dev_init() allocates 512*176 bytes memory for tx_buf and stores
> it at
> >wr_free_list_head.link list on ish_probe().
> But there is no deallocation of this memory in ish_remove() and in
> ish_probe() error path.
> So current
Hello Radu,
> From: Radu Pirea [mailto:radu.pi...@microchip.com]
> Sent: Thursday, July 26, 2018 7:58 PM
> To: Hayashibara, Keiji/林原 啓二 ; 'Andy
> Shevchenko'
>
> Subject: Re: [PATCH v2 2/2] spi: add SPI controller driver for UniPhier SoC
>
>
>
> On 07/26/2018 12:38 PM, Keiji Hayashibara
Hello Radu,
> From: Radu Pirea [mailto:radu.pi...@microchip.com]
> Sent: Thursday, July 26, 2018 7:58 PM
> To: Hayashibara, Keiji/林原 啓二 ; 'Andy
> Shevchenko'
>
> Subject: Re: [PATCH v2 2/2] spi: add SPI controller driver for UniPhier SoC
>
>
>
> On 07/26/2018 12:38 PM, Keiji Hayashibara
Hi Alexei,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: acb1872577b346bd15ab3a3f8dff780d6cca4b70
commit: 819dd92b9c0bc7bce9097d8c1f14240f471bb386 bpfilter: switch to CC from
HOSTCC
date: 8 weeks ago
config:
Hi Alexei,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: acb1872577b346bd15ab3a3f8dff780d6cca4b70
commit: 819dd92b9c0bc7bce9097d8c1f14240f471bb386 bpfilter: switch to CC from
HOSTCC
date: 8 weeks ago
config:
Hi Linus,
On 30 July 2018 at 00:59, Linus Walleij wrote:
> On Thu, Jul 26, 2018 at 2:01 AM Tomer Maimon wrote:
>
> > I initialize bgpio as follow:
> >
> > ret = bgpio_init(>gpio_bank[id].gc,
> > pctrl->dev, 4,
> >
Hi Linus,
On 30 July 2018 at 00:59, Linus Walleij wrote:
> On Thu, Jul 26, 2018 at 2:01 AM Tomer Maimon wrote:
>
> > I initialize bgpio as follow:
> >
> > ret = bgpio_init(>gpio_bank[id].gc,
> > pctrl->dev, 4,
> >
syzbot has found a reproducer for the following crash on:
HEAD commit:d1e0b8e0cb7a Add linux-next specific files for 20180725
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=10eff97840
kernel config:
syzbot has found a reproducer for the following crash on:
HEAD commit:d1e0b8e0cb7a Add linux-next specific files for 20180725
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=10eff97840
kernel config:
Thank you, i found a few case on this module i will try to fix them
and send a new patch series.
On Sun, 29 Jul 2018 at 20:33, Joe Perches wrote:
>
> On Sun, 2018-07-29 at 17:43 +0300, Georgios Tsotsos wrote:
> > Fixing coding style for a few lines that were reported to check from
> >
Thank you, i found a few case on this module i will try to fix them
and send a new patch series.
On Sun, 29 Jul 2018 at 20:33, Joe Perches wrote:
>
> On Sun, 2018-07-29 at 17:43 +0300, Georgios Tsotsos wrote:
> > Fixing coding style for a few lines that were reported to check from
> >
Replaced -1 with defined error code EINVAL
Signed-off-by: Georgios Tsotsos
---
v2: Apply coding style to function cvmx_usb_poll_channel
v3: Break down function cvmx_usb_poll_channel
v4: Return defined error code and applying coding style for function calls
v5: Fixing wrong patch applied before
Replaced -1 with defined error code EINVAL
Signed-off-by: Georgios Tsotsos
---
v2: Apply coding style to function cvmx_usb_poll_channel
v3: Break down function cvmx_usb_poll_channel
v4: Return defined error code and applying coding style for function calls
v5: Fixing wrong patch applied before
Replacing CVMX_WAIT_FOR_FIELD32 macro with equivalent function, and used
simpler approach for new function's parameters.
Signed-off-by: Georgios Tsotsos
---
v3: Changed CVMX_WAIT_FOR_FIELD32 macro to function according as refereed in
commit message and suggested by Greg Kroah-Hartman
v4: Added
Replacing CVMX_WAIT_FOR_FIELD32 macro with equivalent function, and used
simpler approach for new function's parameters.
Signed-off-by: Georgios Tsotsos
---
v3: Changed CVMX_WAIT_FOR_FIELD32 macro to function according as refereed in
commit message and suggested by Greg Kroah-Hartman
v4: Added
So unless something odd happens, this should be the last rc for 4.18.
Nothing particularly odd happened this last week - we got the usual
random set of various minor fixes all over. About two thirds of it is
drivers - networking, staging and usb stands out, but there's a little
bit of stuff all
So unless something odd happens, this should be the last rc for 4.18.
Nothing particularly odd happened this last week - we got the usual
random set of various minor fixes all over. About two thirds of it is
drivers - networking, staging and usb stands out, but there's a little
bit of stuff all
From: Al Viro
we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.
Signed-off-by: Al Viro
---
fs/udf/namei.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/udf/namei.c b/fs/udf/namei.c
index
From: Al Viro
Signed-off-by: Al Viro
---
fs/ext2/ialloc.c | 3 +--
fs/ext2/namei.c | 9 +++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index 6484199b35d1..5c3d7b7e4975 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -611,8
From: Al Viro
Since NFS allows open-by-fhandle, we have to cope with the possibility
of mkdir vs. open-by-guessed-handle races. A local filesystem could
decide what the inumber of the new object will be and insert a locked
inode with that inumber into icache _before_ the on-disk data structures
From: Al Viro
we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.
Signed-off-by: Al Viro
---
fs/udf/namei.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/udf/namei.c b/fs/udf/namei.c
index
From: Al Viro
Signed-off-by: Al Viro
---
fs/ext2/ialloc.c | 3 +--
fs/ext2/namei.c | 9 +++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index 6484199b35d1..5c3d7b7e4975 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -611,8
From: Al Viro
Since NFS allows open-by-fhandle, we have to cope with the possibility
of mkdir vs. open-by-guessed-handle races. A local filesystem could
decide what the inumber of the new object will be and insert a locked
inode with that inumber into icache _before_ the on-disk data structures
From: Al Viro
Make sure that no partially set up inodes can be returned by
open-by-handle.
Signed-off-by: Al Viro
---
fs/btrfs/inode.c | 106 ---
1 file changed, 39 insertions(+), 67 deletions(-)
diff --git a/fs/btrfs/inode.c
From: Al Viro
Make sure that no partially set up inodes can be returned by
open-by-handle.
Signed-off-by: Al Viro
---
fs/btrfs/inode.c | 106 ---
1 file changed, 39 insertions(+), 67 deletions(-)
diff --git a/fs/btrfs/inode.c
From: Al Viro
Cc: Chris Mason
Signed-off-by: Al Viro
---
fs/btrfs/transaction.c | 2 +-
fs/btrfs/tree-log.c| 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index ff5f6c719976..feb0348dbcbf 100644
---
From: Al Viro
Cc: Chris Mason
Signed-off-by: Al Viro
---
fs/btrfs/transaction.c | 2 +-
fs/btrfs/tree-log.c| 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index ff5f6c719976..feb0348dbcbf 100644
---
From: Miklos Szeredi
iput() ends up calling ->evict() on new inode, which is not yet initialized
by owning fs. So use destroy_inode() instead.
Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning
that it wasn't allocated with new_inode(), which already does the
From: Miklos Szeredi
iput() ends up calling ->evict() on new inode, which is not yet initialized
by owning fs. So use destroy_inode() instead.
Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning
that it wasn't allocated with new_inode(), which already does the
From: Al Viro
don't open-code iget_failed(), don't bother with btrfs_free_path(NULL),
move handling of positive return values of btrfs_lookup_inode() from
btrfs_read_locked_inode() to btrfs_iget() and kill now obviously pointless
ASSERT() in there.
Signed-off-by: Al Viro
---
fs/btrfs/inode.c
From: Al Viro
don't open-code iget_failed(), don't bother with btrfs_free_path(NULL),
move handling of positive return values of btrfs_lookup_inode() from
btrfs_read_locked_inode() to btrfs_iget() and kill now obviously pointless
ASSERT() in there.
Signed-off-by: Al Viro
---
fs/btrfs/inode.c
From: Al Viro
We don't want open-by-handle picking half-set-up in-core
struct inode from e.g. mkdir() having failed halfway through.
In other words, we don't want such inodes returned by iget_locked()
on their way to extinction. However, we can't just have them
unhashed - otherwise
From: Al Viro
We don't want open-by-handle picking half-set-up in-core
struct inode from e.g. mkdir() having failed halfway through.
In other words, we don't want such inodes returned by iget_locked()
on their way to extinction. However, we can't just have them
unhashed - otherwise
From: Al Viro
just get rid of pointless checks
Cc: Chris Mason
Signed-off-by: Al Viro
---
fs/btrfs/free-space-cache.c | 4
fs/btrfs/relocation.c | 7 ++-
fs/btrfs/tree-log.c | 6 +-
3 files changed, 3 insertions(+), 14 deletions(-)
diff --git
From: Al Viro
just get rid of pointless checks
Cc: Chris Mason
Signed-off-by: Al Viro
---
fs/btrfs/free-space-cache.c | 4
fs/btrfs/relocation.c | 7 ++-
fs/btrfs/tree-log.c | 6 +-
3 files changed, 3 insertions(+), 14 deletions(-)
diff --git
From: Al Viro
We never look them up in there; inode_fake_hash() will make them appear
hashed for mark_inode_dirty() purposes. And don't leave them around
until memory pressure kicks them out - we never look them up again.
Signed-off-by: Al Viro
---
fs/adfs/inode.c | 2 +-
fs/adfs/super.c | 1
From: Al Viro
The only user is fuse_create_new_entry(), and there it's used to
mitigate the same mkdir/open-by-handle race as in nfs_mkdir().
The same solution applies - unhash the mkdir argument, then
call d_splice_alias() and if that returns a reference to preexisting
alias, dput() and report
From: Al Viro
open-coded in a quite a few places...
Signed-off-by: Al Viro
---
fs/hfs/inode.c | 2 +-
fs/jfs/jfs_imap.c | 8 +---
fs/jfs/super.c | 2 +-
fs/xfs/xfs_iops.c | 2 +-
include/linux/fs.h | 11 +++
5 files changed, 15 insertions(+), 10 deletions(-)
diff
From: Al Viro
we don't need to check is_bad_inode() after the call of
btrfs_read_locked_inode() - it's exactly the same as checking
return value for being non-zero.
Signed-off-by: Al Viro
---
fs/btrfs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Al Viro
We hit that when inumber allocation has failed. In that case
the in-core inode is not hashed and since its ->i_nlink is 1
the only place where jfs checks is_bad_inode() won't be reached.
Signed-off-by: Al Viro
---
fs/jfs/jfs_inode.c | 2 --
1 file changed, 2 deletions(-)
diff
From: Al Viro
We never look them up in there; inode_fake_hash() will make them appear
hashed for mark_inode_dirty() purposes. And don't leave them around
until memory pressure kicks them out - we never look them up again.
Signed-off-by: Al Viro
---
fs/adfs/inode.c | 2 +-
fs/adfs/super.c | 1
From: Al Viro
The only user is fuse_create_new_entry(), and there it's used to
mitigate the same mkdir/open-by-handle race as in nfs_mkdir().
The same solution applies - unhash the mkdir argument, then
call d_splice_alias() and if that returns a reference to preexisting
alias, dput() and report
From: Al Viro
open-coded in a quite a few places...
Signed-off-by: Al Viro
---
fs/hfs/inode.c | 2 +-
fs/jfs/jfs_imap.c | 8 +---
fs/jfs/super.c | 2 +-
fs/xfs/xfs_iops.c | 2 +-
include/linux/fs.h | 11 +++
5 files changed, 15 insertions(+), 10 deletions(-)
diff
From: Al Viro
we don't need to check is_bad_inode() after the call of
btrfs_read_locked_inode() - it's exactly the same as checking
return value for being non-zero.
Signed-off-by: Al Viro
---
fs/btrfs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Al Viro
We hit that when inumber allocation has failed. In that case
the in-core inode is not hashed and since its ->i_nlink is 1
the only place where jfs checks is_bad_inode() won't be reached.
Signed-off-by: Al Viro
---
fs/jfs/jfs_inode.c | 2 --
1 file changed, 2 deletions(-)
diff
From: Al Viro
we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.
Signed-off-by: Al Viro
---
fs/ufs/ialloc.c | 3 +--
fs/ufs/namei.c | 9 +++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ufs/ialloc.c b/fs/ufs/ialloc.c
index
From: Al Viro
we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.
Signed-off-by: Al Viro
---
fs/jfs/jfs_inode.c | 8
fs/jfs/namei.c | 12
2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/fs/jfs/jfs_inode.c
From: Al Viro
we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.
Signed-off-by: Al Viro
---
fs/ufs/ialloc.c | 3 +--
fs/ufs/namei.c | 9 +++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ufs/ialloc.c b/fs/ufs/ialloc.c
index
From: Al Viro
we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.
Signed-off-by: Al Viro
---
fs/jfs/jfs_inode.c | 8
fs/jfs/namei.c | 12
2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/fs/jfs/jfs_inode.c
1 - 100 of 484 matches
Mail list logo
