Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver

2018-08-09 Thread Dan Murphy
On 08/09/2018 09:48 AM, Jacek Anaszewski wrote: > Dan, > > On 08/09/2018 03:30 PM, Dan Murphy wrote: >> Jacek and Pavel >> >> On 08/09/2018 07:09 AM, Jacek Anaszewski wrote: >>> Dan, >>> >>> On 08/08/2018 11:45 PM, Dan Murphy wrote: Jacek On 08/08/2018 04:09 PM, Jacek Anaszewski wro

[PATCH 30/44] perf annotate: Display percent type in stdio output

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa In following patches we will allow to switch percent type even for stdio annotation outputs. Adding the percent type value into the annotation outputs title. $ perf annotate --stdio Percent | Sou ... instructions:u } (2805 samples, percent: local period)

[PATCH 29/44] perf annotate: Make local period the default percent type

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Currently we display the percentages in annotation output based on number of samples hits. Switching it to period based percentage by default, because it corresponds more to the time spent on the line. Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: Alexander S

[PATCH 28/44] perf annotate: Add support to toggle percent type

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add new key bindings to toggle percent type/base in annotation UI browser: 'p' to switch between local and global percent type 'b' to switch between hits and perdio percent base Add the following help messages to the UI browser '?' window: ... p Toggle percent

[PATCH 31/44] perf annotate: Add --percent-type option

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add --percent-type option to set annotation percent type from following choices: global-period, local-period, global-hits, local-hits Examples: $ perf annotate --percent-type period-local --stdio | head -1 Percent | Source code ... es, percent: local period)

[PATCH 24/44] perf annotate: Add percent_type to struct annotation_options

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa It will be used to carry user selection of percent type for annotation output. Passing the percent_type to the annotation_line__print function as the first step and making it default to current percentage type (PERCENT_HITS_LOCAL) value. Signed-off-by: Jiri Olsa Cc: Alexander S

[PATCH 26/44] perf annotate: Pass 'struct annotation_options' to map_symbol__annotation_dump()

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Pass 'struct annotation_options' to map_symbol__annotation_dump(), to carry on and pass the percent_type value. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/2018080413

[PATCH 25/44] perf annotate: Pass struct annotation_options to symbol__calc_lines()

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Pass struct annotation_options to symbol__calc_lines(), to carry on and pass the percent_type value. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20180804130521.11408-

[PATCH 27/44] perf annotate: Pass browser percent_type in annotate_browser__calc_percent()

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Pass browser percent_type in annotate_browser__calc_percent(). Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20180804130521.11408-16-jo...@kernel.org Signed-off-by: Arn

[PATCH 23/44] perf annotate: Add PERCENT_PERIOD_GLOBAL percent value

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding and computing global period percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_PERIOD_GLOBAL index. At the moment it's not displayed, it's coming in following patches. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin C

[PATCH 22/44] perf annotate: Add PERCENT_PERIOD_LOCAL percent value

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding and computing local period percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_PERIOD_LOCAL index. At the moment it's not displayed, it's coming in following patches. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc:

[PATCH 18/44] perf annotate: Rename hist to sym_hist in annotation__calc_percent

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We will need to bring in 'struct hists' variable in this scope, so it's better we do this rename first. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20180804130521.114

[PATCH 21/44] perf annotate: Add PERCENT_HITS_GLOBAL percent value

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding and computing global hits percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_HITS_GLOBAL index. At the moment it's not displayed, it's coming in following patches. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: D

[PATCH 17/44] perf annotate: Rename local sample variables to data

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Based on previous rename, changing also the local variable names to fit properly. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20180804130521.11408-6-jo...@kernel.org

[PATCH 20/44] perf annotate: Switch struct annotation_data::percent to array

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa So we can hold multiple percent values for annotation line. The first member of this array is current local hits percent value (PERCENT_HITS_LOCAL index), so no functional change is expected. Adding annotation_data__percent function to return requested percent value from struct

[PATCH 19/44] perf annotate: Loop group events directly in annotation__calc_percent()

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We need to bring in 'struct hists' object and for that we need 'struct perf_evsel' object in the scope. Switching the group data loop with the evsel group loop. It does the same thing, but it brings evsel object, that we can use later get the 'struct hists' object. Signed-off-b

[PATCH 12/44] perf bpf: Add 'syscall_enter' probe helper for syscall enter tracepoints

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Allowing one to hook into the syscalls:sys_enter_NAME tracepoints, an example is provided that hooks into the 'openat' syscall. Using it with the probe:vfs_getname probe into getname_flags to get the filename args as it is copied from userspace: # perf probe -l

[PATCH 13/44] perf annotate: Make symbol__annotate_fprintf2() local

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no outside user of it. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: https://lkml.kernel.org/r/20180804130521.11408-2-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tool

[PATCH 16/44] perf annotate: Rename struct annotation_line::samples* to data*

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa The name 'samples*' is little confusing because we have nested 'struct sym_hist_entry' under annotation_line struct, which holds 'nr_samples' as well. Also the holding struct name is 'annotation_data' so the 'data' name fits better. Signed-off-by: Jiri Olsa Cc: Alexander Shishk

[PATCH 15/44] perf annotate: Get rid of annotation__scnprintf_samples_period()

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We have more current function tto get the title for annotation, which is hists__scnprintf_title. They both have same output as far as the annotation's header line goes. They differ in counting of the nr_samples, hists__scnprintf_title provides more accurate number based on the se

[PATCH 14/44] perf annotate: Make annotation_line__max_percent static

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no outside user of it. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20180804130521.11408-3-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools

[PATCH 11/44] perf tools: Drop unneeded bitmap_zero() calls

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Yury Norov bitmap_zero() is called after bitmap_alloc() in perf code. But bitmap_alloc() internally uses calloc() which guarantees that allocated area is zeroed. So following bitmap_zero is unneeded. Drop it. This happened because of confusing name for bitmap allocator. It should has name

[PATCH 10/44] perf vendor events arm64: Enable JSON events for eMAG

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Sean V Kelley This patch adds the Ampere Computing eMAG file. This platform follows the ARMv8 recommended IMPLEMENTATION DEFINED events, where applicable. Signed-off-by: Sean V Kelley Reviewed-by: John Garry Cc: Alexander Shishkin Cc: Ganapatrao Kulkarni Cc: Jiri Olsa Cc: Namhyung Ki

[PATCH 09/44] perf report: Add GUI report support for s390 auxiliary trace

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Add support for s390 auxiliary trace support. Use 'perf record -e rbd000 -- ls' to create the perf.data file. Use 'perf report' to display the auxiliary trace data. Output before: [root@s35lp76 perf]# ./perf report --stdio 0x128 [0x10]: failed to process type: 70 Er

[PATCH 08/44] perf report: Add raw report support for s390 auxiliary trace

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Add support for s390 auxiliary trace support. Use 'perf record -e rbd000' to create the perf.data file. The event also has the symbolic name SF_CYCLES_BASIC_DIAG, using 'perf record -e SF_CYCLES_BASIC_DIAG' is equivalent. Use 'perf report -D' to display the auxiliary trace

[PATCH 07/44] perf auxtrace: Support for perf report -D for s390

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Add initial support for s390 auxiliary traces using the CPU-Measurement Sampling Facility. Support and ignore PERF_REPORT_AUXTRACE_INFO records in the perf data file. Later patches will show the contents of the auxiliary traces. Setup the auxtrace queues and data structures

[PATCH 06/44] perf trace: Use perf_evsel__sc_tp_{uint,ptr} for "id"/"args" handling syscalls:* events

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Now it looks just about the same as for the trace__sys_{enter,exit}. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-y59may7zx1eccnp4m3qm4...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Me

[PATCH 05/44] perf trace: Setup struct syscall_tp for syscalls:sys_{enter,exit}_NAME events

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Mapping "__syscall_nr" to "id" and setting up "args" from the offset of "__syscall_nr" + sizeof(u64), as the payload for syscalls:* is the same as for raw_syscalls:*, just the fields have different names. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhy

[PATCH 04/44] perf trace: Allow setting up a syscall_tp struct without a format_field

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To avoid having to ask libtraceevent to find a field by name when handling each tracepoint event, we setup a struct syscall_tp with a tp_field struct having an extractor function + the offset for the "id", "args" and "ret" raw_syscalls:sys_{enter,exit} tracepoints.

[PATCH 03/44] perf trace: Rename some syscall_tp methods to raw_syscall

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Because raw_syscalls have the field for the syscall number as 'id' while the syscalls:sys_{enter,exit}_NAME have it as __syscall_nr... Since we want to support both for being able to enable just a syscalls:sys_{enter,exit}_name instead of asking for raw_syscalls:sy

[PATCH 02/44] perf trace: Use beautifiers on syscalls:sys_enter_ handlers

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We were using the beautifiers only when processing the raw_syscalls:sys_enter events, but we can as well use them for the syscalls:sys_enter_NAME events, as the layout is the same. Some more tweaking is needed as we're processing them straight away, i.e. there is n

[PATCH 01/44] perf trace: Associate vfs_getname()'ed pathname with fd returned from 'openat'

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo When the vfs_getname() wannabe tracepoint is in place: # perf probe -l probe:vfs_getname(on getname_flags:73@acme/git/linux/fs/namei.c with pathname) # 'perf trace' will use it to get the pathname when it is copied from userspace to the kernel, right

[GIT PULL 00/44] perf/core improvements and fixes

2018-08-09 Thread Arnaldo Carvalho de Melo
8-08-02 09:59:41 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.19-20180809 for you to fetch changes up to 6a9405b56c274024564f9014bba97b92c91b34d6: perf map: Optimize maps__fixup_overlappings() (2018-0

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Tom Zanussi
On Thu, 2018-08-09 at 10:55 -0400, Steven Rostedt wrote: > On Thu, 09 Aug 2018 09:51:37 -0500 > Tom Zanussi wrote: > > > Hi Steve, > > > > On Thu, 2018-08-09 at 10:47 -0400, Steven Rostedt wrote: > > > On Thu, 9 Aug 2018 09:34:10 -0500 > > > Tom Zanussi wrote: > > > > > > > From: Tom Zanuss

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Steven Rostedt
On Thu, 09 Aug 2018 09:51:37 -0500 Tom Zanussi wrote: > Hi Steve, > > On Thu, 2018-08-09 at 10:47 -0400, Steven Rostedt wrote: > > On Thu, 9 Aug 2018 09:34:10 -0500 > > Tom Zanussi wrote: > > > > > From: Tom Zanussi > > > > > > Hi, > > > > > > This is v3 of the hist trigger snapshot and

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Tom Zanussi
Hi Steve, On Thu, 2018-08-09 at 10:47 -0400, Steven Rostedt wrote: > On Thu, 9 Aug 2018 09:34:10 -0500 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Hi, > > > > This is v3 of the hist trigger snapshot and onchange additions > > patchset. It's rebased on top of the latest ftrace/core

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread Jeff Layton
On Thu, 2018-08-09 at 09:00 -0400, J. Bruce Fields wrote: > On Wed, Aug 08, 2018 at 06:50:06PM -0400, Jeff Layton wrote: > > That seems like a legit problem. > > > > One possible fix might be to have the waiter on (1,2) walk down the > > entire subtree and wake up any waiter that is waiting on a l

Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver

2018-08-09 Thread Jacek Anaszewski
Dan, On 08/09/2018 03:30 PM, Dan Murphy wrote: > Jacek and Pavel > > On 08/09/2018 07:09 AM, Jacek Anaszewski wrote: >> Dan, >> >> On 08/08/2018 11:45 PM, Dan Murphy wrote: >>> Jacek >>> >>> On 08/08/2018 04:09 PM, Jacek Anaszewski wrote: Hi Dan, On 08/08/2018 11:04 PM, Dan Murphy

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Steven Rostedt
On Thu, 9 Aug 2018 09:34:10 -0500 Tom Zanussi wrote: > From: Tom Zanussi > > Hi, > > This is v3 of the hist trigger snapshot and onchange additions > patchset. It's rebased on top of the latest ftrace/core and adds a > few fixes to some handler/action problems I noticed while testing. Hi To

Re: [Xen-devel] [PATCH] xen/netfront: don't cache skb_shinfo()

2018-08-09 Thread Wei Liu
On Thu, Aug 09, 2018 at 04:42:16PM +0200, Juergen Gross wrote: > skb_shinfo() can change when calling __pskb_pull_tail(): Don't cache > its return value. > > Cc: sta...@vger.kernel.org > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu

[PATCH v3 4/4] clk: imx: add clock driver for i.MX8MQ CCM

2018-08-09 Thread Abel Vesa
From: Lucas Stach Add driver for the Clock Control Module found on i.MX8MQ. This is largely based on the downstream driver from Anson Huang and Bai Ping at NXP, with only some small adaptions to mainline from me. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa --- drivers/clk/imx/Makefil

[PATCH v3 1/4] dt-bindings: add binding for i.MX8MQ CCM

2018-08-09 Thread Abel Vesa
From: Lucas Stach This adds the binding for the i.MX8MQ Clock Controller Module. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa --- .../devicetree/bindings/clock/imx8mq-clock.txt | 20 + include/dt-bindings/clock/imx8mq-clock.h | 629 + 2 files changed,

[PATCH v3 3/4] clk: imx: add SCCG PLL type

2018-08-09 Thread Abel Vesa
From: Lucas Stach The SCCG is a new PLL type introduced on i.MX8. Add support for this. The driver currently misses the PLL lock check, as the preliminary documentation mentions lock configurations, but is quiet about where to find the actual lock status signal. Signed-off-by: Lucas Stach Signe

[PATCH v3 2/4] clk: imx: add fractional PLL output clock

2018-08-09 Thread Abel Vesa
From: Lucas Stach This is a new clock type introduced on i.MX8. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa --- drivers/clk/imx/Makefile | 1 + drivers/clk/imx/clk-frac-pll.c | 230 + drivers/clk/imx/clk.h | 3 + 3 files chang

[PATCH v3 0/4] Add i.MX8MQ clock driver

2018-08-09 Thread Abel Vesa
This is basically just a resend of the following patchset: https://www.spinics.net/lists/linux-clk/msg23141.html I've just updated the patchset and implemented Shawn's and Aisheng's comments. I hope I haven't missed any of their comments. Lucas Stach (4): dt-bindings: add binding for i.MX8MQ

Re: [PATCH] zsmalloc: fix linking bug in init_zspage

2018-08-09 Thread Vlastimil Babka
On 08/09/2018 03:53 PM, zhouxianrong wrote: > The last partial object in last subpage of zspage should not be linked > in allocation list. Please expand the changelog. Why it should not be? What happens if it is? Kernel panic, data corruption or whatnot? So that people not familiar with zsmalloc i

Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-09 Thread Oleg Nesterov
I need to read this (hopefully final) version carefully. I'll try to do this before next Monday. just one note, On 08/09, Ravi Bangoria wrote: > > +static void delayed_uprobe_remove(struct uprobe *uprobe, struct mm_struct > *mm) > +{ > + struct list_head *pos, *q; > + struct delayed_upro

[PATCH] arm:pmsa-v8: remove some extra semicolon

2018-08-09 Thread zhong jiang
There are some extra semicolon in pmsa-v8.c. So just remove them. I detect the issue with the help of Coccinelle. Signed-off-by: zhong jiang --- arch/arm/mm/pmsa-v8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/pmsa-v8.c b/arch/arm/mm/pmsa-v8.c index 617a8

[PATCH v3 3/7] tracing: Generalize hist trigger onmax and save action

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi The action refactor code allowed actions and handlers to be separated, but the existing onmax handler and save action code is still not flexible enough to handle arbitrary coupling. This change generalizes them and in the process makes additional handlers and actions easier to

[PATCH v3 4/7] tracing: Add conditional snapshot

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Currently, tracing snapshots are context-free - they capture the ring buffer contents at the time the tracing_snapshot() function was invoked, and nothing else. Additionally, they're always taken unconditionally - the calling code can decide whether or not to take a snapshot, b

Re: [PATCH 28/33] vfs: syscall: Add fsconfig() for configuring and managing a context [ver #11]

2018-08-09 Thread Miklos Szeredi
On Thu, Aug 9, 2018 at 4:24 PM, David Howells wrote: > Eric W. Biederman wrote: > >> First let me thank you for adding both FSCONFIG_CMD_CREATE and >> FSCONFIG_CMD_RECONFIGURE. Unfortunately the implementation is currently >> broken. So this patch gets my: >> >> This is broken in two specific w

[PATCH v3 7/7] tracing: Add hist trigger onchange() handler

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Add support for a hist:onchange($var) handler, similar to the onmax() handler but triggering whenever there's any change in $var, not just a max. Signed-off-by: Tom Zanussi --- Documentation/trace/histogram.txt | 97 +++ kernel/trace/trace_

[PATCH v3 5/7] tracing: Move hist trigger key printing into a separate function

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Future patches will want to print a histogram key outside a histogram - add and use hist_trigger_print_key() for that purpose. Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --gi

[PATCH v3 6/7] tracing: Add snapshot action

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Add support for hist:handlerXXX($var).snapshot(), which will take a snapshot of the current trace buffer whenever handlerXXX is hit. As a first user, this also adds snapshot() action support for the onmax() handler i.e. hist:onmax($var).snapshot(). Signed-off-by: Tom Zanussi

[PATCH v3 2/7] tracing: Split up onmatch action data

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Currently, the onmatch action data binds the onmatch action to data related to synthetic event generation. Since we want to allow the onmatch handler to potentially invoke a different action, and because we expect other handlers to generate synthetic events, we need to separate

[PATCH v3 1/7] tracing: Refactor hist trigger action code

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi The hist trigger action code currently implements two essentially hard-coded pairs of 'actions' - onmax(), which tracks a variable and saves some event fields when a max is hit, and onmatch(), which is hard-coded to generate a synthetic event. These hardcoded pairs (track max/s

[PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Hi, This is v3 of the hist trigger snapshot and onchange additions patchset. It's rebased on top of the latest ftrace/core and adds a few fixes to some handler/action problems I noticed while testing. v2->v3 changes: - fixed problem where trace actions were only being allo

[PATCH v3 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-09 Thread Dominique Martinet
From: Dominique Martinet Having a specific cache for the fcall allocations helps speed up allocations a bit, especially in case of non-"round" msizes. The caches will automatically be merged if there are multiple caches of items with the same size so we do not need to try to share a cache betwee

[PATCH v3 1/2] net/9p: embed fcall in req to round down buffer allocs

2018-08-09 Thread Dominique Martinet
From: Dominique Martinet 'msize' is often a power of two, or at least page-aligned, so avoiding an overhead of two dozen bytes for each allocation will help the allocator do its work and reduce memory fragmentation. Suggested-by: Matthew Wilcox Signed-off-by: Dominique Martinet Reviewed-by: Gr

[PATCH 0/2] arm64: remove some extra semicolon

2018-08-09 Thread zhong jiang
There are some extra semicolon in arm64 architecture. Just remove them. zhong jiang (2): arm64/kprobes: remove an extra semicolon in arch_prepare_kprobe arm64:guest: remove some extra semicolon in kvm_target_cpu arch/arm64/kernel/probes/kprobes.c | 2 +- arch/arm64/kvm/guest.c |

[PATCH 1/2] arm64/kprobes: remove an extra semicolon in arch_prepare_kprobe

2018-08-09 Thread zhong jiang
There is an extra semicolon in arch_prepare_kprobe, remove it. Signed-off-by: zhong jiang --- arch/arm64/kernel/probes/kprobes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c index e78c3ef..9b65132 100

[PATCH 2/2] arm64:guest: remove some extra semicolon in kvm_target_cpu

2018-08-09 Thread zhong jiang
There are some extra semicolon in kvm_target_cpu, remove it. Signed-off-by: zhong jiang --- arch/arm64/kvm/guest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c index 07256b0..a74f84d 100644 --- a/arch/arm64/kvm/guest.c

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Vlastimil Babka
On 08/09/2018 04:54 AM, Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has memory 0x0 - 0x

Re: [RFC PATCH 2/3] mm/memory_hotplug: Create __shrink_pages and move it to offline_pages

2018-08-09 Thread Jerome Glisse
On Thu, Aug 09, 2018 at 10:24:15AM +0200, Michal Hocko wrote: > On Wed 08-08-18 12:58:15, Jerome Glisse wrote: > > On Wed, Aug 08, 2018 at 08:47:58AM +0200, Michal Hocko wrote: > > > On Tue 07-08-18 11:18:10, Jerome Glisse wrote: > > > > On Tue, Aug 07, 2018 at 04:59:00PM +0200, Michal Hocko wrote:

Re: [PATCH 28/33] vfs: syscall: Add fsconfig() for configuring and managing a context [ver #11]

2018-08-09 Thread David Howells
Eric W. Biederman wrote: > First let me thank you for adding both FSCONFIG_CMD_CREATE and > FSCONFIG_CMD_RECONFIGURE. Unfortunately the implementation is currently > broken. So this patch gets my: > > This is broken in two specific ways. > ... > 2) FSCONFIG_CMD_CREATE will succeed even if the

Re: [PATCH] ftrace: remove unused pointer ftrace_swapper_pid

2018-08-09 Thread Steven Rostedt
On Thu, 9 Aug 2018 13:56:09 +0100 Colin King wrote: > From: Colin Ian King > > Pointer ftrace_swapper_pid is defined but is never used hence it is > redundant and can be removed. The use of this variable was removed > in commit 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap > like e

Re: [PATCH v7 8/8] interconnect: Allow endpoints translation via DT

2018-08-09 Thread Georgi Djakov
Hi Saravana, On 08/02/2018 10:12 PM, skan...@codeaurora.org wrote: > On 2018-08-02 05:07, Georgi Djakov wrote: >> Hi Saravana, >> >> On 08/02/2018 01:57 AM, skan...@codeaurora.org wrote: >>> On 2018-07-31 09:13, Georgi Djakov wrote: Currently we support only platform data for specifying the i

Re: [PATCH 4/5] perf/hw_breakpoint: Set breakpoint as disabled in modify_user_hw_breakpoint error path

2018-08-09 Thread Oleg Nesterov
On 08/09, Jiri Olsa wrote: > > @@ -523,8 +523,10 @@ int modify_user_hw_breakpoint(struct perf_event *bp, > struct perf_event_attr *att > perf_event_disable(bp); > > err = modify_user_hw_breakpoint_check(bp, attr, false); > - if (err) > + if (err) { > + bp->a

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-08-09 Thread Bjorn Helgaas
On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote: > When we don't own AER, we shouldn't touch the AER error bits. This > happens unconditionally on device probe(). Clearing AER bits > willy-nilly might cause firmware to miss errors. Instead > these bits should get cleared by FFS, o

Re: [PATCH 28/33] vfs: syscall: Add fsconfig() for configuring and managing a context [ver #11]

2018-08-09 Thread David Howells
Eric W. Biederman wrote: > First let me thank you for adding both FSCONFIG_CMD_CREATE and > FSCONFIG_CMD_RECONFIGURE. Unfortunately the implementation is currently > broken. So this patch gets my: > > This is broken in two specific ways. > 1) FSCONFIG_CMD_RECONFIGURE always returns -EOPNOTSUPP

Re: [PATCH 5/5] fs/locks: create a tree of dependent requests.

2018-08-09 Thread J. Bruce Fields
On Thu, Aug 09, 2018 at 12:04:41PM +1000, NeilBrown wrote: > When we find an existing lock which conflicts with a request, > and the request wants to wait, we currently add the request > to a list. When the lock is removed, the whole list is woken. > This can cause the thundering-herd problem. > T

Re: [PATCH 1/8] dt-bindings: mmc: Add DQS trim value to Tegra SDHCI

2018-08-09 Thread Thierry Reding
On Thu, Aug 09, 2018 at 05:06:04PM +0300, Aapo Vienamo wrote: > On Thu, 9 Aug 2018 15:46:48 +0200 > Thierry Reding wrote: > > > On Thu, Aug 09, 2018 at 02:45:15PM +0300, Aapo Vienamo wrote: > > > On Thu, 9 Aug 2018 13:36:09 +0200 > > > Thierry Reding wrote: > > > > > > > On Tue, Aug 07, 2018

[PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-09 Thread Yazen Ghannam
From: Yazen Ghannam During mce_threshold_create_device() data structures are allocated for each CPUs MCA banks and thresholding blocks. These data structures are used to save information related to AMD's MCA Error Thresholding feature. The structures are used in the thresholding interrupt handler

[PATCH 1/2] x86/MCE/AMD: Check for NULL banks in THR interrupt handler

2018-08-09 Thread Yazen Ghannam
From: Yazen Ghannam If threshold_init_device() fails then per_cpu(threshold_banks) will be deallocated. The thresholding interrupt handler will still be active, so it's possible to get a NULL pointer dereference if a THR interrupt happens and any of the structures are NULL. Exit the handler if p

[PATCH] zsmalloc: fix linking bug in init_zspage

2018-08-09 Thread zhouxianrong
The last partial object in last subpage of zspage should not be linked in allocation list. Signed-off-by: zhouxianrong --- mm/zsmalloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 8d87e973a4f5..24dd8da0aa59 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmall

Re: [PATCH 1/8] dt-bindings: mmc: Add DQS trim value to Tegra SDHCI

2018-08-09 Thread Aapo Vienamo
On Thu, 9 Aug 2018 15:46:48 +0200 Thierry Reding wrote: > On Thu, Aug 09, 2018 at 02:45:15PM +0300, Aapo Vienamo wrote: > > On Thu, 9 Aug 2018 13:36:09 +0200 > > Thierry Reding wrote: > > > > > On Tue, Aug 07, 2018 at 04:59:57PM +0300, Aapo Vienamo wrote: > > > > Document HS400 DQS trim val

Re: [PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-09 Thread Oleg Nesterov
On 08/09, Jiri Olsa wrote: > > @@ -526,10 +526,9 @@ int modify_user_hw_breakpoint(struct perf_event *bp, > struct perf_event_attr *att > if (err) > return err; > > - if (!attr->disabled) { > + if (!attr->disabled) > perf_event_enable(bp); > -

[PATCH] sched/fair: Disable LB_BIAS by default

2018-08-09 Thread Dietmar Eggemann
LB_BIAS allows the adjustment on how conservative load should be balanced. The rq->cpu_load[idx] array is used for this functionality. It contains weighted CPU load decayed average values over different intervals (idx = 1..4). Idx = 0 is the weighted CPU load itself. The values are updated during

Re: WARNING in try_charge

2018-08-09 Thread Tetsuo Handa
>From b1f38168f14397c7af9c122cd8207663d96e02ec Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Thu, 9 Aug 2018 22:49:40 +0900 Subject: [PATCH] mm, oom: task_will_free_mem(current) should retry until memory reserve fails Commit 696453e66630ad45 ("mm, oom: task_will_free_mem should skip oom_reap

Re: [PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style

2018-08-09 Thread Stefan Wahren
> Greg Gallagher hat am 8. August 2018 um 03:40 > geschrieben: > > > Fix warnings generated by checkpatch.pl for alignment should match open > parenthesis. This is a coding style change only. > > Signed-off-by: Greg Gallagher Acked-by: Stefan Wahren

[PATCH] iio: max44000: remove unused variable max44000_alstim_shift

2018-08-09 Thread Colin King
From: Colin Ian King Variable max44000_alstim_shift is defined but is never used hence it is redundant and can be removed. This variable has been like this since the driver was added back in 2016. Cleans up clang warning: warning: 'max44000_alstim_shift' defined but not used [-Wunused-const-vari

[PATCH] drivers/thermal/tegra: fix a doule free devce node

2018-08-09 Thread zhong jiang
Device node iterators will get the return node. Meawhile, It is also put the previous device node. An explicit put will cause a double put. Signed-off-by: zhong jiang --- drivers/thermal/tegra/soctherm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/thermal/tegra/soctherm.c b/driver

Re: [PATCH 5/8] arm64: dts: tegra186: Add SDMMC4 DQS trim value

2018-08-09 Thread Thierry Reding
On Thu, Aug 09, 2018 at 03:02:26PM +0300, Aapo Vienamo wrote: > On Thu, 9 Aug 2018 13:49:22 +0200 > Thierry Reding wrote: > > > On Tue, Aug 07, 2018 at 05:00:01PM +0300, Aapo Vienamo wrote: > > > Add the HS400 DQS trim value for Tegra186 SDMMC4. > > > > > > Signed-off-by: Aapo Vienamo > > > ---

Re: [PATCH 3/8] mmc: tegra: Implement HS400 enhanced strobe

2018-08-09 Thread Thierry Reding
On Thu, Aug 09, 2018 at 03:22:54PM +0300, Aapo Vienamo wrote: > On Thu, 9 Aug 2018 13:43:45 +0200 > Thierry Reding wrote: > > > On Tue, Aug 07, 2018 at 04:59:59PM +0300, Aapo Vienamo wrote: > > > Implement HS400 enhanced strobe. > > > > Can you provide a little more information about what the

Re: [alsa-devel] [PATCH] ASoC: adav80x: mark expected switch fall-through

2018-08-09 Thread Mark Brown
On Thu, Aug 09, 2018 at 01:23:58PM +0200, Lars-Peter Clausen wrote: > On 08/09/2018 11:30 AM, Mark Brown wrote: > It is. But it might make sense to re-order the code to look like > > case 5400: > if (source != ADAV80X_PLL_SRC_XIN) > return -EINVAL; > > pll_ctr

Re: [PATCH 1/8] dt-bindings: mmc: Add DQS trim value to Tegra SDHCI

2018-08-09 Thread Thierry Reding
On Thu, Aug 09, 2018 at 02:45:15PM +0300, Aapo Vienamo wrote: > On Thu, 9 Aug 2018 13:36:09 +0200 > Thierry Reding wrote: > > > On Tue, Aug 07, 2018 at 04:59:57PM +0300, Aapo Vienamo wrote: > > > Document HS400 DQS trim value device tree property. > > > > > > Signed-off-by: Aapo Vienamo > > > -

Re: [PATCH v8 04/22] s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.

2018-08-09 Thread Harald Freudenberger
Here is now a reworked version of the integrate ap_asm.h into include/asm/ap.h patch which can be used to apply it within the AP virtualisation patch queue for testing: >From c81710e7cd073c4f9a904f3539ecf17fd89c9c2d Mon Sep 17 00:00:00 2001 From: Harald Freudenberger Date: Tue, 12 Jun 2018 15:4

Re: [PATCH 13/40] mmc: tegra: Poll for calibration completion

2018-08-09 Thread Thierry Reding
On Thu, Aug 09, 2018 at 03:56:38PM +0300, Aapo Vienamo wrote: > On Thu, 9 Aug 2018 14:46:16 +0200 > Thierry Reding wrote: > > > On Wed, Aug 01, 2018 at 07:32:03PM +0300, Aapo Vienamo wrote: > > > Implement polling with 10 ms timeout for automatic pad drive strength > > > calibration. > > > > > >

Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library

2018-08-09 Thread Steven Rostedt
On Thu, 9 Aug 2018 10:12:02 +0200 Jiri Olsa wrote: > nah... now when I see it 'te' actualy sounds better ; just kidding, > great we finaly got to this.. is there a branch somewhere with this? I just pushed it to my repo: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.gi

Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver

2018-08-09 Thread Dan Murphy
Jacek and Pavel On 08/09/2018 07:09 AM, Jacek Anaszewski wrote: > Dan, > > On 08/08/2018 11:45 PM, Dan Murphy wrote: >> Jacek >> >> On 08/08/2018 04:09 PM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>> On 08/08/2018 11:04 PM, Dan Murphy wrote: On 08/08/2018 04:02 PM, Pavel Machek wrote: >

Re: [PATCH] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Guenter Roeck
On Fri, Aug 03, 2018 at 12:53:44PM -0700, Palmer Dabbelt wrote: > This file is expected to be included multiple times in the same file in > order to allow the __SYSCALL macro to generate system call tables. With > a global include guard we end up missing __NR_riscv_flush_icache in the > syscall ta

Re: [PATCH] arm64: Trap WFI executed in userspace

2018-08-09 Thread Marc Zyngier
On Thu, 09 Aug 2018 13:47:01 +0100, Dave Martin wrote: > > On Thu, Aug 09, 2018 at 01:38:12PM +0100, Will Deacon wrote: > > On Thu, Aug 09, 2018 at 01:34:57PM +0100, Dave Martin wrote: > > > On Wed, Aug 08, 2018 at 01:34:09PM +0100, Catalin Marinas wrote: > > > > On Tue, Aug 07, 2018 at 11:24:34A

Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver

2018-08-09 Thread Pavel Machek
Hi! > >>> 2 sinks 3 LED strings. How do you know which LED string is which and > >>> what bank it belongs > >>> to when setting the brightness. Each Bank has a separate register for > >>> brightness control. > >> > >> Just a blind shot, without going into details - could you please check > >>

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-09 Thread Jacek Anaszewski
Hi Baolin, On 08/09/2018 07:48 AM, Baolin Wang wrote: [...] > +static int pattern_trig_start_pattern(struct pattern_trig_data *data, > + struct led_classdev *led_cdev) > +{ > + if (!data->npatterns) > + return 0; > + > +

Re: [PATCH 12/40] mmc: tegra: Reconfigure pad voltages during voltage switching

2018-08-09 Thread Thierry Reding
On Thu, Aug 09, 2018 at 03:52:39PM +0300, Aapo Vienamo wrote: > On Thu, 9 Aug 2018 14:43:46 +0200 > Thierry Reding wrote: > > > On Wed, Aug 01, 2018 at 07:32:02PM +0300, Aapo Vienamo wrote: > > > Parse the pinctrl state and nvidia,only-1-8-v properties from the device > > > tree. Validate the pin

Re: [PATCH 10/40] soc/tegra: pmc: Implement pad configuration via pinctrl

2018-08-09 Thread Thierry Reding
On Thu, Aug 09, 2018 at 03:44:12PM +0300, Aapo Vienamo wrote: > On Thu, 9 Aug 2018 14:27:06 +0200 > Thierry Reding wrote: > > > On Wed, Aug 01, 2018 at 07:32:00PM +0300, Aapo Vienamo wrote: > > > Register a pinctrl device and implement get and set functions for > > > PIN_CONFIG_LOW_POWER_MODE and

Re: [PATCH 3/5] fs/locks: change all *_conflict() functions to return a new enum.

2018-08-09 Thread J. Bruce Fields
On Thu, Aug 09, 2018 at 12:04:41PM +1000, NeilBrown wrote: > In a future patch we will need to differentiate between conflicts that > are "transitive" and those that aren't. > A "transitive" conflict is defined as one where any lock that > conflicts with the first (newly requested) lock would confl

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread J. Bruce Fields
On Wed, Aug 08, 2018 at 06:50:06PM -0400, Jeff Layton wrote: > That seems like a legit problem. > > One possible fix might be to have the waiter on (1,2) walk down the > entire subtree and wake up any waiter that is waiting on a lock that > doesn't conflict with the lock on which it's waiting. >

Re: [PATCH 20/40] mmc: tegra: Add a workaround for tap value change glitch

2018-08-09 Thread Thierry Reding
On Wed, Aug 01, 2018 at 07:32:10PM +0300, Aapo Vienamo wrote: > Add quirk to disable the card clock during configuration of the tap > value in tegra_sdhci_set_tap() and issue sdhci_reset() after value > change. This is a workaround to avoid propagation of a potential > glitch caused by setting the

Re: [PATCH 13/40] mmc: tegra: Poll for calibration completion

2018-08-09 Thread Aapo Vienamo
On Thu, 9 Aug 2018 14:46:16 +0200 Thierry Reding wrote: > On Wed, Aug 01, 2018 at 07:32:03PM +0300, Aapo Vienamo wrote: > > Implement polling with 10 ms timeout for automatic pad drive strength > > calibration. > > > > Signed-off-by: Aapo Vienamo > > --- > > drivers/mmc/host/sdhci-tegra.c | 21

<    1   2   3   4   5   6   7   >