Re: [PATCH] drivers: gpio: gpio-adp5588: Fix sleep-in-atomic-context bug

2018-09-02 Thread Michael Hennerich
On 29.08.2018 10:55, Linus Walleij wrote: On Mon, Aug 13, 2018 at 3:53 PM wrote: From: Michael Hennerich This fixes: [BUG] gpio: gpio-adp5588: A possible sleep-in-atomic-context bug in adp5588_gpio_write() [BUG] gpio: gpio-adp5588: A possible sleep-in-atomic-contex

Re: [PATCH 2/7] Compiler Attributes: use the no-underscores syntax

2018-09-02 Thread Geert Uytterhoeven
Hi Miguel, On Sat, Sep 1, 2018 at 12:41 AM Miguel Ojeda wrote: > On Sat, Sep 1, 2018 at 12:10 AM, Miguel Ojeda > wrote: > > arch/parisc/boot/compressed/misc.c:#define malloc malloc_gzip > > include/linux/decompress/mm.h:#define malloc(a) kmalloc(a, GFP_KERNEL) > > lib/inflate.c:#define mal

Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-09-02 Thread Viresh Kumar
On 29-08-18, 09:08, Vincent Guittot wrote: > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > its usage in the code assumes that unit is uW/MHz/V^2 > > In drivers/thermal/cpu_cooling.c, the code is : > > power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv; > d

Re: [PATCH] cpufreq: Convert to using %pOFn instead of device_node.name

2018-09-02 Thread Viresh Kumar
On 27-08-18, 20:52, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-samsung-...@vger.kernel

Re: [PATCH v2] cpufreq: ti-cpufreq: Only register platform_device when supported

2018-09-02 Thread Viresh Kumar
On 23-08-18, 14:20, Dave Gerlach wrote: > Currently the ti-cpufreq driver blindly registers a 'ti-cpufreq' to force > the driver to probe on any platforms where the driver is built in. > However, this should only happen on platforms that actually can make use > of the driver. There is already funct

Re: [PATCH v2] ARM: dts: spear: fix stmpe811 interrupt properties

2018-09-02 Thread Viresh Kumar
On 14-08-18, 09:39, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > The property "irq-over-gpio" simply does not exist (this is nowadays > actually auto detected) and the property "irq-gpios" is actually called > "irq-gpio". > > Signed-off-by: Marcel Ziswiler > > --- > > Changes in v2: > -

Re: [PATCH v1] thermal: core: Fix use-after-free in thermal_cooling_device_destroy_sysfs

2018-09-02 Thread Viresh Kumar
On 13-08-18, 20:14, Dmitry Osipenko wrote: > This patch fixes use-after-free that was detected by KASAN. The bug is > triggered on a CPUFreq driver module unload by freeing 'cdev' on device > unregister and then using the freed structure during of the cdev's sysfs > data destruction. The solution i

Re: [PATCH 1/3] MIPS: jz4780: Allow access to jz4740-i2s

2018-09-02 Thread Mathieu Malaterre
On Fri, Aug 31, 2018 at 10:59 PM Paul Burton wrote: > > On Fri, Aug 31, 2018 at 01:37:52PM -0700, Paul Burton wrote: > > Further to that, this series doesn't seem to work for me. With > > v4.19-rc1, with the patch from [1] & then this series applied I see the > > following when booting a ci20_defc

Re: [PATCH 2/2] mmc: tegra: Implement periodic pad calibration

2018-09-02 Thread Ulf Hansson
On 20 August 2018 at 11:23, Aapo Vienamo wrote: > Rerun the pad calibration procedure before sdhci_request() if > the 100 ms recalibration interval has been exceeded. > > Signed-off-by: Aapo Vienamo Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-tegra.c | 22 ++

Re: [PATCH v2 0/8] Tegra SDHCI support HS400 on Tegra210 and Tegra186

2018-09-02 Thread Ulf Hansson
On 10 August 2018 at 20:13, Aapo Vienamo wrote: > Hi all, > This series implements support for HS400 signaling on Tegra210 and > Tegra186. This includes programming the DQS trimmer values, implementing > enhanced strobe and HS400 delay line calibration. > > This series depends on the "Tegra SDHCI

Re: Access to non-RAM pages

2018-09-02 Thread Jiri Kosina
On Sun, 2 Sep 2018, Linus Torvalds wrote: > Which basically doesn't happen on x86 in reality. BIOSes just don't put > MMIO right after the last page of RAM. I think this is why it only > triggered on Xen, due to some crazy "Xen reacts badly" case where we do > the speculation into a balloon add

[PATCH 11/13] iommu/mediatek: Add shutdown callback

2018-09-02 Thread Yong Wu
In the reboot burning test, if some Multimedia HW has something wrong, It may keep send the invalid request to IOMMU. In order to avoid affect the reboot flow, we add the shutdown callback to disable M4U HW when shutdown. Signed-off-by: Yong Wu --- drivers/iommu/mtk_iommu.c | 6 ++ 1 file ch

[PATCH 10/13] iommu/mediatek: Add VLD_PA_RANGE register backup when suspend

2018-09-02 Thread Yong Wu
The register VLD_PA_RNG(0x118) was forgot to backup while adding 4GB mode support for mt2712. this patch add it. Fixes: 30e2fccf9512 ("iommu/mediatek: Enlarge the validate PA range for 4GB mode") Signed-off-by: Yong Wu --- drivers/iommu/mtk_iommu.c | 2 ++ drivers/iommu/mtk_iommu.h | 1 + 2 file

[PATCH 13/13] iommu/mediatek: Switch to SPDX license identifier

2018-09-02 Thread Yong Wu
Switch to SPDX license identifier for MediaTek iommu/smi and their header files. Signed-off-by: Yong Wu --- drivers/iommu/mtk_iommu.c | 10 +- drivers/iommu/mtk_iommu.h | 10 +- drivers/iommu/mtk_iommu_v1.c | 10 +-

Re: [PATCH v6 1/2] mm: migration: fix migration of huge PMD shared pages

2018-09-02 Thread Michal Hocko
On Thu 30-08-18 14:39:44, Jerome Glisse wrote: > On Thu, Aug 30, 2018 at 11:05:16AM -0700, Mike Kravetz wrote: > > On 08/30/2018 09:57 AM, Jerome Glisse wrote: > > > On Thu, Aug 30, 2018 at 06:19:52PM +0200, Michal Hocko wrote: > > >> On Thu 30-08-18 10:08:25, Jerome Glisse wrote: > > >>> On Thu, A

Re: [PATCH 2/5] gpio: davinci: Use dev name for label and automatic base selection

2018-09-02 Thread Keerthy
On Saturday 01 September 2018 12:43 AM, Andrew F. Davis wrote: > Use dev_name to get a unique label and use -1 for a base to get our > selection automatically. We pull in all GPIOs per chip now so this > does not have the effect of out of order labels like before. > > We do these both together

Re: Access to non-RAM pages

2018-09-02 Thread Juergen Gross
On 03/09/18 04:10, Linus Torvalds wrote: > So _practically_ this is just a Xen bug, nothing more. > > But since in _theory_ you could have MMIO abut regular RAM directly, > it's worth maybe making sure it's purely theory. And that was exactly the reason I brought it up. :-) Juergen

Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin

2018-09-02 Thread Shawn Guo
On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote: > The correct DT property for specifying a GPIO used for reset > is "reset-gpios", fix this here. > > Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards") This Fixes tag and word 'Fix' in subject is inappropriate to me, as yo

Re: [PATCH v2] fs: Convert return type int to vm_fault_t

2018-09-02 Thread Matthew Wilcox
On Thu, Aug 30, 2018 at 10:55:47PM +0530, Souptick Joarder wrote: > +vm_fault_t block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault > *vmf, > + get_block_t get_block, int *err) I don't like returning both the errno and the vm_fault_t. To me that's a sign we need t

Re: [PATCH v2] perf: Fix clean error

2018-09-02 Thread Lei YU
Just find out that da15fc2fa9c07b23db8f5e479bd8a9f0d741ca07 (introduced in v4.19-rc1) already fixes the issue by specifying -j1 on make clean. So this commit is not needed anymore, though I think it does fix the root cause. But if we do want parallel clean, we could revert that and merge this comm

Re: [PATCH V2] ARM: dts: imx7s: enable cpuidle driver

2018-09-02 Thread Shawn Guo
On Mon, Sep 03, 2018 at 09:45:41AM +0800, Anson Huang wrote: > Enable cpuidle for i.MX7S/D using generic ARM cpuidle > driver, below 2 idle states enabled: > > 1. ARM WFI; > 2. SoC WAIT mode. > > Signed-off-by: Anson Huang Applied, thanks.

RE: [PATCH 1/7] spi: add slave device size in spi_device struct

2018-09-02 Thread Yogesh Narayan Gaur
Hi Lothar, > -Original Message- > From: Lothar Waßmann [mailto:l...@karo-electronics.de] > Sent: Friday, August 31, 2018 5:28 PM > To: Yogesh Narayan Gaur > Cc: linux-...@lists.infradead.org; boris.brezil...@bootlin.com; > marek.va...@gmail.com; linux-...@vger.kernel.org; > devicet...@vge

Re: [PATCH v3] sched/pelt: fix update_blocked_averages() for dl and rt

2018-09-02 Thread Dietmar Eggemann
On 08/31/2018 08:22 AM, Vincent Guittot wrote: update_blocked_averages() is called to periodiccally decay the stalled load of idle CPUs and to sync all loads before running load balance. When cfs rq is idle, it trigs a load balance during pick_next_task_fair() in order to potentially pull tasks

Re: [PATCH] sched/fair: fix vruntime_normalized for remote non-migration wakeup

2018-09-02 Thread Dietmar Eggemann
On 08/31/2018 03:42 PM, Steve Muckle wrote: When a task which previously ran on a given CPU is remotely queued to wake up on that same CPU, there is a period where the task's state is TASK_WAKING and its vruntime is not normalized. This is not accounted for in vruntime_normalized() which will cau

Re: [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check

2018-09-02 Thread Shawn Guo
On Wed, Aug 29, 2018 at 03:02:58PM -0500, Rob Herring wrote: > Checking the child node names is pointless as the DT node name can > never be NULL, so remove it. > > Cc: Shawn Guo > Signed-off-by: Rob Herring Applied, thanks.

INQUIRY ORDER

2018-09-02 Thread Mr Walter Benson
Dear Supplier, Please kindly confirm back in reply if am onto the right contact personin your company responsible for inquiries & orders. Please can you as well send your updated 2018 product catalog/price listing to our Import Department desk. Regards Walter Benson Purchase Manager A

Re: Access to non-RAM pages

2018-09-02 Thread Benjamin Herrenschmidt
On Sun, 2018-09-02 at 19:52 -0700, Linus Torvalds wrote: > On Sun, Sep 2, 2018 at 7:47 PM Linus Torvalds > wrote: > > > > The comment actually does talk about it, although the comment also > > claims that the cs read would use load_unaligned_zeropad(), which it > > no longer does (now it only doe

Re: [BUGFIX PATCH -tip] kprobes/x86: Fix to copy RIP relative instruction correctly

2018-09-02 Thread Masami Hiramatsu
Hi Ingo, Could you pick this fix to urgent branch? Thank you, On Fri, 24 Aug 2018 16:57:19 +0900 Masami Hiramatsu wrote: > On Thu, 23 Aug 2018 21:41:09 -0400 > Steven Rostedt wrote: > > > On Fri, 24 Aug 2018 02:16:12 +0900 > > Masami Hiramatsu wrote: > > > > > Dump of assembler code from 0

[PATCH] fs/cifs: suppress a string overflow warning

2018-09-02 Thread Stephen Rothwell
A powerpc build of cifs with gcc v8.2.0 produces this warning: fs/cifs/cifssmb.c: In function ‘CIFSSMBNegotiate’: fs/cifs/cifssmb.c:605:3: warning: ‘strncpy’ writing 16 bytes into a region of size 1 overflows the destination [-Wstringop-overflow=] strncpy(pSMB->DialectsArray+count, protocols[i

Re: [PATCH 5/7] arm64: dts: lx2160a: add fspi node property

2018-09-02 Thread Shawn Guo
On Fri, Aug 31, 2018 at 04:00:02PM +0530, Yogesh Gaur wrote: > Add fspi node property for LX2160A SoC for FlexSPI driver. > Property added for the FlexSPI controller and for the connected > slave device for the LX2160ARDB target. > This is having two SPI-NOR flash device, mt35xu512aba, connected >

linux-next: Tree for Sep 3

2018-09-02 Thread Stephen Rothwell
Hi all, Changes since 20180831: Dropped trees: xarray, ida (temporarily) The net-next tree gained a build failure for which I reverted a commit. Non-merge commits (relative to Linus' tree): 1489 1812 files changed, 56535 insertions(+), 18845 deletions(-) --

Re: Access to non-RAM pages

2018-09-02 Thread Linus Torvalds
On Sun, Sep 2, 2018 at 7:47 PM Linus Torvalds wrote: > > The comment actually does talk about it, although the comment also > claims that the cs read would use load_unaligned_zeropad(), which it > no longer does (now it only does the read_word_at_a_time). IOW, look at commit 12f8ad4b0533 ("vfs: c

Re: Access to non-RAM pages

2018-09-02 Thread Benjamin Herrenschmidt
On Sun, 2018-09-02 at 19:10 -0700, Linus Torvalds wrote: > On Sun, Sep 2, 2018 at 7:01 PM Benjamin Herrenschmidt > wrote: > > > > Still, I can potentially see an issue with DEBUG_PAGEALLOC > > An unmapped page isn't a problem. That's what the whole > load_unaligned_zeropad() is about: it's ok to

[PATCH v2] perf: Fix clean error

2018-09-02 Thread Lei YU
When make perf with -O, it gets error when make clean with below log: $ make -C tools/perf O= # OK $ make -C tools/perf O= clean # Got below error find: cannot delete ‘/builtin-script.o’: No such file or directory find: cannot delete ‘/.subcmd-config.o.cmd’: No such file or directory

Re: [PATCH] arm64: dts: ls208xa: add second duart

2018-09-02 Thread Shawn Guo
On Thu, Aug 30, 2018 at 11:00:38AM +0200, Kurt Kanzenbach wrote: > The NXP LS208xA SoCs have two dual uarts. Thus, add the second one. > > Signed-off-by: Kurt Kanzenbach Applied, thanks.

Re: Access to non-RAM pages

2018-09-02 Thread Linus Torvalds
On Sun, Sep 2, 2018 at 7:25 PM Benjamin Herrenschmidt wrote: > Ah, my bad reading, I was looking at read_word_at_a_time() instead of > load_unaligned_zeropad(). I'm not familiar enough with the dentry qstr > stuff, I assume this is safe ? The dentry qstr should always be 8-byte aligned because it

Re: [PATCH] arm64: dts: ls208xa: add second duart

2018-09-02 Thread Li Yang
On Sun, Sep 2, 2018 at 9:34 PM Shawn Guo wrote: > > It looks good to me. @Leo, are you okay with it? It looks fine. Acked-by: Li Yang > > Shawn > > On Thu, Aug 30, 2018 at 11:00:38AM +0200, Kurt Kanzenbach wrote: > > The NXP LS208xA SoCs have two dual uarts. Thus, add the second one. > > > >

Re: [PATCH] ACPI / LPSS: Ensure LPIOEP is always set on resume

2018-09-02 Thread Zhang Rui
Hi, William, On 六, 2018-09-01 at 12:59 -0500, William Lieurance wrote: > For some number of systems with lpss_quirks enabled, on boot the > system > goes through an acpi_lpss_resume() without a corresponding > acpi_lpss_suspend() having been called. I read the code but didn't find out why this co

[PATCH] sound: soc: fix soc-core.c kernel-doc warning

2018-09-02 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warning: ../sound/soc/soc-core.c:2918: warning: Excess function parameter 'legacy_dai_naming' description in 'snd_soc_register_dais' Signed-off-by: Randy Dunlap Cc: Liam Girdwood Cc: Mark Brown --- sound/soc/soc-core.c |2 -- 1 file changed, 2 deletion

Re: [PATCH] regulator: fix kernel-doc parameter warning

2018-09-02 Thread Randy Dunlap
Sorry about missing the Cc's. Would you like me to resend it? On 09/02/2018 07:33 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kernel-doc warning: > > ../drivers/regulator/core.c:4479: warning: Excess function parameter 'state' > description in 'regulator_suspend' > > Signed-off-by:

[PATCH] regulator: fix kernel-doc parameter warning

2018-09-02 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warning: ../drivers/regulator/core.c:4479: warning: Excess function parameter 'state' description in 'regulator_suspend' Signed-off-by: Randy Dunlap Cc: Liam Girdwood Cc: Mark Brown --- drivers/regulator/core.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] arm64: dts: ls208xa: add second duart

2018-09-02 Thread Shawn Guo
It looks good to me. @Leo, are you okay with it? Shawn On Thu, Aug 30, 2018 at 11:00:38AM +0200, Kurt Kanzenbach wrote: > The NXP LS208xA SoCs have two dual uarts. Thus, add the second one. > > Signed-off-by: Kurt Kanzenbach > --- > arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 16

[PATCH] pci: fix pci.c kernel-doc parameter warning

2018-09-02 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warning: ../drivers/pci/pci.c:218: warning: Excess function parameter 'p' description in 'pci_dev_str_match_path' Signed-off-by: Randy Dunlap Cc: Bjorn Helgaas Cc: linux-...@vger.kernel.org --- drivers/pci/pci.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH] x86: fix kernel-doc atomic.h warnings

2018-09-02 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warnings in arch/x86/include/asm/atomic.h that are caused by having a #define macro between the kernel-doc notation and the function name. Fixed by moving the #define macro to after the function implementation. Make the same change for atomic64_{32,64}.h for co

Re: [PATCH] ARM: dts: imx6sx-sdb: enable gpio buttons as wakeup source

2018-09-02 Thread Shawn Guo
On Thu, Aug 30, 2018 at 02:59:39PM +0800, Anson Huang wrote: > This patch enables i.MX6SX SDB board's below GPIO buttons > as wakeup sources: > > SW4(FUNC1): KEY_VOLUMEUP > SW5(FUNC2): KEY_VOLUMEDOWN > > Signed-off-by: Anson Huang Applied, thanks.

Re: [PATCH] ARM: dts: imx6ull: update iomux header

2018-09-02 Thread Shawn Guo
Add Sébastien for a cross check. Shawn On Thu, Aug 30, 2018 at 01:20:05PM +0800, Anson Huang wrote: > Update i.MX6ULL iomux header according to latest reference > manual Rev.1, 11/2017. > > Signed-off-by: Anson Huang > --- > arch/arm/boot/dts/imx6ull-pinfunc.h | 21 +++-- > 1 f

Re: [PATCH AUTOSEL 4.18 068/131] PCI: mobiveil: Add missing ../pci.h include

2018-09-02 Thread Subrahmanya Lingappa
Acked-by: Subrahmanya Lingappa Thanks. On Sun, Sep 2, 2018 at 6:34 PM Sasha Levin wrote: > > From: Lorenzo Pieralisi > > [ Upstream commit d3743012230f8dab30d47caba1f2ee9e382385e7 ] > > PCI mobiveil host controller driver currently fails to compile > with the following error: > > drivers/pci/con

Re: [PATCH AUTOSEL 4.18 069/131] PCI: mobiveil: Fix struct mobiveil_pcie.pcie_reg_base address type

2018-09-02 Thread Subrahmanya Lingappa
Acked-by: Subrahmanya Lingappa Thanks. On Sun, Sep 2, 2018 at 6:34 PM Sasha Levin wrote: > > From: Lorenzo Pieralisi > > [ Upstream commit af3f606e0bbb6d811c50b7b90fe324b07fb7cab8 ] > > The field pcie_reg_base in struct mobiveil_pcie represents a physical > address so it should be of phys_addr_

Re: [PATCH v2 1/2] iio: adc: sc27xx: Add raw data support

2018-09-02 Thread Baolin Wang
Hi Jonathan, On 2 September 2018 at 16:51, Jonathan Cameron wrote: > On Wed, 29 Aug 2018 14:04:04 +0800 > Baolin Wang wrote: > >> The headset device will use channel 20 of ADC controller to detect events, >> but it needs the raw ADC data to do conversion according to its own formula. >> >> Thus

Re: [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check

2018-09-02 Thread Shawn Guo
On Wed, Aug 29, 2018 at 03:02:58PM -0500, Rob Herring wrote: > Checking the child node names is pointless as the DT node name can > never be NULL, so remove it. > > Cc: Shawn Guo > Signed-off-by: Rob Herring Applied, thanks.

Re: [PATCH v2] fs: Convert return type int to vm_fault_t

2018-09-02 Thread Ryusuke Konishi
Hi Souptick, On Thu, 30 Aug 2018 16:33:52 -0700, Andrew Morton wrote: > On Thu, 30 Aug 2018 22:55:47 +0530 Souptick Joarder wrote: > >> Return type for fault handlers in ext4 and nilfs are >> changed to use vm_fault_t. >> >> Return type of block_page_mkwrite() is changed from >> int to vm_fault

[PATCH v3] membarrier_test: work in progress

2018-09-02 Thread Rafael David Tinoco
Shuah, This is a draft only. I will remove summary from the top, run checkers, etc. Im thinking in replacing membarrier_test entirely with this code (compatible to existing one). Right now, this code: - allows each test to succeed, fail or be skipped independently - allows each test to be teste

Re: Access to non-RAM pages

2018-09-02 Thread Linus Torvalds
On Sun, Sep 2, 2018 at 7:01 PM Benjamin Herrenschmidt wrote: > > Still, I can potentially see an issue with DEBUG_PAGEALLOC An unmapped page isn't a problem. That's what the whole load_unaligned_zeropad() is about: it's ok to take a fault on the part that crosses a page, and we'll just fill the v

linux-next: build warning after merge of the staging tree

2018-09-02 Thread Stephen Rothwell
Hi Greg, After merging the staging tree, today's linux-next build (powerpc allyesconfig) produced this warning: WARNING: drivers/staging/rtl8192u/r8192u_usb: 'dot11d_init' exported twice. Previous export was in drivers/staging/rtl8192e/rtllib.ko Introduced by commit c01f06b7506f ("staging:rt

Re: Access to non-RAM pages

2018-09-02 Thread Benjamin Herrenschmidt
On Sat, 2018-09-01 at 11:06 -0700, Linus Torvalds wrote: > [ Adding a few new people the the cc. > > The issue is the worry about software-speculative accesses (ie > things like CONFIG_DCACHE_WORD_ACCESS - not talking about the hw > speculation now) accessing past RAM into possibly contiguous IO

Re: Access to non-RAM pages

2018-09-02 Thread Benjamin Herrenschmidt
On Sun, 2018-09-02 at 18:42 -0700, Linus Torvalds wrote: > On Sun, Sep 2, 2018 at 6:38 PM Linus Torvalds > wrote: > > It's not used for vmalloc stuff. It's just regular kmalloc(). > > Just to clarify .. that's true of the dcache stuff. > > The strscpy case actually explicitly limits things to pa

Re: KMSAN: uninit-value in snd_midi_event_encode_byte

2018-09-02 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:28f0ca98eadf kmsan: don't instrument do_syscall_64() and _.. git tree: https://github.com/google/kmsan.git/master console output: https://syzkaller.appspot.com/x/log.txt?x=10556c9240 kernel config: https://syzkal

Re: Peer bridge fixup issue under multiple pci domain

2018-09-02 Thread Zihan Yang
Bjorn Helgaas 于2018年8月28日周二 下午7:35写道: > > [+cc EDAC folks, LKML] > > On Sat, Aug 25, 2018 at 10:58:57PM +0800, Zihan Yang wrote: > > Hi all, > > > > I'm trying to use multiple pci domain in qemu q35, but I find there > > might be some issues in peer bridge fixup. > > > > In short, pcibios_fixup_pe

RE: [PATCH 1/2] ARM: dts: imx7s: enable cpuidle driver

2018-09-02 Thread Anson Huang
Anson Huang Best Regards! > -Original Message- > From: Shawn Guo > Sent: Monday, September 3, 2018 9:16 AM > To: Anson Huang > Cc: s.ha...@pengutronix.de; ker...@pengutronix.de; Fabio Estevam > ; robh...@kernel.org; mark.rutl...@arm.com; > li...@armlinux.org.uk; linux-arm-ker...@list

[PATCH V2] ARM: dts: imx7s: enable cpuidle driver

2018-09-02 Thread Anson Huang
Enable cpuidle for i.MX7S/D using generic ARM cpuidle driver, below 2 idle states enabled: 1. ARM WFI; 2. SoC WAIT mode. Signed-off-by: Anson Huang --- changes since V1: replace uppercase with lowercase. arch/arm/boot/dts/imx7d.dtsi | 1 + arch/arm/boot/dts/imx7s.dtsi | 14

Re: Access to non-RAM pages

2018-09-02 Thread Benjamin Herrenschmidt
On Mon, 2018-09-03 at 10:48 +1000, Benjamin Herrenschmidt wrote: > On Sat, 2018-09-01 at 11:06 -0700, Linus Torvalds wrote: > > [ Adding a few new people the the cc. > > > > The issue is the worry about software-speculative accesses (ie > > things like CONFIG_DCACHE_WORD_ACCESS - not talking abo

Re: Access to non-RAM pages

2018-09-02 Thread Benjamin Herrenschmidt
On Sun, 2018-09-02 at 18:38 -0700, Linus Torvalds wrote: > On Sun, Sep 2, 2018 at 6:32 PM Benjamin Herrenschmidt > wrote: > > > > Also, if we cross page boundaries with those guys then we have a bigger > > problem no ? we could fall off a vmalloc page into the nether or into > > an ioremap mappin

Re: Access to non-RAM pages

2018-09-02 Thread Benjamin Herrenschmidt
On Sun, 2018-09-02 at 18:38 -0700, Linus Torvalds wrote: > On Sun, Sep 2, 2018 at 6:32 PM Benjamin Herrenschmidt > wrote: > > > > Also, if we cross page boundaries with those guys then we have a bigger > > problem no ? we could fall off a vmalloc page into the nether or into > > an ioremap mappin

Re: Access to non-RAM pages

2018-09-02 Thread Linus Torvalds
On Sun, Sep 2, 2018 at 6:38 PM Linus Torvalds wrote: > It's not used for vmalloc stuff. It's just regular kmalloc(). Just to clarify .. that's true of the dcache stuff. The strscpy case actually explicitly limits things to page boundaries and falls back to the byte-by-byte case after that.

Re: [PATCH] infiniband: core: mad: Fix a sleep-in-atomic-context bug in ib_mad_recv_done()

2018-09-02 Thread Jia-Ju Bai
On 2018/9/3 4:32, Jason Gunthorpe wrote: On Sat, Sep 01, 2018 at 08:06:59PM +0800, Jia-Ju Bai wrote: The driver may sleep with holding a spinlock. The function call paths (from bottom to top) in Linux-4.16 are: [FUNC] alloc_mad_private(GFP_KERNEL) drivers/infiniband/core/mad.c, 2264:

Re: Access to non-RAM pages

2018-09-02 Thread Linus Torvalds
On Sun, Sep 2, 2018 at 6:32 PM Benjamin Herrenschmidt wrote: > > Also, if we cross page boundaries with those guys then we have a bigger > problem no ? we could fall off a vmalloc page into the nether or into > an ioremap mapping no ? It's not used for vmalloc stuff. It's just regular kmalloc().

Re: [PATCH 2/2] ARM: imx_v6_v7_defconfig: select CONFIG_ARM_CPUIDLE by default

2018-09-02 Thread Shawn Guo
On Wed, Aug 29, 2018 at 01:00:47PM +0800, Anson Huang wrote: > Some i.MX platforms like i.MX7S/D uses generic ARM cpuidle > driver and psci method to support cpuidle feature, select > CONFIG_ARM_CPUIDLE by default for such platforms. > > Signed-off-by: Anson Huang Applied, thanks.

Re: [PATCH net-next 4/5] ipv6: enable IFA_IF_NETNSID for RTM_GETADDR

2018-09-02 Thread Christian Brauner
On Fri, Aug 31, 2018 at 02:41:45AM +0800, kbuild test robot wrote: > Hi Christian, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Christian-Brauner/rtnetlink-add-IFA_IF_NETNSID-for-RTM_

Re: [PATCH 1/2] ARM: dts: imx7s: enable cpuidle driver

2018-09-02 Thread Shawn Guo
On Wed, Aug 29, 2018 at 01:00:46PM +0800, Anson Huang wrote: > Enable cpuidle for i.MX7S/D using generic ARM cpuidle > driver, below 2 idle states enabled: > > 1. ARM WFI; > 2. SoC WAIT mode. > > Signed-off-by: Anson Huang > --- > arch/arm/boot/dts/imx7d.dtsi | 1 + > arch/arm/boot/dts/imx7s.d

[PATCH] tpm: fix response size validation in tpm_get_random()

2018-09-02 Thread Jarkko Sakkinen
When checking whether the response is large enough to be able to contain the received random bytes in tpm_get_random() and tpm2_get_random(), they fail to take account the header size, which should be added to the minimum size. This commit fixes this issue. Cc: sta...@vger.kernel.org Fixes: c659af

Re: [PATCH v2] arm64: dts: ls1043a: Add configure-gfladj property to USB3 node

2018-09-02 Thread Shawn Guo
On Wed, Aug 29, 2018 at 11:30:55AM +0800, Yinbo Zhu wrote: > From: Rajesh Bhagat > > Add "configure-gfladj" boolean property to USB3 node. This property I do not see where this property is documented as bindings and how driver is using it. Shawn > is used to determine whether frame length adju

Re: [PATCH] ARM: dts: imx7d-sdb: enable gpio buttons as wakeup source

2018-09-02 Thread Shawn Guo
On Wed, Aug 29, 2018 at 09:45:38AM +0800, Anson Huang wrote: > This patch enables i.MX7D SDB board's below GPIO buttons > as wakeup sources: > > S1(FUNC1): KEY_VOLUMEUP > S3(FUNC2): KEY_VOLUMEDOWN > > Signed-off-by: Anson Huang Applied, thanks.

Re: [PATCH 4/4] arm64: dts: add Microsys MPX-LS1046A SoM and SBC-LS1046A SBC

2018-09-02 Thread Shawn Guo
On Tue, Aug 28, 2018 at 10:45:44PM +0200, Alexandre Belloni wrote: > Microsys designs a SoM based on the LS1046A named miriac MPX-LS1046A > https://microsys.de/products/system-on-modules/qoriqr-armr-architecture/miriactm-mpx-ls1046a/ > > It also provides an SBC accepting this SoM, the miriac SBC-L

Re: [PATCH] ARM: dts: imx7s-warp: use SPDX-License-Identifier

2018-09-02 Thread Shawn Guo
On Tue, Aug 28, 2018 at 07:06:37PM +0200, Pierre-Jean Texier wrote: > Adopt the SPDX license identifier headers to ease > license compliance management. > > Signed-off-by: Pierre-Jean Texier Applied, thanks.

Re: [PATCH V2 1/2] soc: imx: gpc: use A_CORE instread of A7 for more i.MX platforms

2018-09-02 Thread Shawn Guo
On Tue, Aug 28, 2018 at 04:36:45PM +0800, Anson Huang wrote: > gpcv2 driver is NOT just used on i.MX7D which has Cortex-A7 > cores, but also on i.MX8MQ/i.MX8MM platforms which use Cortex-A53 > cores, so let's use A_CORE instread of A7 to avoid confusion. > > Signed-off-by: Anson Huang > Acked-by:

Linux 4.19-rc2

2018-09-02 Thread Linus Torvalds
As usual, the rc2 release is pretty small. People are taking a breather after the merge window, and it takes a bit of time for bug reports to start coming in and get identified. Plus people were probably still on vacation (particularly Europe), and some people were at Open Source Summit NA last we

Re: [PATCH 07/23] seccomp: remove unnecessary unlikely()

2018-09-02 Thread Kees Cook
On Thu, Aug 30, 2018 at 3:34 PM, Igor Stoppa wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to wrap it > into another. > > Signed-off-by: Igor Stoppa > Cc: Kees Cook Acked-by: Kees Cook -Kees > --- > kernel/seccomp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

Re: [PATCH 2/2] x86/mm/KASLR: Adjust the vmemmap size according to paging mode

2018-09-02 Thread Kirill A. Shutemov
On Thu, Aug 30, 2018 at 11:25:12PM +0800, Baoquan He wrote: > Hi Kirill, > > I made a new version according to your suggestion, just a little > different, I didn't make 1TB as default, just calculate with the actual > size, then align up to 1TB boundary. Just found kcore is printing more > entrie

Re: [PATCH v2 4/4] MAINTAINERS: add entry for fxas21002c gyro driver

2018-09-02 Thread Jonathan Cameron
On Thu, 30 Aug 2018 22:18:25 +0100 Afonso Bordado wrote: > Add entry for fxas21002c gyroscope driver and add myself as > maintainer of this driver. > I'll take a final look at V3, once you have tidied up the various review comments, but this looks nearly ready to merge to me. Thanks, Jonathan

Re: [PATCH v2 2/4] iio: gyro: add device tree support for fxas21002c

2018-09-02 Thread Jonathan Cameron
On Thu, 30 Aug 2018 22:18:23 +0100 Afonso Bordado wrote: > This patch adds device tree support for the fxas21002c driver, including > bindings. > > Signed-off-by: Afonso Bordado > --- > .../bindings/iio/gyroscope/fsl,fxas21002c.txt | 35 +++ > drivers/iio/gyro/fxas21002c.c

Re: [PATCH] iio: pressure: ms5611: switch to SPDX identifier

2018-09-02 Thread Jonathan Cameron
On Sat, 1 Sep 2018 21:52:14 +0200 Tomasz Duszynski wrote: > Drop boilerplate license text and use SPDX identifier instead. > > Signed-off-by: Tomasz Duszynski Applied. Thanks, Jonathan > --- > drivers/iio/pressure/ms5611.h | 5 + > drivers/iio/pressure/ms5611_core.c | 5 + > d

Re: [PATCH] iio: light: bh1750: switch to SPDX identifier

2018-09-02 Thread Jonathan Cameron
On Sat, 1 Sep 2018 21:51:44 +0200 Tomasz Duszynski wrote: > Drop boilerplate license text and use SPDX identifier instead. > > Signed-off-by: Tomasz Duszynski Applied. Thanks, Jonathan > --- > drivers/iio/light/bh1750.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff

Re: [PATCH] infiniband: core: mad: Fix a sleep-in-atomic-context bug in ib_mad_recv_done()

2018-09-02 Thread Jason Gunthorpe
On Sat, Sep 01, 2018 at 08:06:59PM +0800, Jia-Ju Bai wrote: > The driver may sleep with holding a spinlock. > > The function call paths (from bottom to top) in Linux-4.16 are: > > [FUNC] alloc_mad_private(GFP_KERNEL) > drivers/infiniband/core/mad.c, 2264: > alloc_mad_private in ib_mad_recv

Re: [PATCH 2/3] iio: adc: Add Xilinx AMS driver

2018-09-02 Thread Jonathan Cameron
On Thu, 30 Aug 2018 15:52:18 +0530 Manish Narani wrote: > The AMS includes an ADC as well as on-chip sensors that can be used to > sample external voltages and monitor on-die operating conditions, such > as temperature and supply voltage levels. The AMS has two SYSMON blocks. > PL-SYSMON block is

Re: [PATCH 1/7] Compiler Attributes: remove unused attributes

2018-09-02 Thread Arnd Bergmann
On Fri, Aug 31, 2018 at 11:27 PM Nick Desaulniers wrote: > On Fri, Aug 31, 2018 at 1:23 PM Miguel Ojeda > wrote: > > On Fri, Aug 31, 2018 at 8:43 PM, Nick Desaulniers > > > I don't think minimal supported versions are required for these clean > > > ups, and would not block these patches from land

Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-09-02 Thread Richard Weinberger
Am Mittwoch, 29. August 2018, 16:38:34 CEST schrieb Sascha Hauer: > I assumed that make_reservation would align len anyway. I can't find the > place that led me to that assumption anymore and even if this is true > it's probably safer to just stick to the original len for the > non-authenticated ca

KMSAN: uninit-value in snd_midi_event_encode_byte

2018-09-02 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2dca2cbde67a kmsan: fix build warnings with CONFIG_KMSAN=n git tree: https://github.com/google/kmsan.git/master console output: https://syzkaller.appspot.com/x/log.txt?x=1660ef6a40 kernel config: https://syzkaller.appspot.com

[PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-02 Thread Nadav Amit
When page-table entries are set, the compiler might optimize their assignment by using multiple instructions to set the PTE. This might turn into a security hazard if the user somehow manages to use the interim PTE. L1TF does not make our lives easier, making even an interim non-present PTE a secur

Re: [PATCH 1/3] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2018-09-02 Thread Jonathan Cameron
On Thu, 30 Aug 2018 15:52:17 +0530 Manish Narani wrote: > Xilinx AMS have several ADC channels that can be used for measurement of > different voltages and temperatures. Document the same in the bindings. > > Signed-off-by: Manish Narani > --- > .../devicetree/bindings/iio/adc/xilinx-ams.txt

Re: [PATCH] iio: dac: ad5758: Add support for hard reset

2018-09-02 Thread Jonathan Cameron
On Wed, 29 Aug 2018 17:58:42 +0300 Stefan Popa wrote: > The ad5758 has a hardware reset active low input pin. This patch adds a > devicetree entry for a reset GPIO and a new ad5758_reset() function. > During > initialization, it is checked if the reset property is specified and the > the GPIO is

Re: [PATCH] iio: Convert to using %pOFn instead of device_node.name

2018-09-02 Thread Jonathan Cameron
On Mon, 27 Aug 2018 20:52:23 -0500 Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Jonathan Cameron > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: linux-...@vger.kernel.org > Si

Re: [PATCH] iio: adc: qcom-spmi-adc5: Verify channel numbers from DT

2018-09-02 Thread Jonathan Cameron
On Mon, 27 Aug 2018 14:14:53 -0700 Matthias Kaehlcke wrote: > The driver only defines a subset of all possible ADC channels. Channel > numbers read from the device tree are accepted as long as they don't > exceed a max value, even when no channel definition exists. Add a > check to abort initiali

Re: VLAs and security

2018-09-02 Thread Kees Cook
On Sun, Sep 2, 2018 at 1:08 AM, Uecker, Martin wrote: > I do not agree that VLAs are generally bad for security. > I think the opposite is true. A VLA with the right size > allows the compiler to automatically perform or insert > meaningful bounds checks, while a fixed upper bound does not. While

[PATCH v2 3/6] fork: provide a function for copying init_mm

2018-09-02 Thread Nadav Amit
Provide a function for copying init_mm. This function will be later used for setting a temporary mm. Cc: Andy Lutomirski Cc: Kees Cook Cc: Peter Zijlstra Cc: Dave Hansen Reviewed-by: Masami Hiramatsu Tested-by: Masami Hiramatsu Signed-off-by: Nadav Amit --- include/linux/sched/task.h | 1

[PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-02 Thread Nadav Amit
This patch-set addresses some issues that were raised in a recent correspondence and might affect the security and the correctness of code patching. (Note that patching performance is not addressed by this patch-set). The main issue that the patches deal with is the fact that the fixmap PTEs that

[PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-02 Thread Nadav Amit
text_mutex is expected to be held before text_poke() is called, but we cannot add a lockdep assertion since kgdb does not take it, and instead *supposedly* ensures the lock is not taken and will not be acquired by any other core while text_poke() is running. The reason for the "supposedly" comment

[PATCH v2 2/6] x86/mm: temporary mm struct

2018-09-02 Thread Nadav Amit
From: Andy Lutomirski Sometimes we want to set a temporary page-table entries (PTEs) in one of the cores, without allowing other cores to use - even speculatively - these mappings. There are two benefits for doing so: (1) Security: if sensitive PTEs are set, temporary mm prevents their use in ot

[PATCH v2 6/6] x86/alternatives: remove text_poke() return value

2018-09-02 Thread Nadav Amit
The return value of text_poke() is meaningless - it is one of the function inputs. One day someone may allow the callers to deal with text_poke() failures, if those actually happen. In the meanwhile, remove the return value. Cc: Andy Lutomirski Cc: Kees Cook Cc: Peter Zijlstra Reviewed-by: Mas

[PATCH v2 5/6] x86/alternatives: use temporary mm for text poking

2018-09-02 Thread Nadav Amit
text_poke() can potentially compromise the security as it sets temporary PTEs in the fixmap. These PTEs might be used to rewrite the kernel code from other cores accidentally or maliciously, if an attacker gains the ability to write onto kernel memory. Moreover, since remote TLBs are not flushed a

[PATCH v2 4/6] x86/alternatives: initializing temporary mm for patching

2018-09-02 Thread Nadav Amit
To prevent improper use of the PTEs that are used for text patching, we want to use a temporary mm struct. We initailize it by copying the init mm. The address that will be used for patching is taken from the lower area that is usually used for the task memory. Doing so prevents the need to freque

  1   2   3   4   5   >