[PATCH] Documentation/x86: fix typo in zero_page.txt

2018-10-23 Thread Randy Dunlap
From: Randy Dunlap Fix a typo in Documentation/x86/zero_page.txt. Signed-off-by: Randy Dunlap --- Documentation/x86/zero-page.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- lnx-419.orig/Documentation/x86/zero-page.txt +++ lnx-419/Documentation/x86/zero-page.txt @@ -25,7 +25,

[RFC v2 12/14] kunit.py: improve output from python wrapper

2018-10-23 Thread Brendan Higgins
- add colors to displayed output - add timing and summary Signed-off-by: Felix Guo Signed-off-by: Brendan Higgins --- tools/testing/kunit/kunit.py| 20 ++- tools/testing/kunit/kunit_parser.py | 93 - 2 files changed, 109 insertions(+), 4 deletions(-) dif

[PATCH 06/25] afs: Set up the iov_iter before calling afs_extract_data() [ver #2]

2018-10-23 Thread David Howells
afs_extract_data sets up a temporary iov_iter and passes it to AF_RXRPC each time it is called to describe the remaining buffer to be filled. Instead: (1) Put an iterator in the afs_call struct. (2) Set the iterator for each marshalling stage to load data into the appropriate places. A n

[PATCH 05/25] afs: Better tracing of protocol errors [ver #2]

2018-10-23 Thread David Howells
Include the site of detection of AFS protocol errors in trace lines to better be able to determine what went wrong. Signed-off-by: David Howells --- fs/afs/cmservice.c |6 ++ fs/afs/fsclient.c | 117 +++- fs/afs/inode.c |

[PATCH 04/25] iov_iter: Add I/O discard iterator [ver #2]

2018-10-23 Thread David Howells
Add a new iterator, ITER_DISCARD, that can only be used in READ mode and just discards any data copied to it. This is useful in a network filesystem for discarding any unwanted data sent by a server. Signed-off-by: David Howells --- include/linux/uio.h |7 ++ lib/iov_iter.c | 55

[PATCH 01/25] amd-gpu: Don't undefine READ and WRITE [ver #2]

2018-10-23 Thread David Howells
Remove the undefinition of READ and WRITE because these constants may be used elsewhere in subsequently included header files, thus breaking them. These constants don't actually appear to be used in the driver, so the undefinition seems pointless. Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc display

[PATCH 03/25] iov_iter: Separate type from direction and use accessor functions [ver #2]

2018-10-23 Thread David Howells
In the iov_iter struct, separate the iterator type from the iterator direction and use accessor functions to access them in most places. Convert a bunch of places to use switch-statements to access them rather then chains of bitwise-AND statements. This makes it easier to add further iterator typ

[PATCH 02/25] iov_iter: Use accessor function [ver #2]

2018-10-23 Thread David Howells
Use accessor functions to access an iterator's type and direction. This allows for the possibility of using some other method of determining the type of iterator than if-chains with bitwise-AND conditions. Signed-off-by: David Howells --- block/bio.c |2 +- fs/block_dev.c

[PATCH 00/25] AFS development [ver #2]

2018-10-23 Thread David Howells
Hi Al, Here's a set of development patches for AFS if you could pull it for the upcoming merge window. Its main features are: (1) Provide wrapper functions for accessing iov iterators and provide a new read discard iterator type (ITER_DISCARD). (2) Use iov iterators more directly in AF

Re: [PATCH v4 12/17] remoteproc: modify vring allocation to rely on centralized carveout allocator

2018-10-23 Thread Suman Anna
Hi Bjorn, Loic, On 10/15/18 1:40 AM, Bjorn Andersson wrote: > On Wed 10 Oct 11:58 PDT 2018, Loic PALLARDY wrote: > >> >> >>> -Original Message- >>> From: Bjorn Andersson [mailto:bjorn.anders...@linaro.org] >>> Sent: mercredi 10 octobre 2018 07:32 >>> To: Loic PALLARDY >>> Cc: o...@wizer

Re: [PATCH] x86: Remove -pipe from KBUILD_CFLAGS

2018-10-23 Thread Nick Desaulniers
On Tue, Oct 23, 2018 at 4:11 PM Nathan Chancellor wrote: > > Commit 77b0bf55bc67 ("kbuild/Makefile: Prepare for using macros in > inline assembly code to work around asm() related GCC inlining bugs") > added -Wa,- to KBUILD_CFLAGS, which breaks compiling with Clang (hangs > indefinitely at compili

Re: [PATCH] x86: Remove -pipe from KBUILD_CFLAGS

2018-10-23 Thread Nadav Amit
From: Nathan Chancellor Sent: October 23, 2018 at 11:11:25 PM GMT > To: Thomas Gleixner; Ingo Molnar; Borislav Petkov > Cc: H. Peter Anvin; x...@kernel.org, linux-kernel@vger.kernel.org, Nadav > Amit; Kees Cook; Masahiro Yamada; Nick Desaulniers; Nathan Chancellor > Subject: [PATCH] x86: Remove -

[PATCH] x86: Remove -pipe from KBUILD_CFLAGS

2018-10-23 Thread Nathan Chancellor
Commit 77b0bf55bc67 ("kbuild/Makefile: Prepare for using macros in inline assembly code to work around asm() related GCC inlining bugs") added -Wa,- to KBUILD_CFLAGS, which breaks compiling with Clang (hangs indefinitely at compiling init/main.o). This happens because while Clang accepts -pipe (and

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

2018-10-23 Thread hpa
On October 23, 2018 3:53:10 PM PDT, Nick Desaulniers wrote: >On Tue, Oct 23, 2018 at 3:44 PM Nathan Chancellor > wrote: >> >> On Tue, Oct 23, 2018 at 03:08:53PM -0700, Nick Desaulniers wrote: >> > On Tue, Oct 23, 2018 at 2:58 PM Nathan Chancellor >> > wrote: >> > > >> > > On Tue, Oct 23, 2018 at

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

2018-10-23 Thread Nick Desaulniers
On Tue, Oct 23, 2018 at 3:44 PM Nathan Chancellor wrote: > > On Tue, Oct 23, 2018 at 03:08:53PM -0700, Nick Desaulniers wrote: > > On Tue, Oct 23, 2018 at 2:58 PM Nathan Chancellor > > wrote: > > > > > > On Tue, Oct 23, 2018 at 01:01:22PM -0700, H. Peter Anvin wrote: > > > > On 10/23/18 11:40, Ni

[PATCH 6/9] fs/locks: change all *_conflict() functions to return bool.

2018-10-23 Thread NeilBrown
posix_locks_conflict() and flock_locks_conflict() both return int. leases_conflict() returns bool. This inconsistency will cause problems for the next patch if not fixed. So change posix_locks_conflict() and flock_locks_conflict() to return bool. Also change the locks_conflict() helper. And conv

[PATCH 9/9] VFS: locks: remove unnecessary white space.

2018-10-23 Thread NeilBrown
- spaces before tabs, - spaces at the end of lines, - multiple blank lines, - blank lines before EXPORT_SYMBOL, can all go. Signed-off-by: NeilBrown --- fs/locks.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/fs/locks.c b/fs/locks.

[PATCH 4/9] fs/locks: allow a lock request to block other requests.

2018-10-23 Thread NeilBrown
Currently, a lock can block pending requests, but all pending requests are equal. If lots of pending requests are mutually exclusive, this means they will all be woken up and all but one will fail. This can hurt performance. So we will allow pending requests to block other requests. Only the fir

[PATCH 7/9] fs/locks: create a tree of dependent requests.

2018-10-23 Thread NeilBrown
When we find an existing lock which conflicts with a request, and the request wants to wait, we currently add the request to a list. When the lock is removed, the whole list is woken. This can cause the thundering-herd problem. To reduce the problem, we make use of the (new) fact that a pending re

[PATCH 8/9] locks: merge posix_unblock_lock() and locks_delete_block()

2018-10-23 Thread NeilBrown
posix_unblock_lock() is not specific to posix locks, and behaves nearly identically to locks_delete_block() - the former returning a status while the later doesn't. So discard posix_unblock_lock() and use locks_delete_block() instead, after giving that function an appropriate return value. Signed

[PATCH 5/9] fs/locks: always delete_block after waiting.

2018-10-23 Thread NeilBrown
Now that requests can block other requests, we need to be careful to always clean up those blocked requests. Any time that we wait for a request, we might have other requests attached, and when we stop waiting, we must clean them up. If the lock was granted, the requests might have been moved to th

[PATCH 1/9] fs/locks: rename some lists and pointers.

2018-10-23 Thread NeilBrown
struct file lock contains an 'fl_next' pointer which is used to point to the lock that this request is blocked waiting for. So rename it to fl_blocker. The fl_blocked list_head in an active lock is the head of a list of blocked requests. In a request it is a node in that list. These are two dist

[PATCH 3/9] NFS: use locks_copy_lock() to copy locks.

2018-10-23 Thread NeilBrown
Using memcpy() to copy lock requests leave the various list_head in an inconsistent state. As we will soon attach a list of conflicting request to another pending request, we need these lists to be consistent. So change NFS to use locks_init_lock/locks_copy_lock instead of memcpy. Signed-off-by: N

[PATCH 2/9] fs/locks: split out __locks_wake_up_blocks().

2018-10-23 Thread NeilBrown
This functionality will be useful in future patches, so split it out from locks_wake_up_blocks(). Signed-off-by: NeilBrown --- fs/locks.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index a6c6d601286c..b8f33792a0a6 1

[PATCH 0/9 v3] locks: avoid thundering-herd wake-ups

2018-10-23 Thread NeilBrown
This took longer that I had wanted, due to various reasons - sorry. And I'm now posting it in a merge window, which is not ideal. I don't expect it to be included in this merge window and I won't be at all impatient for review, but I didn't want to delay it further. Testing found some problems, p

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

2018-10-23 Thread Nathan Chancellor
On Tue, Oct 23, 2018 at 03:08:53PM -0700, Nick Desaulniers wrote: > On Tue, Oct 23, 2018 at 2:58 PM Nathan Chancellor > wrote: > > > > On Tue, Oct 23, 2018 at 01:01:22PM -0700, H. Peter Anvin wrote: > > > On 10/23/18 11:40, Nick Desaulniers wrote: > > > > On Mon, Oct 22, 2018 at 10:11 PM Nadav Ami

Re: [RFC][PATCH 03/10] hfsplus: use fs_umode_to_dtype() helper

2018-10-23 Thread Viacheslav Dubeyko
On Tue, 2018-10-23 at 21:19 +0100, Phillip Potter wrote: > Replace if/else statements with common lookup table implementation. > > Original patch written by Amir Goldstein. > > Signed-off-by: Phillip Potter > --- > fs/hfsplus/dir.c | 16 ++-- > 1 file changed, 2 insertions(+), 14 de

Re: [PATCH 2/3] staging: greybus: loopback.c: do insertion in O(n) instead of O(n lg n)

2018-10-23 Thread Bryan O'Donoghue
On 23/10/2018 17:20, Rasmus Villemoes wrote: On 2018-10-11 01:03, Bryan O'Donoghue wrote: On 05/10/2018 15:28, Rasmus Villemoes wrote: Signed-off-by: Rasmus Villemoes --- I have no idea if the performance matters (it probably doesn't). Feel free to ignore this and the followup cleanup. What's

[PATCH] modpost: validate symbol names also in find_elf_symbol

2018-10-23 Thread Sami Tolvanen
If an ARM mapping symbol shares an address with a valid symbol, find_elf_symbol can currently return the mapping symbol instead, as the symbol is not validated. This can result in confusing warnings: WARNING: vmlinux.o(.text+0x18f4028): Section mismatch in reference from the function set_reset

Re: [PATCH v4 10/17] remoteproc: add helper function to check carveout device address

2018-10-23 Thread Suman Anna
Hi Loic, On 7/27/18 8:14 AM, Loic Pallardy wrote: > This patch introduces a function to verify that a specified carveout > is fitting request device address and associated length > > Signed-off-by: Loic Pallardy > --- > drivers/remoteproc/remoteproc_core.c | 47 > ++

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

2018-10-23 Thread Nick Desaulniers
On Tue, Oct 23, 2018 at 2:58 PM Nathan Chancellor wrote: > > On Tue, Oct 23, 2018 at 01:01:22PM -0700, H. Peter Anvin wrote: > > On 10/23/18 11:40, Nick Desaulniers wrote: > > > On Mon, Oct 22, 2018 at 10:11 PM Nadav Amit wrote: > > >> > > >> at 5:37 PM, Nathan Chancellor wrote: > > >> > > >> Co

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

2018-10-23 Thread hpa
On October 23, 2018 2:58:11 PM PDT, Nathan Chancellor wrote: >On Tue, Oct 23, 2018 at 01:01:22PM -0700, H. Peter Anvin wrote: >> On 10/23/18 11:40, Nick Desaulniers wrote: >> > On Mon, Oct 22, 2018 at 10:11 PM Nadav Amit >wrote: >> >> >> >> at 5:37 PM, Nathan Chancellor wrote: >> >> >> >> Commi

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

2018-10-23 Thread Nathan Chancellor
On Tue, Oct 23, 2018 at 01:01:22PM -0700, H. Peter Anvin wrote: > On 10/23/18 11:40, Nick Desaulniers wrote: > > On Mon, Oct 22, 2018 at 10:11 PM Nadav Amit wrote: > >> > >> at 5:37 PM, Nathan Chancellor wrote: > >> > >> Commit 77b0bf55bc67 ("kbuild/Makefile: Prepare for using macros in > >> inli

Re: [PATCH v2] cpufreq: intel_pstate: Fix compilation for !CONFIG_ACPI

2018-10-23 Thread Srinivas Pandruvada
On Tue, 2018-10-23 at 21:54 +0200, Dominik Brodowski wrote: > While at it, add a few comments which config options #ifdef > and #else statements refer to. > > Fixes: 86d333a8cc7f ("cpufreq: intel_pstate: Add base_frequency > attribute") > Cc: Srinivas Pandruvada > Cc: Rafael J. Wysocki > Signed-

Re: [PATCH v2] kernel/signal: Signal-based pre-coredump notification

2018-10-23 Thread Enke Chen
Hi, Oleg: On 10/23/18 12:43 PM, Enke Chen wrote: >> >>> --- a/fs/coredump.c >>> +++ b/fs/coredump.c >>> @@ -546,6 +546,7 @@ void do_coredump(const kernel_siginfo_t *siginfo) >>> struct cred *cred; >>> int retval = 0; >>> int ispipe; >>> + bool notify; >>> struct files_struct *di

[PATCH 04/17] prmem: dynamic allocation

2018-10-23 Thread Igor Stoppa
Extension of protected memory to dynamic allocations. Allocations are performed from "pools". A pool is a list of virtual memory areas, in various state of protection. Supported cases === Read Only Pool -- Memory is allocated from the pool, in writable state. Then it gets

[PATCH 01/17] prmem: linker section for static write rare

2018-10-23 Thread Igor Stoppa
Introduce a section and a label for statically allocated write rare data. The label is named "__write_rare_after_init". As the name implies, after the init phase is completed, this section will be modifiable only by invoking write rare functions. NOTE: this needs rework, because the current write

[PATCH 06/17] prmem: test cases for memory protection

2018-10-23 Thread Igor Stoppa
The test cases verify the various interfaces offered by both prmem.h and prmemextra.h The tests avoid triggering crashes, by not performing actions that would be treated as illegal. That part is handled in the lkdtm patch. Signed-off-by: Igor Stoppa CC: Michal Hocko CC: Vlastimil Babka CC: "Ki

[PATCH 11/17] prmem: llist: use designated initializer

2018-10-23 Thread Igor Stoppa
Using a list_head in an unnamed union poses a problem with the current implementation of the initializer, since it doesn't specify the names of the fields it is initializing. This patch makes it use designated initializers. Signed-off-by: Igor Stoppa CC: Kate Stewart CC: "David S. Miller" CC:

[PATCH 08/17] prmem: struct page: track vmap_area

2018-10-23 Thread Igor Stoppa
When a page is used for virtual memory, it is often necessary to obtain a handler to the corresponding vmap_area, which refers to the virtually continuous area generated, when invoking vmalloc. The struct page has a "private" field, which can be re-used, to store a pointer to the parent area. Not

[PATCH 12/17] prmem: linked list: set alignment

2018-10-23 Thread Igor Stoppa
As preparation to using write rare on the nodes of various types of lists, specify that the fields in the basic data structures must be aligned to sizeof(void *) It is meant to ensure that any static allocation will not cross a page boundary, to allow pointers to be updated in one step. Signed-of

[PATCH 14/17] prmem: llist, hlist, both plain and rcu

2018-10-23 Thread Igor Stoppa
In some cases, all the data needing protection can be allocated from a pool in one go, as directly writable, then initialized and protected. The sequence is relatively short and it's acceptable to leave the entire data set unprotected. In other cases, this is not possible, because the data will tr

[PATCH 09/17] prmem: hardened usercopy

2018-10-23 Thread Igor Stoppa
Prevent leaks of protected memory to userspace. The protection from overwrited from userspace is already available, once the memory is write protected. Signed-off-by: Igor Stoppa CC: Kees Cook CC: Chris von Recklinghausen CC: linux...@kvack.org CC: linux-kernel@vger.kernel.org --- include/linu

[PATCH 16/17] prmem: pratomic-long

2018-10-23 Thread Igor Stoppa
Minimalistic functionality for having the write rare version of atomic_long_t data. Signed-off-by: Igor Stoppa CC: Will Deacon CC: Peter Zijlstra CC: Boqun Feng CC: Arnd Bergmann CC: linux-a...@vger.kernel.org CC: linux-kernel@vger.kernel.org --- MAINTAINERS | 1 + include

[PATCH 15/17] prmem: test cases for prlist and prhlist

2018-10-23 Thread Igor Stoppa
These test cases focus on the basic operations required to operate both prlist and prhlist data, in particular creating, growing, shrinking, destroying. They can also be useful as reference for practical use of write-rare lists. Signed-off-by: Igor Stoppa CC: Kate Stewart CC: Philippe Ombredann

[PATCH 13/17] prmem: linked list: disable layout randomization

2018-10-23 Thread Igor Stoppa
Some of the data structures used in list management are composed by two pointers. Since the kernel is now configured by default to randomize the layout of data structures soleley composed by pointers, this might prevent correct type punning between these structures and their write rare counterpart.

[PATCH 17/17] prmem: ima: turn the measurements list write rare

2018-10-23 Thread Igor Stoppa
The measurement list is moved to write rare memory, including related data structures. Various boilerplate linux data structures and related functions are replaced by their write-rare counterpart. Signed-off-by: Igor Stoppa CC: Mimi Zohar CC: Dmitry Kasatkin CC: James Morris CC: "Serge E. Hal

[PATCH 03/17] prmem: vmalloc support for dynamic allocation

2018-10-23 Thread Igor Stoppa
Prepare vmalloc for: - tagging areas used for dynamic allocation of protected memory - supporting various tags, related to the property that an area might have - extrapolating the pool containing a given area - chaining the areas in each pool - extrapolating the area containing a given memory addre

[PATCH 05/17] prmem: shorthands for write rare on common types

2018-10-23 Thread Igor Stoppa
Wrappers around the basic write rare functionality, addressing several common data types found in the kernel, allowing to specify the new values through immediates, like constants and defines. Note: The list is not complete and could be expanded. Signed-off-by: Igor Stoppa CC: Michal Hocko CC:

[PATCH 07/17] prmem: lkdtm tests for memory protection

2018-10-23 Thread Igor Stoppa
Various cases meant to verify that illegal operations on protected memory will either BUG() or WARN(). The test cases fall into 2 main categories: - trying to overwrite (directly) something that is write protected - trying to use write rare functions on something that is not write rare Signed-off

[PATCH 02/17] prmem: write rare for static allocation

2018-10-23 Thread Igor Stoppa
Implementation of write rare for statically allocated data, located in a specific memory section through the use of the __write_rare label. The basic functions are wr_memcpy() and wr_memset(): the write rare counterparts of memcpy() and memset() respectively. To minimize chances of attacks, this

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-23 Thread Helen Koike
Hi Leonardo, On 10/22/18 11:10 PM, Leonardo Brás wrote: > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which > the var

Re: [PATCH v6 10/15] tracing: Add hist trigger snapshot() action test case

2018-10-23 Thread Tom Zanussi
Hi Masami, On Wed, 2018-10-24 at 00:03 +0900, Masami Hiramatsu wrote: > On Thu, 11 Oct 2018 16:02:07 -0500 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Add a test case verifying the basic functionality of the > > hist:snapshot() action. > > > > I think this is OK for current tracing

Re: [PATCH] Revert "workqueue: re-add lockdep dependencies for flushing"

2018-10-23 Thread Sagi Grimberg
I also commented over there regarding this specific problem. I think my wording was inaccurate perhaps. It's not so much direct recursion, but a dependency chain connecting the handler_mutex class back to itself. This is how lockdep finds problems, it doesn't consider actual *instances* but o

Re: [PATCH v6 07/15] tracing: Move hist trigger key printing into a separate function

2018-10-23 Thread Tom Zanussi
Hi Masami, On Tue, 2018-10-23 at 23:37 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Thu, 11 Oct 2018 16:02:04 -0500 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Future patches will want to print a histogram key outside a > > histogram > > - add and use hist_trigger_print_key() for

[RFC] dm-bow working prototype

2018-10-23 Thread Paul Lawrence
bow == backup on write Similar to dm-snap, add the ability to take a snapshot of a device. Unlike dm-snap, a separate volume is not required. dm-bow can be in one of three states. In state one, the free blocks on the device are identified by issuing an FSTRIM to the filesystem. In state two, an

Re: [PATCH v4 08/17] remoteproc: add alloc ops in rproc_mem_entry struct

2018-10-23 Thread Suman Anna
Hi Loic, On 7/27/18 8:14 AM, Loic Pallardy wrote: > Memory entry could be allocated in different ways (ioremap, > dma_alloc_coherent, internal RAM allocator...). > This patch introduces an alloc ops in rproc_mem_entry structure > to associate dedicated allocation mechanism to each memory entry > d

Re: [PATCH] thermal: bcm2835: enable hwmon explicitly

2018-10-23 Thread Matthias Brugger
Hi Stefan, On 23/10/2018 14:01, Stefan Wahren wrote: > Hi Matthias, > >> matthias@kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben: >> >> >> From: Matthias Brugger >> >> By defaul of-based thermal driver do not enable hwmon. >> This patch does this explicitly, so that the temperature

[RFC][PATCH v2 04/10] ext2: use common file type conversion

2018-10-23 Thread Phillip Potter
Deduplicate the ext2 file type conversion implementation. Original patch by Amir Goldstein. v2: - Rebased against Linux 4.19 by Phillip Potter - This version does not remove EXT2_FT_x enum from fs/ext2/ext2.h, as these values are now used in compile-time checks added by Phillip Potter to make

Re: [PATCH v6 01/15] tracing: Refactor hist trigger action code

2018-10-23 Thread Tom Zanussi
Hi Masami, On Tue, 2018-10-23 at 14:09 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Thu, 11 Oct 2018 16:01:58 -0500 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > The hist trigger action code currently implements two essentially > > hard-coded pairs of 'actions' - onmax(), which trac

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-23 Thread Helen Koike
Hi Leonardo, Thanks for your patch. On 10/22/18 11:10 PM, Leonardo Brás wrote: > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADD

Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-23 Thread NeilBrown
On Tue, Oct 23 2018, Theodore Y. Ts'o wrote: > On Tue, Oct 23, 2018 at 03:25:08PM +1100, NeilBrown wrote: >> >> Yes, you could, and you can. But if it was Linus who was behaving >> inappropriately, where did you go then? This is why I think whatever >> "code" we have should be overtly a stateme

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Joel Fernandes
On Tue, Oct 23, 2018 at 01:09:23PM -0700, Matthew Wilcox wrote: > On Tue, Oct 23, 2018 at 01:48:32PM -0600, Shuah Khan wrote: > > On 10/23/2018 01:30 PM, Joel Fernandes wrote: > > > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: > > >> I like this proposal. I think we will open up lot

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Shuah Khan
On 10/23/2018 02:09 PM, Matthew Wilcox wrote: > On Tue, Oct 23, 2018 at 01:48:32PM -0600, Shuah Khan wrote: >> On 10/23/2018 01:30 PM, Joel Fernandes wrote: >>> On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: I like this proposal. I think we will open up lot of test opportunities

Re: [PATCH v4 03/17] remoteproc: add release ops in rproc_mem_entry struct

2018-10-23 Thread Suman Anna
On 10/23/18 11:53 AM, Suman Anna wrote: > On 7/27/18 8:14 AM, Loic Pallardy wrote: >> Memory entry could be allocated in different ways (ioremap, >> dma_alloc_coherent, internal RAM allocator...). >> This patch introduces a release ops in rproc_mem_entry structure >> to associate dedicated release

Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-23 Thread NeilBrown
On Tue, Oct 23 2018, Al Viro wrote: > On Tue, Oct 23, 2018 at 04:28:03PM +1100, NeilBrown wrote: > >> > If that's a clarification, I'm sorry to say that I understand you even >> > less now. >> > What are you proposing? Duopoly? How do you deal with disagreements? >> > Fork? >> > Revert wars?

Re: Git pull ack emails..

2018-10-23 Thread Jacek Anaszewski
On 10/23/2018 02:13 PM, Ulf Hansson wrote: > On 23 October 2018 at 10:41, Linus Torvalds > wrote: >> So I've obviously started pulling stuff for the merge window, and one >> of the things I noticed with Greg doing it for the last few weeks was >> that he has this habit (or automation) to send Ack

Re: [RFC PATCH 0/5] x86: dynamic indirect call promotion

2018-10-23 Thread Dave Hansen
On 10/23/18 1:32 PM, Nadav Amit wrote: >> On 10/17/18 5:54 PM, Nadav Amit wrote: >>> baserelpoline >>> - >>> nginx 22898 25178 (+10%) >>> redis-ycsb 24523 25486 (+4%) >>> dbench 21442103 (+2%) >> Just ou

Re: [PATCH] ARM: debug: enable UART1 for socfpga Cyclone5

2018-10-23 Thread Dinh Nguyen
On 10/23/2018 09:44 AM, Clément Péron wrote: > HI Dinh, > > On Tue, 23 Oct 2018 at 16:04, Dinh Nguyen wrote: >> >> Hi Clément, >> >> On 10/09/2018 06:28 AM, Clément Péron wrote: >>> Cyclone5 and Arria10 doesn't have the same memory map for UART1. >>> >>> Split the SOCFPGA_UART1 into 2 options

Re: [PATCH v2] wireless: mark expected switch fall-throughs

2018-10-23 Thread Johannes Berg
On Tue, 2018-10-23 at 12:58 +0200, Gustavo A. R. Silva wrote: > On 10/23/18 10:59 AM, Gustavo A. R. Silva wrote: > > > > On 10/23/18 9:01 AM, Johannes Berg wrote: > > > On Tue, 2018-10-23 at 02:13 +0200, Gustavo A. R. Silva wrote: > > > > In preparation to enabling -Wimplicit-fallthrough, mark swi

Re: [PATCH V2 17/19] perf scripts python: exported-sql-viewer.py: Add All branches report

2018-10-23 Thread Adrian Hunter
On 23/10/18 11:02 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 23, 2018 at 07:57:17PM +, Hunter, Adrian escreveu: >>> -Original Message- >>> From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] >>> Sent: Tuesday, October 23, 2018 10:30 PM >>> To: Hunter, Adrian >>> Cc: Jiri Ols

Re: [RFC PATCH 0/5] x86: dynamic indirect call promotion

2018-10-23 Thread Nadav Amit
at 11:36 AM, Dave Hansen wrote: > On 10/17/18 5:54 PM, Nadav Amit wrote: >> base relpoline >> - >> nginx22898 25178 (+10%) >> redis-ycsb 24523 25486 (+4%) >> dbench 21442103 (+2%) > > Just out of curiosi

Re: [PATCH v2 2/3] leds: upboard: Add LED support

2018-10-23 Thread Jacek Anaszewski
On 10/23/2018 09:23 PM, Joe Perches wrote: > On Tue, 2018-10-23 at 20:50 +0200, Jacek Anaszewski wrote: >>> diff --git a/drivers/leds/leds-upboard.c b/drivers/leds/leds-upboard.c >>> new file mode 100644 >>> index 000..34a6973 >>> --- /dev/null >>> +++ b/drivers/leds/leds-upboard.c >>> @@ -0,0

Re: [PATCH] Revert "workqueue: re-add lockdep dependencies for flushing"

2018-10-23 Thread Johannes Berg
On Tue, 2018-10-23 at 21:50 +0200, Johannes Berg wrote: > > The reason for the report is that with the workqueue annotations, we've > added new links to the chains that lockdep sees. I _think_ those > annotations are correct and only create links in the chain when they are > actually present, but

[RFC][PATCH v2 08/10] f2fs: use common file type conversion

2018-10-23 Thread Phillip Potter
Deduplicate the f2fs file type conversion implementation. Original patch by Amir Goldstein. v2: - Rebased against Linux 4.19 by Phillip Potter - Compile-time checks added by Phillip Potter to make sure the F2FS_FT_x enum values stay same as FT_x values v1: - Initial implementation Signed-off-

[RFC][PATCH 03/10] hfsplus: use fs_umode_to_dtype() helper

2018-10-23 Thread Phillip Potter
Replace if/else statements with common lookup table implementation. Original patch written by Amir Goldstein. Signed-off-by: Phillip Potter --- fs/hfsplus/dir.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/fs/hfsplus/dir.c b/fs/hfsplus/dir.c index f37662

[RFC][PATCH v3 01/10] fs: common implementation of file type

2018-10-23 Thread Phillip Potter
Many file systems use a copy&paste implementation of dirent to on-disk file type conversions. Create a common implementation to be used by file systems with some useful conversion helpers to reduce open coded file type conversions in file system code. Original patch written by Amir Goldstein. v3

[RFC][PATCH v2 09/10] nilfs2: use common file type conversion

2018-10-23 Thread Phillip Potter
Deduplicate the nilfs2 file type conversion implementation. Original patch by Amir Goldstein. v2: - Compile-time checks added by Phillip Potter to make sure the NILFS_FT_x enum values stay same as FT_x values v1: - Initial implementation Signed-off-by: Phillip Potter --- fs/nilfs2/dir.c

[RFC][PATCH 02/10] ufs: use fs_umode_to_dtype() helper

2018-10-23 Thread Phillip Potter
Replace switch statement with common lookup table implementation. Original patch written by Amir Goldstein. Signed-off-by: Phillip Potter --- fs/ufs/util.h | 29 + 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/fs/ufs/util.h b/fs/ufs/util.h index 1fd30

[RFC][PATCH 00/11] common implementation of dirent file types

2018-10-23 Thread Phillip Potter
This cleanup series is a respin of Amir Goldstein's work, created in late 2016. It removes several instances of duplicated code. Most of the duplication dates back to git pre-historic era. The controversial aspect of this cleanup is that it uses common code to handle file system specific on-disk f

[RFC][PATCH v2 05/10] exofs: use common file type conversion

2018-10-23 Thread Phillip Potter
Deduplicate the exofs file type conversion implementation. Original patch by Amir Goldstein. v2: - This version does not remove EXOFS_FT_x enum from fs/exofs/common.h, as these values are now used in compile-time checks added by Phillip Potter to make sure they remain the same as FT_x values

[RFC][PATCH v2 06/10] ext4: use common file type conversion

2018-10-23 Thread Phillip Potter
Deduplicate the ext4 file type conversion implementation. Original patch by Amir Goldstein. v2: - Rebased against Linux 4.19 by Phillip Potter - This version does not replace the EXT4_FT_x defines from fs/ext4/ext4.h, as these values are now used in compile-time checks added by Phillip Potter

[RFC][PATCH v2 04/10] ext2: use common file type conversion

2018-10-23 Thread Phillip Potter
Deduplicate the ext2 file type conversion implementation. Original patch by Amir Goldstein. v2: - Rebased against Linux 4.19 by Phillip Potter - This version does not remove EXT2_FT_x enum from fs/ext2/ext2.h, as these values are now used in compile-time checks added by Phillip Potter to make

Re: [PATCH stable v2 1/2] termios, tty/tty_baudrate.c: fix buffer overrun

2018-10-23 Thread H. Peter Anvin
On 10/23/18 09:02, h...@zytor.com wrote: >> >> As I think Al's big termios cleanups are going to be hitting Linus's >> tree soon, do you know how these patches interact with that? >> >> This patch seems like it will not, so I'll be glad to queue that up >> after my first round of patches get merged

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Matthew Wilcox
On Tue, Oct 23, 2018 at 01:48:32PM -0600, Shuah Khan wrote: > On 10/23/2018 01:30 PM, Joel Fernandes wrote: > > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: > >> I like this proposal. I think we will open up lot of test opportunities > >> with > >> this approach. > >> > >> Maybe we

[GIT PULL] XArray for 4.20

2018-10-23 Thread Matthew Wilcox
Hi Linus, Please consider pulling the XArray patch set. The XArray provides an improved interface to the radix tree data structure, providing locking as part of the API, specifying GFP flags at allocation time, eliminating preloading, less re-walking the tree, more efficient iterations and not ex

Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.

2018-10-23 Thread Kees Cook
On Mon, Oct 22, 2018 at 10:11 PM, Konstantin Khlebnikov wrote: > On 23.10.2018 7:15, Joe Perches wrote:> On Mon, 2018-10-22 at 22:53 +0530, > Arun KS wrote: >>> Remove managed_page_count_lock spinlock and instead use atomic >>> variables. >> >> Perhaps better to define and use macros for the acces

Re: Git pull ack emails..

2018-10-23 Thread Konstantin Ryabitsev
On Tue, Oct 23, 2018 at 10:46:06AM +0100, Linus Torvalds wrote: If it's a "proper" pull request (ie done by git request-pull), then the magic marker would be that it as that for you to fetch changes up to %H: line where %H is the hash of the tip of the tree that is requested to be pulled. T

Re: [PATCH V2 17/19] perf scripts python: exported-sql-viewer.py: Add All branches report

2018-10-23 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 23, 2018 at 07:57:17PM +, Hunter, Adrian escreveu: > > -Original Message- > > From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] > > Sent: Tuesday, October 23, 2018 10:30 PM > > To: Hunter, Adrian > > Cc: Jiri Olsa ; Andi Kleen ; linux- > > ker...@vger.kernel.org > > S

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

2018-10-23 Thread H. Peter Anvin
On 10/23/18 11:40, Nick Desaulniers wrote: > On Mon, Oct 22, 2018 at 10:11 PM Nadav Amit wrote: >> >> at 5:37 PM, Nathan Chancellor wrote: >> >> Commit 77b0bf55bc67 ("kbuild/Makefile: Prepare for using macros in >> inline assembly code to work around asm() related GCC inlining bugs") >> added thi

Re: Git pull ack emails..

2018-10-23 Thread Olof Johansson
On Tue, Oct 23, 2018 at 9:42 AM Linus Torvalds wrote: > > So I've obviously started pulling stuff for the merge window, and one > of the things I noticed with Greg doing it for the last few weeks was > that he has this habit (or automation) to send Ack emails when he > pulls. > > In fact, I reacte

Re: [PATCH] Revert "workqueue: re-add lockdep dependencies for flushing"

2018-10-23 Thread Johannes Berg
On Tue, 2018-10-23 at 21:44 +0200, Johannes Berg wrote: > > There is > > no agreement however that the kind of checking implemented by the > > "crosslock" > > code made sense. My understanding is that you are trying to reintroduce > > through a backdoor some of the crosslock code. > > Not at al

Re: [RFC PATCH] cgroup, netclassid: add a preemption point to write_classid

2018-10-23 Thread Tejun Heo
On Thu, Oct 18, 2018 at 10:56:17AM +0200, Michal Hocko wrote: > From: Michal Hocko > > We have seen a customer complaining about soft lockups on !PREEMPT > kernel config with 4.4 based kernel ... > If a cgroup has many tasks with many open file descriptors then we would > end up in a large loop w

RE: [PATCH V2 17/19] perf scripts python: exported-sql-viewer.py: Add All branches report

2018-10-23 Thread Hunter, Adrian
> -Original Message- > From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] > Sent: Tuesday, October 23, 2018 10:30 PM > To: Hunter, Adrian > Cc: Jiri Olsa ; Andi Kleen ; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH V2 17/19] perf scripts python: exported-sql-viewer.py: > Add A

[PATCH v2] cpufreq: intel_pstate: Fix compilation for !CONFIG_ACPI

2018-10-23 Thread Dominik Brodowski
While at it, add a few comments which config options #ifdef and #else statements refer to. Fixes: 86d333a8cc7f ("cpufreq: intel_pstate: Add base_frequency attribute") Cc: Srinivas Pandruvada Cc: Rafael J. Wysocki Signed-off-by: Dominik Brodowski diff --git a/drivers/cpufreq/intel_pstate.c b/dr

Re: [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits

2018-10-23 Thread Doug Anderson
Hi, On Mon, Oct 22, 2018 at 6:07 PM Ryan Case wrote: > > Address remaining comments from original driver patch series > > * Move RD_FIFO_CFG to be ordered corretly > * Expand spinlock comment > > Signed-off-by: Ryan Case > --- > > drivers/spi/spi-qcom-qspi.c | 8 > 1 file changed, 4 ins

Re: [PATCH] rdmacg: fix a typo in rdmacg documentation

2018-10-23 Thread Tejun Heo
On Tue, Oct 23, 2018 at 06:01:06PM +0300, Rami Rosen wrote: > This patch fixes a typo in RDMA cgroup documentation. > > Signed-off-by: Rami Rosen Applied to cgroup/for-4.20. Thanks. -- tejun

RE: [PATCH v4 02/17] remoteproc: add rproc_va_to_pa function

2018-10-23 Thread Loic PALLARDY
Hi Suman, > -Original Message- > From: Suman Anna > Sent: mardi 23 octobre 2018 18:51 > To: Loic PALLARDY ; bjorn.anders...@linaro.org; > o...@wizery.com > Cc: linux-remotep...@vger.kernel.org; linux-kernel@vger.kernel.org; > Arnaud POULIQUEN ; > benjamin.gaign...@linaro.org > Subject: Re

Re: [PATCH] Revert "workqueue: re-add lockdep dependencies for flushing"

2018-10-23 Thread Johannes Berg
On Mon, 2018-10-22 at 18:17 -0700, Bart Van Assche wrote: > It seems to me that the inode lock has been annotated correctly as an > rwsem. It's not clear to me however why lockdep complains about a > deadlock for the direct I/O code. I hope someone has the time to go to > the bottom of this. I

RE: [PATCH v4 06/17] remoteproc: introduce rproc_add_carveout function

2018-10-23 Thread Loic PALLARDY
> -Original Message- > From: Suman Anna > Sent: mardi 23 octobre 2018 19:05 > To: Loic PALLARDY ; bjorn.anders...@linaro.org; > o...@wizery.com > Cc: linux-remotep...@vger.kernel.org; linux-kernel@vger.kernel.org; > Arnaud POULIQUEN ; > benjamin.gaign...@linaro.org > Subject: Re: [PATCH

<    1   2   3   4   5   6   >