Re: [RFC PATCH 2/3] mm, memory_hotplug: deobfuscate migration part of offlining

2018-11-20 Thread Michal Hocko
On Tue 20-11-18 15:26:43, David Hildenbrand wrote: [...] > > + do { > > + for (pfn = start_pfn; pfn;) > > + { > > { on a new line looks weird. > > > + /* start memory hot removal */ > > + ret = -EINTR; > > I think we can move that into th

Re: [RFC PATCH 1/3] mm, memory_hotplug: try to migrate full section worth of pages

2018-11-20 Thread Pavel Tatashin
On 18-11-20 14:43:21, Michal Hocko wrote: > From: Michal Hocko > > do_migrate_range has been limiting the number of pages to migrate to 256 > for some reason which is not documented. Even if the limit made some > sense back then when it was introduced it doesn't really serve a good > purpose thes

Re: [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page

2018-11-20 Thread David Hildenbrand
On 20.11.18 14:43, Michal Hocko wrote: > From: Michal Hocko > > filemap_map_pages takes a speculative reference to each page in the > range before it tries to lock that page. While this is correct it > also can influence page migration which will bail out when seeing > an elevated reference count

Re: [RFC PATCH 1/3] mm, memory_hotplug: try to migrate full section worth of pages

2018-11-20 Thread David Hildenbrand
On 20.11.18 15:25, Michal Hocko wrote: > On Tue 20-11-18 15:18:41, David Hildenbrand wrote: > [...] >> (we could also check for pending signals inside that function if really >> required) > > do_migrate_pages is not the proper layer to check signals. Because the > loop only isolates pages and that

Re: [RFC PATCH 2/3] mm, memory_hotplug: deobfuscate migration part of offlining

2018-11-20 Thread David Hildenbrand
On 20.11.18 14:43, Michal Hocko wrote: > From: Michal Hocko > > Memory migration might fail during offlining and we keep retrying in > that case. This is currently obfuscate by goto retry loop. The code > is hard to follow and as a result it is even suboptimal becase each > retry round scans the

Re: [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page

2018-11-20 Thread Michal Hocko
On Tue 20-11-18 17:17:00, Kirill A. Shutemov wrote: > On Tue, Nov 20, 2018 at 03:12:07PM +0100, Michal Hocko wrote: > > On Tue 20-11-18 17:07:15, Kirill A. Shutemov wrote: > > > On Tue, Nov 20, 2018 at 02:43:23PM +0100, Michal Hocko wrote: > > > > From: Michal Hocko > > > > > > > > filemap_map_pa

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-20 Thread Ulf Hansson
On 20 November 2018 at 15:00, Sjoerd Simons wrote: > On Tue, 2018-11-20 at 14:08 +0100, Ulf Hansson wrote: >> + Hal Emmerich >> >> On 20 November 2018 at 12:38, Sjoerd Simons >> wrote: >> > On Tue, 2018-11-20 at 11:23 +0100, Wolfram Sang wrote: >> > > > > > >> > So if you know the pattern, or jus

Re: [RFC PATCH 1/3] mm, memory_hotplug: try to migrate full section worth of pages

2018-11-20 Thread Michal Hocko
On Tue 20-11-18 15:18:41, David Hildenbrand wrote: [...] > (we could also check for pending signals inside that function if really > required) do_migrate_pages is not the proper layer to check signals. Because the loop only isolates pages and that is not expensive. The most expensive part is deepe

Re: [PATCH 21/25] procfs: Use vtime aware kcpustat accessor

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:46:05AM +0100, Frederic Weisbecker wrote: > /* Copy values here to work around gcc-2.95.3, gcc-2.96 */ Just a note to let you know the current minimum GCC version is 4.6 :-)

Re: [PATCH 20/25] sched/kcpustat: Introduce vtime-aware kcpustat accessor

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:46:04AM +0100, Frederic Weisbecker wrote: > +void kcpustat_cputime(struct kernel_cpustat *kcpustat, int cpu, > + u64 *user, u64 *nice, u64 *system, > + u64 *guest, u64 *guest_nice) > +{ > + struct task_struct *curr; > + struct

Re: [RFC PATCH 1/3] mm, memory_hotplug: try to migrate full section worth of pages

2018-11-20 Thread David Hildenbrand
On 20.11.18 14:43, Michal Hocko wrote: > From: Michal Hocko > > do_migrate_range has been limiting the number of pages to migrate to 256 > for some reason which is not documented. Even if the limit made some > sense back then when it was introduced it doesn't really serve a good > purpose these d

Re: [PATCH 19/25] sched/vite: Handle nice updates under vtime

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:46:03AM +0100, Frederic Weisbecker wrote: > On the vtime level, nice updates are currently handled on context > switches. When a task's nice value gets updated while it is sleeping, > the context switch takes into account the new nice value in order to > later record the

[PATCH v5 1/8] regulator: lochnagar: Move driver to binding from DT

2018-11-20 Thread Charles Keepax
Based on review comments on the MFD driver, move the child drivers for the Lochnagar MFD over to binding through device tree. Signed-off-by: Charles Keepax --- Changes since v4: - Split out regulator binding for each regulator Thanks, Charles drivers/regulator/lochnagar-regulator.c | 48

[PATCH v5 5/8] regulator: lochnagar: Add initial binding documentation

2018-11-20 Thread Charles Keepax
Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows the connection of most Cirrus Logic devices on mini-cards, as well as allowing connection of various application processor systems to provide a full evaluation platform. This driver supports the

[PATCH v5 3/8] clk: lochnagar: Add initial binding documentation

2018-11-20 Thread Charles Keepax
Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows the connection of most Cirrus Logic devices on mini-cards, as well as allowing connection of various application processor systems to provide a full evaluation platform. This driver supports the

[PATCH v5 7/8] clk: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-11-20 Thread Charles Keepax
Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows the connection of most Cirrus Logic devices on mini-cards, as well as allowing connection of various application processor systems to provide a full evaluation platform. This driver supports the

[PATCH v5 4/8] pinctrl: lochnagar: Add initial binding documentation

2018-11-20 Thread Charles Keepax
Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows the connection of most Cirrus Logic devices on mini-cards, as well as allowing connection of various application processor systems to provide a full evaluation platform. This driver supports the

[PATCH v5 2/8] mfd: lochnagar: Add initial binding documentation

2018-11-20 Thread Charles Keepax
Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows the connection of most Cirrus Logic devices on mini-cards, as well as allowing connection of various application processor systems to provide a full evaluation platform. This driver supports the

Re: [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page

2018-11-20 Thread Kirill A. Shutemov
On Tue, Nov 20, 2018 at 03:12:07PM +0100, Michal Hocko wrote: > On Tue 20-11-18 17:07:15, Kirill A. Shutemov wrote: > > On Tue, Nov 20, 2018 at 02:43:23PM +0100, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > filemap_map_pages takes a speculative reference to each page in the > > > rang

[PATCH v5 8/8] pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-11-20 Thread Charles Keepax
Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows the connection of most Cirrus Logic devices on mini-cards, as well as allowing connection of various application processor systems to provide a full evaluation platform. This driver supports the

[PATCH v5 6/8] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-11-20 Thread Charles Keepax
Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows the connection of most Cirrus Logic devices on mini-cards, as well as allowing connection of various application processor systems to provide a full evaluation platform. This driver supports the

[PATCH v8] clk: Add (devm_)clk_get_optional() functions

2018-11-20 Thread Phil Edworthy
This adds clk_get_optional() and devm_clk_get_optional() functions to get optional clocks. They behave the same as (devm_)clk_get except where there is no clock producer. In this case, instead of returning -ENOENT, the function returns NULL. This makes error checking simpler and allows clk_prepare_

Re: [PATCH v4 0/2] objtool: read_symbols() fixes

2018-11-20 Thread Josh Poimboeuf
On Tue, Nov 20, 2018 at 09:05:46AM +0100, Artem Savkov wrote: > The series started with 'parent symbol search' patch, but I found another > issue > in read_symbols() while testing the failure-path. > > Artem Savkov (2): > objtool: fix failed cold symbol doublefree > objtool: fix .cold functio

Re: Memory hotplug softlock issue

2018-11-20 Thread Baoquan He
On 11/20/18 at 03:05pm, Michal Hocko wrote: > > Yes, I applied Hugh's patch 8 hours ago, then our QE Ping operated on > > that machine, after many times of hot removing/adding, the endless > > looping during mirgrating is not seen any more. The test result for > > Hugh's patch is positive. I even s

Re: [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page

2018-11-20 Thread Michal Hocko
On Tue 20-11-18 17:07:15, Kirill A. Shutemov wrote: > On Tue, Nov 20, 2018 at 02:43:23PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > filemap_map_pages takes a speculative reference to each page in the > > range before it tries to lock that page. While this is correct it > > also can

[PATCH] RISC-V: add of_node_put()

2018-11-20 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- arch/riscv/kernel/time.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/kernel/time.c b/arch/riscv/kernel/time.c index 1911c8f6b8a6..40470e669a35 100644 --- a/arch/riscv/kernel/time.c +++ b/arch/riscv/kernel

Re: [PATCH 18/25] vtime: Track nice-ness on top of context switch

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:46:02AM +0100, Frederic Weisbecker wrote: > We need to read the nice value of the task running on any CPU, possibly > remotely, in order to correctly support kcpustat on nohz_full. > Unfortunately we can't just read task_nice(tsk) when tsk runs on another > CPU because it

Re: [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page

2018-11-20 Thread Kirill A. Shutemov
On Tue, Nov 20, 2018 at 02:43:23PM +0100, Michal Hocko wrote: > From: Michal Hocko > > filemap_map_pages takes a speculative reference to each page in the > range before it tries to lock that page. While this is correct it > also can influence page migration which will bail out when seeing > an e

Re: Memory hotplug softlock issue

2018-11-20 Thread Michal Hocko
On Tue 20-11-18 21:58:03, Baoquan He wrote: > Hi, > > On 11/20/18 at 02:38pm, Vlastimil Babka wrote: > > On 11/20/18 6:44 AM, Hugh Dickins wrote: > > > [PATCH] mm: put_and_wait_on_page_locked() while page is migrated > > > > > > We have all assumed that it is essential to hold a page reference wh

pcc_cpufreq: high LA

2018-11-20 Thread Ian Kumlien
Hi, We've had this happen a few times now, pcc_cpufreq is loaded and the machine has a LA of 33 with kworkers consuming *all CPU* We have had this happen before, looking at it has been pushed to the leaky-stack^tm in my mind and... 32 cores: processor : 31 vendor_id : GenuineIntel cpu family : 6

Re: [PATCH 15/25] sched/vtime: Introduce vtime_accounting_enabled_cpu()

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:45:59AM +0100, Frederic Weisbecker wrote: > This allows us to check if a remote CPU runs vtime accounting > (ie: is nohz_full). We'll need that to reliably support "nice" > accounting on kcpustat. > > Signed-off-by: Frederic Weisbecker > Cc: Yauheni Kaliuta > Cc: Thoma

[PATCH] ARM: add of_node_put()

2018-11-20 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- arch/arm/kernel/setup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index 375b13f7e780..c20421f0078e 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup

Re: [PATCH 13/25] context_tracking: Introduce context_tracking_enabled_cpu()

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:45:57AM +0100, Frederic Weisbecker wrote: > This allows us to check if a remote CPU runs context tracking > (ie: is nohz_full). We'll need that to reliably support "nice" > accounting on kcpustat. > > Signed-off-by: Frederic Weisbecker > Cc: Yauheni Kaliuta > Cc: Thoma

[PATCH] arm: add missing of_node_put()

2018-11-20 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- arch/arm/kernel/devtree.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c index e3057c1b55b9..9576adf0d15b 100644 --- a/arch/arm/kernel/de

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-20 Thread Sjoerd Simons
On Tue, 2018-11-20 at 14:08 +0100, Ulf Hansson wrote: > + Hal Emmerich > > On 20 November 2018 at 12:38, Sjoerd Simons > wrote: > > On Tue, 2018-11-20 at 11:23 +0100, Wolfram Sang wrote: > > > > > > > > So if you know the pattern, or just happen to hit it often in e.g. > > automated testing, it

Re: [PATCH 09/25] kcpustat: Track running task following vtime sequences

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:45:53AM +0100, Frederic Weisbecker wrote: > In order to make kcpustat vtime aware (ie: work on nohz_full without > freezing), we need to track the task running on the CPU in order to > fetch its vtime delta and add it to the relevant kcpustat field. > > The most efficien

Re: Memory hotplug softlock issue

2018-11-20 Thread Baoquan He
Hi, On 11/20/18 at 02:38pm, Vlastimil Babka wrote: > On 11/20/18 6:44 AM, Hugh Dickins wrote: > > [PATCH] mm: put_and_wait_on_page_locked() while page is migrated > > > > We have all assumed that it is essential to hold a page reference while > > waiting on a page lock: partly to guarantee that t

[PATCH] arm: add missing of_node_put()

2018-11-20 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- arch/arm/kernel/devtree.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c index e3057c1b55b9..9576adf0d15b 100644 --- a/arch/arm/kernel/de

Re: [PATCH 5/7] doc/vm: New documentation for memory cache

2018-11-20 Thread Mike Rapoport
On Wed, Nov 14, 2018 at 03:49:18PM -0700, Keith Busch wrote: > Platforms may provide system memory that contains side caches to help > spped up access. These memory caches are part of a memory node and > the cache attributes are exported by the kernel. > > Add new documentation providing a brief o

Re: [PATCH 1/2] perf vendor events: Add stepping in CPUID string for x86

2018-11-20 Thread Liang, Kan
On 11/15/2018 9:14 PM, Arnaldo Carvalho de Melo wrote: Em Thu, Nov 15, 2018 at 04:01:46PM -0500, Liang, Kan escreveu: On 11/15/2018 3:44 PM, Jiri Olsa wrote: On Wed, Nov 14, 2018 at 01:24:15PM -0800, kan.li...@linux.intel.com wrote: From: Kan Liang Perf tools cannot find the proper even

Re: [PATCH 08/25] vtime: Exit vtime before exit_notify()

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:45:52AM +0100, Frederic Weisbecker wrote: > diff --git a/include/linux/sched.h b/include/linux/sched.h > index d458d65..27e0544 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -265,6 +265,8 @@ struct task_cputime { > enum vtime_state { > /*

Re: [PATCH 3/7] doc/vm: New documentation for memory performance

2018-11-20 Thread Mike Rapoport
Hi, Sorry if I'm jumping too late. On Wed, Nov 14, 2018 at 03:49:16PM -0700, Keith Busch wrote: > Platforms may provide system memory where some physical address ranges > perform differently than others. These heterogeneous memory attributes are > common to the node that provides the memory and e

Re: [PATCH] debugobjects: scale the static pool size

2018-11-20 Thread Waiman Long
On 11/20/2018 01:42 AM, Qian Cai wrote: > The current value of the early boot static pool size is not big enough > for systems with large number of CPUs with timer or/and workqueue > objects selected. As the results, systems have 60+ CPUs with both timer > and workqueue objects enabled could trigge

Can I Trust You?

2018-11-20 Thread Abel Brent
Dear friend, I am Abel Brent, a NATO soldier serving in Afghanistan. I and my Comrades, we are seeking your assistance to help us receive/invest our funds in your country in any lucrative business. Please if this proposal is acceptable by you, kindly respond back to me for more details. Thank

[RFC PATCH 1/3] mm, memory_hotplug: try to migrate full section worth of pages

2018-11-20 Thread Michal Hocko
From: Michal Hocko do_migrate_range has been limiting the number of pages to migrate to 256 for some reason which is not documented. Even if the limit made some sense back then when it was introduced it doesn't really serve a good purpose these days. If the range contains huge pages then we break

Re: Applied "regulator: wm8994: Pass descriptor instead of GPIO number" to the regulator tree

2018-11-20 Thread Marek Szyprowski
Brown This patch causes following kernel warning on Samsung Exynos4412 based Trats2 board: wm8994 4-001a: Failed to get supply 'DBVDD1': -517 wm8994 4-001a: Failed to get supplies: -517 [ cut here ] WARNING: CPU: 0 PID: 1 at drivers/gpio/gpiolib.c:2421 release_

[RFC PATCH 0/3] few memory offlining enhancements

2018-11-20 Thread Michal Hocko
I have been chasing memory offlining not making progress recently. On the way I have noticed few weird decisions in the code. The migration itself is restricted without a reasonable justification and the retry loop around the migration is quite messy. This is addressed by patch 1 and patch 2. Patc

[RFC PATCH 2/3] mm, memory_hotplug: deobfuscate migration part of offlining

2018-11-20 Thread Michal Hocko
From: Michal Hocko Memory migration might fail during offlining and we keep retrying in that case. This is currently obfuscate by goto retry loop. The code is hard to follow and as a result it is even suboptimal becase each retry round scans the full range from start_pfn even though we have succe

[RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page

2018-11-20 Thread Michal Hocko
From: Michal Hocko filemap_map_pages takes a speculative reference to each page in the range before it tries to lock that page. While this is correct it also can influence page migration which will bail out when seeing an elevated reference count. The faultaround code would bail on seeing a locke

Re: [LKP] dd2283f260 [ 97.263072] WARNING:at_kernel/locking/lockdep.c:#lock_downgrade

2018-11-20 Thread Kirill A. Shutemov
On Tue, Nov 20, 2018 at 08:10:51PM +0800, Yang Shi wrote: > > > On 11/20/18 4:57 PM, Kirill A. Shutemov wrote: > > On Fri, Nov 16, 2018 at 08:56:04AM -0800, Yang Shi wrote: > > > > a8dda165ec vfree: add debug might_sleep() > > > > dd2283f260 mm: mmap: zap pages with read mmap_sem in munmap > >

Re: [PATCH v2 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-20 Thread Adrian Hunter
On 12/11/18 9:26 AM, Chunyan Zhang wrote: > Some standard SD host controllers can support both external dma > controllers as well as ADMA/SDMA in which the SD host controller > acts as DMA master. TI's omap controller is the case as an example. > > Currently the generic SDHCI code supports ADMA/SD

[PATCH 3/4] net-next/hinic:fix a bug in set mac address

2018-11-20 Thread Xue Chaojing
In add_mac_addr(), if the MAC address is a muliticast address, it will not be set, which causes the network card fail to receive the multicast packet. This patch fixes this bug. Signed-off-by: Xue Chaojing --- drivers/net/ethernet/huawei/hinic/hinic_main.c | 7 --- 1 file changed, 4 insertio

[PATCH 4/4] net-next/hinic: fix a bug in rx data flow

2018-11-20 Thread Xue Chaojing
In rx_alloc_pkts(), there is a loop call of tasklet, which causes 100% cpu utilization, even no packets are being received. This patch fixes this bug. Signed-off-by: Xue Chaojing --- drivers/net/ethernet/huawei/hinic/hinic_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 1/2] irq/irq_sim: provide irq_sim_fire_edge()

2018-11-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The irq_sim irqchip doesn't allow to configure the sensitivity so every call to irq_sim_fire() fires a dummy interrupt. This used to not matter for gpio-mockup (one of the irq_sim users) until commit fa38869b0161 ("gpiolib: Don't support irq sharing for userspace") which

[PATCH 1/4] net-next/hinic:replace multiply and division operators

2018-11-20 Thread Xue Chaojing
To improve performance, this patch uses bit operations to replace multiply and division operators. Signed-off-by: Xue Chaojing --- .../net/ethernet/huawei/hinic/hinic_hw_wq.c | 55 --- .../net/ethernet/huawei/hinic/hinic_hw_wq.h | 3 +- 2 files changed, 38 insertions(+), 20

[PATCH 2/2] gpio: mockup: use irq_sim_fire_edge()

2018-11-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We now have a specialized variant of irq_sim_fire() - use it in gpio-mockup so that we only generate events of types that were requested with the LINEEVENT ioctl(). Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mockup.c | 5 +++-- 1 file changed, 3 insertio

[PATCH 0/2] irq/irq_sim: provide a specialized variant of irq_sim_fire()

2018-11-20 Thread Bartosz Golaszewski
The interrupts simulator has a limitation in that a call to irq_sim_fire() always fires the dummy interrupt - irrespective of the flags passed to the irq request function. This series addresses a problem with certain libgpiod tests failing when using gpio-mockup with simulated interrupts since com

Backed up kernels

2018-11-20 Thread Jean Delvare
Hi Masahiro, Michal, When I run "make install", if a kernel by the same version number + flavor string already exists, a backup is created with ".old" appended. Over time, this adds many entries to my boot menu, makes some package updates take much longer (e.g. when all initrds must be regenerated

[PATCH] drivers/sbus/char: add of_node_put()

2018-11-20 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/sbus/char/envctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/sbus/char/envctrl.c b/drivers/sbus/char/envctrl.c index 56e962a01493..b8481927bfe4 100644 --- a/drivers/sbus/char/envctrl.c +++ b/dri

Re: Memory hotplug softlock issue

2018-11-20 Thread Vlastimil Babka
On 11/20/18 6:44 AM, Hugh Dickins wrote: > [PATCH] mm: put_and_wait_on_page_locked() while page is migrated > > We have all assumed that it is essential to hold a page reference while > waiting on a page lock: partly to guarantee that there is still a struct > page when MEMORY_HOTREMOVE is configu

Re: BUG: unable to handle kernel NULL pointer dereference in write_port

2018-11-20 Thread Arnd Bergmann
On Tue, Nov 13, 2018 at 9:24 AM Kyungtae Kim wrote: > > We report a bug in v4.19-rc8 (4.20-rc1 as well): > > kernel config: https://kt0755.github.io/etc/config-4.19-rc2.kmsan > repro: https://kt0755.github.io/etc/repro.e3752.c > > This happens during data transition from user-supplied buffer to po

[PATCH] sbus: char: add of_node_put()

2018-11-20 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/sbus/char/display7seg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c index 5c8ed7350a04..a36e4cf1841d 100644 --- a/drivers/sbus/char/display7s

Re: [PATCH] procfd_signal.2: document procfd_signal syscall

2018-11-20 Thread Michael Kerrisk (man-pages)
Hello Christian, On 11/19/18 11:32 AM, Christian Brauner wrote: > Signed-off-by: Christian Brauner > --- > Changelog: > v1: > - patch introduced > --- > man2/procfd_signal.2 | 147 +++ > 1 file changed, 147 insertions(+) > create mode 100644 man2/procfd_s

[PATCH v2 1/3] PCI: dwc: allow to limit registers set length

2018-11-20 Thread Stefan Agner
Add length to the struct dw_pcie and check that the accessors dw_pcie_(rd|wr)_own_conf() do not read/write beyond that point. Signed-off-by: Stefan Agner --- drivers/pci/controller/dwc/pcie-designware-host.c | 4 drivers/pci/controller/dwc/pcie-designware.h | 1 + 2 files changed, 5 in

[PATCH v2 3/3] PCI: imx6: limit DBI register length

2018-11-20 Thread Stefan Agner
Define the length of the DBI registers. This makes sure that the kernel does not access registers beyond that point, avoiding the following abort on a i.MX 6Quad: # cat /sys/devices/soc0/soc/1ffc000.pcie/pci\:00/\:00\:00.0/config [ 100.021433] Unhandled fault: imprecise external abort

[PATCH v2 2/3] PCI: imx6: introduce drvdata

2018-11-20 Thread Stefan Agner
Introduce driver data struct. This will simplify handling of device specific differences. Signed-off-by: Stefan Agner --- Changes in v2: - Split drvdata introduction in a separate patch - Use an array instead of individual struct imx6_pcie_drvdata declarations drivers/pci/controller/dwc/pci-imx

Re: [PATCH 04/25] vtime: Spare a seqcount lock/unlock cycle on context switch

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:45:48AM +0100, Frederic Weisbecker wrote: So I definitely like avoiding that superfluous atomic op, however: > @@ -730,19 +728,25 @@ static void vtime_account_guest(struct task_struct *tsk, > } > } > > +static void __vtime_account_kernel(struct task_struct *tsk

Re: [PATCH] clk: Add (devm_)clk_get_optional() functions

2018-11-20 Thread Andy Shevchenko
On Tue, Nov 20, 2018 at 01:56:52PM +0100, Uwe Kleine-König wrote: > On Tue, Nov 20, 2018 at 12:38:33PM +0200, Andy Shevchenko wrote: > > On Mon, Nov 19, 2018 at 02:12:59PM +, Phil Edworthy wrote: > > > + if (clk == ERR_PTR(-ENOENT)) > > > + return NULL; > > > + else > > > + retu

Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver

2018-11-20 Thread Mark Brown
On Mon, Nov 19, 2018 at 11:10:04PM +0100, Marek Vasut wrote: > On 11/19/2018 04:27 PM, Mark Brown wrote: > > The SPDX header needs to be C++ style so I push people to make the whole > > block C++ otherwise it looks messy. > OK, I'm not gonna wrestle you on this, but I think it looks horrible ;-)

[PATCH] watchdog: cpwd: add of_node_put()

2018-11-20 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/watchdog/cpwd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c index aee0b25cf10d..d3a81642ada5 100644 --- a/drivers/watchdog/cpwd.c +++ b/drivers/watchdog/cpwd

Re: KASAN: use-after-free Read in locks_delete_block

2018-11-20 Thread Dmitry Vyukov
On Tue, Nov 20, 2018 at 12:08 PM, Jeff Layton wrote: > On Tue, 2018-11-20 at 07:57 +0100, Dmitry Vyukov wrote: >> On Sat, Nov 17, 2018 at 3:03 PM, Bruce Fields wrote: >> > On Sat, Nov 17, 2018 at 08:33:27AM -0500, Jeff Layton wrote: >> > > Thanks for the explanation, Dmitry. I've added the tag to

Re: [PATCH 02/25] sched/vtime: Protect idle accounting under vtime seqcount

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 03:45:46AM +0100, Frederic Weisbecker wrote: > Locking the seqcount on idle vtime accounting wasn't thought to be > necessary because the readers of idle cputime don't use vtime (yet). > > Now updating vtime expect the related seqcount to be locked so do it > for locking co

Re: [PATCH v3 1/2] x86/fpu: track AVX-512 usage of tasks

2018-11-20 Thread Li, Aubrey
On 2018/11/18 22:03, Samuel Neves wrote: > On 11/17/18 12:36 AM, Li, Aubrey wrote: >> On 2018/11/17 7:10, Dave Hansen wrote: >>> Just to be clear: there are 3 AVX-512 XSAVE states: >>> >>> XFEATURE_OPMASK, >>> XFEATURE_ZMM_Hi256, >>> XFEATURE_Hi16_ZMM, >>> >>> I honestly

[PATCH] clocksource/drivers/integrator-ap: add of_node_put()

2018-11-20 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/clocksource/timer-integrator-ap.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/clocksource/timer-integrator-ap.c b/drivers/clocksource/timer-integrator-ap.c index 76e526f

Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state

2018-11-20 Thread Vokáč Michal
Hi, sorry for the delay, I was out of office last week. My comments below are just to clarify my attitude to the topic as my name was mentioned few times while I was offline. On 16.11.2018 10:51, Thierry Reding wrote: > On Thu, Nov 15, 2018 at 09:37:33PM +0100, Uwe Kleine-König wrote: >> On Thu, N

RE: [PATCH v9 04/17] tpm: print tpm2_commit_space() error inside tpm2_commit_space()

2018-11-20 Thread Winkler, Tomas
> > On Mon, Nov 19, 2018 at 09:25:22PM +, Winkler, Tomas wrote: > > > > > > > > > > The error logging for tpm2_commit_space() is in a wrong place. This > > > commit moves it inside that function. > > > > > > Cc: James Bottomley > > > Signed-off-by: Jarkko Sakkinen > > > Reviewed-by: Stefa

Re: [PATCH v2] mm: fix swap offset when replacing shmem page

2018-11-20 Thread Matthew Wilcox
On Mon, Nov 19, 2018 at 09:07:27PM -0800, Hugh Dickins wrote: > I don't much like my original use of the name "swap_index", when it was > not the index in a swapfile (though it was the index in the radix tree); > but it will become a correct name with your patch. > > Though Matthew Wilcox seems to

Re: [PATCH 2/2] PCI: imx6: limit DBI register length

2018-11-20 Thread Stefan Agner
On 20.11.2018 14:03, Leonard Crestez wrote: > From: Stefan Agner >> On 20.11.2018 11:22, Leonard Crestez wrote: >> > On Mon, 2018-11-19 at 10:41 +0100, Stefan Agner wrote: >> >> Define the length of the DBI registers. This makes sure that >> >> the kernel does not access registers beyond that poin

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-20 Thread Ulf Hansson
+ Hal Emmerich On 20 November 2018 at 12:38, Sjoerd Simons wrote: > On Tue, 2018-11-20 at 11:23 +0100, Wolfram Sang wrote: >> > > > That also happens to be one of the cards we deploy; However i >> > > > did >> > > > wonder about adding a quirk but decided against it as it was >> > > > not clear >

Re: [PATCH v9 05/17] tpm: declare struct tpm_header

2018-11-20 Thread Jarkko Sakkinen
On Mon, Nov 19, 2018 at 09:33:31PM +, Winkler, Tomas wrote: > > > > > Decleare struct tpm_header that replaces struct tpm_input_header and > Typo Thanks, will fix for the next version. > > struct tpm_output_header. > > > > Signed-off-by: Jarkko Sakkinen > > Reviewed-by: Stefan Berger >

Re: [PATCH] PCI: dwc: layerscape: constify driver data

2018-11-20 Thread Lorenzo Pieralisi
On Mon, Nov 19, 2018 at 11:00:22AM +0100, Stefan Agner wrote: > Constify driver data since they don't get changed at runtime. > > Signed-off-by: Stefan Agner > --- > drivers/pci/controller/dwc/pci-layerscape.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied to pci/dwc

RE: [PATCH 2/2] PCI: imx6: limit DBI register length

2018-11-20 Thread Leonard Crestez
From: Stefan Agner > On 20.11.2018 11:22, Leonard Crestez wrote: > > On Mon, 2018-11-19 at 10:41 +0100, Stefan Agner wrote: > >> Define the length of the DBI registers. This makes sure that > >> the kernel does not access registers beyond that point, avoiding > >> the following abort on a i.MX 6Qu

Re: [PATCH v1 1/1] spi: npcm: fix uninitialized 'val' warning in receive function

2018-11-20 Thread Mark Brown
On Tue, Nov 20, 2018 at 12:51:19PM +0200, Tomer Maimon wrote: > We just tried to reduce the number of lines to minimum, so we have debug it > quite a lot (with all the numbers that can > get from priv->tx_bytes) and the only numbers that minimum function return > are 0, 1 or 2. > But in the end o

uprobe support mix of ftrace and perf

2018-11-20 Thread Masami Hiramatsu
Hello Oleg, I have a question about the (revert) commit 48212542067a ("tracing/uprobes: Revert "Support mix of ftrace and perf""). I found this limitation still exists on uprobe events. Would you have any plan or idea to fix this issue? I thought this revert patch was a tentative one, and shoul

[PATCH] cpuidle: big.LITTLE: add of_node_put()

2018-11-20 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/cpuidle/cpuidle-big_little.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c index db2ede565f1a..a3b8bc09bac8

Re: [PATCH 2/4] mmc: sdhci-omap: Add variable to indicate host is tuning

2018-11-20 Thread Faiz Abbas
Hi Uffe, On 19/11/18 6:48 PM, Ulf Hansson wrote: > On 19 November 2018 at 12:16, Faiz Abbas wrote: >> Add a variable in sdhc_omap_host to indicate whether a tuning >> operation is ongoing. >> >> Signed-off-by: Faiz Abbas > > Please squash this into patch3 as it seems a bit silly to keep this a

Re: [PATCH 0/4] dts/layerscape-pci: removed unsuitable compatible string

2018-11-20 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 11:14:24AM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > Removed the compatible string "snps,dw-pcie" from FSL layerscape-pci > compatible > string list. > > Hou Zhiqiang (4): > doc/layerscape-pci: update the PCIe compatible strings > doc/layerscape-pci: remove

Re: [PATCH v3 03/10] sched/topology: Provide cfs_overload_cpus bitmap

2018-11-20 Thread Valentin Schneider
On 19/11/2018 17:32, Steven Sistare wrote: > On 11/9/2018 12:38 PM, Valentin Schneider wrote: >> Hi Steve, >> >> On 09/11/2018 12:50, Steve Sistare wrote: >> [...] >>> @@ -482,6 +484,10 @@ static void update_top_cache_domain(int cpu) >>> dirty_sched_domain_sysctl(cpu); >>> destroy_sched_

Re: [PATCH] regulator: s2mps11: Fix GPIO descriptor initialization

2018-11-20 Thread Krzysztof Kozlowski
On Tue, 20 Nov 2018 at 13:39, Marek Szyprowski wrote: > > GPIO descriptor array must be zero initialized to ensure that core will > properly handle also the case when no external GPIO pin is defined. > > Fixes: 1c984942f0a4 ("regulator: s2mps11: Pass descriptor instead of GPIO > number") > Signed

Re: [PATCH] perf/x86: Bump INTEL_PMC_MAX_FIXED for Icelake

2018-11-20 Thread Peter Zijlstra
On Wed, Nov 14, 2018 at 02:25:18PM +, Chris Wilson wrote: > I am not aware of what the consequences are of bumping this limit, so > please take the patch with a pinch of salt and more of a heads up! Yeah, this will only make your warning go away, but is not suitable for upstream. The upstream

Re: [PATCH v9 04/17] tpm: print tpm2_commit_space() error inside tpm2_commit_space()

2018-11-20 Thread Jarkko Sakkinen
On Mon, Nov 19, 2018 at 09:25:22PM +, Winkler, Tomas wrote: > > > > > > The error logging for tpm2_commit_space() is in a wrong place. This commit > > moves it inside that function. > > > > Cc: James Bottomley > > Signed-off-by: Jarkko Sakkinen > > Reviewed-by: Stefan Berger > > --- > >

Re: [PATCH v5] tpm: add support for partial reads

2018-11-20 Thread Jarkko Sakkinen
On Mon, Nov 19, 2018 at 10:55:15AM -0800, Tadeusz Struk wrote: > Currently to read a response from the TPM device an application needs > provide big enough buffer for the whole response and read it in one go. > The application doesn't know how big the response it beforehand so it > always needs to

Re: [PATCH cgroup/for-4.21 2/2] cgroup: Add .__DEBUG__. prefix to debug file names

2018-11-20 Thread Peter Zijlstra
On Tue, Nov 13, 2018 at 12:16:37PM -0800, Tejun Heo wrote: > From c1bbd933e5fae83f96acd3f748bb01a0300b315d Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Tue, 13 Nov 2018 12:06:41 -0800 > > Clearly mark the debug files and hide them by default by prefixing > ".__DEBUG__.". ACK

Re: [PATCH cgroup/for-4.21 1/2] cpuset: Minor cgroup2 interface updates

2018-11-20 Thread Peter Zijlstra
On Tue, Nov 13, 2018 at 12:13:39PM -0800, Tejun Heo wrote: > From b1e3aeb11c5e86ee0988a038c4e7682d6beaa977 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Tue, 13 Nov 2018 12:03:33 -0800 > > * Rename the partition file from "cpuset.sched.partition" to > "cpuset.cpus.partition". > > * When w

Re: [PATCH v5 00/10] x86/alternative: text_poke() fixes

2018-11-20 Thread Peter Zijlstra
On Tue, Nov 13, 2018 at 05:07:20AM -0800, Nadav Amit wrote: > v4->v5: > - Fix Xen breakage [Damian Tometzki] > - BUG_ON() when poking_mm initialization fails [PeterZ] > - Better comments on "x86/mm: temporary mm struct" > - Cleaner removal of the custom poker I'll re-iterate my position: it is imp

Re: [PATCH v3 03/10] sched/topology: Provide cfs_overload_cpus bitmap

2018-11-20 Thread Valentin Schneider
On 19/11/2018 17:33, Steven Sistare wrote: [...] >> >> Thinking about misfit stealing, we can't use the sd_llc_shared's because >> on big.LITTLE misfit migrations happen across LLC domains. >> >> I was thinking of adding a misfit sparsemask to the root_domain, but >> then I thought we could do the

[PATCH] regulator: s2mps11: Fix GPIO descriptor initialization

2018-11-20 Thread Marek Szyprowski
GPIO descriptor array must be zero initialized to ensure that core will properly handle also the case when no external GPIO pin is defined. Fixes: 1c984942f0a4 ("regulator: s2mps11: Pass descriptor instead of GPIO number") Signed-off-by: Marek Szyprowski --- This fixes broken eMMC boot on Artik,

Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-11-20 Thread Miquel Raynal
Hi Naga, Boris Brezillon wrote on Tue, 20 Nov 2018 12:02:44 +0100: > On Tue, 20 Nov 2018 07:02:08 + > Naga Sureshkumar Relli wrote: > > > > > > > > Can you please run nandbiterrs (availaible in mtd-utils). I fear your > > > device won't pass the test. > > Yes, nandbiterror test is pa

[PATCH 2/5] ARM: davinci: dm646x: set the GPIO base to 0

2018-11-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Commit 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic base selection") broke the GPIO support on DaVinci boards in legacy mode by allowing gpiolib to set the GPIO base automatically. DaVinci board files use the legacy GPIO API with hard-coded GPIO li

[PATCH 4/5] ARM: davinci: da830: set the GPIO base to 0

2018-11-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Commit 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic base selection") broke the GPIO support on DaVinci boards in legacy mode by allowing gpiolib to set the GPIO base automatically. DaVinci board files use the legacy GPIO API with hard-coded GPIO li

<    1   2   3   4   5   6   7   8   9   >