Re: [PATCH v1 3/3] arm64: dts: qcom: sdm845: Add SD nodes for sdm845-mtp

2018-12-05 Thread Evan Green
On Wed, Dec 5, 2018 at 1:19 PM Doug Anderson wrote: > > Hi, > > On Wed, Nov 28, 2018 at 2:34 PM Evan Green wrote: > > +_2 { > > + status = "okay"; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <_clk _cmd _data _cd_odl>; > > + > > + vmmc-supply = <_l21a_2p95>; >

Re: [PATCH v1 3/3] arm64: dts: qcom: sdm845: Add SD nodes for sdm845-mtp

2018-12-05 Thread Evan Green
On Wed, Dec 5, 2018 at 1:19 PM Doug Anderson wrote: > > Hi, > > On Wed, Nov 28, 2018 at 2:34 PM Evan Green wrote: > > +_2 { > > + status = "okay"; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <_clk _cmd _data _cd_odl>; > > + > > + vmmc-supply = <_l21a_2p95>; >

Re: [PATCH] binder: implement binderfs

2018-12-05 Thread Christian Brauner
On Wed, Dec 05, 2018 at 09:01:45PM +0100, Greg KH wrote: > On Tue, Dec 04, 2018 at 02:12:39PM +0100, Christian Brauner wrote: > > As discussed at Linux Plumbers Conference 2018 in Vancouver [1] this is the > > implementation of binderfs. If you want to skip reading and just see how it > > works,

Re: [PATCH] binder: implement binderfs

2018-12-05 Thread Christian Brauner
On Wed, Dec 05, 2018 at 09:01:45PM +0100, Greg KH wrote: > On Tue, Dec 04, 2018 at 02:12:39PM +0100, Christian Brauner wrote: > > As discussed at Linux Plumbers Conference 2018 in Vancouver [1] this is the > > implementation of binderfs. If you want to skip reading and just see how it > > works,

Re: [PATCH 4.19 044/110] drm/i915: Disable LP3 watermarks on all SNB machines

2018-12-05 Thread Ville Syrjälä
On Thu, Nov 29, 2018 at 03:12:15PM +0100, Greg Kroah-Hartman wrote: > 4.19-stable review patch. If anyone has any objections, please let me know. This one apparently introduces some annoying dmesg errors: [3.487895] [drm:intel_print_wm_latency [i915]] *ERROR* Primary WM3 latency not

Re: [PATCH 4.19 044/110] drm/i915: Disable LP3 watermarks on all SNB machines

2018-12-05 Thread Ville Syrjälä
On Thu, Nov 29, 2018 at 03:12:15PM +0100, Greg Kroah-Hartman wrote: > 4.19-stable review patch. If anyone has any objections, please let me know. This one apparently introduces some annoying dmesg errors: [3.487895] [drm:intel_print_wm_latency [i915]] *ERROR* Primary WM3 latency not

Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-05 Thread Peter Korsgaard
> "Peter" == Peter Korsgaard writes: > This reverts commit 712ff25450bd01366301eef81c33e865d901e7b7. > The output of dmi_save_uuid() is exposed to user space as > /sys/devices/virtual/dmi/id/*_uuid, so this breaks backwards compatibility, > E.G. I have systems that include the content

Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-05 Thread Peter Korsgaard
> "Peter" == Peter Korsgaard writes: > This reverts commit 712ff25450bd01366301eef81c33e865d901e7b7. > The output of dmi_save_uuid() is exposed to user space as > /sys/devices/virtual/dmi/id/*_uuid, so this breaks backwards compatibility, > E.G. I have systems that include the content

Re: [PATCH v2 2/5] genirq: Export irq_chip_set_wake_parent()

2018-12-05 Thread Linus Walleij
On Thu, Nov 29, 2018 at 6:03 PM Thierry Reding wrote: > From: Thierry Reding > > Interrupt controllers in a hierarchy want to use this function to > propogate ->irq_set_wake() operations to their parent domains. > > Signed-off-by: Thierry Reding Tglx/Marc: is this change OK? (ACK?) Yours,

Re: [PATCH v2 2/5] genirq: Export irq_chip_set_wake_parent()

2018-12-05 Thread Linus Walleij
On Thu, Nov 29, 2018 at 6:03 PM Thierry Reding wrote: > From: Thierry Reding > > Interrupt controllers in a hierarchy want to use this function to > propogate ->irq_set_wake() operations to their parent domains. > > Signed-off-by: Thierry Reding Tglx/Marc: is this change OK? (ACK?) Yours,

Re: [PATCH] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading

2018-12-05 Thread Paweł Chmiel
Dnia środa, 5 grudnia 2018 22:02:30 CET Marcel Holtmann pisze: > Hi Pawel, > > > The Broadcom controller on aries S5PV210 boards sends out a couple of > > unknown packets after the firmware is loaded. This will cause > > logging of errors such as: > > Bluetooth: hci0: Frame reassembly failed

Re: [PATCH] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading

2018-12-05 Thread Paweł Chmiel
Dnia środa, 5 grudnia 2018 22:02:30 CET Marcel Holtmann pisze: > Hi Pawel, > > > The Broadcom controller on aries S5PV210 boards sends out a couple of > > unknown packets after the firmware is loaded. This will cause > > logging of errors such as: > > Bluetooth: hci0: Frame reassembly failed

Re: [PATCH v2 1/6] powerpc: prefer memblock APIs returning virtual address

2018-12-05 Thread Mike Rapoport
On Wed, Dec 05, 2018 at 11:37:44PM +1100, Michael Ellerman wrote: > Mike Rapoport writes: > > On Tue, Dec 04, 2018 at 08:59:41PM +1100, Michael Ellerman wrote: > >> Hi Mike, > >> > >> Thanks for trying to clean these up. > >> > >> I think a few could be improved though ... > >> > >> Mike

Re: [PATCH v2 1/6] powerpc: prefer memblock APIs returning virtual address

2018-12-05 Thread Mike Rapoport
On Wed, Dec 05, 2018 at 11:37:44PM +1100, Michael Ellerman wrote: > Mike Rapoport writes: > > On Tue, Dec 04, 2018 at 08:59:41PM +1100, Michael Ellerman wrote: > >> Hi Mike, > >> > >> Thanks for trying to clean these up. > >> > >> I think a few could be improved though ... > >> > >> Mike

[PATCH v2] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading

2018-12-05 Thread Paweł Chmiel
From: Jonathan Bakker The Broadcom controller on aries S5PV210 boards sends out a couple of unknown packets after the firmware is loaded. This will cause logging of errors such as: Bluetooth: hci0: Frame reassembly failed (-84) This is probably also the case with other boards, as there

[PATCH v2] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading

2018-12-05 Thread Paweł Chmiel
From: Jonathan Bakker The Broadcom controller on aries S5PV210 boards sends out a couple of unknown packets after the firmware is loaded. This will cause logging of errors such as: Bluetooth: hci0: Frame reassembly failed (-84) This is probably also the case with other boards, as there

Re: [PATCH v1 3/3] arm64: dts: qcom: sdm845: Add SD nodes for sdm845-mtp

2018-12-05 Thread Doug Anderson
Hi, On Wed, Nov 28, 2018 at 2:34 PM Evan Green wrote: > +_2 { > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <_clk _cmd _data _cd_odl>; > + > + vmmc-supply = <_l21a_2p95>; > + vqmmc-supply = <_2>; > + > + cd-gpios = < 126

Re: [PATCH v1 3/3] arm64: dts: qcom: sdm845: Add SD nodes for sdm845-mtp

2018-12-05 Thread Doug Anderson
Hi, On Wed, Nov 28, 2018 at 2:34 PM Evan Green wrote: > +_2 { > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <_clk _cmd _data _cd_odl>; > + > + vmmc-supply = <_l21a_2p95>; > + vqmmc-supply = <_2>; > + > + cd-gpios = < 126

[PATCH v2] binder: fix use-after-free due to fdget() optimization

2018-12-05 Thread Todd Kjos
44d8047f1d87a ("binder: use standard functions to allocate fds") exposed a pre-existing issue in the binder driver. fdget() is used in ksys_ioctl() as a performance optimization. One of the rules associated with fdget() is that ksys_close() must not be called between the fdget() and the fdput().

[PATCH v2] binder: fix use-after-free due to fdget() optimization

2018-12-05 Thread Todd Kjos
44d8047f1d87a ("binder: use standard functions to allocate fds") exposed a pre-existing issue in the binder driver. fdget() is used in ksys_ioctl() as a performance optimization. One of the rules associated with fdget() is that ksys_close() must not be called between the fdget() and the fdput().

Re: [patch 0/2 for-4.20] mm, thp: fix remote access and allocation regressions

2018-12-05 Thread David Rientjes
On Wed, 5 Dec 2018, Michal Hocko wrote: > > As we've been over countless times, this is the desired effect for > > workloads that fit on a single node. We want local pages of the native > > page size because they (1) are accessed faster than remote hugepages and > > (2) are candidates for

Re: [patch 0/2 for-4.20] mm, thp: fix remote access and allocation regressions

2018-12-05 Thread David Rientjes
On Wed, 5 Dec 2018, Michal Hocko wrote: > > As we've been over countless times, this is the desired effect for > > workloads that fit on a single node. We want local pages of the native > > page size because they (1) are accessed faster than remote hugepages and > > (2) are candidates for

[PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-05 Thread Peter Korsgaard
This reverts commit 712ff25450bd01366301eef81c33e865d901e7b7. The output of dmi_save_uuid() is exposed to user space as /sys/devices/virtual/dmi/id/*_uuid, so this breaks backwards compatibility, E.G. I have systems that include the content of dmi/id/product_uuid as part of the keyphrase for

[PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-05 Thread Peter Korsgaard
This reverts commit 712ff25450bd01366301eef81c33e865d901e7b7. The output of dmi_save_uuid() is exposed to user space as /sys/devices/virtual/dmi/id/*_uuid, so this breaks backwards compatibility, E.G. I have systems that include the content of dmi/id/product_uuid as part of the keyphrase for

Re: [PATCH 1/2] staging: greybus: Align function call parameters to parenthesis

2018-12-05 Thread Sicilia Cristian
On Wed, Dec 05, 2018 at 09:46:03AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 04, 2018 at 09:58:14PM +0100, Cristian Sicilia wrote: > > Aligned some parameters to the previous parenthesis. > > > > Signed-off-by: Cristian Sicilia > > --- > > drivers/staging/greybus/loopback.c | 10 ++

Re: [PATCH 1/2] staging: greybus: Align function call parameters to parenthesis

2018-12-05 Thread Sicilia Cristian
On Wed, Dec 05, 2018 at 09:46:03AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 04, 2018 at 09:58:14PM +0100, Cristian Sicilia wrote: > > Aligned some parameters to the previous parenthesis. > > > > Signed-off-by: Cristian Sicilia > > --- > > drivers/staging/greybus/loopback.c | 10 ++

Re: [PATCH] staging: mt7621-mmc: Remove missed lines of the #if 0 block in sd.c

2018-12-05 Thread NeilBrown
On Wed, Dec 05 2018, Nishad Kamdar wrote: > The below patch > https://lore.kernel.org/patchwork/patch/995533/ > does not completely remove an #if 0 block in sd.c. Standard practice is to identify patches by their commit id. In this case you could git log --oneline

Re: [PATCH] staging: mt7621-mmc: Remove missed lines of the #if 0 block in sd.c

2018-12-05 Thread NeilBrown
On Wed, Dec 05 2018, Nishad Kamdar wrote: > The below patch > https://lore.kernel.org/patchwork/patch/995533/ > does not completely remove an #if 0 block in sd.c. Standard practice is to identify patches by their commit id. In this case you could git log --oneline

Re: [PATCH v2 2/4] dmaengine: mtk_uart_dma: add Mediatek uart DMA support

2018-12-05 Thread Sean Wang
. On Wed, Dec 5, 2018 at 1:31 AM Long Cheng wrote: > > In DMA engine framework, add 8250 mtk dma to support it. > > Signed-off-by: Long Cheng > --- > drivers/dma/mediatek/8250_mtk_dma.c | 894 > +++ > drivers/dma/mediatek/Kconfig| 11 + >

Re: [PATCH v2 2/4] dmaengine: mtk_uart_dma: add Mediatek uart DMA support

2018-12-05 Thread Sean Wang
. On Wed, Dec 5, 2018 at 1:31 AM Long Cheng wrote: > > In DMA engine framework, add 8250 mtk dma to support it. > > Signed-off-by: Long Cheng > --- > drivers/dma/mediatek/8250_mtk_dma.c | 894 > +++ > drivers/dma/mediatek/Kconfig| 11 + >

Re: [PATCH v1 2/3] arm64: dts: qcom: sdm845: Add SD nodes

2018-12-05 Thread Doug Anderson
Hi, On Wed, Nov 28, 2018 at 2:34 PM Evan Green wrote: > > Add the SD controller to SDM845. > > Signed-off-by: Evan Green > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 15 +++ > 1 file changed, 15 insertions(+) Looks right to me. Possibly you might want to make it known in the

Re: [PATCH v1 2/3] arm64: dts: qcom: sdm845: Add SD nodes

2018-12-05 Thread Doug Anderson
Hi, On Wed, Nov 28, 2018 at 2:34 PM Evan Green wrote: > > Add the SD controller to SDM845. > > Signed-off-by: Evan Green > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 15 +++ > 1 file changed, 15 insertions(+) Looks right to me. Possibly you might want to make it known in the

Re: [PATCH v2 01/17] power: supply: olpc_battery: correct the temperature units

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:23:47PM +0100, Lubomir Rintel wrote: > According to [1] and [2], the temperature values are in tenths of degree > Celsius. Exposing the Celsius value makes the battery appear on fire: > > $ upower -i /org/freedesktop/UPower/devices/battery_olpc_battery > ... >

Re: [PATCH v2 01/17] power: supply: olpc_battery: correct the temperature units

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:23:47PM +0100, Lubomir Rintel wrote: > According to [1] and [2], the temperature values are in tenths of degree > Celsius. Exposing the Celsius value makes the battery appear on fire: > > $ upower -i /org/freedesktop/UPower/devices/battery_olpc_battery > ... >

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Ard Biesheuvel
On Wed, 5 Dec 2018 at 20:45, Nathan Chancellor wrote: > > On Wed, Dec 05, 2018 at 07:39:55PM +0100, Ard Biesheuvel wrote: > > On Wed, 5 Dec 2018 at 19:36, Nathan Chancellor > > wrote: > > > > > > On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > > > > (+ Arnd) > > > > > > > > On

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Ard Biesheuvel
On Wed, 5 Dec 2018 at 20:45, Nathan Chancellor wrote: > > On Wed, Dec 05, 2018 at 07:39:55PM +0100, Ard Biesheuvel wrote: > > On Wed, 5 Dec 2018 at 19:36, Nathan Chancellor > > wrote: > > > > > > On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > > > > (+ Arnd) > > > > > > > > On

Re: [PATCH] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading

2018-12-05 Thread Marcel Holtmann
Hi Pawel, > The Broadcom controller on aries S5PV210 boards sends out a couple of > unknown packets after the firmware is loaded. This will cause > logging of errors such as: > Bluetooth: hci0: Frame reassembly failed (-84) > > This is probably also the case with other boards, as there

Re: [PATCH] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading

2018-12-05 Thread Marcel Holtmann
Hi Pawel, > The Broadcom controller on aries S5PV210 boards sends out a couple of > unknown packets after the firmware is loaded. This will cause > logging of errors such as: > Bluetooth: hci0: Frame reassembly failed (-84) > > This is probably also the case with other boards, as there

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-05 Thread Sicilia Cristian
On Wed, Dec 05, 2018 at 10:12:24AM +, Bryan O'Donoghue wrote: > On 04/12/2018 20:58, Cristian Sicilia wrote: > >Some concatenated strings are now spaced. > > > >Signed-off-by: Cristian Sicilia > >--- > > drivers/staging/greybus/loopback.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-05 Thread Sicilia Cristian
On Wed, Dec 05, 2018 at 10:12:24AM +, Bryan O'Donoghue wrote: > On 04/12/2018 20:58, Cristian Sicilia wrote: > >Some concatenated strings are now spaced. > > > >Signed-off-by: Cristian Sicilia > >--- > > drivers/staging/greybus/loopback.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3

Re: [PATCH v2 16/17] power: supply: olpc_battery: Avoid using platform_info

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:24:02PM +0100, Lubomir Rintel wrote: > This wouldn't work on the DT-based ARM platform. Let's read the EC version > directly from the EC driver instead. > > This makes the driver no longer x86 specific. > > Signed-off-by: Lubomir Rintel > Acked-by: Pavel Machek

Re: [PATCH v2 16/17] power: supply: olpc_battery: Avoid using platform_info

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:24:02PM +0100, Lubomir Rintel wrote: > This wouldn't work on the DT-based ARM platform. Let's read the EC version > directly from the EC driver instead. > > This makes the driver no longer x86 specific. > > Signed-off-by: Lubomir Rintel > Acked-by: Pavel Machek

Re: [PATCH v2 15/17] power: supply: olpc_battery: Use devm_power_supply_register()

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:24:01PM +0100, Lubomir Rintel wrote: > This simplifies the error handling. > > Signed-off-by: Lubomir Rintel > > --- Reviewed-by: Sebastian Reichel -- Sebastian > Changes since v1: > - This was split off the "power: supply: olpc_battery: Move priv data to >

Re: [PATCH v2 15/17] power: supply: olpc_battery: Use devm_power_supply_register()

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:24:01PM +0100, Lubomir Rintel wrote: > This simplifies the error handling. > > Signed-off-by: Lubomir Rintel > > --- Reviewed-by: Sebastian Reichel -- Sebastian > Changes since v1: > - This was split off the "power: supply: olpc_battery: Move priv data to >

Re: [PATCH v2 14/17] power: supply: olpc_battery: Move priv data to a struct

2018-12-05 Thread Sebastian Reichel
On Fri, Nov 16, 2018 at 05:24:00PM +0100, Lubomir Rintel wrote: > The global variables for private data are not too nice. I'd like some > more, and that would clutter the global name space even further. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Andy Shevchenko > > --- > Changes since

Re: [PATCH v2 14/17] power: supply: olpc_battery: Move priv data to a struct

2018-12-05 Thread Sebastian Reichel
On Fri, Nov 16, 2018 at 05:24:00PM +0100, Lubomir Rintel wrote: > The global variables for private data are not too nice. I'd like some > more, and that would clutter the global name space even further. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Andy Shevchenko > > --- > Changes since

Re: [PATCH v2 13/17] power: supply: olpc_battery: Use DT to get battery version

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:23:59PM +0100, Lubomir Rintel wrote: > Avoid using the x86 OLPC platform specific call to get the board > version. It won't work on FDT-based ARM MMP2 platform. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Andy Shevchenko > Acked-by: Pavel Machek > > ---

Re: [PATCH v2 13/17] power: supply: olpc_battery: Use DT to get battery version

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:23:59PM +0100, Lubomir Rintel wrote: > Avoid using the x86 OLPC platform specific call to get the board > version. It won't work on FDT-based ARM MMP2 platform. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Andy Shevchenko > Acked-by: Pavel Machek > > ---

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Christian Brauner
On Wed, Dec 05, 2018 at 12:20:43PM -0600, Eric W. Biederman wrote: > Christian Brauner writes: > > > The kill() syscall operates on process identifiers (pid). After a process > > has exited its pid can be reused by another process. If a caller sends a > > signal to a reused pid it will end up

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Christian Brauner
On Wed, Dec 05, 2018 at 12:20:43PM -0600, Eric W. Biederman wrote: > Christian Brauner writes: > > > The kill() syscall operates on process identifiers (pid). After a process > > has exited its pid can be reused by another process. If a caller sends a > > signal to a reused pid it will end up

Re: [PATCH v2 11/17] dt-bindings: olpc_battery: Add XO-1.5 battery

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:23:57PM +0100, Lubomir Rintel wrote: > The XO-1 and XO-1.5 batteries apparently differ in an ability to report > ambient temperature. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Rob Herring > Acked-by: Pavel Machek > > --- Reviewed-by: Sebastian Reichel

Re: [PATCH v2 11/17] dt-bindings: olpc_battery: Add XO-1.5 battery

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 05:23:57PM +0100, Lubomir Rintel wrote: > The XO-1 and XO-1.5 batteries apparently differ in an ability to report > ambient temperature. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Rob Herring > Acked-by: Pavel Machek > > --- Reviewed-by: Sebastian Reichel

Re: [PATCH v10 0/8] Introduce on-chip interconnect API

2018-12-05 Thread Evan Green
On Tue, Nov 27, 2018 at 10:03 AM Georgi Djakov wrote: > > Modern SoCs have multiple processors and various dedicated cores (video, gpu, > graphics, modem). These cores are talking to each other and can generate a > lot of data flowing through the on-chip interconnects. These interconnect > buses

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-05 Thread Joe Lawrence
On 11/29/2018 04:44 AM, Petr Mladek wrote: > Hi, > > I have an updated present for your mailboxes. > > The atomic replace allows to create cumulative patches. They > are useful when you maintain many livepatches and want to remove > one that is lower on the stack. In addition it is very useful

Re: [PATCH v10 0/8] Introduce on-chip interconnect API

2018-12-05 Thread Evan Green
On Tue, Nov 27, 2018 at 10:03 AM Georgi Djakov wrote: > > Modern SoCs have multiple processors and various dedicated cores (video, gpu, > graphics, modem). These cores are talking to each other and can generate a > lot of data flowing through the on-chip interconnects. These interconnect > buses

Re: [PATCH v14 00/11] livepatch: Atomic replace feature

2018-12-05 Thread Joe Lawrence
On 11/29/2018 04:44 AM, Petr Mladek wrote: > Hi, > > I have an updated present for your mailboxes. > > The atomic replace allows to create cumulative patches. They > are useful when you maintain many livepatches and want to remove > one that is lower on the stack. In addition it is very useful

Re: [PATCH v5 4/8] soc: qcom: rpmpd: Add support for get/set performance state

2018-12-05 Thread Stephen Boyd
Quoting Rajendra Nayak (2018-12-05 02:11:22) > > On 12/5/2018 12:33 PM, Rajendra Nayak wrote: > >> > >>> +   return 0; > >>> +   } > >>> + > >>> +   of_node_put(np); > >> > >> This same code exists twice. Perhaps a helper needs to exist for > >> qcom_rpm_get_performance() to 

Re: [PATCH v5 4/8] soc: qcom: rpmpd: Add support for get/set performance state

2018-12-05 Thread Stephen Boyd
Quoting Rajendra Nayak (2018-12-05 02:11:22) > > On 12/5/2018 12:33 PM, Rajendra Nayak wrote: > >> > >>> +   return 0; > >>> +   } > >>> + > >>> +   of_node_put(np); > >> > >> This same code exists twice. Perhaps a helper needs to exist for > >> qcom_rpm_get_performance() to 

Re: [PATCH 1/1] regmap: irq: handle HW using separate mask bits for edges

2018-12-05 Thread Bartosz Golaszewski
śr., 5 gru 2018 o 16:35 Mark Brown napisał(a): > > On Tue, Dec 04, 2018 at 07:15:50PM +0100, Bartosz Golaszewski wrote: > > > Let's reuse the existing type fields in struct regmap_irq to make > > regmap_irq_chip available to such HW. > > I'm not sure this is ideal, it makes the interface less

Re: [PATCH 1/1] regmap: irq: handle HW using separate mask bits for edges

2018-12-05 Thread Bartosz Golaszewski
śr., 5 gru 2018 o 16:35 Mark Brown napisał(a): > > On Tue, Dec 04, 2018 at 07:15:50PM +0100, Bartosz Golaszewski wrote: > > > Let's reuse the existing type fields in struct regmap_irq to make > > regmap_irq_chip available to such HW. > > I'm not sure this is ideal, it makes the interface less

Re: [PATCH 1/2] selftests: firmware: remove use of non-standard diff -Z option

2018-12-05 Thread Dan Rue
On Thu, Nov 29, 2018 at 06:37:32PM -0800, Luis Chamberlain wrote: > On Mon, Nov 26, 2018 at 09:12:15PM -0600, Dan Rue wrote: > > diff -Z is used to trim the trailing whitespace when comparing the > > loaded firmware file with the source firmware file. However, per the > > comment in the source

Re: [PATCH 1/2] selftests: firmware: remove use of non-standard diff -Z option

2018-12-05 Thread Dan Rue
On Thu, Nov 29, 2018 at 06:37:32PM -0800, Luis Chamberlain wrote: > On Mon, Nov 26, 2018 at 09:12:15PM -0600, Dan Rue wrote: > > diff -Z is used to trim the trailing whitespace when comparing the > > loaded firmware file with the source firmware file. However, per the > > comment in the source

Re: [PATCH v1 1/1] clk: npcm: get fixed input clks from DT

2018-12-05 Thread Stephen Boyd
Quoting Tali Perry (2018-12-05 11:47:02) > --- No commit text? No Signed-off-by? Sorry, I don't understand what this patch is for or what's going on. > drivers/clk/clk-npcm7xx.c | 64 > +++ > 1 file changed, 53 insertions(+), 11 deletions(-) > >

Re: [PATCH v1 1/1] clk: npcm: get fixed input clks from DT

2018-12-05 Thread Stephen Boyd
Quoting Tali Perry (2018-12-05 11:47:02) > --- No commit text? No Signed-off-by? Sorry, I don't understand what this patch is for or what's going on. > drivers/clk/clk-npcm7xx.c | 64 > +++ > 1 file changed, 53 insertions(+), 11 deletions(-) > >

Re: [PATCH 3/6] power: supply: charger-manager: Fix incorrect return value

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 07:01:10PM +0800, Baolin Wang wrote: > Fix incorrect return value. > > Signed-off-by: Baolin Wang > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [PATCH 3/6] power: supply: charger-manager: Fix incorrect return value

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 07:01:10PM +0800, Baolin Wang wrote: > Fix incorrect return value. > > Signed-off-by: Baolin Wang > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

[PATCH] Bluetooth: btbcm: Add entry for BCM4329B1 UART bluetooth

2018-12-05 Thread Paweł Chmiel
This patch adds the device ID for the BCM 4329 combo module used in the Samsung Aries based phones (Galaxy S and it's variants). ``` [ 11.508980] Bluetooth: hci0: BCM: chip id 41 [ 11.518975] Bluetooth: hci0: BCM: features 0x04 [ 11.550132] Bluetooth: hci0: BCM4329B1 [ 11.557046]

[PATCH] Bluetooth: btbcm: Add entry for BCM4329B1 UART bluetooth

2018-12-05 Thread Paweł Chmiel
This patch adds the device ID for the BCM 4329 combo module used in the Samsung Aries based phones (Galaxy S and it's variants). ``` [ 11.508980] Bluetooth: hci0: BCM: chip id 41 [ 11.518975] Bluetooth: hci0: BCM: features 0x04 [ 11.550132] Bluetooth: hci0: BCM4329B1 [ 11.557046]

Re: [LKP] [mm] ac5b2c1891: vm-scalability.throughput -61.3% regression

2018-12-05 Thread Andrea Arcangeli
Hello, Sorry, it has been challenging to keep up with all fast replies, so I'll start by answering to the critical result below: On Tue, Dec 04, 2018 at 10:45:58AM +, Mel Gorman wrote: > thpscale Percentage Faults Huge >4.20.0-rc4 4.20.0-rc4 >

Re: [LKP] [mm] ac5b2c1891: vm-scalability.throughput -61.3% regression

2018-12-05 Thread Andrea Arcangeli
Hello, Sorry, it has been challenging to keep up with all fast replies, so I'll start by answering to the critical result below: On Tue, Dec 04, 2018 at 10:45:58AM +, Mel Gorman wrote: > thpscale Percentage Faults Huge >4.20.0-rc4 4.20.0-rc4 >

Re: [PATCH 4/6] power: supply: charger-manager: Make code more readable

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 07:01:11PM +0800, Baolin Wang wrote: > Make code more readable. > > Signed-off-by: Baolin Wang > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH 4/6] power: supply: charger-manager: Make code more readable

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 07:01:11PM +0800, Baolin Wang wrote: > Make code more readable. > > Signed-off-by: Baolin Wang > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH 2/6] power: supply: charger-manager: Fix some misspelled words

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 07:01:09PM +0800, Baolin Wang wrote: > Fix some misspelled words. > > Signed-off-by: Baolin Wang > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH 2/6] power: supply: charger-manager: Fix some misspelled words

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 07:01:09PM +0800, Baolin Wang wrote: > Fix some misspelled words. > > Signed-off-by: Baolin Wang > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH 1/6] power: supply: charger-manager: Remove unused index counting

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 07:01:08PM +0800, Baolin Wang wrote: > Remove unused index counting. > > Signed-off-by: Baolin Wang > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c |4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [PATCH 1/6] power: supply: charger-manager: Remove unused index counting

2018-12-05 Thread Sebastian Reichel
Hi, On Fri, Nov 16, 2018 at 07:01:08PM +0800, Baolin Wang wrote: > Remove unused index counting. > > Signed-off-by: Baolin Wang > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c |4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [PATCH 5/6] power: supply: charger-manager: Remove deprecated extcon APIs

2018-12-05 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 10:57:12AM +0800, Baolin Wang wrote: > Hi Rob, > On Wed, 5 Dec 2018 at 05:52, Rob Herring wrote: > > > > On Fri, Nov 16, 2018 at 07:01:12PM +0800, Baolin Wang wrote: > > > The struct extcon_specific_cable_nb and related APIs are deprecated now, > > > so we should use

Re: [PATCH 5/6] power: supply: charger-manager: Remove deprecated extcon APIs

2018-12-05 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 10:57:12AM +0800, Baolin Wang wrote: > Hi Rob, > On Wed, 5 Dec 2018 at 05:52, Rob Herring wrote: > > > > On Fri, Nov 16, 2018 at 07:01:12PM +0800, Baolin Wang wrote: > > > The struct extcon_specific_cable_nb and related APIs are deprecated now, > > > so we should use

Re: [patch 0/2 for-4.20] mm, thp: fix remote access and allocation regressions

2018-12-05 Thread Michal Hocko
On Wed 05-12-18 11:49:26, David Rientjes wrote: > On Wed, 5 Dec 2018, Michal Hocko wrote: > > > > The revert is certainly needed to prevent the regression, yes, but I > > > anticipate that Andrea will report back that patch 2 at least improves > > > the > > > situation for the problem that he

Re: [patch 0/2 for-4.20] mm, thp: fix remote access and allocation regressions

2018-12-05 Thread Michal Hocko
On Wed 05-12-18 11:49:26, David Rientjes wrote: > On Wed, 5 Dec 2018, Michal Hocko wrote: > > > > The revert is certainly needed to prevent the regression, yes, but I > > > anticipate that Andrea will report back that patch 2 at least improves > > > the > > > situation for the problem that he

RE: [PATCH 0/9] dt-bindings: Firmware node binding for ZynqMP core

2018-12-05 Thread Jolly Shah
Hi Rob, Thanks for the review. Please find my responses inline. Thanks, Jolly Shah > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, December 04, 2018 2:06 PM > To: Jolly Shah > Cc: mark.rutl...@arm.com; Michal Simek ; Rajan Vaja > ; Nava kishore Manne

RE: [PATCH 0/9] dt-bindings: Firmware node binding for ZynqMP core

2018-12-05 Thread Jolly Shah
Hi Rob, Thanks for the review. Please find my responses inline. Thanks, Jolly Shah > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, December 04, 2018 2:06 PM > To: Jolly Shah > Cc: mark.rutl...@arm.com; Michal Simek ; Rajan Vaja > ; Nava kishore Manne

Re: [PATCH v6 4/7] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm

2018-12-05 Thread Mimi Zohar
On Tue, 2018-12-04 at 15:40 -0800, Jarkko Sakkinen wrote: > On Tue, Dec 04, 2018 at 09:21:35AM +0100, Roberto Sassu wrote: > > Currently the TPM driver allows other kernel subsystems to read only the > > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > > tpm2_pcr_read() to

Re: [PATCH v6 4/7] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm

2018-12-05 Thread Mimi Zohar
On Tue, 2018-12-04 at 15:40 -0800, Jarkko Sakkinen wrote: > On Tue, Dec 04, 2018 at 09:21:35AM +0100, Roberto Sassu wrote: > > Currently the TPM driver allows other kernel subsystems to read only the > > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > > tpm2_pcr_read() to

Re: [PATCH] clk: mediatek: fix the PCIe MAC clock parent

2018-12-05 Thread Stephen Boyd
Quoting Ryder Lee (2018-12-04 22:41:10) > The PCIe function doesn't work as the clock tree of MAC layer is wrong. > Hence fix the clock table. > > Fixes: 3b5e748615e7 ("clk: mediatek: add clock support for MT7629 SoC") > Signed-off-by: Ryder Lee > --- Applied to clk-next

Re: [PATCH] clk: mediatek: fix the PCIe MAC clock parent

2018-12-05 Thread Stephen Boyd
Quoting Ryder Lee (2018-12-04 22:41:10) > The PCIe function doesn't work as the clock tree of MAC layer is wrong. > Hence fix the clock table. > > Fixes: 3b5e748615e7 ("clk: mediatek: add clock support for MT7629 SoC") > Signed-off-by: Ryder Lee > --- Applied to clk-next

Re: [PATCH v14 11/11] selftests/livepatch: introduce tests

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:31AM +0100, Petr Mladek wrote: > From: Joe Lawrence > > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against: > > - basic livepatching (multiple patches, atomic replace) > - pre/post (un)patch

Re: [PATCH v14 11/11] selftests/livepatch: introduce tests

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:31AM +0100, Petr Mladek wrote: > From: Joe Lawrence > > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against: > > - basic livepatching (multiple patches, atomic replace) > - pre/post (un)patch

Re: [PATCH v14 10/11] livepatch: Remove ordering and refuse loading conflicting patches

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:30AM +0100, Petr Mladek wrote: > The atomic replace and cumulative patches were introduced as a more secure > way to handle dependent patches. They simplify the logic: > > + Any new cumulative patch is supposed to take over shadow variables > and changes made

Re: [PATCH v14 10/11] livepatch: Remove ordering and refuse loading conflicting patches

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:30AM +0100, Petr Mladek wrote: > The atomic replace and cumulative patches were introduced as a more secure > way to handle dependent patches. They simplify the logic: > > + Any new cumulative patch is supposed to take over shadow variables > and changes made

Re: [PATCH v14 09/11] livepatch: Atomic replace and cumulative patches documentation

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:29AM +0100, Petr Mladek wrote: > User documentation for the atomic replace feature. It makes it easier > to maintain livepatches using so-called cumulative patches. > > Signed-off-by: Petr Mladek > --- Acked-by: Joe Lawrence >

Re: [PATCH v14 09/11] livepatch: Atomic replace and cumulative patches documentation

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:29AM +0100, Petr Mladek wrote: > User documentation for the atomic replace feature. It makes it easier > to maintain livepatches using so-called cumulative patches. > > Signed-off-by: Petr Mladek > --- Acked-by: Joe Lawrence >

Re: [PATCH v14 08/11] livepatch: Remove Nop structures when unused

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:28AM +0100, Petr Mladek wrote: > Replaced patches are removed from the stack when the transition is > finished. It means that Nop structures will never be needed again > and can be removed. Why should we care? > > + Nop structures make false feeling that the

Re: [PATCH v14 08/11] livepatch: Remove Nop structures when unused

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:28AM +0100, Petr Mladek wrote: > Replaced patches are removed from the stack when the transition is > finished. It means that Nop structures will never be needed again > and can be removed. Why should we care? > > + Nop structures make false feeling that the

Re: [patch 1/2 for-4.20] mm, thp: restore node-local hugepage allocations

2018-12-05 Thread Michal Hocko
On Wed 05-12-18 11:24:53, David Rientjes wrote: > On Wed, 5 Dec 2018, Michal Hocko wrote: > > > > > At minimum do not remove the cleanup part which consolidates the gfp > > > > hadnling to a single place. There is no real reason to have the > > > > __GFP_THISNODE ugliness outside of

Re: [patch 1/2 for-4.20] mm, thp: restore node-local hugepage allocations

2018-12-05 Thread Michal Hocko
On Wed 05-12-18 11:24:53, David Rientjes wrote: > On Wed, 5 Dec 2018, Michal Hocko wrote: > > > > > At minimum do not remove the cleanup part which consolidates the gfp > > > > hadnling to a single place. There is no real reason to have the > > > > __GFP_THISNODE ugliness outside of

Re: [PATCH] leds: 88pm860x: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Pavel Machek
On Wed 2018-12-05 13:50:27, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For instances using of_node_cmp, this has the side effect of now using > case sensitive comparisons. This

Re: [PATCH 1/5] gnss: sirf: write data to gnss only when the gnss device is open

2018-12-05 Thread Andreas Kemnade
On Wed, 5 Dec 2018 15:47:39 +0100 Johan Hovold wrote: > On Sun, Nov 18, 2018 at 10:57:57PM +0100, Andreas Kemnade wrote: > > The api forbids writing data there otherwise. Prepare for the > > serdev_open()/close() being a part of runtime pm. > > > > Signed-off-by: Andreas Kemnade > > --- > >

Re: [PATCH] leds: 88pm860x: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Pavel Machek
On Wed 2018-12-05 13:50:27, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For instances using of_node_cmp, this has the side effect of now using > case sensitive comparisons. This

Re: [PATCH 1/5] gnss: sirf: write data to gnss only when the gnss device is open

2018-12-05 Thread Andreas Kemnade
On Wed, 5 Dec 2018 15:47:39 +0100 Johan Hovold wrote: > On Sun, Nov 18, 2018 at 10:57:57PM +0100, Andreas Kemnade wrote: > > The api forbids writing data there otherwise. Prepare for the > > serdev_open()/close() being a part of runtime pm. > > > > Signed-off-by: Andreas Kemnade > > --- > >

<    2   3   4   5   6   7   8   9   10   11   >