Re: [Letux-kernel] [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2019-01-18 Thread J, KEERTHY
On 1/19/2019 12:42 PM, Andreas Kemnade wrote: On Sat, 19 Jan 2019 12:09:48 +0530 "J, KEERTHY" wrote: On 1/19/2019 1:18 AM, Tony Lindgren wrote: * Andreas Kemnade [190118 19:42]: On Fri, 18 Jan 2019 20:38:47 +0100 Andreas Kemnade wrote: Hi, On Fri, 18 Jan 2019 10:36:30 -0800 Tony

Re: [PATCH 1/2] tpm/eventlog/tpm1: Simplify walking over *pos measurements

2019-01-18 Thread Jia Zhang
On 2019/1/18 下午11:18, Jarkko Sakkinen wrote: > On Thu, Jan 17, 2019 at 09:32:55AM +0800, Jia Zhang wrote: >> >> >> On 2019/1/17 上午6:09, Jarkko Sakkinen wrote: >>> Please use "tpm:" tag for commits, not "tpm/eventlog/tpm1". >>> ... snipped > > OK, got it now. I think I will apply this! Will

Question about out_unmap section of map_sg in amd_iommu.c

2019-01-18 Thread Jerry Snitselaar
out_unmap: pr_err("%s: IOMMU mapping error in map_sg (io-pages: %d)\n", dev_name(dev), npages); for_each_sg(sglist, s, nelems, i) { int j, pages = iommu_num_pages(sg_phys(s), s->length, PAGE_SIZE); for (j = 0; j < pages;

Re: [Letux-kernel] [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2019-01-18 Thread Andreas Kemnade
On Sat, 19 Jan 2019 12:09:48 +0530 "J, KEERTHY" wrote: > On 1/19/2019 1:18 AM, Tony Lindgren wrote: > > * Andreas Kemnade [190118 19:42]: > >> On Fri, 18 Jan 2019 20:38:47 +0100 > >> Andreas Kemnade wrote: > >> > >>> Hi, > >>> > >>> On Fri, 18 Jan 2019 10:36:30 -0800 > >>> Tony Lindgren

Re: [RFC PATCH] mm, oom: fix use-after-free in oom_kill_process

2019-01-18 Thread Michal Hocko
On Fri 18-01-19 16:50:22, Shakeel Butt wrote: [...] > On looking further it seems like the process selected to be oom-killed > has exited even before reaching read_lock(_lock) in > oom_kill_process(). More specifically the tsk->usage is 1 which is due > to get_task_struct() in oom_evaluate_task()

Re: [Letux-kernel] [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2019-01-18 Thread J, KEERTHY
On 1/19/2019 1:18 AM, Tony Lindgren wrote: * Andreas Kemnade [190118 19:42]: On Fri, 18 Jan 2019 20:38:47 +0100 Andreas Kemnade wrote: Hi, On Fri, 18 Jan 2019 10:36:30 -0800 Tony Lindgren wrote: [...] til the next workaround. That flags also causes the iclk being

[PATCH v5 4/5] irqchip: sifive-plic: Differentiate between PLIC handler and context

2019-01-18 Thread Anup Patel
We explicitly differentiate between PLIC handler and context because PLIC context is for given mode of HART whereas PLIC handler is per-CPU software construct meant for handling interrupts from a particular PLIC context. To achieve this differentiation, we rename "nr_handlers" to "nr_contexts"

[PATCH v5 5/5] irqchip: sifive-plic: Implement irq_set_affinity() for SMP host

2019-01-18 Thread Anup Patel
Currently on SMP host, all CPUs take external interrupts routed via PLIC. All CPUs will try to claim a given external interrupt but only one of them will succeed while other CPUs would simply resume whatever they were doing before. This means if we have N CPUs then for every external interrupt N-1

[PATCH v5 3/5] irqchip: sifive-plic: Add warning in plic_init() if handler already present

2019-01-18 Thread Anup Patel
We have two enteries (one for M-mode and another for S-mode) in the interrupts-extended DT property of PLIC DT node for each HART. It is expected that firmware/bootloader will set M-mode HWIRQ line of each HART to 0x (i.e. -1) in interrupts-extended DT property because Linux runs in S-mode

[PATCH v5 2/5] irqchip: sifive-plic: Don't inline plic_toggle() and plic_irq_toggle()

2019-01-18 Thread Anup Patel
The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a for loop so both these functions are not suitable for being inline hence this patch removes the inline keyword. Signed-off-by: Anup Patel --- drivers/irqchip/irq-sifive-plic.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v5 1/5] irqchip: sifive-plic: Pre-compute context hart base and enable base

2019-01-18 Thread Anup Patel
This patch does following optimizations: 1. Pre-compute hart base for each context handler 2. Pre-compute enable base for each context handler 3. Have enable lock for each context handler instead of global plic_toggle_lock Signed-off-by: Anup Patel --- drivers/irqchip/irq-sifive-plic.c | 47

[PATCH v5 0/5] IRQ affinity support in PLIC driver

2019-01-18 Thread Anup Patel
This patchset primarily adds IRQ affinity support in PLIC driver and other improvements. It gives mechanism for explicitly route external interrupts to particular CPUs using smp_affinity attribute of each Linux IRQs. Also, we can now use IRQ balancer from kernel-space or user-space. The patchset

Re: [patch 7/9] smb3: Cleanup license mess

2019-01-18 Thread Steve French
merged into cifs-2.6.git for-next On Thu, Jan 17, 2019 at 5:17 PM Thomas Gleixner wrote: > > Precise and non-ambiguous license information is important. The recently > added aegis header file has a SPDX license identifier, which is nice, but > at the same time it has a contradictionary license

Re: [PATCH v4 5/5] irqchip: sifive-plic: Implement irq_set_affinity() for SMP host

2019-01-18 Thread Anup Patel
On Tue, Jan 15, 2019 at 9:27 PM Christoph Hellwig wrote: > > > + if (!force) > > + cpu = cpumask_any_and(mask_val, cpu_online_mask); > > + else > > + cpu = cpumask_first(mask_val); > > Any reason for the inverted test? Okay, I will not use inverted test here. > >

Re: [PATCH v4 4/5] irqchip: sifive-plic: Differentiate between PLIC handler and context

2019-01-18 Thread Anup Patel
On Tue, Jan 15, 2019 at 9:26 PM Christoph Hellwig wrote: > > On Thu, Dec 27, 2018 at 04:48:20PM +0530, Anup Patel wrote: > > We explicitly differentiate between PLIC handler and context because > > PLIC context is for given mode of HART whereas PLIC handler is per-CPU > > software construct meant

Re: [PATCH v4 3/5] irqchip: sifive-plic: Add warning in plic_init() if handler already present

2019-01-18 Thread Anup Patel
On Tue, Jan 15, 2019 at 9:24 PM Christoph Hellwig wrote: > > On Thu, Dec 27, 2018 at 04:48:19PM +0530, Anup Patel wrote: > > We have two enteries (one for M-mode and another for S-mode) in the > > interrupts-extended DT property of PLIC DT node for each HART. It is > > expected that

[PATCH] PM / devfreq: fix mem leak and missing check of return value in devfreq_add_device()

2019-01-18 Thread Yangtao Li
'devfreq' is malloced in devfreq_add_device() and should be freed in the error handling cases, otherwise it will cause memory leak. devm_kzalloc() could fail, so insert a check of its return value. And if it fails, returns -ENOMEM. Signed-off-by: Yangtao Li --- drivers/devfreq/devfreq.c | 33

Re: [PATCH v4 2/5] irqchip: sifive-plic: Don't inline plic_toggle() and plic_irq_toggle()

2019-01-18 Thread Anup Patel
On Tue, Jan 15, 2019 at 9:24 PM Christoph Hellwig wrote: > > On Thu, Dec 27, 2018 at 04:48:18PM +0530, Anup Patel wrote: > > The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a > > for loop so both these functions are not suitable for being inline > > hence this patch removes the

Re: [PATCH] remoteproc: qcom_q6v5: don't auto boot remote processor

2019-01-18 Thread Sibi Sankar
Hi Brian, Thanks for the review On 2019-01-19 02:34, Brian Norris wrote: Hi Sibi, On Fri, Jan 18, 2019 at 11:46 AM Sibi Sankar wrote: On 2019-01-19 00:05, Brian Norris wrote: > On Thu, Jan 17, 2019 at 11:04 PM Sibi Sankar >> After experimenting with in kernel solutions for >> three

Re: [Linux-eng] [RFC 0/3] Abstract empty functions with STUB_UNLESS macro

2019-01-18 Thread Masahiro Yamada
On Sat, Jan 19, 2019 at 1:02 AM Andrew Murray wrote: > > A common pattern found in header files is a function declaration dependent > on a CONFIG_ option being enabled, followed by an empty function for when > that option isn't enabled. This boilerplate code can often take up a lot > of space and

Re: [RFC PATCH] mm, oom: fix use-after-free in oom_kill_process

2019-01-18 Thread Tetsuo Handa
On 2019/01/19 9:50, Shakeel Butt wrote: > On looking further it seems like the process selected to be oom-killed > has exited even before reaching read_lock(_lock) in > oom_kill_process(). More specifically the tsk->usage is 1 which is due > to get_task_struct() in oom_evaluate_task() and the

Re: [PATCH v2 13/29] arch: add split IPC system calls where needed

2019-01-18 Thread Gabriel Paubert
On Fri, Jan 18, 2019 at 05:18:19PM +0100, Arnd Bergmann wrote: > The IPC system call handling is highly inconsistent across architectures, > some use sys_ipc, some use separate calls, and some use both. We also > have some architectures that require passing IPC_64 in the flags, and > others that

[PATCH V2 rdma-next 2/3] RDMA/hns: Fix the chip hanging caused by sending mailbox during reset

2019-01-18 Thread Wei Hu (Xavier)
On hi08 chip, There is a possibility of chip hanging and some errors when sending mailbox & doorbell during reset. We can fix it by prohibiting mailbox and doorbell during reset and reset occurred to ensure that hardware can work normally. Fixes: a04ff739f2a9 ("RDMA/hns: Add command queue support

[PATCH V2 rdma-next 3/3] RDMA/hns: Fix the chip hanging caused by sending doorbell during reset

2019-01-18 Thread Wei Hu (Xavier)
On hi08 chip, There is a possibility of chip hanging when sending doorbell during reset. We can fix it by prohibiting doorbell during reset. Fixes: 2d40788825ac ("RDMA/hns: Add support for processing send wr and receive wr") Signed-off-by: Wei Hu (Xavier) ---

[PATCH V2 rdma-next 0/3] RDMA/hns: Some fixes for hns RoCE driver

2019-01-18 Thread Wei Hu (Xavier)
Hi, Jason and Doug This patch series includes three bugfixes for reset related operations and are maked based on wip/jgg-for-next branch. Best Regards Xavier Wei Hu (Xavier) (3): RDMA/hns: Fix the Oops during rmmod or insmod ko when reset occurs RDMA/hns: Fix the chip hanging caused by

[PATCH V2 rdma-next 1/3] RDMA/hns: Fix the Oops during rmmod or insmod ko when reset occurs

2019-01-18 Thread Wei Hu (Xavier)
In the reset process, the hns3 NIC driver notifies the RoCE driver to perform reset related processing by calling the .reset_notify() interface registered by the RoCE driver in hip08 SoC. In the current version, if a reset occurs simultaneously during the execution of rmmod or insmod ko, there

Re: [PATCH v1 1/5] pwm: mediatek: add a property "mediatek,num-pwms"

2019-01-18 Thread Ryder Lee
On Fri, 2019-01-18 at 09:43 +0100, Matthias Brugger wrote: > > On 18/01/2019 04:24, Ryder Lee wrote: > > This adds a property "mediatek,num-pwms" to avoid having an endless > > list of compatibles with no differences for the same driver. > > > > Thus, the driver should have backwards

Re: [PATCH] workqueue: Try to catch flush_work() without INIT_WORK().

2019-01-18 Thread Tetsuo Handa
On 2019/01/19 4:48, Daniel Jordan wrote: > On Sat, Jan 19, 2019 at 02:04:58AM +0900, Tetsuo Handa wrote: >> syzbot found a flush_work() caller who forgot to call INIT_WORK() >> because that work_struct was allocated by kzalloc(). But the message >> >> INFO: trying to register non-static key. >>

Re: [PATCH v2] perf scripts python: Add Python 3 support to failed-syscalls-by-pid.py

2019-01-18 Thread Tony Jones
On 1/18/19 5:12 PM, Tony Jones wrote: > On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > >> +from __future__ import print_function > > You don't need this unless you're actually requiring functionality that only > exists in v3. > For example, you need it to handle the suppress newline

Re: [PATCH v6 00/16] locking/lockdep: Add support for dynamic keys

2019-01-18 Thread Bart Van Assche
On 1/18/19 1:48 AM, Peter Zijlstra wrote: On Mon, Jan 14, 2019 at 08:52:33AM -0800, Bart Van Assche wrote: On Mon, 2019-01-14 at 13:52 +0100, Peter Zijlstra wrote: On Fri, Jan 11, 2019 at 09:01:41AM -0800, Bart Van Assche wrote: The list_del_rcu() call must only happen once. Yes; obviously.

Shooting and Retouching

2019-01-18 Thread Jenna
Want to shoot photos for your products and retouching also i needed? We are studio special for photo shooting and retouching. For your photos: White background, Optimized for Shopify, Retouching included Revisions accepted We can also give you dedicate editing service for your photos Let me

[REGRESSION 3.16.61] x86/vdso: Fix asm constraints on vDSO syscall fallbacks

2019-01-18 Thread tedheadster
I bisected a bug than manifests itself on 32-bit i386 architectures to commit 4f9007359bcd28bc83c63cb9af38d8b2c8c1670d for long term kernel 3.16.61. It appears as one of two cases, varying by cpu architecture. All of them fail with an error message variation of "systemd[1]: Assertion

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-18 Thread Tony Jones
On 1/18/19 4:29 PM, Tony Jones wrote: > I'd been simultaneously working on a patch set to fix up Python3. > > It's actually already in our Factory and SLE15-SP1 releases as we had a > deadline to kill Python2 usage for internal rpms. > > I was going to post once I'd fixed the last remaining

Re: [RFC PATCH] mm, oom: fix use-after-free in oom_kill_process

2019-01-18 Thread Roman Gushchin
Hi Shakeel! > > On looking further it seems like the process selected to be oom-killed > has exited even before reaching read_lock(_lock) in > oom_kill_process(). More specifically the tsk->usage is 1 which is due > to get_task_struct() in oom_evaluate_task() and the put_task_struct > within

Re: [PATCH] sched/wait: introduce wait_event_freezable_hrtimeout

2019-01-18 Thread Joel Fernandes
On Fri, Jan 18, 2019 at 06:08:01PM +0100, Hugo Lefeuvre wrote: [...] > > > +/* > > > + * like wait_event_hrtimeout() -- except it uses TASK_INTERRUPTIBLE to > > > avoid > > > + * increasing load and is freezable. > > > + */ > > > +#define wait_event_freezable_hrtimeout(wq_head, condition,

Re: [PATCH 4/5] riscv: treat cpu devicetree nodes without status as enabled

2019-01-18 Thread Paul Walmsley
On Fri, 18 Jan 2019, Johan Hovold wrote: > Follow the Linux convention and treat devicetree nodes without a status > property as enabled rather than disabled, while also allowing "ok" as a > shorthand for "okay". > > Signed-off-by: Johan Hovold Reviewed-by: Paul Walmsley ... although I

Re: [PATCH 3/5] riscv: fix riscv_of_processor_hartid() comment

2019-01-18 Thread Paul Walmsley
On Fri, 18 Jan 2019, Johan Hovold wrote: > The riscv_of_processor_hartid() helper returns -ENODEV when the > specified node isn't an enabled and valid RISC-V hart node. > > Also drop the unnecessary parenthesis around errno defines. > > Signed-off-by: Johan Hovold Reviewed-by: Paul Walmsley

Re: [PATCH v2] perf scripts python: Add Python 3 support to stackcollapse.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > Support both Python 2 and Python 3 in stackcollapse.py. ``print`` is now a > function rather than a statement. This should have no functional change. > > Signed-off-by: Seeteena Thoufeek > Reviewed-by: Ravi Bangoria > --- >

Re: [PATCH 2/5] riscv: use pr_info and friends

2019-01-18 Thread Paul Walmsley
On Fri, 18 Jan 2019, Johan Hovold wrote: > Use the pr_info and pr_err macros instead of printk with explicit log > levels. > > Signed-off-by: Johan Hovold Reviewed-by: Paul Walmsley - Paul

[PATCH v6 1/8] perf cs-etm: Add last instruction information in packet

2019-01-18 Thread Leo Yan
Decoder provides last instruction related information, these information can be used for trace analysis; specifically we can get to know what kind of branch instruction has been executed, mainly the information are contained in three element fields: last_i_type: this is significant type for

[PATCH v6 5/8] perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata

2019-01-18 Thread Leo Yan
If packet processing wants to know the packet is bound with which ETM version, it needs to access metadata to decide that based on metadata magic number; but we cannot simply to use CPU logic ID number as index to access metadata sequential array, especially when system have hotplugged off CPUs,

[PATCH v6 0/8] perf cs-etm: Add support for sample flags

2019-01-18 Thread Leo Yan
This patch seris adds support for sample flags so can facilitate perf to print sample flags for branch instruction. Patch 0001 is used to save last branch information in packet structure, this includes instruction type, subtype and condition flag to help making decision for which branch

[PATCH v6 4/8] perf cs-etm: Add exception number in exception packet

2019-01-18 Thread Leo Yan
When an exception packet comes, it contains the information for exception number; the exception number indicates the exception types, so from it we can know if the exception is taken for interrupt, system call or other traps, etc. This patch simply adds a field in cs_etm_packet struct, it records

[PATCH v6 7/8] perf cs-etm: Set sample flags for exception packet

2019-01-18 Thread Leo Yan
The exception taken and returning are typical flow for instruction jump but it needs to be handled with exception packets. This patch is to set sample flags for exception packet. Since the exception packet contains the exception number, according to the exception number this patch makes decision

[PATCH v6 6/8] perf cs-etm: Add traceID in packet

2019-01-18 Thread Leo Yan
Add traceID in packet, thus we can use traceID to retrieve metadata pointer from traceID-metadata tuple. Signed-off-by: Leo Yan --- tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 2 ++ tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 1 + 2 files changed, 3 insertions(+) diff --git

[PATCH v6 8/8] perf cs-etm: Set sample flags for exception return packet

2019-01-18 Thread Leo Yan
When return from exception, we need to distinguish if it's system call return or for other type exceptions for setting sample flags. Due to the exception return packet doesn't contain exception number, so we cannot decide sample flags based on exception number. On the other hand, the exception

[PATCH v6 3/8] perf cs-etm: Set sample flags for trace discontinuity

2019-01-18 Thread Leo Yan
In the middle of trace stream, it might be interrupted thus the trace data is not continuous, the trace stream firstly is ended for previous trace block and restarted for next block. To display related information for showing trace is restarted, this patch set sample flags for trace

[PATCH v6 2/8] perf cs-etm: Set sample flags for instruction range packet

2019-01-18 Thread Leo Yan
The perf sample data contains flags to indicate the hardware trace data is belonging to which type branch instruction, thus this can be used to print out the human readable string. Arm CoreSight ETM sample data is missed to set flags and it is always set to zeros, this results in perf tool skips

Shooting and Retouching

2019-01-18 Thread Jenna
Want to shoot photos for your products and retouching also i needed? We are studio special for photo shooting and retouching. For your photos: White background, Optimized for Shopify, Retouching included Revisions accepted We can also give you dedicate editing service for your photos Let me

Shooting and Retouching

2019-01-18 Thread Jenna
Want to shoot photos for your products and retouching also i needed? We are studio special for photo shooting and retouching. For your photos: White background, Optimized for Shopify, Retouching included Revisions accepted We can also give you dedicate editing service for your photos Let me

Re: [PATCH v2] perf scripts python: Add Python 3 support to sctop.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > +from __future__ import print_function Again, you don't need this. > - print "\nsyscall events for %s:\n\n" % (for_comm), > + print("\nsyscall events for %s:\n\n" % (for_comm)), same comments regarding

Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr

2019-01-18 Thread Jerry Hoemann
On Tue, Jan 15, 2019 at 04:07:03PM +0800, Pingfan Liu wrote: > People reported a bug on a high end server with many pcie devices, where > kernel bootup with crashkernel=384M, and kaslr is enabled. Even > though we still see much memory under 896 MB, the finding still failed > intermittently.

[GIT PULL] SCSI fixes for 5.0-rc2

2019-01-18 Thread James Bottomley
A set of 17 fixes. Most of these are minor or trivial. The one fix that may be serious is the isci one: the bug can cause hba parameters to be set from uninitialized memory. I don't think it's exploitable, but you never know. The patch is available here:

Re: [PATCH v2] perf scripts python: Add Python 3 support to netdev-times.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote:> Support both Python 2 and Python 3 in netdev-times.py. ``print`` > is now a function rather than a statement. This should have no > functional change. Same feedback as all the other patches applies. In addition: $ git annotate

Re: [PATCH v2] perf scripts python: Add Python 3 support to intel-pt-events.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > Support both Python 2 and Python 3 in intel-pt-events.py.``print`` > is now a function rather than a statement. This should have no > functional change. > > Fixes indentation issue, replace spaces with tab. Again, trailing comma use is incorrect.

Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component

2019-01-18 Thread Curtis Malainey
On Fri, Jan 18, 2019 at 5:12 PM Curtis Malainey wrote: > > > > On Fri, Jan 18, 2019 at 3:02 PM Pierre-Louis Bossart > wrote: >> >> >> On 1/15/19 3:16 PM, Pierre-Louis Bossart wrote: >> > >> >>> Beyond the fact that the platform_name seems to be totally useless, >> >>> additional tests show that

Shooting and Retouching

2019-01-18 Thread Jenna
Want to shoot photos for your products and retouching also i needed? We are studio special for photo shooting and retouching. For your photos: White background, Optimized for Shopify, Retouching included Revisions accepted We can also give you dedicate editing service for your photos Let me

RE: [PATCH hyperv-fixes,3/3] Fix hash key value reset after other ops

2019-01-18 Thread Michael Kelley
From: Haiyang Zhang Sent: Monday, January 14, 2019 4:52 PM > > Changing mtu, channels, or buffer sizes ops call to netvsc_attach(), > rndis_set_subchannel(), which always reset the hash key to default > value. That will override hash key changed previously. This patch > fixes the problem by

RE: [PATCH hyperv-fixes,2/3] Refactor assignments of struct netvsc_device_info

2019-01-18 Thread Michael Kelley
From: Haiyang Zhang Sent: Monday, January 14, 2019 4:52 PM > > These assignments occur in multiple places. The patch refactor them > to a function for simplicity. It also puts the struct to heap area > for future expension. > > Signed-off-by: Haiyang Zhang > --- >

RE: [PATCH hyperv-fixes,1/3] Fix ethtool change hash key error

2019-01-18 Thread Michael Kelley
From: Haiyang Zhang Sent: Monday, January 14, 2019 4:52 PM > > Hyper-V hosts require us to disable RSS before changing RSS key, > otherwise the changing request will fail. This patch fixes the > coding error. > > Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table") >

Re: [PATCH v2] perf scripts python: Add Python 3 support to failed-syscalls-by-pid.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > +from __future__ import print_function You don't need this unless you're actually requiring functionality that only exists in v3. For example, you need it to handle the suppress newline functionality such as "end=". > def print_error_totals(): >

Re: [PATCH v2] perf scripts python: Add Python 3 support to export-to-sqlite.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > Support both Python 2 and Python 3 in export-to-sqlite.py. ``print`` is > now a function rather than a statement. This should have no functional > change. I don't see any changes handling the following: $ git annotate

[PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-18 Thread Steve Longerbeam
Disable the SMFC before disabling the IDMA channel, instead of after, in csi_idmac_unsetup(). This fixes a complete system hard lockup on the SabreAuto when streaming from the ADV7180, by repeatedly sending a stream off immediately followed by stream on: while true; do v4l2-ctl -d4

[PATCH v3 2/2] media: imx: prpencvf: Stop upstream before disabling IDMA channel

2019-01-18 Thread Steve Longerbeam
Upstream must be stopped immediately after receiving the last EOF and before disabling the IDMA channel. This can be accomplished by moving upstream stream off to just after receiving the last EOF completion in prp_stop(). For symmetry also move upstream stream on to end of prp_start(). This

Re: [PATCH v9 4/4] sound/usb: Use Media Controller API to share media resources

2019-01-18 Thread shuah
On 1/18/19 2:54 PM, shuah wrote: On 1/18/19 1:36 AM, Hans Verkuil wrote: On 12/18/18 6:59 PM, sh...@kernel.org wrote: From: Shuah Khan Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical

[PATCH] libnvdimm: Clarify nd_pfn_init() flow

2019-01-18 Thread Dan Williams
In recent days, 2 engineers, including the original author of nd_pfn_init(), overlooked the internal call to nd_pfn_validate() and the implications to memory allocation. Clarify this situation to help anyone that reads through this code in the future. Reported-by: Wei Yang Signed-off-by: Dan

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > - print "vec=%s\n" % \ > - (symbol_str("irq__softirq_entry", "vec", vec)), > + print("vec=%s\n" % \ > + (symbol_str("irq__softirq_entry", "vec", vec))), Again, check the trailing comma usage: $ echo

Re: [PATCH v2] perf scripts python: Add Python 3 support to syscall-counts-by-pid.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > - print "\nsyscall events for %s:\n\n" % (for_comm), > + print("\nsyscall events for %s:\n\n" % (for_comm)), > else: > - print "\nsyscall events by comm/pid:\n\n", > + print("\nsyscall events by comm/pid:\n\n"), >

[RFC PATCH] mm, oom: fix use-after-free in oom_kill_process

2019-01-18 Thread Shakeel Butt
In our internal syzbot instance running on upstream kernel, we see the following crash. syzbot has found the following crash on: HEAD commit: 47bfa6d9dc8c Merge tag 'selinux-pr-20190115' of git://git.kernel.org/pub/scm/linux/kernel/g.. git tree:

Re: [PATCH v2] perf scripts python: Add Python 3 support to exported-sql-viewer.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > +if sys.version_info[0] < 3: > +import cPickle > +else: > +import _pickle as cPickle Do you really need this? pickle is already in Python2. Also, did you test these changes on Python3? I think you'll find you also need the following

Re: [PATCH v2 1/2] media: imx: csi: Disable CSI immediately after last EOF

2019-01-18 Thread Steve Longerbeam
On 1/18/19 11:01 AM, Steve Longerbeam wrote: On 1/18/19 2:24 AM, Philipp Zabel wrote: On Thu, 2019-01-17 at 12:49 -0800, Steve Longerbeam wrote: Disable the CSI immediately after receiving the last EOF before stream off (and thus before disabling the IDMA channel). This fixes a complete

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-18 Thread Matthias Kaehlcke
On Fri, Jan 18, 2019 at 10:44:16AM +0100, Johan Hovold wrote: > On Thu, Jan 17, 2019 at 09:21:09AM -0800, Matthias Kaehlcke wrote: > > > I observed that the qcom_geni_serial driver doesn't raise RTS with > > flow control disabled. It seems we have to investigate why that's the > > case. I agree

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-18 Thread Tony Jones
On 1/17/19 4:32 AM, Jiri Olsa wrote: > On Thu, Jan 17, 2019 at 03:15:28PM +0530, Seeteena Thoufeek wrote: >> Support both Python 2 and Python 3 in check-perf-trace.py. >> ``print`` is now a function rather than a statement. This should have >> no functional change. >> >> Fix indentation issue,

Re: [PATCH] NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA

2019-01-18 Thread Dave Jiang
On 1/18/19 5:10 PM, Logan Gunthorpe wrote: > Presently, when ntb_transport is used with DMA and the IOMMU turned on, > it fails with errors from the IOMMU such as: > > DMAR: DRHD: handling fault status reg 202 > DMAR: [DMA Write] Request device [00:04.0] fault addr > 381fc034

[PATCH] tty: serial: qcom_geni_serial: Allow mctrl when flow control is disabled

2019-01-18 Thread Matthias Kaehlcke
The geni set/get_mctrl() functions currently do nothing unless hardware flow control is enabled. Remove this arbitrary limitation. Suggested-by: Johan Hovold Fixes: 8a8a66a1a18a ("tty: serial: qcom_geni_serial: Add support for flow control") Signed-off-by: Matthias Kaehlcke ---

[PATCH v3 2/9] platform/chrome: Add new driver for Wilco EC

2019-01-18 Thread Nick Crews
From: Duncan Laurie This EC is an incompatible variant of the typical Chrome OS embedded controller. It uses the same low-level communication and a similar protocol with some significant differences. The EC firmware does not support the same mailbox commands so it is not registered as a

[PATCH v3 1/9] platform/chrome: Remove cros_ec dependency in lpc_mec

2019-01-18 Thread Nick Crews
From: Duncan Laurie In order to allow this code to be re-used, remove the dependency on the rest of the cros_ec code from the cros_ec_lpc_mec functions. Instead of using a hardcoded register base address of 0x800 have this be passed in to cros_ec_lpc_mec_init(). The existing cros_ec use case

[PATCH v3 3/9] platform/chrome: Add support for raw commands in debugfs

2019-01-18 Thread Nick Crews
From: Duncan Laurie Add a debugfs attribute that allows sending raw commands to the EC. This is useful for development and debug but should not be enabled in a production environment. Turn the keyboard global mic mute led on > echo 00 f2 01 76 06 00 00 01 01 > /sys/kernel/debug/wilco_ec/raw

[PATCH v3 5/9] platform/chrome: rtc: Add RTC driver

2019-01-18 Thread Nick Crews
From: Duncan Laurie This Embedded Controller has an internal RTC that is exposed as a standard RTC class driver with read/write functionality. The driver is added to the drivers/rtc/ so that the maintainer of that directory will be able to comment on this change, as that maintainer is the

[PATCH v3 4/9] platform/chrome: Add sysfs attributes

2019-01-18 Thread Nick Crews
From: Duncan Laurie Add some sample sysfs attributes for the Wilco EC that show how the mailbox interface works. "Legacy" attributes are those that existed in the EC before it was adapted to ChromeOS. > cat /sys/bus/platform/devices/GOOG000C\:00/version Label: 99.99.99 SVN Revision :

[PATCH v3 9/9] platform/chrome: Add binary telemetry attributes

2019-01-18 Thread Nick Crews
From: Nick Crews The Wilco Embedded Controller is able to send telemetry data which is useful for enterprise applications. A daemon running on the OS sends a command (possibly with args) to the EC via this sysfs interface, and the EC responds over the sysfs interface with the response. Both the

[PATCH v3 6/9] platform/chrome: Add event handling

2019-01-18 Thread Nick Crews
From: Duncan Laurie The Wilco Embedded Controller can return extended events that are not handled by standard ACPI objects. These events can include hotkeys which map to standard functions like brightness controls, or information about EC controlled features like the charger or battery. These

[PATCH v3 7/9] platform/chrome: Add EC properties

2019-01-18 Thread Nick Crews
From: Nick Crews A Property is typically a data item that is stored to NVRAM. Each of these data items has an index associated with it known as the Property ID (PID). The Property ID is used by the system BIOS (and EC) to refer to the Property. Properties may have variable lengths. Many features

[PATCH v3 0/9] platform/chrome: rtc: Add support for Wilco EC

2019-01-18 Thread Nick Crews
There is a new chromebook that contains a different Embedded Controller (codename Wilco) than the rest of the chromebook series. Thus the kernel requires a different driver than the already existing and generalized cros_ec_* drivers. Specifically, this driver adds support for getting and setting

[PATCH v3 8/9] platform/chrome: Add peakshift and adv_batt_charging

2019-01-18 Thread Nick Crews
From: Nick Crews Create "peakshift" and "advanced_battery_charging" directories within the "properties" directory, and create the relevant attributes within these. These properties have to do with configuring some of the advanced power management options that prolong battery health and reduce

[PATCH 2/6] selftests: fix typo in seccomp_bpf.c

2019-01-18 Thread Tycho Andersen
There used to be an explanation here because it could trigger lockdep previously, but now we're not doing recursive locking, so it really is just for grins. Signed-off-by: Tycho Andersen --- tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/6] selftests: don't kill child immediately in get_metadata() test

2019-01-18 Thread Tycho Andersen
This this test forks a child, and then the parent waits for a write() to a pipe signalling the child is ready to be attached to. If something in the child ASSERTs before it does this write, the test will hang waiting for it. Instead, let's EXPECT, so that execution continues until we do the write.

[PATCH 6/6] selftests: unshare userns in seccomp pidns testcases

2019-01-18 Thread Tycho Andersen
The pid ns cannot be unshare()d as an unprivileged user without owning the userns as well. Let's unshare the userns so that we can subsequently unshare the pidns. This also means that we don't need to set the no new privs bit as in the other test cases, since we're unsharing the userns.

[PATCH 4/6] selftests: skip seccomp get_metadata test if not real root

2019-01-18 Thread Tycho Andersen
The get_metadata() test requires real root, so let's skip it if we're not real root. Note that I used XFAIL here because that's what the test does later if CONFIG_CHEKCKPOINT_RESTORE happens to not be enabled. After looking at the code, there doesn't seem to be a nice way to skip tests defined as

[PATCH v1 0/6] seccomp test fixes

2019-01-18 Thread Tycho Andersen
Hi all, Here are the fixes I previously mentioned I would send. I previously assumed that the tests were mostly run as root, but it turns out everything else besides the stuff I wrote in the seccomp tests either sets NNP and doesn't require real root, so it all actually works. This set of fixes

[PATCH 3/6] selftest: include stdio.h in kselftest.h

2019-01-18 Thread Tycho Andersen
While playing around with a way to skip the seccomp get_metadata test, I noticed that this header uses printf() without defining it, leading to, ../kselftest.h: In function ‘ksft_print_header’: ../kselftest.h:61:3: warning: implicit declaration of function ‘printf’

[PATCH 5/6] selftests: set NO_NEW_PRIVS bit in seccomp user tests

2019-01-18 Thread Tycho Andersen
seccomp() doesn't allow users who aren't root in their userns to attach filters unless they have the nnp bit set, so let's set it so that these tests can pass when run as an unprivileged user. This idea stolen from the other seccomp tests, which use this trick :) Signed-off-by: Tycho Andersen

[PATCH] NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA

2019-01-18 Thread Logan Gunthorpe
Presently, when ntb_transport is used with DMA and the IOMMU turned on, it fails with errors from the IOMMU such as: DMAR: DRHD: handling fault status reg 202 DMAR: [DMA Write] Request device [00:04.0] fault addr 381fc034 [fault reason 05] PTE Write access is not set This is

[PATCH] iommu/vt-d: Implement dma_[un]map_resource()

2019-01-18 Thread Logan Gunthorpe
Currently the Intel IOMMU uses the default dma_[un]map_resource() implementations does nothing and simply returns the physical address unmodified. However, this doesn't create the IOVA entries necessary for addresses mapped this way to work when the IOMMU is enabled. Thus, when the IOMMU is

[PATCH] dts: arm64/sdm845: Add clocks to WCN3990 WLAN module device node

2019-01-18 Thread Douglas Anderson
When commit be7019103469 ("dts: arm64/sdm845: Add WCN3990 WLAN module device node") was posted upstream no clocks were specified. However, when the pack was picked into the Chrome OS kernel tree (allegedly directly from the mailing list post) it had clock properties. I presume that the clock

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-18 Thread Stephen Warren
On 1/16/19 9:32 AM, Vincent Whitchurch wrote: The Virtio-over-PCIe framework living under drivers/misc/mic/vop implements a generic framework to use virtio between two Linux systems, given shared memory and a couple of interrupts. It does not actually require the Intel MIC hardware, x86-64, or

Re: [PATCH v1 8/8] phy: qcom-ufs: Refactor all init steps into phy_poweron

2019-01-18 Thread Stephen Boyd
Quoting Evan Green (2019-01-11 15:01:29) > diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c > b/drivers/phy/qualcomm/phy-qcom-ufs.c > index f2979ccad00a3..a4cff17fef925 100644 > --- a/drivers/phy/qualcomm/phy-qcom-ufs.c > +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c > @@ -147,6 +147,21 @@ struct phy

Re: [PATCH v6] drm/msm/a6xx: Add support for an interconnect path

2019-01-18 Thread Evan Green
On Fri, Jan 18, 2019 at 3:27 PM Jordan Crouse wrote: > > On Fri, Jan 18, 2019 at 03:04:34PM -0800, Evan Green wrote: > > On Fri, Jan 18, 2019 at 12:24 PM Jordan Crouse > > wrote: > > > > > > Try to get the interconnect path for the GPU and vote for the maximum > > > bandwidth to support all

[PATCH 2/7] [media] doc-rst: switch to new names for Full Screen/Aspect keys

2019-01-18 Thread Dmitry Torokhov
We defined better names for keys to activate full screen mode or change aspect ratio (while keeping the existing keycodes to avoid breaking userspace), so let's use them in the document. Signed-off-by: Dmitry Torokhov --- Documentation/media/uapi/rc/rc-tables.rst | 4 ++-- 1 file changed, 2

[PATCH 4/7] HID: input: add mapping for Expose/Overview key

2019-01-18 Thread Dmitry Torokhov
According to HUTRR77 usage 0x29f from the consumer page is reserved for the Desktop application to present all running user’s application windows. Linux defines KEY_SCALE to request Compiz Scale (Expose) mode, so let's add the mapping. Signed-off-by: Dmitry Torokhov --- This can be applied

  1   2   3   4   5   6   7   8   9   10   >