Re: [PATCH reset-next 2/2] reset: brcmstb: Fix 32-bit build with 64-bit resource_size_t

2019-01-23 Thread Philipp Zabel
Hi Florian, On Tue, 2019-01-22 at 16:33 -0800, Florian Fainelli wrote: > On 32-bit architectures defining resource_size_t as 64-bit (because of > PAE), we can run into a linker failure because of the modulo and the > division against resource_size(), replace the two problematic operations > with

Re: [PATCH v9 09/26] arm64: Unmask PMR before going idle

2019-01-23 Thread Ard Biesheuvel
On Wed, 23 Jan 2019 at 09:56, Julien Thierry wrote: > > > > On 22/01/2019 20:18, Ard Biesheuvel wrote: > > On Mon, 21 Jan 2019 at 16:36, Julien Thierry wrote: > >> > >> CPU does not received signals for interrupts with a priority masked by > >> ICC_PMR_EL1. This means the CPU might not come back

Re: [PATCH RFC] fuse: Prevent background write requests increase inode size

2019-01-23 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 3:03 PM Kirill Tkhai wrote: > > Hi, Miklos, > > this is not a well-tested patch, this is a concept, > showing the places, where it looks we have a problem. > > Commit 7879c4e58b7c made io->async careless about inode size, > and this is wrong. Asyncronuos background requests

Re: [PATCH v6 1/2] PM-runtime: update accounting_timestamp only when enable

2019-01-23 Thread Ulf Hansson
On Wed, 23 Jan 2019 at 09:50, Vincent Guittot wrote: > > On Wed, 23 Jan 2019 at 09:14, Ulf Hansson wrote: > > > > On Tue, 22 Jan 2019 at 15:24, Vincent Guittot > > wrote: > > > > > > Initializing accounting_timestamp to something different from 0 during > > > pm_runtime_init() doesn't make

Re: [PATCH] s390: pci: no need to check return value of debugfs_create functions

2019-01-23 Thread Sebastian Ott
On Tue, 22 Jan 2019, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc:

Re: [PATCH] s390: kernel: no need to check return value of debugfs_create functions

2019-01-23 Thread Heiko Carstens
On Tue, Jan 22, 2019 at 05:33:37PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 22, 2019 at 05:24:54PM +0100, Heiko Carstens wrote: > > On Tue, Jan 22, 2019 at 04:21:02PM +0100, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the > > > return value.

Re: [PATCH v2 1/4] locking/qspinlock: Handle > 4 slowpath nesting levels

2019-01-23 Thread Will Deacon
On Tue, Jan 22, 2019 at 10:49:08PM -0500, Waiman Long wrote: > Four queue nodes per cpu are allocated to enable up to 4 nesting levels > using the per-cpu nodes. Nested NMIs are possible in some architectures. > Still it is very unlikely that we will ever hit more than 4 nested > levels with

Re: [PATCH 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-01-23 Thread Viktor.Rosendahl
Hi Joel, On Tue, 2019-01-22 at 16:53 -0500, Joel Fernandes wrote: > Could you CC me on the other patches as well, next time? I am quite > interested and recently have worked on the latency tracer. > Sure, I will. > > > +MODULE_PARM_DESC(burst_size, "The size of a burst (default 1)"); > >

[PATCH v3 -next] mtd: docg3: Fix a possible memory leak of mtd->name

2019-01-23 Thread YueHaibing
In case DOC_CHIPID_G3, mtd->name is not freed in err handling path, which is alloced by kasprintf(). Fix this by using devm_kasprintf(). Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support") Signed-off-by: YueHaibing --- v3: use devm_kasprintf --- drivers/mtd/devices/docg3.c | 4 ++--

Re: [PATCH v2] PM / EM: Expose the Energy Model in debugfs

2019-01-23 Thread Quentin Perret
On Tuesday 22 Jan 2019 at 19:41:36 (+0100), Greg KH wrote: > On Tue, Jan 22, 2019 at 04:42:47PM +, Quentin Perret wrote: > > The recently introduced Energy Model (EM) framework manages power cost > > tables of CPUs. These tables are currently only visible from kernel > > space. However, in

minimal version requirement for ld

2019-01-23 Thread Cao jin
Hi, (Not sure I am sending the right place) Documentation/process/changes.rst says the minimal version for binutils is 2.20. I am trying the binutils-2.20.51.0.2-5.48.el6.x86_64.rpm of Centos6 on Fedora28, and it give me: HOSTCC scripts/basic/fixdep /usr/bin/ld: unrecognized option '-plugin'

Want to edit your photos

2019-01-23 Thread Judy
We want to work for you to edit your photos. We can do your photos with white background, sharpen, retouching is included for all your photos. Waiting for the test photos to start with. Thanks, Judy

Re: WARN_ON_ONCE(!new_owner) within wake_futex_pi() triggered

2019-01-23 Thread Heiko Carstens
On Tue, Jan 22, 2019 at 10:14:00PM +0100, Thomas Gleixner wrote: > On Mon, 21 Jan 2019, Thomas Gleixner wrote: > > On Mon, 21 Jan 2019, Heiko Carstens wrote: > > > > > Hi Thomas, > > > > > > [full quote below] > > > > > > Did you have any time to look into this yet? :) > > > > > > The warning

Re: [PATCH v2 2/4] locking/qspinlock_stat: Track the no MCS node available case

2019-01-23 Thread Will Deacon
On Tue, Jan 22, 2019 at 10:49:09PM -0500, Waiman Long wrote: > Track the number of slowpath locking operations that are being done > without any MCS node available as well renaming lock_index[123] to make > them more descriptive. > > Using these stat counters is one way to find out if a code path

Re: [PATCH 0/7] SCSI: cleanup debugfs usage

2019-01-23 Thread John Garry
On 22/01/2019 15:08, Greg Kroah-Hartman wrote: When calling debugfs code, there is no need to ever check the return value of the call, as no logic should ever change if a call works properly or not. Fix up a bunch of x86-specific code to not care about the results of debugfs. Greg

Re: [PATCH] qspinlock: no need to check return value of debugfs_create functions

2019-01-23 Thread Greg Kroah-Hartman
On Wed, Jan 23, 2019 at 09:10:18AM +, Will Deacon wrote: > On Tue, Jan 22, 2019 at 04:21:43PM +0100, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do

Re: [PATCH v6 07/16] sched/core: uclamp: Add system default clamps

2019-01-23 Thread Peter Zijlstra
On Tue, Jan 22, 2019 at 03:41:29PM +, Patrick Bellasi wrote: > On 22-Jan 16:13, Peter Zijlstra wrote: > > On Tue, Jan 22, 2019 at 02:43:29PM +, Patrick Bellasi wrote: > > > Do you think that could be acceptable? > > > > Think so, it's a sysctl poke, 'nobody' ever does that. > > Cool,

Re: [PATCH V10 4/4] mmc: tegra: HW Command Queue Support for Tegra SDMMC

2019-01-23 Thread Thierry Reding
On Tue, Jan 22, 2019 at 11:56:33AM -0800, Sowjanya Komatineni wrote: > This patch adds HW Command Queue for supported Tegra SDMMC > controllers. > > Signed-off-by: Sowjanya Komatineni > --- > [V10]: Changes are same as V9 except this series has SDHCI core changes > into seperate patch >

Re: [PATCH v6 05/16] sched/core: uclamp: Update CPU's refcount on clamp changes

2019-01-23 Thread Peter Zijlstra
On Tue, Jan 22, 2019 at 03:33:15PM +, Patrick Bellasi wrote: > On 22-Jan 15:57, Peter Zijlstra wrote: > > On Tue, Jan 22, 2019 at 02:01:15PM +, Patrick Bellasi wrote: > > > Yes, I would say we have two options: > > > > > > 1) SCHED_FLAG_KEEP_POLICY enforces all the scheduling class

Re: [PATCH V10 3/4] mmc: sdhci: Add ADMA3 DMA support for V4 enabled host

2019-01-23 Thread Thierry Reding
On Tue, Jan 22, 2019 at 11:56:32AM -0800, Sowjanya Komatineni wrote: > Below are the supported DMA types in Host Control1 Register > with Version 4 enable > b'00 - SDMA > b'01 - Not Used > b'10 - ADMA2 > b'11 - ADMA2 or ADMA3 > > ADMA3 uses Command Descriptor to issue an SD command. > A

Re: [PATCH V10 1/4] dt-bindings: mmc: Add supports-cqe property

2019-01-23 Thread Thierry Reding
On Tue, Jan 22, 2019 at 11:56:30AM -0800, Sowjanya Komatineni wrote: > Add supports-cqe optional property for MMC hosts. > > This property is used to identify the specific host controller > supporting command queue. > > Signed-off-by: Sowjanya Komatineni > --- > [V10]: This patch version moves

Re: [PATCH v4 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller

2019-01-23 Thread Vignesh R
On 23-Jan-19 2:15 PM, Boris Brezillon wrote: > On Tue, 22 Jan 2019 12:11:37 +0530 > Vignesh R wrote: > >> Cadence OSPI controller IP supports Octal IO (x8 IO lines), >> It also has an integrated PHY. IP register layout is very >> similar to existing QSPI IP except for additional bits to

Re: [PATCH -next] mtd: docg3: Fix passing zero to 'PTR_ERR' warning in doc_probe_device

2019-01-23 Thread Boris Brezillon
On Wed, 23 Jan 2019 14:58:27 +0800 YueHaibing wrote: > Fix a static code checker warning: > drivers/mtd/devices/docg3.c:1875 > doc_probe_device() warn: passing zero to 'ERR_PTR' > > Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support") > Signed-off-by: YueHaibing > --- >

Re: [PATCH] qspinlock: no need to check return value of debugfs_create functions

2019-01-23 Thread Will Deacon
On Tue, Jan 22, 2019 at 04:21:43PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Peter Zijlstra > Cc: Ingo Molnar

Re: [PATCH v2 -next] mtd: docg3: Fix a possible memory leak of mtd->name

2019-01-23 Thread YueHaibing
Pls ignore this err patch. On 2019/1/23 17:07, YueHaibing wrote: > In case DOC_CHIPID_G3, mtd->name is not freed in err handling path, > which is alloced by kasprintf(). Fix this by using devm_kasprintf(). > > Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support") > Signed-off-by:

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-23 Thread Ard Biesheuvel
On Wed, 23 Jan 2019 at 08:15, Christoph Hellwig wrote: > > On Tue, Jan 22, 2019 at 10:07:07PM +0100, Ard Biesheuvel wrote: > > Yes, so much was clear. And the reason this breaks on some arm64 > > systems is because > > a) non-snooped PCIe TLP attributes may be ignored, and > > b) non-x86 CPUs do

[PATCH v2 -next] mtd: docg3: Fix a possible memory leak of mtd->name

2019-01-23 Thread YueHaibing
In case DOC_CHIPID_G3, mtd->name is not freed in err handling path, which is alloced by kasprintf(). Fix this by using devm_kasprintf(). Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support") Signed-off-by: YueHaibing --- v2: use devm_kasprintf --- drivers/mtd/devices/docg3.c | 4 ++--

Re: [PATCH 4.14 00/59] 4.14.95-stable review

2019-01-23 Thread Jon Hunter
On 21/01/2019 13:43, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.95 release. > There are 59 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH 4.9 00/51] 4.9.152-stable review

2019-01-23 Thread Jon Hunter
On 21/01/2019 13:43, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.152 release. > There are 51 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

[PATCH -next] watchdog: pika_wdt: drop pointless static qualifier in pikawdt_init

2019-01-23 Thread YueHaibing
There is no need to have the 'post1' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/watchdog/pika_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/pika_wdt.c b/drivers/watchdog/pika_wdt.c index

Re: [PATCH v9 11/26] efi: Let architectures decide the flags that should be saved/restored

2019-01-23 Thread Julien Thierry
On 21/01/2019 15:42, Ard Biesheuvel wrote: > On Mon, 21 Jan 2019 at 16:34, Julien Thierry wrote: >> >> Currently, irqflags are saved before calling runtime services and >> checked for mismatch on return. >> >> Provide a pair of overridable macros to save and restore (if needed) the >> state

Re: [PATCH] squashfs: fix mtime underflow on 64 bit system

2019-01-23 Thread zhengbin (A)
Ping? On 2019/1/17 16:21, zhengbin wrote: > If we change the file mtime to 1969, mksquashfs and mount, > the atime/mtime of this file will be underflow. The reason is > treating timestamps with the high bit set as positive > times(before 1970), which should be set as negative times > just like on

[PATCH] irqchip/gic-v4: fix occasional VLPI drop

2019-01-23 Thread Heyi Guo
1. In current implementation, every VLPI will temporarily be mapped to the first CPU in system (normally CPU0) and then moved to the real scheduled CPU later. 2. So there is a time window and a VLPI may be sent to CPU0 instead of the real scheduled vCPU, in a multi-CPU virtual machine. 3.

Re: [PATCH] bpftool: Fix prog dump by tag

2019-01-23 Thread Daniel Borkmann
On 01/18/2019 01:58 PM, Jiri Olsa wrote: > Lance reported an issue with bpftool not being able to > dump program if there are more programs loaded and you > want to dump any but the first program, like: > > # bpftool prog > 28: kprobe name trace_req_start tag 1dfc28ba8b3dd597 gpl >

Re: [PATCH v9 09/26] arm64: Unmask PMR before going idle

2019-01-23 Thread Julien Thierry
On 22/01/2019 20:18, Ard Biesheuvel wrote: > On Mon, 21 Jan 2019 at 16:36, Julien Thierry wrote: >> >> CPU does not received signals for interrupts with a priority masked by >> ICC_PMR_EL1. This means the CPU might not come back from a WFI >> instruction. >> >> Make sure ICC_PMR_EL1 does not

Re: [PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2019-01-23 Thread Nicholas Piggin
Christophe Leroy's on January 23, 2019 12:11 am: > Looks like book3s/32 doesn't set RI on machine check, so > checking RI before calling die() will always be fatal > allthought this is not an issue in most cases. Oh good catch, this is a fix for powerpc/64 as well. I think actually the panic was

Re: [PATCH] i2c: imx: fix inconsistent IS_ERR and PTR_ERR

2019-01-23 Thread Gustavo A. R. Silva
On 1/23/19 2:28 AM, Wolfram Sang wrote: > On Tue, Jan 22, 2019 at 06:37:41PM -0600, Gustavo A. R. Silva wrote: >> Fix inconsistent IS_ERR and PTR_ERR in i2c_imx_dma_request. >> >> The proper pointer to be passed as argument is dma->chan_tx. >> >> This bug was detected with the help of

RE: linux-next: Fixes tag needs some work in the renesas tree

2019-01-23 Thread Fabrizio Castro
Hello Stephen, I am sorry for the trouble. My editor is configured to automatically wrap lines when they are too long, I'll be more careful next time. Do you need me to do anything about this patch? Thanks, Fab > From: Stephen Rothwell > Sent: 22 January 2019 20:56 > To: Simon Horman >

Re: [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name

2019-01-23 Thread YueHaibing
On 2019/1/23 16:46, Boris Brezillon wrote: > On Wed, 23 Jan 2019 14:59:43 +0800 > YueHaibing wrote: > >> In case DOC_CHIPID_G3, mtd->name should be freed in the >> err handling path, which is alloced by kasprintf. >> >> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support") >>

Re: [PATCH 6/6] x86: xen: no need to check return value of debugfs_create functions

2019-01-23 Thread Juergen Gross
On 22/01/2019 15:35, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Stefano

Re: [PATCH V2] wlcore: sdio: Fixup power on/off sequence

2019-01-23 Thread Ulf Hansson
On Tue, 22 Jan 2019 at 17:24, Kalle Valo wrote: > > Ulf Hansson wrote: > > > During "wlan-up", we are programming the FW into the WiFi-chip. However, > > re-programming the FW doesn't work, unless a power cycle of the WiFi-chip > > is made in-between the programmings. > > > > To conform to this

Re: [PATCH] rt2x00: no need to check return value of debugfs_create functions

2019-01-23 Thread Stanislaw Gruszka
On Tue, Jan 22, 2019 at 04:21:34PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Stanislaw Gruszka > Cc: Helmut

Re: [PATCH] iwlegacy: no need to check return value of debugfs_create functions

2019-01-23 Thread Stanislaw Gruszka
On Tue, Jan 22, 2019 at 04:21:18PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Stanislaw Gruszka > Cc: Kalle

Re: [PATCH V2] wlcore: sdio: Fixup power on/off sequence

2019-01-23 Thread Ulf Hansson
On Tue, 22 Jan 2019 at 17:08, Jan Kiszka wrote: > > On 21.01.19 15:40, Ulf Hansson wrote: > > On Fri, 18 Jan 2019 at 16:09, Ulf Hansson wrote: > >> > >> On Fri, 18 Jan 2019 at 13:09, Jan Kiszka wrote: > >>> > >>> On 17.01.19 10:54, Ulf Hansson wrote: > On Wed, 16 Jan 2019 at 21:26, Jan

[PATCH -next] gpio: davinci: drop pointless static qualifier

2019-01-23 Thread YueHaibing
There is no need to have the 'gpio_unbanked' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/gpio/gpio-davinci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c

Re: [PATCH v6 1/2] PM-runtime: update accounting_timestamp only when enable

2019-01-23 Thread Vincent Guittot
On Wed, 23 Jan 2019 at 09:14, Ulf Hansson wrote: > > On Tue, 22 Jan 2019 at 15:24, Vincent Guittot > wrote: > > > > Initializing accounting_timestamp to something different from 0 during > > pm_runtime_init() doesn't make sense and put useless ordering constraint > > between > >

Re: Licensing of include/linux/hash.h

2019-01-23 Thread Domenico Andreoli
Ben Finney writes: > Domenico Andreoli writes: > > > the situation of dwarves-dfsg improved a lot over the weekend > > That's good to hear. What is the event you're referring to? Can you give > a URL to something that describes this change? Upstream (in CC) reacted to my request of

[PATCH -next] cpuset: drop pointless static qualifier in cpuset_hotplug_workfn

2019-01-23 Thread YueHaibing
There is no need to have the 'new_mems' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- kernel/cgroup/cpuset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index

Re: [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name

2019-01-23 Thread Boris Brezillon
On Wed, 23 Jan 2019 14:59:43 +0800 YueHaibing wrote: > In case DOC_CHIPID_G3, mtd->name should be freed in the > err handling path, which is alloced by kasprintf. > > Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support") > Signed-off-by: YueHaibing > --- > drivers/mtd/devices/docg3.c

Re: [PATCH v4 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller

2019-01-23 Thread Boris Brezillon
On Tue, 22 Jan 2019 12:11:37 +0530 Vignesh R wrote: > Cadence OSPI controller IP supports Octal IO (x8 IO lines), > It also has an integrated PHY. IP register layout is very > similar to existing QSPI IP except for additional bits to support Octal > and Octal DDR mode. Therefore, extend current

Re: [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.

2019-01-23 Thread Lukas Wunner
On Tue, Jan 22, 2019 at 06:13:11AM -0800, Ronald Tschalär wrote: > commit d6abe6df706c66d803e6dd4fe98c1b6b7f125a56 (drm/bridge: > sil_sii8620: do not have a dependency of RC_CORE) added a dependency on > INPUT. However, this causes problems with other drivers, in particular > an input driver that

[PATCH -next] pinctrl: sirf: drop pointless static qualifier in sirfsoc_gpio_probe

2019-01-23 Thread YueHaibing
There is no need to have the 'sgpio' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/pinctrl/sirf/pinctrl-sirf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/sirf/pinctrl-sirf.c

Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-01-23 Thread Steven Rostedt
On Fri, 18 Jan 2019 13:44:25 +0900 Masami Hiramatsu wrote: > Since commit 533059281ee5 ("tracing: probeevent: Introduce new > argument fetching code") dropped the $comm support from uprobe > events, this re-enables it. > > For $comm support, uses strlcpy() instead of strncpy_from_user() > to

Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator

2019-01-23 Thread Gustavo A. R. Silva
On 1/23/19 2:33 AM, Jiri Olsa wrote: > On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote: >> Notice that the use of the bitwise OR operator '|' always leads to >> true in this particular case, which seems a bit suspicious due to >> the context in which this expression is being

[PATCH -next] usb: host: drop pointless static qualifier

2019-01-23 Thread YueHaibing
There is no need to have the 'dummy_mask' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/usb/host/ehci-ps3.c | 2 +- drivers/usb/host/ohci-ps3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 1/2] irqchip: Add driver for Loongson-1 interrupt controller

2019-01-23 Thread Marc Zyngier
Hi Jiaxun, On Wed, 23 Jan 2019 06:23:36 +, Jiaxun Yang wrote: > > This controller appeared on Loongson-1 family MCUs > including Loongson-1B and Loongson-1C. > > Signed-off-by: Jiaxun Yang > --- > drivers/irqchip/Kconfig| 9 ++ > drivers/irqchip/Makefile | 1 + >

Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator

2019-01-23 Thread Jiri Olsa
On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote: > Notice that the use of the bitwise OR operator '|' always leads to > true in this particular case, which seems a bit suspicious due to > the context in which this expression is being used. > > Fix this by using bitwise AND

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-23 Thread Christian Borntraeger
On 23.01.2019 00:11, Paolo Bonzini wrote: > On 22/01/19 21:48, Greg Kroah-Hartman wrote: >>> This also brings the question: shall we move these counters out of debugfs >>> into something else? >> If you have code that relies on debugfs, yes, you need to move that out >> of debugfs because more

Re: [PATCH] i2c: imx: fix inconsistent IS_ERR and PTR_ERR

2019-01-23 Thread Wolfram Sang
On Tue, Jan 22, 2019 at 06:37:41PM -0600, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in i2c_imx_dma_request. > > The proper pointer to be passed as argument is dma->chan_tx. > > This bug was detected with the help of Coccinelle. > > Fixes: 5b3a23a3cc94 ("i2c: imx: notify

Re: Regression: spi: core: avoid waking pump thread from spi_sync instead run teardown delayed

2019-01-23 Thread Marek Szyprowski
Hi All On 2019-01-22 10:36, Geert Uytterhoeven wrote: > On Mon, Jan 14, 2019 at 4:36 PM Jon Hunter wrote: >> I have noticed that system suspend has started failing consistently on a >> couple Tegra boards over the last few days with the linux-next branch. >> The following error is seen on on

Re: [PATCH 1/2] kbuild: remove top-level built-in.a

2019-01-23 Thread Nicholas Piggin
Masahiro Yamada's on January 15, 2019 7:01 pm: > Hi Nicholas, > > > On Tue, Jan 15, 2019 at 5:07 PM Nicholas Piggin wrote: >> >> Masahiro Yamada's on January 14, 2019 1:27 pm: >> > The symbol table in the final archive is unneeded because it is passed >> > to the linker after the

Re: [PATCH v8 2/3] sched/fair: update scale invariance of PELT

2019-01-23 Thread Dietmar Eggemann
On 1/16/19 10:43 AM, Vincent Guittot wrote: [...] +static inline u64 rq_clock_pelt(struct rq *rq) +{ Doesn't this function need lockdep_assert_held(>lock); assert_clock_updated(rq); like rq_clock() and rq_clock_task()? Later to support commit cb42c9a3ebbb "sched/core: Add debugging

Re: [RFC PATCH] time/nohz: allow the boot CPU to be nohz_full

2019-01-23 Thread Nicholas Piggin
Frederic Weisbecker's on January 17, 2019 3:54 am: > On Mon, Jan 14, 2019 at 04:47:45PM +1000, Nicholas Piggin wrote: >> We have a supercomputer site testing nohz_full to reduce jitter with >> good results, but they want CPU0 to be nohz_full. That happens to be >> the boot CPU, which is disallowed

Re: [PATCH] power: domain: no need to check return value of debugfs_create functions

2019-01-23 Thread Ulf Hansson
On Wed, 23 Jan 2019 at 08:59, Greg Kroah-Hartman wrote: > > On Wed, Jan 23, 2019 at 08:44:36AM +0100, Ulf Hansson wrote: > > On Tue, 22 Jan 2019 at 16:23, Greg Kroah-Hartman > > wrote: > > > > > > When calling debugfs functions, there is no need to ever check the > > > return value. The

Re: [PATCH kernel] vfio-pci/nvlink2: Fix ancient gcc warnings

2019-01-23 Thread Geert Uytterhoeven
Hi Alex, On Wed, Jan 23, 2019 at 5:30 AM Alex Williamson wrote: > The below patch comes about from the build regressions and improvements > list you've sent out, but something doesn't add up that we'd be testing > with an old compiler where initialization with { 0 } generates a > "missing braces

Re: [PATCH] qspinlock: no need to check return value of debugfs_create functions

2019-01-23 Thread Peter Zijlstra
On Tue, Jan 22, 2019 at 04:21:43PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. So I've seen you do a fair number of

Re: [PATCH v6 1/2] PM-runtime: update accounting_timestamp only when enable

2019-01-23 Thread Ulf Hansson
On Tue, 22 Jan 2019 at 15:24, Vincent Guittot wrote: > > Initializing accounting_timestamp to something different from 0 during > pm_runtime_init() doesn't make sense and put useless ordering constraint > between > timekeeping_init() and pm_runtime_init(). > PM runtime should start accounting

[PATCH] time: Mark expected switch fall-throughs

2019-01-23 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: kernel/time/hrtimer.c: In function ‘hrtimer_fixup_activate’: ./include/linux/compiler.h:77:22: warning: this statement may fall through

Re: [PATCH v1 3/3] crypto: s5p: add AES support for Exynos5433

2019-01-23 Thread Krzysztof Kozlowski
On Tue, 22 Jan 2019 at 16:26, Kamil Konieczny wrote: > > Add AES crypto HW acceleration for Exynos5433, with the help of SlimSSS IP. > > Signed-off-by: Kamil Konieczny > --- > drivers/crypto/s5p-sss.c | 50 > 1 file changed, 46 insertions(+), 4

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-01-23 Thread Hans Verkuil
On 01/23/2019 06:27 AM, Tomasz Figa wrote: > On Tue, Jan 22, 2019 at 11:47 PM Hans Verkuil wrote: >> >> On 01/22/19 11:02, Tomasz Figa wrote: >>> On Mon, Nov 12, 2018 at 8:37 PM Hans Verkuil wrote: Hi Tomasz, A general note for the stateful and stateless patches: they

Re: [PATCH] kprobes: no need to check return value of debugfs_create functions

2019-01-23 Thread Masami Hiramatsu
On Wed, 23 Jan 2019 07:54:22 +0100 Greg Kroah-Hartman wrote: > On Wed, Jan 23, 2019 at 11:15:16AM +0900, Masami Hiramatsu wrote: > > On Tue, 22 Jan 2019 16:21:46 +0100 > > Greg Kroah-Hartman wrote: > > > > > When calling debugfs functions, there is no need to ever check the > > > return value.

Re: [PATCH net-next] bna: Mark expected switch fall-throughs

2019-01-23 Thread Gustavo A. R. Silva
On 1/23/19 2:03 AM, Sudarsana Reddy Kalluru wrote: > -Original Message- > From: Gustavo A. R. Silva [mailto:gust...@embeddedor.com] > Sent: 23 January 2019 13:23 > To: Rasesh Mody ; Sudarsana Kalluru > ; dept-gelinuxnic...@cavium.com; David S. > Miller > Cc: net...@vger.kernel.org;

[PATCH net-next] net/mlx4: Mark expected switch fall-through

2019-01-23 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/net/ethernet/mellanox/mlx4/eq.c: In function ‘mlx4_eq_int’: drivers/net/ethernet/mellanox/mlx4/mlx4.h:219:5: warning: this statement may

Re: [PATCH] virtio: support VIRTIO_F_ORDER_PLATFORM

2019-01-23 Thread Tiwei Bie
On Tue, Jan 22, 2019 at 11:04:29PM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 01:03:46AM +0800, Tiwei Bie wrote: > > This patch introduces the support for VIRTIO_F_ORDER_PLATFORM. > > When this feature is negotiated, driver will use the barriers > > suitable for hardware devices. >

RE: [PATCH net-next] bna: Mark expected switch fall-throughs

2019-01-23 Thread Sudarsana Reddy Kalluru
-Original Message- From: Gustavo A. R. Silva [mailto:gust...@embeddedor.com] Sent: 23 January 2019 13:23 To: Rasesh Mody ; Sudarsana Kalluru ; dept-gelinuxnic...@cavium.com; David S. Miller Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva Subject: [PATCH

[PATCH 2/3] firmware: imx: enable imx scu general irq function

2019-01-23 Thread Anson Huang
The System Controller Firmware (SCFW) controls RTC, thermal and WDOG etc., these resources' interrupt function are managed by SCU. When any IRQ pending, SCU will notify Linux via MU general interrupt channel #3, and Linux kernel needs to call SCU APIs to get IRQ status and notify each module to

[PATCH 3/3] arm64: dts: freescale: imx8qxp: enable scu general irq channel

2019-01-23 Thread Anson Huang
On i.MX8QXP, SCU uses MU1 general interrupt channel #3 to notify user for IRQs of RTC alarm, thermal alarm and WDOG etc., mailbox RX doorbell mode is used for this function, this patch adds support for it. Signed-off-by: Anson Huang --- arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 -- 1

[PATCH 1/3] dt-bindings: fsl: scu: add general interrupt support

2019-01-23 Thread Anson Huang
Add scu general interrupt function support. Signed-off-by: Anson Huang --- .../devicetree/bindings/arm/freescale/fsl,scu.txt | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt

Re: [PATCH v1 2/3] dt-bindings: crypto: document Exynos5433 SlimSSS

2019-01-23 Thread Krzysztof Kozlowski
On Tue, 22 Jan 2019 at 16:26, Kamil Konieczny wrote: > > Document DT bindings for crypto Samsung Exynos5433 SlimSSS (Slim Security > SubSystem) IP. > > Signed-off-by: Kamil Konieczny > --- > .../devicetree/bindings/crypto/samsung-sss.txt | 13 ++--- > 1 file changed, 10

Re: [PATCH] power: domain: no need to check return value of debugfs_create functions

2019-01-23 Thread Greg Kroah-Hartman
On Wed, Jan 23, 2019 at 08:44:36AM +0100, Ulf Hansson wrote: > On Tue, 22 Jan 2019 at 16:23, Greg Kroah-Hartman > wrote: > > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something

<    5   6   7   8   9   10