Re: [RFC][Patch v8 6/7] KVM: Enables the kernel to isolate and report free pages

2019-02-05 Thread Michael S. Tsirkin
On Mon, Feb 04, 2019 at 03:18:53PM -0500, Nitesh Narayan Lal wrote: > This patch enables the kernel to scan the per cpu array and > compress it by removing the repetitive/re-allocated pages. > Once the per cpu array is completely filled with pages in the > buddy it wakes up the kernel per cpu

Re: [PATCH 1/9] iommu/vt-d: Allow interrupts from the entire bus for aliased devices

2019-02-05 Thread Logan Gunthorpe
On 2019-02-05 12:19 p.m., Jacob Pan wrote: > On Fri, 1 Feb 2019 10:27:29 -0700 > Logan Gunthorpe wrote: > >> On 2019-02-01 9:44 a.m., Joerg Roedel wrote: >>> On Thu, Jan 31, 2019 at 11:56:48AM -0700, Logan Gunthorpe wrote: @@ -394,6 +402,10 @@ static int set_msi_sid(struct irte *irte,

Re: Linux Kernel Regression: HAPS quirk breaks PCIe on i.MX6QP

2019-02-05 Thread Thinh Nguyen
Hi Bjorn, Bjorn Helgaas wrote: > On Fri, Feb 01, 2019 at 08:27:00PM +, Thinh Nguyen wrote: >> Lukas Wunner wrote: >>> On Thu, Jan 31, 2019 at 11:46:23PM +, Thinh Nguyen wrote: --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -629,6 +629,9 @@ static void

Re: [PATCH] vfio: platform: reset: fix up include directives to remove ccflags-y

2019-02-05 Thread Alex Williamson
On Wed, 30 Jan 2019 11:52:31 +0900 Masahiro Yamada wrote: > For the include directive with double-quotes "", the preprocessor > searches the header in the relative path to the current file. > > Fix them up, and remove the header search path option. > > Signed-off-by: Masahiro Yamada > --- >

linux-next: Fixes tag needs some work in the userns tree

2019-02-05 Thread Stephen Rothwell
Hi Eric, In commit a692933a8769 ("signal: Always attempt to allocate siginfo for SIGSTOP") Fixes tag Fixes: 6dfc88977e42 ("[PATCH] shared thread signals") has these problem(s): - Target SHA1 does not exist -- Cheers, Stephen Rothwell pgp7RLx8wG44L.pgp Description: OpenPGP digital

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-05 Thread Tony Krowiak
On 2/4/19 5:15 AM, Harald Freudenberger wrote: On 01.02.19 15:35, Cornelia Huck wrote: On Thu, 31 Jan 2019 18:50:57 -0500 Tony Krowiak wrote: On 1/31/19 4:55 AM, Cornelia Huck wrote: On Wed, 30 Jan 2019 12:48:46 -0500 Tony Krowiak wrote: Two questions: - Does the event cover _any_ change

[PATCH 2/2] selftests: tpm2: Extend tests to cover partial reads

2019-02-05 Thread Tadeusz Struk
Three new tests added: 1. Send get random cmd, read header in 1st read, read the rest in second read - expect success 2. Send get random cmd, read only part of the response, send another get random command, read the response - expect success 3. Send get random cmd followed by another get

[PATCH 1/2] selftests: tpm2: Open tpm dev in unbuffered mode

2019-02-05 Thread Tadeusz Struk
In order to have control over how many bytes are read or written the device needs to be opened in unbuffered mode. Signed-off-by: Tadeusz Struk --- tools/testing/selftests/tpm2/tpm2.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] build_bug.h: add wrapper for _Static_assert

2019-02-05 Thread Luc Van Oostenryck
On Tue, Feb 05, 2019 at 10:53:31AM +0100, Rasmus Villemoes wrote: > On 05/02/2019 00.12, Andrew Morton wrote: > >> > >> It would be (very) nice to actually use this macro in a few places so > >> it gets its build testing while in -next. > > > > ie, just about every BUILD_BUG_ON in mm/ could use

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-05 Thread Tony Krowiak
On 2/4/19 5:01 AM, Sebastian Ott wrote: On Thu, 31 Jan 2019, Tony Krowiak wrote: On 1/30/19 1:32 PM, Sebastian Ott wrote: On Wed, 30 Jan 2019, Tony Krowiak wrote: +++ b/drivers/s390/cio/chsc.h @@ -9,6 +9,7 @@ #include #include #include +#include This should be moved to chsc.c

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-05 Thread Tony Krowiak
On 2/4/19 5:06 AM, Harald Freudenberger wrote: On 01.02.19 16:38, Tony Krowiak wrote: On 2/1/19 4:01 AM, Heiko Carstens wrote: On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote: On 1/30/19 1:32 PM, Sebastian Ott wrote: On Wed, 30 Jan 2019, Tony Krowiak wrote: +#if

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Heiner Kallweit
On 05.02.2019 21:18, Joe Perches wrote: > On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote: >> >> On 02/05/2019 10:42 AM, Joe Perches wrote: >>> It's declared after a pointer so it is already is 2 byte aligned. >>> >>> A lot of drivers wouldn't work otherwise. >> >> Maybe these drivers are

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Eric Dumazet
On 02/05/2019 12:18 PM, Joe Perches wrote: > I still think adding __align() is unnecessary here unless > it follows something like a bool or a u8. This would be some historical side effect, and we do not want to rely on that. A security feature could in fact ask a compiler to perform random

[PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug()

2019-02-05 Thread Laurent Vivier
resize_hpt_for_hotplug() reports a warning when it cannot increase the hash page table ("Unable to resize hash page table to target order") but this is not blocking and can make user thinks something has not worked properly. As we move the message to the debug area, report again the ENODEV error.

Re: [PATCH v3 1/4] staging: iio: ad7780: add gain & filter gpio support

2019-02-05 Thread Renato Lui Geh
Hi Peter, Thank you for the review! Comments inline. Renato On 02/05, Peter Meerwald-Stadler wrote: On Tue, 5 Feb 2019, Renato Lui Geh wrote: Previously, the AD7780 driver only supported gpio for the 'powerdown' pin. This commit adds suppport for the 'gain' and 'filter' pin. comments

linux-next: Fixes tag needs some work in the scsi-fixes tree

2019-02-05 Thread Stephen Rothwell
Hi Martin, In commit bb61b843ffd4 ("scsi: cxlflash: Prevent deadlock when adapter probe fails") Fixes tag Fixes: c21e0bbfc485("cxlflash: Base support for IBM CXL Flash Adapter") has these problem(s): - missing space between the SHA1 and the subject -- Cheers, Stephen Rothwell

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Joe Perches
On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote: > > On 02/05/2019 10:42 AM, Joe Perches wrote: > > It's declared after a pointer so it is already is 2 byte aligned. > > > > A lot of drivers wouldn't work otherwise. > > Maybe these drivers are only used on arches where this does not

Re: mm: race in put_and_wait_on_page_locked()

2019-02-05 Thread Hugh Dickins
On Tue, 5 Feb 2019, Linus Torvalds wrote: > On Mon, Feb 4, 2019 at 8:43 PM Hugh Dickins wrote: > > > > Something I shall not be doing, is verifying the correctness of the > > low-level get_page_unless_zero() versus page_ref_freeze() protocol > > on arm64 and power - nobody has reported on x86,

Re: [PATCH 1/1] Lib: sort.c: replaced heap sort algorithm with introspective sort

2019-02-05 Thread Andrew Morton
On Tue, 5 Feb 2019 21:24:13 +0300 Andrey Abramov wrote: > Replaced heap sort algorithm with faster introspective sort algorithm. > > Signed-off-by: Andrey Abramov > --- > v1: The introspective sort algorithm is faster the heap sort (for example on > my machine on a 100MB of random data it

RE: [PATCH 2/2] arc: hsdk_defconfig: enable CONFIG_ARC_UBOOT_SUPPORT

2019-02-05 Thread Kevin Hilman
Alexey Brodkin writes: > Hi Vineet, Corentin, > >> -Original Message- >> From: Vineet Gupta >> Sent: Tuesday, February 5, 2019 7:42 PM >> To: Eugeniy Paltsev ; cla...@baylibre.com >> Cc: linux-kernel@vger.kernel.org; alexey.brod...@synopsys.com; >> khil...@baylibre.com; linux-snps- >>

Re: [PATCH v3] selftests: add TPM 2.0 tests

2019-02-05 Thread James Morris
On Tue, 5 Feb 2019, Jarkko Sakkinen wrote: > On Mon, Feb 04, 2019 at 03:16:40PM +0200, Jarkko Sakkinen wrote: > > Added the tests that I've been using for testing TPM 2.0 functionality > > for a long time but have been out-of-tree so far, residing in > > > >

Re: Linux Kernel Regression: HAPS quirk breaks PCIe on i.MX6QP

2019-02-05 Thread Bjorn Helgaas
On Fri, Feb 01, 2019 at 08:27:00PM +, Thinh Nguyen wrote: > Lukas Wunner wrote: > > On Thu, Jan 31, 2019 at 11:46:23PM +, Thinh Nguyen wrote: > >> --- a/drivers/pci/quirks.c > >> +++ b/drivers/pci/quirks.c > >> @@ -629,6 +629,9 @@ static void quirk_synopsys_haps(struct pci_dev *pdev) > >>

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Eric Dumazet
On 02/05/2019 10:42 AM, Joe Perches wrote: > > It's declared after a pointer so it is already is 2 byte aligned. > > A lot of drivers wouldn't work otherwise. Maybe these drivers are only used on arches where this does not matter.

Re: [PATCH 09/12] btrfs: change set_level() to bound the level passed in

2019-02-05 Thread Dennis Zhou
On Tue, Feb 05, 2019 at 08:54:15PM +0100, David Sterba wrote: > On Tue, Feb 05, 2019 at 02:32:54PM -0500, Dennis Zhou wrote: > > On Tue, Feb 05, 2019 at 08:06:37PM +0100, David Sterba wrote: > > > On Mon, Feb 04, 2019 at 03:20:05PM -0500, Dennis Zhou wrote: > > > > -unsigned int

[PATCH v3] pinctrl: samsung: Remove legacy API for handling external wakeup interrupts mask

2019-02-05 Thread Krzysztof Kozlowski
Remove the legacy, ugly API of exposing the static value of external wakeup interrupts mask, because all arch-machine users where converted to use generic implementation from pinctrl driver. Signed-off-by: Krzysztof Kozlowski Cc: Tomasz Figa Cc: Sylwester Nawrocki Acked-by: Tomasz Figa ---

Re: [PATCH v3 1/4] staging: iio: ad7780: add gain & filter gpio support

2019-02-05 Thread Peter Meerwald-Stadler
On Tue, 5 Feb 2019, Renato Lui Geh wrote: > Previously, the AD7780 driver only supported gpio for the 'powerdown' > pin. This commit adds suppport for the 'gain' and 'filter' pin. comments below > Signed-off-by: Renato Lui Geh > Signed-off-by: Giuliano Belinassi > Co-developed-by: Giuliano

Re: [PATCH v15] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2019-02-05 Thread Bjorn Helgaas
On Tue, Feb 5, 2019 at 6:06 AM Wolfram Sang wrote: > > +03:00.7 Non-VGA unclassified device: Advanced Micro Devices, Inc. [AMD] > > Device > > + 15e6 > > + > > +in your 'lspci -v', then this driver is for your device. > >

[RFC v2] usb: xhci: add Immediate Data Transfer support

2019-02-05 Thread Nicolas Saenz Julienne
Immediate data transfers (IDT) allow the HCD to copy small chunks of data (up to 8bytes) directly into its output transfer TRBs. This avoids the somewhat expensive DMA mappings that are performed by default on most URBs submissions. In the case an URB was suitable for IDT. The data is directly

Re: [PATCH 09/12] btrfs: change set_level() to bound the level passed in

2019-02-05 Thread David Sterba
On Tue, Feb 05, 2019 at 02:32:54PM -0500, Dennis Zhou wrote: > On Tue, Feb 05, 2019 at 08:06:37PM +0100, David Sterba wrote: > > On Mon, Feb 04, 2019 at 03:20:05PM -0500, Dennis Zhou wrote: > > > -unsigned int btrfs_compress_str2level(const char *str) > > > +unsigned int

Re: [PATCH 3/3] KVM: x86: fix use of L1 MMIO areas in nested guests

2019-02-05 Thread Jim Mattson
On Thu, Aug 17, 2017 at 9:37 AM Paolo Bonzini wrote: > > There is currently some confusion between nested and L1 GPAs. The > assignment to "direct" in kvm_mmu_page_fault tries to fix that, but > it is not enough. What this patch does is fence off the MMIO cache > completely when using shadow

Re: [PATCHv3 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning

2019-02-05 Thread Anand Moon
hi Martin, On Tue, 5 Feb 2019 at 02:19, Martin Blumenstingl wrote: > > Hi Anand, > > On Mon, Feb 4, 2019 at 9:04 PM Anand Moon wrote: > [...] > > > > @@ -36,6 +43,8 @@ > > > > regulator-min-microvolt = <500>; > > > > regulator-max-microvolt = <500>; > > >

Re: [PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-02-05 Thread Nikolay Aleksandrov
On 05/02/2019 04:58, Callum Sinclair wrote: > Currently the only way to clear the mfc cache was to delete the entries > one by one using the MRT_DEL_MFC socket option or to destroy and > recreate the socket. > > Create a new socket option which will clear the multicast forwarding > cache on the

Re: [RFC PATCH 1/4] glibc: Perform rseq(2) registration at C startup and thread creation (v7)

2019-02-05 Thread Mathieu Desnoyers
- On Feb 4, 2019, at 4:28 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > Register rseq(2) TLS for each thread (including main), and unregister > for each thread (excluding main). "rseq" stands for Restartable > Sequences. > > See the rseq(2) man page proposed here: >

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-05 Thread Bjorn Andersson
On Tue 05 Feb 02:52 PST 2019, Alim Akhtar wrote: > Hi Bjorn, > > On 05/02/19 11:57 AM, Bjorn Andersson wrote: > > On Mon 04 Feb 20:58 PST 2019, Alim Akhtar wrote: > > > >> Hi Marc, > >> > >> On 04/02/19 11:12 PM, Marc Gonzalez wrote: > >>> This reverts commit

Re: [PATCH v3 2/3] Input: add new vibrator driver for various MSM SOCs

2019-02-05 Thread Dmitry Torokhov
Hi Brian, On Wed, Oct 24, 2018 at 09:29:36PM -0400, Brian Masney wrote: > This patch adds a new vibrator driver that supports various Qualcomm > MSM SOCs. Driver was tested on a LG Nexus 5 (hammerhead) phone. > ... > + > +#define msm_vibrator_write(msm_vibrator, offset, value) \ > +

Re: [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon

2019-02-05 Thread James Bottomley
On Mon, 2019-02-04 at 15:37 +0200, Jarkko Sakkinen wrote: > diff --git a/drivers/char/tpm/tpm_i2c_infineon.c > b/drivers/char/tpm/tpm_i2c_infineon.c > index 9086edc9066b..b9d5a1dda8d2 100644 > --- a/drivers/char/tpm/tpm_i2c_infineon.c > +++ b/drivers/char/tpm/tpm_i2c_infineon.c [...] > @@ -527,8

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-05 Thread Jeffrey Hugo
On 2/5/2019 11:19 AM, Evan Green wrote: On Tue, Feb 5, 2019 at 9:52 AM Marc Gonzalez wrote: On 05/02/2019 18:24, Marc Gonzalez wrote: /*** system hangs here for several seconds, then reboots ***/ Silly me. The system crashes in ufshcd_dump_regs() which is a bug I fixed myself. Once I

[PATCH] sh: migor: Include missing dma-mapping header

2019-02-05 Thread Jacopo Mondi
Since the removal of the stale soc_camera headers, Migo-R board fails to build due to missing dma-mapping include directive. Include missing dma-mapping.h header in Migo-R board file to fix the build error. Fixes: a50c7738e8ae ("media: sh: migor: Remove stale soc_camera include") Signed-off-by:

Re: [PATCH 09/12] btrfs: change set_level() to bound the level passed in

2019-02-05 Thread Dennis Zhou
On Tue, Feb 05, 2019 at 08:06:37PM +0100, David Sterba wrote: > On Mon, Feb 04, 2019 at 03:20:05PM -0500, Dennis Zhou wrote: > > -unsigned int btrfs_compress_str2level(const char *str) > > +unsigned int btrfs_compress_str2level(unsigned int type, const char *str) > > { > > - if (strncmp(str,

Re: [PATCH 0/6] RFC v2: mm: gup/dma tracking

2019-02-05 Thread Christopher Lameter
On Mon, 4 Feb 2019, Ira Weiny wrote: > On Mon, Feb 04, 2019 at 05:14:19PM +, Christopher Lameter wrote: > > Frankly I still think this does not solve anything. > > > > Concurrent write access from two sources to a single page is simply wrong. > > You cannot make this right by allowing long

[PATCH v2 12/12] btrfs: add zstd compression level support

2019-02-05 Thread Dennis Zhou
>From 0d8684d1d7b18dfa9d5bc9c74033c6c3b6fecd92 Mon Sep 17 00:00:00 2001 From: Dennis Zhou Date: Sat, 19 Jan 2019 18:51:39 -0800 Zstd compression requires different amounts of memory for each level of compression. The prior patches implemented indirection to allow for each compression type to

Re: [PATCH v3 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels

2019-02-05 Thread Bjorn Andersson
On Tue 05 Feb 11:00 PST 2019, Nicolas Dechesne wrote: > Hey Mani, > > thanks for sending this out, it should have been just like that in the > first place ;) > Thanks Nico for the confirmation, I will queue this for v5.2 Regards, Bjorn > On Fri, Dec 21, 2018 at 3:36 AM Manivannan Sadhasivam

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Joe Perches
On Tue, 2019-02-05 at 11:14 -0800, David Miller wrote: > From: Joe Perches > Date: Tue, 05 Feb 2019 10:42:54 -0800 > > > On Mon, 2019-02-04 at 19:20 -0800, David Miller wrote: > >> From: Thierry Reding > >> Date: Mon, 4 Feb 2019 17:42:13 +0100 > >> > >> > @@ -7316,7 +7325,7 @@ static int

Re: [PATCH 1/9] iommu/vt-d: Allow interrupts from the entire bus for aliased devices

2019-02-05 Thread Jacob Pan
On Fri, 1 Feb 2019 10:27:29 -0700 Logan Gunthorpe wrote: > On 2019-02-01 9:44 a.m., Joerg Roedel wrote: > > On Thu, Jan 31, 2019 at 11:56:48AM -0700, Logan Gunthorpe wrote: > >> @@ -394,6 +402,10 @@ static int set_msi_sid(struct irte *irte, > >> struct pci_dev *dev) set_irte_sid(irte,

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread David Miller
From: Joe Perches Date: Tue, 05 Feb 2019 10:42:54 -0800 > On Mon, 2019-02-04 at 19:20 -0800, David Miller wrote: >> From: Thierry Reding >> Date: Mon, 4 Feb 2019 17:42:13 +0100 >> >> > @@ -7316,7 +7325,7 @@ static int rtl_get_ether_clk(struct rtl8169_private >> > *tp) >> > static int

Re: [PATCH 2/2] selftests: firmware: add CONFIG_FW_LOADER_USER_HELPER_FALLBACK to config

2019-02-05 Thread Luis Chamberlain
On Mon, Feb 04, 2019 at 08:41:50PM -0600, Dan Rue wrote: > On Mon, Feb 04, 2019 at 05:39:57PM -0600, Luis Chamberlain wrote: > > On Thu, Nov 29, 2018 at 8:31 PM Luis Chamberlain wrote: > > > > > > On Mon, Nov 26, 2018 at 09:12:16PM -0600, Dan Rue wrote: > > > >

Re: [RFC v1 0/3] Address potential user-after-free on module unload

2019-02-05 Thread Sven Van Asbroeck
On Tue, Feb 5, 2019 at 1:43 PM Greg KH wrote: > > > It really should happen when the device is removed (if it is a driver > that binds to a device.) Absolutely. That's why I'm advocating adding a devm_init_work(), which will take care of this automatically. But it's of course not universally

Re: [PATCH v3] mtd: rawnand: atmel: fix possible object reference leak

2019-02-05 Thread Miquel Raynal
Hi Wen, For the next version can you please post a series with the three commits which are fixing the same reference leak? No need to add a cover letter though. Wen Yang wrote on Tue, 5 Feb 2019 14:32:41 +: > of_find_device_by_node() takes a reference to the struct device > when it finds a

Re: [PATCH] i2c: core-smbus: don't trace smbus_reply data on errors

2019-02-05 Thread Wolfram Sang
> > > Hmm, instead of tracing nothing, as this is already a "conditional > > > trace event", why not add to that condition: > > > > > > TP_CONDITION(res >= 0 && read_write == I2C_SMBUS_READ), > > > > > > Unless you want to still trace some data on failure. > > > > John, any comment to this?

Re: [PATCH 09/12] btrfs: change set_level() to bound the level passed in

2019-02-05 Thread David Sterba
On Mon, Feb 04, 2019 at 03:20:05PM -0500, Dennis Zhou wrote: > -unsigned int btrfs_compress_str2level(const char *str) > +unsigned int btrfs_compress_str2level(unsigned int type, const char *str) > { > - if (strncmp(str, "zlib", 4) != 0) > + unsigned int level; > + int ret; > + > +

RE: [PATCH 10/10] acpi: bgrt: parse BGRT to obtain BMP address before it gets clobbered

2019-02-05 Thread Ghannam, Yazen
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Ard Biesheuvel > Sent: Saturday, February 2, 2019 3:41 AM > To: linux-...@vger.kernel.org; Ingo Molnar ; Thomas > Gleixner > Cc: Ard Biesheuvel ; linux-kernel@vger.kernel.org; > AKASHI

Re: [PATCH] mtd: rawnand: meson: Fix linking error on 32-bit platforms

2019-02-05 Thread Miquel Raynal
Hi Nathan, Nathan Chancellor wrote on Tue, 29 Jan 2019 14:46:57 -0700: > On arm little endian allyesconfig: > > ld.lld: error: undefined symbol: __aeabi_uldivmod > >>> referenced by meson_nand.c > >>> mtd/nand/raw/meson_nand.o:(meson_nfc_setup_data_interface) in archive >

Re: [PATCH -next] mtd: rawnand: stm32_fmc2: Make some functions static

2019-02-05 Thread Miquel Raynal
Hi Yue, YueHaibing wrote on Wed, 30 Jan 2019 18:09:08 +0800: > Fixes the following sparse warning: > drivers/mtd/nand/raw/stm32_fmc2_nand.c:1228:6: warning: symbol > 'stm32_fmc2_read_data' was not declared. Should it be static? > drivers/mtd/nand/raw/stm32_fmc2_nand.c:1275:6: warning: symbol

Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init

2019-02-05 Thread Miquel Raynal
Hi Colin, Colin King wrote on Tue, 29 Jan 2019 10:57:57 +: > From: Colin Ian King > > The call to meson_chip_buffer_init is not assigning ret, however, ret > is being checked for failure. Fix this by adding in the missing assignment. > > Fixes: 2d570b34b41a ("mtd: rawnand: meson: add

Re: [PATCH][next] mtd: rawnand: meson:: make several functions static

2019-02-05 Thread Miquel Raynal
Hi Colin, Colin King wrote on Tue, 29 Jan 2019 12:44:29 +: > From: Colin Ian King > > There are several functions that are local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings. > > Signed-off-by: Colin Ian King Merged in

Re: [REGRESSION 4.20-rc1] 45975c7d21a1 ("rcu: Define RCU-sched API in terms of RCU for Tree RCU PREEMPT builds")

2019-02-05 Thread Aaro Koskinen
Hi, On Tue, Feb 05, 2019 at 09:05:59PM +0800, Tom Li wrote: > On Tue, Feb 05, 2019 at 11:58:09AM +0200, Aaro Koskinen wrote: > > Can you try below fix? It works on my Loongson. > > Hello Aaro, thanks for your response. But in case you've missed > the original thread, please check it at: > >

Re: [PATCH v3 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels

2019-02-05 Thread Nicolas Dechesne
Hey Mani, thanks for sending this out, it should have been just like that in the first place ;) On Fri, Dec 21, 2018 at 3:36 AM Manivannan Sadhasivam wrote: > > On Mon, Oct 29, 2018 at 03:12:45PM +0530, Manivannan Sadhasivam wrote: > > For all 96Boards, the following standard is used for

Re: [PATCH] staging: vt6656: Use the correct style for SPDX license Identifier

2019-02-05 Thread Joe Perches
On Tue, 2019-02-05 at 19:44 +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 05, 2019 at 08:36:24PM +0530, Nishad Kamdar wrote: > > This patch corrects the style for SPDX license Identifier in mac.h > > by using "/* */" in place of "//" as per Linux kernel licensing rules. > > Issue found by

[PATCH v3 6/8] scsi: ufs: qcom: Expose the reset controller for PHY

2019-02-05 Thread Evan Green
Expose a reset controller that the phy will later use to control its own PHY reset in the UFS controller. This will enable the combining of PHY init functionality into a single function. Signed-off-by: Evan Green --- Note: The remaining changes in this series need this change, since the PHYs

[PATCH 2/2] power: supply: gpio-charger: Add support for charger status.

2019-02-05 Thread Artur Rojek
Introduce optional support of POWER_SUPPLY_PROP_STATUS for chargers which provide charging status GPIO. Signed-off-by: Artur Rojek --- drivers/power/supply/gpio-charger.c | 53 +++-- 1 file changed, 42 insertions(+), 11 deletions(-) diff --git

[PATCH v3 5/8] arm64: dts: msm8996: Add UFS PHY reset controller

2019-02-05 Thread Evan Green
Add the reset controller for the UFS controller, and wire it up so that the UFS PHY can initialize itself without relying on implicit sequencing between the two drivers. Signed-off-by: Evan Green Reviewed-by: Stephen Boyd --- Changes in v3: None Changes in v2: None

[PATCH v3 8/8] phy: ufs-qcom: Refactor all init steps into phy_poweron

2019-02-05 Thread Evan Green
The phy code was using implicit sequencing between the PHY driver and the UFS driver to implement certain hardware requirements. Specifically, the PHY reset register in the UFS controller needs to be deasserted before serdes start occurs in the PHY. Before this change, the code was doing this by

Re: mm: race in put_and_wait_on_page_locked()

2019-02-05 Thread Hugh Dickins
On Tue, 5 Feb 2019, Qian Cai wrote: > > >> Cai, can you please check if you can reproduce this issue in your > >> environment with 5.0-rc5? > > > > Yes, please do - practical confirmation more convincing than my certainty. > > Indeed, I am no longer be able to reproduce this anymore. Great,

[PATCH 1/2] dt-bindings: power: supply: gpio-charger: Add status-gpios property

2019-02-05 Thread Artur Rojek
Add documentation for the "status-gpios" property. Signed-off-by: Artur Rojek --- .../devicetree/bindings/power/supply/gpio-charger.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt

[PATCH v3 4/8] arm64: dts: sdm845: Add UFS PHY reset

2019-02-05 Thread Evan Green
Wire up the reset controller in the Qcom UFS controller for the PHY. This will be used to toggle PHY reset during initialization of the PHY. Signed-off-by: Evan Green Reviewed-by: Stephen Boyd --- This commit is based atop the series at [1]. Patches 1 and 2 of that series have landed, but 3, 4,

[PATCH v3 7/8] phy: qcom: Utilize UFS reset controller

2019-02-05 Thread Evan Green
Move the PHY reset from ufs-qcom into the respective PHYs. This will allow us to merge the two phases of UFS PHY initialization. Signed-off-by: Evan Green --- Changes in v3: - Refactored to move reset control in a single commit (Stephen) - Use no_pcs_sw_reset as an indicator of UFS reset in

[PATCH v3 3/8] dt-bindings: phy: qcom-ufs: Add resets property

2019-02-05 Thread Evan Green
Add a resets property to the PHY that represents the PHY reset register in the UFS controller itself. This better describes the complete specification of the PHY, and allows the PHY to perform its initialization in a single function, rather than relying on back-channel sequencing of initialization

[PATCH v3 1/8] dt-bindings: ufs: Add #reset-cells for Qualcomm controllers

2019-02-05 Thread Evan Green
Enable Qualcomm UFS controllers to expose the PHY reset via a reset controller. Signed-off-by: Evan Green Reviewed-by: Rob Herring Reviewed-by: Stephen Boyd --- Fixing up this aspect of it made me notice that this patch [1] hasn't landed yet. It really ought to. [1]

[PATCH v3 0/8] phy: qcom-ufs: Enable regulators to be off in suspend

2019-02-05 Thread Evan Green
The goal with this series is to enable shutting off regulators that power UFS during system suspend. In "the good life" version of this, we'd just disable the regulators in phy_poweroff() and be done with it. Unfortunately, that's not symmetric, as regulators are not enabled during phy_poweron().

[PATCH v3 2/8] dt-bindings: phy-qcom-qmp: Add UFS PHY reset

2019-02-05 Thread Evan Green
Add a required reset to the SDM845 UFS phy to express the PHY reset bit inside the UFS controller register space. Before this change, this reset was not expressed in the DT, and the driver utilized two different callbacks (phy_init and phy_poweron) to implement a two-phase initialization procedure

Re: linux-next: Fixes tag needs some work in the origin tree

2019-02-05 Thread Palmer Dabbelt
On Sat, 02 Feb 2019 13:33:10 PST (-0800), Stephen Rothwell wrote: [Just a reminder for the future.] Hi all, In commit 2bb10639f12c ("RISC-V: fix bad use of of_node_put") Fixes tag Fixes: 94f9bf118f ("RISC-V: Fix of_node_* refcount") has these problem(s): - SHA1 should be at least 12

Re: [PATCH v3 8/9] mtd: rawnand: ingenic: Add support for the JZ4725B

2019-02-05 Thread Miquel Raynal
Hi Paul, [...] > >> + > >> +static void jz4725b_bch_init(struct ingenic_ecc *bch, > >> + struct ingenic_ecc_params *params, bool encode) > > > > I don't know the IP but 'encode' looks strange, what is it supposed to > > mean? > > It is used to toggle between

Re: [PATCH] x86/ima: require signed kernel modules

2019-02-05 Thread Mimi Zohar
On Tue, 2019-02-05 at 12:32 -0600, Seth Forshee wrote: > On Tue, Feb 05, 2019 at 11:47:24AM -0500, Mimi Zohar wrote: > > Hi Seth, > > > > On Tue, 2019-02-05 at 09:18 -0600, Seth Forshee wrote: > > > On Thu, Jan 31, 2019 at 02:18:59PM -0500, Mimi Zohar wrote: > > > > Require signed kernel modules

Re: [PATCH net-next v3] net: dsa: mv88e6xxx: Prevent suspend to RAM

2019-02-05 Thread Miquel Raynal
Hi Vivien, Vivien Didelot wrote on Tue, 5 Feb 2019 11:28:57 -0500: > Hi Miquel, > > On Tue, 5 Feb 2019 12:07:28 +0100, Miquel Raynal > wrote: > > > +/* There is no suspend to RAM support at DSA level yet, the switch > > configuration > > + * would be lost after a power cycle so prevent it

Re: [PATCH] component: Add documentation

2019-02-05 Thread Daniel Vetter
On Tue, Feb 05, 2019 at 04:49:02PM +, Russell King - ARM Linux admin wrote: > On Tue, Feb 05, 2019 at 05:21:07PM +0100, Daniel Vetter wrote: > > Someone owes me a beer ... > > I find that deeply offensive - it is clearly directed at me personally > as author of the component helper. > >

Re: [PATCH] staging: vt6656: Use the correct style for SPDX license Identifier

2019-02-05 Thread Greg Kroah-Hartman
On Tue, Feb 05, 2019 at 08:36:24PM +0530, Nishad Kamdar wrote: > This patch corrects the style for SPDX license Identifier in mac.h > by using "/* */" in place of "//" as per Linux kernel licensing rules. > Issue found by checkpatch. > > Signed-off-by: Nishad Kamdar > --- >

Re: [RFC v1 0/3] Address potential user-after-free on module unload

2019-02-05 Thread Greg KH
On Tue, Feb 05, 2019 at 10:22:50AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 5, 2019 at 9:57 AM Kees Cook wrote: > > > > > > Can a Coccinelle script get written to find module-use of the non-devm > > work init? > > My thoughts exactly ! But sadly I'm not a Coccinelle expert. I did > look

Re: [RFC PATCH 0/4] kvm: Report unused guest pages to host

2019-02-05 Thread Alexander Duyck
On Tue, 2019-02-05 at 12:25 -0500, Nitesh Narayan Lal wrote: > On 2/4/19 1:15 PM, Alexander Duyck wrote: > > This patch set provides a mechanism by which guests can notify the host of > > pages that are not currently in use. Using this data a KVM host can more > > easily balance memory workloads

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Joe Perches
On Mon, 2019-02-04 at 19:20 -0800, David Miller wrote: > From: Thierry Reding > Date: Mon, 4 Feb 2019 17:42:13 +0100 > > > @@ -7316,7 +7325,7 @@ static int rtl_get_ether_clk(struct rtl8169_private > > *tp) > > static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id > > *ent)

Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-02-05 Thread Bjorn Andersson
On Thu 31 Jan 09:33 PST 2019, Srinivas Kandagatla wrote: > On 31/01/2019 16:05, Bjorn Andersson wrote: > > Sure, but we want the design to allow for that still, either in future > > upstream or by additional downstream code. > > > Yes, I agree, I don't have solution for this ATM. > It will be

Re: [PATCH net-next 0/3] nixge: Fixed-link support

2019-02-05 Thread David Miller
From: Moritz Fischer Date: Mon, 4 Feb 2019 09:30:37 -0800 > From: Moritz Fischer > > This series adds fixed-link support to nixge. > > The first patch corrects the binding to correctly reflect > hardware that does not come with MDIO cores instantiated. > > The second patch adds fixed link

[PATCH] ARCv2: support manual regfile save on interrupts

2019-02-05 Thread Vineet Gupta
There's a hardware bug which affects the HSDK platform, triggered by micro-ops for auto-saving regfile on taken interrupt. The workaround is to inhibit autosave. Signed-off-by: Vineet Gupta --- arch/arc/Kconfig | 8 ++ arch/arc/include/asm/entry-arcv2.h | 54

Re: [RFC v1 0/3] Address potential user-after-free on module unload

2019-02-05 Thread Greg KH
On Tue, Feb 05, 2019 at 02:57:11PM +, Kees Cook wrote: > On Mon, Feb 4, 2019 at 10:09 PM Sven Van Asbroeck wrote: > > > > I think there _might_ be potential use-after-free issues on module unload. There are loads of issues with module unloading, which is why it pretty much is a "best effort"

Re: [PATCH v4] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-02-05 Thread Grove, Bradley
Acked-by: Bradley Grove On 1/26/2019 2:52 AM, Nathan Chancellor wrote: Clang warns several times in the scsi subsystem (trimmed for brevity): drivers/scsi/hpsa.c:6209:7: warning: overflow converting case value to switch condition type (2147762695 to 18446744071562347015) [-Wswitch]

libelf-0.175 breaks objtool

2019-02-05 Thread Steven Rostedt
Just a FYI. After a recent upgrade in debian testing, I was not able to build the kernel. I have a custom build of gcc, so I thought it was strange that I was getting something like this (took this from the web, as I don't have the error anymore with the work around, and currently doing a full

preempt.h: some SOFTIRQ_OFFSET should be SOFTIRQ_MASK?

2019-02-05 Thread Denys Vlasenko
SOFTIRQ is a counter. Why here: #define in_serving_softirq()(softirq_count() & SOFTIRQ_OFFSET) #define in_task() (!(preempt_count() & \ (NMI_MASK | HARDIRQ_MASK | SOFTIRQ_OFFSET))) we check only lowest bit?

Re: [RFC PATCH 8/8] svm: Allow AVIC with in-kernel irqchip mode

2019-02-05 Thread Alex Williamson
On Mon, 4 Feb 2019 14:42:32 + "Suthikulpanit, Suravee" wrote: > Once the IRQ ack notifier for in-kernel PIT is no longer required > and run-time AVIC activate/deactivate is supported, we can remove > the kernel irqchip split mode requirement for AVIC. > > Hence, remove the check for irqchip

Re: [PATCH v3 08/10] x86/setcpuid: Add kernel option setcpuid

2019-02-05 Thread Fenghua Yu
On Tue, Feb 05, 2019 at 04:43:09PM +0100, Borislav Petkov wrote: > On Tue, Feb 05, 2019 at 07:19:16AM -0800, Dave Hansen wrote: > > This is one of the few times that we're pretty confident that folks will > > use this. The reason we're going to this trouble is that the split lock > > detection is

Re: [PATCH] x86/ima: require signed kernel modules

2019-02-05 Thread Seth Forshee
On Tue, Feb 05, 2019 at 11:47:24AM -0500, Mimi Zohar wrote: > Hi Seth, > > On Tue, 2019-02-05 at 09:18 -0600, Seth Forshee wrote: > > On Thu, Jan 31, 2019 at 02:18:59PM -0500, Mimi Zohar wrote: > > > Require signed kernel modules on systems with secure boot mode enabled. > > > > > > To

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread Dennis Zhou
On Tue, Feb 05, 2019 at 07:27:49PM +0100, David Sterba wrote: > On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote: > > On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote: > > > On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote: > > > > > > > Something is wrong, the

[PATCH 1/1] Lib: sort.c: replaced heap sort algorithm with introspective sort

2019-02-05 Thread Andrey Abramov
Replaced heap sort algorithm with faster introspective sort algorithm. Signed-off-by: Andrey Abramov --- v1: The introspective sort algorithm is faster the heap sort (for example on my machine on a 100MB of random data it was consistently almost twice faster) and it doesn't have the worst

[RFC][PATCH] usb: f_fs: Avoid crash due to out-of-scope stack ptr access

2019-02-05 Thread John Stultz
Since the 5.0 merge window opened, I've been seeing frequent crashes on suspend and reboot with the trace: [ 36.911170] Unable to handle kernel paging request at virtual address ff801153d660 [ 36.912769] Unable to handle kernel paging request at virtual address ff84b564 ... [

Re: [PATCH 2/4] pwm: stm32-lp: Add power management support

2019-02-05 Thread Tomasz Duszynski
On Tue, Feb 05, 2019 at 01:40:27PM +0100, Fabrice Gasnier wrote: > Add suspend/resume PM sleep ops. When going to low power, disable > active PWM channel. Active PWM channel is resumed, by calling > pwm_apply_state(). This is inspired by Thierry's comment in [1]. > Don't touch inactive channels,

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread David Sterba
On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote: > On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote: > > On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote: > > > > > > Something is wrong, the patchset on top of 5.0-rc5 hangs in test > > > > > > btrfs/007, without

Re: linux-next: Tree for Feb 5 (btrfs/zstd)

2019-02-05 Thread David Sterba
On Tue, Feb 05, 2019 at 09:40:40AM -0800, Randy Dunlap wrote: > On 2/4/19 10:12 PM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20190204: > > > > on i386: > > ../fs/btrfs/zstd.c: In function ‘zstd_reclaim_timer_fn’: > ../fs/btrfs/zstd.c:27:35: warning: integer overflow in

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread David Miller
From: Thierry Reding Date: Mon, 4 Feb 2019 17:42:13 +0100 > @@ -7316,7 +7325,7 @@ static int rtl_get_ether_clk(struct rtl8169_private *tp) > static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id > *ent) > { > const struct rtl_cfg_info *cfg = rtl_cfg_infos +

Re: [PATCH] PCI: Probe bridge window attributes once at enumeration-time

2019-02-05 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 05:02:26PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 29, 2019 at 05:47:32PM -0500, Michael S. Tsirkin wrote: > > On Tue, Jan 29, 2019 at 04:43:33PM -0600, Bjorn Helgaas wrote: > > > On Tue, Jan 22, 2019 at 01:02:54PM -0600, Bjorn Helgaas wrote: > > > > From: Bjorn Helgaas

Re: Question on handling managed IRQs when hotplugging CPUs

2019-02-05 Thread Christoph Hellwig
On Tue, Feb 05, 2019 at 03:09:28PM +, John Garry wrote: > For SCSI devices, unfortunately not all IO sent to the HW originates from > blk-mq or any other single entity. Where else would SCSI I/O originate from?

Re: [PATCH] platform/x86: intel_int0002_vgpio: Only implement irq_set_wake on Bay Trail

2019-02-05 Thread Andy Shevchenko
On Sun, Feb 3, 2019 at 11:42 AM Hans de Goede wrote: > > Commit c3b8e884defa ("platform/x86: intel_int0002_vgpio: Implement > irq_set_wake"), was written to fix some wakeup issues on Bay Trail (BYT) > devices. > > We've received a bug report that this causes a suspend regression on some > Cherry

Re: [PATCH 00/10] ICL support and other enhancements for PMC Core

2019-02-05 Thread Bhardwaj, Rajneesh
On 05-Feb-19 11:36 PM, Andy Shevchenko wrote: On Fri, Feb 1, 2019 at 9:32 AM Rajneesh Bhardwaj wrote: This patch series provides Icelake support for PMC Core driver and while doing so it introduces the Icelake Mobile to intel-family.h as per the CPUID from below Coreboot link

<    1   2   3   4   5   6   7   8   9   10   >