Re: [PATCH v3 2/2] x86/mm/KASLR: Change the granularity of randomization to PUD size in 5-level

2019-03-12 Thread Kirill A. Shutemov
On Fri, Mar 08, 2019 at 10:56:16AM +0800, Baoquan He wrote: > The current randomization granularity of 5-level is 512 GB. Improve > it to 1 GB. This can add more randomness to memory region KASLR in > 5-level paging mode > > Signed-off-by: Baoquan He Acked-by: Kirill A. Shutemov -- Kirill

Re: [PATCH v3 1/2] x86/mm/KASLR: Only build one PUD entry of area for real mode trampoline

2019-03-12 Thread Kirill A. Shutemov
On Fri, Mar 08, 2019 at 10:56:15AM +0800, Baoquan He wrote: > The current code builds identity mapping for real mode treampoline by > borrowing page tables from the direct mapping section if KASLR is > enabled. It will copy present entries of the first PUD table in 4-level > paging mode, or the

Re: [RFC][PATCH 00/16] sched: Core scheduling

2019-03-12 Thread Aaron Lu
On Mon, Mar 11, 2019 at 05:20:19PM -0700, Greg Kerr wrote: > On Mon, Mar 11, 2019 at 4:36 PM Subhra Mazumdar > wrote: > > > > > > On 3/11/19 11:34 AM, Subhra Mazumdar wrote: > > > > > > On 3/10/19 9:23 PM, Aubrey Li wrote: > > >> On Sat, Mar 9, 2019 at 3:50 AM Subhra Mazumdar > > >> wrote: > >

Re: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-03-12 Thread William Breathitt Gray
On Tue, Mar 12, 2019 at 01:36:57PM +0900, Masahiro Yamada wrote: > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray > wrote: > > > > Replace verbose implementation in set_multiple callback with > > for_each_set_clump8 macro to simplify code and improve clarity. An > > improvement in this

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-12 Thread Uwe Kleine-König
Hello, On Thu, Feb 14, 2019 at 04:59:03PM +0100, Uwe Kleine-König wrote: > On Wed, Feb 13, 2019 at 01:37:03PM +0100, Thierry Reding wrote: > > On Thu, Feb 07, 2019 at 11:16:57AM +0100, Uwe Kleine-König wrote: > > > On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: > > [...] > > > > diff

Re: [PATCH v9 1/9] bitops: Introduce the for_each_set_clump8 macro

2019-03-12 Thread William Breathitt Gray
On Tue, Mar 12, 2019 at 02:36:21PM +0900, Masahiro Yamada wrote: > On Fri, Mar 8, 2019 at 5:57 PM William Breathitt Gray > wrote: > > > > On Fri, Mar 08, 2019 at 09:31:00AM +0100, Linus Walleij wrote: > > > On Sun, Mar 3, 2019 at 8:47 AM William Breathitt Gray > > > wrote: > > > > > > > This

Re: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-03-12 Thread Andy Shevchenko
On Tue, Mar 12, 2019 at 6:40 AM Masahiro Yamada wrote: > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray > wrote: > > > > Replace verbose implementation in set_multiple callback with > > for_each_set_clump8 macro to simplify code and improve clarity. An > > improvement in this case is that

RE: [PATCH v5] PM / devfreq: Restart previous governor if new governor fails to start

2019-03-12 Thread MyungJoo Ham
>From: Saravana Kannan > >If the new governor fails to start, switch back to old governor so that the >devfreq state is not left in some weird limbo. > >[Mjungjoo: assume fatal on revert failure and set df->governor to NULL] >Signed-off-by: Sibi Sankar >Signed-off-by: Saravana Kannan

Re: [PATCH v9 1/9] bitops: Introduce the for_each_set_clump8 macro

2019-03-12 Thread Andy Shevchenko
On Tue, Mar 12, 2019 at 7:04 AM Masahiro Yamada wrote: > On Sun, Mar 3, 2019 at 4:48 PM William Breathitt Gray > wrote: > > > > This macro iterates for each 8-bit group of bits (clump) with set bits, > > within a bitmap memory region. For each iteration, "start" is set to the > > bit offset of

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-12 Thread Julia Lawall
On Tue, 12 Mar 2019, maowenan wrote: > > > On 2019/3/12 14:35, Joe Perches wrote: > > On Tue, 2019-03-12 at 14:29 +0800, maowenan wrote: > >> ping... > >> > >> On 2019/3/9 11:26, Mao Wenan wrote: > >>> Using is_zero_ether_addr() instead of directly use > >>> memcmp() to determine if the

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-12 Thread Joe Perches
On Tue, 2019-03-12 at 14:58 +0800, maowenan wrote: > On 2019/3/12 14:35, Joe Perches wrote: > > On Tue, 2019-03-12 at 14:29 +0800, maowenan wrote: > > > ping... > > > > > > On 2019/3/9 11:26, Mao Wenan wrote: > > > > Using is_zero_ether_addr() instead of directly use > > > > memcmp() to determine

Re: [PATCH] mm/swap: Avoid undefined behavior in __swapoffset

2019-03-12 Thread Pi-Hsun Shih
On Thu, Mar 7, 2019 at 9:23 PM Michal Hocko wrote: > > On Thu 07-03-19 20:47:52, Pi-Hsun Shih wrote: > > On Thu, Mar 7, 2019 at 8:23 PM Michal Hocko wrote: > > > > > > On Thu 07-03-19 17:46:50, Pi-Hsun Shih wrote: > > > > Use offsetof to calculate offset of a field to avoid UBSAN warning like: >

Re: [PATCH 0/3] userfaultfd: allow to forbid unprivileged users

2019-03-12 Thread Mike Rapoport
Hi Peter, On Mon, Mar 11, 2019 at 05:36:58PM +0800, Peter Xu wrote: > Hi, > > (The idea comes from Andrea, and following discussions with Mike and > other people) > > This patchset introduces a new sysctl flag to allow the admin to > forbid users from using userfaultfd: > > $ cat

Re: FS-Cache: Duplicate cookie detected

2019-03-12 Thread David Howells
Christian Kujau wrote: > My /usr/local/src mount was mounted with vers=4.2 (default), while > nfstest_cache was mounting its test-mount with vers=4.1! Apart from the > different rsize/wsize values, the version number stood out. And indeed, > when I mount my regular NFS mount /usr/local/src

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-12 Thread maowenan
On 2019/3/12 14:35, Joe Perches wrote: > On Tue, 2019-03-12 at 14:29 +0800, maowenan wrote: >> ping... >> >> On 2019/3/9 11:26, Mao Wenan wrote: >>> Using is_zero_ether_addr() instead of directly use >>> memcmp() to determine if the ethernet address is all >>> zeros. > [] >>> diff --git

Re: [PATCH 1/3] userfaultfd/sysctl: introduce unprivileged_userfaultfd

2019-03-12 Thread Mike Rapoport
On Mon, Mar 11, 2019 at 05:36:59PM +0800, Peter Xu wrote: > Introduce a new sysctl called "vm.unprivileged_userfaultfd" that can > be used to decide whether userfaultfd syscalls are allowed by > unprivileged users. It'll allow three modes: > > - disabled: disallow unprivileged users to use

[PATCH v2] media: rga: fix NULL pointer dereferences and a memory leak

2019-03-12 Thread Kangjie Lu
In case __get_free_pages fails, the fix releases resources and return -ENOMEM to avoid NULL pointer dereferences. Also, the fix frees pages when video_register_device fails to avoid a memory leak. Signed-off-by: Kangjie Lu --- drivers/media/platform/rockchip/rga/rga.c | 15 ++- 1

Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-12 Thread Yash Shah
On Mon, Mar 11, 2019 at 6:59 PM Uwe Kleine-König wrote: > > Hello, > > On Mon, Mar 11, 2019 at 05:10:17PM +0530, Yash Shah wrote: > > On Fri, Mar 8, 2019 at 5:27 PM Uwe Kleine-König > > wrote: > > > On Fri, Mar 08, 2019 at 04:59:36PM +0530, Yash Shah wrote: > > > > On Thu, Mar 7, 2019 at 8:57 PM

[PATCH 1/1] PM / Domains: Avoid a potential deadlock

2019-03-12 Thread Jiada Wang
Lockdep warns that prepare_lock and genpd->mlock can cause a deadlock the deadlock scenario is like following: First thread is probing cs2000 cs2000_probe() clk_register() __clk_core_init() clk_prepare_lock()> acquires prepare_lock

Re: [PATCH] mfd: cros: Update EC protocol to match current EC code

2019-03-12 Thread Gwendal Grignou
Regarding: """While we are here I'd suggest if we can also fix the few errors (3) and warnings (5) spotted by checkpatch. With that it's an ack from my side.""" These errors and warning are for code that is not used by the kernel: WARNING: __aligned(size) is preferred over

Re: KASAN: null-ptr-deref Read in reclaim_high

2019-03-12 Thread Eric Biggers
On Mon, Mar 11, 2019 at 11:25:41PM -0700, Andrew Morton wrote: > On Tue, 12 Mar 2019 07:08:38 +0100 Dmitry Vyukov wrote: > > > On Tue, Mar 12, 2019 at 12:37 AM Andrew Morton > > wrote: > > > > > > On Mon, 11 Mar 2019 06:08:01 -0700 syzbot > > > wrote: > > > > > > > syzbot has bisected this

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-12 Thread Joe Perches
On Tue, 2019-03-12 at 14:29 +0800, maowenan wrote: > ping... > > On 2019/3/9 11:26, Mao Wenan wrote: > > Using is_zero_ether_addr() instead of directly use > > memcmp() to determine if the ethernet address is all > > zeros. [] > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c > >

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-12 Thread maowenan
ping... On 2019/3/9 11:26, Mao Wenan wrote: > Using is_zero_ether_addr() instead of directly use > memcmp() to determine if the ethernet address is all > zeros. > > Signed-off-by: Mao Wenan > --- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH] PM / OPP: Update performance state when freq == old_freq

2019-03-12 Thread Jorge Ramirez
On 3/12/19 05:57, Viresh Kumar wrote: > At boot up, CPUfreq core performs a sanity check to see if the system is > running at a frequency defined in the frequency table of the CPU. If so, > we try to find a valid frequency (lowest frequency greater than the > currently programmed frequency) from

Re: [PATCH 3/3] arm64: librem5-devkit: Add defconfig for the Librem5 devkit

2019-03-12 Thread Daniel Baluta
On Tue, Mar 12, 2019 at 1:47 AM Angus Ainslie (Purism) wrote: > > Signed-off-by: Angus Ainslie (Purism) Hi Angus, My impression was that for arm64 world there will be only one defconfig. So, I'm not sure if this patch would be acceptable. thanks, Daniel. > --- >

Re: [RFC PATCH v3 0/5] tracing: common error_log for ftrace

2019-03-12 Thread Masami Hiramatsu
Hi Tom, On Tue, 5 Mar 2019 23:06:46 +0900 Masami Hiramatsu wrote: > On Mon, 4 Mar 2019 17:36:43 -0600 > > Changes from v2: > > > > - Added [n] numbering as suggested by Masami > Hmm, this seems a bit different what I suggested. I'm trying to port probe event's error report on your error

Re: KASAN: null-ptr-deref Read in reclaim_high

2019-03-12 Thread Andrew Morton
On Tue, 12 Mar 2019 07:08:38 +0100 Dmitry Vyukov wrote: > On Tue, Mar 12, 2019 at 12:37 AM Andrew Morton > wrote: > > > > On Mon, 11 Mar 2019 06:08:01 -0700 syzbot > > wrote: > > > > > syzbot has bisected this bug to: > > > > > > commit 29a4b8e275d1f10c51c7891362877ef6cffae9e7 > > > Author:

Re: [PATCH 2/3] arm64: dts: fsl: Build the Librem5 devkit devicetree

2019-03-12 Thread Daniel Baluta
On Tue, Mar 12, 2019 at 1:48 AM Angus Ainslie (Purism) wrote: > > Compile the Librem5 devkit device tree > > Signed-off-by: Angus Ainslie (Purism) > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/freescale/Makefile >

[PATCH v2] hid: logitech: check the return value of create_singlethread_workqueue

2019-03-12 Thread Kangjie Lu
create_singlethread_workqueue may fail and return NULL. The fix checks if it is NULL to avoid NULL pointer dereference. Also, the fix moves the call of create_singlethread_workqueue earlier to avoid resource-release issues. Signed-off-by: Kangjie Lu --- drivers/hid/hid-logitech-hidpp.c | 8

Re: KASAN: null-ptr-deref Read in reclaim_high

2019-03-12 Thread Dmitry Vyukov
On Tue, Mar 12, 2019 at 12:37 AM Andrew Morton wrote: > > On Mon, 11 Mar 2019 06:08:01 -0700 syzbot > wrote: > > > syzbot has bisected this bug to: > > > > commit 29a4b8e275d1f10c51c7891362877ef6cffae9e7 > > Author: Shakeel Butt > > Date: Wed Jan 9 22:02:21 2019 + > > > > memcg:

Re: FS-Cache: Duplicate cookie detected

2019-03-12 Thread Christian Kujau
On Mon, 11 Mar 2019, David Howells wrote: > I've a couple more patches for you - one a bugfix and one that will print more > information. They don't actually affect the problem you're seeing. I'll post > them as replies to this message. Thanks for the patches. I've applied all three to v5.0 and

<    8   9   10   11   12   13