Re: [PATCH 11/12] perf tools: Reuse shared eBPF dso objects

2019-04-16 Thread Adrian Hunter
On 17/04/19 9:51 AM, Jiri Olsa wrote: > On Wed, Apr 17, 2019 at 09:35:32AM +0300, Adrian Hunter wrote: >> On 16/04/19 7:01 PM, Jiri Olsa wrote: >>> The eBPF program can be loaded multiple times >>> with the same name (tag). We can share dso >>> objects for those programs. >> >> Doesn't a eBPF progr

Re: [PATCH v4] tty: rocket: Remove the rp_ioctl

2019-04-16 Thread Jiri Slaby
On 17. 04. 19, 8:52, Jiri Slaby wrote: > So could you rework the patch to remove only the one? And in a separate > patch, introduce a printk_ratelimited warning to every "case *:" (i.e. Not printk_ratelimited, but "dev_warn_ratelimited(tty->dev" as we have a device. > no warning in the "default"

Re: [PATCH v4 1/2] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-04-16 Thread Marco Felsch
Hi Angus, On 19-04-16 16:36, Angus Ainslie wrote: > Hi Marco, > > On 2019-04-16 15:20, Marco Felsch wrote: > > Hi Angus, > > > > On 19-04-16 11:02, Angus Ainslie wrote: > > > Hi Marco, > > > > > > On 2019-04-16 00:54, Marco Felsch wrote: > > > > Hi Agnus, > > > > > > > > > > Just a nitpick but

linux-next: build failure after merge of the akpm-current tree

2019-04-16 Thread Stephen Rothwell
Hi Andrew, After merging the akpm-current tree, today's linux-next build (arm multi_v7_defconfig) failed like this: fs/binfmt_elf.c: In function 'load_elf_binary': fs/binfmt_elf.c:1140:7: error: 'elf_interpreter' undeclared (first use in this function); did you mean 'interpreter'? if (!elf_int

Re: [PATCH v4] tty: rocket: Remove the rp_ioctl

2019-04-16 Thread Jiri Slaby
On 17. 04. 19, 8:46, Greg Kroah-Hartman wrote: > On Wed, Apr 17, 2019 at 08:27:41AM +0200, Jiri Slaby wrote: >> On 16. 04. 19, 16:53, Fuqian Huang wrote: >>> --- a/drivers/tty/rocket.c >>> +++ b/drivers/tty/rocket.c >> ... >>> -/* IOCTL call handler into the driver */ >>> -static int rp_ioctl(stru

Re: [PATCH 11/12] perf tools: Reuse shared eBPF dso objects

2019-04-16 Thread Jiri Olsa
On Wed, Apr 17, 2019 at 09:35:32AM +0300, Adrian Hunter wrote: > On 16/04/19 7:01 PM, Jiri Olsa wrote: > > The eBPF program can be loaded multiple times > > with the same name (tag). We can share dso > > objects for those programs. > > Doesn't a eBPF program get recompiled differently every time i

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Greg Kroah-Hartman
On Tue, Apr 16, 2019 at 11:41:53PM -0700, Nathan Chancellor wrote: > On Wed, Apr 17, 2019 at 08:15:08AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 16, 2019 at 09:47:51AM -0700, Nathan Chancellor wrote: > > > On Tue, Apr 16, 2019 at 11:00:52AM +0200, Greg Kroah-Hartman wrote: > > > > On Mon, A

Re: [PATCH v4] tty: rocket: Remove the rp_ioctl

2019-04-16 Thread Greg Kroah-Hartman
On Wed, Apr 17, 2019 at 08:27:41AM +0200, Jiri Slaby wrote: > On 16. 04. 19, 16:53, Fuqian Huang wrote: > > --- a/drivers/tty/rocket.c > > +++ b/drivers/tty/rocket.c > ... > > -/* IOCTL call handler into the driver */ > > -static int rp_ioctl(struct tty_struct *tty, > > - unsigned in

Re: [PATCH v2] panic: add an option to replay all the printk message in buffer

2019-04-16 Thread Feng Tang
Hi Andrew, On Tue, Apr 16, 2019 at 09:19:22PM -0700, Andrew Morton wrote: > On Wed, 10 Apr 2019 23:37:18 +0800 Feng Tang wrote: > > > Currently on panic, kernel will lower the loglevel and print out > > new printk msg only with console_flush_on_panic(). > > > > Add an option for users to config

linux-next: build failure after merge of the akpm-current tree

2019-04-16 Thread Stephen Rothwell
Hi Andrew, After merging the akpm-current tree, today's linux-next build (arm multi_v7_defconfig) failed like this: mm/vmscan.c: In function 'snapshot_refaults': mm/vmscan.c:2969:14: error: implicit declaration of function 'lruvec_page_state_local'; did you mean 'lruvec_page_state'? [-Werror=im

Re: [PATCH v3 3/5] mtd: Add support for HyperBus memory devices

2019-04-16 Thread Vignesh Raghavendra
Hi, On 14/04/19 11:21 PM, Sergei Shtylyov wrote: > Hello! > > On 04/12/2019 12:29 PM, Vignesh Raghavendra wrote: > >> Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate >> Bus interface between a host system master and one or more slave >> interfaces. HyperBus is used to co

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Nathan Chancellor
On Wed, Apr 17, 2019 at 08:15:08AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 16, 2019 at 09:47:51AM -0700, Nathan Chancellor wrote: > > On Tue, Apr 16, 2019 at 11:00:52AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > > > > On Mon, A

Re: [PATCH v3 4/5] dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory controller

2019-04-16 Thread Vignesh Raghavendra
On 14/04/19 11:25 PM, Sergei Shtylyov wrote: > On 04/12/2019 12:29 PM, Vignesh Raghavendra wrote: > >> Add binding documentation for TI's HyperBus memory controller present on >> AM654 SoC. >> >> Signed-off-by: Vignesh Raghavendra >> --- >> .../devicetree/bindings/mtd/ti,am654-hbmc.txt | 31 +

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-16 Thread Heikki Krogerus
On Tue, Apr 16, 2019 at 11:35:36PM +0200, Hans de Goede wrote: > Hi, > > On 12-04-19 15:41, Heikki Krogerus wrote: > > Now that the software nodes support references, and the > > device connection API support parsing fwnode references, > > replacing the old connection descriptions with software no

Re: [PATCH 11/12] perf tools: Reuse shared eBPF dso objects

2019-04-16 Thread Adrian Hunter
On 16/04/19 7:01 PM, Jiri Olsa wrote: > The eBPF program can be loaded multiple times > with the same name (tag). We can share dso > objects for those programs. Doesn't a eBPF program get recompiled differently every time it is loaded? > > Link: http://lkml.kernel.org/n/tip-3damf8vq1dryhtpbk5b06

Re: [PATCH] watchdog: intel_scu_watchdog: fix spelling mistake: "set_hearbeat" -> "set_heartbeat"

2019-04-16 Thread Mukesh Ojha
On 4/16/2019 7:03 PM, Colin King wrote: From: Colin Ian King There is a spelling mistake in a pr_debug message. Fix it. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/watchdog/intel_scu_watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [GIT PULL] Hyper-V commits for 5.1

2019-04-16 Thread Greg KH
On Tue, Apr 16, 2019 at 09:34:51PM -0400, Sasha Levin wrote: > 2. Fix to show monitor data only when monitor pages are actually > allocated, also by Kimberly Brown. That's not really a "fix", more like a "new feature", right? > drivers/hv/vmbus_drv.c | 166 > +

Re: [PATCH v4] tty: rocket: Remove the rp_ioctl

2019-04-16 Thread Jiri Slaby
On 16. 04. 19, 16:53, Fuqian Huang wrote: > --- a/drivers/tty/rocket.c > +++ b/drivers/tty/rocket.c ... > -/* IOCTL call handler into the driver */ > -static int rp_ioctl(struct tty_struct *tty, > - unsigned int cmd, unsigned long arg) > -{ > - struct r_port *info = tty->driver

Re: [PATCH v2] Staging: greybus: Cleanup in greybus driver

2019-04-16 Thread Greg KH
On Tue, Apr 16, 2019 at 05:13:18PM -0500, Madhumitha Prabakaran wrote: > Fix a blank line after structure declarations. Also, convert > macros into inline functions in order to maintain Linux kernel > coding style based on which the inline function is > preferable over the macro. > > Blank line fi

Re: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-04-16 Thread Ingo Molnar
* Theodore Ts'o wrote: > It seems though the assumption that we're assuming the attacker has > arbitrary ability to get the low bits of the stack, so *if* that's > true, then eventually, you'd be able to get enough samples that you > could reverse engineer the prandom state. This could take

Transaction from CITI BANK

2019-04-16 Thread Mr. TS
Attention Please Please confirm email if active. There is are some funds that need to me transfer to this bearer, So get back ASAP Regards Hans Schwarz

Re: [PATCH 4.19 000/101] 4.19.35-stable review

2019-04-16 Thread Greg Kroah-Hartman
On Wed, Apr 17, 2019 at 08:15:56AM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 17, 2019 at 03:46:09AM +0530, Bharath Vedartham wrote: > > Compiled and Booted(defconfig) on my x86 machine. No dmesg regressions. > > Thanks for testing 2 of these and letting me know. Oops, you tested 3, thanks fo

Re: [PATCH 4.19 000/101] 4.19.35-stable review

2019-04-16 Thread Greg Kroah-Hartman
On Wed, Apr 17, 2019 at 03:46:09AM +0530, Bharath Vedartham wrote: > Compiled and Booted(defconfig) on my x86 machine. No dmesg regressions. Thanks for testing 2 of these and letting me know. greg k-h

Re: [PATCH 5.0 000/117] 5.0.8-stable review

2019-04-16 Thread Greg Kroah-Hartman
On Tue, Apr 16, 2019 at 03:41:02PM -0600, shuah wrote: > On 4/15/19 12:59 PM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.0.8 release. > > There are 117 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with

Re: [PATCH 4.9 72/76] arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value

2019-04-16 Thread Greg Kroah-Hartman
On Tue, Apr 16, 2019 at 09:47:51AM -0700, Nathan Chancellor wrote: > On Tue, Apr 16, 2019 at 11:00:52AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Apr 15, 2019 at 03:01:51PM -0700, Nathan Chancellor wrote: > > > On Mon, Apr 15, 2019 at 08:44:36PM +0200, Greg Kroah-Hartman wrote: > > > > From: Wil

Re: [tip:perf/core] perf/x86/intel: Force resched when TFA sysctl is modified

2019-04-16 Thread Ingo Molnar
* Vince Weaver wrote: > On Tue, 16 Apr 2019, tip-bot for Stephane Eranian wrote: > > > Commit-ID: f447e4eb3ad1e60d173ca997fcb2ef2a66f12574 > > Gitweb: > > https://git.kernel.org/tip/f447e4eb3ad1e60d173ca997fcb2ef2a66f12574 > > Author: Stephane Eranian > > AuthorDate: Mon, 8 Apr 2019

Re: [PATCH v2] x86/PCI: fix a memory leak bug

2019-04-16 Thread Ingo Molnar
* Wenwen Wang wrote: > On Tue, Apr 16, 2019 at 3:33 PM Thomas Gleixner wrote: > > > > On Tue, 16 Apr 2019, Wenwen Wang wrote: > > > > > In pcibios_irq_init(), the PCI IRQ routing table 'pirq_table' is firstly > > > found through pirq_find_routing_table(). If the table is not found and > > > 'C

Re: [PATCH-tip 0/2] locking/rwsem: Rwsem rearchitecture part 2 follow-up patches

2019-04-16 Thread Ingo Molnar
* Waiman Long wrote: > On 04/16/2019 01:37 PM, Peter Zijlstra wrote: > > On Tue, Apr 16, 2019 at 01:03:10PM -0400, Waiman Long wrote: > >> On 04/16/2019 10:17 AM, Peter Zijlstra wrote: > >>> On Tue, Apr 16, 2019 at 09:18:50AM -0400, Waiman Long wrote: > On 04/16/2019 09:10 AM, Peter Zijlst

Re: [PATCH v2] proc/sysctl: add shared variables for range check

2019-04-16 Thread Matteo Croce
On April 17, 2019 12:17:41 PM GMT+09:00, Andrew Morton wrote: > On Wed, 17 Apr 2019 02:59:43 +0200 Matteo Croce > wrote: > > > In the sysctl code the proc_dointvec_minmax() function is often used > to > > validate the user supplied value between an allowed range. This > function > > uses the ex

Re: [PATCH V2 0/3] Introduce Thermal Pressure

2019-04-16 Thread Ingo Molnar
* Ingo Molnar wrote: > * Thara Gopinath wrote: > > > The test results below shows 3-5% improvement in performance when > > using the third solution compared to the default system today where > > scheduler is unware of cpu capacity limitations due to thermal events. > > The numbers look very

Re: [PATCH v4 2/2] x86/boot/KASLR: skip the specified crashkernel region

2019-04-16 Thread Pingfan Liu
On Wed, Apr 17, 2019 at 3:01 AM Borislav Petkov wrote: > > On Mon, Apr 08, 2019 at 01:58:35PM +0800, Pingfan Liu wrote: > > crashkernel=x@y or or =range1:size1[,range2:size2,...]@offset option may > > fail to reserve the required memory region if KASLR puts kernel into the > > region. To avoid thi

Re: [PATCH v2] proc/sysctl: add shared variables for range check

2019-04-16 Thread kbuild test robot
Hi Matteo, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.1-rc5] [cannot apply to next-20190416] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH v4 1/2] kernel/crash_core: separate the parsing routines to lib/parse_crashkernel.c

2019-04-16 Thread Pingfan Liu
On Wed, Apr 17, 2019 at 3:01 AM Borislav Petkov wrote: > > On Mon, Apr 08, 2019 at 01:58:34PM +0800, Pingfan Liu wrote: > > Beside kernel, at early boot stage, the KASLR code also needs to parse the > > crashkernel=x@y or crashkernel=ramsize-range:size[,...][@offset] option, > > and avoid to put r

Re: [PATCH V2 0/3] Introduce Thermal Pressure

2019-04-16 Thread Ingo Molnar
* Thara Gopinath wrote: > The test results below shows 3-5% improvement in performance when > using the third solution compared to the default system today where > scheduler is unware of cpu capacity limitations due to thermal events. The numbers look very promising! I've rearranged the resul

[PATCH v3 11/11] riscv: Make mmap allocation top-down by default

2019-04-16 Thread Alexandre Ghiti
In order to avoid wasting user address space by using bottom-up mmap allocation scheme, prefer top-down scheme when possible. Before: root@qemuriscv64:~# cat /proc/self/maps 0001-00016000 r-xp fe:00 6389 /bin/cat.coreutils 00016000-00017000 r--p 5000 fe:00 6389 /bin/ca

[PATCH v3 10/11] mips: Use generic mmap top-down layout

2019-04-16 Thread Alexandre Ghiti
mips uses a top-down layout by default that fits the generic functions. At the same time, this commit allows to fix problem uncovered and not fixed for mips here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1429066.html Signed-off-by: Alexandre Ghiti --- arch/mips/Kconfig

Aw: Re: [PATCH v1 0/4] make hdmi work on bananapi-r2

2019-04-16 Thread Frank Wunderlich
Hi CK Hu, you mean the problematic patch is fix possible_crtcs (4/4) and the others are ok? can you push the first 3 while working on the last one? regards Frank

[PATCH v3 09/11] mips: Use STACK_TOP when computing mmap base address

2019-04-16 Thread Alexandre Ghiti
mmap base address must be computed wrt stack top address, using TASK_SIZE is wrong since STACK_TOP and TASK_SIZE are not equivalent. Signed-off-by: Alexandre Ghiti --- arch/mips/mm/mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/mm/mmap.c b/arch/mips/mm/m

[PATCH v3 08/11] mips: Properly account for stack randomization and stack guard gap

2019-04-16 Thread Alexandre Ghiti
This commit takes care of stack randomization and stack guard gap when computing mmap base address and checks if the task asked for randomization. This fixes the problem uncovered and not fixed for mips here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1429066.html Signed-off-by:

[PATCH v3 07/11] arm: Use generic mmap top-down layout

2019-04-16 Thread Alexandre Ghiti
arm uses a top-down mmap layout by default that exactly fits the generic functions, so get rid of arch specific code and use the generic version by selecting ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT. Signed-off-by: Alexandre Ghiti --- arch/arm/Kconfig | 1 + arch/arm/include/asm/pr

[PATCH v3 06/11] arm: Use STACK_TOP when computing mmap base address

2019-04-16 Thread Alexandre Ghiti
mmap base address must be computed wrt stack top address, using TASK_SIZE is wrong since STACK_TOP and TASK_SIZE are not equivalent. Signed-off-by: Alexandre Ghiti --- arch/arm/mm/mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/mmap.c b/arch/arm/mm/mmap

Detecting x86 LAPIC timer frequency from CPUID data

2019-04-16 Thread Daniel Drake
The CPUID.0x16 leaf provides "Bus (Reference) Frequency (in MHz)". In the thread "No 8254 PIT & no HPET on new Intel N3350 platforms causes kernel panic during early boot" we are exploring ways to have the kernel avoid using the PIT/HPET IRQ0 timer in more cases, and Thomas Gleixner suggested that

[PATCH v3 05/11] arm: Properly account for stack randomization and stack guard gap

2019-04-16 Thread Alexandre Ghiti
This commit takes care of stack randomization and stack guard gap when computing mmap base address and checks if the task asked for randomization. This fixes the problem uncovered and not fixed for arm here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1429066.html Signed-off-by: A

[PATCH v3 04/11] arm64, mm: Move generic mmap layout functions to mm

2019-04-16 Thread Alexandre Ghiti
arm64 handles top-down mmap layout in a way that can be easily reused by other architectures, so make it available in mm. It then introduces a new config ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT that can be set by other architectures to benefit from those functions. Note that this new config depends o

Re: [PATCH v2] proc/sysctl: add shared variables for range check

2019-04-16 Thread kbuild test robot
Hi Matteo, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.1-rc5] [cannot apply to next-20190416] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[PATCH v3 03/11] arm64: Consider stack randomization for mmap base only when necessary

2019-04-16 Thread Alexandre Ghiti
Do not offset mmap base address because of stack randomization if current task does not want randomization. Signed-off-by: Alexandre Ghiti --- arch/arm64/mm/mmap.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c index ed4f9915f

[PATCH v3 02/11] arm64: Make use of is_compat_task instead of hardcoding this test

2019-04-16 Thread Alexandre Ghiti
Each architecture has its own way to determine if a task is a compat task, by using is_compat_task in arch_mmap_rnd, it allows more genericity and then it prepares its moving to mm/. Signed-off-by: Alexandre Ghiti --- arch/arm64/mm/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v3 01/11] mm, fs: Move randomize_stack_top from fs to mm

2019-04-16 Thread Alexandre Ghiti
This preparatory commit moves this function so that further introduction of generic topdown mmap layout is contained only in mm/util.c. Signed-off-by: Alexandre Ghiti Reviewed-by: Christoph Hellwig --- fs/binfmt_elf.c| 20 include/linux/mm.h | 2 ++ mm/util.c

[PATCH v3 00/11] Provide generic top-down mmap layout functions

2019-04-16 Thread Alexandre Ghiti
This series introduces generic functions to make top-down mmap layout easily accessible to architectures, in particular riscv which was the initial goal of this series. The generic implementation was taken from arm64 and used successively by arm, mips and finally riscv. Note that in addition the s

mmotm 2019-04-16-22-01 uploaded

2019-04-16 Thread akpm
The mm-of-the-moment snapshot 2019-04-16-22-01 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You wi

Re: [PATCH] x86/tlb: Revert: Align TLB invalidation info

2019-04-16 Thread Nadav Amit
> On Apr 16, 2019, at 11:28 AM, Peter Zijlstra wrote: > > On Tue, Apr 16, 2019 at 10:45:05AM -0700, Linus Torvalds wrote: >> So very much Ack on that patch, but maybe we could do a bit more cleanup >> here? > > Yeah, Nadav was going to try and clean that up. But I figured we should > get this r

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-16 Thread Jiada Wang
Hi Eugeniu thanks for your test & comments and adding more people for review I will add necessary backtrace information to description and rephrase commit summary in V2 patch Thanks, Jiada On 2019/04/17 2:48, Eugeniu Rosca wrote: Hi Jiada, Adding below people, since they've made recent contr

Re: [PATCH] ARM: dts: exynos: add CCI-400 PMU nodes support to Exynos542x SoCs

2019-04-16 Thread Anand Moon
Hi Krzysztof, On Tue, 16 Apr 2019 at 15:49, Krzysztof Kozlowski wrote: > > On Mon, 15 Apr 2019 at 14:24, Anand Moon wrote: > > Cache Coherent Interface (CCI) among Cortex-A15 and Cortex-A7, G2D, G3D and > > SSS > > > > Level 0 > CPU blocks such as Cortex-A15 (CA15), Cortex-A7 (CA7) are > > join

Re: [PATCH v2] panic: add an option to replay all the printk message in buffer

2019-04-16 Thread Andrew Morton
On Wed, 10 Apr 2019 23:37:18 +0800 Feng Tang wrote: > Currently on panic, kernel will lower the loglevel and print out > new printk msg only with console_flush_on_panic(). > > Add an option for users to configure the "panic_print" to see > all dmesg in buffer, some of which they may have never s

Re: [PATCH] ARM: debug-ll: add default address for digicolor

2019-04-16 Thread Baruch Siach
Hi Arnd, On Tue, Apr 16, 2019 at 03:17:30PM +0200, Arnd Bergmann wrote: > The digicolor platform has three UARTs, but the Kconfig.debug > file explicitly lists port zero as the one to be used for the > console, while not providing any default values. > > This can get an automated randconfig build

Re: [PATCH v3] arm64: sysreg: make mrs_s and msr_s macros work with Clang and LTO

2019-04-16 Thread Kees Cook
On Tue, Apr 16, 2019 at 12:08 PM Mark Rutland wrote: > > On Mon, Apr 15, 2019 at 10:22:27AM -0700, Nick Desaulniers wrote: > > On Mon, Apr 15, 2019 at 10:06 AM Mark Rutland wrote: > > > It would be nice if we could simply rely on a more recent binutils these > > > days, which supports the generic

Re: next/master boot bisection: next-20190215 on beaglebone-black

2019-04-16 Thread Kees Cook
On Tue, Apr 16, 2019 at 4:04 PM Guenter Roeck wrote: > > On Tue, Apr 16, 2019 at 1:37 PM Dan Williams wrote: > > Ah, no, the problem is that jump_label_init() is called by > > setup_arch() on x86, and smp_prepare_boot_cpu() on powerpc, but not > > until after parse_args() on ARM. > > > Anywhere b

Re: fs/proc: Crash observed in next_tgid (fs/proc/base.c)

2019-04-16 Thread Kees Cook
On Mon, Apr 15, 2019 at 7:58 AM Jitendra Sharma wrote: > > Hi Kees Cook/Luis, > > We are observing one kernel crash in next_tgid function through > getdents64 path. Call stack is as shown below: > > -000|has_group_leader_pid(inline) > -000|next_tgid( > | [X20] ns = 0xFF87CABB1AC0, > | [locdesc

Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

2019-04-16 Thread Andrew Morton
On Wed, 10 Apr 2019 10:07:24 +0200 David Hildenbrand wrote: > Care to fixup both u64 to resource_size_t? Or should I send a patch? > Whatever you prefer. Please send along a fixup. This patch series has no evidence of having been reviewed :(. Can you suggest who could help us out here?

Re: [PATCH] stm class: Fix out of bound access from bitmap allocation

2019-04-16 Thread Sai Prakash Ranjan
On 4/16/2019 8:30 PM, Alexander Shishkin wrote: Sai Prakash Ranjan writes: From: Mulu He Bitmap allocation works on array of unsigned longs and for stm master allocation when the number of software channels is 32, 4 bytes are allocated and there is a out of bound access at the first 8 bytes

RE: [PATCH V12 1/5] dt-bindings: fsl: scu: add thermal binding

2019-04-16 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, April 16, 2019 11:22 AM > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > controller, the system controller is in charge of system power, clock and > thermal sensors etc. management, Linux kernel has to communicate with > system controll

Re: [PATCH v1 1/3] thermal: rockchip: add pinctrl control

2019-04-16 Thread elaine.zhang
hi, 在 2019/4/16 下午6:12, Daniel Lezcano 写道: Hi Elaine, On 11/04/2019 09:46, elaine.zhang wrote: hi, 在 2019/4/4 上午11:03, Daniel Lezcano 写道: On 01/04/2019 08:43, Elaine Zhang wrote: Based on the TSADC Tshut mode to select pinctrl, instead of setting pinctrl based on architecture (Not depends o

Re: [PATCH] init: Initialize jump labels before command line option parsing

2019-04-16 Thread Andrew Morton
On Tue, 16 Apr 2019 17:39:03 -0700 Guenter Roeck wrote: > > > Has it been confirmed that this fixes > > > mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch > > > on beaglebone-black? > > > > This only fixes dynamically enabling the shuffling on 32-bit ARM. > > Guenter

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-16 Thread Kees Cook
On Tue, Apr 16, 2019 at 10:21 PM Kees Cook wrote: > > On Mon, Apr 8, 2019 at 5:09 PM Matteo Croce wrote: > > > > Use the shared variables for range check, instead of declaring a local one > > in every source file. > > > > Signed-off-by: Matteo Croce > > --- > > kernel/pid_namespace.c | 3 +- >

RE: [PATCH] i2c: imx: correct the method of getting private data in notifier_call

2019-04-16 Thread Anson Huang
Hi, Aisheng Best Regards! Anson Huang > -Original Message- > From: Aisheng Dong > Sent: Wednesday, April 17, 2019 11:13 AM > To: Anson Huang ; shawn...@kernel.org; > s.ha...@pengutronix.de; ker...@pengutronix.de; feste...@gmail.com; > wsa+rene...@sang-engineering.com; u.kleine-koe...@peng

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-16 Thread Kees Cook
On Mon, Apr 8, 2019 at 5:09 PM Matteo Croce wrote: > > Use the shared variables for range check, instead of declaring a local one > in every source file. > > Signed-off-by: Matteo Croce > --- > kernel/pid_namespace.c | 3 +- > kernel/sysctl.c| 193 --

Re: [PATCH v2] proc/sysctl: add shared variables for range check

2019-04-16 Thread Andrew Morton
On Wed, 17 Apr 2019 02:59:43 +0200 Matteo Croce wrote: > In the sysctl code the proc_dointvec_minmax() function is often used to > validate the user supplied value between an allowed range. This function > uses the extra1 and extra2 members from struct ctl_table as minimum and > maximum allowed v

RE: [PATCH] i2c: imx: correct the method of getting private data in notifier_call

2019-04-16 Thread Aisheng Dong
[...] > > > > Fixes: 90ad2cbe88c2("i2c: imx: use clk notifier for rate changes") > > Signed-off-by: Anson Huang > > Please also provide how to reproduce it. > And it seems not a new issue, should we CC stable? Besides above comments: Reviewed-by: Dong Aisheng Regards Dong Aisheng > > Regar

RE: [PATCH] i2c: imx: correct the method of getting private data in notifier_call

2019-04-16 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, April 17, 2019 10:00 AM > > The way of getting private imx_i2c_struct in i2c_imx_clk_notifier_call() is > incorrect, should use clk_change_nb element to get correct address and avoid > below kernel dump during POST_RATE_CHANGE notify by clk > framework: > >

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-16 Thread Jiada Wang
Hi Daniel On 2019/04/17 4:22, Daniel Lezcano wrote: On 11/04/2019 12:03, Jiada Wang wrote: Currently IRQ is remain enabled after .remove, later if device is probed, IRQ is requested before .thermal_init, this may cause IRQ function be triggered but not able to clear IRQ status, thus cause syste

[PATCH 0/3] fix leaked of_node references in drivers/firmware

2019-04-16 Thread Wen Yang
The call to of_get_cpu_node/of_find_compatible_node/of_parse_phandle... returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. We developed a coccinelle SmPL to detect drivers/firmware code and found some issues. This patch series fixes those

[PATCH 1/3] firmware: arm_sdei: fix leaked of_node references

2019-04-16 Thread Wen Yang
In sdei_present_dt function, fw_np is obtained by calling of_find_node_by_name(), np is obtained by calling of_find_matching_node(), and the reference counts of those two device_nodes, fw_np and np, are increased. But when the function exits, only of_node_put is called on np, and fw_np's reference

[PATCH 2/3] firmware: psci: fix leaked of_node references

2019-04-16 Thread Wen Yang
The call to of_find_matching_node_and_match returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. 672 int __init psci_dt_init(void) 673 { 674 struct device_node *np; ... 678 np = of_find_matching_node_and_match(...); 679 6

[PATCH 3/3] firmware: stratix10-svc: fix leaked of_node references

2019-04-16 Thread Wen Yang
In stratix10_svc_init function, fw_np is obtained by calling of_find_node_by_name(), np is obtained by calling of_find_matching_node(), and the reference counts of those two device_nodes, fw_np and np, are increased. But when the function exits, only of_node_put is called on np, and fw_np's referen

[PATCH 1/2] power: supply: fix leaked of_node refs in ab8500_bm_of_probe

2019-04-16 Thread Wen Yang
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. 492 int ab8500_bm_of_probe(struct device *dev, 493struct device_node *np, 494struct abx500_bm_data *bm) 495 { 4

[PATCH 2/2] power: supply: fix leaked of_node refs in power_supply_get_battery_info

2019-04-16 Thread Wen Yang
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/power/supply/power_supply_core.c:601:2-8: ERROR: missing of_node_put; acquired a node pointer wi

[PATCH 0/2] fix leaked of_node references in drivers/power

2019-04-16 Thread Wen Yang
The call to of_get_cpu_node/of_find_compatible_node/of_parse_phandle... returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. We developed a coccinelle SmPL to detect drivers/power code and found some issues. This patch series fixes those iss

Re: [PATCH 1/2] ras: fix an off-by-one error in __find_elem()

2019-04-16 Thread Cong Wang
On Tue, Apr 16, 2019 at 7:31 PM Cong Wang wrote: > Yes it is, I have a stacktrace in production which clearly shows > del_elem.isra.1+0x34/0x40, unlike the one I triggered via fake > PFN's. I can show you if you want, it is on 4.14, so very unlikely > it is interesting to anyone here. Correct mys

Re: [PATCH 1/2] ras: fix an off-by-one error in __find_elem()

2019-04-16 Thread Cong Wang
On Tue, Apr 16, 2019 at 6:53 PM Luck, Tony wrote: > > On Tue, Apr 16, 2019 at 04:47:55PM -0700, Cong Wang wrote: > > 229 static void del_elem(struct ce_array *ca, int idx) > > 230 { > > 231 /* Save us a function call when deleting the last element. */ > > 232 if (ca->n - (idx + 1))

linux-next: build warning after merge of the block tree

2019-04-16 Thread Stephen Rothwell
Hi all, After merging the block tree, today's linux-next build (x86_64 allmodconfig) produced this warning: fs/f2fs/node.c: In function 'f2fs_remove_inode_page': fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long un

[PATCH -next] regulator: stm32-pwr: Make some symbols static

2019-04-16 Thread Wei Yongjun
Fixes the following sparse warnings: drivers/regulator/stm32-pwr.c:35:5: warning: symbol 'ready_mask_table' was not declared. Should it be static? drivers/regulator/stm32-pwr.c:47:5: warning: symbol 'stm32_pwr_reg_is_ready' was not declared. Should it be static? drivers/regulator/stm32-pwr.c:57:

[PATCH -next] regulator: stm32-pwr: Fix return value check in stm32_pwr_regulator_probe()

2019-04-16 Thread Wei Yongjun
In case of error, the function of_iomap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 6cdae8173f67 ("regulator: Add support for stm32 power regulators") Signed-off-by: Wei Yongjun --- drivers/regulator/stm32-pwr.c | 4

Re: [greybus-dev] [PATCH v2] Staging: greybus: Cleanup in greybus driver

2019-04-16 Thread Viresh Kumar
On 16-04-19, 17:13, Madhumitha Prabakaran wrote: > Fix a blank line after structure declarations. Also, convert > macros into inline functions in order to maintain Linux kernel > coding style based on which the inline function is > preferable over the macro. > > Blank line fixes are suggested by c

Re: [PATCH v4 2/2] dt-bindings: cpufreq: Document allwinner,sun50i-h6-operating-points

2019-04-16 Thread Viresh Kumar
On 16-04-19, 11:52, Yangtao Li wrote: > Allwinner Process Voltage Scaling Tables defines the voltage and > frequency value based on the speedbin blown in the efuse combination. > The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to > provide the OPP framework with required informati

Re: [PATCH v4 0/2] cpufreq: Add sunxi nvmem based CPU scaling driver

2019-04-16 Thread Viresh Kumar
On 16-04-19, 11:52, Yangtao Li wrote: > Add sunxi nvmem based CPU scaling driver, refers to qcom-cpufreq-kryo. > > Yangtao Li (2): > cpufreq: Add sunxi nvmem based CPU scaling driver > dt-bindings: cpufreq: Document allwinner,sun50i-h6-operating-points > > .../bindings/opp/sun50i-nvmem-cpufr

[PATCH] i2c: imx: correct the method of getting private data in notifier_call

2019-04-16 Thread Anson Huang
The way of getting private imx_i2c_struct in i2c_imx_clk_notifier_call() is incorrect, should use clk_change_nb element to get correct address and avoid below kernel dump during POST_RATE_CHANGE notify by clk framework: Unable to handle kernel paging request at virtual address 03ef1488 pgd = (ptrv

Re: [RFC][PATCH] tracing/x86: Save CR2 before tracing irqsoff on error_entry

2019-04-16 Thread He Zhe
>From the last replies in the thread, it seems some work is going on. May I ask when we can possibly roughly have a fix or workaround? Thanks, Zhe On 3/21/19 10:15 AM, Steven Rostedt wrote: > From: Steven Rostedt (VMware) > > He Zhe reported a crash by enabling trace events and selecting > "use

Re: [PATCH 1/2] ras: fix an off-by-one error in __find_elem()

2019-04-16 Thread Luck, Tony
On Tue, Apr 16, 2019 at 04:47:55PM -0700, Cong Wang wrote: > 229 static void del_elem(struct ce_array *ca, int idx) > 230 { > 231 /* Save us a function call when deleting the last element. */ > 232 if (ca->n - (idx + 1)) > 233 memmove((void *)&ca->array[idx], > 234

[GIT PULL] Hyper-V commits for 5.1

2019-04-16 Thread Sasha Levin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git tags/hyperv-fixes-si

[PATCH v3 2/2] platform/chrome: wilco_ec: Add USB PowerShare Policy control

2019-04-16 Thread Nick Crews
USB PowerShare is a policy which affects charging via the special USB PowerShare port (marked with a small lightning bolt or battery icon) when in low power states: - In S0, the port will always provide power. - In S0ix, if power_share is enabled, then power will be supplied to the port when on A

[PATCH v3 1/2] platform/chrome: wilco_ec: Add Boot on AC support

2019-04-16 Thread Nick Crews
Boot on AC is a policy which makes the device boot from S5 when AC power is connected. This is useful for users who want to run their device headless or with a dock. v3 changes: - Add docstring to wilco_ec_add_sysfs() - Tweak a comment - Use val > 1 instead of val != 0 && val != 1 v2 changes: - Mo

Re: [PATCH v2 02/19] PM / devfreq: tegra: Replace readl-writel with relaxed versions

2019-04-16 Thread Chanwoo Choi
Hi, On 19. 4. 15. 오후 11:54, Dmitry Osipenko wrote: > There is no need to insert memory barrier on each readl/writel > invocation, hence use the relaxed versions. > > Signed-off-by: Dmitry Osipenko > --- > drivers/devfreq/tegra-devfreq.c | 8 > 1 file changed, 4 insertions(+), 4 deletio

Re: [PATCH v2 06/19] PM / devfreq: tegra: Fix missed error checking on devfreq initialization failure

2019-04-16 Thread Chanwoo Choi
Hi, On 19. 4. 16. 오후 11:29, Dmitry Osipenko wrote: > 16.04.2019 5:32, Chanwoo Choi пишет: >> Hi, >> >> patch6/7/8/9 are for handling of exception handling in probe() function. >> Actually, I'm not sure that there are special reason to split out >> the patches. I think that you can squash patch6/7/

[PATCH v2] proc/sysctl: add shared variables for range check

2019-04-16 Thread Matteo Croce
In the sysctl code the proc_dointvec_minmax() function is often used to validate the user supplied value between an allowed range. This function uses the extra1 and extra2 members from struct ctl_table as minimum and maximum allowed value. On sysctl handler declaration, in every source file there

Re: [PATCH v2 05/19] PM / devfreq: tegra: Replace write memory barrier with the read barrier

2019-04-16 Thread Chanwoo Choi
On 19. 4. 16. 오후 10:57, Dmitry Osipenko wrote: > 16.04.2019 11:00, Chanwoo Choi пишет: >> Hi, >> >> On 19. 4. 15. 오후 11:54, Dmitry Osipenko wrote: >>> The write memory barrier isn't needed because the BUS buffer is flushed >>> by read after write that happens after the removed wmb(), we will also >

[PATCH v4 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver

2019-04-16 Thread Nick Crews
Add control of the charging algorithm used on Wilco devices. See Documentation/ABI/testing/sysfs-class-power-wilco for the userspace interface and other info. v4 changes: -Move implementation from drivers/platform/chrome/wilco_ec/charge_config.c to drivers/power/supply/wilco_charger.c -Move driv

[PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties

2019-04-16 Thread Nick Crews
Add "Standard", "Adaptive", and "Custom" modes to the charge_type property, to expand the existing "Trickle" and "Fast" modes. In addition, add POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties, to expand the existing CHARGE_CONTROL_* pro

Re: [PATCH] init: Initialize jump labels before command line option parsing

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 5:04 PM Dan Williams wrote: > > On Tue, Apr 16, 2019 at 4:44 PM Andrew Morton > wrote: > > > > On Tue, 16 Apr 2019 13:54:04 -0700 Dan Williams > > wrote: > > > > > When a module option, or core kernel argument, toggles a static-key it > > > requires jump labels to be in

Re: [PATCH] x86/mm/mem_encrypt: fix a crash with kmemleak_scan

2019-04-16 Thread Qian Cai
On 4/16/19 1:11 PM, Borislav Petkov wrote: >> +/* >> + * Inform kmemleak about the hole in the .bss section since the >> + * corresponding pages will be unmapped with DEBUG_PAGEALLOC=y. >> + */ >> +kmemleak_free_part((void *)vaddr, vaddr_end - vaddr); >> free_init_pages("un

Re: [PATCH] KVM: vmx: print more APICv fields in dump_vmcs

2019-04-16 Thread Krish Sadhukhan
On 04/15/2019 06:35 AM, Paolo Bonzini wrote: The SVI, RVI, virtual-APIC page address and APIC-access page address fields were left out of dump_vmcs. Add them. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx/vmx.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) dif

  1   2   3   4   5   6   7   8   9   10   >