[PATCH 1/3] ntb_hw_switchtec: Remove redundant steps of switchtec_ntb_reinit_peer() function

2019-06-06 Thread Kelvin Cao
From: Joey Zhang When a re-initialization is caused by a link event, the driver will re-setup the shared memory window. But at that time, the shared memory is still valid, and it's unnecessary to free, reallocate and then initialize it again. We only need to reconfigure the hardware registers.

Re: [RFC] printk/sysrq: Don't play with console_loglevel

2019-06-06 Thread Petr Mladek
On Mon 2019-06-03 15:51:53, Sergey Senozhatsky wrote: > On (05/28/19 15:42), Petr Mladek wrote: > > On Tue 2019-05-28 13:46:19, Sergey Senozhatsky wrote: > > > On (05/28/19 13:15), Sergey Senozhatsky wrote: > > > > On (05/28/19 01:24), Dmitry Safonov wrote: > > > > [..] > > > > > While handling

[PATCH 2/3] ntb_hw_switchtec: Skip unnecessary re-setup of shared memory window for crosslink case

2019-06-06 Thread Kelvin Cao
From: Wesley Sheng In case of NTB crosslink topology, the setting of shared memory window in the virtual partition doesn't reset on peer's reboot. So skip the unnecessary re-setup of shared memory window for that case. Signed-off-by: Wesley Sheng --- drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 3

[PATCH 3/3] ntb_hw_switchtec: Fix setup MW with failure bug

2019-06-06 Thread Kelvin Cao
From: Joey Zhang Switchtec does not support setting multiple MWs simultaneously. The driver takes a hardware lock to ensure that two peers are not doing this simultaneously and it fails if someone else takes the lock. In most cases, this is fine as clients only setup the MWs once on one side of

[PATCH 0/3] Redundant steps removal and bug fix of ntb_hw_switchtec

2019-06-06 Thread Kelvin Cao
Hi, Everyone, This patch series remove redundant steps and fix one bug of the ntb_hw_switchtec module. When a re-initialization is caused by a link event, the driver will re-setup the shared memory windows. But at that time, the shared memory is still valid, and it's unnecessary to free,

Re: [PATCH 0/3] (Qualcomm) UFS device reset support

2019-06-06 Thread Bjorn Andersson
On Wed 05 Jun 23:32 PDT 2019, Avri Altman wrote: > > > > On Wed 05 Jun 02:32 PDT 2019, Avri Altman wrote: > > > > > > > > > > On Tue 04 Jun 22:50 PDT 2019, Avri Altman wrote: > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > On Tue, Jun 4, 2019 at 12:22 AM Bjorn Andersson > > > > > >

Re: [PATCH v4 1/2] HID: quirks: Refactor ELAN 400 and 401 handling

2019-06-06 Thread Benjamin Tissoires
On Thu, Jun 6, 2019 at 1:25 AM Jeffrey Hugo wrote: > > On Tue, May 21, 2019 at 10:42 AM Bjorn Andersson > wrote: > > > > On Tue 23 Apr 09:06 PDT 2019, Jeffrey Hugo wrote: > > > > > There needs to be coordination between hid-quirks and the elan_i2c driver > > > about which devices are handled by

Re: [PATCH 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes

2019-06-06 Thread Jon Hunter
On 06/06/2019 06:58, Sameer Pujar wrote: > > On 6/4/2019 2:37 PM, Jon Hunter wrote: >> On 06/05/2019 12:58, Sameer Pujar wrote: >>> Add DT nodes for following devices on Tegra186 and Tegra194 >>>   * ACONNECT >>>   * ADMA >>>   * AGIC >>> >>> Signed-off-by: Sameer Pujar >>> --- >>>  

Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver

2019-06-06 Thread Marc Zyngier
On Wed, 05 Jun 2019 23:06:05 +0100, Benjamin Herrenschmidt wrote: > > On Wed, 2019-06-05 at 16:12 +0100, Marc Zyngier wrote: > > > Those error messages are control path messages. if we return the same > > > error value from here and from the previous error, how can we > > > differentiate

Re: [PATCH] arm64: dts: sdm845: Add CPU topology

2019-06-06 Thread Vincent Guittot
Hi Quentin, On Wed, 5 Jun 2019 at 19:21, Quentin Perret wrote: > > On Friday 17 May 2019 at 14:55:19 (-0700), Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-05-16 04:54:45) > > > (cc'ing Andy's correct email address) > > > > > > On Wed, May 15, 2019 at 2:46 AM Stephen Boyd wrote: > > > > >

Re: [PATCH 2/3] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver

2019-06-06 Thread Benjamin Herrenschmidt
On Thu, 2019-06-06 at 16:47 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2019-06-06 at 08:37 +0200, Greg KH wrote: > > On Thu, Jun 06, 2019 at 07:55:43AM +1000, Benjamin Herrenschmidt wrote: > > > On Wed, 2019-06-05 at 09:59 +0200, Greg KH wrote: > > > > > > > > > +struct irq_domain

Re: [PATCH v2 -next] crypto: atmel-i2c - Fix build error while CRC16 set to m

2019-06-06 Thread Herbert Xu
On Fri, May 31, 2019 at 08:17:49PM +0800, YueHaibing wrote: > If CRYPTO_DEV_ATMEL_ECC is set m, which select CRC16 to m, > while CRYPTO_DEV_ATMEL_SHA204A is set to y, building fails. > > drivers/crypto/atmel-i2c.o: In function 'atmel_i2c_checksum': > atmel-i2c.c:(.text+0x16): undefined reference

Re: [PATCH] crypto: gcm - fix cacheline sharing

2019-06-06 Thread Herbert Xu
On Thu, Jun 06, 2019 at 08:53:10AM +0200, Ard Biesheuvel wrote: > > That same patch 'fixes' CBC, since CBC was never broken to begin with. > The CTS driver does not have something like the auth_tag sharing the > same cacheline with the IV, so CBC has always worked fine. CBC is broken. Any crypto

Re: [PATCH v3] USB: move usb debugfs directory creation to the usb common core

2019-06-06 Thread Greg Kroah-Hartman
On Thu, Jun 06, 2019 at 10:32:48AM +0800, Chunfeng Yun wrote: > On Wed, 2019-06-05 at 14:44 +0200, Greg Kroah-Hartman wrote: > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > move it to the common "core" USB code so that it is properly initialized > > and removed as

perf top --stdio, glibc 2.28, stdio EOF sticky

2019-06-06 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hello, "perf top --stdio" (or perf kvm top --stdio) keyboard handling does not work properly for me. Instead of accepting key presses, it just displays the "Mapped keys:" help output always. Seems to be related to this glibc 2.28 stdio change:

Re: [PATCH 2/3] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver

2019-06-06 Thread Benjamin Herrenschmidt
On Thu, 2019-06-06 at 08:37 +0200, Greg KH wrote: > On Thu, Jun 06, 2019 at 07:55:43AM +1000, Benjamin Herrenschmidt wrote: > > On Wed, 2019-06-05 at 09:59 +0200, Greg KH wrote: > > > > > > > +struct irq_domain *al_fic_wire_get_domain(struct al_fic *fic); > > > > + > > > > +struct al_fic

linux-next: Tree for Jun 6

2019-06-06 Thread Stephen Rothwell
Hi all, Changes since 20190605: The hwmon-fixes tree gained a build failure for which I reverted a commit. The hwmon-staging tree gained a conflict against Linus' tree. The v4l-dvb tree gained conflicts against Linus' tree. The net-next tree gained a conflict against the bpf tree. The tpmdd

Re: [PATCH v12 00/31] Speculative page faults

2019-06-06 Thread Haiyan Song
Hi Laurent, Regression test for v12 patch serials have been run on Intel 2s skylake platform, some regressions were found by LKP-tools (linux kernel performance). Only tested the cases that have been run and found regressions on v11 patch serials. Get the patch serials from

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Sameer Pujar
On 6/6/2019 11:30 AM, Peter Ujfalusi wrote: Hi Sameer, On 06/06/2019 6.49, Sameer Pujar wrote: Sorry for late reply. [Resending the reply since delivery failed for few recipients] I discussed this internally with HW folks and below is the reason why DMA needs to know FIFO size. - FIFOs

Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook

2019-06-06 Thread Christoph Hellwig
On Wed, Jun 05, 2019 at 10:06:18PM -0500, Larry Finger wrote: > First of all, you have my sympathy for the laborious bisection on a > PowerBook G4. I have done several myself. Thank you. > > I confirm your results. > > The ppc code has a maximum DMA size of 31 bits, thus a 32-bit request will >

Re: [PATCH 2/3] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver

2019-06-06 Thread Greg KH
On Thu, Jun 06, 2019 at 07:55:43AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2019-06-05 at 09:59 +0200, Greg KH wrote: > > > > > +struct irq_domain *al_fic_wire_get_domain(struct al_fic *fic); > > > + > > > +struct al_fic *al_fic_wire_init(struct device_node *node, > > > +

RE: [PATCH v2 2/3] scsi: ufs: Allow resetting the UFS device

2019-06-06 Thread Avri Altman
> static int ufshcd_hba_init(struct ufs_hba *hba) > { > int err; > @@ -7425,9 +7460,15 @@ static int ufshcd_hba_init(struct ufs_hba *hba) > if (err) > goto out_disable_vreg; > > + err = ufshcd_init_device_reset(hba); > + if (err) > + goto

Re: [PATCH 1/3] x86/CPU: Add more Icelake model number

2019-06-06 Thread Borislav Petkov
On Mon, Jun 03, 2019 at 06:41:20AM -0700, kan.li...@linux.intel.com wrote: > From: Kan Liang > > Add the CPUID model number of Icelake (ICL) desktop and server > processors to the Intel family list. > > Signed-off-by: Kan Liang > Signed-off-by: Qiuxu Zhuo You're sending this patch but it has

RE: [EXT] Re: [PATCH v6 4/5] usb: host: Stops USB controller init if PLL fails to lock

2019-06-06 Thread Yinbo Zhu
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: 2019年6月5日 22:22 > To: Yinbo Zhu > Cc: Xiaobo Xie ; Greg Kroah-Hartman > ; Ramneek Mehresh > ; Nikhil Badola > ; Ran Wang ; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Jiafei Pan > >

Re: [PATCH 1/2] media: v4l2-core: Shifting signed 32-bit value by 31 bits error

2019-06-06 Thread Hans Verkuil
On 6/6/19 5:22 AM, Randy Dunlap wrote: > On 6/5/19 2:53 PM, Shuah Khan wrote: >> Fix the following cppcheck error: >> >> Checking drivers/media/v4l2-core/v4l2-ioctl.c ... >> [drivers/media/v4l2-core/v4l2-ioctl.c:1370]: (error) Shifting signed 32-bit >> value by 31 bits is undefined behaviour >>

Re: [PATCH v6 09/10] usb: roles: add USB Type-B GPIO connector driver

2019-06-06 Thread Andy Shevchenko
On Thu, Jun 6, 2019 at 5:53 AM Chunfeng Yun wrote: > > On Wed, 2019-06-05 at 11:45 +0300, Andy Shevchenko wrote: > > On Wed, May 29, 2019 at 10:44 AM Chunfeng Yun > > wrote: > > > > > > Due to the requirement of usb-connector.txt binding, the old way > > > using extcon to support USB Dual-Role

RE: [PATCH 0/3] (Qualcomm) UFS device reset support

2019-06-06 Thread Avri Altman
> > On Wed 05 Jun 02:32 PDT 2019, Avri Altman wrote: > > > > > > > On Tue 04 Jun 22:50 PDT 2019, Avri Altman wrote: > > > > > > > Hi, > > > > > > > > > > > > > > On Tue, Jun 4, 2019 at 12:22 AM Bjorn Andersson > > > > > wrote: > > > > > > > > > > > > This series exposes the ufs_reset line as a

[PATCH V3] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Bitan Biswas
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. Replace BUG() with error handling code. Signed-off-by: Bitan Biswas --- drivers/i2c/busses/i2c-tegra.c | 66 +++--- 1 file

Re: [PATCH 08/13] IB/iser: set virt_boundary_mask in the scsi host

2019-06-06 Thread Christoph Hellwig
On Wed, Jun 05, 2019 at 05:22:35PM -0300, Jason Gunthorpe wrote: > On Wed, Jun 05, 2019 at 09:08:31PM +0200, Christoph Hellwig wrote: > > This ensures all proper DMA layer handling is taken care of by the > > SCSI midlayer. > > Maybe not entirely related to this series, but it looks like the SCSI

Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Bitan Biswas
On 5/31/19 5:45 AM, Dmitry Osipenko wrote: 31.05.2019 12:04, Bitan Biswas пишет: On 5/30/19 4:43 AM, Dmitry Osipenko wrote: 30.05.2019 14:36, Dmitry Osipenko пишет: 30.05.2019 9:14, Bitan Biswas пишет: Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c except for BUG/BUG_ON

Re: [PATCH v2] arm64: dts: qcom: Add Dragonboard 845c

2019-06-06 Thread Vinod Koul
On 05-06-19, 21:38, Bjorn Andersson wrote: > This adds an initial dts for the Dragonboard 845. Supported > functionality includes Debug UART, UFS, USB-C (peripheral), USB-A > (host), microSD-card and Bluetooth. > > Initializing the SMMU is clearing the mapping used for the splash screen >

Re: [PATCH 12/16] mm: consolidate the get_user_pages* implementations

2019-06-06 Thread Christoph Hellwig
On Wed, Jun 05, 2019 at 11:01:17PM -0700, John Hubbard wrote: > I started reviewing this one patch, and it's kind of messy figuring out > if the code motion preserves everything because of > all the consolidation from other places, plus having to move things in > and out of the ifdef blocks. So

Re: [PATCH RFC 03/10] mm/gup: Pass flags down to __gup_device_huge* calls

2019-06-06 Thread Christoph Hellwig
On Wed, Jun 05, 2019 at 06:45:36PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > In order to support checking for a layout lease on a FS DAX inode these > calls need to know if FOLL_LONGTERM was specified. > > Prepare for this with this patch. The GUP fast argument passing is a mess.

Re: [5.2.0-rcx] Bluetooth: hci0: unexpected event for opcode

2019-06-06 Thread Marcel Holtmann
Hi Joerg, > In 5.2.0-rcx I see a new error message on startup probably after > loading the Bluetooth firmware: > [1.609460] Bluetooth: hci0: unexpected event for opcode 0xfc2f > >> dmesg | grep Bluetooth > [0.130969] Bluetooth: Core ver 2.22 > [0.130973] Bluetooth: HCI device and

Re: [RFC v2 0/5] cgroup-aware unbound workqueues

2019-06-06 Thread Mike Rapoport
Hi Tejun, On Wed, Jun 05, 2019 at 06:53:19AM -0700, Tejun Heo wrote: > Hello, Daniel. > > On Wed, Jun 05, 2019 at 09:36:45AM -0400, Daniel Jordan wrote: > > My use case for this work is kernel multithreading, the series formerly > > known > > as ktask[2] that I'm now trying to combine with

Re: rcu_read_lock lost its compiler barrier

2019-06-06 Thread Herbert Xu
On Wed, Jun 05, 2019 at 11:05:11PM -0700, Paul E. McKenney wrote: > > In case you were wondering, the reason that I was giving you such > a hard time was that from what I could see, you were pushing for no > {READ,WRITE}_ONCE() at all. ;-) Hmm, that's exactly what it should be in

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Peter Ujfalusi
Hi Sameer, On 06/06/2019 6.49, Sameer Pujar wrote: > Sorry for late reply. > [Resending the reply since delivery failed for few recipients] > I discussed this internally with HW folks and below is the reason why > DMA needs > to know FIFO size. > > - FIFOs reside in peripheral device(ADMAIF),

Re: [PATCH] perf record: Add support to collect callchains from kernel or user space only.

2019-06-06 Thread 禹舟键
PING ufo19890607 于2019年5月30日周四 下午9:29写道: > > From: yuzhoujian > > One can just record callchains in the kernel or user space with > this new options. We can use it together with "--all-kernel" options. > This two options is used just like print_stack(sys) or print_ustack(usr) > for systemtap.

Re: rcu_read_lock lost its compiler barrier

2019-06-06 Thread Paul E. McKenney
On Thu, Jun 06, 2019 at 12:51:09PM +0800, Herbert Xu wrote: > On Tue, Jun 04, 2019 at 10:44:18AM -0400, Alan Stern wrote: > > > > Currently the LKMM says the test is allowed and there is a data race, > > but this answer clearly is wrong since it would violate the RCU > > guarantee. > > Thank

Re: [PATCH 12/16] mm: consolidate the get_user_pages* implementations

2019-06-06 Thread John Hubbard
On 6/1/19 12:49 AM, Christoph Hellwig wrote: > Always build mm/gup.c, and move the nommu versions and replace the > separate stubs for various functions by the default ones, with the _fast > version always falling back to the slow path because gup_fast_permitted > always returns false now if

Re: [PATCH 01/16] firmware: ti_sci: Add resource management APIs for ringacc, psi-l and udma

2019-06-06 Thread Lokesh Vutla
Hi Peter, On 06/05/19 6:04 PM, Peter Ujfalusi wrote: > Signed-off-by: Peter Ujfalusi Patch has the following checkpatch warnings and checks which can be fixed: WARNING: Missing commit description - Add an appropriate one CHECK: Lines should not end with a '(' #262: FILE:

<    5   6   7   8   9   10