Re: [PATCH 3/4] clk: meson: g12a: add notifiers to handle cpu clock change

2019-07-30 Thread Neil Armstrong
On 30/07/2019 10:37, Jerome Brunet wrote: > On Mon 29 Jul 2019 at 15:16, Neil Armstrong wrote: > >> In order to implement clock switching for the CLKID_CPU_CLK and >> CLKID_CPUB_CLK, notifiers are added on specific points of the >> clock tree : >> >> cpu_clk / cpub_clk >> | \- cpu_clk_dyn >> |

BUG: soft lockup in inet6_sendmsg

2019-07-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:fde50b96 Add linux-next specific files for 20190726 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1587037860 kernel config: https://syzkaller.appspot.com/x/.config?x=4b58274564b354c1

Re: [PATCH 4/4] csky: Add dma_inv_range for DMA_FROM_DEVICE

2019-07-30 Thread Guo Ren
Thx Arnd, On Tue, Jul 30, 2019 at 9:43 PM Arnd Bergmann wrote: > > On Tue, Jul 30, 2019 at 2:16 PM wrote: > > From: Guo Ren > > > diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c > > index 3f1ff9d..d8f0f81 100644 > > --- a/arch/csky/mm/dma-mapping.c > > +++

[PATCH 08/22] ARM: dts: imx7-colibri: Add touch controllers

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker Add atmel mxt multitouch controller and TouchRevolution multitouch controller which are connected over an I2C bus. Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 37 + 1 file changed, 37 insertions(+) diff --git

[PATCH 07/22] ARM: dts: imx7-colibri: fix 1.8V/UHS support

2019-07-30 Thread Philippe Schenker
From: Stefan Agner Add pinmuxing and do not specify voltage restrictions in the module level device tree. Signed-off-by: Stefan Agner Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx7-colibri.dtsi | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff

[PATCH 03/22] ARM: dts: imx7-colibri: prepare module device tree for FlexCAN

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker Prepare FlexCAN use on SODIMM 55/63 178/188. Those SODIMM pins are compatible for CAN bus use with several modules from the Colibri family. Add Better drivestrength and also add flexcan2. Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx7-colibri.dtsi | 35

[PATCH 04/22] ARM: dts: imx7-colibri: Add sleep mode to ethernet

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker Add sleep pinmux to the fec so it can properly sleep. Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx7-colibri.dtsi | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi

Re: WARNING in __mmdrop

2019-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2019 at 03:44:47PM +0800, Jason Wang wrote: > > On 2019/7/29 下午10:44, Michael S. Tsirkin wrote: > > On Mon, Jul 29, 2019 at 10:24:43PM +0800, Jason Wang wrote: > > > On 2019/7/29 下午4:59, Michael S. Tsirkin wrote: > > > > On Mon, Jul 29, 2019 at 01:54:49PM +0800, Jason Wang wrote:

memory leak in pty_common_install

2019-07-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6789f873 Merge tag 'pm-5.3-rc2' of git://git.kernel.org/pu.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1696897c60 kernel config: https://syzkaller.appspot.com/x/.config?x=339b6a6b3640d115

[PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board

2019-07-30 Thread Lukasz Majewski
Before this change the device tree description of qspi node for second memory on BK4 board was wrong (applicable to old, in-house tunned fsl-quadspi.c driver). As a result this memory was not recognized correctly when used with the new spi-fsl-qspi.c driver. >From the dt-bindings: "Required SPI

[PATCH 06/22] ARM: dts: imx7-colibri: add GPIO wakeup key

2019-07-30 Thread Philippe Schenker
From: Stefan Agner Add wakeup GPIO key which is able to wake the system from sleep modes (e.g. Suspend-to-Memory). Signed-off-by: Stefan Agner Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 14 ++ arch/arm/boot/dts/imx7-colibri.dtsi |

Re: [PATCH v2 00/12] tracing/probe: Add multi-probes per event support

2019-07-30 Thread Steven Rostedt
On Tue, 30 Jul 2019 15:23:31 +0900 Masami Hiramatsu wrote: > Hi Steve, > > Have you already picked this series? > If not yet, should I update and resend this series? I started to, but then got distracted :-/ I'll work with the current series, no need to resend. Sorry for the delay. -- Steve

Re: [PATCH 5.3] mwifiex: fix 802.11n/WPA detection

2019-07-30 Thread Kalle Valo
Brian Norris wrote: > Commit 63d7ef36103d ("mwifiex: Don't abort on small, spec-compliant > vendor IEs") adjusted the ieee_types_vendor_header struct, which > inadvertently messed up the offsets used in > mwifiex_is_wpa_oui_present(). Add that offset back in, mirroring >

[PATCH 02/22] ARM: dts: imx7-colibri: disable HS400

2019-07-30 Thread Philippe Schenker
From: Stefan Agner Force HS200 by masking bit 63 of the SDHCI capability register. The i.MX ESDHC driver uses SDHCI_QUIRK2_CAPS_BIT63_FOR_HS400. With that the stack checks bit 63 to descide whether HS400 is available. Using sdhci-caps-mask allows to mask bit 63. The stack then selects HS200 as

[PATCH 00/22] This patchset holds some common changes that were never upstreamed.

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker With latest downstream kernel upgrade, I took the aproach to select mainline devicetrees and atomically add missing stuff for downstream. These patches I send here are separated out with changes that also have a benfit for mainline. Philippe Marcel Ziswiler (1):

Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages()

2019-07-30 Thread Marek Marczykowski-Górecki
On Tue, Jul 30, 2019 at 08:22:02PM +0530, Souptick Joarder wrote: > On Tue, Jul 30, 2019 at 7:52 PM Marek Marczykowski-Górecki > wrote: > > > > On Tue, Jul 30, 2019 at 10:05:42AM -0400, Boris Ostrovsky wrote: > > > On 7/30/19 2:03 AM, Souptick Joarder wrote: > > > > On Mon, Jul 29, 2019 at 7:06

[PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static

2019-07-30 Thread YueHaibing
Fix sparse warning: drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning: symbol 'analogix_dp_atomic_check' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- 1 file changed,

Re: [PATCH 01/12] rdmacg: Replace strncmp with str_has_prefix

2019-07-30 Thread Steven Rostedt
On Tue, 30 Jul 2019 00:03:28 -0700 Joe Perches wrote: > I believe I'm still in favor of global conversion of > strstarts to str_has_prefix. > So am I. -- Steve

Re: [PATCH 2/2] uprobe: collapse THP pmd after removing all uprobes

2019-07-30 Thread Kirill A. Shutemov
On Sun, Jul 28, 2019 at 10:43:35PM -0700, Song Liu wrote: > After all uprobes are removed from the huge page (with PTE pgtable), it > is possible to collapse the pmd and benefit from THP again. This patch > does the collapse by calling khugepaged_add_pte_mapped_thp(). > > Signed-off-by: Song Liu

[PATCH 05/22] ARM: dts: add recovery for I2C for iMX7

2019-07-30 Thread Philippe Schenker
From: Oleksandr Suvorov - add recovery mode for applicable i2c buses for Colibri iMX7 module. Signed-off-by: Oleksandr Suvorov Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx7-colibri.dtsi | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff

RE: [PATCH v2] hv: tools: fixed Python pep8/flake8 warnings for lsvmbus

2019-07-30 Thread Adrian Vladu
Hello, There were two patches you have queued for hyperv-fixes a while ago, but I don't see them anymore in the hyperv-fixes tree: https://lore.kernel.org/patchwork/patch/1070848/ https://lore.kernel.org/patchwork/patch/1070806/ I have checked them and they can still be applied successfully on

Re: linux-next: Tree for Jul 30 (drivers/net/phy/mdio-octeon.c: i386)

2019-07-30 Thread Randy Dunlap
On 7/29/19 10:15 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190729: > on i386: ../drivers/net/phy/mdio-octeon.c: In function ‘octeon_mdiobus_probe’: ../drivers/net/phy/mdio-octeon.c:48:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

[PATCH] dt-bindings: Fix generated example files getting added to schemas

2019-07-30 Thread Rob Herring
Commit 837158b847a4 ("dt-bindings: Check the examples against the schemas") started generating YAML encoded DT files to validate the examples against the schema. When running 'make dt_binding_check' in tree after the 1st time, the generated example .dt.yaml files are mistakenly added to the list

Re: [PATCH v2 2/3] ASoC: Add codec driver for ST TDA7802

2019-07-30 Thread Mark Brown
On Tue, Jul 30, 2019 at 01:09:36PM +0100, Thomas Preston wrote: > index ..0f82a88bc1a4 > --- /dev/null > +++ b/sound/soc/codecs/tda7802.c > @@ -0,0 +1,509 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * tda7802.c -- codec driver for ST TDA7802 Please make the entire comment a

Re: [PATCH 1/2] khugepaged: enable collapse pmd for pte-mapped THP

2019-07-30 Thread Kirill A. Shutemov
On Sun, Jul 28, 2019 at 10:43:34PM -0700, Song Liu wrote: > khugepaged needs exclusive mmap_sem to access page table. When it fails > to lock mmap_sem, the page will fault in as pte-mapped THP. As the page > is already a THP, khugepaged will not handle this pmd again. > > This patch enables the

RE: [PATCH v2] net/socket: fix GCC8+ Wpacked-not-aligned warnings

2019-07-30 Thread David Laight
From: Qian Cai > Sent: 30 July 2019 15:38 ... > Use an implicit alignment for "struct __kernel_sockaddr_storage" so it > can keep the same alignments as a member in both packed and un-packed > structures without breaking UAPI. > > Suggested-by: David Laight ... Although I suggested it needs a

[PATCH 09/22] ARM: dts: imx6qdl-colibri: add phy to fec

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker Add the phy-node and mdio bus to the fec-node, represented as is on hardware. This commit includes micrel,led-mode that is set to the default value, prepared for someone who wants to change this. Signed-off-by: Philippe Schenker ---

[PATCH 18/22] ARM: dts: imx6ull-colibri: Add watchdog

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker This patch adds the watchdog to the imx6ull-colibri devicetree Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx6ull-colibri.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi

[PATCH 19/22] ARM: dts: imx6ull: improve can templates

2019-07-30 Thread Philippe Schenker
From: Max Krummenacher Add the pinmuxing and a inactive node for flexcan1 on SODIMM 55/63 and move the inactive flexcan nodes to imx6ull-colibri-eval-v3.dtsi where they belong. Note that this commit does not enable flexcan functionality, but rather eases the effort needed to do so.

[PATCH 13/22] ARM: dts: colibri-imx6: Add missing pinmuxing to Toradex eval board

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker This patch adds some missing pinmuxing that is in the colibri standard to the dts. Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 20/22] ARM: dts: imx6ull-colibri: Add general wakeup key used on Colibri

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker This adds the possibility to wake the module with an external signal as defined in the Colibri standard Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH 11/22] ARM: dts: imx6: Add sleep state to can interfaces

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker This patch prepares the devicetree for the new Ixora V1.2 where we are able to turn off the supply of the can transceiver. This implies to use a sleep state on transmission pins in order to prevent backfeeding. Signed-off-by: Philippe Schenker ---

[PATCH 16/22] ARM: dts: imx6ull-colibri: Add sleep mode to fec

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker Do not change the clock as the power for this phy is switched with that clock. Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx6ull-colibri.dtsi | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git

[PATCH 17/22] ARM: dts: imx6ull-colibri: reduce v_batt current in power off

2019-07-30 Thread Philippe Schenker
From: Max Krummenacher Reduce the current drawn from VCC_BATT when the main power on the 3V3 pins to the module are switched off. This switches off SoC internal pull resistors which are provided on the module for TAMPER7 and TAMPER9 SoC pin and switches on a pull down instead of a pullup for

[PATCH 14/22] ARM: dts: apalis-imx6: Add some example I2C devices

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker Those devices are used in conjunction with Toradex's evalboard. Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx6q-apalis-eval.dts | 95 + 1 file changed, 95 insertions(+) diff --git a/arch/arm/boot/dts/imx6q-apalis-eval.dts

[PATCH 12/22] ARM: dts: imx6: Add touchscreens used on Toradex eval boards

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker This commit adds the touchscreens from Toradex so one can enable it. Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 44 +++ arch/arm/boot/dts/imx6q-apalis-eval.dts | 19

Re: [PATCH 2/2] KVM: selftests: Enable dirty_log_test on s390x

2019-07-30 Thread Christian Borntraeger
On 30.07.19 12:01, Thomas Huth wrote: > To run the dirty_log_test on s390x, we have to make sure that we > access the dirty log bitmap with little endian byte ordering and > we have to properly align the memslot of the guest. > Also all dirty bits of a segment are set once on s390x when one >

[PATCH 15/22] ARM: dts: apalis-imx6: Add some optional I2C devices

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker This commit adds the mipi_csi node to Toradex's evalboard as found on the mezzanine connector Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx6q-apalis-eval.dts | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH 1/2] mm/filemap: don't initiate writeback if mapping has no dirty pages

2019-07-30 Thread Konstantin Khlebnikov
On 30.07.2019 17:14, Jan Kara wrote: On Tue 23-07-19 11:16:51, Konstantin Khlebnikov wrote: On 23.07.2019 3:52, Andrew Morton wrote: (cc linux-fsdevel and Jan) Thanks for CC Andrew. On Mon, 22 Jul 2019 12:36:08 +0300 Konstantin Khlebnikov wrote: Functions like

[PATCH 01/22] ARM: dts: imx7-colibri: make sure module supplies are always on

2019-07-30 Thread Philippe Schenker
From: Marcel Ziswiler Prevent regulators from being switched off. Signed-off-by: Marcel Ziswiler Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx7-colibri.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi

[PATCH net-next] rxrpc: Fix -Wframe-larger-than= warnings from on-stack crypto

2019-07-30 Thread David Howells
rxkad sometimes triggers a warning about oversized stack frames when building with clang for a 32-bit architecture: net/rxrpc/rxkad.c:243:12: error: stack frame size of 1088 bytes in function 'rxkad_secure_packet' [-Werror,-Wframe-larger-than=] net/rxrpc/rxkad.c:501:12: error: stack frame size

Re: [PATCH] scsi: 3w-sas: Fix unterminated strncpy

2019-07-30 Thread James Bottomley
On Tue, 2019-07-30 at 16:40 +0800, Chuhong Yuan wrote: > strncpy(dest, src, strlen(src)) leads to unterminated > dest, which is dangerous. I don't buy that. The structure is only used for the TW_IOCTL_GET_COMPATIBILITY_INFO ioctl and all the fields for that are fixed width and are copied over as

[PATCH 21/22] ARM: dts: imx6/7-colibri: switch dr_mode to otg

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker In order for the otg ports, that these modules support, it is needed that dr_mode is on otg. Switch to use that feature. Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +- arch/arm/boot/dts/imx7-colibri.dtsi| 2 +- 2 files changed,

[PATCH 22/22] ARM: dts: imx6ull-colibri: Add touchscreens used with Eval Board

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker This adds the common touchscreens that are used with Toradex's Eval Boards. Signed-off-by: Philippe Schenker --- .../arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 37 +++ 1 file changed, 37 insertions(+) diff --git

[PATCH 10/22] ARM: dts: imx6qdl-colibri: Add missing pin declaration in iomuxc

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker This adds the muxing for the optional pins usb-oc (overcurrent) and usb-id. Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/imx6qdl-colibri.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi

Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages()

2019-07-30 Thread Souptick Joarder
On Tue, Jul 30, 2019 at 7:52 PM Marek Marczykowski-Górecki wrote: > > On Tue, Jul 30, 2019 at 10:05:42AM -0400, Boris Ostrovsky wrote: > > On 7/30/19 2:03 AM, Souptick Joarder wrote: > > > On Mon, Jul 29, 2019 at 7:06 PM Marek Marczykowski-Górecki > > > wrote: > > >> On Mon, Jul 29, 2019 at

[PATCH net 2/2] rxrpc: Fix the lack of notification when sendmsg() fails on a DATA packet

2019-07-30 Thread David Howells
Fix the fact that a notification isn't sent to the recvmsg side to indicate a call failed when sendmsg() fails to transmit a DATA packet with the error ENETUNREACH, EHOSTUNREACH or ECONNREFUSED. Without this notification, the afs client just sits there waiting for the call to complete in some

Re: [PATCH 1/2] drivers: base: swnode: link devices to software nodes

2019-07-30 Thread Rafael J. Wysocki
On 7/30/2019 1:52 PM, Heikki Krogerus wrote: On Mon, Jul 29, 2019 at 03:15:32PM +0200, Dmitry Torokhov wrote: On Mon, Jul 29, 2019 at 03:07:15PM +0300, Heikki Krogerus wrote: On Sat, Jul 13, 2019 at 12:52:58AM -0700, Dmitry Torokhov wrote: It is helpful to know what device, if any, a software

[PATCH net 1/2] rxrpc: Fix potential deadlock

2019-07-30 Thread David Howells
There is a potential deadlock in rxrpc_peer_keepalive_dispatch() whereby rxrpc_put_peer() is called with the peer_hash_lock held, but if it reduces the peer's refcount to 0, rxrpc_put_peer() calls __rxrpc_put_peer() - which the tries to take the already held lock. Fix this by providing a version

[PATCH net 0/2] rxrpc: Fixes

2019-07-30 Thread David Howells
rxrpc-fixes-20190730 and can also be found on the following branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes David --- David Howells (2): rxrpc: Fix potential deadlock rxrpc: Fix the lack of notification when sendmsg() fails on a DATA

[PATCH] powerpc/kvm: Mark expected switch fall-through

2019-07-30 Thread Paul Menzel
Date: Tue, 30 Jul 2019 10:53:10 +0200 Fix the error below triggered by `-Wimplicit-fallthrough`, by tagging it as an expected fall-through. arch/powerpc/kvm/book3s_32_mmu.c: In function ‘kvmppc_mmu_book3s_32_xlate_pte’: arch/powerpc/kvm/book3s_32_mmu.c:241:21: error: this statement may

Re: [PATCH v2] net/socket: fix GCC8+ Wpacked-not-aligned warnings

2019-07-30 Thread Marcelo Ricardo Leitner
On Tue, Jul 30, 2019 at 10:38:08AM -0400, Qian Cai wrote: > In file included from ./include/linux/sctp.h:42, > from net/core/skbuff.c:47: > ./include/uapi/linux/sctp.h:395:1: warning: alignment 4 of 'struct > sctp_paddr_change' is less than 8 [-Wpacked-not-aligned] > }

Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

2019-07-30 Thread Keith Busch
On Tue, Jul 30, 2019 at 03:45:31AM -0700, Rafael J. Wysocki wrote: > So I can reproduce this problem with plain 5.3-rc1 and the patch below fixes > it. > > Also Mario reports that the same patch needs to be applied for his 9380 to > reach > SLP_S0 after some additional changes under

Re: [GIT PULL] Wimplicit-fallthrough patches for 5.3-rc2

2019-07-30 Thread Kalle Valo
Kalle Valo writes: > "Gustavo A. R. Silva" writes: > >> On 7/27/19 1:08 PM, Linus Torvalds wrote: >> >>> >>> Ok, I have tried re-pulling and if it passes my build tests cleanly >>> I'll push the result out. >>> >> >> Awesome. :) > > BTW, now when using ccache 3.2.4 (which I admit is an old

Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-07-30 Thread Stephen Rothwell
Hi Michael, On Wed, 31 Jul 2019 00:28:55 +1000 Michael Ellerman wrote: > > Why do we think it's an expected fall through? I can't really convince > myself from the surrounding code that it's definitely intentional. Its been that way since this code was introduced by commit 0365ba7fb1fa

Re: [PATCH v2] fs: xfs: Fix possible null-pointer dereferences in xchk_da_btree_block_check_sibling()

2019-07-30 Thread Darrick J. Wong
On Tue, Jul 30, 2019 at 10:32:06AM +0800, Jia-Ju Bai wrote: > In xchk_da_btree_block_check_sibling(), there is an if statement on > line 274 to check whether ds->state->altpath.blk[level].bp is NULL: > if (ds->state->altpath.blk[level].bp) > > When ds->state->altpath.blk[level].bp is NULL, it

[PATCH v2] net/socket: fix GCC8+ Wpacked-not-aligned warnings

2019-07-30 Thread Qian Cai
In file included from ./include/linux/sctp.h:42, from net/core/skbuff.c:47: ./include/uapi/linux/sctp.h:395:1: warning: alignment 4 of 'struct sctp_paddr_change' is less than 8 [-Wpacked-not-aligned] } __attribute__((packed, aligned(4))); ^ ./include/uapi/linux/sctp.h:728:1:

Re: [alsa-devel] [PATCH v2 1/3] dt-bindings: ASoC: Add TDA7802 amplifier

2019-07-30 Thread Mark Brown
On Tue, Jul 30, 2019 at 03:12:21PM +0100, Thomas Preston wrote: > On 30/07/2019 14:12, Marco Felsch wrote: > >>> +- compatible : "st,tda7802" > >>> +- reg : the I2C address of the device > >>> +- enable-supply : a regulator spec for the PLLen pin > > Shouldn't that be a pin called 'pllen-gpios'?

[PATCH][net-next] mac80211: add missing null return check from call to ieee80211_get_sband

2019-07-30 Thread Colin King
From: Colin Ian King The return from ieee80211_get_sband can potentially be a null pointer, so it seems prudent to add a null check to avoid a null pointer dereference on sband. Addresses-Coverity: ("Dereference null return") Fixes: 2ab45876756f ("mac80211: add support for the ADDBA extension

Re: [PATCH v2 4/5] pinctrl: uniphier: Add Pro5 PCIe pin-mux settings

2019-07-30 Thread Masahiro Yamada
On Tue, Jul 30, 2019 at 2:44 PM Kunihiko Hayashi wrote: > > Pro5 PCIe interface uses the following pins: > XPERST, XPEWAKE, XPECLKRQ > > Signed-off-by: Kunihiko Hayashi > --- Acked-by: Masahiro Yamada -- Best Regards Masahiro Yamada

[PATCH] enetc: Fix build error without PHYLIB

2019-07-30 Thread YueHaibing
If PHYLIB is not set, build enetc will fails: drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_open': enetc.c: undefined reference to `phy_disconnect' enetc.c: undefined reference to `phy_start' drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_close': enetc.c:

[PATCH v2] rtl8192_init_priv_variable: null check is missing for kzalloc

2019-07-30 Thread Navid Emamdoost
Allocation for priv->pFirmware may fail, so a null check is necessary. priv->pFirmware is accessed later in rtl8192_adapter_start. I added the check and made appropriate changes to propagate the errno to the caller. Update: fixed style errors Signed-off-by: Navid Emamdoost ---

Re: [PATCH] powerpc: workaround clang codegen bug in dcbz

2019-07-30 Thread Arnd Bergmann
On Tue, Jul 30, 2019 at 3:49 PM Segher Boessenkool wrote: > > On Tue, Jul 30, 2019 at 09:34:28AM +0200, Arnd Bergmann wrote: > > Upon a second look, I think the issue is that the "Z" is an input argument > > when it should be an output. clang decides that it can make a copy of the > > input and

Re: [PATCH v2 2/5] pinctrl: uniphier: Add another audio I/O pin-mux settings for LD20

2019-07-30 Thread Masahiro Yamada
On Tue, Jul 30, 2019 at 2:43 PM Kunihiko Hayashi wrote: > > This adds support for pinmux settings of aout1b group. This group includes > audio I/O signals derived from xirq pins, and it is equivalent to "aout1" > in functionality. > > Signed-off-by: Kunihiko Hayashi > --- Acked-by: Masahiro

Re: [PATCH v2 1/5] pinctrl: uniphier: Separate modem group from UART ctsrts group

2019-07-30 Thread Masahiro Yamada
On Tue, Jul 30, 2019 at 2:43 PM Kunihiko Hayashi wrote: > > It depends on the board implementation whether to have each pins of > CTS/RTS, and others for modem. So it is necessary to divide current > uart_ctsrts group into uart_ctsrts and uart_modem groups. > > Since the number of implemented

Re: [PATCH v2] kbuild: Check for unknown options with cc-option usage in Kconfig and clang

2019-07-30 Thread Masahiro Yamada
On Mon, Jul 29, 2019 at 11:23 PM Stephen Boyd wrote: > > Quoting Masahiro Yamada (2019-07-29 03:02:40) > > > > Thanks for catching this. > > > > I wonder if we could fix this issue > > by one-liner, like this: > > > > > > diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include > > index

Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-07-30 Thread Michael Ellerman
Stephen Rothwell writes: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: powerpc): > > drivers/macintosh/smu.c: In function 'smu_queue_i2c': > drivers/macintosh/smu.c:854:21: warning: this statement may fall through >

Re: [patch V2 3/5] lib/vdso/32: Provide legacy syscall fallbacks

2019-07-30 Thread Sean Christopherson
On Tue, Jul 30, 2019 at 11:38:50AM +0200, Thomas Gleixner wrote: > To address the regression which causes seccomp to deny applications the > access to clock_gettime64() and clock_getres64() syscalls because they > are not enabled in the existing filters. > > That trips over the fact that 32bit

Re: [RFC PATCH 0/6] tiny: Add driver for gooddisplay epaper panels

2019-07-30 Thread Daniel Vetter
Hi Jan! On Tue, Jul 30, 2019 at 3:46 PM Jan Sebastian Götte wrote: > > Hi, > > I've been working on a tinydrm-based driver for black/white/red, b/w/yellow > and b/w epaper displays made by good display[sic!][0]. These panels are > fairly popular since waveshare[1] sells raspberry pi and

Re: [PATCH 18/20] fs: omfs: Initialize filesystem timestamp ranges

2019-07-30 Thread Bob Copeland
On Mon, Jul 29, 2019 at 06:49:22PM -0700, Deepa Dinamani wrote: > Fill in the appropriate limits to avoid inconsistencies > in the vfs cached inode times when timestamps are > outside the permitted range. > > Signed-off-by: Deepa Dinamani > Cc: m...@bobcopeland.com > Cc:

Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages()

2019-07-30 Thread Marek Marczykowski-Górecki
On Tue, Jul 30, 2019 at 10:05:42AM -0400, Boris Ostrovsky wrote: > On 7/30/19 2:03 AM, Souptick Joarder wrote: > > On Mon, Jul 29, 2019 at 7:06 PM Marek Marczykowski-Górecki > > wrote: > >> On Mon, Jul 29, 2019 at 02:02:54PM +0530, Souptick Joarder wrote: > >>> On Mon, Jul 29, 2019 at 1:35 PM

Re: [PATCH v2 3/3] ASoC: TDA7802: Add turn-on diagnostic routine

2019-07-30 Thread Mark Brown
On Tue, Jul 30, 2019 at 01:09:37PM +0100, Thomas Preston wrote: > + struct dentry *debugfs; > + struct mutex diagnostic_mutex; > +}; It is unclear what this mutex usefully protects, it only gets taken when writing to the debugfs file to trigger this diagnostic mode but doesn't do

Re: [alsa-devel] [PATCH v2 3/3] ASoC: TDA7802: Add turn-on diagnostic routine

2019-07-30 Thread Mark Brown
On Tue, Jul 30, 2019 at 03:04:19PM +0100, Thomas Preston wrote: > On 30/07/2019 13:41, Charles Keepax wrote: > > This could probably be removed using regmap_multi_reg_write. > The problem is that I want to retain the state of the other bits in those > registers. Maybe I should make a copy of the

Re: [alsa-devel] [PATCH v2 3/3] ASoC: TDA7802: Add turn-on diagnostic routine

2019-07-30 Thread Charles Keepax
On Tue, Jul 30, 2019 at 03:04:19PM +0100, Thomas Preston wrote: > On 30/07/2019 13:41, Charles Keepax wrote: > >> +static int tda7802_bulk_update(struct regmap *map, struct reg_update > >> *update, > >> + size_t update_count) > >> +{ > >> + int i, err; > >> + > >> + for (i = 0; i <

Re: [PATCH net] net: stmmac: Sync RX Buffer upon allocation

2019-07-30 Thread Ezequiel Garcia
On Tue, 30 Jul 2019 at 10:57, Jose Abreu wrote: > > With recent changes that introduced support for Page Pool in stmmac, Jon > reported that NFS boot was no longer working on an ARM64 based platform > that had the IP behind an IOMMU. > > As Page Pool API does not guarantee DMA syncing because of

Re: [PATCH 1/2] mm/filemap: don't initiate writeback if mapping has no dirty pages

2019-07-30 Thread Jan Kara
On Tue 23-07-19 11:16:51, Konstantin Khlebnikov wrote: > On 23.07.2019 3:52, Andrew Morton wrote: > > > > (cc linux-fsdevel and Jan) Thanks for CC Andrew. > > On Mon, 22 Jul 2019 12:36:08 +0300 Konstantin Khlebnikov > > wrote: > > > > > Functions like filemap_write_and_wait_range() should do

Re: [PATCH 5.2 048/215] drm/omap: dont check dispc timings for DSI

2019-07-30 Thread Sebastian Reichel
Hi, On Tue, Jul 30, 2019 at 01:37:51PM +0200, Pavel Machek wrote: > On Mon 2019-07-29 21:20:44, Greg Kroah-Hartman wrote: > > [ Upstream commit ad9df7d91b4a6e8f4b20c2bf539ac09b3b2ad6eb ] > > > > While most display types only forward their VM to the DISPC, this > > is not true for DSI. DSI

Re: [alsa-devel] [PATCH v2 1/3] dt-bindings: ASoC: Add TDA7802 amplifier

2019-07-30 Thread Thomas Preston
On 30/07/2019 14:12, Marco Felsch wrote: > Hi Charles, > > sorry for jumping in.. > > On 19-07-30 13:27, Charles Keepax wrote: >> On Tue, Jul 30, 2019 at 01:09:35PM +0100, Thomas Preston wrote: >>> Signed-off-by: Thomas Preston >>> Cc: Patrick Glaser >>> Cc: Rob Duncan >>> Cc: Nate Case >>>

Re: [alsa-devel] [PATCH v2 1/3] dt-bindings: ASoC: Add TDA7802 amplifier

2019-07-30 Thread Thomas Preston
On 30/07/2019 13:27, Charles Keepax wrote: > On Tue, Jul 30, 2019 at 01:09:35PM +0100, Thomas Preston wrote: >> Signed-off-by: Thomas Preston >> Cc: Patrick Glaser >> Cc: Rob Duncan >> Cc: Nate Case >> --- >> .../devicetree/bindings/sound/tda7802.txt | 26 +++ >> 1 file

Re: [PATCH 1/2] net: dsa: mv88e6xxx: add support to setup led-control register through device-tree

2019-07-30 Thread Andrew Lunn
On Tue, Jul 30, 2019 at 12:14:50PM +0200, Hubert Feurstein wrote: > So it is possible to change the default behaviour of the switch LEDs. Sorry, but this is not going to be accepted. There is an ongoing discussion about PHY LEDs and how they should be configured. Switch LEDs are no different from

[PATCH] fgraph: Remove redundant ftrace_graph_notrace_addr() test

2019-07-30 Thread Changbin Du
We already have tested it before. The second one should be removed. With this change, the performance should have little improvement. Fixes: 9cd2992f2d6c ("fgraph: Have set_graph_notrace only affect function_graph tracer") Signed-off-by: Changbin Du --- kernel/trace/trace_functions_graph.c |

Re: [RFC PATCH 05/16] RISC-V: KVM: Implement VCPU interrupts and requests handling

2019-07-30 Thread Paolo Bonzini
On 30/07/19 15:35, Anup Patel wrote: > On Tue, Jul 30, 2019 at 6:48 PM Paolo Bonzini wrote: >> >> On 30/07/19 14:45, Anup Patel wrote: >>> Here's some text from RISC-V spec regarding SIP CSR: >>> "software interrupt-pending (SSIP) bit in the sip register. A pending >>> supervisor-level software

Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages()

2019-07-30 Thread Boris Ostrovsky
On 7/30/19 2:03 AM, Souptick Joarder wrote: > On Mon, Jul 29, 2019 at 7:06 PM Marek Marczykowski-Górecki > wrote: >> On Mon, Jul 29, 2019 at 02:02:54PM +0530, Souptick Joarder wrote: >>> On Mon, Jul 29, 2019 at 1:35 PM Souptick Joarder >>> wrote: On Sun, Jul 28, 2019 at 11:36 PM Marek

Re: [PATCH v4] platform/chrome: cros_ec_trace: update generating script

2019-07-30 Thread Tzung-Bi Shih
Hi Enric, I found it is error-prone to replace the EC_CMDS after updated. Perhaps, we should introduce an intermediate file "cros_ec_trace.inc". The generating script replaces whole ".inc" file every time and the cros_ec_trace.c includes the "cros_ec_trace.inc". If this proposal makes sense to

Re: [PATCH 5.2 000/215] 5.2.5-stable review

2019-07-30 Thread Greg Kroah-Hartman
On Tue, Jul 30, 2019 at 08:01:42AM -0600, shuah wrote: > On 7/29/19 1:19 PM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.2.5 release. > > There are 215 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with

Re: [alsa-devel] [PATCH v2 3/3] ASoC: TDA7802: Add turn-on diagnostic routine

2019-07-30 Thread Thomas Preston
Hi, Thanks for getting back to me so quickly. On 30/07/2019 13:41, Charles Keepax wrote: > On Tue, Jul 30, 2019 at 01:09:37PM +0100, Thomas Preston wrote: >> Add a debugfs device node which initiates the turn-on diagnostic routine >> feature of the TDA7802 amplifier. The four status registers

Re: [PATCH 0/4] net: dsa: mv88e6xxx: add support for MV88E6220

2019-07-30 Thread Andrew Lunn
On Tue, Jul 30, 2019 at 12:04:25PM +0200, Hubert Feurstein wrote: > This patch series adds support for the MV88E6220 chip to the mv88e6xxx driver. > The MV88E6220 is almost the same as MV88E6250 except that the ports 2-4 are > not routed to pins. > > Furthermore, PTP support is added to the

Re: [RFC PATCH 00/16] KVM RISC-V Support

2019-07-30 Thread Paolo Bonzini
On 30/07/19 15:50, Anup Patel wrote: >> BTW, since IPIs are handled in the SBI I wouldn't bother with in-kernel >> PLIC emulation unless you can demonstrate performance improvements (for >> example due to irqfd). In fact, it may be more interesting to add > > I thought VHOST requires irqfd and

Re: [PATCH 5.2 000/215] 5.2.5-stable review

2019-07-30 Thread shuah
On 7/29/19 1:19 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.2.5 release. There are 215 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value

2019-07-30 Thread Andrew Lunn
On Tue, Jul 30, 2019 at 12:11:42PM +0200, Hubert Feurstein wrote: > Using the define here makes the code more expressive. > > Signed-off-by: Hubert Feurstein Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 1/4] net: dsa: mv88e6xxx: add support for MV88E6220

2019-07-30 Thread Hubert Feurstein
Hi Andrew, [...] > Do the registers for the ports exist? Yes, they do and they return sane values. > > + [MV88E6220] = { > > + .prod_num = MV88E6XXX_PORT_SWITCH_ID_PROD_6220, > > + .family = MV88E6XXX_FAMILY_6250, > > + .name = "Marvell 88E6220", > > +

Re: [PATCH] net: dsa: mv88e6xxx: extend PTP gettime function to read system clock

2019-07-30 Thread Andrew Lunn
On Tue, Jul 30, 2019 at 12:10:07PM +0200, Hubert Feurstein wrote: > This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl. > > Signed-off-by: Hubert Feurstein Please include the PTP maintainer for patches like this. Richard also wrote this PTP code. Andrew > --- >

Re: [PATCH 4.19 000/113] 4.19.63-stable review

2019-07-30 Thread shuah
On 7/29/19 1:21 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.63 release. There are 113 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH v3] sched/core: Don't use dying mm as active_mm of kthreads

2019-07-30 Thread Waiman Long
On 7/30/19 4:43 AM, Peter Zijlstra wrote: > On Mon, Jul 29, 2019 at 05:07:28PM -0400, Waiman Long wrote: >> It was found that a dying mm_struct where the owning task has exited >> can stay on as active_mm of kernel threads as long as no other user >> tasks run on those CPUs that use it as

Re: [PATCH 4.14 000/293] 4.14.135-stable review

2019-07-30 Thread shuah
On 7/29/19 1:18 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.135 release. There are 293 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: RFC: remove Nuvoton w90x900/nuc900 platform?

2019-07-30 Thread Avi Fishman
Note that we we are going to add soon drivers/net/ethernet/nuvoton/npcm7xx_emc.c so maybe don't remove drivers/net/ethernet/nuvoton On Tue, Jul 30, 2019 at 4:01 PM Arnd Bergmann wrote: > > That wasn't it either, sorry for spamming the rest. I found one more > address for Zongshun at Huawei. > >

Re: [PATCH 4/4] net: dsa: mv88e6xxx: add PTP support for MV88E6250 family

2019-07-30 Thread Andrew Lunn
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.h > b/drivers/net/dsa/mv88e6xxx/chip.h > index 720cace3db4e..64872251e479 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.h > +++ b/drivers/net/dsa/mv88e6xxx/chip.h > @@ -273,6 +273,10 @@ struct mv88e6xxx_chip { > u16 trig_config; > u16

RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-30 Thread Jose Abreu
From: Jon Hunter Date: Jul/30/2019, 14:36:39 (UTC+00:00) > > On 30/07/2019 10:39, Jose Abreu wrote: > > ... > > > I looked at netsec implementation and I noticed that we are syncing the > > old buffer for device instead of the new one. netsec syncs the buffer > > for device immediately

[PATCH net] net: stmmac: Sync RX Buffer upon allocation

2019-07-30 Thread Jose Abreu
With recent changes that introduced support for Page Pool in stmmac, Jon reported that NFS boot was no longer working on an ARM64 based platform that had the IP behind an IOMMU. As Page Pool API does not guarantee DMA syncing because of the use of DMA_ATTR_SKIP_CPU_SYNC flag, we have to explicit

[PATCH] staging/octeon: Fix build error without CONFIG_NETDEVICES

2019-07-30 Thread YueHaibing
While do COMPILE_TEST build without CONFIG_NETDEVICES, we get Kconfig warning: WARNING: unmet direct dependencies detected for PHYLIB Depends on [n]: NETDEVICES [=n] Selected by [y]: - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=n] || COMPILE_TEST [=y])

<    4   5   6   7   8   9   10   11   12   13   >