Re: [PATCH v2] lib/smp_processor_id: Don't use cpumask_equal()

2019-10-07 Thread Peter Zijlstra
On Thu, Oct 03, 2019 at 04:36:08PM -0400, Waiman Long wrote: > The check_preemption_disabled() function uses cpumask_equal() to see > if the task is bounded to the current CPU only. cpumask_equal() calls > memcmp() to do the comparison. As x86 doesn't have __HAVE_ARCH_MEMCMP, > the slow memcmp()

Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for dpclk

2019-10-07 Thread Shawn Guo
On Fri, Sep 20, 2019 at 04:34:19PM +0800, Wen He wrote: > Update DT node name clock-controller to clock-display, The node name clock-controller is so good, and I do not understand why you need to change it. Shawn > also change > the property #clock-cells value to zero. > > This update

Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk()

2019-10-07 Thread Qian Cai
On Mon, 2019-10-07 at 11:05 +0200, Petr Mladek wrote: > On Mon 2019-10-07 10:07:42, Michal Hocko wrote: > > On Fri 04-10-19 18:26:45, Qian Cai wrote: > > > It is unsafe to call printk() while zone->lock was held, i.e., > > > > > > zone->lock --> console_lock > > > > > > because the console could

Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver

2019-10-07 Thread Guenter Roeck
On 10/7/19 12:58 AM, eugen.hris...@microchip.com wrote: [ ... ] Hello Guenter, Thank you for the feedback. After reviewing this, can you please guide me towards one of the possible two directions: merge this driver with sama5d4_wdt , and have a single driver with support for both hardware

Re: [PATCH v10 06/16] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-10-07 Thread Dan Murphy
Jacek On 10/6/19 11:12 AM, Jacek Anaszewski wrote: Dan, On 10/1/19 4:56 PM, Dan Murphy wrote: Introduce the LP5036/30/24/18/12/9 RGB LED driver. The difference in these parts are the number of LED outputs where the: LP5036 can control 36 LEDs LP5030 can control 30 LEDs LP5024 can control 24

Re: [v2 1/2] arm64: dts: ls1028a: Update the clock providers for the Mali DP500

2019-10-07 Thread Shawn Guo
On Fri, Sep 20, 2019 at 04:34:18PM +0800, Wen He wrote: > In order to maximise performance of the LCD Controller's 64-bit AXI > bus, for any give speed bin of the device, the AXI master interface > clock(ACLK) clock can be up to CPU_frequency/2, which is already > capable of optimal performance.

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Walter Wu
On Mon, 2019-10-07 at 14:19 +0200, Dmitry Vyukov wrote: > On Mon, Oct 7, 2019 at 2:03 PM Walter Wu wrote: > > > > > > > > > > On Mon, Oct 7, 2019 at 10:18 AM Walter Wu > > > > > > > > > > wrote: > > > > > > > > > > > The patchsets help to produce KASAN report when size is > > > > > > > > > > >

Re: [PATCH v11 0/6] mm / virtio: Provide support for unused page reporting

2019-10-07 Thread Nitesh Narayan Lal
On 10/2/19 10:25 AM, Alexander Duyck wrote: [...] >>> My suggestion would be to look at reworking the patch set and >>> post numbers for my patch set versus the bitmap approach and we can >>> look at them then. >> Agreed. However, in order to fix an issue I have to reproduce it first. > With the

Re: [PATCH] dmaengine: zx: Use devm_platform_ioremap_resource() in zx_dma_probe()

2019-10-07 Thread Shawn Guo
On Sun, Sep 22, 2019 at 02:37:13PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 22 Sep 2019 14:32:12 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus

Re: [PATCH v4 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB board

2019-10-07 Thread Stefan-gabriel Mirea
On 10/6/2019 5:00 AM, Shawn Guo wrote: > On Thu, Sep 05, 2019 at 11:58:32AM +, Stefan-gabriel Mirea wrote: >> From: Eddy Petrișor >> >> Add entry for the NXP S32V234 Customer Evaluation Board to the board/SoC >> bindings. >> >> Signed-off-by: Eddy Petrișor >> Signed-off-by: Stefan-Gabriel

Re: [PATCH] firmware: vpd: Add an interface to read VPD value

2019-10-07 Thread Guenter Roeck
On 10/7/19 1:03 AM, Tzung-Bi Shih wrote: On Mon, Oct 7, 2019 at 3:16 PM Cheng-Yi Chiang wrote: Add an interface for other driver to query VPD value. This will be used for ASoC machine driver to query calibration data stored in VPD for smart amplifier speaker resistor calibration.

Re: [PATCH v2] kheaders: making headers archive reproducible

2019-10-07 Thread Andreas Schwab
On Okt 07 2019, Greg KH wrote: > On Mon, Oct 07, 2019 at 01:49:47PM +0200, Andreas Schwab wrote: >> GEN kernel/kheaders_data.tar.xz >> tar: unrecognized option '--sort=name' >> Try `tar --help' or `tar --usage' for more information. >> make[2]: *** [kernel/kheaders_data.tar.xz] Error 64 >>

[PATCH v11 6/8] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

2019-10-07 Thread Ricardo Ribalda Delgado
New control to pass to userspace the width/height of a pixel. Which is needed for calibration and lens selection. Reviewed-by: Philipp Zabel Signed-off-by: Ricardo Ribalda Delgado --- .../media/uapi/v4l/ext-ctrls-image-source.rst | 10 ++ 1 file changed, 10 insertions(+) diff

Re: [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support

2019-10-07 Thread Shawn Guo
On Thu, Sep 19, 2019 at 05:46:47PM +0800, Anson Huang wrote: > Enable i2c3 for i.MX8MM EVK board. > > Signed-off-by: Anson Huang > --- > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git

Re: [RFC v5 4/6] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores

2019-10-07 Thread Vincent Guittot
On Mon, 7 Oct 2019 at 10:31, Parth Shah wrote: > > The algorithm finds the first non idle core in the system and tries to > place a task in the idle CPU in the chosen core. To maintain > cache hotness, work of finding non idle core starts from the prev_cpu, > which also reduces task ping-pong

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Dmitry Vyukov
On Mon, Oct 7, 2019 at 2:03 PM Walter Wu wrote: > > > > > > > > > On Mon, Oct 7, 2019 at 10:18 AM Walter Wu > > > > > > > > > wrote: > > > > > > > > > > The patchsets help to produce KASAN report when size is > > > > > > > > > > negative numbers > > > > > > > > > > in memory operation

Re: [PATCH] usb: cdns3: Fix for incorrect DMA mask.

2019-10-07 Thread Roger Quadros
On 07/10/2019 15:03, Pawel Laszczak wrote: This patch restores the correct DMA mask after switching back to device mode. The issue occurred because Device part of controller use 32 bits DMA and Host side use 64 bits DMA. During loading XHCI driver the DMA mask used by driver is overwritten by

Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()

2019-10-07 Thread Guenter Roeck
Hi Max, On 10/6/19 9:04 PM, Max Filippov wrote: On Sun, Oct 6, 2019 at 3:25 PM Guenter Roeck wrote: this patch causes all my sparc64 emulations to stall during boot. It causes all alpha emulations to crash with [1a] and [1b] when booting from a virtual disk, and one of the xtensa emulations

[PATCH 1/2] usb: cdns3: fix cdns3_core_init_role()

2019-10-07 Thread Roger Quadros
At startup we should trigger the HW state machine only if it is OTG mode. Otherwise we should just start the respective role. Initialize idle role by default. If we don't do this then cdns3_idle_role_stop() is not called when switching to host/device role and so lane switch mechanism doesn't

[PATCH 2/2] usb: cdns3: gadget: Fix full-speed mode

2019-10-07 Thread Roger Quadros
We need to disable USB3 PHY for full-speed mode else gadget mode is broken. Signed-off-by: Roger Quadros Signed-off-by: Sekhar Nori --- drivers/usb/cdns3/gadget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c index

[PATCH 0/2] usb: cdns3: fixes for 5.4-rc

2019-10-07 Thread Roger Quadros
Hi, Here are 2 fixes we found while testing the cdns3 driver on our platform. The first one fixes a corner case where super-speed in host mode doesn't work if device was plugged before the cdns3 driver probes. The second one fixes the case when gadget driver is limited to full-speed. cheers,

Re: [PATCH 5/5] perf record: Put a copy of kcore into the perf.data directory

2019-10-07 Thread Adrian Hunter
On 7/10/19 2:20 PM, Jiri Olsa wrote: > On Fri, Oct 04, 2019 at 11:31:21AM +0300, Adrian Hunter wrote: > > SNIP > >> bool strict_freq; >> bool sample_id; >> bool no_bpf_event; >> +bool kcore; >> unsigned int freq; >> unsigned int

Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk()

2019-10-07 Thread Qian Cai
On Mon, 2019-10-07 at 13:37 +0200, Michal Hocko wrote: > On Mon 07-10-19 07:04:00, Qian Cai wrote: > > > > > > > On Oct 7, 2019, at 4:07 AM, Michal Hocko wrote: > > > > > > I do not think that removing the printk is the right long term solution. > > > While I do agree that removing the

Re: [PATCH 1/3] arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk

2019-10-07 Thread Shawn Guo
On Thu, Sep 19, 2019 at 01:05:57PM +0800, Anson Huang wrote: > On i.MX8MQ, usdhc's ipg clock is from IMX8MQ_CLK_IPG_ROOT, > assign it explicitly instead of using IMX8MQ_CLK_DUMMY. > > Signed-off-by: Anson Huang Fixes tag? Shawn > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++-- > 1

Re: [PATCH 5/5] perf record: Put a copy of kcore into the perf.data directory

2019-10-07 Thread Adrian Hunter
On 7/10/19 2:20 PM, Jiri Olsa wrote: > On Fri, Oct 04, 2019 at 11:31:21AM +0300, Adrian Hunter wrote: > > SNIP > >> +} >> + >> static int record__mmap_evlist(struct record *rec, >> struct evlist *evlist) >> { >> @@ -1383,6 +1417,12 @@ static int __cmd_record(struct

Re: [RFC][PATCH 0/9] Variable size jump_label support

2019-10-07 Thread Peter Zijlstra
In the failed thread Ingo posted: >On Mon, Oct 07, 2019 at 01:26:06PM +0200, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > > These here patches are something I've been poking at for a while, > > enabling jump_label to use 2 byte jumps/nops. > > > > It _almost_ works :-/ > > > > That is,

Re: [PATCH] bus: sunxi-rsb: Make interrupt handling more robust

2019-10-07 Thread Samuel Holland
Hello, On 8/24/19 12:50 PM, Samuel Holland wrote: > The RSB controller has two registers for controlling interrupt inputs: > RSB_INTE, which has bits for each possible interrupt, and the global > interrupt enable bit in RSB_CTRL. > > Currently, we enable the bits in RSB_INTE before each

Re: [PATCH 4/5] perf tools: Support single perf.data file directory

2019-10-07 Thread Adrian Hunter
On 7/10/19 2:20 PM, Jiri Olsa wrote: > On Fri, Oct 04, 2019 at 11:31:20AM +0300, Adrian Hunter wrote: > > SNIP > >> u8 pad[8] = {0}; >> >> -if (!perf_data__is_pipe(data) && !perf_data__is_dir(data)) { >> +if (!perf_data__is_pipe(data) && perf_data__is_single_file(data)) { >>

Re: [PATCH v2 3/3] drm/sun4i: sun6i_mipi_dsi: fix DCS long write packet length

2019-10-07 Thread Maxime Ripard
On Mon, Oct 07, 2019 at 12:03:02AM +0800, Icenowy Zheng wrote: > The packet length of DCS long write packet should not be added with 1 > when constructing long write packet. > > Fix this. > > Signed-off-by: Icenowy Zheng Applied, thanks Maxime signature.asc Description: PGP signature

[PATCH] perf session: Fix indent in perf_session__new()

2019-10-07 Thread Adrian Hunter
Minor white space fix. Reported-by: Jiri Olsa Signed-off-by: Adrian Hunter --- tools/perf/util/session.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 061bb4d6a3f5..5b7a85224cee 100644 ---

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-07 Thread Jarkko Sakkinen
On Mon, Oct 07, 2019 at 11:10:24AM +0300, Jarkko Sakkinen wrote: > Actually, maybe like this: > > struct sgx_enclave_add_page_desc { > __u64 addr; > __u64 offset; > __u64 secinfo; > __u16 mrmask; > __u8reserved[6]; > }; > > struct sgx_enclave_add_page {

[PATCH] usb: cdns3: Fix for incorrect DMA mask.

2019-10-07 Thread Pawel Laszczak
This patch restores the correct DMA mask after switching back to device mode. The issue occurred because Device part of controller use 32 bits DMA and Host side use 64 bits DMA. During loading XHCI driver the DMA mask used by driver is overwritten by XHCI driver so it must be restored to 32 bits.

[PATCH] usb: cdns3: Fix dequeue implementation.

2019-10-07 Thread Pawel Laszczak
Dequeuing implementation in cdns3_gadget_ep_dequeu gets first request from deferred_req_list and changed TRB associated with it to LINK TRB. This approach is incorrect because deferred_req_list contains requests that have not been placed on hardware RING. In this case driver should just giveback

Re: [PATCH v10 6/8] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

2019-10-07 Thread Hans Verkuil
On 10/7/19 2:03 PM, Ricardo Ribalda Delgado wrote: > Hi Hans > > > > On Mon, Oct 7, 2019 at 2:01 PM Hans Verkuil wrote: >> >> On 10/7/19 1:35 PM, Ricardo Ribalda Delgado wrote: >>> New control to pass to userspace the width/height of a pixel. Which is >>> needed for calibration and lens

Re: [PATCH] mfd: intel-lpss: use devm_ioremap_uc for mmio

2019-10-07 Thread Andy Shevchenko
On Mon, Sep 30, 2019 at 02:05:22PM +0300, Andy Shevchenko wrote: > On Fri, Sep 27, 2019 at 11:55:13AM -0600, Tuowen Zhao wrote: > > Write-combining BAR for intel-lpss-pci in MTRR causes system hangs > > during boot. > > > > This patch adds devm_ioremap_uc as a new managed wrapper to ioremap_uc >

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Walter Wu
On Mon, 2019-10-07 at 12:51 +0200, Dmitry Vyukov wrote: > On Mon, Oct 7, 2019 at 11:50 AM Walter Wu wrote: > > > > On Mon, 2019-10-07 at 17:28 +0800, Walter Wu wrote: > > > On Mon, 2019-10-07 at 11:10 +0200, Dmitry Vyukov wrote: > > > > On Mon, Oct 7, 2019 at 11:03 AM Walter Wu > > > > wrote: >

Re: [PATCH v10 6/8] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

2019-10-07 Thread Ricardo Ribalda Delgado
Hi Hans On Mon, Oct 7, 2019 at 2:01 PM Hans Verkuil wrote: > > On 10/7/19 1:35 PM, Ricardo Ribalda Delgado wrote: > > New control to pass to userspace the width/height of a pixel. Which is > > needed for calibration and lens selection. > > > > Reviewed-by: Philipp Zabel > > Signed-off-by:

[PATCH] net: phy: mscc: make arrays static, makes object smaller

2019-10-07 Thread Colin King
From: Colin Ian King Don't populate const arrays on the stack but instead make them static. Makes the object code smaller by 1058 bytes. Before: textdata bss dec hex filename 298796144 0 360238cb7 drivers/net/phy/mscc.o After: textdata bss

Re: [PATCH] clk: mark clk_disable_unused() as __init

2019-10-07 Thread Geert Uytterhoeven
On Fri, Oct 4, 2019 at 12:30 PM Rasmus Villemoes wrote: > clk_disable_unused is only called once, as a late_initcall, so reclaim > a bit of memory by marking it (and the functions and data it is the > sole user of) as __init/__initdata. This moves ~1900 bytes from .text > to .init.text for a

Re: [PATCH 1/3] perf/core: Provide a kernel-internal interface to recalibrate event period

2019-10-07 Thread Paolo Bonzini
On 30/09/19 09:22, Like Xu wrote: > -static int perf_event_period(struct perf_event *event, u64 __user *arg) > +static int _perf_event_period(struct perf_event *event, u64 value) __perf_event_period or perf_event_period_locked would be more consistent with other code in Linux. Paolo

Re: Re: printk meeting at LPC

2019-10-07 Thread Petr Mladek
On Fri 2019-10-04 09:48:24, Tony Asleson wrote: > On 9/13/19 8:26 AM, John Ogness wrote: > > 9. Support for printk dictionaries will be discontinued. I will look > > into who is using this and why. If printk dictionaries are important for > > you, speak up now! > > I think this functionality is

Re: [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1

2019-10-07 Thread Alain Volmat
Hi Pierre-Yves, thanks for the comments. On Mon, Oct 07, 2019 at 09:59:22AM +0200, Pierre Yves MORDRET wrote: > Hi Alain > > Fixes tag is missing in your patch. > [ i.e ==> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver") ] Okay, will push a v2 for that. > > Nonetheless patch only

Re: [PATCH v10 6/8] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

2019-10-07 Thread Hans Verkuil
On 10/7/19 1:35 PM, Ricardo Ribalda Delgado wrote: > New control to pass to userspace the width/height of a pixel. Which is > needed for calibration and lens selection. > > Reviewed-by: Philipp Zabel > Signed-off-by: Ricardo Ribalda Delgado > --- >

Re: [PATCH v22 08/24] x86/sgx: Enumerate and track EPC sections

2019-10-07 Thread Jarkko Sakkinen
On Sat, Oct 05, 2019 at 11:26:27AM +0200, Borislav Petkov wrote: > On Tue, Sep 03, 2019 at 05:26:39PM +0300, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > Enumerate Enclave Page Cache (EPC) sections via CPUID and add the data > > structures necessary to track EPC pages so that

Re: [PATCH] ARM: zx: Use devm_platform_ioremap_resource() in zx296702_pd_probe()

2019-10-07 Thread Shawn Guo
On Wed, Sep 18, 2019 at 07:57:05AM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 18 Sep 2019 07:40:26 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus

[PATCH] nfp: bpf: make array exp_mask static, makes object smaller

2019-10-07 Thread Colin King
From: Colin Ian King Don't populate the array exp_mask on the stack but instead make it static. Makes the object code smaller by 224 bytes. Before: textdata bss dec hex filename 778322290 0 80122 138fa ethernet/netronome/nfp/bpf/jit.o After: textdata

Re: [PATCH v2] kheaders: making headers archive reproducible

2019-10-07 Thread Greg KH
On Mon, Oct 07, 2019 at 01:49:47PM +0200, Andreas Schwab wrote: > GEN kernel/kheaders_data.tar.xz > tar: unrecognized option '--sort=name' > Try `tar --help' or `tar --usage' for more information. > make[2]: *** [kernel/kheaders_data.tar.xz] Error 64 > make[1]: *** [kernel] Error 2 > make:

Re: [PATCH] arm64: dts: lx2160a: Correct CPU core idle state name

2019-10-07 Thread Shawn Guo
On Tue, Sep 17, 2019 at 03:33:56PM +0800, Ran Wang wrote: > lx2160a support PW15 but not PW20, correct name to avoid confusing. > > Signed-off-by: Ran Wang Leo, agree? Shawn > --- > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 36 > +- > 1 file changed, 18

[RESEND][PATCH 1/2] regulator: da9062: Simplify the code iterating all regulators

2019-10-07 Thread Axel Lin
It's more straightforward to use for statement here. Signed-off-by: Axel Lin Acked-by: Steve Twiss --- This was sent on https://lkml.org/lkml/2019/7/11/208 with Adam's Ack. drivers/regulator/da9062-regulator.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [PATCH v2 1/3] drm/sun4i: dsi: Fix video start delay computation

2019-10-07 Thread Maxime Ripard
On Mon, Oct 07, 2019 at 12:03:00AM +0800, Icenowy Zheng wrote: > From: Jagan Teki > > The LCD timing definitions between Linux DRM vs Allwinner are different, > below diagram shows this clear differences. > >Active Front Sync Back >

[RESEND][PATCH 2/2] regulator: da9062: Simplify da9062_buck_set_mode for BUCK_MODE_MANUAL case

2019-10-07 Thread Axel Lin
The sleep flag bit decides the mode for BUCK_MODE_MANUAL case, simplify the logic as the result is the same. Signed-off-by: Axel Lin Reviewed-by: Adam Thomson --- This was sent on https://lkml.org/lkml/2019/9/26/24 with Adam's Review. drivers/regulator/da9062-regulator.c | 9 +++-- 1 file

Re: [PATCH v2] kheaders: making headers archive reproducible

2019-10-07 Thread Andreas Schwab
GEN kernel/kheaders_data.tar.xz tar: unrecognized option '--sort=name' Try `tar --help' or `tar --usage' for more information. make[2]: *** [kernel/kheaders_data.tar.xz] Error 64 make[1]: *** [kernel] Error 2 make: *** [sub-make] Error 2 $ tar --version tar (GNU tar) 1.26 Copyright (C) 2011

Re: [PATCH v10 04/16] leds: multicolor: Introduce a multicolor class definition

2019-10-07 Thread Dan Murphy
Jacek Thanks for the review On 10/6/19 10:23 AM, Jacek Anaszewski wrote: Dan, Thank you for the update. On 10/1/19 4:56 PM, Dan Murphy wrote: Introduce a multicolor class that groups colored LEDs within a LED node. The multi color class groups monochrome LEDs and allows controlling two

Re: [PATCH v1] arm64: dts: freescale: add initial support for colibri imx8x

2019-10-07 Thread Shawn Guo
On Mon, Sep 16, 2019 at 03:04:27PM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > This patch adds the device tree to support Toradex Colibri iMX8X a > computer on module which can be used on different carrier boards. > > The module consists of a NXP i.MX 8X family SoC (either i.MX

Re: x86/random: Speculation to the rescue

2019-10-07 Thread Theodore Y. Ts'o
On Sun, Oct 06, 2019 at 08:21:03PM +0200, Pavel Machek wrote: > Even without cycle counter... if we _know_ we are trying to generate > entropy and have MMC available, we don't care about power and > performance. > > So we can just... > >issue read request on MMC >while (!interrupt_done)

[PATCH] regulator: pbias: Get rid of struct pbias_regulator_data

2019-10-07 Thread Axel Lin
Only the desc field is really used, so use struct regulator_desc instead. Then struct pbias_regulator_data can be removed. Signed-off-by: Axel Lin --- drivers/regulator/pbias-regulator.c | 69 +++-- 1 file changed, 26 insertions(+), 43 deletions(-) diff --git

Re: [PATCH v2 2/7] iio: adc: max1027: Make it optional to use interrupts

2019-10-07 Thread Jonathan Cameron
On Mon, 7 Oct 2019 12:01:22 +0200 Miquel Raynal wrote: > Hi Jonathan, > > Jonathan Cameron wrote on Sun, 6 Oct 2019 11:18:37 > +0100: > > > On Thu, 3 Oct 2019 19:33:56 +0200 > > Miquel Raynal wrote: > > > > > The chip has a 'start conversion' and a 'end of conversion' pair of > > > pins.

[PATCH 2/2] usb: cdns3: Add TI specific wrapper driver

2019-10-07 Thread Roger Quadros
The J721e platform comes with 2 Cadence USB3 controller instances. This driver supports the TI specific wrapper on this platform. Signed-off-by: Roger Quadros Signed-off-by: Sekhar Nori --- drivers/usb/cdns3/Kconfig| 10 ++ drivers/usb/cdns3/Makefile | 1 +

[PATCH 0/2] usb: cdns3: Add TI wrapper

2019-10-07 Thread Roger Quadros
Hi, Texas Instruments SoCs have a wrapper module around the Cadence USB3 core. It takes care of clocking and powering the core and providing initial configuration to the core. This series adds the driver for the TI wrapper and associated DT binding document. This is for -next kernel. Thanks.

[PATCH 1/2] dt-bindings: usb: Add binding for the TI wrapper for Cadence USB3 controller

2019-10-07 Thread Roger Quadros
TI platforms have a wrapper module around the Cadence USB3 controller. Add binding information for that. Signed-off-by: Roger Quadros Signed-off-by: Sekhar Nori --- .../devicetree/bindings/usb/cdns-usb3-ti.txt | 59 +++ 1 file changed, 59 insertions(+) create mode 100644

Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk()

2019-10-07 Thread Michal Hocko
On Mon 07-10-19 07:04:00, Qian Cai wrote: > > > > On Oct 7, 2019, at 4:07 AM, Michal Hocko wrote: > > > > I do not think that removing the printk is the right long term solution. > > While I do agree that removing the debugging printk __offline_isolated_pages > > does make sense because it is

[PATCH v10 2/8] Documentation: v4l2_ctrl_new_std_compound

2019-10-07 Thread Ricardo Ribalda Delgado
From: Ricardo Ribalda Delgado Function for initializing compound controls with a default value. Suggested-by: Hans Verkuil Reviewed-by: Jacopo Mondi Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/kapi/v4l2-controls.rst | 9 + 1 file changed, 9 insertions(+) diff

[PATCH v10 1/8] media: v4l2-core: Implement v4l2_ctrl_new_std_compound

2019-10-07 Thread Ricardo Ribalda Delgado
From: Ricardo Ribalda Delgado Currently compound controls do not have a simple way of initializing its values. This results in ofuscated code with type_ops init. This patch introduces a new field on the control with the default value for the compound control that can be set with the brand new

[PATCH v10 7/8] media: v4l2-ctrl: Add new helper v4l2_ctrl_ptr_create

2019-10-07 Thread Ricardo Ribalda Delgado
This helper function simplifies the code by not needing a union v4l2_ctrl_ptr and an assignment every time we need to use a ctrl_ptr. Suggested-by: Hans Verkuil Signed-off-by: Ricardo Ribalda Delgado --- include/media/v4l2-ctrls.h | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v10 5/8] media: add V4L2_CID_UNIT_CELL_SIZE control

2019-10-07 Thread Ricardo Ribalda Delgado
This control returns the unit cell size in nanometres. The struct provides the width and the height in separated fields to take into consideration asymmetric pixels and/or hardware binning. This control is required for automatic calibration of sensors/cameras. Reviewed-by: Philipp Zabel

[PATCH v10 8/8] media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE

2019-10-07 Thread Ricardo Ribalda Delgado
According to the product brief, the unit cell size is 1120 nanometers^2. https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 9 + 1 file changed, 9 insertions(+)

[PATCH v10 4/8] Documentation: media: Document V4L2_CTRL_TYPE_AREA

2019-10-07 Thread Ricardo Ribalda Delgado
A struct v4l2_area containing the width and the height of a rectangular area. Reviewed-by: Jacopo Mondi Reviewed-by: Philipp Zabel Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v10 3/8] media: add V4L2_CTRL_TYPE_AREA control type

2019-10-07 Thread Ricardo Ribalda Delgado
From: Ricardo Ribalda Delgado This type contains the width and the height of a rectangular area. Reviewed-by: Jacopo Mondi Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-ctrls.c | 21 ++ include/media/v4l2-ctrls.h | 42

[PATCH v10 0/8] Implement UNIT_CELL_SIZE control

2019-10-07 Thread Ricardo Ribalda Delgado
UNIT_CELL_SIZE is a control that represents the size of a cell (pixel). We required a bit of boilerplate to add this control :) - New way to init compount controls - New control type Thanks to Hans, Jacopo and Philipp for your help. You might want to see the series at my github repository if

[PATCH v10 6/8] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

2019-10-07 Thread Ricardo Ribalda Delgado
New control to pass to userspace the width/height of a pixel. Which is needed for calibration and lens selection. Reviewed-by: Philipp Zabel Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/uapi/v4l/ext-ctrls-image-source.rst | 9 + 1 file changed, 9 insertions(+) diff

Re: [PATCH v2 02/13] static_call: Add basic static call infrastructure

2019-10-07 Thread Peter Zijlstra
On Mon, Oct 07, 2019 at 10:27:10AM +0200, Peter Zijlstra wrote: > +#define STATIC_CALL_PREFIX static_call_ Yesterday I got an allmodconfig build complaining about symbols being too long, in part due to this prefix. Should we change it to something like: "__SC__" ?

Re: [UNVERIFIED SENDER] Re: [PATCH v4 2/2] soc: amazon: al-pos-edac: Introduce Amazon's Annapurna Labs POS EDAC driver

2019-10-07 Thread Shenhar, Talel
thanks for the review On 10/7/2019 2:26 PM, Marc Zyngier wrote: On Thu, 03 Oct 2019 12:32:41 +0100, Talel Shenhar wrote: + log1 = readl(al_pos->mmio_base + AL_POS_ERROR_LOG_1); I already commented on the misuse of strict accesses. Unless you can explain and document *why* you need the

Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk()

2019-10-07 Thread Michal Hocko
On Mon 07-10-19 11:05:53, Petr Mladek wrote: > On Mon 2019-10-07 10:07:42, Michal Hocko wrote: > > On Fri 04-10-19 18:26:45, Qian Cai wrote: > > > It is unsafe to call printk() while zone->lock was held, i.e., > > > > > > zone->lock --> console_lock > > > > > > because the console could always

Re: [PATCH v2 00/13] Add static_call()

2019-10-07 Thread Peter Zijlstra
On Mon, Oct 07, 2019 at 10:27:08AM +0200, Peter Zijlstra wrote: > This series, which depends on the previous two, introduces static_call(). > > static_call(), is the idea of static_branch() applied to indirect function > calls. Remove a data load (indirection) by modifying the text. > > These

Re: [PATCH 1/7] dt-bindings: watchdog: renesas-wdt: Document r8a774b1 support

2019-10-07 Thread Geert Uytterhoeven
On Fri, Oct 4, 2019 at 10:35 AM Fabrizio Castro wrote: > RZ/G2N (a.k.a. R8A774B1) watchdog implementation is compatible > with R-Car Gen3, therefore add the relevant documentation. > > Signed-off-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 3/7] dt-bindings: PCI: rcar: Add device tree support for r8a774b1

2019-10-07 Thread Geert Uytterhoeven
On Fri, Oct 4, 2019 at 10:35 AM Fabrizio Castro wrote: > Add PCIe support for the RZ/G2N (a.k.a. R8A774B1). > > Signed-off-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH 2/7] dt-bindings: spi: sh-msiof: Add r8a774b1 support

2019-10-07 Thread Geert Uytterhoeven
On Fri, Oct 4, 2019 at 10:35 AM Fabrizio Castro wrote: > Document RZ/G2N (R8A774B1) SoC bindings. > > Signed-off-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH v3 0/2] perf: add support for logging debug messages to file

2019-10-07 Thread Jiri Olsa
On Fri, Oct 04, 2019 at 10:39:52AM +0800, Changbin Du wrote: > When in TUI mode, it is impossible to show all the debug messages to > console. This make it hard to debug perf issues using debug messages. > This patch adds support for logging debug messages to file to resolve > this problem. > >

Re: [PATCH v4 2/2] soc: amazon: al-pos-edac: Introduce Amazon's Annapurna Labs POS EDAC driver

2019-10-07 Thread Marc Zyngier
On Thu, 03 Oct 2019 12:32:41 +0100, Talel Shenhar wrote: > > The Amazon's Annapurna Labs SoCs includes Point Of Serialization error > logging unit that reports an error in case write error (e.g . Attempt to > write to a read only register). > This error shall be reported to EDAC subsystem as

[PATCH v2 00/13] Add static_call()

2019-10-07 Thread Peter Zijlstra
This series, which depends on the previous two, introduces static_call(). static_call(), is the idea of static_branch() applied to indirect function calls. Remove a data load (indirection) by modifying the text. These patches are still based on the work Josh did earlier, but incorporated

[PATCH v2 09/13] x86/alternatives: Teach text_poke_bp() to emulate RET

2019-10-07 Thread Peter Zijlstra
Future patches will need to poke a RET instruction, provide the infrastructure required for this. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/text-patching.h | 16 arch/x86/kernel/alternative.c|6 ++ 2 files changed, 22 insertions(+) ---

[PATCH v2 08/13] tracepoints: Use static_call

2019-10-07 Thread Peter Zijlstra
From: Steven Rostedt [peterz: updated to new interface] Signed-off-by: Steven Rostedt (VMware) Signed-off-by: Peter Zijlstra (Intel) --- include/linux/tracepoint-defs.h |5 ++ include/linux/tracepoint.h | 75 ++-- include/trace/define_trace.h

Re: [RFC][PATCH 0/9] Variable size jump_label support

2019-10-07 Thread Ingo Molnar
[ Sorry, fixed the Cc:lkml line. ] * Peter Zijlstra wrote: > These here patches are something I've been poking at for a while, > enabling jump_label to use 2 byte jumps/nops. > > It _almost_ works :-/ > > That is, you can build some kernels with it (x86_64-defconfig for > example works

[RFC][PATCH 5/9] jump_label, x86: Introduce jump_entry_size()

2019-10-07 Thread Peter Zijlstra
This allows architectures to have variable sized jumps. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/jump_label.h |4 ++-- arch/x86/kernel/jump_label.c |5 + include/linux/jump_label.h|9 + kernel/jump_label.c |2 +- 4

[RFC][PATCH 8/9] jump_label,objtool: Generate possible statistics

2019-10-07 Thread Peter Zijlstra
x86_64-defconfigx86_64-allmodconfig-UBSAN-KASAN NOP2164121796 JMP848 114 NOP5101031042 JMP32 29 91 Which results in a possible 3*(1641+48) ~ 5k saving for defconfig and 3*(21796+114)

Re: [PATCH] depmod: create and use System.map.no_namespaces

2019-10-07 Thread Jessica Yu
+++ Matthias Maennich [07/10/19 07:46 +0100]: Hi! On Sat, Oct 05, 2019 at 04:53:56PM +0900, Masahiro Yamada wrote: On Sat, Oct 5, 2019 at 3:25 AM Lucas De Marchi wrote: On Fri, Oct 4, 2019 at 2:57 AM Matthias Maennich wrote: depmod in its current version is not aware of symbol namespace

[RFC][PATCH 1/9] jump_label, x86: Strip ASM jump_label support

2019-10-07 Thread Peter Zijlstra
In prepration for variable size jump_label support; remove all ASM bits that are not used. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/entry/calling.h |2 +- arch/x86/include/asm/jump_label.h | 28 2 files changed, 5 insertions(+), 25

[PATCH v3 2/6] x86/alternatives: Update int3_emulate_push() comment

2019-10-07 Thread Peter Zijlstra
Update the comment now that we've merged x86_32 support. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/text-patching.h |3 +++ 1 file changed, 3 insertions(+) --- a/arch/x86/include/asm/text-patching.h +++ b/arch/x86/include/asm/text-patching.h @@ -85,6 +85,9 @@ static

[RFC][PATCH 6/9] jump_label, x86: Add variable length patching support

2019-10-07 Thread Peter Zijlstra
This allows the patching to to emit 2 byte JMP/NOP instruction in addition to the 5 byte JMP/NOP we already did. This allows for more compact code. This code is not yet used, as we don't emit shorter code at compile time yet. Signed-off-by: Peter Zijlstra (Intel) ---

Re: [PATCH v3] ARM: dts: imx6qdl-rex: add gpio expander pca9535

2019-10-07 Thread Shawn Guo
On Mon, Sep 16, 2019 at 12:43:53PM +0200, Gilles DOFFE wrote: > The pca9535 gpio expander is present on the Rex baseboard, but missing > from the dtsi. > The pca9535 is on i2c2 bus which is common to the three SOM > variants (Basic/Pro/Ultra), thus it is activated by default. > > Add also the new

[PATCH v3 4/6] x86/alternatives: Add and use text_gen_insn() helper

2019-10-07 Thread Peter Zijlstra
Provide a simple helper function to create common instruction encodings. Signed-off-by: Peter Zijlstra (Intel) Cc: Steven Rostedt Cc: Daniel Bristot de Oliveira Cc: Masami Hiramatsu --- arch/x86/include/asm/text-patching.h |2 + arch/x86/kernel/alternative.c| 36

[PATCH v2 01/13] compiler.h: Make __ADDRESSABLE() symbol truly unique

2019-10-07 Thread Peter Zijlstra
From: Josh Poimboeuf The __ADDRESSABLE() macro uses the __LINE__ macro to create a temporary symbol which has a unique name. However, if the macro is used multiple times from within another macro, the line number will always be the same, resulting in duplicate symbols. Make the temporary

[RFC][PATCH 4/9] jump_label, x86: Improve error when we fail expected text

2019-10-07 Thread Peter Zijlstra
There is only a single usage site left, remove the function and extend the print to include more information, like the expected text and the patch type. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/kernel/jump_label.c | 23 ++- 1 file changed, 10 insertions(+), 13

[PATCH v2 05/13] x86/static_call: Add out-of-line static call implementation

2019-10-07 Thread Peter Zijlstra
From: Josh Poimboeuf Add the x86 out-of-line static call implementation. For each key, a permanent trampoline is created which is the destination for all static calls for the given key. The trampoline has a direct jump which gets patched by static_call_update() when the destination function

[RFC][PATCH v2 13/13] x86/perf, static_call: Optimize x86_pmu methods

2019-10-07 Thread Peter Zijlstra
Replace many of the indirect calls with static_call(). XXX run performance numbers Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/events/core.c | 136 +++-- 1 file changed, 98 insertions(+), 38 deletions(-) --- a/arch/x86/events/core.c +++

[PATCH v2 12/13] static_call: Allow early init

2019-10-07 Thread Peter Zijlstra
In order to use static_call() to wire up x86_pmu, we need to initialize earlier; copy some of the tricks from jump_label to enable this. Primarily we overload key->next to store a sites pointer when there are no modules, this avoids having to use kmalloc() to initialize the sites and allows us to

[PATCH v2 02/13] static_call: Add basic static call infrastructure

2019-10-07 Thread Peter Zijlstra
From: Josh Poimboeuf Static calls are a replacement for global function pointers. They use code patching to allow direct calls to be used instead of indirect calls. They give the flexibility of function pointers, but with improved performance. This is especially important for cases where

[PATCH v2 06/13] x86/static_call: Add inline static call implementation for x86-64

2019-10-07 Thread Peter Zijlstra
From: Josh Poimboeuf Add the inline static call implementation for x86-64. For each key, a temporary trampoline is created, named __static_call_tramp_. The trampoline has an indirect jump to the destination function. Objtool uses the trampoline naming convention to detect all the call sites.

[PATCH v2 11/13] static_call: Handle tail-calls

2019-10-07 Thread Peter Zijlstra
GCC can turn our static_call(name)(args...) into a tail call, in which case we get a JMP.d32 into the trampoline (which then does a further tail-call). Teach objtool to recognise and mark these in .static_call_sites and adjust the code patching to deal with this. Signed-off-by: Peter Zijlstra

[RESEND] everything text-poke: ftrace, modules, static_call and jump_label

2019-10-07 Thread Peter Zijlstra
Because typing on a Monday is hard, here's a resend with the LKML address corrected. --- Hi All, Here are 4 series that have accumulated in my queue for a while and I figured I'd 'finish' and send out again. The first series is rewriting x86/ftrace to use the normal text_poke() interfaces we

<    5   6   7   8   9   10   11   12   13   >