Re: [PATCH v4 04/10] mtd: rawnand: stm32_fmc2: cleanup

2020-05-11 Thread Miquel Raynal
Hi Christophe, Christophe Kerello wrote on Tue, 12 May 2020 08:49:54 +0200: > Hi Miquel, > > On 5/11/20 10:39 PM, Miquel Raynal wrote: > > > > Christophe Kerello wrote on Wed, 6 May 2020 > > 11:11:13 +0200: > > > >> This patch renames functions and local variables. > >> This cleanup is don

[PATCH] mtd: offset align to block size bofore block operation

2020-05-11 Thread WeiXiong Liao
The off parameter on mtdpsore_block_*() does not align to block size, which makes some bugs. For example, a block contains dmesg zones with number 0 to 3. When user remove all these files, mapped to these zones, mtdpstore is expected to check whether No.0 to No.3 is unused then erase this block. Ho

Re: [PATCH v1 5/5] bus: mhi: core: Handle write lock properly in mhi_pm_m0_transition

2020-05-11 Thread Manivannan Sadhasivam
On Mon, May 11, 2020 at 07:03:09PM -0700, Hemant Kumar wrote: > Take write lock only to protect db_mode member of mhi channel. > This allows rest of the mhi channels to just take read lock which > fine grains the locking. It prevents channel readers to starve if > they try to enter critical section

BUG: unable to handle kernel paging request in bitfill_aligned

2020-05-11 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1d3962ae Merge tag 'io_uring-5.7-2020-05-08' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1487425810 kernel config: https://syzkaller.appspot.com/x/.config?x=b0212dbee046bc1f das

Re: [PATCH v1 4/5] bus: mhi: core: Do not process SYS_ERROR if RDDM is supported

2020-05-11 Thread Manivannan Sadhasivam
On Mon, May 11, 2020 at 07:03:08PM -0700, Hemant Kumar wrote: > Devices that support RDDM do not require processing SYS_ERROR as it is > deemed redundant. Avoid SYS_ERROR processing if RDDM is supported by > the device. > > Signed-off-by: Hemant Kumar > Reviewed-by: Jeffrey Hugo Reviewed-by: Ma

general protection fault in nfsd_reply_cache_free_locked

2020-05-11 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6e7f2eac Merge tag 'arm64-fixes' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1456703410 kernel config: https://syzkaller.appspot.com/x/.config?x=b0212dbee046bc1f das

Re: [PATCH] memory/samsung: reduce unnecessary mutex lock area

2020-05-11 Thread Krzysztof Kozlowski
On Fri, May 08, 2020 at 06:13:38AM -0700, Bernard Zhao wrote: > Maybe dmc->df->lock is unnecessary to protect function > exynos5_dmc_perf_events_check(dmc). If we have to protect, > dmc->lock is more better and more effective. > Also, it seems not needed to protect "if (ret) & dev_warn" > branch. >

Re: [PATCH v5] streamline_config.pl: add LMC_KEEP to preserve some kconfigs

2020-05-11 Thread Masahiro Yamada
On Sun, May 10, 2020 at 10:06 AM Changbin Du wrote: > > Sometimes it is useful to preserve batches of configs when making > localmodconfig. For example, I usually don't want any usb and fs > modules to be disabled. Now we can do it by: > > $ make LMC_KEEP="drivers/usb:fs" localmodconfig > > Signe

[PATCH v3] mtd: rawnand: brcmnand: correctly verify erased pages

2020-05-11 Thread Álvaro Fernández Rojas
The current code checks that the whole OOB area is erased. This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will fail due to the usable OOB bytes not being 0xff. Correct this by only checking that data and ECC bytes aren't 0xff. Fixes: 02b88eea9f9c ("mtd: brcmnand: Add chec

Re: [PATCH v1 3/5] bus: mhi: core: Skip handling BHI irq if MHI reg access is not allowed

2020-05-11 Thread Manivannan Sadhasivam
On Mon, May 11, 2020 at 07:03:07PM -0700, Hemant Kumar wrote: > Driver continues handling of BHI interrupt even if MHI register access > is not allowed. By doing so it calls the status call back and performs > early notification for the MHI client. This is not needed when MHI > register access is n

Re: [PATCH v4 04/10] mtd: rawnand: stm32_fmc2: cleanup

2020-05-11 Thread Christophe Kerello
Hi Miquel, On 5/11/20 10:39 PM, Miquel Raynal wrote: Christophe Kerello wrote on Wed, 6 May 2020 11:11:13 +0200: This patch renames functions and local variables. This cleanup is done to get all functions starting by stm32_fmc2_nfc in the FMC2 raw NAND driver when all functions will start by

Re: [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-11 Thread Chao Yu
On 2020/5/12 11:24, Jaegeuk Kim wrote: > On 05/12, Chao Yu wrote: >> On 2020/5/12 6:11, Jaegeuk Kim wrote: >>> On 05/11, Chao Yu wrote: On 2020/5/10 3:03, Jaegeuk Kim wrote: > On 05/09, Chao Yu wrote: >> On 2020/5/9 0:10, Jaegeuk Kim wrote: >>> Hi Sayali, >>> >>> In order t

Re: [PATCH] mm, swap: Use prandom_u32_max()

2020-05-11 Thread Michal Hocko
On Tue 12-05-20 14:41:46, Huang Ying wrote: > To improve the code readability and get random number with higher > quality. I understand the readability argument but why should prandom_u32_max (which I was not aware of) provide a higher quality randomness? > Signed-off-by: "Huang, Ying" > Cc: Mic

Re: signal quality and cable diagnostic

2020-05-11 Thread Oleksij Rempel
On Mon, May 11, 2020 at 04:59:26PM +0200, Michal Kubecek wrote: > On Mon, May 11, 2020 at 04:13:10PM +0200, Oleksij Rempel wrote: > > > > I continue to work on TJA11xx PHY and need to export some additional > > cable diagnostic/link stability information: Signal Quality Index (SQI). > > The PHY da

Re: [PATCH v1 2/5] bus: mhi: core: Handle disable transitions in state worker

2020-05-11 Thread Manivannan Sadhasivam
On Mon, May 11, 2020 at 07:03:06PM -0700, Hemant Kumar wrote: > Mission mode transition is handled by state worker thread but > power off is not. There is a possibility while mission mode > transition is in progress which calls MHI client driver probe, > power off is issued by MHI controller. This

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-11 Thread Martijn Coenen
Hi Jens, What do you think of this series? Thanks, Martijn On Wed, Apr 29, 2020 at 4:03 PM Martijn Coenen wrote: > > This allows userspace to completely setup a loop device with a single > ioctl, removing the in-between state where the device can be partially > configured - eg the loop device h

Re: [PATCH v1 1/5] bus: mhi: core: Remove the system error worker thread

2020-05-11 Thread Manivannan Sadhasivam
On Mon, May 11, 2020 at 07:03:05PM -0700, Hemant Kumar wrote: > Remove the system error worker thread and instead have the > execution environment worker handle that transition to serialize > processing and avoid any possible race conditions during > shutdown. > > Signed-off-by: Hemant Kumar > Re

Re: [PATCH 3/3] ALSA: hda/realtek: Enable headset mic of ASUS UX581LV with ALC295

2020-05-11 Thread Takashi Iwai
On Tue, 12 May 2020 08:15:28 +0200, Jian-Hong Pan wrote: > > The ASUS UX581LV laptop's audio (1043:19e1) with ALC295 can't detect the > headset microphone until ALC295_FIXUP_ASUS_MIC_NO_PRESENCE quirk > applied. > > Signed-off-by: Jian-Hong Pan Applied, thanks. Takashi

Re: [PATCH 1/3] ALSA: hda/realtek - Enable headset mic of ASUS GL503VM with ALC295

2020-05-11 Thread Takashi Iwai
On Tue, 12 May 2020 08:15:24 +0200, Jian-Hong Pan wrote: > > From: Chris Chiu > > The ASUS laptop GL503VM with ALC295 can't detect the headset microphone. > The headset microphone does not work until pin 0x19 is enabled for it. > > Signed-off-by: Chris Chiu > Signed-off-by: Daniel Drake > Sig

Re: [PATCH 2/3] ALSA: hda/realtek - Enable headset mic of ASUS UX550GE with ALC295

2020-05-11 Thread Takashi Iwai
On Tue, 12 May 2020 08:15:26 +0200, Jian-Hong Pan wrote: > > The ASUS laptop UX550GE with ALC295 can't detect the headset microphone > until ALC295_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. > > Signed-off-by: Jian-Hong Pan > Signed-off-by: Daniel Drake Applied, thanks. Takashi

RE: [PATCH v7 3/7] i3c: master: add i3c_secondary_master_register

2020-05-11 Thread Parshuram Raju Thombare
>Can you really select the bus mode without knowing the I3C devices you >have on the bus? Or maybe that's a preliminary initialization which is >then updated when you receive DEFSLVS events. I think we can select bus mode based on knowledge of I2C devices on the bus. I was expecting to support dif

[PATCH] mm, swap: Use prandom_u32_max()

2020-05-11 Thread Huang Ying
To improve the code readability and get random number with higher quality. Signed-off-by: "Huang, Ying" Cc: Michal Hocko Cc: Minchan Kim Cc: Tim Chen Cc: Hugh Dickins --- mm/swapfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/swapfile.c b/mm/swapfile.c index a0a

[PATCH] devfreq: Use lockdep asserts instead of manual checks for locked mutex

2020-05-11 Thread Krzysztof Kozlowski
Instead of warning when mutex_is_locked(), just use the lockdep framework. The code is smaller and checks could be disabled for production environments (it is useful only during development). Put asserts at beginning of function, even before validating arguments. The behavior of update_devfreq()

[PATCH rdma-next 0/2] Fix kasan compilation warnings

2020-05-11 Thread Leon Romanovsky
From: Leon Romanovsky Hi, The following two fixes are adding missing function prototypes declarations to internal kasan header in order to eliminate compilation warnings. Thanks Leon Romanovsky (2): kasan: fix compilation warnings due to missing function prototypes kasan: add missing proto

Re: [PATCH v2] usb: raw-gadget: fix gadget endpoint selection

2020-05-11 Thread Felipe Balbi
Greg Kroah-Hartman writes: > On Sat, May 09, 2020 at 11:02:13AM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Andrey Konovalov writes: >> >> here you're changing userspace ABI. Aren't we going to possibly break >> >> some existing applications? >> > >> > Hi Felipe, >> > >> > I've been working on

[PATCH rdma-next 2/2] kasan: add missing prototypes to fix compilation warnings

2020-05-11 Thread Leon Romanovsky
From: Leon Romanovsky Use internal kasan header to declare missing prototypes to fix the following compilation warnings. mm/kasan/report.c:457:6: warning: no previous prototype for 'report_enabled' [-Wmissing-prototypes] 457 | bool report_enabled(void) | ^~ mm/kasan/rep

Re: MAINTAINERS: Wrong ordering in VIRTIO BALLOON

2020-05-11 Thread David Hildenbrand
On 12.05.20 07:21, Lukas Bulwahn wrote: > Hi David, > > with your commit 6d6b93b9afd8 ("MAINTAINERS: Add myself as virtio-balloon > co-maintainer"), visible on next-20200508, ./scripts/checkpatch.pl -f > MAINTAINERS complains: > > WARNING: Misordered MAINTAINERS entry - list file patterns in al

Re: [PATCH v2 0/3] arm64: perf_event: Fix time offset prior to epoch

2020-05-11 Thread Leo Yan
Hi Peter, On Mon, May 11, 2020 at 11:25:19AM +0200, Peter Zijlstra wrote: > On Mon, May 11, 2020 at 11:22:00AM +0200, Peter Zijlstra wrote: > > > (_completely_ untested) > > > > --- > > arch/arm64/kernel/perf_event.c | 27 ++- > > include/linux/sched_clock.h| 28

Re: net/sonic: Fix some resource leaks in error handling paths

2020-05-11 Thread Markus Elfring
> Markus, if you were to write a patch to improve upon coding-style.rst, > who should review it? All involved contributors have got chances to provide constructive comments. I would be curious who will actually dare to contribute further ideas for this area. > If you are unable to write or revi

[PATCH rdma-next 1/2] kasan: fix compilation warnings due to missing function prototypes

2020-05-11 Thread Leon Romanovsky
From: Leon Romanovsky __asan_report_* function generates the following warnings while compiling kernel, add them to the internal header to be aligned with other __asan_* function prototypes. mm/kasan/generic_report.c:130:6: warning: no previous prototype for '__asan_report_load1_noabort' [-Wmis

Re: [PATCH v2 09/14] net: ethernet: mtk-eth-mac: new driver

2020-05-11 Thread Bartosz Golaszewski
pon., 11 maj 2020 o 21:24 Florian Fainelli napisał(a): > > > > On 5/11/2020 8:07 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC > > family. For now we only support full-duplex. > > > > Signed-off-by: Bar

[PATCH] scsi: hisi_sas: display correct proc_name in sysfs

2020-05-11 Thread Jason Yan
The 'proc_name' entry in sysfs for hisi_sas is 'null' now becuase it is not initialized in scsi_host_template. It looks like: [root@localhost ~]# cat /sys/class/scsi_host/host2/proc_name (null) While the other driver's entry looks like: linux-vnMQMU:~ # cat /sys/class/scsi_host/host0/proc_name m

Re: [PATCH] ASoC: rsnd: add interrupt support for SSI BUSIF buffer

2020-05-11 Thread kbuild test robot
Hi Yongbo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on asoc/for-next] [also build test WARNING on v5.7-rc4 next-20200508] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

RE: [EXT] Re: [PATCH v1 net-next 3/3] net: dsa: felix: add support Credit Based Shaper(CBS) for hardware offload

2020-05-11 Thread Xiaoliang Yang
Hi Jakub, On Mon, 11 May 2020 22:34:32 Jakub Kicinski wrote: > > +int vsc9959_qos_port_cbs_set(struct dsa_switch *ds, int port, > > + struct tc_cbs_qopt_offload *cbs_qopt) > > static I will update this in v2, thanks. Regards, Xiaoliang Yang

Re: [RFC PATCH 00/14] iio: buffer: add support for multiple buffers

2020-05-11 Thread Ardelean, Alexandru
On Mon, 2020-05-11 at 21:56 +0200, Lars-Peter Clausen wrote: > [External] > > On 5/11/20 4:56 PM, Ardelean, Alexandru wrote: > > On Mon, 2020-05-11 at 15:58 +0200, Lars-Peter Clausen wrote: > > > [External] > > > > > > On 5/11/20 3:24 PM, Ardelean, Alexandru wrote: > > > > On Mon, 2020-05-11 at 1

Re: [RFC PATCH v2 1/7] block: Extand commit_rqs() to do batch processing

2020-05-11 Thread Sagi Grimberg
devices will benefit from the batching so maybe the flag needs to be inverted? BLK_MQ_F_DONT_BATCHING_SUBMISSION? Actually I'd rather to not add any flag, and we may use some algorithm (maybe EWMA or other intelligent stuff, or use hctx->dispatch_busy directly) to figure out one dynamic batch

RE: [PATCH v7 4/7] i3c: master: add mastership handover support

2020-05-11 Thread Parshuram Raju Thombare
>Those waits should be done in the master driver. Pass a timeout to >->request_master() or make it a property of the i3c_master_controller >if you like, but don't poll the status from the core. Ok, I will move these pollings, check master has DA and MR done to master driver method request_masters

RE: [EXT] Re: [PATCH v1 net-next 1/3] net: dsa: felix: qos classified based on pcp

2020-05-11 Thread Xiaoliang Yang
Hi Vladimir, On Mon, 11 May 2020 at 08:19, Vladimir Oltean wrote: > > The new skbedit priority offload action looks interesting to me. > But it also raises the question of what to do in the default case where such > rules are not installed. I think it is ok to support a > 1-to-1 VLAN PCP to TC

[PATCH 3/3] ALSA: hda/realtek: Enable headset mic of ASUS UX581LV with ALC295

2020-05-11 Thread Jian-Hong Pan
The ASUS UX581LV laptop's audio (1043:19e1) with ALC295 can't detect the headset microphone until ALC295_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/so

Re: [PATCH -next] s390: Remove two unused inline functions

2020-05-11 Thread Sven Schnelle
Hi Joe, On Mon, May 11, 2020 at 01:38:57PM -0700, Joe Perches wrote: > Awhile back, I posted a list of apparently unused static inline > functions in .h files treewide found by a script: > > https://lore.kernel.org/lkml/4603e761a5f39f4d97375e1e08d20d720c526341.ca...@perches.com/ > > Here are th

Re: [PATCH v4 00/16] mtd: spi-nor: add xSPI Octal DTR support

2020-05-11 Thread Tudor.Ambarus
Hi, Boris, Pratyush, I stripped case 2/, we'll not treat it for now. On Monday, May 11, 2020 12:27:12 PM EEST Boris Brezillon wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 11 May 2020 09:00:35 + > > wrote: > > Hi, Pratyush

[PATCH 2/3] ALSA: hda/realtek - Enable headset mic of ASUS UX550GE with ALC295

2020-05-11 Thread Jian-Hong Pan
The ASUS laptop UX550GE with ALC295 can't detect the headset microphone until ALC295_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Jian-Hong Pan Signed-off-by: Daniel Drake --- sound/pci/hda/patch_realtek.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/patch_r

[PATCH 1/3] ALSA: hda/realtek - Enable headset mic of ASUS GL503VM with ALC295

2020-05-11 Thread Jian-Hong Pan
From: Chris Chiu The ASUS laptop GL503VM with ALC295 can't detect the headset microphone. The headset microphone does not work until pin 0x19 is enabled for it. Signed-off-by: Chris Chiu Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 14 +

[PATCH] hpet: Fix a small information leak

2020-05-11 Thread Allen Pais
hpet_info has a hole in it cause of which we might end up leaking a few bytes. Zero them with memset(). Fixes: 54066a57c584 ("hpet: kill BKL, add compat_ioctl") Signed-off-by: Allen Pais --- drivers/char/hpet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hpet.c b/drivers/c

Re: [Intel-gfx] [PATCH 3/3] misc/habalabs: don't set default fence_ops->wait

2020-05-11 Thread Daniel Vetter
On Tue, May 12, 2020 at 4:14 AM Dave Airlie wrote: > > On Mon, 11 May 2020 at 19:37, Oded Gabbay wrote: > > > > On Mon, May 11, 2020 at 12:11 PM Daniel Vetter > > wrote: > > > > > > It's the default. > > Thanks for catching that. > > > > > > > > Also so much for "we're not going to tell the gra

Re: next/master bisection: baseline.login on jetson-tk1

2020-05-11 Thread Guillaume Tucker
i.org/next/master/next-20200511/arm/tegra_defconfig/gcc-8/lab-collabora/baseline-tegra124-jetson-tk1.html#L573 Stack trace: <0>[2.953683] [] (__iommu_probe_device) from [] (iommu_probe_device+0x18/0x124) <0>[2.962810] [] (iommu_probe_device) from [] (of_iommu_con

Re: [PATCH v2 05/14] net: core: provide priv_to_netdev()

2020-05-11 Thread Bartosz Golaszewski
pon., 11 maj 2020 o 22:41 David Miller napisał(a): > > From: Bartosz Golaszewski > Date: Mon, 11 May 2020 17:07:50 +0200 > > > From: Bartosz Golaszewski > > > > Appropriate amount of extra memory for private data is allocated at > > the end of struct net_device. We have a helper - netdev_priv()

Re: [PATCH net] net: broadcom: Imply BROADCOM_PHY for BCMGENET

2020-05-11 Thread Marek Szyprowski
Hi Florian, On 11.05.2020 20:19, Florian Fainelli wrote: > On 5/11/2020 12:21 AM, Marek Szyprowski wrote: >> On 09.05.2020 00:32, Florian Fainelli wrote: >>> The GENET controller on the Raspberry Pi 4 (2711) is typically >>> interfaced with an external Broadcom PHY via a RGMII electrical >>> inter

[PATCH v3 1/2] mtd: rawnand: brcmnand: fix hamming oob layout

2020-05-11 Thread Álvaro Fernández Rojas
First 2 bytes are used in large-page nand. Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops") Cc: sta...@vger.kernel.org Signed-off-by: Álvaro Fernández Rojas --- v3: invert patch order v2: extend original comment drivers/mtd/nand/raw/brcmnand/brcmnand.c | 11 +++ 1

[PATCH v3 2/2] mtd: rawnand: brcmnand: improve hamming oob layout

2020-05-11 Thread Álvaro Fernández Rojas
The current code generates 8 oob sections: S1 1-5 ECC 6-8 S2 9-15 S3 16-21 ECC 22-24 S4 25-31 S5 32-37 ECC 38-40 S6 41-47 S7 48-53 ECC 54-56 S8 57-63 Change it by merging continuous sections: S1 1-5 ECC 6-8 S2 9-21 ECC 22-24

[PATCH v3 0/2] mtd: rawnand: brcmnand: improve hamming oob layout

2020-05-11 Thread Álvaro Fernández Rojas
These patches improve the OOB hamming layout by reducing the number of oob sections and correctly v3: invert patch order. v2: extend original comment and correctly skip byte 6 for small-page. Álvaro Fernández Rojas (2): mtd: rawnand: brcmnand: fix hamming oob layout mtd: rawnand: brcmnand: i

[PATCH v2 bpf-next 0/7] bpf, printk: add BTF-based type printing

2020-05-11 Thread Alan Maguire
The printk family of functions support printing specific pointer types using %p format specifiers (MAC addresses, IP addresses, etc). For full details see Documentation/core-api/printk-formats.rst. This patchset proposes introducing a "print typed pointer" format specifier "%pT"; the argument ass

[PATCH v2 bpf-next 3/7] checkpatch: add new BTF pointer format specifier

2020-05-11 Thread Alan Maguire
checkpatch complains about unknown format specifiers, so add the BTF format specifier we will implement in a subsequent patch to avoid errors. Signed-off-by: Alan Maguire --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts

[PATCH v2 bpf-next 2/7] bpf: move to generic BTF show support, apply it to seq files/strings

2020-05-11 Thread Alan Maguire
generalize the "seq_show" seq file support in btf.c to support a generic show callback of which we support two instances; the current seq file show, and a show with snprintf() behaviour which instead writes the type data to a supplied string. Both classes of show function call btf_type_show() with

[PATCH v2 bpf-next 5/7] printk: extend test_printf to test %pT BTF-based format specifier

2020-05-11 Thread Alan Maguire
Add tests to verify basic type display and to iterate through all enums, structs, unions and typedefs ensuring expected behaviour occurs. Since test_printf can be built as a module we need to export a BTF kind iterator function to allow us to iterate over all names of a particular BTF kind. These

[PATCH v2 bpf-next 1/7] bpf: provide function to get vmlinux BTF information

2020-05-11 Thread Alan Maguire
It will be used later for BTF printk() support Signed-off-by: Alan Maguire --- include/linux/bpf.h | 2 ++ kernel/bpf/verifier.c | 18 -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index cf4b6e4..de19a35 100644 ---

[PATCH v2 bpf-next 7/7] bpf: add tests for %pT format specifier

2020-05-11 Thread Alan Maguire
tests verify we get > 0 return value from bpf_trace_print() using %pT format specifier with various modifiers/pointer values. Signed-off-by: Alan Maguire --- .../selftests/bpf/prog_tests/trace_printk_btf.c| 83 ++ .../selftests/bpf/progs/netif_receive_skb.c| 81 ++

[PATCH v2 bpf-next 6/7] bpf: add support for %pT format specifier for bpf_trace_printk() helper

2020-05-11 Thread Alan Maguire
Allow %pT[cNx0] format specifier for BTF-based display of data associated with pointer. Signed-off-by: Alan Maguire --- include/uapi/linux/bpf.h | 27 ++- kernel/trace/bpf_trace.c | 21 ++--- tools/include/uapi/linux/bpf.h | 27

[PATCH v2 bpf-next 4/7] printk: add type-printing %pT format specifier which uses BTF

2020-05-11 Thread Alan Maguire
printk supports multiple pointer object type specifiers (printing netdev features etc). Extend this support using BTF to cover arbitrary types. "%pT" specifies the typed format, and the pointer argument is a "struct btf_ptr *" where struct btf_ptr is as follows: struct btf_ptr { void *pt

Re: [PATCH v8 10/11] mtd: Support kmsg dumper based on pstore/blk

2020-05-11 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/12 下午1:12, Kees Cook wrote: > [resend to proper CC list...] > > On Tue, May 12, 2020 at 11:12:42AM +0800, WeiXiong Liao wrote: >> hi Kees Cook, >> >> The off parameter on mtdpsore_block*() does not align to block size, >> which makes some bugs. For example, a block contain

Re: [PATCH] gcc-plugins: remove always false $(if ...) in Makefile

2020-05-11 Thread Masahiro Yamada
On Sun, May 10, 2020 at 11:14 AM Kees Cook wrote: > > On Sun, May 10, 2020 at 11:00:44AM +0900, Masahiro Yamada wrote: > > This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused > > GCC_PLUGIN_SUBDIR"). > > > > $(if $(findstring /,$(p)),...) is always false because none of plugins

Re: stable/linux-4.4.y bisection: baseline.login on at91-sama5d4_xplained

2020-05-11 Thread Guillaume Tucker
Please see the bisection report below about a boot failure. Reports aren't automatically sent to the public while we're trialing new bisection features on kernelci.org but this one looks valid. It appears to be due to the fact that the network interface is failing to get brought up: [ 114.38500

Re: [PATCH] Makefile: support compressed debug info

2020-05-11 Thread Masahiro Yamada
On Tue, May 5, 2020 at 9:47 AM Fangrui Song wrote: > > > On 2020-05-04, Sedat Dilek wrote: > >On Mon, May 4, 2020 at 5:13 AM Nick Desaulniers > > wrote: > >> > >> As debug information gets larger and larger, it helps significantly save > >> the size of vmlinux images to compress the information in

Re: [PATCH] ifcvf: move IRQ request/free to status change handlers

2020-05-11 Thread Jason Wang
On 2020/5/12 上午11:38, Jason Wang wrote:   static int ifcvf_start_datapath(void *private)   {   struct ifcvf_hw *vf = ifcvf_private_to_vf(private); @@ -118,9 +172,12 @@ static void ifcvf_vdpa_set_status(struct vdpa_device *vdpa_dev, u8 status)   {   struct ifcvf_adapter *adapter;

Re: [PATCH v8 01/11] pstore/zone: Introduce common layer to manage storage zones

2020-05-11 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/12 PM 1:15, Kees Cook wrote: > On Tue, May 12, 2020 at 11:55:20AM +0800, WeiXiong Liao wrote: >> On 2020/5/12 AM 7:32, Kees Cook wrote: >>> [...] >>> +struct psz_context { >>> + struct pstore_zone **kpszs; >>> + unsigned int kmsg_max_cnt; >>> + unsigned int kmsg_read_

Re: [PATCH] Makefile: support compressed debug info

2020-05-11 Thread Masahiro Yamada
Hi Sedat, On Tue, May 5, 2020 at 1:25 AM Sedat Dilek wrote: > > On Mon, May 4, 2020 at 5:13 AM Nick Desaulniers > wrote: > > > > As debug information gets larger and larger, it helps significantly save > > the size of vmlinux images to compress the information in the debug > > information secti

Re: linux-next: manual merge of the vfs tree with the parisc-hd tree

2020-05-11 Thread Luis Chamberlain
On Mon, May 11, 2020 at 10:22:04PM -0700, Kees Cook wrote: > On Tue, May 12, 2020 at 12:33:05AM +, Luis Chamberlain wrote: > > On Mon, May 11, 2020 at 09:55:16AM +0800, Xiaoming Ni wrote: > > > On 2020/5/11 9:11, Stephen Rothwell wrote: > > > > Hi all, > > > > > > > > Today's linux-next merge

Re: [PATCH -next] iommu/msm: Make msm_iommu_lock static

2020-05-11 Thread Bjorn Andersson
On Mon 11 May 19:17 PDT 2020, Samuel Zou wrote: > Fix the following sparse warning: > > drivers/iommu/msm_iommu.c:37:1: warning: symbol 'msm_iommu_lock' was not > declared. > > The msm_iommu_lock has only call site within msm_iommu.c > It should be static > Reviewed-by: Bjorn Andersson Rega

Re: [v2 4/4] regulator: qcom: labibb: Add SC interrupt handling

2020-05-11 Thread Bjorn Andersson
On Fri 08 May 13:42 PDT 2020, Sumit Semwal wrote: > From: Nisha Kumari > > Add Short circuit interrupt handling and recovery for the lab and > ibb regulators on qcom platforms. > > The client panel drivers need to register for REGULATOR_EVENT_OVER_CURRENT > notification which will be triggered

Re: [PATCH v2] tpm: eventlog: Replace zero-length array with flexible-array member

2020-05-11 Thread Kees Cook
On Fri, May 08, 2020 at 11:38:26AM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced i

[tip:core/rcu] BUILD SUCCESS 68f0f2690e183306b52671a9ad09fb31808b0500

2020-05-11 Thread kbuild test robot
onfig-a006-20200511 i386 randconfig-a005-20200511 i386 randconfig-a003-20200511 i386 randconfig-a001-20200511 i386 randconfig-a004-20200511 i386 randconfig-a002-20200511 x86_64 randconfig-a006-20200

Re: linux-next: manual merge of the vfs tree with the parisc-hd tree

2020-05-11 Thread Kees Cook
On Tue, May 12, 2020 at 12:33:05AM +, Luis Chamberlain wrote: > On Mon, May 11, 2020 at 09:55:16AM +0800, Xiaoming Ni wrote: > > On 2020/5/11 9:11, Stephen Rothwell wrote: > > > Hi all, > > > > > > Today's linux-next merge of the vfs tree got a conflict in: > > > > > >kernel/sysctl.c > >

MAINTAINERS: Wrong ordering in VIRTIO BALLOON

2020-05-11 Thread Lukas Bulwahn
Hi David, with your commit 6d6b93b9afd8 ("MAINTAINERS: Add myself as virtio-balloon co-maintainer"), visible on next-20200508, ./scripts/checkpatch.pl -f MAINTAINERS complains: WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order #17982: FILE: MAINTAINERS:17982: +F:

Re: [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-11 Thread Madhuparna Bhowmik
On Sat, May 09, 2020 at 02:19:38PM -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 12:52:44 +0530 Amol Grover wrote: > > ipmr_for_each_table() uses list_for_each_entry_rcu() for > > traversing outside of an RCU read-side critical section but > > under the protection of pernet_ops_rwsem. Hence ad

Re: [PATCH 2/3] remoteproc: Add inline coredump functionality

2020-05-11 Thread Bjorn Andersson
On Mon 11 May 17:41 PDT 2020, risha...@codeaurora.org wrote: > On 2020-05-11 17:30, Bjorn Andersson wrote: > > On Mon 11 May 17:11 PDT 2020, risha...@codeaurora.org wrote: > > > On 2020-05-07 13:21, Bjorn Andersson wrote: > > > > On Thu 16 Apr 11:38 PDT 2020, Rishabh Bhatnagar wrote: > > > > > dif

Re: [PATCH v8 01/11] pstore/zone: Introduce common layer to manage storage zones

2020-05-11 Thread Kees Cook
On Tue, May 12, 2020 at 11:55:20AM +0800, WeiXiong Liao wrote: > On 2020/5/12 AM 7:32, Kees Cook wrote: > > [...] > > +struct psz_context { > > + struct pstore_zone **kpszs; > > + unsigned int kmsg_max_cnt; > > + unsigned int kmsg_read_cnt; > > + unsigned int kmsg_write_cnt; > > + /* > >

Re: Re: signal quality and cable diagnostic

2020-05-11 Thread Oleksij Rempel
On Mon, May 11, 2020 at 09:54:35PM +0200, Andrew Lunn wrote: > On Mon, May 11, 2020 at 07:32:05PM +, Christian Herber wrote: > > On May 11, 2020 4:33:53 PM Andrew Lunn wrote: > > > > > > Are the classes part of the Open Alliance specification? Ideally we > > > want to report something standard

Re: [PATCH] dma-buf: fix use-after-free in dmabuffs_dname

2020-05-11 Thread Charan Teja Kalla
Thank you Greg for the comments. On 5/6/2020 2:30 PM, Greg KH wrote: On Wed, May 06, 2020 at 02:00:10PM +0530, Charan Teja Kalla wrote: Thank you Greg for the reply. On 5/5/2020 3:38 PM, Greg KH wrote: On Tue, Apr 28, 2020 at 01:24:02PM +0530, Charan Teja Reddy wrote: The following race oc

Re: [PATCH v8 10/11] mtd: Support kmsg dumper based on pstore/blk

2020-05-11 Thread Kees Cook
[resend to proper CC list...] On Tue, May 12, 2020 at 11:12:42AM +0800, WeiXiong Liao wrote: > hi Kees Cook, > > The off parameter on mtdpsore_block*() does not align to block size, > which makes some bugs. For example, a block contains 4 dmesg zones > and it's expected to erase this block when u

RE: [PATCH v7 1/7] i3c: master: secondary master initialization document

2020-05-11 Thread Parshuram Raju Thombare
>> Document describing secondary master initialization, >> mastership handover and DEFSLVS handling processes. > >Thanks for doing that, but you probably didn't try to compile the doc >(the formatting is all messed up). > ># make htmldocs Yes, it looks messed in email but I built html format of do

Re: linux-next boot error: WARNING: suspicious RCU usage in ip6mr_get_table

2020-05-11 Thread Madhuparna Bhowmik
On Tue, May 12, 2020 at 11:28:47AM +1000, Stephen Rothwell wrote: > Hi all, > > On Fri, 8 May 2020 04:54:02 +0530 Madhuparna Bhowmik > wrote: > > > > On Thu, May 07, 2020 at 08:50:55AM -0400, Qian Cai wrote: > > > > > > > > > > On May 7, 2020, at 5:32 AM, Dmitry Vyukov wrote: > > > > > > >

Re: [PATCH] kernel: sysctl: ignore invalid taint bits introduced via kernel.tainted and taint the kernel with TAINT_USER on writes

2020-05-11 Thread Luis Chamberlain
On Mon, May 11, 2020 at 09:03:13PM -0400, Rafael Aquini wrote: > On Tue, May 12, 2020 at 12:17:03AM +, Luis Chamberlain wrote: > > On Mon, May 11, 2020 at 07:59:14PM -0400, Rafael Aquini wrote: > > > On Mon, May 11, 2020 at 11:10:45PM +, Luis Chamberlain wrote: > > > > On Mon, May 11, 2020

[PATCH] perf record: Use an eventfd to wakeup when done

2020-05-11 Thread Anand K Mistry
The setting and checking of 'done' contains a rare race where the signal handler setting 'done' is run after checking to break the loop, but before waiting in evlist__poll(). In this case, the main loop won't wake up until either another signal is sent, or the perf data fd causes a wake up. The fo

RE: [PATCH v7 2/7] i3c: master: use i3c_master_register only for main master

2020-05-11 Thread Parshuram Raju Thombare
>> +/** >> + * i3c_master_register() - register an I3C master > >The function should be renamed and the doc updated to reflect the fact >that it only works for primary masters: > >i3c_primary_master_register() - register a primary I3C master Sure, I will do that. >> + * @master: master used to se

Re: [PATCH v10 08/11] KVM: x86/pmu: Add LBR feature emulation via guest LBR event

2020-05-11 Thread Xu, Like
On 2020/5/8 21:09, Peter Zijlstra wrote: On Mon, Apr 27, 2020 at 11:16:40AM +0800, Like Xu wrote: On 2020/4/24 20:16, Peter Zijlstra wrote: And I suppose that is why you need that horrible: needs_guest_lbr_without_counter() thing to begin with. Do you suggest to use event->attr.config check to

[Patch v2] efi: cper: Add support for printing Firmware Error Record Reference

2020-05-11 Thread Punit Agrawal
While debugging a boot failure, the following unknown error record was seen in the boot logs. <...> BERT: Error records from previous boot: [Hardware Error]: event severity: fatal [Hardware Error]: Error 0, type: fatal [Hardware Error]: section type: unknown, 81212a96-09ed-

linux-next: manual merge of the sound-asoc tree with the crypto tree

2020-05-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the sound-asoc tree got a conflict in: sound/soc/codecs/cros_ec_codec.c between commit: 85fc78b80f15 ("ASoC: cros_ec_codec: use crypto_shash_tfm_digest()") from the crypto tree and commit: a1304cba816e ("ASoC: cros_ec_codec: allocate shash_desc dynami

Re: [PATCH 2/2] kbuild: remove {CLEAN,MRPROPER,DISTCLEAN}_DIRS

2020-05-11 Thread Masahiro Yamada
On Mon, May 4, 2020 at 5:08 PM Masahiro Yamada wrote: > > Merge {CLEAN,MRPROPER,DISTCLEAN}_DIRS into {CLEAN,MRPROPER,DISTCLEAN}_FILES > because the difference is just the -r option passed to the 'rm' command. > > Do likewise as commit 1634f2bfdb84 ("kbuild: remove clean-dirs syntax"). > > Signed-o

[RFC] e1000e: Relax condition to trigger reset for ME workaround

2020-05-11 Thread Punit Agrawal
It's an error if the value of the RX/TX tail descriptor does not match what was written. The error condition is true regardless the duration of the interference from ME. But the code only performs the reset if E1000_ICH_FWSM_PCIM2PCI_COUNT (2000) iterations of 50us delay have transpired. The extra

[PATCH v4 2/2] KVM: x86/pmu: Support full width counting

2020-05-11 Thread Like Xu
Intel CPUs have a new alternative MSR range (starting from MSR_IA32_PMC0) for GP counters that allows writing the full counter width. Enable this range from a new capability bit (IA32_PERF_CAPABILITIES.FW_WRITE[bit 13]). The guest would query CPUID to get the counter width, and sign extends the co

[PATCH 1/2] KVM: x86/pmu: Tweak kvm_pmu_get_msr to pass 'struct msr_data' in

2020-05-11 Thread Like Xu
From: Wei Wang Change kvm_pmu_get_msr() to get the msr_data struct, as the host_initiated field from the struct could be used by get_msr. This also makes this API consistent with kvm_pmu_set_msr. No functional changes. Signed-off-by: Wei Wang --- arch/x86/kvm/pmu.c | 4 ++-- arch/x8

Re: mmotm 2020-05-11-15-43 uploaded (mm/memcontrol.c, huge pages)

2020-05-11 Thread Randy Dunlap
On 5/11/20 3:44 PM, Andrew Morton wrote: > The mm-of-the-moment snapshot 2020-05-11-15-43 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -mm patch queu

Re: [PATCH 1/2] kbuild: remove misleading stale FIXME comment

2020-05-11 Thread Masahiro Yamada
On Mon, May 4, 2020 at 5:08 PM Masahiro Yamada wrote: > > This comment was added by commit ("kbuild: Restore build nr, improve > vmlinux link") [1]. > > It was talking about if_changed_rule at that time. Now, it is unclear > what to fix. > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/

Re: [PATCH v2 00/15] kbuild: support 'userprogs' syntax

2020-05-11 Thread Masahiro Yamada
On Wed, Apr 29, 2020 at 12:45 PM Masahiro Yamada wrote: > > > Several Makefiles use 'hostprogs' to build programs for the host > architecture where it is not appropriate to do so. > This is just because Kbuild lacks the support for building programs > for the target architecture. > > This series i

Re: [PATCH] bpfilter: check if $(CC) can static link in Kconfig

2020-05-11 Thread Masahiro Yamada
On Sun, May 10, 2020 at 10:04 AM Alexei Starovoitov wrote: > > On Sat, May 9, 2020 at 12:40 AM Masahiro Yamada wrote: > > > > On Fedora, linking static libraries requires the glibc-static RPM > > package, which is not part of the glibc-devel package. > > > > CONFIG_CC_CAN_LINK does not check the

Re: [PATCH] xen/pvcalls-back: test for errors when calling backend_connect()

2020-05-11 Thread Jürgen Groß
On 11.05.20 23:41, Stefano Stabellini wrote: On Mon, 11 May 2020, Juergen Gross wrote: backend_connect() can fail, so switch the device to connected only if no error occurred. Fixes: 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling") Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross

[RFC] mm/vmstat: Add events for THP migration without split

2020-05-11 Thread Anshuman Khandual
Add the following new trace events which will help in validating migration events involving PMD based THP pages. 1. THP_PMD_MIGRATION_ENTRY_SET 2. THP_PMD_MIGRATION_ENTRY_REMOVE There are no clear method to confirm whether a THP migration happened with out involving it's split. These trace events

Re: [PATCH] x86/platform/uv: HUB RTC cleanup

2020-05-11 Thread Christoph Hellwig
On Mon, May 11, 2020 at 05:35:35PM -0500, Dimitri Sivanich wrote: > Remove unused event code and other cleanup for HUB RTC. Can you explain how this is dead? That's not entirely obvious from the patch. Also you probably want to split it the cleans into one or several additional patches and aso d

Re: [PATCH 00/14] thermal core include cleanups

2020-05-11 Thread Viresh Kumar
On 11-05-20, 17:54, Amit Kucheria wrote: > I noticed some remnants from when thermal core could be modular. While > cleaning that up, I fixed up the includes to be sorted alphabetically and > included export.h in files that were using EXPORT_SYMBOL* or THIS_MODULE > while at the same time removing

Re: [PATCH v5 3/7] fpga: dfl: introduce interrupt trigger setting API

2020-05-11 Thread Moritz Fischer
On Mon, Apr 20, 2020 at 04:11:39PM +0800, Xu Yilun wrote: > FPGA user applications may be interested in interrupts generated by > DFL features. For example, users can implement their own FPGA > logics with interrupts enabled in AFU (Accelerated Function Unit, > dynamic region of DFL based FPGA). So

  1   2   3   4   5   6   7   8   9   10   >