[PATCH 05/14] fs: check FMODE_WRITE in __kernel_write

2020-05-12 Thread Christoph Hellwig
We still need to check if the fѕ is open write, even for the low-level helper. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/read_write.c b/fs/read_write.c index 2c601d853ff3d..76be155ad9824 100644 --- a/fs/read_write.c +++ b/fs/rea

[PATCH 04/14] fs: unexport __kernel_write

2020-05-12 Thread Christoph Hellwig
This is a very special interface that skips sb_writes protection, and not used by modules anymore. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/read_write.c b/fs/read_write.c index bbfa9b12b15eb..2c601d853ff3d 100644 --- a/fs/read_wri

[PATCH 13/14] fs: remove __vfs_read

2020-05-12 Thread Christoph Hellwig
Fold it into the two callers. Signed-off-by: Christoph Hellwig --- fs/read_write.c| 43 +-- include/linux/fs.h | 1 - 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 4e19152a7efe0..46ddfce17e839

[PATCH 09/14] fs: don't change the address limit for ->write_iter in __kernel_write

2020-05-12 Thread Christoph Hellwig
If we write to a file that implements ->write_iter there is no need to change the address limit if we send a kvec down. Implement that case, and prefer it over using plain ->write with a changed address limit if available. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 34 ++

[PATCH 14/14] fs: don't change the address limit for ->read_iter in __kernel_read

2020-05-12 Thread Christoph Hellwig
If we read to a file that implements ->read_iter there is no need to change the address limit if we send a kvec down. Implement that case, and prefer it over using plain ->read with a changed address limit if available. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 24 +

[PATCH 07/14] fs: implement kernel_write using __kernel_write

2020-05-12 Thread Christoph Hellwig
Consolidate the two in-kernel write helpers to make upcoming changes easier. The only difference are the missing call to rw_verify_area in kernel_write, and an access_ok check that doesn't make sense for kernel buffers to start with. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 17 +++

[PATCH 06/14] fs: remove the call_{read,write}_iter functions

2020-05-12 Thread Christoph Hellwig
Just open coding the methods calls is a lot easier to follow. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 4 ++-- drivers/target/target_core_file.c | 4 ++-- fs/aio.c | 4 ++-- fs/io_uring.c | 4 ++-- fs/read_write.c

[PATCH 08/14] fs: remove __vfs_write

2020-05-12 Thread Christoph Hellwig
Fold it into the two callers. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 46 ++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index abb84391cfbc5..3bcb084f160de 100644 --- a/fs/read_write.

[PATCH 12/14] fs: implement kernel_read using __kernel_read

2020-05-12 Thread Christoph Hellwig
Consolidate the two in-kernel read helpers to make upcoming changes easier. The only difference are the missing call to rw_verify_area in kernel_read, and an access_ok check that doesn't make sense for kernel buffers to start with. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 13 +

[PATCH 11/14] integrity/ima: switch to using __kernel_read

2020-05-12 Thread Christoph Hellwig
__kernel_read has a bunch of additional sanity checks, and this moves the set_fs out of non-core code. Signed-off-by: Christoph Hellwig --- security/integrity/iint.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/security/integrity/iint.c b/security/integrity/

[PATCH 10/14] fs: add a __kernel_read helper

2020-05-12 Thread Christoph Hellwig
This is the counterpart to __kernel_write, and skip the rw_verify_area call compared to kernel_read. Signed-off-by: Christoph Hellwig --- fs/read_write.c| 21 + include/linux/fs.h | 1 + 2 files changed, 22 insertions(+) diff --git a/fs/read_write.c b/fs/read_write.c in

[PATCH 01/14] cachefiles: switch to kernel_write

2020-05-12 Thread Christoph Hellwig
__kernel_write doesn't take a sb_writers references, which we need here. Signed-off-by: Christoph Hellwig --- fs/cachefiles/rdwr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cachefiles/rdwr.c b/fs/cachefiles/rdwr.c index 1dc97f2d62013..c0b99ccd9a79f 100644 --- a/fs/ca

clean up kernel_{read,write} & friends v2

2020-05-12 Thread Christoph Hellwig
Hi Al, this series fixes a few issues and cleans up the helpers that read from or write to kernel space buffers, and ensures that we don't change the address limit if we are using the ->read_iter and ->write_iter methods that don't need the changed address limit. Changes since v1: - __kernel_wri

[PATCH 03/14] bpfilter: switch to kernel_write

2020-05-12 Thread Christoph Hellwig
While pipes don't really need sb_writers projection, __kernel_write is an interface better kept private, and the additional rw_verify_area does not hurt here. Signed-off-by: Christoph Hellwig --- net/bpfilter/bpfilter_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net

[PATCH 02/14] autofs: switch to kernel_write

2020-05-12 Thread Christoph Hellwig
While pipes don't really need sb_writers projection, __kernel_write is an interface better kept private, and the additional rw_verify_area does not hurt here. Signed-off-by: Christoph Hellwig --- fs/autofs/waitq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/autofs/wait

RE: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema

2020-05-12 Thread Anson Huang
Hi, Rob > Subject: RE: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema > > Hi, Rob > > > > Subject: Re: [PATCH V2] dt-bindings: thermal: Convert i.MX to > > json-schema > > > > On Fri, Apr 10, 2020 at 09:07:24AM +0800, Anson Huang wrote: > > > Convert the i.MX thermal binding to DT

Re: [PATCH v8 00/10] Introduce OPP bandwidth bindings

2020-05-12 Thread Viresh Kumar
On 12-05-20, 15:53, Georgi Djakov wrote: > Here is a proposal to extend the OPP bindings with bandwidth based on > a few previous discussions [1] and patchsets from me [2][3] and Saravana > [4][5][6][7][8][9]. > > Changes in v8: > * Addressed review comments from Matthias, Sibi and Viresh. > * Pic

[PATCH v2 2/2] clk: qcom: gcc: Add missing UFS clocks for SM8150

2020-05-12 Thread Vinod Koul
Add the missing ufs card and ufs phy clocks for SM8150. They were missed in earlier addition of clock driver. Fixes: 2a1d7eb854bb ("clk: qcom: gcc: Add global clock controller driver for SM8150") Signed-off-by: Vinod Koul --- Changes in v2: - Add fixes tag drivers/clk/qcom/gcc-sm8150.c | 84

[PATCH v2 1/2] clk: qcom: gcc: Add GPU and NPU clocks for SM8150

2020-05-12 Thread Vinod Koul
Add the GPU and NPU clocks for SM8150. They were missed in earlier addition of clock driver. Fixes: 2a1d7eb854bb ("clk: qcom: gcc: Add global clock controller driver for SM8150") Signed-off-by: Vinod Koul --- Changes in v2: - add fixes tag - remove BRANCH_HALT_SKIP from these clk drivers/c

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-12 Thread Jisheng Zhang
Hi, On Tue, 12 May 2020 20:43:40 +0200 Heiner Kallweit wrote: > > > On 12.05.2020 12:46, Jisheng Zhang wrote: > > The PHY Register Accessible Interrupt is enabled by default, so > > there's such an interrupt during init. In PHY POLL mode case, the > > INTB/PMEB pin is alway active, it is not go

Re: [PATCH 0/2] Bluetooth: Update LE scanning parameters for suspend

2020-05-12 Thread Marcel Holtmann
Hi Abhishek, > This series updates the values used for window and interval when the > system suspends. It also fixes a u8 vs u16 bug when setting up passive > scanning. > > The values chosen for window and interval are 11.25ms and 640ms. I have > tested these on several Chromebooks with different

Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support

2020-05-12 Thread Greg Kroah-Hartman
On Tue, May 12, 2020 at 11:23:27PM -0700, Scott Branden wrote: > Hi Luis, > > A few comments inline before I cleanup. > > On 2020-05-12 5:27 p.m., Luis Chamberlain wrote: > > On Thu, May 07, 2020 at 05:27:33PM -0700, Scott Branden wrote: > > > diff --git a/fs/exec.c b/fs/exec.c > > > index 06b4c5

Re: [PATCH v2 1/3] rcu/kasan: record and print call_rcu() call stack

2020-05-12 Thread Dmitry Vyukov
On Wed, May 13, 2020 at 3:48 AM Walter Wu wrote: > > > > Are you sure it will increase object size? > > > > I think we overlap kasan_free_meta with the object as well. The only > > > > case we don't overlap kasan_free_meta with the object are > > > > SLAB_TYPESAFE_BY_RCU || cache->ctor. But these

Re: [PATCH 1/4] perf expr: Add parsing support for multiple expressions

2020-05-12 Thread Ian Rogers
On Mon, May 11, 2020 at 1:54 PM Jiri Olsa wrote: > > Adding support to parse metric difinitions in following form: Typo on definitions. > NAME = EXPRESSION ; > NAME = EXPRESSION ; > ... > > The parsed NAME and EXPRESSION will be used in following > changes to feed the metric code with defi

Re: [PATCH v5 6/7] misc: bcm-vk: add Broadcom VK driver

2020-05-12 Thread Greg Kroah-Hartman
On Tue, May 12, 2020 at 11:31:28PM -0700, Scott Branden wrote: > Hi Luis, > > On 2020-05-12 5:38 p.m., Luis Chamberlain wrote: > > On Thu, May 07, 2020 at 05:27:38PM -0700, Scott Branden wrote: > > > +#if defined(CONFIG_REQ_FW_INTO_BUF_PRIV) > > > + > > > +#define KERNEL_PREAD_FLAG_PART 0x0001 /

gcc-10: kernel stack is corrupted and fails to boot

2020-05-12 Thread Kalle Valo
(trimming CC, changing title) Kalle Valo writes: > Kalle Valo writes: > >> Arnd Bergmann writes: >> >>> gcc-10 correctly points out a bug with a zero-length array in >>> struct ath10k_pci: >>> >>> drivers/net/wireless/ath/ath10k/ahb.c: In function 'ath10k_ahb_remove': >>> drivers/net/wireless/

Re: CMA enhancement - non-default areas in x86

2020-05-12 Thread gre...@linuxfoundation.org
On Wed, May 13, 2020 at 06:13:55AM +, Idgar, Or wrote: > Hi, > I'm working with Linux kernel on x86 and needed a way to allocate a very > large contiguous memory (around 20GB) for DMA operations. For what type of device? > I've found out that CMA is one of the major ways to do so, but our pr

Re: [PATCH v3 2/3] KVM: x86: Move pkru save/restore to x86.c

2020-05-12 Thread Paolo Bonzini
On 12/05/20 19:17, Babu Moger wrote: > > On 5/12/20 11:39 AM, Jim Mattson wrote: >> On Mon, May 11, 2020 at 4:33 PM Babu Moger wrote: >>> MPK feature is supported by both VMX and SVM. So we can >>> safely move pkru state save/restore to common code. Also >>> move all the pkru data structure to kv

Re: [PATCH v8 10/10] OPP: Add support for setting interconnect-tags

2020-05-12 Thread Viresh Kumar
On 12-05-20, 15:53, Georgi Djakov wrote: > From: Sibi Sankar > > Add support for setting tags on icc paths associated with > the opp_table. > > Signed-off-by: Sibi Sankar > Signed-off-by: Georgi Djakov > --- Applied this delta: diff --git a/drivers/opp/of.c b/drivers/opp/of.c index f71dc5eb0

Re: [PATCH v8 08/10] cpufreq: dt: Validate all interconnect paths

2020-05-12 Thread Viresh Kumar
On 12-05-20, 15:53, Georgi Djakov wrote: > Currently when we check for the available resources, we assume that there > is only one interconnect path, but in fact it could be more than one. Do > some validation to determine the number of paths and verify if each one > of them is available. > > Sign

Re: Patch "ipc/mqueue.c: change __do_notify() to bypass check_kill_permission()" has been added to the 4.14-stable tree

2020-05-12 Thread Greg KH
On Tue, May 12, 2020 at 08:51:16PM -0400, Sasha Levin wrote: > This is a note to let you know that I've just added the patch titled > > ipc/mqueue.c: change __do_notify() to bypass check_kill_permission() > > to the 4.14-stable tree which can be found at: > > http://www.kernel.org/git/?p

Re: [PATCH v8 04/10] OPP: Add support for parsing interconnect bandwidth

2020-05-12 Thread Viresh Kumar
On 12-05-20, 15:53, Georgi Djakov wrote: > The OPP bindings now support bandwidth values, so add support to parse it > from device tree and store it into the new dev_pm_opp_icc_bw struct, which > is part of the dev_pm_opp. > > Signed-off-by: Georgi Djakov > --- > v8: > * Drop bandwidth requests a

Re: [PATCH v8 02/10] OPP: Add helpers for reading the binding properties

2020-05-12 Thread Viresh Kumar
On 12-05-20, 15:53, Georgi Djakov wrote: > diff --git a/drivers/opp/of.c b/drivers/opp/of.c > @@ -558,26 +580,13 @@ static struct dev_pm_opp *_opp_add_static_v2(struct > opp_table *opp_table, > if (!new_opp) > return ERR_PTR(-ENOMEM); > > - ret = of_property_read_u64(np,

Re: [patch V5 02/38] x86/entry/64: Use native swapgs in asm_native_load_gs_index()

2020-05-12 Thread Thomas Gleixner
Steven Rostedt writes: > On Tue, 12 May 2020 23:01:01 +0200 > Thomas Gleixner wrote: > >> When PARAVIRT_XXL is in use, then load_gs_index() uses >> xen_load_gs_index() and (asm_))native_load_gs_index() is unused. >> >> It's therefore pointless to use the paravirtualized SWAPGS implementation >>

Re: [patch V4 part 3 08/29] x86/entry/64: Provide sane error entry/exit

2020-05-12 Thread Thomas Gleixner
Steven Rostedt writes: > On Tue, 05 May 2020 15:44:02 +0200 > Thomas Gleixner wrote: > >> +.if \sane == 0 >> TRACE_IRQS_OFF > > Are you implying that TRACE_IRQS_OFF is insane? Very much so.

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-12 Thread Greg KH
On Wed, May 13, 2020 at 06:13:17AM +, Ashwin H wrote: > This patch fixes CVE-2018-20669 in 4.19 tree. Ok, but what does that mean for us? You need to say why you are sending a patch, otherwise we will guess wrong. greg k-h

[PATCH 06/33] net: add sock_set_timestamps

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SO_TIMESTAMP* sockopts from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/sock.h | 1 + net/core/sock.c | 47 +--- net/rxrpc/local_object.c | 8 +-- 3 f

[PATCH 15/33] tcp: add tcp_sock_set_keepidle

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the TCP_KEEP_IDLE sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/linux/tcp.h | 1 + net/ipv4/tcp.c| 49 ++- net/rds/tcp_listen.c | 5 + net/sunrpc/x

Re: [PATCH v4 00/12] perf metric fixes and test

2020-05-12 Thread Ian Rogers
On Mon, May 11, 2020 at 9:12 AM Ian Rogers wrote: > > On Mon, May 11, 2020 at 8:32 AM Arnaldo Carvalho de Melo > wrote: > > > > Em Thu, May 07, 2020 at 10:44:45AM +0200, Jiri Olsa escreveu: > > > On Fri, May 01, 2020 at 10:33:21AM -0700, Ian Rogers wrote: > > > > Add a test that all perf metrics

Re: [PATCH v4 2/2] mailbox: sprd: Add Spreadtrum mailbox driver

2020-05-12 Thread Baolin Wang
On Wed, May 13, 2020 at 2:05 PM Jassi Brar wrote: > > On Tue, May 12, 2020 at 11:14 PM Baolin Wang wrote: > > > > Hi Jassi, > > > > On Thu, May 7, 2020 at 11:23 AM Baolin Wang wrote: > > > > > > Hi Jassi, > > > > > > On Thu, May 7, 2020 at 7:25 AM Jassi Brar > > > wrote: > > > > > > > > On Wed

[PATCH 14/33] tcp: add tcp_sock_set_user_timeout

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the TCP_USER_TIMEOUT sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- fs/ocfs2/cluster/tcp.c | 22 ++ include/linux/tcp.h| 1 + net/ipv4/tcp.c | 8 net/sunrpc/xprtsock.c |

remove kernel_setsockopt and kernel_getsockopt

2020-05-12 Thread Christoph Hellwig
Hi Dave, this series removes the kernel_setsockopt and kernel_getsockopt functions, and instead switches their users to small functions that implement setting (or in one case getting) a sockopt directly using a normal kernel function call with type safety and all the other benefits of not having a

[PATCH 19/33] ipv4: add ip_sock_set_freebind

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the IP_FREEBIND sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- drivers/target/iscsi/iscsi_target_login.c | 13 +++-- include/net/ip.h | 1 + net/ipv4/ip_sockglue.c

[PATCH 09/33] net: add sock_set_reuseport

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SO_REUSEPORT sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/sock.h| 1 + net/core/sock.c | 8 net/sunrpc/xprtsock.c | 17 + 3 files changed, 10 insertions(+), 1

Re: [PATCH v5 6/7] misc: bcm-vk: add Broadcom VK driver

2020-05-12 Thread Scott Branden
Hi Luis, On 2020-05-12 5:38 p.m., Luis Chamberlain wrote: On Thu, May 07, 2020 at 05:27:38PM -0700, Scott Branden wrote: +#if defined(CONFIG_REQ_FW_INTO_BUF_PRIV) + +#define KERNEL_PREAD_FLAG_PART 0x0001 /* Allow reading part of file */ +#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_b

[PATCH 17/33] tcp: add tcp_sock_set_keepcnt

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the TCP_KEEPCNT sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/linux/tcp.h | 1 + net/ipv4/tcp.c| 12 net/rds/tcp.h | 2 +- net/rds/tcp_listen.c | 17 +++-- ne

[PATCH 11/33] tcp: tcp_sock_set_nodelay

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the TCP_NODELAY sockopt from kernel space without going through a fake uaccess. Cleanup the callers to avoid pointless wrappers now that this is a simple function call. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_int.h | 7 drivers

[PATCH 30/33] tipc: call tsk_set_importance from tipc_topsrv_create_listener

2020-05-12 Thread Christoph Hellwig
Avoid using kernel_setsockopt for the TIPC_IMPORTANCE option when we can just use the internal helper. The only change needed is to pass a struct sock instead of tipc_sock, which is private to socket.c Signed-off-by: Christoph Hellwig --- net/tipc/socket.c | 18 +- net/tipc/sock

[PATCH 28/33] sctp: add sctp_sock_set_nodelay

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SCTP_NODELAY sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- fs/dlm/lowcomms.c | 10 ++ include/net/sctp/sctp.h | 1 + net/sctp/socket.c | 8 3 files changed, 11 insertions(+), 8

[PATCH 18/33] ipv4: add ip_sock_set_tos

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the IP_TOS sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/tcp.c | 14 +++--- drivers/nvme/target/tcp.c | 10 ++ include/net/ip.h | 2 ++ net/ipv4/ip_sockglue.c| 30

[PATCH 29/33] rxrpc_sock_set_min_security_level

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the RXRPC_MIN_SECURITY_LEVEL sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- fs/afs/rxrpc.c | 6 ++ include/net/af_rxrpc.h | 2 ++ net/rxrpc/af_rxrpc.c | 13 + 3 files changed, 17 insert

Re: [PATCH 2/2] perf test: Improve pmu event metric testing

2020-05-12 Thread Ian Rogers
On Tue, May 12, 2020 at 11:22 PM Ian Rogers wrote: > > Break pmu-events test into 2 and add a test to verify that all pmu metric > expressions simply parse. Try to parse all metric ids/events, failing if > metrics for the current architecture fail to parse. > > Tested on power9, skylakex, haswell,

[PATCH 33/33] net: remove kernel_getsockopt

2020-05-12 Thread Christoph Hellwig
No users left. Signed-off-by: Christoph Hellwig --- include/linux/net.h | 2 -- net/socket.c| 34 -- 2 files changed, 36 deletions(-) diff --git a/include/linux/net.h b/include/linux/net.h index ece7513326293..e10f378194a59 100644 --- a/include/linux/net

[PATCH 23/33] ipv6: add ip6_sock_set_recverr

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the IPV6_RECVERR sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/ipv6.h | 1 + net/ipv6/ipv6_sockglue.c | 10 ++ net/rxrpc/local_object.c | 10 ++ 3 files changed, 13 insertions(+

[PATCH 21/33] ipv4: add ip_sock_set_mtu_discover

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the IP_MTU_DISCOVER sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/ip.h | 2 ++ net/ipv4/ip_sockglue.c | 22 ++ net/rxrpc/local_object.c | 8 +--- net/rxrpc/output.c

[PATCH 32/33] sctp: add sctp_sock_get_primary_addr

2020-05-12 Thread Christoph Hellwig
Add a helper to directly get the SCTP_PRIMARY_ADDR sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- fs/dlm/lowcomms.c | 11 +++- include/net/sctp/sctp.h | 1 + net/sctp/socket.c | 57 + 3

[PATCH 27/33] sctp: export sctp_setsockopt_bindx

2020-05-12 Thread Christoph Hellwig
And call it directly from dlm instead of going through kernel_setsockopt. Signed-off-by: Christoph Hellwig --- fs/dlm/lowcomms.c | 13 - include/net/sctp/sctp.h | 3 +++ net/sctp/socket.c | 5 +++-- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/fs/dlm/

[PATCH 26/33] sctp: lift copying in addrs into sctp_setsockopt

2020-05-12 Thread Christoph Hellwig
Prepare for additional kernel-space callers of sctp_setsockopt_bindx. Signed-off-by: Christoph Hellwig --- net/sctp/socket.c | 71 ++- 1 file changed, 27 insertions(+), 44 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 827a9903e

[PATCH 31/33] net: remove kernel_setsockopt

2020-05-12 Thread Christoph Hellwig
No users left. Signed-off-by: Christoph Hellwig --- include/linux/net.h | 2 -- net/socket.c| 31 --- 2 files changed, 33 deletions(-) diff --git a/include/linux/net.h b/include/linux/net.h index 6451425e828f5..ece7513326293 100644 --- a/include/linux/net.h

[PATCH 16/33] tcp: add tcp_sock_set_keepintvl

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the TCP_KEEPINTVL sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/linux/tcp.h | 1 + net/ipv4/tcp.c| 12 net/rds/tcp_listen.c | 4 +--- net/sunrpc/xprtsock.c | 3 +-- 4 files chan

[PATCH 22/33] ipv6: add ip6_sock_set_v6only

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the IPV6_V6ONLY sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/ipv6.h| 3 +++ net/ipv6/ip6_udp_tunnel.c | 5 + net/ipv6/ipv6_sockglue.c | 11 +++ net/sunrpc/svcsock.c | 8 +

[PATCH 10/33] tcp: add tcp_sock_set_cork

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the TCP_CORK sockopt from kernel space without going through a fake uaccess. Cleanup the callers to avoid pointless wrappers now that this is a simple function call. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_int.h | 14 drivers/block

[PATCH 24/33] ipv6: add ip6_sock_set_addr_preferences

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the IPV6_ADD_PREFERENCES sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/ipv6.h | 1 + net/ipv6/ipv6_sockglue.c | 127 +-- net/sunrpc/xprtsock.c| 8 ++-

[PATCH 20/33] ipv4: add ip_sock_set_recverr

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the IP_RECVERR sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/ip.h | 1 + net/ipv4/ip_sockglue.c | 10 ++ net/rxrpc/local_object.c | 8 +--- 3 files changed, 12 insertions(+), 7

[PATCH 04/33] net: add sock_set_sndtimeo

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SO_SNDTIMEO_NEW sockopt from kernel space without going through a fake uaccess. The interface is simplified to only pass the seconds value, as that is the only thing needed at the moment. Signed-off-by: Christoph Hellwig --- fs/dlm/lowcomms.c | 8 ++-- inc

[PATCH 08/33] net: add sock_set_rcvbuf

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SO_RCVBUFFORCE sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- fs/dlm/lowcomms.c | 7 +- include/net/sock.h | 1 + net/core/sock.c| 59 +- 3 files changed,

[PATCH 12/33] tcp: add tcp_sock_set_quickack

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the TCP_QUICKACK sockopt from kernel space without going through a fake uaccess. Cleanup the callers to avoid pointless wrappers now that this is a simple function call. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_int.h | 7 -- drivers/blo

[PATCH 25/33] ipv6: add ip6_sock_set_recvpktinfo

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the IPV6_RECVPKTINFO sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/ipv6.h | 1 + net/ipv6/ipv6_sockglue.c | 8 net/sunrpc/svcsock.c | 11 +++ 3 files changed, 12 insertion

[PATCH v2 2/2] perf test: Improve pmu event metric testing

2020-05-12 Thread Ian Rogers
Break pmu-events test into 2 and add a test to verify that all pmu metric expressions simply parse. Try to parse all metric ids/events, warning if metrics for the current architecture fail to parse. Tested on power9, skylakex, haswell, broadwell, westmere, sandybridge and ivybridge with the patch

[PATCH v2 1/2] perf expr: Test parsing of floating point numbers

2020-05-12 Thread Ian Rogers
Add test for fix in: commit 5741da3dee4c ("perf expr: Parse numbers as doubles") Signed-off-by: Ian Rogers --- tools/perf/tests/expr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/tests/expr.c b/tools/perf/tests/expr.c index f9e8e5628836..3f742612776a 100644 --- a/tools/perf/te

[PATCH 02/33] net: add sock_set_linger

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SO_LINGER sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/tcp.c | 9 + drivers/nvme/target/tcp.c | 6 +- include/net/sock.h| 1 + net/core/sock.c | 36 ++

[PATCH 07/33] net: add sock_set_keepalive

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SO_KEEPALIVE sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- fs/dlm/lowcomms.c | 6 +- include/net/sock.h| 1 + net/core/sock.c | 10 ++ net/rds/tcp_listen.c | 6 +- net/sunrpc

[PATCH 05/33] net: add sock_bindtoindex

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SO_BINDTOIFINDEX sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/sock.h| 1 + net/core/sock.c | 21 +++-- net/ipv4/udp_tunnel.c | 4 +--- net/ipv6/ip6_udp_tun

[PATCH 13/33] tcp: add tcp_sock_set_syncnt

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the TCP_SYNCNT sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/tcp.c | 9 + include/linux/tcp.h | 1 + net/ipv4/tcp.c | 12 3 files changed, 14 insertions(+), 8

[PATCH 03/33] net: add sock_set_priority

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SO_PRIORITY sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/tcp.c | 12 ++-- drivers/nvme/target/tcp.c | 18 -- include/net/sock.h| 1 + net/core/sock.c

[PATCH 01/33] net: add sock_set_reuseaddr

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the SO_REUSEADDR sockopt from kernel space without going through a fake uaccess. For this the iscsi target now has to formally depend on inet to avoid a mostly theoretical compile failure. For actual operation it already did depend on having ipv4 or ipv6 support. Sig

Re: [PATCH] printk: Add loglevel for "do not print to consoles".

2020-05-12 Thread Sergey Senozhatsky
On (20/04/30 01:35), Tetsuo Handa wrote: > Below is the default rules for rsyslog-8.24.0-52.el7 (userspace syslog > daemon). > Of course administrators can modify as needed, but notice that KERN_INFO is > saved > to /var/log/messages but KERN_DEBUG is saved to nowhere. > > -- > # Log all

Re: [PATCH] powerpc/kvm: silence kmemleak false positives

2020-05-12 Thread Qian Cai
> On May 13, 2020, at 12:04 AM, Michael Ellerman wrote: > > This should probably also have an include of ? No, asm/book3s/64/pgalloc.h has already had it and since this is book3s_64_mmu_radix.c, it will include it eventually from, asm/pgalloc.h asm/book3s/pgalloc.h

Re: [PATCH 19/31] riscv: use asm-generic/cacheflush.h

2020-05-12 Thread Christoph Hellwig
On Tue, May 12, 2020 at 04:00:26PM -0700, Palmer Dabbelt wrote: > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt > > Were you trying to get these all in at once, or do you want me to take it into > my tree? Except for the small fixups at the beginning of the series this needs to go in to

Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support

2020-05-12 Thread Scott Branden
Hi Luis, A few comments inline before I cleanup. On 2020-05-12 5:27 p.m., Luis Chamberlain wrote: On Thu, May 07, 2020 at 05:27:33PM -0700, Scott Branden wrote: diff --git a/fs/exec.c b/fs/exec.c index 06b4c550af5d..cfab212fab9d 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -896,10 +896,14 @@ stru

[PATCH 2/2] perf test: Improve pmu event metric testing

2020-05-12 Thread Ian Rogers
Break pmu-events test into 2 and add a test to verify that all pmu metric expressions simply parse. Try to parse all metric ids/events, failing if metrics for the current architecture fail to parse. Tested on power9, skylakex, haswell, broadwell, westmere, sandybridge and ivybridge with the patch

[PATCH 1/2] perf expr: Test parsing of floating point numbers

2020-05-12 Thread Ian Rogers
Add test for fix in: commit 5741da3dee4c ("perf expr: Parse numbers as doubles") Signed-off-by: Ian Rogers --- tools/perf/tests/expr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/tests/expr.c b/tools/perf/tests/expr.c index f9e8e5628836..3f742612776a 100644 --- a/tools/perf/te

Re: [PATCH v3 05/11] arm64: Add call_break_hook() to early_brk64() for early kgdb

2020-05-12 Thread Will Deacon
Hey Doug, On Tue, May 12, 2020 at 08:27:50AM -0700, Doug Anderson wrote: > On Tue, May 12, 2020 at 12:36 AM Will Deacon wrote: > > On Mon, May 11, 2020 at 03:45:02PM -0700, Doug Anderson wrote: > > > On Mon, May 11, 2020 at 7:59 AM Will Deacon wrote: > > > > On Tue, Apr 28, 2020 at 02:13:45PM -0

[PATCH] Fix suspicious RCU usage warning

2020-05-12 Thread madhuparnabhowmik10
From: Madhuparna Bhowmik This patch fixes the following warning: = WARNING: suspicious RCU usage 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted - net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!! ipmr_new_table() returns an

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-12 Thread Ashwin H
This patch fixes CVE-2018-20669 in 4.19 tree. On 13/05/20, 11:36 AM, "Greg KH" wrote: On Wed, May 13, 2020 at 07:19:21AM +0530, ashwin-h wrote: > From: Linus Torvalds > > commit 594cc251fdd0d231d342d88b2fdff4bc42fb0690 upstream. > > Originally, the rule used to be tha

Re: [PATCH] nvme/core:disable streams when get stream params failed

2020-05-12 Thread Wu Bo
On 2020/5/13 0:06, Christoph Hellwig wrote: On Wed, May 06, 2020 at 04:37:01PM +0800, Wu Bo wrote: After enable nvme streams, then if get stream params failed, We should disable streams before return error in nvme_configure_directives() function. Signed-off-by: Wu Bo --- drivers/nvme/host/co

RE: [PATCH] input: keyboard: imx_sc_key: Use devm_add_action_or_reset() to handle all cleanups

2020-05-12 Thread Anson Huang
Gentle ping... > Subject: [PATCH] input: keyboard: imx_sc_key: Use > devm_add_action_or_reset() to handle all cleanups > > Use devm_add_action_or_reset() to handle all cleanups of failure in .probe > and .remove, then .remove callback can be dropped. > > Signed-off-by: Anson Huang > --- > driv

Re: [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache"

2020-05-12 Thread Sascha Hauer
On Tue, May 12, 2020 at 01:32:26AM +0800, Robin Gong wrote: > This reverts commit d288bddd8374e0a043ac9dde64a1ae6a09411d74, since > 'context_loaded' finally removed. > > Signed-off-by: Robin Gong > --- > drivers/dma/imx-sdma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/

Re: [PATCH v7 RESEND 05/13] dmaengine: imx-sdma: remove dupilicated sdma_load_context

2020-05-12 Thread Sascha Hauer
In the subject: s/dupilicated/duplicated/ Sascha On Tue, May 12, 2020 at 01:32:28AM +0800, Robin Gong wrote: > Since sdma_transfer_init() will do sdma_load_context before any > sdma transfer, no need once more in sdma_config_channel(). > > Signed-off-by: Robin Gong > Acked-by: Vinod Koul > ---

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-12 Thread Greg KH
On Wed, May 13, 2020 at 07:19:21AM +0530, ashwin-h wrote: > From: Linus Torvalds > > commit 594cc251fdd0d231d342d88b2fdff4bc42fb0690 upstream. > > Originally, the rule used to be that you'd have to do access_ok() > separately, and then user_access_begin() before actually doing the > direct (opti

Re: [PATCH v4 2/2] mailbox: sprd: Add Spreadtrum mailbox driver

2020-05-12 Thread Jassi Brar
On Tue, May 12, 2020 at 11:14 PM Baolin Wang wrote: > > Hi Jassi, > > On Thu, May 7, 2020 at 11:23 AM Baolin Wang wrote: > > > > Hi Jassi, > > > > On Thu, May 7, 2020 at 7:25 AM Jassi Brar wrote: > > > > > > On Wed, May 6, 2020 at 8:29 AM Baolin Wang wrote: > > > > > > > > Hi Jassi, > > > > > >

[PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting

2020-05-12 Thread Rajendra Nayak
Add an optional power domain which when specified can be used for setting the performance state of Venus. Signed-off-by: Rajendra Nayak --- Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml| 6 +- Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +-

Re: [PATCH 1/3] net: add a CMSG_USER_DATA macro

2020-05-12 Thread Christoph Hellwig
On Tue, May 12, 2020 at 11:28:08AM +0300, Sergei Shtylyov wrote: >Perhaps it's time to add missing spaces consistently, not just one that > you added? That is all fixed up in the next patch.

Re: [RFC 16/17] drm/amdgpu: gpu recovery does full modesets

2020-05-12 Thread Daniel Vetter
On Tue, May 12, 2020 at 10:10 PM Kazlauskas, Nicholas wrote: > > On 2020-05-12 12:12 p.m., Daniel Vetter wrote: > > On Tue, May 12, 2020 at 4:24 PM Alex Deucher wrote: > >> > >> On Tue, May 12, 2020 at 9:45 AM Daniel Vetter > >> wrote: > >>> > >>> On Tue, May 12, 2020 at 3:29 PM Alex Deucher

[PATCH v5 3/5] remoteproc: qcom: Update PIL relocation info on load

2020-05-12 Thread Bjorn Andersson
Update the PIL relocation information in IMEM with information about where the firmware for various remoteprocs are loaded. Signed-off-by: Bjorn Andersson --- Changes since v4: - Dropped unnecessary comment about ignoring return value. drivers/remoteproc/Kconfig | 3 +++ drivers/remo

[PATCH v5 4/5] arm64: dts: qcom: qcs404: Add IMEM and PIL info region

2020-05-12 Thread Bjorn Andersson
Add a simple-mfd representing IMEM on QCS404 and define the PIL relocation info region, so that post mortem tools will be able to locate the loaded remoteprocs. Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson --- Changes since v4: - imem is no longer compatible with "syscon" arch/arm

[PATCH v5 5/5] arm64: dts: qcom: sdm845: Add IMEM and PIL info region

2020-05-12 Thread Bjorn Andersson
Add a simple-mfd representing IMEM on SDM845 and define the PIL relocation info region, so that post mortem tools will be able to locate the loaded remoteprocs. Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson --- Changes since v4: - imem is no longer compatible with "syscon" arch/arm

[PATCH v5 1/5] dt-bindings: remoteproc: Add Qualcomm PIL info binding

2020-05-12 Thread Bjorn Andersson
Add a devicetree binding for the Qualcomm peripheral image loader relocation information region found in the IMEM. Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson --- Changes since v4: - Fixed reg in example to make it compile .../bindings/remoteproc/qcom,pil-info.yaml| 44 ++

Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers

2020-05-12 Thread Jason Wang
On 2020/5/13 下午12:42, Zhu, Lingshan wrote: On 5/13/2020 12:12 PM, Jason Wang wrote: On 2020/5/12 下午4:00, Zhu Lingshan wrote: This commit move IRQ request and free operations from probe() to VIRTIO status change handler to comply with VIRTIO spec. VIRTIO spec 1.1, section 2.1.2 Device Requ

[PATCH v5 2/5] remoteproc: qcom: Introduce helper to store pil info in IMEM

2020-05-12 Thread Bjorn Andersson
A region in IMEM is used to communicate load addresses of remoteproc to post mortem debug tools. Implement a helper function that can be used to store this information in order to enable these tools to process collected ramdumps. Signed-off-by: Bjorn Andersson --- Changes since v4: - Replaced pl

  1   2   3   4   5   6   7   8   9   10   >