[PATCH] kunit: Fix TabError, remove defconfig code and handle when there is no kunitconfig

2020-05-29 Thread Vitor Massaru Iha
The identation before this code (`if not os.path.exists(cli_args.build_dir):``) was with spaces instead of tabs after fixed up merge conflits, this commit revert spaces to tabs: [iha@bbking linux]$ tools/testing/kunit/kunit.py run File "tools/testing/kunit/kunit.py", line 247 if not linux:

Re: [PATCH v3 1/2] dt-bindings: chrome: Add cros-ec-typec mux props

2020-05-29 Thread Prashant Malani
Hi Rob, Would you prefer these switches to be defined in the usb-connector.yaml bindings file? If there are no other concerns, I can push a fresh version of the patch with the properties defined in usb-connector.yaml. Thanks, On Tue, May 19, 2020 at 2:46 PM Prashant Malani wrote: > > Add

Re: [PATCH net-next v2] dt-bindings: net: rename the bindings document for MediaTek STAR EMAC

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 15:59:02 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The driver itself was renamed before getting merged into mainline, but > the binding document kept the old name. This makes both names consistent. > > Signed-off-by: Bartosz Golaszewski > --- > v1 ->

Re: linux-next: manual merge of the nfsd tree with the nfs-anna tree

2020-05-29 Thread Chuck Lever
> On May 28, 2020, at 8:59 PM, Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the nfsd tree got a conflict in: > > include/trace/events/sunrpc.h > > between commit: > > 2baebf955125 ("SUNRPC: Split the xdr_buf event class") > > from the nfs-anna tree and commit: >

Re: [PATCH v2 3/4] dt-bindings: power: Add BQ28z610 compatible

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 07:21:46 -0500, Dan Murphy wrote: > Add the Texas Instruments bq28z610 battery monitor to the bq27xxx > binding. > > Signed-off-by: Dan Murphy > --- > Documentation/devicetree/bindings/power/supply/bq27xxx.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob

Re: [PATCH v2 1/4] dt-bindings: power: Add BQ27561 compatible

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 07:21:44 -0500, Dan Murphy wrote: > Add the Texas Instruments bq27561 battery monitor to the bq27xxx > binding. > > Signed-off-by: Dan Murphy > --- > Documentation/devicetree/bindings/power/supply/bq27xxx.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

[PATCH v3] regmap: fix alignment issue

2020-05-29 Thread Jens Thoms Toerring
The assembly and disassembly of data to be sent to or received from a device invoke functions (regmap_format_XXX() and regmap_parse_XXX()) that extract or insert data items from or into a buffer, using assignments. In some cases those functions are called with buffer pointers with odd addresses.

Re: [PATCH v4 1/4] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings

2020-05-29 Thread Rob Herring
On Thu, May 28, 2020 at 05:57:09PM +0800, EastL wrote: > Document the devicetree bindings for MediaTek Command-Queue DMA controller > which could be found on MT6779 SoC or other similar Mediatek SoCs. > > Signed-off-by: EastL Need a full name. > --- >

Re: [PATCH net-next v4 1/4] dt-bindings: net: Add tx and rx internal delays

2020-05-29 Thread Dan Murphy
Rob On 5/29/20 1:25 PM, Rob Herring wrote: On Wed, May 27, 2020 at 11:49:31AM -0500, Dan Murphy wrote: tx-internal-delays and rx-internal-delays are a common setting for RGMII capable devices. These properties are used when the phy-mode or phy-controller is set to rgmii-id, rgmii-rxid or

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Bjorn Helgaas
[+cc Rafael, linux-kernel] On Fri, May 29, 2020 at 08:50:46PM +0200, Heiner Kallweit wrote: > On 28.05.2020 23:44, Heiner Kallweit wrote: > > For whatever reason with this change (and losing ASPM control) I also > > loose the PCIe PME interrupts. This prevents my network card from > > resuming

Re: [PATCH net-next v4 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-29 Thread Dan Murphy
Rob On 5/29/20 2:03 PM, Rob Herring wrote: On Wed, May 27, 2020 at 11:49:33AM -0500, Dan Murphy wrote: Add the internal delay values into the header and update the binding with the internal delay properties. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83869.yaml |

Re: clean up kernel_{read,write} & friends v2

2020-05-29 Thread Linus Torvalds
On Fri, May 29, 2020 at 6:08 AM David Laight wrote: > > A wide monitor is for looking at lots of files. Not necessarily. Excessive line breaks are BAD. They cause real and every-day problems. They cause problems for things like "grep" both in the patterns and in the output, since grep (and a

Re: [PATCH v4 0/2] soc: ti: add k3 platforms chipid module driver

2020-05-29 Thread santosh . shilimkar
On 5/29/20 11:34 AM, Arnd Bergmann wrote: On Fri, May 29, 2020 at 8:22 PM Grygorii Strashko wrote: On 12/05/2020 15:34, Grygorii Strashko wrote: .../bindings/soc/ti/k3-socinfo.yaml | 40 + drivers/soc/ti/Kconfig| 10 ++ drivers/soc/ti/Makefile

Re: [PATCH v6 03/11] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 12:33:13 +0300, Serge Semin wrote: > Add the "baikal,bt1-sys-i2c" compatible string to the DW I2C binding. Even > though the corresponding node is supposed to be a child of the Baikal-T1 > System Controller, its reg property is left required for compatibility. > >

Re: [PATCH net-next 2/2] bridge: mrp: Add support for role MRA

2020-05-29 Thread Jakub Kicinski
On Fri, 29 May 2020 10:05:14 + Horatiu Vultur wrote: > A node that has the MRA role, it can behave as MRM or MRC. > > Initially it starts as MRM and sends MRP_Test frames on both ring ports. > If it detects that there are MRP_Test send by another MRM, then it > checks if these frames have a

[PATCH v2 1/4] dt-bindings: pinctrl: Document 7211 compatible for brcm,bcm2835-gpio.txt

2020-05-29 Thread Florian Fainelli
Document the brcm,bcm7211-gpio compatible string in the brcm,bcm2835-gpio.txt document. Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v6 02/11] dt-bindings: i2c: Convert DW I2C slave to the DW I2C master example

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 12:33:12 +0300, Serge Semin wrote: > dtc currently doesn't support I2C_OWN_SLAVE_ADDRESS flag set in the > i2c "reg" property. If dtc finds an i2c-slave sub-node having an address > higher than ten-bits wide it'll print an ugly warning: > > Warning (i2c_bus_reg):

[PATCH v2 0/4] pinctrl: bcm2835: Support for wake-up interrupts

2020-05-29 Thread Florian Fainelli
Hi Linus, This patch series updates the bcm2835 pinctrl driver to support the BCM7211 SoC which is quite similar to 2711 (Raspberry Pi 4) except that it also supports wake-up interrupts. Thanks! Changes in v2: - fixed patch #3 to reference the correct data structure (Stefan) - fixed patch #4

[PATCH v2 2/4] dt-bindings: pinctrl: Document optional BCM7211 wake-up interrupts

2020-05-29 Thread Florian Fainelli
BCM7211 supports wake-up interrupts in the form of optional interrupt lines, one per bank, plus the "all banks" interrupt line. Signed-off-by: Florian Fainelli --- .../devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v2 4/4] pinctrl: bcm2835: Add support for wake-up interrupts

2020-05-29 Thread Florian Fainelli
Leverage the IRQCHIP_MASK_ON_SUSPEND flag in order to avoid having to specifically treat the GPIO interrupts during suspend and resume, and simply implement an irq_set_wake() callback that is responsible for enabling the parent wake-up interrupt as a wake-up interrupt. To avoid allocating

Re: [PATCH v2] kasan: fix clang compilation warning due to stack protector

2020-05-29 Thread Marco Elver
On Fri, 29 May 2020 at 21:12, Andrey Konovalov wrote: > > KASAN uses a single cc-option invocation to disable both conserve-stack > and stack-protector flags. The former flag is not present in Clang, which > causes cc-option to fail, and results in stack-protector being enabled. > > Fix by using

[PATCH v2 3/4] pinctrl: bcm2835: Match BCM7211 compatible string

2020-05-29 Thread Florian Fainelli
The BCM7211 SoC uses the same pinconf_ops as the ones defined for the BCM2711 SoC, match the compatible string and use the correct set of options. Signed-off-by: Florian Fainelli --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()

2020-05-29 Thread John Hubbard
On 2020-05-29 01:29, Dragan Cvetic wrote: Hi John, Thank you for the suggestion, please find my comment below: -Original Message- From: John Hubbard Sent: Wednesday 27 May 2020 02:26 To: LKML Cc: Souptick Joarder ; John Hubbard ; Derek Kiernan ; Dragan Cvetic ; Arnd Bergmann ; Greg

Re: [PATCH net-next] vmxnet3: use correct hdr reference when packet is encapsulated

2020-05-29 Thread David Miller
From: Ronak Doshi Date: Thu, 28 May 2020 19:53:52 -0700 > 'Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload > support")' added support for encapsulation offload. However, while > preparing inner tso packet, it uses reference to outer ip headers. > > This patch fixes this issue

Re: [PATCH v13 3/7] dt-bindings: clock: Add documentation for X1830 bindings.

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 11:15:45 +0800, 周琰杰 (Zhou Yanjie) wrote: > Add documentation for the clock bindings of the X1830 Soc from Ingenic. > > Signed-off-by: 周琰杰 (Zhou Yanjie) > Reviewed-by: Rob Herring > --- > > Notes: > v11: > New patch, split from [3/6] in v10. > > v11->v12: >

Re: [PATCH 3/4] dt-bindings: timer: renesas,cmt: Document r8a7742 CMT support

2020-05-29 Thread Rob Herring
On Fri, May 29, 2020 at 02:53:02PM +0200, Geert Uytterhoeven wrote: > Hi Prabhakar, > > On Wed, May 27, 2020 at 11:19 PM Lad Prabhakar > wrote: > > Document SoC specific compatible strings for r8a7742. No driver change > > is needed as the fallback strings will activate the right code. > > > >

Re: [PATCH] kasan: fix clang compilation warning due to stack protector

2020-05-29 Thread Andrey Konovalov
On Fri, May 29, 2020 at 4:56 PM Marco Elver wrote: > > On Thu, 28 May 2020 at 19:20, 'Andrey Konovalov' via kasan-dev > wrote: > > > > KASAN uses a single cc-option invocation to disable both conserve-stack > > and stack-protector flags. The former flag is not present in Clang, which > > causes

[PATCH v2] kasan: fix clang compilation warning due to stack protector

2020-05-29 Thread Andrey Konovalov
KASAN uses a single cc-option invocation to disable both conserve-stack and stack-protector flags. The former flag is not present in Clang, which causes cc-option to fail, and results in stack-protector being enabled. Fix by using separate cc-option calls for each flag. Also collect all flags in

Re: [PATCH v2 3/3] selftests/seccomp: Test SECCOMP_IOCTL_NOTIF_ADDFD

2020-05-29 Thread Tycho Andersen
On Fri, May 29, 2020 at 06:46:07PM +, Sargun Dhillon wrote: > On Fri, May 29, 2020 at 12:41:51AM -0700, Kees Cook wrote: > > On Thu, May 28, 2020 at 04:08:58AM -0700, Sargun Dhillon wrote: > > > + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, ), 0); > > > + > > > + nextid = req.id + 1; >

Re: [PATCH 1/4] dt-bindings: thermal: rcar-thermal: Add device tree support for r8a7742

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 22:18:37 +0100, Lad Prabhakar wrote: > Add thermal sensor support for r8a7742 SoC. The Renesas RZ/G1H > (r8a7742) thermal sensor module is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,rcar-gen2-thermal". >

Re: [PATCH v3 00/28] KVM: nSVM: event fixes and migration support

2020-05-29 Thread Paolo Bonzini
On 29/05/20 19:59, Sean Christopherson wrote: >> [PATCH v3 00/28] KVM: nSVM: event fixes and migration support > You've got something funky going on with the way you generate cover letters, > looks like it doesn't count patches authored by someone else. The 'v3' is > also missing from the

Re: [PATCH v14 1/3] dt-bindings: i2c: npcm7xx: add NPCM I2C controller

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 23:08:18 +0300, Tali Perry wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM I2C controller. > > Signed-off-by: Tali Perry > --- > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 62 +++ > 1 file changed, 62 insertions(+) > create mode

Re: [PATCH v2 11/12] dt-bindings: iio: imu: Add inv_icm42600 documentation

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 08:57:10PM +0200, Jean-Baptiste Maneyrol wrote: > Document the ICM-426xxx devices devicetree bindings. > > Signed-off-by: Jean-Baptiste Maneyrol > --- > .../bindings/iio/imu/invensense,icm42600.yaml | 86 +++ > 1 file changed, 86 insertions(+) > create

Re: [PATCH 1/6] x86/entry: Introduce local_db_{save,restore}()

2020-05-29 Thread Peter Zijlstra
On Fri, May 29, 2020 at 10:28:33AM -0700, Andy Lutomirski wrote: > > +static __always_inline unsigned long local_db_save(void) > > +{ > > +unsigned long dr7; > > + > > +get_debugreg(, 7); > > +dr7 ^= 0x400; > > Why xor? This seems extra confusing. I'll do the normal mask thing ..

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2020-05-29 Thread Logan Gunthorpe
On 2020-05-29 6:45 a.m., Christoph Hellwig wrote: > On Thu, May 28, 2020 at 06:00:44PM -0600, Logan Gunthorpe wrote: >>> This issue is most likely in the i915 driver and is most likely caused by >>> the driver not respecting the return value of the dma_map_ops::map_sg >>> function. You can

Re: [PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode

2020-05-29 Thread Paolo Bonzini
On 29/05/20 20:10, Krish Sadhukhan wrote: >> Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, >> since the map is not used elsewhere in the function.  There are >> just two calls, so move it there. > > The last sentence sounds bit incomplete. Good point---more precisely,

Re: [PATCH net-next v4 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 11:49:33AM -0500, Dan Murphy wrote: > Add the internal delay values into the header and update the binding > with the internal delay properties. > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/net/ti,dp83869.yaml | 16 > 1 file

Re: Kernel crash due to memory corruption with v5.4.26-rt17 and PowerPC e500

2020-05-29 Thread Mark Marshall
My config is attached. This is the greatly reduced config that I used when trying to narrow down the problem. We normally have much more enabled, but that had no effect on the bug in my testing. We do, unfortunately, have quite a few out-of-tree patches, but they are all in USB or Networking,

[PATCH v2 2/2] m68k,nommu: fix implicit cast from __user in __{get,put}_user_asm()

2020-05-29 Thread Luc Van Oostenryck
The assembly for __get_user_asm() & __put_user_asm() uses memcpy() when the size is 8. However, the pointer is always a __user one while memcpy() expects a plain one and so this cast creates a lot of warnings when using Sparse. So, fix this by adding a cast to 'void __force *' at memcpy()'s

Re: [PATCH 10/30] KVM: nSVM: extract preparation of VMCB for nested run

2020-05-29 Thread Paolo Bonzini
On 29/05/20 20:27, Krish Sadhukhan wrote: >> >> +static void nested_prepare_vmcb_save(struct vcpu_svm *svm, struct >> vmcb *nested_vmcb) > > > Not a big deal, but I feel that it helps a lot in readability if we keep > the names symmetric. This one could be named prepare_nested_vmcb_save to >

[PATCH v2 1/2] m68k,nommu: add missing __user in uaccess' __ptr() macro

2020-05-29 Thread Luc Van Oostenryck
The assembly for __get_user() & __put_user() uses a macro, __ptr(), to cast the pointer to 'unsigned long *' but the pointer is always a __user one and so this cast creates a lot of warnings when using Sparse. So, change to the cast to 'unsigned long __user *'. Reported-by: kbuild test robot

[PATCH v2 0/2] fix missing handling of __user in nommu's uaccess()

2020-05-29 Thread Luc Van Oostenryck
I received a bug report for an unrelated patch when used with m68k-nommu. It appears that the origin of the problem is that __get_user() and __put_user() doesn't handle correctly __user. These 2 patches fix this. Note: this is only minimaly tested but is quite straightforward and since this

Re: [PATCH -tip v3 05/11] kcsan: Remove 'noinline' from __no_kcsan_or_inline

2020-05-29 Thread Peter Zijlstra
On Fri, May 29, 2020 at 08:36:56PM +0200, Marco Elver wrote: > > +/* Section for code which can't be instrumented at all */ > > +#define noinstr > > \ > > + noinline notrace __attribute((__section__(".noinstr.text"))) > >

[git pull] IOMMU Fixes for Linux v5.7-rc7

2020-05-29 Thread Joerg Roedel
Hi Linus, The following changes since commit 9cb1fd0efd195590b828b9b865421ad345a4a145: Linux 5.7-rc7 (2020-05-24 15:32:54 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-fixes-v5.7-rc7 for you to fetch changes up to

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Serge Semin
On Fri, May 29, 2020 at 09:45:37PM +0300, Serge Semin wrote: > On Fri, May 29, 2020 at 09:42:01PM +0300, Andy Shevchenko wrote: > > On Fri, May 29, 2020 at 09:22:56PM +0300, Serge Semin wrote: > > > On Fri, May 29, 2020 at 12:13:38PM -0600, Rob Herring wrote: > > > > On Wed, May 27, 2020 at

Re: [PATCH v8 0/8] powerpc: switch VDSO to C implementation

2020-05-29 Thread Christophe Leroy
Hi Michael, Le 28/04/2020 à 15:16, Christophe Leroy a écrit : This is the seventh version of a series to switch powerpc VDSO to generic C implementation. Main changes since v7 are: - Added gettime64 on PPC32 This series applies on today's powerpc/merge branch. See the last patches for

Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-29 Thread Guenter Roeck
On 5/29/20 10:57 AM, Vijay Khemka wrote: > > > On 5/29/20, 5:47 AM, "Manikandan Elumalai" > wrote: > > The adm1278 temperature sysfs attribute need it for one of the openbmc > platform . > This functionality is not enabled by default, so PMON_CONFIG needs to be > modified in order

Re: [PATCH] powerpc/32s: Fix another build failure with CONFIG_PPC_KUAP_DEBUG

2020-05-29 Thread Christophe Leroy
Le 29/05/2020 à 20:50, Christophe Leroy a écrit : From: Christophe Leroy 'thread' doesn't exist in kuap_check() macro. Use 'current' instead. Fixes: a68c31fc01ef ("powerpc/32s: Implement Kernel Userspace Access Protection") Signed-off-by: Christophe Leroy Argh, can you drop this line

Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-29 Thread Guenter Roeck
On 5/29/20 10:42 AM, Patrick Williams wrote: > Hi Guenter, > > Thanks for the initial look at this. > > One question for you below... > > On Fri, May 29, 2020 at 10:30:16AM -0700, Guenter Roeck wrote: >> On 5/29/20 5:46 AM, Manikandan Elumalai wrote: >>> + /* Enable TEMP1 by default

[PATCH] powerpc/32s: Fix another build failure with CONFIG_PPC_KUAP_DEBUG

2020-05-29 Thread Christophe Leroy
From: Christophe Leroy 'thread' doesn't exist in kuap_check() macro. Use 'current' instead. Fixes: a68c31fc01ef ("powerpc/32s: Implement Kernel Userspace Access Protection") Signed-off-by: Christophe Leroy Cc: sta...@vger.kernel.org Signed-off-by: Christophe Leroy ---

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-05-29 Thread Markus Elfring
> Please just remove the message instead, it's a tiny allocation that's > unlikely to ever fail, and the caller will print an error anyway. How do you think about to take another look at a previous update suggestion like the following? powerpc/nvram: Delete three error messages for a failed

RE: [EXTERNAL] Re: [PATCH v4] perf inject --jit: Remove //anon mmap events

2020-05-29 Thread Steve MacLean
> I've been trying variants of: > > Before: >/tmp/perf/perf record -k 1 -e cycles:u -o /tmp/perf.data java >-agentpath:/tmp/perf/libperf-jvmti.so -XX:+PreserveFramePointer >-XX:InitialCodeCacheSize=20M -XX:ReservedCodeCacheSize=1G -jar >dacapo-9.12-bach.jar jython /tmp/perf/perf inject -i

Re: [PATCH v2 3/3] selftests/seccomp: Test SECCOMP_IOCTL_NOTIF_ADDFD

2020-05-29 Thread Sargun Dhillon
On Fri, May 29, 2020 at 12:41:51AM -0700, Kees Cook wrote: > On Thu, May 28, 2020 at 04:08:58AM -0700, Sargun Dhillon wrote: > > + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, ), 0); > > + > > + nextid = req.id + 1; > > + > > + /* Wait for getppid to be called for the second time */ >

Re: [PATCH v3 5/6] hwmon: pmbus: adm1266: read blackbox

2020-05-29 Thread Guenter Roeck
On 5/29/20 6:05 AM, alexandru.tach...@analog.com wrote: > From: Alexandru Tachici > > Use the nvmem kernel api to expose the black box > chip functionality to userspace. > This needs to be split into two functions: Add nvmem support, add debugfs file. Guenter > Signed-off-by: Alexandru

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Serge Semin
On Fri, May 29, 2020 at 09:42:01PM +0300, Andy Shevchenko wrote: > On Fri, May 29, 2020 at 09:22:56PM +0300, Serge Semin wrote: > > On Fri, May 29, 2020 at 12:13:38PM -0600, Rob Herring wrote: > > > On Wed, May 27, 2020 at 06:33:51PM +0300, Serge Semin wrote: > > > > you're sending > > > new

Re: [PATCH v3 4/6] hwmon: pmbus: adm1266: add debugfs attr for states

2020-05-29 Thread Guenter Roeck
On 5/29/20 6:05 AM, alexandru.tach...@analog.com wrote: > From: Alexandru Tachici > > Add debugfs files for go_command and read_state. > > Signed-off-by: Alexandru Tachici > --- > drivers/hwmon/pmbus/adm1266.c | 47 +++ > 1 file changed, 47 insertions(+) > >

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Andy Shevchenko
On Fri, May 29, 2020 at 09:22:56PM +0300, Serge Semin wrote: > On Fri, May 29, 2020 at 12:13:38PM -0600, Rob Herring wrote: > > On Wed, May 27, 2020 at 06:33:51PM +0300, Serge Semin wrote: > > you're sending > > new versions too fast. Give people time to review. > > Yeah, you did. Sorry for

Re: [PATCH v7 1/4] bitops: Introduce the the for_each_set_clump macro

2020-05-29 Thread Andy Shevchenko
On Fri, May 29, 2020 at 11:38:18PM +0530, Syed Nayyar Waris wrote: > On Sun, May 24, 2020 at 8:15 PM kbuild test robot wrote: ... > >579 static inline unsigned long bitmap_get_value(const unsigned long > > *map, > >580unsigned long

Re: [PATCH -tip v3 05/11] kcsan: Remove 'noinline' from __no_kcsan_or_inline

2020-05-29 Thread Marco Elver
On Fri, 29 May 2020 at 19:08, Peter Zijlstra wrote: [...] > > Doesn't this mean we can do the below? If nobody complains about the lack of __no_kcsan_or_inline, let's do it. See comments below. > --- > Documentation/dev-tools/kcsan.rst | 6 -- > arch/x86/include/asm/bitops.h | 6

Re: [PATCH] RDMA/core: Fix several reference count leaks.

2020-05-29 Thread Jason Gunthorpe
On Wed, May 27, 2020 at 10:02:30PM -0500, wu000...@umn.edu wrote: > From: Qiushi Wu > > kobject_init_and_add() takes reference even when it fails. > If this function returns an error, kobject_put() must be called to > properly clean up the memory associated with the object. Previous > commit

Re: [PATCH v3 3/6] hwmon: pmbus: adm1266: Add support for GPIOs

2020-05-29 Thread Guenter Roeck
On 5/29/20 6:05 AM, alexandru.tach...@analog.com wrote: > From: Alexandru Tachici > > Adm1266 exposes 9 GPIOs and 16 PDIOs which are currently read-only. They > are controlled by the internal sequencing engine. > > This patch makes adm1266 driver expose GPIOs and PDIOs to user-space > using

Re: [PATCH v4 0/2] soc: ti: add k3 platforms chipid module driver

2020-05-29 Thread Arnd Bergmann
On Fri, May 29, 2020 at 8:22 PM Grygorii Strashko wrote: > On 12/05/2020 15:34, Grygorii Strashko wrote: > > .../bindings/soc/ti/k3-socinfo.yaml | 40 + > > drivers/soc/ti/Kconfig| 10 ++ > > drivers/soc/ti/Makefile | 1 + > >

Re: [PATCH V2 0/4] x86/entry: simply stack switching when exception on userspace

2020-05-29 Thread Andy Lutomirski
On Fri, May 29, 2020 at 1:26 AM Lai Jiangshan wrote: > > 7f2590a110b8("x86/entry/64: Use a per-CPU trampoline stack for IDT entries") > has resulted that when exception on userspace, the kernel (error_entry) > always push the pt_regs to entry stack(sp0), and then copy them to the > kernel stack.

Re: [PATCH v30 09/20] mm: Introduce vm_ops->may_mprotect()

2020-05-29 Thread Dave Hansen
On 5/14/20 5:43 PM, Jarkko Sakkinen wrote: > From: Sean Christopherson > > Add vm_ops()->may_mprotect() to check additional constrains set by a > subsystem for a mprotect() call. This changelog needs some more detail about why this is needed. It would also be nice to include thought about what

Re: [PATCH] x86/uaccess: Remove redundant likely/unlikely annotations

2020-05-29 Thread Randy Dunlap
On 5/29/20 10:25 AM, Josh Poimboeuf wrote: > On Fri, May 29, 2020 at 06:54:19PM +0200, Peter Zijlstra wrote: >> On Fri, May 29, 2020 at 11:50:11AM -0500, Josh Poimboeuf wrote: >>> The nested likelys seem like overkill anyway -- user_access_begin() is >>> __always_inline and it already has

Re: [PATCH][next] IB/hfi1: fix spelling mistake "enought" -> "enough"

2020-05-29 Thread Jason Gunthorpe
On Thu, May 28, 2020 at 12:07:09PM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in an error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/hfi1/chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to

Re: [PATCH 10/30] KVM: nSVM: extract preparation of VMCB for nested run

2020-05-29 Thread Krish Sadhukhan
On 5/29/20 8:39 AM, Paolo Bonzini wrote: Split out filling svm->vmcb.save and svm->vmcb.control before VMRUN. Only the latter will be useful when restoring nested SVM state. This patch introduces no semantic change, so the MMU setup is still done in nested_prepare_vmcb_save. The next patch

Re: [PATCH] x86/resctrl: fix a NULL vs IS_ERR() static checker warning

2020-05-29 Thread Reinette Chatre
Hi Dan, On 5/29/2020 5:27 AM, Dan Carpenter wrote: > The callers don't expect *d_cdp to be set to an error pointer, they only > check for NULL. This leads to a static checker warning: > > arch/x86/kernel/cpu/resctrl/rdtgroup.c:2648 __init_one_rdt_domain() > warn: 'd_cdp' could be an

[PATCH v7] dt-bindings: spi: Convert DW SPI binding to DT schema

2020-05-29 Thread Serge Semin
Modern device tree bindings are supposed to be created as YAML-files in accordance with dt-schema. This commit replaces two DW SPI legacy bare text bindings with YAML file. As before the bindings file states that the corresponding dts node is supposed to be compatible either with generic DW APB

Re: [PATCH net-next v4 1/4] dt-bindings: net: Add tx and rx internal delays

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 11:49:31AM -0500, Dan Murphy wrote: > tx-internal-delays and rx-internal-delays are a common setting for RGMII > capable devices. > > These properties are used when the phy-mode or phy-controller is set to > rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Serge Semin
On Fri, May 29, 2020 at 12:13:38PM -0600, Rob Herring wrote: > On Wed, May 27, 2020 at 06:33:51PM +0300, Serge Semin wrote: > > Rob, > > Could you pay attention to this patch? The patchset review procedure is > > nearly over, while the DT part is only partly reviewed by you. > > Pretty sure I

Re: [PATCH v4 0/2] soc: ti: add k3 platforms chipid module driver

2020-05-29 Thread Grygorii Strashko
Hi Santosh, On 12/05/2020 15:34, Grygorii Strashko wrote: Hi All, This series introduces TI K3 Multicore SoC platforms chipid module driver which provides identification support of the TI K3 SoCs (family, revision) and register this information with the SoC bus. It is available under

Re: [GIT PULL] sh: remove sh5 support

2020-05-29 Thread Christoph Hellwig
On Fri, May 29, 2020 at 01:53:38PM -0400, Rich Felker wrote: > Frustratingly, I _still_ don't have an official tree on kernel.org for > the purpose of being the canonical place for linux-next to pull from, > due to policies around pgp keys and nobody following up on signing > mine. This is all

Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone

2020-05-29 Thread Martin Kepplinger
On 29.05.20 20:07, Pavel Machek wrote: > Hi! > > Plus, do we need calibration matrix for magnetometer? I guess so. It's not a calibration matrix, it's the mount matrix that tells you how the chip is placed on the PCB relative to a "natural" orientation, see

Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq

2020-05-29 Thread Jason Gunthorpe
On Thu, May 28, 2020 at 04:04:27PM +0100, Colin King wrote: > From: Colin Ian King > > The pointer raq is being assigned twice. Fix this by removing > one of the redundant assignments. > > Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general > pointers") >

Re: [PATCH v30 09/20] mm: Introduce vm_ops->may_mprotect()

2020-05-29 Thread Jarkko Sakkinen
On Fri, May 29, 2020 at 02:10:38PM +0200, Borislav Petkov wrote: > On Fri, May 15, 2020 at 03:43:59AM +0300, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > Add vm_ops()->may_mprotect() to check additional constrains set by a > > "constraints" > > > subsystem for a mprotect()

Re: [PATCH v3 104/105] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 05:49:14PM +0200, Maxime Ripard wrote: > The HDMI controllers found in the BCM2711 SoC need some adjustments to the > bindings, especially since the registers have been shuffled around in more > register ranges. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org >

Re: [PATCH 0/2] x86/entry: simplify RESTORE_CR3

2020-05-29 Thread Andy Lutomirski
On Mon, May 25, 2020 at 9:35 PM Lai Jiangshan wrote: > > When I searched percpu data touched by entry code for #DB > protection[1], it seems to me RESTORE_CR3() does too much work, > this patchset simplifies it. > > Patch 1 enhances 21e944591102("x86/mm: Optimize RESTORE_CR3") for > kernel CR3. >

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Lukas Wunner
On Fri, May 29, 2020 at 11:03:48AM -0700, Florian Fainelli wrote: > On 5/29/20 10:53 AM, Lukas Wunner wrote: > > On Fri, May 29, 2020 at 10:46:01AM -0700, Florian Fainelli wrote: > >> On 5/29/20 10:43 AM, Lukas Wunner wrote: > >>> Finally, it would be nice if the check would be optimized away when

Re: [PATCH] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-05-29 Thread Mark Brown
On Sat, May 30, 2020 at 01:26:20AM +0800, Tzung-Bi Shih wrote: > On Fri, May 29, 2020 at 9:05 PM Mark Brown wrote: > > I thought that was normal for DMICs - is this selecting between left and > > right or something? > Not sure what is the common name but use the same context here. > MT6358

Re: [PATCH v3 02/25] dt-bindings: clock: Add a binding for the RPi Firmware clocks

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 17:44:58 +0200, Maxime Ripard wrote: > The firmware running on the RPi VideoCore can be used to discover and > change the various clocks running in the BCM2711. Since devices will > need to use them through the DT, let's add a pretty simple binding. > > Cc: Michael Turquette

Re: [PATCH 8/8] blk-mq: drain I/O when all CPUs in a hctx are offline

2020-05-29 Thread Paul E. McKenney
On Fri, May 29, 2020 at 11:53:15AM +0800, Ming Lei wrote: > Hi Paul, > > On Thu, May 28, 2020 at 08:07:28PM -0700, Paul E. McKenney wrote: > > On Fri, May 29, 2020 at 09:53:04AM +0800, Ming Lei wrote: > > > Hi Paul, > > > > > > Thanks for your response! > > > > > > On Thu, May 28, 2020 at

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 06:33:51PM +0300, Serge Semin wrote: > Rob, > Could you pay attention to this patch? The patchset review procedure is > nearly over, while the DT part is only partly reviewed by you. Pretty sure I commented on this. Not sure what version, you're sending new versions too

Re: [PATCH V5 0/9] Enable ext4 support for per-file/directory DAX operations

2020-05-29 Thread Ira Weiny
On Fri, May 29, 2020 at 12:17:17AM -0400, Theodore Y. Ts'o wrote: > On Thu, May 28, 2020 at 10:54:41PM -0400, Theodore Y. Ts'o wrote: > > > > Thanks, applied to the ext4-dax branch. > > > > I spoke too soon. While I tried merging with the ext4.git dev branch, > a merge conflict made me look

Re: [PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode

2020-05-29 Thread Krish Sadhukhan
On 5/29/20 8:39 AM, Paolo Bonzini wrote: Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, since the map is not used elsewhere in the function. There are just two calls, so move it there. The last sentence sounds bit incomplete. Also, does it make sense to mention the

Re: general protection fault in inet_unhash

2020-05-29 Thread Eric Dumazet
On 5/29/20 10:32 AM, Eric Dumazet wrote: > L2TP seems to use sk->sk_node to insert sockets into l2tp_ip_table, _and_ > uses l2tp_ip_prot.unhash == inet_unhash > > So if/when BPF_CGROUP_RUN_PROG_INET_SOCK(sk) returns an error and > inet_create() calls sk_common_release() > bad things happen,

Re: [PATCH 1/4] sctp: add sctp_sock_set_nodelay

2020-05-29 Thread David Teigland
On Fri, May 29, 2020 at 02:09:40PM +0200, Christoph Hellwig wrote: > Add a helper to directly set the SCTP_NODELAY sockopt from kernel space > without going through a fake uaccess. Ack, they look fine to me, thanks. Dave

Re: [PATCH V6 3/5] clk: qcom: Add DT bindings for ipq6018 apss clock controller

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 17:54:50 +0530, Sivaprakash Murugesan wrote: > Add dt-binding for ipq6018 apss clock controller > > Signed-off-by: Sivaprakash Murugesan > --- > [V6] > * Addressed review comment from Stephen > include/dt-bindings/clock/qcom,apss-ipq.h | 12 > 1 file changed,

Re: [PATCH V6 1/5] dt-bindings: clock: add ipq6018 a53 pll compatible

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 05:54:48PM +0530, Sivaprakash Murugesan wrote: > cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 > pll found on ipq6018 devices. > > Signed-off-by: Sivaprakash Murugesan > --- > * [V6] > re-ordered compatible string, dropped Rob's review tag for

Re: [PATCH v7 1/4] bitops: Introduce the the for_each_set_clump macro

2020-05-29 Thread Syed Nayyar Waris
On Sun, May 24, 2020 at 8:15 PM kbuild test robot wrote: > > Hi Syed, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on b9bbe6ed63b2b9f2c9ee5cbd0f2c946a2723f4ce] > > url: >

Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone

2020-05-29 Thread Pavel Machek
Hi! Plus, do we need calibration matrix for magnetometer? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH 2/2] perf build: Allow explicitely disabling the NO_SYSCALL_TABLE variable

2020-05-29 Thread Jiri Olsa
On Fri, May 29, 2020 at 12:55:52PM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > This is useful to see if, on x86, the legacy libaudit still works, as it > is used in architectures that don't have the SYSCALL_TABLE logic and we > want to have it tested in 'make -C

Re: [PATCH v14 1/1] perf tools: add support for libpfm4

2020-05-29 Thread Ian Rogers
On Fri, May 29, 2020 at 10:36 AM Arnaldo Carvalho de Melo wrote: > > Em Fri, May 29, 2020 at 02:23:10PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, May 29, 2020 at 10:03:51AM -0700, Ian Rogers escreveu: > > > On Tue, May 5, 2020 at 11:29 AM Ian Rogers wrote: > > > > > > > > From:

[PATCH] dt-bindings: Merge gpio-usb-b-connector with usb-connector

2020-05-29 Thread Thierry Reding
From: Thierry Reding The binding for usb-connector is a superset of gpio-usb-b-connector. One major difference is that gpio-usb-b-connector requires at least one of the vbus-gpios and id-gpios properties to be specified. Merge the two bindings by adding the compatible string combination for the

Re: [PATCH] [v2] PCI: tegra: Fix runtime PM imbalance on error

2020-05-29 Thread Thierry Reding
On Thu, May 21, 2020 at 10:47:09AM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. > > Also, call pm_runtime_disable() when

Re: [RFC] decrease tsk->signal->live before profile_task_exit

2020-05-29 Thread Eric W. Biederman
liuchao writes: > I want to dermine which thread is the last one to enter > do_exit in profile_task_exit. But when a lot of threads > exit, tsk->signal->live is not correct since it decrease > after profile_task_exit. I don't think that would be wise. Any additional code before the sanity

Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:58 AM, Lukas Wunner wrote: > On Fri, May 29, 2020 at 10:48:11AM -0700, Florian Fainelli wrote: >> On 5/29/20 10:47 AM, Lukas Wunner wrote: >>> On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: Make sure we clear the FIFOs, stop the block, disable the clock and

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:53 AM, Lukas Wunner wrote: > On Fri, May 29, 2020 at 10:46:01AM -0700, Florian Fainelli wrote: >> On 5/29/20 10:43 AM, Lukas Wunner wrote: >>> On Thu, May 28, 2020 at 08:58:04PM +0200, Nicolas Saenz Julienne wrote: --- a/drivers/spi/spi-bcm2835.c +++

Re: [PATCH] ARM: dts: imx53: ppd: alarm LEDs use kernel LED interface

2020-05-29 Thread Sebastian Reichel
Hi, On Fri, May 29, 2020 at 06:02:04PM +0200, Pavel Machek wrote: > > ping? > > Well, I thought that we maybe do not need standard LEDs on medical hardware. The discussion died and the patch was not applied :) In general IDK how worthwhile it is to use standard LED names for them. I suppose the

Re: [PATCH 8/8] ARM: OMAP2: Use custom soc attribute group instead of device_create_file

2020-05-29 Thread Tony Lindgren
* Sudeep Holla [200523 17:10]: > Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried to use it, it was

<    1   2   3   4   5   6   7   8   9   10   >