Re: [PATCH] uacce: fix some coding styles

2020-07-20 Thread Zhangfei Gao
On 2020/7/20 下午3:18, Kai Ye wrote: 1. add some parameter check. 2. delete some redundant code. 3. modify the module author information. Signed-off-by: Kai Ye Reviewed-by: Zhou Wang Thanks Kai. --- drivers/misc/uacce/uacce.c | 28 +--- 1 file changed, 13 insertio

Re: mmotm 2020-07-20-19-06 uploaded (net/ipv6/ip6_vti.o)

2020-07-20 Thread Stephen Rothwell
Hi all, On Tue, 21 Jul 2020 16:54:24 +1000 Stephen Rothwell wrote: > > On Mon, 20 Jul 2020 23:09:34 -0700 Randy Dunlap wrote: > > > > on i386: > > > > ld: net/ipv6/ip6_vti.o: in function `vti6_rcv_tunnel': > > ip6_vti.c:(.text+0x2d11): undefined reference to `xfrm6_tunnel_spi_lookup' > > Ca

[PATCH] HID: quirks: add NOGET quirk for Logitech GROUP

2020-07-20 Thread Ikjoon Jang
Add HID_QUIRK_NOGET for Logitech GROUP device. Logitech GROUP is a compound with camera and audio. When the HID interface in an audio device is requested to get specific report id, all following control transfers are stalled and never be restored back. BugLink: https://bugzilla.kernel.org/show_bu

Re: mmotm 2020-07-20-19-06 uploaded (net/ipv6/ip6_vti.o)

2020-07-20 Thread Stephen Rothwell
Hi all, On Mon, 20 Jul 2020 23:09:34 -0700 Randy Dunlap wrote: > > on i386: > > ld: net/ipv6/ip6_vti.o: in function `vti6_rcv_tunnel': > ip6_vti.c:(.text+0x2d11): undefined reference to `xfrm6_tunnel_spi_lookup' Caused by commit 08622869ed3f ("ip6_vti: support IP6IP6 tunnel processing with .

Re: [PATCH] riscv: Select ARCH_HAS_DEBUG_VM_PGTABLE

2020-07-20 Thread Emil Renner Berthing
On Tue, 21 Jul 2020 at 06:04, Palmer Dabbelt wrote: > > On Tue, 14 Jul 2020 20:20:54 PDT (-0700), anshuman.khand...@arm.com wrote: > > > > > > On 07/15/2020 02:56 AM, Emil Renner Berthing wrote: > >> This allows the pgtable tests to be built. > >> > >> Signed-off-by: Emil Renner Berthing > >> ---

Re: hibernation reverts in 4.19.134: better alternative?

2020-07-20 Thread Eugeniu Rosca
Hi Pavel, On Mon, Jul 20, 2020 at 12:15:22PM +0200, Pavel Machek wrote: > This is queued for 4.19.134-stable, reverting 3 patches. But it seems > better alternative is available... > > commit f3e697b7b6f5e2c570226f8f8692fb7db57215ec > Author: Sasha Levin > Date: Fri Jul 17 12:58:32 2020 -0400

Re: [PATCH 4/5] drm/vblank: Use spin_(un)lock_irq() in drm_queue_vblank_event()

2020-07-20 Thread Daniel Vetter
On Mon, Jul 20, 2020 at 03:07:35PM -0400, Lyude Paul wrote: > This one's easy - we're already calling kzalloc() in this function, so Nit: "kzalloc(GFP_KERNEL)", since kzalloc(GFP_ATOMIC) is perfectly fine in interrupt context. With that clarified for the entire series: Reviewed-by: Daniel Vetter

Re: [PATCH v2] pinctrl: core: print gpio in pins debugfs file

2020-07-20 Thread Andy Shevchenko
On Mon, Jul 20, 2020 at 10:18 PM Drew Fustini wrote: > > If there is a gpio range mapping for the pin, then print out the gpio > number for the pin in the debugfs 'pins' file. > > Here is an example output on the BeagleBone Black from: > /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single/pin

Re: [PATCH 2/2] debugfs: Add access restriction option

2020-07-20 Thread Enderborg, Peter
On 7/15/20 11:39 AM, Greg Kroah-Hartman wrote: > On Wed, Jul 15, 2020 at 10:42:07AM +0200, Peter Enderborg wrote: >> Since debugfs include sensitive information it need to be treated >> carefully. But it also has many very useful debug functions for userspace. >> With this option we can have same c

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-20 Thread Daniel Vetter
On Tue, Jul 21, 2020 at 05:33:00AM +, Sidong Yang wrote: > Hi, Daniel and Melissa > > I tested some code for this problem trying to find the code that make problem > in igt test. > kms_cursor_crc test in igt test has 3 steps (preparation, test, cleanup). I > check each steps > and I found th

Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

2020-07-20 Thread Alexander A. Klimov
Am 21.07.20 um 08:05 schrieb Leon Romanovsky: On Mon, Jul 20, 2020 at 11:34:00PM +0200, Alexander A. Klimov wrote: Am 20.07.20 um 18:48 schrieb Leon Romanovsky: On Mon, Jul 20, 2020 at 08:36:35AM -0600, Jonathan Corbet wrote: On Mon, 20 Jul 2020 17:07:16 +0300 Leon Romanovsky wrote: Do

[PATCH v2] ipmi/watchdog: add missing newlines when printing parameters by sysfs

2020-07-20 Thread Xiongfeng Wang
When I cat some ipmi_watchdog parameters by sysfs, it displays as follows. It's better to add a newline for easy reading. root@(none):/# cat /sys/module/ipmi_watchdog/parameters/action resetroot@(none):/# cat /sys/module/ipmi_watchdog/parameters/preaction pre_noneroot@(none):/# cat /sys/module/ipm

[PATCH] serial: 8250: fix null-ptr-deref in serial8250_start_tx()

2020-07-20 Thread Yang Yingliang
I got null-ptr-deref in serial8250_start_tx(): [ 78.114630] Unable to handle kernel NULL pointer dereference at virtual address [ 78.123778] Mem abort info: [ 78.126560] ESR = 0x8607 [ 78.129603] EC = 0x21: IABT (current EL), IL = 32 bits [ 78.134891] SET = 0,

Re: [PATCH v7 3/4] mmc: mediatek: command queue support

2020-07-20 Thread yong....@mediatek.com
On Mon, 2020-07-20 at 08:42 +0800, Chun-Hung Wu wrote: > Support command queue for mt6779 platform. > a. Add msdc_set_busy_timeout() to calculate emmc write timeout. > b. Connect mtk msdc driver to cqhci driver through >host->cq_host->ops = &msdc_cmdq_ops; > c. msdc_cmdq_irq() will link up with

Re: [PATCH v2 24/24] scsi: aic7xxx: aic79xx_osm: Remove set but unused variabes 'saved_scsiid' and 'saved_modes'

2020-07-20 Thread Hannes Reinecke
On 7/15/20 1:03 AM, James Bottomley wrote: On Tue, 2020-07-14 at 22:39 +0100, Lee Jones wrote: On Tue, 14 Jul 2020, James Bottomley wrote: On Tue, 2020-07-14 at 09:46 +0200, Hannes Reinecke wrote: On 7/13/20 10:00 AM, Lee Jones wrote: Haven't been used since 2006. Fixes the following W=1 ke

Re: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

2020-07-20 Thread Mike Rapoport
Hi, On Tue, Jul 21, 2020 at 01:56:33AM +, liwei (CM) wrote: > Hi, all > > I'm sorry to bother you, but still very hope you can give comments or > suggestions to this patch, thank you very much. I cannot find your patch neither in Inbox nor in the public archives. Can you resend it please?

[RFC PATCH] mm: silence soft lockups from unlock_page

2020-07-20 Thread Michal Hocko
From: Michal Hocko We have seen a bug report with huge number of soft lockups during the system boot on !PREEMPT kernel NMI watchdog: BUG: soft lockup - CPU#1291 stuck for 22s! [systemd-udevd:43283] [...] NIP [c094e66c] _raw_spin_lock_irqsave+0xac/0x100 LR [c094e654] _raw_spin_loc

linux-next: build failure after merge of the scsi-mkp tree

2020-07-20 Thread Stephen Rothwell
Hi all, After merging the scsi-mkp tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: modpost: "exynos_ufs_dump_info" [drivers/scsi/ufs/ufs-exynos.ko] undefined! ERROR: modpost: "exynos_ufs_init_dbg" [drivers/scsi/ufs/ufs-exynos.ko] undefined! ERROR: modpost: "exynos_

RE: [PATCH 1/2] dt-bindings: reset: Updated binding for Versal reset driver

2020-07-20 Thread Sai Krishna Potthuri
Hi Rob, Thanks for the review > -Original Message- > From: Rob Herring > Sent: Tuesday, July 21, 2020 7:38 AM > To: Sai Krishna Potthuri > Cc: Philipp Zabel ; Michal Simek > ; devicet...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org; git > ; saik

[v3 PATCH RESEND] printk: Make linux/printk.h self-contained

2020-07-20 Thread Herbert Xu
As it stands if you include printk.h by itself it will fail to compile because it requires definitions from ratelimit.h. However, simply including ratelimit.h from printk.h does not work due to inclusion loops involving sched.h and kernel.h. This patch solves this by moving bits from ratelimit.h

Re: [PATCH v2 3/4] dt-bindings: i2c-stm32: add SMBus Alert bindings

2020-07-20 Thread Wolfram Sang
Hi Rob, > > > The I2C/SMBUS framework already provides a mechanism to enable SMBus-Alert > > > by naming an IRQ line "smbus_alert". However, on stm32, the SMBus-Alert is > > > part of the i2c IRQ. Using the smbus_alert naming here would lead to > > > having > > > 2 handlers (the handler of the dr

Re: [PATCH v5 04/18] nitro_enclaves: Init PCI device driver

2020-07-20 Thread Paraschiv, Andra-Irina
On 20/07/2020 17:24, Alexander Graf wrote: On 15.07.20 21:45, Andra Paraschiv wrote: The Nitro Enclaves PCI device is used by the kernel driver as a means of communication with the hypervisor on the host where the primary VM and the enclaves run. It handles requests with regard to enclave l

Re: [PATCH] ipmi/watchdog: add missing newlines when printing parameters by sysfs

2020-07-20 Thread Xiongfeng Wang
On 2020/7/21 10:00, Joe Perches wrote: > On Tue, 2020-07-21 at 09:20 +0800, Xiongfeng Wang wrote: >> On 2020/7/21 3:52, Corey Minyard wrote: >>> On Mon, Jul 20, 2020 at 10:03:25AM +0800, Xiongfeng Wang wrote: When I cat some ipmi_watchdog parameters by sysfs, it displays as follows. It

linux-next: manual merge of the dmaengine tree with the phy-next tree

2020-07-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the dmaengine tree got a conflict in: MAINTAINERS between commit: 4a33bea00314 ("phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver") from the phy-next tree and commit: ef9303fdf46f ("dt: bindings: dma: xilinx: dpdma: DT bindings f

Re: [PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

2020-07-20 Thread Xiongfeng Wang
Hi, On 2020/7/21 8:44, David Miller wrote: > From: Xiongfeng Wang > Date: Mon, 20 Jul 2020 19:17:49 +0800 > >> -return sprintf(buf, "%lu", trans_timeout); >> +return sprintf(buf, "%lu\n", trans_timeout); > > Better to replace it with 'fmt_ulong'. Thanks for your advice. I will change i

Re: mmotm 2020-07-20-19-06 uploaded (net/ipv6/ip6_vti.o)

2020-07-20 Thread Steffen Klassert
On Mon, Jul 20, 2020 at 11:09:34PM -0700, Randy Dunlap wrote: > On 7/20/20 7:07 PM, Andrew Morton wrote: > > The mm-of-the-moment snapshot 2020-07-20-19-06 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > > >

Re: [PATCH 0/2] Modularization of DFL private feature drivers

2020-07-20 Thread Xu Yilun
On Mon, Jul 20, 2020 at 05:21:43PM +0800, Wu, Hao wrote: > > On 7/16/20 8:48 PM, Wu, Hao wrote: > > >> Subject: Re: [PATCH 0/2] Modularization of DFL private feature drivers > > >> > > >> Generally i think this is a good approach. > > >> > > >> However I do have concern. > > >> > > >> The feature_i

Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

2020-07-20 Thread Leon Romanovsky
On Mon, Jul 20, 2020 at 11:34:00PM +0200, Alexander A. Klimov wrote: > > > Am 20.07.20 um 18:48 schrieb Leon Romanovsky: > > On Mon, Jul 20, 2020 at 08:36:35AM -0600, Jonathan Corbet wrote: > > > On Mon, 20 Jul 2020 17:07:16 +0300 > > > Leon Romanovsky wrote: > > > > > > > > Do *you* want to revie

Re: [PATCH] i2c: xiic: Fix reference count leaks.

2020-07-20 Thread Michal Simek
Hi Qiushi, On 13. 07. 20 21:41, Qiushi Wu wrote: > Hi Michal, > I think multiple previous patches also fixed similar problems, such as > https://patchwork.kernel.org/patch/2404751/ > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2227849.html > https://patchwork.ozlabs.org/project/li

[PATCH v5 4/4] power: supply: core: property to control reverse charge

2020-07-20 Thread Qiwu Huang
From: Qiwu Huang Interface to control wireless reverse charge. Supply reverse charge function when enabled. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 12 drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h

Re: [PATCH v4 1/7] ipq806x: gcc: add support for child probe

2020-07-20 Thread Amit Kucheria
On Tue, Jul 21, 2020 at 11:27 AM Amit Kucheria wrote: > > > > On Tue, 21 Jul, 2020, 05:06 Stephen Boyd, wrote: >> >> Quoting Amit Kucheria (2020-07-20 02:41:44) >> > On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith wrote: >> > > >> > > Add support for child probing needed for tsens driver that share

[PATCH v5 2/4] power: supply: core: add wireless charger adapter type property

2020-07-20 Thread Qiwu Huang
From: Qiwu Huang Reports what type of wireless adapter connection is currently active for the supply. for example it can show if ADAPTER_PD capable source is attached. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 28 + drivers/power/supply/pow

[PATCH v5 3/4] power: supply: core: add wireless signal strength property

2020-07-20 Thread Qiwu Huang
From: Qiwu Huang reports wireless signal strength. The value show degree of coupling between tx and rx. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 10 ++ drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h|

[PATCH v5 0/4] add some power supply properties about wireless/wired charging

2020-07-20 Thread Qiwu Huang
From: Qiwu Huang This patchset aims to provide power supply properties about wireless/wired charging. "quick_charge_type" reports different types of quick charge based on the charging power; "tx_adapter" shows" the type of wireless charging adapter; "signal_strength" shows the coupling level be

[PATCH v5 1/4] power: supply: core: add quick charge type property

2020-07-20 Thread Qiwu Huang
From: Qiwu Huang Reports the kind of quick charge type based on different adapter power. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 21 + drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h| 10 ++

RE: [EXT] Re: [PATCH 1/2] net: dsa: Add flag for 802.1AD when adding VLAN for dsa switch and port

2020-07-20 Thread Hongbo Wang
Thanks for your suggestion! I will change the code. thanks. -Original Message- From: Florian Fainelli Sent: 2020年7月21日 12:57 To: Hongbo Wang ; Xiaoliang Yang ; allan.niel...@microchip.com; Po Liu ; Claudiu Manoil ; Alexandru Marginean ; Vladimir Oltean ; Leo Li ; Mingkai Hu ; and...@

Re: [PATCH v8 6/7] arm64: dts: add dts nodes for MT6779

2020-07-20 Thread Hanks Chen
On Mon, 2020-07-20 at 18:13 +0200, Matthias Brugger wrote: > > On 16/07/2020 06:04, Hanks Chen wrote: > > On Tue, 2020-07-14 at 20:14 +0200, Matthias Brugger wrote: > >> > >> On 14/07/2020 11:20, Hanks Chen wrote: > >>> this adds initial MT6779 dts settings for board support, > >>> including cpu,

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-20 Thread Stephen Boyd
Quoting Douglas Anderson (2020-07-20 17:24:53) > When I have KASAN enabled on my kernel and I start stressing the > touchscreen my system tends to hang. The touchscreen is one of the > only things that does a lot of big i2c transfers and ends up hitting > the DMA paths in the geni i2c driver. It

Re: kworker/0:3+pm hogging CPU

2020-07-20 Thread Michal Hocko
On Mon 20-07-20 16:02:43, Alan Stern wrote: > On Mon, Jul 20, 2020 at 08:16:05PM +0200, Michal Hocko wrote: > > On Mon 20-07-20 13:48:12, Alan Stern wrote: > > > On Mon, Jul 20, 2020 at 07:45:30PM +0200, Michal Hocko wrote: > > > > On Mon 20-07-20 13:38:07, Alan Stern wrote: > > > > > On Mon, Jul 2

Re: [PATCH V2 vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-20 Thread Jason Wang
On 2020/7/20 下午3:14, Eli Cohen wrote: Add a front end VDPA driver that registers in the VDPA bus and provides networking to a guest. The VDPA driver creates the necessary resources on the VF it is driving such that data path will be offloaded. Notifications are being communicated through the d

[PATCH] xtensa: add boot-elf targets to extra-y

2020-07-20 Thread Max Filippov
The commit 8fe87a92f262 ("kbuild: always create directories of targets") exposed an issue in the xtensa makefiles that results in the following build error in a clean directory: scripts/Makefile.build:374: arch/xtensa/boot/boot-elf/boot.lds] Error 1 arch/xtensa/boot/boot-elf/bootstrap.S:21: f

Re: [PATCH 11/14] mm: use SWP_SYNCHRONOUS_IO more intelligently

2020-07-20 Thread Minchan Kim
Thanks for Ccing me, Shakeel. On Mon, Jul 20, 2020 at 10:52:55AM -0700, Shakeel Butt wrote: > +Minchan Kim > > On Mon, Jul 20, 2020 at 12:52 AM Christoph Hellwig wrote: > > > > There is no point in trying to call bdev_read_page if SWP_SYNCHRONOUS_IO > > is not set, as the device won't support it

Re: [PATCH 2/2] KVM: PPC: Book3S HV: rework secure mem slot dropping

2020-07-20 Thread Paul Mackerras
On Wed, Jul 08, 2020 at 02:16:36PM +0200, Laurent Dufour wrote: > Le 08/07/2020 à 13:25, Bharata B Rao a écrit : > > On Fri, Jul 03, 2020 at 05:59:14PM +0200, Laurent Dufour wrote: > > > When a secure memslot is dropped, all the pages backed in the secure > > > device > > > (aka really backed by s

[RFC PATCH] platform: ioremap: Build iomap functions even without HAS_IOMEM

2020-07-20 Thread David Gow
A number of drivers use devm_platform_ioremap_resource(), but do not (or did not) explicitly depend on IOMEM[1,2]. Given that the only platform without HAS_IOMEM seems to be UML, and it has sufficient stubs for devm_platform_ioremap_resource() and its dependencies to build, we can remove the HAS_IO

[PATCH 0/2] Remove MT6779 UART3 clock support

2020-07-20 Thread Hanks Chen
remove the redundant clk interface of uart. CLK_INFRA_UART3 is a dummy clk interface, it has no effect on the operation of the read/write instruction. Hanks Chen (2): dt-bindings: clock: remove UART3 clock support clk: mediatek: remove UART3 clock support drivers/clk/mediatek/clk-mt6779.c

[PATCH 1/2] dt-bindings: clock: remove UART3 clock support

2020-07-20 Thread Hanks Chen
remove the redundant clk interface of uart. Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support") Signed-off-by: Hanks Chen --- include/dt-bindings/clock/mt6779-clk.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/dt-bindings/clock/mt6779-clk.h b/include/dt-bindings/clock/

[PATCH 2/2] clk: mediatek: remove UART3 clock support

2020-07-20 Thread Hanks Chen
CLK_INFRA_UART3 is a dummy clk interface, it has no effect on the operation of the read/write instruction. Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support") Signed-off-by: Hanks Chen --- drivers/clk/mediatek/clk-mt6779.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-20 Thread Sai Prakash Ranjan
On 2020-07-21 05:54, Douglas Anderson wrote: When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA paths in the geni i2c driver. It appears

Re: [PATCH 1/6] syscalls: use uaccess_kernel in addr_limit_user_check

2020-07-20 Thread Christoph Hellwig
On Mon, Jul 20, 2020 at 10:30:30PM -0700, Guenter Roeck wrote: > Guess I lost it somewhere. Are you saying the check was wrong all along > and your patch fixed it ? Oh, it is a little complicated. Normally we have two address space limits, KERNEL_DS and USER_DS, and they are supposed to be differ

Re: [PATCH v4 01/24] Documentation: locking: Describe seqlock design and usage

2020-07-20 Thread Ahmed S. Darwish
On Mon, Jul 20, 2020 at 09:35:51PM -0400, Steven Rostedt wrote: > On Mon, 20 Jul 2020 17:55:07 +0200 > "Ahmed S. Darwish" wrote: > > +Read path, three categories: > > + > > +1. Normal Sequence readers which never block a writer but they must > > + retry if a writer is in progress by detecting ch

Re: [PATCH V2 vhost next 06/10] vdpa: Modify get_vq_state() to return error code

2020-07-20 Thread Jason Wang
On 2020/7/20 下午3:14, Eli Cohen wrote: Modify get_vq_state() so it returns an error code. In case of hardware acceleration, the available index may be retrieved from the device, an operation that can possibly fail. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen Acked-by: Jason Wang

Re: [PATCH V2 vhost next 05/10] vhost: Fix documentation

2020-07-20 Thread Jason Wang
On 2020/7/20 下午3:14, Eli Cohen wrote: Fix documentation to match actual function prototypes. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen Acked-by: Jason Wang --- drivers/vhost/iotlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/iotlb

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-20 Thread Sidong Yang
On Wed, Jul 15, 2020 at 06:08:44PM +0200, Daniel Vetter wrote: > On Wed, Jul 15, 2020 at 5:57 PM Melissa Wen wrote: > > > > On 07/15, Sidong Yang wrote: > > > On Wed, Jul 15, 2020 at 10:17:56AM +0200, Daniel Vetter wrote: > > > > On Tue, Jul 14, 2020 at 9:01 PM Melissa Wen > > > > wrote: > > > >

Re: [PATCH 1/6] syscalls: use uaccess_kernel in addr_limit_user_check

2020-07-20 Thread Guenter Roeck
On 7/20/20 10:20 PM, Christoph Hellwig wrote: > On Mon, Jul 20, 2020 at 10:15:37PM -0700, Guenter Roeck wrote: - if (CHECK_DATA_CORRUPTION(uaccess_kernel(), + if (CHECK_DATA_CORRUPTION(!uaccess_kernel(), How does this work anywhere ? >>> >>> No, that is the wrong che

Re: [PATCH] PCI/ATS: PASID and PRI are only enumerated in PF devices.

2020-07-20 Thread kernel test robot
Hi Ashok, Thank you for the patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on iommu/next linux/master linus/master v5.8-rc6 next-20200720] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH 02/24] bpfilter: fix up a sparse annotation

2020-07-20 Thread Al Viro
On Tue, Jul 21, 2020 at 07:23:26AM +0200, Christoph Hellwig wrote: > On Tue, Jul 21, 2020 at 04:40:16AM +0200, Luc Van Oostenryck wrote: > > > req.pid = current->pid; > > > req.cmd = optname; > > > - req.addr = (long __force __user)optval; > > > + req.addr = (__force long)optval; > > > > For c

Re: [GIT PULL] EFI fixes for v5.8-rc

2020-07-20 Thread Ard Biesheuvel
On Sat, 18 Jul 2020 at 08:54, Ard Biesheuvel wrote: > > On Thu, 9 Jul 2020 at 16:28, Ard Biesheuvel wrote: > > > > The following changes since commit 2a55280a3675203496d302463b941834228b9875: > > > > efi/libstub: arm: Print CPU boot mode and MMU state at boot (2020-06-17 > > 15:29:11 +0200) >

Re: [PATCH 02/24] bpfilter: fix up a sparse annotation

2020-07-20 Thread Christoph Hellwig
On Tue, Jul 21, 2020 at 04:40:16AM +0200, Luc Van Oostenryck wrote: > > req.pid = current->pid; > > req.cmd = optname; > > - req.addr = (long __force __user)optval; > > + req.addr = (__force long)optval; > > For casts to integers, even '__force' is not needed (since integers > can't be

Re: [PATCH 1/6] syscalls: use uaccess_kernel in addr_limit_user_check

2020-07-20 Thread Christoph Hellwig
On Mon, Jul 20, 2020 at 10:15:37PM -0700, Guenter Roeck wrote: > >> - if (CHECK_DATA_CORRUPTION(uaccess_kernel(), > >> + if (CHECK_DATA_CORRUPTION(!uaccess_kernel(), > >> > >> How does this work anywhere ? > > > > No, that is the wrong check - we want to make sure the address > > space

Re: [PATCH 1/6] syscalls: use uaccess_kernel in addr_limit_user_check

2020-07-20 Thread Guenter Roeck
, this patch is: >> >> - if (CHECK_DATA_CORRUPTION(!segment_eq(get_fs(), USER_DS), >> + if (CHECK_DATA_CORRUPTION(uaccess_kernel(), >> >> So there is a negation in the condition. Indeed, the following change >> on top of next-20200720 fixes the problem f

Re: [PATCH 08/10] dma-mapping: consolidate the NO_DMA definition in kernel/dma/Kconfig

2020-07-20 Thread Christoph Hellwig
On Mon, Jul 20, 2020 at 11:17:26PM -0400, Rich Felker wrote: > On Tue, Jul 14, 2020 at 02:18:54PM +0200, Christoph Hellwig wrote: > > Have a single definition that architetures can select. > > > > Signed-off-by: Christoph Hellwig > > --- > > arch/m68k/Kconfig | 4 +--- > > arch/m68k/Kcon

Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-20 Thread Christoph Hellwig
On Mon, Jul 20, 2020 at 11:27:57PM +0200, Richard Weinberger wrote: > On Mon, Jul 20, 2020 at 2:37 PM Artem Bityutskiy wrote: > > > > On Mon, 2020-07-20 at 14:07 +0200, Christoph Hellwig wrote: > > > What about jffs2 and blk2mtd raw block devices? > > I don't worry much about blk2mtd. > > > If m

Re: [PATCH v4 5/7] powerpc/iommu: Move iommu_table cleaning routine to iommu_table_clean

2020-07-20 Thread Alexey Kardashevskiy
On 16/07/2020 17:16, Leonardo Bras wrote: > Move the part of iommu_table_free() that does struct iommu_table cleaning > into iommu_table_clean, so we can invoke it separately. > > This new function is useful for cleaning struct iommu_table before > initializing it again with a new DMA window, w

Re: [PATCH] unicore32: use get_kernel_nofault in dump mem and dump_instr

2020-07-20 Thread christoph hellwig
On Tue, Jul 21, 2020 at 10:09:20AM +0800, Guan Xuetao wrote: > Very good to remove ds/fs in unicore arch. > Could u send me full patch for test? This is the full patch for now. The actual removal will need more core instrastructure and at least one more merge window.

[PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Chi Song
An imbalanced TX indirection table causes netvsc to have low performance. This table is created and managed during runtime. To help better diagnose performance issues caused by imbalanced tables, add device attributes to show the content of TX indirection tables. Signed-off-by: Chi Song --- v4: u

Re: [PATCH 1/6] syscalls: use uaccess_kernel in addr_limit_user_check

2020-07-20 Thread Christoph Hellwig
_eq(get_fs(), USER_DS), > + if (CHECK_DATA_CORRUPTION(uaccess_kernel(), > > So there is a negation in the condition. Indeed, the following change > on top of next-20200720 fixes the problem for mps2-an385. > > - if (CHECK_DATA_CORRUPTION(uaccess_kernel(), > + if (CHECK_D

Re: [PATCH 1/2] net: dsa: Add flag for 802.1AD when adding VLAN for dsa switch and port

2020-07-20 Thread Florian Fainelli
On 7/20/2020 3:41 AM, hongbo.w...@nxp.com wrote: > From: "hongbo.wang" > > the following command can be supported: > ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100 You should probably include the switch driver that is going to be benefiting from doing these changes in t

Re: 5.8-rc*: kernel BUG at kernel/signal.c:1917

2020-07-20 Thread Paul Gortmaker
[Re: 5.8-rc*: kernel BUG at kernel/signal.c:1917] On 20/07/2020 (Mon 16:21) Peter Zijlstra wrote: > On Mon, Jul 20, 2020 at 04:02:24PM +0200, Oleg Nesterov wrote: > > I have to admit, I do not understand the usage of prev_state in schedule(), > > it looks really, really subtle... > > Right, so c

[PATCH v2] media: cafe-driver: use generic power management

2020-07-20 Thread Vaibhav Gupta
Drivers using legacy PM have to manage PCI states and device's PM states themselves. They also need to take care of configuration registers. With improved and powerful support of generic PM, PCI Core takes care of above mentioned, device-independent, jobs. This driver makes use of PCI helper func

Re: [PATCH v5 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Stephen Hemminger
On Tue, 21 Jul 2020 03:50:00 + Chi Song wrote: > +static void netvsc_attrs_init(void) > +{ > + char buffer[4]; > + int i; > + > + for (i = 0; i < VRSS_SEND_TAB_SIZE; i++) { > + sprintf(buffer, "%02u", i); > + dev_attr_netvsc_dev_attrs[i].attr.name = > +

KASAN: stack-out-of-bounds Write in sys_imageblit

2020-07-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4fa640dc Merge tag 'vfio-v5.8-rc7' of git://github.com/awi.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17ec2d5890 kernel config: https://syzkaller.appspot.com/x/.config?x=575b381064b1cba2 das

Re: [PATCH v4 09/10] powerpc/watchpoint: Return available watchpoints dynamically

2020-07-20 Thread Jordan Niethe
On Tue, Jul 21, 2020 at 1:57 PM Ravi Bangoria wrote: > > > > On 7/20/20 9:12 AM, Jordan Niethe wrote: > > On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria > > wrote: > >> > >> So far Book3S Powerpc supported only one watchpoint. Power10 is > >> introducing 2nd DAWR. Enable 2nd DAWR support for Power

Re: [PATCH V2 vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-20 Thread kernel test robot
Hi Eli, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20200717] url: https://github.com/0day-ci/linux/commits/Eli-Cohen/VDPA-support-for-Mellanox-ConnectX-devices/20200720-160220 base:aab7ee9f8ff0110bfcd594b33dc33748dc1baf46 config: x86_64

KASAN: use-after-free Read in sock_def_write_space (2)

2020-07-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5714ee50 copy_xstate_to_kernel: Fix typo which caused GDB .. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13059e7f10 kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267 das

[PATCH] x86/cpu: Add Lakefield, Alder Lake and Rocket Lake to Intel family

2020-07-20 Thread Tony Luck
Three new CPU models. Signed-off-by: Tony Luck --- This patch supercedes https://lore.kernel.org/lkml/20200709192353.21151-1-tony.l...@intel.com/ That one just added Rocket Lake arch/x86/include/asm/intel-family.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/include/as

Re: KASAN: use-after-free Read in userfaultfd_release (2)

2020-07-20 Thread Stephen Rothwell
Hi all, On Mon, 20 Jul 2020 11:50:25 -0400 Qian Cai wrote: > > On Fri, Jul 17, 2020 at 11:05:41AM -0400, Qian Cai wrote: > > On Mon, Jul 13, 2020 at 08:34:06AM -0700, syzbot wrote: > > > syzbot has bisected this bug to: > > > > > > commit d08ac70b1e0dc71ac2315007bcc3efb283b2eae4 > > > Author:

general protection fault in __xfrm6_tunnel_spi_check

2020-07-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4c43049f Add linux-next specific files for 20200716 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=16f786d710 kernel config: https://syzkaller.appspot.com/x/.config?x=2c76d72659687242 dashboard

linux-next: manual merge of the tip tree with the crypto tree

2020-07-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in: arch/x86/include/asm/inst.h between commit: d7866e503bdc ("crypto: x86 - Remove include/asm/inst.h") (also "crypto: x86 - Put back integer parts of include/asm/inst.h" which I have added to the crypto tree merge today) fro

[PATCH 0/3] PWM backlight interpolation adjustments

2020-07-20 Thread Alexandru Stan
I was trying to adjust the brightness for a new chromebook: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2291209 Like a lot of panels, the low end needs to be cropped, and now that we have the interpolation stuff I wanted to make use of it and bake in even the curve.

[PATCH 1/3] backlight: pwm_bl: Fix interpolation

2020-07-20 Thread Alexandru Stan
Whenever num-interpolated-steps was larger than the distance between 2 consecutive brightness levels the table would get really discontinuous. The slope of the interpolation would stick with integers only and if it was 0 the whole line segment would get skipped. Example settings: brightnes

[PATCH 2/3] backlight: pwm_bl: Artificially add 0% during interpolation

2020-07-20 Thread Alexandru Stan
Some displays need the low end of the curve cropped in order to make them happy. In that case we still want to have the 0% point, even though anything between 0% and 5%(example) would be skipped. Signed-off-by: Alexandru Stan --- drivers/video/backlight/pwm_bl.c | 8 1 file changed, 8

[PATCH 3/3] ARM: dts: rockchip: Remove 0 point in backlight

2020-07-20 Thread Alexandru Stan
After the "PWM backlight interpolation adjustments" patches, the backlight interpolation works a little differently. The way these dts files were working before was relying on a bug (IMHO). Remove the 0-3 range since otherwise we would have a 252 long interpolation that would slowly go between 0 a

[PATCH v2] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation

2020-07-20 Thread Fangrui Song
When CROSS_COMPILE is set (e.g. aarch64-linux-gnu-), if $(CROSS_COMPILE)elfedit is found at /usr/bin/aarch64-linux-gnu-elfedit, GCC_TOOLCHAIN_DIR will be set to /usr/bin/. --prefix= will be set to /usr/bin/ and Clang as of 11 will search for both $(prefix)aarch64-linux-gnu-$needle and $(prefix)$ne

Re: [RFT PATCH v3 1/9] RISC-V: Move DT mapping outof fixmap

2020-07-20 Thread Atish Patra
On Sat, Jul 18, 2020 at 2:24 AM Arnd Bergmann wrote: > > On Sat, Jul 18, 2020 at 3:05 AM Atish Patra wrote: > > On Thu, Jul 16, 2020 at 11:32 PM Arnd Bergmann wrote: > > > On Fri, Jul 17, 2020 at 1:41 AM Atish Patra wrote: > > > > +#define DTB_EARLY_SIZE SZ_1M > > > > +static char early

[RFC][PATCH 3/4] arm64: add host pvstate support

2020-07-20 Thread Sergey Senozhatsky
Add PV-state support bits to the host. Host uses the guest PV-state per-CPU pointers to update the VCPU state each time it kvm_arch_vcpu_load() or kvm_arch_vcpu_put() the VCPU, so that guest scheduler can become aware of the fact that not all VCPUs are always available. Currently guest scheduler on

[RFC][PATCH 4/4] arm64: do not use dummy vcpu_is_preempted() anymore

2020-07-20 Thread Sergey Senozhatsky
vcpu_is_preempted() now can represent the actual state of the VCPU, so the scheduler can make better decisions when it picks the idle CPU to enqueue a task on. I executed a whole bunch of scheduler tests [0]. One particular test that shows the importance of vcpu_is_preempted() is AIO stress-ng test

[RFC][PATCH 2/4] arm64: add guest pvstate support

2020-07-20 Thread Sergey Senozhatsky
PV-state is a per-CPU struct, which, for the time being, holds boolean `preempted' vCPU state. During the startup, given that host supports PV-state, each guest vCPU sends a pointer to its per-CPU variable to the host as a payload with the SMCC HV call, so that host can update vCPU state when it pu

[RFC][PATCH 1/4] arm64:kvm: define pv_state SMCCC HV calls

2020-07-20 Thread Sergey Senozhatsky
These will be used later on to configure and enable vCPU PV-state support, which is needed for vcpu_is_preempted(). Signed-off-by: Sergey Senozhatsky --- include/linux/arm-smccc.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/linux/arm-smccc.h b/include/linux/ar

[RFC][PATCH 0/4] arm64:kvm: teach guest sched that VCPUs can be preempted

2020-07-20 Thread Sergey Senozhatsky
Hello, RFC We noticed that in a number of cases when we wake_up_process() on arm64 guest we end up enqueuing that task on a preempted VCPU. The culprit appears to be the fact that arm64 guests are not aware of VCPU preemption as such, so when sched picks up an idle VCPU it always

Re: [PATCH] riscv: Select ARCH_HAS_DEBUG_VM_PGTABLE

2020-07-20 Thread Palmer Dabbelt
On Tue, 14 Jul 2020 20:20:54 PDT (-0700), anshuman.khand...@arm.com wrote: On 07/15/2020 02:56 AM, Emil Renner Berthing wrote: This allows the pgtable tests to be built. Signed-off-by: Emil Renner Berthing --- The tests seem to succeed both in Qemu and on the HiFive Unleashed Both with and

Re: [PATCH v2 13/16] scripts/kallsyms: move ignored symbol types to is_ignored_symbol()

2020-07-20 Thread Finn Thain
On Mon, 20 Jul 2020, Masahiro Yamada wrote: > > I got a similar report before. > > I'd like to know whether or not > this is the same issue as fixed by > 7883a14339299773b2ce08dcfd97c63c199a9289 > The problem can be observed with 3d77e6a8804ab ("Linux 5.7"). So it appears that 7883a14339299 ("

[PATCH v3 1/2] dt-bindings: devapc: add bindings for mtk-devapc

2020-07-20 Thread Neal Liu
Add bindings for mtk-devapc. Signed-off-by: Neal Liu --- .../devicetree/bindings/soc/mediatek/devapc.yaml | 58 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/mediatek/devapc.yaml diff --git a/Documentation/devicetree/bindings

[PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-20 Thread Neal Liu
MediaTek bus fabric provides TrustZone security support and data protection to prevent slaves from being accessed by unexpected masters. The security violation is logged and sent to the processor for further analysis or countermeasures. Any occurrence of security violation would raise an interrupt

[PATCH v3] Add MediaTek MT6779 devapc driver

2020-07-20 Thread Neal Liu
These patch series introduce a MediaTek MT6779 devapc driver. MediaTek bus fabric provides TrustZone security support and data protection to prevent slaves from being accessed by unexpected masters. The security violation is logged and sent to the processor for further analysis or countermeasure

Re: [PATCH v4 09/10] powerpc/watchpoint: Return available watchpoints dynamically

2020-07-20 Thread Ravi Bangoria
On 7/20/20 9:12 AM, Jordan Niethe wrote: On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria wrote: So far Book3S Powerpc supported only one watchpoint. Power10 is introducing 2nd DAWR. Enable 2nd DAWR support for Power10. Availability of 2nd DAWR will depend on CPU_FTR_DAWR1. Signed-off-by: Rav

Re: [PATCH 2/4] printk: store instead of processing cont parts

2020-07-20 Thread Joe Perches
On Mon, 2020-07-20 at 11:30 -0700, Linus Torvalds wrote: > On Sun, Jul 19, 2020 at 6:51 PM Sergey Senozhatsky > wrote: > > Do I get it right, what you are saying is - when we process a PR_CONT > > message the cont buffer should already contain previous non-LOG_NEWLINE > > and non-PR_CONT message,

Re: [PATCH v2 3/3] mfd: intel-m10-bmc: add Max10 BMC chip support for Intel FPGA PAC

2020-07-20 Thread Xu Yilun
On Tue, Jul 21, 2020 at 11:47:13AM +0800, Xu Yilun wrote: > On Fri, Jul 17, 2020 at 07:16:09PM +0100, Mark Brown wrote: > > On Thu, Jul 16, 2020 at 06:42:54PM +0800, Xu Yilun wrote: > > > > > +static const struct spi_device_id m10bmc_spi_id[] = { > > > + { "m10-n3000", M10_N3000 }, > > > + { } > >

KASAN: slab-out-of-bounds Read in xfrm6_tunnel_alloc_spi

2020-07-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4c43049f Add linux-next specific files for 20200716 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=10e7e9d710 kernel config: https://syzkaller.appspot.com/x/.config?x=2c76d72659687242 dashboard

Re: [PATCH v2 3/3] mfd: intel-m10-bmc: add Max10 BMC chip support for Intel FPGA PAC

2020-07-20 Thread Xu Yilun
On Fri, Jul 17, 2020 at 07:16:09PM +0100, Mark Brown wrote: > On Thu, Jul 16, 2020 at 06:42:54PM +0800, Xu Yilun wrote: > > > +static const struct spi_device_id m10bmc_spi_id[] = { > > + { "m10-n3000", M10_N3000 }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(spi, m10bmc_spi_id); > > > +static

[PATCH v5 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Chi Song
An imbalanced TX indirection table causes netvsc to have low performance. This table is created and managed during runtime. To help better diagnose performance issues caused by imbalanced tables, add device attributes to show the content of TX indirection tables. Signed-off-by: Chi Song --- v4: u

  1   2   3   4   5   6   7   8   9   10   >