Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Jason A. Donenfeld
Hi Christoph, On Thu, Jul 23, 2020 at 08:08:54AM +0200, Christoph Hellwig wrote: > diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c > index da933f99b5d517..42befbf12846c0 100644 > --- a/net/ipv4/ip_sockglue.c > +++ b/net/ipv4/ip_sockglue.c > @@ -1422,7 +1422,8 @@ int

[PATCH] soc: qmi: allow user to set handle wq to hiprio

2020-07-27 Thread 王文虎
Currently the qmi_handle is initialized single threaded and strictly ordered with the active set to 1. This is pretty simple and safe but sometimes ineffency. So it is better to allow user to decide whether a high priority workqueue should be used. Signed-off-by: Wang Wenhu ---

[PATCH 4/6] ASoC: amd: Adding support for ALC1015 codec in machine driver

2020-07-27 Thread Ravulapati Vishnu vardhan rao
Adding support for ALC1015 RTK codec in machine driver. Passing specific card structure based on its ACPI ID. Signed-off-by: Ravulapati Vishnu vardhan rao --- sound/soc/amd/Kconfig| 1 + sound/soc/amd/acp3x-rt5682-max9836.c | 63 ++-- 2 files changed,

[PATCH 2/6] ASoC: amd: Passing card structure based on codec

2020-07-27 Thread Ravulapati Vishnu vardhan rao
Passing specific snd_soc_card structure depending on the ACPI ID. In future we can add other IDs in the ACPI table and pass the structure. Signed-off-by: Ravulapati Vishnu vardhan rao --- sound/soc/amd/acp3x-rt5682-max9836.c | 24 +++- 1 file changed, 19 insertions(+), 5

[PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682

2020-07-27 Thread Ravulapati Vishnu vardhan rao
changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because, This flag which was previously set as SND_SOC_RT5682 used to build rt5682 codec driver but by changing into SND_SOC_RT5682_I2C is preventing to build rt5682 codec driver and machine driver fails to probe.So Reverting the changes.

[PATCH 5/6] ASoC: amd: Adding DAI LINK for rt1015 codec

2020-07-27 Thread Ravulapati Vishnu vardhan rao
DAI link support for RTK 1015 and providing the codec details depending on the snd_soc_card selected by ACPI ID. Signed-off-by: Ravulapati Vishnu vardhan rao --- sound/soc/amd/acp3x-rt5682-max9836.c | 35 1 file changed, 30 insertions(+), 5 deletions(-) diff --git

[PATCH 6/6] ASoC: amd: Added hw_params support for ALC1015

2020-07-27 Thread Ravulapati Vishnu vardhan rao
Adding rt1015 hw_params which set Bit-clock ratio PLL and appropriate sys clk specific with RTK1015. Signed-off-by: Ravulapati Vishnu vardhan rao --- sound/soc/amd/acp3x-rt5682-max9836.c | 39 1 file changed, 39 insertions(+) diff --git

[PATCH 1/6] ASoC: amd: Renaming snd-soc-card structure and fields.

2020-07-27 Thread Ravulapati Vishnu vardhan rao
As in future our machine driver supports multiple codecs So changing naming convention of snd_soc_card struct and its fields. Signed-off-by: Ravulapati Vishnu vardhan rao --- sound/soc/amd/acp3x-rt5682-max9836.c | 28 ++-- 1 file changed, 14 insertions(+), 14

Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-27 Thread Mike Snitzer
This mail needs to be saent to sta...@vger.kernel.org (now cc'd). Greg et al: please backport 2df3bae9a6543e90042291707b8db0cbfbae9ee9 Thanks, Mike On Mon, Jul 27 2020 at 9:40am -0400, John Donnelly wrote: > From: Mike Snitzer > > Discontinue issuing writethrough write IO in series to the

Re: [RFC PATCH 4/9] PCI/AER: Extend AER error handling to RCECs

2020-07-27 Thread Sean V Kelley
On 27 Jul 2020, at 7:04, Jonathan Cameron wrote: On Fri, 24 Jul 2020 10:22:18 -0700 Sean V Kelley wrote: From: Jonathan Cameron Currently the kernel does not handle AER errors for Root Complex integrated End Points (RCiEPs)[0]. These devices sit on a root bus within the Root Complex

[PATCH 1/2] iio: trigger: hrtimer: Disable irqs before calling iio_trigger_poll()

2020-07-27 Thread Christian Eggers
iio_trigger_poll() calls generic_handle_irq(). This function expects to be run with local IRQs disabled. Signed-off-by: Christian Eggers Cc: sta...@vger.kernel.org --- drivers/iio/trigger/iio-trig-hrtimer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [RFC PATCH 4/9] PCI/AER: Extend AER error handling to RCECs

2020-07-27 Thread Sean V Kelley
On 27 Jul 2020, at 4:00, Jonathan Cameron wrote: On Fri, 24 Jul 2020 10:22:18 -0700 Sean V Kelley wrote: From: Jonathan Cameron Currently the kernel does not handle AER errors for Root Complex integrated End Points (RCiEPs)[0]. These devices sit on a root bus within the Root Complex

Re: [Linux-kernel-mentees] [PATCH v2] infiniband: Prevent uninit-value in ucma_accept()

2020-07-27 Thread Jason Gunthorpe
On Sat, Jul 25, 2020 at 10:27:16PM -0400, Peilin Ye wrote: > ucma_accept() is reading uninitialized memory when `in_len` is > less than `offsetof(struct rdma_ucm_accept, ece)`. Fix it. > > Reported-and-tested-by: syzbot+086ab5ca9eafd2379...@syzkaller.appspotmail.com > Link: >

[PATCH] iio: trigger: sysfs: Disable irqs before calling iio_trigger_poll()

2020-07-27 Thread Christian Eggers
iio_trigger_poll() calls generic_handle_irq(). This function expects to be run with local IRQs disabled. Signed-off-by: Christian Eggers Cc: sta...@vger.kernel.org --- drivers/iio/trigger/iio-trig-sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/trigger/iio-trig-sysfs.c

Re: [PATCH v10 04/13] iommu/arm-smmu-qcom: Add implementation for the adreno GPU SMMU

2020-07-27 Thread Jordan Crouse
On Sun, Jul 26, 2020 at 11:27:03PM -0700, Bjorn Andersson wrote: > On Mon 20 Jul 08:40 PDT 2020, Jordan Crouse wrote: > > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c > [..] > > +static int qcom_adreno_smmu_alloc_context_bank(struct arm_smmu_domain > > *smmu_domain,

Re: [RFC PATCH 0/9] Add RCEC handling to PCI/AER

2020-07-27 Thread Sean V Kelley
Hi Jonathan, On 27 Jul 2020, at 5:37, Jonathan Cameron wrote: On Fri, 24 Jul 2020 10:22:14 -0700 Sean V Kelley wrote: Root Complex Event Collectors (RCEC) provide support for terminating error and PME messages from Root Complex Integrated Endpoints (RCiEPs). An RCEC resides on a Bus in

Re: [Linux-kernel-mentees] [PATCH v3] media/v4l2-core: Fix kernel-infoleak in video_put_user()

2020-07-27 Thread Arnd Bergmann
On Mon, Jul 27, 2020 at 4:43 PM Dan Carpenter wrote: > > On Mon, Jul 27, 2020 at 04:05:38PM +0200, Arnd Bergmann wrote: > > On Mon, Jul 27, 2020 at 3:16 PM Dan Carpenter > > wrote: > > > > > > On Mon, Jul 27, 2020 at 09:25:16AM +0200, Arnd Bergmann wrote: > > > > On Mon, Jul 27, 2020 at 12:28

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Jon Nettleton
On Mon, Jul 27, 2020 at 4:17 PM Russell King - ARM Linux admin wrote: > > On Mon, Jul 27, 2020 at 03:33:17PM +0200, Jon Nettleton wrote: > > On Mon, Jul 27, 2020 at 11:46 AM Russell King - ARM Linux admin > > wrote: > > > > > > On Thu, Jul 23, 2020 at 09:57:55PM +0200, Alexandre Belloni wrote: >

Re: [PATCH 08/10] media: uapi: h264: Clean slice invariants syntax elements

2020-07-27 Thread Tomasz Figa
On Mon, Jul 27, 2020 at 4:39 PM Ezequiel Garcia wrote: > > Hi Alexandre, > > Thanks a lot for the review. > > On Sat, 2020-07-25 at 23:34 +0900, Alexandre Courbot wrote: > > On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia > > wrote: > > > The H.264 specification requires in its "Slice header

Re: [PATCH v3 07/19] fs/kernel_read_file: Split into separate source file

2020-07-27 Thread Mimi Zohar
On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > These routines are used in places outside of exec(2), so in preparation > for refactoring them, move them into a separate source file, > fs/kernel_read_file.c. > > Acked-by: Scott Branden > Signed-off-by: Kees Cook Reviewed-by: Mimi Zohar

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-07-27 Thread Joe Perches
On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: > So, I think you would like to have parenthesis intentionally. > If so, > test1 ? : (test2 ? :) > would be better. > > > If not, > test1 ? : test2 ? : > may be what you want (without any parenthesis). Use whatever style you like, it's

Re: [RESEND RFC PATCH v1] arm64: kvm: flush tlbs by range in unmap_stage2_range function

2020-07-27 Thread Zhenyu Ye
Hi Marc, On 2020/7/26 1:40, Marc Zyngier wrote: > On 2020-07-24 14:43, Zhenyu Ye wrote: >> Now in unmap_stage2_range(), we flush tlbs one by one just after the >> corresponding pages cleared.  However, this may cause some performance >> problems when the unmap range is very large (such as when

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-27 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月27日 週一 下午3:54寫道: > > On Sat, 2020-07-25 at 07:24 +0800, Chun-Kuang Hu wrote: > > Hi Yongqiang: > > > > Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > > > > > This patch add support for mediatek SOC MT8183 > > > 1.ovl_2l share driver with ovl > > > > I think

Re: bpfilter logging write errors in dmesg

2020-07-27 Thread Christoph Hellwig
Strange. Can you add this additional debugging patch: diff --git a/fs/read_write.c b/fs/read_write.c index 4fb797822567a6..d0a8ada1efd954 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -369,8 +369,10 @@ int rw_verify_area(int read_write, struct file *file, const loff_t *ppos, size_t

[PATCH 2/2] iio: light: as73211: New driver

2020-07-27 Thread Christian Eggers
Support for AMS AS73211 JENCOLOR(R) Digital XYZ Sensor. This driver has no built-in trigger. In order for making triggered measurements, an external (software) trigger driver like iio-trig-hrtimer or iio-trig-sysfs is required. The sensor supports single and continuous measurement modes. The

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Alexandre Belloni
On 27/07/2020 10:45:53+0100, Russell King - ARM Linux admin wrote: > > This is but this shouldn't be a DT property as it has to be changed > > dynamically. I'm working on an ioctl interface to change this > > configuration. > > Why does it need to be changed dynamically? If the hardware

[PATCH 1/2] dt-bindings: iio: light: add AMS AS73211 support

2020-07-27 Thread Christian Eggers
Add DT bindings for AMS AS73211 XYZ True Color Sensor. Signed-off-by: Christian Eggers --- .../bindings/iio/light/ams,as73211.yaml | 54 +++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/ams,as73211.yaml diff --git

[PATCH] iio: light: Support AMS AS73211 digital XYZ sensor

2020-07-27 Thread Christian Eggers
This series adds support for the AMS AS73211 digital XYZ sensor.

Re: [PATCH 2/6] interconnect: qcom: Implement xlate_extended() to parse tags

2020-07-27 Thread Sibi Sankar
Hey Georgi, Thanks for the patch! On 7/23/20 6:39 PM, Georgi Djakov wrote: Implement a function to parse the arguments of the "interconnects" DT property and populate the interconnect path tags if this information is available. Signed-off-by: Georgi Djakov ---

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-27 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月27日 週一 上午11:06寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-24 at 23:55 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月24日 週五 下午2:55寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Fri, 2020-07-24 at 00:32 +0800, Chun-Kuang Hu wrote: > > > > Hi, Neal:

Re: [Linux-kernel-mentees] [PATCH v3] media/v4l2-core: Fix kernel-infoleak in video_put_user()

2020-07-27 Thread Dan Carpenter
On Mon, Jul 27, 2020 at 10:14:16AM -0400, Peilin Ye wrote: > Yes, I would like to! I will start from: > > drivers/firewire/core-cdev.c:463 My prefered fix for this would be to add a memset at the start of fill_bus_reset_event(). memset(event, 0, sizeof(*event));

Re: Re: [PATCH] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode

2020-07-27 Thread dinghao . liu
> I review things in the order that they appear in my inbox so I hadn't > seen Greg and Larry's comments. You've now stumbled into an area of > politics where you have conflicting reviews... :P Fortunately, we're > all of us reasonable people. > > I think your patch is correct in that it is

Re: [Linux-kernel-mentees] [PATCH v3] media/v4l2-core: Fix kernel-infoleak in video_put_user()

2020-07-27 Thread Dan Carpenter
On Mon, Jul 27, 2020 at 04:05:38PM +0200, Arnd Bergmann wrote: > On Mon, Jul 27, 2020 at 3:16 PM Dan Carpenter > wrote: > > > > On Mon, Jul 27, 2020 at 09:25:16AM +0200, Arnd Bergmann wrote: > > > On Mon, Jul 27, 2020 at 12:28 AM Peilin Ye wrote: > > > > > > > > video_put_user() is copying

Re: [PATCH 09/10] media: hantro: Don't require unneeded H264_SLICE_PARAMS

2020-07-27 Thread Ezequiel Garcia
Hi Alexandre, Despite you've asked to ignore this review, let me comment on it. On Sat, 2020-07-25 at 23:45 +0900, Alexandre Courbot wrote: > On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia > wrote: > > Now that slice invariant parameters have been moved, > > the driver no longer needs this

[PATCH 4.14 11/64] irqdomain/treewide: Keep firmware node unconditionally allocated

2020-07-27 Thread Greg Kroah-Hartman
From: Thomas Gleixner [ Upstream commit e3beca48a45b5e0e6e6a4e0124276b8248dcc9bb ] Quite some non OF/ACPI users of irqdomains allocate firmware nodes of type IRQCHIP_FWNODE_NAMED or IRQCHIP_FWNODE_NAMED_ID and free them right after creating the irqdomain. The only purpose of these FW nodes is

[PATCH 4.14 21/64] bnxt_en: Fix race when modifying pause settings.

2020-07-27 Thread Greg Kroah-Hartman
From: Vasundhara Volam [ Upstream commit 163e9ef63641a02de4c95cd921577265c52e1ce2 ] The driver was modified to not rely on rtnl lock to protect link settings about 2 years ago. The pause setting was missed when making that change. Fix it by acquiring link_lock mutex before calling

[PATCH 4.14 45/64] x86: math-emu: Fix up cmp insn for clang ias

2020-07-27 Thread Greg Kroah-Hartman
From: Arnd Bergmann [ Upstream commit 81e96851ea32deb2c921c870eecabf335f598aeb ] The clang integrated assembler requires the 'cmp' instruction to have a length prefix here: arch/x86/math-emu/wm_sqrt.S:212:2: error: ambiguous instructions require an explicit suffix (could be 'cmpb', 'cmpw', or

[PATCH RESEND] scsi: hpsa and dc395x: Remove pci_dma_compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested. -

[PATCH 4.14 46/64] binder: Dont use mmput() from shrinker function.

2020-07-27 Thread Greg Kroah-Hartman
From: Tetsuo Handa commit f867c771f98891841c217fa8459244ed0dd28921 upstream. syzbot is reporting that mmput() from shrinker function has a risk of deadlock [1], for delayed_uprobe_add() from update_ref_ctr() calls kzalloc(GFP_KERNEL) with delayed_uprobe_lock held, and uprobe_clear_state() from

[PATCH 4.14 36/64] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-07-27 Thread Greg Kroah-Hartman
From: Dinghao Liu [ Upstream commit 5b78fac4b1ba731cf4177fdbc1e3a4661521bcd0 ] pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao

[PATCH 4.14 08/64] drivers/net/wan/lapbether: Fixed the value of hard_header_len

2020-07-27 Thread Greg Kroah-Hartman
From: Xie He [ Upstream commit 9dc829a135fb5927f1519de11286e2bbb79f5b66 ] When this driver transmits data, first this driver will remove a pseudo header of 1 byte, then the lapb module will prepend the LAPB header of 2 or 3 bytes, then this driver will prepend a length field of 2 bytes,

[PATCH 4.14 42/64] Input: synaptics - enable InterTouch for ThinkPad X1E 1st gen

2020-07-27 Thread Greg Kroah-Hartman
From: Ilya Katsnelson [ Upstream commit dcb00fc799dc03fd320e123e4c81b3278c763ea5 ] Tested on my own laptop, touchpad feels slightly more responsive with this on, though it might just be placebo. Signed-off-by: Ilya Katsnelson Reviewed-by: Lyude Paul Link:

[PATCH 4.14 40/64] hwmon: (aspeed-pwm-tacho) Avoid possible buffer overflow

2020-07-27 Thread Greg Kroah-Hartman
From: Evgeny Novikov [ Upstream commit bc4071aafcf4d0535ee423b69167696d6c03207d ] aspeed_create_fan() reads a pwm_port value using of_property_read_u32(). If pwm_port will be more than ARRAY_SIZE(pwm_port_params), there will be a buffer overflow in

[PATCH RESEND] scsi: mpt3sas: Remove pci-dma-compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested. -

Re: [PATCH v3 06/19] fs/kernel_read_file: Split into separate include file

2020-07-27 Thread Mimi Zohar
On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > From: Scott Branden > > Move kernel_read_file* out of linux/fs.h to its own linux/kernel_read_file.h > include file. That header gets pulled in just about everywhere > and doesn't really need functions not related to the general fs interface.

[PATCH 4.14 43/64] usb: gadget: udc: gr_udc: fix memleak on error handling path in gr_ep_init()

2020-07-27 Thread Greg Kroah-Hartman
From: Evgeny Novikov [ Upstream commit c8f8529e2c4141afa2ebb487ad48e8a6ec3e8c99 ] gr_ep_init() does not assign the allocated request anywhere if allocation of memory for the buffer fails. This is a memory leak fixed by the given patch. Found by Linux Driver Verification project

[PATCH 4.14 44/64] arm64: Use test_tsk_thread_flag() for checking TIF_SINGLESTEP

2020-07-27 Thread Greg Kroah-Hartman
From: Will Deacon [ Upstream commit 5afc78551bf5d53279036e0bf63314e35631d79f ] Rather than open-code test_tsk_thread_flag() at each callsite, simply replace the couple of offenders with calls to test_tsk_thread_flag() directly. Signed-off-by: Will Deacon Signed-off-by: Sasha Levin ---

[PATCH 4.14 50/64] staging: wlan-ng: properly check endpoint types

2020-07-27 Thread Greg Kroah-Hartman
From: Rustam Kovhaev commit faaff9765664009c1c7c65551d32e9ed3b1dda8f upstream. As syzkaller detected, wlan-ng driver does not do sanity check of endpoints in prism2sta_probe_usb(), add check for xfer direction and type Reported-and-tested-by:

[PATCH 4.14 56/64] serial: 8250_mtk: Fix high-speed baud rates clamping

2020-07-27 Thread Greg Kroah-Hartman
From: Serge Semin commit 551e553f0d4ab623e2a6f424ab5834f9c7b5229c upstream. Commit 7b668c064ec3 ("serial: 8250: Fix max baud limit in generic 8250 port") fixed limits of a baud rate setting for a generic 8250 port. In other words since that commit the baud rate has been permitted to be within

[PATCH 4.14 28/64] mlxsw: destroy workqueue when trap_register in mlxsw_emad_init

2020-07-27 Thread Greg Kroah-Hartman
From: Liu Jian [ Upstream commit 5dbaeb87f2b309936be0aeae00cbc9e7f20ab296 ] When mlxsw_core_trap_register fails in mlxsw_emad_init, destroy_workqueue() shouled be called to destroy mlxsw_core->emad_wq. Fixes: d965465b60ba ("mlxsw: core: Fix possible deadlock") Signed-off-by: Liu Jian

[PATCH 4.14 55/64] serial: 8250: fix null-ptr-deref in serial8250_start_tx()

2020-07-27 Thread Greg Kroah-Hartman
From: Yang Yingliang commit f4c23a140d80ef5e6d3d1f8f57007649014b60fa upstream. I got null-ptr-deref in serial8250_start_tx(): [ 78.114630] Unable to handle kernel NULL pointer dereference at virtual address [ 78.123778] Mem abort info: [ 78.126560] ESR = 0x8607 [

[PATCH RESEND] scsi: qla2xxx: Remove pci-dma-compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested. -

[PATCH 4.14 25/64] drm: sun4i: hdmi: Fix inverted HPD result

2020-07-27 Thread Greg Kroah-Hartman
From: Chen-Yu Tsai [ Upstream commit baa1841eb797eadce6c907bdaed7cd6f01815404 ] When the extra HPD polling in sun4i_hdmi was removed, the result of HPD was accidentally inverted. Fix this by inverting the check. Fixes: bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling") Signed-off-by:

[PATCH 4.14 53/64] staging: comedi: addi_apci_1500: check INSN_CONFIG_DIGITAL_TRIG shift

2020-07-27 Thread Greg Kroah-Hartman
From: Ian Abbott commit fc846e9db67c7e808d77bf9e2ef3d49e3820ce5d upstream. The `INSN_CONFIG` comedi instruction with sub-instruction code `INSN_CONFIG_DIGITAL_TRIG` includes a base channel in `data[3]`. This is used as a right shift amount for other bitmask values without being checked. Shift

[PATCH RESEND 1/2] scsi: megaraid: Remove pci-dma-compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_

[PATCH RESEND 2/2] scsi: megaraid: Remove remaining pci-dma-compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_

Re: [PATCH 4.19 42/86] scripts/gdb: fix lx-symbols gdb.error while loading modules

2020-07-27 Thread Kieran Bingham
Hi Stefano, On 27/07/2020 15:37, Stefano Garzarella wrote: > On Mon, Jul 27, 2020 at 03:26:42PM +0100, Kieran Bingham wrote: >> Hi Greg, Sasha, >> >> On 27/07/2020 15:04, Greg Kroah-Hartman wrote: >>> From: Stefano Garzarella >>> >>> [ Upstream commit 7359608a271ce81803de148befefd309baf88c76 ]

Re: [PATCH] KVM: Using macros instead of magic values

2020-07-27 Thread Paolo Bonzini
On 21/07/20 10:23, Haiwei Li wrote: > From: Haiwei Li > > Instead of using magic values, use macros. > > Signed-off-by: Haiwei Li > --- >  arch/x86/kvm/lapic.c | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > index

Re: [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable

2020-07-27 Thread Andy Shevchenko
Joe, can we amend checkpatch to at least shout about simple typos in the tag area? See below for the context. On Mon, Jul 27, 2020 at 4:48 PM Vaibhav Gupta wrote: > On Mon, Jul 27, 2020 at 04:38:40PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 27, 2020 at 4:21 PM Vaibhav Gupta > > wrote:

[PATCH 4.19 20/86] ALSA: info: Drop WARN_ON() from buffer NULL sanity check

2020-07-27 Thread Greg Kroah-Hartman
From: Takashi Iwai commit 60379ba08532eca861e933b389526a4dc89e0c42 upstream. snd_info_get_line() has a sanity check of NULL buffer -- both buffer itself being NULL and buffer->buffer being NULL. Basically both checks are valid and necessary, but the problem is that it's with snd_BUG_ON() macro

[PATCH 4.19 18/86] IB/umem: fix reference count leak in ib_umem_odp_get()

2020-07-27 Thread Greg Kroah-Hartman
From: Yang Yingliang Add missing mmput() on error path to avoid ref-count leak. This problem is introduced by 79bb5b7ee177 ("RDMA/umem: Fix missing mmap_sem in get umem ODP call") and resolved by f27a0d50a4bc ("RDMA/umem: Use umem->owning_mm inside ODP"). So, it's only needed in stable-4.14

[PATCH 2/2] ima: Fail rule parsing when asymmetric key measurement isn't supportable

2020-07-27 Thread Tyler Hicks
Measuring keys is currently only supported for asymmetric keys. In the future, this might change. For now, the "func=KEY_CHECK" and "keyrings=" options are only appropriate when CONFIG_IMA_MEASURE_ASYMMETRIC_KEYS is enabled. Make this clear at policy load so that IMA policy authors don't assume

[PATCH 4.19 14/86] irqdomain/treewide: Keep firmware node unconditionally allocated

2020-07-27 Thread Greg Kroah-Hartman
From: Thomas Gleixner [ Upstream commit e3beca48a45b5e0e6e6a4e0124276b8248dcc9bb ] Quite some non OF/ACPI users of irqdomains allocate firmware nodes of type IRQCHIP_FWNODE_NAMED or IRQCHIP_FWNODE_NAMED_ID and free them right after creating the irqdomain. The only purpose of these FW nodes is

[PATCH 0/2] ima: Fix keyrings race condition and other key related bugs

2020-07-27 Thread Tyler Hicks
Nayna pointed out that the "keyrings=" option in an IMA policy rule should only be accepted when CONFIG_IMA_MEASURE_ASYMMETRIC_KEYS is enabled: https://lore.kernel.org/linux-integrity/336cc947-1f70-0286-6506-6df3d1d23...@linux.vnet.ibm.com/ While fixing this, the compiler warned me about the

[PATCH 4.19 15/86] SUNRPC reverting d03727b248d0 ("NFSv4 fix CLOSE not waiting for direct IO compeletion")

2020-07-27 Thread Greg Kroah-Hartman
From: Olga Kornievskaia commit 65caafd0d2145d1dd02072c4ced540624daeab40 upstream. Reverting commit d03727b248d0 "NFSv4 fix CLOSE not waiting for direct IO compeletion". This patch made it so that fput() by calling inode_dio_done() in nfs_file_release() would wait uninterruptably for any

[PATCH 4.14 63/64] ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb

2020-07-27 Thread Greg Kroah-Hartman
From: Qiujun Huang commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream. In ath9k_hif_usb_rx_cb interface number is assumed to be 0. usb_ifnum_to_if(urb->dev, 0) But it isn't always true. The case reported by syzbot: https://lore.kernel.org/linux-usb/666c9c05a1c05...@google.com

[PATCH 4.19 12/86] drivers/firmware/psci: Fix memory leakage in alloc_init_cpu_groups()

2020-07-27 Thread Greg Kroah-Hartman
From: Gavin Shan [ Upstream commit c377e67c6271954969384f9be1b1b71de13eba30 ] The CPU mask (@tmp) should be released on failing to allocate @cpu_groups or any of its elements. Otherwise, it leads to memory leakage because the CPU mask variable is dynamically allocated when

[PATCH 4.14 64/64] ath9k: Fix regression with Atheros 9271

2020-07-27 Thread Greg Kroah-Hartman
From: Mark O'Donovan commit 92f53e2fda8bb9a559ad61d57bfb397ce67ed0ab upstream. This fix allows ath9k_htc modules to connect to WLAN once again. Fixes: 2bbcaaee1fcb ("ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb") Link: https://bugzilla.kernel.org/show_bug.cgi?id=208251

[PATCH 4.19 11/86] drm/nouveau/i2c/g94-: increase NV_PMGR_DP_AUXCTL_TRANSACTREQ timeout

2020-07-27 Thread Greg Kroah-Hartman
From: Ben Skeggs [ Upstream commit 0156e76d388310a490aeb0f2fbb5b284ded3aecc ] Tegra TRM says worst-case reply time is 1216us, and this should fix some spurious timeouts that have been popping up. Signed-off-by: Ben Skeggs Signed-off-by: Sasha Levin ---

[PATCH 4.19 22/86] btrfs: fix double free on ulist after backref resolution failure

2020-07-27 Thread Greg Kroah-Hartman
From: Filipe Manana commit 580c079b5766ac706f56eec5c79aee4bf929fef6 upstream. At btrfs_find_all_roots_safe() we allocate a ulist and set the **roots argument to point to it. However if later we fail due to an error returned by find_parent_nodes(), we free that ulist but leave a dangling pointer

[PATCH 4.19 25/86] bnxt_en: Fix race when modifying pause settings.

2020-07-27 Thread Greg Kroah-Hartman
From: Vasundhara Volam [ Upstream commit 163e9ef63641a02de4c95cd921577265c52e1ce2 ] The driver was modified to not rely on rtnl lock to protect link settings about 2 years ago. The pause setting was missed when making that change. Fix it by acquiring link_lock mutex before calling

Re: [PATCH 08/10] media: uapi: h264: Clean slice invariants syntax elements

2020-07-27 Thread Ezequiel Garcia
Hi Alexandre, Thanks a lot for the review. On Sat, 2020-07-25 at 23:34 +0900, Alexandre Courbot wrote: > On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia > wrote: > > The H.264 specification requires in its "Slice header semantics" > > section that the following values shall be the same in all

Re: [PATCH] qed: fix assignment of n_rq_elems to incorrect params field

2020-07-27 Thread Colin Ian King
On 27/07/2020 15:36, Alexander Lobakin wrote: > Hi Colin, > > From: Colin King > Date: Mon, 27 Jul 2020 15:17:12 +0100 > >> From: Colin Ian King >> >> Currently n_rq_elems is being assigned to params.elem_size instead of the >> field params.num_elems. Coverity is detecting this as a double

[PATCH 4.19 27/86] hippi: Fix a size used in a pci_free_consistent() in an error handling path

2020-07-27 Thread Greg Kroah-Hartman
From: Christophe JAILLET [ Upstream commit 3195c4706b00106aa82c73acd28340fa8fc2bfc1 ] The size used when calling 'pci_alloc_consistent()' and 'pci_free_consistent()' should match. Fix it and have it consistent with the corresponding call in 'rr_close()'. Fixes: 1da177e4c3f4

include/linux/spinlock.h:378:9: sparse: sparse: context imbalance in 'cfspi_ss_cb' - unexpected unlock

2020-07-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 92ed301919932f13b9172e525674157e983d commit: 80591e61a0f7e88deaada69844e4a31280c4a38f kbuild: tell sparse about the $ARCH date: 9 months ago config: nios2-randconfig-s032-20200727 (attached as .config

[PATCH 4.19 08/86] xtensa: update *pos in cpuinfo_op.next

2020-07-27 Thread Greg Kroah-Hartman
From: Max Filippov [ Upstream commit 0d5ab144429e8bd80889b856a44d56ab4a5cd59b ] Increment *pos in the cpuinfo_op.next to fix the following warning triggered by cat /proc/cpuinfo: seq_file: buggy .next function c_next did not update position index Signed-off-by: Max Filippov Signed-off-by:

[PATCH 4.19 06/86] scsi: scsi_transport_spi: Fix function pointer check

2020-07-27 Thread Greg Kroah-Hartman
From: Tom Rix [ Upstream commit 5aee52c44d9170591df65fafa1cd408acc1225ce ] clang static analysis flags several null function pointer problems. drivers/scsi/scsi_transport_spi.c:374:1: warning: Called function pointer is null (null dereference) [core.CallAndMessage]

[PATCH 4.19 40/86] serial: exar: Fix GPIO configuration for Sealevel cards based on XR17V35X

2020-07-27 Thread Greg Kroah-Hartman
From: Matthew Howell [ Upstream commit 5fdbe136ae19ab751daaa4d08d9a42f3e30d17f9 ] Sealevel XR17V35X based devices are inoperable on kernel versions 4.11 and above due to a change in the GPIO preconfiguration introduced in commit 7dea8165f1d. This patch fixes this by preconfiguring the GPIO on

[PATCH 4.19 04/86] pinctrl: amd: fix npins for uart0 in kerncz_groups

2020-07-27 Thread Greg Kroah-Hartman
From: Jacky Hu [ Upstream commit 69339d083dfb7786b0e0b3fc19eaddcf11fabdfb ] uart0_pins is defined as: static const unsigned uart0_pins[] = {135, 136, 137, 138, 139}; which npins is wronly specified as 9 later { .name = "uart0", .pins = uart0_pins,

Re: [PATCH v3] mm/hugetlb: split hugetlb_cma in nodes with memory

2020-07-27 Thread Aneesh Kumar K.V
Mike Kravetz writes: > On 7/19/20 11:22 PM, Anshuman Khandual wrote: >> >> >> On 07/17/2020 10:32 PM, Mike Kravetz wrote: >>> On 7/16/20 10:02 PM, Anshuman Khandual wrote: On 07/16/2020 11:55 PM, Mike Kravetz wrote: > >From 17c8f37afbf42fe7412e6eebb3619c6e0b7e1c3c Mon Sep 17

[PATCH 4.19 09/86] drivers/net/wan/lapbether: Fixed the value of hard_header_len

2020-07-27 Thread Greg Kroah-Hartman
From: Xie He [ Upstream commit 9dc829a135fb5927f1519de11286e2bbb79f5b66 ] When this driver transmits data, first this driver will remove a pseudo header of 1 byte, then the lapb module will prepend the LAPB header of 2 or 3 bytes, then this driver will prepend a length field of 2 bytes,

[PATCH 4.19 54/86] Input: elan_i2c - only increment wakeup count on touch

2020-07-27 Thread Greg Kroah-Hartman
From: Derek Basehore [ Upstream commit 966334dfc472bdfa67bed864842943b19755d192 ] This moves the wakeup increment for elan devices to the touch report. This prevents the drivers from incorrectly reporting a wakeup when the resume callback resets then device, which causes an interrupt to occur.

[PATCH 4.19 33/86] bonding: check error value of register_netdevice() immediately

2020-07-27 Thread Greg Kroah-Hartman
From: Taehee Yoo [ Upstream commit 544f287b84959203367cd29e16e772717612fab4 ] If register_netdevice() is failed, net_device should not be used because variables are uninitialized or freed. So, the routine should be stopped immediately. But, bond_create() doesn't check return value of

[PATCH 4.19 53/86] Input: synaptics - enable InterTouch for ThinkPad X1E 1st gen

2020-07-27 Thread Greg Kroah-Hartman
From: Ilya Katsnelson [ Upstream commit dcb00fc799dc03fd320e123e4c81b3278c763ea5 ] Tested on my own laptop, touchpad feels slightly more responsive with this on, though it might just be placebo. Signed-off-by: Ilya Katsnelson Reviewed-by: Lyude Paul Link:

[PATCH 4.19 47/86] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-07-27 Thread Greg Kroah-Hartman
From: Dinghao Liu [ Upstream commit 5b78fac4b1ba731cf4177fdbc1e3a4661521bcd0 ] pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao

[PATCH 4.19 00/86] 4.19.135-rc1 review

2020-07-27 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.135 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 29 Jul 2020 13:48:51 +. Anything

[PATCH 4.19 36/86] ipvs: fix the connection sync failed in some cases

2020-07-27 Thread Greg Kroah-Hartman
From: guodeqing [ Upstream commit 8210e344ccb798c672ab237b1a4f241bda08909b ] The sync_thread_backup only checks sk_receive_queue is empty or not, there is a situation which cannot sync the connection entries when sk_receive_queue is empty and sk_rmem_alloc is larger than sk_rcvbuf, the sync

[PATCH 4.19 51/86] hwmon: (aspeed-pwm-tacho) Avoid possible buffer overflow

2020-07-27 Thread Greg Kroah-Hartman
From: Evgeny Novikov [ Upstream commit bc4071aafcf4d0535ee423b69167696d6c03207d ] aspeed_create_fan() reads a pwm_port value using of_property_read_u32(). If pwm_port will be more than ARRAY_SIZE(pwm_port_params), there will be a buffer overflow in

[PATCH 4.19 41/86] scripts/decode_stacktrace: strip basepath from all paths

2020-07-27 Thread Greg Kroah-Hartman
From: Pi-Hsun Shih [ Upstream commit d178770d8d21489abf5bafefcbb6d5243b482e9a ] Currently the basepath is removed only from the beginning of the string. When the symbol is inlined and there's multiple line outputs of addr2line, only the first line would have basepath removed. Change to remove

Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

2020-07-27 Thread Jiri Pirko
Mon, Jul 27, 2020 at 03:29:17PM CEST, andy.shevche...@gmail.com wrote: >On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan wrote: [...] > >> + pci_set_drvdata(pdev, fw); >> + >> + err = prestera_fw_init(fw); >> + if (err) >> + goto err_prestera_fw_init; >> + >> +

[PATCH 4.19 82/86] ASoC: rt5670: Add new gpio1_is_ext_spk_en quirk and enable it on the Lenovo Miix 2 10

2020-07-27 Thread Greg Kroah-Hartman
From: Hans de Goede commit 85ca6b17e2bb96b19caac3b02c003d670b66de96 upstream. The Lenovo Miix 2 10 has a keyboard dock with extra speakers in the dock. Rather then the ACL5672's GPIO1 pin being used as IRQ to the CPU, it is actually used to enable the amplifier for these speakers (the IRQ to

[PATCH 4.19 29/86] net: dp83640: fix SIOCSHWTSTAMP to update the struct with actual configuration

2020-07-27 Thread Greg Kroah-Hartman
From: Sergey Organov [ Upstream commit 473309fb8372365ad211f425bca760af800e10a7 ] >From Documentation/networking/timestamping.txt: A driver which supports hardware time stamping shall update the struct with the actual, possibly more permissive configuration. Do update the struct passed

[PATCH 4.19 76/86] mm: memcg/slab: fix memory leak at non-root kmem_cache destroy

2020-07-27 Thread Greg Kroah-Hartman
From: Muchun Song commit d38a2b7a9c939e6d7329ab92b96559ccebf7b135 upstream. If the kmem_cache refcount is greater than one, we should not mark the root kmem_cache as dying. If we mark the root kmem_cache dying incorrectly, the non-root kmem_cache can never be destroyed. It resulted in memory

[PATCH 4.19 74/86] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation

2020-07-27 Thread Greg Kroah-Hartman
From: Fangrui Song commit ca9b31f6bb9c6aa9b4e5f0792f39a97bbffb8c51 upstream. When CROSS_COMPILE is set (e.g. aarch64-linux-gnu-), if $(CROSS_COMPILE)elfedit is found at /usr/bin/aarch64-linux-gnu-elfedit, GCC_TOOLCHAIN_DIR will be set to /usr/bin/. --prefix= will be set to /usr/bin/ and Clang

Re: [PATCH] coresight: etm4x: Fix etm4_count race using atomic variable

2020-07-27 Thread Sai Prakash Ranjan
On 2020-07-27 15:09, Suzuki K Poulose wrote: On 07/27/2020 07:07 AM, Sai Prakash Ranjan wrote: etm4_count keeps track of number of ETMv4 registered and on some systems, a race is observed on etm4_count variable which can lead to multiple calls to cpuhp_setup_state_nocalls_cpuslocked(). This

[PATCH 4.19 65/86] staging: wlan-ng: properly check endpoint types

2020-07-27 Thread Greg Kroah-Hartman
From: Rustam Kovhaev commit faaff9765664009c1c7c65551d32e9ed3b1dda8f upstream. As syzkaller detected, wlan-ng driver does not do sanity check of endpoints in prism2sta_probe_usb(), add check for xfer direction and type Reported-and-tested-by:

[PATCH 4.19 81/86] x86, vmlinux.lds: Page-align end of ..page_aligned sections

2020-07-27 Thread Greg Kroah-Hartman
From: Joerg Roedel commit de2b41be8fcccb2f5b6c480d35df590476344201 upstream. On x86-32 the idt_table with 256 entries needs only 2048 bytes. It is page-aligned, but the end of the .bss..page_aligned section is not guaranteed to be page-aligned. As a result, objects from other .bss sections may

[PATCH 4.19 69/86] staging: comedi: addi_apci_1564: check INSN_CONFIG_DIGITAL_TRIG shift

2020-07-27 Thread Greg Kroah-Hartman
From: Ian Abbott commit 926234f1b8434c4409aa4c53637aa3362ca07cea upstream. The `INSN_CONFIG` comedi instruction with sub-instruction code `INSN_CONFIG_DIGITAL_TRIG` includes a base channel in `data[3]`. This is used as a right shift amount for other bitmask values without being checked. Shift

Re: [PATCH 4.19 42/86] scripts/gdb: fix lx-symbols gdb.error while loading modules

2020-07-27 Thread Stefano Garzarella
On Mon, Jul 27, 2020 at 03:26:42PM +0100, Kieran Bingham wrote: > Hi Greg, Sasha, > > On 27/07/2020 15:04, Greg Kroah-Hartman wrote: > > From: Stefano Garzarella > > > > [ Upstream commit 7359608a271ce81803de148befefd309baf88c76 ] > > > > Commit ed66f991bb19 ("module: Refactor section attr

[PATCH 5.4 004/138] pinctrl: amd: fix npins for uart0 in kerncz_groups

2020-07-27 Thread Greg Kroah-Hartman
From: Jacky Hu [ Upstream commit 69339d083dfb7786b0e0b3fc19eaddcf11fabdfb ] uart0_pins is defined as: static const unsigned uart0_pins[] = {135, 136, 137, 138, 139}; which npins is wronly specified as 9 later { .name = "uart0", .pins = uart0_pins,

<    5   6   7   8   9   10   11   12   13   14   >