RE: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682

2020-07-28 Thread RAVULAPATI, VISHNU VARDHAN RAO
[AMD Official Use Only - Internal Distribution Only] So Actually for rt5682 codec Now in 5.8 there are three flags : SND_SOC_RT5682 SND_SOC_RT5682_I2C SND_SOC_RT5682_SDW But till 5.7.8 we have SND_SOC_RT5682 SND_SOC_RT5682_SDW So in our design we were using SND_SOC_RT5682 which build snd_soc_rt5

Re: [PATCH] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

2020-07-28 Thread Xie He
Hi Brian Norris, I'm wishing to change a driver from using "hard_header_len" to using "needed_headroom" to declare its needed headroom. I submitted a patch and it is decided it needs to be reviewed. I see you submitted a similar patch in the past. So I think you might be able to help review my pat

[PATCH] sched: Make select_idle_sibling search domain configurable

2020-07-28 Thread Xi Wang
The scope of select_idle_sibling idle cpu search is LLC. This becomes a problem for the AMD CCX architecture, as the sd_llc is only 4 cores. On a many core machine, the range of search is too small to reach a satisfactory level of statistical multiplexing / efficient utilization of short idle time

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-07-28 Thread Martin Kepplinger
On 06.07.20 18:41, Alan Stern wrote: > On Tue, Jun 30, 2020 at 20:49:58PM -0400, Alan Stern wrote: >> On Tue, Jun 30, 2020 at 04:31:58PM -0700, Bart Van Assche wrote: >>> On 2020-06-30 12:38, Alan Stern wrote: Assume that BLK_MQ_REQ_PREEMPT is set in flags. Then where exactly does blk_q

Re: [PATCH] Bluetooth: Fix suspend notifier race

2020-07-28 Thread Marcel Holtmann
Hi Abhishek, > Unregister from suspend notifications and cancel suspend preparations > before running hci_dev_do_close. Otherwise, the suspend notifier may > race with unregister and cause cmd_timeout even after hdev has been > freed. > > Signed-off-by: Abhishek Pandit-Subedi > Reviewed-by: Miao

Re: [PATCH] mfd: dm355evm_msp: Convert LEDs to GPIO descriptor table

2020-07-28 Thread Lee Jones
On Mon, 27 Jul 2020, Linus Walleij wrote: > This converts the DaVinci DM355EVM LEDs to use GPIO > descriptor look-ups. > > Cc: Sekhar Nori > Cc: Bartosz Golaszewski > Signed-off-by: Linus Walleij > --- > drivers/mfd/dm355evm_msp.c | 49 -- > 1 file changed,

Re: [PATCH RFC 3/6] pwm: pwm-qti-lpg: Add PWM driver for QTI LPG module

2020-07-28 Thread Uwe Kleine-König
Hello Martin, On Mon, Jul 27, 2020 at 11:16:57PM +0200, Martin Botka wrote: > Mo 27. 7. 2020 at 22:10 Uwe Kleine-König > wrote: > > > > On Fri, Jul 24, 2020 at 11:36:53PM +0200, Martin Botka wrote: > > > From: Fenglin Wu > > > > > > Add pwm_chip to support QTI LPG module and export LPG channels

Re: [PATCH v3 0/3] Few bug fixes and Convert to pin_user_pages*()

2020-07-28 Thread Souptick Joarder
Hi Boris, On Sun, Jul 12, 2020 at 9:01 AM Souptick Joarder wrote: > > This series contains few clean up, minor bug fixes and > Convert get_user_pages() to pin_user_pages(). > > I'm compile tested this, but unable to run-time test, > so any testing help is much appriciated. > > v2: > Addre

Re: [PATCH] usb: hso: check for return value in hso_serial_common_create()

2020-07-28 Thread Greg KH
On Mon, Jul 27, 2020 at 11:42:17PM -0700, Rustam Kovhaev wrote: > in case of an error tty_register_device_attr() returns ERR_PTR(), > add IS_ERR() check > > Reported-and-tested-by: syzbot+67b2bd0e34f952d03...@syzkaller.appspotmail.com > Link: https://syzkaller.appspot.com/bug?extid=67b2bd0e34f952d

Re: [PATCH 1/2] Bluetooth: hci_h5: Set HCI_UART_RESET_ON_INIT to correct flags

2020-07-28 Thread Marcel Holtmann
Hi Nicolas, > HCI_UART_RESET_ON_INIT belongs in hdev_flags, not flags. > > Fixes: ce945552fde4a09 ("Bluetooth: hci_h5: Add support for serdev enumerated > devices") > Signed-off-by: Nicolas Boichat > > --- > > drivers/bluetooth/hci_h5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] Bluetooth: Return NOTIFY_DONE for hci_suspend_notifier

2020-07-28 Thread Marcel Holtmann
Hi Max, > The original return is NOTIFY_STOP, but notifier_call_chain would stop > the future call for register_pm_notifier even registered on other Kernel > modules with the same priority which value is zero. > > Signed-off-by: Max Chou > --- > net/bluetooth/hci_core.c | 2 +- > 1 file changed,

Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card support

2020-07-28 Thread Greg KH
On Tue, Jul 28, 2020 at 08:40:25AM +0200, Jiri Slaby wrote: > On 28. 07. 20, 8:20, Christoph Hellwig wrote: > > On Tue, Jul 28, 2020 at 08:05:36AM +0200, Jiri Slaby wrote: > >> On 27. 07. 20, 15:05, Christoph Hellwig wrote: > >>> Since commit 1355cba9c3ba ("tty/synclink: remove ISA support"), the >

Re: [PATCH v17 17/21] mm/lru: replace pgdat lru_lock with lruvec lock

2020-07-28 Thread Alex Shi
在 2020/7/28 上午7:34, Alexander Duyck 写道: >> @@ -847,11 +847,21 @@ static bool too_many_isolated(pg_data_t *pgdat) >> * contention, to give chance to IRQs. Abort completely if >> * a fatal signal is pending. >> */ >> - if (!(low_pfn

Re: [PATCH 2/2] Bluetooth: hci_serdev: Only unregister device if it was registered

2020-07-28 Thread Marcel Holtmann
Hi Nicolas, > We should not call hci_unregister_dev if the device was not > successfully registered. > > Fixes: c34dc3bfa7642fd ("Bluetooth: hci_serdev: Introduce > hci_uart_unregister_device()") > Signed-off-by: Nicolas Boichat > > --- > > drivers/bluetooth/hci_serdev.c | 3 ++- > 1 file chan

Re: [PATCH v6 01/13] mfd: add simple regmap based I2C driver

2020-07-28 Thread Lee Jones
On Sun, 26 Jul 2020, Michael Walle wrote: > There are I2C devices which contain several different functions but > doesn't require any special access functions. For these kind of drivers > an I2C regmap should be enough. > > Create an I2C driver which creates an I2C regmap and enumerates its > chi

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-07-28 Thread Sai Prakash Ranjan
On 2020-07-28 11:58, Bjorn Andersson wrote: On Mon 27 Jul 21:40 PDT 2020, Sai Prakash Ranjan wrote: On 2020-07-28 02:28, Bjorn Andersson wrote: > On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > > > Hi Bjorn, > > > > On 2020-06-21 13:39, Sai Prakash Ranjan wrote: > > > Hi Bjorn, > > >

Re: [PATCH 03/10] remoteproc: imx: use devm_ioremap

2020-07-28 Thread Oleksij Rempel
On Mon, Jul 27, 2020 at 08:11:09AM +, Peng Fan wrote: > > Subject: Re: [PATCH 03/10] remoteproc: imx: use devm_ioremap > > > > On Mon, Jul 27, 2020 at 06:51:00AM +, Peng Fan wrote: > > > > Subject: Re: [PATCH 03/10] remoteproc: imx: use devm_ioremap > > > > > > > > On Mon, Jul 27, 2020 at

[PATCH] [v2] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode

2020-07-28 Thread Dinghao Liu
The variable authmode can be uninitialized. The danger would be if it equals to _WPA_IE_ID_ (0xdd) or _WPA2_IE_ID_ (0x33). We can avoid this by setting it to zero instead. This is the approach that was used in the rtl8723bs driver. Fixes: 7b464c9fa5cc ("staging: r8188eu: Add files for new driver -

Re: [PATCH v6 02/13] dt-bindings: mfd: Add bindings for sl28cpld

2020-07-28 Thread Lee Jones
On Sun, 26 Jul 2020, Michael Walle wrote: > Add a device tree bindings for the board management controller found on > the Kontron SMARC-sAL28 board. > > Signed-off-by: Michael Walle > Reviewed-by: Rob Herring > --- > Changes since v5: > - none > > Changes since v4: > - fix the regex of the u

Re: [PATCH v6 03/13] mfd: simple-mfd-i2c: add sl28cpld support

2020-07-28 Thread Lee Jones
On Sun, 26 Jul 2020, Michael Walle wrote: > Add the core support for the board management controller found on the > SMARC-sAL28 board. > > At the moment, this controller is used on the Kontron SMARC-sAL28 board. > > Signed-off-by: Michael Walle > --- > Changes since v5: > - none > > Changes s

Re: [PATCH v4 1/6] fs: introduce FMODE_ZONE_APPEND and IOCB_ZONE_APPEND

2020-07-28 Thread Christoph Hellwig
On Tue, Jul 28, 2020 at 02:49:59AM +0100, Matthew Wilcox wrote: > On Sun, Jul 26, 2020 at 04:18:10PM +0100, Christoph Hellwig wrote: > > Zone append is a protocol context that ha not business showing up > > in a file system interface. The right interface is a generic way > > to report the written

Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early boot

2020-07-28 Thread Oleksij Rempel
On Mon, Jul 27, 2020 at 09:18:31AM +, Peng Fan wrote: > > Subject: Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early > > boot > > > > On Mon, Jul 27, 2020 at 06:44:32AM +, Peng Fan wrote: > > > Hi Oleksij, > > > > > > > Subject: Re: [PATCH 00/10] remoteproc: imx_rproc: suppo

Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs

2020-07-28 Thread Amelie DELAUNAY
Hi, On 7/27/20 9:44 PM, Andy Shevchenko wrote: On Mon, Jul 27, 2020 at 10:04 PM Martin Blumenstingl wrote: On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay wrote: > -   p->activate_stm_id_vb_detection = true; > +   p->activate_stm_id_vb_detection = > +   !of_property_re

Re: [PATCH v3] usb: dwc3: Add support for VBUS power control

2020-07-28 Thread Mike Looijmans
Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijm...@topicproducts.com W: www.topicproducts.com Please consider the environment before printing this e-mail On 2

Re: [PATCH 5.4 000/138] 5.4.54-rc1 review

2020-07-28 Thread Naresh Kamboju
On Mon, 27 Jul 2020 at 19:48, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.54 release. > There are 138 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

[PATCH] selftests: more general make nesting support

2020-07-28 Thread Greg Thelen
selftests can be built from the toplevel kernel makefile (e.g. make kselftest-all) or directly (make -C tools/testing/selftests all). The toplevel kernel makefile explicitly disables implicit rules with "MAKEFLAGS += -rR", which is passed to tools/testing/selftests. Some selftest makefiles requir

Re: [PATCH 5.7 000/179] 5.7.11-rc1 review

2020-07-28 Thread Naresh Kamboju
On Mon, 27 Jul 2020 at 19:49, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.7.11 release. > There are 179 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

Re: [PATCH] ARM: dts: berlin: Align L2 cache-controller nodename with dtschema

2020-07-28 Thread Arnd Bergmann
On Tue, Jul 28, 2020 at 8:37 AM Jisheng Zhang wrote: > > Hi arm-soc, > > > On Fri, 26 Jun 2020 10:06:41 +0200 Krzysztof Kozlowski wrote: > > > > > > > Fix dtschema validator warnings like: > > l2-cache-controller@ac: $nodename:0: > > 'l2-cache-controller@ac' does not match > >

Re: linux-next: build failure after merge of the char-misc tree

2020-07-28 Thread Stephen Rothwell
Hi Greg, On Mon, 27 Jul 2020 11:24:48 +0200 Greg KH wrote: > > On Mon, Jul 27, 2020 at 06:08:31PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the char-misc tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > In file included from drivers/misc/

Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex

2020-07-28 Thread Masami Hiramatsu
On Sat, 25 Jul 2020 12:21:10 +0200 Ingo Molnar wrote: > > * Jarkko Sakkinen wrote: > > > On Fri, Jul 24, 2020 at 11:17:11AM +0200, Ingo Molnar wrote: > > > > > > * Jarkko Sakkinen wrote: > > > > > > > --- a/kernel/kprobes.c > > > > +++ b/kernel/kprobes.c > > > > @@ -564,7 +564,7 @@ static v

Re: [Linux-kernel-mentees] [PATCH net v2] xdp: Prevent kernel-infoleak in xsk_getsockopt()

2020-07-28 Thread Arnd Bergmann
On Tue, Jul 28, 2020 at 7:37 AM Peilin Ye wrote: > > xsk_getsockopt() is copying uninitialized stack memory to userspace when > `extra_stats` is `false`. Fix it. > > Fixes: 8aa5a33578e9 ("xsk: Add new statistics") > Suggested-by: Dan Carpenter > Signed-off-by: Peilin Ye Acked-by: Arnd Bergmann

Re: [PATCH] Staging : media : atomisp : fixed a brace coding sytle issue

2020-07-28 Thread Greg KH
On Tue, Jul 28, 2020 at 03:00:10AM +0530, Ankit wrote: > From: Ankit Baluni You need a ' ' before the '<' character. > > Fixed a coding style issue. Be more descriptive of what you are doing, this is vague. > > Signed-off-by: Ankit Baluni Same here with the ' '. thanks, greg k-h

Re: [PATCH v3 0/3] Few bug fixes and Convert to pin_user_pages*()

2020-07-28 Thread Jürgen Groß
On 28.07.20 09:10, Souptick Joarder wrote: Hi Boris, On Sun, Jul 12, 2020 at 9:01 AM Souptick Joarder wrote: This series contains few clean up, minor bug fixes and Convert get_user_pages() to pin_user_pages(). I'm compile tested this, but unable to run-time test, so any testing help is much

Re: [RESEND PATCH] drivers: arm arch timer: Correct fault programming of CNTKCTL_EL1.EVNTI

2020-07-28 Thread zhukeqian
Friendly ping. Is this an effective bugfix? On 2020/7/17 17:21, Keqian Zhu wrote: > ARM virtual counter supports event stream. It can only trigger an event > when the trigger bit of CNTVCT_EL0 changes from 0 to 1 (or from 1 to 0), > so the actual period of event stream is 2 ^ (cntkctl_evnti + 1).

Re: [PATCH] ARM: dts: berlin: Align L2 cache-controller nodename with dtschema

2020-07-28 Thread Jisheng Zhang
On Tue, 28 Jul 2020 09:33:05 +0200 Arnd Bergmann wrote: > > > On Tue, Jul 28, 2020 at 8:37 AM Jisheng Zhang > wrote: > > > > Hi arm-soc, > > > > > > On Fri, 26 Jun 2020 10:06:41 +0200 Krzysztof Kozlowski wrote: > > > > > > > > > > > Fix dtschema validator warnings like: > > > l2-cache-co

Re: [PATCH v6 01/13] mfd: add simple regmap based I2C driver

2020-07-28 Thread Michael Walle
Am 2020-07-28 09:19, schrieb Lee Jones: On Sun, 26 Jul 2020, Michael Walle wrote: There are I2C devices which contain several different functions but doesn't require any special access functions. For these kind of drivers an I2C regmap should be enough. Create an I2C driver which creates an

Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller

2020-07-28 Thread Uwe Kleine-König
Hello, just a few minor issues left: On Sun, Jul 26, 2020 at 01:18:27AM +0200, Michael Walle wrote: > diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c > new file mode 100644 > index ..956fa09f3aba > --- /dev/null > +++ b/drivers/pwm/pwm-sl28cpld.c > @@ -0,0 +1,223

Re: [RESEND PATCH v2] mfd: syscon: Use a unique name with regmap_config

2020-07-28 Thread Arnd Bergmann
On Mon, Jul 27, 2020 at 11:10 PM Suman Anna wrote: > > The DT node full name is currently being used in regmap_config > which in turn is used to create the regmap debugfs directories. > This name however is not guaranteed to be unique and the regmap > debugfs registration can fail in the cases whe

[PATCH v5 0/3] Add USB role switch support to DWC2

2020-07-28 Thread Amelie Delaunay
When using usb-c connector (but it can also be the case with a micro-b connector), iddig, avalid, bvalid, vbusvalid input signals may not be connected to the DWC2 OTG controller. DWC2 OTG controller features an overriding control of the PHY voltage valid and ID input signals. So, missing signals ca

[PATCH v5 1/3] dt-bindings: usb: dwc2: add optional usb-role-switch property

2020-07-28 Thread Amelie Delaunay
This patch documents the usb-role-switch property in dwc2 bindings, now that usb-role-switch support is available in dwc2 driver. Reviewed-by: Martin Blumenstingl Signed-off-by: Amelie Delaunay --- Documentation/devicetree/bindings/usb/dwc2.yaml | 4 1 file changed, 4 insertions(+) diff -

[PATCH v5 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs

2020-07-28 Thread Amelie Delaunay
If usb-role-switch is present in the device tree, it means that ID and Vbus signals are not connected to the OTG controller but to an external component (GPIOs, Type-C controller). In this configuration, usb role switch is used to force valid sessions on STM32MP15 SoCs. Signed-off-by: Amelie Delau

[PATCH v5 2/3] usb: dwc2: override PHY input signals with usb role switch support

2020-07-28 Thread Amelie Delaunay
This patch adds support for usb role switch to dwc2, by using overriding control of the PHY voltage valid and ID input signals. iddig signal (ID) can be overridden: - when setting GUSBCFG_FORCEHOSTMODE, iddig input pin is overridden with 1; - when setting GUSBCFG_FORCEDEVMODE, iddig input pin is o

Re: [PATCH 1/2] media: stm32-dcmi: create video dev within notifier bound

2020-07-28 Thread Hugues FRUCHET
Reviewed-by: Hugues Fruchet On 7/28/20 8:37 AM, Alain Volmat wrote: > In case of an error during the initialization of the sensor, > the video device is still available since created at the > probe of the dcmi driver. Moreover the device wouldn't > be released even when removing the module since

Re: [PATCH] hwrng: imx-rngc - setup default RNG quality

2020-07-28 Thread Marco Felsch
Hi Christian, On 20-07-27 14:45, Christian Eggers wrote: > When hw_random device's quality is non-zero, it will automatically fill > the kernel's entropy pool at boot. For this purpose, one conservative > quality value is being picked up as the default value. IMHO your value is not conservative

Re: [PATCH 2/2] media: stm32-dcmi: fix probe error path & module remove

2020-07-28 Thread Hugues FRUCHET
Reviewed-by: Hugues Fruchet On 7/28/20 8:37 AM, Alain Volmat wrote: > This commit add missing vb2_queue_release calls with the > probe error path and module remove. > Missing v4l2_async_notifier_unregister is also added within > the probe error path > > Fixes: 37404f91ef8b ("[media] stm32-dcmi:

Re: [PATCH] thermal: core: Add thermal zone enable/disable notification

2020-07-28 Thread Zhang Rui
On Tue, 2020-07-28 at 01:10 +0200, Daniel Lezcano wrote: > Now the calls to enable/disable a thermal zone are centralized in a > call to a function, we can add in these the corresponding netlink > notifications. > > Signed-off-by: Daniel Lezcano Acked-by: Zhang Rui > --- > drivers/thermal/ther

RE: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early boot

2020-07-28 Thread Peng Fan
> Subject: Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early > boot > > On Mon, Jul 27, 2020 at 09:18:31AM +, Peng Fan wrote: > > > Subject: Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and > > > early boot > > > > > > On Mon, Jul 27, 2020 at 06:44:32AM +, Peng Fan

[PATCHv2] coresight: etm4x: Fix etm4_count race by moving cpuhp callbacks to init

2020-07-28 Thread Sai Prakash Ranjan
etm4_count keeps track of number of ETMv4 registered and on some systems, a race is observed on etm4_count variable which can lead to multiple calls to cpuhp_setup_state_nocalls_cpuslocked(). This function internally calls cpuhp_store_callbacks() which prevents multiple registrations of callbacks f

Re: [PATCH RCC 1/6] pwm: Add different PWM output types support

2020-07-28 Thread Uwe Kleine-König
Hello Martin, On Mon, Jul 27, 2020 at 10:56:31PM +0200, Martin Botka wrote: > Mo 27. 7. 2020 at 22:10 Uwe Kleine-König > wrote: > > On Fri, Jul 24, 2020 at 11:36:51PM +0200, Martin Botka wrote: > > > +/* > > > + * pwm_output_type_support() > > > + * @pwm: PWM device > > > + * > > > + * Returns:

Re: [PATCH 4/7] net/mlx5: drop unnecessary list_empty

2020-07-28 Thread Saeed Mahameed
On Mon, 2020-07-27 at 10:10 -0700, David Miller wrote: > From: Julia Lawall > Date: Sun, 26 Jul 2020 12:58:29 +0200 > > > list_for_each_entry is able to handle an empty list. > > The only effect of avoiding the loop is not initializing the > > index variable. > > Drop list_empty tests in cases wh

Re: [PATCH linux-next] clk: sparx5: Review changes

2020-07-28 Thread Lars Povlsen
Stephen Boyd writes: > Quoting Arnd Bergmann (2020-07-27 13:11:49) >> On Mon, Jul 27, 2020 at 9:39 PM Stephen Boyd wrote: >> > >> > Why was the clk driver merged to linux-next outside of the clk tree? Was >> > there some sort of dependency? >> >> I merged the entire series of the base platform

Re: linux-next: build failure after merge of the char-misc tree

2020-07-28 Thread Greg KH
On Tue, Jul 28, 2020 at 05:33:31PM +1000, Stephen Rothwell wrote: > Hi Greg, > > On Mon, 27 Jul 2020 11:24:48 +0200 Greg KH wrote: > > > > On Mon, Jul 27, 2020 at 06:08:31PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the char-misc tree, today's linux-next build (x86_6

Re: [PATCH][next] net/mlx5: Use fallthrough pseudo-keyword

2020-07-28 Thread Saeed Mahameed
On Mon, 2020-07-27 at 13:24 -0700, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Mon, 27 Jul 2020 13:03:56 -0500 > > > Replace the existing /* fall through */ comments and its variants > with > > the new pseudo-keyword macro fallthrough[1]. Also, remove > unnecessary > > fall-through

RE: [PATCH v7 3/8] scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs

2020-07-28 Thread Avri Altman
> > Dumping testbus registers is heavy enough to cause stability issues > sometime, just remove them as of now. > > Signed-off-by: Can Guo Reviewed-by: Avri Altman

Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early boot

2020-07-28 Thread Oleksij Rempel
On Tue, Jul 28, 2020 at 07:50:04AM +, Peng Fan wrote: > > Subject: Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early > > boot > > > > On Mon, Jul 27, 2020 at 09:18:31AM +, Peng Fan wrote: > > > > Subject: Re: [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and > > > > ear

Re: [PATCH v2] drm/hisilicon: Fixed the warning: Assignment of 0/1 to bool variable

2020-07-28 Thread Thomas Zimmermann
Hi Am 07.07.20 um 04:58 schrieb Tian Tao: > fixed the following warning: > hibmc_drm_drv.c:296:1-18:WARNING: Assignment of 0/1 to bool variable. > hibmc_drm_drv.c:301:2-19: WARNING: Assignment of 0/1 to bool variable. > > v2: > using the pci_dev.msi_enabled instead of priv->msi_enabled. > > Sign

Re: [PATCH v6 02/13] dt-bindings: mfd: Add bindings for sl28cpld

2020-07-28 Thread Michael Walle
Am 2020-07-28 09:24, schrieb Lee Jones: On Sun, 26 Jul 2020, Michael Walle wrote: Add a device tree bindings for the board management controller found on the Kontron SMARC-sAL28 board. Signed-off-by: Michael Walle Reviewed-by: Rob Herring --- Changes since v5: - none Changes since v4: -

Re: [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support

2020-07-28 Thread Lee Jones
On Fri, 17 Jul 2020, David E. Box wrote: > Intel Platform Monitoring Technology (PMT) is an architecture for > enumerating and accessing hardware monitoring facilities. PMT supports > multiple types of monitoring capabilities. This driver creates platform > devices for each type so that they may b

Re: [PATCH V2 1/4] gpio: mxc: Support module build

2020-07-28 Thread Linus Walleij
On Mon, Jul 27, 2020 at 12:44 PM Arnd Bergmann wrote: > On Mon, Jul 27, 2020 at 10:18 AM Anson Huang wrote: > > > Why is this driver using syscore_ops rather than > > > SIMPLE_DEV_PM_OPS() or similar? > > > > Below is the original patch of using syscore_ops, it has explanation: > > > > commit 1a

Re: [RESEND PATCH v2] mfd: syscon: Use a unique name with regmap_config

2020-07-28 Thread Lee Jones
On Mon, 27 Jul 2020, Suman Anna wrote: > The DT node full name is currently being used in regmap_config > which in turn is used to create the regmap debugfs directories. > This name however is not guaranteed to be unique and the regmap > debugfs registration can fail in the cases where the syscon

Re: [PATCH 2/2] media: bt8xx: avoid a useless memset

2020-07-28 Thread Christophe JAILLET
Le 27/07/2020 à 18:09, Joe Perches a écrit : On Mon, 2020-07-27 at 15:51 +0200, Christophe JAILLET wrote: Avoid a memset after a call to 'dma_alloc_coherent()'. This is useless since commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") [] diff --git a/drivers/media/pci/bt

Re: [PATCH 2/2] media: bt8xx: avoid a useless memset

2020-07-28 Thread Christophe JAILLET
Le 27/07/2020 à 18:16, Joe Perches a écrit : On Mon, 2020-07-27 at 09:09 -0700, Joe Perches wrote: On Mon, 2020-07-27 at 15:51 +0200, Christophe JAILLET wrote: Avoid a memset after a call to 'dma_alloc_coherent()'. This is useless since commit 518a2f1925c3 ("dma-mapping: zero memory returned fr

RE: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-28 Thread David Laight
From: Christoph Hellwig > Sent: 27 July 2020 17:24 > > On Mon, Jul 27, 2020 at 06:16:32PM +0200, Jason A. Donenfeld wrote: > > Maybe sockptr_advance should have some safety checks and sometimes > > return -EFAULT? Or you should always use the implementation where > > being a kernel address is an e

Re: [PATCH 03/15] arm, xtensa: simplify initialization of high memory pages

2020-07-28 Thread Max Filippov
On Mon, Jul 27, 2020 at 10:12 PM Mike Rapoport wrote: > > From: Mike Rapoport > > The function free_highpages() in both arm and xtensa essentially open-code > for_each_free_mem_range() loop to detect high memory pages that were not > reserved and that should be initialized and passed to the buddy

Re: [PATCH V2 1/4] gpio: mxc: Support module build

2020-07-28 Thread Linus Walleij
On Mon, Jul 27, 2020 at 1:57 PM Arnd Bergmann wrote: > Overall, my feeling is that making sure all drivers that depend on the pinctrl > driver can deal with deferred probing is a prerequisite before this can be > made a loadable module itself (same for clk, irqchip, etc drivers that others > may

Re: [PATCH v4 4/6] dt-bindings: snps,dw-apb-ssi: Add sparx5 support, plus rx-sample-delay-ns property

2020-07-28 Thread Lars Povlsen
Rob Herring writes: > On Fri, Jul 24, 2020 at 01:14:02PM +0200, Lars Povlsen wrote: >> This has the following changes for the snps,dw-apb-ss DT bindings: >> >> - Add "microchip,sparx5-spi" as the compatible for the Sparx5 SoC >> controller >> >> - Add the property "rx-sample-delay-ns" >> >> Si

linux-next: build failure after merge of the vhost tree

2020-07-28 Thread Stephen Rothwell
Hi all, After merging the vhost tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/virtio/virtio_vdpa.c:17: include/linux/vdpa.h:43:21: error: expected ':', ',', ';', '}' or '__attribute__' before '.' token 43 | bool features_valid. |

Re: [Linux-kernel-mentees] [PATCH] drm/bufs: Prevent kernel-infoleak in copy_one_buf()

2020-07-28 Thread Arnd Bergmann
On Tue, Jul 28, 2020 at 3:45 AM Peilin Ye wrote: > > copy_one_buf() is copying uninitialized stack memory to userspace due to > the compiler not initializing holes in statically allocated structures. > Fix it by initializing `v` with memset(). I would add 'potentially' somewhere in that descripti

Re: [PATCH v6 01/13] mfd: add simple regmap based I2C driver

2020-07-28 Thread Lee Jones
On Tue, 28 Jul 2020, Michael Walle wrote: > Am 2020-07-28 09:19, schrieb Lee Jones: > > On Sun, 26 Jul 2020, Michael Walle wrote: > > > > > There are I2C devices which contain several different functions but > > > doesn't require any special access functions. For these kind of > > > drivers > > >

Re: [PATCH] KVM: x86: Deflect unknown MSR accesses to user space

2020-07-28 Thread Vitaly Kuznetsov
Alexander Graf writes: > MSRs are weird. Some of them are normal control registers, such as EFER. > Some however are registers that really are model specific, not very > interesting to virtualization workloads, and not performance critical. > Others again are really just windows into package conf

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Masami Hiramatsu
On Sun, 26 Jul 2020 19:06:20 +0300 Ard Biesheuvel wrote: > On Sun, 26 Jul 2020 at 11:14, Mike Rapoport wrote: > > > > On Sat, Jul 25, 2020 at 06:16:48AM +0300, Jarkko Sakkinen wrote: > > > On Fri, Jul 24, 2020 at 11:27:46AM +0200, Ingo Molnar wrote: > > > > > > > > * Jarkko Sakkinen wrote: > >

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-28 Thread Jason A. Donenfeld
On Tue, Jul 28, 2020 at 10:07 AM David Laight wrote: > > From: Christoph Hellwig > > Sent: 27 July 2020 17:24 > > > > On Mon, Jul 27, 2020 at 06:16:32PM +0200, Jason A. Donenfeld wrote: > > > Maybe sockptr_advance should have some safety checks and sometimes > > > return -EFAULT? Or you should alw

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-28 Thread Linus Walleij
On Mon, Jul 27, 2020 at 11:50 PM Serge Semin wrote: > It turns out my "mostly" was wrong in this matter. It's 4 out of 17 patches, > which make the initialization in the same order as mine: I'll think about fixing them up to all look the same at some point if noone beats me to it. Sorry for the

Re: [PATCH] staging/speakup: Update TODO list

2020-07-28 Thread Greg KH
On Sun, Jul 26, 2020 at 06:54:52PM +0200, Samuel Thibault wrote: > Thanks to Okash's latest work, the TODO list is essentially empty, so > the way out from staging now seems open. > > The status of the remaining issue mentioned in TODO is not clear, we > asked the speakup user mailing list for rep

[PATCH] dt-bindings: regulator: Convert sy8824x to json-schema

2020-07-28 Thread Jisheng Zhang
Convert the sy8824x binding to DT schema format using json-schema. Signed-off-by: Jisheng Zhang --- .../bindings/regulator/silergy,sy8824x.yaml | 40 +++ .../devicetree/bindings/regulator/sy8824x.txt | 24 --- 2 files changed, 40 insertions(+), 24 deletions(-) create m

Re: [PATCH -mmotm] pinctrl: mediatek: fix build for tristate changes

2020-07-28 Thread Linus Walleij
On Tue, Jul 28, 2020 at 7:55 AM Randy Dunlap wrote: > From: Randy Dunlap > > Export mtk_is_virt_gpio() for the case when > CONFIG_PINCTRL_MTK=y > CONFIG_PINCTRL_MTK_V2=y > CONFIG_PINCTRL_MTK_MOORE=y > CONFIG_PINCTRL_MTK_PARIS=m > > to fix this build error: > > ERROR: modpost: "mtk_is_virt_gpio"

Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller

2020-07-28 Thread Michael Walle
Hi, Am 2020-07-28 09:43, schrieb Uwe Kleine-König: Hello, just a few minor issues left: thanks for the review. On Sun, Jul 26, 2020 at 01:18:27AM +0200, Michael Walle wrote: diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c new file mode 100644 index ..956fa

Re: Kernel panic - not syncing: IO-APIC + timer doesn't work!

2020-07-28 Thread Thomas Gleixner
Scott, Scott Branden writes: > Bios now updated to latest.  Same kernel panic issue.  Log below. > > I think it is related to power cycling quickly. > Should APIC work if PC power cycled in a few seconds or is that the > problem? Yes, emphasis on should. Just to clarify, if you reboot it works a

Re: linux-next: build failure after merge of the char-misc tree

2020-07-28 Thread Stephen Rothwell
Hi Greg, On Tue, 28 Jul 2020 09:53:36 +0200 Greg KH wrote: > > On Tue, Jul 28, 2020 at 05:33:31PM +1000, Stephen Rothwell wrote: > > Hi Greg, > > > > On Mon, 27 Jul 2020 11:24:48 +0200 Greg KH wrote: > > > > > > On Mon, Jul 27, 2020 at 06:08:31PM +1000, Stephen Rothwell wrote: > > > > Hi al

[PATCH v2] Staging : media : atomisp : fixed a brace coding sytle issue

2020-07-28 Thread Ankit
From: Ankit Baluni Removed braces for a 'if' condition as it contain only single line & there is no need for braces for such case according to coding style rules. Signed-off-by: Ankit Baluni --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

Re: BUG: omap5: v5.8-rc7 boot fails

2020-07-28 Thread Tony Lindgren
* H. Nikolaus Schaller [200727 20:51]: > Hi Tony, > after trying v5.8-rc7 the Pyra boot hangs after ca. 3 seconds > (a little random what the last log line is). > > I could bisect it to: > > 6cfcd5563b4fadbf49ba8fa481978e5e86d30322 is the first bad commit > commit 6cfcd5563b4fadbf49ba8fa481978e5

RE: mmotm 2020-07-27-18-18 uploaded (drivers/scsi/ufs/: SCSI_UFS_EXYNOS)

2020-07-28 Thread Alim Akhtar
Hi Randy, > -Original Message- > From: Randy Dunlap > Sent: 28 July 2020 08:53 > To: Andrew Morton ; broo...@kernel.org; linux- > fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; linux...@kvack.org; > linux-n...@vger.kernel.org; mho...@suse.cz; mm-comm...@vger.kernel.org; > s...@can

Re: [PATCH v6 01/13] mfd: add simple regmap based I2C driver

2020-07-28 Thread Michael Walle
Am 2020-07-28 10:15, schrieb Lee Jones: On Tue, 28 Jul 2020, Michael Walle wrote: Am 2020-07-28 09:19, schrieb Lee Jones: > On Sun, 26 Jul 2020, Michael Walle wrote: > > > There are I2C devices which contain several different functions but > > doesn't require any special access functions. For t

Re: [PATCH v6 02/13] dt-bindings: mfd: Add bindings for sl28cpld

2020-07-28 Thread Lee Jones
On Tue, 28 Jul 2020, Michael Walle wrote: > Am 2020-07-28 09:24, schrieb Lee Jones: > > On Sun, 26 Jul 2020, Michael Walle wrote: > > > > > Add a device tree bindings for the board management controller found > > > on > > > the Kontron SMARC-sAL28 board. > > > > > > Signed-off-by: Michael Walle

Re: [PATCH] mtd: revert "spi-nor: intel: provide a range for poll_timout"

2020-07-28 Thread Tudor.Ambarus
Hi, Mika, On 7/23/20 12:05 PM, Alexander Sverdlin wrote: > > Hello Tudor, > > On 22/07/2020 19:03, tudor.amba...@microchip.com wrote: >> On 7/22/20 7:37 PM, Alexander Sverdlin wrote: > > [...] > >>> I've performed my testing as well and got the following results: >>> >>> Vanilla Linux 4.9 (i.e

Re: linux-next: manual merge of the devicetree tree with the pci tree

2020-07-28 Thread Sivaprakash Murugesan
On 7/28/2020 11:19 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the devicetree tree got a conflict in: Documentation/devicetree/bindings/pci/qcom,pcie.txt between commits: 736ae5c91712 ("dt-bindings: PCI: qcom: Add missing clks") b11b8cc161de ("dt-bindings: PCI: qc

Re: [PATCHv2] coresight: etm4x: Fix etm4_count race by moving cpuhp callbacks to init

2020-07-28 Thread Stephen Boyd
Quoting Sai Prakash Ranjan (2020-07-28 00:51:02) > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c > b/drivers/hwtracing/coresight/coresight-etm4x.c > index 6d7d2169bfb2..adb71987a1e3 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresi

[v2 1/4] ACPI: APD: Change name from ST to FCH

2020-07-28 Thread Akshu Agrawal
AMD SoC general pupose clk is present in new platforms with same MMIO mappings. We can reuse the same clk handler support for other platforms. Hence, changing name from ST(SoC) to FCH(IP) Signed-off-by: Akshu Agrawal --- v2: pulled in clk changes so that patch compiles individually drivers/acpi

Re: [PATCH 1/2] clk: imx: imx8m: avoid memory leak

2020-07-28 Thread Stephen Boyd
Quoting peng@nxp.com (2020-07-27 19:54:48) > From: Peng Fan > > Use devm_kzalloc to avoid memory leak when probe fail. Please add () to functions in commit text. > > Signed-off-by: Peng Fan

[v2 2/4] clk: x86: Change name from ST to FCH

2020-07-28 Thread Akshu Agrawal
AMD SoC general pupose clk is present in new platforms with minor differences. We can reuse the same clk driver for other platforms. Hence, changing name from ST(SoC) to FCH(IP) Signed-off-by: Akshu Agrawal --- v2: Moved some changes to acp:apd patch so that individual patches compile drivers/c

[3/4] ACPI: APD: Add a fmw property is_raven

2020-07-28 Thread Akshu Agrawal
Since there is slight difference in AMD RV based soc in misc clk architecture. The fmw property will help in differentiating the SoCs. Signed-off-by: Akshu Agrawal --- drivers/acpi/acpi_apd.c | 4 include/linux/platform_data/clk-fch.h | 1 + 2 files changed, 5 insertions(+) d

[v3 4/4] clk: x86: Support RV architecture

2020-07-28 Thread Akshu Agrawal
There is minor difference between previous family of SoC and the current one. Which is the there is only 48Mh fixed clk. There is no mux and no option to select another freq as there in previous. Signed-off-by: Akshu Agrawal --- v2: Consolidated the loops in remove. v3: Removed negation in condit

[PATCH] /proc/PID/smaps: Consistent whitespace output format

2020-07-28 Thread Michal Koutný
The keys in smaps output are padded to fixed width with spaces. All except for THPeligible that uses tabs (only since commit c06306696f83 ("mm: thp: fix false negative of shmem vma's THP eligibility")). Unify the output formatting to save time debugging some naïve parsers. (Part of the unification

Re: [PATCH] objtool,x86: Verify poke_int3_handler() is self contained

2020-07-28 Thread peterz
On Mon, Jul 27, 2020 at 10:56:03PM +0200, Thomas Gleixner wrote: > pet...@infradead.org writes: > > Abuse the SMAP rules to ensure poke_int3_handler() doesn't call out to > > anything. > > Yuck. Isn't that what noinstr is for or am I missing something? Well, we don't want poke_int3_handler() to c

Re: [PATCH 4.19 00/86] 4.19.135-rc1 review

2020-07-28 Thread Naresh Kamboju
On Mon, 27 Jul 2020 at 19:40, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.135 release. > There are 86 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Re

Re: [PATCH v6 01/13] mfd: add simple regmap based I2C driver

2020-07-28 Thread Lee Jones
On Tue, 28 Jul 2020, Michael Walle wrote: > Am 2020-07-28 10:15, schrieb Lee Jones: > > On Tue, 28 Jul 2020, Michael Walle wrote: > > > > > Am 2020-07-28 09:19, schrieb Lee Jones: > > > > On Sun, 26 Jul 2020, Michael Walle wrote: > > > > > > > > > There are I2C devices which contain several diffe

Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4

2020-07-28 Thread Tony Lindgren
* Pavel Machek [200726 08:25]: > Hi! > > > > Here's the updated set of these patches fixed up for Johan's and > > > Pavel's earlier comments. > > > > > > This series does the following: > > > > > > 1. Adds functions to n_gsm.c for serdev-ngsm.c driver to use > > > > > > 2. Adds a generic serde

Re: [PATCH v6 02/13] dt-bindings: mfd: Add bindings for sl28cpld

2020-07-28 Thread Michael Walle
Am 2020-07-28 10:27, schrieb Lee Jones: On Tue, 28 Jul 2020, Michael Walle wrote: Am 2020-07-28 09:24, schrieb Lee Jones: > On Sun, 26 Jul 2020, Michael Walle wrote: > > > Add a device tree bindings for the board management controller found > > on > > the Kontron SMARC-sAL28 board. > > > > Sign

Re: [PATCH] MIPS: qi_lb60: Fix routing to audio amplifier

2020-07-28 Thread Thomas Bogendoerfer
On Mon, Jul 27, 2020 at 08:11:28PM +0200, Paul Cercueil wrote: > The ROUT (right channel output of audio codec) was connected to INL > (left channel of audio amplifier) instead of INR (right channel of audio > amplifier). > > Fixes: 8ddebad15e9b ("MIPS: qi_lb60: Migrate to devicetree") > Cc: sta..

Re: [PATCH v3 1/5] of_address: Add bus type match for pci ranges parser

2020-07-28 Thread Thomas Bogendoerfer
On Mon, Jul 27, 2020 at 11:50:14AM -0600, Rob Herring wrote: > On Fri, Jul 24, 2020 at 7:45 PM Jiaxun Yang wrote: > > > > So the parser can be used to parse range property of ISA bus. > > > > As they're all using PCI-like method of range property, there is no need > > start a new parser. > > > > S

  1   2   3   4   5   6   7   8   9   10   >